From owner-cvs-lib Sun Apr 12 22:44:44 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id WAA09806 for cvs-lib-outgoing; Sun, 12 Apr 1998 22:44:44 -0700 (PDT) (envelope-from owner-cvs-lib) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id WAA09653; Sun, 12 Apr 1998 22:44:14 -0700 (PDT) (envelope-from jkh@FreeBSD.org) From: "Jordan K. Hubbard" Received: (from jkh@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id WAA10012; Sun, 12 Apr 1998 22:43:46 -0700 (PDT) Date: Sun, 12 Apr 1998 22:43:46 -0700 (PDT) Message-Id: <199804130543.WAA10012@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-lib@FreeBSD.ORG Subject: cvs commit: src/lib/libc/stdlib atof.3 Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk jkh 1998/04/12 22:43:45 PDT Modified files: (Branch: RELENG_2_2) lib/libc/stdlib atof.3 Log: remove bogus bugs section. Submitted by: Niall Smart Revision Changes Path 1.1.1.1.8.1 +0 -8 src/lib/libc/stdlib/atof.3 From owner-cvs-lib Mon Apr 13 16:22:50 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id QAA22094 for cvs-lib-outgoing; Mon, 13 Apr 1998 16:22:50 -0700 (PDT) (envelope-from owner-cvs-lib) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id XAA21473; Mon, 13 Apr 1998 23:21:28 GMT (envelope-from steve@FreeBSD.org) From: Steve Price Received: (from steve@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id QAA11157; Mon, 13 Apr 1998 16:20:54 -0700 (PDT) Date: Mon, 13 Apr 1998 16:20:54 -0700 (PDT) Message-Id: <199804132320.QAA11157@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-lib@FreeBSD.ORG Subject: cvs commit: src/lib/libc/stdio Makefile.inc Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk steve 1998/04/13 16:20:54 PDT Modified files: (Branch: RELENG_2_2) lib/libc/stdio Makefile.inc Log: Add MLINK for mkdtemp.3. PR: 6291 Submitted by: Niall Smart Revision Changes Path 1.6.2.2 +2 -2 src/lib/libc/stdio/Makefile.inc From owner-cvs-lib Tue Apr 14 00:26:39 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id AAA13696 for cvs-lib-outgoing; Tue, 14 Apr 1998 00:26:39 -0700 (PDT) (envelope-from owner-cvs-lib) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id HAA13425; Tue, 14 Apr 1998 07:25:44 GMT (envelope-from peter@FreeBSD.org) From: Peter Wemm Received: (from peter@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id AAA13705; Tue, 14 Apr 1998 00:25:07 -0700 (PDT) Date: Tue, 14 Apr 1998 00:25:07 -0700 (PDT) Message-Id: <199804140725.AAA13705@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-lib@FreeBSD.ORG Subject: cvs commit: src/lib/libc/stdio mktemp.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk peter 1998/04/14 00:25:07 PDT Modified files: lib/libc/stdio mktemp.c Log: Fix a nasty flaw as a result of using the arc4random() pre-seeding of leading XXX's. It could wrap an uppercase character through chars like: [ \ ] ^ _ ` in between Z and a. The backslash and back tick might be particularly nasty in a shell script context. Also, since we've been using upper-case generated values for a while now, go with the flow and use them in the pathname search rotation. Revision Changes Path 1.10 +4 -2 src/lib/libc/stdio/mktemp.c From owner-cvs-lib Tue Apr 14 20:13:40 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id UAA00904 for cvs-lib-outgoing; Tue, 14 Apr 1998 20:13:40 -0700 (PDT) (envelope-from owner-cvs-lib) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id DAA00700; Wed, 15 Apr 1998 03:12:21 GMT (envelope-from peter@FreeBSD.org) From: Peter Wemm Received: (from peter@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id UAA15262; Tue, 14 Apr 1998 20:11:38 -0700 (PDT) Date: Tue, 14 Apr 1998 20:11:38 -0700 (PDT) Message-Id: <199804150311.UAA15262@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-lib@FreeBSD.ORG Subject: cvs commit: src/lib/libc/stdio mktemp.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk peter 1998/04/14 20:11:37 PDT Modified files: (Branch: RELENG_2_2) lib/libc/stdio mktemp.c Log: MFC: don't generate potential shell or interpreter metacharacters when doing character rotation while searching for unique names. Revision Changes Path 1.4.2.4 +4 -2 src/lib/libc/stdio/mktemp.c From owner-cvs-lib Wed Apr 15 16:15:53 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id QAA12804 for cvs-lib-outgoing; Wed, 15 Apr 1998 16:15:53 -0700 (PDT) (envelope-from owner-cvs-lib) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id XAA12442; Wed, 15 Apr 1998 23:14:28 GMT (envelope-from ache@FreeBSD.org) From: "Andrey A. Chernov" Received: (from ache@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id QAA21483; Wed, 15 Apr 1998 16:13:38 -0700 (PDT) Date: Wed, 15 Apr 1998 16:13:38 -0700 (PDT) Message-Id: <199804152313.QAA21483@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-lib@FreeBSD.ORG Subject: cvs commit: src/lib/libncurses curses.h Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk ache 1998/04/15 16:13:37 PDT Modified files: lib/libncurses curses.h Log: Add some easy to implement XSI macros including attr_get Revision Changes Path 1.11 +10 -1 src/lib/libncurses/curses.h From owner-cvs-lib Wed Apr 15 16:16:39 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id QAA12903 for cvs-lib-outgoing; Wed, 15 Apr 1998 16:16:39 -0700 (PDT) (envelope-from owner-cvs-lib) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id XAA12724; Wed, 15 Apr 1998 23:15:28 GMT (envelope-from ache@FreeBSD.org) From: "Andrey A. Chernov" Received: (from ache@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id QAA21517; Wed, 15 Apr 1998 16:14:39 -0700 (PDT) Date: Wed, 15 Apr 1998 16:14:39 -0700 (PDT) Message-Id: <199804152314.QAA21517@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-lib@FreeBSD.ORG Subject: cvs commit: src/lib/libncurses curses.h Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk ache 1998/04/15 16:14:39 PDT Modified files: (Branch: RELENG_2_2) lib/libncurses curses.h Log: MFC: XSI macros including attr_get Revision Changes Path 1.6.6.4 +10 -1 src/lib/libncurses/curses.h From owner-cvs-lib Thu Apr 16 17:59:50 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id RAA03041 for cvs-lib-outgoing; Thu, 16 Apr 1998 17:59:50 -0700 (PDT) (envelope-from owner-cvs-lib) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id AAA02875; Fri, 17 Apr 1998 00:59:25 GMT (envelope-from brian@FreeBSD.org) From: Brian Somers Received: (from brian@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id RAA06913; Thu, 16 Apr 1998 17:59:16 -0700 (PDT) Date: Thu, 16 Apr 1998 17:59:16 -0700 (PDT) Message-Id: <199804170059.RAA06913@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-lib@FreeBSD.ORG Subject: cvs commit: src/lib/libc/gen tcsetpgrp.3 Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk brian 1998/04/16 17:59:16 PDT Modified files: lib/libc/gen tcsetpgrp.3 Log: Typo police Revision Changes Path 1.4 +1 -1 src/lib/libc/gen/tcsetpgrp.3 From owner-cvs-lib Fri Apr 17 00:27:20 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id AAA26234 for cvs-lib-outgoing; Fri, 17 Apr 1998 00:27:20 -0700 (PDT) (envelope-from owner-cvs-lib) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id HAA26167; Fri, 17 Apr 1998 07:27:03 GMT (envelope-from phk@FreeBSD.org) From: Poul-Henning Kamp Received: (from phk@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id AAA08530; Fri, 17 Apr 1998 00:26:52 -0700 (PDT) Date: Fri, 17 Apr 1998 00:26:52 -0700 (PDT) Message-Id: <199804170726.AAA08530@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-lib@FreeBSD.ORG Subject: cvs commit: src/lib/libz Makefile Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk phk 1998/04/17 00:26:52 PDT Modified files: lib/libz Makefile Log: Manpages not installed PR: 6327 Reviewed by: phk Submitted by: Chia-liang Kao Revision Changes Path 1.8 +3 -1 src/lib/libz/Makefile From owner-cvs-lib Fri Apr 17 01:31:25 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id BAA06747 for cvs-lib-outgoing; Fri, 17 Apr 1998 01:31:25 -0700 (PDT) (envelope-from owner-cvs-lib) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id IAA06707; Fri, 17 Apr 1998 08:31:19 GMT (envelope-from phk@FreeBSD.org) From: Poul-Henning Kamp Received: (from phk@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id BAA09176; Fri, 17 Apr 1998 01:31:08 -0700 (PDT) Date: Fri, 17 Apr 1998 01:31:08 -0700 (PDT) Message-Id: <199804170831.BAA09176@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-lib@FreeBSD.ORG Subject: cvs commit: src/lib/libz Makefile Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk phk 1998/04/17 01:31:08 PDT Modified files: lib/libz Makefile Log: Backup out the last commit, it was already there. Noticed by: bde Revision Changes Path 1.9 +1 -3 src/lib/libz/Makefile From owner-cvs-lib Fri Apr 17 02:38:02 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id CAA16400 for cvs-lib-outgoing; Fri, 17 Apr 1998 02:38:02 -0700 (PDT) (envelope-from owner-cvs-lib) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id JAA16328; Fri, 17 Apr 1998 09:37:53 GMT (envelope-from jb@FreeBSD.org) From: John Birrell Received: (from jb@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id CAA09481; Fri, 17 Apr 1998 02:37:42 -0700 (PDT) Date: Fri, 17 Apr 1998 02:37:42 -0700 (PDT) Message-Id: <199804170937.CAA09481@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-lib@FreeBSD.ORG Subject: cvs commit: src/lib/libc_r/uthread uthread_kern.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk jb 1998/04/17 02:37:41 PDT Modified files: lib/libc_r/uthread uthread_kern.c Log: When in PS_SIGWAIT state, still call signal handlers and set errno to EINTR. Revision Changes Path 1.9 +2 -13 src/lib/libc_r/uthread/uthread_kern.c From owner-cvs-lib Fri Apr 17 02:39:56 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id CAA16617 for cvs-lib-outgoing; Fri, 17 Apr 1998 02:39:56 -0700 (PDT) (envelope-from owner-cvs-lib) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id JAA16580; Fri, 17 Apr 1998 09:39:49 GMT (envelope-from jb@FreeBSD.org) From: John Birrell Received: (from jb@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id CAA09517; Fri, 17 Apr 1998 02:39:38 -0700 (PDT) Date: Fri, 17 Apr 1998 02:39:38 -0700 (PDT) Message-Id: <199804170939.CAA09517@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-lib@FreeBSD.ORG Subject: cvs commit: src/lib/libc_r/uthread uthread_info.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk jb 1998/04/17 02:39:38 PDT Modified files: lib/libc_r/uthread uthread_info.c Log: Allow a thread dump to report the thread's sigmask when in the PS_SIGWAIT state. Revision Changes Path 1.4 +4 -0 src/lib/libc_r/uthread/uthread_info.c From owner-cvs-lib Fri Apr 17 04:22:46 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id EAA05456 for cvs-lib-outgoing; Fri, 17 Apr 1998 04:22:46 -0700 (PDT) (envelope-from owner-cvs-lib) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id LAA05414; Fri, 17 Apr 1998 11:22:39 GMT (envelope-from tg@FreeBSD.org) From: Thomas Gellekum Received: (from tg@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id EAA10804; Fri, 17 Apr 1998 04:22:27 -0700 (PDT) Date: Fri, 17 Apr 1998 04:22:27 -0700 (PDT) Message-Id: <199804171122.EAA10804@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-lib@FreeBSD.ORG Subject: cvs commit: src/lib/libc_r/uthread uthread_kern.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk tg 1998/04/17 04:22:27 PDT Modified files: (Branch: RELENG_2_2) lib/libc_r/uthread uthread_kern.c Log: MFC: when in PS_SIGWAIT state, still call signal handlers and set errno to EINTR. Revision Changes Path 1.3.2.3 +2 -13 src/lib/libc_r/uthread/uthread_kern.c From owner-cvs-lib Sat Apr 18 02:34:35 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id CAA01339 for cvs-lib-outgoing; Sat, 18 Apr 1998 02:34:35 -0700 (PDT) (envelope-from owner-cvs-lib) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id JAA01296; Sat, 18 Apr 1998 09:34:25 GMT (envelope-from obrien@FreeBSD.org) From: "David E. O'Brien" Received: (from obrien@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id CAA15833; Sat, 18 Apr 1998 02:34:06 -0700 (PDT) Date: Sat, 18 Apr 1998 02:34:06 -0700 (PDT) Message-Id: <199804180934.CAA15833@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-lib@FreeBSD.ORG Subject: cvs commit: src/lib Makefile Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk obrien 1998/04/18 02:34:06 PDT Modified files: (Branch: RELENG_2_2) lib Makefile Log: Make bulding libc_r the default. This is useful for ports like mysql. Revision Changes Path 1.47.2.13 +1 -1 src/lib/Makefile From owner-cvs-lib Sat Apr 18 12:25:40 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id MAA15286 for cvs-lib-outgoing; Sat, 18 Apr 1998 12:25:40 -0700 (PDT) (envelope-from owner-cvs-lib) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id TAA15160; Sat, 18 Apr 1998 19:25:07 GMT (envelope-from des@FreeBSD.org) From: "Dag-Erling C. Sm\xf8rgrav" Received: (from des@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id MAA15002; Sat, 18 Apr 1998 12:24:45 -0700 (PDT) Date: Sat, 18 Apr 1998 12:24:45 -0700 (PDT) Message-Id: <199804181924.MAA15002@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-lib@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/lib/libc/sys lseek.2 src/sys/kern vfs_syscalls.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk des 1998/04/18 12:24:45 PDT Modified files: lib/libc/sys lseek.2 Log: Return EINVAL and do not changefile pointer if resulting offset is negative. PR: kern/6184 Revision Changes Path 1.7 +2 -2 src/lib/libc/sys/lseek.2 Modified files: sys/kern vfs_syscalls.c Log: Return EINVAL and do not change file pointer if resulting offset is negative. PR: kern/6184 Revision Changes Path 1.98 +7 -5 src/sys/kern/vfs_syscalls.c From owner-cvs-lib Sat Apr 18 20:06:01 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id UAA00995 for cvs-lib-outgoing; Sat, 18 Apr 1998 20:06:01 -0700 (PDT) (envelope-from owner-cvs-lib) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id DAA00956; Sun, 19 Apr 1998 03:05:34 GMT (envelope-from bde@godzilla.zeta.org.au) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.7/8.8.7) id NAA15945; Sun, 19 Apr 1998 13:00:06 +1000 Date: Sun, 19 Apr 1998 13:00:06 +1000 From: Bruce Evans Message-Id: <199804190300.NAA15945@godzilla.zeta.org.au> To: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-lib@FreeBSD.ORG, cvs-sys@FreeBSD.ORG, des@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libc/sys lseek.2 src/sys/kern vfs_syscalls.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk >des 1998/04/18 12:24:45 PDT > > Modified files: > lib/libc/sys lseek.2 > Log: > Return EINVAL and do not changefile pointer if resulting offset is negative. > PR: kern/6184 > > Revision Changes Path > 1.7 +2 -2 src/lib/libc/sys/lseek.2 > > Modified files: > sys/kern vfs_syscalls.c > Log: > Return EINVAL and do not change file pointer if resulting offset is negative. > PR: kern/6184 This is wrong. Please back it out. It breaks at least the ability to seek to high addresses in /dev/[k]mem on 64 bit systems. Not long ago when off_t was 32 bits, it was normal to seek to "negative" addresses in /dev/kmem, so portable programs should be able to handle such addresses at least if they actually request them. libkvm/kvm_proc.c:kvm_uread() shows how to handle them: errno = 0; if (lseek(fd, (off_t)uva, 0) == -1 && errno != 0) { /* Error. */ ... } /* No error. */ ... This allows seeking to (off_t)-1 provided the system supports it. I replied to the PR, but for some reason the followup didn't get attached to the PR. Bruce From owner-cvs-lib Sat Apr 18 22:17:30 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id WAA14465 for cvs-lib-outgoing; Sat, 18 Apr 1998 22:17:30 -0700 (PDT) (envelope-from owner-cvs-lib) Received: from alpo.whistle.com (alpo.whistle.com [207.76.204.38]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id FAA14288; Sun, 19 Apr 1998 05:17:13 GMT (envelope-from julian@whistle.com) Received: (from daemon@localhost) by alpo.whistle.com (8.8.5/8.8.5) id WAA23995; Sat, 18 Apr 1998 22:08:31 -0700 (PDT) Received: from current1.whistle.com(207.76.205.22) via SMTP by alpo.whistle.com, id smtpd023993; Sun Apr 19 05:08:30 1998 Date: Sat, 18 Apr 1998 22:03:14 -0700 (PDT) From: Julian Elischer To: Bruce Evans cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-lib@FreeBSD.ORG, cvs-sys@FreeBSD.ORG, des@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libc/sys lseek.2 src/sys/kern vfs_syscalls.c In-Reply-To: <199804190300.NAA15945@godzilla.zeta.org.au> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk If this is truely 'common' then that's unfortunate. what do POSIX and friends have to say about it? On Sun, 19 Apr 1998, Bruce Evans wrote: > >des 1998/04/18 12:24:45 PDT > > > > Modified files: > > lib/libc/sys lseek.2 > > Log: > > Return EINVAL and do not changefile pointer if resulting offset is negative. > > PR: kern/6184 > > > > Revision Changes Path > > 1.7 +2 -2 src/lib/libc/sys/lseek.2 > > > > Modified files: > > sys/kern vfs_syscalls.c > > Log: > > Return EINVAL and do not change file pointer if resulting offset is negative. > > PR: kern/6184 > > This is wrong. Please back it out. It breaks at least the ability to > seek to high addresses in /dev/[k]mem on 64 bit systems. Not long ago > when off_t was 32 bits, it was normal to seek to "negative" addresses in > /dev/kmem, so portable programs should be able to handle such addresses > at least if they actually request them. libkvm/kvm_proc.c:kvm_uread() > shows how to handle them: > > errno = 0; > if (lseek(fd, (off_t)uva, 0) == -1 && errno != 0) { > /* Error. */ > ... > } > /* No error. */ > ... > > This allows seeking to (off_t)-1 provided the system supports it. > > I replied to the PR, but for some reason the followup didn't get attached > to the PR. > > Bruce > From owner-cvs-lib Sat Apr 18 23:05:51 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id XAA20653 for cvs-lib-outgoing; Sat, 18 Apr 1998 23:05:51 -0700 (PDT) (envelope-from owner-cvs-lib) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id GAA20546; Sun, 19 Apr 1998 06:05:20 GMT (envelope-from bde@godzilla.zeta.org.au) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.7/8.8.7) id QAA21960; Sun, 19 Apr 1998 16:03:28 +1000 Date: Sun, 19 Apr 1998 16:03:28 +1000 From: Bruce Evans Message-Id: <199804190603.QAA21960@godzilla.zeta.org.au> To: bde@zeta.org.au, julian@whistle.com Subject: Re: cvs commit: src/lib/libc/sys lseek.2 src/sys/kern vfs_syscalls.c Cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-lib@FreeBSD.ORG, cvs-sys@FreeBSD.ORG, des@FreeBSD.ORG Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk >If this is truely 'common' then that's unfortunate. >what do POSIX and friends have to say about it? Same as usual. On successful completion, the appropriate value is returned. Otherwise, -1 is returned and errno is set to indicate the error. For lseek() the appropriate value is the "offset location as measured in bytes from the beginning of the file". The implementation gets to decided what an error is. The rationale clarifies this in detail for lseek(): "An invalid file offset that would cause EINVAL to be returned may be both implementation defined and device dependent (for example, memory may have few invalid values). A negative file offset may be valid for some devices in some implementations". FreeBSD uses a simple implementation with all negative file offsets valid for all file types. OTOH, for fcntl(), the behaviour is completely undefined if the length of the locked region is negative, and FreeBSD rejects "negative" start and end offsets and negative lengths. This is reasonable because locking is not supported for special files. Bruce From owner-cvs-lib Sat Apr 18 23:49:28 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id XAA25759 for cvs-lib-outgoing; Sat, 18 Apr 1998 23:49:28 -0700 (PDT) (envelope-from owner-cvs-lib) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id GAA25608; Sun, 19 Apr 1998 06:47:54 GMT (envelope-from phk@FreeBSD.org) From: Poul-Henning Kamp Received: (from phk@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id XAA21493; Sat, 18 Apr 1998 23:47:28 -0700 (PDT) Date: Sat, 18 Apr 1998 23:47:28 -0700 (PDT) Message-Id: <199804190647.XAA21493@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-include@FreeBSD.ORG, cvs-lib@FreeBSD.ORG Subject: cvs commit: src/include time.h src/lib/libc/stdtime asctime.c localtime.c Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk phk 1998/04/18 23:47:28 PDT Modified files: include time.h lib/libc/stdtime asctime.c localtime.c Log: ctime_r and asctime_r are not implemented. prototypes in time.h do not match POSIX. PR: 6345 Reviewed by: phk Submitted by: Dmitry Khrustalev Revision Changes Path 1.12 +2 -2 src/include/time.h 1.5 +12 -3 src/lib/libc/stdtime/asctime.c 1.18 +9 -0 src/lib/libc/stdtime/localtime.c