From owner-p4-projects@FreeBSD.ORG  Sun Sep 28 21:24:36 2003
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 5D40716A4C0; Sun, 28 Sep 2003 21:24:36 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3286616A4B3
	for <perforce@freebsd.org>; Sun, 28 Sep 2003 21:24:36 -0700 (PDT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B231C43FD7
	for <perforce@freebsd.org>; Sun, 28 Sep 2003 21:24:35 -0700 (PDT)
	(envelope-from sam@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.9/8.12.9) with ESMTP id h8T4OZXJ024962
	for <perforce@freebsd.org>; Sun, 28 Sep 2003 21:24:35 -0700 (PDT)
	(envelope-from sam@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.12.9/8.12.9/Submit) id h8T4OZsD024959
	for perforce@freebsd.org; Sun, 28 Sep 2003 21:24:35 -0700 (PDT)
	(envelope-from sam@freebsd.org)
Date: Sun, 28 Sep 2003 21:24:35 -0700 (PDT)
Message-Id: <200309290424.h8T4OZsD024959@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	sam@freebsd.org using -f
From: Sam Leffler <sam@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Subject: PERFORCE change 38769 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Sep 2003 04:24:36 -0000

http://perforce.freebsd.org/chv.cgi?CH=38769

Change 38769 by sam@sam_ebb on 2003/09/28 21:24:02

	One more time: rtrequest(RTM_DELETE...) locks the route so we cannot
	be holding it when we call it.  

Affected files ...

.. //depot/projects/netperf/sys/netinet/if_ether.c#9 edit

Differences ...

==== //depot/projects/netperf/sys/netinet/if_ether.c#9 (text+ko) ====

@@ -936,13 +936,14 @@
 		 * If this is the only references to a protocol
 		 * cloned route, remove it.
 		 */
+		RT_UNLOCK(rt);
 		if (rt->rt_refcnt == 1 && (rt->rt_flags & RTF_WASCLONED)) {
 			rtrequest(RTM_DELETE,
 					(struct sockaddr *)rt_key(rt),
 					rt->rt_gateway, rt_mask(rt),
 					rt->rt_flags, 0);
 		}
-		RTFREE_LOCKED(rt);
+		RTFREE(rt);
 		return (0);
 	} else {
 		rt->rt_refcnt--;