From owner-freebsd-cvsweb@FreeBSD.ORG Tue Jun 1 08:25:28 2004 Return-Path: Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 973E916A4CE for ; Tue, 1 Jun 2004 08:25:28 -0700 (PDT) Received: from mta11.adelphia.net (mta11.adelphia.net [68.168.78.205]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3323743D45 for ; Tue, 1 Jun 2004 08:25:28 -0700 (PDT) (envelope-from crosswhi@xwhite.org) Received: from louis.home.net ([68.71.52.15]) by mta11.adelphia.net (InterMail vM.5.01.06.08 201-253-122-130-108-20031117) with ESMTP id <20040601152527.UYTY21898.mta11.adelphia.net@louis.home.net> for ; Tue, 1 Jun 2004 11:25:27 -0400 Received: from louis.home.net (crosswhi@localhost.home.net [127.0.0.1]) by louis.home.net (8.12.9/8.12.9) with ESMTP id i51FPQuS030549 for ; Tue, 1 Jun 2004 09:25:26 -0600 (MDT) Received: from localhost (crosswhi@localhost) by louis.home.net (8.12.9/8.12.10/Submit) with ESMTP id i51FPQFx020115 for ; Tue, 1 Jun 2004 09:25:26 -0600 (MDT) Date: Tue, 1 Jun 2004 09:25:20 -0600 (MDT) From: Joel Crosswhite To: freebsd-cvsweb@freebsd.org Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: Internet Explorer oddity with cvsweb 3.0.1 X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS Web maintenance mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Jun 2004 15:25:28 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello all, I've come across a strange issue that only occurs with the current version of cvsweb and IE 6.0, with the .NET framework installed. When people try to download .dlls or any binary files, they're given the following error: IEExec.exe - Common Language Runtime Debugging Services Application has generated an exception that could not be handled. PID = . TID = . When I hit Ok, the debugger dies, when I hit Cancel, it tries to debug it using the frameworks debugger. This didn't show up until I upgraded CVS and cvsweb since the last CVS security hole. This works under other browsers just fine; Firefox and Opera are the two that I tested. Has anyone else seen this behavior or might know how to fix it? Thanks in advance, Joel -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (OpenBSD) iD8DBQFAvJ/lz0vw5+J3EqoRAv1zAKCUtOynHNf+Khs1yQHGusNpCpkz6wCgocez uqpTIW7FQhn1UyMetOG3zHY= =+6/d -----END PGP SIGNATURE----- From owner-freebsd-cvsweb@FreeBSD.ORG Tue Jun 1 10:37:48 2004 Return-Path: Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 014F216A4CE for ; Tue, 1 Jun 2004 10:37:48 -0700 (PDT) Received: from smtp1.pp.htv.fi (smtp1.pp.htv.fi [213.243.153.34]) by mx1.FreeBSD.org (Postfix) with ESMTP id C746D43D66 for ; Tue, 1 Jun 2004 10:37:46 -0700 (PDT) (envelope-from scop@FreeBSD.org) Received: from posti.pp.htv.fi (posti.pp.htv.fi [212.90.64.50]) by smtp1.pp.htv.fi (Postfix) with ESMTP id C7AA580109 for ; Tue, 1 Jun 2004 20:37:45 +0300 (EEST) Received: from [62.78.130.181] (cs78130181.pp.htv.fi [62.78.130.181]) /8.11.1) with ESMTP id i51HbjJ05677 for ; Tue, 1 Jun 2004 20:37:45 +0300 (EETDST) From: Ville =?ISO-8859-1?Q?Skytt=E4?= To: freebsd-cvsweb@FreeBSD.org In-Reply-To: References: Content-Type: text/plain Organization: FreeBSD Message-Id: <1086111464.30172.100.camel@bobcat.mine.nu> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 (1.4.6-2) Date: Tue, 01 Jun 2004 20:37:45 +0300 Content-Transfer-Encoding: 7bit Subject: Re: Internet Explorer oddity with cvsweb 3.0.1 X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS Web maintenance mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Jun 2004 17:37:48 -0000 On Tue, 2004-06-01 at 18:25, Joel Crosswhite wrote: > I've come across a strange issue that only occurs with the current > version of cvsweb and IE 6.0, with the .NET framework installed. When > people try to download .dlls or any binary files, they're given the > following error: > > IEExec.exe - Common Language Runtime Debugging Services > Application has generated an exception that could not be handled. > PID = . TID = . I don't have a Windows box to test with, but Google helps: http://groups.google.com/groups?threadm=ezit98N7DHA.2300%40TK2MSFTNGP10.phx.gbl Looks like a .NET "feature" to me. Right-click->Save As...? From owner-freebsd-cvsweb@FreeBSD.ORG Tue Jun 1 11:53:12 2004 Return-Path: Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6719B16A4CE for ; Tue, 1 Jun 2004 11:53:12 -0700 (PDT) Received: from mc.ch1.ummail.com (mc.ch1.ummail.com [216.64.213.35]) by mx1.FreeBSD.org (Postfix) with ESMTP id C9CB443D5F for ; Tue, 1 Jun 2004 11:53:11 -0700 (PDT) (envelope-from walter.dexter@mcd.com) Received: from dmmc01.ch1.ummail.com (dmmc01.ch1.ummail.com [216.64.213.124:25]) by mc.ch1.ummail.com with ESMTP id J0601-1453-030000; Tue, 1 Jun 2004 18:53:06 GMT X-PROVIDER-INFO: Contact abuse@unitedmessaging.com for abuse/spam/UBE complaints To: freebsd-cvsweb@freebsd.org X-Mailer: Lotus Notes Release 5.0.10 March 22, 2002 Message-ID: From: walter.dexter@mcd.com Date: Tue, 1 Jun 2004 13:53:02 -0500 X-MIMETrack: Serialize by Router on CHI-MCD-DH01/HU/US/MCD(Release 5.0.12 |February 13, 2003) at 06/01/2004 01:32:37 PM MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="<<001-40bcd096-64b8>>" Content-Disposition: inline Content-Transfer-Encoding: 8bit Subject: Directory name with spaces X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS Web maintenance mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Jun 2004 18:53:12 -0000 --<<001-40bcd096-64b8>> Content-type: text/plain Content-transfer-encoding: 8bit One of the users of my CVS server has complained that CVSWEB isn't able to download files located in a directory with spaces in its name. Is this a known issue? Is there a patch or work-around, aside from not using spaces? It appears to work fine for everything except the download link. For example, the "view - text" link for a revision generates the following URL: http://usitcvs/cgi-bin/cvsweb.cgi/cvstest/dir%20with%20space/hi.txt?rev=1.1;content-type=text%2Fplain whereas the "download" link generates: http://usitcvs/cgi-bin/cvsweb.cgi/~checkout~/cvstest/dir+with+space/hi.txt?rev=1.1;content-type=text%2Fplain which works fine if I change the "+" to "%20" by hand. It honestly seems possible to me that I'm out-of-date on some Perl library or something, but this admin gig is a very small part of my list of assigned tasks, so I'm hoping someone can point me in the right direction. Looking at the code, I'd guess something needs to be tweaked in download_url(), but I'm no Perl guy, either. Thanks, Walt Dexter McDonald's Corporation 630-623-2058 walter.dexter@mcd.com --<<001-40bcd096-64b8>> Content-type: text/plain Content-transfer-encoding: 8bit The information contained in this e-mail and any accompanying documents is confidential, may be privileged, and is intended solely for the person and/or entity to whom it is addressed (i.e. those identified in the "To" and "cc" box). They are the property of McDonald's Corporation. Unauthorized review,use, disclosure, or copying of this communication, or any part thereof, is strictly prohibited and may be unlawful. If you have received this e-mail in error, please return the e-mail and attachments to the sender and delete the e-mail and attachments and any copy from your system. McDonald's thanks you for your cooperation. --<<001-40bcd096-64b8>>-- From owner-freebsd-cvsweb@FreeBSD.ORG Wed Jun 2 10:10:22 2004 Return-Path: Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 282AC16A4CF for ; Wed, 2 Jun 2004 10:10:22 -0700 (PDT) Received: from mail.vgelder.com (vge.xs4all.nl [80.127.85.34]) by mx1.FreeBSD.org (Postfix) with ESMTP id 92F6143D2F for ; Wed, 2 Jun 2004 10:10:21 -0700 (PDT) (envelope-from k.vriezen@vgelder.com) Received: by mail.vgelder.com (Postfix, from userid 106) id 286DDA4A; Wed, 2 Jun 2004 19:13:52 +0200 (CEST) Received: from santiago.intern (santiago.dmz [192.168.2.200])by mail.vgelder.com (Postfix) with ESMTP id C6CB29BFfor ; Wed, 2 Jun 2004 19:13:51 +0200 (CEST) Received: from santiago.intern (localhost.localdomain [127.0.0.1])by santiago.intern (8.12.11/8.12.11/Debian-3) with ESMTP id i52HAKQ6012782for ; Wed, 2 Jun 2004 19:10:20 +0200 Received: (from kv@localhost)by santiago.intern (8.12.11/8.12.11/Debian-3) id i52HAJ9I012779for freebsd-cvsweb@FreeBSD.org; Wed, 2 Jun 2004 19:10:19 +0200 X-Authentication-Warning: santiago.intern: kv set sender to k.vriezen@vgelder.com using -f Date: Wed, 2 Jun 2004 19:10:19 +0200 From: Koos Vriezen To: freebsd-cvsweb@FreeBSD.org Message-ID: <20040602171019.GA12732@vgelder.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.5.1+cvs20040105i X-Copyrighted-Material: Please visit http://www.company.com/privacy.htm Subject: cvsweb version 3:3.0.1-1 diff problems (and howto debug this) X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS Web maintenance mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jun 2004 17:10:22 -0000 Hi, I've a problem with cvsweb 3:3.0.1-1 (debian/testing) after upgrading (don't know which version, but I upgrade frequently). The various projects show fine, also the history of a file works. What doesn't work are the links from a file history page (and this did work in the previous version). Eg. the links 'text'/'markeup' return the same history file. The 'preferred' link (for diff) shows a page with: Error: module/file.diff: no such file or directory for file 'file' in module 'module'. I also purged and reinstalled the package w/o luck. The only change I made to the /etc/cvsweb.conf file is in the @CVSrepositories array. Replaced the default /var/lib/cvs with our repositry (I also did that before the upgrade). Also, www-data (the user which runs apache) should be able to read everything in there. Any quick hints for fixing would be nice. But what is the best way to debug these configuration errors? Eg. is there a list of env vars I should export so I can run this script on the commandline, an example of a QUERY_STRING etc? Tia, Koos Vriezen ***************DISCLAIMER*************** Bewijs van Afstand: Dit emailbericht is slechts bestemd voor de personen aan wie het is gericht en kan informatie bevatten die persoonlijk of vertrouwelijk is en niet openbaar mag worden gemaakt zonder goedkeuring van de auteur. Indien u dit bericht per vergissing heeft ontvangen, verzoeken wij u ons op de hoogte te stellen en het bericht te vernietigen zonder het te kopiëren of te distribueren. Ons bedrijf staat niet in voor juiste en volledige overbrenging van de inhoud van een verzonden bericht, noch voor de tijdige ontvangst daarvan. Disclaimer: This E-mail is for use of the intended recipient(s) only and can contain information that is personal or confidential. It is prohibited to distribute the content of this message without the author's prior permission. If you have received it in error, please notify the sender and immediately delete this message without distributing or retaining copies hereof. Our company is not responsible for the comprehensiveness of this message nor it's time of delivery. ********************************************* From owner-freebsd-cvsweb@FreeBSD.ORG Wed Jun 2 12:37:08 2004 Return-Path: Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 04FBE16A4CE for ; Wed, 2 Jun 2004 12:37:08 -0700 (PDT) Received: from smtp1.pp.htv.fi (smtp1.pp.htv.fi [213.243.153.34]) by mx1.FreeBSD.org (Postfix) with ESMTP id BA04D43D41 for ; Wed, 2 Jun 2004 12:37:07 -0700 (PDT) (envelope-from scop@FreeBSD.org) Received: from posti.pp.htv.fi (posti.pp.htv.fi [212.90.64.50]) by smtp1.pp.htv.fi (Postfix) with ESMTP id 5AAF981364 for ; Wed, 2 Jun 2004 22:37:06 +0300 (EEST) Received: from [62.78.130.181] (cs78130181.pp.htv.fi [62.78.130.181]) /8.11.1) with ESMTP id i52Jb5J28051 for ; Wed, 2 Jun 2004 22:37:05 +0300 (EETDST) From: Ville =?ISO-8859-1?Q?Skytt=E4?= To: freebsd-cvsweb@FreeBSD.org In-Reply-To: <20040602171019.GA12732@vgelder.com> References: <20040602171019.GA12732@vgelder.com> Content-Type: text/plain Organization: FreeBSD Message-Id: <1086205024.30172.159.camel@bobcat.mine.nu> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 (1.4.6-2) Date: Wed, 02 Jun 2004 22:37:04 +0300 Content-Transfer-Encoding: 7bit Subject: Re: cvsweb version 3:3.0.1-1 diff problems (and howto debug this) X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS Web maintenance mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jun 2004 19:37:08 -0000 On Wed, 2004-06-02 at 20:10, Koos Vriezen wrote: > The various projects show fine, also the history of a file works. What > doesn't work are the links from a file history page (and this did work > in the previous version). Eg. the links 'text'/'markeup' return the same > history file. The 'preferred' link (for diff) shows a page with: > Error: module/file.diff: no such file or directory > for file 'file' in module 'module'. Some shooting-in-the-dark questions: What do the URLs in the server's access log look like for each of these (text/markup/preferred) when you hit the links? Do the "download", "annotated" and "colored" links work as expected? Which web server and browser do you use? Does it happen with all files in CVS, or just some of them? Anything in the server error log? > Any quick hints for fixing would be nice. I'm unable to reproduce any of the above, so no instant help available :( > But what is the best way to debug these configuration errors? I don't know if they're configuration errors or plain bugs, and dunno about the best way to debug either, but one lowly approach is to insert some warn() statements in the code and watch the web server error log. Depending on where you're inserting the warn()'s, you may also have to temporarily comment out some "open(STDERR, '>', devnull())"s in the code to actually see the warnings. > Eg. is there a list of env vars I should export > so I can run this script on the commandline, an example of a QUERY_STRING > etc? ISTR Debian applies some patches to make it possible to run the script on the command line, but AFAIK they have never been sent upstream (ie. here), and I have not tried them out. From owner-freebsd-cvsweb@FreeBSD.ORG Thu Jun 3 02:30:45 2004 Return-Path: Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 701A216A4CE for ; Thu, 3 Jun 2004 02:30:45 -0700 (PDT) Received: from mail.vgelder.com (vge.xs4all.nl [80.127.85.34]) by mx1.FreeBSD.org (Postfix) with ESMTP id D737D43D2F for ; Thu, 3 Jun 2004 02:30:44 -0700 (PDT) (envelope-from k.vriezen@vgelder.com) Received: by mail.vgelder.com (Postfix, from userid 106) id 8A6399CE; Thu, 3 Jun 2004 11:34:32 +0200 (CEST) Received: from santiago.intern (santiago.dmz [192.168.2.200])by mail.vgelder.com (Postfix) with ESMTP id 4360F48Dfor ; Thu, 3 Jun 2004 11:34:32 +0200 (CEST) Received: from santiago.intern (localhost.localdomain [127.0.0.1])by santiago.intern (8.12.11/8.12.11/Debian-3) with ESMTP id i539Ug2v018919for ; Thu, 3 Jun 2004 11:30:42 +0200 Received: (from kv@localhost)by santiago.intern (8.12.11/8.12.11/Debian-3) id i539UgxU018916for freebsd-cvsweb@FreeBSD.org; Thu, 3 Jun 2004 11:30:42 +0200 X-Authentication-Warning: santiago.intern: kv set sender to k.vriezen@vgelder.com using -f Date: Thu, 3 Jun 2004 11:30:42 +0200 From: Koos Vriezen To: freebsd-cvsweb@FreeBSD.org Message-ID: <20040603093042.GB12805@vgelder.com> References: <20040602171019.GA12732@vgelder.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040602171019.GA12732@vgelder.com> User-Agent: Mutt/1.5.5.1+cvs20040105i X-Copyrighted-Material: Please visit http://www.company.com/privacy.htm Subject: Re: cvsweb version 3:3.0.1-1 diff problems (and howto debug this) X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS Web maintenance mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jun 2004 09:30:45 -0000 You wrote: > On Wed, 2004-06-02 at 20:10, Koos Vriezen wrote: > > > The various projects show fine, also the history of a file works. What > > doesn't work are the links from a file history page (and this did work > > in the previous version). Eg. the links 'text'/'markeup' return the > > same > > history file. The 'preferred' link (for diff) shows a page with: > > Error: module/file.diff: no such file or directory > > for file 'file' in module 'module'. > > Some shooting-in-the-dark questions: > What do the URLs in the server's access log look like for each of these > (text/markup/preferred) when you hit the links? Do the "download", > "annotated" and "colored" links work as expected? download works, annotated AFAICS doesn't (but I never used this one) and colored does not work either. For revision 1.2 for file 'myfile' in module 'mymodule' for our internal web server (www.intern): preferred: http://www.intern/cgi-bin/cvsweb/mymodule/myfile.diff?r1=1.1;r2=1.2 colored: http://www.intern/cgi-bin/cvsweb/mymodule/myfile.diff?r1=1.1;r2=1.2;f=h text: http://www.intern/cgi-bin/cvsweb/mymodule/myfile?rev=1.2;content-type=text%2Fplain markup: http://www.intern/cgi-bin/cvsweb/mymodule/myfile?rev=1.2;content-type=text%2Fx-cvsweb-markup and a working one (download): http://www.intern/cgi-bin/cvsweb/~checkout~/mymodule/myfile?rev=1.2;content-type=text%2Fplain colored/preferred both return that error page: Error Error: mymodule/myfile.diff: no such file or directory -------------------------------------------------------------- FreeBSD-CVSweb > Which web server and browser do you use? $ apt-show-versions apache2-mpm-prefork apache2-mpm-prefork/testing uptodate 2.0.49-1 IE6 and konqueror-3.2.2 > Does it happen with all files in CVS, or just some of them? All of them > Anything in the server error log? No (I guess you mean apache log files). Even not when commenting "open(STDERR, '>', devnull())" (two cases). > > But what is the best way to debug these configuration errors? > > I don't know if they're configuration errors or plain bugs, and dunno > about the best way to debug either, but one lowly approach is to insert > some warn() statements in the code and watch the web server error log. Recommendations where? Already tried just before the above error page is generated: line1380: } else { my $fh = do { local (*FH); }; my $module; # Assume it's a module name with a potential path following it. my $xtra = (($module = $where) =~ s|/.*||) ? $& : ''; warn("xtra: $xtra\nmodule: $module\nfh: $fh\n"); # Is there an indexed version of modules? if (open($fh, "< $cvsroot/CVSROOT/modules")) { warn("$cvsroot/CVSROOT/modules opened\n"); while (<$fh>) { generates this when pressing 'preferred': [Thu Jun 03 11:21:37 2004] [error] [client 192.168.1.106] xtra: /myfile.diff, referer: http://www.intern/cgi-bin/cvsweb/mymodule/myfile [Thu Jun 03 11:21:37 2004] [error] [client 192.168.1.106] module: mymodule, referer: http://www.intern/cgi-bin/cvsweb/mymodule/myfile [Thu Jun 03 11:21:37 2004] [error] [client 192.168.1.106] fh: *main::FH, referer: http://www.intern/cgi-bin/cvsweb/mymodule/myfile [Thu Jun 03 11:21:37 2004] [error] [client 192.168.1.106] /var/smb/ontwikkel/cvs/CVSROOT/modules opened, referer: http://www.intern/cgi-bin/cvsweb/mymodule/myfile Btw, /var/smb/ontwikkel/cvs/CVSROOT/modules only contains lines starting with '#'. But maybe cvsweb should even come to this part? Thanks, Koos ***************DISCLAIMER*************** Bewijs van Afstand: Dit emailbericht is slechts bestemd voor de personen aan wie het is gericht en kan informatie bevatten die persoonlijk of vertrouwelijk is en niet openbaar mag worden gemaakt zonder goedkeuring van de auteur. Indien u dit bericht per vergissing heeft ontvangen, verzoeken wij u ons op de hoogte te stellen en het bericht te vernietigen zonder het te kopiëren of te distribueren. Ons bedrijf staat niet in voor juiste en volledige overbrenging van de inhoud van een verzonden bericht, noch voor de tijdige ontvangst daarvan. Disclaimer: This E-mail is for use of the intended recipient(s) only and can contain information that is personal or confidential. It is prohibited to distribute the content of this message without the author's prior permission. If you have received it in error, please notify the sender and immediately delete this message without distributing or retaining copies hereof. Our company is not responsible for the comprehensiveness of this message nor it's time of delivery. ********************************************* From owner-freebsd-cvsweb@FreeBSD.ORG Thu Jun 3 08:51:36 2004 Return-Path: Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3CEEE16A4CE for ; Thu, 3 Jun 2004 08:51:36 -0700 (PDT) Received: from smtp3.pp.htv.fi (smtp3.pp.htv.fi [213.243.153.36]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0208C43D54 for ; Thu, 3 Jun 2004 08:51:36 -0700 (PDT) (envelope-from scop@FreeBSD.org) Received: from posti.pp.htv.fi (posti.pp.htv.fi [212.90.64.50]) by smtp3.pp.htv.fi (Postfix) with ESMTP id E675227B327 for ; Thu, 3 Jun 2004 18:51:34 +0300 (EEST) Received: from [62.78.130.181] (cs78130181.pp.htv.fi [62.78.130.181]) /8.11.1) with ESMTP id i53FpYJ25514 for ; Thu, 3 Jun 2004 18:51:34 +0300 (EETDST) From: Ville =?ISO-8859-1?Q?Skytt=E4?= To: freebsd-cvsweb@FreeBSD.org In-Reply-To: <20040603093042.GB12805@vgelder.com> References: <20040602171019.GA12732@vgelder.com> <20040603093042.GB12805@vgelder.com> Content-Type: text/plain Organization: FreeBSD Message-Id: <1086277893.30172.244.camel@bobcat.mine.nu> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 (1.4.6-2) Date: Thu, 03 Jun 2004 18:51:33 +0300 Content-Transfer-Encoding: 7bit Subject: Re: cvsweb version 3:3.0.1-1 diff problems (and howto debug this) X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS Web maintenance mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jun 2004 15:51:36 -0000 On Thu, 2004-06-03 at 12:30, Koos Vriezen wrote: > You wrote: > For revision 1.2 for file 'myfile' in module 'mymodule' for our > internal web server (www.intern): [...] These look ok to me, although they don't look like the access log entries my Apache 2 generates. Just to be sure and to eliminate any browser issues: you did grab them from the access log, not the cvsweb HTML, right? > > I don't know if they're configuration errors or plain bugs, and dunno > > about the best way to debug either, but one lowly approach is to insert > > some warn() statements in the code and watch the web server error log. > > Recommendations where? When doing a diff, cvsweb should enter doDiff() near line 1320 or 1350 (the latter in your case, I guess, as the URLs have a ".diff" extension). Ditto, for annotate, it should enter doAnnotate() near line 1315. Try placing some warn()'s above those to find out why it (apparently) does not. > Btw, /var/smb/ontwikkel/cvs/CVSROOT/modules only contains lines starting > with '#'. But maybe cvsweb should even come to this part? Right, it should have went to doDiff() earlier. From owner-freebsd-cvsweb@FreeBSD.ORG Fri Jun 4 02:50:07 2004 Return-Path: Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0645716A4CE for ; Fri, 4 Jun 2004 02:50:07 -0700 (PDT) Received: from mail.vgelder.com (vge.xs4all.nl [80.127.85.34]) by mx1.FreeBSD.org (Postfix) with ESMTP id 64E8743D1D for ; Fri, 4 Jun 2004 02:50:06 -0700 (PDT) (envelope-from k.vriezen@vgelder.com) Received: by mail.vgelder.com (Postfix, from userid 106) id 4AD67A45; Fri, 4 Jun 2004 11:54:17 +0200 (CEST) Received: from santiago.intern (santiago.dmz [192.168.2.200])by mail.vgelder.com (Postfix) with ESMTP id 060B09CEfor ; Fri, 4 Jun 2004 11:54:17 +0200 (CEST) Received: from santiago.intern (localhost.localdomain [127.0.0.1])by santiago.intern (8.12.11/8.12.11/Debian-3) with ESMTP id i549o2xF028913for ; Fri, 4 Jun 2004 11:50:02 +0200 Received: (from kv@localhost)by santiago.intern (8.12.11/8.12.11/Debian-3) id i549o2II028910for freebsd-cvsweb@FreeBSD.org; Fri, 4 Jun 2004 11:50:02 +0200 X-Authentication-Warning: santiago.intern: kv set sender to k.vriezen@vgelder.com using -f Date: Fri, 4 Jun 2004 11:50:02 +0200 From: Koos Vriezen To: freebsd-cvsweb@FreeBSD.org Message-ID: <20040604095002.GA28772@vgelder.com> References: <20040602171019.GA12732@vgelder.com> <20040603093042.GB12805@vgelder.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040603093042.GB12805@vgelder.com> User-Agent: Mutt/1.5.5.1+cvs20040105i X-Copyrighted-Material: Please visit http://www.company.com/privacy.htm Subject: Re: cvsweb version 3:3.0.1-1 diff problems (and howto debug this) X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS Web maintenance mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jun 2004 09:50:07 -0000 > On Thu, Jun 03, 2004 at 11:30:42AM +0200, Koos Vriezen wrote: > > > > download works, annotated AFAICS doesn't (but I never used this one) and > > colored does not work either. > > For revision 1.2 for file 'myfile' in module 'mymodule' for our > > internal web server (www.intern): > > preferred: > > http://www.intern/cgi-bin/cvsweb/mymodule/myfile.diff?r1=1.1;r2=1.2 > > colored: > > http://www.intern/cgi-bin/cvsweb/mymodule/myfile.diff?r1=1.1;r2=1.2;f=h Ok, turned out to be the query string was not parsed right. The string r1=1.1;r2=1.2 was changed to r1%3D1.1%3Br2%3D1.2 at line 387: my %query = (); if (defined($ENV{QUERY_STRING})) { $ENV{QUERY_STRING} = uri_escape($ENV{QUERY_STRING}); for my $p (split(/[;&]+/, $ENV{QUERY_STRING})) { next unless $p; $p =~ y/+/ /; my ($key, $val) = split(/=/, $p, 2); next unless defined($key); $val = 1 unless defined($val); ($key = uri_unescape($key)) =~ /[[:graph:]]/ or next; ($val = uri_unescape($val)) =~ /[[:graph:]]/ or next; $query{$key} = $val; } } commenting out the 'uri_escape' line makes cvsweb work again. Up to you and/or debian maintainer to fix this, or is it my perl? (seem more likely to me to have a url_unescape or indeed nothing than escaping but I'm not in to this topic ATM) Thanks for the help, Koos ***************DISCLAIMER*************** Bewijs van Afstand: Dit emailbericht is slechts bestemd voor de personen aan wie het is gericht en kan informatie bevatten die persoonlijk of vertrouwelijk is en niet openbaar mag worden gemaakt zonder goedkeuring van de auteur. Indien u dit bericht per vergissing heeft ontvangen, verzoeken wij u ons op de hoogte te stellen en het bericht te vernietigen zonder het te kopiëren of te distribueren. Ons bedrijf staat niet in voor juiste en volledige overbrenging van de inhoud van een verzonden bericht, noch voor de tijdige ontvangst daarvan. Disclaimer: This E-mail is for use of the intended recipient(s) only and can contain information that is personal or confidential. It is prohibited to distribute the content of this message without the author's prior permission. If you have received it in error, please notify the sender and immediately delete this message without distributing or retaining copies hereof. Our company is not responsible for the comprehensiveness of this message nor it's time of delivery. ********************************************* From owner-freebsd-cvsweb@FreeBSD.ORG Fri Jun 4 06:57:30 2004 Return-Path: Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 13D0316A4CE for ; Fri, 4 Jun 2004 06:57:30 -0700 (PDT) Received: from smtp2.pp.htv.fi (smtp2.pp.htv.fi [213.243.153.35]) by mx1.FreeBSD.org (Postfix) with ESMTP id CEEBC43D45 for ; Fri, 4 Jun 2004 06:57:29 -0700 (PDT) (envelope-from scop@FreeBSD.org) Received: from posti.pp.htv.fi (posti.pp.htv.fi [212.90.64.50]) by smtp2.pp.htv.fi (Postfix) with ESMTP id B18EA297F78 for ; Fri, 4 Jun 2004 16:57:24 +0300 (EEST) Received: from [62.78.130.181] (cs78130181.pp.htv.fi [62.78.130.181]) /8.11.1) with ESMTP id i54DvOJ22213 for ; Fri, 4 Jun 2004 16:57:24 +0300 (EETDST) From: Ville =?ISO-8859-1?Q?Skytt=E4?= To: freebsd-cvsweb@FreeBSD.org In-Reply-To: <20040604095002.GA28772@vgelder.com> References: <20040602171019.GA12732@vgelder.com> <20040604095002.GA28772@vgelder.com> Content-Type: text/plain Organization: FreeBSD Message-Id: <1086357443.30172.290.camel@bobcat.mine.nu> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 (1.4.6-2) Date: Fri, 04 Jun 2004 16:57:24 +0300 Content-Transfer-Encoding: 7bit Subject: Re: cvsweb version 3:3.0.1-1 diff problems (and howto debug this) X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS Web maintenance mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jun 2004 13:57:30 -0000 On Fri, 2004-06-04 at 12:50, Koos Vriezen wrote: > Ok, turned out to be the query string was not parsed right. The string > r1=1.1;r2=1.2 was changed to r1%3D1.1%3Br2%3D1.2 at line 387: > > my %query = (); > if (defined($ENV{QUERY_STRING})) { > $ENV{QUERY_STRING} = uri_escape($ENV{QUERY_STRING}); > for my $p (split(/[;&]+/, $ENV{QUERY_STRING})) { [...] > commenting out the 'uri_escape' line makes cvsweb work again. > Up to you and/or debian maintainer to fix this, or is it my perl? That uri_escape() line does not exist in vanilla FreeBSD-CVSweb, so I guess it's a Debian addition and should be fixed there. It looks fundamentally broken to me; the only thing I can suggest is to remove it (instead of eg. trying to tweak the split() regexp below it to cope with the twice [1] escaped query string). [1] The QUERY_STRING environment variable should alredy be in URI encoded form. If it isn't, many things will most certainly break, and blindly re-encoding the whole of it before parsing the key=value pairs will not produce meaningful results. http://hoohoo.ncsa.uiuc.edu/cgi/env.html