From owner-freebsd-cvsweb@FreeBSD.ORG  Thu Jul 22 21:15:53 2004
Return-Path: <owner-freebsd-cvsweb@FreeBSD.ORG>
Delivered-To: freebsd-cvsweb@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C0CFB16A4CE
	for <freebsd-cvsweb@freebsd.org>;
	Thu, 22 Jul 2004 21:15:53 +0000 (GMT)
Received: from smtp1.pp.htv.fi (smtp1.pp.htv.fi [213.243.153.34])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8C7D543D41
	for <freebsd-cvsweb@freebsd.org>;
	Thu, 22 Jul 2004 21:15:53 +0000 (GMT)
	(envelope-from scop@FreeBSD.org)
Received: from [62.78.130.181] (cs78130181.pp.htv.fi [62.78.130.181])
	by smtp1.pp.htv.fi (Postfix) with ESMTP id 86032802D4
	for <freebsd-cvsweb@freebsd.org>;
	Fri, 23 Jul 2004 00:15:52 +0300 (EEST)
From: Ville =?ISO-8859-1?Q?Skytt=E4?= <scop@FreeBSD.org>
To: "'freebsd-cvsweb@freebsd.org'" <freebsd-cvsweb@freebsd.org>
In-Reply-To: <762A181C0D966E459A2EB3B810142C7707B2196B@nmrusdunsx12.nmrlan.net>
References: 
	 <762A181C0D966E459A2EB3B810142C7707B2196B@nmrusdunsx12.nmrlan.net>
Content-Type: text/plain
Organization: FreeBSD
Message-Id: <1090530951.29086.371.camel@bobcat.mine.nu>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.6 (1.4.6-2) 
Date: Fri, 23 Jul 2004 00:15:51 +0300
Content-Transfer-Encoding: 7bit
Subject: Re: Bug in sub hrefquote
X-BeenThere: freebsd-cvsweb@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS Web maintenance mailing list <freebsd-cvsweb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-cvsweb>,
	<mailto:freebsd-cvsweb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-cvsweb>
List-Post: <mailto:freebsd-cvsweb@freebsd.org>
List-Help: <mailto:freebsd-cvsweb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-cvsweb>,
	<mailto:freebsd-cvsweb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Jul 2004 21:15:53 -0000

On Fri, 2004-07-16 at 18:09, Quezada, Alex wrote:

Hi, and sorry for the delay,

> 	this routine is incorrectly translating spaces into +:  
> y/ /+/;
> 
> 	This is wrong, and if you have directories in your path that include
> spaces, the link you get is wrong.  I have replaced this with a substitution
> of '%20', which works as expected.

That change should be ok (see also below), but could you provide an
exact reproducer for this?  Ie. name of the directory, the resulting
link, where in the CVSweb UI it occurs, and the browser + version.  I've
spotted a few places where hrefquote() is clearly used in a wrong way
(<a name="..." in dir listings), but I haven't noticed any problems with
whitespace in paths for a long time.

> 	There's probably other ways to do this (like urlencode), but this
> seems simpler.

I would like to get rid of hrefquote() altogether.  Will look into it
soonish.

> PS: I figured out my broken binary problem.  BEA Weblogic's cgi interpreter
> was the culprit.  I installed Apache, and all is peachy now.

What OS do you use?  It is possible that we need to add a few binmode()
calls here and there.