From owner-freebsd-rc@FreeBSD.ORG Mon Feb 5 11:11:52 2007 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 396BE16A40D for ; Mon, 5 Feb 2007 11:11:50 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id 0E06F13C48E for ; Mon, 5 Feb 2007 11:11:50 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (linimon@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l15BBnH9026086 for ; Mon, 5 Feb 2007 11:11:49 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from linimon@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l15BBmsD026082 for freebsd-rc@FreeBSD.org; Mon, 5 Feb 2007 11:11:48 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 5 Feb 2007 11:11:48 GMT Message-Id: <200702051111.l15BBmsD026082@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: linimon set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-rc@FreeBSD.org Cc: Subject: Current problem reports assigned to you X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2007 11:11:52 -0000 Current FreeBSD problem reports Critical problems Serious problems S Tracker Resp. Description -------------------------------------------------------------------------------- o conf/48881 rc [PATCH] The influence of /etc/start_ifname on /etc/rc. o conf/98758 rc [patch] Templatize 'jail_fstab' in /etc/rc.d/jail o conf/98846 rc [patch] Templatize 'jail_rootdir' in /etc/rc.d/jail o bin/104623 rc "rc.d/ppp restart" stops all instances of ppp o conf/105689 rc syslogd starts too late at boot o conf/107155 rc /etc/rc.d/ppp-user does not bring up pppoe at boot o conf/107278 rc [patch] possible DoS when using the jail_interface opt o conf/107316 rc [rc.d]: [base] [rpc.lockd] nfslocking restart does not o conf/107364 rc pf fails to start on bootup after system update from F o conf/108226 rc second copy of ppp started at boot time 10 problems total. Non-critical problems S Tracker Resp. Description -------------------------------------------------------------------------------- o conf/45226 rc Fix for rc.network, ppp-user annoyance o conf/48870 rc [PATCH] rc.network: allow to cancel interface status d o conf/55916 rc [PATCH] ppp-user options o conf/58939 rc [patch] dumb little hack for /etc/rc.firewall{,6} o conf/73677 rc [patch] add support for powernow states to power_profi o conf/74817 rc [patch] network.subr: fixed automatic configuration of o conf/77663 rc Suggestion: add /etc/rc.d/addnetswap after addcritremo o conf/78906 rc [patch] Allow mixer_enable="NO" in rc.conf o conf/79196 rc [PATCH] configurable dummynet loading from /etc/rc.co o kern/81006 rc ipnat not working with tunnel interfaces on startup o conf/85363 rc syntax error in /etc/rc.d/devfs o conf/85819 rc [patch] script allowing multiuser mode in spite of fsc o conf/88913 rc [patch] wrapper support for rc.subr o conf/89061 rc [patch] IPv6 6to4 auto-configuration enhancement o conf/89870 rc [patch] feature request to make netif verbose rc.conf o conf/92523 rc [patch] allow rc scripts to kill process after a timeo o conf/93815 rc [patch] Adds in the ability to save ipfw rules to rc.d o conf/95162 rc [patch] Missing feature in rc.subr o conf/96343 rc [patch] rc.d order change to start inet6 before pf o conf/99444 rc [patch] Enhancement: rc.subr could easily support star o conf/99595 rc [PATCH] /etc/rc.d/dhclient doesn't interact well with o conf/99721 rc [patch] /etc/rc.initdiskless problem copy dotfile in s o conf/102700 rc [PATCH] Add encrypted /tmp support to GELI/GBDE rc.d s o conf/102722 rc kerberos5 server startupscript should use --detach o conf/102913 rc /etc/rc.d/named killall in jailed OS o conf/103486 rc [rc.d] [patch] rc.d/jail: mount fstab after devfs o conf/103489 rc [rc.d] [patch] named_chroot_autoupdate doesn't work in o conf/103976 rc rc.d/named restart failure o conf/104408 rc command not set in rc.d/isdnd, can't stop isdnd with t o conf/104549 rc [patch] rc.d/nfsd needs special _find_processes functi o conf/104884 rc [patch] Add support EtherChannel configuration to rc.c o conf/105145 rc [PATCH] add redial function to rc.d/ppp o conf/105568 rc [patch] Add more flexibility to rc.conf, to choose "_e o conf/106009 rc [patch] Fix pppoed startup script to process multiply o conf/106873 rc [patch] rc.d/nfslocking does not properly restart o conf/106978 rc "daily run" incorrectly assumes auth.log is rolled mor o conf/107035 rc bridge interface given in rc.conf not taking an (stati 37 problems total. From owner-freebsd-rc@FreeBSD.ORG Mon Feb 5 16:15:17 2007 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 31D8F16A4A0; Mon, 5 Feb 2007 16:15:10 +0000 (UTC) (envelope-from flz@FreeBSD.org) Received: from smtp1-g19.free.fr (smtp1-g19.free.fr [212.27.42.27]) by mx1.freebsd.org (Postfix) with ESMTP id A538513C441; Mon, 5 Feb 2007 16:15:09 +0000 (UTC) (envelope-from flz@FreeBSD.org) Received: from smtp.xbsd.org (unknown [82.233.2.192]) by smtp1-g19.free.fr (Postfix) with ESMTP id 9292D9B913; Mon, 5 Feb 2007 17:15:07 +0100 (CET) Received: from localhost (localhost.xbsd.org [127.0.0.1]) by smtp.xbsd.org (Postfix) with ESMTP id F37B711AD2; Mon, 5 Feb 2007 17:15:05 +0100 (CET) X-Virus-Scanned: amavisd-new at xbsd.org Received: from smtp.xbsd.org ([127.0.0.1]) by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8aVIX3NIguUd; Mon, 5 Feb 2007 17:14:58 +0100 (CET) Received: from [193.95.134.156] (mayday.esat.net [193.95.134.156]) by smtp.xbsd.org (Postfix) with ESMTP id BA3501164F; Mon, 5 Feb 2007 17:14:56 +0100 (CET) Message-ID: <45C757FA.2000209@FreeBSD.org> Date: Mon, 05 Feb 2007 16:14:50 +0000 From: Florent Thoumie User-Agent: Thunderbird 1.5.0.9 (X11/20070122) MIME-Version: 1.0 To: Norikatsu Shigemura References: <20061029010934.5afef73e.nork@FreeBSD.org> <200610281610.k9SGAIVb051055@freefall.freebsd.org> <20070129000459.b2dba4e0.nork@FreeBSD.org> In-Reply-To: <20070129000459.b2dba4e0.nork@FreeBSD.org> X-Enigmail-Version: 0.94.1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig40C6C70D41F5517E42A9C95A" Cc: dougb@FreeBSD.org, freebsd-bugs@FreeBSD.org, FreeBSD-gnats-submit@FreeBSD.org, freebsd-rc@FreeBSD.org Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2007 16:15:17 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig40C6C70D41F5517E42A9C95A Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Norikatsu Shigemura wrote: > On Sat, 28 Oct 2006 16:10:18 GMT > FreeBSD-gnats-submit@FreeBSD.org wrote: >> Thank you very much for your problem report. >> It has the internal identification `conf/104884'. >> The individual assigned to look at your >> report is: freebsd-bugs.=20 >> You can access the state of your problem report at any time >> via this link: >> http://www.freebsd.org/cgi/query-pr.cgi?pr=3D104884 >>> Category: conf >>> Responsible: freebsd-bugs >>> Synopsis: Add support EtherChannel configuration to rc.conf >>> Arrival-Date: Sat Oct 28 16:10:18 GMT 2006 >=20 > I chased HEAD. Please see following patch. > Anyone, please handle this PR? > And I'll make a patch for 6-stable. >=20 I've made my comments on this. Maybe someone else should review it? Doug, any input on that? --=20 Florent Thoumie flz@FreeBSD.org FreeBSD Committer --------------enig40C6C70D41F5517E42A9C95A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFFx1f/MxEkbVFH3PQRCi3rAJ9WtYBkxykvYLPBxBCiyF71mk7fjwCfQRz9 odg1ail5TUYqRh9Wct33sdY= =+qNW -----END PGP SIGNATURE----- --------------enig40C6C70D41F5517E42A9C95A-- From owner-freebsd-rc@FreeBSD.ORG Mon Feb 5 16:20:32 2007 Return-Path: X-Original-To: freebsd-rc@hub.freebsd.org Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7C7FD16A4CC for ; Mon, 5 Feb 2007 16:20:32 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id 4A9A313C441 for ; Mon, 5 Feb 2007 16:20:32 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l15GKW8W051494 for ; Mon, 5 Feb 2007 16:20:32 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l15GKWaQ051493; Mon, 5 Feb 2007 16:20:32 GMT (envelope-from gnats) Date: Mon, 5 Feb 2007 16:20:32 GMT Message-Id: <200702051620.l15GKWaQ051493@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org From: Florent Thoumie Cc: Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Florent Thoumie List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2007 16:20:33 -0000 The following reply was made to PR conf/104884; it has been noted by GNATS. From: Florent Thoumie To: Norikatsu Shigemura Cc: freebsd-rc@FreeBSD.org, freebsd-bugs@FreeBSD.org, FreeBSD-gnats-submit@FreeBSD.org, dougb@FreeBSD.org Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf Date: Mon, 05 Feb 2007 16:14:50 +0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig40C6C70D41F5517E42A9C95A Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Norikatsu Shigemura wrote: > On Sat, 28 Oct 2006 16:10:18 GMT > FreeBSD-gnats-submit@FreeBSD.org wrote: >> Thank you very much for your problem report. >> It has the internal identification `conf/104884'. >> The individual assigned to look at your >> report is: freebsd-bugs.=20 >> You can access the state of your problem report at any time >> via this link: >> http://www.freebsd.org/cgi/query-pr.cgi?pr=3D104884 >>> Category: conf >>> Responsible: freebsd-bugs >>> Synopsis: Add support EtherChannel configuration to rc.conf >>> Arrival-Date: Sat Oct 28 16:10:18 GMT 2006 >=20 > I chased HEAD. Please see following patch. > Anyone, please handle this PR? > And I'll make a patch for 6-stable. >=20 I've made my comments on this. Maybe someone else should review it? Doug, any input on that? --=20 Florent Thoumie flz@FreeBSD.org FreeBSD Committer --------------enig40C6C70D41F5517E42A9C95A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFFx1f/MxEkbVFH3PQRCi3rAJ9WtYBkxykvYLPBxBCiyF71mk7fjwCfQRz9 odg1ail5TUYqRh9Wct33sdY= =+qNW -----END PGP SIGNATURE----- --------------enig40C6C70D41F5517E42A9C95A-- From owner-freebsd-rc@FreeBSD.ORG Mon Feb 5 16:40:33 2007 Return-Path: X-Original-To: freebsd-rc@hub.freebsd.org Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2AB3A16A410 for ; Mon, 5 Feb 2007 16:40:33 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id 387F613C4A7 for ; Mon, 5 Feb 2007 16:40:31 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l15GeVQn054189 for ; Mon, 5 Feb 2007 16:40:31 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l15GeUS3054188; Mon, 5 Feb 2007 16:40:31 GMT (envelope-from gnats) Date: Mon, 5 Feb 2007 16:40:31 GMT Message-Id: <200702051640.l15GeUS3054188@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org From: Brooks Davis Cc: Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Brooks Davis List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2007 16:40:33 -0000 The following reply was made to PR conf/104884; it has been noted by GNATS. From: Brooks Davis To: Florent Thoumie Cc: Norikatsu Shigemura , dougb@freebsd.org, freebsd-bugs@freebsd.org, FreeBSD-gnats-submit@freebsd.org, freebsd-rc@freebsd.org Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf Date: Mon, 5 Feb 2007 10:36:46 -0600 On Mon, Feb 05, 2007 at 04:14:50PM +0000, Florent Thoumie wrote: > Norikatsu Shigemura wrote: > > On Sat, 28 Oct 2006 16:10:18 GMT > > FreeBSD-gnats-submit@FreeBSD.org wrote: > >> Thank you very much for your problem report. > >> It has the internal identification `conf/104884'. > >> The individual assigned to look at your > >> report is: freebsd-bugs. > >> You can access the state of your problem report at any time > >> via this link: > >> http://www.freebsd.org/cgi/query-pr.cgi?pr=104884 > >>> Category: conf > >>> Responsible: freebsd-bugs > >>> Synopsis: Add support EtherChannel configuration to rc.conf > >>> Arrival-Date: Sat Oct 28 16:10:18 GMT 2006 > > > > I chased HEAD. Please see following patch. > > Anyone, please handle this PR? > > And I'll make a patch for 6-stable. > > > > I've made my comments on this. Maybe someone else should review it? It seems basicly fine and should be useful. (At least until someone finally shoots the netgraph part of ng_fec in the head.) I'd like to see "" be the offical way to not configure any fec interfaces. gif_up's use of NO is a mistake (IMO). It would be OK to allow "NO" as an undocumented synanim for "". -- Brooks From owner-freebsd-rc@FreeBSD.ORG Mon Feb 5 16:41:25 2007 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 733F216A4A5; Mon, 5 Feb 2007 16:41:24 +0000 (UTC) (envelope-from flz@FreeBSD.org) Received: from smtp7-g19.free.fr (smtp7-g19.free.fr [212.27.42.64]) by mx1.freebsd.org (Postfix) with ESMTP id 9734A13C4C3; Mon, 5 Feb 2007 16:41:20 +0000 (UTC) (envelope-from flz@FreeBSD.org) Received: from smtp.xbsd.org (unknown [82.233.2.192]) by smtp7-g19.free.fr (Postfix) with ESMTP id A8EE65685; Mon, 5 Feb 2007 17:41:19 +0100 (CET) Received: from localhost (localhost.xbsd.org [127.0.0.1]) by smtp.xbsd.org (Postfix) with ESMTP id C082D117C5; Mon, 5 Feb 2007 17:41:18 +0100 (CET) X-Virus-Scanned: amavisd-new at xbsd.org Received: from smtp.xbsd.org ([127.0.0.1]) by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Y8+CL00AAt4l; Mon, 5 Feb 2007 17:41:10 +0100 (CET) Received: from [193.95.134.156] (mayday.esat.net [193.95.134.156]) by smtp.xbsd.org (Postfix) with ESMTP id EB39511413; Mon, 5 Feb 2007 17:41:09 +0100 (CET) Message-ID: <45C75E1F.2070709@FreeBSD.org> Date: Mon, 05 Feb 2007 16:41:03 +0000 From: Florent Thoumie User-Agent: Thunderbird 1.5.0.9 (X11/20070122) MIME-Version: 1.0 To: Brooks Davis References: <20061029010934.5afef73e.nork@FreeBSD.org> <200610281610.k9SGAIVb051055@freefall.freebsd.org> <20070129000459.b2dba4e0.nork@FreeBSD.org> <45C757FA.2000209@FreeBSD.org> <20070205163646.GB48768@lor.one-eyed-alien.net> In-Reply-To: <20070205163646.GB48768@lor.one-eyed-alien.net> X-Enigmail-Version: 0.94.1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig1AFF4891C58A325D2BF554BF" Cc: FreeBSD-gnats-submit@freebsd.org, freebsd-bugs@freebsd.org, dougb@freebsd.org, freebsd-rc@freebsd.org, Norikatsu Shigemura Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2007 16:41:27 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig1AFF4891C58A325D2BF554BF Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Brooks Davis wrote: > On Mon, Feb 05, 2007 at 04:14:50PM +0000, Florent Thoumie wrote: >> Norikatsu Shigemura wrote: >>> On Sat, 28 Oct 2006 16:10:18 GMT >>> FreeBSD-gnats-submit@FreeBSD.org wrote: >>>> Thank you very much for your problem report. >>>> It has the internal identification `conf/104884'. >>>> The individual assigned to look at your >>>> report is: freebsd-bugs.=20 >>>> You can access the state of your problem report at any time >>>> via this link: >>>> http://www.freebsd.org/cgi/query-pr.cgi?pr=3D104884 >>>>> Category: conf >>>>> Responsible: freebsd-bugs >>>>> Synopsis: Add support EtherChannel configuration to rc.conf >>>>> Arrival-Date: Sat Oct 28 16:10:18 GMT 2006 >>> I chased HEAD. Please see following patch. >>> Anyone, please handle this PR? >>> And I'll make a patch for 6-stable. >>> >> I've made my comments on this. Maybe someone else should review it? >=20 > It seems basicly fine and should be useful. (At least until someone > finally shoots the netgraph part of ng_fec in the head.) I'd like to > see "" be the offical way to not configure any fec interfaces. gif_up's= > use of NO is a mistake (IMO). It would be OK to allow "NO" as an > undocumented synanim for "". Agreed, as said in my previous post. I think we could just set gif_interfaces and fec_interfaces to "" in -CURRENT and add the "NO" compatibility in RELENG_6 when MFC time comes? That would be a candidate for 7.0 RELNOTES. Does it make any sense to you? --=20 Florent Thoumie flz@FreeBSD.org FreeBSD Committer --------------enig1AFF4891C58A325D2BF554BF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFFx14kMxEkbVFH3PQRCs/uAJ9dx+NaGSyPnIFVmw8QGcTJ7orzygCcDqRl /Dhp6oOEDNkXhMopL6pBlHM= =0aIJ -----END PGP SIGNATURE----- --------------enig1AFF4891C58A325D2BF554BF-- From owner-freebsd-rc@FreeBSD.ORG Mon Feb 5 16:50:26 2007 Return-Path: X-Original-To: freebsd-rc@hub.freebsd.org Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7A26C16A409 for ; Mon, 5 Feb 2007 16:50:25 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id A84CE13C4B5 for ; Mon, 5 Feb 2007 16:50:24 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l15GoOMI054516 for ; Mon, 5 Feb 2007 16:50:24 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l15GoOrP054515; Mon, 5 Feb 2007 16:50:24 GMT (envelope-from gnats) Date: Mon, 5 Feb 2007 16:50:24 GMT Message-Id: <200702051650.l15GoOrP054515@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org From: Florent Thoumie Cc: Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Florent Thoumie List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2007 16:50:26 -0000 The following reply was made to PR conf/104884; it has been noted by GNATS. From: Florent Thoumie To: Brooks Davis Cc: Norikatsu Shigemura , dougb@freebsd.org, freebsd-bugs@freebsd.org, FreeBSD-gnats-submit@freebsd.org, freebsd-rc@freebsd.org Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf Date: Mon, 05 Feb 2007 16:41:03 +0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig1AFF4891C58A325D2BF554BF Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Brooks Davis wrote: > On Mon, Feb 05, 2007 at 04:14:50PM +0000, Florent Thoumie wrote: >> Norikatsu Shigemura wrote: >>> On Sat, 28 Oct 2006 16:10:18 GMT >>> FreeBSD-gnats-submit@FreeBSD.org wrote: >>>> Thank you very much for your problem report. >>>> It has the internal identification `conf/104884'. >>>> The individual assigned to look at your >>>> report is: freebsd-bugs.=20 >>>> You can access the state of your problem report at any time >>>> via this link: >>>> http://www.freebsd.org/cgi/query-pr.cgi?pr=3D104884 >>>>> Category: conf >>>>> Responsible: freebsd-bugs >>>>> Synopsis: Add support EtherChannel configuration to rc.conf >>>>> Arrival-Date: Sat Oct 28 16:10:18 GMT 2006 >>> I chased HEAD. Please see following patch. >>> Anyone, please handle this PR? >>> And I'll make a patch for 6-stable. >>> >> I've made my comments on this. Maybe someone else should review it? >=20 > It seems basicly fine and should be useful. (At least until someone > finally shoots the netgraph part of ng_fec in the head.) I'd like to > see "" be the offical way to not configure any fec interfaces. gif_up's= > use of NO is a mistake (IMO). It would be OK to allow "NO" as an > undocumented synanim for "". Agreed, as said in my previous post. I think we could just set gif_interfaces and fec_interfaces to "" in -CURRENT and add the "NO" compatibility in RELENG_6 when MFC time comes? That would be a candidate for 7.0 RELNOTES. Does it make any sense to you? --=20 Florent Thoumie flz@FreeBSD.org FreeBSD Committer --------------enig1AFF4891C58A325D2BF554BF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFFx14kMxEkbVFH3PQRCs/uAJ9dx+NaGSyPnIFVmw8QGcTJ7orzygCcDqRl /Dhp6oOEDNkXhMopL6pBlHM= =0aIJ -----END PGP SIGNATURE----- --------------enig1AFF4891C58A325D2BF554BF-- From owner-freebsd-rc@FreeBSD.ORG Mon Feb 5 16:55:08 2007 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id CDC6916A408; Mon, 5 Feb 2007 16:55:04 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (grnl-static-02-0046.dsl.iowatelecom.net [69.66.56.110]) by mx1.freebsd.org (Postfix) with ESMTP id 745F713C4B2; Mon, 5 Feb 2007 16:55:04 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.13.8/8.13.8) with ESMTP id l15GalVj050108; Mon, 5 Feb 2007 10:36:47 -0600 (CST) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.13.8/8.13.8/Submit) id l15Gals2050107; Mon, 5 Feb 2007 10:36:47 -0600 (CST) (envelope-from brooks) Date: Mon, 5 Feb 2007 10:36:46 -0600 From: Brooks Davis To: Florent Thoumie Message-ID: <20070205163646.GB48768@lor.one-eyed-alien.net> References: <20061029010934.5afef73e.nork@FreeBSD.org> <200610281610.k9SGAIVb051055@freefall.freebsd.org> <20070129000459.b2dba4e0.nork@FreeBSD.org> <45C757FA.2000209@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <45C757FA.2000209@FreeBSD.org> User-Agent: Mutt/1.5.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (lor.one-eyed-alien.net [127.0.0.1]); Mon, 05 Feb 2007 10:36:47 -0600 (CST) Cc: FreeBSD-gnats-submit@freebsd.org, freebsd-bugs@freebsd.org, dougb@freebsd.org, freebsd-rc@freebsd.org, Norikatsu Shigemura Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2007 16:55:08 -0000 On Mon, Feb 05, 2007 at 04:14:50PM +0000, Florent Thoumie wrote: > Norikatsu Shigemura wrote: > > On Sat, 28 Oct 2006 16:10:18 GMT > > FreeBSD-gnats-submit@FreeBSD.org wrote: > >> Thank you very much for your problem report. > >> It has the internal identification `conf/104884'. > >> The individual assigned to look at your > >> report is: freebsd-bugs. > >> You can access the state of your problem report at any time > >> via this link: > >> http://www.freebsd.org/cgi/query-pr.cgi?pr=104884 > >>> Category: conf > >>> Responsible: freebsd-bugs > >>> Synopsis: Add support EtherChannel configuration to rc.conf > >>> Arrival-Date: Sat Oct 28 16:10:18 GMT 2006 > > > > I chased HEAD. Please see following patch. > > Anyone, please handle this PR? > > And I'll make a patch for 6-stable. > > > > I've made my comments on this. Maybe someone else should review it? It seems basicly fine and should be useful. (At least until someone finally shoots the netgraph part of ng_fec in the head.) I'd like to see "" be the offical way to not configure any fec interfaces. gif_up's use of NO is a mistake (IMO). It would be OK to allow "NO" as an undocumented synanim for "". -- Brooks From owner-freebsd-rc@FreeBSD.ORG Mon Feb 5 18:50:25 2007 Return-Path: X-Original-To: freebsd-rc@hub.freebsd.org Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2324F16A40B for ; Mon, 5 Feb 2007 18:50:25 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id E9AA013C494 for ; Mon, 5 Feb 2007 18:50:24 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l15IoOmk062756 for ; Mon, 5 Feb 2007 18:50:24 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l15IoOG3062751; Mon, 5 Feb 2007 18:50:24 GMT (envelope-from gnats) Date: Mon, 5 Feb 2007 18:50:24 GMT Message-Id: <200702051850.l15IoOG3062751@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org From: Doug Barton Cc: Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Doug Barton List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2007 18:50:25 -0000 The following reply was made to PR conf/104884; it has been noted by GNATS. From: Doug Barton To: Florent Thoumie Cc: Brooks Davis , Norikatsu Shigemura , freebsd-bugs@freebsd.org, FreeBSD-gnats-submit@freebsd.org, freebsd-rc@freebsd.org Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf Date: Mon, 05 Feb 2007 10:44:13 -0800 Florent Thoumie wrote: > Brooks Davis wrote: >> On Mon, Feb 05, 2007 at 04:14:50PM +0000, Florent Thoumie wrote: >>> Norikatsu Shigemura wrote: >>>> On Sat, 28 Oct 2006 16:10:18 GMT >>>> FreeBSD-gnats-submit@FreeBSD.org wrote: >>>>> Thank you very much for your problem report. >>>>> It has the internal identification `conf/104884'. >>>>> The individual assigned to look at your >>>>> report is: freebsd-bugs. >>>>> You can access the state of your problem report at any time >>>>> via this link: >>>>> http://www.freebsd.org/cgi/query-pr.cgi?pr=104884 >>>>>> Category: conf >>>>>> Responsible: freebsd-bugs >>>>>> Synopsis: Add support EtherChannel configuration to rc.conf >>>>>> Arrival-Date: Sat Oct 28 16:10:18 GMT 2006 >>>> I chased HEAD. Please see following patch. >>>> Anyone, please handle this PR? >>>> And I'll make a patch for 6-stable. >>>> >>> I've made my comments on this. Maybe someone else should review it? >> It seems basicly fine and should be useful. (At least until someone >> finally shoots the netgraph part of ng_fec in the head.) I'd like to >> see "" be the offical way to not configure any fec interfaces. gif_up's >> use of NO is a mistake (IMO). It would be OK to allow "NO" as an >> undocumented synanim for "". > > Agreed, as said in my previous post. > > I think we could just set gif_interfaces and fec_interfaces to "" in > -CURRENT and add the "NO" compatibility in RELENG_6 when MFC time comes? > That would be a candidate for 7.0 RELNOTES. > > Does it make any sense to you? My instinct is to have it the other way around, with "NO" being the default, and "" being a synonym. We've trained people that "NO" is the way to turn things off with rc, and the one glaring exception to that rule (sendmail) has caused an enormous amount of confusion over the years. Other than that, I have no objections here. hth, Doug -- This .signature sanitized for your protection From owner-freebsd-rc@FreeBSD.ORG Mon Feb 5 18:51:01 2007 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 97DEE16A48F; Mon, 5 Feb 2007 18:51:01 +0000 (UTC) (envelope-from flz@FreeBSD.org) Received: from smtp3-g19.free.fr (smtp3-g19.free.fr [212.27.42.29]) by mx1.freebsd.org (Postfix) with ESMTP id AC7EF13C4B7; Mon, 5 Feb 2007 18:51:00 +0000 (UTC) (envelope-from flz@FreeBSD.org) Received: from smtp.xbsd.org (unknown [82.233.2.192]) by smtp3-g19.free.fr (Postfix) with ESMTP id D3DB44A1E6; Mon, 5 Feb 2007 19:50:58 +0100 (CET) Received: from localhost (localhost.xbsd.org [127.0.0.1]) by smtp.xbsd.org (Postfix) with ESMTP id 3E65611B13; Mon, 5 Feb 2007 19:50:57 +0100 (CET) X-Virus-Scanned: amavisd-new at xbsd.org Received: from smtp.xbsd.org ([127.0.0.1]) by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wNbxgGsbEidR; Mon, 5 Feb 2007 19:50:48 +0100 (CET) Received: from [193.120.13.130] (cream.xbsd.org [193.120.13.130]) by smtp.xbsd.org (Postfix) with ESMTP id D8A0311B10; Mon, 5 Feb 2007 19:50:46 +0100 (CET) Message-ID: <45C77B9B.20403@FreeBSD.org> Date: Mon, 05 Feb 2007 18:46:51 +0000 From: Florent Thoumie User-Agent: Thunderbird 1.5.0.9 (X11/20070122) MIME-Version: 1.0 To: Doug Barton References: <20061029010934.5afef73e.nork@FreeBSD.org> <200610281610.k9SGAIVb051055@freefall.freebsd.org> <20070129000459.b2dba4e0.nork@FreeBSD.org> <45C757FA.2000209@FreeBSD.org> <20070205163646.GB48768@lor.one-eyed-alien.net> <45C75E1F.2070709@FreeBSD.org> <45C77AFD.1050801@FreeBSD.org> In-Reply-To: <45C77AFD.1050801@FreeBSD.org> X-Enigmail-Version: 0.94.1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enigEB8CC80FB262C2C8C1201611" Cc: FreeBSD-gnats-submit@freebsd.org, freebsd-bugs@freebsd.org, Brooks Davis , freebsd-rc@freebsd.org, Norikatsu Shigemura Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2007 18:51:02 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigEB8CC80FB262C2C8C1201611 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Doug Barton wrote: > Florent Thoumie wrote: >> Brooks Davis wrote: >>> On Mon, Feb 05, 2007 at 04:14:50PM +0000, Florent Thoumie wrote: >>>> Norikatsu Shigemura wrote: >>>>> On Sat, 28 Oct 2006 16:10:18 GMT >>>>> FreeBSD-gnats-submit@FreeBSD.org wrote: >>>>>> Thank you very much for your problem report. >>>>>> It has the internal identification `conf/104884'. >>>>>> The individual assigned to look at your >>>>>> report is: freebsd-bugs. You can access the state of your problem >>>>>> report at any time >>>>>> via this link: >>>>>> http://www.freebsd.org/cgi/query-pr.cgi?pr=3D104884 >>>>>>> Category: conf >>>>>>> Responsible: freebsd-bugs >>>>>>> Synopsis: Add support EtherChannel configuration to rc.conf= >>>>>>> Arrival-Date: Sat Oct 28 16:10:18 GMT 2006 >>>>> I chased HEAD. Please see following patch. >>>>> Anyone, please handle this PR? >>>>> And I'll make a patch for 6-stable. >>>>> >>>> I've made my comments on this. Maybe someone else should review it? >>> It seems basicly fine and should be useful. (At least until someone >>> finally shoots the netgraph part of ng_fec in the head.) I'd like to= >>> see "" be the offical way to not configure any fec interfaces. gif_up= 's >>> use of NO is a mistake (IMO). It would be OK to allow "NO" as an >>> undocumented synanim for "". >> >> Agreed, as said in my previous post. >> >> I think we could just set gif_interfaces and fec_interfaces to "" in >> -CURRENT and add the "NO" compatibility in RELENG_6 when MFC time come= s? >> That would be a candidate for 7.0 RELNOTES. >> >> Does it make any sense to you? >=20 > My instinct is to have it the other way around, with "NO" being the > default, and "" being a synonym. We've trained people that "NO" is the > way to turn things off with rc, and the one glaring exception to that > rule (sendmail) has caused an enormous amount of confusion over the yea= rs. >=20 > Other than that, I have no objections here. IMHO, it makes sense to have "NO" as opposed to "YES". In this case, it's a list. So an empty list would be "", but keeping "NO"-compatibility for the -STABLE branch ensures POLA. At least that's how I see it. --=20 Florent Thoumie flz@FreeBSD.org FreeBSD Committer --------------enigEB8CC80FB262C2C8C1201611 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFFx3uyMxEkbVFH3PQRCqhkAKCQBImTiFhsraqP5cUh45Y/C5MIhACeJupV NYtNF9lLKx9vyWC+JZHSr0E= =HVOK -----END PGP SIGNATURE----- --------------enigEB8CC80FB262C2C8C1201611-- From owner-freebsd-rc@FreeBSD.ORG Mon Feb 5 19:00:51 2007 Return-Path: X-Original-To: freebsd-rc@hub.freebsd.org Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id DB10416A4E2 for ; Mon, 5 Feb 2007 19:00:50 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id EFE8013C4BB for ; Mon, 5 Feb 2007 19:00:44 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l15J0i7f063124 for ; Mon, 5 Feb 2007 19:00:44 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l15J0ilj063123; Mon, 5 Feb 2007 19:00:44 GMT (envelope-from gnats) Date: Mon, 5 Feb 2007 19:00:44 GMT Message-Id: <200702051900.l15J0ilj063123@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org From: Florent Thoumie Cc: Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Florent Thoumie List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2007 19:00:51 -0000 The following reply was made to PR conf/104884; it has been noted by GNATS. From: Florent Thoumie To: Doug Barton Cc: Brooks Davis , Norikatsu Shigemura , freebsd-bugs@freebsd.org, FreeBSD-gnats-submit@freebsd.org, freebsd-rc@freebsd.org Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf Date: Mon, 05 Feb 2007 18:46:51 +0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigEB8CC80FB262C2C8C1201611 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Doug Barton wrote: > Florent Thoumie wrote: >> Brooks Davis wrote: >>> On Mon, Feb 05, 2007 at 04:14:50PM +0000, Florent Thoumie wrote: >>>> Norikatsu Shigemura wrote: >>>>> On Sat, 28 Oct 2006 16:10:18 GMT >>>>> FreeBSD-gnats-submit@FreeBSD.org wrote: >>>>>> Thank you very much for your problem report. >>>>>> It has the internal identification `conf/104884'. >>>>>> The individual assigned to look at your >>>>>> report is: freebsd-bugs. You can access the state of your problem >>>>>> report at any time >>>>>> via this link: >>>>>> http://www.freebsd.org/cgi/query-pr.cgi?pr=3D104884 >>>>>>> Category: conf >>>>>>> Responsible: freebsd-bugs >>>>>>> Synopsis: Add support EtherChannel configuration to rc.conf= >>>>>>> Arrival-Date: Sat Oct 28 16:10:18 GMT 2006 >>>>> I chased HEAD. Please see following patch. >>>>> Anyone, please handle this PR? >>>>> And I'll make a patch for 6-stable. >>>>> >>>> I've made my comments on this. Maybe someone else should review it? >>> It seems basicly fine and should be useful. (At least until someone >>> finally shoots the netgraph part of ng_fec in the head.) I'd like to= >>> see "" be the offical way to not configure any fec interfaces. gif_up= 's >>> use of NO is a mistake (IMO). It would be OK to allow "NO" as an >>> undocumented synanim for "". >> >> Agreed, as said in my previous post. >> >> I think we could just set gif_interfaces and fec_interfaces to "" in >> -CURRENT and add the "NO" compatibility in RELENG_6 when MFC time come= s? >> That would be a candidate for 7.0 RELNOTES. >> >> Does it make any sense to you? >=20 > My instinct is to have it the other way around, with "NO" being the > default, and "" being a synonym. We've trained people that "NO" is the > way to turn things off with rc, and the one glaring exception to that > rule (sendmail) has caused an enormous amount of confusion over the yea= rs. >=20 > Other than that, I have no objections here. IMHO, it makes sense to have "NO" as opposed to "YES". In this case, it's a list. So an empty list would be "", but keeping "NO"-compatibility for the -STABLE branch ensures POLA. At least that's how I see it. --=20 Florent Thoumie flz@FreeBSD.org FreeBSD Committer --------------enigEB8CC80FB262C2C8C1201611 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFFx3uyMxEkbVFH3PQRCqhkAKCQBImTiFhsraqP5cUh45Y/C5MIhACeJupV NYtNF9lLKx9vyWC+JZHSr0E= =HVOK -----END PGP SIGNATURE----- --------------enigEB8CC80FB262C2C8C1201611-- From owner-freebsd-rc@FreeBSD.ORG Mon Feb 5 19:02:23 2007 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3042416A40B; Mon, 5 Feb 2007 19:02:22 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (grnl-static-02-0046.dsl.iowatelecom.net [69.66.56.110]) by mx1.freebsd.org (Postfix) with ESMTP id D35BC13C47E; Mon, 5 Feb 2007 19:02:21 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.13.8/8.13.8) with ESMTP id l15J2L8L051561; Mon, 5 Feb 2007 13:02:21 -0600 (CST) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.13.8/8.13.8/Submit) id l15J2LnO051560; Mon, 5 Feb 2007 13:02:21 -0600 (CST) (envelope-from brooks) Date: Mon, 5 Feb 2007 13:02:21 -0600 From: Brooks Davis To: Florent Thoumie Message-ID: <20070205190220.GA51379@lor.one-eyed-alien.net> References: <20061029010934.5afef73e.nork@FreeBSD.org> <200610281610.k9SGAIVb051055@freefall.freebsd.org> <20070129000459.b2dba4e0.nork@FreeBSD.org> <45C757FA.2000209@FreeBSD.org> <20070205163646.GB48768@lor.one-eyed-alien.net> <45C75E1F.2070709@FreeBSD.org> <45C77AFD.1050801@FreeBSD.org> <45C77B9B.20403@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <45C77B9B.20403@FreeBSD.org> User-Agent: Mutt/1.5.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (lor.one-eyed-alien.net [127.0.0.1]); Mon, 05 Feb 2007 13:02:21 -0600 (CST) Cc: freebsd-bugs@FreeBSD.org, Doug Barton , freebsd-rc@FreeBSD.org, Norikatsu Shigemura , Brooks Davis , FreeBSD-gnats-submit@FreeBSD.org Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2007 19:02:23 -0000 On Mon, Feb 05, 2007 at 06:46:51PM +0000, Florent Thoumie wrote: > Doug Barton wrote: > > Florent Thoumie wrote: > >> Brooks Davis wrote: > >>> On Mon, Feb 05, 2007 at 04:14:50PM +0000, Florent Thoumie wrote: > >>>> Norikatsu Shigemura wrote: > >>>>> On Sat, 28 Oct 2006 16:10:18 GMT > >>>>> FreeBSD-gnats-submit@FreeBSD.org wrote: > >>>>>> Thank you very much for your problem report. > >>>>>> It has the internal identification `conf/104884'. > >>>>>> The individual assigned to look at your > >>>>>> report is: freebsd-bugs. You can access the state of your problem > >>>>>> report at any time > >>>>>> via this link: > >>>>>> http://www.freebsd.org/cgi/query-pr.cgi?pr=104884 > >>>>>>> Category: conf > >>>>>>> Responsible: freebsd-bugs > >>>>>>> Synopsis: Add support EtherChannel configuration to rc.conf > >>>>>>> Arrival-Date: Sat Oct 28 16:10:18 GMT 2006 > >>>>> I chased HEAD. Please see following patch. > >>>>> Anyone, please handle this PR? > >>>>> And I'll make a patch for 6-stable. > >>>>> > >>>> I've made my comments on this. Maybe someone else should review it? > >>> It seems basicly fine and should be useful. (At least until someone > >>> finally shoots the netgraph part of ng_fec in the head.) I'd like to > >>> see "" be the offical way to not configure any fec interfaces. gif_up's > >>> use of NO is a mistake (IMO). It would be OK to allow "NO" as an > >>> undocumented synanim for "". > >> > >> Agreed, as said in my previous post. > >> > >> I think we could just set gif_interfaces and fec_interfaces to "" in > >> -CURRENT and add the "NO" compatibility in RELENG_6 when MFC time comes? > >> That would be a candidate for 7.0 RELNOTES. > >> > >> Does it make any sense to you? > > > > My instinct is to have it the other way around, with "NO" being the > > default, and "" being a synonym. We've trained people that "NO" is the > > way to turn things off with rc, and the one glaring exception to that > > rule (sendmail) has caused an enormous amount of confusion over the years. > > > > Other than that, I have no objections here. > > IMHO, it makes sense to have "NO" as opposed to "YES". In this case, > it's a list. So an empty list would be "", but keeping > "NO"-compatibility for the -STABLE branch ensures POLA. At least that's > how I see it. I agree. It's a list not a Boolean. There's no reason to poison its name space this way. Also, gif_interfaces is the only *_interfaces variable that takes "NO" as a special argument. The default should be an empty list which results in nothing happening. I'd suggest making empty list the value for the default gif_interfaces in /etc/defaults/rc.conf in both branches, removing support for NO in CURRENT and emitting a warning in stable. -- Brooks From owner-freebsd-rc@FreeBSD.ORG Mon Feb 5 19:10:27 2007 Return-Path: X-Original-To: freebsd-rc@hub.freebsd.org Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3C88916A40E for ; Mon, 5 Feb 2007 19:10:26 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id 0073F13C494 for ; Mon, 5 Feb 2007 19:10:26 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l15JAP03063545 for ; Mon, 5 Feb 2007 19:10:25 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l15JAPd5063541; Mon, 5 Feb 2007 19:10:25 GMT (envelope-from gnats) Date: Mon, 5 Feb 2007 19:10:25 GMT Message-Id: <200702051910.l15JAPd5063541@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org From: Brooks Davis Cc: Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Brooks Davis List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2007 19:10:27 -0000 The following reply was made to PR conf/104884; it has been noted by GNATS. From: Brooks Davis To: Florent Thoumie Cc: Doug Barton , Brooks Davis , Norikatsu Shigemura , freebsd-bugs@FreeBSD.org, FreeBSD-gnats-submit@FreeBSD.org, freebsd-rc@FreeBSD.org Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf Date: Mon, 5 Feb 2007 13:02:21 -0600 On Mon, Feb 05, 2007 at 06:46:51PM +0000, Florent Thoumie wrote: > Doug Barton wrote: > > Florent Thoumie wrote: > >> Brooks Davis wrote: > >>> On Mon, Feb 05, 2007 at 04:14:50PM +0000, Florent Thoumie wrote: > >>>> Norikatsu Shigemura wrote: > >>>>> On Sat, 28 Oct 2006 16:10:18 GMT > >>>>> FreeBSD-gnats-submit@FreeBSD.org wrote: > >>>>>> Thank you very much for your problem report. > >>>>>> It has the internal identification `conf/104884'. > >>>>>> The individual assigned to look at your > >>>>>> report is: freebsd-bugs. You can access the state of your problem > >>>>>> report at any time > >>>>>> via this link: > >>>>>> http://www.freebsd.org/cgi/query-pr.cgi?pr=104884 > >>>>>>> Category: conf > >>>>>>> Responsible: freebsd-bugs > >>>>>>> Synopsis: Add support EtherChannel configuration to rc.conf > >>>>>>> Arrival-Date: Sat Oct 28 16:10:18 GMT 2006 > >>>>> I chased HEAD. Please see following patch. > >>>>> Anyone, please handle this PR? > >>>>> And I'll make a patch for 6-stable. > >>>>> > >>>> I've made my comments on this. Maybe someone else should review it? > >>> It seems basicly fine and should be useful. (At least until someone > >>> finally shoots the netgraph part of ng_fec in the head.) I'd like to > >>> see "" be the offical way to not configure any fec interfaces. gif_up's > >>> use of NO is a mistake (IMO). It would be OK to allow "NO" as an > >>> undocumented synanim for "". > >> > >> Agreed, as said in my previous post. > >> > >> I think we could just set gif_interfaces and fec_interfaces to "" in > >> -CURRENT and add the "NO" compatibility in RELENG_6 when MFC time comes? > >> That would be a candidate for 7.0 RELNOTES. > >> > >> Does it make any sense to you? > > > > My instinct is to have it the other way around, with "NO" being the > > default, and "" being a synonym. We've trained people that "NO" is the > > way to turn things off with rc, and the one glaring exception to that > > rule (sendmail) has caused an enormous amount of confusion over the years. > > > > Other than that, I have no objections here. > > IMHO, it makes sense to have "NO" as opposed to "YES". In this case, > it's a list. So an empty list would be "", but keeping > "NO"-compatibility for the -STABLE branch ensures POLA. At least that's > how I see it. I agree. It's a list not a Boolean. There's no reason to poison its name space this way. Also, gif_interfaces is the only *_interfaces variable that takes "NO" as a special argument. The default should be an empty list which results in nothing happening. I'd suggest making empty list the value for the default gif_interfaces in /etc/defaults/rc.conf in both branches, removing support for NO in CURRENT and emitting a warning in stable. -- Brooks From owner-freebsd-rc@FreeBSD.ORG Mon Feb 5 19:10:59 2007 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 098AE16A403 for ; Mon, 5 Feb 2007 19:10:57 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx22.fluidhosting.com [204.14.89.5]) by mx1.freebsd.org (Postfix) with SMTP id 6128B13C46B for ; Mon, 5 Feb 2007 19:10:56 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: (qmail 27292 invoked by uid 399); 5 Feb 2007 18:44:15 -0000 Received: from pool-71-160-134-240.lsanca.dsl-w.verizon.net (HELO lap.dougb.net) (dougb@dougbarton.us@71.160.134.240) by mail2.fluidhosting.com with SMTP; 5 Feb 2007 18:44:15 -0000 X-Originating-IP: 71.160.134.240 Message-ID: <45C77AFD.1050801@FreeBSD.org> Date: Mon, 05 Feb 2007 10:44:13 -0800 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 2.0b2 (X11/20070116) MIME-Version: 1.0 To: Florent Thoumie References: <20061029010934.5afef73e.nork@FreeBSD.org> <200610281610.k9SGAIVb051055@freefall.freebsd.org> <20070129000459.b2dba4e0.nork@FreeBSD.org> <45C757FA.2000209@FreeBSD.org> <20070205163646.GB48768@lor.one-eyed-alien.net> <45C75E1F.2070709@FreeBSD.org> In-Reply-To: <45C75E1F.2070709@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: FreeBSD-gnats-submit@freebsd.org, freebsd-bugs@freebsd.org, Brooks Davis , freebsd-rc@freebsd.org, Norikatsu Shigemura Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2007 19:10:59 -0000 Florent Thoumie wrote: > Brooks Davis wrote: >> On Mon, Feb 05, 2007 at 04:14:50PM +0000, Florent Thoumie wrote: >>> Norikatsu Shigemura wrote: >>>> On Sat, 28 Oct 2006 16:10:18 GMT >>>> FreeBSD-gnats-submit@FreeBSD.org wrote: >>>>> Thank you very much for your problem report. >>>>> It has the internal identification `conf/104884'. >>>>> The individual assigned to look at your >>>>> report is: freebsd-bugs. >>>>> You can access the state of your problem report at any time >>>>> via this link: >>>>> http://www.freebsd.org/cgi/query-pr.cgi?pr=104884 >>>>>> Category: conf >>>>>> Responsible: freebsd-bugs >>>>>> Synopsis: Add support EtherChannel configuration to rc.conf >>>>>> Arrival-Date: Sat Oct 28 16:10:18 GMT 2006 >>>> I chased HEAD. Please see following patch. >>>> Anyone, please handle this PR? >>>> And I'll make a patch for 6-stable. >>>> >>> I've made my comments on this. Maybe someone else should review it? >> It seems basicly fine and should be useful. (At least until someone >> finally shoots the netgraph part of ng_fec in the head.) I'd like to >> see "" be the offical way to not configure any fec interfaces. gif_up's >> use of NO is a mistake (IMO). It would be OK to allow "NO" as an >> undocumented synanim for "". > > Agreed, as said in my previous post. > > I think we could just set gif_interfaces and fec_interfaces to "" in > -CURRENT and add the "NO" compatibility in RELENG_6 when MFC time comes? > That would be a candidate for 7.0 RELNOTES. > > Does it make any sense to you? My instinct is to have it the other way around, with "NO" being the default, and "" being a synonym. We've trained people that "NO" is the way to turn things off with rc, and the one glaring exception to that rule (sendmail) has caused an enormous amount of confusion over the years. Other than that, I have no objections here. hth, Doug -- This .signature sanitized for your protection From owner-freebsd-rc@FreeBSD.ORG Mon Feb 5 19:23:54 2007 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 97E5E16A407; Mon, 5 Feb 2007 19:23:54 +0000 (UTC) (envelope-from flz@FreeBSD.org) Received: from smtp1-g19.free.fr (smtp1-g19.free.fr [212.27.42.27]) by mx1.freebsd.org (Postfix) with ESMTP id 2ACFF13C4B3; Mon, 5 Feb 2007 19:23:54 +0000 (UTC) (envelope-from flz@FreeBSD.org) Received: from smtp.xbsd.org (unknown [82.233.2.192]) by smtp1-g19.free.fr (Postfix) with ESMTP id 6EF289B848; Mon, 5 Feb 2007 20:23:53 +0100 (CET) Received: from localhost (localhost.xbsd.org [127.0.0.1]) by smtp.xbsd.org (Postfix) with ESMTP id 80C1D11AD2; Mon, 5 Feb 2007 20:23:52 +0100 (CET) X-Virus-Scanned: amavisd-new at xbsd.org Received: from smtp.xbsd.org ([127.0.0.1]) by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MK8M8BKRYhO5; Mon, 5 Feb 2007 20:23:44 +0100 (CET) Received: from [193.120.13.130] (cream.xbsd.org [193.120.13.130]) by smtp.xbsd.org (Postfix) with ESMTP id 09AFA1164F; Mon, 5 Feb 2007 20:23:42 +0100 (CET) Message-ID: <45C78362.4030003@FreeBSD.org> Date: Mon, 05 Feb 2007 19:20:02 +0000 From: Florent Thoumie User-Agent: Thunderbird 1.5.0.9 (X11/20070122) MIME-Version: 1.0 To: Norikatsu Shigemura References: <20061029010934.5afef73e.nork@FreeBSD.org> <200610281610.k9SGAIVb051055@freefall.freebsd.org> <20070129000459.b2dba4e0.nork@FreeBSD.org> In-Reply-To: <20070129000459.b2dba4e0.nork@FreeBSD.org> X-Enigmail-Version: 0.94.1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig10F7C438CF396E3BC8035EEA" Cc: freebsd-bugs@FreeBSD.org, FreeBSD-gnats-submit@FreeBSD.org, freebsd-rc@FreeBSD.org Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2007 19:23:54 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig10F7C438CF396E3BC8035EEA Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Norikatsu Shigemura wrote: > On Sat, 28 Oct 2006 16:10:18 GMT > FreeBSD-gnats-submit@FreeBSD.org wrote: >> Thank you very much for your problem report. >> It has the internal identification `conf/104884'. >> The individual assigned to look at your >> report is: freebsd-bugs.=20 >> You can access the state of your problem report at any time >> via this link: >> http://www.freebsd.org/cgi/query-pr.cgi?pr=3D104884 >>> Category: conf >>> Responsible: freebsd-bugs >>> Synopsis: Add support EtherChannel configuration to rc.conf >>> Arrival-Date: Sat Oct 28 16:10:18 GMT 2006 >=20 > I chased HEAD. Please see following patch. > Anyone, please handle this PR? > And I'll make a patch for 6-stable. I just noticed two other things. > +# fec_up ifn ^^^ fec_up uses fec_interfaces, not $1, so this is wrong. > +# Configure Fast EtherChannel for interface $ifn. Returns 0 if FEC > +# arguments were found and configured; returns 1 otherwise. fec_up is never called with an argument anyway at the moment. It wouldn't be hard to do: work on $1 or $fec_interfaces if $1 is empty. I guess we could use both 'fec_up $ifn' and 'gif_up $ifn' in rc.d/netif. The newly introduced variables also need to be documented in rc.conf.5. Could you please provide a patch for this? I also noticed we don't have gif_down (hence no fec_down). --=20 Florent Thoumie flz@FreeBSD.org FreeBSD Committer --------------enig10F7C438CF396E3BC8035EEA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFFx4NqMxEkbVFH3PQRCpa7AJ92OTvKEnTFuvgd8dxE9qMOeslJAgCfS8nk NzppeTdeSYYb8h+DjhsHluc= =GH+e -----END PGP SIGNATURE----- --------------enig10F7C438CF396E3BC8035EEA-- From owner-freebsd-rc@FreeBSD.ORG Mon Feb 5 19:30:29 2007 Return-Path: X-Original-To: freebsd-rc@hub.freebsd.org Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E9C6F16A408 for ; Mon, 5 Feb 2007 19:30:28 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id 78A1813C494 for ; Mon, 5 Feb 2007 19:30:28 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l15JUS9V064339 for ; Mon, 5 Feb 2007 19:30:28 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l15JUS8O064334; Mon, 5 Feb 2007 19:30:28 GMT (envelope-from gnats) Date: Mon, 5 Feb 2007 19:30:28 GMT Message-Id: <200702051930.l15JUS8O064334@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org From: Florent Thoumie Cc: Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Florent Thoumie List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2007 19:30:29 -0000 The following reply was made to PR conf/104884; it has been noted by GNATS. From: Florent Thoumie To: Norikatsu Shigemura Cc: freebsd-rc@FreeBSD.org, freebsd-bugs@FreeBSD.org, FreeBSD-gnats-submit@FreeBSD.org Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf Date: Mon, 05 Feb 2007 19:20:02 +0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig10F7C438CF396E3BC8035EEA Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Norikatsu Shigemura wrote: > On Sat, 28 Oct 2006 16:10:18 GMT > FreeBSD-gnats-submit@FreeBSD.org wrote: >> Thank you very much for your problem report. >> It has the internal identification `conf/104884'. >> The individual assigned to look at your >> report is: freebsd-bugs.=20 >> You can access the state of your problem report at any time >> via this link: >> http://www.freebsd.org/cgi/query-pr.cgi?pr=3D104884 >>> Category: conf >>> Responsible: freebsd-bugs >>> Synopsis: Add support EtherChannel configuration to rc.conf >>> Arrival-Date: Sat Oct 28 16:10:18 GMT 2006 >=20 > I chased HEAD. Please see following patch. > Anyone, please handle this PR? > And I'll make a patch for 6-stable. I just noticed two other things. > +# fec_up ifn ^^^ fec_up uses fec_interfaces, not $1, so this is wrong. > +# Configure Fast EtherChannel for interface $ifn. Returns 0 if FEC > +# arguments were found and configured; returns 1 otherwise. fec_up is never called with an argument anyway at the moment. It wouldn't be hard to do: work on $1 or $fec_interfaces if $1 is empty. I guess we could use both 'fec_up $ifn' and 'gif_up $ifn' in rc.d/netif. The newly introduced variables also need to be documented in rc.conf.5. Could you please provide a patch for this? I also noticed we don't have gif_down (hence no fec_down). --=20 Florent Thoumie flz@FreeBSD.org FreeBSD Committer --------------enig10F7C438CF396E3BC8035EEA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFFx4NqMxEkbVFH3PQRCpa7AJ92OTvKEnTFuvgd8dxE9qMOeslJAgCfS8nk NzppeTdeSYYb8h+DjhsHluc= =GH+e -----END PGP SIGNATURE----- --------------enig10F7C438CF396E3BC8035EEA-- From owner-freebsd-rc@FreeBSD.ORG Mon Feb 5 22:32:09 2007 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8640416A498 for ; Mon, 5 Feb 2007 22:32:07 +0000 (UTC) (envelope-from zcwalinski@metroland.com) Received: from server05.metroland.com (server05.metroland.com [192.206.149.20]) by mx1.freebsd.org (Postfix) with ESMTP id A935113C4C4 for ; Mon, 5 Feb 2007 22:31:55 +0000 (UTC) (envelope-from zcwalinski@metroland.com) Received: from server06.metroland.com (tem-xchange-srv.tem.metroland.com [66.207.103.173] (may be forged)) by server05.metroland.com (8.13.1/8.13.1) with ESMTP id l15M15n5011647 for ; Mon, 5 Feb 2007 17:01:05 -0500 (EST) (envelope-from zcwalinski@metroland.com) Received: from CSYS-EVS01.corp.metroland.com ([10.151.25.36]) by server06.metroland.com (8.11.3/8.11.1) with ESMTP id l15MDJh30901 for ; Mon, 5 Feb 2007 17:13:20 -0500 (EST) (envelope-from zcwalinski@metroland.com) X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Date: Mon, 5 Feb 2007 17:02:26 -0500 Message-ID: <5CD1A0226571E74A830A15192855981801964429@CSYS-EVS01.corp.metroland.com> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: I need help with Script running as a daemon !!! Thread-Index: AcdJcVIZPKrrWsuyTxCDrFojpcbj3g== X-Priority: 1 Priority: Urgent Importance: high From: "Cwalinski, Zygmunt" To: Subject: I need help with Script running as a daemon !!! X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2007 22:32:10 -0000 Hi, I am a new user to FreeBSD. All is new for me but I try to learn more and more everyday. I have to run a script as a daemon. Nice job for first time user :) Unfortunately I have to run more sophisticated daemon then this below but I can't even mange this simple daemon. Fortunately I have just found this mailing list and I hope I will get some help from you. I am trying to run the following script "runtest" as a daemon -------------------------------------------------------------- while true do sleep 1 done My daemon script: ----------------- #!/bin/sh . /etc/rc.subr # PROVIDE: Test # REQUIRE: DAEMON # BEFORE: LOGIN # KEYWORD: My test name=3D"runtest" pidfile=3D"/var/run/${name}.pid" rcvar=3D`set_rcvar` start_postcmd=3Druntest_poststart command=3D"sh /etc/runtest" command_args=3D"&" command_interpreter=3Dyes load_rc_config $name runtest_enable=3D${runtest_enable-:NO} runtest_poststart() { echo $! > ${pidfile} } run_rc_command "$1" When I start above daemon I get: ------------------------------------ test# sh /usr/local/etc/rc.d/runtestd start eval: cannot open sh: No such file or directory [: !=3D: argument expected [: sh: unexpected operator Starting runtest. and runtest script is running. Then I try to stop it and I get the following information: ---------------------------------------------------------- test# sh /usr/local/etc/rc.d/runtestd stop eval: cannot open sh: No such file or directory [: !=3D: argument expected runtest not running? (check /var/run/runtest.pid). runtest.pid does exists and there is correct process ID for my script What am I doing wrong? Please help me with it as I have spent few days already. Zyggi From owner-freebsd-rc@FreeBSD.ORG Mon Feb 5 22:54:50 2007 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9D5E316A401 for ; Mon, 5 Feb 2007 22:54:48 +0000 (UTC) (envelope-from wmoran@collaborativefusion.com) Received: from mx00.pub.collaborativefusion.com (mx00.pub.collaborativefusion.com [206.210.89.199]) by mx1.freebsd.org (Postfix) with ESMTP id 53B6F13C4A7 for ; Mon, 5 Feb 2007 22:54:48 +0000 (UTC) (envelope-from wmoran@collaborativefusion.com) Received: from vanquish.pgh.priv.collaborativefusion.com (vanquish.pgh.priv.collaborativefusion.com [192.168.2.61]) (SSL: TLSv1/SSLv3,256bits,AES256-SHA) by wingspan with esmtp; Mon, 05 Feb 2007 17:44:18 -0500 id 00056407.45C7B342.000169DC Date: Mon, 5 Feb 2007 17:44:17 -0500 From: Bill Moran To: "Cwalinski, Zygmunt" Message-Id: <20070205174417.159138c0.wmoran@collaborativefusion.com> In-Reply-To: <5CD1A0226571E74A830A15192855981801964429@CSYS-EVS01.corp.metroland.com> References: <5CD1A0226571E74A830A15192855981801964429@CSYS-EVS01.corp.metroland.com> Organization: Collaborative Fusion X-Mailer: Sylpheed 2.3.0 (GTK+ 2.10.7; i386-portbld-freebsd6.1) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: freebsd-rc@freebsd.org Subject: Re: I need help with Script running as a daemon !!! X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2007 22:54:50 -0000 In response to "Cwalinski, Zygmunt" : > Hi, > I am a new user to FreeBSD. All is new for me but I try to learn more > and more everyday. > I have to run a script as a daemon. Nice job for first time user :) > Unfortunately I have to run more sophisticated daemon then this below > but I can't even mange this simple daemon. > Fortunately I have just found this mailing list and I hope I will get > some help from you. > > I am trying to run the following script "runtest" as a daemon > -------------------------------------------------------------- > while true > do > sleep 1 > done > > My daemon script: > ----------------- > #!/bin/sh > . /etc/rc.subr > # PROVIDE: Test > # REQUIRE: DAEMON > # BEFORE: LOGIN > # KEYWORD: My test > name="runtest" > pidfile="/var/run/${name}.pid" > rcvar=`set_rcvar` > start_postcmd=runtest_poststart > command="sh /etc/runtest" > command_args="&" > command_interpreter=yes > load_rc_config $name > runtest_enable=${runtest_enable-:NO} > > runtest_poststart() { > echo $! > ${pidfile} > } > run_rc_command "$1" > > When I start above daemon I get: > ------------------------------------ > test# sh /usr/local/etc/rc.d/runtestd start > eval: cannot open sh: No such file or directory > [: !=: argument expected > [: sh: unexpected operator > Starting runtest. > > and runtest script is running. > > Then I try to stop it and I get the following information: > ---------------------------------------------------------- > test# sh /usr/local/etc/rc.d/runtestd stop > eval: cannot open sh: No such file or directory > [: !=: argument expected > runtest not running? (check /var/run/runtest.pid). > > runtest.pid does exists and there is correct process ID for my script > > What am I doing wrong? > Please help me with it as I have spent few days already. use the -x option to get helpful information from sh. i.e.: sh -x /usr/local/etc/rc.d/runtestd start -- Bill Moran Collaborative Fusion Inc. From owner-freebsd-rc@FreeBSD.ORG Mon Feb 5 22:56:03 2007 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 63D8D16A409 for ; Mon, 5 Feb 2007 22:56:00 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (grnl-static-02-0046.dsl.iowatelecom.net [69.66.56.110]) by mx1.freebsd.org (Postfix) with ESMTP id 050DF13C478 for ; Mon, 5 Feb 2007 22:55:57 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.13.8/8.13.8) with ESMTP id l15MtuXB053812; Mon, 5 Feb 2007 16:55:56 -0600 (CST) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.13.8/8.13.8/Submit) id l15MtuCk053811; Mon, 5 Feb 2007 16:55:56 -0600 (CST) (envelope-from brooks) Date: Mon, 5 Feb 2007 16:55:56 -0600 From: Brooks Davis To: "Cwalinski, Zygmunt" Message-ID: <20070205225556.GB53516@lor.one-eyed-alien.net> References: <5CD1A0226571E74A830A15192855981801964429@CSYS-EVS01.corp.metroland.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="JP+T4n/bALQSJXh8" Content-Disposition: inline In-Reply-To: <5CD1A0226571E74A830A15192855981801964429@CSYS-EVS01.corp.metroland.com> User-Agent: Mutt/1.5.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (lor.one-eyed-alien.net [127.0.0.1]); Mon, 05 Feb 2007 16:55:57 -0600 (CST) Cc: freebsd-rc@freebsd.org Subject: Re: I need help with Script running as a daemon !!! X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2007 22:56:03 -0000 --JP+T4n/bALQSJXh8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 05, 2007 at 05:02:26PM -0500, Cwalinski, Zygmunt wrote: > Hi, > I am a new user to FreeBSD. All is new for me but I try to learn more > and more everyday. > I have to run a script as a daemon. Nice job for first time user :) > Unfortunately I have to run more sophisticated daemon then this below > but I can't even mange this simple daemon. > Fortunately I have just found this mailing list and I hope I will get > some help from you. >=20 > I am trying to run the following script "runtest" as a daemon > -------------------------------------------------------------- > while true > do > sleep 1 > done >=20 > My daemon script: > ----------------- > #!/bin/sh > . /etc/rc.subr > # PROVIDE: Test > # REQUIRE: DAEMON > # BEFORE: LOGIN > # KEYWORD: My test > name=3D"runtest" > pidfile=3D"/var/run/${name}.pid" > rcvar=3D`set_rcvar` > start_postcmd=3Druntest_poststart > command=3D"sh /etc/runtest" > command_args=3D"&" > command_interpreter=3Dyes > load_rc_config $name > runtest_enable=3D${runtest_enable-:NO} >=20 > runtest_poststart() { > echo $! > ${pidfile} > } > run_rc_command "$1" >=20 > When I start above daemon I get: > ------------------------------------ > test# sh /usr/local/etc/rc.d/runtestd start > eval: cannot open sh: No such file or directory > [: !=3D: argument expected > [: sh: unexpected operator > Starting runtest. >=20 > and runtest script is running. >=20 > Then I try to stop it and I get the following information: > ---------------------------------------------------------- > test# sh /usr/local/etc/rc.d/runtestd stop > eval: cannot open sh: No such file or directory > [: !=3D: argument expected > runtest not running? (check /var/run/runtest.pid). >=20 > runtest.pid does exists and there is correct process ID for my script >=20 > What am I doing wrong? > Please help me with it as I have spent few days already. You need to write a runtest_start() that runs the command and immediatly create the PID file. Note that for ${command} to work at all it must be an absolute path to something with the execute bit set. -- Brooks --JP+T4n/bALQSJXh8 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFFx7X8XY6L6fI4GtQRAvZ5AJ4jpzIoihtHENg8r09D8xOq8lAvjwCgtHL8 XMIXPNRHaCCyqcEHizWCY14= =uj/A -----END PGP SIGNATURE----- --JP+T4n/bALQSJXh8-- From owner-freebsd-rc@FreeBSD.ORG Tue Feb 6 00:20:13 2007 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A41D316A40E for ; Tue, 6 Feb 2007 00:20:13 +0000 (UTC) (envelope-from zcwalinski@metroland.com) Received: from server05.metroland.com (server05.metroland.com [192.206.149.20]) by mx1.freebsd.org (Postfix) with ESMTP id 43C0713C461 for ; Tue, 6 Feb 2007 00:20:13 +0000 (UTC) (envelope-from zcwalinski@metroland.com) Received: from server06.metroland.com (tem-xchange-srv.tem.metroland.com [66.207.103.173] (may be forged)) by server05.metroland.com (8.13.1/8.13.1) with ESMTP id l160KCPs026937; Mon, 5 Feb 2007 19:20:12 -0500 (EST) (envelope-from zcwalinski@metroland.com) Received: from CSYS-EVS01.corp.metroland.com ([10.151.25.36]) by server06.metroland.com (8.11.3/8.11.1) with ESMTP id l160WRh35202; Mon, 5 Feb 2007 19:32:28 -0500 (EST) (envelope-from zcwalinski@metroland.com) X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Date: Mon, 5 Feb 2007 19:10:28 -0500 Message-ID: <5CD1A0226571E74A830A15192855981801964460@CSYS-EVS01.corp.metroland.com> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: I need help with Script running as a daemon !!! Thread-Index: AcdJeUJ97dxf47wSS8agdVOETThiTgACKMEg From: "Cwalinski, Zygmunt" To: "Brooks Davis" Cc: freebsd-rc@freebsd.org Subject: RE: I need help with Script running as a daemon !!! X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Feb 2007 00:20:13 -0000 Dave,=20 Thanks for your email. I have set execute bit and change the script to: name=3D"runtest" pidfile=3D"/var/run/${name}.pid" rcvar=3D`set_rcvar` start_cmd=3Druntest_start command=3D"/etc/runtest" command_interpreter=3Dwhile load_rc_config $name runtest_enable=3D${runtest_enable-:NO} runtest_start() { $command & echo $! > ${pidfile} } I get no error when I start this script but still when I am trying to stop the daemon I am getting the following error: runtest not running? (check /var/run/runtest.pid). (pidfile contains a correct process ID) Zyggi -----Original Message----- From: Brooks Davis [mailto:brooks@freebsd.org]=20 Sent: 05-02-2007 5:56 PM To: Cwalinski, Zygmunt Cc: freebsd-rc@freebsd.org Subject: Re: I need help with Script running as a daemon !!! On Mon, Feb 05, 2007 at 05:02:26PM -0500, Cwalinski, Zygmunt wrote: > Hi, > I am a new user to FreeBSD. All is new for me but I try to learn more > and more everyday. > I have to run a script as a daemon. Nice job for first time user :) > Unfortunately I have to run more sophisticated daemon then this below > but I can't even mange this simple daemon. > Fortunately I have just found this mailing list and I hope I will get > some help from you. >=20 > I am trying to run the following script "runtest" as a daemon > -------------------------------------------------------------- > while true > do > sleep 1 > done >=20 > My daemon script: > ----------------- > #!/bin/sh > . /etc/rc.subr > # PROVIDE: Test > # REQUIRE: DAEMON > # BEFORE: LOGIN > # KEYWORD: My test > name=3D"runtest" > pidfile=3D"/var/run/${name}.pid" > rcvar=3D`set_rcvar` > start_postcmd=3Druntest_poststart > command=3D"sh /etc/runtest" > command_args=3D"&" > command_interpreter=3Dyes > load_rc_config $name > runtest_enable=3D${runtest_enable-:NO} >=20 > runtest_poststart() { > echo $! > ${pidfile} > } > run_rc_command "$1" >=20 > When I start above daemon I get: > ------------------------------------ > test# sh /usr/local/etc/rc.d/runtestd start > eval: cannot open sh: No such file or directory > [: !=3D: argument expected > [: sh: unexpected operator > Starting runtest. >=20 > and runtest script is running. >=20 > Then I try to stop it and I get the following information: > ---------------------------------------------------------- > test# sh /usr/local/etc/rc.d/runtestd stop > eval: cannot open sh: No such file or directory > [: !=3D: argument expected > runtest not running? (check /var/run/runtest.pid). >=20 > runtest.pid does exists and there is correct process ID for my script >=20 > What am I doing wrong? > Please help me with it as I have spent few days already. You need to write a runtest_start() that runs the command and immediatly create the PID file. Note that for ${command} to work at all it must be an absolute path to something with the execute bit set. -- Brooks From owner-freebsd-rc@FreeBSD.ORG Tue Feb 6 02:30:48 2007 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id CE88C16A408; Tue, 6 Feb 2007 02:30:45 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (grnl-static-02-0046.dsl.iowatelecom.net [69.66.56.110]) by mx1.freebsd.org (Postfix) with ESMTP id 77D4013C467; Tue, 6 Feb 2007 02:30:43 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.13.8/8.13.8) with ESMTP id l162Ug62055271; Mon, 5 Feb 2007 20:30:42 -0600 (CST) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.13.8/8.13.8/Submit) id l162UfF5055270; Mon, 5 Feb 2007 20:30:41 -0600 (CST) (envelope-from brooks) Date: Mon, 5 Feb 2007 20:30:41 -0600 From: Brooks Davis To: "Cwalinski, Zygmunt" Message-ID: <20070206023041.GA55215@lor.one-eyed-alien.net> References: <5CD1A0226571E74A830A15192855981801964460@CSYS-EVS01.corp.metroland.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="liOOAslEiF7prFVr" Content-Disposition: inline In-Reply-To: <5CD1A0226571E74A830A15192855981801964460@CSYS-EVS01.corp.metroland.com> User-Agent: Mutt/1.5.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (lor.one-eyed-alien.net [127.0.0.1]); Mon, 05 Feb 2007 20:30:42 -0600 (CST) Cc: Brooks Davis , freebsd-rc@freebsd.org Subject: Re: I need help with Script running as a daemon !!! X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Feb 2007 02:30:48 -0000 --liOOAslEiF7prFVr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable [Please don't top-post. It's considered rude on FreeBSD mailing lists.] On Mon, Feb 05, 2007 at 07:10:28PM -0500, Cwalinski, Zygmunt wrote: > Dave,=20 > Thanks for your email. I have set execute bit and change the script to: >=20 > name=3D"runtest" > pidfile=3D"/var/run/${name}.pid" > rcvar=3D`set_rcvar` > start_cmd=3Druntest_start > command=3D"/etc/runtest" > command_interpreter=3Dwhile > load_rc_config $name > runtest_enable=3D${runtest_enable-:NO} >=20 > runtest_start() { > $command & > echo $! > ${pidfile} > } >=20 > I get no error when I start this script but still when I am trying to > stop the daemon I am getting the following error: > runtest not running? (check /var/run/runtest.pid). >=20 > (pidfile contains a correct process ID) The value of command_interpreter is bogus. From your previous post, it should probably be /bin/sh. That shouldn't be fatal in an of it self though. What does "ps auxww | grep `cat /var/run/runtest.pid`" say? Also, what version of FreeBSD are you running? -- Brooks --liOOAslEiF7prFVr Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFFx+hRXY6L6fI4GtQRApnUAJ9Dek3PcIyJHdZNfOsU5tAhjK+Z1gCcDvTW enPazcuyPRqE83z6tDH79Dc= =Vd57 -----END PGP SIGNATURE----- --liOOAslEiF7prFVr-- From owner-freebsd-rc@FreeBSD.ORG Tue Feb 6 02:50:16 2007 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3C42C16A400; Tue, 6 Feb 2007 02:50:16 +0000 (UTC) (envelope-from zcwalinski@metroland.com) Received: from server05.metroland.com (server05.metroland.com [192.206.149.20]) by mx1.freebsd.org (Postfix) with ESMTP id E3A7513C428; Tue, 6 Feb 2007 02:50:07 +0000 (UTC) (envelope-from zcwalinski@metroland.com) Received: from server06.metroland.com (tem-xchange-srv.tem.metroland.com [66.207.103.173] (may be forged)) by server05.metroland.com (8.13.1/8.13.1) with ESMTP id l162o74B036675; Mon, 5 Feb 2007 21:50:07 -0500 (EST) (envelope-from zcwalinski@metroland.com) Received: from CSYS-EVS01.corp.metroland.com ([10.151.25.36]) by server06.metroland.com (8.11.3/8.11.1) with ESMTP id l1632Mh38453; Mon, 5 Feb 2007 22:02:23 -0500 (EST) (envelope-from zcwalinski@metroland.com) X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Date: Mon, 5 Feb 2007 21:50:08 -0500 Message-ID: <5CD1A0226571E74A830A15192855981801964470@CSYS-EVS01.corp.metroland.com> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: I need help with Script running as a daemon !!! Thread-Index: AcdJlx7eNlGLj2WIT+6Ggbj18t3skQAAPzEg From: "Cwalinski, Zygmunt" To: "Brooks Davis" Cc: freebsd-rc@freebsd.org Subject: RE: I need help with Script running as a daemon !!! X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Feb 2007 02:50:16 -0000 -----Original Message----- From: Brooks Davis [mailto:brooks@freebsd.org]=20 Sent: 05-02-2007 9:31 PM To: Cwalinski, Zygmunt Cc: Brooks Davis; freebsd-rc@freebsd.org Subject: Re: I need help with Script running as a daemon !!! [Please don't top-post. It's considered rude on FreeBSD mailing lists.] On Mon, Feb 05, 2007 at 07:10:28PM -0500, Cwalinski, Zygmunt wrote: > Dave,=20 > Thanks for your email. I have set execute bit and change the script to: >=20 > name=3D"runtest" > pidfile=3D"/var/run/${name}.pid" > rcvar=3D`set_rcvar` > start_cmd=3Druntest_start > command=3D"/etc/runtest" > command_interpreter=3Dwhile > load_rc_config $name > runtest_enable=3D${runtest_enable-:NO} >=20 > runtest_start() { > $command & > echo $! > ${pidfile} > } >=20 > I get no error when I start this script but still when I am trying to > stop the daemon I am getting the following error: > runtest not running? (check /var/run/runtest.pid). >=20 > (pidfile contains a correct process ID) The value of command_interpreter is bogus. From your previous post, it should probably be /bin/sh. That shouldn't be fatal in an of it self though. What does "ps auxww | grep `cat /var/run/runtest.pid`" say? Also, what version of FreeBSD are you running? -- Brooks [Thanks for your top-post remark] I am running FreeBSD 6.2 When I set "command_interpreter=3D/bin/sh" I get the following error during startup: /usr/local/etc/rc.d/runtestd: WARNING: $command_interpreter /bin/sh !=3D while (although script is running) "ps auxww | grep `cat /var/run/runtest.pid`" says: root 1314 0.0 1.1 1836 1396 p1 S 9:38PM 0:00.03 /bin/sh /usr/local/etc/rc.d/runtestd start Here is my current script: #!/bin/sh . /etc/rc.subr # PROVIDE: Test # REQUIRE: DAEMON # BEFORE: LOGIN # KEYWORD: My test name=3D"runtest" pidfile=3D"/var/run/${name}.pid" rcvar=3D`set_rcvar` start_cmd=3Druntest_start command=3D"/etc/runtest" command_interpreter=3D/bin/sh load_rc_config $name runtest_enable=3D${runtest_enable-:NO} runtest_start() { $command & echo $! > ${pidfile} } run_rc_command "$1" Zyggi From owner-freebsd-rc@FreeBSD.ORG Tue Feb 6 03:33:47 2007 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9D1C816A405 for ; Tue, 6 Feb 2007 03:33:47 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (grnl-static-02-0046.dsl.iowatelecom.net [69.66.56.110]) by mx1.freebsd.org (Postfix) with ESMTP id 567E413C48D for ; Tue, 6 Feb 2007 03:33:47 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.13.8/8.13.8) with ESMTP id l163XkJX055791; Mon, 5 Feb 2007 21:33:46 -0600 (CST) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.13.8/8.13.8/Submit) id l163XkSO055790; Mon, 5 Feb 2007 21:33:46 -0600 (CST) (envelope-from brooks) Date: Mon, 5 Feb 2007 21:33:46 -0600 From: Brooks Davis To: "Cwalinski, Zygmunt" Message-ID: <20070206033346.GC55215@lor.one-eyed-alien.net> References: <5CD1A0226571E74A830A15192855981801964470@CSYS-EVS01.corp.metroland.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="zCKi3GIZzVBPywwA" Content-Disposition: inline In-Reply-To: <5CD1A0226571E74A830A15192855981801964470@CSYS-EVS01.corp.metroland.com> User-Agent: Mutt/1.5.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (lor.one-eyed-alien.net [127.0.0.1]); Mon, 05 Feb 2007 21:33:46 -0600 (CST) Cc: freebsd-rc@freebsd.org Subject: Re: I need help with Script running as a daemon !!! X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Feb 2007 03:33:47 -0000 --zCKi3GIZzVBPywwA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 05, 2007 at 09:50:08PM -0500, Cwalinski, Zygmunt wrote: > -----Original Message----- > From: Brooks Davis [mailto:brooks@freebsd.org]=20 > Sent: 05-02-2007 9:31 PM > To: Cwalinski, Zygmunt > Cc: Brooks Davis; freebsd-rc@freebsd.org > Subject: Re: I need help with Script running as a daemon !!! >=20 > [Please don't top-post. It's considered rude on FreeBSD mailing lists.] >=20 > On Mon, Feb 05, 2007 at 07:10:28PM -0500, Cwalinski, Zygmunt wrote: > > Dave,=20 > > Thanks for your email. I have set execute bit and change the script > to: > >=20 > > name=3D"runtest" > > pidfile=3D"/var/run/${name}.pid" > > rcvar=3D`set_rcvar` > > start_cmd=3Druntest_start > > command=3D"/etc/runtest" > > command_interpreter=3Dwhile > > load_rc_config $name > > runtest_enable=3D${runtest_enable-:NO} > >=20 > > runtest_start() { > > $command & > > echo $! > ${pidfile} > > } > >=20 > > I get no error when I start this script but still when I am trying to > > stop the daemon I am getting the following error: > > runtest not running? (check /var/run/runtest.pid). > >=20 > > (pidfile contains a correct process ID) >=20 > The value of command_interpreter is bogus. From your previous > post, it should probably be /bin/sh. That shouldn't be fatal in an of > it self though. What does "ps auxww | grep `cat /var/run/runtest.pid`" > say? >=20 > Also, what version of FreeBSD are you running? >=20 > -- Brooks >=20 > [Thanks for your top-post remark] > I am running FreeBSD 6.2 >=20 > When I set "command_interpreter=3D/bin/sh" I get the following error > during startup: > /usr/local/etc/rc.d/runtestd: WARNING: $command_interpreter /bin/sh !=3D > while > (although script is running) >=20 > "ps auxww | grep `cat /var/run/runtest.pid`" says: > root 1314 0.0 1.1 1836 1396 p1 S 9:38PM 0:00.03 > /bin/sh /usr/local/etc/rc.d/runtestd start >=20 > Here is my current script: > #!/bin/sh > . /etc/rc.subr > # PROVIDE: Test > # REQUIRE: DAEMON > # BEFORE: LOGIN > # KEYWORD: My test > name=3D"runtest" > pidfile=3D"/var/run/${name}.pid" > rcvar=3D`set_rcvar` > start_cmd=3Druntest_start > command=3D"/etc/runtest" > command_interpreter=3D/bin/sh >=20 > load_rc_config $name > runtest_enable=3D${runtest_enable-:NO} >=20 > runtest_start() { > $command & > echo $! > ${pidfile} > } > run_rc_command "$1" If this is the output then /usr/local/etc/rc.d/runtestd should be command since that's what is actually being run. What is /etc/runtest? A symlink? -- Brooks --zCKi3GIZzVBPywwA Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFFx/cZXY6L6fI4GtQRAvu9AKDJp5WdBW9lDn5hshJ3RRVQPPcQcwCfSB+H j0HGw1vSRjAvHIDknOhGRWY= =Yl7X -----END PGP SIGNATURE----- --zCKi3GIZzVBPywwA-- From owner-freebsd-rc@FreeBSD.ORG Tue Feb 6 04:03:54 2007 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8DC2A16A403; Tue, 6 Feb 2007 04:03:54 +0000 (UTC) (envelope-from zcwalinski@metroland.com) Received: from server05.metroland.com (server05.metroland.com [192.206.149.20]) by mx1.freebsd.org (Postfix) with ESMTP id 4B87213C442; Tue, 6 Feb 2007 04:03:54 +0000 (UTC) (envelope-from zcwalinski@metroland.com) Received: from server06.metroland.com (tem-xchange-srv.tem.metroland.com [66.207.103.173] (may be forged)) by server05.metroland.com (8.13.1/8.13.1) with ESMTP id l1643ri4041097; Mon, 5 Feb 2007 23:03:53 -0500 (EST) (envelope-from zcwalinski@metroland.com) Received: from CSYS-EVS01.corp.metroland.com ([10.151.25.36]) by server06.metroland.com (8.11.3/8.11.1) with ESMTP id l164G9h40292; Mon, 5 Feb 2007 23:16:09 -0500 (EST) (envelope-from zcwalinski@metroland.com) X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Date: Mon, 5 Feb 2007 23:04:35 -0500 Message-ID: <5CD1A0226571E74A830A15192855981801964476@CSYS-EVS01.corp.metroland.com> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: I need help with Script running as a daemon !!! Thread-Index: AcdJn+ym2rY27hcRRkG2NmAubiR51gAAEvcg From: "Cwalinski, Zygmunt" To: "Brooks Davis" Cc: freebsd-rc@freebsd.org Subject: RE: I need help with Script running as a daemon !!! X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Feb 2007 04:03:54 -0000 -----Original Message----- From: Brooks Davis [mailto:brooks@freebsd.org]=20 Sent: 05-02-2007 10:34 PM To: Cwalinski, Zygmunt Cc: freebsd-rc@freebsd.org Subject: Re: I need help with Script running as a daemon !!! On Mon, Feb 05, 2007 at 09:50:08PM -0500, Cwalinski, Zygmunt wrote: > -----Original Message----- > From: Brooks Davis [mailto:brooks@freebsd.org]=20 > Sent: 05-02-2007 9:31 PM > To: Cwalinski, Zygmunt > Cc: Brooks Davis; freebsd-rc@freebsd.org > Subject: Re: I need help with Script running as a daemon !!! >=20 > [Please don't top-post. It's considered rude on FreeBSD mailing lists.] >=20 > On Mon, Feb 05, 2007 at 07:10:28PM -0500, Cwalinski, Zygmunt wrote: > > Dave,=20 > > Thanks for your email. I have set execute bit and change the script > to: > >=20 > > name=3D"runtest" > > pidfile=3D"/var/run/${name}.pid" > > rcvar=3D`set_rcvar` > > start_cmd=3Druntest_start > > command=3D"/etc/runtest" > > command_interpreter=3Dwhile > > load_rc_config $name > > runtest_enable=3D${runtest_enable-:NO} > >=20 > > runtest_start() { > > $command & > > echo $! > ${pidfile} > > } > >=20 > > I get no error when I start this script but still when I am trying to > > stop the daemon I am getting the following error: > > runtest not running? (check /var/run/runtest.pid). > >=20 > > (pidfile contains a correct process ID) >=20 > The value of command_interpreter is bogus. From your previous > post, it should probably be /bin/sh. That shouldn't be fatal in an of > it self though. What does "ps auxww | grep `cat /var/run/runtest.pid`" > say? >=20 > Also, what version of FreeBSD are you running? >=20 > -- Brooks >=20 > [Thanks for your top-post remark] > I am running FreeBSD 6.2 >=20 > When I set "command_interpreter=3D/bin/sh" I get the following error > during startup: > /usr/local/etc/rc.d/runtestd: WARNING: $command_interpreter /bin/sh = !=3D > while > (although script is running) >=20 > "ps auxww | grep `cat /var/run/runtest.pid`" says: > root 1314 0.0 1.1 1836 1396 p1 S 9:38PM 0:00.03 > /bin/sh /usr/local/etc/rc.d/runtestd start >=20 > Here is my current script: > #!/bin/sh > . /etc/rc.subr > # PROVIDE: Test > # REQUIRE: DAEMON > # BEFORE: LOGIN > # KEYWORD: My test > name=3D"runtest" > pidfile=3D"/var/run/${name}.pid" > rcvar=3D`set_rcvar` > start_cmd=3Druntest_start > command=3D"/etc/runtest" > command_interpreter=3D/bin/sh >=20 > load_rc_config $name > runtest_enable=3D${runtest_enable-:NO} >=20 > runtest_start() { > $command & > echo $! > ${pidfile} > } > run_rc_command "$1" If this is the output then /usr/local/etc/rc.d/runtestd should be command since that's what is actually being run. What is /etc/runtest? A symlink? -- Brooks Here is "runtest" script: while true do sleep 1 done I can't see runtest when I check "ps" but I can see runtestd. ??? Zyggi From owner-freebsd-rc@FreeBSD.ORG Tue Feb 6 22:08:16 2007 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9E0E816A402 for ; Tue, 6 Feb 2007 22:08:16 +0000 (UTC) (envelope-from gurdiga@gmail.com) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.175]) by mx1.freebsd.org (Postfix) with ESMTP id 3F28C13C478 for ; Tue, 6 Feb 2007 22:08:16 +0000 (UTC) (envelope-from gurdiga@gmail.com) Received: by ug-out-1314.google.com with SMTP id o2so16529uge for ; Tue, 06 Feb 2007 14:08:15 -0800 (PST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition; b=Kda33SBv2sFxh5GtT5PrOW23VWqT/Lbkcj0bHZv/CocC0cd4hPoJV8Nz99L7mga1EZRm53OPsEgE6JIQ3iTZug5xDbAlfatgnAyyECEZhWFk8pSomU1dknp7Fe+l859PvIHDJxIpJ+4t3ucy4NGbNoaYYPgT2XEflo7N9LJB+Ds= Received: by 10.78.18.3 with SMTP id 3mr1955478hur.1170798085068; Tue, 06 Feb 2007 13:41:25 -0800 (PST) Received: by 10.78.32.19 with HTTP; Tue, 6 Feb 2007 13:41:25 -0800 (PST) Message-ID: Date: Tue, 6 Feb 2007 23:41:25 +0200 From: "Vlad GURDIGA" To: freebsd-rc@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline Subject: local rc.d X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Feb 2007 22:08:16 -0000 Hello, Is it OK that scripts in /usr/local/etc/rc.d/ are not run (even if the "some_daemon"_enable is set to "YES" in rc.conf) if they do not have ".sh" suffix? After installation of various daemons (in my case apache22, dbus, gdm, hald, mysql-server, squid, avahi-daemo and avahi-dnsconfig) they do no start on boot until they get ".sh" suffix. #uname -a FreeBSD uxterm 6.2-STABLE FreeBSD 6.2-STABLE #3: Fri Feb 2 20:51:46 EET 2007 vladd@uxterm:/usr/src/sys/i386/compile/uxterm i386 From owner-freebsd-rc@FreeBSD.ORG Wed Feb 7 00:13:34 2007 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0CB2D16A400 for ; Wed, 7 Feb 2007 00:13:34 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx22.fluidhosting.com [204.14.89.5]) by mx1.freebsd.org (Postfix) with SMTP id 9D84913C478 for ; Wed, 7 Feb 2007 00:13:33 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: (qmail 24960 invoked by uid 399); 7 Feb 2007 00:13:30 -0000 Received: from localhost (HELO ?192.168.0.4?) (dougb@dougbarton.us@127.0.0.1) by localhost with SMTP; 7 Feb 2007 00:13:30 -0000 X-Originating-IP: 127.0.0.1 Message-ID: <45C919A2.6040006@FreeBSD.org> Date: Tue, 06 Feb 2007 16:13:22 -0800 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 2.0b2 (Windows/20070116) MIME-Version: 1.0 To: Vlad GURDIGA References: In-Reply-To: X-Enigmail-Version: 0.94.2.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-rc@freebsd.org Subject: Re: local rc.d X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Feb 2007 00:13:34 -0000 Vlad GURDIGA wrote: > Hello, > > Is it OK that scripts in /usr/local/etc/rc.d/ are not run (even if the > "some_daemon"_enable is set to "YES" in rc.conf) if they do not have > ".sh" suffix? After installation of various daemons (in my case > apache22, dbus, gdm, hald, mysql-server, squid, avahi-daemo and > avahi-dnsconfig) they do no start on boot until they get ".sh" suffix. You probably need to run mergemaster, or otherwise upgrade your /etc, specifically the bits related to rc. hth, Doug -- This .signature sanitized for your protection From owner-freebsd-rc@FreeBSD.ORG Wed Feb 7 17:18:13 2007 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7B64C16A405; Wed, 7 Feb 2007 17:18:12 +0000 (UTC) (envelope-from nork@FreeBSD.org) Received: from sakura.ninth-nine.com (sakura.ninth-nine.com [219.127.74.120]) by mx1.freebsd.org (Postfix) with ESMTP id 0283B13C471; Wed, 7 Feb 2007 17:18:11 +0000 (UTC) (envelope-from nork@FreeBSD.org) Received: from nadesico.ninth-nine.com (nadesico.ninth-nine.com [219.127.74.122]) by sakura.ninth-nine.com (8.13.8/8.13.8/NinthNine) with SMTP id l17HIAOK026543; Thu, 8 Feb 2007 02:18:10 +0900 (JST) (envelope-from nork@FreeBSD.org) Date: Thu, 8 Feb 2007 02:18:10 +0900 From: Norikatsu Shigemura To: Florent Thoumie Message-Id: <20070208021810.6bc5ccb1.nork@FreeBSD.org> In-Reply-To: <200702051930.l15JUS8O064334@freefall.freebsd.org> References: <200702051930.l15JUS8O064334@freefall.freebsd.org> X-Mailer: Sylpheed 2.4.0beta2 (GTK+ 2.10.9; i386-portbld-freebsd6.2) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0.2 (sakura.ninth-nine.com [219.127.74.121]); Thu, 08 Feb 2007 02:18:10 +0900 (JST) Cc: freebsd-rc@FreeBSD.org, Norikatsu Shigemura Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Feb 2007 17:18:13 -0000 On Mon, 5 Feb 2007 19:30:28 GMT Florent Thoumie wrote: > I just noticed two other things. > > +# fec_up ifn > ^^^ > fec_up uses fec_interfaces, not $1, so this is wrong. > > +# Configure Fast EtherChannel for interface $ifn. Returns 0 if FEC > > +# arguments were found and configured; returns 1 otherwise. > fec_up is never called with an argument anyway at the moment. It > wouldn't be hard to do: work on $1 or $fec_interfaces if $1 is empty. I > guess we could use both 'fec_up $ifn' and 'gif_up $ifn' in rc.d/netif. Yes. This is ng_fec_create's comment. I rewrote my patch. Please check following patch. > The newly introduced variables also need to be documented in rc.conf.5. > Could you please provide a patch for this? I made it, but please fix my broken English:-). > I also noticed we don't have gif_down (hence no fec_down). I noticed. But it's too hard how should we do. Index: src/etc/network.subr =================================================================== RCS file: /home/ncvs/src/etc/network.subr,v retrieving revision 1.176 diff -u -r1.176 network.subr --- src/etc/network.subr 29 Oct 2006 13:29:49 -0000 1.176 +++ src/etc/network.subr 7 Feb 2007 17:16:21 -0000 @@ -455,6 +455,25 @@ debug "Destroyed clones: ${_list}" } +# Create netgraph nodes. +# +ng_mkpeer() { + ngctl -f - 2> /dev/null < /dev/null 2>&1 + + bogus="" + while true; do + iface=`ng_create_one fec dummy fec` + if [ -z "${iface}" ]; then + exit 2 + fi + if [ "${iface}" = "${req_iface}" ]; then + echo ${iface} + break + fi + bogus="${bogus} ${iface}" + done + + for iface in ${bogus}; do + ngctl shutdown ${iface}: + done +} + +fec_up() { + case ${fec_interfaces} in + [Nn][Oo] | '') + ;; + *) + for i in ${fec_interfaces}; do + ng_fec_create $i + for j in `get_if_var $i fecconfig_IF`; do + case ${j} in + '') + continue + ;; + *) + ngctl msg ${i}: add_iface "\"${j}\"" + ;; + esac + done + done + ;; + esac +} + # # ipx_up ifn # Configure any IPX addresses for interface $ifn. Returns 0 if IPX Index: src/etc/defaults/rc.conf =================================================================== RCS file: /home/ncvs/src/etc/defaults/rc.conf,v retrieving revision 1.303 diff -u -r1.303 rc.conf --- src/etc/defaults/rc.conf 20 Jan 2007 04:24:19 -0000 1.303 +++ src/etc/defaults/rc.conf 7 Feb 2007 17:16:22 -0000 @@ -183,6 +183,10 @@ # Choose correct tunnel addrs. #gifconfig_gif0="10.1.1.1 10.1.2.1" # Examples typically for a router. #gifconfig_gif1="10.1.1.2 10.1.2.2" # Examples typically for a router. +fec_interfaces="NO" # List of Fast EtherChannels (or "NO") +#fec_interfaces="fec0 fec1" +#fecconfig_fec0="fxp0 dc0" # Examples typically for two NICs +#fecconfig_fec1="em0 em1 bge0 bge1" # Examples typically for four NICs # User ppp configuration. ppp_enable="NO" # Start user-ppp (or NO). Index: src/etc/rc.d/netif =================================================================== RCS file: /home/ncvs/src/etc/rc.d/netif,v retrieving revision 1.21 diff -u -r1.21 netif --- src/etc/rc.d/netif 30 Dec 2006 22:53:20 -0000 1.21 +++ src/etc/rc.d/netif 7 Feb 2007 17:16:22 -0000 @@ -57,6 +57,9 @@ # Create cloned interfaces clone_up + # Create Fast EtherChannel interfaces + fec_up + # Create IPv6<-->IPv4 tunnels gif_up Index: src/share/man/man5/rc.conf.5 =================================================================== RCS file: /home/ncvs/src/share/man/man5/rc.conf.5,v retrieving revision 1.314 diff -u -r1.314 rc.conf.5 --- src/share/man/man5/rc.conf.5 24 Jan 2007 09:22:56 -0000 1.314 +++ src/share/man/man5/rc.conf.5 7 Feb 2007 17:16:22 -0000 @@ -1163,6 +1163,33 @@ are automatically appended to .Va network_interfaces for configuration. +.It Va fec_interfaces +.Pq Vt str +Set to the list of +.Xr ng_fec 4 +Fast EtherChannel interfaces to configure on this host. +A +.Va fecconfig_ Ns Aq Ar interface +variable is assumed to exist for each value of +.Ar interface . +The value of this variable is used to configure link aggregated interfaces +according to the syntax of the +.Cm NGM_FEC_ADD_IFACE +to +.Xr ngctl 8 +msg. +Additionally, this option ensures that each listed interface is created +via the +.Cm mkpeer +command to +.Xr ngctl 8 +before attempting to configure it. +For example: +.Bd -literal +fec_interfaces="fec0" +fecconfig_fec0="em0 em1" +ifconfig_fec0="DHCP" +.Ed .It Va gif_interfaces .Pq Vt str Set to the list of From owner-freebsd-rc@FreeBSD.ORG Thu Feb 8 18:01:44 2007 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8C88516A40B; Thu, 8 Feb 2007 18:01:44 +0000 (UTC) (envelope-from flz@FreeBSD.org) Received: from smtp3-g19.free.fr (smtp3-g19.free.fr [212.27.42.29]) by mx1.freebsd.org (Postfix) with ESMTP id 1128313C48E; Thu, 8 Feb 2007 18:01:43 +0000 (UTC) (envelope-from flz@FreeBSD.org) Received: from smtp.xbsd.org (unknown [82.233.2.192]) by smtp3-g19.free.fr (Postfix) with ESMTP id 06E0E4A5B7; Thu, 8 Feb 2007 19:01:43 +0100 (CET) Received: from localhost (localhost.xbsd.org [127.0.0.1]) by smtp.xbsd.org (Postfix) with ESMTP id 82B5011B5D; Thu, 8 Feb 2007 19:01:42 +0100 (CET) X-Virus-Scanned: amavisd-new at xbsd.org Received: from smtp.xbsd.org ([127.0.0.1]) by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 14gu6K0S6sjH; Thu, 8 Feb 2007 19:01:30 +0100 (CET) Received: from [193.95.134.156] (mayday.esat.net [193.95.134.156]) by smtp.xbsd.org (Postfix) with ESMTP id C711E117C5; Thu, 8 Feb 2007 19:01:29 +0100 (CET) Message-ID: <45CB6570.8020809@FreeBSD.org> Date: Thu, 08 Feb 2007 18:01:20 +0000 From: Florent Thoumie User-Agent: Thunderbird 1.5.0.9 (X11/20070122) MIME-Version: 1.0 To: Norikatsu Shigemura References: <200702051930.l15JUS8O064334@freefall.freebsd.org> <20070208021810.6bc5ccb1.nork@FreeBSD.org> In-Reply-To: <20070208021810.6bc5ccb1.nork@FreeBSD.org> X-Enigmail-Version: 0.94.1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enigA2FD93C2FA429C281902AD54" Cc: freebsd-rc@FreeBSD.org, bug-followup@FreeBSD.org Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Feb 2007 18:01:44 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigA2FD93C2FA429C281902AD54 Content-Type: multipart/mixed; boundary="------------070003080308050907030409" This is a multi-part message in MIME format. --------------070003080308050907030409 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Norikatsu Shigemura wrote: > On Mon, 5 Feb 2007 19:30:28 GMT > Florent Thoumie wrote: >> I just noticed two other things. >> > +# fec_up ifn >> ^^^ >> fec_up uses fec_interfaces, not $1, so this is wrong. >> > +# Configure Fast EtherChannel for interface $ifn. Returns 0 if FEC= >> > +# arguments were found and configured; returns 1 otherwise. >> fec_up is never called with an argument anyway at the moment. It >> wouldn't be hard to do: work on $1 or $fec_interfaces if $1 is empty.= I >> guess we could use both 'fec_up $ifn' and 'gif_up $ifn' in rc.d/netif= =2E >=20 > Yes. This is ng_fec_create's comment. I rewrote my patch. > Please check following patch. >=20 >> The newly introduced variables also need to be documented in rc.conf.= 5. >> Could you please provide a patch for this? >=20 > I made it, but please fix my broken English:-). >=20 >> I also noticed we don't have gif_down (hence no fec_down). >=20 > I noticed. But it's too hard how should we do. I've rewritten the patch with the modifications we've discussed earlier (set default to "" instead of "NO"). I think it's fine now, so this version is likely to be the one that will hit the tree (in two or three days unless someone thinks there's something wrong). I guess a MFC delayed by 3 weeks will be ok. I'll include the "NO" compatibility at that time. --=20 Florent Thoumie flz@FreeBSD.org FreeBSD Committer --------------070003080308050907030409 Content-Type: text/x-patch; name="patch-fec.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline; filename="patch-fec.diff" Index: src/etc/defaults/rc.conf =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/ncvs/src/etc/defaults/rc.conf,v retrieving revision 1.303 diff -u -r1.303 rc.conf --- src/etc/defaults/rc.conf 20 Jan 2007 04:24:19 -0000 1.303 +++ src/etc/defaults/rc.conf 8 Feb 2007 17:57:13 -0000 @@ -178,11 +178,15 @@ sppp_interfaces=3D"" # List of sppp interfaces. #sppp_interfaces=3D"isp0" # example: sppp over ISDN #spppconfig_isp0=3D"authproto=3Dchap myauthname=3Dfoo myauthsecret=3D'to= p secret' hisauthname=3Dsome-gw hisauthsecret=3D'another secret'" -gif_interfaces=3D"NO" # List of GIF tunnels (or "NO"). +gif_interfaces=3D"" # List of GIF tunnels. #gif_interfaces=3D"gif0 gif1" # Examples typically for a router. # Choose correct tunnel addrs. #gifconfig_gif0=3D"10.1.1.1 10.1.2.1" # Examples typically for a router.= #gifconfig_gif1=3D"10.1.1.2 10.1.2.2" # Examples typically for a router.= +fec_interfaces=3D"" # List of Fast EtherChannels. +#fec_interfaces=3D"fec0 fec1" +#fecconfig_fec0=3D"fxp0 dc0" # Examples typically for two NICs +#fecconfig_fec1=3D"em0 em1 bge0 bge1" # Examples typically for four NICs= =20 # User ppp configuration. ppp_enable=3D"NO" # Start user-ppp (or NO). Index: src/etc/rc.d/netif =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/ncvs/src/etc/rc.d/netif,v retrieving revision 1.21 diff -u -r1.21 netif --- src/etc/rc.d/netif 30 Dec 2006 22:53:20 -0000 1.21 +++ src/etc/rc.d/netif 8 Feb 2007 17:57:13 -0000 @@ -57,6 +57,9 @@ # Create cloned interfaces clone_up =20 + # Create Fast EtherChannel interfaces + fec_up + # Create IPv6<-->IPv4 tunnels gif_up =20 Index: src/etc/network.subr =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/ncvs/src/etc/network.subr,v retrieving revision 1.176 diff -u -r1.176 network.subr --- src/etc/network.subr 29 Oct 2006 13:29:49 -0000 1.176 +++ src/etc/network.subr 8 Feb 2007 17:57:13 -0000 @@ -455,26 +455,82 @@ debug "Destroyed clones: ${_list}" } =20 +# Create netgraph nodes. +# +ng_mkpeer() { + ngctl -f - 2> /dev/null </dev/null 2>&1 + ifconfig $i tunnel ${peers} + ifconfig $i up + ;; + esac + done +} + +# ng_fec_create ifn +# Configure Fast EtherChannel for interface $ifn. Returns 0 if FEC +# arguments were found and configured; returns !0 otherwise. +ng_fec_create() { + local req_iface iface bogus + req_iface=3D"$1" + + ngctl shutdown ${req_iface}: > /dev/null 2>&1 + + bogus=3D"" + while true; do + iface=3D`ng_create_one fec dummy fec` + if [ -z "${iface}" ]; then + exit 2 + fi + if [ "${iface}" =3D "${req_iface}" ]; then + echo ${iface} + break + fi + bogus=3D"${bogus} ${iface}" + done + + for iface in ${bogus}; do + ngctl shutdown ${iface}: + done +} + +fec_up() { + for i in ${fec_interfaces}; do + ng_fec_create $i + for j in `get_if_var $i fecconfig_IF`; do + case ${j} in '') continue ;; *) - ifconfig $i create >/dev/null 2>&1 - ifconfig $i tunnel ${peers} - ifconfig $i up + ngctl msg ${i}: add_iface "\"${j}\"" ;; esac done - ;; - esac + done } =20 # Index: src/share/man/man5/rc.conf.5 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/ncvs/src/share/man/man5/rc.conf.5,v retrieving revision 1.314 diff -u -r1.314 rc.conf.5 --- src/share/man/man5/rc.conf.5 24 Jan 2007 09:22:56 -0000 1.314 +++ src/share/man/man5/rc.conf.5 8 Feb 2007 17:57:13 -0000 @@ -24,7 +24,7 @@ .\" .\" $FreeBSD: src/share/man/man5/rc.conf.5,v 1.314 2007/01/24 09:22:56 c= eri Exp $ .\" -.Dd January 23, 2007 +.Dd February 8, 2007 .Dt RC.CONF 5 .Os .Sh NAME @@ -1163,6 +1163,33 @@ are automatically appended to .Va network_interfaces for configuration. +.It Va fec_interfaces +.Pq Vt str +Set to the list of +.Xr ng_fec 4 +Fast EtherChannel interfaces to configure on this host. +A +.Va fecconfig_ Ns Aq Ar interface +variable is assumed to exist for each value of +.Ar interface . +The value of this variable is used to configure link aggregated interfac= es +according to the syntax of the +.Cm NGM_FEC_ADD_IFACE +to +.Xr ngctl 8=20 +msg. +Additionally, this option ensures that each listed interface is created +via the +.Cm mkpeer +command to +.Xr ngctl 8 +before attempting to configure it. +For example: +.Bd -literal +fec_interfaces=3D"fec0" +fecconfig_fec0=3D"em0 em1" +ifconfig_fec0=3D"DHCP" +.Ed .It Va gif_interfaces .Pq Vt str Set to the list of --------------070003080308050907030409-- --------------enigA2FD93C2FA429C281902AD54 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFFy2V1MxEkbVFH3PQRChnDAJ962eR82AKZl7fmw6XnAT4BOEGDmQCfTxkG 2o+c4NUuBbhYaOErrRA8hdk= =GmK7 -----END PGP SIGNATURE----- --------------enigA2FD93C2FA429C281902AD54-- From owner-freebsd-rc@FreeBSD.ORG Thu Feb 8 18:10:28 2007 Return-Path: X-Original-To: freebsd-rc@hub.freebsd.org Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D097416A400 for ; Thu, 8 Feb 2007 18:10:26 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id 8A76913C48E for ; Thu, 8 Feb 2007 18:10:26 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l18IAQmt098332 for ; Thu, 8 Feb 2007 18:10:26 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l18IAQnu098331; Thu, 8 Feb 2007 18:10:26 GMT (envelope-from gnats) Date: Thu, 8 Feb 2007 18:10:26 GMT Message-Id: <200702081810.l18IAQnu098331@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org From: Florent Thoumie Cc: Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Florent Thoumie List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Feb 2007 18:10:28 -0000 The following reply was made to PR conf/104884; it has been noted by GNATS. From: Florent Thoumie To: Norikatsu Shigemura Cc: freebsd-rc@FreeBSD.org, bug-followup@FreeBSD.org Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf Date: Thu, 08 Feb 2007 18:01:20 +0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigA2FD93C2FA429C281902AD54 Content-Type: multipart/mixed; boundary="------------070003080308050907030409" This is a multi-part message in MIME format. --------------070003080308050907030409 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Norikatsu Shigemura wrote: > On Mon, 5 Feb 2007 19:30:28 GMT > Florent Thoumie wrote: >> I just noticed two other things. >> > +# fec_up ifn >> ^^^ >> fec_up uses fec_interfaces, not $1, so this is wrong. >> > +# Configure Fast EtherChannel for interface $ifn. Returns 0 if FEC= >> > +# arguments were found and configured; returns 1 otherwise. >> fec_up is never called with an argument anyway at the moment. It >> wouldn't be hard to do: work on $1 or $fec_interfaces if $1 is empty.= I >> guess we could use both 'fec_up $ifn' and 'gif_up $ifn' in rc.d/netif= =2E >=20 > Yes. This is ng_fec_create's comment. I rewrote my patch. > Please check following patch. >=20 >> The newly introduced variables also need to be documented in rc.conf.= 5. >> Could you please provide a patch for this? >=20 > I made it, but please fix my broken English:-). >=20 >> I also noticed we don't have gif_down (hence no fec_down). >=20 > I noticed. But it's too hard how should we do. I've rewritten the patch with the modifications we've discussed earlier (set default to "" instead of "NO"). I think it's fine now, so this version is likely to be the one that will hit the tree (in two or three days unless someone thinks there's something wrong). I guess a MFC delayed by 3 weeks will be ok. I'll include the "NO" compatibility at that time. --=20 Florent Thoumie flz@FreeBSD.org FreeBSD Committer --------------070003080308050907030409 Content-Type: text/x-patch; name="patch-fec.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline; filename="patch-fec.diff" Index: src/etc/defaults/rc.conf =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/ncvs/src/etc/defaults/rc.conf,v retrieving revision 1.303 diff -u -r1.303 rc.conf --- src/etc/defaults/rc.conf 20 Jan 2007 04:24:19 -0000 1.303 +++ src/etc/defaults/rc.conf 8 Feb 2007 17:57:13 -0000 @@ -178,11 +178,15 @@ sppp_interfaces=3D"" # List of sppp interfaces. #sppp_interfaces=3D"isp0" # example: sppp over ISDN #spppconfig_isp0=3D"authproto=3Dchap myauthname=3Dfoo myauthsecret=3D'to= p secret' hisauthname=3Dsome-gw hisauthsecret=3D'another secret'" -gif_interfaces=3D"NO" # List of GIF tunnels (or "NO"). +gif_interfaces=3D"" # List of GIF tunnels. #gif_interfaces=3D"gif0 gif1" # Examples typically for a router. # Choose correct tunnel addrs. #gifconfig_gif0=3D"10.1.1.1 10.1.2.1" # Examples typically for a router.= #gifconfig_gif1=3D"10.1.1.2 10.1.2.2" # Examples typically for a router.= +fec_interfaces=3D"" # List of Fast EtherChannels. +#fec_interfaces=3D"fec0 fec1" +#fecconfig_fec0=3D"fxp0 dc0" # Examples typically for two NICs +#fecconfig_fec1=3D"em0 em1 bge0 bge1" # Examples typically for four NICs= =20 # User ppp configuration. ppp_enable=3D"NO" # Start user-ppp (or NO). Index: src/etc/rc.d/netif =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/ncvs/src/etc/rc.d/netif,v retrieving revision 1.21 diff -u -r1.21 netif --- src/etc/rc.d/netif 30 Dec 2006 22:53:20 -0000 1.21 +++ src/etc/rc.d/netif 8 Feb 2007 17:57:13 -0000 @@ -57,6 +57,9 @@ # Create cloned interfaces clone_up =20 + # Create Fast EtherChannel interfaces + fec_up + # Create IPv6<-->IPv4 tunnels gif_up =20 Index: src/etc/network.subr =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/ncvs/src/etc/network.subr,v retrieving revision 1.176 diff -u -r1.176 network.subr --- src/etc/network.subr 29 Oct 2006 13:29:49 -0000 1.176 +++ src/etc/network.subr 8 Feb 2007 17:57:13 -0000 @@ -455,26 +455,82 @@ debug "Destroyed clones: ${_list}" } =20 +# Create netgraph nodes. +# +ng_mkpeer() { + ngctl -f - 2> /dev/null </dev/null 2>&1 + ifconfig $i tunnel ${peers} + ifconfig $i up + ;; + esac + done +} + +# ng_fec_create ifn +# Configure Fast EtherChannel for interface $ifn. Returns 0 if FEC +# arguments were found and configured; returns !0 otherwise. +ng_fec_create() { + local req_iface iface bogus + req_iface=3D"$1" + + ngctl shutdown ${req_iface}: > /dev/null 2>&1 + + bogus=3D"" + while true; do + iface=3D`ng_create_one fec dummy fec` + if [ -z "${iface}" ]; then + exit 2 + fi + if [ "${iface}" =3D "${req_iface}" ]; then + echo ${iface} + break + fi + bogus=3D"${bogus} ${iface}" + done + + for iface in ${bogus}; do + ngctl shutdown ${iface}: + done +} + +fec_up() { + for i in ${fec_interfaces}; do + ng_fec_create $i + for j in `get_if_var $i fecconfig_IF`; do + case ${j} in '') continue ;; *) - ifconfig $i create >/dev/null 2>&1 - ifconfig $i tunnel ${peers} - ifconfig $i up + ngctl msg ${i}: add_iface "\"${j}\"" ;; esac done - ;; - esac + done } =20 # Index: src/share/man/man5/rc.conf.5 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/ncvs/src/share/man/man5/rc.conf.5,v retrieving revision 1.314 diff -u -r1.314 rc.conf.5 --- src/share/man/man5/rc.conf.5 24 Jan 2007 09:22:56 -0000 1.314 +++ src/share/man/man5/rc.conf.5 8 Feb 2007 17:57:13 -0000 @@ -24,7 +24,7 @@ .\" .\" $FreeBSD: src/share/man/man5/rc.conf.5,v 1.314 2007/01/24 09:22:56 c= eri Exp $ .\" -.Dd January 23, 2007 +.Dd February 8, 2007 .Dt RC.CONF 5 .Os .Sh NAME @@ -1163,6 +1163,33 @@ are automatically appended to .Va network_interfaces for configuration. +.It Va fec_interfaces +.Pq Vt str +Set to the list of +.Xr ng_fec 4 +Fast EtherChannel interfaces to configure on this host. +A +.Va fecconfig_ Ns Aq Ar interface +variable is assumed to exist for each value of +.Ar interface . +The value of this variable is used to configure link aggregated interfac= es +according to the syntax of the +.Cm NGM_FEC_ADD_IFACE +to +.Xr ngctl 8=20 +msg. +Additionally, this option ensures that each listed interface is created +via the +.Cm mkpeer +command to +.Xr ngctl 8 +before attempting to configure it. +For example: +.Bd -literal +fec_interfaces=3D"fec0" +fecconfig_fec0=3D"em0 em1" +ifconfig_fec0=3D"DHCP" +.Ed .It Va gif_interfaces .Pq Vt str Set to the list of --------------070003080308050907030409-- --------------enigA2FD93C2FA429C281902AD54 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFFy2V1MxEkbVFH3PQRChnDAJ962eR82AKZl7fmw6XnAT4BOEGDmQCfTxkG 2o+c4NUuBbhYaOErrRA8hdk= =GmK7 -----END PGP SIGNATURE----- --------------enigA2FD93C2FA429C281902AD54-- From owner-freebsd-rc@FreeBSD.ORG Thu Feb 8 21:55:25 2007 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 77DC616A4EB for ; Thu, 8 Feb 2007 21:55:25 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx22.fluidhosting.com [204.14.89.5]) by mx1.freebsd.org (Postfix) with SMTP id E3AD413C48D for ; Thu, 8 Feb 2007 21:55:24 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: (qmail 32119 invoked by uid 399); 8 Feb 2007 21:55:24 -0000 Received: from localhost (HELO ?192.168.0.4?) (dougb@dougbarton.us@127.0.0.1) by localhost with SMTP; 8 Feb 2007 21:55:24 -0000 X-Originating-IP: 127.0.0.1 Message-ID: <45CB9C44.8010207@FreeBSD.org> Date: Thu, 08 Feb 2007 13:55:16 -0800 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 2.0b2 (Windows/20070116) MIME-Version: 1.0 To: Brooks Davis References: <20061029010934.5afef73e.nork@FreeBSD.org> <200610281610.k9SGAIVb051055@freefall.freebsd.org> <20070129000459.b2dba4e0.nork@FreeBSD.org> <45C757FA.2000209@FreeBSD.org> <20070205163646.GB48768@lor.one-eyed-alien.net> <45C75E1F.2070709@FreeBSD.org> <45C77AFD.1050801@FreeBSD.org> <45C77B9B.20403@FreeBSD.org> <20070205190220.GA51379@lor.one-eyed-alien.net> In-Reply-To: <20070205190220.GA51379@lor.one-eyed-alien.net> X-Enigmail-Version: 0.94.2.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-bugs@FreeBSD.org, FreeBSD-gnats-submit@FreeBSD.org, freebsd-rc@FreeBSD.org, Norikatsu Shigemura , Florent Thoumie Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Feb 2007 21:55:25 -0000 Brooks Davis wrote: > The default should be an empty list which results in nothing happening. > I'd suggest making empty list the value for the default gif_interfaces > in /etc/defaults/rc.conf in both branches, removing support for NO in > CURRENT and emitting a warning in stable. How about issuing a warning for NO in both branches? Whether I agree with you or not on the importance of keeping things clean and consistent, I definitely do not want to err on the side of pedantry over usability. Doug -- This .signature sanitized for your protection From owner-freebsd-rc@FreeBSD.ORG Thu Feb 8 22:00:43 2007 Return-Path: X-Original-To: freebsd-rc@hub.freebsd.org Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7E52D16A405 for ; Thu, 8 Feb 2007 22:00:43 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id 322E413C4A8 for ; Thu, 8 Feb 2007 22:00:43 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l18M0hBX013751 for ; Thu, 8 Feb 2007 22:00:43 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l18M0gSW013749; Thu, 8 Feb 2007 22:00:43 GMT (envelope-from gnats) Date: Thu, 8 Feb 2007 22:00:43 GMT Message-Id: <200702082200.l18M0gSW013749@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org From: Doug Barton Cc: Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Doug Barton List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Feb 2007 22:00:43 -0000 The following reply was made to PR conf/104884; it has been noted by GNATS. From: Doug Barton To: Brooks Davis Cc: Florent Thoumie , Norikatsu Shigemura , freebsd-bugs@FreeBSD.org, FreeBSD-gnats-submit@FreeBSD.org, freebsd-rc@FreeBSD.org Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf Date: Thu, 08 Feb 2007 13:55:16 -0800 Brooks Davis wrote: > The default should be an empty list which results in nothing happening. > I'd suggest making empty list the value for the default gif_interfaces > in /etc/defaults/rc.conf in both branches, removing support for NO in > CURRENT and emitting a warning in stable. How about issuing a warning for NO in both branches? Whether I agree with you or not on the importance of keeping things clean and consistent, I definitely do not want to err on the side of pedantry over usability. Doug -- This .signature sanitized for your protection From owner-freebsd-rc@FreeBSD.ORG Thu Feb 8 22:47:00 2007 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9FCC216A401; Thu, 8 Feb 2007 22:47:00 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (grnl-static-02-0046.dsl.iowatelecom.net [69.66.56.110]) by mx1.freebsd.org (Postfix) with ESMTP id 544E813C49D; Thu, 8 Feb 2007 22:47:00 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.13.8/8.13.8) with ESMTP id l18Mkx3F098015; Thu, 8 Feb 2007 16:46:59 -0600 (CST) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.13.8/8.13.8/Submit) id l18Mkxng098014; Thu, 8 Feb 2007 16:46:59 -0600 (CST) (envelope-from brooks) Date: Thu, 8 Feb 2007 16:46:59 -0600 From: Brooks Davis To: Doug Barton Message-ID: <20070208224659.GA96852@lor.one-eyed-alien.net> References: <20061029010934.5afef73e.nork@FreeBSD.org> <200610281610.k9SGAIVb051055@freefall.freebsd.org> <20070129000459.b2dba4e0.nork@FreeBSD.org> <45C757FA.2000209@FreeBSD.org> <20070205163646.GB48768@lor.one-eyed-alien.net> <45C75E1F.2070709@FreeBSD.org> <45C77AFD.1050801@FreeBSD.org> <45C77B9B.20403@FreeBSD.org> <20070205190220.GA51379@lor.one-eyed-alien.net> <45CB9C44.8010207@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <45CB9C44.8010207@FreeBSD.org> User-Agent: Mutt/1.5.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (lor.one-eyed-alien.net [127.0.0.1]); Thu, 08 Feb 2007 16:46:59 -0600 (CST) Cc: freebsd-bugs@FreeBSD.org, Brooks Davis , freebsd-rc@FreeBSD.org, Florent Thoumie , Norikatsu Shigemura , FreeBSD-gnats-submit@FreeBSD.org Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Feb 2007 22:47:00 -0000 On Thu, Feb 08, 2007 at 01:55:16PM -0800, Doug Barton wrote: > Brooks Davis wrote: > > > The default should be an empty list which results in nothing happening. > > I'd suggest making empty list the value for the default gif_interfaces > > in /etc/defaults/rc.conf in both branches, removing support for NO in > > CURRENT and emitting a warning in stable. > > How about issuing a warning for NO in both branches? Whether I agree > with you or not on the importance of keeping things clean and > consistent, I definitely do not want to err on the side of pedantry > over usability. That would be fine. I don't really care as long as it's deprecated. FWIW, only users who don't update /etc/defaults/rc.conf or who manually set gif_interfaces="NO" would be effected so the size of the set of effected users is probalby close to epilon and even all that will happen is cloning an extra interface and then not configuring it so it should be basicly harmless to just remove direct support for it. -- Brooks From owner-freebsd-rc@FreeBSD.ORG Thu Feb 8 22:50:28 2007 Return-Path: X-Original-To: freebsd-rc@hub.freebsd.org Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0A5B316A400 for ; Thu, 8 Feb 2007 22:50:28 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id EF16613C4B6 for ; Thu, 8 Feb 2007 22:50:27 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l18MoRmc019113 for ; Thu, 8 Feb 2007 22:50:27 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l18MoRkO019112; Thu, 8 Feb 2007 22:50:27 GMT (envelope-from gnats) Date: Thu, 8 Feb 2007 22:50:27 GMT Message-Id: <200702082250.l18MoRkO019112@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org From: Brooks Davis Cc: Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Brooks Davis List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Feb 2007 22:50:28 -0000 The following reply was made to PR conf/104884; it has been noted by GNATS. From: Brooks Davis To: Doug Barton Cc: Brooks Davis , Florent Thoumie , Norikatsu Shigemura , freebsd-bugs@FreeBSD.org, FreeBSD-gnats-submit@FreeBSD.org, freebsd-rc@FreeBSD.org Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf Date: Thu, 8 Feb 2007 16:46:59 -0600 On Thu, Feb 08, 2007 at 01:55:16PM -0800, Doug Barton wrote: > Brooks Davis wrote: > > > The default should be an empty list which results in nothing happening. > > I'd suggest making empty list the value for the default gif_interfaces > > in /etc/defaults/rc.conf in both branches, removing support for NO in > > CURRENT and emitting a warning in stable. > > How about issuing a warning for NO in both branches? Whether I agree > with you or not on the importance of keeping things clean and > consistent, I definitely do not want to err on the side of pedantry > over usability. That would be fine. I don't really care as long as it's deprecated. FWIW, only users who don't update /etc/defaults/rc.conf or who manually set gif_interfaces="NO" would be effected so the size of the set of effected users is probalby close to epilon and even all that will happen is cloning an extra interface and then not configuring it so it should be basicly harmless to just remove direct support for it. -- Brooks From owner-freebsd-rc@FreeBSD.ORG Thu Feb 8 23:35:29 2007 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1EE3216A400; Thu, 8 Feb 2007 23:35:29 +0000 (UTC) (envelope-from flz@FreeBSD.org) Received: from smtp6-g19.free.fr (smtp6-g19.free.fr [212.27.42.36]) by mx1.freebsd.org (Postfix) with ESMTP id 9E88B13C49D; Thu, 8 Feb 2007 23:35:28 +0000 (UTC) (envelope-from flz@FreeBSD.org) Received: from smtp.xbsd.org (unknown [82.233.2.192]) by smtp6-g19.free.fr (Postfix) with ESMTP id 4C8F34353E; Fri, 9 Feb 2007 00:35:27 +0100 (CET) Received: from localhost (localhost.xbsd.org [127.0.0.1]) by smtp.xbsd.org (Postfix) with ESMTP id 1B21711B37; Fri, 9 Feb 2007 00:35:21 +0100 (CET) X-Virus-Scanned: amavisd-new at xbsd.org Received: from smtp.xbsd.org ([127.0.0.1]) by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id m3cUNkQ1pTai; Fri, 9 Feb 2007 00:35:14 +0100 (CET) Received: from [193.120.13.130] (cream.xbsd.org [193.120.13.130]) by smtp.xbsd.org (Postfix) with ESMTP id 8A04811AD8; Fri, 9 Feb 2007 00:35:10 +0100 (CET) Message-ID: <45CBB2A1.706@FreeBSD.org> Date: Thu, 08 Feb 2007 23:30:41 +0000 From: Florent Thoumie User-Agent: Thunderbird 1.5.0.9 (X11/20070122) MIME-Version: 1.0 To: Brooks Davis References: <20061029010934.5afef73e.nork@FreeBSD.org> <200610281610.k9SGAIVb051055@freefall.freebsd.org> <20070129000459.b2dba4e0.nork@FreeBSD.org> <45C757FA.2000209@FreeBSD.org> <20070205163646.GB48768@lor.one-eyed-alien.net> <45C75E1F.2070709@FreeBSD.org> <45C77AFD.1050801@FreeBSD.org> <45C77B9B.20403@FreeBSD.org> <20070205190220.GA51379@lor.one-eyed-alien.net> <45CB9C44.8010207@FreeBSD.org> <20070208224659.GA96852@lor.one-eyed-alien.net> In-Reply-To: <20070208224659.GA96852@lor.one-eyed-alien.net> X-Enigmail-Version: 0.94.1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig5E80D3757FBED01672C33A4F" Cc: freebsd-bugs@FreeBSD.org, Doug Barton , freebsd-rc@FreeBSD.org, Norikatsu Shigemura , FreeBSD-gnats-submit@FreeBSD.org Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Feb 2007 23:35:29 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig5E80D3757FBED01672C33A4F Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Brooks Davis wrote: > On Thu, Feb 08, 2007 at 01:55:16PM -0800, Doug Barton wrote: >> Brooks Davis wrote: >> >>> The default should be an empty list which results in nothing happenin= g. >>> I'd suggest making empty list the value for the default gif_interface= s >>> in /etc/defaults/rc.conf in both branches, removing support for NO in= >>> CURRENT and emitting a warning in stable. >> How about issuing a warning for NO in both branches? Whether I agree >> with you or not on the importance of keeping things clean and >> consistent, I definitely do not want to err on the side of pedantry >> over usability. >=20 > That would be fine. I don't really care as long as it's deprecated. >=20 > FWIW, only users who don't update /etc/defaults/rc.conf or who manually= > set gif_interfaces=3D"NO" would be effected so the size of the set of > effected users is probalby close to epilon and even all that will happe= n > is cloning an extra interface and then not configuring it so it should > be basicly harmless to just remove direct support for it. Fine with me as well. Should we make it a warning on RELENG_6 and an error on HEAD, or a warning on both. The former being be what I was planning to do, ie. remove support for "NO" in HEAD but issue a message saying semantics have changed. The latter would mean identical code in both HEAD and RELENG_6 (so "NO"-compatibility in both branches), but we'd need a reminder to remove this "NO"-support in HEAD once RELENG_7 is branched. --=20 Florent Thoumie flz@FreeBSD.org FreeBSD Committer --------------enig5E80D3757FBED01672C33A4F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFFy7KmMxEkbVFH3PQRCmK4AJ9Kll/nStdtq4bJj7/DOWXrPERuVwCePPRv 995tN2tSqMK/JfKTcq+27W8= =tBI1 -----END PGP SIGNATURE----- --------------enig5E80D3757FBED01672C33A4F-- From owner-freebsd-rc@FreeBSD.ORG Thu Feb 8 23:40:32 2007 Return-Path: X-Original-To: freebsd-rc@hub.freebsd.org Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2EF5316A406 for ; Thu, 8 Feb 2007 23:40:32 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id CFDD113C467 for ; Thu, 8 Feb 2007 23:40:31 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l18NeV1L022724 for ; Thu, 8 Feb 2007 23:40:31 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l18NeVbN022723; Thu, 8 Feb 2007 23:40:31 GMT (envelope-from gnats) Date: Thu, 8 Feb 2007 23:40:31 GMT Message-Id: <200702082340.l18NeVbN022723@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org From: Florent Thoumie Cc: Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Florent Thoumie List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Feb 2007 23:40:32 -0000 The following reply was made to PR conf/104884; it has been noted by GNATS. From: Florent Thoumie To: Brooks Davis Cc: Doug Barton , Norikatsu Shigemura , freebsd-bugs@FreeBSD.org, FreeBSD-gnats-submit@FreeBSD.org, freebsd-rc@FreeBSD.org Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf Date: Thu, 08 Feb 2007 23:30:41 +0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig5E80D3757FBED01672C33A4F Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Brooks Davis wrote: > On Thu, Feb 08, 2007 at 01:55:16PM -0800, Doug Barton wrote: >> Brooks Davis wrote: >> >>> The default should be an empty list which results in nothing happenin= g. >>> I'd suggest making empty list the value for the default gif_interface= s >>> in /etc/defaults/rc.conf in both branches, removing support for NO in= >>> CURRENT and emitting a warning in stable. >> How about issuing a warning for NO in both branches? Whether I agree >> with you or not on the importance of keeping things clean and >> consistent, I definitely do not want to err on the side of pedantry >> over usability. >=20 > That would be fine. I don't really care as long as it's deprecated. >=20 > FWIW, only users who don't update /etc/defaults/rc.conf or who manually= > set gif_interfaces=3D"NO" would be effected so the size of the set of > effected users is probalby close to epilon and even all that will happe= n > is cloning an extra interface and then not configuring it so it should > be basicly harmless to just remove direct support for it. Fine with me as well. Should we make it a warning on RELENG_6 and an error on HEAD, or a warning on both. The former being be what I was planning to do, ie. remove support for "NO" in HEAD but issue a message saying semantics have changed. The latter would mean identical code in both HEAD and RELENG_6 (so "NO"-compatibility in both branches), but we'd need a reminder to remove this "NO"-support in HEAD once RELENG_7 is branched. --=20 Florent Thoumie flz@FreeBSD.org FreeBSD Committer --------------enig5E80D3757FBED01672C33A4F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFFy7KmMxEkbVFH3PQRCmK4AJ9Kll/nStdtq4bJj7/DOWXrPERuVwCePPRv 995tN2tSqMK/JfKTcq+27W8= =tBI1 -----END PGP SIGNATURE----- --------------enig5E80D3757FBED01672C33A4F-- From owner-freebsd-rc@FreeBSD.ORG Thu Feb 8 23:47:39 2007 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0095B16A402; Thu, 8 Feb 2007 23:47:39 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (grnl-static-02-0046.dsl.iowatelecom.net [69.66.56.110]) by mx1.freebsd.org (Postfix) with ESMTP id 909BA13C48D; Thu, 8 Feb 2007 23:47:38 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.13.8/8.13.8) with ESMTP id l18Nlb0A098603; Thu, 8 Feb 2007 17:47:37 -0600 (CST) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.13.8/8.13.8/Submit) id l18Nlb3n098602; Thu, 8 Feb 2007 17:47:37 -0600 (CST) (envelope-from brooks) Date: Thu, 8 Feb 2007 17:47:37 -0600 From: Brooks Davis To: Florent Thoumie Message-ID: <20070208234737.GA98583@lor.one-eyed-alien.net> References: <20070129000459.b2dba4e0.nork@FreeBSD.org> <45C757FA.2000209@FreeBSD.org> <20070205163646.GB48768@lor.one-eyed-alien.net> <45C75E1F.2070709@FreeBSD.org> <45C77AFD.1050801@FreeBSD.org> <45C77B9B.20403@FreeBSD.org> <20070205190220.GA51379@lor.one-eyed-alien.net> <45CB9C44.8010207@FreeBSD.org> <20070208224659.GA96852@lor.one-eyed-alien.net> <45CBB2A1.706@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <45CBB2A1.706@FreeBSD.org> User-Agent: Mutt/1.5.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (lor.one-eyed-alien.net [127.0.0.1]); Thu, 08 Feb 2007 17:47:37 -0600 (CST) Cc: freebsd-bugs@FreeBSD.org, Doug Barton , freebsd-rc@FreeBSD.org, Norikatsu Shigemura , Brooks Davis , FreeBSD-gnats-submit@FreeBSD.org Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Feb 2007 23:47:39 -0000 On Thu, Feb 08, 2007 at 11:30:41PM +0000, Florent Thoumie wrote: > Brooks Davis wrote: > > On Thu, Feb 08, 2007 at 01:55:16PM -0800, Doug Barton wrote: > >> Brooks Davis wrote: > >> > >>> The default should be an empty list which results in nothing happening. > >>> I'd suggest making empty list the value for the default gif_interfaces > >>> in /etc/defaults/rc.conf in both branches, removing support for NO in > >>> CURRENT and emitting a warning in stable. > >> How about issuing a warning for NO in both branches? Whether I agree > >> with you or not on the importance of keeping things clean and > >> consistent, I definitely do not want to err on the side of pedantry > >> over usability. > > > > That would be fine. I don't really care as long as it's deprecated. > > > > FWIW, only users who don't update /etc/defaults/rc.conf or who manually > > set gif_interfaces="NO" would be effected so the size of the set of > > effected users is probalby close to epilon and even all that will happen > > is cloning an extra interface and then not configuring it so it should > > be basicly harmless to just remove direct support for it. > > Fine with me as well. Should we make it a warning on RELENG_6 and an > error on HEAD, or a warning on both. The former being be what I was > planning to do, ie. remove support for "NO" in HEAD but issue a message > saying semantics have changed. The latter would mean identical code in > both HEAD and RELENG_6 (so "NO"-compatibility in both branches), but > we'd need a reminder to remove this "NO"-support in HEAD once RELENG_7 > is branched. I'd say a warning in both. -- Brooks From owner-freebsd-rc@FreeBSD.ORG Thu Feb 8 23:50:23 2007 Return-Path: X-Original-To: freebsd-rc@hub.freebsd.org Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B902016A408 for ; Thu, 8 Feb 2007 23:50:23 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id AA04313C4B2 for ; Thu, 8 Feb 2007 23:50:23 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l18NoNLX023086 for ; Thu, 8 Feb 2007 23:50:23 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l18NoNi7023084; Thu, 8 Feb 2007 23:50:23 GMT (envelope-from gnats) Date: Thu, 8 Feb 2007 23:50:23 GMT Message-Id: <200702082350.l18NoNi7023084@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org From: Brooks Davis Cc: Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Brooks Davis List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Feb 2007 23:50:23 -0000 The following reply was made to PR conf/104884; it has been noted by GNATS. From: Brooks Davis To: Florent Thoumie Cc: Brooks Davis , Doug Barton , Norikatsu Shigemura , freebsd-bugs@FreeBSD.org, FreeBSD-gnats-submit@FreeBSD.org, freebsd-rc@FreeBSD.org Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf Date: Thu, 8 Feb 2007 17:47:37 -0600 On Thu, Feb 08, 2007 at 11:30:41PM +0000, Florent Thoumie wrote: > Brooks Davis wrote: > > On Thu, Feb 08, 2007 at 01:55:16PM -0800, Doug Barton wrote: > >> Brooks Davis wrote: > >> > >>> The default should be an empty list which results in nothing happening. > >>> I'd suggest making empty list the value for the default gif_interfaces > >>> in /etc/defaults/rc.conf in both branches, removing support for NO in > >>> CURRENT and emitting a warning in stable. > >> How about issuing a warning for NO in both branches? Whether I agree > >> with you or not on the importance of keeping things clean and > >> consistent, I definitely do not want to err on the side of pedantry > >> over usability. > > > > That would be fine. I don't really care as long as it's deprecated. > > > > FWIW, only users who don't update /etc/defaults/rc.conf or who manually > > set gif_interfaces="NO" would be effected so the size of the set of > > effected users is probalby close to epilon and even all that will happen > > is cloning an extra interface and then not configuring it so it should > > be basicly harmless to just remove direct support for it. > > Fine with me as well. Should we make it a warning on RELENG_6 and an > error on HEAD, or a warning on both. The former being be what I was > planning to do, ie. remove support for "NO" in HEAD but issue a message > saying semantics have changed. The latter would mean identical code in > both HEAD and RELENG_6 (so "NO"-compatibility in both branches), but > we'd need a reminder to remove this "NO"-support in HEAD once RELENG_7 > is branched. I'd say a warning in both. -- Brooks From owner-freebsd-rc@FreeBSD.ORG Thu Feb 8 23:52:35 2007 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 86DC716A402; Thu, 8 Feb 2007 23:52:35 +0000 (UTC) (envelope-from flz@FreeBSD.org) Received: from smtp7-g19.free.fr (smtp7-g19.free.fr [212.27.42.64]) by mx1.freebsd.org (Postfix) with ESMTP id 1174913C46B; Thu, 8 Feb 2007 23:52:35 +0000 (UTC) (envelope-from flz@FreeBSD.org) Received: from smtp.xbsd.org (unknown [82.233.2.192]) by smtp7-g19.free.fr (Postfix) with ESMTP id EEBC75508; Fri, 9 Feb 2007 00:52:33 +0100 (CET) Received: from localhost (localhost.xbsd.org [127.0.0.1]) by smtp.xbsd.org (Postfix) with ESMTP id 93BFA11B37; Fri, 9 Feb 2007 00:52:33 +0100 (CET) X-Virus-Scanned: amavisd-new at xbsd.org Received: from smtp.xbsd.org ([127.0.0.1]) by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PXMY+1Y4wG+s; Fri, 9 Feb 2007 00:52:27 +0100 (CET) Received: from [193.120.13.130] (cream.xbsd.org [193.120.13.130]) by smtp.xbsd.org (Postfix) with ESMTP id 5324D11ADC; Fri, 9 Feb 2007 00:52:26 +0100 (CET) Message-ID: <45CBB6B4.7050407@FreeBSD.org> Date: Thu, 08 Feb 2007 23:48:04 +0000 From: Florent Thoumie User-Agent: Thunderbird 1.5.0.9 (X11/20070122) MIME-Version: 1.0 To: Brooks Davis References: <20070129000459.b2dba4e0.nork@FreeBSD.org> <45C757FA.2000209@FreeBSD.org> <20070205163646.GB48768@lor.one-eyed-alien.net> <45C75E1F.2070709@FreeBSD.org> <45C77AFD.1050801@FreeBSD.org> <45C77B9B.20403@FreeBSD.org> <20070205190220.GA51379@lor.one-eyed-alien.net> <45CB9C44.8010207@FreeBSD.org> <20070208224659.GA96852@lor.one-eyed-alien.net> <45CBB2A1.706@FreeBSD.org> <20070208234737.GA98583@lor.one-eyed-alien.net> In-Reply-To: <20070208234737.GA98583@lor.one-eyed-alien.net> X-Enigmail-Version: 0.94.1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig44FBBDEA77F2D581571B4587" Cc: freebsd-bugs@FreeBSD.org, Doug Barton , freebsd-rc@FreeBSD.org, Norikatsu Shigemura , FreeBSD-gnats-submit@FreeBSD.org Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Feb 2007 23:52:35 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig44FBBDEA77F2D581571B4587 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Brooks Davis wrote: > On Thu, Feb 08, 2007 at 11:30:41PM +0000, Florent Thoumie wrote: >> Brooks Davis wrote: >>> On Thu, Feb 08, 2007 at 01:55:16PM -0800, Doug Barton wrote: >>>> Brooks Davis wrote: >>>> >>>>> The default should be an empty list which results in nothing happen= ing. >>>>> I'd suggest making empty list the value for the default gif_interfa= ces >>>>> in /etc/defaults/rc.conf in both branches, removing support for NO = in >>>>> CURRENT and emitting a warning in stable. >>>> How about issuing a warning for NO in both branches? Whether I agree= >>>> with you or not on the importance of keeping things clean and >>>> consistent, I definitely do not want to err on the side of pedantry >>>> over usability. >>> That would be fine. I don't really care as long as it's deprecated. >>> >>> FWIW, only users who don't update /etc/defaults/rc.conf or who manual= ly >>> set gif_interfaces=3D"NO" would be effected so the size of the set of= >>> effected users is probalby close to epilon and even all that will hap= pen >>> is cloning an extra interface and then not configuring it so it shoul= d >>> be basicly harmless to just remove direct support for it. >> Fine with me as well. Should we make it a warning on RELENG_6 and an >> error on HEAD, or a warning on both. The former being be what I was >> planning to do, ie. remove support for "NO" in HEAD but issue a messag= e >> saying semantics have changed. The latter would mean identical code in= >> both HEAD and RELENG_6 (so "NO"-compatibility in both branches), but >> we'd need a reminder to remove this "NO"-support in HEAD once RELENG_7= >> is branched. >=20 > I'd say a warning in both. Re-reading Doug's message, he's probably thinking the same thing, but this is for gif_interfaces only, right? --=20 Florent Thoumie flz@FreeBSD.org FreeBSD Committer --------------enig44FBBDEA77F2D581571B4587 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFFy7a0MxEkbVFH3PQRCrFIAJ9oelmuwW66WzTncTrqPQspTLfpjQCeOq42 FihB34D9SR37ISDNpVn2aeU= =PAkV -----END PGP SIGNATURE----- --------------enig44FBBDEA77F2D581571B4587-- From owner-freebsd-rc@FreeBSD.ORG Fri Feb 9 00:00:36 2007 Return-Path: X-Original-To: freebsd-rc@hub.freebsd.org Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 57EDD16A400 for ; Fri, 9 Feb 2007 00:00:36 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id 3978113C474 for ; Fri, 9 Feb 2007 00:00:36 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l1900adY023393 for ; Fri, 9 Feb 2007 00:00:36 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l1900aF2023392; Fri, 9 Feb 2007 00:00:36 GMT (envelope-from gnats) Date: Fri, 9 Feb 2007 00:00:36 GMT Message-Id: <200702090000.l1900aF2023392@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org From: Florent Thoumie Cc: Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Florent Thoumie List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Feb 2007 00:00:36 -0000 The following reply was made to PR conf/104884; it has been noted by GNATS. From: Florent Thoumie To: Brooks Davis Cc: Doug Barton , Norikatsu Shigemura , freebsd-bugs@FreeBSD.org, FreeBSD-gnats-submit@FreeBSD.org, freebsd-rc@FreeBSD.org Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf Date: Thu, 08 Feb 2007 23:48:04 +0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig44FBBDEA77F2D581571B4587 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Brooks Davis wrote: > On Thu, Feb 08, 2007 at 11:30:41PM +0000, Florent Thoumie wrote: >> Brooks Davis wrote: >>> On Thu, Feb 08, 2007 at 01:55:16PM -0800, Doug Barton wrote: >>>> Brooks Davis wrote: >>>> >>>>> The default should be an empty list which results in nothing happen= ing. >>>>> I'd suggest making empty list the value for the default gif_interfa= ces >>>>> in /etc/defaults/rc.conf in both branches, removing support for NO = in >>>>> CURRENT and emitting a warning in stable. >>>> How about issuing a warning for NO in both branches? Whether I agree= >>>> with you or not on the importance of keeping things clean and >>>> consistent, I definitely do not want to err on the side of pedantry >>>> over usability. >>> That would be fine. I don't really care as long as it's deprecated. >>> >>> FWIW, only users who don't update /etc/defaults/rc.conf or who manual= ly >>> set gif_interfaces=3D"NO" would be effected so the size of the set of= >>> effected users is probalby close to epilon and even all that will hap= pen >>> is cloning an extra interface and then not configuring it so it shoul= d >>> be basicly harmless to just remove direct support for it. >> Fine with me as well. Should we make it a warning on RELENG_6 and an >> error on HEAD, or a warning on both. The former being be what I was >> planning to do, ie. remove support for "NO" in HEAD but issue a messag= e >> saying semantics have changed. The latter would mean identical code in= >> both HEAD and RELENG_6 (so "NO"-compatibility in both branches), but >> we'd need a reminder to remove this "NO"-support in HEAD once RELENG_7= >> is branched. >=20 > I'd say a warning in both. Re-reading Doug's message, he's probably thinking the same thing, but this is for gif_interfaces only, right? --=20 Florent Thoumie flz@FreeBSD.org FreeBSD Committer --------------enig44FBBDEA77F2D581571B4587 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFFy7a0MxEkbVFH3PQRCrFIAJ9oelmuwW66WzTncTrqPQspTLfpjQCeOq42 FihB34D9SR37ISDNpVn2aeU= =PAkV -----END PGP SIGNATURE----- --------------enig44FBBDEA77F2D581571B4587-- From owner-freebsd-rc@FreeBSD.ORG Fri Feb 9 00:03:51 2007 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id F0B0616A40A; Fri, 9 Feb 2007 00:03:50 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (grnl-static-02-0046.dsl.iowatelecom.net [69.66.56.110]) by mx1.freebsd.org (Postfix) with ESMTP id 0436F13C4DE; Fri, 9 Feb 2007 00:01:10 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.13.8/8.13.8) with ESMTP id l19019Hi098797; Thu, 8 Feb 2007 18:01:09 -0600 (CST) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.13.8/8.13.8/Submit) id l19019fx098796; Thu, 8 Feb 2007 18:01:09 -0600 (CST) (envelope-from brooks) Date: Thu, 8 Feb 2007 18:01:09 -0600 From: Brooks Davis To: Florent Thoumie Message-ID: <20070209000109.GA98754@lor.one-eyed-alien.net> References: <20070205163646.GB48768@lor.one-eyed-alien.net> <45C75E1F.2070709@FreeBSD.org> <45C77AFD.1050801@FreeBSD.org> <45C77B9B.20403@FreeBSD.org> <20070205190220.GA51379@lor.one-eyed-alien.net> <45CB9C44.8010207@FreeBSD.org> <20070208224659.GA96852@lor.one-eyed-alien.net> <45CBB2A1.706@FreeBSD.org> <20070208234737.GA98583@lor.one-eyed-alien.net> <45CBB6B4.7050407@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <45CBB6B4.7050407@FreeBSD.org> User-Agent: Mutt/1.5.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (lor.one-eyed-alien.net [127.0.0.1]); Thu, 08 Feb 2007 18:01:09 -0600 (CST) Cc: freebsd-bugs@FreeBSD.org, Doug Barton , freebsd-rc@FreeBSD.org, Norikatsu Shigemura , Brooks Davis , FreeBSD-gnats-submit@FreeBSD.org Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Feb 2007 00:03:51 -0000 On Thu, Feb 08, 2007 at 11:48:04PM +0000, Florent Thoumie wrote: > Brooks Davis wrote: > > On Thu, Feb 08, 2007 at 11:30:41PM +0000, Florent Thoumie wrote: > >> Brooks Davis wrote: > >>> On Thu, Feb 08, 2007 at 01:55:16PM -0800, Doug Barton wrote: > >>>> Brooks Davis wrote: > >>>> > >>>>> The default should be an empty list which results in nothing happening. > >>>>> I'd suggest making empty list the value for the default gif_interfaces > >>>>> in /etc/defaults/rc.conf in both branches, removing support for NO in > >>>>> CURRENT and emitting a warning in stable. > >>>> How about issuing a warning for NO in both branches? Whether I agree > >>>> with you or not on the importance of keeping things clean and > >>>> consistent, I definitely do not want to err on the side of pedantry > >>>> over usability. > >>> That would be fine. I don't really care as long as it's deprecated. > >>> > >>> FWIW, only users who don't update /etc/defaults/rc.conf or who manually > >>> set gif_interfaces="NO" would be effected so the size of the set of > >>> effected users is probalby close to epilon and even all that will happen > >>> is cloning an extra interface and then not configuring it so it should > >>> be basicly harmless to just remove direct support for it. > >> Fine with me as well. Should we make it a warning on RELENG_6 and an > >> error on HEAD, or a warning on both. The former being be what I was > >> planning to do, ie. remove support for "NO" in HEAD but issue a message > >> saying semantics have changed. The latter would mean identical code in > >> both HEAD and RELENG_6 (so "NO"-compatibility in both branches), but > >> we'd need a reminder to remove this "NO"-support in HEAD once RELENG_7 > >> is branched. > > > > I'd say a warning in both. > > Re-reading Doug's message, he's probably thinking the same thing, but > this is for gif_interfaces only, right? That's what I'd do. There's no reason to introduce support for an instantly deprecated feature in a new variable, particularly since gif_interfaces is the odd one out. -- Brooks From owner-freebsd-rc@FreeBSD.ORG Fri Feb 9 00:07:52 2007 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2C9E416A409 for ; Fri, 9 Feb 2007 00:07:52 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx22.fluidhosting.com [204.14.89.5]) by mx1.freebsd.org (Postfix) with SMTP id AA39613C4BF for ; Fri, 9 Feb 2007 00:07:51 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: (qmail 26586 invoked by uid 399); 9 Feb 2007 00:07:50 -0000 Received: from localhost (HELO ?192.168.0.4?) (dougb@dougbarton.us@127.0.0.1) by localhost with SMTP; 9 Feb 2007 00:07:50 -0000 X-Originating-IP: 127.0.0.1 Message-ID: <45CBBB4E.1030007@FreeBSD.org> Date: Thu, 08 Feb 2007 16:07:42 -0800 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 2.0b2 (Windows/20070116) MIME-Version: 1.0 To: Brooks Davis References: <20070205163646.GB48768@lor.one-eyed-alien.net> <45C75E1F.2070709@FreeBSD.org> <45C77AFD.1050801@FreeBSD.org> <45C77B9B.20403@FreeBSD.org> <20070205190220.GA51379@lor.one-eyed-alien.net> <45CB9C44.8010207@FreeBSD.org> <20070208224659.GA96852@lor.one-eyed-alien.net> <45CBB2A1.706@FreeBSD.org> <20070208234737.GA98583@lor.one-eyed-alien.net> <45CBB6B4.7050407@FreeBSD.org> <20070209000109.GA98754@lor.one-eyed-alien.net> In-Reply-To: <20070209000109.GA98754@lor.one-eyed-alien.net> X-Enigmail-Version: 0.94.2.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-bugs@FreeBSD.org, FreeBSD-gnats-submit@FreeBSD.org, freebsd-rc@FreeBSD.org, Norikatsu Shigemura , Florent Thoumie Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Feb 2007 00:07:52 -0000 Brooks Davis wrote: > On Thu, Feb 08, 2007 at 11:48:04PM +0000, Florent Thoumie wrote: >> Brooks Davis wrote: >>> On Thu, Feb 08, 2007 at 11:30:41PM +0000, Florent Thoumie wrote: >>>> Brooks Davis wrote: >>>>> On Thu, Feb 08, 2007 at 01:55:16PM -0800, Doug Barton wrote: >>>>>> Brooks Davis wrote: >>>>>> >>>>>>> The default should be an empty list which results in nothing happening. >>>>>>> I'd suggest making empty list the value for the default gif_interfaces >>>>>>> in /etc/defaults/rc.conf in both branches, removing support for NO in >>>>>>> CURRENT and emitting a warning in stable. >>>>>> How about issuing a warning for NO in both branches? Whether I agree >>>>>> with you or not on the importance of keeping things clean and >>>>>> consistent, I definitely do not want to err on the side of pedantry >>>>>> over usability. >>>>> That would be fine. I don't really care as long as it's deprecated. >>>>> >>>>> FWIW, only users who don't update /etc/defaults/rc.conf or who manually >>>>> set gif_interfaces="NO" would be effected so the size of the set of >>>>> effected users is probalby close to epilon and even all that will happen >>>>> is cloning an extra interface and then not configuring it so it should >>>>> be basicly harmless to just remove direct support for it. >>>> Fine with me as well. Should we make it a warning on RELENG_6 and an >>>> error on HEAD, or a warning on both. The former being be what I was >>>> planning to do, ie. remove support for "NO" in HEAD but issue a message >>>> saying semantics have changed. The latter would mean identical code in >>>> both HEAD and RELENG_6 (so "NO"-compatibility in both branches), but >>>> we'd need a reminder to remove this "NO"-support in HEAD once RELENG_7 >>>> is branched. >>> I'd say a warning in both. >> Re-reading Doug's message, he's probably thinking the same thing, but >> this is for gif_interfaces only, right? > > That's what I'd do. There's no reason to introduce support for an > instantly deprecated feature in a new variable, particularly since > gif_interfaces is the odd one out. Yes. Doug -- This .signature sanitized for your protection From owner-freebsd-rc@FreeBSD.ORG Fri Feb 9 00:10:34 2007 Return-Path: X-Original-To: freebsd-rc@hub.freebsd.org Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1ED2E16A400 for ; Fri, 9 Feb 2007 00:10:34 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id DC9D513C4B2 for ; Fri, 9 Feb 2007 00:10:33 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l190AXAb024218 for ; Fri, 9 Feb 2007 00:10:33 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l190AXss024217; Fri, 9 Feb 2007 00:10:33 GMT (envelope-from gnats) Date: Fri, 9 Feb 2007 00:10:33 GMT Message-Id: <200702090010.l190AXss024217@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org From: Brooks Davis Cc: Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Brooks Davis List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Feb 2007 00:10:34 -0000 The following reply was made to PR conf/104884; it has been noted by GNATS. From: Brooks Davis To: Florent Thoumie Cc: Brooks Davis , Doug Barton , Norikatsu Shigemura , freebsd-bugs@FreeBSD.org, FreeBSD-gnats-submit@FreeBSD.org, freebsd-rc@FreeBSD.org Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf Date: Thu, 8 Feb 2007 18:01:09 -0600 On Thu, Feb 08, 2007 at 11:48:04PM +0000, Florent Thoumie wrote: > Brooks Davis wrote: > > On Thu, Feb 08, 2007 at 11:30:41PM +0000, Florent Thoumie wrote: > >> Brooks Davis wrote: > >>> On Thu, Feb 08, 2007 at 01:55:16PM -0800, Doug Barton wrote: > >>>> Brooks Davis wrote: > >>>> > >>>>> The default should be an empty list which results in nothing happening. > >>>>> I'd suggest making empty list the value for the default gif_interfaces > >>>>> in /etc/defaults/rc.conf in both branches, removing support for NO in > >>>>> CURRENT and emitting a warning in stable. > >>>> How about issuing a warning for NO in both branches? Whether I agree > >>>> with you or not on the importance of keeping things clean and > >>>> consistent, I definitely do not want to err on the side of pedantry > >>>> over usability. > >>> That would be fine. I don't really care as long as it's deprecated. > >>> > >>> FWIW, only users who don't update /etc/defaults/rc.conf or who manually > >>> set gif_interfaces="NO" would be effected so the size of the set of > >>> effected users is probalby close to epilon and even all that will happen > >>> is cloning an extra interface and then not configuring it so it should > >>> be basicly harmless to just remove direct support for it. > >> Fine with me as well. Should we make it a warning on RELENG_6 and an > >> error on HEAD, or a warning on both. The former being be what I was > >> planning to do, ie. remove support for "NO" in HEAD but issue a message > >> saying semantics have changed. The latter would mean identical code in > >> both HEAD and RELENG_6 (so "NO"-compatibility in both branches), but > >> we'd need a reminder to remove this "NO"-support in HEAD once RELENG_7 > >> is branched. > > > > I'd say a warning in both. > > Re-reading Doug's message, he's probably thinking the same thing, but > this is for gif_interfaces only, right? That's what I'd do. There's no reason to introduce support for an instantly deprecated feature in a new variable, particularly since gif_interfaces is the odd one out. -- Brooks From owner-freebsd-rc@FreeBSD.ORG Fri Feb 9 00:11:01 2007 Return-Path: X-Original-To: freebsd-rc@hub.freebsd.org Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id DC2A416A40A for ; Fri, 9 Feb 2007 00:11:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id 7815113C4B2 for ; Fri, 9 Feb 2007 00:11:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l190B1kH024312 for ; Fri, 9 Feb 2007 00:11:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l190B1EP024311; Fri, 9 Feb 2007 00:11:01 GMT (envelope-from gnats) Date: Fri, 9 Feb 2007 00:11:01 GMT Message-Id: <200702090011.l190B1EP024311@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org From: Doug Barton Cc: Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Doug Barton List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Feb 2007 00:11:02 -0000 The following reply was made to PR conf/104884; it has been noted by GNATS. From: Doug Barton To: Brooks Davis Cc: Florent Thoumie , Norikatsu Shigemura , freebsd-bugs@FreeBSD.org, FreeBSD-gnats-submit@FreeBSD.org, freebsd-rc@FreeBSD.org Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf Date: Thu, 08 Feb 2007 16:07:42 -0800 Brooks Davis wrote: > On Thu, Feb 08, 2007 at 11:48:04PM +0000, Florent Thoumie wrote: >> Brooks Davis wrote: >>> On Thu, Feb 08, 2007 at 11:30:41PM +0000, Florent Thoumie wrote: >>>> Brooks Davis wrote: >>>>> On Thu, Feb 08, 2007 at 01:55:16PM -0800, Doug Barton wrote: >>>>>> Brooks Davis wrote: >>>>>> >>>>>>> The default should be an empty list which results in nothing happening. >>>>>>> I'd suggest making empty list the value for the default gif_interfaces >>>>>>> in /etc/defaults/rc.conf in both branches, removing support for NO in >>>>>>> CURRENT and emitting a warning in stable. >>>>>> How about issuing a warning for NO in both branches? Whether I agree >>>>>> with you or not on the importance of keeping things clean and >>>>>> consistent, I definitely do not want to err on the side of pedantry >>>>>> over usability. >>>>> That would be fine. I don't really care as long as it's deprecated. >>>>> >>>>> FWIW, only users who don't update /etc/defaults/rc.conf or who manually >>>>> set gif_interfaces="NO" would be effected so the size of the set of >>>>> effected users is probalby close to epilon and even all that will happen >>>>> is cloning an extra interface and then not configuring it so it should >>>>> be basicly harmless to just remove direct support for it. >>>> Fine with me as well. Should we make it a warning on RELENG_6 and an >>>> error on HEAD, or a warning on both. The former being be what I was >>>> planning to do, ie. remove support for "NO" in HEAD but issue a message >>>> saying semantics have changed. The latter would mean identical code in >>>> both HEAD and RELENG_6 (so "NO"-compatibility in both branches), but >>>> we'd need a reminder to remove this "NO"-support in HEAD once RELENG_7 >>>> is branched. >>> I'd say a warning in both. >> Re-reading Doug's message, he's probably thinking the same thing, but >> this is for gif_interfaces only, right? > > That's what I'd do. There's no reason to introduce support for an > instantly deprecated feature in a new variable, particularly since > gif_interfaces is the odd one out. Yes. Doug -- This .signature sanitized for your protection From owner-freebsd-rc@FreeBSD.ORG Fri Feb 9 00:23:29 2007 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 402A516A405; Fri, 9 Feb 2007 00:23:29 +0000 (UTC) (envelope-from flz@FreeBSD.org) Received: from smtp1-g19.free.fr (smtp1-g19.free.fr [212.27.42.27]) by mx1.freebsd.org (Postfix) with ESMTP id BDC5613C428; Fri, 9 Feb 2007 00:23:28 +0000 (UTC) (envelope-from flz@FreeBSD.org) Received: from smtp.xbsd.org (unknown [82.233.2.192]) by smtp1-g19.free.fr (Postfix) with ESMTP id 9160E3396; Fri, 9 Feb 2007 01:23:27 +0100 (CET) Received: from localhost (localhost.xbsd.org [127.0.0.1]) by smtp.xbsd.org (Postfix) with ESMTP id 31CC211B4F; Fri, 9 Feb 2007 01:23:26 +0100 (CET) X-Virus-Scanned: amavisd-new at xbsd.org Received: from smtp.xbsd.org ([127.0.0.1]) by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qcdEPffgllQp; Fri, 9 Feb 2007 01:23:19 +0100 (CET) Received: from [193.120.13.130] (cream.xbsd.org [193.120.13.130]) by smtp.xbsd.org (Postfix) with ESMTP id 0E0C1117C5; Fri, 9 Feb 2007 01:23:17 +0100 (CET) Message-ID: <45CBBDC9.3050708@FreeBSD.org> Date: Fri, 09 Feb 2007 00:18:17 +0000 From: Florent Thoumie User-Agent: Thunderbird 1.5.0.9 (X11/20070122) MIME-Version: 1.0 To: Doug Barton References: <20070205163646.GB48768@lor.one-eyed-alien.net> <45C75E1F.2070709@FreeBSD.org> <45C77AFD.1050801@FreeBSD.org> <45C77B9B.20403@FreeBSD.org> <20070205190220.GA51379@lor.one-eyed-alien.net> <45CB9C44.8010207@FreeBSD.org> <20070208224659.GA96852@lor.one-eyed-alien.net> <45CBB2A1.706@FreeBSD.org> <20070208234737.GA98583@lor.one-eyed-alien.net> <45CBB6B4.7050407@FreeBSD.org> <20070209000109.GA98754@lor.one-eyed-alien.net> <45CBBB4E.1030007@FreeBSD.org> In-Reply-To: <45CBBB4E.1030007@FreeBSD.org> X-Enigmail-Version: 0.94.1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig59D108A34FC56C76D5FE6DA7" Cc: freebsd-bugs@FreeBSD.org, Brooks Davis , freebsd-rc@FreeBSD.org, Norikatsu Shigemura , FreeBSD-gnats-submit@FreeBSD.org Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Feb 2007 00:23:29 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig59D108A34FC56C76D5FE6DA7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Doug Barton wrote: > Brooks Davis wrote: >> On Thu, Feb 08, 2007 at 11:48:04PM +0000, Florent Thoumie wrote: >>> Brooks Davis wrote: >>>> On Thu, Feb 08, 2007 at 11:30:41PM +0000, Florent Thoumie wrote: >>>>> Brooks Davis wrote: >>>>>> On Thu, Feb 08, 2007 at 01:55:16PM -0800, Doug Barton wrote: >>>>>>> Brooks Davis wrote: >>>>>>> >>>>>>>> The default should be an empty list which results in nothing hap= pening. >>>>>>>> I'd suggest making empty list the value for the default gif_inte= rfaces >>>>>>>> in /etc/defaults/rc.conf in both branches, removing support for = NO in >>>>>>>> CURRENT and emitting a warning in stable. >>>>>>> How about issuing a warning for NO in both branches? Whether I ag= ree >>>>>>> with you or not on the importance of keeping things clean and >>>>>>> consistent, I definitely do not want to err on the side of pedant= ry >>>>>>> over usability. >>>>>> That would be fine. I don't really care as long as it's deprecate= d. >>>>>> >>>>>> FWIW, only users who don't update /etc/defaults/rc.conf or who man= ually >>>>>> set gif_interfaces=3D"NO" would be effected so the size of the set= of >>>>>> effected users is probalby close to epilon and even all that will = happen >>>>>> is cloning an extra interface and then not configuring it so it sh= ould >>>>>> be basicly harmless to just remove direct support for it. >>>>> Fine with me as well. Should we make it a warning on RELENG_6 and a= n >>>>> error on HEAD, or a warning on both. The former being be what I was= >>>>> planning to do, ie. remove support for "NO" in HEAD but issue a mes= sage >>>>> saying semantics have changed. The latter would mean identical code= in >>>>> both HEAD and RELENG_6 (so "NO"-compatibility in both branches), bu= t >>>>> we'd need a reminder to remove this "NO"-support in HEAD once RELEN= G_7 >>>>> is branched. >>>> I'd say a warning in both. >>> Re-reading Doug's message, he's probably thinking the same thing, but= >>> this is for gif_interfaces only, right? >> That's what I'd do. There's no reason to introduce support for an >> instantly deprecated feature in a new variable, particularly since >> gif_interfaces is the odd one out. >=20 > Yes. Here's the updated network.subr diff: http://people.freebsd.org/~flz/local/netsubr.diff --=20 Florent Thoumie flz@FreeBSD.org FreeBSD Committer --------------enig59D108A34FC56C76D5FE6DA7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFFy73OMxEkbVFH3PQRCrb0AJ93RAfQtJBEaN+vnZYfNX9ZITYvTgCfQ9FQ 68/45jWOhtBJHWxpAsleAmE= =ArTm -----END PGP SIGNATURE----- --------------enig59D108A34FC56C76D5FE6DA7-- From owner-freebsd-rc@FreeBSD.ORG Fri Feb 9 00:26:00 2007 Return-Path: X-Original-To: rc@freebsd.org Delivered-To: freebsd-rc@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1121016A400; Fri, 9 Feb 2007 00:26:00 +0000 (UTC) (envelope-from flz@FreeBSD.org) Received: from smtp8-g19.free.fr (smtp8-g19.free.fr [212.27.42.65]) by mx1.freebsd.org (Postfix) with ESMTP id 9AC0A13C48E; Fri, 9 Feb 2007 00:25:59 +0000 (UTC) (envelope-from flz@FreeBSD.org) Received: from smtp.xbsd.org (unknown [82.233.2.192]) by smtp8-g19.free.fr (Postfix) with ESMTP id B3B1F54AA; Fri, 9 Feb 2007 01:25:58 +0100 (CET) Received: from localhost (localhost.xbsd.org [127.0.0.1]) by smtp.xbsd.org (Postfix) with ESMTP id 31EFA11B4F; Fri, 9 Feb 2007 01:25:58 +0100 (CET) X-Virus-Scanned: amavisd-new at xbsd.org Received: from smtp.xbsd.org ([127.0.0.1]) by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2HnWyaTIzRMf; Fri, 9 Feb 2007 01:25:53 +0100 (CET) Received: from [193.120.13.130] (cream.xbsd.org [193.120.13.130]) by smtp.xbsd.org (Postfix) with ESMTP id 72BBE117C5; Fri, 9 Feb 2007 01:25:52 +0100 (CET) Message-ID: <45CBBE8A.4030901@FreeBSD.org> Date: Fri, 09 Feb 2007 00:21:30 +0000 From: Florent Thoumie User-Agent: Thunderbird 1.5.0.9 (X11/20070122) MIME-Version: 1.0 To: Florent Thoumie References: <45B36737.6080208@FreeBSD.org> <45B3A899.2060207@FreeBSD.org> In-Reply-To: <45B3A899.2060207@FreeBSD.org> X-Enigmail-Version: 0.94.1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig8C38EB8EA33C1B72B0F9EBAD" Cc: Andrew Pantyukhin , rc@freebsd.org Subject: Re: Service-specific default locales X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Feb 2007 00:26:00 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig8C38EB8EA33C1B72B0F9EBAD Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Florent Thoumie wrote: > Florent Thoumie wrote: >> Andrew Pantyukhin wrote: >>> I need to run different services in different locales >>> (basically LANG/LC_ALL changed). Before I look at how >>> to implement it, is there any objection to >>> _locale presetting the two variables to its >>> value (and possibly some error-checking via locale(1)? >>> >>> As for a site-wide default, I currently have "export >>> LANG=3Den_US.UTF-8" in my rc.conf. Should we introduce >>> a general "locale" variable for this? >> Makes sense to me. Have a look at *_nice variable for example. >=20 > Thinking about it, maybe something like _env would be better > (cause more generic). Of course you wouldn't be able to do error > checking but I'm not sure it's so useful anyway. Any update on that, do you need help or something? --=20 Florent Thoumie flz@FreeBSD.org FreeBSD Committer --------------enig8C38EB8EA33C1B72B0F9EBAD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFFy76KMxEkbVFH3PQRCqnGAJ4wN0yVZKN2L/MCZgQp6u/m/iXGzgCZAeJz zt8ddSPoG3ebWNzSm3UpcpA= =SbW2 -----END PGP SIGNATURE----- --------------enig8C38EB8EA33C1B72B0F9EBAD-- From owner-freebsd-rc@FreeBSD.ORG Fri Feb 9 00:30:26 2007 Return-Path: X-Original-To: freebsd-rc@hub.freebsd.org Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9A5A316A400 for ; Fri, 9 Feb 2007 00:30:26 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id 8B39813C481 for ; Fri, 9 Feb 2007 00:30:26 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l190UQYD025112 for ; Fri, 9 Feb 2007 00:30:26 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l190UQa9025111; Fri, 9 Feb 2007 00:30:26 GMT (envelope-from gnats) Date: Fri, 9 Feb 2007 00:30:26 GMT Message-Id: <200702090030.l190UQa9025111@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org From: Florent Thoumie Cc: Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Florent Thoumie List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Feb 2007 00:30:26 -0000 The following reply was made to PR conf/104884; it has been noted by GNATS. From: Florent Thoumie To: Doug Barton Cc: Brooks Davis , Norikatsu Shigemura , freebsd-bugs@FreeBSD.org, FreeBSD-gnats-submit@FreeBSD.org, freebsd-rc@FreeBSD.org Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf Date: Fri, 09 Feb 2007 00:18:17 +0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig59D108A34FC56C76D5FE6DA7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Doug Barton wrote: > Brooks Davis wrote: >> On Thu, Feb 08, 2007 at 11:48:04PM +0000, Florent Thoumie wrote: >>> Brooks Davis wrote: >>>> On Thu, Feb 08, 2007 at 11:30:41PM +0000, Florent Thoumie wrote: >>>>> Brooks Davis wrote: >>>>>> On Thu, Feb 08, 2007 at 01:55:16PM -0800, Doug Barton wrote: >>>>>>> Brooks Davis wrote: >>>>>>> >>>>>>>> The default should be an empty list which results in nothing hap= pening. >>>>>>>> I'd suggest making empty list the value for the default gif_inte= rfaces >>>>>>>> in /etc/defaults/rc.conf in both branches, removing support for = NO in >>>>>>>> CURRENT and emitting a warning in stable. >>>>>>> How about issuing a warning for NO in both branches? Whether I ag= ree >>>>>>> with you or not on the importance of keeping things clean and >>>>>>> consistent, I definitely do not want to err on the side of pedant= ry >>>>>>> over usability. >>>>>> That would be fine. I don't really care as long as it's deprecate= d. >>>>>> >>>>>> FWIW, only users who don't update /etc/defaults/rc.conf or who man= ually >>>>>> set gif_interfaces=3D"NO" would be effected so the size of the set= of >>>>>> effected users is probalby close to epilon and even all that will = happen >>>>>> is cloning an extra interface and then not configuring it so it sh= ould >>>>>> be basicly harmless to just remove direct support for it. >>>>> Fine with me as well. Should we make it a warning on RELENG_6 and a= n >>>>> error on HEAD, or a warning on both. The former being be what I was= >>>>> planning to do, ie. remove support for "NO" in HEAD but issue a mes= sage >>>>> saying semantics have changed. The latter would mean identical code= in >>>>> both HEAD and RELENG_6 (so "NO"-compatibility in both branches), bu= t >>>>> we'd need a reminder to remove this "NO"-support in HEAD once RELEN= G_7 >>>>> is branched. >>>> I'd say a warning in both. >>> Re-reading Doug's message, he's probably thinking the same thing, but= >>> this is for gif_interfaces only, right? >> That's what I'd do. There's no reason to introduce support for an >> instantly deprecated feature in a new variable, particularly since >> gif_interfaces is the odd one out. >=20 > Yes. Here's the updated network.subr diff: http://people.freebsd.org/~flz/local/netsubr.diff --=20 Florent Thoumie flz@FreeBSD.org FreeBSD Committer --------------enig59D108A34FC56C76D5FE6DA7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFFy73OMxEkbVFH3PQRCrb0AJ93RAfQtJBEaN+vnZYfNX9ZITYvTgCfQ9FQ 68/45jWOhtBJHWxpAsleAmE= =ArTm -----END PGP SIGNATURE----- --------------enig59D108A34FC56C76D5FE6DA7-- From owner-freebsd-rc@FreeBSD.ORG Fri Feb 9 01:17:25 2007 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AD68316A406; Fri, 9 Feb 2007 01:17:25 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (grnl-static-02-0046.dsl.iowatelecom.net [69.66.56.110]) by mx1.freebsd.org (Postfix) with ESMTP id 560B713C4B8; Fri, 9 Feb 2007 01:17:25 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.13.8/8.13.8) with ESMTP id l191HOuC099462; Thu, 8 Feb 2007 19:17:24 -0600 (CST) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.13.8/8.13.8/Submit) id l191HOhC099461; Thu, 8 Feb 2007 19:17:24 -0600 (CST) (envelope-from brooks) Date: Thu, 8 Feb 2007 19:17:24 -0600 From: Brooks Davis To: Florent Thoumie Message-ID: <20070209011724.GA99453@lor.one-eyed-alien.net> References: <45C77B9B.20403@FreeBSD.org> <20070205190220.GA51379@lor.one-eyed-alien.net> <45CB9C44.8010207@FreeBSD.org> <20070208224659.GA96852@lor.one-eyed-alien.net> <45CBB2A1.706@FreeBSD.org> <20070208234737.GA98583@lor.one-eyed-alien.net> <45CBB6B4.7050407@FreeBSD.org> <20070209000109.GA98754@lor.one-eyed-alien.net> <45CBBB4E.1030007@FreeBSD.org> <45CBBDC9.3050708@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <45CBBDC9.3050708@FreeBSD.org> User-Agent: Mutt/1.5.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (lor.one-eyed-alien.net [127.0.0.1]); Thu, 08 Feb 2007 19:17:24 -0600 (CST) Cc: freebsd-bugs@FreeBSD.org, Doug Barton , freebsd-rc@FreeBSD.org, Norikatsu Shigemura , Brooks Davis , FreeBSD-gnats-submit@FreeBSD.org Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Feb 2007 01:17:25 -0000 On Fri, Feb 09, 2007 at 12:18:17AM +0000, Florent Thoumie wrote: > Doug Barton wrote: > > Brooks Davis wrote: > >> On Thu, Feb 08, 2007 at 11:48:04PM +0000, Florent Thoumie wrote: > >>> Brooks Davis wrote: > >>>> On Thu, Feb 08, 2007 at 11:30:41PM +0000, Florent Thoumie wrote: > >>>>> Brooks Davis wrote: > >>>>>> On Thu, Feb 08, 2007 at 01:55:16PM -0800, Doug Barton wrote: > >>>>>>> Brooks Davis wrote: > >>>>>>> > >>>>>>>> The default should be an empty list which results in nothing happening. > >>>>>>>> I'd suggest making empty list the value for the default gif_interfaces > >>>>>>>> in /etc/defaults/rc.conf in both branches, removing support for NO in > >>>>>>>> CURRENT and emitting a warning in stable. > >>>>>>> How about issuing a warning for NO in both branches? Whether I agree > >>>>>>> with you or not on the importance of keeping things clean and > >>>>>>> consistent, I definitely do not want to err on the side of pedantry > >>>>>>> over usability. > >>>>>> That would be fine. I don't really care as long as it's deprecated. > >>>>>> > >>>>>> FWIW, only users who don't update /etc/defaults/rc.conf or who manually > >>>>>> set gif_interfaces="NO" would be effected so the size of the set of > >>>>>> effected users is probalby close to epilon and even all that will happen > >>>>>> is cloning an extra interface and then not configuring it so it should > >>>>>> be basicly harmless to just remove direct support for it. > >>>>> Fine with me as well. Should we make it a warning on RELENG_6 and an > >>>>> error on HEAD, or a warning on both. The former being be what I was > >>>>> planning to do, ie. remove support for "NO" in HEAD but issue a message > >>>>> saying semantics have changed. The latter would mean identical code in > >>>>> both HEAD and RELENG_6 (so "NO"-compatibility in both branches), but > >>>>> we'd need a reminder to remove this "NO"-support in HEAD once RELENG_7 > >>>>> is branched. > >>>> I'd say a warning in both. > >>> Re-reading Doug's message, he's probably thinking the same thing, but > >>> this is for gif_interfaces only, right? > >> That's what I'd do. There's no reason to introduce support for an > >> instantly deprecated feature in a new variable, particularly since > >> gif_interfaces is the odd one out. > > > > Yes. > > Here's the updated network.subr diff: > > http://people.freebsd.org/~flz/local/netsubr.diff Looks good to me. -- Brooks From owner-freebsd-rc@FreeBSD.ORG Fri Feb 9 01:20:22 2007 Return-Path: X-Original-To: freebsd-rc@hub.freebsd.org Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 669F516A402 for ; Fri, 9 Feb 2007 01:20:22 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id 3F1AA13C4A7 for ; Fri, 9 Feb 2007 01:20:22 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l191KLhf029059 for ; Fri, 9 Feb 2007 01:20:21 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l191KLsb029058; Fri, 9 Feb 2007 01:20:21 GMT (envelope-from gnats) Date: Fri, 9 Feb 2007 01:20:21 GMT Message-Id: <200702090120.l191KLsb029058@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org From: Brooks Davis Cc: Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Brooks Davis List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Feb 2007 01:20:22 -0000 The following reply was made to PR conf/104884; it has been noted by GNATS. From: Brooks Davis To: Florent Thoumie Cc: Doug Barton , Brooks Davis , Norikatsu Shigemura , freebsd-bugs@FreeBSD.org, FreeBSD-gnats-submit@FreeBSD.org, freebsd-rc@FreeBSD.org Subject: Re: conf/104884: Add support EtherChannel configuration to rc.conf Date: Thu, 8 Feb 2007 19:17:24 -0600 On Fri, Feb 09, 2007 at 12:18:17AM +0000, Florent Thoumie wrote: > Doug Barton wrote: > > Brooks Davis wrote: > >> On Thu, Feb 08, 2007 at 11:48:04PM +0000, Florent Thoumie wrote: > >>> Brooks Davis wrote: > >>>> On Thu, Feb 08, 2007 at 11:30:41PM +0000, Florent Thoumie wrote: > >>>>> Brooks Davis wrote: > >>>>>> On Thu, Feb 08, 2007 at 01:55:16PM -0800, Doug Barton wrote: > >>>>>>> Brooks Davis wrote: > >>>>>>> > >>>>>>>> The default should be an empty list which results in nothing happening. > >>>>>>>> I'd suggest making empty list the value for the default gif_interfaces > >>>>>>>> in /etc/defaults/rc.conf in both branches, removing support for NO in > >>>>>>>> CURRENT and emitting a warning in stable. > >>>>>>> How about issuing a warning for NO in both branches? Whether I agree > >>>>>>> with you or not on the importance of keeping things clean and > >>>>>>> consistent, I definitely do not want to err on the side of pedantry > >>>>>>> over usability. > >>>>>> That would be fine. I don't really care as long as it's deprecated. > >>>>>> > >>>>>> FWIW, only users who don't update /etc/defaults/rc.conf or who manually > >>>>>> set gif_interfaces="NO" would be effected so the size of the set of > >>>>>> effected users is probalby close to epilon and even all that will happen > >>>>>> is cloning an extra interface and then not configuring it so it should > >>>>>> be basicly harmless to just remove direct support for it. > >>>>> Fine with me as well. Should we make it a warning on RELENG_6 and an > >>>>> error on HEAD, or a warning on both. The former being be what I was > >>>>> planning to do, ie. remove support for "NO" in HEAD but issue a message > >>>>> saying semantics have changed. The latter would mean identical code in > >>>>> both HEAD and RELENG_6 (so "NO"-compatibility in both branches), but > >>>>> we'd need a reminder to remove this "NO"-support in HEAD once RELENG_7 > >>>>> is branched. > >>>> I'd say a warning in both. > >>> Re-reading Doug's message, he's probably thinking the same thing, but > >>> this is for gif_interfaces only, right? > >> That's what I'd do. There's no reason to introduce support for an > >> instantly deprecated feature in a new variable, particularly since > >> gif_interfaces is the odd one out. > > > > Yes. > > Here's the updated network.subr diff: > > http://people.freebsd.org/~flz/local/netsubr.diff Looks good to me. -- Brooks From owner-freebsd-rc@FreeBSD.ORG Fri Feb 9 01:21:02 2007 Return-Path: X-Original-To: rc@freebsd.org Delivered-To: freebsd-rc@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9B33716A400 for ; Fri, 9 Feb 2007 01:21:02 +0000 (UTC) (envelope-from infofarmer@gmail.com) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.168]) by mx1.freebsd.org (Postfix) with ESMTP id 376E613C46B for ; Fri, 9 Feb 2007 01:21:02 +0000 (UTC) (envelope-from infofarmer@gmail.com) Received: by ug-out-1314.google.com with SMTP id o2so598832uge for ; Thu, 08 Feb 2007 17:21:01 -0800 (PST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=OG7tyNsv0Xf8ZdZ/SOfl0Fyj4E3U/5Q+4mGuwC3KUvGLwmZjE1c4+7IabB8S5IewS6E58un/z9jkU/TryWAJZRSmNR1hnq9zZW/V2JtRfjER7+wRu7vsn/6OQaI1DN7IO+0VavA4nggZ7jODv3qVj40bivLJvVU7n1s9LrL+qzo= Received: by 10.78.166.7 with SMTP id o7mr4744182hue.1170984061055; Thu, 08 Feb 2007 17:21:01 -0800 (PST) Received: by 10.78.164.20 with HTTP; Thu, 8 Feb 2007 17:21:01 -0800 (PST) Message-ID: Date: Fri, 9 Feb 2007 04:21:01 +0300 From: "Andrew Pantyukhin" Sender: infofarmer@gmail.com To: "Florent Thoumie" In-Reply-To: <45CBBE8A.4030901@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <45B36737.6080208@FreeBSD.org> <45B3A899.2060207@FreeBSD.org> <45CBBE8A.4030901@FreeBSD.org> X-Google-Sender-Auth: 0888b6e981095873 Cc: rc@freebsd.org Subject: Re: Service-specific default locales X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Feb 2007 01:21:02 -0000 On 2/9/07, Florent Thoumie wrote: > Florent Thoumie wrote: > > Florent Thoumie wrote: > >> Andrew Pantyukhin wrote: > >>> I need to run different services in different locales > >>> (basically LANG/LC_ALL changed). Before I look at how > >>> to implement it, is there any objection to > >>> _locale presetting the two variables to its > >>> value (and possibly some error-checking via locale(1)? > >>> > >>> As for a site-wide default, I currently have "export > >>> LANG=en_US.UTF-8" in my rc.conf. Should we introduce > >>> a general "locale" variable for this? > >> Makes sense to me. Have a look at *_nice variable for example. > > > > Thinking about it, maybe something like _env would be better > > (cause more generic). Of course you wouldn't be able to do error > > checking but I'm not sure it's so useful anyway. > > Any update on that, do you need help or something? I solved my immediate problem through hacks even before posting here, so a good implementation is not exactly at the top of my todo list. I'll be happy to see it done by someone else, otherwise I'll get to it myself later. From owner-freebsd-rc@FreeBSD.ORG Fri Feb 9 12:14:08 2007 Return-Path: X-Original-To: freebsd-rc@hub.freebsd.org Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7AA1D16A403; Fri, 9 Feb 2007 12:14:08 +0000 (UTC) (envelope-from flz@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id 5488813C441; Fri, 9 Feb 2007 12:14:08 +0000 (UTC) (envelope-from flz@FreeBSD.org) Received: from freefall.freebsd.org (flz@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l19CE8ha080066; Fri, 9 Feb 2007 12:14:08 GMT (envelope-from flz@freefall.freebsd.org) Received: (from flz@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l19CE8So080062; Fri, 9 Feb 2007 12:14:08 GMT (envelope-from flz) Date: Fri, 9 Feb 2007 12:14:08 GMT From: Florent Thoumie Message-Id: <200702091214.l19CE8So080062@freefall.freebsd.org> To: nork@FreeBSD.org, flz@FreeBSD.org, freebsd-rc@FreeBSD.org Cc: Subject: Re: conf/104884: [patch] Add support EtherChannel configuration to rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Feb 2007 12:14:08 -0000 Synopsis: [patch] Add support EtherChannel configuration to rc.conf State-Changed-From-To: open->patched State-Changed-By: flz State-Changed-When: Fri Feb 9 12:13:28 UTC 2007 State-Changed-Why: Committed to HEAD, MFC after ... well a few weeks. http://www.freebsd.org/cgi/query-pr.cgi?pr=104884 From owner-freebsd-rc@FreeBSD.ORG Fri Feb 9 12:14:32 2007 Return-Path: X-Original-To: freebsd-rc@hub.freebsd.org Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A5AF916A401; Fri, 9 Feb 2007 12:14:32 +0000 (UTC) (envelope-from flz@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id 7F96113C481; Fri, 9 Feb 2007 12:14:32 +0000 (UTC) (envelope-from flz@FreeBSD.org) Received: from freefall.freebsd.org (flz@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l19CEWwY080155; Fri, 9 Feb 2007 12:14:32 GMT (envelope-from flz@freefall.freebsd.org) Received: (from flz@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l19CEWcJ080151; Fri, 9 Feb 2007 12:14:32 GMT (envelope-from flz) Date: Fri, 9 Feb 2007 12:14:32 GMT From: Florent Thoumie Message-Id: <200702091214.l19CEWcJ080151@freefall.freebsd.org> To: flz@FreeBSD.org, freebsd-rc@FreeBSD.org, flz@FreeBSD.org Cc: Subject: Re: conf/104884: [patch] Add support EtherChannel configuration to rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Feb 2007 12:14:32 -0000 Synopsis: [patch] Add support EtherChannel configuration to rc.conf Responsible-Changed-From-To: freebsd-rc->flz Responsible-Changed-By: flz Responsible-Changed-When: Fri Feb 9 12:14:31 UTC 2007 Responsible-Changed-Why: I'll take care of the MFC/ http://www.freebsd.org/cgi/query-pr.cgi?pr=104884 From owner-freebsd-rc@FreeBSD.ORG Fri Feb 9 12:15:07 2007 Return-Path: X-Original-To: freebsd-rc@hub.freebsd.org Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id DB0DC16A405; Fri, 9 Feb 2007 12:15:07 +0000 (UTC) (envelope-from flz@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id B544913C461; Fri, 9 Feb 2007 12:15:07 +0000 (UTC) (envelope-from flz@FreeBSD.org) Received: from freefall.freebsd.org (flz@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l19CF7IE080279; Fri, 9 Feb 2007 12:15:07 GMT (envelope-from flz@freefall.freebsd.org) Received: (from flz@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l19CF79B080275; Fri, 9 Feb 2007 12:15:07 GMT (envelope-from flz) Date: Fri, 9 Feb 2007 12:15:07 GMT From: Florent Thoumie Message-Id: <200702091215.l19CF79B080275@freefall.freebsd.org> To: flz@FreeBSD.org, freebsd-rc@FreeBSD.org, flz@FreeBSD.org Cc: Subject: Re: conf/104884: [patch] Add support EtherChannel configuration to rc.conf X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Feb 2007 12:15:07 -0000 Synopsis: [patch] Add support EtherChannel configuration to rc.conf Responsible-Changed-From-To: freebsd-rc->flz Responsible-Changed-By: flz Responsible-Changed-When: Fri Feb 9 12:15:06 UTC 2007 Responsible-Changed-Why: I'll take care of the MFC. http://www.freebsd.org/cgi/query-pr.cgi?pr=104884 From owner-freebsd-rc@FreeBSD.ORG Fri Feb 9 21:39:19 2007 Return-Path: X-Original-To: freebsd-rc@hub.freebsd.org Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 168AA16A409; Fri, 9 Feb 2007 21:39:19 +0000 (UTC) (envelope-from linimon@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id E2EE713C4A5; Fri, 9 Feb 2007 21:39:18 +0000 (UTC) (envelope-from linimon@FreeBSD.org) Received: from freefall.freebsd.org (linimon@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l19LdIHP028793; Fri, 9 Feb 2007 21:39:18 GMT (envelope-from linimon@freefall.freebsd.org) Received: (from linimon@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l19LdI4Y028789; Fri, 9 Feb 2007 21:39:18 GMT (envelope-from linimon) Date: Fri, 9 Feb 2007 21:39:18 GMT From: Mark Linimon Message-Id: <200702092139.l19LdI4Y028789@freefall.freebsd.org> To: linimon@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-rc@FreeBSD.org Cc: Subject: Re: conf/108988: [patch] RELENG_6_2 rc.d/jail unaliases incorrectly, on failed startup X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Feb 2007 21:39:19 -0000 Synopsis: [patch] RELENG_6_2 rc.d/jail unaliases incorrectly, on failed startup Responsible-Changed-From-To: freebsd-bugs->freebsd-rc Responsible-Changed-By: linimon Responsible-Changed-When: Fri Feb 9 21:38:36 UTC 2007 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=108988 From owner-freebsd-rc@FreeBSD.ORG Sat Feb 10 00:40:13 2007 Return-Path: X-Original-To: freebsd-rc@hub.freebsd.org Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A073616A400 for ; Sat, 10 Feb 2007 00:40:13 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id 5F81C13C47E for ; Sat, 10 Feb 2007 00:40:13 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l1A0eCPJ041548 for ; Sat, 10 Feb 2007 00:40:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l1A0eC1H041543; Sat, 10 Feb 2007 00:40:12 GMT (envelope-from gnats) Date: Sat, 10 Feb 2007 00:40:12 GMT Message-Id: <200702100040.l1A0eC1H041543@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org From: "Simon L. Nielsen" Cc: Subject: Re: conf/108988: [patch] RELENG_6_2 rc.d/jail unaliases incorrectly, on failed startup X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: "Simon L. Nielsen" List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Feb 2007 00:40:13 -0000 The following reply was made to PR conf/108988; it has been noted by GNATS. From: "Simon L. Nielsen" To: freebsd-gnats-submit@FreeBSD.org Cc: Subject: Re: conf/108988: [patch] RELENG_6_2 rc.d/jail unaliases incorrectly, on failed startup Date: Sat, 10 Feb 2007 01:13:14 +0100 Hey, Note that this was fixed in src/etc/rc.d/jail 1.35 and have been MFC'ed to RELENG_6 some time ago, but it didn't make it into 6.2. If somebody cares enough (I don't) they might convince re@ to make this an Errata. -- Simon L. Nielsen