From owner-freebsd-perl@FreeBSD.ORG Sun Mar 18 05:07:57 2012 Return-Path: Delivered-To: perl@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B7046106564A; Sun, 18 Mar 2012 05:07:57 +0000 (UTC) (envelope-from prvs=417e1e0f2=pauls@utdallas.edu) Received: from ip-relay-001.utdallas.edu (ip-relay-001.utdallas.edu [129.110.20.111]) by mx1.freebsd.org (Postfix) with ESMTP id 77B828FC08; Sun, 18 Mar 2012 05:07:57 +0000 (UTC) X-Group: RELAYLIST X-IronPort-AV: E=Sophos;i="4.73,605,1325484000"; d="scan'208";a="93628318" Received: from unknown (HELO mx31.utdallas.edu) ([10.110.20.31]) by ip-relay-001.utdallas.edu with ESMTP; 18 Mar 2012 00:06:48 -0500 Received: from UTDEX27.campus.ad.utdallas.edu (utdex27.utdallas.edu [10.180.14.54]) by mx31.utdallas.edu (Postfix) with ESMTP id 0F5C64284D; Sun, 18 Mar 2012 00:06:48 -0500 (CDT) Received: from UTDEX23.campus.ad.utdallas.edu ([169.254.2.146]) by UTDEX27.campus.ad.utdallas.edu ([10.180.14.54]) with mapi id 14.01.0339.001; Sun, 18 Mar 2012 00:06:47 -0500 From: "Schmehl, Paul L" To: Steve Wills Thread-Topic: ports/165826: [PATCH] net/p5-Net-Nessus-XMLRPC: add missing DEPENDS Thread-Index: AQHNBJC1XyRwxus/IUmlmoy+6Dfa35ZvgIAr Date: Sun, 18 Mar 2012 05:06:47 +0000 Message-ID: References: <201203071740.q27HeCFT018574@freefall.freebsd.org>, <4F6515CC.8000807@FreeBSD.org> In-Reply-To: <4F6515CC.8000807@FreeBSD.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.100.40.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "perl@FreeBSD.org" Subject: RE: ports/165826: [PATCH] net/p5-Net-Nessus-XMLRPC: add missing DEPENDS X-BeenThere: freebsd-perl@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: maintainer of a number of perl-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Mar 2012 05:07:57 -0000 ________________________________________=0A= From: Steve Wills [swills@FreeBSD.org]=0A= Sent: Saturday, March 17, 2012 5:53 PM=0A= To: Schmehl, Paul L=0A= Cc: perl@FreeBSD.org=0A= Subject: Re: ports/165826: [PATCH] net/p5-Net-Nessus-XMLRPC: add missing DE= PENDS=0A= =0A= On 03/07/12 12:40, Paul Schmehl wrote:=0A= >=0A= > According to the CPAN page=0A= > (),=0A= > only IO::Socket::SSL is required (and in FreeBSD, Net::SSL is a RUN_DEPE= NDS=0A= > for IO::Socket::SSL. anyway.)=0A= >=0A= > "'This CPAN module uses LWP for communicating with Nessus over XMLRPC vi= a=0A= > https. Therefore, make sure that you have Net::SSL (provided by=0A= > Crypt::SSLeay): http://search.cpan.org/perldoc?Crypt::SSLeay or=0A= > IO::Socket::SSL: http://search.cpan.org/perldoc?IO::Socket::SSL"=0A= >=0A= > If you want to argue that LWP is a RUN_DEPENDS, I can see that, but why= =0A= > HTML::Message and XML::Simple? Why does the author think these other=0A= > modules are required?=0A= >=0A= > I need more information before making this change.=0A= =0A= Unfortunately, the documentation doesn't match the code. I found these=0A= by running "make test" with just the package installed (in a chroot).=0A= Looking at the code:=0A= =0A= ./work/Net-Nessus-XMLRPC-0.30/lib/Net/Nessus/XMLRPC.pm:use=0A= HTTP::Request::Common;=0A= =0A= hence the dep on HTML::Message. Similarly:=0A= =0A= ./work/Net-Nessus-XMLRPC-0.30/lib/Net/Nessus/XMLRPC.pm:use XML::Simple;=0A= =0A= hence the dep on XML::Simple.=0A= =0A= > Even if these other modules were required, they wouldn't be BUILD_DEPEND= S,=0A= > they would be RUN_DEPENDS, so the patch would need to be corrected for t= hat.=0A= =0A= The "build" will complain that these modules are missing at build time:=0A= =0A= =3D=3D=3D> Configuring for p5-Net-Nessus-XMLRPC-0.30=0A= Warning: prerequisite HTTP::Request::Common 0 not found.=0A= Warning: prerequisite LWP::UserAgent 0 not found.=0A= Warning: prerequisite XML::Simple 0 not found.=0A= =0A= I like to avoid those warnings so that if, for example, an update to the=0A= module requires a new module I can see it easily instead of comparing=0A= that list to the RUN_DEPENDS to see if any are missing.=0A= =0A= >From a package standpoint it makes no difference if they're also=0A= BUILD_DEPENDS because they're going to be RUN_DEPENDS anyway and from a=0A= ports (building from source) perspective, it's cleaner, easier to see=0A= new depends, let's you run "make test" if you want and less worrisome=0A= for the uninformed.=0A= =0A= Steve=0A= =0A= Makes perfect sense. I approve the changes.=0A=