From owner-svn-src-stable-8@FreeBSD.ORG Sun Sep 23 14:50:02 2012 Return-Path: Delivered-To: svn-src-stable-8@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 571951065680; Sun, 23 Sep 2012 14:50:02 +0000 (UTC) (envelope-from zeising@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 3DA888FC0C; Sun, 23 Sep 2012 14:50:02 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q8NEo2AZ020635; Sun, 23 Sep 2012 14:50:02 GMT (envelope-from zeising@svn.freebsd.org) Received: (from zeising@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id q8NEo26s020633; Sun, 23 Sep 2012 14:50:02 GMT (envelope-from zeising@svn.freebsd.org) Message-Id: <201209231450.q8NEo26s020633@svn.freebsd.org> From: Niclas Zeising Date: Sun, 23 Sep 2012 14:50:02 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org X-SVN-Group: stable-8 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r240859 - stable/8/share/man/man4 X-BeenThere: svn-src-stable-8@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 8-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Sep 2012 14:50:02 -0000 Author: zeising (doc,ports committer) Date: Sun Sep 23 14:50:01 2012 New Revision: 240859 URL: http://svn.freebsd.org/changeset/base/240859 Log: MFC r240205: Change the link pointing to more information about the Yarrow algorithm, the current link points to a irrelevant catchall site. PR: docs/171411 Submitted by: Mark Martinec (pr), zeising (patch) Approved by: joel (mentor) Modified: stable/8/share/man/man4/random.4 Directory Properties: stable/8/share/man/man4/ (props changed) Modified: stable/8/share/man/man4/random.4 ============================================================================== --- stable/8/share/man/man4/random.4 Sun Sep 23 14:49:28 2012 (r240858) +++ stable/8/share/man/man4/random.4 Sun Sep 23 14:50:01 2012 (r240859) @@ -23,7 +23,7 @@ .\" .\" $FreeBSD$ .\" -.Dd July 19, 2006 +.Dd September 7, 2012 .Dt RANDOM 4 .Os .Sh NAME @@ -143,7 +143,7 @@ if you wish to use them for entropy harv The other variables are explained in the paper describing the .Em Yarrow algorithm at -.Pa http://www.counterpane.com/yarrow.html . +.Pa http://www.schneier.com/yarrow.html . .Pp These variables are all limited in terms of the values they may contain: From owner-svn-src-stable-8@FreeBSD.ORG Sun Sep 23 20:16:17 2012 Return-Path: Delivered-To: svn-src-stable-8@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A6F391065670; Sun, 23 Sep 2012 20:16:17 +0000 (UTC) (envelope-from sbruno@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 91E118FC12; Sun, 23 Sep 2012 20:16:17 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q8NKGHTL068190; Sun, 23 Sep 2012 20:16:17 GMT (envelope-from sbruno@svn.freebsd.org) Received: (from sbruno@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id q8NKGHde068187; Sun, 23 Sep 2012 20:16:17 GMT (envelope-from sbruno@svn.freebsd.org) Message-Id: <201209232016.q8NKGHde068187@svn.freebsd.org> From: Sean Bruno Date: Sun, 23 Sep 2012 20:16:17 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org X-SVN-Group: stable-8 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r240871 - stable/8/sys/dev/mfi X-BeenThere: svn-src-stable-8@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 8-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Sep 2012 20:16:17 -0000 Author: sbruno Date: Sun Sep 23 20:16:17 2012 New Revision: 240871 URL: http://svn.freebsd.org/changeset/base/240871 Log: MFC r238373 sys/dev/mfivar.h contains references to MFI_DEBUG, but it never gets turned on unless the file also includes opt_mfi.h. Submitted by: Andrew Boyer aboyer@averesystems.com Modified: stable/8/sys/dev/mfi/mfivar.h Directory Properties: stable/8/sys/ (props changed) stable/8/sys/dev/ (props changed) stable/8/sys/dev/mfi/ (props changed) Modified: stable/8/sys/dev/mfi/mfivar.h ============================================================================== --- stable/8/sys/dev/mfi/mfivar.h Sun Sep 23 20:12:10 2012 (r240870) +++ stable/8/sys/dev/mfi/mfivar.h Sun Sep 23 20:16:17 2012 (r240871) @@ -61,6 +61,7 @@ __FBSDID("$FreeBSD$"); #include #include +#include "opt_mfi.h" /* * SCSI structures and definitions are used from here, but no linking From owner-svn-src-stable-8@FreeBSD.ORG Sun Sep 23 20:24:17 2012 Return-Path: Delivered-To: svn-src-stable-8@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 98C18106566B; Sun, 23 Sep 2012 20:24:17 +0000 (UTC) (envelope-from sbruno@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 844A28FC0A; Sun, 23 Sep 2012 20:24:17 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q8NKOHnB069664; Sun, 23 Sep 2012 20:24:17 GMT (envelope-from sbruno@svn.freebsd.org) Received: (from sbruno@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id q8NKOHfr069662; Sun, 23 Sep 2012 20:24:17 GMT (envelope-from sbruno@svn.freebsd.org) Message-Id: <201209232024.q8NKOHfr069662@svn.freebsd.org> From: Sean Bruno Date: Sun, 23 Sep 2012 20:24:17 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org X-SVN-Group: stable-8 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r240874 - stable/8/sys/dev/mfi X-BeenThere: svn-src-stable-8@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 8-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Sep 2012 20:24:17 -0000 Author: sbruno Date: Sun Sep 23 20:24:17 2012 New Revision: 240874 URL: http://svn.freebsd.org/changeset/base/240874 Log: MFC r238371 When an MFI command fails, the driver needs to set bio->bio_resid so that the upper levels notice. Otherwise we see commands silently failing leading to data corruption. This mirrors dadone() Submitted by: Andrew Boyer aboyer@averesystems.com Modified: stable/8/sys/dev/mfi/mfi_disk.c Directory Properties: stable/8/sys/ (props changed) stable/8/sys/dev/ (props changed) stable/8/sys/dev/mfi/ (props changed) Modified: stable/8/sys/dev/mfi/mfi_disk.c ============================================================================== --- stable/8/sys/dev/mfi/mfi_disk.c Sun Sep 23 20:17:28 2012 (r240873) +++ stable/8/sys/dev/mfi/mfi_disk.c Sun Sep 23 20:24:17 2012 (r240874) @@ -298,6 +298,7 @@ mfi_disk_complete(struct bio *bio) hdr = bio->bio_driver1; if (bio->bio_flags & BIO_ERROR) { + bio->bio_resid = bio->bio_bcount; if (bio->bio_error == 0) bio->bio_error = EIO; disk_err(bio, "hard error", -1, 1); From owner-svn-src-stable-8@FreeBSD.ORG Sun Sep 23 20:31:46 2012 Return-Path: Delivered-To: svn-src-stable-8@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 08EA61065675; Sun, 23 Sep 2012 20:31:46 +0000 (UTC) (envelope-from sbruno@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id E78EC8FC08; Sun, 23 Sep 2012 20:31:45 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q8NKVjSo071039; Sun, 23 Sep 2012 20:31:45 GMT (envelope-from sbruno@svn.freebsd.org) Received: (from sbruno@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id q8NKVjRT071036; Sun, 23 Sep 2012 20:31:45 GMT (envelope-from sbruno@svn.freebsd.org) Message-Id: <201209232031.q8NKVjRT071036@svn.freebsd.org> From: Sean Bruno Date: Sun, 23 Sep 2012 20:31:45 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org X-SVN-Group: stable-8 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r240877 - stable/8/sys/dev/aac X-BeenThere: svn-src-stable-8@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 8-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Sep 2012 20:31:46 -0000 Author: sbruno Date: Sun Sep 23 20:31:45 2012 New Revision: 240877 URL: http://svn.freebsd.org/changeset/base/240877 Log: MFC r238601 On BIO_ERROR, set bio_resid to stop losing data in the error case. Submitted by: Mark Johnston Modified: stable/8/sys/dev/aac/aac_disk.c Directory Properties: stable/8/sys/ (props changed) stable/8/sys/dev/ (props changed) stable/8/sys/dev/aac/ (props changed) Modified: stable/8/sys/dev/aac/aac_disk.c ============================================================================== --- stable/8/sys/dev/aac/aac_disk.c Sun Sep 23 20:28:47 2012 (r240876) +++ stable/8/sys/dev/aac/aac_disk.c Sun Sep 23 20:31:45 2012 (r240877) @@ -334,8 +334,10 @@ aac_biodone(struct bio *bp) { fwprintf(NULL, HBA_FLAGS_DBG_FUNCTION_ENTRY_B, ""); - if (bp->bio_flags & BIO_ERROR) + if (bp->bio_flags & BIO_ERROR) { + bp->bio_resid = bp->bio_bcount; disk_err(bp, "hard error", -1, 1); + } biodone(bp); } From owner-svn-src-stable-8@FreeBSD.ORG Tue Sep 25 01:28:14 2012 Return-Path: Delivered-To: svn-src-stable-8@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3FAB8106566C; Tue, 25 Sep 2012 01:28:14 +0000 (UTC) (envelope-from eadler@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 2A27D8FC0C; Tue, 25 Sep 2012 01:28:14 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q8P1SE8q036198; Tue, 25 Sep 2012 01:28:14 GMT (envelope-from eadler@svn.freebsd.org) Received: (from eadler@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id q8P1SDfG036196; Tue, 25 Sep 2012 01:28:13 GMT (envelope-from eadler@svn.freebsd.org) Message-Id: <201209250128.q8P1SDfG036196@svn.freebsd.org> From: Eitan Adler Date: Tue, 25 Sep 2012 01:28:13 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org X-SVN-Group: stable-8 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r240903 - stable/8/sys/dev/ixgbe X-BeenThere: svn-src-stable-8@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 8-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Sep 2012 01:28:14 -0000 Author: eadler Date: Tue Sep 25 01:28:13 2012 New Revision: 240903 URL: http://svn.freebsd.org/changeset/base/240903 Log: MFC r240466: Define missing DEBUGOUT# macros. DEBUGOUT[45] are not yet used but are being defined pre-emptively to avoid future build breakage PR: kern/168967 Approved by: cperciva (implicit) Modified: stable/8/sys/dev/ixgbe/ixgbe_osdep.h Directory Properties: stable/8/sys/ (props changed) stable/8/sys/dev/ (props changed) stable/8/sys/dev/ixgbe/ (props changed) Modified: stable/8/sys/dev/ixgbe/ixgbe_osdep.h ============================================================================== --- stable/8/sys/dev/ixgbe/ixgbe_osdep.h Mon Sep 24 23:57:16 2012 (r240902) +++ stable/8/sys/dev/ixgbe/ixgbe_osdep.h Tue Sep 25 01:28:13 2012 (r240903) @@ -68,12 +68,17 @@ #define DEBUGOUT1(S,A) printf(S "\n",A) #define DEBUGOUT2(S,A,B) printf(S "\n",A,B) #define DEBUGOUT3(S,A,B,C) printf(S "\n",A,B,C) + #define DEBUGOUT4(S,A,B,C,D) printf(S "\n",A,B,C,D) + #define DEBUGOUT5(S,A,B,C,D,E) printf(S "\n",A,B,C,D,E) + #define DEBUGOUT6(S,A,B,C,D,E,F) printf(S "\n",A,B,C,D,E,F) #define DEBUGOUT7(S,A,B,C,D,E,F,G) printf(S "\n",A,B,C,D,E,F,G) #else #define DEBUGOUT(S) #define DEBUGOUT1(S,A) #define DEBUGOUT2(S,A,B) #define DEBUGOUT3(S,A,B,C) + #define DEBUGOUT4(S,A,B,C,D) + #define DEBUGOUT5(S,A,B,C,D,E) #define DEBUGOUT6(S,A,B,C,D,E,F) #define DEBUGOUT7(S,A,B,C,D,E,F,G) #endif From owner-svn-src-stable-8@FreeBSD.ORG Tue Sep 25 01:31:24 2012 Return-Path: Delivered-To: svn-src-stable-8@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6B29B1065670; Tue, 25 Sep 2012 01:31:24 +0000 (UTC) (envelope-from eadler@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 3B7358FC19; Tue, 25 Sep 2012 01:31:24 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q8P1VOw8036731; Tue, 25 Sep 2012 01:31:24 GMT (envelope-from eadler@svn.freebsd.org) Received: (from eadler@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id q8P1VOia036727; Tue, 25 Sep 2012 01:31:24 GMT (envelope-from eadler@svn.freebsd.org) Message-Id: <201209250131.q8P1VOia036727@svn.freebsd.org> From: Eitan Adler Date: Tue, 25 Sep 2012 01:31:24 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org X-SVN-Group: stable-8 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r240906 - in stable/8/tools: diag diag/ac tools tools/backout_commit tools/mfc X-BeenThere: svn-src-stable-8@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 8-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Sep 2012 01:31:24 -0000 Author: eadler Date: Tue Sep 25 01:31:23 2012 New Revision: 240906 URL: http://svn.freebsd.org/changeset/base/240906 Log: MFC r240470: Remove scripts and tools which only functioned when src was using CVS Approved by: cperciva (implicit) Deleted: stable/8/tools/diag/ac/ stable/8/tools/tools/backout_commit/ stable/8/tools/tools/mfc/ Modified: stable/8/tools/diag/README stable/8/tools/tools/README Directory Properties: stable/8/tools/diag/ (props changed) stable/8/tools/tools/ (props changed) Modified: stable/8/tools/diag/README ============================================================================== --- stable/8/tools/diag/README Tue Sep 25 01:28:15 2012 (r240905) +++ stable/8/tools/diag/README Tue Sep 25 01:31:23 2012 (r240906) @@ -8,8 +8,6 @@ the integrity. Please make a subdir per program, and add a brief description to this file. -ac Various scripts that checks of style/content correctness of - committers lists in doc/ area. dumpvfscache program that can be used to examine the contents of the vfs name cache. httpd-error check for Web files which does not exists on your host Modified: stable/8/tools/tools/README ============================================================================== --- stable/8/tools/tools/README Tue Sep 25 01:28:15 2012 (r240905) +++ stable/8/tools/tools/README Tue Sep 25 01:31:23 2012 (r240906) @@ -10,8 +10,6 @@ file. ansify Convert K&R-style function definitions to ANSI style ath Tools specific to the Atheros 802.11 support -backout_commit A tool for reading in a commit message and generating - a script that will backout the commit. cfi Common Flash Interface (CFI) tool commitsdb A tool for reconstructing commit history using md5 checksums of the commit logs. @@ -45,8 +43,6 @@ kerninclude Shellscript to find unused # kernxref Shellscript to cross reference symbols in the LINT kernel. kttcp An in-kernel version of the ttcp network performance tool mctest A multicast test program -mfc Merge a directory from HEAD to a branch where it does not - already exist and other MFC related script(s). mid Create a Message-ID database for mailing lists. mwl Tools specific to the Marvell 88W8363 support ncpus Count the number of processors From owner-svn-src-stable-8@FreeBSD.ORG Tue Sep 25 01:33:23 2012 Return-Path: Delivered-To: svn-src-stable-8@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 419411065673; Tue, 25 Sep 2012 01:33:23 +0000 (UTC) (envelope-from eadler@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 2C9B28FC12; Tue, 25 Sep 2012 01:33:23 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q8P1XN0C037139; Tue, 25 Sep 2012 01:33:23 GMT (envelope-from eadler@svn.freebsd.org) Received: (from eadler@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id q8P1XMhU037135; Tue, 25 Sep 2012 01:33:22 GMT (envelope-from eadler@svn.freebsd.org) Message-Id: <201209250133.q8P1XMhU037135@svn.freebsd.org> From: Eitan Adler Date: Tue, 25 Sep 2012 01:33:22 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org X-SVN-Group: stable-8 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r240910 - stable/8/share/misc X-BeenThere: svn-src-stable-8@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 8-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Sep 2012 01:33:23 -0000 Author: eadler Date: Tue Sep 25 01:33:22 2012 New Revision: 240910 URL: http://svn.freebsd.org/changeset/base/240910 Log: MFC r240480: Belatedly add myself Approved by: cperciva (implicit) Modified: stable/8/share/misc/committers-src.dot Directory Properties: stable/8/share/misc/ (props changed) Modified: stable/8/share/misc/committers-src.dot ============================================================================== --- stable/8/share/misc/committers-src.dot Tue Sep 25 01:33:22 2012 (r240909) +++ stable/8/share/misc/committers-src.dot Tue Sep 25 01:33:22 2012 (r240910) @@ -83,6 +83,7 @@ dg [label="David Greenman\ndg@FreeBSD.or dhartmei [label="Daniel Hartmeier\ndhartmei@FreeBSD.org\n2004/04/06"] dmlb [label="Duncan Barclay\ndmlb@FreeBSD.org\n2001/12/14"] dwmalone [label="David Malone\ndwmalone@FreeBSD.org\n2000/07/11"] +eadler [label="Eitan Adler\neadler@FreeBSD.org\n2012/01/18"] ed [label="Ed Schouten\ned@FreeBSD.org\n2008/05/22"] edwin [label="Edwin Groothuis\nedwin@FreeBSD.org\n2007/06/25"] eik [label="Oliver Eikemeier\neik@FreeBSD.org\n2004/05/20"] @@ -234,6 +235,7 @@ brooks -> jamie bz -> jamie bz -> syrinx +cperciva -> eadler cperciva -> flz cperciva -> simon From owner-svn-src-stable-8@FreeBSD.ORG Tue Sep 25 13:34:10 2012 Return-Path: Delivered-To: svn-src-stable-8@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 68D661065674; Tue, 25 Sep 2012 13:34:10 +0000 (UTC) (envelope-from tijl@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 535DF8FC24; Tue, 25 Sep 2012 13:34:10 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q8PDYAIN037832; Tue, 25 Sep 2012 13:34:10 GMT (envelope-from tijl@svn.freebsd.org) Received: (from tijl@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id q8PDYA3J037830; Tue, 25 Sep 2012 13:34:10 GMT (envelope-from tijl@svn.freebsd.org) Message-Id: <201209251334.q8PDYA3J037830@svn.freebsd.org> From: Tijl Coosemans Date: Tue, 25 Sep 2012 13:34:10 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org X-SVN-Group: stable-8 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r240920 - stable/8/sys/cam/scsi X-BeenThere: svn-src-stable-8@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 8-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Sep 2012 13:34:10 -0000 Author: tijl Date: Tue Sep 25 13:34:09 2012 New Revision: 240920 URL: http://svn.freebsd.org/changeset/base/240920 Log: MFC r240701: Fix a panic when trying to play invalid audio tracks. PR: kern/167340 Reported by: Michael L. Semon Modified: stable/8/sys/cam/scsi/scsi_cd.c Directory Properties: stable/8/sys/ (props changed) stable/8/sys/cam/ (props changed) Modified: stable/8/sys/cam/scsi/scsi_cd.c ============================================================================== --- stable/8/sys/cam/scsi/scsi_cd.c Tue Sep 25 13:32:05 2012 (r240919) +++ stable/8/sys/cam/scsi/scsi_cd.c Tue Sep 25 13:34:09 2012 (r240920) @@ -1962,6 +1962,7 @@ cdioctl(struct disk *dp, u_long cmd, voi || (st > (softc->toc.header.ending_track - softc->toc.header.starting_track))) { error = EINVAL; + cam_periph_unlock(periph); break; } sentry = &softc->toc.entries[st].addr; From owner-svn-src-stable-8@FreeBSD.ORG Wed Sep 26 11:12:10 2012 Return-Path: Delivered-To: svn-src-stable-8@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 11CB5106564A; Wed, 26 Sep 2012 11:12:10 +0000 (UTC) (envelope-from mm@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id D680B8FC08; Wed, 26 Sep 2012 11:12:09 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q8QBC9Pt015948; Wed, 26 Sep 2012 11:12:09 GMT (envelope-from mm@svn.freebsd.org) Received: (from mm@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id q8QBC9EC015945; Wed, 26 Sep 2012 11:12:09 GMT (envelope-from mm@svn.freebsd.org) Message-Id: <201209261112.q8QBC9EC015945@svn.freebsd.org> From: Martin Matuska Date: Wed, 26 Sep 2012 11:12:09 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org X-SVN-Group: stable-8 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r240958 - stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs X-BeenThere: svn-src-stable-8@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 8-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Sep 2012 11:12:10 -0000 Author: mm Date: Wed Sep 26 11:12:09 2012 New Revision: 240958 URL: http://svn.freebsd.org/changeset/base/240958 Log: MFC r236248-r236250: MFC r236248 (pjd): Remove unused variable. MFC r236249 (pjd): Eliminate 'where' argument, we don't use it. MFC r236250 (pjd): Tighten up the assertion: because size can't be 0 and even if sm_space is equal to sm_size, any 'sm_space - size' will be less than sm_size. Modified: stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_scan.c stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/space_map.c Directory Properties: stable/8/sys/ (props changed) stable/8/sys/cddl/ (props changed) stable/8/sys/cddl/contrib/opensolaris/ (props changed) Modified: stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_scan.c ============================================================================== --- stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_scan.c Wed Sep 26 10:58:15 2012 (r240957) +++ stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_scan.c Wed Sep 26 11:12:09 2012 (r240958) @@ -67,7 +67,6 @@ int zfs_resilver_min_time_ms = 3000; /* boolean_t zfs_no_scrub_io = B_FALSE; /* set to disable scrub i/o */ boolean_t zfs_no_scrub_prefetch = B_FALSE; /* set to disable srub prefetching */ enum ddt_class zfs_scrub_ddt_class_max = DDT_CLASS_DUPLICATE; -int dsl_scan_delay_completion = B_FALSE; /* set to delay scan completion */ #define DSL_SCAN_IS_SCRUB_RESILVER(scn) \ ((scn)->scn_phys.scn_func == POOL_SCAN_SCRUB || \ Modified: stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/space_map.c ============================================================================== --- stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/space_map.c Wed Sep 26 10:58:15 2012 (r240957) +++ stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/space_map.c Wed Sep 26 11:12:09 2012 (r240958) @@ -149,7 +149,6 @@ space_map_add(space_map_t *sm, uint64_t void space_map_remove(space_map_t *sm, uint64_t start, uint64_t size) { - avl_index_t where; space_seg_t ssearch, *ss, *newseg; uint64_t end = start + size; int left_over, right_over; @@ -161,7 +160,7 @@ space_map_remove(space_map_t *sm, uint64 ssearch.ss_start = start; ssearch.ss_end = end; - ss = avl_find(&sm->sm_root, &ssearch, &where); + ss = avl_find(&sm->sm_root, &ssearch, NULL); /* Make sure we completely overlap with someone */ if (ss == NULL) { @@ -172,7 +171,7 @@ space_map_remove(space_map_t *sm, uint64 } VERIFY3U(ss->ss_start, <=, start); VERIFY3U(ss->ss_end, >=, end); - VERIFY(sm->sm_space - size <= sm->sm_size); + VERIFY(sm->sm_space - size < sm->sm_size); left_over = (ss->ss_start != start); right_over = (ss->ss_end != end); From owner-svn-src-stable-8@FreeBSD.ORG Wed Sep 26 12:36:23 2012 Return-Path: Delivered-To: svn-src-stable-8@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5ADC510656A9; Wed, 26 Sep 2012 12:36:23 +0000 (UTC) (envelope-from mm@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 3B8B08FC17; Wed, 26 Sep 2012 12:36:23 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q8QCaNho027114; Wed, 26 Sep 2012 12:36:23 GMT (envelope-from mm@svn.freebsd.org) Received: (from mm@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id q8QCaM6w027107; Wed, 26 Sep 2012 12:36:22 GMT (envelope-from mm@svn.freebsd.org) Message-Id: <201209261236.q8QCaM6w027107@svn.freebsd.org> From: Martin Matuska Date: Wed, 26 Sep 2012 12:36:22 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org X-SVN-Group: stable-8 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r240960 - in stable/8/cddl: lib/libzfs sbin/zfs sbin/zpool usr.bin/zinject usr.bin/ztest usr.sbin/zdb X-BeenThere: svn-src-stable-8@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 8-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Sep 2012 12:36:23 -0000 Author: mm Date: Wed Sep 26 12:36:22 2012 New Revision: 240960 URL: http://svn.freebsd.org/changeset/base/240960 Log: MFC r226940 (rmh): Fix a few gratuitous library dependencies. Some of the ZFS utilities are linked with libraries they don't use: - zinject doesn't use libavl - ztest doesn't use libz - zdb uses neither libavl nor libz - zfs uses neither libbsdxml nor libm, nor libsbuf - zpool uses neither libbsdxml nor libm, nor libsbuf In addition, libzfs needs libm because it uses pow(), however it isn't linked with -lm. This went unnoticed because all its users had -lm before. Modified: stable/8/cddl/lib/libzfs/Makefile stable/8/cddl/sbin/zfs/Makefile stable/8/cddl/sbin/zpool/Makefile stable/8/cddl/usr.bin/zinject/Makefile stable/8/cddl/usr.bin/ztest/Makefile stable/8/cddl/usr.sbin/zdb/Makefile Directory Properties: stable/8/cddl/ (props changed) stable/8/cddl/lib/ (props changed) stable/8/cddl/sbin/ (props changed) stable/8/cddl/usr.bin/ (props changed) stable/8/cddl/usr.sbin/ (props changed) Modified: stable/8/cddl/lib/libzfs/Makefile ============================================================================== --- stable/8/cddl/lib/libzfs/Makefile Wed Sep 26 12:36:09 2012 (r240959) +++ stable/8/cddl/lib/libzfs/Makefile Wed Sep 26 12:36:22 2012 (r240960) @@ -6,8 +6,8 @@ .PATH: ${.CURDIR}/../../../cddl/contrib/opensolaris/lib/libzfs/common LIB= zfs -DPADD= ${LIBMD} ${LIBPTHREAD} ${LIBUMEM} ${LIBUTIL} -LDADD= -lmd -lpthread -lumem -lutil +DPADD= ${LIBMD} ${LIBPTHREAD} ${LIBUMEM} ${LIBUTIL} ${LIBM} +LDADD= -lmd -lpthread -lumem -lutil -lm SRCS= deviceid.c \ fsshare.c \ Modified: stable/8/cddl/sbin/zfs/Makefile ============================================================================== --- stable/8/cddl/sbin/zfs/Makefile Wed Sep 26 12:36:09 2012 (r240959) +++ stable/8/cddl/sbin/zfs/Makefile Wed Sep 26 12:36:22 2012 (r240960) @@ -20,8 +20,8 @@ CFLAGS+= -I${.CURDIR}/../../../sys/cddl/ CFLAGS+= -I${.CURDIR}/../../../sys/cddl/contrib/opensolaris/uts/common/sys CFLAGS+= -I${.CURDIR}/../../../sys/cddl/contrib/opensolaris/common/zfs -DPADD= ${LIBBSDXML} ${LIBGEOM} ${LIBM} ${LIBNVPAIR} ${LIBSBUF} ${LIBUMEM} \ +DPADD= ${LIBGEOM} ${LIBNVPAIR} ${LIBUMEM} \ ${LIBUTIL} ${LIBUUTIL} ${LIBZFS} -LDADD= -lbsdxml -lgeom -lm -lnvpair -lsbuf -lumem -lutil -luutil -lzfs +LDADD= -lgeom -lnvpair -lumem -lutil -luutil -lzfs .include Modified: stable/8/cddl/sbin/zpool/Makefile ============================================================================== --- stable/8/cddl/sbin/zpool/Makefile Wed Sep 26 12:36:09 2012 (r240959) +++ stable/8/cddl/sbin/zpool/Makefile Wed Sep 26 12:36:22 2012 (r240960) @@ -25,8 +25,8 @@ CFLAGS+= -I${.CURDIR}/../../../sys/cddl/ CFLAGS+= -I${.CURDIR}/../../../cddl/contrib/opensolaris/lib/libzpool/common CFLAGS+= -I${.CURDIR}/../../../cddl/contrib/opensolaris/cmd/stat/common -DPADD= ${LIBAVL} ${LIBBSDXML} ${LIBGEOM} ${LIBM} ${LIBNVPAIR} ${LIBSBUF} \ +DPADD= ${LIBAVL} ${LIBGEOM} ${LIBNVPAIR} \ ${LIBUMEM} ${LIBUTIL} ${LIBUUTIL} ${LIBZFS} -LDADD= -lavl -lbsdxml -lgeom -lm -lnvpair -lsbuf -lumem -lutil -luutil -lzfs +LDADD= -lavl -lgeom -lnvpair -lumem -lutil -luutil -lzfs .include Modified: stable/8/cddl/usr.bin/zinject/Makefile ============================================================================== --- stable/8/cddl/usr.bin/zinject/Makefile Wed Sep 26 12:36:09 2012 (r240959) +++ stable/8/cddl/usr.bin/zinject/Makefile Wed Sep 26 12:36:22 2012 (r240960) @@ -18,8 +18,8 @@ CFLAGS+= -I${.CURDIR}/../../../sys/cddl/ CFLAGS+= -I${.CURDIR}/../../contrib/opensolaris/head CFLAGS+= -I${.CURDIR}/../../lib/libumem -DPADD= ${LIBAVL} ${LIBGEOM} ${LIBM} ${LIBNVPAIR} ${LIBUMEM} ${LIBUUTIL} \ +DPADD= ${LIBGEOM} ${LIBM} ${LIBNVPAIR} ${LIBUMEM} ${LIBUUTIL} \ ${LIBZFS} ${LIBZPOOL} ${LIBUUTIL} -LDADD= -lavl -lgeom -lm -lnvpair -lumem -luutil -lzfs -lzpool +LDADD= -lgeom -lm -lnvpair -lumem -luutil -lzfs -lzpool .include Modified: stable/8/cddl/usr.bin/ztest/Makefile ============================================================================== --- stable/8/cddl/usr.bin/ztest/Makefile Wed Sep 26 12:36:09 2012 (r240959) +++ stable/8/cddl/usr.bin/ztest/Makefile Wed Sep 26 12:36:22 2012 (r240960) @@ -17,8 +17,8 @@ CFLAGS+= -I${.CURDIR}/../../contrib/open CFLAGS+= -I${.CURDIR}/../../lib/libumem DPADD= ${LIBM} ${LIBNVPAIR} ${LIBUMEM} ${LIBZPOOL} \ - ${LIBPTHREAD} ${LIBZ} ${LIBAVL} -LDADD= -lm -lnvpair -lumem -lzpool -lpthread -lz -lavl + ${LIBPTHREAD} ${LIBAVL} +LDADD= -lm -lnvpair -lumem -lzpool -lpthread -lavl CSTD= c99 Modified: stable/8/cddl/usr.sbin/zdb/Makefile ============================================================================== --- stable/8/cddl/usr.sbin/zdb/Makefile Wed Sep 26 12:36:09 2012 (r240959) +++ stable/8/cddl/usr.sbin/zdb/Makefile Wed Sep 26 12:36:22 2012 (r240960) @@ -20,9 +20,9 @@ CFLAGS+= -I${.CURDIR}/../../../sys/cddl/ CFLAGS+= -I${.CURDIR}/../../../cddl/contrib/opensolaris/head CFLAGS+= -I${.CURDIR}/../../lib/libumem -DPADD= ${LIBAVL} ${LIBGEOM} ${LIBM} ${LIBNVPAIR} ${LIBPTHREAD} ${LIBUMEM} \ - ${LIBUUTIL} ${LIBZ} ${LIBZFS} ${LIBZPOOL} -LDADD= -lavl -lgeom -lm -lnvpair -lpthread -lumem -luutil -lz -lzfs -lzpool +DPADD= ${LIBGEOM} ${LIBM} ${LIBNVPAIR} ${LIBPTHREAD} ${LIBUMEM} \ + ${LIBUUTIL} ${LIBZFS} ${LIBZPOOL} +LDADD= -lgeom -lm -lnvpair -lpthread -lumem -luutil -lzfs -lzpool CSTD= c99 From owner-svn-src-stable-8@FreeBSD.ORG Wed Sep 26 20:14:05 2012 Return-Path: Delivered-To: svn-src-stable-8@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 55974106564A; Wed, 26 Sep 2012 20:14:05 +0000 (UTC) (envelope-from dteske@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 263B68FC0A; Wed, 26 Sep 2012 20:14:05 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q8QKE5se085574; Wed, 26 Sep 2012 20:14:05 GMT (envelope-from dteske@svn.freebsd.org) Received: (from dteske@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id q8QKE4vK085570; Wed, 26 Sep 2012 20:14:04 GMT (envelope-from dteske@svn.freebsd.org) Message-Id: <201209262014.q8QKE4vK085570@svn.freebsd.org> From: Devin Teske Date: Wed, 26 Sep 2012 20:14:04 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org X-SVN-Group: stable-8 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r240972 - stable/8/usr.sbin/sysinstall X-BeenThere: svn-src-stable-8@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 8-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Sep 2012 20:14:05 -0000 Author: dteske Date: Wed Sep 26 20:14:04 2012 New Revision: 240972 URL: http://svn.freebsd.org/changeset/base/240972 Log: Add new DEBUG kernel distribution. Submitted by: Rick Miller Reviewed by: adrian (co-mentor) Approved by: adrian (co-mentor) Modified: stable/8/usr.sbin/sysinstall/dist.c stable/8/usr.sbin/sysinstall/dist.h stable/8/usr.sbin/sysinstall/menus.c Modified: stable/8/usr.sbin/sysinstall/dist.c ============================================================================== --- stable/8/usr.sbin/sysinstall/dist.c Wed Sep 26 20:09:48 2012 (r240971) +++ stable/8/usr.sbin/sysinstall/dist.c Wed Sep 26 20:14:04 2012 (r240972) @@ -102,6 +102,7 @@ static Distribution KernelDistTable[] = #ifdef WITH_SMP DTE_TARBALL("SMP", &KernelDists, KERNEL_SMP, "/boot"), #endif + DTE_TARBALL("DEBUG", &KernelDists, KERNEL_DEBUG, "/boot"), DTE_END, }; Modified: stable/8/usr.sbin/sysinstall/dist.h ============================================================================== --- stable/8/usr.sbin/sysinstall/dist.h Wed Sep 26 20:09:48 2012 (r240971) +++ stable/8/usr.sbin/sysinstall/dist.h Wed Sep 26 20:14:04 2012 (r240972) @@ -73,6 +73,7 @@ /* Subtypes for KERNEL distribution */ #define DIST_KERNEL_GENERIC 0x00001 #define DIST_KERNEL_SMP 0x00002 +#define DIST_KERNEL_DEBUG 0x00004 #define DIST_KERNEL_ALL 0xFFFFF /* Canned distribution sets */ Modified: stable/8/usr.sbin/sysinstall/menus.c ============================================================================== --- stable/8/usr.sbin/sysinstall/menus.c Wed Sep 26 20:09:48 2012 (r240971) +++ stable/8/usr.sbin/sysinstall/menus.c Wed Sep 26 20:14:04 2012 (r240972) @@ -1032,6 +1032,8 @@ DMenu MenuKernelDistributions = { { " SMP", "GENERIC symmetric multiprocessor kernel configuration", dmenuFlagCheck, dmenuSetFlag, NULL, &KernelDists, '[', 'X', ']', DIST_KERNEL_SMP }, #endif + { " DEBUG", "DEBUG kernel configuration", + dmenuFlagCheck, dmenuSetFlag, NULL, &KernelDists, '[', 'X', ']', DIST_KERNEL_DEBUG }, { NULL } }, }; From owner-svn-src-stable-8@FreeBSD.ORG Thu Sep 27 04:06:21 2012 Return-Path: Delivered-To: svn-src-stable-8@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6F87B106566B; Thu, 27 Sep 2012 04:06:21 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 598218FC0A; Thu, 27 Sep 2012 04:06:21 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q8R46LBB048316; Thu, 27 Sep 2012 04:06:21 GMT (envelope-from pfg@svn.freebsd.org) Received: (from pfg@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id q8R46LPE048313; Thu, 27 Sep 2012 04:06:21 GMT (envelope-from pfg@svn.freebsd.org) Message-Id: <201209270406.q8R46LPE048313@svn.freebsd.org> From: "Pedro F. Giffuni" Date: Thu, 27 Sep 2012 04:06:21 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org X-SVN-Group: stable-8 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r240980 - in stable/8: lib/libc/rpc sys/rpc X-BeenThere: svn-src-stable-8@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 8-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Sep 2012 04:06:21 -0000 Author: pfg Date: Thu Sep 27 04:06:20 2012 New Revision: 240980 URL: http://svn.freebsd.org/changeset/base/240980 Log: MFC 240880: Revert a change from Bull's NFSv4 libtirpc implementation: libtirpc: be sure to free cl_netid and cl_tp This change is causing rpc.lockd to exit after startup. Reported by: David Wolfskill Modified: stable/8/lib/libc/rpc/clnt_vc.c stable/8/sys/rpc/clnt_vc.c Directory Properties: stable/8/lib/libc/rpc/ (props changed) stable/8/sys/rpc/ (props changed) Modified: stable/8/lib/libc/rpc/clnt_vc.c ============================================================================== --- stable/8/lib/libc/rpc/clnt_vc.c Thu Sep 27 04:05:39 2012 (r240979) +++ stable/8/lib/libc/rpc/clnt_vc.c Thu Sep 27 04:06:20 2012 (r240980) @@ -672,10 +672,6 @@ clnt_vc_destroy(cl) if (ct->ct_addr.buf) free(ct->ct_addr.buf); mem_free(ct, sizeof(struct ct_data)); - if (cl->cl_netid && cl->cl_netid[0]) - mem_free(cl->cl_netid, strlen(cl->cl_netid) +1); - if (cl->cl_tp && cl->cl_tp[0]) - mem_free(cl->cl_tp, strlen(cl->cl_tp) +1); mem_free(cl, sizeof(CLIENT)); mutex_unlock(&clnt_fd_lock); thr_sigsetmask(SIG_SETMASK, &(mask), NULL); Modified: stable/8/sys/rpc/clnt_vc.c ============================================================================== --- stable/8/sys/rpc/clnt_vc.c Thu Sep 27 04:05:39 2012 (r240979) +++ stable/8/sys/rpc/clnt_vc.c Thu Sep 27 04:06:20 2012 (r240980) @@ -836,10 +836,6 @@ clnt_vc_destroy(CLIENT *cl) soclose(so); } mem_free(ct, sizeof(struct ct_data)); - if (cl->cl_netid && cl->cl_netid[0]) - mem_free(cl->cl_netid, strlen(cl->cl_netid) +1); - if (cl->cl_tp && cl->cl_tp[0]) - mem_free(cl->cl_tp, strlen(cl->cl_tp) +1); mem_free(cl, sizeof(CLIENT)); } From owner-svn-src-stable-8@FreeBSD.ORG Thu Sep 27 08:06:03 2012 Return-Path: Delivered-To: svn-src-stable-8@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id DA6471065678; Thu, 27 Sep 2012 08:06:03 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id C5BC78FC17; Thu, 27 Sep 2012 08:06:03 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q8R863RL079557; Thu, 27 Sep 2012 08:06:03 GMT (envelope-from mav@svn.freebsd.org) Received: (from mav@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id q8R863TO079555; Thu, 27 Sep 2012 08:06:03 GMT (envelope-from mav@svn.freebsd.org) Message-Id: <201209270806.q8R863TO079555@svn.freebsd.org> From: Alexander Motin Date: Thu, 27 Sep 2012 08:06:03 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org X-SVN-Group: stable-8 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r240987 - stable/8/sys/dev/sound/pci/hda X-BeenThere: svn-src-stable-8@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 8-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Sep 2012 08:06:04 -0000 Author: mav Date: Thu Sep 27 08:06:03 2012 New Revision: 240987 URL: http://svn.freebsd.org/changeset/base/240987 Log: MFC r240884: Fix panic caused by wrong pointer dereference, left after pin sense rewrite at r230551. Also while there, make sense polling use reported for each node separately instead of reporting accumulated total status. Modified: stable/8/sys/dev/sound/pci/hda/hdaa.c Directory Properties: stable/8/sys/ (props changed) stable/8/sys/dev/ (props changed) stable/8/sys/dev/sound/ (props changed) stable/8/sys/dev/sound/pci/ (props changed) Modified: stable/8/sys/dev/sound/pci/hda/hdaa.c ============================================================================== --- stable/8/sys/dev/sound/pci/hda/hdaa.c Thu Sep 27 08:04:59 2012 (r240986) +++ stable/8/sys/dev/sound/pci/hda/hdaa.c Thu Sep 27 08:06:03 2012 (r240987) @@ -627,7 +627,7 @@ hdaa_sense_init(struct hdaa_devinfo *dev (HDA_CONFIG_DEFAULTCONF_MISC(w->wclass.pin.config) & 1) != 0) { device_printf(devinfo->dev, "No presence detection support at nid %d\n", - as[i].pins[15]); + w->nid); } else { if (w->unsol < 0) poll = 1; @@ -636,7 +636,7 @@ hdaa_sense_init(struct hdaa_devinfo *dev "Headphones redirection for " "association %d nid=%d using %s.\n", w->bindas, w->nid, - (poll != 0) ? "polling" : + (w->unsol < 0) ? "polling" : "unsolicited responses"); ); }; From owner-svn-src-stable-8@FreeBSD.ORG Thu Sep 27 10:41:35 2012 Return-Path: Delivered-To: svn-src-stable-8@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1FE10106564A; Thu, 27 Sep 2012 10:41:35 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id E48298FC15; Thu, 27 Sep 2012 10:41:34 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q8RAfYQA099566; Thu, 27 Sep 2012 10:41:34 GMT (envelope-from kib@svn.freebsd.org) Received: (from kib@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id q8RAfYJ6099561; Thu, 27 Sep 2012 10:41:34 GMT (envelope-from kib@svn.freebsd.org) Message-Id: <201209271041.q8RAfYJ6099561@svn.freebsd.org> From: Konstantin Belousov Date: Thu, 27 Sep 2012 10:41:34 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org X-SVN-Group: stable-8 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r240991 - in stable/8/sys: conf dev/random modules/random X-BeenThere: svn-src-stable-8@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 8-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Sep 2012 10:41:35 -0000 Author: kib Date: Thu Sep 27 10:41:34 2012 New Revision: 240991 URL: http://svn.freebsd.org/changeset/base/240991 Log: MFC r229887 (by jkim): Enable hardware RNG for VIA Nano processors. Modified: stable/8/sys/conf/files.amd64 stable/8/sys/dev/random/probe.c stable/8/sys/modules/random/Makefile Directory Properties: stable/8/sys/ (props changed) stable/8/sys/dev/ (props changed) stable/8/sys/dev/random/ (props changed) stable/8/sys/modules/ (props changed) Modified: stable/8/sys/conf/files.amd64 ============================================================================== --- stable/8/sys/conf/files.amd64 Thu Sep 27 10:30:11 2012 (r240990) +++ stable/8/sys/conf/files.amd64 Thu Sep 27 10:41:34 2012 (r240991) @@ -223,6 +223,7 @@ dev/lindev/lindev.c optional lindev dev/nfe/if_nfe.c optional nfe pci dev/nve/if_nve.c optional nve pci dev/nvram/nvram.c optional nvram isa +dev/random/nehemiah.c optional random dev/sio/sio.c optional sio dev/sio/sio_isa.c optional sio isa dev/sio/sio_pccard.c optional sio pccard Modified: stable/8/sys/dev/random/probe.c ============================================================================== --- stable/8/sys/dev/random/probe.c Thu Sep 27 10:30:11 2012 (r240990) +++ stable/8/sys/dev/random/probe.c Thu Sep 27 10:41:34 2012 (r240991) @@ -36,7 +36,7 @@ __FBSDID("$FreeBSD$"); #include #include -#if defined(__i386__) && !defined(PC98) +#if defined(__amd64__) || (defined(__i386__) && !defined(PC98)) #include #include #include @@ -55,7 +55,7 @@ random_ident_hardware(struct random_syst *systat = random_yarrow; /* Then go looking for hardware */ -#if defined(__i386__) && !defined(PC98) +#if defined(__amd64__) || (defined(__i386__) && !defined(PC98)) if (via_feature_rng & VIA_HAS_RNG) { *systat = random_nehemiah; } Modified: stable/8/sys/modules/random/Makefile ============================================================================== --- stable/8/sys/modules/random/Makefile Thu Sep 27 10:30:11 2012 (r240990) +++ stable/8/sys/modules/random/Makefile Thu Sep 27 10:41:34 2012 (r240991) @@ -6,7 +6,7 @@ KMOD= random SRCS= randomdev.c probe.c -.if ${MACHINE} == "i386" +.if ${MACHINE} == "amd64" || ${MACHINE} == "i386" SRCS+= nehemiah.c .endif SRCS+= randomdev_soft.c yarrow.c hash.c From owner-svn-src-stable-8@FreeBSD.ORG Thu Sep 27 10:56:26 2012 Return-Path: Delivered-To: svn-src-stable-8@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AB931106564A; Thu, 27 Sep 2012 10:56:26 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 943918FC0C; Thu, 27 Sep 2012 10:56:26 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q8RAuQc6003623; Thu, 27 Sep 2012 10:56:26 GMT (envelope-from kib@svn.freebsd.org) Received: (from kib@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id q8RAuQt1003611; Thu, 27 Sep 2012 10:56:26 GMT (envelope-from kib@svn.freebsd.org) Message-Id: <201209271056.q8RAuQt1003611@svn.freebsd.org> From: Konstantin Belousov Date: Thu, 27 Sep 2012 10:56:26 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org X-SVN-Group: stable-8 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r240994 - in stable/8/sys: amd64/conf conf dev/random i386/conf modules/random X-BeenThere: svn-src-stable-8@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 8-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Sep 2012 10:56:26 -0000 Author: kib Date: Thu Sep 27 10:56:25 2012 New Revision: 240994 URL: http://svn.freebsd.org/changeset/base/240994 Log: MFC r240135: Add support for new Intel on-CPU Bull Mountain random number generator. MFC r240455: Rename the IVY_RNG option to RDRAND_RNG. Added: stable/8/sys/dev/random/ivy.c - copied, changed from r240135, head/sys/dev/random/ivy.c Deleted: stable/8/sys/dev/random/nehemiah.h Modified: stable/8/sys/amd64/conf/GENERIC stable/8/sys/conf/files.amd64 stable/8/sys/conf/files.i386 stable/8/sys/conf/options.amd64 stable/8/sys/conf/options.i386 stable/8/sys/dev/random/nehemiah.c stable/8/sys/dev/random/probe.c stable/8/sys/i386/conf/GENERIC stable/8/sys/modules/random/Makefile Directory Properties: stable/8/sys/ (props changed) stable/8/sys/amd64/ (props changed) stable/8/sys/conf/ (props changed) stable/8/sys/dev/ (props changed) stable/8/sys/dev/random/ (props changed) stable/8/sys/i386/ (props changed) stable/8/sys/modules/ (props changed) Modified: stable/8/sys/amd64/conf/GENERIC ============================================================================== --- stable/8/sys/amd64/conf/GENERIC Thu Sep 27 10:51:38 2012 (r240993) +++ stable/8/sys/amd64/conf/GENERIC Thu Sep 27 10:56:25 2012 (r240994) @@ -271,6 +271,8 @@ device wi # WaveLAN/Intersil/Symbol 80 # Pseudo devices. device loop # Network loopback device random # Entropy device +options PADLOCK_RNG # VIA Padlock RNG +options RDRAND_RNG # Intel Bull Mountain RNG device ether # Ethernet support device vlan # 802.1Q VLAN support device tun # Packet tunnel. Modified: stable/8/sys/conf/files.amd64 ============================================================================== --- stable/8/sys/conf/files.amd64 Thu Sep 27 10:51:38 2012 (r240993) +++ stable/8/sys/conf/files.amd64 Thu Sep 27 10:56:25 2012 (r240994) @@ -223,7 +223,8 @@ dev/lindev/lindev.c optional lindev dev/nfe/if_nfe.c optional nfe pci dev/nve/if_nve.c optional nve pci dev/nvram/nvram.c optional nvram isa -dev/random/nehemiah.c optional random +dev/random/ivy.c optional random rdrand_rng +dev/random/nehemiah.c optional random padlock_rng dev/sio/sio.c optional sio dev/sio/sio_isa.c optional sio isa dev/sio/sio_pccard.c optional sio pccard Modified: stable/8/sys/conf/files.i386 ============================================================================== --- stable/8/sys/conf/files.i386 Thu Sep 27 10:51:38 2012 (r240993) +++ stable/8/sys/conf/files.i386 Thu Sep 27 10:56:25 2012 (r240994) @@ -223,7 +223,8 @@ dev/nfe/if_nfe.c optional nfe pci dev/nve/if_nve.c optional nve pci dev/nvram/nvram.c optional nvram isa dev/pcf/pcf_isa.c optional pcf -dev/random/nehemiah.c optional random +dev/random/ivy.c optional random rdrand_rng +dev/random/nehemiah.c optional random padlock_rng dev/sbni/if_sbni.c optional sbni dev/sbni/if_sbni_isa.c optional sbni isa dev/sbni/if_sbni_pci.c optional sbni pci Modified: stable/8/sys/conf/options.amd64 ============================================================================== --- stable/8/sys/conf/options.amd64 Thu Sep 27 10:51:38 2012 (r240993) +++ stable/8/sys/conf/options.amd64 Thu Sep 27 10:56:25 2012 (r240994) @@ -67,3 +67,7 @@ XENHVM opt_global.h # options for the Intel C600 SAS driver (isci) ISCI_LOGGING opt_isci.h + +# hw random number generators for random(4) +PADLOCK_RNG opt_cpu.h +RDRAND_RNG opt_cpu.h Modified: stable/8/sys/conf/options.i386 ============================================================================== --- stable/8/sys/conf/options.i386 Thu Sep 27 10:51:38 2012 (r240993) +++ stable/8/sys/conf/options.i386 Thu Sep 27 10:56:25 2012 (r240994) @@ -124,3 +124,7 @@ XENHVM opt_global.h # options for the Intel C600 SAS driver (isci) ISCI_LOGGING opt_isci.h + +# hw random number generators for random(4) +PADLOCK_RNG opt_cpu.h +RDRAND_RNG opt_cpu.h Copied and modified: stable/8/sys/dev/random/ivy.c (from r240135, head/sys/dev/random/ivy.c) ============================================================================== --- head/sys/dev/random/ivy.c Wed Sep 5 13:18:51 2012 (r240135, copy source) +++ stable/8/sys/dev/random/ivy.c Thu Sep 27 10:56:25 2012 (r240994) @@ -30,7 +30,7 @@ __FBSDID("$FreeBSD$"); #include "opt_cpu.h" -#ifdef IVY_RNG +#ifdef RDRAND_RNG #include #include Modified: stable/8/sys/dev/random/nehemiah.c ============================================================================== --- stable/8/sys/dev/random/nehemiah.c Thu Sep 27 10:51:38 2012 (r240993) +++ stable/8/sys/dev/random/nehemiah.c Thu Sep 27 10:56:25 2012 (r240994) @@ -28,6 +28,10 @@ #include __FBSDID("$FreeBSD$"); +#include "opt_cpu.h" + +#ifdef PADLOCK_RNG + #include #include #include @@ -203,3 +207,5 @@ random_nehemiah_read(void *buf, int c) mtx_unlock(&random_nehemiah_mtx); return (c); } + +#endif Modified: stable/8/sys/dev/random/probe.c ============================================================================== --- stable/8/sys/dev/random/probe.c Thu Sep 27 10:51:38 2012 (r240993) +++ stable/8/sys/dev/random/probe.c Thu Sep 27 10:56:25 2012 (r240994) @@ -28,12 +28,17 @@ #include __FBSDID("$FreeBSD$"); +#if defined(__amd64__) || (defined(__i386__) && !defined(PC98)) +#include "opt_cpu.h" +#endif + #include #include +#include +#include #include #include #include -#include #include #if defined(__amd64__) || (defined(__i386__) && !defined(PC98)) @@ -45,7 +50,15 @@ __FBSDID("$FreeBSD$"); #include #include -#include + +#if defined(__amd64__) || (defined(__i386__) && !defined(PC98)) +#ifdef PADLOCK_RNG +extern struct random_systat random_nehemiah; +#endif +#ifdef RDRAND_RNG +extern struct random_systat random_ivy; +#endif +#endif void random_ident_hardware(struct random_systat *systat) @@ -56,8 +69,25 @@ random_ident_hardware(struct random_syst /* Then go looking for hardware */ #if defined(__amd64__) || (defined(__i386__) && !defined(PC98)) +#ifdef PADLOCK_RNG if (via_feature_rng & VIA_HAS_RNG) { - *systat = random_nehemiah; + int enable; + + enable = 1; + TUNABLE_INT_FETCH("hw.nehemiah_rng_enable", &enable); + if (enable) + *systat = random_nehemiah; } #endif +#ifdef RDRAND_RNG + if (cpu_feature2 & CPUID2_RDRAND) { + int enable; + + enable = 1; + TUNABLE_INT_FETCH("hw.ivy_rng_enable", &enable); + if (enable) + *systat = random_ivy; + } +#endif +#endif } Modified: stable/8/sys/i386/conf/GENERIC ============================================================================== --- stable/8/sys/i386/conf/GENERIC Thu Sep 27 10:51:38 2012 (r240993) +++ stable/8/sys/i386/conf/GENERIC Thu Sep 27 10:56:25 2012 (r240994) @@ -284,6 +284,8 @@ device wi # WaveLAN/Intersil/Symbol 80 # Pseudo devices. device loop # Network loopback device random # Entropy device +options PADLOCK_RNG # VIA Padlock RNG +options RDRAND_RNG # Intel Bull Mountain RNG device ether # Ethernet support device vlan # 802.1Q VLAN support device tun # Packet tunnel. Modified: stable/8/sys/modules/random/Makefile ============================================================================== --- stable/8/sys/modules/random/Makefile Thu Sep 27 10:51:38 2012 (r240993) +++ stable/8/sys/modules/random/Makefile Thu Sep 27 10:56:25 2012 (r240994) @@ -8,10 +8,11 @@ KMOD= random SRCS= randomdev.c probe.c .if ${MACHINE} == "amd64" || ${MACHINE} == "i386" SRCS+= nehemiah.c +SRCS+= ivy.c .endif SRCS+= randomdev_soft.c yarrow.c hash.c SRCS+= rijndael-alg-fst.c rijndael-api-fst.c sha2.c -SRCS+= bus_if.h device_if.h vnode_if.h +SRCS+= bus_if.h device_if.h vnode_if.h opt_cpu.h CFLAGS+= -I${.CURDIR}/../.. From owner-svn-src-stable-8@FreeBSD.ORG Thu Sep 27 18:52:04 2012 Return-Path: Delivered-To: svn-src-stable-8@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id CAF0E1065680; Thu, 27 Sep 2012 18:52:04 +0000 (UTC) (envelope-from trociny@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 9B52C8FC16; Thu, 27 Sep 2012 18:52:04 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q8RIq4vG076386; Thu, 27 Sep 2012 18:52:04 GMT (envelope-from trociny@svn.freebsd.org) Received: (from trociny@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id q8RIq4bx076384; Thu, 27 Sep 2012 18:52:04 GMT (envelope-from trociny@svn.freebsd.org) Message-Id: <201209271852.q8RIq4bx076384@svn.freebsd.org> From: Mikolaj Golub Date: Thu, 27 Sep 2012 18:52:04 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org X-SVN-Group: stable-8 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r241004 - stable/8/usr.sbin/bsnmpd/modules/snmp_hostres X-BeenThere: svn-src-stable-8@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 8-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Sep 2012 18:52:04 -0000 Author: trociny Date: Thu Sep 27 18:52:04 2012 New Revision: 241004 URL: http://svn.freebsd.org/changeset/base/241004 Log: MFC r240595: In snmp_hostres, device_map table is used for consistent device table indexing. When a device has gone it is not removed from device_map table but just its entry_p field is set to NULL. So when traversing device_map in disk_OS_get_ATA_disks() and disk_OS_get_MD_disks() check for entry_p being NULL, otherwise the bsnmpd crash is possible when a removed map entry is dereferenced. Before the fix, for disk_OS_get_ATA_disks() the crash could be easily reproduced running: atacontrol detach ata1 The crash was not observed in disk_OS_get_MD_disks() because currently snmp_hostres does no see md(4) disks: to get the device list it uses devinfo(3), which does not return md devices. Reported by: Miroslav Lachman 000.fbsd quip.cz Modified: stable/8/usr.sbin/bsnmpd/modules/snmp_hostres/hostres_diskstorage_tbl.c Directory Properties: stable/8/usr.sbin/bsnmpd/ (props changed) Modified: stable/8/usr.sbin/bsnmpd/modules/snmp_hostres/hostres_diskstorage_tbl.c ============================================================================== --- stable/8/usr.sbin/bsnmpd/modules/snmp_hostres/hostres_diskstorage_tbl.c Thu Sep 27 18:51:03 2012 (r241003) +++ stable/8/usr.sbin/bsnmpd/modules/snmp_hostres/hostres_diskstorage_tbl.c Thu Sep 27 18:52:04 2012 (r241004) @@ -287,6 +287,9 @@ disk_OS_get_ATA_disks(void) /* Walk over the device table looking for ata disks */ STAILQ_FOREACH(map, &device_map, link) { + /* Skip deleted entries. */ + if (map->entry_p == NULL) + continue; for (found = lookup; found->media != DSM_UNKNOWN; found++) { if (strncmp(map->name_key, found->dev_name, strlen(found->dev_name)) != 0) @@ -342,6 +345,9 @@ disk_OS_get_MD_disks(void) /* Look for md devices */ STAILQ_FOREACH(map, &device_map, link) { + /* Skip deleted entries. */ + if (map->entry_p == NULL) + continue; if (sscanf(map->name_key, "md%d", &unit) != 1) continue; From owner-svn-src-stable-8@FreeBSD.ORG Fri Sep 28 01:04:10 2012 Return-Path: Delivered-To: svn-src-stable-8@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 89FCD1065677; Fri, 28 Sep 2012 01:04:10 +0000 (UTC) (envelope-from eadler@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 742D28FC0A; Fri, 28 Sep 2012 01:04:10 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q8S14A3g039561; Fri, 28 Sep 2012 01:04:10 GMT (envelope-from eadler@svn.freebsd.org) Received: (from eadler@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id q8S14Are039559; Fri, 28 Sep 2012 01:04:10 GMT (envelope-from eadler@svn.freebsd.org) Message-Id: <201209280104.q8S14Are039559@svn.freebsd.org> From: Eitan Adler Date: Fri, 28 Sep 2012 01:04:10 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org X-SVN-Group: stable-8 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r241017 - stable/8/lib/libfetch X-BeenThere: svn-src-stable-8@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 8-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Sep 2012 01:04:10 -0000 Author: eadler Date: Fri Sep 28 01:04:09 2012 New Revision: 241017 URL: http://svn.freebsd.org/changeset/base/241017 Log: MFC r240495: Adding missing return statements during error conditions. PR: kern/171187 Approved by: cperciva (implicit) Modified: stable/8/lib/libfetch/file.c Directory Properties: stable/8/lib/libfetch/ (props changed) Modified: stable/8/lib/libfetch/file.c ============================================================================== --- stable/8/lib/libfetch/file.c Fri Sep 28 01:04:09 2012 (r241016) +++ stable/8/lib/libfetch/file.c Fri Sep 28 01:04:09 2012 (r241017) @@ -50,12 +50,15 @@ fetchXGetFile(struct url *u, struct url_ f = fopen(u->doc, "r"); - if (f == NULL) + if (f == NULL) { fetch_syserr(); + return (NULL); + } if (u->offset && fseeko(f, u->offset, SEEK_SET) == -1) { fclose(f); fetch_syserr(); + return (NULL); } fcntl(fileno(f), F_SETFD, FD_CLOEXEC); @@ -78,12 +81,15 @@ fetchPutFile(struct url *u, const char * else f = fopen(u->doc, "w+"); - if (f == NULL) + if (f == NULL) { fetch_syserr(); + return (NULL); + } if (u->offset && fseeko(f, u->offset, SEEK_SET) == -1) { fclose(f); fetch_syserr(); + return (NULL); } fcntl(fileno(f), F_SETFD, FD_CLOEXEC); From owner-svn-src-stable-8@FreeBSD.ORG Fri Sep 28 22:26:45 2012 Return-Path: Delivered-To: svn-src-stable-8@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4FA9B106564A; Fri, 28 Sep 2012 22:26:45 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 398358FC15; Fri, 28 Sep 2012 22:26:45 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q8SMQjPt016006; Fri, 28 Sep 2012 22:26:45 GMT (envelope-from delphij@svn.freebsd.org) Received: (from delphij@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id q8SMQjl9016004; Fri, 28 Sep 2012 22:26:45 GMT (envelope-from delphij@svn.freebsd.org) Message-Id: <201209282226.q8SMQjl9016004@svn.freebsd.org> From: Xin LI Date: Fri, 28 Sep 2012 22:26:45 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org X-SVN-Group: stable-8 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r241040 - stable/8/usr.sbin/mountd X-BeenThere: svn-src-stable-8@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 8-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Sep 2012 22:26:45 -0000 Author: delphij Date: Fri Sep 28 22:26:44 2012 New Revision: 241040 URL: http://svn.freebsd.org/changeset/base/241040 Log: MFC r239744: Show error messages if nmount() failed. Modified: stable/8/usr.sbin/mountd/mountd.c Directory Properties: stable/8/usr.sbin/mountd/ (props changed) Modified: stable/8/usr.sbin/mountd/mountd.c ============================================================================== --- stable/8/usr.sbin/mountd/mountd.c Fri Sep 28 20:43:03 2012 (r241039) +++ stable/8/usr.sbin/mountd/mountd.c Fri Sep 28 22:26:44 2012 (r241040) @@ -2464,11 +2464,11 @@ do_mount(struct exportlist *ep, struct g } if (errno == EPERM) { if (debug) - warnx("can't change attributes for %s", - dirp); + warnx("can't change attributes for %s: %s", + dirp, errmsg); syslog(LOG_ERR, - "can't change attributes for %s", - dirp); + "can't change attributes for %s: %s", + dirp, errmsg); ret = 1; goto error_exit; }