From owner-freebsd-rc@FreeBSD.ORG Mon Jan 14 11:06:53 2013 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 7303D4F7 for ; Mon, 14 Jan 2013 11:06:53 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 6454A658 for ; Mon, 14 Jan 2013 11:06:53 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r0EB6rUh086515 for ; Mon, 14 Jan 2013 11:06:53 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r0EB6q0w086513 for freebsd-rc@FreeBSD.org; Mon, 14 Jan 2013 11:06:52 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 14 Jan 2013 11:06:52 GMT Message-Id: <201301141106.r0EB6q0w086513@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-rc@FreeBSD.org Subject: Current problem reports assigned to freebsd-rc@FreeBSD.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2013 11:06:53 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o conf/175105 rc /etc/rc.d/* and more: syntax 'return_boolean_cmd && do o conf/175079 rc [rc.subr] [patch] rc.subr poorly handles recursive run o conf/174595 rc /etc/rc.d/sysctl : unknown oid 'XXX' [regression] o bin/173153 rc [rc.d] [patch] $netwait_ip should be more parallel o conf/172787 rc FreeBSD 9.x broken alias syntax on vlan interfaces o conf/172532 rc [rc] [patch] service routing restart always fails o conf/169047 rc [rc.subr] [patch] /etc/rc.subr not checking some scrip o bin/168544 rc [patch] [rc]: addswap-mounted swapfiles cause panic on o conf/167566 rc [rc.d] [patch] ipdivert module loading vs. ipfw rc.d o o conf/166484 rc [rc] [patch] rc.initdiskless patch for different major o conf/165769 rc [rc][jai][ipv6] IPv6 Initialization on external iface o conf/164393 rc [rc.d] restarting netif with static addresses doesn't o conf/163508 rc [rc.subr] [patch] Add "enable" and "disable" commands o conf/163488 rc Confusing explanation in defaults/rc.conf o conf/163321 rc [rc.conf] [patch] allow _fib syntax in rc.conf o conf/162642 rc .sh scripts in /usr/local/etc/rc.d get executed, not s o conf/161107 rc [rc] stop_boot in mountcritlocal usage is incorrect. o conf/160403 rc [rc] [patch] concurrently running rc-scripts during bo o conf/160240 rc rc.d/mdconfig and mdconfig2 should autoset $_type to v o conf/159846 rc [rc.conf] routing_stop_inet6() logic doesn't handle ip o conf/158557 rc [patch] /etc/rc.d/pf broken messages o conf/158127 rc [patch] remount_optional option in rc.initdiskless doe o conf/153666 rc [rc.d][patch] mount filesystems from fstab over zfs da o conf/153200 rc post-boot /etc/rc.d/network_ipv6 start can miss neighb o conf/153123 rc [rc] [patch] add gsched rc file to automatically inser o conf/150474 rc [patch] rc.d/accounting: Add ability to set location o o conf/149867 rc [PATCH] rc.d script to manage multiple FIBS (kern opti o conf/149831 rc [PATCH] add support to /etc/rc.d/jail for delegating Z o conf/148656 rc rc.firewall(8): {oip} and {iip} variables in rc.firewa o conf/147685 rc [rc.d] [patch] new feature for /etc/rc.d/fsck o conf/147444 rc [rc.d] [patch] /etc/rc.d/zfs stop not called on reboot o conf/146053 rc [patch] [request] shutdown of jails breaks inter-jail o conf/145399 rc [patch] rc.d scripts are unable to start/stop programs o conf/145009 rc [patch] rc.subr(8): rc.conf should allow mac label con o conf/143637 rc [patch] ntpdate(8) support for ntp-servers supplied by o conf/143085 rc [patch] ftp-proxy(8) rc(8) with multiple instances a conf/142973 rc [jail] [patch] Strange counter init value in jail rc o conf/142434 rc [patch] Add cpuset(1) support to rc.subr(8) o conf/142304 rc rc.conf(5): mdconfig and mdconfig2 rc.d scripts lack e o conf/141909 rc rc.subr(8): [patch] add rc.conf.d support to /usr/loca o conf/141678 rc [patch] A minor enhancement to how /etc/rc.d/jail dete o conf/140440 rc [patch] allow local command files in rc.{suspend,resum o conf/140261 rc [patch] Improve flexibility of mdconfig2 startup scrip p conf/138208 rc [rc.d] [patch] Making rc.firewall (workstation) IPv6 a o conf/137271 rc [rc.d] Cannot update /etc/host.conf when root filesyst o conf/136624 rc [rc.d] sysctl variables for ipnat are not applied on b o conf/134918 rc [patch] rc.subr fails to detect perl daemons o conf/134660 rc [patch] rc-script for initializing ng_netflow+ng_ipfw o conf/134333 rc PPP configuration problem in the rc.d scripts in combi o conf/133890 rc [patch] sshd(8): add multiple profiles to the rc.d scr o conf/128299 rc [patch] /etc/rc.d/geli does not mount partitions using o conf/126392 rc [patch] rc.conf ifconfig_xx keywords cannot be escaped o conf/124747 rc [patch] savecore can't create dump from encrypted swap o conf/124248 rc [jail] [patch] add support for nice value for rc.d/jai o conf/123734 rc [patch] Chipset VIA CX700 requires extra initializatio o conf/123222 rc [patch] Add rtprio(1)/idprio(1) support to rc.subr(8). p conf/123119 rc [patch] rc script for ipfw does not handle IPv6 o conf/122968 rc [rc.d] /etc/rc.d/addswap: md swapfile multiplication a o conf/122477 rc [patch] /etc/rc.d/mdconfig and mdconfig2 are ignoring o conf/122170 rc [patch] [request] New feature: notify admin via page o o kern/121566 rc [nfs] [request] [patch] ethernet iface should be broug a conf/119874 rc [patch] "/etc/rc.d/pf reload" fails if there are macro o conf/119076 rc [patch] [rc.d] /etc/rc.d/netif tries to remove alias a o bin/118325 rc [patch] [request] new periodic script to test statuses f conf/118255 rc savecore never finding kernel core dumps (rcorder prob f conf/117935 rc [patch] ppp fails to start at boot because of missing f conf/113915 rc [patch] ndis wireless driver fails to associate when i o conf/108589 rc rtsol(8) fails due to default ipfw rules o conf/106009 rc [ppp] [patch] [request] Fix pppoed startup script to p f conf/105689 rc [ppp] [request] syslogd starts too late at boot f conf/105145 rc [ppp] [patch] [request] add redial function to rc.d/pp f conf/104549 rc [patch] rc.d/nfsd needs special _find_processes functi o conf/102700 rc [geli] [patch] Add encrypted /tmp support to GELI/GBDE o conf/93815 rc [patch] Adds in the ability to save ipfw rules to rc.d f conf/92523 rc [patch] allow rc scripts to kill process after a timeo o conf/89870 rc [patch] [request] make netif verbose rc.conf toggle a conf/88913 rc [patch] wrapper support for rc.subr o conf/85819 rc [patch] script allowing multiuser mode in spite of fsc o kern/81006 rc ipnat not working with tunnel interfaces on startup o conf/77663 rc Suggestion: add /etc/rc.d/addnetswap after addcritremo o conf/73677 rc [patch] add support for powernow states to power_profi a conf/58939 rc [patch] dumb little hack for /etc/rc.firewall{,6} f conf/56934 rc [patch] rc.firewall rules for natd expect an interface 83 problems total. From owner-freebsd-rc@FreeBSD.ORG Tue Jan 15 04:15:19 2013 Return-Path: Delivered-To: freebsd-rc@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 03F63901; Tue, 15 Jan 2013 04:15:19 +0000 (UTC) (envelope-from linimon@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id D346E354; Tue, 15 Jan 2013 04:15:18 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r0F4FIJd083078; Tue, 15 Jan 2013 04:15:18 GMT (envelope-from linimon@freefall.freebsd.org) Received: (from linimon@localhost) by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r0F4FIbJ083074; Tue, 15 Jan 2013 04:15:18 GMT (envelope-from linimon) Date: Tue, 15 Jan 2013 04:15:18 GMT Message-Id: <201301150415.r0F4FIbJ083074@freefall.freebsd.org> To: linimon@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-rc@FreeBSD.org From: linimon@FreeBSD.org Subject: Re: conf/175311: [patch] add "dump" fs type support to rc.d/dumpon X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jan 2013 04:15:19 -0000 Synopsis: [patch] add "dump" fs type support to rc.d/dumpon Responsible-Changed-From-To: freebsd-bugs->freebsd-rc Responsible-Changed-By: linimon Responsible-Changed-When: Tue Jan 15 04:14:28 UTC 2013 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=175311 From owner-freebsd-rc@FreeBSD.ORG Tue Jan 15 11:30:02 2013 Return-Path: Delivered-To: freebsd-rc@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 55FAFDA for ; Tue, 15 Jan 2013 11:30:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 48713E86 for ; Tue, 15 Jan 2013 11:30:02 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r0FBU1lt086837 for ; Tue, 15 Jan 2013 11:30:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r0FBU1vB086836; Tue, 15 Jan 2013 11:30:01 GMT (envelope-from gnats) Date: Tue, 15 Jan 2013 11:30:01 GMT Message-Id: <201301151130.r0FBU1vB086836@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org Cc: From: Olivier Smedts Subject: Re: conf/174595: /etc/rc.d/sysctl : unknown oid ' XXX' [regression] X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Olivier Smedts List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jan 2013 11:30:02 -0000 The following reply was made to PR conf/174595; it has been noted by GNATS. From: Olivier Smedts To: d@delphij.net Cc: bug-followup@freebsd.org Subject: Re: conf/174595: /etc/rc.d/sysctl : unknown oid 'XXX' [regression] Date: Tue, 15 Jan 2013 12:16:12 +0100 In the compat.linux.osrelease case it's not a fatal error, it seems that sysctl manages to set the correct value after the linux kld is loaded by linux_enable="YES", even if it failed the first time. % sysctl compat.linux.osrelease compat.linux.osrelease: 2.6.32 I don't really know why and which mechanism is responsible of this but it behaves like "late" mounts. 2012/12/24 Xin Li : > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > It seems that the old behavior is actually wrong... How are we > benefited by not being told about fatal errors? > > Cheers, > - -- > Xin LI https://www.delphij.net/ > FreeBSD - The Power to Serve! Live free or die > -----BEGIN PGP SIGNATURE----- > > iQEcBAEBCAAGBQJQ2NR3AAoJEG80Jeu8UPuzniUH/0WqlPNwNRhyk1EosRKsVQyU > 0x3O9AKRHh1k7qlvCkqSr3tFjMnJ+DVLKL9AfkgPweZj7mQ2q8G3BPZTzYlNWFts > aqiZ0o+Ua5F6FVx992yaCPS8Lbwkfmab/ia2HlrowJJmiLdjwu6rOisTnCTPbbvw > NbLKzja72nrYFQ5ibub5zFoCP0lwJwSV2m6mhOyG+G07LXY4OZTdPuaBrJ3zCqt2 > Pd8AV9jmxsTn5e5jj1w3hJRhShQ1mgSeknYNBvbOFwQE2q4I+UVUr6ulmD624y57 > 9ID1RHXB8SBbGGyLwaTShSMsSOE1e1wSPNBO2pJzwHSeYw6rMNjo5izrL4GCDhM= > =gVdi > -----END PGP SIGNATURE----- -- Olivier Smedts _ ASCII ribbon campaign ( ) e-mail: olivier@gid0.org - against HTML email & vCards X www: http://www.gid0.org - against proprietary attachments / \ "Il y a seulement 10 sortes de gens dans le monde : ceux qui comprennent le binaire, et ceux qui ne le comprennent pas." From owner-freebsd-rc@FreeBSD.ORG Fri Jan 18 10:20:24 2013 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 50DDC878; Fri, 18 Jan 2013 10:20:24 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-ie0-f181.google.com (mail-ie0-f181.google.com [209.85.223.181]) by mx1.freebsd.org (Postfix) with ESMTP id EE3F2CD3; Fri, 18 Jan 2013 10:20:23 +0000 (UTC) Received: by mail-ie0-f181.google.com with SMTP id 16so6087547iea.12 for ; Fri, 18 Jan 2013 02:20:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=BCUg2gbdIMf0xNVHLTLI7JckmXTlXAZaXNLPKhZKZ+Q=; b=MwsnBVebkyX8k8ewyRWij+2dW+sFWEOfKABRdqdmLHf3s338TKCvWESAZJB9t75UW9 M0umq5I/X+YhJB4YKYf9ee8bUAaZZ5WH+Cz0ZgER61OwUWCeT5RIP8CFssgykDbNhlCS APM6KJXyf8lJelUmqqtAOZOSRnEKG2CYP3KYtZ01uvb25RR78o4EWdb8vrzaweXUJjrg DEmrO+YXjAPpWXa7tQP6zYmMDC5nxUjswnOgW9R337UUO5T+l7235IsO49rYlnkSxzqz 7L/0IBqDMxGDuhwFUkPmCZS+LtWkshKSgUfLGx+zLyVhhHkPXKDvOzOdkfHOYjbLJH/+ GSvg== MIME-Version: 1.0 X-Received: by 10.42.27.74 with SMTP id i10mr5557540icc.47.1358504423525; Fri, 18 Jan 2013 02:20:23 -0800 (PST) Received: by 10.64.16.73 with HTTP; Fri, 18 Jan 2013 02:20:23 -0800 (PST) Received: by 10.64.16.73 with HTTP; Fri, 18 Jan 2013 02:20:23 -0800 (PST) In-Reply-To: References: <20121118.074325.564844639489846824.hrs@allbsd.org> <20121118002245.GB15055@dft-labs.eu> <20121118.150935.240651183336258002.hrs@allbsd.org> Date: Fri, 18 Jan 2013 10:20:23 +0000 Message-ID: Subject: Re: mountlate being too mount-happy From: Chris Rees To: Hiroki Sato Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: Mateusz Guzik , "freebsd-rc@freebsd.org" , Mateusz Guzik X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jan 2013 10:20:24 -0000 [dragging it up again!] On 18 November 2012 14:28, Chris Rees wrote: > On 18 November 2012 06:09, Hiroki Sato wrote: >> Mateusz Guzik wrote >> in <20121118002245.GB15055@dft-labs.eu>: >> >> mj> On Sun, Nov 18, 2012 at 07:43:25AM +0900, Hiroki Sato wrote: >> mj> > Chris Rees wrote >> mj> > in < CADLo839wqzAPenuQDOVpQ74yjCMkPQNceKpvs_N9XNwMLrkC1A@mail.gmail.com>: >> mj> > >> mj> > ut> On 2 November 2012 14:21, Eitan Adler wrote: >> mj> > ut> > On 2 November 2012 09:56, Chris Rees wrote: >> mj> > ut> >> I'll take a look. >> mj> > ut> > >> mj> > ut> > untested: >> mj> > ut> >> mj> > ut> Based on Eitan's patch, I've tested this one, and documented it in mount(8) too: >> mj> > ut> >> mj> > ut> http://www.bayofrum.net/~crees/patches/mountonlylate.diff >> mj> > ut> >> mj> > ut> Does anyone have any suggestions/objections/urge to approve it? >> mj> > >> mj> > Is the original problem due to backgrounding of NFS mount only? If >> mj> > so, implementing prevention of duplicate invocation into mount(8) >> mj> > would be more reasonable, I think. >> mj> > >> mj> >> mj> We have 2 distinct scripts that try to mount same set of filesystems. >> mj> I think this is the real bug here and proposed patches makes it go away in >> mj> an IMHO acceptable way. >> >> I just wanted to make sure if the case is limited to background NFS >> mount or not. >> >> rc.d/mountlate just tries to mount the filesystems that are not >> mounted yet at that time in addition to the "late" ones, not always >> to mount the same set twice. If it is a bug, it is better to simply >> fix -l to exclude not-yet-mounted ones without "late" keyword than >> adding another option. > > I don't think it's a bug as such-- -l option is clearly labelled in > the manpage (emphasis mine): > > When used in conjunction with the -a option, *also* mount those > file systems which are marked as ``late''. > > I think that for POLA and to avoid changing behaviour of an option > that's been there a long time we need the -L option. > > I disagree with Mateusz here-- split operations in rc makes two > scripts necessary; mount and mountlate are two separate operations, > done at different times. Hiroki-san, do you still believe that changing the behaviour of -l is the correct way to go, rather than add a -L option for only late filesystems? (mount -la currently mounts *all* filesystems, you suggested to change to just late). I'd like to fix this, but I want to make sure you're happy with the solution. Chris From owner-freebsd-rc@FreeBSD.ORG Sat Jan 19 00:50:01 2013 Return-Path: Delivered-To: freebsd-rc@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 97DC0219 for ; Sat, 19 Jan 2013 00:50:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 6E4CEF6 for ; Sat, 19 Jan 2013 00:50:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r0J0o0vv068723 for ; Sat, 19 Jan 2013 00:50:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r0J0o0UR068719; Sat, 19 Jan 2013 00:50:00 GMT (envelope-from gnats) Date: Sat, 19 Jan 2013 00:50:00 GMT Message-Id: <201301190050.r0J0o0UR068719@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org Cc: From: Xin Li Subject: Re: conf/175311: [patch] add "dump" fs type support to rc.d/dumpon X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Xin Li List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Jan 2013 00:50:01 -0000 The following reply was made to PR conf/175311; it has been noted by GNATS. From: Xin Li To: Garrett Cooper Cc: freebsd-gnats-submit@FreeBSD.org Subject: Re: conf/175311: [patch] add "dump" fs type support to rc.d/dumpon Date: Fri, 18 Jan 2013 16:43:08 -0800 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 01/14/13 14:49, Garrett Cooper wrote: > >> Number: 175311 Category: conf Synopsis: >> [patch] add "dump" fs type support to rc.d/dumpon Confidential: >> no Severity: non-critical Priority: low Responsible: >> freebsd-bugs State: open Quarter: Keywords: >> Date-Required: Class: sw-bug Submitter-Id: >> current-users Arrival-Date: Mon Jan 14 22:50:00 UTC 2013 >> Closed-Date: Last-Modified: Originator: Garrett Cooper >> Release: 10-CURRENT Organization: > EMC Isilon >> Environment: > FreeBSD gran-tourismo.west.isilon.com 10.0-CURRENT FreeBSD > 10.0-CURRENT #1 r+294c6eb: Fri Jan 4 07:38:46 PST 2013 > root@gran-tourismo.west.isilon.com:/usr/obj/usr/src/sys/GRAN-TOURISMO > amd64 >> Description: > savecore(8) notes that you can use dump for the FS type, but dumpon > only supports swap for the FS type. The attached patch enhances > both FS types to work with dumpon + savecore. >> How-To-Repeat: > >> Fix: > > > Patch attached with submission follows: > > From 16921efded40ef4c7800f07157f0e52be4cf8121 Mon Sep 17 00:00:00 > 2001 From: Garrett Cooper Date: Mon, 14 Jan > 2013 14:39:59 -0800 Subject: [PATCH] Support the pseudo fs_vfstype > == "dump" noted in savecore(8) > > Signed-off-by: Garrett Cooper --- > etc/rc.d/dumpon | 7 ++++++- 1 file changed, 6 insertions(+), 1 > deletion(-) > > diff --git a/etc/rc.d/dumpon b/etc/rc.d/dumpon index > ce5fc1c..981ff84 100755 --- a/etc/rc.d/dumpon +++ > b/etc/rc.d/dumpon @@ -40,7 +40,12 @@ dumpon_start() return $? fi > while read dev mp type more ; do - [ "${type}" = "swap" ] || > continue + case "$type" in + dump|swap) + ;; + *) + > continue;; + esac Why not just: [ "${type}" = "swap" -o "${type}" = "dump" ] || continue? - -- Xin LI https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- iQEcBAEBCgAGBQJQ+ewcAAoJEG80Jeu8UPuzD40IAKe2N2o8ZVNODj65hXWWgiZa BlTyog+MUxr9FwQQMelaZqUz7jywuyLFWeiFZcBohmOonthKIwX8saUyozphW6nc jqpfKiZcywN6EaQfNucSsF55QdO2ndqCsXCDu+e4iyYK3KdTnc38gz+YbfzJOdxZ Y2W7QNNKIBINXngFyRdvhOk2W+okEcbsu7tMxzp8tYu+bDQLWNHo7183gKjjnqeX md/xhyHiFrRB48fZQ1+voAisnarI7ElKVNZVDwKBPzzsaNUsF56L+jmoQ2sqlhZF oAThcW1tC9AMDlR8RWWmvWDwoDjeubKNOPr/3Yl+z2vsmeSIEf/7IIjidNILfzM= =6mng -----END PGP SIGNATURE----- From owner-freebsd-rc@FreeBSD.ORG Sat Jan 19 00:50:02 2013 Return-Path: Delivered-To: freebsd-rc@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id B1BA221A for ; Sat, 19 Jan 2013 00:50:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 8C2B4F7 for ; Sat, 19 Jan 2013 00:50:02 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r0J0o2vT069018 for ; Sat, 19 Jan 2013 00:50:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r0J0o28a069011; Sat, 19 Jan 2013 00:50:02 GMT (envelope-from gnats) Date: Sat, 19 Jan 2013 00:50:02 GMT Message-Id: <201301190050.r0J0o28a069011@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org Cc: From: Garrett Cooper Subject: Re: conf/175311: [patch] add "dump" fs type support to rc.d/dumpon X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Garrett Cooper List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Jan 2013 00:50:02 -0000 The following reply was made to PR conf/175311; it has been noted by GNATS. From: Garrett Cooper To: d@delphij.net Cc: freebsd-gnats-submit@FreeBSD.org Subject: Re: conf/175311: [patch] add "dump" fs type support to rc.d/dumpon Date: Fri, 18 Jan 2013 16:47:44 -0800 On Jan 18, 2013, at 4:43 PM, Xin Li wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA512 > > On 01/14/13 14:49, Garrett Cooper wrote: >> >>> Number: 175311 Category: conf Synopsis: >>> [patch] add "dump" fs type support to rc.d/dumpon Confidential: >>> no Severity: non-critical Priority: low Responsible: >>> freebsd-bugs State: open Quarter: Keywords: >>> Date-Required: Class: sw-bug Submitter-Id: >>> current-users Arrival-Date: Mon Jan 14 22:50:00 UTC 2013 >>> Closed-Date: Last-Modified: Originator: Garrett Cooper >>> Release: 10-CURRENT Organization: >> EMC Isilon >>> Environment: >> FreeBSD gran-tourismo.west.isilon.com 10.0-CURRENT FreeBSD >> 10.0-CURRENT #1 r+294c6eb: Fri Jan 4 07:38:46 PST 2013 >> root@gran-tourismo.west.isilon.com:/usr/obj/usr/src/sys/GRAN-TOURISMO >> amd64 >>> Description: >> savecore(8) notes that you can use dump for the FS type, but dumpon >> only supports swap for the FS type. The attached patch enhances >> both FS types to work with dumpon + savecore. >>> How-To-Repeat: >> >>> Fix: >> >> >> Patch attached with submission follows: >> >> From 16921efded40ef4c7800f07157f0e52be4cf8121 Mon Sep 17 00:00:00 >> 2001 From: Garrett Cooper Date: Mon, 14 Jan >> 2013 14:39:59 -0800 Subject: [PATCH] Support the pseudo fs_vfstype >> == "dump" noted in savecore(8) >> >> Signed-off-by: Garrett Cooper --- >> etc/rc.d/dumpon | 7 ++++++- 1 file changed, 6 insertions(+), 1 >> deletion(-) >> >> diff --git a/etc/rc.d/dumpon b/etc/rc.d/dumpon index >> ce5fc1c..981ff84 100755 --- a/etc/rc.d/dumpon +++ >> b/etc/rc.d/dumpon @@ -40,7 +40,12 @@ dumpon_start() return $? fi >> while read dev mp type more ; do - [ "${type}" = "swap" ] || >> continue + case "$type" in + dump|swap) + ;; + *) + >> continue;; + esac > > Why not just: > > [ "${type}" = "swap" -o "${type}" = "dump" ] || continue? That's valid too -- didn't realize it had been converted to a built-in: $ type [ [ is a shell builtin Thanks! -Garrett