Date: Sun, 3 Dec 2017 10:04:52 -0700 (MST) From: Gerald Pfeifer <gerald@pfeifer.com> To: java@FreeBSD.org, Joe Nosay <superbisquit@gmail.com>, Rene Ladan <rene@FreeBSD.org> Subject: Re: Remove dead code from java/cacao/Makefile Message-ID: <alpine.LSU.2.21.1712030948580.2983@anthias.pfeifer.com> In-Reply-To: <alpine.LSU.2.21.1705280131360.3529@anthias.pfeifer.com> References: <alpine.LSU.2.21.1705142235120.4477@anthias.pfeifer.com> <CA%2BWntOu5d7avfVhoa-Y2a7dghQBHU8PizyRsjN1eCHe49Sz6QA@mail.gmail.com> <alpine.LSU.2.21.1705280131360.3529@anthias.pfeifer.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 28 May 2017, Gerald Pfeifer wrote:
> I did not propose to remove that option, I merely wanted to relay
> that (a) currently this alternative codepath is simply broken and
> (b) remove three lines of dead code at least.
Let me follow-up on this again.
Rene, I saw that you recently updated java/cacao. Can you approve?
I verified that WITH_GCC has exactly two occurrences in the _entire_
Ports tree, and that is this dead code in java/cacao/Makefile.
Any real objections towards removing this _dead_ code?
Gerald
PS: There is more, but let's focus on this most straightforward one
for now where I'm surprised (a) nobody else cared and (b) even this
was hard to get in.
Index: java/cacao/Makefile
===================================================================
--- java/cacao/Makefile (revision 455410)
+++ java/cacao/Makefile (working copy)
@@ -37,9 +37,6 @@
JAR= ${LOCALBASE}/bootstrap-openjdk6/bin/jar
JAVAC= ${LOCALBASE}/bootstrap-openjdk6/bin/javac
.else
-.if defined(WITH_GCC)
-GCC_SUFX= ${WITH_GCC:S/.//}
-.endif
GCC_SUFX?= 46
BUILD_DEPENDS+= gcj${GCC_SUFX}:lang/gcc${GCC_SUFX}
EXTRA_PATCHES= ${FILESDIR}/gcj.patch
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.LSU.2.21.1712030948580.2983>