From owner-freebsd-rc@freebsd.org Sun Aug 27 04:21:18 2017 Return-Path: Delivered-To: freebsd-rc@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1D411DE6A33 for ; Sun, 27 Aug 2017 04:21:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0935A64533 for ; Sun, 27 Aug 2017 04:21:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v7R4LHDW043521 for ; Sun, 27 Aug 2017 04:21:17 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-rc@FreeBSD.org Subject: [Bug 121566] [nfs] [request] [patch] ethernet iface should be brought up when booting from a mfs_root over nfs Date: Sun, 27 Aug 2017 04:21:18 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: jpaetzel@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: Overcome By Events X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: freebsd-rc@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc bug_status resolution Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Aug 2017 04:21:18 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D121566 Josh Paetzel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jpaetzel@FreeBSD.org Status|In Progress |Closed Resolution|--- |Overcome By Events --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-rc@freebsd.org Wed Aug 30 13:02:51 2017 Return-Path: Delivered-To: freebsd-rc@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DA37AE01859 for ; Wed, 30 Aug 2017 13:02:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C824C6C3FE for ; Wed, 30 Aug 2017 13:02:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v7UD2pq8047611 for ; Wed, 30 Aug 2017 13:02:51 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-rc@FreeBSD.org Subject: [Bug 199127] rc.d/ntpd: user-set ntpd_flags stomps over rc-defined ones (pidfile, driftfile) Date: Wed, 30 Aug 2017 13:02:50 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: conf X-Bugzilla-Version: 9.2-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: crees@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-rc@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Aug 2017 13:02:52 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D199127 Chris Rees changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |crees@FreeBSD.org --- Comment #2 from Chris Rees --- Created attachment 185920 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D185920&action= =3Dedit Use command_args not rc_flags to avoid rc.conf messing up configuration I've come across this bug too, but only realised after seeing this one :) On my machine the pidfile doesn't appear because I've overridden ntpd_flags= in rc.conf. The correct use is to have command_args for non-configurable stuff, not (ab= )use ${name}_flags and hope no-one changes them! Please would someone approve me to commit this? Cheers! Chris --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-rc@freebsd.org Wed Aug 30 13:12:38 2017 Return-Path: Delivered-To: freebsd-rc@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DCE6BE01D24 for ; Wed, 30 Aug 2017 13:12:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CB04A6CB49 for ; Wed, 30 Aug 2017 13:12:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v7UDCc0c070773 for ; Wed, 30 Aug 2017 13:12:38 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-rc@FreeBSD.org Subject: [Bug 216115] service -e showing sendmail enabled when it is not Date: Wed, 30 Aug 2017 13:12:38 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: conf X-Bugzilla-Version: 11.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: crees@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-rc@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Aug 2017 13:12:39 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D216115 Chris Rees changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |crees@FreeBSD.org Status|New |In Progress --- Comment #4 from Chris Rees --- I can't reproduce, I'm sorry. [crees@pegasus]~/ntpd_flags% service -e | grep sendmail [crees@pegasus]~/ntpd_flags% grep ^sendmail /etc/rc.conf sendmail_enable=3D"NONE" [crees@pegasus]~/ntpd_flags% Please would you try this to help debug? Open a Bourne shell (sh) somewhere and run these commands, and give the output. $ . /etc/rc.subr $ load_rc_config sendmail $ echo $sendmail_enable --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-rc@freebsd.org Wed Aug 30 13:13:55 2017 Return-Path: Delivered-To: freebsd-rc@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2FBE5E01D57 for ; Wed, 30 Aug 2017 13:13:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1DF976CB8E for ; Wed, 30 Aug 2017 13:13:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v7UDDsxC072498 for ; Wed, 30 Aug 2017 13:13:54 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-rc@FreeBSD.org Subject: [Bug 124747] [patch] savecore can't create dump from encrypted swap Date: Wed, 30 Aug 2017 13:13:54 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: conf X-Bugzilla-Version: 8.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: crees@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: freebsd-rc@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: resolution cc bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Aug 2017 13:13:55 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D124747 Chris Rees changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |crees@FreeBSD.org Status|In Progress |Closed --- Comment #4 from Chris Rees --- I agree :) --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-rc@freebsd.org Wed Aug 30 14:59:21 2017 Return-Path: Delivered-To: freebsd-rc@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E03B5E03CFE for ; Wed, 30 Aug 2017 14:59:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CE64570156 for ; Wed, 30 Aug 2017 14:59:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v7UExLW8037986 for ; Wed, 30 Aug 2017 14:59:21 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-rc@FreeBSD.org Subject: [Bug 216115] service -e showing sendmail enabled when it is not Date: Wed, 30 Aug 2017 14:59:21 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: conf X-Bugzilla-Version: 11.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: jasonmader@gmail.com X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-rc@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Aug 2017 14:59:22 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D216115 --- Comment #5 from Jason Mader --- (In reply to Chris Rees from comment #4) # sh # . /etc/rc.subr # load_rc_config sendmail # echo $sendmail_enable NONE # grep sendmail /etc/rc.conf sendmail_enable=3D"NONE" # service -e /etc/rc.d/hostid /etc/rc.d/zvol /etc/rc.d/hostid_save /etc/rc.d/zfs /etc/rc.d/cleanvar /etc/rc.d/ip6addrctl /etc/rc.d/netif /etc/rc.d/ipsec /etc/rc.d/ipfw /etc/rc.d/newsyslog /etc/rc.d/syslogd /etc/rc.d/savecore /etc/rc.d/dmesg /etc/rc.d/nfsuserd /etc/rc.d/nfsd /etc/rc.d/virecover /etc/rc.d/motd /etc/rc.d/ntpd /etc/rc.d/rctl /etc/rc.d/sshd /etc/rc.d/sendmail /etc/rc.d/cron /etc/rc.d/mixer /etc/rc.d/gptboot /etc/rc.d/bgfsck 11.0-RELEASE-p12 --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-rc@freebsd.org Thu Aug 31 00:11:05 2017 Return-Path: Delivered-To: freebsd-rc@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A4DE3E0D9FA for ; Thu, 31 Aug 2017 00:11:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9379AEB8 for ; Thu, 31 Aug 2017 00:11:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v7V0B5sb051971 for ; Thu, 31 Aug 2017 00:11:05 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-rc@FreeBSD.org Subject: [Bug 190793] Some rc scripts return non zero status on success Date: Thu, 31 Aug 2017 00:11:05 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: conf X-Bugzilla-Version: 10.0-STABLE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: emaste@freebsd.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-rc@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Aug 2017 00:11:05 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D190793 Ed Maste changed: What |Removed |Added ---------------------------------------------------------------------------- Status|New |Open --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-rc@freebsd.org Thu Aug 31 07:45:23 2017 Return-Path: Delivered-To: freebsd-rc@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CB53DE1836F for ; Thu, 31 Aug 2017 07:45:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B96916D56F for ; Thu, 31 Aug 2017 07:45:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v7V7jNG4089127 for ; Thu, 31 Aug 2017 07:45:23 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-rc@FreeBSD.org Subject: [Bug 190793] Some rc scripts return non zero status on success Date: Thu, 31 Aug 2017 07:45:23 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: conf X-Bugzilla-Version: 10.0-STABLE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: crees@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: crees@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: assigned_to bug_status cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Aug 2017 07:45:23 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D190793 Chris Rees changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|freebsd-rc@FreeBSD.org |crees@FreeBSD.org Status|Open |In Progress CC| |crees@FreeBSD.org --- Comment #1 from Chris Rees --- While here, we could remove some of the x$foo style nonsense, as this hasn't been a problem for decades. I'll have a look later. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-rc@freebsd.org Thu Aug 31 18:32:33 2017 Return-Path: Delivered-To: freebsd-rc@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 79399E03737 for ; Thu, 31 Aug 2017 18:32:33 +0000 (UTC) (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4B7873DEC for ; Thu, 31 Aug 2017 18:32:32 +0000 (UTC) (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id v7VIWOcH096369; Thu, 31 Aug 2017 11:32:24 -0700 (PDT) (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd-rwg@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id v7VIWOPS096368; Thu, 31 Aug 2017 11:32:24 -0700 (PDT) (envelope-from freebsd-rwg) From: "Rodney W. Grimes" Message-Id: <201708311832.v7VIWOPS096368@pdx.rh.CN85.dnsmgr.net> Subject: Re: [Bug 199127] rc.d/ntpd: user-set ntpd_flags stomps over rc-defined ones (pidfile, driftfile) (fwd) In-Reply-To: <4f7c8211-2e37-facc-39df-9b1b413be139@physics.org> To: Chris Rees Date: Thu, 31 Aug 2017 11:32:24 -0700 (PDT) CC: freebsd-rc@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Aug 2017 18:32:33 -0000 > Hi Rod, > > [Please copy rc@ in for discussion] Added, seemed to be missing from your reply to me. And please keep me in CC: as I am not on that mail list. > Rodney W. Grimes wrote: > > ----- Forwarded message from bugzilla-noreply@freebsd.org ----- > > > > Delivered-To: freebsd-rc@mailman.ysv.freebsd.org > > From: bugzilla-noreply@freebsd.org > > To: freebsd-rc@freebsd.org > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199127 > > > > Chris Rees changed: > > > > What |Removed |Added > > ---------------------------------------------------------------------------- > > CC| |crees@FreeBSD.org > > > > --- Comment #2 from Chris Rees --- > > Created attachment 185920 > > --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=185920&action=edit > > Use command_args not rc_flags to avoid rc.conf messing up configuration > > > > I've come across this bug too, but only realised after seeing this one :) > > > > On my machine the pidfile doesn't appear because I've overridden ntpd_flags in > > rc.conf. > > > > The correct use is to have command_args for non-configurable stuff, not (ab)use > > ${name}_flags and hope no-one changes them! > > > > Please would someone approve me to commit this? > > > > Cheers! > > > > Chris > > > RG> I actually think this is pilot error, when you override any *_flags > > RG> in /etc/rc.conf you must take into consideration all things that > RG> the defaults did. > > RG>For ntpd_flags: ntpd_flags="-p /var/run/ntpd.pid -f /var/db/ntpd.drift" > RG>If you override that, and want -p and -f args you should be setting > RG>the correct way to do this for your example rc.conf would be: > RG>ntpd_enable="yes" > RG>ntpd_config="/conf/ME/ntp.conf" > RG>ntpd_sync_on_start="yes" > RG>ntpd_flags="-p /var/run/ntpd.pid -f ${ntpd_config} -4" > > RG>Your patch would actually hardcode ntpd_flags into the > RG>rc.d file which would be a very bad idea. > > Sorry, but I have to disagree here. ntpd is the only file I > can see that sets any flags in defaults/rc.conf that are actually > unnecessary to configure. In fact, changing the argument to -p > completely breaks the rc script and makes it unable to stop ntpd. > This can't possibly by pilot error, more code error. Ok, I can see the issue with -p being non trivial and probably an extreme case for anyone wanting to mess with. I agree that -p should be removed from ntpd_flags in /etc/defaults/rc.conf and /etc/rc.d/ntpd It may be desirable at some time to add routines to parse a -p or -P out of a _flags so that these cases can be handled, but at this point in time that is far beyond the issues here. My original point that if your are going to overide a _flags from /etc/defaults/rc.conf it is your responsibility to copy the current value being set from the defaults and modify it to suit your needs. Expecting _flags to actually be an _addflags is a bad assumption the user has made in this bug report. My above recomended settings to /etc/rc.conf would infact eleviate the problem the original bug submitter had. > If you look down defaults/rc.conf, nearly all the _flags > values are empty by default, or have a couple of *configurable* > defaults. Perhaps you could argue that the placement of the > database file should be configurable (I'd suggest not as it's > pointless), but you can't possibly say that an rc.conf setting > should easily be able to break the script? Then we shall disagree on that point, if it was so pointless to allow altering the location of the "database"(sic), I think you mean config file, then why does the -f option even exist for ntpd? > > This is what the variable command_args is for, and why I suggest using it! > No one needs to mess about with pidfiles in rc.conf. I think that is a fairly reasonble view, but I would change the wording from "No one" to "Extermly rare" > Most other scripts do the right thing: > > [crees@zeus]/etc/rc.d% grep command_args * | grep pidfile > bsnmpd:command_args="-p ${pidfile}" Agreeable with that. > bthidd:command_args="-c ${config} -H ${hids} -p ${pidfile}" I am not sure I see that adding 2 variables to /etc/defaults/rc.conf is any better than a properly crafted bthidd_flags variable. What your advocating would be having every possible option to every command be listed as a variable in /etc/defaults/rc.conf and removing all the _flags. I am not sure this is the right path to go down. I do concide that -p and -P are probably easier to just deal with for now, but I can not agree that we need _config _hids _etc as has started to happen. > hostapd:command_args="-P ${pidfile} -B ${conf_file}" > wpa_supplicant:command_args="-B -i $ifn -c $conf_file -D $driver -P $pidfile" I wont even start on how broekn wpa_supplicant's rc files are.... > > [crees@zeus]/etc/rc.d% grep _flags /etc/defaults/rc.conf | grep pid > pppoed_flags="-P /var/run/pppoed.pid" # Flags to pppoed (if enabled). > ntpd_flags="-p /var/run/ntpd.pid -f /var/db/ntpd.drift" > > I think pppoed is also wrong. What makes it wrong? Your unwillingness to copy the _flags from /etc/defaults/rc.conf into your /etc/rc.conf and edit what it is you want to add/change/remove? Yes, you can break things, but unix has always allowed one to walk around with a fairly full load of bullets in the toe gun. PS: The patch as provided appears to totally remove ntpd_flags from /etc/defaults/rc.conf, that is an error that must be corrected. -- Rod Grimes rgrimes@freebsd.org