From owner-freebsd-current@freebsd.org Sun Dec 29 00:27:12 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6DF0D1CCD2B for ; Sun, 29 Dec 2019 00:27:12 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "troutmask", Issuer "troutmask" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 47lhG669qMz3Q3X for ; Sun, 29 Dec 2019 00:27:10 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id xBT0R2VI068174 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sat, 28 Dec 2019 16:27:02 -0800 (PST) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id xBT0R279068173; Sat, 28 Dec 2019 16:27:02 -0800 (PST) (envelope-from sgk) Date: Sat, 28 Dec 2019 16:27:02 -0800 From: Steve Kargl To: "Rodney W. Grimes" Cc: freebsd-current@freebsd.org Subject: Re: OpenSSL breaks factor(6) Message-ID: <20191229002702.GA68167@troutmask.apl.washington.edu> Reply-To: sgk@troutmask.apl.washington.edu References: <20191228035155.GA62416@troutmask.apl.washington.edu> <201912280442.xBS4grnp041518@gndrsh.dnsmgr.net> <20191228051533.GA62606@troutmask.apl.washington.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191228051533.GA62606@troutmask.apl.washington.edu> User-Agent: Mutt/1.12.2 (2019-09-21) X-Rspamd-Queue-Id: 47lhG669qMz3Q3X X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=washington.edu (policy=none); spf=none (mx1.freebsd.org: domain of sgk@troutmask.apl.washington.edu has no SPF policy when checking 128.95.76.21) smtp.mailfrom=sgk@troutmask.apl.washington.edu X-Spamd-Result: default: False [-2.23 / 15.00]; ARC_NA(0.00)[]; HAS_REPLYTO(0.00)[sgk@troutmask.apl.washington.edu]; DMARC_POLICY_SOFTFAIL(0.10)[washington.edu : No valid SPF, No valid DKIM,none]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; IP_SCORE(-0.23)[ip: (0.05), ipnet: 128.95.0.0/16(-0.26), asn: 73(-0.91), country: US(-0.05)]; MIME_GOOD(-0.10)[text/plain]; REPLYTO_ADDR_EQ_FROM(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:73, ipnet:128.95.0.0/16, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Dec 2019 00:27:12 -0000 On Fri, Dec 27, 2019 at 09:15:33PM -0800, Steve Kargl wrote: > On Fri, Dec 27, 2019 at 08:42:53PM -0800, Rodney W. Grimes wrote: > > > On Fri, Dec 27, 2019 at 07:00:04PM -0800, Rodney W. Grimes wrote: > > > > > On Fri, Dec 27, 2019 at 01:47:17PM -0800, Steve Kargl wrote: > > > > > > > > > > This patch now includes a fix for hexadecimal conversion. It > > > > > simple scans the string for a hex digit in [a,...,f] and assumes > > > > > that a hexadecimal string has been entered. A string that includes > > > > > character from the decimal digits is assumed to by a decimal > > > > > representation. > > > > > > > > It looks to me that the old code did the common method of > > > > try to convert as decimal, if that fails, try it as hex, > > > > if that fails report an error. > > > > > > > > Why is is that this common logic no longer works? > > > > > > AFAICT, BN_dec2bn and BN_hex2bn from OpenSSL scan from left > > > to right, does a conversion with what is possible, and reports > > > success. That is, for 1abc, BN_dec2bn can convert 1 to 1 and > > > reports success. The local implementations of these functions, > > > when OpenSSL is not used, does not do this partial conversion. > > > > I think I see now, the local implementaton checks for whole > > string conversion with a test for newline or null as the last > > byte converted by strtoul, the OpenSSL does not do this. > > > > My patch fixes that. The manpage documents that '1abcp' should > convert '1abc'. The 'p' simply terminates the conversion. The > local implementations actually flags an error. I suspect the > logic never worked as intended. The use of OpenSSL functions > in factor(6) was introduced in r104722 by fanf@. > > > So why ever use the, um, IMHO broken for this application, > > SSL versions of these functions? Or if we do need to use > > them for some reason apply the whole string conversion > > checks as wrappers around them? > > You'll need to ask fanf@, but I suspect the SSL version > was introduced to allow the factoring of integers that > exceed (uint64_t)(-1). > Updated patch with a svn log message. * usr.bin/factor/factor.6: . Document support for hexadecimal numbers. . Document termination conditions for interactive input. . Correct the maximum value for 'stop'. * usr.bin/factor/factor.c: . Include stdbool for bool type. . New function, contains_hex_alpha_digits(), checks whether an string of digits contains one of the alpha digits for hexadecimal representations (ie., abcdef). This function determines if decimal or hexadecimal conversion is required. . In the WITHOUT_OPENSSL case, make BN_dec2bn() and BN_hex2bn() conform to the documented termination conditions for parsing a string. * usr.bin/primes/primes.c: . Fix a comment, which has been wrong since 2014-09-27 (r272207). Index: usr.bin/factor/factor.6 =================================================================== --- usr.bin/factor/factor.6 (revision 355983) +++ usr.bin/factor/factor.6 (working copy) @@ -36,7 +36,7 @@ .\" .\" chongo /\oo/\ .\" -.Dd October 10, 2002 +.Dd December 27, 2019 .Dt FACTOR 6 .Os .Sh NAME @@ -67,11 +67,20 @@ .Nm is invoked with no arguments, .Nm -reads numbers, one per line, from standard input, until end of file or error. +reads numbers, one per line, from standard input until end of file or 0 +is entered or an error occurs. Leading white-space and empty lines are ignored. Numbers may be preceded by a single .Ql + . Numbers are terminated by a non-digit character (such as a newline). +Numbers can be either decimal or hexadecimal strings. +If the string contains only decimal digits, it is treated as a +decimal representation for a number. +A hexadecimal string should not contain a +.Em 0x +or +.Em 0X +prefix. After a number is read, it is factored. .Pp The @@ -89,7 +98,7 @@ value must not be greater than the maximum. The default and maximum value of .Ar stop -is 3825123056546413050. +is 18446744073709551615. .Pp When the .Nm primes Index: usr.bin/factor/factor.c =================================================================== --- usr.bin/factor/factor.c (revision 355983) +++ usr.bin/factor/factor.c (working copy) @@ -71,6 +71,7 @@ #include #include #include +#include #include #include #include @@ -104,6 +105,7 @@ #endif +static bool contains_hex_alpha_digits(char *str); static void BN_print_dec_fp(FILE *, const BIGNUM *); static void pr_fact(BIGNUM *); /* print factors of a value */ @@ -148,21 +150,25 @@ for (p = buf; isblank(*p); ++p); if (*p == '\n' || *p == '\0') continue; + if (*p == '+') p++; if (*p == '-') errx(1, "negative numbers aren't permitted."); - if (BN_dec2bn(&val, buf) == 0 && - BN_hex2bn(&val, buf) == 0) - errx(1, "%s: illegal numeric format.", buf); + ch = contains_hex_alpha_digits(p) ? + BN_hex2bn(&val, p) : BN_dec2bn(&val, p); + if (ch == 0) + errx(1, "%s: illegal numeric format.", p); pr_fact(val); } /* Factor the arguments. */ else - for (; *argv != NULL; ++argv) { - if (argv[0][0] == '-') + for (p = *argv; p != NULL; p = *++argv) { + if (*p == '+') p++; + if (*p == '-') errx(1, "negative numbers aren't permitted."); - if (BN_dec2bn(&val, argv[0]) == 0 && - BN_hex2bn(&val, argv[0]) == 0) - errx(1, "%s: illegal numeric format.", argv[0]); + ch = contains_hex_alpha_digits(p) ? + BN_hex2bn(&val, p) : BN_dec2bn(&val, p); + if (ch == 0) + errx(1, "%s: illegal numeric format.", p); pr_fact(val); } exit(0); @@ -346,7 +352,7 @@ errno = 0; **a = strtoul(str, &p, 10); - return (errno == 0 && (*p == '\n' || *p == '\0')); + return (errno == 0 ? 1 : 0); /* OpenSSL returns 0 on error! */ } static int @@ -356,7 +362,7 @@ errno = 0; **a = strtoul(str, &p, 16); - return (errno == 0 && (*p == '\n' || *p == '\0')); + return (errno == 0 ? 1 : 0); /* OpenSSL returns 0 on error! */ } static BN_ULONG @@ -370,3 +376,17 @@ } #endif + +/* Check if the string contains a hexadecimal digit. */ +static bool +contains_hex_alpha_digits(char *str) +{ + char c, *p; + + for (p = str; *p; p++) { + c = tolower(*p); + if (c >= 'a' && c <= 'f') + return true; + } + return false; +} Index: usr.bin/primes/primes.c =================================================================== --- usr.bin/primes/primes.c (revision 355983) +++ usr.bin/primes/primes.c (working copy) @@ -55,7 +55,7 @@ * primes [-h] [start [stop]] * * Print primes >= start and < stop. If stop is omitted, - * the value 4294967295 (2^32-1) is assumed. If start is + * the value 18446744073709551615 (2^64-1) is assumed. If start is * omitted, start is read from standard input. * * validation check: there are 664579 primes between 0 and 10^7 -- Steve From owner-freebsd-current@freebsd.org Sun Dec 29 00:30:11 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DC3C31CD073 for ; Sun, 29 Dec 2019 00:30:11 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-TO1-obe.outbound.protection.outlook.com (mail-eopbgr670073.outbound.protection.outlook.com [40.107.67.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47lhKZ4Wbwz3QGN for ; Sun, 29 Dec 2019 00:30:10 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mBpiLLUPTS8zWKbGUSsDTVL+gAo2N1C3mq51SoES6EiN8enADMZvexHga998zSy3tvO99L5G1bSTy5t/Zn+x2uCi+6CzDQoENrZFGQA6o11O82Qh5iAkg7RtisxyU/VO8TwLdCLRuVC0rqcpP+67pmS7trO6AuqkPJFylSx7fcNi5NQiZ2VX8MlnN/bEBJwkfZi3aLzKWc39o7rELOrWtttiJaMNQRyRmzTWz0PaTWCXqysZQ0DaDlx7LoZnEZSzft9shPaSyHLki+lANp5nimCMj6/xox5mfyOhAZRgzuUeav9pZX+DQzXjcuZwYG1Xzu+61umXE9ceu3bEC42seg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/YPbhaMR/VjpUB0R3XwO+2Ly3Rn88GZi16ExGixnYvc=; b=YvizOs93jncM03TY6d6zIfXNO0XnDSS2pGQl1oBNfYcnqBX68lIjiRmpx6x6X3fwgzDATmMZQAAJtGYSYWaHhzBT2dVViLSAMol6V3ClozsRGpzIHKlsm2YofrDWNpQD1LZJtMd+fWqPkBvVpPtLvi+ALY7B7ZU+uvoXZZfZpfovnLYKHmuiQvz6kIjLQji9K3X9uiA9z7bWi+dvySaAtA/tNV+LYEXiQo5fznQVbrOwNBy7KpRy7OcO+YgmTy0pdDA5of+PAAeyyhYB7lA9vmX8Qsi3pT77fKIP9oOCpAOGL/n1KjYvaa3sXKjaneDjLCTbUiGURHxSgPny6R1ZvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=uoguelph.ca; dmarc=pass action=none header.from=uoguelph.ca; dkim=pass header.d=uoguelph.ca; arc=none Received: from YQBPR0101MB1427.CANPRD01.PROD.OUTLOOK.COM (52.132.69.153) by YQBPR0101MB1745.CANPRD01.PROD.OUTLOOK.COM (52.132.71.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2581.11; Sun, 29 Dec 2019 00:30:08 +0000 Received: from YQBPR0101MB1427.CANPRD01.PROD.OUTLOOK.COM ([fe80::7512:8580:8d82:6c94]) by YQBPR0101MB1427.CANPRD01.PROD.OUTLOOK.COM ([fe80::7512:8580:8d82:6c94%6]) with mapi id 15.20.2581.007; Sun, 29 Dec 2019 00:30:08 +0000 From: Rick Macklem To: "freebsd-current@freebsd.org" Subject: getting rid of sys/nfs/nfs_lock.c Thread-Topic: getting rid of sys/nfs/nfs_lock.c Thread-Index: AQHVvd4uYot+uGDYskWjg23o3Tr07A== Date: Sun, 29 Dec 2019 00:30:08 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 03545925-7243-41a0-ab56-08d78bf64232 x-ms-traffictypediagnostic: YQBPR0101MB1745: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0266491E90 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(366004)(396003)(136003)(39860400002)(189003)(199004)(786003)(4744005)(8936002)(52536014)(5660300002)(186003)(316002)(55016002)(33656002)(9686003)(6506007)(71200400001)(7696005)(64756008)(66556008)(6916009)(86362001)(81166006)(66446008)(76116006)(8676002)(66476007)(66946007)(81156014)(478600001)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:YQBPR0101MB1745; H:YQBPR0101MB1427.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2G6gZL5MMU8RXYv32QQGV5ENL4Ms5QF4pS4RqRzacwRaOcIKpO/9qgKIIla6M+0FjtwL6MY+ur4jWHKLdLEtC+zCSi4F89N+xR7+UkSna/IdOXaZXvFOF56n9i9Qo7YB0TuD27HGEzB1vyf0sZFXZm7kiFP5yVoLeJ95Dt8soewhhdFarn2cx0nrbIU+qeiUMnk2mSCeX31XiPguWbKv3+kpkM2nDGCegSrWIvYAC5gEC7xw2Cuwl6Not9v1narKXbnd5gjOkVO7rTWNI120uvS1vakGMo7XqR10nLPYZfLZ3EVswd+JzCGrOm6MDyFQj822jJmdqiJWDSNHLDXEmyRF2K/ZY8dKEvgQd3oVJ50o0iCs9wnET41n7gJB2gYZGVVfa4yjRxY+TxsvXWwneQwIJC0jitwtR4GUEj/rlwvWPLRW9PdLKAxLoHkjDuAx x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: 03545925-7243-41a0-ab56-08d78bf64232 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Dec 2019 00:30:08.2548 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Rz6G38HBKuTtXkB/vMzws0LQmB3izTrzx9ajqAFXRHVkYLXi0O119EAq7wdSM+9Lp7V1RsW3Zws0dUvrhwVEaw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQBPR0101MB1745 X-Rspamd-Queue-Id: 47lhKZ4Wbwz3QGN X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of rmacklem@uoguelph.ca designates 40.107.67.73 as permitted sender) smtp.mailfrom=rmacklem@uoguelph.ca X-Spamd-Result: default: False [-4.67 / 15.00]; RCVD_TLS_LAST(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[uoguelph.ca]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCPT_COUNT_ONE(0.00)[1]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-1.37)[ipnet: 40.64.0.0/10(-3.84), asn: 8075(-2.94), country: US(-0.05)]; RCVD_IN_DNSWL_NONE(0.00)[73.67.107.40.list.dnswl.org : 127.0.3.0]; TO_DN_EQ_ADDR_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:8075, ipnet:40.64.0.0/10, country:US]; ARC_ALLOW(-1.00)[i=1] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Dec 2019 00:30:11 -0000 Hi,=0A= =0A= sys/nfs/nfs_lock.c uses Giant. Since it has not been used by default since= =0A= March 2008, I suspect it can be removed from head without any impact.=0A= Post March 2008, the only way this code could be executed is by both=0A= building a kernel without "options NFSLOCKD" and deleting nfslockd.ko=0A= from the kernel boot directory and then running rpc.lockd on the system.=0A= =0A= I doubt anyone has been doing both of the above, but if you think it is=0A= still useful, please speak up. (I have an untested patch that replaces Gian= t=0A= with a regular mutex. I realized this code is not used when I trying to tes= t it.;-)=0A= =0A= Also, if it seems appropriate, I could commit a patch that makes it print o= ut=0A= "deprecated and going away before FreeBSD 13" message, but I doubt anyone= =0A= will ever see it.=0A= Should I do such a message and wait a few months for the deletion?=0A= =0A= Thanks for your comments, rick=0A= ps: The current patch that prepares the kernel for deletion of sys/nfs/nfs_= lock.c=0A= is in reviews.freebsd.org/D22933.=0A= =0A= From owner-freebsd-current@freebsd.org Sun Dec 29 00:32:42 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F3E3B1CD3C6 for ; Sun, 29 Dec 2019 00:32:41 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-TO1-obe.outbound.protection.outlook.com (mail-eopbgr670043.outbound.protection.outlook.com [40.107.67.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47lhNS4brCz3Qct for ; Sun, 29 Dec 2019 00:32:40 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QskNRd1NHMj/VkqWLp9+adiuw4694JnE8agQpH7YKpfQIDAk31r+OYJ+EDkKZOYJXpRfgLvrMFXMSwrUVZMM8mZNk95n01ZKs0nzIBd1jZ6DdElX5FI0yXdhOEVvviMY67sY94cZGv4ef6dt/Faayq4Nkcq18HEKUWeHy4W1jCcDJHovHq8pH6U8WviOXaN+C6Im4B1gMlRQzJ6G70Dsxl/lN16co4h+cbbfOmuOkZssWv5w5JR94Nb2O0528VII8GAYLja3VfEiisek7ADjIMibb2fTbvX2RhYPxggiPfNrl/pmjYO2gfjb1WZA4fYjUZ2rHuSF9Xc2kSVuOcjjVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oz/Bgw0EL1E7xYKQ75OH6pSdUJgsYfoyYVBWb/0qXi8=; b=QYNRc1nYwBq/bTfwZsuaZHcFH1aSM4dRx9MJDBvhUfkmRySTe1donzXiYtaebUcQWv6nkuKzac6x0qrwVY6/FMH9TdCMM1RU2WyXUHFuiw0mNFh1lvtlNmFxLHs8YgUT40+1baqQq2xrfb9UuSgU05XMMv5AW8CjEp93H2NbSLydDcwKvL7QFC0jP9aZ08oF9kGntunGKmLwMUGRf4tfl/x6kQup+a6Uzy/m8BDxW9cc0hbClF0g5Oeygisc/gYvy8uzYnd/fnpsrBDfZAPc78YT+g9t8zUbzpzktRXEk3etIjwLmxhkSx8LEBT+v0QcAFRhMVL7dVExqQr/xArtVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=uoguelph.ca; dmarc=pass action=none header.from=uoguelph.ca; dkim=pass header.d=uoguelph.ca; arc=none Received: from YQBPR0101MB1427.CANPRD01.PROD.OUTLOOK.COM (52.132.69.153) by YQBPR0101MB1745.CANPRD01.PROD.OUTLOOK.COM (52.132.71.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2581.11; Sun, 29 Dec 2019 00:32:39 +0000 Received: from YQBPR0101MB1427.CANPRD01.PROD.OUTLOOK.COM ([fe80::7512:8580:8d82:6c94]) by YQBPR0101MB1427.CANPRD01.PROD.OUTLOOK.COM ([fe80::7512:8580:8d82:6c94%6]) with mapi id 15.20.2581.007; Sun, 29 Dec 2019 00:32:39 +0000 From: Rick Macklem To: "freebsd-current@freebsd.org" Subject: Re: getting rid of sys/nfs/nfs_lock.c Thread-Topic: getting rid of sys/nfs/nfs_lock.c Thread-Index: AQHVvd4uYot+uGDYskWjg23o3Tr07KfQQvDH Date: Sun, 29 Dec 2019 00:32:39 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 87e00d51-2aa7-4dba-ebcc-08d78bf69c0e x-ms-traffictypediagnostic: YQBPR0101MB1745: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0266491E90 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(366004)(396003)(136003)(39860400002)(189003)(199004)(786003)(8936002)(52536014)(5660300002)(186003)(316002)(55016002)(33656002)(9686003)(53546011)(6506007)(71200400001)(7696005)(2940100002)(64756008)(66556008)(6916009)(86362001)(966005)(81166006)(66446008)(76116006)(8676002)(66476007)(66946007)(81156014)(478600001)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:YQBPR0101MB1745; H:YQBPR0101MB1427.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: C2h2VBDR5P6h/6AKAw7VV3S1EUgwcmkHLdjZjaPfrODgCH9x3Ix69G0vcMgQkV4kPs7fNpLMBK8wiq5peCvfdoJPPoduwjOl3LAxzJVdT4l2eQuyWLtWRvI8yuRlRLPDiXiNSBwG2SkkW2wHl6g6hf2qGkPIVWv2pf/2Gmlufo/HDviooqjnMRiUeVXdc01fj8TLIcsmMxoblo7aX/XdNK4wiiQPAeI16pZ48/vzyVt7RXREiyJO0rqlYNVELgnlG9xpR4jk4mXkLrAVOapbE76qo0+wHjWSMCgDO3m/52os8C/02kHOtPk8Y/V/1KriFBmS1RsZl/YJFiNdZHQFk3btyzOirB4uaoRVDvvThi+Z8w4O5TpA0Pwhene3lDdJK8zK3FZYvacVGH3xusAjt1f9knIHRaZKxJxRsqKizbN71CrxCSdDd3LHaw8WdF6scAEbJaBobY6NgM9Aod/QAL2MsE+LnGrKP5d/vx5au+4= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: 87e00d51-2aa7-4dba-ebcc-08d78bf69c0e X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Dec 2019 00:32:39.2014 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gfQUQZFI7zGlEYGODJty/YOYhokI2g1qKqsB5CQ5KiB1531Vx/fbHYRIjGh8U+YPdzRX8sYFJdL3tAJMJ7Xiqw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQBPR0101MB1745 X-Rspamd-Queue-Id: 47lhNS4brCz3Qct X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of rmacklem@uoguelph.ca designates 40.107.67.43 as permitted sender) smtp.mailfrom=rmacklem@uoguelph.ca X-Spamd-Result: default: False [-4.67 / 15.00]; RCVD_TLS_LAST(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[uoguelph.ca]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCPT_COUNT_ONE(0.00)[1]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-1.37)[ipnet: 40.64.0.0/10(-3.84), asn: 8075(-2.94), country: US(-0.05)]; RCVD_IN_DNSWL_NONE(0.00)[43.67.107.40.list.dnswl.org : 127.0.3.0]; TO_DN_EQ_ADDR_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:8075, ipnet:40.64.0.0/10, country:US]; ARC_ALLOW(-1.00)[i=1] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Dec 2019 00:32:42 -0000 Oh, I forgot to mention that, post March 2008, this code was replaced by th= e in kernel nlm found in sys/nlm, which is why it has been in use. ________________________________________ From: owner-freebsd-current@freebsd.org = on behalf of Rick Macklem Sent: Saturday, December 28, 2019 7:30 PM To: freebsd-current@freebsd.org Subject: getting rid of sys/nfs/nfs_lock.c Hi, sys/nfs/nfs_lock.c uses Giant. Since it has not been used by default since March 2008, I suspect it can be removed from head without any impact. Post March 2008, the only way this code could be executed is by both building a kernel without "options NFSLOCKD" and deleting nfslockd.ko from the kernel boot directory and then running rpc.lockd on the system. I doubt anyone has been doing both of the above, but if you think it is still useful, please speak up. (I have an untested patch that replaces Gian= t with a regular mutex. I realized this code is not used when I trying to tes= t it.;-) Also, if it seems appropriate, I could commit a patch that makes it print o= ut "deprecated and going away before FreeBSD 13" message, but I doubt anyone will ever see it. Should I do such a message and wait a few months for the deletion? Thanks for your comments, rick ps: The current patch that prepares the kernel for deletion of sys/nfs/nfs_= lock.c is in reviews.freebsd.org/D22933. _______________________________________________ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" From owner-freebsd-current@freebsd.org Sun Dec 29 03:46:57 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 66D5D1D2F85 for ; Sun, 29 Dec 2019 03:46:57 +0000 (UTC) (envelope-from drosih@rpi.edu) Received: from smtp9.server.rpi.edu (smtp9.server.rpi.edu [128.113.2.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "canit.localdomain", Issuer "canit.localdomain" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 47lmhc1J7sz44LB for ; Sun, 29 Dec 2019 03:46:55 +0000 (UTC) (envelope-from drosih@rpi.edu) Received: from smtp-auth3.server.rpi.edu (route.canit.rpi.edu [128.113.2.233]) by smtp9.server.rpi.edu (8.14.4/8.14.4/Debian-8+deb8u2) with ESMTP id xBT3kr3F036723 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 28 Dec 2019 22:46:53 -0500 Received: from smtp-auth3.server.rpi.edu (localhost [127.0.0.1]) by smtp-auth3.server.rpi.edu (Postfix) with ESMTP id 562065800E; Sat, 28 Dec 2019 22:46:53 -0500 (EST) Received: from [172.16.67.1] (gilead-qc124.netel.rpi.edu [128.113.124.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: drosih) by smtp-auth3.server.rpi.edu (Postfix) with ESMTPSA id 38C5E58003; Sat, 28 Dec 2019 22:46:53 -0500 (EST) From: "Garance A Drosehn" To: "Steve Kargl" Cc: freebsd-current@freebsd.org Subject: Re: OpenSSL breaks factor(6) Date: Sat, 28 Dec 2019 22:46:52 -0500 X-Mailer: MailMate (1.13.1r5671) Message-ID: <92557725-6612-46ED-BA39-FCE91EF6D091@rpi.edu> In-Reply-To: <20191227224212.GA61594@troutmask.apl.washington.edu> References: <20191227212530.GA61314@troutmask.apl.washington.edu> <20191227214717.GA61475@troutmask.apl.washington.edu> <20191227224212.GA61594@troutmask.apl.washington.edu> MIME-Version: 1.0 Content-Type: text/plain X-Virus-Scanned: ClamAV using ClamSMTP X-Bayes-Prob: 0.0001 (Score 0, tokens from: outgoing, @@RPTN) X-Spam-Score: 0.00 () [Hold at 10.10] X-CanIt-Incident-Id: 021HDKReD X-CanIt-Geo: ip=128.113.124.17; country=US; latitude=37.7510; longitude=-97.8220; http://maps.google.com/maps?q=37.7510,-97.8220&z=6 X-CanItPRO-Stream: outgoing X-Canit-Stats-ID: Bayes signature not available X-Scanned-By: CanIt (www . roaringpenguin . com) on 128.113.2.229 X-Rspamd-Queue-Id: 47lmhc1J7sz44LB X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=pass (policy=none) header.from=rpi.edu; spf=pass (mx1.freebsd.org: domain of drosih@rpi.edu designates 128.113.2.229 as permitted sender) smtp.mailfrom=drosih@rpi.edu X-Spamd-Result: default: False [-4.77 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:128.113.2.225/28]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_MED(-0.20)[229.2.113.128.list.dnswl.org : 127.0.11.2]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[rpi.edu,none]; IP_SCORE(-1.77)[ipnet: 128.113.0.0/16(-4.89), asn: 91(-3.91), country: US(-0.05)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:91, ipnet:128.113.0.0/16, country:US]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Dec 2019 03:46:57 -0000 On 27 Dec 2019, at 17:42, Steve Kargl wrote: > > This patch now includes a fix for hexadecimal conversion. It > simple scans the string for a hex digit in [a,...,f] and assumes > that a hexadecimal string has been entered. A string that includes > character from the decimal digits is assumed to by a decimal > representation. What if the user wants to factor a hexadecimal value which does not happen to include [a...f]? How about recognizing a prefix of '0x' as a way to indicate the value is hexadecimal? -- Garance Alistair Drosehn = drosih@rpi.edu Senior Systems Programmer or gad@FreeBSD.org Rensselaer Polytechnic Institute; Troy, NY; USA From owner-freebsd-current@freebsd.org Sun Dec 29 05:10:39 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C3CAB1D4603 for ; Sun, 29 Dec 2019 05:10:39 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "troutmask", Issuer "troutmask" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 47lpYB33Kyz47TP for ; Sun, 29 Dec 2019 05:10:37 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id xBT5AZrw068956 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sat, 28 Dec 2019 21:10:35 -0800 (PST) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id xBT5AZBf068955; Sat, 28 Dec 2019 21:10:35 -0800 (PST) (envelope-from sgk) Date: Sat, 28 Dec 2019 21:10:35 -0800 From: Steve Kargl To: Garance A Drosehn Cc: freebsd-current@freebsd.org Subject: Re: OpenSSL breaks factor(6) Message-ID: <20191229051035.GA68947@troutmask.apl.washington.edu> Reply-To: sgk@troutmask.apl.washington.edu References: <20191227212530.GA61314@troutmask.apl.washington.edu> <20191227214717.GA61475@troutmask.apl.washington.edu> <20191227224212.GA61594@troutmask.apl.washington.edu> <92557725-6612-46ED-BA39-FCE91EF6D091@rpi.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <92557725-6612-46ED-BA39-FCE91EF6D091@rpi.edu> User-Agent: Mutt/1.12.2 (2019-09-21) X-Rspamd-Queue-Id: 47lpYB33Kyz47TP X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=washington.edu (policy=none); spf=none (mx1.freebsd.org: domain of sgk@troutmask.apl.washington.edu has no SPF policy when checking 128.95.76.21) smtp.mailfrom=sgk@troutmask.apl.washington.edu X-Spamd-Result: default: False [-2.23 / 15.00]; ARC_NA(0.00)[]; HAS_REPLYTO(0.00)[sgk@troutmask.apl.washington.edu]; DMARC_POLICY_SOFTFAIL(0.10)[washington.edu : No valid SPF, No valid DKIM,none]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; IP_SCORE(-0.23)[ip: (0.05), ipnet: 128.95.0.0/16(-0.26), asn: 73(-0.91), country: US(-0.05)]; MIME_GOOD(-0.10)[text/plain]; REPLYTO_ADDR_EQ_FROM(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:73, ipnet:128.95.0.0/16, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Dec 2019 05:10:39 -0000 On Sat, Dec 28, 2019 at 10:46:52PM -0500, Garance A Drosehn wrote: > On 27 Dec 2019, at 17:42, Steve Kargl wrote: > > > > This patch now includes a fix for hexadecimal conversion. It > > simple scans the string for a hex digit in [a,...,f] and assumes > > that a hexadecimal string has been entered. A string that includes > > character from the decimal digits is assumed to by a decimal > > representation. > > What if the user wants to factor a hexadecimal value which does not > happen to include [a...f]? > > How about recognizing a prefix of '0x' as a way to indicate the value > is hexadecimal? > An interested user will need to add that support. AFAIK, factor(6) has never recognized the 0x prefix, and I'm not trying to add new features. I'm simply fixing factor(6) to match its documentation, and trying to ensure WITH_OPENSSL and WITHOUT_OPENSSL give the same results where applicable. The logic is to first try to convert the string to a decimal if the leading digits are members of the set [0,...,9]. If this conversion fails, then try to convert the string as a hexadecimal number. A problem occurs because OpenSSL's BN_dec2bn does not fail for a number like '1abc' (converts it to 1) whereas the local implementation of BN_dec2bn fails during the conversion, and so the BN_hex2bn function is executed and '1abc' is converted. -- Steve From owner-freebsd-current@freebsd.org Sun Dec 29 05:34:57 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1150D1D4CB5 for ; Sun, 29 Dec 2019 05:34:57 +0000 (UTC) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47lq5C5t0yz48K9 for ; Sun, 29 Dec 2019 05:34:55 +0000 (UTC) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id xBT5YqBr046010; Sat, 28 Dec 2019 21:34:52 -0800 (PST) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: (from freebsd-rwg@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id xBT5YqVp046009; Sat, 28 Dec 2019 21:34:52 -0800 (PST) (envelope-from freebsd-rwg) From: "Rodney W. Grimes" Message-Id: <201912290534.xBT5YqVp046009@gndrsh.dnsmgr.net> Subject: Re: OpenSSL breaks factor(6) In-Reply-To: <20191229051035.GA68947@troutmask.apl.washington.edu> To: sgk@troutmask.apl.washington.edu Date: Sat, 28 Dec 2019 21:34:52 -0800 (PST) CC: Garance A Drosehn , freebsd-current@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 47lq5C5t0yz48K9 X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of freebsd-rwg@gndrsh.dnsmgr.net has no SPF policy when checking 69.59.192.140) smtp.mailfrom=freebsd-rwg@gndrsh.dnsmgr.net X-Spamd-Result: default: False [-0.46 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.72)[-0.716,0]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[dnsmgr.net]; AUTH_NA(1.00)[]; NEURAL_HAM_LONG(-0.68)[-0.682,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:13868, ipnet:69.59.192.0/19, country:US]; MID_RHS_MATCH_FROM(0.00)[]; IP_SCORE(0.04)[ip: (0.14), ipnet: 69.59.192.0/19(0.07), asn: 13868(0.02), country: US(-0.05)]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Dec 2019 05:34:57 -0000 > On Sat, Dec 28, 2019 at 10:46:52PM -0500, Garance A Drosehn wrote: > > On 27 Dec 2019, at 17:42, Steve Kargl wrote: > > > > > > This patch now includes a fix for hexadecimal conversion. It > > > simple scans the string for a hex digit in [a,...,f] and assumes > > > that a hexadecimal string has been entered. A string that includes > > > character from the decimal digits is assumed to by a decimal > > > representation. > > > > What if the user wants to factor a hexadecimal value which does not > > happen to include [a...f]? > > > > How about recognizing a prefix of '0x' as a way to indicate the value > > is hexadecimal? > > > > An interested user will need to add that support. AFAIK, factor(6) > has never recognized the 0x prefix, and I'm not trying to add new > features. I'm simply fixing factor(6) to match its documentation, > and trying to ensure WITH_OPENSSL and WITHOUT_OPENSSL give the > same results where applicable. > > The logic is to first try to convert the string to a decimal if > the leading digits are members of the set [0,...,9]. If this > conversion fails, then try to convert the string as a hexadecimal > number. A problem occurs because OpenSSL's BN_dec2bn does not fail > for a number like '1abc' (converts it to 1) whereas the local > implementation of BN_dec2bn fails during the conversion, and so > the BN_hex2bn function is executed and '1abc' is converted. Wasnt the hex conversion undocumented? Since it seems to have issues, and is of dubious value might it might be best to just remove it? > -- > Steve -- Rod Grimes rgrimes@freebsd.org From owner-freebsd-current@freebsd.org Sun Dec 29 06:34:45 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A547F1D6239 for ; Sun, 29 Dec 2019 06:34:45 +0000 (UTC) (envelope-from drosih@rpi.edu) Received: from smtp10.server.rpi.edu (smtp10.server.rpi.edu [128.113.2.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "canit.localdomain", Issuer "canit.localdomain" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 47lrQF0mjDz4BfB for ; Sun, 29 Dec 2019 06:34:44 +0000 (UTC) (envelope-from drosih@rpi.edu) Received: from smtp-auth1.server.rpi.edu (route.canit.rpi.edu [128.113.2.231]) by smtp10.server.rpi.edu (8.14.4/8.14.4/Debian-8+deb8u2) with ESMTP id xBT6YUik026784 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 29 Dec 2019 01:34:33 -0500 Received: from smtp-auth1.server.rpi.edu (localhost [127.0.0.1]) by smtp-auth1.server.rpi.edu (Postfix) with ESMTP id 02ACA58007; Sun, 29 Dec 2019 01:34:30 -0500 (EST) Received: from [172.16.67.1] (gilead-qc124.netel.rpi.edu [128.113.124.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: drosih) by smtp-auth1.server.rpi.edu (Postfix) with ESMTPSA id BC9E258002; Sun, 29 Dec 2019 01:34:29 -0500 (EST) From: "Garance A Drosehn" To: "Steve Kargl" Cc: freebsd-current@freebsd.org Subject: Re: OpenSSL breaks factor(6) Date: Sun, 29 Dec 2019 01:34:28 -0500 X-Mailer: MailMate (1.13.1r5671) Message-ID: In-Reply-To: <20191229051035.GA68947@troutmask.apl.washington.edu> References: <20191227212530.GA61314@troutmask.apl.washington.edu> <20191227214717.GA61475@troutmask.apl.washington.edu> <20191227224212.GA61594@troutmask.apl.washington.edu> <92557725-6612-46ED-BA39-FCE91EF6D091@rpi.edu> <20191229051035.GA68947@troutmask.apl.washington.edu> MIME-Version: 1.0 Content-Type: text/plain; markup=markdown X-Virus-Scanned: ClamAV using ClamSMTP X-Bayes-Prob: 0.0001 (Score 0, tokens from: outgoing, @@RPTN) X-Spam-Score: 0.00 () [Hold at 10.10] X-CanIt-Incident-Id: 031HGyu0M X-CanIt-Geo: ip=128.113.124.17; country=US; latitude=37.7510; longitude=-97.8220; http://maps.google.com/maps?q=37.7510,-97.8220&z=6 X-CanItPRO-Stream: outgoing X-Canit-Stats-ID: Bayes signature not available X-Scanned-By: CanIt (www . roaringpenguin . com) on 128.113.2.230 X-Rspamd-Queue-Id: 47lrQF0mjDz4BfB X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=pass (policy=none) header.from=rpi.edu; spf=pass (mx1.freebsd.org: domain of drosih@rpi.edu designates 128.113.2.230 as permitted sender) smtp.mailfrom=drosih@rpi.edu X-Spamd-Result: default: False [-4.77 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:128.113.2.225/28]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_MED(-0.20)[230.2.113.128.list.dnswl.org : 127.0.11.2]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[rpi.edu,none]; IP_SCORE(-1.77)[ipnet: 128.113.0.0/16(-4.90), asn: 91(-3.92), country: US(-0.05)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:91, ipnet:128.113.0.0/16, country:US]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Dec 2019 06:34:45 -0000 On 29 Dec 2019, at 0:10, Steve Kargl wrote: > On Sat, Dec 28, 2019 at 10:46:52PM -0500, Garance A Drosehn wrote: >> >> What if the user wants to factor a hexadecimal value which does not >> happen to include [a...f]? >> >> How about recognizing a prefix of '0x' as a way to indicate the value >> is hexadecimal? > > An interested user will need to add that support. AFAIK, factor(6) > has never recognized the 0x prefix, and I'm not trying to add new > features. I'm simply fixing factor(6) to match its documentation, > and trying to ensure WITH_OPENSSL and WITHOUT_OPENSSL give the > same results where applicable. Well, I'd be willing to do the work to add the new feature, and also make the commit. It'd be a nice easy task for me to tackle... :) But I think documenting that "hex works, but only for hex values which have at least one A-F in the value" is not something that I'd want to draw attention to via documentation. -- Garance Alistair Drosehn = drosih@rpi.edu or gad@FreeBSD.org From owner-freebsd-current@freebsd.org Sun Dec 29 06:42:40 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 39CBA1D65D3 for ; Sun, 29 Dec 2019 06:42:40 +0000 (UTC) (envelope-from dclarke@blastwave.org) Received: from jax4mhob02.myregisteredsite.com (jax4mhob02.myregisteredsite.com [64.69.218.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.registeredsite.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47lrbM1MMBz4C40 for ; Sun, 29 Dec 2019 06:42:38 +0000 (UTC) (envelope-from dclarke@blastwave.org) Received: from mailpod.hostingplatform.com (atl4qobmail01pod2.registeredsite.com [10.30.77.35]) by jax4mhob02.myregisteredsite.com (8.14.4/8.14.4) with ESMTP id xBT6gaoE014481 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Sun, 29 Dec 2019 01:42:37 -0500 Received: (qmail 18010 invoked by uid 0); 29 Dec 2019 06:42:36 -0000 X-TCPREMOTEIP: 99.253.169.68 X-Authenticated-UID: dclarke@blastwave.org Received: from unknown (HELO ?172.16.35.2?) (dclarke@blastwave.org@99.253.169.68) by 0 with ESMTPA; 29 Dec 2019 06:42:36 -0000 Subject: Re: getting rid of sys/nfs/nfs_lock.c To: freebsd-current@freebsd.org References: From: Dennis Clarke Message-ID: <663f9bf2-c556-109f-dfdb-5eeb00fc0c2e@blastwave.org> Date: Sun, 29 Dec 2019 01:42:35 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:72.0) Gecko/20100101 Thunderbird/72.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 47lrbM1MMBz4C40 X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of dclarke@blastwave.org has no SPF policy when checking 64.69.218.82) smtp.mailfrom=dclarke@blastwave.org X-Spamd-Result: default: False [0.84 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-0.33)[-0.329,0]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-0.03)[-0.029,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; TO_DN_NONE(0.00)[]; AUTH_NA(1.00)[]; RCPT_COUNT_ONE(0.00)[1]; RCVD_COUNT_THREE(0.00)[3]; RCVD_TLS_LAST(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[82.218.69.64.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; DMARC_NA(0.00)[blastwave.org]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:19871, ipnet:64.69.218.0/23, country:US]; MID_RHS_MATCH_FROM(0.00)[]; IP_SCORE(0.30)[ipnet: 64.69.218.0/23(-0.12), asn: 19871(1.67), country: US(-0.05)] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Dec 2019 06:42:40 -0000 On 12/28/19 7:30 PM, Rick Macklem wrote: > Hi, > > sys/nfs/nfs_lock.c uses Giant. Since it has not been used by default since > March 2008, I suspect it can be removed from head without any impact. > Post March 2008, the only way this code could be executed is by both > building a kernel without "options NFSLOCKD" and deleting nfslockd.ko > from the kernel boot directory and then running rpc.lockd on the system. > > I doubt anyone has been doing both of the above, but if you think it is > still useful, please speak up. (I have an untested patch that replaces Giant > with a regular mutex. I realized this code is not used when I trying to test it.;-) > > Also, if it seems appropriate, I could commit a patch that makes it print out > "deprecated and going away before FreeBSD 13" message, but I doubt anyone > will ever see it. > Should I do such a message and wait a few months for the deletion? Such a message is a good idea. I am curious if there is any way in which we would see that message when creating an NFS share via ZFS set sharenfs='foo' ? -- Dennis Clarke RISC-V/SPARC/PPC/ARM/CISC UNIX and Linux spoken GreyBeard and suspenders optional From owner-freebsd-current@freebsd.org Sun Dec 29 06:50:43 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 159C61D6993 for ; Sun, 29 Dec 2019 06:50:43 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "troutmask", Issuer "troutmask" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 47lrmf12SZz4CKQ for ; Sun, 29 Dec 2019 06:50:41 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id xBT6odR2069310 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sat, 28 Dec 2019 22:50:39 -0800 (PST) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id xBT6od0m069309; Sat, 28 Dec 2019 22:50:39 -0800 (PST) (envelope-from sgk) Date: Sat, 28 Dec 2019 22:50:39 -0800 From: Steve Kargl To: "Rodney W. Grimes" Cc: Garance A Drosehn , freebsd-current@freebsd.org Subject: Re: OpenSSL breaks factor(6) Message-ID: <20191229065039.GA69227@troutmask.apl.washington.edu> Reply-To: sgk@troutmask.apl.washington.edu References: <20191229051035.GA68947@troutmask.apl.washington.edu> <201912290534.xBT5YqVp046009@gndrsh.dnsmgr.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201912290534.xBT5YqVp046009@gndrsh.dnsmgr.net> User-Agent: Mutt/1.12.2 (2019-09-21) X-Rspamd-Queue-Id: 47lrmf12SZz4CKQ X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=washington.edu (policy=none); spf=none (mx1.freebsd.org: domain of sgk@troutmask.apl.washington.edu has no SPF policy when checking 128.95.76.21) smtp.mailfrom=sgk@troutmask.apl.washington.edu X-Spamd-Result: default: False [-2.23 / 15.00]; ARC_NA(0.00)[]; HAS_REPLYTO(0.00)[sgk@troutmask.apl.washington.edu]; DMARC_POLICY_SOFTFAIL(0.10)[washington.edu : No valid SPF, No valid DKIM,none]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_GOOD(-0.10)[text/plain]; REPLYTO_ADDR_EQ_FROM(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; IP_SCORE(-0.23)[ip: (0.05), ipnet: 128.95.0.0/16(-0.26), asn: 73(-0.91), country: US(-0.05)]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:73, ipnet:128.95.0.0/16, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Dec 2019 06:50:43 -0000 On Sat, Dec 28, 2019 at 09:34:52PM -0800, Rodney W. Grimes wrote: > > On Sat, Dec 28, 2019 at 10:46:52PM -0500, Garance A Drosehn wrote: > > > On 27 Dec 2019, at 17:42, Steve Kargl wrote: > > > > > > > > This patch now includes a fix for hexadecimal conversion. It > > > > simple scans the string for a hex digit in [a,...,f] and assumes > > > > that a hexadecimal string has been entered. A string that includes > > > > character from the decimal digits is assumed to by a decimal > > > > representation. > > > > > > What if the user wants to factor a hexadecimal value which does not > > > happen to include [a...f]? > > > > > > How about recognizing a prefix of '0x' as a way to indicate the value > > > is hexadecimal? > > > > > > > An interested user will need to add that support. AFAIK, factor(6) > > has never recognized the 0x prefix, and I'm not trying to add new > > features. I'm simply fixing factor(6) to match its documentation, > > and trying to ensure WITH_OPENSSL and WITHOUT_OPENSSL give the > > same results where applicable. > > > > The logic is to first try to convert the string to a decimal if > > the leading digits are members of the set [0,...,9]. If this > > conversion fails, then try to convert the string as a hexadecimal > > number. A problem occurs because OpenSSL's BN_dec2bn does not fail > > for a number like '1abc' (converts it to 1) whereas the local > > implementation of BN_dec2bn fails during the conversion, and so > > the BN_hex2bn function is executed and '1abc' is converted. > > Wasnt the hex conversion undocumented? Yes, and I fixed the manpage to document the behavior. And, I fixed factor(6) to match the documentation in other aspects (e.g., leading '+' character). > Since it seems to have issues, and is of dubious value > might it might be best to just remove it? It has been a part of FreeBSD's factor since r104722 | fanf | 2002-10-09 That is 17 years. Are you sure no one is using this feature in some script? What about backwards compatibility? AFAICT, with my limited testing, my patch should fix the issues that I discovered. Do what you want with the patch (including ignoring it). Hopefully, someone in the FreeBSD project will now recognize that factor(6) with and without OpenSSL gives inconsistent results, and neither matches factor(6)'s manpage. -- Steve From owner-freebsd-current@freebsd.org Sun Dec 29 07:17:36 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0C5AB1D7080 for ; Sun, 29 Dec 2019 07:17:36 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "troutmask", Issuer "troutmask" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 47lsMf2dk7z4DXg for ; Sun, 29 Dec 2019 07:17:33 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id xBT7HVYG069916 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sat, 28 Dec 2019 23:17:31 -0800 (PST) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id xBT7HVC1069915; Sat, 28 Dec 2019 23:17:31 -0800 (PST) (envelope-from sgk) Date: Sat, 28 Dec 2019 23:17:31 -0800 From: Steve Kargl To: Garance A Drosehn Cc: freebsd-current@freebsd.org Subject: Re: OpenSSL breaks factor(6) Message-ID: <20191229071731.GB69227@troutmask.apl.washington.edu> Reply-To: sgk@troutmask.apl.washington.edu References: <20191227212530.GA61314@troutmask.apl.washington.edu> <20191227214717.GA61475@troutmask.apl.washington.edu> <20191227224212.GA61594@troutmask.apl.washington.edu> <92557725-6612-46ED-BA39-FCE91EF6D091@rpi.edu> <20191229051035.GA68947@troutmask.apl.washington.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) X-Rspamd-Queue-Id: 47lsMf2dk7z4DXg X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=washington.edu (policy=none); spf=none (mx1.freebsd.org: domain of sgk@troutmask.apl.washington.edu has no SPF policy when checking 128.95.76.21) smtp.mailfrom=sgk@troutmask.apl.washington.edu X-Spamd-Result: default: False [-2.23 / 15.00]; ARC_NA(0.00)[]; HAS_REPLYTO(0.00)[sgk@troutmask.apl.washington.edu]; DMARC_POLICY_SOFTFAIL(0.10)[washington.edu : No valid SPF, No valid DKIM,none]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; IP_SCORE(-0.23)[ip: (0.05), ipnet: 128.95.0.0/16(-0.26), asn: 73(-0.91), country: US(-0.05)]; MIME_GOOD(-0.10)[text/plain]; REPLYTO_ADDR_EQ_FROM(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:73, ipnet:128.95.0.0/16, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Dec 2019 07:17:36 -0000 On Sun, Dec 29, 2019 at 01:34:28AM -0500, Garance A Drosehn wrote: > On 29 Dec 2019, at 0:10, Steve Kargl wrote: > > > On Sat, Dec 28, 2019 at 10:46:52PM -0500, Garance A Drosehn wrote: > >> > >> What if the user wants to factor a hexadecimal value which does not > >> happen to include [a...f]? > >> > >> How about recognizing a prefix of '0x' as a way to indicate the value > >> is hexadecimal? > > > > An interested user will need to add that support. AFAIK, factor(6) > > has never recognized the 0x prefix, and I'm not trying to add new > > features. I'm simply fixing factor(6) to match its documentation, > > and trying to ensure WITH_OPENSSL and WITHOUT_OPENSSL give the > > same results where applicable. > > Well, I'd be willing to do the work to add the new feature, and also > make the commit. It'd be a nice easy task for me to tackle... :) > > But I think documenting that "hex works, but only for hex values > which have at least one A-F in the value" is not something that I'd > want to draw attention to via documentation. > You have a 17 year history to worry about as hexadecimal support was added by "r104720 | fanf | 2002-10-09". Compiling factor(6) with and without OpenSSL support after 2002-10-09 gives a utility with different inconsistent behavior. Current code: With OpenSSL % factor 1abc 1: 1 % factor 1abczzzz 1: 1 % factor +125 factor: +125: illegal numeric format. Without OpenSSL % factor 1abc 6844: 2 2 29 59 % factor 1abczzzz factor: 1abczzzz: illegal numeric format. % factor +125 125: 5 5 5 Patched code: With OpenSSL % factor 1abc 6844: 2 2 29 59 % factor 1abczzzz 6844: 2 2 29 59 % factor +125 125: 5 5 5 Without OpenSSL % factor 1abc 6844: 2 2 29 59 % factor 1abczzzz 6844: 2 2 29 59 % factor +125 125: 5 5 5 -- Steve From owner-freebsd-current@freebsd.org Sun Dec 29 07:29:09 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3343A1D73D9 for ; Sun, 29 Dec 2019 07:29:09 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "troutmask", Issuer "troutmask" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 47lsd03gnhz4Dvw for ; Sun, 29 Dec 2019 07:29:08 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id xBT7T6cm069989 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sat, 28 Dec 2019 23:29:06 -0800 (PST) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id xBT7T6fa069988; Sat, 28 Dec 2019 23:29:06 -0800 (PST) (envelope-from sgk) Date: Sat, 28 Dec 2019 23:29:06 -0800 From: Steve Kargl To: Garance A Drosehn Cc: freebsd-current@freebsd.org Subject: Re: OpenSSL breaks factor(6) Message-ID: <20191229072906.GA69981@troutmask.apl.washington.edu> Reply-To: sgk@troutmask.apl.washington.edu References: <20191227212530.GA61314@troutmask.apl.washington.edu> <20191227214717.GA61475@troutmask.apl.washington.edu> <20191227224212.GA61594@troutmask.apl.washington.edu> <92557725-6612-46ED-BA39-FCE91EF6D091@rpi.edu> <20191229051035.GA68947@troutmask.apl.washington.edu> <20191229071731.GB69227@troutmask.apl.washington.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191229071731.GB69227@troutmask.apl.washington.edu> User-Agent: Mutt/1.12.2 (2019-09-21) X-Rspamd-Queue-Id: 47lsd03gnhz4Dvw X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=washington.edu (policy=none); spf=none (mx1.freebsd.org: domain of sgk@troutmask.apl.washington.edu has no SPF policy when checking 128.95.76.21) smtp.mailfrom=sgk@troutmask.apl.washington.edu X-Spamd-Result: default: False [-2.23 / 15.00]; ARC_NA(0.00)[]; HAS_REPLYTO(0.00)[sgk@troutmask.apl.washington.edu]; DMARC_POLICY_SOFTFAIL(0.10)[washington.edu : No valid SPF, No valid DKIM,none]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; IP_SCORE(-0.23)[ip: (0.05), ipnet: 128.95.0.0/16(-0.26), asn: 73(-0.91), country: US(-0.05)]; MIME_GOOD(-0.10)[text/plain]; REPLYTO_ADDR_EQ_FROM(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:73, ipnet:128.95.0.0/16, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Dec 2019 07:29:09 -0000 On Sat, Dec 28, 2019 at 11:17:31PM -0800, Steve Kargl wrote: > On Sun, Dec 29, 2019 at 01:34:28AM -0500, Garance A Drosehn wrote: > > On 29 Dec 2019, at 0:10, Steve Kargl wrote: > > > > > On Sat, Dec 28, 2019 at 10:46:52PM -0500, Garance A Drosehn wrote: > > >> > > >> What if the user wants to factor a hexadecimal value which does not > > >> happen to include [a...f]? > > >> > > >> How about recognizing a prefix of '0x' as a way to indicate the value > > >> is hexadecimal? Here you go. '0x' support is undocumented. Index: usr.bin/factor/factor.6 =================================================================== --- usr.bin/factor/factor.6 (revision 355983) +++ usr.bin/factor/factor.6 (working copy) @@ -36,7 +36,7 @@ .\" .\" chongo /\oo/\ .\" -.Dd October 10, 2002 +.Dd December 27, 2019 .Dt FACTOR 6 .Os .Sh NAME @@ -67,11 +67,20 @@ .Nm is invoked with no arguments, .Nm -reads numbers, one per line, from standard input, until end of file or error. +reads numbers, one per line, from standard input until end of file or 0 +is entered or an error occurs. Leading white-space and empty lines are ignored. Numbers may be preceded by a single .Ql + . Numbers are terminated by a non-digit character (such as a newline). +Numbers can be either decimal or hexadecimal strings. +If the string contains only decimal digits, it is treated as a +decimal representation for a number. +A hexadecimal string should not contain a +.Em 0x +or +.Em 0X +prefix. After a number is read, it is factored. .Pp The @@ -89,7 +98,7 @@ value must not be greater than the maximum. The default and maximum value of .Ar stop -is 3825123056546413050. +is 18446744073709551615. .Pp When the .Nm primes Index: usr.bin/factor/factor.c =================================================================== --- usr.bin/factor/factor.c (revision 355983) +++ usr.bin/factor/factor.c (working copy) @@ -71,6 +71,7 @@ #include #include #include +#include #include #include #include @@ -104,6 +105,7 @@ #endif +static bool contains_hex_alpha_digits(char *str); static void BN_print_dec_fp(FILE *, const BIGNUM *); static void pr_fact(BIGNUM *); /* print factors of a value */ @@ -148,21 +150,37 @@ for (p = buf; isblank(*p); ++p); if (*p == '\n' || *p == '\0') continue; + if (*p == '+') p++; if (*p == '-') errx(1, "negative numbers aren't permitted."); - if (BN_dec2bn(&val, buf) == 0 && - BN_hex2bn(&val, buf) == 0) - errx(1, "%s: illegal numeric format.", buf); + if (*p == '0') { + p++; + if (*p == 'x' || *p == 'X') + ch = BN_hex2bn(&val, ++p); + } else { + ch = contains_hex_alpha_digits(p) ? + BN_hex2bn(&val, p) : BN_dec2bn(&val, p); + } + if (ch == 0) + errx(1, "%s: illegal numeric format.", p); pr_fact(val); } /* Factor the arguments. */ else - for (; *argv != NULL; ++argv) { - if (argv[0][0] == '-') + for (p = *argv; p != NULL; p = *++argv) { + if (*p == '+') p++; + if (*p == '-') errx(1, "negative numbers aren't permitted."); - if (BN_dec2bn(&val, argv[0]) == 0 && - BN_hex2bn(&val, argv[0]) == 0) - errx(1, "%s: illegal numeric format.", argv[0]); + if (*p == '0') { + p++; + if (*p == 'x' || *p == 'X') + ch = BN_hex2bn(&val, ++p); + } else { + ch = contains_hex_alpha_digits(p) ? + BN_hex2bn(&val, p) : BN_dec2bn(&val, p); + } + if (ch == 0) + errx(1, "%s: illegal numeric format.", p); pr_fact(val); } exit(0); @@ -346,7 +364,7 @@ errno = 0; **a = strtoul(str, &p, 10); - return (errno == 0 && (*p == '\n' || *p == '\0')); + return (errno == 0 ? 1 : 0); /* OpenSSL returns 0 on error! */ } static int @@ -356,7 +374,7 @@ errno = 0; **a = strtoul(str, &p, 16); - return (errno == 0 && (*p == '\n' || *p == '\0')); + return (errno == 0 ? 1 : 0); /* OpenSSL returns 0 on error! */ } static BN_ULONG @@ -370,3 +388,20 @@ } #endif + +/* + * Check if the string contains one of 'abcdef' from the set of + * hexadecimal digits. + */ +static bool +contains_hex_alpha_digits(char *str) +{ + char c, *p; + + for (p = str; *p; p++) { + c = tolower(*p); + if (c >= 'a' && c <= 'f') + return true; + } + return false; +} Index: usr.bin/primes/primes.c =================================================================== --- usr.bin/primes/primes.c (revision 355983) +++ usr.bin/primes/primes.c (working copy) @@ -55,7 +55,7 @@ * primes [-h] [start [stop]] * * Print primes >= start and < stop. If stop is omitted, - * the value 4294967295 (2^32-1) is assumed. If start is + * the value 18446744073709551615 (2^64-1) is assumed. If start is * omitted, start is read from standard input. * * validation check: there are 664579 primes between 0 and 10^7 -- Steve From owner-freebsd-current@freebsd.org Sun Dec 29 16:02:51 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 449E51E2B63 for ; Sun, 29 Dec 2019 16:02:51 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "troutmask", Issuer "troutmask" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 47m51j6VxLz3G8V for ; Sun, 29 Dec 2019 16:02:49 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id xBTG2lXw072146 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO) for ; Sun, 29 Dec 2019 08:02:47 -0800 (PST) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id xBTG2lcA072145 for freebsd-current@freebsd.org; Sun, 29 Dec 2019 08:02:47 -0800 (PST) (envelope-from sgk) Date: Sun, 29 Dec 2019 08:02:47 -0800 From: Steve Kargl To: freebsd-current@freebsd.org Subject: Re: OpenSSL breaks factor(6) Message-ID: <20191229160247.GA72129@troutmask.apl.washington.edu> Reply-To: sgk@troutmask.apl.washington.edu References: <20191227212530.GA61314@troutmask.apl.washington.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191227212530.GA61314@troutmask.apl.washington.edu> User-Agent: Mutt/1.12.2 (2019-09-21) X-Rspamd-Queue-Id: 47m51j6VxLz3G8V X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=washington.edu (policy=none); spf=none (mx1.freebsd.org: domain of sgk@troutmask.apl.washington.edu has no SPF policy when checking 128.95.76.21) smtp.mailfrom=sgk@troutmask.apl.washington.edu X-Spamd-Result: default: False [-2.23 / 15.00]; ARC_NA(0.00)[]; HAS_REPLYTO(0.00)[sgk@troutmask.apl.washington.edu]; DMARC_POLICY_SOFTFAIL(0.10)[washington.edu : No valid SPF, No valid DKIM,none]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; IP_SCORE(-0.23)[ip: (0.05), ipnet: 128.95.0.0/16(-0.26), asn: 73(-0.91), country: US(-0.05)]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLYTO_ADDR_EQ_FROM(0.00)[]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:73, ipnet:128.95.0.0/16, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Dec 2019 16:02:51 -0000 Here's a final attempt at fixing and documenting FreeBSD's factor(6). Do what you want with the patch. With and without OpenSSL, one now gets % factor +123 123 123zzzz 123zabc 123abc +123abc 0x123abc +0x123abc 123: 3 41 123: 3 41 123: 3 41 123: 3 41 1194684: 2 2 3 29 3433 1194684: 2 2 3 29 3433 1194684: 2 2 3 29 3433 1194684: 2 2 3 29 3433 * usr.bin/factor/factor.6: . Update documentation to note that hexadecimal strings are accepted. . Document that a hexadecimal number can have an optional 0x or 0X prefix. . Document that a 0 value in interactive mode terminates factor(6). . Fix the maximum value for 'stop' in primes(6). . While here, spell "white-space" as "whitespace" and "non-digit" as "nondigit". * usr.bin/factor/factor.c: . Include stdbool to get acces to bool type. . Use consistent style for function prototypes. . New function. is_hex_str() looks for the longest substring and determines if it is a hexadecimal number. . New function. Factor (pun intended) out common code into convert_str2bn(). . For the WIHTOUT_OPENSSL case, make BN_dec2bn() and BN_hex2bn() return 0 on error like their OpenSSL counterparts. * usr.bin/primes/primes.c: . Fix comment. Index: usr.bin/factor/factor.6 =================================================================== --- usr.bin/factor/factor.6 (revision 355983) +++ usr.bin/factor/factor.6 (working copy) @@ -36,7 +36,7 @@ .\" .\" chongo /\oo/\ .\" -.Dd October 10, 2002 +.Dd December 29, 2019 .Dt FACTOR 6 .Os .Sh NAME @@ -67,11 +67,22 @@ .Nm is invoked with no arguments, .Nm -reads numbers, one per line, from standard input, until end of file or error. +reads numbers, one per line, from standard input until end of file or 0 +is entered or an error occurs. Leading white-space and empty lines are ignored. +.Pp Numbers may be preceded by a single .Ql + . +Numbers can be either decimal or hexadecimal strings where the longest +leading substring is used. Numbers are terminated by a non-digit character (such as a newline). +If the string contains only decimal digits, it is treated as a +decimal representation for a number. +A hexadecimal string can contain an optional +.Em 0x +or +.Em 0X +prefix. After a number is read, it is factored. .Pp The @@ -89,7 +100,7 @@ value must not be greater than the maximum. The default and maximum value of .Ar stop -is 3825123056546413050. +is 18446744073709551615. .Pp When the .Nm primes Index: usr.bin/factor/factor.c =================================================================== --- usr.bin/factor/factor.c (revision 355983) +++ usr.bin/factor/factor.c (working copy) @@ -71,6 +71,7 @@ #include #include #include +#include #include #include #include @@ -97,8 +98,8 @@ #define BN_is_one(v) (*(v) == 1) #define BN_mod_word(a, b) (*(a) % (b)) -static int BN_dec2bn(BIGNUM **a, const char *str); -static int BN_hex2bn(BIGNUM **a, const char *str); +static int BN_dec2bn(BIGNUM **, const char *); +static int BN_hex2bn(BIGNUM **, const char *); static BN_ULONG BN_div_word(BIGNUM *, BN_ULONG); static void BN_print_fp(FILE *, const BIGNUM *); @@ -105,7 +106,8 @@ #endif static void BN_print_dec_fp(FILE *, const BIGNUM *); - +static void convert_str2bn(BIGNUM **, char *); +static bool is_hex_str(char *); static void pr_fact(BIGNUM *); /* print factors of a value */ static void pr_print(BIGNUM *); /* print a prime */ static void usage(void); @@ -148,21 +150,13 @@ for (p = buf; isblank(*p); ++p); if (*p == '\n' || *p == '\0') continue; - if (*p == '-') - errx(1, "negative numbers aren't permitted."); - if (BN_dec2bn(&val, buf) == 0 && - BN_hex2bn(&val, buf) == 0) - errx(1, "%s: illegal numeric format.", buf); + convert_str2bn(&val, p); pr_fact(val); } /* Factor the arguments. */ else - for (; *argv != NULL; ++argv) { - if (argv[0][0] == '-') - errx(1, "negative numbers aren't permitted."); - if (BN_dec2bn(&val, argv[0]) == 0 && - BN_hex2bn(&val, argv[0]) == 0) - errx(1, "%s: illegal numeric format.", argv[0]); + for (p = *argv; p != NULL; p = *++argv) { + convert_str2bn(&val, p); pr_fact(val); } exit(0); @@ -346,7 +340,7 @@ errno = 0; **a = strtoul(str, &p, 10); - return (errno == 0 && (*p == '\n' || *p == '\0')); + return (errno == 0 ? 1 : 0); /* OpenSSL returns 0 on error! */ } static int @@ -356,7 +350,7 @@ errno = 0; **a = strtoul(str, &p, 16); - return (errno == 0 && (*p == '\n' || *p == '\0')); + return (errno == 0 ? 1 : 0); /* OpenSSL returns 0 on error! */ } static BN_ULONG @@ -370,3 +364,46 @@ } #endif + +/* + * Scan the string from left-to-right to see if the longest substring + * is a valid hexadecimal number. + */ +static bool +is_hex_str(char *str) +{ + char c, *p; + bool saw_hex = false; + + for (p = str; *p; p++) { + if (isdigit(*p)) + continue; + c = tolower(*p); + if (c >= 'a' && c <= 'f') { + saw_hex = true; + continue; + } + break; /* Not a hexadecimal digit. */ + } + return saw_hex; +} + +/* Convert string pointed to by *str to a bignum. */ +static void +convert_str2bn(BIGNUM **val, char *p) +{ + int n = 0; + + if (*p == '+') p++; + if (*p == '-') + errx(1, "negative numbers aren't permitted."); + if (*p == '0') { + p++; + if (*p == 'x' || *p == 'X') + n = BN_hex2bn(val, ++p); + } else { + n = is_hex_str(p) ? BN_hex2bn(val, p) : BN_dec2bn(val, p); + } + if (n == 0) + errx(1, "%s: illegal numeric format.", p); +} Index: usr.bin/primes/primes.c =================================================================== --- usr.bin/primes/primes.c (revision 355983) +++ usr.bin/primes/primes.c (working copy) @@ -55,7 +55,7 @@ * primes [-h] [start [stop]] * * Print primes >= start and < stop. If stop is omitted, - * the value 4294967295 (2^32-1) is assumed. If start is + * the value 18446744073709551615 (2^64-1) is assumed. If start is * omitted, start is read from standard input. * * validation check: there are 664579 primes between 0 and 10^7 -- Steve From owner-freebsd-current@freebsd.org Sun Dec 29 16:05:52 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EBB631E2D77 for ; Sun, 29 Dec 2019 16:05:52 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "troutmask", Issuer "troutmask" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 47m55D0bfyz3GNg for ; Sun, 29 Dec 2019 16:05:51 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id xBTG5oZb072186 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO) for ; Sun, 29 Dec 2019 08:05:50 -0800 (PST) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id xBTG5o4e072185 for freebsd-current@freebsd.org; Sun, 29 Dec 2019 08:05:50 -0800 (PST) (envelope-from sgk) Date: Sun, 29 Dec 2019 08:05:50 -0800 From: Steve Kargl To: freebsd-current@freebsd.org Subject: Re: OpenSSL breaks factor(6) Message-ID: <20191229160550.GA72177@troutmask.apl.washington.edu> Reply-To: sgk@troutmask.apl.washington.edu References: <20191227212530.GA61314@troutmask.apl.washington.edu> <20191229160247.GA72129@troutmask.apl.washington.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191229160247.GA72129@troutmask.apl.washington.edu> User-Agent: Mutt/1.12.2 (2019-09-21) X-Rspamd-Queue-Id: 47m55D0bfyz3GNg X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=washington.edu (policy=none); spf=none (mx1.freebsd.org: domain of sgk@troutmask.apl.washington.edu has no SPF policy when checking 128.95.76.21) smtp.mailfrom=sgk@troutmask.apl.washington.edu X-Spamd-Result: default: False [-2.23 / 15.00]; ARC_NA(0.00)[]; HAS_REPLYTO(0.00)[sgk@troutmask.apl.washington.edu]; DMARC_POLICY_SOFTFAIL(0.10)[washington.edu : No valid SPF, No valid DKIM,none]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; IP_SCORE(-0.23)[ip: (0.05), ipnet: 128.95.0.0/16(-0.26), asn: 73(-0.90), country: US(-0.05)]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLYTO_ADDR_EQ_FROM(0.00)[]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:73, ipnet:128.95.0.0/16, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Dec 2019 16:05:53 -0000 On Sun, Dec 29, 2019 at 08:02:47AM -0800, Steve Kargl wrote: > Here's a final attempt at fixing and documenting FreeBSD's factor(6). > Do what you want with the patch. With and without OpenSSL, one now > gets > > % factor +123 123 123zzzz 123zabc 123abc +123abc 0x123abc +0x123abc > 123: 3 41 > 123: 3 41 > 123: 3 41 > 123: 3 41 > 1194684: 2 2 3 29 3433 > 1194684: 2 2 3 29 3433 > 1194684: 2 2 3 29 3433 > 1194684: 2 2 3 29 3433 > > * usr.bin/factor/factor.6: > . Update documentation to note that hexadecimal strings are accepted. > . Document that a hexadecimal number can have an optional 0x or 0X prefix. > . Document that a 0 value in interactive mode terminates factor(6). Whoops. Leading zeros are ignored. > . Fix the maximum value for 'stop' in primes(6). > . While here, spell "white-space" as "whitespace" and "non-digit" as > "nondigit". -- steve From owner-freebsd-current@freebsd.org Sun Dec 29 21:53:49 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8CDE21EB6AE for ; Sun, 29 Dec 2019 21:53:49 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic312-24.consmr.mail.gq1.yahoo.com (sonic312-24.consmr.mail.gq1.yahoo.com [98.137.69.205]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47mDph1NyTz49Fx for ; Sun, 29 Dec 2019 21:53:47 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-YMail-OSG: NuT6VIAVM1lkr0K..FNo7kSONnfOQXoG7Lwh13cY.WJuLxC.vq3rT6pnWwaRecR JwCF0WGv0BI00vmqLyu_Nbi2cofiQPsbEwZCm4jDHzxPNqsd9oKIoSFknx2WUBwUgc9sHqsmEzMF OsfJmYz0dX3qQSkLb.YGCy6N16IaIjhcm5_kui9OxTRi3j8vawT1Aw6dEJiVoetxFlS9IWJRvEjR q2vmzs1pmcZoZd8Rx39nHkNwmCht7SkHnOUGDhX2gveitHmswkOfY3b.PP0L7aUFswDi9m6xpOVP zI.tVm8XoA._4uG5G8mJRilP3mFIvMznEZzSrr2yDyGJZZMBzrFBq4.tJSoCIaTiXu3GXOEN_cnn X5hxBFrtlFvjdPklhZUNYylYLifgHueqiatl32xwcGcTrE9rRHwv7I0ub4LZQpTpJZm5xHNK0Yd2 xXZS4pX4GLXGFIZLnTLlukQjhLvy.9vaNk7dCyXBa7Z4OM2Gn2Bcwt12RmXIoiSLL5whvZlkOcvs Owqs1dwKdwHCYzvM3ZPh2J7myyK.qDD5FI8mmsLy5EgZyw1arsfJj6r5yBmtlZznqc694uxdw3hu 3kESEQCfINpOSeA84V95ZQdpO31Sc1aB8zSwM35ZyMHcW6jd_TpxEOa_uSU0D9qWSVzKKnKFkVz3 r.hTiFkNlCL.lAIW_z0sqMjGke.9u0b7RBNKsmixMe_tGccD.QbenVKKTaVG1KYMPrVFm7chq2qb mKRxYKZb0hL37uuVojgaeYGKYXTxrRhrNsKU803kz1F63HBLMUlkjzSxaqoXoqs60p9wGLFX3N1A pzGvKWVW7EtsccGSVinI8IdxbBqIC1hHQiyUXlYNNIO0uj8sktofuqyIVQoLuYHw2RPq1xsWkqE3 wgrPf8Hr7I_UxlkQ9YzCZzmtYa20m5YoB.yiEWRsFTV7qGT7PdcMc510xCSg7KT4TjVvDPYB6hqK b1GK9MhE1MIFI6MxUOkARn3HLJO3AmJYrYXbao0xxqCGhrl6nnVQ9fhAszFi5hXTSZMRn3ObDJN4 HBfpyX5vW2XA9IAUgiuMbXNESuejuxb7NfNg2jznCre9VksizYrKuaoCQazjmsQ4im4AK0QHbwUM uOXaRf.grOvJJQRu8gcT1iE8RjTcajTBUGFg_Ol8UF77RfS3.KVEjNUd5Bzz.M3qwpuH4hTqPxNe YKaIUjTxxfcQpSpM983I.YjXQhjYAFWngvkb.4GRh11omhR5fuzGvxRFlElkVc6_CfCbaB9Wqn9o Z1IQnMvjqWsMx3qWyKTP59DZvKcpIK8PrP461canjYiCnKEw.oqQqKZaXl13SOGqRxi_xmYx8hVK f20Y_oEjhZsOKZYaAkx2GIV3VA9I4YqDnDNI1iaoZ4FkB2gReVgGbXq4VN2ReXSRFFcwposdkleR qgay3zWsOAbyIZeWH2kHewD3wQwjAKls1mQ-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.gq1.yahoo.com with HTTP; Sun, 29 Dec 2019 21:53:45 +0000 Received: by smtp402.mail.bf1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID fc63e35a929149add8784bf4660eb341; Sun, 29 Dec 2019 21:53:44 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.40.2.2.4\)) Subject: head -r356109 on 32-bit powerpc (old PowerMac): Memory modified after free during late-stage of boot, most recently used by bus-sc Message-Id: <28FD8632-AC91-40D7-B6E7-36E304D37794@yahoo.com> Date: Sun, 29 Dec 2019 13:53:42 -0800 To: FreeBSD Current , freebsd-hackers@freebsd.org, FreeBSD PowerPC ML X-Mailer: Apple Mail (2.3608.40.2.2.4) References: <28FD8632-AC91-40D7-B6E7-36E304D37794.ref@yahoo.com> X-Rspamd-Queue-Id: 47mDph1NyTz49Fx X-Spamd-Bar: - X-Spamd-Result: default: False [-1.77 / 15.00]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; FREEMAIL_FROM(0.00)[yahoo.com]; MV_CASE(0.50)[]; DKIM_TRACE(0.00)[yahoo.com:+]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/21, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[yahoo.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.40)[-0.399,0]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; NEURAL_HAM_LONG(-0.87)[-0.867,0]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE(0.00)[ip: (5.15), ipnet: 98.137.64.0/21(0.89), asn: 36647(0.71), country: US(-0.05)]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[205.69.137.98.list.dnswl.org : 127.0.5.0]; RWL_MAILSPIKE_POSSIBLE(0.00)[205.69.137.98.rep.mailspike.net : 127.0.0.17]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Dec 2019 21:53:49 -0000 The kernel here is from expanding: = https://artifact.ci.freebsd.org/snapshot/head/r356109/powerpc/powerpc/kern= el*.txz (So: not my kernel build.) This is, of course, a debug kernel. World is my build (via system-clang, not gcc 4.2.1) Hand copied from an image of the crash information (no input possible at the db> prompt) . . . . . . Root mount waiting for: CAM usbus0 usbus1 ugen1.2: at usbus1 uhub4 on uhub0 uhub4: on ubus1 Memory modified after free 0x1e4d180(28) val=3D1e5a9c0 0 0x1e4d190 panic: Most recently used by bus-sc cpuid =3D 0 time =3D 2 KDB: stack backtrace: 0xd2630390: at kdb_backtrace+0x5c 0xd2630400: at vpanic+0x1f8 0xd2630470: at panic+0x68 0xd26304c0: at mtrash_ctor+0x9c 0xd26304e0: at item_ctor+0xb4 0xd2630510: at uma_zalloc_arg+0x1b4 0xd2630540: at malloc+0xfc 0xd2630580: at alloc_bounce_pages+0x7c 0xd26305c0: at bus_dmamap_create+0x1e8 0xd26305f0: at bus_dmamem_alloc+0x64 0xd2630620: at usb_pc_alloc_mem+0xbc 0xd2630660: at usbd_transfer_setup_sub_malloc+0x28c 0xd26306c0: at ohci_xfer_setup+0x1e4 0xd2630720: at usbd_trasnfer_setup+0x494 0xd26307a0: at usbd_ctrl_trasnfer_setup+0x184 0xd26307f0: at usbd_do_request_flags+0x300 0xd2630870: at usbd_req_set_address+0xdc 0xd26308b0: at usb_alloc_device+0x3cc 0xd2630940: at uhub_explore+0x678 0xd26309b0: at usb_bus_explore+0x128 0xd26309d0: at usb_process+0x128 0xd2630a10: at fork_exit+0xc0 0xd2630a40: at fork_trampoline+0xc KDB: enter: panic [ thread pid 15 tid 100040 ] Stopped at kdb_enter +0x70: addi r0,r0,0x0 db>=20 Unfortunately, I have no control at that point so this is all the information available about the PowerMac's state. I can report the that following sequences do boot (so far): boot -s then exit at the shell prompt boot -v (I've also seen a Rock64 Cortex-A53 board with boot crashes, where boot -v happened to boot, but only a personal non-debug kernel build was tried at the time.) The PowerMac is a 2-processor G4 model, with FW800. 2 GiBytes of RAM. Note: Historically I've experimented with system-clang and more modern gcc builds for 32-bit powerpc and powerpc64. The above is from me getting ready to jump over to the official system-clang context (and ELFv2 for powerpc64). I wanted to know some of the status of things that I'd see just before those changes so I'd have some clue what might be new vs. old when I switch over. =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar) From owner-freebsd-current@freebsd.org Sun Dec 29 22:05:08 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 703061EBED5; Sun, 29 Dec 2019 22:05:08 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [IPv6:2a01:4f8:c17:6c4b::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47mF3l3Dbgz4B17; Sun, 29 Dec 2019 22:05:07 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2020.home.selasky.org (unknown [62.141.129.235]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id D60762605BE; Sun, 29 Dec 2019 23:04:58 +0100 (CET) Subject: Re: head -r356109 on 32-bit powerpc (old PowerMac): Memory modified after free during late-stage of boot, most recently used by bus-sc To: Mark Millard , FreeBSD Current , freebsd-hackers@freebsd.org, FreeBSD PowerPC ML References: <28FD8632-AC91-40D7-B6E7-36E304D37794.ref@yahoo.com> <28FD8632-AC91-40D7-B6E7-36E304D37794@yahoo.com> From: Hans Petter Selasky Message-ID: <42bf7ff5-1279-28cb-5b4b-a0335e819a3a@selasky.org> Date: Sun, 29 Dec 2019 23:04:55 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <28FD8632-AC91-40D7-B6E7-36E304D37794@yahoo.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 47mF3l3Dbgz4B17 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of hps@selasky.org designates 2a01:4f8:c17:6c4b::2 as permitted sender) smtp.mailfrom=hps@selasky.org X-Spamd-Result: default: False [-4.94 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+a:mail.turbocat.net]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[selasky.org]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; IP_SCORE(-2.64)[ip: (-9.19), ipnet: 2a01:4f8::/29(-2.43), asn: 24940(-1.54), country: DE(-0.02)]; FREEMAIL_TO(0.00)[yahoo.com]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/29, country:DE]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Dec 2019 22:05:08 -0000 On 2019-12-29 22:53, Mark Millard via freebsd-hackers wrote: > 0xd2630510: at uma_zalloc_arg+0x1b4 > 0xd2630540: at malloc+0xfc > 0xd2630580: at alloc_bounce_pages+0x7c > 0xd26305c0: at bus_dmamap_create+0x1e8 Do you know what drivers are using bounce pages? --HPS From owner-freebsd-current@freebsd.org Sun Dec 29 22:14:32 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F3F571EC575 for ; Sun, 29 Dec 2019 22:14:31 +0000 (UTC) (envelope-from drosih@rpi.edu) Received: from smtp9.server.rpi.edu (smtp9.server.rpi.edu [128.113.2.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "canit.localdomain", Issuer "canit.localdomain" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 47mFGZ6lpGz4Bkd for ; Sun, 29 Dec 2019 22:14:30 +0000 (UTC) (envelope-from drosih@rpi.edu) Received: from smtp-auth1.server.rpi.edu (smtp-auth1.server.rpi.edu [128.113.2.231]) by smtp9.server.rpi.edu (8.14.4/8.14.4/Debian-8+deb8u2) with ESMTP id xBTMETUk037559 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 29 Dec 2019 17:14:29 -0500 Received: from smtp-auth1.server.rpi.edu (localhost [127.0.0.1]) by smtp-auth1.server.rpi.edu (Postfix) with ESMTP id E726C5801A; Sun, 29 Dec 2019 17:14:28 -0500 (EST) Received: from [172.16.67.1] (gilead-qc124.netel.rpi.edu [128.113.124.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: drosih) by smtp-auth1.server.rpi.edu (Postfix) with ESMTPSA id DBB4658002; Sun, 29 Dec 2019 17:14:28 -0500 (EST) From: "Garance A Drosehn" To: "Steve Kargl" Cc: freebsd-current@freebsd.org Subject: Re: OpenSSL breaks factor(6) Date: Sun, 29 Dec 2019 17:14:28 -0500 X-Mailer: MailMate (1.13.1r5671) Message-ID: In-Reply-To: <20191229071731.GB69227@troutmask.apl.washington.edu> References: <20191227212530.GA61314@troutmask.apl.washington.edu> <20191227214717.GA61475@troutmask.apl.washington.edu> <20191227224212.GA61594@troutmask.apl.washington.edu> <92557725-6612-46ED-BA39-FCE91EF6D091@rpi.edu> <20191229051035.GA68947@troutmask.apl.washington.edu> <20191229071731.GB69227@troutmask.apl.washington.edu> MIME-Version: 1.0 Content-Type: text/plain; markup=markdown X-Virus-Scanned: ClamAV using ClamSMTP X-Bayes-Prob: 0.0001 (Score 0, tokens from: outgoing, @@RPTN) X-Spam-Score: 0.00 () [Hold at 10.10] X-CanIt-Incident-Id: 021HWetpB X-CanIt-Geo: ip=128.113.124.17; country=US; latitude=37.7510; longitude=-97.8220; http://maps.google.com/maps?q=37.7510,-97.8220&z=6 X-CanItPRO-Stream: outgoing X-Canit-Stats-ID: Bayes signature not available X-Scanned-By: CanIt (www . roaringpenguin . com) on 128.113.2.229 X-Rspamd-Queue-Id: 47mFGZ6lpGz4Bkd X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=pass (policy=none) header.from=rpi.edu; spf=pass (mx1.freebsd.org: domain of drosih@rpi.edu designates 128.113.2.229 as permitted sender) smtp.mailfrom=drosih@rpi.edu X-Spamd-Result: default: False [-4.78 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:128.113.2.225/28]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_MED(-0.20)[229.2.113.128.list.dnswl.org : 127.0.11.2]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[rpi.edu,none]; IP_SCORE(-1.78)[ipnet: 128.113.0.0/16(-4.90), asn: 91(-3.92), country: US(-0.05)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:91, ipnet:128.113.0.0/16, country:US]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Dec 2019 22:14:32 -0000 On 29 Dec 2019, at 2:17, Steve Kargl wrote: > On Sun, Dec 29, 2019 at 01:34:28AM -0500, Garance A Drosehn wrote: >>> >>> An interested user will need to add that support. AFAIK, factor(6) >>> has never recognized the 0x prefix, and I'm not trying to add new >>> features. I'm simply fixing factor(6) to match its documentation, >>> and trying to ensure WITH_OPENSSL and WITHOUT_OPENSSL give the >>> same results where applicable. >> >> Well, I'd be willing to do the work to add the new feature, and also >> make the commit. It'd be a nice easy task for me to tackle... :) >> >> But I think documenting that "hex works, but only for hex values >> which have at least one A-F in the value" is not something that I'd >> want to draw attention to via documentation. >> > > You have a 17 year history to worry about as hexadecimal support > was added by "r104720 | fanf | 2002-10-09". Compiling factor(6) > with and without OpenSSL support after 2002-10-09 gives a utility > with different inconsistent behavior. If I understand you right, that behavior has not been documented for 17 years. If it continues to be un-documented, that cannot possibly break any scripts. I'm not saying we should remove the behavior, I'm just saying we don't need to document it. Especially not if we add support for a better way to specify hex values. On 29 Dec 2019, at 1:50, Steve Kargl wrote: > > Do what you want with the patch (including ignoring it). > Hopefully, someone in the FreeBSD project will now > recognize that factor(6) with and without OpenSSL gives > inconsistent results, and neither matches factor(6)'s > manpage. Oh. I tend to lose track with who is and isn't a src-committer on FreeBSD. I've seen your name enough that I assumed you were one. If you're not, I can handle committing these changes, including the new feature. That'll keep my commit bit alive for another year! -- Garance Alistair Drosehn = drosih@rpi.edu or gad@FreeBSD.org From owner-freebsd-current@freebsd.org Sun Dec 29 22:18:05 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 13EF71EC703 for ; Sun, 29 Dec 2019 22:18:05 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound2m.ore.mailhop.org (outbound2m.ore.mailhop.org [54.149.155.156]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47mFLh4kC2z4Btr for ; Sun, 29 Dec 2019 22:18:04 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1577657882; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=NEExqKe5LzZ6zs/DWyGL0uaMF6Ih7V878XjuCf7Ou2SyyIY+cfmKZicfEwwhhW09Z22yKUFox1mRK v+fOB++a+gbX+lgRA3t0JEY7uW/J3ZBaRuOY7oz/fLDy/gkr5IXhJyo3kfh7t65lp2dU8vCEhUY5RP HtKdMgT1Ni2q7c77+Meyrb56871x8vkkz4j8FNDqi5VDf5XG3llsy9Dfwet6nOwG7zxM2eBL/EkRSk fsE0FOeY+2GWx/kuT8oERehOb9jiZfOMBvI4J9DMtc6H+DzvWCB1TLrxh+N3KdV04Ni8mIRZjyqtJe v0irfoUngttYUhs6cEWGP0qwpnSkgLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:dkim-signature:from; bh=toCG9VxpbGq2eDSiy5Yj2NLeWr4rHpiQLyKUQALsdQ0=; b=mR0y9e6l2vZAwHu/tqjnye4QLn2Gi8IYiTuZVa+8PIazw5qmFdYU21zoR/9wFq6WQKohItJ15YBnk VDZO8UB9dFqSx2J1KmixQvwNxF+/RotiZoH6Ny6puF98BBYZb5yhpaoXqGUIhkCdUXL4TMFkme8V2B 08D/dFM6xxQOMQc6qwW4w+u8Rn12mwsg0WYRZyuEWG9BdFW6MbnDFx+N9xoeDt1KgLOnT4mXsiCL1z zNFKsp0g8qtiU+H+/47iODrfwA5fsFaXwWtepL/81OMPqvI/O+QRQEjNO200KxCKckBvUo29gvwRUv U8n48dj+Fq/W1MPDYG1Ek4LNdROekZQ== ARC-Authentication-Results: i=1; outbound4.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:from; bh=toCG9VxpbGq2eDSiy5Yj2NLeWr4rHpiQLyKUQALsdQ0=; b=TKQLbBEXFq5Vo+oYpOTYKwSoyScJBCaOvbeV4qRiFU7xJb6lIxNud4FpG0oS/1w3UPnqwwP80B1XW fU+9U/jk7KlZPlprKS6Z+Rbuxihcq6u2c+s+8/H0qLaLJ8S+5rxcuOjiJkVJJlrrG11xzqKFOLzxZN xBar5jzy12Mnf5Dfasn0nudCr2wvPL/we9QSRNDSHhGcR5GL096fdxaX+K9AZt7d3WyC64D9zKQTdB V/3hmOs0KM37PSUrRDBQf1wb82PFnTgkKgkwiSGNWUzqABUntRU0Vp95qVqAQdkMym6mlDXDRuiKZS yDaXTB9QvMsPQ2q7cRvaUe4NG9mrWCA== X-MHO-RoutePath: aGlwcGll X-MHO-User: 12246c86-2a89-11ea-829f-79a40d15cccd X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound4.ore.mailhop.org (Halon) with ESMTPSA id 12246c86-2a89-11ea-829f-79a40d15cccd; Sun, 29 Dec 2019 22:18:01 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id xBTMHwdM098783; Sun, 29 Dec 2019 15:17:59 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: Subject: Re: head -r356109 on 32-bit powerpc (old PowerMac): Memory modified after free during late-stage of boot, most recently used by bus-sc From: Ian Lepore To: Hans Petter Selasky , Mark Millard , FreeBSD Current , freebsd-hackers@freebsd.org, FreeBSD PowerPC ML Date: Sun, 29 Dec 2019 15:17:58 -0700 In-Reply-To: <42bf7ff5-1279-28cb-5b4b-a0335e819a3a@selasky.org> References: <28FD8632-AC91-40D7-B6E7-36E304D37794.ref@yahoo.com> <28FD8632-AC91-40D7-B6E7-36E304D37794@yahoo.com> <42bf7ff5-1279-28cb-5b4b-a0335e819a3a@selasky.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 47mFLh4kC2z4Btr X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-1.96 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.97)[-0.969,0]; NEURAL_HAM_LONG(-1.00)[-0.996,0]; ASN(0.00)[asn:16509, ipnet:54.148.0.0/15, country:US] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Dec 2019 22:18:05 -0000 On Sun, 2019-12-29 at 23:04 +0100, Hans Petter Selasky wrote: > On 2019-12-29 22:53, Mark Millard via freebsd-hackers wrote: > > 0xd2630510: at uma_zalloc_arg+0x1b4 > > 0xd2630540: at malloc+0xfc > > 0xd2630580: at alloc_bounce_pages+0x7c > > 0xd26305c0: at bus_dmamap_create+0x1e8 > > Do you know what drivers are using bounce pages? > > busdma isn't the culprit here. It was trying to allocate memory and the uma code found a block that was free and checked it before handing it out, and discovered that it had been modified after being freed. Before being freed, the memory was last used as the softc for some device (perhaps only during probing of a device that never attached). That device would most likely be the culprit (or a wild-pointer write hit that block). -- Ian From owner-freebsd-current@freebsd.org Sun Dec 29 22:31:30 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0EEC01ECDDD for ; Sun, 29 Dec 2019 22:31:30 +0000 (UTC) (envelope-from wingairak@gmail.com) Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47mFf900Xtz4Cdn for ; Sun, 29 Dec 2019 22:31:28 +0000 (UTC) (envelope-from wingairak@gmail.com) Received: by mail-lj1-x242.google.com with SMTP id h23so31696218ljc.8 for ; Sun, 29 Dec 2019 14:31:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=jdcQVGvjA1WLU+B2e6wiQEXaFJ3zs9PJENTzAKeaztg=; b=HEywTEcZechkMgRn+/dSpjlDV45kn1LJ0klQqcXK7p2B3ZZd5hEMENko66bchuOWjZ kzw5Yn8F2Y4BrhO1Vm31KNMWDd1VDDle7l4vRWF1F7kAvhrb3oqhJhD1bmXbmM2POqwI mGx3ig94soxHm4yqM92AC4VVhO6Yex0HCbna5dBIHiuKLtjN24pP5+m13SnBnlFagy4E hVwfz7VUT69zYKSjF0IFzTB2nBXfbbpkExOgK030btoVQ7e+X4KEA+kY08Wfmh+J7PpF RCSGPxV00pFdThCiTDSkkCBmm+TxnEvEWB2X+tL2s16mGwPEoOoAfdHvl0W8BNlSi7/1 LqdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=jdcQVGvjA1WLU+B2e6wiQEXaFJ3zs9PJENTzAKeaztg=; b=s2Onet7JJZtHBWm3Y0yxeyc7jqVfN7LJaHHhgGi6vdgQk+yPQRMo4SR2unjYUiw5W2 QiW8RJlifOtCmGO62wVtl5IHLq1mjwraf6JGk11nMMZ4d+O/lXsFRMEsQVfnaNTXwnud 5As7RwkCs1FU9on7j2+YtQmNRYeNOmprZUXBZTR8FuqgxNL52rz3gu1IT9ya7rlr8E34 P2+wAinqBb76ebomGzt6BWUygRJ4ADPDyEMhalsLSt12iHMfGZC/W24TyoQNs+5CYTgW +1bTUfqYE08qPzq3/4Ty4Jl69Opijl8Yn237Xfjy3slFHBJX4UPXHUKYDpauw3FxmlLm /+AQ== X-Gm-Message-State: APjAAAVavdISHOJ0c6ozcamYKkP/N8f/+wlAU9i01wcJnM1TgFqwew1T 1Evc+KyckVWfNGrwtevPsPCRAv2pYOv8ytXrX8WEJb9p X-Google-Smtp-Source: APXvYqwLXHI2fm7+OikPeu0N+teP4hA0rSyEPUdhvckHzpMz3HcZHS3li/EgDE2MSbUAtzKfxD9Vx4Ww54DLoHLBAsM= X-Received: by 2002:a2e:86c4:: with SMTP id n4mr35590471ljj.97.1577658687394; Sun, 29 Dec 2019 14:31:27 -0800 (PST) MIME-Version: 1.0 Received: by 2002:ac2:47fc:0:0:0:0:0 with HTTP; Sun, 29 Dec 2019 14:31:26 -0800 (PST) In-Reply-To: References: <20191227212530.GA61314@troutmask.apl.washington.edu> <20191227214717.GA61475@troutmask.apl.washington.edu> <20191227224212.GA61594@troutmask.apl.washington.edu> <92557725-6612-46ED-BA39-FCE91EF6D091@rpi.edu> <20191229051035.GA68947@troutmask.apl.washington.edu> <20191229071731.GB69227@troutmask.apl.washington.edu> From: Robert Wing Date: Sun, 29 Dec 2019 13:31:26 -0900 Message-ID: Subject: Re: OpenSSL breaks factor(6) To: Garance A Drosehn Cc: Steve Kargl , "freebsd-current@freebsd.org" X-Rspamd-Queue-Id: 47mFf900Xtz4Cdn X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=HEywTEcZ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of wingairak@gmail.com designates 2a00:1450:4864:20::242 as permitted sender) smtp.mailfrom=wingairak@gmail.com X-Spamd-Result: default: False [-2.00 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; URI_COUNT_ODD(1.00)[5]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; IP_SCORE(0.00)[ip: (2.68), ipnet: 2a00:1450::/32(-2.64), asn: 15169(-1.87), country: US(-0.05)]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2.4.2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Dec 2019 22:31:30 -0000 Have y'all ever seen reviews.freebsd.org? On Sunday, December 29, 2019, Garance A Drosehn wrote: > On 29 Dec 2019, at 2:17, Steve Kargl wrote: > > > On Sun, Dec 29, 2019 at 01:34:28AM -0500, Garance A Drosehn wrote: > >>> > >>> An interested user will need to add that support. AFAIK, factor(6) > >>> has never recognized the 0x prefix, and I'm not trying to add new > >>> features. I'm simply fixing factor(6) to match its documentation, > >>> and trying to ensure WITH_OPENSSL and WITHOUT_OPENSSL give the > >>> same results where applicable. > >> > >> Well, I'd be willing to do the work to add the new feature, and also > >> make the commit. It'd be a nice easy task for me to tackle... :) > >> > >> But I think documenting that "hex works, but only for hex values > >> which have at least one A-F in the value" is not something that I'd > >> want to draw attention to via documentation. > >> > > > > You have a 17 year history to worry about as hexadecimal support > > was added by "r104720 | fanf | 2002-10-09". Compiling factor(6) > > with and without OpenSSL support after 2002-10-09 gives a utility > > with different inconsistent behavior. > > If I understand you right, that behavior has not been documented > for 17 years. If it continues to be un-documented, that cannot > possibly break any scripts. I'm not saying we should remove the > behavior, I'm just saying we don't need to document it. Especially > not if we add support for a better way to specify hex values. > > On 29 Dec 2019, at 1:50, Steve Kargl wrote: > > > > Do what you want with the patch (including ignoring it). > > Hopefully, someone in the FreeBSD project will now > > recognize that factor(6) with and without OpenSSL gives > > inconsistent results, and neither matches factor(6)'s > > manpage. > > Oh. I tend to lose track with who is and isn't a src-committer on > FreeBSD. I've seen your name enough that I assumed you were one. > If you're not, I can handle committing these changes, including the > new feature. That'll keep my commit bit alive for another year! > > -- > Garance Alistair Drosehn = drosih@rpi.edu or gad@FreeBSD.org > _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" > From owner-freebsd-current@freebsd.org Sun Dec 29 22:38:30 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 920821ED012 for ; Sun, 29 Dec 2019 22:38:30 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic301-22.consmr.mail.gq1.yahoo.com (sonic301-22.consmr.mail.gq1.yahoo.com [98.137.64.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47mFpF3tSJz4Cys for ; Sun, 29 Dec 2019 22:38:29 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-YMail-OSG: OtHDFYwVM1nw4x2hTs7fVbQ6U63BeCIVWSGrRh5_K8m.ue3qkGoYswLbZhsXeNL PIgdYI41NWvwlWRT78LcKxkz82gS66GpICVtKo5h_.JUAb_JpA0MaEHF8OPACyfoRo9Zuq2UHMSV 7VS_4E4w1HESherZ.KzRvekRhzlRb.rIAVL41lpqGnIB6gDVFTaas5Rav9TeOgXfB6eEQe6hvXJS 0J81MYF4W5mjOrXzd8ke8184RMxkufOMA.xeNYO4aHdXlDLhd_L7tfzU5dxPxszwN24V.bc0Tmp2 VnugUPQ4Cst2_Jg6jZBIuobPXvxsEFZ_NZbEjhp0Xu8QhTWzJ4Y_FO6_zh7XCcnPf8oWuQ6oaZ9g 2vOnBVmEJjgbe9W5QTWz4N.wn5aUL5DbOXmIVju.92lBTQ5yMPWuTX8pTev1R62XYvBu2M2rxkcv f7idn4U8YDu9up1hArqb40hNd9eYIhe0sKia5T0BXcSZ5OCriSetP48Y5RSXPQ7ceJycnZsIyBc8 ZpA02aLiEx.z7WCVSgN9QMe5VL9.hv0U0nm.DRfy5CnJbKNb5ViVlC0yh5DB_cMl35TQq7HkozvH 7bc1OA693vylfroiSPs36M4tPtmfsr6A5GWWqGjDARSOAJfcieJu1b8pwjQoFV6MSF_Wk7GhoSww YR.0JQquCMibEOZq_bhrz2YGKiMapcg9CCiObRhLsabpF5PSVa0PVJRbN7MuUkwM0QpqaVzhp0A2 yFEWlmmaakNwmunmB22eP3sRLzWWNQ84Pu1f_rx5nI3yqbAOkrK2VQg4qXFyVmYT3MLyEnm2C86Y rGOzbqLQFJXE.LCHPVjyFU0dVyDqaYVPDNvWShVlwSi0T6L5wIx8KnfxruFX_JYK4STiGbWr.Vq. 8tjF_Avv7A.repsTn8hMkxpLT4l98IVvbDMURsJX6mYh7rpMXhC86MhSw3.qRTg2cCctZxmzHAJe KHLR9jinvHm6CWGPlRD4ohLfOPXfYu5YWPAr71wiIHR5DgFQ9JJv2We7oh8RmDZUDpJ7.O97_e6Y gvpFJ7Sw40iZhxPPHjFF9a5HpQlWds4fCphZ27J11VbLXIRwM5K6fak.Sb6wMydVpuB.bFjvKmG_ 3ihlQv6d4bjOldytRgDthDxDV.by1wi1ipMd5p_QI5VRYSk2IYRwOZw77rAOmZSoUT5wiKbjwt3H KqNDzweLEIh7kaMKjTYl2vqls8ZZ5BLkfO7VektpVOp1fGwl065ET.Bo4nBW2t8.51gZ5kAB_qZx X0332seBT7GFl6d51suGLYVodyD7CUQPtIgwlYXI4RHhVmqKWBlqGgizniygxHuHZlnFx02Ooh.P CRZULHglbMn46Qyg3MHOMyx3PnZRnonijPCGvnID4w0P5pMTOIFEN._5azZaqEMbmIaCj4CQdyIS 5yYJvPWqukhJXeD1V6eJD1ZiqOdXOjxa1 Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.gq1.yahoo.com with HTTP; Sun, 29 Dec 2019 22:38:26 +0000 Received: by smtp415.mail.bf1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 3437fd782ca164bedfbfac2ffe024092; Sun, 29 Dec 2019 22:38:22 +0000 (UTC) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.40.2.2.4\)) Subject: Re: head -r356109 on 32-bit powerpc (old PowerMac): Memory modified after free during late-stage of boot, most recently used by bus-sc From: Mark Millard In-Reply-To: <42bf7ff5-1279-28cb-5b4b-a0335e819a3a@selasky.org> Date: Sun, 29 Dec 2019 14:38:20 -0800 Cc: FreeBSD Current , freebsd-hackers@freebsd.org, FreeBSD PowerPC ML Content-Transfer-Encoding: quoted-printable Message-Id: <558A986F-B0C9-447A-A569-4D90A2B44C58@yahoo.com> References: <28FD8632-AC91-40D7-B6E7-36E304D37794.ref@yahoo.com> <28FD8632-AC91-40D7-B6E7-36E304D37794@yahoo.com> <42bf7ff5-1279-28cb-5b4b-a0335e819a3a@selasky.org> To: Hans Petter Selasky X-Mailer: Apple Mail (2.3608.40.2.2.4) X-Rspamd-Queue-Id: 47mFpF3tSJz4Cys X-Spamd-Bar: - X-Spamd-Result: default: False [-1.99 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.57)[-0.569,0]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; FREEMAIL_FROM(0.00)[yahoo.com]; MIME_GOOD(-0.10)[text/plain]; MV_CASE(0.50)[]; NEURAL_HAM_LONG(-0.92)[-0.924,0]; TO_DN_SOME(0.00)[]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[yahoo.com:+]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; RCVD_IN_DNSWL_NONE(0.00)[148.64.137.98.list.dnswl.org : 127.0.5.0]; RCVD_TLS_LAST(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/21, country:US]; MID_RHS_MATCH_FROM(0.00)[]; IP_SCORE(0.00)[ip: (4.35), ipnet: 98.137.64.0/21(0.89), asn: 36647(0.71), country: US(-0.05)]; DWL_DNSWL_NONE(0.00)[yahoo.com.dwl.dnswl.org : 127.0.5.0] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Dec 2019 22:38:30 -0000 On 2019-Dec-29, at 14:04, Hans Petter Selasky = wrote: > On 2019-12-29 22:53, Mark Millard via freebsd-hackers wrote: >> 0xd2630510: at uma_zalloc_arg+0x1b4 >> 0xd2630540: at malloc+0xfc >> 0xd2630580: at alloc_bounce_pages+0x7c >> 0xd26305c0: at bus_dmamap_create+0x1e8 >=20 > Do you know what drivers are using bounce pages? No clue. Looking around a bit I see that there is: if (newtag->lowaddr < ptoa((vm_paddr_t)Maxmem) && newtag->iommu = =3D=3D NULL) newtag->flags |=3D BUS_DMA_COULD_BOUNCE; if (newtag->alignment > 1) newtag->flags |=3D BUS_DMA_COULD_BOUNCE; in bus_dma_tag_create (in sys/powerpc/powerpc/busdma_machdep.c ). But that does not indicate what all specifically might have met one of those 2 conditions for some tag creation. (The material is not familiar.) =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar) From owner-freebsd-current@freebsd.org Sun Dec 29 23:42:49 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1BC711EE6D0 for ; Sun, 29 Dec 2019 23:42:49 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-TO1-obe.outbound.protection.outlook.com (mail-eopbgr670043.outbound.protection.outlook.com [40.107.67.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47mHDR6qLDz4Grh for ; Sun, 29 Dec 2019 23:42:47 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YxPSyAenuF/7P/fnHUv/9V6v7YdFR68lB7RuodFlIphWkovUGhqIyUXm9NZMrUpnWDAXKHmhp2VeEJyigU7xoXYeEHhCZPA4xDTvEa8zd6B9BDwgNPe4ZOu6xJ4pJZYD+mNpSG6QytZVYYYTceovLPuY7RmFKdd/uPVYJLjRT5njJ9xBe9RLIUDv+fjUj9CV5qf+ZO16twod2F66r3yoZ4Gm9my/3qN3fhS8Tf9/CehkTkkUaiDGkv0A6sWGlLSE6C8Nqpp9CR3ctAwMQNwx9Y/78aj5IFk4BvsoZFbAlYfh7FfSLX8vZiex19/0QiDKnMBLlo7e9+jbXedgWgfTIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5ECfv9/sdxh2X1Ff6n71JCL2a1F/4BLHf/nLfqp7Sqg=; b=hKmtjAWgnVli6zZZ/dKu4L+MY5H8nQpPwGjfI+G5TyZ8ubO4x7tFvbNFrjUSPYGkg6xBf6Pq4hMTayBR+JcOxYKsUGoMgpSp3QwP3N38CHXTXTX5wSDAn0Iv089KuNLyMwmwgo9/nfl35ZhVCO9h0HrNgOC0LxVjyN9s0Nc9p53B/MYVcSQGCOY3gcVs2KqaIV2xZGQRnRg4fcZNadIVA/ExgFpnJQ4bUqxbwsJWXVZo/6SvOPlNVJa7znY1RAmHx31Nw6nhLykccTWgJYdDsx91pci9D6Z92PseTy+tt+ZDf9IUYkAf6DFLISrnIprrM6joemyQQJfQo0BN8vaa8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=uoguelph.ca; dmarc=pass action=none header.from=uoguelph.ca; dkim=pass header.d=uoguelph.ca; arc=none Received: from YQBPR0101MB1427.CANPRD01.PROD.OUTLOOK.COM (52.132.69.153) by YQBPR0101MB1860.CANPRD01.PROD.OUTLOOK.COM (52.132.67.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2581.11; Sun, 29 Dec 2019 23:42:46 +0000 Received: from YQBPR0101MB1427.CANPRD01.PROD.OUTLOOK.COM ([fe80::7512:8580:8d82:6c94]) by YQBPR0101MB1427.CANPRD01.PROD.OUTLOOK.COM ([fe80::7512:8580:8d82:6c94%6]) with mapi id 15.20.2581.007; Sun, 29 Dec 2019 23:42:46 +0000 From: Rick Macklem To: Dennis Clarke , "freebsd-current@freebsd.org" Subject: Re: getting rid of sys/nfs/nfs_lock.c Thread-Topic: getting rid of sys/nfs/nfs_lock.c Thread-Index: AQHVvd4uYot+uGDYskWjg23o3Tr07KfQqpKAgAEbkU8= Date: Sun, 29 Dec 2019 23:42:46 +0000 Message-ID: References: , <663f9bf2-c556-109f-dfdb-5eeb00fc0c2e@blastwave.org> In-Reply-To: <663f9bf2-c556-109f-dfdb-5eeb00fc0c2e@blastwave.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8b0b2473-1541-4946-cf1c-08d78cb8ce71 x-ms-traffictypediagnostic: YQBPR0101MB1860: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0266491E90 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(346002)(376002)(39860400002)(396003)(366004)(199004)(189003)(33656002)(76116006)(2906002)(316002)(110136005)(786003)(86362001)(7696005)(66446008)(64756008)(66556008)(6506007)(66946007)(186003)(52536014)(66476007)(71200400001)(81156014)(9686003)(8676002)(966005)(478600001)(55016002)(5660300002)(81166006)(8936002); DIR:OUT; SFP:1101; SCL:1; SRVR:YQBPR0101MB1860; H:YQBPR0101MB1427.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: olMCXVTcZ6ya/r5dXsCzhcO2L1V/DwClrOhlpLWaR2/t4SSOQOWj14EchCZ5THr8RR4D+QkTq9faUm6pMm59UEA7tnPLRn2AMPT3LUcuAZZMcjurvbRCCujEV5pWMx9BgIbZ/n6vZgauv4pthLo64eKr96oFD9hEVSh8/ZhpzjLGCL8pjil//IUec8IoVHDB8MEf1VRpirqFTO68Z4E9e+UbHFQ6cXaFV7YuyuGfOu1kp7Cb8lBeLy17bVLLthvLpgtpDC5CxqLRkDS8NOW728Y+mNlGgvDmk+4AlEgSuTiUoZlGFp3Xb4955WVgSgNN3WiGmwYrPoXIXrZC+ueEeEvx44TufzfFePRxR1Q9dGjMDG9ILn5MpRiD5RoN1ICjVnSS8YvX1UN5YaJEioEFYPraSFlGbHcm9Rzh9iRrEVrI7V/BfPYdwO6H6TYqHj4WlDoXUBasczLU5bml3LxN8/plxgjYRak1fMiaW3MivfM= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: 8b0b2473-1541-4946-cf1c-08d78cb8ce71 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Dec 2019 23:42:46.1091 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cbO/jhDcCYCwOh6vrZdgeRo0o8YL4COXEuIWk4VHmWWr6HLapO6hpPtQ4wXjSqBKCIAKv4ssXibI0n94FEBJvg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQBPR0101MB1860 X-Rspamd-Queue-Id: 47mHDR6qLDz4Grh X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of rmacklem@uoguelph.ca designates 40.107.67.43 as permitted sender) smtp.mailfrom=rmacklem@uoguelph.ca X-Spamd-Result: default: False [-4.67 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[uoguelph.ca]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[43.67.107.40.list.dnswl.org : 127.0.3.0]; IP_SCORE(-1.37)[ipnet: 40.64.0.0/10(-3.84), asn: 8075(-2.95), country: US(-0.05)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:8075, ipnet:40.64.0.0/10, country:US]; ARC_ALLOW(-1.00)[i=1] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Dec 2019 23:42:49 -0000 Dennis Clarke wrote:=0A= >On 12/28/19 7:30 PM, Rick Macklem wrote:=0A= >> Hi,=0A= >>=0A= >> sys/nfs/nfs_lock.c uses Giant. Since it has not been used by default sin= ce=0A= >> March 2008, I suspect it can be removed from head without any impact.=0A= >> Post March 2008, the only way this code could be executed is by both=0A= >> building a kernel without "options NFSLOCKD" and deleting nfslockd.ko=0A= >> from the kernel boot directory and then running rpc.lockd on the system.= =0A= >>=0A= >> I doubt anyone has been doing both of the above, but if you think it is= =0A= >> still useful, please speak up. (I have an untested patch that replaces G= iant=0A= >> with a regular mutex. I realized this code is not used when I trying to = test it.;-)=0A= >>=0A= >> Also, if it seems appropriate, I could commit a patch that makes it prin= t out=0A= >> "deprecated and going away before FreeBSD 13" message, but I doubt anyon= e=0A= >> will ever see it.=0A= >> Should I do such a message and wait a few months for the deletion?=0A= >=0A= >Such a message is a good idea.=0A= >=0A= >I am curious if there is any way in which we would see that message when= =0A= >creating an NFS share via ZFS set sharenfs=3D'foo' ?=0A= Only if your kernel was built without "options NFSLOCKD" and you do not=0A= have nfslockd.ko in your kernel boot directory.=0A= Highly unlikely for amd64, since neither of the above would be true unless= =0A= you created a custom kernel config and deleted nfslockd.ko from the kernel= =0A= boot directory you installed it in.=0A= =0A= It is slightly more likely to occur for an arm installation, since many of = those=0A= do not configure NFS into the kernel, if you did not have the modules in th= e=0A= boot directory and you then started rpc.lockd.=0A= =0A= rick=0A= =0A= =0A= --=0A= Dennis Clarke=0A= RISC-V/SPARC/PPC/ARM/CISC=0A= UNIX and Linux spoken=0A= GreyBeard and suspenders optional=0A= _______________________________________________=0A= freebsd-current@freebsd.org mailing list=0A= https://lists.freebsd.org/mailman/listinfo/freebsd-current=0A= To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"= =0A= From owner-freebsd-current@freebsd.org Mon Dec 30 00:01:57 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7ED9B1EF1C4 for ; Mon, 30 Dec 2019 00:01:57 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "troutmask", Issuer "troutmask" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 47mHfX1Rrnz4J7x for ; Mon, 30 Dec 2019 00:01:55 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id xBU01rGv074809 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sun, 29 Dec 2019 16:01:53 -0800 (PST) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id xBU01rvw074808; Sun, 29 Dec 2019 16:01:53 -0800 (PST) (envelope-from sgk) Date: Sun, 29 Dec 2019 16:01:53 -0800 From: Steve Kargl To: Robert Wing Cc: Garance A Drosehn , "freebsd-current@freebsd.org" Subject: Re: OpenSSL breaks factor(6) Message-ID: <20191230000153.GA74782@troutmask.apl.washington.edu> Reply-To: sgk@troutmask.apl.washington.edu References: <20191227212530.GA61314@troutmask.apl.washington.edu> <20191227214717.GA61475@troutmask.apl.washington.edu> <20191227224212.GA61594@troutmask.apl.washington.edu> <92557725-6612-46ED-BA39-FCE91EF6D091@rpi.edu> <20191229051035.GA68947@troutmask.apl.washington.edu> <20191229071731.GB69227@troutmask.apl.washington.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) X-Rspamd-Queue-Id: 47mHfX1Rrnz4J7x X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=washington.edu (policy=none); spf=none (mx1.freebsd.org: domain of sgk@troutmask.apl.washington.edu has no SPF policy when checking 128.95.76.21) smtp.mailfrom=sgk@troutmask.apl.washington.edu X-Spamd-Result: default: False [-2.23 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; DMARC_POLICY_SOFTFAIL(0.10)[washington.edu : No valid SPF, No valid DKIM,none]; HAS_REPLYTO(0.00)[sgk@troutmask.apl.washington.edu]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; IP_SCORE(-0.23)[ip: (0.05), ipnet: 128.95.0.0/16(-0.26), asn: 73(-0.90), country: US(-0.05)]; MIME_GOOD(-0.10)[text/plain]; REPLYTO_ADDR_EQ_FROM(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; R_SPF_NA(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:73, ipnet:128.95.0.0/16, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Dec 2019 00:01:57 -0000 On Sun, Dec 29, 2019 at 01:31:26PM -0900, Robert Wing wrote: > Have y'all ever seen reviews.freebsd.org? > I have a FreeBSD login account and a FreeBSD bugzilla account. I don't need yet another FreeBSD account. If bugzilla were set up to parse email replies, this would be attached a bug report. -- Steve From owner-freebsd-current@freebsd.org Mon Dec 30 00:16:36 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0D34D1EF851 for ; Mon, 30 Dec 2019 00:16:36 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "troutmask", Issuer "troutmask" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 47mHzQ4cgWz4JrS for ; Mon, 30 Dec 2019 00:16:34 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id xBU0GWCb074868 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sun, 29 Dec 2019 16:16:32 -0800 (PST) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id xBU0GWaC074867; Sun, 29 Dec 2019 16:16:32 -0800 (PST) (envelope-from sgk) Date: Sun, 29 Dec 2019 16:16:32 -0800 From: Steve Kargl To: Garance A Drosehn Cc: freebsd-current@freebsd.org Subject: Re: OpenSSL breaks factor(6) Message-ID: <20191230001632.GB74782@troutmask.apl.washington.edu> Reply-To: sgk@troutmask.apl.washington.edu References: <20191227212530.GA61314@troutmask.apl.washington.edu> <20191227214717.GA61475@troutmask.apl.washington.edu> <20191227224212.GA61594@troutmask.apl.washington.edu> <92557725-6612-46ED-BA39-FCE91EF6D091@rpi.edu> <20191229051035.GA68947@troutmask.apl.washington.edu> <20191229071731.GB69227@troutmask.apl.washington.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) X-Rspamd-Queue-Id: 47mHzQ4cgWz4JrS X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=washington.edu (policy=none); spf=none (mx1.freebsd.org: domain of sgk@troutmask.apl.washington.edu has no SPF policy when checking 128.95.76.21) smtp.mailfrom=sgk@troutmask.apl.washington.edu X-Spamd-Result: default: False [-2.23 / 15.00]; ARC_NA(0.00)[]; HAS_REPLYTO(0.00)[sgk@troutmask.apl.washington.edu]; DMARC_POLICY_SOFTFAIL(0.10)[washington.edu : No valid SPF, No valid DKIM,none]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; IP_SCORE(-0.23)[ip: (0.05), ipnet: 128.95.0.0/16(-0.25), asn: 73(-0.90), country: US(-0.05)]; MIME_GOOD(-0.10)[text/plain]; REPLYTO_ADDR_EQ_FROM(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:73, ipnet:128.95.0.0/16, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Dec 2019 00:16:36 -0000 On Sun, Dec 29, 2019 at 05:14:28PM -0500, Garance A Drosehn wrote: > On 29 Dec 2019, at 2:17, Steve Kargl wrote: > > > On Sun, Dec 29, 2019 at 01:34:28AM -0500, Garance A Drosehn wrote: > >>> > >>> An interested user will need to add that support. AFAIK, factor(6) > >>> has never recognized the 0x prefix, and I'm not trying to add new > >>> features. I'm simply fixing factor(6) to match its documentation, > >>> and trying to ensure WITH_OPENSSL and WITHOUT_OPENSSL give the > >>> same results where applicable. > >> > >> Well, I'd be willing to do the work to add the new feature, and also > >> make the commit. It'd be a nice easy task for me to tackle... :) > >> > >> But I think documenting that "hex works, but only for hex values > >> which have at least one A-F in the value" is not something that I'd > >> want to draw attention to via documentation. > >> > > > > You have a 17 year history to worry about as hexadecimal support > > was added by "r104720 | fanf | 2002-10-09". Compiling factor(6) > > with and without OpenSSL support after 2002-10-09 gives a utility > > with different inconsistent behavior. > > If I understand you right, that behavior has not been documented > for 17 years. If it continues to be un-documented, that cannot > possibly break any scripts. I'm not saying we should remove the > behavior, I'm just saying we don't need to document it. Especially > not if we add support for a better way to specify hex values. See the most recent patch. It does everything you want with '0x' or '0X', maintains what was likely the intended behavior, and makes the with/without OpenSSL support consistent. I disagree with not documenting what the utility does. Currently, the string '1abc' returns '1' with OpenSSL and 6844 without OpenSSL. It is not possible to understand this behavior based on the manpage. > > On 29 Dec 2019, at 1:50, Steve Kargl wrote: > > > > Do what you want with the patch (including ignoring it). > > Hopefully, someone in the FreeBSD project will now > > recognize that factor(6) with and without OpenSSL gives > > inconsistent results, and neither matches factor(6)'s > > manpage. > > Oh. I tend to lose track with who is and isn't a src-committer on > FreeBSD. I've seen your name enough that I assumed you were one. > If you're not, I can handle committing these changes, including the > new feature. That'll keep my commit bit alive for another year! > I gave up my commit bit years ago, because the individuals who set up jenkins reduced freebsd-current@ to a spam repository for jenkins build logs and refused to stop spamming the list. freebsd-current@ has yet to recover from that era. I still have my kargl@freebsd.org address. I do, however, still use FreeBSD. When I find a problem and can fix it, I submit patches to the relevant mailing list and/or bugzilla. -- Steve From owner-freebsd-current@freebsd.org Mon Dec 30 21:11:34 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BC6491EA1AA for ; Mon, 30 Dec 2019 21:11:34 +0000 (UTC) (envelope-from yeking@red54.com) Received: from smtpbguseast2.qq.com (smtpbguseast2.qq.com [54.204.34.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47mqqT1dS4z4TrD for ; Mon, 30 Dec 2019 21:11:33 +0000 (UTC) (envelope-from yeking@red54.com) X-QQ-FEAT: J2LDBW4VWtrGB/hb/7KD9ngZUsDIUf/xDqtqhM26EqhJqjtg8chq3tvFqZkzQ Tr9FnLo9UNxjhNz5cODA1s3c86VW+8JjGFu6W0fxSlWiz/vnMugV+xNBY7V9uSMGBrXJsfj ikQCf1q+d9rWbZdSnVIP+3JWlyRZgfPsYmMHssWdewZ0euzeuKuPyyWV140BDALqPAmg4z5 uw6mUhZLfZeB1WDCHR0q0cgG5MLU9GnqTsdYkjYeR2sHw/FXmRkNqkAJgAFpd9PGoChdVte wfEGUUfYaWflv9G9BX68hfAPTvCgpQbj9+rni17x+zq00Dm3ozprwRDPE= X-QQ-SSF: 00000000000000F000000000000000U X-HAS-ATTACH: no X-QQ-BUSINESS-ORIGIN: 2 X-Originating-IP: 223.73.97.47 X-QQ-STYLE: X-QQ-mid: webmail304t1577740265t7901241 From: "=?gb18030?B?0LvWwrDuIChYSUUgWmhpYmFuZyk=?=" To: "=?gb18030?B?ZnJlZWJzZC1oYWNrZXJz?=" , "=?gb18030?B?ZnJlZWJzZC1jdXJyZW50?=" , "=?gb18030?B?ZnJlZWJzZC1kb2M=?=" Subject: [PATCH] Fix "Last database update: 2020-12-30 15:16:53 UTC" problem Mime-Version: 1.0 Content-Type: text/plain; charset="gb18030" Content-Transfer-Encoding: base64 Date: Tue, 31 Dec 2019 05:11:05 +0800 X-Priority: 3 Message-ID: X-QQ-MIME: TCMime 1.0 by Tencent X-Mailer: QQMail 2.x X-QQ-Mailer: QQMail 2.x X-QQ-SENDSIZE: 520 Received: from qq.com (unknown [127.0.0.1]) by smtp.qq.com (ESMTP) with SMTP id ; Tue, 31 Dec 2019 05:11:06 +0800 (CST) Feedback-ID: webmail:red54.com:bgforeign:bgforeign12 X-QQ-Bgrelay: 1 X-Rspamd-Queue-Id: 47mqqT1dS4z4TrD X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of yeking@red54.com designates 54.204.34.130 as permitted sender) smtp.mailfrom=yeking@red54.com X-Spamd-Result: default: False [-0.83 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; HAS_XOIP(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+ip4:54.204.34.0/24:c]; MV_CASE(0.50)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; MIME_BASE64_TEXT(0.10)[]; HAS_X_PRIO_THREE(0.00)[3]; RCVD_IN_DNSWL_NONE(0.00)[130.34.204.54.list.dnswl.org : 127.0.5.0]; TO_EXCESS_BASE64(1.50)[]; IP_SCORE(-0.63)[asn: 14618(-3.11), country: US(-0.05)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:14618, ipnet:54.204.0.0/15, country:US]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Dec 2019 21:11:34 -0000 aHR0cHM6Ly93d3cuZnJlZWJzZC5vcmcvY2dpL3BvcnRzLmNnaT9xdWVyeT1mcmVlYnNkLWRv Yy1hbGwKaHR0cHM6Ly93ZWIuYXJjaGl2ZS5vcmcvd2ViLzIwMTkxMjMwMjEwNDIxL2h0dHBz Oi8vd3d3LmZyZWVic2Qub3JnL2NnaS9wb3J0cy5jZ2k/cXVlcnk9ZnJlZWJzZC1kb2MtYWxs CgpJbmRleDogZG9jL2hlYWQvZW5fVVMuSVNPODg1OS0xL2h0ZG9jcy9jZ2kvcG9ydHMuY2dp Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIGRvYy9oZWFkL2VuX1VTLklTTzg4NTktMS9odGRvY3MvY2dp L3BvcnRzLmNnaQkocmV2aXNpb24gNTM3MjEpCisrKyBkb2MvaGVhZC9lbl9VUy5JU084ODU5 LTEvaHRkb2NzL2NnaS9wb3J0cy5jZ2kJKHdvcmtpbmcgY29weSkKQEAgLTE2Niw3ICsxNjYs NyBAQAogCiAgICAgJG1vZHRpbWUgPSAoIHN0YXQoJGZpbGUpIClbOV07CiAgICAgaWYgKCBk ZWZpbmVkKCRtb2R0aW1lKSAmJiAkbW9kdGltZSA+IDAgKSB7Ci0gICAgICAgICRtb2R0aW1l c3RyID0gc3RyZnRpbWUoICIlRy0lbS0lZCAlSDolTTolUyBVVEMiLCBnbXRpbWUoJG1vZHRp bWUpICk7CisgICAgICAgICRtb2R0aW1lc3RyID0gc3RyZnRpbWUoICIlWS0lbS0lZCAlSDol TTolUyBVVEMiLCBnbXRpbWUoJG1vZHRpbWUpICk7CiAgICAgfQogICAgIGVsc2UgewogICAg ICAgICAkbW9kdGltZXN0ciA9ICJVbmtub3duIjs= ***** From owner-freebsd-current@freebsd.org Tue Dec 31 09:00:23 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8F9621F76DA for ; Tue, 31 Dec 2019 09:00:23 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic309-20.consmr.mail.gq1.yahoo.com (sonic309-20.consmr.mail.gq1.yahoo.com [98.137.65.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47n7YL3PnNz443h for ; Tue, 31 Dec 2019 09:00:22 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-YMail-OSG: Zv0ti80VM1leMHs1DLa23kJwLdodVdCLZrLIXhiBGc8p6kOkmV4UIw9ayEQYoBK Eq7EK5lLe_jTz5ENEH8Vfb7KPC5ZF8QW7Durg0aBI7hneMq5V0pt9ifT7hfW5ec3m_GGfND2G5Bx XcOJTADB_a5BzRYCJA6hxMbfhvy0QFRJPJ2xqCtbyo0EJjsON7FOVh8Zqj7W3AG2Ct0ynMBDE0nT lb3vo0WA9M0CP4rFOSColsBV.AdBiB5YKzsS5muqhESvNVAaE_3oAT3oflWwjVRZ1hkl0g9Cb2GR pyMVjJJQKpVeof18kVPgaYDfpI6N90x4mUG0GpfauznBZmVqb62HRfjetkzQ3DTzzaUkppfn3Zu1 GyFuHTzR760RiPrKA6as2e1_KAck3QSMP4sr7h1HlbsElMOSuyciV5ztlkfkGS30zQagtQWcfxZE 0A.Y5o4RoEiG8fw5abq.2g.BDkOcqALbPN8_KYmFf2cKQo36dAqx1bZHO0nTAsitS7t0yWaze4EW YIqXkqp8.Dwt_efznk_fKkNubCgJ2gMFD0l3CtN8xX.i3q5Iji3gHjJd.4mKQ_SbW6uFFttVwvZS eH8wujR7TSWXkBkuHTHiGHiMP6OhZ7jHk39RhYuzfUI33zqNsdAqiefS6wo6a3EfRJ3rmgEwZcT1 w0AUNJW1Qqq25Sck5BMYV8EgQ7FBiFUuXVp0BhW9jsPbmFJAmbMFGMQ.MT6uAjeKow4.7vSrlakG KD8alEu3oPnGQtrTy7HFHxV9iLRZcfEHiaLkzE3uXVQ2ivpmInvH.PFhI0cuXLEYeUlNjOZHpHFd TwrCNImXJIDEc0I50ayGDUy8I3_kAgCYhQN4vA3zA.OBmXttqS0a3E680Tz_vPo80Weh2GCdjBb_ HDYxMBSq5DUcTrZUXRNtaeJUz9wW8VBsUtICcnd2ctPIPEPuFQYtbtK_SE7Jp6stUixDkJBWCpRK Z2CgFw5C5gd5z9B_gdS6mAYIOpdB1OtHhcIiC3sQo16hq0KNQ_Y1DLUU1e8csgAl2_urH6w24CXd PQov961MC88gnex7A6ouPENW7w0Ta8Vc3lGLgjb5SdI2dD7FNH6J31L4xIZ5xA3NGo1l8nUC3XXf d8.JCVUhDM.peJWyUNLwvsfTgrHvr_bAz3Bee.qPVwYTpqrCU8dP8tGVVXrWXmIUSrY.w6xs.7LY l6J.dVNW5bZ.VPqQ3Ug3NPPD8nsokOznMoa1jUgSaZnRGW6SkqUGwOFty.KekPpS5nkEd7Scpmqy UnUY6GilDBki9SOOOEQBBUlPUFEuLIQzg_EA.uLHdKedNG3O0_MMoPozo3Ozd9I1gYjtcUL1UU21 .yejb7x5CB47V1eTcJ1usCUkthXastvI5pqVvh42q7cuSEisWFg3ArMDsCHGxKAWqUawRhMyRPGd 710HzyAU4xmhuLnqOSc807.iBJ_xAeXNiK68uYUY- Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.gq1.yahoo.com with HTTP; Tue, 31 Dec 2019 09:00:20 +0000 Received: by smtp411.mail.gq1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID ac8603420c63711fef4aea8cbf1ed437; Tue, 31 Dec 2019 09:00:17 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.40.2.2.4\)) Subject: Old PowerMac3,6 and Giant locking: List of what its boot reports as warnings Message-Id: <1525B89C-CAA3-4113-BE44-3363B5003FB1@yahoo.com> Date: Tue, 31 Dec 2019 01:00:17 -0800 To: FreeBSD Current , FreeBSD PowerPC ML X-Mailer: Apple Mail (2.3608.40.2.2.4) References: <1525B89C-CAA3-4113-BE44-3363B5003FB1.ref@yahoo.com> X-Rspamd-Queue-Id: 47n7YL3PnNz443h X-Spamd-Bar: - X-Spamd-Result: default: False [-1.14 / 15.00]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; FREEMAIL_FROM(0.00)[yahoo.com]; MIME_GOOD(-0.10)[text/plain]; MV_CASE(0.50)[]; NEURAL_HAM_LONG(-0.72)[-0.721,0]; RCVD_COUNT_TWO(0.00)[2]; NEURAL_SPAM_MEDIUM(0.08)[0.084,0]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[yahoo.com:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[146.65.137.98.list.dnswl.org : 127.0.5.0]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; RCVD_TLS_LAST(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/21, country:US]; MID_RHS_MATCH_FROM(0.00)[]; IP_SCORE(0.00)[ip: (7.51), ipnet: 98.137.64.0/21(0.88), asn: 36647(0.71), country: US(-0.05)]; DWL_DNSWL_NONE(0.00)[yahoo.com.dwl.dnswl.org : 127.0.5.0] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Dec 2019 09:00:23 -0000 Booting head -r356187 on an old G4 PowerMac3,6 shows the following Giant warnings: # dmesg -a | grep Giant WARNING: Device "kbd" is Giant locked and may be deleted before FreeBSD = 13.0. WARNING: Device "openfirm" is Giant locked and may be deleted before = FreeBSD 13.0. WARNING: Device "powermac_nvram" is Giant locked and may be deleted = before FreeBSD 13.0. WARNING: Device "agp" is Giant locked and may be deleted before FreeBSD = 13.0. WARNING: Device "consolectl" is Giant locked and may be deleted before = FreeBSD 13.0. ( This was booted with kern.vty=3Dsc , mostly because on some other hardware kern.vty=3Dvt historically did not handle the 2560x1440 screen [crashing during boot] but sc worked fine. ) =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar) From owner-freebsd-current@freebsd.org Wed Jan 1 08:10:52 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DC18B1F7A68 for ; Wed, 1 Jan 2020 08:10:52 +0000 (UTC) (envelope-from yeking@red54.com) Received: from smtpproxy21.qq.com (smtpbg704.qq.com [203.205.195.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47nkPl1cFyz4fSx for ; Wed, 1 Jan 2020 08:10:50 +0000 (UTC) (envelope-from yeking@red54.com) X-QQ-FEAT: 1mVGv73xmHmXRywCohCTw/mlA+iORvafeREA+pMK1t6L4VMyJdn0NwGfVi9c2 DZGmtnCfs1CTEqwB7h6NXY1c3Fv9aRwMi1jm9s9xBAHnGpupYz9Oe7ztaPkckqYVc8qiVmN IlKKQxLm2pOmU/64CiDM+bz5Jt51Vuk4MXu0Wi+jstFHR5HX2uwqb4FbSBx3koKmyEUAAZk nO/4xZw0HtRIp27ozbSh4tAsR2QILtBEJ1f0LDWfiEky1prUTYmS2OejMinKtPvFDvAo7q+ zs4MZxp8d54QyLQ1/rj3A1ivCD2CpOnHgYPhaViWzMr1ii X-QQ-SSF: 00000000000000F000000000000000U X-HAS-ATTACH: no X-QQ-BUSINESS-ORIGIN: 2 X-Originating-IP: 223.73.228.69 X-QQ-STYLE: X-QQ-mid: webmail304t1577866221t2943489 From: "=?utf-8?B?6LCi6Ie06YKmIChYSUUgWmhpYmFuZyk=?=" To: "=?utf-8?B?ZnJlZWJzZC1oYWNrZXJz?=" , "=?utf-8?B?ZnJlZWJzZC1jdXJyZW50?=" , "=?utf-8?B?ZnJlZWJzZC1kb2M=?=" , "=?utf-8?B?Y3JlZXM=?=" , "=?utf-8?B?d29zY2g=?=" Subject: [PATCH] Fix "Last database update: 2020-12-30 15:16:53 UTC" problem Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Date: Wed, 1 Jan 2020 16:10:21 +0800 X-Priority: 3 Message-ID: X-QQ-MIME: TCMime 1.0 by Tencent X-Mailer: QQMail 2.x X-QQ-Mailer: QQMail 2.x X-QQ-SENDSIZE: 520 Received: from qq.com (unknown [127.0.0.1]) by smtp.qq.com (ESMTP) with SMTP id ; Wed, 01 Jan 2020 16:10:21 +0800 (CST) Feedback-ID: webmail:red54.com:bgforeign:bgforeign11 X-QQ-Bgrelay: 1 X-Rspamd-Queue-Id: 47nkPl1cFyz4fSx X-Spamd-Bar: + Authentication-Results: mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of yeking@red54.com designates 203.205.195.105 as permitted sender) smtp.mailfrom=yeking@red54.com X-Spamd-Result: default: False [1.09 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.48)[-0.476,0]; HAS_XOIP(0.00)[]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:203.205.195.0/24:c]; MV_CASE(0.50)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; NEURAL_HAM_LONG(-0.71)[-0.708,0]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; MIME_BASE64_TEXT(0.10)[]; HAS_X_PRIO_THREE(0.00)[3]; TO_EXCESS_BASE64(1.50)[]; IP_SCORE(0.47)[asn: 132203(2.33), country: CN(0.02)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:132203, ipnet:203.205.194.0/23, country:CN]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jan 2020 08:10:52 -0000 Rm9yd2FyZCB0byBjcmVlcyBhbmQgd29zY2guCgpodHRwczovL3dlYi5hcmNoaXZlLm9yZy93 ZWIvMjAxOTEyMzAyMTA0MjEvaHR0cHM6Ly93d3cuZnJlZWJzZC5vcmcvY2dpL3BvcnRzLmNn aT9xdWVyeT1mcmVlYnNkLWRvYy1hbGwKaHR0cHM6Ly93ZWIuYXJjaGl2ZS5vcmcvd2ViLzIw MTkxMjMxMDU0MTIzL2h0dHBzOi8vd3d3LmZyZWVic2Qub3JnL2NnaS9wb3J0cy5jZ2k/cXVl cnk9ZnJlZWJzZC1kb2MtYWxsCgpJbmRleDogZG9jL2hlYWQvZW5fVVMuSVNPODg1OS0xL2h0 ZG9jcy9jZ2kvcG9ydHMuY2dpCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGRvYy9oZWFkL2VuX1VTLklT Tzg4NTktMS9odGRvY3MvY2dpL3BvcnRzLmNnaQkocmV2aXNpb24gNTM3MjEpCisrKyBkb2Mv aGVhZC9lbl9VUy5JU084ODU5LTEvaHRkb2NzL2NnaS9wb3J0cy5jZ2kJKHdvcmtpbmcgY29w eSkKQEAgLTE2Niw3ICsxNjYsNyBAQAogCiAgICAgJG1vZHRpbWUgPSAoIHN0YXQoJGZpbGUp IClbOV07CiAgICAgaWYgKCBkZWZpbmVkKCRtb2R0aW1lKSAmJiAkbW9kdGltZSA+IDAgKSB7 Ci0gICAgICAgICRtb2R0aW1lc3RyID0gc3RyZnRpbWUoICIlRy0lbS0lZCAlSDolTTolUyBV VEMiLCBnbXRpbWUoJG1vZHRpbWUpICk7CisgICAgICAgICRtb2R0aW1lc3RyID0gc3RyZnRp bWUoICIlWS0lbS0lZCAlSDolTTolUyBVVEMiLCBnbXRpbWUoJG1vZHRpbWUpICk7CiAgICAg fQogICAgIGVsc2UgewogICAgICAgICAkbW9kdGltZXN0ciA9ICJVbmtub3duIjs= From owner-freebsd-current@freebsd.org Thu Jan 2 01:20:49 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AB0001E5FC6 for ; Thu, 2 Jan 2020 01:20:49 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic313-21.consmr.mail.gq1.yahoo.com (sonic313-21.consmr.mail.gq1.yahoo.com [98.137.65.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47p9G85wMxz4c3c for ; Thu, 2 Jan 2020 01:20:48 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-YMail-OSG: 2KLGJg4VM1nax4Lkfx.YJhEBihDvn8NqWV1EhLoWAg9KV_7gEsFSpBy2CDj687g 1Gd1N.CjqsOU9vBWAiZhx30_kAQc6hV0QiMhKbK..FHXDj4xMHtd10XVhlDNAdtH.SbY_pycLvlQ HSMlJbAVjMSaA_QYNMMS0n5J_Qb3iavI2NS8EPjomtmy8ZE0V0799HMRxFoSg61PGTac2zAv9t_D miUBDijfa1s2JsM9.pvLrLiHSy88tKsIuaSym9tgkx3X9RdJ3ktrGZYXAghvswteZPlmvZd2pjLD cd9qJU4VtkKKAN17aUuK3QmubS8rkPAn9xI1vRbrJ6DAEUxb5JvWOACEn5Zk3_Xo515G9rixLjWO H9GONAPj.mP.0._lqxWZVXIC8YhkPdG3NJufySvVpDYDqFsFEB7HPFMk3A3AuOLojpsBd6YuofBW J8msQLMqP8ExhTN0ZLpYRzRHkRokH4Suyb4HJJqPfeo.9Hrlqeo5j8IDeiYiF5jwwO5qED8MibGW T0m33mfqIwPbeb4e96gqH89oZuG30VvqlXkeAH3FfhX00ymZzlqocD3WOI_y0LFwEvb1aF5pldn3 idDQw8xouOQ7rTSFDzVuz1gEX5I71_ifdVT8_pwjYC8NDic1WhJrBL52WprL7g0qxLHYydSR13f. Gh_5deRTAqOaS4PzLMLCvuswW4MGUFhqmS0UjZKTwugRKUy6oP4zV8M6LsdZeDWL8fvOzrSIhFYc glWQZPKD1hSWazbCBgaaBMwdzDfjdtXl2mVYBcIUAagJv.D8eW8xYBQ9QM_m9iKYYonnFpupipuu QW_QgmR3uUKxmPi969EZBNROWcAt9_9JX0qH0LUOK.oh1eFcZpxHIQ0C4vkveuHSSlX1tvwJEG.V ABmzyPMrGAP7fQRwYAz3rexjQzij0HFU_bg5KYKvJ0KbRxr.iXE44saNvHo2z1VGKroPQ5Wq40fJ d8OvwVaHx2.rhrHiwTncp2nzLeZpjPTH2eewVEqy6bN5ZBLo2RGaHHB6pPOxVj5LLv7UBJM_VXPt ETh3kktn5MrIElSq4WjT_iqHB5YSHyPK.vTWO4MHOLGIU9jRwYlICPab6sj0PooS6WpS31YLDBLm jgG0BkQ2G2Z4tfETQfEbbGKL1MOmNrzAkCDwWHn_8UfwHES1tlp1aQkkjpFmPw3bEPSqx3KXj.Pp xcGzCcyf4agOLMKzTOhVl_gjkzeMNLP.g1u1jeX1zlhQMqtyQmSwq5nBWrl8mwBE0xn.nycBjKPm 1ddfSuASX.XcUhJ9DOvLfaX1pCyga10Lwc3yj3JIeSgLze3SQ47414U3YHQ354yQpPwMPYQNrpjT R__xQS0WK6ZYP1dK81dn4a9TcC0G9ptbL4laCykLaWlpY4K24O1uOH_1LLWfHS5G.31BML7j5IvI NFDgLb5EsOogJMfatgFxBJhWeKfasvcy0 Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.gq1.yahoo.com with HTTP; Thu, 2 Jan 2020 01:20:46 +0000 Received: by smtp409.mail.ne1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 30265e3e687889c3d416af800e9adf26; Thu, 02 Jan 2020 01:20:41 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.40.2.2.4\)) Subject: Old PowerMac G5 (powerpc64) Giant lock usage: a list of warnings shown by dmesg -a (openfirm, kdb, powermac_nvram) Message-Id: <7A3DC64C-E77A-413F-8124-CE61819A1898@yahoo.com> Date: Wed, 1 Jan 2020 17:20:39 -0800 To: FreeBSD Current , FreeBSD PowerPC ML X-Mailer: Apple Mail (2.3608.40.2.2.4) References: <7A3DC64C-E77A-413F-8124-CE61819A1898.ref@yahoo.com> X-Rspamd-Queue-Id: 47p9G85wMxz4c3c X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.33 / 15.00]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; FREEMAIL_FROM(0.00)[yahoo.com]; MV_CASE(0.50)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[yahoo.com:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/21, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[yahoo.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.85)[-0.849,0]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-0.98)[-0.977,0]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE(0.00)[ip: (1.60), ipnet: 98.137.64.0/21(0.88), asn: 36647(0.71), country: US(-0.05)]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[84.65.137.98.list.dnswl.org : 127.0.5.0]; RWL_MAILSPIKE_POSSIBLE(0.00)[84.65.137.98.rep.mailspike.net : 127.0.0.17]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Jan 2020 01:20:49 -0000 The list is shorter than it was for an old PowerMac G4 (32-bit powerpc). For a G5 powerpc64 example running head -r356187 (so ELFv2): # dmesg -a | grep Giant WARNING: Device "openfirm" is Giant locked and may be deleted before = FreeBSD 13.0. WARNING: Device "kbd" is Giant locked and may be deleted before FreeBSD = 13.0. WARNING: Device "powermac_nvram" is Giant locked and may be deleted = before FreeBSD 13.0. =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar) From owner-freebsd-current@freebsd.org Thu Jan 2 11:03:49 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 61F151F46E1; Thu, 2 Jan 2020 11:03:49 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: from drew.franken.de (mail-n.franken.de [193.175.24.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.franken.de", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47pQBs1WX5z4HGl; Thu, 2 Jan 2020 11:03:48 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: from mb.fritz.box (ip4d16e760.dynamic.kabel-deutschland.de [77.22.231.96]) (Authenticated sender: macmic) by mail-n.franken.de (Postfix) with ESMTPSA id 3DF7672106C11; Thu, 2 Jan 2020 12:03:46 +0100 (CET) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.40.2.2.4\)) Subject: Re: panic: vm_page_astate_fcmpset: invalid head requeue request on RPI3 From: Michael Tuexen In-Reply-To: <20200102001231.GA84583@www.zefox.net> Date: Thu, 2 Jan 2020 12:03:45 +0100 Cc: freebsd-arm@freebsd.org, freebsd-current Content-Transfer-Encoding: quoted-printable Message-Id: References: <20200102001231.GA84583@www.zefox.net> To: bob prohaska X-Mailer: Apple Mail (2.3608.40.2.2.4) X-Spam-Status: No, score=-1.6 required=5.0 tests=ALL_TRUSTED,BAYES_00, IP_LINK_PLUS,NORMAL_HTTP_TO_IP,NUMERIC_HTTP_ADDR,WEIRD_PORT autolearn=disabled version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mail-n.franken.de X-Rspamd-Queue-Id: 47pQBs1WX5z4HGl X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-1.93 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.94)[-0.942,0]; ASN(0.00)[asn:680, ipnet:193.174.0.0/15, country:DE]; NEURAL_HAM_LONG(-0.99)[-0.991,0] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Jan 2020 11:03:49 -0000 > On 2. Jan 2020, at 01:12, bob prohaska wrote: >=20 > While playing at compiling www/chromium using=20 > FreeBSD 13.0-CURRENT (GENERIC) #2 r356165: Mon Dec 30 09:59:03 PST = 2019 > the machine crashed, reporting=20 > panic: vm_page_astate_fcmpset: invalid head requeue request for page = 0xfffffd0031880490 This problem is NOT arm specific. I've seen it on an amd64 system = running syzkaller: = http://212.201.121.91:10000/crash?id=3D00704eb865e893ffda473a4859e062eef51= 2cbde Best regards Michael >=20 > cpuid =3D 2 > time =3D 1577921727 > KDB: stack backtrace: > db_trace_self() at db_trace_self_wrapper+0x28 > pc =3D 0xffff000000735c5c lr =3D 0xffff000000106814 > sp =3D 0xffff0000521ec240 fp =3D 0xffff0000521ec450 >=20 > db_trace_self_wrapper() at vpanic+0x18c > pc =3D 0xffff000000106814 lr =3D 0xffff000000408d90 > sp =3D 0xffff0000521ec460 fp =3D 0xffff0000521ec510 >=20 > vpanic() at panic+0x44 > pc =3D 0xffff000000408d90 lr =3D 0xffff000000408b40 > sp =3D 0xffff0000521ec520 fp =3D 0xffff0000521ec5a0 >=20 > panic() at _vm_page_pqstate_commit_dequeue+0x340 > pc =3D 0xffff000000408b40 lr =3D 0xffff0000006ed840 > sp =3D 0xffff0000521ec5b0 fp =3D 0xffff0000521ec5f0 >=20 > _vm_page_pqstate_commit_dequeue() at = vm_page_pqstate_commit_dequeue+0xb8 > pc =3D 0xffff0000006ed840 lr =3D 0xffff0000006e954c > sp =3D 0xffff0000521ec600 fp =3D 0xffff0000521ec640 >=20 > vm_page_pqstate_commit_dequeue() at vm_page_pqstate_commit+0x50 > pc =3D 0xffff0000006e954c lr =3D 0xffff0000006e93ac > sp =3D 0xffff0000521ec650 fp =3D 0xffff0000521ec670 >=20 > vm_page_pqstate_commit() at vm_pageout_laundry_worker+0x5e4 > pc =3D 0xffff0000006e93ac lr =3D 0xffff0000006f02c0 > sp =3D 0xffff0000521ec680 fp =3D 0xffff0000521ec940 >=20 > vm_pageout_laundry_worker() at fork_exit+0x7c > pc =3D 0xffff0000006f02c0 lr =3D 0xffff0000003c7fdc > sp =3D 0xffff0000521ec950 fp =3D 0xffff0000521ec980 >=20 > fork_exit() at fork_trampoline+0x10 > pc =3D 0xffff0000003c7fdc lr =3D 0xffff00000075230c > sp =3D 0xffff0000521ec990 fp =3D 0x0000000000000000 >=20 > KDB: enter: panic > [ thread pid 21 tid 100071 ] > Stopped at 0 > db> bt > Tracing pid 21 tid 100071 td 0xfffffd0001078560 > db_trace_self() at db_stack_trace+0xf8 > pc =3D 0xffff000000735c5c lr =3D 0xffff000000103c58 > sp =3D 0xffff0000521ebe10 fp =3D 0xffff0000521ebe40 >=20 > db_stack_trace() at db_command+0x228 > pc =3D 0xffff000000103c58 lr =3D 0xffff0000001038d0 > sp =3D 0xffff0000521ebe50 fp =3D 0xffff0000521ebf30 >=20 > db_command() at db_command_loop+0x58 > pc =3D 0xffff0000001038d0 lr =3D 0xffff000000103678 > sp =3D 0xffff0000521ebf40 fp =3D 0xffff0000521ebf60 >=20 > db_command_loop() at db_trap+0xf4 > pc =3D 0xffff000000103678 lr =3D 0xffff00000010697c > sp =3D 0xffff0000521ebf70 fp =3D 0xffff0000521ec190 >=20 > db_trap() at kdb_trap+0x1d8 > pc =3D 0xffff00000010697c lr =3D 0xffff0000004510d0 > sp =3D 0xffff0000521ec1a0 fp =3D 0xffff0000521ec250 >=20 > kdb_trap() at do_el1h_sync+0xf4 > pc =3D 0xffff0000004510d0 lr =3D 0xffff000000752588 > sp =3D 0xffff0000521ec260 fp =3D 0xffff0000521ec290 >=20 > do_el1h_sync() at handle_el1h_sync+0x78 > pc =3D 0xffff000000752588 lr =3D 0xffff000000738078 > sp =3D 0xffff0000521ec2a0 fp =3D 0xffff0000521ec3b0 >=20 > handle_el1h_sync() at kdb_enter+0x34 > pc =3D 0xffff000000738078 lr =3D 0xffff00000045071c > sp =3D 0xffff0000521ec3c0 fp =3D 0xffff0000521ec450 >=20 > kdb_enter() at vpanic+0x1a8 > pc =3D 0xffff00000045071c lr =3D 0xffff000000408dac > sp =3D 0xffff0000521ec460 fp =3D 0xffff0000521ec510 >=20 > vpanic() at panic+0x44 > pc =3D 0xffff000000408dac lr =3D 0xffff000000408b40 > sp =3D 0xffff0000521ec520 fp =3D 0xffff0000521ec5a0 >=20 > panic() at _vm_page_pqstate_commit_dequeue+0x340 > pc =3D 0xffff000000408b40 lr =3D 0xffff0000006ed840 > sp =3D 0xffff0000521ec5b0 fp =3D 0xffff0000521ec5f0 >=20 > _vm_page_pqstate_commit_dequeue() at = vm_page_pqstate_commit_dequeue+0xb8 > pc =3D 0xffff0000006ed840 lr =3D 0xffff0000006e954c > sp =3D 0xffff0000521ec600 fp =3D 0xffff0000521ec640 >=20 > vm_page_pqstate_commit_dequeue() at vm_page_pqstate_commit+0x50 > pc =3D 0xffff0000006e954c lr =3D 0xffff0000006e93ac > sp =3D 0xffff0000521ec650 fp =3D 0xffff0000521ec670 >=20 > vm_page_pqstate_commit() at vm_pageout_laundry_worker+0x5e4 > pc =3D 0xffff0000006e93ac lr =3D 0xffff0000006f02c0 > sp =3D 0xffff0000521ec680 fp =3D 0xffff0000521ec940 >=20 > vm_pageout_laundry_worker() at fork_exit+0x7c > pc =3D 0xffff0000006f02c0 lr =3D 0xffff0000003c7fdc > sp =3D 0xffff0000521ec950 fp =3D 0xffff0000521ec980 >=20 > fork_exit() at fork_trampoline+0x10 > pc =3D 0xffff0000003c7fdc lr =3D 0xffff00000075230c > sp =3D 0xffff0000521ec990 fp =3D 0x0000000000000000 >=20 > db>=20 >=20 > Thanks for reading, if there's anything to try please let me know. >=20 > bob prohaska >=20 > _______________________________________________ > freebsd-arm@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-arm > To unsubscribe, send any mail to "freebsd-arm-unsubscribe@freebsd.org" From owner-freebsd-current@freebsd.org Thu Jan 2 13:58:30 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1B42A1F7CFB; Thu, 2 Jan 2020 13:58:30 +0000 (UTC) (envelope-from vidwer@gmail.com) Received: from mail-ot1-x342.google.com (mail-ot1-x342.google.com [IPv6:2607:f8b0:4864:20::342]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47pV4P741Pz4RYR; Thu, 2 Jan 2020 13:58:29 +0000 (UTC) (envelope-from vidwer@gmail.com) Received: by mail-ot1-x342.google.com with SMTP id k14so57191412otn.4; Thu, 02 Jan 2020 05:58:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1Np9hTJ+HnMqW9yoB2odhuV3i9H2dub40W06D4ninls=; b=S5QKMmiWajiymWE5nXWZyq+6k+BNyAsegGyrdj0pQ00t5+Fq+nOJMBUJ52BUKOeAMZ yfAwVYRvmnGGC+znj9GfPNsZiaTtTs7VS+AyIs7Ewdj3JZoO36Wj0pZJ2tZinvg7htn1 oiQMUKPoXLG9hbipb1gioERZmwSaghjDFRhm4Zsf4zb7E7u1tOAbfyLRk3y0Nrw0sL8O hCTkFCSC0QSZjq+w6bS2WB1cfW2ZYnF/49zOGm4QxGsOpT+7Z3MGRSDOrgtE1CqMr4hx gpdRJY9S53vdVJr1ogMAD7vFJaknYwAIgUnVxnfF07U2SVMbAXEVrvlVV15ooW+sPdv6 NUIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1Np9hTJ+HnMqW9yoB2odhuV3i9H2dub40W06D4ninls=; b=kVjMm5t06JNyPg7yhv+3vUgKsr6u2NNoJWhF3cgXv6FBBLqNL+rGJYyh85Se7krp+r VX3Y66MN5vxwvAv86IbJr4122G9EeZBzFivij8Zx6k69AmGqhZLrAA6dyag1KtXI5BP+ IL3QYPwew9k88r4buVG3DYMSK+ss3J7n1Z3yvvSUd86eT1w1xJLRNJG74NREcY4/I0OZ tg9BiEfa1/TvpEHiPRLmQDjxfwLccvHUaPyACUcax2om5+LPEOamA4SH7P7MwjotvzTJ E7QGVRAvtsEV1bha/GvAoquAZR8KsRBE5r0+oCZrFwwSsXqD2OfkRoWjWmK0HC2nuIqh +hnw== X-Gm-Message-State: APjAAAXdmJ15+D0+oIb+Xu0aEaTRjdRdKmsVh7cTdjCOzhdS2W2z11EO fhQ2CkC9gMF4BQk8kydLf5aOVmz51CoQTBCsO7qfSgUC X-Google-Smtp-Source: APXvYqwtXMhDZCHl/8Knx35tydqCULUAh50ri91oCrhnnaJxOdT9zL95I8/AMC2uJLn6fx1xNHCEBMRR5ppq97Sr23E= X-Received: by 2002:a05:6830:1e21:: with SMTP id t1mr73848652otr.194.1577973508408; Thu, 02 Jan 2020 05:58:28 -0800 (PST) MIME-Version: 1.0 References: <20200102001231.GA84583@www.zefox.net> In-Reply-To: From: Idwer Vollering Date: Thu, 2 Jan 2020 14:58:16 +0100 Message-ID: Subject: Re: panic: vm_page_astate_fcmpset: invalid head requeue request on RPI3 To: Michael Tuexen Cc: bob prohaska , freebsd-arm@freebsd.org, freebsd-current Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 47pV4P741Pz4RYR X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Jan 2020 13:58:30 -0000 This can happen on amd64, on r356262, too. $ kgdb /boot/kernel/kernel vmcore.0 GNU gdb (GDB) 8.3.1 [GDB v8.3.1 for FreeBSD] Copyright (C) 2019 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "x86_64-portbld-freebsd13.0". Type "show configuration" for configuration details. For bug reporting instructions, please see: . Find the GDB manual and other documentation resources online at: . For help, type "help". Type "apropos word" to search for commands related to "word"... Reading symbols from /boot/kernel/kernel... Reading symbols from /usr/lib/debug//boot/kernel/kernel.debug... Unread portion of the kernel message buffer: panic: vm_page_astate_fcmpset: invalid head requeue request for page 0xfffffe0001c8a7b8 cpuid = 2 time = 1577970641 KDB: stack backtrace: db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe00567ff710 vpanic() at vpanic+0x17e/frame 0xfffffe00567ff770 panic() at panic+0x43/frame 0xfffffe00567ff7d0 _vm_page_pqstate_commit_dequeue() at _vm_page_pqstate_commit_dequeue+0x34f/frame 0xfffffe00567ff840 vm_page_pqstate_commit_dequeue() at vm_page_pqstate_commit_dequeue+0x96/frame 0xfffffe00567ff880 vm_page_pqstate_commit() at vm_page_pqstate_commit+0x46/frame 0xfffffe00567ff8b0 vm_pageout_laundry_worker() at vm_pageout_laundry_worker+0x5be/frame 0xfffffe00567ffb30 fork_exit() at fork_exit+0x80/frame 0xfffffe00567ffb70 fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe00567ffb70 --- trap 0, rip = 0, rsp = 0, rbp = 0 --- KDB: enter: panic __curthread () at /usr/src/sys/amd64/include/pcpu_aux.h:55 55 __asm("movq %%gs:%P1,%0" : "=r" (td) : "n" (offsetof(struct pcpu, (kgdb) bt #0 __curthread () at /usr/src/sys/amd64/include/pcpu_aux.h:55 #1 doadump (textdump=0) at /usr/src/sys/kern/kern_shutdown.c:392 #2 0xffffffff8049bbba in db_dump (dummy=, dummy2=, dummy3=, dummy4=) at /usr/src/sys/ddb/db_command.c:575 #3 0xffffffff8049b97c in db_command (last_cmdp=, cmd_table=, dopager=1) at /usr/src/sys/ddb/db_command.c:482 #4 0xffffffff8049b6ed in db_command_loop () at /usr/src/sys/ddb/db_command.c:535 #5 0xffffffff8049e918 in db_trap (type=, code=) at /usr/src/sys/ddb/db_main.c:252 #6 0xffffffff80c15ab7 in kdb_trap (type=3, code=0, tf=) at /usr/src/sys/kern/subr_kdb.c:691 #7 0xffffffff8106a9d4 in trap (frame=0xfffffe00567ff640) at /usr/src/sys/amd64/amd64/trap.c:585 #8 #9 kdb_enter (why=0xffffffff811f6c89 "panic", msg=) at /usr/src/sys/kern/subr_kdb.c:478 #10 0xffffffff80bca46a in vpanic (fmt=, ap=) at /usr/src/sys/kern/kern_shutdown.c:897 #11 0xffffffff80bca203 in panic (fmt=0xffffffff81c7b008 "\260\266\033\201\377\377\377\377") at /usr/src/sys/kern/kern_shutdown.c:835 #12 0xffffffff80f2bb8f in _vm_page_pqstate_commit_dequeue (pq=, m=0xfffffe0001c8a7b8, old=0xfffffe00567ff900, new=...) at /usr/src/sys/vm/vm_page.h:790 #13 0xffffffff80f27d76 in vm_page_pqstate_commit_dequeue (m=0xfffffe0001c8a7b8, old=0xfffffe00567ff900, new=...) at /usr/src/sys/vm/vm_page.c:3369 #14 0xffffffff80f27c06 in vm_page_pqstate_commit (m=0xfffffe0001c8a7b8, old=0x80, new=...) at /usr/src/sys/vm/vm_page.c:3446 #15 0xffffffff80f2e82e in vm_pageout_launder (vmd=, launder=982, in_shortfall=) at /usr/src/sys/vm/vm_pageout.c:839 #16 vm_pageout_laundry_worker (arg=) at /usr/src/sys/vm/vm_pageout.c:1101 #17 0xffffffff80b87650 in fork_exit (callout=0xffffffff80f2e270 , arg=0x0, frame=0xfffffe00567ffb80) at /usr/src/sys/kern/kern_fork.c:1058 #18 (kgdb) up #1 doadump (textdump=0) at /usr/src/sys/kern/kern_shutdown.c:392 392 dumptid = curthread->td_tid; (kgdb) #2 0xffffffff8049bbba in db_dump (dummy=, dummy2=, dummy3=, dummy4=) at /usr/src/sys/ddb/db_command.c:575 575 error = doadump(false); (kgdb) #3 0xffffffff8049b97c in db_command (last_cmdp=, cmd_table=, dopager=1) at /usr/src/sys/ddb/db_command.c:482 482 (*cmd->fcn)(addr, have_addr, count, modif); (kgdb) #4 0xffffffff8049b6ed in db_command_loop () at /usr/src/sys/ddb/db_command.c:535 535 db_command(&db_last_command, &db_cmd_table, /* dopager */ 1); (kgdb) #5 0xffffffff8049e918 in db_trap (type=, code=) at /usr/src/sys/ddb/db_main.c:252 252 db_command_loop(); (kgdb) #6 0xffffffff80c15ab7 in kdb_trap (type=3, code=0, tf=) at /usr/src/sys/kern/subr_kdb.c:691 691 handled = be->dbbe_trap(type, code); (kgdb) #7 0xffffffff8106a9d4 in trap (frame=0xfffffe00567ff640) at /usr/src/sys/amd64/amd64/trap.c:585 585 if (kdb_trap(type, dr6, frame)) (kgdb) #8 (kgdb) #9 kdb_enter (why=0xffffffff811f6c89 "panic", msg=) at /usr/src/sys/kern/subr_kdb.c:478 478 kdb_why = KDB_WHY_UNSET; (kgdb) #10 0xffffffff80bca46a in vpanic (fmt=, ap=) at /usr/src/sys/kern/kern_shutdown.c:897 897 kdb_enter(KDB_WHY_PANIC, "panic"); (kgdb) #11 0xffffffff80bca203 in panic (fmt=0xffffffff81c7b008 "\260\266\033\201\377\377\377\377") at /usr/src/sys/kern/kern_shutdown.c:835 835 vpanic(fmt, ap); (kgdb) #12 0xffffffff80f2bb8f in _vm_page_pqstate_commit_dequeue (pq=, m=0xfffffe0001c8a7b8, old=0xfffffe00567ff900, new=...) at /usr/src/sys/vm/vm_page.h:790 790 KASSERT((new.flags & PGA_ENQUEUED) == 0 || new.queue != PQ_NONE, (kgdb) #13 0xffffffff80f27d76 in vm_page_pqstate_commit_dequeue (m=0xfffffe0001c8a7b8, old=0xfffffe00567ff900, new=...) at /usr/src/sys/vm/vm_page.c:3369 3369 ret = _vm_page_pqstate_commit_dequeue(pq, m, old, new); (kgdb) #14 0xffffffff80f27c06 in vm_page_pqstate_commit (m=0xfffffe0001c8a7b8, old=0x80, new=...) at /usr/src/sys/vm/vm_page.c:3446 3446 if (!vm_page_pqstate_commit_dequeue(m, old, new)) (kgdb) #15 0xffffffff80f2e82e in vm_pageout_launder (vmd=, launder=982, in_shortfall=) at /usr/src/sys/vm/vm_pageout.c:839 839 if (!vm_page_pqstate_commit(m, &old, new)) (kgdb) #16 vm_pageout_laundry_worker (arg=) at /usr/src/sys/vm/vm_pageout.c:1101 1101 target -= min(vm_pageout_launder(vmd, launder, (kgdb) #17 0xffffffff80b87650 in fork_exit (callout=0xffffffff80f2e270 , arg=0x0, frame=0xfffffe00567ffb80) at /usr/src/sys/kern/kern_fork.c:1058 1058 callout(arg, frame); (kgdb) #18 (kgdb) Initial frame selected; you cannot go up. Op do 2 jan. 2020 om 12:03 schreef Michael Tuexen : > > > On 2. Jan 2020, at 01:12, bob prohaska wrote: > > > > While playing at compiling www/chromium using > > FreeBSD 13.0-CURRENT (GENERIC) #2 r356165: Mon Dec 30 09:59:03 PST 2019 > > the machine crashed, reporting > > panic: vm_page_astate_fcmpset: invalid head requeue request for page 0xfffffd0031880490 > This problem is NOT arm specific. I've seen it on an amd64 system running syzkaller: > http://212.201.121.91:10000/crash?id=00704eb865e893ffda473a4859e062eef512cbde > > Best regards > Michael > > > > cpuid = 2 > > time = 1577921727 > > KDB: stack backtrace: > > db_trace_self() at db_trace_self_wrapper+0x28 > > pc = 0xffff000000735c5c lr = 0xffff000000106814 > > sp = 0xffff0000521ec240 fp = 0xffff0000521ec450 > > > > db_trace_self_wrapper() at vpanic+0x18c > > pc = 0xffff000000106814 lr = 0xffff000000408d90 > > sp = 0xffff0000521ec460 fp = 0xffff0000521ec510 > > > > vpanic() at panic+0x44 > > pc = 0xffff000000408d90 lr = 0xffff000000408b40 > > sp = 0xffff0000521ec520 fp = 0xffff0000521ec5a0 > > > > panic() at _vm_page_pqstate_commit_dequeue+0x340 > > pc = 0xffff000000408b40 lr = 0xffff0000006ed840 > > sp = 0xffff0000521ec5b0 fp = 0xffff0000521ec5f0 > > > > _vm_page_pqstate_commit_dequeue() at vm_page_pqstate_commit_dequeue+0xb8 > > pc = 0xffff0000006ed840 lr = 0xffff0000006e954c > > sp = 0xffff0000521ec600 fp = 0xffff0000521ec640 > > > > vm_page_pqstate_commit_dequeue() at vm_page_pqstate_commit+0x50 > > pc = 0xffff0000006e954c lr = 0xffff0000006e93ac > > sp = 0xffff0000521ec650 fp = 0xffff0000521ec670 > > > > vm_page_pqstate_commit() at vm_pageout_laundry_worker+0x5e4 > > pc = 0xffff0000006e93ac lr = 0xffff0000006f02c0 > > sp = 0xffff0000521ec680 fp = 0xffff0000521ec940 > > > > vm_pageout_laundry_worker() at fork_exit+0x7c > > pc = 0xffff0000006f02c0 lr = 0xffff0000003c7fdc > > sp = 0xffff0000521ec950 fp = 0xffff0000521ec980 > > > > fork_exit() at fork_trampoline+0x10 > > pc = 0xffff0000003c7fdc lr = 0xffff00000075230c > > sp = 0xffff0000521ec990 fp = 0x0000000000000000 > > > > KDB: enter: panic > > [ thread pid 21 tid 100071 ] > > Stopped at 0 > > db> bt > > Tracing pid 21 tid 100071 td 0xfffffd0001078560 > > db_trace_self() at db_stack_trace+0xf8 > > pc = 0xffff000000735c5c lr = 0xffff000000103c58 > > sp = 0xffff0000521ebe10 fp = 0xffff0000521ebe40 > > > > db_stack_trace() at db_command+0x228 > > pc = 0xffff000000103c58 lr = 0xffff0000001038d0 > > sp = 0xffff0000521ebe50 fp = 0xffff0000521ebf30 > > > > db_command() at db_command_loop+0x58 > > pc = 0xffff0000001038d0 lr = 0xffff000000103678 > > sp = 0xffff0000521ebf40 fp = 0xffff0000521ebf60 > > > > db_command_loop() at db_trap+0xf4 > > pc = 0xffff000000103678 lr = 0xffff00000010697c > > sp = 0xffff0000521ebf70 fp = 0xffff0000521ec190 > > > > db_trap() at kdb_trap+0x1d8 > > pc = 0xffff00000010697c lr = 0xffff0000004510d0 > > sp = 0xffff0000521ec1a0 fp = 0xffff0000521ec250 > > > > kdb_trap() at do_el1h_sync+0xf4 > > pc = 0xffff0000004510d0 lr = 0xffff000000752588 > > sp = 0xffff0000521ec260 fp = 0xffff0000521ec290 > > > > do_el1h_sync() at handle_el1h_sync+0x78 > > pc = 0xffff000000752588 lr = 0xffff000000738078 > > sp = 0xffff0000521ec2a0 fp = 0xffff0000521ec3b0 > > > > handle_el1h_sync() at kdb_enter+0x34 > > pc = 0xffff000000738078 lr = 0xffff00000045071c > > sp = 0xffff0000521ec3c0 fp = 0xffff0000521ec450 > > > > kdb_enter() at vpanic+0x1a8 > > pc = 0xffff00000045071c lr = 0xffff000000408dac > > sp = 0xffff0000521ec460 fp = 0xffff0000521ec510 > > > > vpanic() at panic+0x44 > > pc = 0xffff000000408dac lr = 0xffff000000408b40 > > sp = 0xffff0000521ec520 fp = 0xffff0000521ec5a0 > > > > panic() at _vm_page_pqstate_commit_dequeue+0x340 > > pc = 0xffff000000408b40 lr = 0xffff0000006ed840 > > sp = 0xffff0000521ec5b0 fp = 0xffff0000521ec5f0 > > > > _vm_page_pqstate_commit_dequeue() at vm_page_pqstate_commit_dequeue+0xb8 > > pc = 0xffff0000006ed840 lr = 0xffff0000006e954c > > sp = 0xffff0000521ec600 fp = 0xffff0000521ec640 > > > > vm_page_pqstate_commit_dequeue() at vm_page_pqstate_commit+0x50 > > pc = 0xffff0000006e954c lr = 0xffff0000006e93ac > > sp = 0xffff0000521ec650 fp = 0xffff0000521ec670 > > > > vm_page_pqstate_commit() at vm_pageout_laundry_worker+0x5e4 > > pc = 0xffff0000006e93ac lr = 0xffff0000006f02c0 > > sp = 0xffff0000521ec680 fp = 0xffff0000521ec940 > > > > vm_pageout_laundry_worker() at fork_exit+0x7c > > pc = 0xffff0000006f02c0 lr = 0xffff0000003c7fdc > > sp = 0xffff0000521ec950 fp = 0xffff0000521ec980 > > > > fork_exit() at fork_trampoline+0x10 > > pc = 0xffff0000003c7fdc lr = 0xffff00000075230c > > sp = 0xffff0000521ec990 fp = 0x0000000000000000 > > > > db> > > > > Thanks for reading, if there's anything to try please let me know. > > > > bob prohaska > > > > _______________________________________________ > > freebsd-arm@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/freebsd-arm > > To unsubscribe, send any mail to "freebsd-arm-unsubscribe@freebsd.org" > > _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" From owner-freebsd-current@freebsd.org Thu Jan 2 14:16:52 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C89C91D052D; Thu, 2 Jan 2020 14:16:52 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qt1-x844.google.com (mail-qt1-x844.google.com [IPv6:2607:f8b0:4864:20::844]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47pVTb4Xk2z4Sgr; Thu, 2 Jan 2020 14:16:51 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qt1-x844.google.com with SMTP id d18so32049741qtj.10; Thu, 02 Jan 2020 06:16:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=XK55SPCdSSATJL8TZbbKfkavp3TxuT/wIHBpfG5n14Y=; b=b3Y5mCI2pSVGtKs/i+O/jjfc8kd3tVkaGXAlb8ruUxE5nR6Ad/391RJc8U7Yr9dZYz psojNyLujZY+tzSMecaZo+7pmHosbZOV/0XXH7qZFV48uK+GUwyKgSN5B9rMBJeqjGjo 6si2uft9FaXsg/pnkMzcWK30oIqLK9JR8rhJTtfB7lOT//Nwm3o8HvTBp6JCI7NU3yP6 X4DxUvZHPXdbUJhE+5yzYY11HmAFPoYtrWbubXp9mVf4paffcSo30lTV/X+ZAPluccuO fbvO+HWn3ZhtIwTfzVIm5wu5ZrEw4l0UvEnv7A6f13OCTl0kO/Y8+bcLq3GWl9h55ih1 alsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=XK55SPCdSSATJL8TZbbKfkavp3TxuT/wIHBpfG5n14Y=; b=VweX1VHeJLHrZdNmWnw8/Tuxl6bjjbS1piOEw1yppgJBSrJLcza7AFp9VAVAXp7E/E TGSDqLO6fnOuUJ3b87Sx/x7DGr0osVX+SYx+7wrWMi1YVNkHbGk68QPNLb/grHOzkr4B p2BOgNwyDgHmmIT8WzpSj4T70hxMrJgYHg34IlpLunHZ5qVA1n4zlRaVOQiYRe0vlVL7 WmTW8jbNcjwsSqqpvsE27VDzRA/j1Ki7Xn9EGmFAnCrGt2O58LJhCEI6RjKvoQrm3rv9 AmlouAAkTWTB2Pb2js8P8dBBB1l59/0mXj9QA9IXUk1KF62ORT2xd+VkU9yPogtPB+dh bMLQ== X-Gm-Message-State: APjAAAX/u2SGsQafDJcXY6vHtoeqXqfSAaFKkuOAvobMf/EYZW8k11LB I0JUwnG9m07sdK9hqxqy6Xm3c6Fh X-Google-Smtp-Source: APXvYqySmHqDReLs0excxaFRS+cyfL3ikEUAScqwmI/wQo9zdMnAellUX9NYALMDDJzJvqfADhQZkQ== X-Received: by 2002:aed:3c12:: with SMTP id t18mr62183448qte.140.1577974610434; Thu, 02 Jan 2020 06:16:50 -0800 (PST) Received: from raichu (toroon0560w-lp130-05-69-158-183-252.dsl.bell.ca. [69.158.183.252]) by smtp.gmail.com with ESMTPSA id x8sm15141313qki.60.2020.01.02.06.16.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jan 2020 06:16:49 -0800 (PST) Sender: Mark Johnston Date: Thu, 2 Jan 2020 09:16:47 -0500 From: Mark Johnston To: Idwer Vollering Cc: Michael Tuexen , bob prohaska , freebsd-arm@freebsd.org, freebsd-current Subject: Re: panic: vm_page_astate_fcmpset: invalid head requeue request on RPI3 Message-ID: <20200102141647.GB71506@raichu> References: <20200102001231.GA84583@www.zefox.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 47pVTb4Xk2z4Sgr X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=b3Y5mCI2; dmarc=none; spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::844 as permitted sender) smtp.mailfrom=markjdb@gmail.com X-Spamd-Result: default: False [-2.04 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; NEURAL_HAM_MEDIUM(-1.00)[-0.997,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[freebsd.org]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; RCVD_IN_DNSWL_NONE(0.00)[4.4.8.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(-0.34)[ip: (2.34), ipnet: 2607:f8b0::/32(-2.14), asn: 15169(-1.87), country: US(-0.05)]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; FREEMAIL_TO(0.00)[gmail.com]; MID_RHS_NOT_FQDN(0.50)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Jan 2020 14:16:52 -0000 On Thu, Jan 02, 2020 at 02:58:16PM +0100, Idwer Vollering wrote: > This can happen on amd64, on r356262, too. > > $ kgdb /boot/kernel/kernel vmcore.0 > GNU gdb (GDB) 8.3.1 [GDB v8.3.1 for FreeBSD] > Copyright (C) 2019 Free Software Foundation, Inc. > License GPLv3+: GNU GPL version 3 or later > This is free software: you are free to change and redistribute it. > There is NO WARRANTY, to the extent permitted by law. > Type "show copying" and "show warranty" for details. > This GDB was configured as "x86_64-portbld-freebsd13.0". > Type "show configuration" for configuration details. > For bug reporting instructions, please see: > . > Find the GDB manual and other documentation resources online at: > . > > For help, type "help". > Type "apropos word" to search for commands related to "word"... > Reading symbols from /boot/kernel/kernel... > Reading symbols from /usr/lib/debug//boot/kernel/kernel.debug... > > Unread portion of the kernel message buffer: > panic: vm_page_astate_fcmpset: invalid head requeue request for page Sorry for the breakage. I believe the patch below will fix the problem, I am testing it now. diff --git a/sys/vm/vm_pageout.c b/sys/vm/vm_pageout.c index 1e74f5c4c6db..cbdab1374f72 100644 --- a/sys/vm/vm_pageout.c +++ b/sys/vm/vm_pageout.c @@ -834,6 +834,7 @@ vm_pageout_launder(struct vm_domain *vmd, int launder, bool in_shortfall) if (new.act_count > ACT_MAX) new.act_count = ACT_MAX; + new.flags &= ~PGA_QUEUE_OP_MASK; new.flags |= PGA_REQUEUE; new.queue = PQ_ACTIVE; if (!vm_page_pqstate_commit(m, &old, new)) @@ -1313,8 +1314,9 @@ vm_pageout_scan_active(struct vm_domain *vmd, int page_shortage) */ ps_delta = 0; if (old.queue != PQ_ACTIVE) { - old.queue = PQ_ACTIVE; - old.flags |= PGA_REQUEUE; + new.flags &= ~PGA_QUEUE_OP_MASK; + new.flags |= PGA_REQUEUE; + new.queue = PQ_ACTIVE; } } else { /* @@ -1350,6 +1352,7 @@ vm_pageout_scan_active(struct vm_domain *vmd, int page_shortage) ps_delta = 1; } + new.flags &= ~PGA_QUEUE_OP_MASK; new.flags |= PGA_REQUEUE; new.queue = nqueue; } @@ -1560,6 +1563,7 @@ vm_pageout_scan_inactive(struct vm_domain *vmd, int shortage, if (new.act_count > ACT_MAX) new.act_count = ACT_MAX; + new.flags &= ~PGA_QUEUE_OP_MASK; new.flags |= PGA_REQUEUE; new.queue = PQ_ACTIVE; if (!vm_page_pqstate_commit(m, &old, new)) From owner-freebsd-current@freebsd.org Thu Jan 2 23:33:53 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8DE521DEED3 for ; Thu, 2 Jan 2020 23:33:53 +0000 (UTC) (envelope-from flo@smeets.xyz) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 47pkrK0kf1z48WB for ; Thu, 2 Jan 2020 23:33:53 +0000 (UTC) (envelope-from flo@smeets.xyz) Received: by mailman.nyi.freebsd.org (Postfix) id 1631C1DEED0; Thu, 2 Jan 2020 23:33:53 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 14DC51DEECE for ; Thu, 2 Jan 2020 23:33:53 +0000 (UTC) (envelope-from flo@smeets.xyz) Received: from mail-out.smeets.xyz (mail-out.smeets.xyz [IPv6:2a01:4f8:10a:3543::25:11]) by mx1.freebsd.org (Postfix) with ESMTP id 47pkrJ0Ywzz48W8 for ; Thu, 2 Jan 2020 23:33:51 +0000 (UTC) (envelope-from flo@smeets.xyz) Received: from mail.smeets.xyz (mail.smeets.xyz [IPv6:2a01:4f8:10a:3543::25:3]) by mail-out.smeets.xyz (Postfix) with ESMTP id BD971386C1 for ; Fri, 3 Jan 2020 00:33:45 +0100 (CET) Received: from amavis.smeets.xyz (amavis.smeets.xyz [IPv6:2a01:4f8:10a:3543::aa:4]) by mail.smeets.xyz (Postfix) with ESMTP id B2DFEB05B3 for ; Fri, 3 Jan 2020 00:33:45 +0100 (CET) X-Virus-Scanned: amavisd-new at smeets.xyz Received: from mail.smeets.xyz ([IPv6:2a01:4f8:10a:3543::25:3]) by amavis.smeets.xyz (amavis.smeets.xyz [IPv6:2a01:4f8:10a:3543::aa:4]) (amavisd-new, port 10025) with ESMTP id KPNyXcp5-aNq for ; Fri, 3 Jan 2020 00:33:45 +0100 (CET) Received: from [IPv6:2003:cf:df0e:7879:84dd:2fdc:ec64:569a] (p20030006314ED47984DD2FDCEC64569A.dip0.t-ipconnect.de [IPv6:2003:6:314e:d479:84dd:2fdc:ec64:569a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) by mail.smeets.xyz (Postfix) with ESMTPSA id 665B0B059E for ; Fri, 3 Jan 2020 00:33:45 +0100 (CET) From: Florian Smeets Subject: netstat / sockstat in jail don't list tcp/udp sockets To: current@freebsd.org Message-ID: Date: Fri, 3 Jan 2020 00:33:45 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:73.0) Gecko/20100101 Thunderbird/73.0a1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 47pkrJ0Ywzz48W8 X-Spamd-Bar: --- X-Spamd-Result: default: False [-3.50 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[current@freebsd.org]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; IP_SCORE(-0.80)[ipnet: 2a01:4f8::/29(-2.43), asn: 24940(-1.55), country: DE(-0.02)]; DMARC_POLICY_ALLOW(-0.50)[smeets.xyz,reject]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/29, country:DE]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Jan 2020 23:33:53 -0000 Hi, maybe all of this is related to the net.inet.tcp.pcblist error message further down. What works on 12.1 (host running stable/12, jail running 12.1-RELEASE) root@db21:~ # sockstat -4 -l -P tcp USER COMMAND PID FD PROTO LOCAL ADDRESS FOREIGN ADDRESS root sshd 3907 4 tcp4 *:22 *:* root perl 3885 6 tcp4 *:4949 *:* mysql mysqld 3771 11 tcp4 *:4567 *:* mysql mysqld 3771 38 tcp46 *:3306 *:* nagios nrpe3 3465 4 tcp4 *:5666 *:* root master 3459 13 tcp4 *:25 *:* root@db21:~ # netstat -nl -p tcp Active Internet connections Proto Recv-Q Send-Q Local Address Foreign Address (state) tcp4 0 0 172.17.2.33.4567 172.17.1.33.22220 ESTABLISHED tcp4 0 0 172.17.2.33.58278 172.17.3.33.4567 ESTABLISHED root@db21:~ # sysctl net.inet.tcp.pcblist root@db21:~ # echo $? 0 doesn't work on head (r356268, host world/kernel and jail are in sync) root@db31:/ # sockstat -4 -l -P tcp USER COMMAND PID FD PROTO LOCAL ADDRESS FOREIGN ADDRESS root@db31:/ # netstat -nl -p tcp netstat: sysctl: net.inet.tcp.pcblist: No such file or directory root@db31:/ # sysctl net.inet.tcp.pcblist root@db31:/ # echo $? 0 root@db31:/ # exit root@host:~ # sockstat -4 -l -P tcp -j db31 USER COMMAND PID FD PROTO LOCAL ADDRESS FOREIGN ADDRESS root sshd 40 3 tcp4 *:22 *:* 88 mysqld 23261 11 tcp4 *:4567 *:* 88 mysqld 23261 37 tcp4 *:3306 *:* As db31 is my only jail running head and I only set this up in December I cannot tell how long this has been broken. Florian From owner-freebsd-current@freebsd.org Fri Jan 3 09:18:29 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 681151EBE2A for ; Fri, 3 Jan 2020 09:18:29 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic309-20.consmr.mail.gq1.yahoo.com (sonic309-20.consmr.mail.gq1.yahoo.com [98.137.65.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47pzpq3PZSz4bRj for ; Fri, 3 Jan 2020 09:18:27 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-YMail-OSG: 7XB1gfUVM1m3RI1RsXNC6kcfmgWPE.WM9dOnJ2ACTRoP_VI6I8arMNMrPSZhwc9 4fz346tVHvhcX8h6OUbLjo6jaRzp_nkW0g4P9dSqXriXIg5U9SkyGNmITt3F0TqigLUPZT66.IrL JcAI9VQylGVqlG3Y5a0cYyWMfeF42qVz5ov07qjHygwuE99Kb5bvnSGt0wem5G_mOQ8XmxqIPHCv v_ABmuBy17Gz867hd1u0lyshEB.KunXho4FxnHew0_zf_t9e_PMwy6Abz2drRXLGvHaEmiIKB5h_ 5ogFKeQFVZjE_z9CHFGr0Y06NrP8fUkfJEWTiArmGXwQjzO2TEkimiU2NSut1dRRzqqVlSNPSCw0 r_4BiHSg_hyonUn0W.g7Vbpz6ha40F3d9X2v3geWSrQ9.xo7E7HN3xVxGfqcqlaYrj9pytF6ABGY dsOOx5tkWX_M.SJyGro_mG6nyAb9n2__.NvONYIv7oMEj42IBopVcQI0H7gdD2M0WAm1uCrG5hZN awzC8MM.mWzlaoUpGjXLDYdfAvmjiuqJ0KWskWZQjcLNmwITS8Hi.GZHL8idahVjKe1MWtoXsegO JHheXQNlTAeA58uoyY1gYdKjU6cTNqLl.R1hDq1TxUZKYsZ.6xq4oRFLCgdpxexfyJbEz_Z0sK4o d6OeNc8oDrc1ZcouWWO2PLb.sC1tapXGAFiLaSbQ5OmeG2iOq0N1L0eBOdMRfTl7WAQ9yruwXLbX BmxXtDWIvY99xWDcqV5LoHfVh4jFbLPyO7TaykZ17ztlsLghRpxGSVt4zJy6kfV.v7ojTR5eloew t7mxB6KGaLqfwoXeMNi3Gqu70SgRChVnQSayXI3i44bxa22d2PKjVYL1xXXyfAukeMg_gYzMKbB5 g4lahkm0NtfdmItu7V88ciZnSoahdM1O66WWHjNZov7PyqVWlLuYBsz.35G1z8RGXjFG8yzf1XPV T_2CyNZ2Bra7zXCOKJxu2bSBpGWodGQV31DzK1NEB9YozcCwP7YAUuYG1A5_z2S_YEZKEcgiRLiD AGpeudvM3Ge7eUoHnKvluw52sUXPZMeUTVrGwoIWZ_bSNpkfmxfimYKAHDZWSR0sFQfCF4K7Whzl J9fW_IOth13mA3SM_VxbPnoFv2QhZ3NID_w9iWd1Qq8prgkZ3oBbguLXiB3CHGeEZA8kbGEWYDzf TYYrdGIt4vEHDqYl1RXAqTeL5zniVGm7ZglA2fCBbaiGL5.Z4oU8T_FDKTZ7ZojKbAtN_w0QiPCa WX8WX9uP5Nr8GiEq.k4uUB_Fgrg4YMLWiqPvLw168MQ7AXn.fwq6YFYJ52Tb4ypuFEqAic68U.FG MJqpZpOCHaNwDnfhZHYncPxYAM8b709WeuPchIaFQby1495K82DynU6fT8RqTH2tJa9SfDnpw81l Md71Gyo4T0GibVjW72aoVQuhxon2N1RU- Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.gq1.yahoo.com with HTTP; Fri, 3 Jan 2020 09:18:25 +0000 Received: by smtp415.mail.ne1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 474d053d45a3b4a793bc816ed52fb0df; Fri, 03 Jan 2020 09:18:20 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.40.2.2.4\)) Subject: head -r354701 seems to be why/when 32-bit powerpc FreeBSD stopped being able to boot PowerMac G5s (2 socket ones, anyway) Message-Id: <74629EC2-E81E-44D7-B767-2B95084E8982@yahoo.com> Date: Fri, 3 Jan 2020 01:18:19 -0800 To: "bdragon@freebsd.org" , Justin Hibbits , FreeBSD Current , FreeBSD PowerPC ML X-Mailer: Apple Mail (2.3608.40.2.2.4) References: <74629EC2-E81E-44D7-B767-2B95084E8982.ref@yahoo.com> X-Rspamd-Queue-Id: 47pzpq3PZSz4bRj X-Spamd-Bar: / X-Spamd-Result: default: False [-0.98 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; FREEMAIL_FROM(0.00)[yahoo.com]; MV_CASE(0.50)[]; DKIM_TRACE(0.00)[yahoo.com:+]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/21, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[yahoo.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.28)[-0.277,0]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; NEURAL_HAM_LONG(-0.20)[-0.203,0]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE(0.00)[ip: (7.42), ipnet: 98.137.64.0/21(0.88), asn: 36647(0.70), country: US(-0.05)]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[146.65.137.98.list.dnswl.org : 127.0.5.0]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jan 2020 09:18:29 -0000 (NOTE: I only have access to 2-socket G5's, so I do not know the behavior for other kinds. I've access to both 2-cores-each and 1-core-each contexts.) This analysis is based on installing artifact.ci.freebsd.org materials and testing if they boot the G5's or not. Other than a little /etc/fstab and /boot/loader.conf material, the artifact materials are unchanged. My builds are not involved. -r354702 fails to boot. (Details later, below.) -r354700 (the closest prior 32-bit powerpc artifcact) boots fine. -r354701 and -r354702 are: Author: bdragon Date: Thu Nov 14 04:34:17 2019 New Revision: 354701 URL: https://svnweb.freebsd.org/changeset/base/354701 Log: powerpc: Kernel fixes for ppc32 and powerpcspe w/ lld Fix wrong section ordering that was causing a ".got is not contiguous with other relro sections" lld error. This also brings ldscript.powerpc and ldscript.powerpcspe closer to ldscript.powerpc64. Also, remove unnecessary text relocs from the ppc32 AIM trap code. Author: mav Date: Thu Nov 14 04:34:58 2019 New Revision: 354702 URL: https://svnweb.freebsd.org/changeset/base/354702 Log: Make ntb(4) send bus_get_dma_tag() requests to parent buses passing real bus' child pointers instead of grandchilds. DMAR does not like requests from devices not parented directly by PCI. At this point I'm guessing -r354701 since it is powerpc specific. The following is based on typing from screen images . . . Failure style #1: . . . Trying to mount root from ufs:/dev/ada0s3 [rw,noatime]... SMP: 2 CPUs found; 2 CPUs usable; 1 CPUs woken WARNING: WITNESS option enabled, expect reduced performance. (And that is all.) Failure style #2: . . . Trying to mount root from ufs:/dev/ada0s3 [rw,noatime]... SMP: 2 CPUs found; 2 CPUs usable; 1 CPUs woken WARNING: WITNESS option enabled, expect reduced performance. [ thread pid 1 tid 100002 ] Stopped at dsmisssize+0x68c: illegal instruction 0 db> (So just 3 more lines showing up.) NOTE: I do not claim that there are not more problems later in head's history that fail even earlier in the boot, thus hiding what is reported here. There is one that I've not yet isolated the first artifact version for. Thus, testing for what I'm reporting here may require using older vintages of FreeBSD, unless other problems are dealt with first. === Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar) From owner-freebsd-current@freebsd.org Fri Jan 3 12:16:09 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3D8D51F09D6; Fri, 3 Jan 2020 12:16:09 +0000 (UTC) (envelope-from lwhsu@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47q3ls0XhVz3Htx; Fri, 3 Jan 2020 12:16:09 +0000 (UTC) (envelope-from lwhsu@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1129) id E5A1B1FCC1; Fri, 3 Jan 2020 12:16:08 +0000 (UTC) Date: Fri, 3 Jan 2020 12:16:08 +0000 From: Li-Wen Hsu To: freebsd-testing@freebsd.org Cc: freebsd-current@freebsd.org, freebsd-stable@freebsd.org Subject: FreeBSD CI Weekly Report 2019-12-29 Message-ID: <20200103121608.GA1545@freefall.freebsd.org> Reply-To: freebsd-testing@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.11.4 (2019-03-13) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jan 2020 12:16:09 -0000 (Please send the followup to freebsd-testing@ and note Reply-To is set.) FreeBSD CI Weekly Report 2019-12-29 =================================== Here is a summary of the FreeBSD Continuous Integration results for the period from 2019-12-23 to 2019-12-29. During this period, we have: * 1811 builds (95.1% (-3.4) passed, 4.9% (+3.4) failed) of buildworld and buildkernel (GENERIC and LINT) were executed on aarch64, amd64, armv6, armv7, i386, mips, mips64, powerpc, powerpc64, powerpcspe, riscv64, sparc64 architectures for head, stable/12, stable/11 branches. * 197 test runs (88.9% (+2.3) passed, 2.5% (-4.5) unstable, 8.6% (+2.2) exception) were executed on amd64, i386, riscv64 architectures for head, stable/12, stable/11 branches. * 22 doc builds (100% (0) passed) Test case status (on 2019-12-29 23:59): | Branch/Architecture | Total | Pass | Fail | Skipped | | ------------------- | -------- | --------- | ----- | ------- | | head/amd64 | 7636 (0) | 7567 (-3) | 0 (0) | 69 (+3) | | head/i386 | 7634 (0) | 7563 (+3) | 0 (0) | 71 (-3) | | 12-STABLE/amd64 | 7491 (0) | 7440 (-3) | 0 (0) | 51 (+3) | | 12-STABLE/i386 | 7489 (0) | 7434 (0) | 0 (0) | 55 (0) | | 11-STABLE/amd64 | 6860 (0) | 6813 (+3) | 0 (0) | 47 (-3) | | 11-STABLE/i386 | 6858 (0) | 6806 (-3) | 0 (0) | 52 (+3) | (The statistics from experimental jobs are omitted) If any of the issues found by CI are in your area of interest or expertise please investigate the PRs listed below. The latest web version of this report is available at https://hackmd.io/@FreeBSD-CI/report-20191229 and archive is available at https://hackmd.io/@FreeBSD-CI/ , any help is welcome. ## News * FreeBSD Foundation 2019 in Review: CI and Testing Advancements https://www.freebsdfoundation.org/blog/2019-in-review-ci-and-testing-advancements/ ## Failing build * https://ci.freebsd.org/job/FreeBSD-head-powerpcspe-build/ There are some issues after PowerPC switch to llvm toolchain. ## Failing and Flaky Tests (from experimental jobs) * https://ci.freebsd.org/job/FreeBSD-head-amd64-dtrace_test/ * cddl.usr.sbin.dtrace.common.misc.t_dtrace_contrib.tst_dynopt_d * https://bugs.freebsd.org/237641 * https://ci.freebsd.org/job/FreeBSD-head-amd64-test_zfs/ * There are ~13 failing and ~109 skipped cases, including flakey ones, see https://ci.freebsd.org/job/FreeBSD-head-amd64-test_zfs/lastCompletedBuild/testReport/ for more details * Work for cleaning these failing cass are in progress ## Disabled Tests * sys.fs.tmpfs.mount_test.large https://bugs.freebsd.org/212862 * sys.fs.tmpfs.link_test.kqueue https://bugs.freebsd.org/213662 * sys.kqueue.libkqueue.kqueue_test.main https://bugs.freebsd.org/233586 * sys.kern.ptrace_test.ptrace__PT_KILL_competing_stop https://bugs.freebsd.org/220841 * lib.libc.regex.exhaust_test.regcomp_too_big (i386 only) https://bugs.freebsd.org/237450 * sys.netinet.socket_afinet.socket_afinet_bind_zero https://bugs.freebsd.org/238781 * sys.netpfil.pf.names.names * sys.netpfil.pf.synproxy.synproxy https://bugs.freebsd.org/238870 * sys.kern.ptrace_test.ptrace__follow_fork_child_detached_unrelated_debugger https://bugs.freebsd.org/239292 * sys.kern.ptrace_test.ptrace__follow_fork_both_attached_unrelated_debugger https://bugs.freebsd.org/239397 * sys.kern.ptrace_test.ptrace__parent_sees_exit_after_child_debugger https://bugs.freebsd.org/239399 * sys.kern.ptrace_test.ptrace__follow_fork_parent_detached_unrelated_debugger https://bugs.freebsd.org/239425 * lib.libc.gen.getmntinfo_test.getmntinfo_test https://bugs.freebsd.org/240049 * sys.sys.qmath_test.qdivq_s64q https://bugs.freebsd.org/240219 * sys.kern.ptrace_test.ptrace__getppid https://bugs.freebsd.org/240510 * lib.libc.sys.stat_test.stat_socket https://bugs.freebsd.org/240621 * lib.libarchive.functional_test.test_write_filter_zstd https://bugs.freebsd.org/240683 * lib.libcasper.services.cap_dns.dns_test.main https://bugs.freebsd.org/241435 * local.kyua.* (31 cases) & local.lutok.* (3 cases) on 11-i386 https://ci.freebsd.org/job/FreeBSD-stable-11-i386-test/2278/testReport/ * sys.geom.class.multipath.failloop.failloop https://bugs.freebsd.org/242689 ## Issues ### Cause build fails * https://bugs.freebsd.org/233735 Possible build race: genoffset.o /usr/src/sys/sys/types.h: error: machine/endian.h: No such file or directory * https://bugs.freebsd.org/233769 Possible build race: ld: error: unable to find library -lgcc_s ### Cause kernel panics * https://bugs.freebsd.org/238870 sys.netpfil.pf.names.names and sys.netpfil.pf.synproxy.synproxy cause panic Patch exists: * https://reviews.freebsd.org/D20868 * https://reviews.freebsd.org/D20869 ### Open * https://bugs.freebsd.org/242689 sys.geom.class.multipath.failloop.failloop fails due to too many CTF entries * https://bugs.freebsd.org/237403 Tests in sys/opencrypto should be converted to Python3 * https://bugs.freebsd.org/237641 Flakey test case: common.misc.t_dtrace_contrib.tst_dynopt_d * https://bugs.freebsd.org/237656 "Freed UMA keg (rtentry) was not empty (18 items). Lost 1 pages of memory." seen when running sys/netipsec tests * https://bugs.freebsd.org/238781 sys.netinet.socket_afinet.socket_afinet_bind_zero does not work when mac_portacl(4) loaded * https://bugs.freebsd.org/239292 Flakey test case: sys.kern.ptrace_test.ptrace__follow_fork_child_detached_unrelated_debugger * https://bugs.freebsd.org/239397 Flakey test case: sys.kern.ptrace_test.ptrace__follow_fork_both_attached_unrelated_debugger * https://bugs.freebsd.org/239399 Flakey test case: sys.kern.ptrace_test.ptrace__parent_sees_exit_after_child_debugger * https://bugs.freebsd.org/239425 Flakey test case: sys.kern.ptrace_test.ptrace__follow_fork_parent_detached_unrelated_debugger * https://bugs.freebsd.org/241662 Flakey test case: lib.libarchive.functional_test.test_fuzz_iso9660 ### Others * [Tickets related to testing@](https://preview.tinyurl.com/y9maauwg) From owner-freebsd-current@freebsd.org Sat Jan 4 20:35:59 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 00DE71F6FE2; Sat, 4 Jan 2020 20:35:59 +0000 (UTC) (envelope-from peter@rulingia.com) Received: from vtr.rulingia.com (vtr.rulingia.com [IPv6:2001:19f0:5801:ebe:5400:1ff:fe53:30fd]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "vtr.rulingia.com", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47qtp53ZRgz4blF; Sat, 4 Jan 2020 20:35:56 +0000 (UTC) (envelope-from peter@rulingia.com) Received: from server.rulingia.com (ppp239-208.static.internode.on.net [59.167.239.208]) by vtr.rulingia.com (8.15.2/8.15.2) with ESMTPS id 004KZgAM011995 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 5 Jan 2020 07:35:48 +1100 (AEDT) (envelope-from peter@rulingia.com) X-Bogosity: Ham, spamicity=0.000000 Received: from server.rulingia.com (localhost.rulingia.com [127.0.0.1]) by server.rulingia.com (8.15.2/8.15.2) with ESMTPS id 004KZZlc033410 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 5 Jan 2020 07:35:35 +1100 (AEDT) (envelope-from peter@server.rulingia.com) Received: (from peter@localhost) by server.rulingia.com (8.15.2/8.15.2/Submit) id 004KZZev033409; Sun, 5 Jan 2020 07:35:35 +1100 (AEDT) (envelope-from peter) Date: Sun, 5 Jan 2020 07:35:35 +1100 From: Peter Jeremy To: Mark Millard Cc: freebsd-arm , FreeBSD Current Subject: Re: head -r356066 reaching kern.ipc.nmbclusters on Rock64 (CortexA53 with 4GiByte of RAM) while putting files on it via nfs: some evidence Message-ID: <20200104203535.GA32966@server.rulingia.com> References: <65659DD9-335A-40C7-A6DE-B71019BCD6E6.ref@yahoo.com> <65659DD9-335A-40C7-A6DE-B71019BCD6E6@yahoo.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="J2SCkAp4GZ/dPZZf" Content-Disposition: inline In-Reply-To: <65659DD9-335A-40C7-A6DE-B71019BCD6E6@yahoo.com> X-PGP-Key: http://www.rulingia.com/keys/peter.pgp User-Agent: Mutt/1.12.2 (2019-09-21) X-Rspamd-Queue-Id: 47qtp53ZRgz4blF X-Spamd-Bar: ------- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of peter@rulingia.com designates 2001:19f0:5801:ebe:5400:1ff:fe53:30fd as permitted sender) smtp.mailfrom=peter@rulingia.com X-Spamd-Result: default: False [-7.59 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+mx]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; DMARC_NA(0.00)[rulingia.com]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; SIGNED_PGP(-2.00)[]; FREEMAIL_TO(0.00)[yahoo.com]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:20473, ipnet:2001:19f0:5800::/38, country:US]; RCVD_TLS_ALL(0.00)[]; IP_SCORE(-3.19)[ip: (-9.67), ipnet: 2001:19f0:5800::/38(-4.84), asn: 20473(-1.40), country: US(-0.05)] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Jan 2020 20:35:59 -0000 --J2SCkAp4GZ/dPZZf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Sorry for the delay in responding. On 2019-Dec-27 21:59:49 -0800, Mark Millard via freebsd-arm wrote: >The following sort of sequence leads to the Rock64 not >responding on the console or over ethernet, after notifying >of nmbclusters having been reached. (This limits what >information I have of what things were like at the end.) There's a bug in the dwc(4) driver such that it can leak mbuf clusters. I've been running with the following patch but need to clean it up samewhat before I can commit it: Index: sys/dev/dwc/if_dwc.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- sys/dev/dwc/if_dwc.c (revision 356350) +++ sys/dev/dwc/if_dwc.c (working copy) @@ -755,7 +755,6 @@ dwc_rxfinish_locked(struct dwc_softc *sc) { struct ifnet *ifp; - struct mbuf *m0; struct mbuf *m; int error, idx, len; uint32_t rdes0; @@ -762,9 +761,8 @@ =20 ifp =3D sc->ifp; =20 - for (;;) { + for (; ; sc->rx_idx =3D next_rxidx(sc, sc->rx_idx)) { idx =3D sc->rx_idx; - rdes0 =3D sc->rxdesc_ring[idx].tdes0; if ((rdes0 & DDESC_RDES0_OWN) !=3D 0) break; @@ -773,9 +771,9 @@ BUS_DMASYNC_POSTREAD); bus_dmamap_unload(sc->rxbuf_tag, sc->rxbuf_map[idx].map); =20 + m =3D sc->rxbuf_map[idx].mbuf; len =3D (rdes0 >> DDESC_RDES0_FL_SHIFT) & DDESC_RDES0_FL_MASK; if (len !=3D 0) { - m =3D sc->rxbuf_map[idx].mbuf; m->m_pkthdr.rcvif =3D ifp; m->m_pkthdr.len =3D len; m->m_len =3D len; @@ -784,24 +782,33 @@ /* Remove trailing FCS */ m_adj(m, -ETHER_CRC_LEN); =20 + /* Consume the mbuf and mark it as consumed */ + sc->rxbuf_map[idx].mbuf =3D NULL; DWC_UNLOCK(sc); (*ifp->if_input)(ifp, m); DWC_LOCK(sc); + m =3D NULL; } else { /* XXX Zero-length packet ? */ } =20 - if ((m0 =3D dwc_alloc_mbufcl(sc)) !=3D NULL) { - if ((error =3D dwc_setup_rxbuf(sc, idx, m0)) !=3D 0) { - /* - * XXX Now what? - * We've got a hole in the rx ring. - */ + if (m =3D=3D NULL) { + if ((m =3D dwc_alloc_mbufcl(sc)) =3D=3D NULL) { + if_inc_counter(sc->ifp, IFCOUNTER_IQDROPS, 1); + continue; } - } else + } + + if ((error =3D dwc_setup_rxbuf(sc, idx, m)) !=3D 0) { + m_free(m); + device_printf(sc->dev, + "dwc_setup_rxbuf returned %d\n", error); if_inc_counter(sc->ifp, IFCOUNTER_IQDROPS, 1); - - sc->rx_idx =3D next_rxidx(sc, sc->rx_idx); + /* + * XXX Now what? + * We've got a hole in the rx ring. + */ + } } } --=20 Peter Jeremy --J2SCkAp4GZ/dPZZf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEE7rKYbDBnHnTmXCJ+FqWXoOSiCzQFAl4Q9xJfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEVF QjI5ODZDMzA2NzFFNzRFNjVDMjI3RTE2QTU5N0EwRTRBMjBCMzQACgkQFqWXoOSi CzQTpg//WnVv/CeDAL5WlR+xk8ocAbu0G3KymVzUkMjYvCWRJ0Fc3M9c+8yw/IAv j9p5emq1+APq89fB4edxhPH4nqjZEnuxd47/Gla8QMLQ1I9g0eyZwdb7wg6Oa+bp 23JffW2ovdMzMatKVnC9soB1QflXRCfGEmhJV5L/JV3xB/fjNs5soQrXk45gLDnY lSDA24IAjnGz8a1ZialujFPf581A4Nts3DMXNvvsIUr4nrEF73ZWs27kZtodEam6 EdkQnfrpW3bzQjca4ubefi6ONAb3dui/VLV4f9IWUUrKaY1IA2NMxcDWa2t8dEzw c8E88qfycXLpIRbVOWUTEx4WHeyBBf/OdtqoyQzU8TrAbfAU4kxjuTyEBmnaQRF5 NSBkc04iK7R4NbOPcq0GCzhW0lWjLaIwCVBfTAZ2vPPo50QiMeBfU+Y/jLXMxKKu QvfwFaPsbF1H3yUn3u8T/EJRQ1mX1X4yYSGRd+PG1k8SGjaezmAHZ2zEL/HHawu3 CSrU8CdFn60reZqCrLAvw3js8b2M/cmfNy9S4mkuGdnakPgPYuV0h/e/xd+kt/6Q IuIfZ6O6HiZCaCGFYRsLr3+McV2dOFhGdL5fPefzBcmNmXnkjJh+Ee3yLQSLizLF jxijm9qjA3Uo5gdxOkaK2jR9SGztC2XmtF37ly4w69fdPYXG16E= =iJkU -----END PGP SIGNATURE----- --J2SCkAp4GZ/dPZZf--