From owner-freebsd-fs@freebsd.org Sun Feb 14 02:45:50 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 980E95464C4 for ; Sun, 14 Feb 2021 02:45:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4DdWnV3gMRz3vsk for ; Sun, 14 Feb 2021 02:45:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 7DF0C5464C3; Sun, 14 Feb 2021 02:45:50 +0000 (UTC) Delivered-To: fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7DBA054646A for ; Sun, 14 Feb 2021 02:45:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DdWnV35X3z3vvy for ; Sun, 14 Feb 2021 02:45:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 5CC7D227B1 for ; Sun, 14 Feb 2021 02:45:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11E2joBn025692 for ; Sun, 14 Feb 2021 02:45:50 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11E2jo30025691 for fs@FreeBSD.org; Sun, 14 Feb 2021 02:45:50 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 253158] Panic: snapacct_ufs2: bad block - Non-suJ mksnap_ffs(8) crash Date: Sun, 14 Feb 2021 02:45:49 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: panic X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: cy@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Feb 2021 02:45:50 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253158 --- Comment #33 from Cy Schubert --- It's on freefall in ~cy/pr253158.tar.xz. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Sun Feb 14 08:14:01 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A7CAE54E629 for ; Sun, 14 Feb 2021 08:14:01 +0000 (UTC) (envelope-from artem@artem.ru) Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [94.100.177.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ddg48445Sz4jF9 for ; Sun, 14 Feb 2021 08:14:00 +0000 (UTC) (envelope-from artem@artem.ru) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mail.ru; s=mail3; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Date:Message-ID:Subject:From:To:From:Subject:Content-Type:Content-Transfer-Encoding:To:Cc; bh=6ZuGSHsfM7Me6KY6gZ0SHNMQNQI6nw71fAU0t6yA0+I=; b=an5wnXCvNKMQzepcqOT4G+hmER98NU59OsrGiIxHndoTcbgRBuuFQzk6Yn6V/jiD8RFPh8UGHgXzZfRVXo2/7SFEzy046PpNvjSdduImWolvESeJWflOJjb7Kpn78GUEA6Me540Dm4VcTpEVE9nu+FUa3j0kJUjFfe/dKzuJxfU=; Received: by smtp33.i.mail.ru with esmtpa (envelope-from ) id 1lBCXV-000834-Ja for freebsd-fs@freebsd.org; Sun, 14 Feb 2021 11:13:58 +0300 To: freebsd-fs@freebsd.org From: Artem Kuchin Subject: How read file data from certain mirror with zdb ? Message-ID: <6d484dd6-c2d0-66ef-c703-f7575c2e4d33@artem.ru> Date: Sun, 14 Feb 2021 11:13:57 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: ru X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD981647AC6901E234B939F02D0E92C1ADFFCD11FC915E146DC182A05F5380850400119425E0593111C03C8B269B025D44F245C962A6F2FF094581BFC9EFAFD3D13 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7811C3E343B302E2EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637B5932F77F0041FFB8638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FC34BF3D2517DEEB51B4E08244B7190432AB0D17678A4DB7D3389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C05A64D9A1E9CA65708941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6D6FBC3EC642A93BBCC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C22495D224A4ECC5A0F1076E601842F6C81A12EF20D2F80756B5F7E9C4E3C761E06A776E601842F6C81A127C277FBC8AE2E8B024BE31D930B01393AA81AA40904B5D9DBF02ECDB25306B2B25CBF701D1BE8734AD6D5ED66289B5278DA827A17800CE75A9E79F66F1C28F367F23339F89546C5A8DF7F3B2552694A6FED454B719173D6725E5C173C3A84C3C9BE88FFEDFA497A35872C767BF85DA2F004C906525384306FED454B719173D6462275124DF8B9C9D28595B116005B47574AF45C6390F7469DAA53EE0834AAEE X-C1DE0DAB: C20DE7B7AB408E4181F030C43753B8186998911F362727C414F749A5E30D975C1C18E6A7EDD591E693269B5B341073B3EC047CCE8B41163F9C2B6934AE262D3EE7EAB7254005DCED4F23434ECEEDB5761E0A4E2319210D9B64D260DF9561598F01A9E91200F654B03031C89702B531498E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34B0359B88B232A0C6A56B7AB92110DAA6AFF75DCC5EB2007EC1C4E0E09940A68723B59953180C46741D7E09C32AA3244CF4F66B969BBEA66DBF999BA1B052DF18E3D93501275E802F3EB3F6AD6EA9203E X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojbL9S8ysBdXh64Ns0/kWpLH83RTd9WriQ X-Mailru-Sender: 0E9E14D9EC491FBA9E420E78D0FA8647ED1341AE4416BE89C7895E202F3DF7420DF36DDD7DA1CC040A1FD29A504278DEE66B5C1DBFD5D09D2FFF0A5F0DFA254CD0701747CC0EF98689F635B1FCB23A66AE208404248635DF X-Mras: Ok X-Rspamd-Queue-Id: 4Ddg48445Sz4jF9 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=mail.ru header.s=mail3 header.b=an5wnXCv; dmarc=none; spf=none (mx1.freebsd.org: domain of artem@artem.ru has no SPF policy when checking 94.100.177.93) smtp.mailfrom=artem@artem.ru X-Spamd-Result: default: False [-2.40 / 15.00]; ARC_NA(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[94.100.177.93:from]; R_DKIM_ALLOW(-0.20)[mail.ru:s=mail3]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; DMARC_NA(0.00)[artem.ru]; RCPT_COUNT_ONE(0.00)[1]; SPAMHAUS_ZRD(0.00)[94.100.177.93:from:127.0.2.255]; DKIM_TRACE(0.00)[mail.ru:+]; NEURAL_HAM_SHORT(-1.00)[-1.000]; R_SPF_NA(0.00)[no SPF record]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; SUBJECT_ENDS_QUESTION(1.00)[]; ASN(0.00)[asn:47764, ipnet:94.100.176.0/20, country:RU]; MID_RHS_MATCH_FROM(0.00)[]; MAILMAN_DEST(0.00)[freebsd-fs]; RCVD_IN_DNSWL_LOW(-0.10)[94.100.177.93:from] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Feb 2021 08:14:01 -0000 Hello! Have a mirror pool. I can read the file dta with zdb using zdb -R pool path But i need to read the data from certain mirror drive. How to i specify the path to get data from selected mirror drive? From owner-freebsd-fs@freebsd.org Sun Feb 14 09:56:54 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 60D7552923E for ; Sun, 14 Feb 2021 09:56:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4DdjLt25ctz4pmv for ; Sun, 14 Feb 2021 09:56:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 47EF952923D; Sun, 14 Feb 2021 09:56:54 +0000 (UTC) Delivered-To: fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 47B7D528F71 for ; Sun, 14 Feb 2021 09:56:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DdjLt1Qddz4pQm for ; Sun, 14 Feb 2021 09:56:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 2383D27FE4 for ; Sun, 14 Feb 2021 09:56:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11E9us4W039476 for ; Sun, 14 Feb 2021 09:56:54 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11E9usQp039475 for fs@FreeBSD.org; Sun, 14 Feb 2021 09:56:54 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 253158] Panic: snapacct_ufs2: bad block - Non-suJ mksnap_ffs(8) crash Date: Sun, 14 Feb 2021 09:56:54 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: panic X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: kib@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Feb 2021 09:56:54 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253158 --- Comment #34 from Konstantin Belousov --- (In reply to Cy Schubert from comment #33) So everything in the dump looks fine, except in the vn_io_fault1() frame, the short_uio offset and resid are corrupted, which ultimately causes the panic when ffs_read() tries to actually move bytes around. Please apply the following debugging patch, compile the same way as you did, and provide me with the kernel.full+vmcore, again. Thanks. diff --git a/sys/kern/vfs_vnops.c b/sys/kern/vfs_vnops.c index f8943b3c07e7..72357d3ab2af 100644 --- a/sys/kern/vfs_vnops.c +++ b/sys/kern/vfs_vnops.c @@ -1339,6 +1339,8 @@ vn_io_fault1(struct vnode *vp, struct uio *uio, struct vn_io_fault_args *args, td->td_ma =3D ma; td->td_ma_cnt =3D cnt; +volatile struct uio short_uio1; +short_uio1 =3D short_uio; error =3D vn_io_fault_doio(args, &short_uio, td); vm_page_unhold_pages(ma, cnt); adv =3D len - short_uio.uio_resid; --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Sun Feb 14 17:52:24 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3DBD95372B3 for ; Sun, 14 Feb 2021 17:52:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4DdvvX15Rrz3rnM for ; Sun, 14 Feb 2021 17:52:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 257705372B1; Sun, 14 Feb 2021 17:52:24 +0000 (UTC) Delivered-To: fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 253AD53710E for ; Sun, 14 Feb 2021 17:52:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DdvvX0WWGz3rwF for ; Sun, 14 Feb 2021 17:52:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 050776B95 for ; Sun, 14 Feb 2021 17:52:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11EHqNfM062915 for ; Sun, 14 Feb 2021 17:52:23 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11EHqNeu062914 for fs@FreeBSD.org; Sun, 14 Feb 2021 17:52:23 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 253158] Panic: snapacct_ufs2: bad block - Non-suJ mksnap_ffs(8) crash Date: Sun, 14 Feb 2021 17:52:23 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: panic X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: bugzilla.freebsd@omnilan.de X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Feb 2021 17:52:24 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253158 --- Comment #35 from Harald Schmalzbauer --- Created attachment 222440 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D222440&action= =3Dedit kgdb output with volatile struct uio short_uio1 (In reply to Konstantin Belousov from comment #34) Please find attached the output after adding your diff - I could reproduce = on main-14 aswell. Nothing obviously (to me) differs in my debug info, so might be useless too? --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Sun Feb 14 19:34:23 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 897CC539F9C for ; Sun, 14 Feb 2021 19:34:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4Ddy9C3GCKz4Shf for ; Sun, 14 Feb 2021 19:34:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 6E365539F9B; Sun, 14 Feb 2021 19:34:23 +0000 (UTC) Delivered-To: fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6DFFA539C67 for ; Sun, 14 Feb 2021 19:34:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ddy9C2dHxz4Sbn for ; Sun, 14 Feb 2021 19:34:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4DCB110511 for ; Sun, 14 Feb 2021 19:34:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11EJYNg5013245 for ; Sun, 14 Feb 2021 19:34:23 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11EJYNi9013244 for fs@FreeBSD.org; Sun, 14 Feb 2021 19:34:23 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 253158] Panic: snapacct_ufs2: bad block - Non-suJ mksnap_ffs(8) crash Date: Sun, 14 Feb 2021 19:34:22 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: panic X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: cy@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Feb 2021 19:34:23 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253158 --- Comment #36 from Cy Schubert --- Panic. See freefall:~cy/pr253158-2.tar.xz --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Sun Feb 14 21:00:04 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1DC7B53BFA4 for ; Sun, 14 Feb 2021 21:00:04 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4Df044060Jz4Xty for ; Sun, 14 Feb 2021 21:00:04 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: by mailman.nyi.freebsd.org (Postfix) id 038F753BFA3; Sun, 14 Feb 2021 21:00:04 +0000 (UTC) Delivered-To: fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0356853BF35 for ; Sun, 14 Feb 2021 21:00:04 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Df0436ZZvz4Xf4 for ; Sun, 14 Feb 2021 21:00:03 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id D3E001160B for ; Sun, 14 Feb 2021 21:00:03 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11EL03BN055641 for ; Sun, 14 Feb 2021 21:00:03 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11EL03e2055640 for fs@FreeBSD.org; Sun, 14 Feb 2021 21:00:03 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Message-Id: <202102142100.11EL03e2055640@kenobi.freebsd.org> X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@FreeBSD.org using -f From: bugzilla-noreply@FreeBSD.org To: fs@FreeBSD.org Subject: Problem reports for fs@FreeBSD.org that need special attention Date: Sun, 14 Feb 2021 21:00:03 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Feb 2021 21:00:04 -0000 To view an individual PR, use: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=(Bug Id). The following is a listing of current problems submitted by FreeBSD users, which need special attention. These represent problem reports covering all versions including experimental development code and obsolete releases. Status | Bug Id | Description ------------+-----------+--------------------------------------------------- New | 203492 | mount_unionfs -o below causes panic Open | 144447 | [zfs] sharenfs fsunshare() & fsshare_main() non f Open | 211491 | System hangs after "Uptime" on reboot with ZFS Open | 221909 | [ZFS] Add a sysctl to toggle send_corrupt_data Open | 237067 | ZFS: Crash in vdev_dtl_reassess when using GELI w Open | 240831 | zfs: Panic during snapshot on 12.1-STABLE r352648 Open | 243973 | [zfs] rollback segmentation fault Open | 244656 | zfs: resilver doesn't provide enough information Open | 244692 | gjournal: Does not support TRIM Open | 244899 | [PATCH] zfs: xattr on a symlink target > 136 caus Open | 251035 | [zfs] Allow 64 bit ZFS to support 32 bit ioctls ( 11 problems total for which you should take action. From owner-freebsd-fs@freebsd.org Mon Feb 15 02:19:33 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A67A9545267 for ; Mon, 15 Feb 2021 02:19:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4Df78h6sPTz4tCF for ; Mon, 15 Feb 2021 02:19:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 493F55455F2; Mon, 15 Feb 2021 02:19:32 +0000 (UTC) Delivered-To: fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4648B5452B9 for ; Mon, 15 Feb 2021 02:19:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Df78f5x9cz4tMx for ; Mon, 15 Feb 2021 02:19:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 420611557E for ; Mon, 15 Feb 2021 02:19:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11F2JUEP019713 for ; Mon, 15 Feb 2021 02:19:30 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11F2JUX6019712 for fs@FreeBSD.org; Mon, 15 Feb 2021 02:19:30 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 253428] getdirentries does not work correctly on NFS mounts Date: Mon, 15 Feb 2021 02:19:30 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2021 02:19:33 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253428 --- Comment #12 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Da0698341cd894ba4a640e9a9bb0f72c21= 33d1228 commit a0698341cd894ba4a640e9a9bb0f72c2133d1228 Author: Rick Macklem AuthorDate: 2021-02-15 02:16:58 +0000 Commit: Rick Macklem CommitDate: 2021-02-15 02:16:58 +0000 getdirentries.2: fix for NFS mounts It was reported that getdirentries(2) was returning dirents with d_off set to 0 for an NFS mount. This is believed to be correct behaviour at this time (it may change for some NFS mounts in the future), but is inconsistent with what the getdirentries(2) man page says. This patch fixes the man page. This is a content change. PR: 253428 Reviewed by: asomers MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D28664 lib/libc/sys/getdirentries.2 | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Mon Feb 15 03:39:01 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2EC725471B9 for ; Mon, 15 Feb 2021 03:39:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4Df8wP0fSsz3FBS for ; Mon, 15 Feb 2021 03:39:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 13A1B547234; Mon, 15 Feb 2021 03:39:01 +0000 (UTC) Delivered-To: fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 124305472AA for ; Mon, 15 Feb 2021 03:39:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Df8wN6xnlz3FQD for ; Mon, 15 Feb 2021 03:39:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id D705816A22 for ; Mon, 15 Feb 2021 03:39:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11F3d06e056232 for ; Mon, 15 Feb 2021 03:39:00 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11F3d05q056231 for fs@FreeBSD.org; Mon, 15 Feb 2021 03:39:00 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 253158] Panic: snapacct_ufs2: bad block - Non-suJ mksnap_ffs(8) crash Date: Mon, 15 Feb 2021 03:39:01 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: panic X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: kib@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2021 03:39:01 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253158 --- Comment #37 from Konstantin Belousov --- (In reply to Cy Schubert from comment #36) Ok, I can (partially) understand it. Below are two patches. I believe that either one of them should fix the problem. Can you check please? [Both are needed for correctness] commit 83a450af9edfd1b5ca705e8101870109225fdc7d Author: Konstantin Belousov Date: Mon Feb 15 05:36:02 2021 +0200 UFS snapshots: properly set the vm object size. PR: 253158 diff --git a/sys/ufs/ffs/ffs_snapshot.c b/sys/ufs/ffs/ffs_snapshot.c index 8f0adde6f5e4..6da84fb46bb0 100644 --- a/sys/ufs/ffs/ffs_snapshot.c +++ b/sys/ufs/ffs/ffs_snapshot.c @@ -59,6 +59,9 @@ __FBSDID("$FreeBSD$"); #include #include +#include +#include + #include #include @@ -328,6 +331,7 @@ ffs_snapshot(mp, snapfile) goto out; bawrite(bp); ip->i_size =3D lblktosize(fs, (off_t)(numblks + 1)); + vnode_pager_setsize(vp, ip->i_size); DIP_SET(ip, i_size, ip->i_size); UFS_INODE_SET_FLAG(ip, IN_SIZEMOD | IN_CHANGE | IN_UPDATE); /* commit 7b34e5b278f9f2af69f5d39f7999507a17238293 Author: Konstantin Belousov Date: Mon Feb 15 05:34:06 2021 +0200 pgcache read: protect against reads past end of the vm object size If uio_offset is past end of the object size, calculated resid is negat= ive. Delegate handling this case to the locked read, as any other non-trivial situation. PR: 253158 diff --git a/sys/kern/vfs_vnops.c b/sys/kern/vfs_vnops.c index 46b333b2261f..b13eb442e436 100644 --- a/sys/kern/vfs_vnops.c +++ b/sys/kern/vfs_vnops.c @@ -967,6 +967,8 @@ vn_read_from_obj(struct vnode *vp, struct uio *uio) #else vsz =3D atomic_load_64(&obj->un_pager.vnp.vnp_size); #endif + if (uio->uio_offset >=3D vsz) + goto out; if (uio->uio_offset + resid > vsz) resid =3D vsz - uio->uio_offset; --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Mon Feb 15 04:32:10 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3BECA5483AF for ; Mon, 15 Feb 2021 04:32:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4DfB5k10rDz3J0P for ; Mon, 15 Feb 2021 04:32:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 22423548492; Mon, 15 Feb 2021 04:32:10 +0000 (UTC) Delivered-To: fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 207A25485A1 for ; Mon, 15 Feb 2021 04:32:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DfB5k0D8mz3Hx7 for ; Mon, 15 Feb 2021 04:32:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id EEAA21753B for ; Mon, 15 Feb 2021 04:32:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11F4W9GG086110 for ; Mon, 15 Feb 2021 04:32:09 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11F4W9r7086109 for fs@FreeBSD.org; Mon, 15 Feb 2021 04:32:09 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 253158] Panic: snapacct_ufs2: bad block - Non-suJ mksnap_ffs(8) crash Date: Mon, 15 Feb 2021 04:32:09 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: panic X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: cy@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status resolution Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2021 04:32:10 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253158 Cy Schubert changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Progress |Closed Resolution|--- |FIXED --- Comment #38 from Cy Schubert --- That fixes it. beastie# newfs /dev/ada3 /dev/ada3: 16384.0MB (33554432 sectors) block size 32768, fragment size 4096 using 27 cylinder groups of 625.22MB, 20007 blks, 80128 inodes. super-block backups (for fsck_ffs -b #) at: 192, 1280640, 2561088, 3841536, 5121984, 6402432, 7682880, 8963328, 102437= 76, 11524224, 12804672, 14085120, 15365568, 16646016, 17926464, 19206912, 20487360, 21767808, 23048256, 24328704, 25609152, 26889600, 28170048, 29450496, 30730944, 32011392, 33291840 beastie# mount /dev/ada3 /mnt beastie# mksnap_ffs /mnt/.snap/test beastie# fstyp /mnt/.snap/test ufs beastie#=20 Note: when committing, I didn't report this problem. I only tested it. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Mon Feb 15 04:44:22 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 51E0754888A for ; Mon, 15 Feb 2021 04:44:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4DfBMp1j1xz3JYK for ; Mon, 15 Feb 2021 04:44:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 3A636548888; Mon, 15 Feb 2021 04:44:22 +0000 (UTC) Delivered-To: fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3A2D15485BB for ; Mon, 15 Feb 2021 04:44:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DfBMp16QGz3JbC for ; Mon, 15 Feb 2021 04:44:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 15400177C5 for ; Mon, 15 Feb 2021 04:44:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11F4iMUL090540 for ; Mon, 15 Feb 2021 04:44:22 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11F4iMf4090539 for fs@FreeBSD.org; Mon, 15 Feb 2021 04:44:22 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 253158] Panic: snapacct_ufs2: bad block - Non-suJ mksnap_ffs(8) crash Date: Mon, 15 Feb 2021 04:44:22 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: panic X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: kib@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2021 04:44:22 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253158 --- Comment #39 from Konstantin Belousov --- (In reply to Cy Schubert from comment #38) Did you tested each patch alone, or just applied both? I am interested to see if each patch alone fixes it as well. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Mon Feb 15 07:05:09 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 157DF54B63E for ; Mon, 15 Feb 2021 07:05:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4DfFVD73Gfz3R9R for ; Mon, 15 Feb 2021 07:05:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id F046E54B63D; Mon, 15 Feb 2021 07:05:08 +0000 (UTC) Delivered-To: fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F010754B4AB for ; Mon, 15 Feb 2021 07:05:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DfFVD6KY3z3Qlr for ; Mon, 15 Feb 2021 07:05:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id C83BE197A6 for ; Mon, 15 Feb 2021 07:05:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11F758ex059885 for ; Mon, 15 Feb 2021 07:05:08 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11F758xT059884 for fs@FreeBSD.org; Mon, 15 Feb 2021 07:05:08 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 253158] Panic: snapacct_ufs2: bad block - Non-suJ mksnap_ffs(8) crash Date: Mon, 15 Feb 2021 07:05:09 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: panic X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: mckusick@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2021 07:05:09 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253158 --- Comment #40 from Kirk McKusick --- (In reply to Konstantin Belousov from comment #37) Doing the vnode_pager_setsize() after setting the size is clearly the corre= ct fix. The previous code did not call vnode_pager_setsize() but worked because lat= er in ffs_snapshot() it does a UFS_WRITE() to output the snaplist. Previously = the UFS_WRITE() allocated the extra block at the end of the file which caused i= t to do the needed vnode_pager_setsize(). But the new code had already allocated= the extra block, so UFS_WRITE() did not extend the size and thus did not do the vnode_pager_setsize(). --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Mon Feb 15 07:28:22 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0A95F54B93A for ; Mon, 15 Feb 2021 07:28:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4DfG115Xbdz3hj8 for ; Mon, 15 Feb 2021 07:28:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id BE14C54B939; Mon, 15 Feb 2021 07:28:21 +0000 (UTC) Delivered-To: fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BDD9954BA20 for ; Mon, 15 Feb 2021 07:28:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DfG114ty0z3hnp for ; Mon, 15 Feb 2021 07:28:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 9ADBF19C2C for ; Mon, 15 Feb 2021 07:28:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11F7SLKe071882 for ; Mon, 15 Feb 2021 07:28:21 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11F7SLnl071881 for fs@FreeBSD.org; Mon, 15 Feb 2021 07:28:21 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 253158] Panic: snapacct_ufs2: bad block - Non-suJ mksnap_ffs(8) crash Date: Mon, 15 Feb 2021 07:28:21 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: panic X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: kib@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2021 07:28:22 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253158 --- Comment #41 from Konstantin Belousov --- (In reply to Kirk McKusick from comment #40) There are actually two bugs, fixed by two patches. One is the wrong size of the vnode vm object. BTW, I opted for additional vnode_pager_setsize() instead of setting fs_size + fs_blksize in initial vnode_create_vobject(), but I might reconsider this. It is somewhat simpler to see consequences of the fix/no fix when testing this variant of the patch alone. Second bug is that page cache read path in vfs_vnops.c is confused when uio_offset is past the end of file as recorded by vnode_pager_setsize(). It results in negative resid corrupting the state of the io request. Either of changes should fix the problem, which I want to get confirmations for. But both bugs should be fixed. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Mon Feb 15 08:19:51 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6E59854D058 for ; Mon, 15 Feb 2021 08:19:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4DfH8R2W9Wz3krN for ; Mon, 15 Feb 2021 08:19:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 5473254D057; Mon, 15 Feb 2021 08:19:51 +0000 (UTC) Delivered-To: fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 543CA54D312 for ; Mon, 15 Feb 2021 08:19:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DfH8R1q2Fz3l4J for ; Mon, 15 Feb 2021 08:19:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 314A11A5A9 for ; Mon, 15 Feb 2021 08:19:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11F8JpP7000684 for ; Mon, 15 Feb 2021 08:19:51 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11F8Jp3e000683 for fs@FreeBSD.org; Mon, 15 Feb 2021 08:19:51 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 253158] Panic: snapacct_ufs2: bad block - Non-suJ mksnap_ffs(8) crash Date: Mon, 15 Feb 2021 08:19:51 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: panic X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: bugzilla.freebsd@omnilan.de X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2021 08:19:51 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253158 --- Comment #42 from Harald Schmalzbauer --- (In reply to Konstantin Belousov from comment #41) I tried both diffs on their own on main-14 post 8563de2f2799b2cb6f2f06e3c9dddd48dca2a986 and you are right that both fix the panic with my simple test (ffs_snapshot.c=3D>fstyp-success; patch -R=3D>fstyp-panic; vfs_vnops.c=3D>fstyp-"filesystem not recognized" but no = panic). As you might have noticed, the code path is far beyond my skills. But I think I understand your explanation. What I do not understand is why it wasn't a problem for Kirk McKusick e.g. Depends on cache size? Here's the full output of the vfs_vnops.c-only-patched kernel and fstyp(8) result: fstyp: fread: Operation not permitted fstyp: /.snap/.test2: filesystem not recognized Thanks, -harry --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Mon Feb 15 08:22:12 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F36C654D35B; Mon, 15 Feb 2021 08:22:11 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4DfHC303V7z3lKt; Mon, 15 Feb 2021 08:22:06 +0000 (UTC) (envelope-from avg@FreeBSD.org) X-Originating-IP: 195.64.148.76 Received: from [192.168.0.88] (unknown [195.64.148.76]) (Authenticated sender: andriy.gapon@uabsd.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 68AFE20011; Mon, 15 Feb 2021 08:22:04 +0000 (UTC) To: FreeBSD Current , freebsd-fs@FreeBSD.org From: Andriy Gapon Subject: panic: condition seqc_in_modify(_vp->v_seqc) not met at zfs_acl.c:1147 (zfs_acl_chown_setattr) Message-ID: <1b261679-3492-dda8-614e-21150a2375d8@FreeBSD.org> Date: Mon, 15 Feb 2021 10:22:03 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.7.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4DfHC303V7z3lKt X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [0.00 / 15.00]; ASN(0.00)[asn:29169, ipnet:217.70.176.0/20, country:FR]; local_wl_from(0.00)[FreeBSD.org] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2021 08:22:12 -0000 I've got this panic once when copying a couple of files. The system is stable/13 as of 1996360d7338d, a custom kernel configuration, but no local source code modifications. Unread portion of the kernel message buffer: VNASSERT failed: ({ seqc_t __seqc = (_vp->v_seqc); __builtin_expect((__seqc & 1), 0); }) not true at /usr/devel/git/trant/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_acl.c:1147 (zfs_acl_chown_setattr) 0xfffff8013e4e85b8: type VDIR usecount 1, writecount 0, refcount 1 seqc users 0 mountedhere 0 hold count flags () flags () lock type zfs: EXCL by thread 0xfffffe01dd1cd560 (pid 30747, kdeinit5, tid 159911) panic: condition seqc_in_modify(_vp->v_seqc) not met at /usr/devel/git/trant/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_acl.c:1147 (zfs_acl_chown_setattr) Any ideas, suggestions, hints? Thanks! (kgdb) #0 doadump (textdump=textdump@entry=1) at /usr/devel/git/trant/sys/kern/kern_shutdown.c:399 #1 0xffffffff8083bea2 in kern_reboot (howto=260) at /usr/devel/git/trant/sys/kern/kern_shutdown.c:486 #2 0xffffffff8083c4f7 in vpanic ( fmt=0xffffffff80c33e58 "condition %s not met at %s:%d (%s)", ap=0xfffffe029a36c2c0) at /usr/devel/git/trant/sys/kern/kern_shutdown.c:919 #3 0xffffffff8083c0a3 in panic (fmt=) at /usr/devel/git/trant/sys/kern/kern_shutdown.c:843 #4 0xffffffff8036fd21 in zfs_acl_chown_setattr (zp=0xfffff801ccd203b0) at /usr/devel/git/trant/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_acl.c:1147 #5 0xffffffff8037e52d in zfs_setattr (zp=0xfffff8024b04f760, vap=vap@entry=0xfffffe029a36c870, flags=flags@entry=0, cr=, cr@entry=0xfffff8003ecedc00) at /usr/devel/git/trant/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vnops_os.c:2758 #6 0xffffffff803817ee in zfs_freebsd_setattr (ap=) at /usr/devel/git/trant/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vnops_os.c:4918 #7 0xffffffff80ba6087 in VOP_SETATTR_APV ( vop=0xffffffff80e59280 , a=a@entry=0xfffffe029a36ca00) at vnode_if.c:927 #8 0xffffffff80915a89 in VOP_SETATTR (vp=vp@entry=0xfffff8016524d5b8, vap=vap@entry=0xfffffe029a36ca30, cred=, cred@entry=0xfffff8003ecedc00) at ./vnode_if.h:485 #9 0xffffffff80915d67 in setfown (td=, cred=0xfffff8003ecedc00, vp=0xfffff8016524d5b8, uid=uid@entry=4294967295, gid=gid@entry=20) at /usr/devel/git/trant/sys/kern/vfs_syscalls.c:2942 #10 0xffffffff80915eb6 in kern_fchownat (td=0xfffffe01dd1cd560, fd=fd@entry=-100, path=0x803697858 , pathseg=pathseg@entry=UIO_USERSPACE, uid=-1, gid=, flag=0) at /usr/devel/git/trant/sys/kern/vfs_syscalls.c:3002 #11 0xffffffff80915db6 in sys_chown (td=, uap=) at /usr/devel/git/trant/sys/kern/vfs_syscalls.c:2962 #12 0xffffffff80b25b69 in syscallenter (td=0xfffffe01dd1cd560) at /usr/devel/git/trant/sys/amd64/amd64/../../kern/subr_syscall.c:189 #13 0xffffffff80b25845 in amd64_syscall (td=0xfffffe01dd1cd560, traced=0) at /usr/devel/git/trant/sys/amd64/amd64/trap.c:1156 -- Andriy Gapon From owner-freebsd-fs@freebsd.org Mon Feb 15 08:54:34 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 085AA54E78D for ; Mon, 15 Feb 2021 08:54:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4DfHwT6X5zz3nKb for ; Mon, 15 Feb 2021 08:54:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id DE21254E145; Mon, 15 Feb 2021 08:54:33 +0000 (UTC) Delivered-To: fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DDE3254E639 for ; Mon, 15 Feb 2021 08:54:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DfHwT5s03z3n15 for ; Mon, 15 Feb 2021 08:54:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id B802A1AAC7 for ; Mon, 15 Feb 2021 08:54:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11F8sXDS020795 for ; Mon, 15 Feb 2021 08:54:33 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11F8sXew020794 for fs@FreeBSD.org; Mon, 15 Feb 2021 08:54:33 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 253158] Panic: snapacct_ufs2: bad block - Non-suJ mksnap_ffs(8) crash Date: Mon, 15 Feb 2021 08:54:33 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: panic X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: cy@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2021 08:54:34 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253158 --- Comment #43 from Cy Schubert --- (In reply to Konstantin Belousov from comment #39) Both patches, each by themselves, don't panic. The sys/ufs/ffs/ffs_snapshot= .c patch resolves the problem without causing any other problems. However the sys/kern/vfs_vnops.c patch by itself causes other problems which results in the following errors during boot: mountroot: waiting for device /dev/ada0s1a... input in flex scanner failed read: read error: Unknown error: 66047 warning: total configured swap (524276 pages) exceeds maximum recommended amount (457736 pages). [...] Starting dhclient. input in flex scanner failed /etc/rc.d/dhclient: WARNING: failed to start dhclient vtnet2: link state changed to UP pid 417 (sleep), jid 0, uid 0: exited on signal 3 Quit The system hung during boot because the network interface never obtained an= IP address through dhclient. beastie# newfs /dev/ada3 /dev/ada3: 16384.0MB (33554432 sectors) block size 32768, fragment size 4096 using 27 cylinder groups of 625.22MB, 20007 blks, 80128 inodes. super-block backups (for fsck_ffs -b #) at: 192, 1280640, 2561088, 3841536, 5121984, 6402432, 7682880, 8963328, 102437= 76, 11524224, 12804672, 14085120, 15365568, 16646016, 17926464, 19206912, 20487360, 21767808, 23048256, 24328704, 25609152, 26889600, 28170048, 29450496, 30730944, 32011392, 33291840 beastie# mount /dev/ada3 /mnt beastie# mksnap_ffs /mnt/.snap/test beastie# fstyp /mnt/.snap/test: filesystem not recognized. beastie# It's getting late here. I cannot continue testing sys/kern/vfs_vnops.c by itself tonight. I can continue tomorrow. Repeat: sys/ufs/ffs/ffs_snapshot.c does fix the problem without any negative effects. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Mon Feb 15 09:03:26 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C470954EAC9 for ; Mon, 15 Feb 2021 09:03:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4DfJ6k51WJz3ntB for ; Mon, 15 Feb 2021 09:03:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id AC3F654EBC3; Mon, 15 Feb 2021 09:03:26 +0000 (UTC) Delivered-To: fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AC09E54EE94 for ; Mon, 15 Feb 2021 09:03:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DfJ6k4MLBz3nfB for ; Mon, 15 Feb 2021 09:03:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 872151AA6A for ; Mon, 15 Feb 2021 09:03:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11F93QFf025539 for ; Mon, 15 Feb 2021 09:03:26 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11F93QRj025538 for fs@FreeBSD.org; Mon, 15 Feb 2021 09:03:26 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 253158] Panic: snapacct_ufs2: bad block - Non-suJ mksnap_ffs(8) crash Date: Mon, 15 Feb 2021 09:03:26 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: panic X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: cy@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2021 09:03:26 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253158 --- Comment #44 from Cy Schubert --- (In reply to Harald Schmalzbauer from comment #42) The sys/kern/vfs_vnops.c patch by itself introduces other problems. Togethe= r, both patches or the sys/ufs/ffs/ffs_snapshot.c patch by itself resolve the panic without any regressions. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Mon Feb 15 09:45:24 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2A27754F91C; Mon, 15 Feb 2021 09:45:24 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4DfK374htYz3rWL; Mon, 15 Feb 2021 09:45:23 +0000 (UTC) (envelope-from avg@FreeBSD.org) X-Originating-IP: 195.64.148.76 Received: from [192.168.0.88] (unknown [195.64.148.76]) (Authenticated sender: andriy.gapon@uabsd.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 8A94724000A; Mon, 15 Feb 2021 09:45:20 +0000 (UTC) Subject: Re: panic: condition seqc_in_modify(_vp->v_seqc) not met at zfs_acl.c:1147 (zfs_acl_chown_setattr) From: Andriy Gapon To: FreeBSD Current , freebsd-fs@FreeBSD.org References: <1b261679-3492-dda8-614e-21150a2375d8@FreeBSD.org> Message-ID: <038304d0-2cd0-f089-56ee-c094cdc4cc21@FreeBSD.org> Date: Mon, 15 Feb 2021 11:45:19 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <1b261679-3492-dda8-614e-21150a2375d8@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4DfK374htYz3rWL X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [0.00 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; ASN(0.00)[asn:29169, ipnet:217.70.176.0/20, country:FR] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2021 09:45:24 -0000 On 15/02/2021 10:22, Andriy Gapon wrote: > > I've got this panic once when copying a couple of files. > The system is stable/13 as of 1996360d7338d, a custom kernel configuration, but > no local source code modifications. > > Unread portion of the kernel message buffer: > VNASSERT failed: ({ seqc_t __seqc = (_vp->v_seqc); __builtin_expect((__seqc & > 1), 0); }) not true at > /usr/devel/git/trant/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_acl.c:1147 > (zfs_acl_chown_setattr) > 0xfffff8013e4e85b8: type VDIR > usecount 1, writecount 0, refcount 1 seqc users 0 mountedhere 0 > hold count flags () > flags () > lock type zfs: EXCL by thread 0xfffffe01dd1cd560 (pid 30747, kdeinit5, tid > 159911) > panic: condition seqc_in_modify(_vp->v_seqc) not met at > /usr/devel/git/trant/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_acl.c:1147 > (zfs_acl_chown_setattr) > > Any ideas, suggestions, hints? > Thanks! > ... > #4 0xffffffff8036fd21 in zfs_acl_chown_setattr (zp=0xfffff801ccd203b0) > at /usr/devel/git/trant/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_acl.c:1147 > #5 0xffffffff8037e52d in zfs_setattr (zp=0xfffff8024b04f760, > vap=vap@entry=0xfffffe029a36c870, flags=flags@entry=0, > cr=, cr@entry=0xfffff8003ecedc00) > at > /usr/devel/git/trant/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vnops_os.c:2758 So, this is actually the second zfs_acl_chown_setattr call here: err = zfs_acl_chown_setattr(zp); ASSERT(err == 0); if (attrzp) { err = zfs_acl_chown_setattr(attrzp); ASSERT(err == 0); } I am not sure if the assertion is actually applicable to attrzp (extended attributes "directory"). At least I do not see any seq calls for it. -- Andriy Gapon From owner-freebsd-fs@freebsd.org Mon Feb 15 09:47:44 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4E06C54FAE4 for ; Mon, 15 Feb 2021 09:47:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4DfK5r1Z82z3rjx for ; Mon, 15 Feb 2021 09:47:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 35CBC54F97D; Mon, 15 Feb 2021 09:47:44 +0000 (UTC) Delivered-To: fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3594454FAE3 for ; Mon, 15 Feb 2021 09:47:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DfK5r0zWGz3rSV for ; Mon, 15 Feb 2021 09:47:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 14C821B63F for ; Mon, 15 Feb 2021 09:47:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11F9litu048925 for ; Mon, 15 Feb 2021 09:47:44 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11F9liwi048924 for fs@FreeBSD.org; Mon, 15 Feb 2021 09:47:44 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 253158] Panic: snapacct_ufs2: bad block - Non-suJ mksnap_ffs(8) crash Date: Mon, 15 Feb 2021 09:47:44 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: panic X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: kib@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2021 09:47:44 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253158 --- Comment #45 from Konstantin Belousov --- (In reply to Cy Schubert from comment #44) Yes, the vfs_vnops.c patch might leave error uninitialized. Fixed commit below. commit 04822fadd7b1d7d20373cf3fa8e7fdd5a26e7da9 Author: Konstantin Belousov Date: Mon Feb 15 05:34:06 2021 +0200 pgcache read: protect against reads past end of the vm object size If uio_offset is past end of the object size, calculated resid is negat= ive. Delegate handling this case to the locked read, as any other non-trivial situation. PR: 253158 diff --git a/sys/kern/vfs_vnops.c b/sys/kern/vfs_vnops.c index 46b333b2261f..3e6abb01bfd7 100644 --- a/sys/kern/vfs_vnops.c +++ b/sys/kern/vfs_vnops.c @@ -967,6 +967,10 @@ vn_read_from_obj(struct vnode *vp, struct uio *uio) #else vsz =3D atomic_load_64(&obj->un_pager.vnp.vnp_size); #endif + if (uio->uio_offset >=3D vsz) { + error =3D EJUSTRETURN; + goto out; + } if (uio->uio_offset + resid > vsz) resid =3D vsz - uio->uio_offset; --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Mon Feb 15 11:40:32 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 59CEE52A6C9 for ; Mon, 15 Feb 2021 11:40:32 +0000 (UTC) (envelope-from se@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DfMc01tgVz4T2f; Mon, 15 Feb 2021 11:40:32 +0000 (UTC) (envelope-from se@freebsd.org) Received: from Stefans-MacBook-Pro-449.fritz.box (p200300cd5f3baf00255f7833c3ce7a1a.dip0.t-ipconnect.de [IPv6:2003:cd:5f3b:af00:255f:7833:c3ce:7a1a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: se/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id C1FE23A8B; Mon, 15 Feb 2021 11:40:31 +0000 (UTC) (envelope-from se@freebsd.org) To: Karl Denninger , freebsd-fs@freebsd.org References: <0ca45adf-8f60-a4c3-6264-6122444a3ffd@denninger.net> <899c6b4f-2368-7ec2-4dfe-fa09fab35447@artem.ru> <20210212165216.2f613482@fabiankeil.de> <10977ffc-f806-69dd-0cef-d4fd4fc5f649@artem.ru> <2f82f113-9ca1-99a9-a433-89e3ae5edcbe@denninger.net> <2bf4f69c-9d5d-5ff9-0daa-c87515437ca3@artem.ru> <5aa03138-1dc8-5a9c-1be6-d47ed22fc0cf@denninger.net> <225e4da5-79ec-a57a-90e5-35989e6484d5@freebsd.org> <3aeb9d42-f69d-1f4c-b1f5-74dd4d28578c@denninger.net> From: Stefan Esser Subject: Re: Reading a corrupted file on ZFS Message-ID: <06e62e4c-6f9e-4cfd-d662-78b8b4dfbf21@freebsd.org> Date: Mon, 15 Feb 2021 12:40:30 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <3aeb9d42-f69d-1f4c-b1f5-74dd4d28578c@denninger.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PV58Vz1S3UI6WqlQ1X6PWLlpVGZ34ifyu" X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2021 11:40:32 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --PV58Vz1S3UI6WqlQ1X6PWLlpVGZ34ifyu Content-Type: multipart/mixed; boundary="9meMAz6IgCAX2ddGb5FMox3xlca6hQnsS"; protected-headers="v1" From: Stefan Esser To: Karl Denninger , freebsd-fs@freebsd.org Message-ID: <06e62e4c-6f9e-4cfd-d662-78b8b4dfbf21@freebsd.org> Subject: Re: Reading a corrupted file on ZFS References: <0ca45adf-8f60-a4c3-6264-6122444a3ffd@denninger.net> <899c6b4f-2368-7ec2-4dfe-fa09fab35447@artem.ru> <20210212165216.2f613482@fabiankeil.de> <10977ffc-f806-69dd-0cef-d4fd4fc5f649@artem.ru> <2f82f113-9ca1-99a9-a433-89e3ae5edcbe@denninger.net> <2bf4f69c-9d5d-5ff9-0daa-c87515437ca3@artem.ru> <5aa03138-1dc8-5a9c-1be6-d47ed22fc0cf@denninger.net> <225e4da5-79ec-a57a-90e5-35989e6484d5@freebsd.org> <3aeb9d42-f69d-1f4c-b1f5-74dd4d28578c@denninger.net> In-Reply-To: <3aeb9d42-f69d-1f4c-b1f5-74dd4d28578c@denninger.net> --9meMAz6IgCAX2ddGb5FMox3xlca6hQnsS Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Am 13.02.21 um 17:54 schrieb Karl Denninger: > On 2/13/2021 11:51, Stefan Esser wrote: >> Therefore: There are valid reasons to not have redundancy and >> still not loose a large file of data for single bad block of a >> non-redundant (e.g striped for performance) ZPOOL/ZFS. >> >> Regards, STefan >> > That's what the patch does -- it allows you to read the file but the=20 > known-bad blocks will be "blanked" (marked that it's no good.) Yes, I'm well aware of that fact. I just think we should allow those in this particular error case an easy way out - and in fact I just noticed that we already do! > Perhaps that sysctl should be part of the system generally, but you CAN= =20 > do it the hard way with zdb even without it although it's a SERIOUS pai= n=20 > in the neck. While possible with ZDB, nobody will want to do this, if a simple alternative exists: $ sysctl vfs.zfs.send vfs.zfs.send.override_estimate_recordsize: 0 vfs.zfs.send.no_prefetch_queue_ff: 20 vfs.zfs.send.queue_ff: 20 vfs.zfs.send.no_prefetch_queue_length: 1048576 vfs.zfs.send.unmodified_spill_blocks: 1 vfs.zfs.send.queue_length: 16777216 vfs.zfs.send.corrupt_data: 0 These are due to the following lines at the end of /sys/contrib/openzfs/module/zfs/dmu_send.c: /* BEGIN CSTYLED */ ZFS_MODULE_PARAM(zfs_send, zfs_send_, corrupt_data, INT, ZMOD_RW, "Allow sending corrupt data"); ZFS_MODULE_PARAM(zfs_send, zfs_send_, queue_length, INT, ZMOD_RW, "Maximum send queue length"); [...] Just set vfs.zfs.send.corrupt_data to 1 to have unreadable blocks returned filled with 0x2f5baddb10c (not 0 as suggested in this thread). This has been a standard feature of ZFSonLinux for more than 6 years, apparently, and we have got it with the mapping of module parameters to sysctl variables ... Regards, STefan --9meMAz6IgCAX2ddGb5FMox3xlca6hQnsS-- --PV58Vz1S3UI6WqlQ1X6PWLlpVGZ34ifyu Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEo3HqZZwL7MgrcVMTR+u171r99UQFAmAqXa4FAwAAAAAACgkQR+u171r99USW Nwf/TfPmw2Wz4+TOu4NYSiqNZ2ACkVCbd6jWFQb2vENDdmFSQbc9aWf7Jvs7NrmX5S917mikWYhZ KmygRSKp6y2I7qOeXGRVOWNRS4hm779a20S16Jk6Wo7YjamS1mpdqlcmNmjUlkj+R4fMY2kjYqHX I0AqkNsX/HZNw7W2LzmXRrZ0K7BchTrOkhpRsCiQ3ov+gFay2jirBL7b7UuY2p1i6ABo/Wa+3JRQ nCZ5vdMcWKqii3nCZMR1FWuj3r19WPyMdGRPgmM/Svozul04gMVd4hc6itg2TCZYVf11fDb1w/Ek na+p/LPrgtFsC2Tr2lfJf/8BKb8J9MqqyEHJKIgd7w== =mCgd -----END PGP SIGNATURE----- --PV58Vz1S3UI6WqlQ1X6PWLlpVGZ34ifyu-- From owner-freebsd-fs@freebsd.org Mon Feb 15 17:36:27 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 793AC533566 for ; Mon, 15 Feb 2021 17:36:27 +0000 (UTC) (envelope-from artem@artem.ru) Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [94.100.177.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4DfWVf16DQz4qWN for ; Mon, 15 Feb 2021 17:36:25 +0000 (UTC) (envelope-from artem@artem.ru) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mail.ru; s=mail3; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Date:Message-ID:Subject:From:To:From:Subject:Content-Type:Content-Transfer-Encoding:To:Cc; bh=P83QYRYAahU9o4Pr0cE5Oy9S2BwSS3RAV3b/UFQDBnA=; b=QH6/vsphS+f0OoUNwgfStQ1jY3VX/V/x8SQvWcRnbxBZDnq+tabLXp4XPE2la0jEXu7yj2MuoFibR1IPZede2wW9y0lcoghIgjSU1zoRABTjbFftb6ynvjF4H5QOSD5/7wjcKlgNjli3A8jndJdvj90iRktwX7QPPO5Uiy87KPQ=; Received: by smtp34.i.mail.ru with esmtpa (envelope-from ) id 1lBhnK-0000wP-3C for freebsd-fs@freebsd.org; Mon, 15 Feb 2021 20:36:22 +0300 To: freebsd-fs@freebsd.org From: Artem Kuchin Subject: Simulating bad sectors on file based storage device. How? Message-ID: <1c372ed8-f5fb-0637-9cce-e892cb38ed28@artem.ru> Date: Mon, 15 Feb 2021 20:36:26 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: ru X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD91883A1EE8D2E99320BEAE35521DD1BA8AF4307321059D6B3182A05F53808504098450C9E801D78CA49CE03D0F0C20979BC686FA10C6F7D457E060CA57E5FB8A2 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7D114FA852BF02E08EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006372B866E63D69A26578638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FC8726D74DEFB7B5A8028A5EF30CB2405BBB391AFA0C313C0A389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C045A75973B56231AD8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6E954A0C70C50C109CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C2249B9421E6AB0F59BC976E601842F6C81A12EF20D2F80756B5F7E9C4E3C761E06A776E601842F6C81A127C277FBC8AE2E8B5F89305699A7FCB33AA81AA40904B5D9DBF02ECDB25306B2B25CBF701D1BE8734AD6D5ED66289B5278DA827A17800CE754A400A07F115C5967F23339F89546C5A8DF7F3B2552694A6FED454B719173D6725E5C173C3A84C369456C5265B6C55C35872C767BF85DA2F004C906525384306FED454B719173D6462275124DF8B9C9D28595B116005B47574AF45C6390F7469DAA53EE0834AAEE X-C1DE0DAB: C20DE7B7AB408E4181F030C43753B8186998911F362727C414F749A5E30D975C1C18E6A7EDD591E61652B662FA314152FE03ADF03D22097E9C2B6934AE262D3EE7EAB7254005DCED722383FBE7D0D3A71E0A4E2319210D9B64D260DF9561598F01A9E91200F654B06CE7B4E551862B828E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D349EC559D073CA5B68C1B955C0DEDAF02FDFB412A17349609A4E7D10880B12AC856649CBB2BAC53FCF1D7E09C32AA3244C31CB558EAB41630C1E6F495396431D1E95A9E0DC41E9A4CF3EB3F6AD6EA9203E X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojiBTwj6noE5e1NUCf3R2mSA== X-Mailru-Sender: 332320C0CE44B5007D883C09EB686233414F47965E1C023F72A9B5B09F89FB5A058B4CC93B12BFF90A1FD29A504278DEE66B5C1DBFD5D09D2FFF0A5F0DFA254CD0701747CC0EF98689F635B1FCB23A66AE208404248635DF X-Mras: Ok X-Rspamd-Queue-Id: 4DfWVf16DQz4qWN X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=mail.ru header.s=mail3 header.b=QH6/vsph; dmarc=none; spf=none (mx1.freebsd.org: domain of artem@artem.ru has no SPF policy when checking 94.100.177.94) smtp.mailfrom=artem@artem.ru X-Spamd-Result: default: False [-1.46 / 15.00]; ARC_NA(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[94.100.177.94:from]; R_DKIM_ALLOW(-0.20)[mail.ru:s=mail3]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; DMARC_NA(0.00)[artem.ru]; RCPT_COUNT_ONE(0.00)[1]; SPAMHAUS_ZRD(0.00)[94.100.177.94:from:127.0.2.255]; DKIM_TRACE(0.00)[mail.ru:+]; NEURAL_HAM_SHORT(-0.16)[-0.156]; RCVD_IN_DNSWL_NONE(0.00)[94.100.177.94:from]; R_SPF_NA(0.00)[no SPF record]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; SUBJECT_ENDS_QUESTION(1.00)[]; ASN(0.00)[asn:47764, ipnet:94.100.176.0/20, country:RU]; MID_RHS_MATCH_FROM(0.00)[]; MAILMAN_DEST(0.00)[freebsd-fs] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2021 17:36:27 -0000 Hello! Is there a way to build a file base storage device (for example, file based zfs mirror) and then simulate a bad sector for one of the mirror sides? Artem From owner-freebsd-fs@freebsd.org Mon Feb 15 17:37:44 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 66848533A38 for ; Mon, 15 Feb 2021 17:37:44 +0000 (UTC) (envelope-from lopez.on.the.lists@yellowspace.net) Received: from mail.yellowspace.net (mail.yellowspace.net [62.146.62.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with UTF8SMTPS id 4DfWX742bTz4qHs for ; Mon, 15 Feb 2021 17:37:43 +0000 (UTC) (envelope-from lopez.on.the.lists@yellowspace.net) To: freebsd-fs@freebsd.org From: Lorenzo Perone Subject: Migrating from base to OpenZFS: GELI drives, send/receive, and sysctls/loader.conf Message-ID: <183ed751-5a2e-5468-c82c-670820bac138@yellowspace.net> Date: Mon, 15 Feb 2021 18:37:34 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4DfWX742bTz4qHs X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of lopez.on.the.lists@yellowspace.net designates 62.146.62.106 as permitted sender) smtp.mailfrom=lopez.on.the.lists@yellowspace.net X-Spamd-Result: default: False [-1.61 / 15.00]; ARC_NA(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[62.146.62.106:from]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+a:mail.yellowspace.net]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; DMARC_NA(0.00)[yellowspace.net]; RCPT_COUNT_ONE(0.00)[1]; SPAMHAUS_ZRD(0.00)[62.146.62.106:from:127.0.2.255]; NEURAL_SPAM_SHORT(0.69)[0.690]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15598, ipnet:62.146.0.0/16, country:DE]; MID_RHS_MATCH_FROM(0.00)[]; MAILMAN_DEST(0.00)[freebsd-fs] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2021 17:37:44 -0000 Hi All, I have followed regularly the development of openzfs for FreeBSD and I guess I'm ready and eager to give it a first try on a 12.2 updated system by using the port. Particularly watching the (now a little outdated, but still good) talk by Alan Jude @ EuroBSDCon 2019 was very encouraging. What I'm planning as a first run is: On the same machine: - Boot with openzfs_load instead of zfs_load - Import the "base" created pool with openzfs - Create a new pool with openzfs - Send/Receive and/or rsync data from the old to the new one A few questions arised for which I didn't find an answer yet in the official documentation. 1) Will a pool on GELI drives import well with openzfs too? I'd assume yes, why shouldn't it. Just asking to correct me if there are any precautions I should be taking or surprises to expect. 2) Will the "old" settings be honored by openzfs, such as vfs.zfs.arc_min, vfs.zfs.arc_max in /boot/loader.conf? 3) Is there an openzfs_enable as opposed to zfs_enable in rc.conf (to import/mount pools at boot)? Or is zfs_enable just compatible? 4) As far as I know, it should be possible to send/receive data from an unencrypted dataset to an encrypted one. Is this advisable from an "old base" zfs dataset (not encrypted, on geli) to a new openzfs one (encrypted at the dataset level), or should we resort to rsync? 5) What's the actual current status on extended attributes? Will they be retained in a send/receive from FreeBSD-"old" to FreeBSD-OpenZFS? I have a few shares on that machine where macs have "dropped" their EAs via AFP/SMB, what should I expect? Thanks a lot for any attention by people who know this right away, Best Regards, Lorenzo From owner-freebsd-fs@freebsd.org Mon Feb 15 17:44:24 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B22AB533972 for ; Mon, 15 Feb 2021 17:44:24 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-ot1-f52.google.com (mail-ot1-f52.google.com [209.85.210.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DfWgq6s3Mz4qry for ; Mon, 15 Feb 2021 17:44:23 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-ot1-f52.google.com with SMTP id b16so4331996otq.1 for ; Mon, 15 Feb 2021 09:44:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/DkvCPdrKPgtuIdQ7D3LeJXbXmKTwnE2+J1jdGtqxHY=; b=SjNoDGoYGxT9qsK6WR9a9MnApNBEM6CbKP6b7OtblHvWLiCN2rBQZYKYROnaTXehIC bq0x54AHVogkRTV6vmA1/S/uMW4HobAYrj8h0DKF6souFGizYOduPk1iQDYrKYh1Pw5t FxaAsu5Yi0wm7UjIobcD9DliAl9lmzCM2+8EibaqU3mhxZxtB1cX6CAxDo3RfKg1d0nt FhbFpjtscD7lzoZyOVyBFVQanCTr+zW/7es07PNepJOp/a+CRSPr+D9j/zwMmIYSgMAL GFzTFQhlhn3w8UWqFFsge4NyGtMS6IYg38YEqq3NZxiLlfsB31bHmlgaTVs00P4h+FIK VYiQ== X-Gm-Message-State: AOAM531VXHEJt4GpvI56ipAbZEixzyShV+HMwnAUhCjUKECSDwbkJUKz f9JW4M5CZSFadvGapYvhxd+MDIZmIWAAknBBjrafS87yOqM= X-Google-Smtp-Source: ABdhPJxBbdWTLZzmygqk5TjgCmvvXIFfDPAvXDixIcpdL8MIQOgJ84FZ2RK9J90T8iFiO3PljcpZKIvMLXY5F56Rrk0= X-Received: by 2002:a05:6830:18e6:: with SMTP id d6mr12671962otf.251.1613411063001; Mon, 15 Feb 2021 09:44:23 -0800 (PST) MIME-Version: 1.0 References: <1c372ed8-f5fb-0637-9cce-e892cb38ed28@artem.ru> In-Reply-To: <1c372ed8-f5fb-0637-9cce-e892cb38ed28@artem.ru> From: Alan Somers Date: Mon, 15 Feb 2021 10:44:12 -0700 Message-ID: Subject: Re: Simulating bad sectors on file based storage device. How? To: Artem Kuchin Cc: freebsd-fs X-Rspamd-Queue-Id: 4DfWgq6s3Mz4qry X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of asomers@gmail.com designates 209.85.210.52 as permitted sender) smtp.mailfrom=asomers@gmail.com X-Spamd-Result: default: False [-0.01 / 15.00]; RWL_MAILSPIKE_GOOD(0.00)[209.85.210.52:from]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; TO_DN_ALL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; FORGED_SENDER(0.30)[asomers@freebsd.org,asomers@gmail.com]; SUBJECT_ENDS_QUESTION(1.00)[]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FROM_NEQ_ENVFROM(0.00)[asomers@freebsd.org,asomers@gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; ARC_NA(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[209.85.210.52:from]; FREEFALL_USER(0.00)[asomers]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-fs@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; NEURAL_SPAM_SHORT(0.99)[0.988]; SPAMHAUS_ZRD(0.00)[209.85.210.52:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.210.52:from]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[freebsd-fs] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2021 17:44:24 -0000 If you have SCSI disks, you can inject errors with `sysctl kern.cam.da.0.error_inject`. If not, you can use gnop(8) to simulate a flaky disk. On Mon, Feb 15, 2021 at 10:36 AM Artem Kuchin wrote: > Hello! > > Is there a way to build a file base storage device (for example, file > based zfs mirror) and then simulate a bad sector for one of the mirror > sides? > > Artem > > > _______________________________________________ > freebsd-fs@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-fs > To unsubscribe, send any mail to "freebsd-fs-unsubscribe@freebsd.org" > From owner-freebsd-fs@freebsd.org Mon Feb 15 20:09:11 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 384C853861B for ; Mon, 15 Feb 2021 20:09:11 +0000 (UTC) (envelope-from fjwcash@gmail.com) Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DfZtt0LYhz3JWF for ; Mon, 15 Feb 2021 20:09:09 +0000 (UTC) (envelope-from fjwcash@gmail.com) Received: by mail-qt1-x82d.google.com with SMTP id h16so5605385qth.11 for ; Mon, 15 Feb 2021 12:09:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LsMmOMVoxhkPBnYTzGtMBv2aQU7v9U5ZMk5DNdAlo3w=; b=j9dsPF2qK6RAf5/iNpEyhPl4yjQnPioY8BGOtSqEO74PpPmiI8TeMOnMcU3HchFsrx pz1DZ6PWB6bmd9HIXDCsfCRj1Na0itEejQofluXXl1vw70bBQqPdVRbXFqvgIvlRBjBi bOfdd/blGWN+uTkPMSvJjzOfwt2kmtPVQpa+/BLunED6EImDqCIet/7cetOt8r4tcD4l OI3gSFI6AgMlvvTegT63tZmkzlQcSNlUvhCg8fGsz5DgH3mo8lOza9G2/0vrAJ6Qk89k L51ZKMPOrPVbxCc56hO3Ojz0MpZWubv0TZlk9chWMOgIBDONyUfA+9715G+54s6FVhA0 TMgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LsMmOMVoxhkPBnYTzGtMBv2aQU7v9U5ZMk5DNdAlo3w=; b=JZjfAbeZqfPGXwgbM0fk3x5IWOMSy6lyZW8bc8SR3VxrGlyTsBEyz9eHNRqJWBUHRK vftihUTz+5Sok9YljOHAGHal3EV+INBIcUdfp/5veJN5B436VbRX+msNMTNHuTfnfJdI ot1P2T8Lz+/G+4Voqry/4fI1p2BZcUgnZdoIuzhpnysjk9F2hRE25joGHj+/31ILPnFY sUYJiYr266okwukzu/69UE9GOBIzBpJNhEdhnBSxtQrokqNQ+hPNg69EmqnRRCB0eHUf G+J4IRxMYRcLUg8ANQzvCdt6UHIU7l25swaoqZ8aLtjG4L3s/L0p9ShcaN5tTLURHixM I/Nw== X-Gm-Message-State: AOAM530A+Ki4SJxwxmvXJC/f4/xs+NhV/vRmxOGBhLiayBpAUSO1mjon curqOtTRPJaLw/KopDMeb7zENkrG6l/Eh4wenJrDHS2f X-Google-Smtp-Source: ABdhPJwbLU9hbIbwazcNvtyhnmNv9wjF5FKBZf3M/1UBvoHYXAEcjBjArjrTeVBZ0G/rspTJTM9RSofYNReG7IXZTlU= X-Received: by 2002:ac8:5a8a:: with SMTP id c10mr16238096qtc.30.1613419748668; Mon, 15 Feb 2021 12:09:08 -0800 (PST) MIME-Version: 1.0 References: <183ed751-5a2e-5468-c82c-670820bac138@yellowspace.net> In-Reply-To: <183ed751-5a2e-5468-c82c-670820bac138@yellowspace.net> From: Freddie Cash Date: Mon, 15 Feb 2021 12:08:57 -0800 Message-ID: Subject: Re: Migrating from base to OpenZFS: GELI drives, send/receive, and sysctls/loader.conf To: Lorenzo Perone Cc: FreeBSD Filesystems X-Rspamd-Queue-Id: 4DfZtt0LYhz3JWF X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=j9dsPF2q; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of fjwcash@gmail.com designates 2607:f8b0:4864:20::82d as permitted sender) smtp.mailfrom=fjwcash@gmail.com X-Spamd-Result: default: False [-4.00 / 15.00]; FREEMAIL_FROM(0.00)[gmail.com]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RBL_DBL_DONT_QUERY_IPS(0.00)[2607:f8b0:4864:20::82d:from]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-fs@freebsd.org]; SPAMHAUS_ZRD(0.00)[2607:f8b0:4864:20::82d:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::82d:from]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[freebsd-fs] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2021 20:09:11 -0000 On Mon., Feb. 15, 2021, 9:37 a.m. Lorenzo Perone, < lopez.on.the.lists@yellowspace.net> wrote: > Hi All, > > I have followed regularly the development of openzfs for FreeBSD and I > guess I'm ready and eager to give it a first try on a 12.2 updated > system by using the port. > > Particularly watching the (now a little outdated, but still good) talk > by Alan Jude @ EuroBSDCon 2019 was very encouraging. > > What I'm planning as a first run is: > > On the same machine: > > - Boot with openzfs_load instead of zfs_load > - Import the "base" created pool with openzfs > - Create a new pool with openzfs > - Send/Receive and/or rsync data from the old to the new one > A few questions arised for which I didn't find an answer yet in the > official documentation. > > 1) Will a pool on GELI drives import well with openzfs too? I'd assume > yes, why shouldn't it. Just asking to correct me if there are any > precautions I should be taking or surprises to expect. > > 2) Will the "old" settings be honored by openzfs, such as > vfs.zfs.arc_min, vfs.zfs.arc_max in /boot/loader.conf? > > 3) Is there an openzfs_enable as opposed to zfs_enable in rc.conf (to > import/mount pools at boot)? Or is zfs_enable just compatible? > > 4) As far as I know, it should be possible to send/receive data from an > unencrypted dataset to an encrypted one. Is this advisable from an "old > base" zfs dataset (not encrypted, on geli) to a new openzfs one > (encrypted at the dataset level), or should we resort to rsync? > > 5) What's the actual current status on extended attributes? Will they be > retained in a send/receive from FreeBSD-"old" to FreeBSD-OpenZFS? I have > a few shares on that machine where macs have "dropped" their EAs via > AFP/SMB, what should I expect? > > Thanks a lot for any attention by people who know this right away, > If this is a boot pool, create a new boot environment and reboot into it before making any changes. In the new BE, install the port, update loader.conf and test things out. So long as you don't do a "zpool upgrade" or enable any new features, then you can always change BE at the loader menu to revert back to the working config. Doing it that way saved me a lot of headaches when trying to use the openzfs packages (which don't work on 12.2). Had to eventually install via the ports tree. A bunch of sysctls are the same, a bunch are named slightly differently, and there's a whole bunch of new ones. Best bet is to comment then all out and see if the autotune setup works for you. If not, then tweak the new sysctls as you go. It's just zfs_enable in rc.conf for both base and port ZFS. You can "zfs send" between versions without issue. Can't help with the GELI or xattrs questions as I don't use those. Hope that helps, Cheers, Freddie Typos due to smartphone keyboard. > From owner-freebsd-fs@freebsd.org Mon Feb 15 22:02:19 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A07DE53C1EE for ; Mon, 15 Feb 2021 22:02:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4DfdPR3zTYz3kGd for ; Mon, 15 Feb 2021 22:02:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 8893E53C1EC; Mon, 15 Feb 2021 22:02:19 +0000 (UTC) Delivered-To: fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8860E53C5D3 for ; Mon, 15 Feb 2021 22:02:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DfdPR3NnQz3kDR for ; Mon, 15 Feb 2021 22:02:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 6767A25602 for ; Mon, 15 Feb 2021 22:02:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11FM2JcQ062718 for ; Mon, 15 Feb 2021 22:02:19 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11FM2J3s062717 for fs@FreeBSD.org; Mon, 15 Feb 2021 22:02:19 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 253158] Panic: snapacct_ufs2: bad block - Non-suJ mksnap_ffs(8) crash Date: Mon, 15 Feb 2021 22:02:18 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: panic X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: mckusick@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2021 22:02:19 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253158 --- Comment #46 from Kirk McKusick --- (In reply to Konstantin Belousov from comment #41) You should defintely push the fix for ffs_snapshot.c as it fixes the snapsh= ot breakage. As mentioned earlier, I would like to see the snapshot fixes push= ed into 13.0 if that is possible. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Mon Feb 15 22:06:14 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DCABF53C3BB for ; Mon, 15 Feb 2021 22:06:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4DfdTy5g9Pz3kRC for ; Mon, 15 Feb 2021 22:06:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id C0ABF53C4DD; Mon, 15 Feb 2021 22:06:14 +0000 (UTC) Delivered-To: fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C073F53C79A for ; Mon, 15 Feb 2021 22:06:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DfdTy50NBz3kJ3 for ; Mon, 15 Feb 2021 22:06:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 9E66625146 for ; Mon, 15 Feb 2021 22:06:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11FM6Esq063556 for ; Mon, 15 Feb 2021 22:06:14 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11FM6E88063555 for fs@FreeBSD.org; Mon, 15 Feb 2021 22:06:14 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 253158] Panic: snapacct_ufs2: bad block - Non-suJ mksnap_ffs(8) crash Date: Mon, 15 Feb 2021 22:06:14 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: panic X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: mckusick@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2021 22:06:14 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253158 --- Comment #47 from Kirk McKusick --- (In reply to Harald Schmalzbauer from comment #42) Thanks for your ongoing help in resolving this problem. For now, I suggest that you include the patch to ffs_snapshot.c as it solves that problem. For now I would not include the change to vfs_vnops.c as it is not needed to fix the snapshot problem and does cause other regressions. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Mon Feb 15 22:44:42 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CCB6D53D6A1 for ; Mon, 15 Feb 2021 22:44:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4DffLL27lsz3nHv for ; Mon, 15 Feb 2021 22:44:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 476C253D6A0; Mon, 15 Feb 2021 22:44:42 +0000 (UTC) Delivered-To: fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4735353D5A1 for ; Mon, 15 Feb 2021 22:44:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DffLK5WWYz3nL0 for ; Mon, 15 Feb 2021 22:44:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 31A0025ABC for ; Mon, 15 Feb 2021 22:44:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11FMifMf086018 for ; Mon, 15 Feb 2021 22:44:41 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11FMif6b086017 for fs@FreeBSD.org; Mon, 15 Feb 2021 22:44:41 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 253158] Panic: snapacct_ufs2: bad block - Non-suJ mksnap_ffs(8) crash Date: Mon, 15 Feb 2021 22:44:41 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: panic X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: cy@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2021 22:44:42 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253158 --- Comment #48 from Cy Schubert --- (In reply to Kirk McKusick from comment #47) kib's second patch to vfs_vnops.c fixes the regression. Agreed however it c= an wait. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Tue Feb 16 05:16:07 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7DAB65288BE for ; Tue, 16 Feb 2021 05:16:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4Dfq1x64dGz4m2G for ; Tue, 16 Feb 2021 05:16:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id CC4E25288BA; Tue, 16 Feb 2021 05:16:05 +0000 (UTC) Delivered-To: fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CBB06528C3B for ; Tue, 16 Feb 2021 05:16:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dfq1v0C3pz4lph for ; Tue, 16 Feb 2021 05:16:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 8228E2DBD for ; Tue, 16 Feb 2021 05:15:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11G5Fv0J099172 for ; Tue, 16 Feb 2021 05:15:57 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11G5Fvf8099171 for fs@FreeBSD.org; Tue, 16 Feb 2021 05:15:57 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 253158] Panic: snapacct_ufs2: bad block - Non-suJ mksnap_ffs(8) crash Date: Tue, 16 Feb 2021 05:15:57 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: panic X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2021 05:16:07 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253158 --- Comment #49 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Dc61fae1475f1864dc4bba667b642f279a= fd44855 commit c61fae1475f1864dc4bba667b642f279afd44855 Author: Konstantin Belousov AuthorDate: 2021-02-15 03:34:06 +0000 Commit: Konstantin Belousov CommitDate: 2021-02-16 05:09:37 +0000 pgcache read: protect against reads past end of the vm object size If uio_offset is past end of the object size, calculated resid is negat= ive. Delegate handling this case to the locked read, as any other non-trivial situation. PR: 253158 Reported by: Harald Schmalzbauer Tested by: cy Sponsored by: The FreeBSD Foundation MFC after: 1 week sys/kern/vfs_vnops.c | 4 ++++ 1 file changed, 4 insertions(+) --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Tue Feb 16 05:16:07 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7564C5288BD for ; Tue, 16 Feb 2021 05:16:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4Dfq1x6LY2z4m0f for ; Tue, 16 Feb 2021 05:16:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id D5F175288BB; Tue, 16 Feb 2021 05:16:05 +0000 (UTC) Delivered-To: fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D55A052832C for ; Tue, 16 Feb 2021 05:16:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dfq1w6QtGz4lth for ; Tue, 16 Feb 2021 05:16:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 03EE52D3F for ; Tue, 16 Feb 2021 05:15:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11G5Fwj4099218 for ; Tue, 16 Feb 2021 05:15:58 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11G5Fwd5099217 for fs@FreeBSD.org; Tue, 16 Feb 2021 05:15:58 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 253158] Panic: snapacct_ufs2: bad block - Non-suJ mksnap_ffs(8) crash Date: Tue, 16 Feb 2021 05:15:58 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: panic X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2021 05:16:07 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253158 --- Comment #50 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Dc31480a1f66537e59b02e935a547bcfc7= 6715278 commit c31480a1f66537e59b02e935a547bcfc76715278 Author: Konstantin Belousov AuthorDate: 2021-02-15 03:36:02 +0000 Commit: Konstantin Belousov CommitDate: 2021-02-16 05:11:52 +0000 UFS snapshots: properly set the vm object size. Citing Kirk: The previous code [before 8563de2f2799b2cb -- kib] did not call vnode_pager_setsize() but worked because later in ffs_snapshot() it does a UFS_WRITE() to output the snaplist. Previously the UFS_WRITE() allocated the extra block at the end of the file which caused it to do the needed vnode_pager_setsize(). But the new code had already allocated the extra block, so UFS_WRITE() did not extend the size and thus did not do the vnode_pager_setsize(). PR: 253158 Reported by: Harald Schmalzbauer Reviewed by: mckusick Tested by: cy Sponsored by: The FreeBSD Foundation MFC after: 1 week sys/ufs/ffs/ffs_snapshot.c | 4 ++++ 1 file changed, 4 insertions(+) --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Tue Feb 16 13:05:09 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4E1125377CD for ; Tue, 16 Feb 2021 13:05:09 +0000 (UTC) (envelope-from artem@artem.ru) Received: from smtp16.mail.ru (smtp16.mail.ru [94.100.176.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dg1R7650cz3r0L; Tue, 16 Feb 2021 13:05:07 +0000 (UTC) (envelope-from artem@artem.ru) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mail.ru; s=mail3; h=Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:From:Subject:Content-Type:Content-Transfer-Encoding:To:Cc; bh=azbHe7Y16XO1uhy8mqXZ+dZ2r/QmrDYZx5ZEduZQDEg=; b=urhshIemX1gQMO/IGnVcjlS/XobXEAzaw35v+pTH2maYjvrQyfTTLpkc4fyoACAcQFiAO5YEN9NPXu0i27A7ABt6kxngGXqr8WLzo+oEDunes3u+8Ro2u9cAEGIQIi+DTIBYKbYU3jR+zb+GSyPLH4grfUC/uf+ICK+MKqAkKpg=; Received: by smtp16.mail.ru with esmtpa (envelope-from ) id 1lC02J-0000cg-Ts; Tue, 16 Feb 2021 16:05:04 +0300 Subject: Re: Simulating bad sectors on file based storage device. How? To: Alan Somers Cc: freebsd-fs References: <1c372ed8-f5fb-0637-9cce-e892cb38ed28@artem.ru> From: Artem Kuchin Message-ID: <46b52475-385f-5931-f425-fd546dd5b377@artem.ru> Date: Tue, 16 Feb 2021 16:05:03 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Language: ru X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD91883A1EE8D2E9932D506EC6BA87A3EB954D62ED708969C42182A05F5380850409AD0748D01794369A5A0C729B77894E6B89BCCD181B1D66B1FE078770827080A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE757E1881156861268EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006379448E89E2A57838D8638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FC354FF1FD8BDDBAD480A10E699DCD1951E13596B38BEEFE64389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C07E7E81EEA8A9722B8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B636DA1BED736F9328CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C2249A67B2C3FC51BBECF76E601842F6C81A12EF20D2F80756B5F7E9C4E3C761E06A776E601842F6C81A127C277FBC8AE2E8B70B3DB00C1004C513AA81AA40904B5D9DBF02ECDB25306B2B25CBF701D1BE8734AD6D5ED66289B5278DA827A17800CE754A400A07F115C5967F23339F89546C5A8DF7F3B2552694A6FED454B719173D6725E5C173C3A84C369456C5265B6C55C35872C767BF85DA2F004C906525384306FED454B719173D6462275124DF8B9C9D28595B116005B47574AF45C6390F7469DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A5F56B33BD76DE0900F52A9F9A901566E609C6EAD31CCEDA98D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75BE60A39C19F270AE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3435BBF0AC4E3A921CDAB419A0B244DD1ADC891AA455E90FC14F98450A38F1C7FBB154C4B02DB8580E1D7E09C32AA3244C3E51D9E3F825290511D612B568AC9915B018FE5BB746DCD1729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojiBTwj6noE5cItd6E+CGuHg== X-Mailru-Sender: 0E9E14D9EC491FBAFBE22BEA66C48D6A0E98EE005F1B8075A5A0C729B77894E66FABB19E5423EC378A4382C47DA47812C77752E0C033A69E376A1339FE8876DF1FC4F5A70058821069EB1F849E6DBC830DA7A0AF5A3A8387 X-Mras: Ok X-Rspamd-Queue-Id: 4Dg1R7650cz3r0L X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=mail.ru header.s=mail3 header.b=urhshIem; dmarc=none; spf=none (mx1.freebsd.org: domain of artem@artem.ru has no SPF policy when checking 94.100.176.153) smtp.mailfrom=artem@artem.ru X-Spamd-Result: default: False [-2.40 / 15.00]; ARC_NA(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[94.100.176.153:from]; R_DKIM_ALLOW(-0.20)[mail.ru:s=mail3]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_HAS_DN(0.00)[]; RWL_MAILSPIKE_GOOD(0.00)[94.100.176.153:from]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; DMARC_NA(0.00)[artem.ru]; SPAMHAUS_ZRD(0.00)[94.100.176.153:from:127.0.2.255]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[mail.ru:+]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_SHORT(-1.00)[-0.998]; R_SPF_NA(0.00)[no SPF record]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; SUBJECT_ENDS_QUESTION(1.00)[]; ASN(0.00)[asn:47764, ipnet:94.100.176.0/20, country:RU]; MID_RHS_MATCH_FROM(0.00)[]; MAILMAN_DEST(0.00)[freebsd-fs]; RCVD_IN_DNSWL_LOW(-0.10)[94.100.176.153:from] Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2021 13:05:09 -0000 gnope only allows to set probability, but i need an exact block in an exact place. 15.02.2021 20:44, Alan Somers пишет: > If you have SCSI disks, you can inject errors with `sysctl > kern.cam.da.0.error_inject`.  If not, you can use gnop(8) to simulate > a flaky disk. > > On Mon, Feb 15, 2021 at 10:36 AM Artem Kuchin > wrote: > > Hello! > > Is there a way to build a file base storage device (for example, file > based zfs mirror) and then simulate a bad sector for one of the > mirror > sides? > > Artem > > > _______________________________________________ > freebsd-fs@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-fs > > To unsubscribe, send any mail to > "freebsd-fs-unsubscribe@freebsd.org > " > From owner-freebsd-fs@freebsd.org Tue Feb 16 13:21:48 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 94750537F6F for ; Tue, 16 Feb 2021 13:21:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4Dg1pN3Wrjz3rMl for ; Tue, 16 Feb 2021 13:21:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 78FB253830A; Tue, 16 Feb 2021 13:21:48 +0000 (UTC) Delivered-To: fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 78C99538309 for ; Tue, 16 Feb 2021 13:21:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dg1pN20Ctz3rbM for ; Tue, 16 Feb 2021 13:21:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 3818311B6F for ; Tue, 16 Feb 2021 13:21:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11GDLmP5076992 for ; Tue, 16 Feb 2021 13:21:48 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11GDLmfv076980 for fs@FreeBSD.org; Tue, 16 Feb 2021 13:21:48 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 252316] [PATCH] add OCF offloading to ZFS Date: Tue, 16 Feb 2021 13:21:48 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: gldisater@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.isobsolete attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2021 13:21:48 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D252316 Jeremy Faulkner changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #221152|0 |1 is obsolete| | --- Comment #1 from Jeremy Faulkner --- Created attachment 222488 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D222488&action= =3Dedit The patch with OpenZFS contrib files excluded --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Tue Feb 16 15:52:02 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D5BEF53D3A3 for ; Tue, 16 Feb 2021 15:52:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4Dg57k5DsYz4cTY for ; Tue, 16 Feb 2021 15:52:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id B39D953D31C; Tue, 16 Feb 2021 15:52:02 +0000 (UTC) Delivered-To: fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B355653D16C for ; Tue, 16 Feb 2021 15:52:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dg57k4b8xz4cNx for ; Tue, 16 Feb 2021 15:52:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 908E513E07 for ; Tue, 16 Feb 2021 15:52:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11GFq2B5066379 for ; Tue, 16 Feb 2021 15:52:02 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11GFq2xh066367 for fs@FreeBSD.org; Tue, 16 Feb 2021 15:52:02 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 252316] [PATCH] add OCF offloading to ZFS Date: Tue, 16 Feb 2021 15:52:02 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: markj@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2021 15:52:02 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D252316 Mark Johnston changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |markj@FreeBSD.org --- Comment #2 from Mark Johnston --- I don't quite understand the bug here. Can you provide a test case which illustrates where e.g., safexcel, is going wrong? --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Tue Feb 16 16:21:38 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 628DF53E85F for ; Tue, 16 Feb 2021 16:21:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4Dg5nt27w8z4gFW for ; Tue, 16 Feb 2021 16:21:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 496BE53E678; Tue, 16 Feb 2021 16:21:38 +0000 (UTC) Delivered-To: fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 492FC53E85E for ; Tue, 16 Feb 2021 16:21:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dg5nt1YYQz4fxY for ; Tue, 16 Feb 2021 16:21:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 28CEB142FD for ; Tue, 16 Feb 2021 16:21:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11GGLcpG087621 for ; Tue, 16 Feb 2021 16:21:38 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11GGLcS5087620 for fs@FreeBSD.org; Tue, 16 Feb 2021 16:21:38 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 252316] [PATCH] add OCF offloading to ZFS Date: Tue, 16 Feb 2021 16:21:38 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: gldisater@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2021 16:21:38 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D252316 --- Comment #3 from Jeremy Faulkner --- The original patch includes adding a consumer for OCF to offload SHA256 in = ZFS, it can be used to test. When implementing that patch I encountered an issue where none of the OCF drivers were handling crp_digest_start on a crypto_request. So the drivers would run Init and Finish without running Up= date producing an incorrect result and causing ZFS to output checksum errors as = the data written prior to patching was not matching the miscalculated checksum. After discussing it with Allan Jude I've resubmitted the patch without the OpenZFS parts and will submit those parts upstream after some modification = so it will not break Linux compiles. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Tue Feb 16 17:59:11 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 04ABB541B59 for ; Tue, 16 Feb 2021 17:59:11 +0000 (UTC) (envelope-from lopez.on.the.lists@yellowspace.net) Received: from mail.yellowspace.net (mail.yellowspace.net [62.146.62.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with UTF8SMTPS id 4Dg7yQ0XZwz4pj0 for ; Tue, 16 Feb 2021 17:59:09 +0000 (UTC) (envelope-from lopez.on.the.lists@yellowspace.net) Subject: Re: Migrating from base to OpenZFS: GELI drives, send/receive, and sysctls/loader.conf To: freebsd-fs@freebsd.org References: <183ed751-5a2e-5468-c82c-670820bac138@yellowspace.net> From: Lorenzo Perone Message-ID: <3b13d100-92af-276c-dd58-3d914eeea432@yellowspace.net> Date: Tue, 16 Feb 2021 18:59:01 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4Dg7yQ0XZwz4pj0 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of lopez.on.the.lists@yellowspace.net designates 62.146.62.106 as permitted sender) smtp.mailfrom=lopez.on.the.lists@yellowspace.net X-Spamd-Result: default: False [-3.18 / 15.00]; ARC_NA(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[62.146.62.106:from]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+a:mail.yellowspace.net]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; DMARC_NA(0.00)[yellowspace.net]; RCPT_COUNT_ONE(0.00)[1]; SPAMHAUS_ZRD(0.00)[62.146.62.106:from:127.0.2.255]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.88)[-0.882]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15598, ipnet:62.146.0.0/16, country:DE]; MID_RHS_MATCH_FROM(0.00)[]; MAILMAN_DEST(0.00)[freebsd-fs] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2021 17:59:11 -0000 Am 15.02.21 um 21:08 schrieb Freddie Cash: > On Mon., Feb. 15, 2021, 9:37 a.m. Lorenzo Perone, > > wrote: > > Hi All, > > I have followed regularly the development of openzfs for FreeBSD and I > guess I'm ready and eager to give it a first try on a 12.2 updated > system by using the port. > > Particularly watching the (now a little outdated, but still good) talk > by Alan Jude @ EuroBSDCon 2019 was very encouraging. > > What I'm planning as a first run is: > > On the same machine: > > - Boot with openzfs_load instead of zfs_load > - Import the "base" created pool with openzfs > - Create a new pool with openzfs > - Send/Receive and/or rsync data from the old to the new one > > > A few questions arised for which I didn't find an answer yet in the > official documentation. > > 1) Will a pool on GELI drives import well with openzfs too? I'd assume > yes, why shouldn't it. Just asking to correct me if there are any > precautions I should be taking or surprises to expect. > > 2) Will the "old" settings be honored by openzfs, such as > vfs.zfs.arc_min, vfs.zfs.arc_max in /boot/loader.conf? > > 3) Is there an openzfs_enable as opposed to zfs_enable in rc.conf (to > import/mount pools at boot)? Or is zfs_enable just compatible? > > 4) As far as I know, it should be possible to send/receive data from an > unencrypted dataset to an encrypted one. Is this advisable from an "old > base" zfs dataset (not encrypted, on geli) to a new openzfs one > (encrypted at the dataset level), or should we resort to rsync? > > 5) What's the actual current status on extended attributes? Will they be > retained in a send/receive from FreeBSD-"old" to FreeBSD-OpenZFS? I have > a few shares on that machine where macs have "dropped" their EAs via > AFP/SMB, what should I expect? > > Thanks a lot for any attention by people who know this right away, > > > If this is a boot pool, create a new boot environment and reboot into it > before making any changes. In the new BE, install the port, update > loader.conf and test things out. So long as you don't do a "zpool > upgrade" or enable any new features, then you can always change BE at > the loader menu to revert back to the working config. No, for boot SSDs I usually resort to UFS on gmirror + gjournal... ZFS on root is appealing (boot environments and rollbacks..) but until now booting has been something I have rather kept out of ZFS, legacy or not. Maybe one day.. :) > Doing it that way saved me a lot of headaches when trying to use the > openzfs packages (which don't work on 12.2). Had to eventually install > via the ports tree. Good to know. I'd expect something like this to be fixed soon, however? > A bunch of sysctls are the same, a bunch are named slightly differently, > and there's a whole bunch of new ones. Best bet is to comment then all > out and see if the autotune setup works for you. If not, then tweak the > new sysctls as you go. I'm usually totally fine with autotune, with the only exception of vfs.zfs.arc_min and vfs.zfs.arc_max... I'll dump them out once it starts working. > It's just zfs_enable in rc.conf for both base and port ZFS. Cool. > You can "zfs send" between versions without issue. Double cool :) > Can't help with the GELI or xattrs questions as I don't use those. I guess GELI is a no-brainer, xattrs I guess I'll find out.. Best Regards and thanx a lot!! Lorenzo From owner-freebsd-fs@freebsd.org Tue Feb 16 20:16:09 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6685A548083; Tue, 16 Feb 2021 20:16:09 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [217.70.178.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4DgC0S2YcSz3KX5; Tue, 16 Feb 2021 20:16:08 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from [192.168.0.88] (unknown [195.64.148.76]) (Authenticated sender: andriy.gapon@uabsd.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 48D11240003; Tue, 16 Feb 2021 20:16:05 +0000 (UTC) Subject: Re: panic: condition seqc_in_modify(_vp->v_seqc) not met at zfs_acl.c:1147 (zfs_acl_chown_setattr) From: Andriy Gapon To: FreeBSD Current , freebsd-fs@FreeBSD.org References: <1b261679-3492-dda8-614e-21150a2375d8@FreeBSD.org> <038304d0-2cd0-f089-56ee-c094cdc4cc21@FreeBSD.org> Cc: Mateusz Guzik Message-ID: <8f944450-734d-e70b-c1fb-10d2239576e2@FreeBSD.org> Date: Tue, 16 Feb 2021 22:16:04 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <038304d0-2cd0-f089-56ee-c094cdc4cc21@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4DgC0S2YcSz3KX5 X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [0.00 / 15.00]; ASN(0.00)[asn:29169, ipnet:217.70.176.0/20, country:FR]; local_wl_from(0.00)[FreeBSD.org] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2021 20:16:09 -0000 On 15/02/2021 11:45, Andriy Gapon wrote: > On 15/02/2021 10:22, Andriy Gapon wrote: >> >> I've got this panic once when copying a couple of files. >> The system is stable/13 as of 1996360d7338d, a custom kernel configuration, but >> no local source code modifications. >> >> Unread portion of the kernel message buffer: >> VNASSERT failed: ({ seqc_t __seqc = (_vp->v_seqc); __builtin_expect((__seqc & >> 1), 0); }) not true at >> /usr/devel/git/trant/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_acl.c:1147 >> (zfs_acl_chown_setattr) >> 0xfffff8013e4e85b8: type VDIR >> usecount 1, writecount 0, refcount 1 seqc users 0 mountedhere 0 >> hold count flags () >> flags () >> lock type zfs: EXCL by thread 0xfffffe01dd1cd560 (pid 30747, kdeinit5, tid >> 159911) >> panic: condition seqc_in_modify(_vp->v_seqc) not met at >> /usr/devel/git/trant/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_acl.c:1147 >> (zfs_acl_chown_setattr) >> >> Any ideas, suggestions, hints? >> Thanks! >> > ... >> #4 0xffffffff8036fd21 in zfs_acl_chown_setattr (zp=0xfffff801ccd203b0) >> at /usr/devel/git/trant/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_acl.c:1147 >> #5 0xffffffff8037e52d in zfs_setattr (zp=0xfffff8024b04f760, >> vap=vap@entry=0xfffffe029a36c870, flags=flags@entry=0, >> cr=, cr@entry=0xfffff8003ecedc00) >> at >> /usr/devel/git/trant/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vnops_os.c:2758 > > So, this is actually the second zfs_acl_chown_setattr call here: > err = zfs_acl_chown_setattr(zp); > ASSERT(err == 0); > if (attrzp) { > err = zfs_acl_chown_setattr(attrzp); > ASSERT(err == 0); > } > > I am not sure if the assertion is actually applicable to attrzp (extended > attributes "directory"). > At least I do not see any seq calls for it. > So, I think that the problem should be reproducible by simply chown-ing a file with an extended attribute. The kernel should be compiled with both DEBUG_VFS_LOCKS and INVARIANTS. -- Andriy Gapon From owner-freebsd-fs@freebsd.org Tue Feb 16 20:38:53 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 02F2C548E78; Tue, 16 Feb 2021 20:38:53 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DgCVh2Flhz3N46; Tue, 16 Feb 2021 20:38:51 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-wr1-x429.google.com with SMTP id b3so14934439wrj.5; Tue, 16 Feb 2021 12:38:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=iGd+8BpkhSHf8cNB2VsjeYXmpDzwRF7TGyCD5H5cRwY=; b=RokdnjYuZd6JKohvRHku9lidHu66xXmpTEkiF+uNGEP78/aClKoAlfyS6R5vxNYSKF AIRCDz+mSTndnsDdH/Ae/bm392G4Fkzx4P1RtTT5HQBJJm7x+aDDu7SxeV7jGvBfdU8t 6we6NkAlOCqxwuUxEFydBi8AywWdPDdnojCnvr2Xg6bzLZjmFx4jEd9zz4+9686EeVvK j60OgJKqMd4V3akGQJyr+ZgSmVvIzLyA0gT0xyciAz0YI+BVLIJuUvdb+xap/JYcZtJq 8kisH1tBn1ka7wYQhShKCWagvyY6MoKKqDDGt4kXv6hHuIBwy5HgPEuOzgSM/hEZeV7P nbng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=iGd+8BpkhSHf8cNB2VsjeYXmpDzwRF7TGyCD5H5cRwY=; b=tJKDAQIC9zZ45p+cJ+Xn0nFvdOjyMH1ykDXH0940zF2oTAVze3DhM5C6po3au+Ju1D EcNWby19xAG/HzSC31ruQBA+9J9Of5kBiVYC5qMJwSlGBBd7mZ07SHxwChJ/4dsSW6Eq 555C4SWIdkCOss7SCuNT/ki49CElbGedWCGFvfyn50ENCESKmU52syR8ioqvwUYV9AYq I18Ch0/7riPoGNK8z7kCrQAUJqrhsBIyEvTgOszSQYSzbjzA1jozoimSdrzlEz6skWQ3 gTp3HVR/VMQp1jj6vF2OBuoe5Uf+vzgiLJT1SBDRYUxoY0VZZzaTwWe2b7oS6mUQ5xOs SKKQ== X-Gm-Message-State: AOAM531BU+i5cGwaLUk2JVCPDfWjrDBz3hXaRW5aCaEtk6WLknzsww6i 9rb6oWnKSol1ixiQ/fDJjpVPyQDRGV0KEycbUZDt0D48 X-Google-Smtp-Source: ABdhPJwbg5bwXZStriNmNm82VcnkQhUW0I1W7wayhqUQgJLjNCNceDAptDVgl+WamZouS2KHdNWX8VX84BprgrJv6so= X-Received: by 2002:a05:6000:1565:: with SMTP id 5mr25711315wrz.109.1613507929501; Tue, 16 Feb 2021 12:38:49 -0800 (PST) MIME-Version: 1.0 Received: by 2002:adf:e406:0:0:0:0:0 with HTTP; Tue, 16 Feb 2021 12:38:48 -0800 (PST) In-Reply-To: <8f944450-734d-e70b-c1fb-10d2239576e2@FreeBSD.org> References: <1b261679-3492-dda8-614e-21150a2375d8@FreeBSD.org> <038304d0-2cd0-f089-56ee-c094cdc4cc21@FreeBSD.org> <8f944450-734d-e70b-c1fb-10d2239576e2@FreeBSD.org> From: Mateusz Guzik Date: Tue, 16 Feb 2021 21:38:48 +0100 Message-ID: Subject: Re: panic: condition seqc_in_modify(_vp->v_seqc) not met at zfs_acl.c:1147 (zfs_acl_chown_setattr) To: Andriy Gapon Cc: FreeBSD Current , freebsd-fs@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4DgCVh2Flhz3N46 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=RokdnjYu; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of mjguzik@gmail.com designates 2a00:1450:4864:20::429 as permitted sender) smtp.mailfrom=mjguzik@gmail.com X-Spamd-Result: default: False [-4.00 / 15.00]; ARC_NA(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[2a00:1450:4864:20::429:from]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; TO_DN_SOME(0.00)[]; SPAMHAUS_ZRD(0.00)[2a00:1450:4864:20::429:from:127.0.2.255]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::429:from]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[freebsd-current,freebsd-fs]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] X-Mailman-Approved-At: Wed, 17 Feb 2021 05:25:02 +0000 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2021 20:38:53 -0000 I think for future proofing it would be best if all vnodes going there had seqc marked, thus I think this should do the trick: diff --git a/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vnops_os.c b/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vnops_os.c index d5f0da9ecd4b..8172916c4329 100644 --- a/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vnops_os.c +++ b/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vnops_os.c @@ -2756,7 +2756,9 @@ zfs_setattr(znode_t *zp, vattr_t *vap, int flags, cred_t *cr) err = zfs_acl_chown_setattr(zp); ASSERT(err == 0); if (attrzp) { + vn_seqc_write_begin(ZTOV(attrzp)); err = zfs_acl_chown_setattr(attrzp); + vn_seqc_write_end(ZTOV(attrzp)); ASSERT(err == 0); } } I don't see other calls to the routine. On 2/16/21, Andriy Gapon wrote: > On 15/02/2021 11:45, Andriy Gapon wrote: >> On 15/02/2021 10:22, Andriy Gapon wrote: >>> >>> I've got this panic once when copying a couple of files. >>> The system is stable/13 as of 1996360d7338d, a custom kernel >>> configuration, but >>> no local source code modifications. >>> >>> Unread portion of the kernel message buffer: >>> VNASSERT failed: ({ seqc_t __seqc = (_vp->v_seqc); >>> __builtin_expect((__seqc & >>> 1), 0); }) not true at >>> /usr/devel/git/trant/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_acl.c:1147 >>> (zfs_acl_chown_setattr) >>> 0xfffff8013e4e85b8: type VDIR >>> usecount 1, writecount 0, refcount 1 seqc users 0 mountedhere 0 >>> hold count flags () >>> flags () >>> lock type zfs: EXCL by thread 0xfffffe01dd1cd560 (pid 30747, >>> kdeinit5, tid >>> 159911) >>> panic: condition seqc_in_modify(_vp->v_seqc) not met at >>> /usr/devel/git/trant/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_acl.c:1147 >>> (zfs_acl_chown_setattr) >>> >>> Any ideas, suggestions, hints? >>> Thanks! >>> >> ... >>> #4 0xffffffff8036fd21 in zfs_acl_chown_setattr (zp=0xfffff801ccd203b0) >>> at >>> /usr/devel/git/trant/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_acl.c:1147 >>> #5 0xffffffff8037e52d in zfs_setattr (zp=0xfffff8024b04f760, >>> vap=vap@entry=0xfffffe029a36c870, flags=flags@entry=0, >>> cr=, cr@entry=0xfffff8003ecedc00) >>> at >>> /usr/devel/git/trant/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vnops_os.c:2758 >> >> So, this is actually the second zfs_acl_chown_setattr call here: >> err = zfs_acl_chown_setattr(zp); >> ASSERT(err == 0); >> if (attrzp) { >> err = zfs_acl_chown_setattr(attrzp); >> ASSERT(err == 0); >> } >> >> I am not sure if the assertion is actually applicable to attrzp (extended >> attributes "directory"). >> At least I do not see any seq calls for it. >> > > So, I think that the problem should be reproducible by simply chown-ing a > file > with an extended attribute. The kernel should be compiled with both > DEBUG_VFS_LOCKS and INVARIANTS. > > -- > Andriy Gapon > -- Mateusz Guzik From owner-freebsd-fs@freebsd.org Wed Feb 17 05:32:58 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 59380533196 for ; Wed, 17 Feb 2021 05:32:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4DgRLy1tNkz4nrB for ; Wed, 17 Feb 2021 05:32:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 3EC76533162; Wed, 17 Feb 2021 05:32:58 +0000 (UTC) Delivered-To: fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3E918532E67 for ; Wed, 17 Feb 2021 05:32:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DgRLy1Dwjz4nnn for ; Wed, 17 Feb 2021 05:32:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 1D8C41F51F for ; Wed, 17 Feb 2021 05:32:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11H5Wwm2078451 for ; Wed, 17 Feb 2021 05:32:58 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11H5Wwfo078450 for fs@FreeBSD.org; Wed, 17 Feb 2021 05:32:58 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 253564] When using Root on ZFS with cuse.ko: Mounting from zfs:zroot with error 6 Date: Wed, 17 Feb 2021 05:32:58 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: linimon@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: assigned_to Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Feb 2021 05:32:58 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253564 Mark Linimon changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|bugs@FreeBSD.org |fs@FreeBSD.org --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Wed Feb 17 10:09:54 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 474FD53A560 for ; Wed, 17 Feb 2021 10:09:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4DgYVT70Snz549G for ; Wed, 17 Feb 2021 10:09:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id F00C453A383; Wed, 17 Feb 2021 10:09:53 +0000 (UTC) Delivered-To: fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EFB7D53A663 for ; Wed, 17 Feb 2021 10:09:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DgYVT64JWz54Cj for ; Wed, 17 Feb 2021 10:09:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id BF4B622A31 for ; Wed, 17 Feb 2021 10:09:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11HA9r6F045766 for ; Wed, 17 Feb 2021 10:09:53 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11HA9r0J045765 for fs@FreeBSD.org; Wed, 17 Feb 2021 10:09:53 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 224601] autofs: Make automount(8) call chdir("/") before create_directory() Date: Wed, 17 Feb 2021 10:09:54 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Feb 2021 10:09:54 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D224601 --- Comment #9 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D63640b2f552c0476f50484635eb9888ea= fcd22dc commit 63640b2f552c0476f50484635eb9888eafcd22dc Author: Robert Wing AuthorDate: 2021-02-17 09:22:23 +0000 Commit: Robert Wing CommitDate: 2021-02-17 10:02:56 +0000 automount(8): fix absolute path when creating a mountpoint When executing automount(8), it will attempt to create the directory wh= ere an autofs filesystem is to be mounted. Explicity set the root path for this directory to "/". This fixes the issue where the directory being created was being treate= d as a relative path instead of an absolute path (as expected). PR: 224601 Reported by: kusumi.tomohiro@gmail.com Reviewed by: trasz MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D27832 usr.sbin/autofs/common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Wed Feb 17 14:49:23 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0E987543AC1 for ; Wed, 17 Feb 2021 14:49:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4Dgghy6s2Xz3P0w for ; Wed, 17 Feb 2021 14:49:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id EB514543BA2; Wed, 17 Feb 2021 14:49:22 +0000 (UTC) Delivered-To: fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EB1DE543C82 for ; Wed, 17 Feb 2021 14:49:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dgghy6GL1z3Nw7 for ; Wed, 17 Feb 2021 14:49:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id CA11D26594 for ; Wed, 17 Feb 2021 14:49:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11HEnMDs015190 for ; Wed, 17 Feb 2021 14:49:22 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11HEnMcn015189 for fs@FreeBSD.org; Wed, 17 Feb 2021 14:49:22 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 224601] autofs: Make automount(8) call chdir("/") before create_directory() Date: Wed, 17 Feb 2021 14:49:23 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: emaste@freebsd.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Feb 2021 14:49:23 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D224601 Ed Maste changed: What |Removed |Added ---------------------------------------------------------------------------- Status|New |In Progress --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Wed Feb 17 19:02:35 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 28E1452C4A5 for ; Wed, 17 Feb 2021 19:02:35 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DgnK70jqBz3D0M for ; Wed, 17 Feb 2021 19:02:35 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from [192.168.1.10] (unknown [98.42.164.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: rpokala) by smtp.freebsd.org (Postfix) with ESMTPSA id C3B412DAFC for ; Wed, 17 Feb 2021 19:02:34 +0000 (UTC) (envelope-from rpokala@freebsd.org) User-Agent: Microsoft-MacOutlook/16.45.21011103 Date: Wed, 17 Feb 2021 11:02:31 -0800 Subject: Re: Simulating bad sectors on file based storage device. How? From: Ravi Pokala To: "freebsd-fs@freebsd.org" Message-ID: <7DBD44C9-AB81-43AB-94C9-212577A765B3@panasas.com> Thread-Topic: Simulating bad sectors on file based storage device. How? Mime-version: 1.0 Content-type: text/plain; charset="UTF-8" Content-transfer-encoding: 7bit X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Feb 2021 19:02:35 -0000 -----Original Message----- Date: Tue, 16 Feb 2021 16:05:03 +0300 From: Artem Kuchin To: Alan Somers Cc: freebsd-fs Subject: Re: Simulating bad sectors on file based storage device. How? Message-ID: <46b52475-385f-5931-f425-fd546dd5b377@artem.ru> Content-Type: text/plain; charset=utf-8; format=flowed gnope only allows to set probability, but i need an exact block in an exact place. ATA, NVMe, and SCSI all have commands to mark specific ranges of logical sectors as unreadable. - ATA: WRITE_UNCORRECTABLE_EXT (has both report-failure-instantly and perform-real-error-recovery-before-reporting-failure modes) - NVMe: Write Uncorrectable - SCSI: WRITE_LONG (has both report-failure-instantly and perform-real-error-recovery-before-reporting-failure modes) The base system does not contain programs to issue those commands specifically, but the commands can be assembled by hand and sent to the drive via `camcontrol cmd' (ATA, SCSI) or `nvmecontrol io-passthru' (NVMe). Obviously, assembling those commands would require spending some time with the ATA specs from t13.org, the NVMe specs from nvme.org, or the SCSI "Block Commands" spec from t10.org. It should go without saying that those commands are dangerous, because by definition they destroy data. Use with caution after deep study of the docs in question. -Ravi (rpokala@) 15.02.2021 20:44, Alan Somers ?????: > If you have SCSI disks, you can inject errors with `sysctl > kern.cam.da.0.error_inject`.? If not, you can use gnop(8) to simulate > a flaky disk. > > On Mon, Feb 15, 2021 at 10:36 AM Artem Kuchin > wrote: > > Hello! > > Is there a way to build a file base storage device (for example, file > based zfs mirror) and then simulate a bad sector for one of the > mirror > sides? > > Artem From owner-freebsd-fs@freebsd.org Wed Feb 17 19:22:16 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C9C9B52D8F7 for ; Wed, 17 Feb 2021 19:22:16 +0000 (UTC) (envelope-from ira@wakeful.net) Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dgnlr5BKKz3F47 for ; Wed, 17 Feb 2021 19:22:16 +0000 (UTC) (envelope-from ira@wakeful.net) Received: by mail-wr1-x42a.google.com with SMTP id g6so18547410wrs.11 for ; Wed, 17 Feb 2021 11:22:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wakeful-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4YuPDE/9CnHQWtqFa3kw6YgdJg6URzAQagkXU16Jf38=; b=CfaVfYOgCs3oQKU7s1FgBkvjasUFuW0uugx5EgIzeOOkV1EW0LBr50oHuSgTTBRo0L Grr3FPWuB6DWqVWdqKKSSCU/siovSUDuMU1IlkHS/xGflh9cohAB83lDtuMl19Gj8v85 kn8UqeW8lN59zIhvHmX3lsMYKC2h0CkPvwl83kEHU0l/4PiUo+tAEo9beu8gcNNuxL5m 7LgOE3jRW43sX25aN9H5k1Xp4r1MEAVquG6cH9v6A8eUCWulR1fXxfGAbtve7E5NAG9N PksuQYgVJ/l7AKgTm6JkbLG3Poe9Z0x5Kn6GWUZSlNTf2EuxJlR+jeyXKlmEbg1AucQ0 uS/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4YuPDE/9CnHQWtqFa3kw6YgdJg6URzAQagkXU16Jf38=; b=qrOqUzE+7rS2W7pOpQJrk87Fw4zvR0tXlI0dge4DV0wzXBy9yHroD4CURk+5TD0kVD gxOFxrZtqVeY87MT8c6VLkfzvMIRPRbPuvIfARzvSDtvbbslNs4tllBIfomUjTuajZUQ 8IGuM3BbKC0ONqSf5N4EeECBnwt5EoY+09bHYeQOXRnu1r2SmQMJV0J1pNqXAceoH3Pi NK9U700ofASHRWdgv9hgFiM7a7We7e3+Ma9HqVJ0Xhic4e/q43r0AOLdEFUU0GOqv5qc eFGfDpfwRfwmFFkv+KyDjFcCxLXj65hjaJeFnvSFnOkMXxruIJdjCjTvkKBqnasmyDBc 1qMg== X-Gm-Message-State: AOAM533CPxuSWftwGWHPUKDN6i8r2zhpHrPWEcCsYCoEiPi30GgMqkRe Oo5MFQdzLvvDziCV0pCVRRe4TkXrtYbNET67p1E3K+bT+fiWIo5P X-Google-Smtp-Source: ABdhPJyiTcVRFGqlW2TE6wLRrHUjn7TRY2KFDCJjL8Pn5dFO3INHRSDp74KYM8f+im4a11g8noAGEovUP3U7l58Htys= X-Received: by 2002:adf:bac8:: with SMTP id w8mr725451wrg.68.1613589734683; Wed, 17 Feb 2021 11:22:14 -0800 (PST) MIME-Version: 1.0 References: <7DBD44C9-AB81-43AB-94C9-212577A765B3@panasas.com> In-Reply-To: <7DBD44C9-AB81-43AB-94C9-212577A765B3@panasas.com> From: Ira Cooper Date: Wed, 17 Feb 2021 14:22:04 -0500 Message-ID: Subject: Re: Simulating bad sectors on file based storage device. How? To: Ravi Pokala Cc: "freebsd-fs@freebsd.org" X-Rspamd-Queue-Id: 4Dgnlr5BKKz3F47 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Feb 2021 19:22:16 -0000 A suggestion: Use ISCSI to emulate the SCSI layer, and use the target to emulate the errors you want to emulate. I believe the ports collection has at least one userland target in it. -Ira On Wed, Feb 17, 2021 at 2:02 PM Ravi Pokala wrote: > -----Original Message----- > Date: Tue, 16 Feb 2021 16:05:03 +0300 > From: Artem Kuchin > To: Alan Somers > Cc: freebsd-fs > Subject: Re: Simulating bad sectors on file based storage device. How? > Message-ID: <46b52475-385f-5931-f425-fd546dd5b377@artem.ru> > Content-Type: text/plain; charset=utf-8; format=flowed > > gnope only allows to set probability, but i need an exact block in an > exact place. > > ATA, NVMe, and SCSI all have commands to mark specific ranges of logical > sectors as unreadable. > > - ATA: WRITE_UNCORRECTABLE_EXT (has both report-failure-instantly and > perform-real-error-recovery-before-reporting-failure modes) > > - NVMe: Write Uncorrectable > > - SCSI: WRITE_LONG (has both report-failure-instantly and > perform-real-error-recovery-before-reporting-failure modes) > > The base system does not contain programs to issue those commands > specifically, but the commands can be assembled by hand and sent to the > drive via `camcontrol cmd' (ATA, SCSI) or `nvmecontrol io-passthru' (NVMe). > Obviously, assembling those commands would require spending some time with > the ATA specs from t13.org, the NVMe specs from nvme.org, or the SCSI > "Block Commands" spec from t10.org. > > It should go without saying that those commands are dangerous, because by > definition they destroy data. Use with caution after deep study of the docs > in question. > > -Ravi (rpokala@) > > > 15.02.2021 20:44, Alan Somers ?????: > > If you have SCSI disks, you can inject errors with `sysctl > > kern.cam.da.0.error_inject`.? If not, you can use gnop(8) to > simulate > > a flaky disk. > > > > On Mon, Feb 15, 2021 at 10:36 AM Artem Kuchin > > wrote: > > > > Hello! > > > > Is there a way to build a file base storage device (for example, > file > > based zfs mirror) and then simulate a bad sector for one of the > > mirror > > sides? > > > > Artem > > > > _______________________________________________ > freebsd-fs@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-fs > To unsubscribe, send any mail to "freebsd-fs-unsubscribe@freebsd.org" > From owner-freebsd-fs@freebsd.org Wed Feb 17 20:56:55 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 05D50532651 for ; Wed, 17 Feb 2021 20:56:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4Dgqs26ZcYz3N3w for ; Wed, 17 Feb 2021 20:56:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id DFAA65326B6; Wed, 17 Feb 2021 20:56:54 +0000 (UTC) Delivered-To: fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DF70353281B for ; Wed, 17 Feb 2021 20:56:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dgqs25sGWz3NKm for ; Wed, 17 Feb 2021 20:56:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id B7B71393F for ; Wed, 17 Feb 2021 20:56:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11HKusQP032984 for ; Wed, 17 Feb 2021 20:56:54 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11HKusY1032983 for fs@FreeBSD.org; Wed, 17 Feb 2021 20:56:54 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 252981] panic with ZFS encryption and QAT: VERIFY3(0 == spa_do_crypt_bad(... Date: Wed, 17 Feb 2021 20:56:55 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: panic X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: markj@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Feb 2021 20:56:55 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D252981 Mark Johnston changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Open |In Progress --- Comment #9 from Mark Johnston --- https://github.com/openzfs/zfs/pull/11612 --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Wed Feb 17 21:37:52 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3359A533FFF for ; Wed, 17 Feb 2021 21:37:52 +0000 (UTC) (envelope-from Walter.von.Entferndt@posteo.net) Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4DgrmH0kFrz3jSH for ; Wed, 17 Feb 2021 21:37:50 +0000 (UTC) (envelope-from Walter.von.Entferndt@posteo.net) Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 7BEB12400FB for ; Wed, 17 Feb 2021 22:37:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1613597868; bh=WNfhFSZUcTpk7nA1WXfRMGHcyLsq9B6m4h8DoT5J+T0=; h=From:To:Cc:Subject:Date:From; b=mJabhBPSHx7DwL8Nk6CLZAK3w/RBwVrDSfOA4qgIfblHc5kzTPTy3MNKm1PkXDVTC htzmz+NCoXvtEKU/G/tHSD4Z17ifUT/dBW5XPh13ft+BBkReJPFEGc/b7DN17PII6O wAaYQ5uFNhYuXbR/ECiQ/0ue/EJW8uR977INQRFQhAp9ARrPRLw3T3vaP0dDbZBMlH HNMQbDx/yLhvBgLpvWgJN6+KXsHaPWARW6rAD4+uRq8frxdUTAmCLRRAVhDJAaLqW7 MwIS3JQ1u8PC/k2NqGz7kp4WVAojD7N1D8pFIKORjRFnRC1XRVhldecitB+QB3bOeO 0jrNuS25ULM/w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4DgrmC3D40z9rxT; Wed, 17 Feb 2021 22:37:47 +0100 (CET) From: Walter von Entferndt To: artem@artem.ru Cc: freebsd-fs@freebsd.org Subject: Re: Simulating bad sectors on file based storage device. How? Date: Wed, 17 Feb 2021 22:37:37 +0100 Message-ID: <2038526.4WAli8B44Z@t450s.local.lan> X-Face: #$[hC+4[4W*mS3hB&izisyT_#E]^Aq+7Isv`2Tu5q*1~jR@&['74B>Ibyrk]GTJ!j$ NjX=#L2#k2X7OnaaRM_Pd5`>`8OJ3; +I2 References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Rspamd-Queue-Id: 4DgrmH0kFrz3jSH X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=posteo.net header.s=2017 header.b=mJabhBPS; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (mx1.freebsd.org: domain of Walter.von.Entferndt@posteo.net designates 185.67.36.66 as permitted sender) smtp.mailfrom=Walter.von.Entferndt@posteo.net X-Spamd-Result: default: False [-3.20 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; RWL_MAILSPIKE_GOOD(0.00)[185.67.36.66:from]; R_SPF_ALLOW(-0.20)[+ip4:185.67.36.0/23]; TO_DN_NONE(0.00)[]; RCVD_DKIM_ARC_DNSWL_MED(-0.50)[]; RCVD_COUNT_THREE(0.00)[3]; RCVD_IN_DNSWL_MED(-0.20)[185.67.36.66:from]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[posteo.net,none]; DKIM_TRACE(0.00)[posteo.net:+]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; SUBJECT_ENDS_QUESTION(1.00)[]; CTE_CASE(0.50)[]; ASN(0.00)[asn:8495, ipnet:185.67.36.0/23, country:DE]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[posteo.net:s=2017]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-fs@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[freebsd-fs] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Feb 2021 21:37:52 -0000 At Mittwoch, 17. Februar 2021, 13:00:02 CET, Artem Kuchin wrote: > 15.02.2021 20:44, Alan Somers ?????: > > If you have SCSI disks, you can inject errors with `sysctl > > kern.cam.da.0.error_inject`.? If not, you can use gnop(8) to > > simulate a flaky disk. > > gnop only allows to set probability, but i need an exact block in an > exact place. > Then RTSL & adjust a few lines in the source of gnop(8) (/usr/src/sys/ geom/nop/g_nop.c, the error is inserted @line 158-167). Search for "failprob". It's very straightforward to adopt that and mimic a fail- on-specific-block# by copy & paste & adjust that functionality. Obviously you'll have to recompile all userland software that accesses the gnop(4), but these should be very few to none. -- =|o) "Stell' Dir vor es geht und keiner kriegt's hin." (Wolfgang Neuss) From owner-freebsd-fs@freebsd.org Wed Feb 17 21:44:18 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 40A445346F3 for ; Wed, 17 Feb 2021 21:44:18 +0000 (UTC) (envelope-from artem@artem.ru) Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dgrvh5Ywnz3jlh for ; Wed, 17 Feb 2021 21:44:16 +0000 (UTC) (envelope-from artem@artem.ru) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mail.ru; s=mail3; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:From:Subject:Content-Type:Content-Transfer-Encoding:To:Cc; bh=eiPXEtGr0/BYtjXFoaedMzbftlbpsUlX1lrUwOwQbnc=; b=W1WKPXB6shpdr0HCXfGH/Qr7FLA79Q8bwXrCmYzNSDPswtREPDwFB22VzHg1yDAQKENUAMhyodVvYi39UBsb+5XSrY4KqspkElK5iAEeXdhd41alzpYkVs/YOBIF9mR38zWY87vmM06hDB/PYRXHMLSrUwPDvSOTwghMELdlrDY=; Received: by smtp52.i.mail.ru with esmtpa (envelope-from ) id 1lCUcH-0002M3-2s; Thu, 18 Feb 2021 00:44:13 +0300 Subject: Re: Simulating bad sectors on file based storage device. How? To: Walter von Entferndt Cc: freebsd-fs@freebsd.org References: <2038526.4WAli8B44Z@t450s.local.lan> From: Artem Kuchin Message-ID: Date: Thu, 18 Feb 2021 00:44:13 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <2038526.4WAli8B44Z@t450s.local.lan> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: ru X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD975C3EC174F5669221340953D8FEAAFCA26BB79E5C093AA91182A05F538085040A49F0D982DE5CEE63FF2970E972C65480E48C5DC2EB3695DDE9AABF4A32A0577 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE758E3775C3D7FDEE4EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637BA5555A0C16230F4EA1F7E6F0F101C674E70A05D1297E1BBC6CDE5D1141D2B1CD402014F5224927FDDE129A938AA5F8E7C72AD61EAFF6A2E9FA2833FD35BB23D9E625A9149C048EE1E561CDFBCA1751FCB629EEF1311BF91D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8B9FC99A4BA45EE8B4A471835C12D1D977C4224003CC836476EB9C4185024447017B076A6E789B0E975F5C1EE8F4F765FCA96415FF9D2A38D33AA81AA40904B5D9CF19DD082D7633A078D18283394535A93AA81AA40904B5D98AA50765F79006377C1DF3794FA78393D81D268191BDAD3D698AB9A7B718F8C442539A7722CA490C13377AFFFEAFD26923F8577A6DFFEA7C289736CE4F78F08393EC92FD9297F6715571747095F342E857739F23D657EF2BD5E8D9A59859A8B67393CE827C55B5F775ECD9A6C639B01B4E70A05D1297E1BBC6867C52282FAC85D9B7C4F32B44FF5775D391926547D3B0BD9CCCA9EDD067B1EDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A5E4E2485866DBF93BA1B921D3B1A4BA5EA8B6B5FD760E7039D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75DEAE4BB767A572CB410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3455049D7B43D89D64F34F9307D3ABB3A520DD23A9ED2B9C33BCC52B7EFDD03599594925DEFAEA8CEC1D7E09C32AA3244CF9CA75F5400434ECA577496F397A701DB018FE5BB746DCD1729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojJkVkVdRHm/+MILApCXnNNg== X-Mailru-Sender: 0E9E14D9EC491FBA4CEF082AF5CC4C29732D407BE069D565EBEC6F5ED9114CA534AD54B71D4632CB0A1FD29A504278DEE66B5C1DBFD5D09D2FFF0A5F0DFA254CD0701747CC0EF98689F635B1FCB23A66AE208404248635DF X-Mras: Ok X-Rspamd-Queue-Id: 4Dgrvh5Ywnz3jlh X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=mail.ru header.s=mail3 header.b=W1WKPXB6; dmarc=none; spf=none (mx1.freebsd.org: domain of artem@artem.ru has no SPF policy when checking 94.100.177.112) smtp.mailfrom=artem@artem.ru X-Spamd-Result: default: False [-2.38 / 15.00]; ARC_NA(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[94.100.177.112:from]; R_DKIM_ALLOW(-0.20)[mail.ru:s=mail3]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[artem.ru]; SPAMHAUS_ZRD(0.00)[94.100.177.112:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[mail.ru:+]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_SHORT(-0.98)[-0.979]; R_SPF_NA(0.00)[no SPF record]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; SUBJECT_ENDS_QUESTION(1.00)[]; ASN(0.00)[asn:47764, ipnet:94.100.176.0/20, country:RU]; MID_RHS_MATCH_FROM(0.00)[]; MAILMAN_DEST(0.00)[freebsd-fs]; RCVD_IN_DNSWL_LOW(-0.10)[94.100.177.112:from] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Feb 2021 21:44:18 -0000 18.02.2021 0:37, Walter von Entferndt пишет: > At Mittwoch, 17. Februar 2021, 13:00:02 CET, Artem Kuchin > wrote: >> 15.02.2021 20:44, Alan Somers ?????: >>> If you have SCSI disks, you can inject errors with `sysctl >>> kern.cam.da.0.error_inject`.? If not, you can use gnop(8) to >>> simulate a flaky disk. >> gnop only allows to set probability, but i need an exact block in an >> exact place. >> > Then RTSL & adjust a few lines in the source of gnop(8) (/usr/src/sys/ > geom/nop/g_nop.c, the error is inserted @line 158-167). Search for > "failprob". It's very straightforward to adopt that and mimic a fail- > on-specific-block# by copy & paste & adjust that functionality. > > Obviously you'll have to recompile all userland software that accesses > the gnop(4), but these should be very few to none. True! Thank you for the idea! I forgot i can program C :) I can copy the source and just make my own utility. Artem From owner-freebsd-fs@freebsd.org Thu Feb 18 01:03:53 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AF96E540D29 for ; Thu, 18 Feb 2021 01:03:53 +0000 (UTC) (envelope-from mckusick@mckusick.com) Received: from chez.mckusick.com (chez.mckusick.com [70.36.157.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4DgxL03gbhz4Wyq for ; Thu, 18 Feb 2021 01:03:52 +0000 (UTC) (envelope-from mckusick@mckusick.com) Received: from chez.mckusick.com (localhost [IPv6:::1]) by chez.mckusick.com (8.15.2/8.15.2) with ESMTP id 11I16xkk087677; Wed, 17 Feb 2021 17:07:00 -0800 (PST) (envelope-from mckusick@mckusick.com) Message-Id: <202102180107.11I16xkk087677@chez.mckusick.com> From: Kirk McKusick To: Artem Kuchin Subject: Re: Simulating bad sectors on file based storage device. How? cc: "freebsd-fs@freebsd.org" X-URL: http://WWW.McKusick.COM/ Reply-To: Kirk McKusick MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <87675.1613610419.1@chez.mckusick.com> Date: Wed, 17 Feb 2021 17:06:59 -0800 X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,MISSING_MID, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on chez.mckusick.com X-Rspamd-Queue-Id: 4DgxL03gbhz4Wyq X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of mckusick@mckusick.com has no SPF policy when checking 70.36.157.235) smtp.mailfrom=mckusick@mckusick.com X-Spamd-Result: default: False [-0.10 / 15.00]; HAS_REPLYTO(0.00)[mckusick@mckusick.com]; TO_DN_EQ_ADDR_SOME(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCPT_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; R_DKIM_NA(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[70.36.157.235:from]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:46375, ipnet:70.36.128.0/19, country:US]; FAKE_REPLY(1.00)[]; ARC_NA(0.00)[]; REPLYTO_EQ_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; FREEFALL_USER(0.00)[mckusick]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; SUBJECT_ENDS_QUESTION(1.00)[]; AUTH_NA(1.00)[]; DMARC_NA(0.00)[mckusick.com]; SPAMHAUS_ZRD(0.00)[70.36.157.235:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_SPF_NA(0.00)[no SPF record]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[freebsd-fs] X-Mailman-Approved-At: Thu, 18 Feb 2021 19:11:36 +0000 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Feb 2021 01:03:53 -0000 > Date: Tue, 16 Feb 2021 16:05:03 +0300 > From: Artem Kuchin > To: Alan Somers > Cc: freebsd-fs > Subject: Re: Simulating bad sectors on file based storage device. How? > > gnope only allows to set probability, but i need an exact block in an > exact place. I have a hacked up version of gnop that adds the -F option to tell it to fail any access to a specific set of sectors. So to make /dev/da0p1 into a disk that failed sectors 64-71, I use # gnop create -F 64-71 /dev/da0p1 which creates /dev/da0p1.nop with the desired property. No damage is done to /dev/da0p1 beyond the fact that no writes to the specified range will be made. If this driver would be useful, let me know and I'll dig it out. Kirk McKusick From owner-freebsd-fs@freebsd.org Thu Feb 18 19:13:37 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5CE855460EF for ; Thu, 18 Feb 2021 19:13:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4DhPWP20Txz3JdK for ; Thu, 18 Feb 2021 19:13:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 446D154641D; Thu, 18 Feb 2021 19:13:37 +0000 (UTC) Delivered-To: fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 431C354641C for ; Thu, 18 Feb 2021 19:13:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DhPWP1Cn2z3JNw for ; Thu, 18 Feb 2021 19:13:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 1CC1D1DCAE for ; Thu, 18 Feb 2021 19:13:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11IJDb9f081411 for ; Thu, 18 Feb 2021 19:13:37 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11IJDb3P081410 for fs@FreeBSD.org; Thu, 18 Feb 2021 19:13:37 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 253617] ffs_sbget: panic: Unregistered use of FPU in kernel Date: Thu, 18 Feb 2021 19:13:37 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: panic X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: linimon@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: assigned_to keywords Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Feb 2021 19:13:37 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253617 Mark Linimon changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|bugs@FreeBSD.org |fs@FreeBSD.org Keywords| |panic --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Fri Feb 19 01:08:56 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8E1F55333D7 for ; Fri, 19 Feb 2021 01:08:56 +0000 (UTC) (envelope-from gldisater@gmail.com) Received: from mail-qv1-xf30.google.com (mail-qv1-xf30.google.com [IPv6:2607:f8b0:4864:20::f30]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DhYPM49KZz4f2r for ; Fri, 19 Feb 2021 01:08:55 +0000 (UTC) (envelope-from gldisater@gmail.com) Received: by mail-qv1-xf30.google.com with SMTP id t18so1917167qvn.8 for ; Thu, 18 Feb 2021 17:08:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=Fg+OJszaUUGyGUmKI4zVNRAtBTGHLHzOskWbvAGbJlo=; b=tDTw/wZ51tDUESr6vZhbhi7FWHdlQWLvVxJCCMgCDDXlGX8p0ReGLHaZLZPsU2eFYC tjlKVnRH5AECDLn708OvuF2dT1DJ7jsm3VZT1PRBLC/FmC+CDjSaeqloLbbSpkOCHXwL DQzzyUh9wilkZZd0LjZ9PqTmktAuZ7z9M+ieuV2TWwXovaR/4AIkK/aowMn+LRtkDTmB GeagvLlsMRdp85zb9M0u6QZ8+JvMKzd3xW2DUskehR4jrBXdP8/68KfEMoT9kq4cJ2tE SHUfpH8cHx7xdDTD+7bvXqOt4vTl8kNefaUzh+pxim7tSKdxu9CAP0aFsB7WLvBsjxKR Q9Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Fg+OJszaUUGyGUmKI4zVNRAtBTGHLHzOskWbvAGbJlo=; b=f8GmuSOvr8+aICszOX29b+zHFwYsr1whpuqiNLQNSeXPq4DU7CZPk6FVPgTGYPmEnB q2RgiI9ksZpMsbsFhMghuHxM6gJGfpOpso6MOb8+8j78SBq1wiwIzRiTqvuFOoWyIGf5 K9yVQL6t/HFstrJQ611oqXkuP1XsGPRlnnWrGXz5PnTj7UxIj+JkyTkGRAGezEgfpw8l BBnDi1h9Iz4jBcLkJxG9nkGhYGZVlzTYVM2OQfuaiP7tHruK//mm/FBNxbUbnHLuahd1 8sfmFj964Gi+guR7tGMRwINwW0uJA24E2gYsLTqF3XHXEjn0pxCL5alJ7Cubu0COFQVq QIkw== X-Gm-Message-State: AOAM5310cg2pIWf/CwFRr0ixYILecz4i8diLIsApZaMUgDKhAphSpGz5 sx1zfyoeyJOCYaI0oBSp3RFWac23uWQ= X-Google-Smtp-Source: ABdhPJxhpEFRjVnMEYPOdsaUC5IgXzskKyDgDMGLVNHoUdsvHjcKJ2cWhzs/V6uDXhfPw5ApoFdIJg== X-Received: by 2002:a0c:8365:: with SMTP id j92mr7240028qva.19.1613696933984; Thu, 18 Feb 2021 17:08:53 -0800 (PST) Received: from [192.168.1.201] (ip-45-74-99-44.user.start.ca. [45.74.99.44]) by smtp.gmail.com with ESMTPSA id y68sm21138qkb.76.2021.02.18.17.08.52 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Feb 2021 17:08:53 -0800 (PST) Subject: Re: Reading a corrupted file on ZFS To: freebsd-fs@freebsd.org References: From: Jeremy Faulkner Message-ID: <92c03e85-4014-b5ee-17a5-bac3902678cb@gmail.com> Date: Thu, 18 Feb 2021 20:08:51 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4DhYPM49KZz4f2r X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=tDTw/wZ5; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of gldisater@gmail.com designates 2607:f8b0:4864:20::f30 as permitted sender) smtp.mailfrom=gldisater@gmail.com X-Spamd-Result: default: False [-3.73 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; TO_DN_NONE(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-0.75)[-0.747]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RBL_DBL_DONT_QUERY_IPS(0.00)[2607:f8b0:4864:20::f30:from]; FREEMAIL_ENVFROM(0.00)[gmail.com]; MID_RHS_MATCH_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.98)[-0.979]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-fs@freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; SPAMHAUS_ZRD(0.00)[2607:f8b0:4864:20::f30:from:127.0.2.255]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::f30:from]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[freebsd-fs] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2021 01:08:56 -0000 ZDB can be used to pull individual blocks out of a zpool to allow you to piece together what's left of your file. https://www.youtube.com/watch?v=y7gQwypNMdk https://gist.github.com/mdimura/5aa4c163a7e0856b3712b6a880670678 On 2021-02-12 9:53 a.m., Artem Kuchin wrote: > I did a little experiment > > I have a mirror ZFS pool called ZDATA, i created a file and damanged the > same byte in file in it on both disks. > > File has ABCDEF string. > > >         ZDATA       ONLINE       0     0     0 >           mirror-0  ONLINE       0     0     0 >             ada0    ONLINE       0     0     1 >             ada1    ONLINE       0     0     0 > > > destroy ZDATA > > on ada0 change A to Z > on ada1 change A to Y > reimport > > root@xigmanas:~# zpool status >   pool: ZDATA >  state: ONLINE >   scan: scrub repaired 24K in 0 days 00:03:01 with 0 errors on Fri Feb > 12 16:48:46 2021 > config: > >         NAME        STATE     READ WRITE CKSUM >         ZDATA       ONLINE       0     0     0 >           mirror-0  ONLINE       0     0     0 >             ada0    ONLINE       0     0     0 >             ada1    ONLINE       0     0     0 > > errors: No known data errors > > Hmm. it repaired something. Read data from disks. > ada0 - Z > ada1 - Y > so, that repair was not the rotten bytes. > > Now run scrub > > root@xigmanas:~# zpool status -v ZDATA >   pool: ZDATA >  state: ONLINE > status: One or more devices has experienced an error resulting in data >         corruption.  Applications may be affected. > action: Restore the file in question if possible.  Otherwise restore the >         entire pool from backup. >    see:http://illumos.org/msg/ZFS-8000-8A > >   scan: scrub repaired 0 in 0 days 00:03:02 with 1 errors on Fri Feb 12 > 16:59:49 2021 > config: > >         NAME        STATE     READ WRITE CKSUM >         ZDATA       ONLINE       0     0     1 >           mirror-0  ONLINE       0     0     2 >             ada0    ONLINE       0     0     2 >             ada1    ONLINE       0     0     2 > > errors: Permanent errors have been detected in the following files: > >         /data/DATASET1/test.file > > the data is still Z and Y, not sync-ed. > > I cannot read or write this file. This is bad. > > zfs set checksum=off ZDATA > > did not help, still cannot read or write the file. > > zpool clear -F ZDATA > > still cannot r/w the file > > Now i am stuck in worst situation that with UFS - i cannot read what's > left of this file. > > I deleted the file and the scrubbed - error went away. But i lost the file. > > So, the question is how to read the file with an error ? I googled for 2 > hours and still did not find a solution. > > > Artem > > _______________________________________________ > freebsd-fs@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-fs > To unsubscribe, send any mail to "freebsd-fs-unsubscribe@freebsd.org" -- -- Jeremy Faulkner From owner-freebsd-fs@freebsd.org Fri Feb 19 12:45:02 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 49AA1529CE4 for ; Fri, 19 Feb 2021 12:45:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4DhrrZ1Pfvz3w3c for ; Fri, 19 Feb 2021 12:45:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 302F4529965; Fri, 19 Feb 2021 12:45:02 +0000 (UTC) Delivered-To: fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2FF7C529964 for ; Fri, 19 Feb 2021 12:45:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DhrrZ0r5xz3wQC for ; Fri, 19 Feb 2021 12:45:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 0FEF94289 for ; Fri, 19 Feb 2021 12:45:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11JCj2bq054115 for ; Fri, 19 Feb 2021 12:45:02 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11JCj2sd054114 for fs@FreeBSD.org; Fri, 19 Feb 2021 12:45:02 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 253617] ffs_sbget: panic: Unregistered use of FPU in kernel Date: Fri, 19 Feb 2021 12:45:02 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: panic X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: kib@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2021 12:45:02 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253617 Konstantin Belousov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kib@FreeBSD.org --- Comment #1 from Konstantin Belousov --- If you turn off acceleration, or use different hypervisor or bare metal, do= you see the same problem? I believe this is a hypervisor bug, OS cannot/should not do anything there. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Fri Feb 19 12:48:22 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0C4C3529F1E for ; Fri, 19 Feb 2021 12:48:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4DhrwP6m3Qz4QtB for ; Fri, 19 Feb 2021 12:48:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id E7F8C529E78; Fri, 19 Feb 2021 12:48:21 +0000 (UTC) Delivered-To: fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E7C2E529E77 for ; Fri, 19 Feb 2021 12:48:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DhrwP69VCz4QyS for ; Fri, 19 Feb 2021 12:48:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id C6BB63CE3 for ; Fri, 19 Feb 2021 12:48:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11JCmLOQ055350 for ; Fri, 19 Feb 2021 12:48:21 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11JCmLDQ055349 for fs@FreeBSD.org; Fri, 19 Feb 2021 12:48:21 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 253617] ffs_sbget: panic: Unregistered use of FPU in kernel Date: Fri, 19 Feb 2021 12:48:21 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: panic X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: arichardson@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2021 12:48:22 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253617 --- Comment #2 from Alex Richardson --- This seems to happen with TCG as well, so it's not KVM. Possibly a generic = QEMU bug then? --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Fri Feb 19 12:50:20 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2942252A230 for ; Fri, 19 Feb 2021 12:50:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4Dhryh0VNqz4RBs for ; Fri, 19 Feb 2021 12:50:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 10F5D52A067; Fri, 19 Feb 2021 12:50:20 +0000 (UTC) Delivered-To: fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 10BAC52A1A7 for ; Fri, 19 Feb 2021 12:50:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dhryg71bpz4RBr for ; Fri, 19 Feb 2021 12:50:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id E42974097 for ; Fri, 19 Feb 2021 12:50:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11JCoJVv056035 for ; Fri, 19 Feb 2021 12:50:19 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11JCoJgD056034 for fs@FreeBSD.org; Fri, 19 Feb 2021 12:50:19 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 253617] ffs_sbget: panic: Unregistered use of FPU in kernel Date: Fri, 19 Feb 2021 12:50:20 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: panic X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: arichardson@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2021 12:50:20 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253617 --- Comment #3 from Alex Richardson --- Note: this is QEMU running with as `qemu-system-x86_64 -M accel=3Dtcg -cpu Nehalem -smp 8 -m 2048 -nographic -drive if=3Dnone,file=3D/local/scratch/alr48/cheri/output/freebsd-amd64.img,id=3Dd= rv,format=3Draw -device virtio-blk-pci,drive=3Ddrv`, so possibly related to the -smp option= . I have not seen it without QEMU's smp flag. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Fri Feb 19 12:55:39 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4B5A152A448 for ; Fri, 19 Feb 2021 12:55:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4Dhs4q1Sn6z4RWD for ; Fri, 19 Feb 2021 12:55:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 323EF52A447; Fri, 19 Feb 2021 12:55:39 +0000 (UTC) Delivered-To: fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3206352A4D1 for ; Fri, 19 Feb 2021 12:55:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dhs4q0tZwz4RYZ for ; Fri, 19 Feb 2021 12:55:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 0FF87405D for ; Fri, 19 Feb 2021 12:55:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11JCtdNb062494 for ; Fri, 19 Feb 2021 12:55:39 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11JCtdOn062493 for fs@FreeBSD.org; Fri, 19 Feb 2021 12:55:39 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 253617] ffs_sbget: panic: Unregistered use of FPU in kernel Date: Fri, 19 Feb 2021 12:55:39 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: panic X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: kib@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2021 12:55:39 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253617 --- Comment #4 from Konstantin Belousov --- Note that CRC32 instruction is qualified on SSE4.2, but it does not use any of FPU registers. It operates on GPR so it does not require saving user context before executing in kernel. It should not even cause #NM (Device Not Available) exception at all, accor= ding to SDM. Adding fpu_kern_enter() around it would hugely hit non-buggy environments like bare metal or non-buggy hypervisors. Try to report it to QEMU devs. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Fri Feb 19 16:11:00 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 766E1531871 for ; Fri, 19 Feb 2021 16:11:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4DhxQD2l28z4g6g for ; Fri, 19 Feb 2021 16:11:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 5DE0A531870; Fri, 19 Feb 2021 16:11:00 +0000 (UTC) Delivered-To: fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5DA33531CCC for ; Fri, 19 Feb 2021 16:11:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DhxQD24TXz4fsm for ; Fri, 19 Feb 2021 16:11:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 39FEB677D for ; Fri, 19 Feb 2021 16:11:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11JGB05L079252 for ; Fri, 19 Feb 2021 16:11:00 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11JGB0Yp079237 for fs@FreeBSD.org; Fri, 19 Feb 2021 16:11:00 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 253617] ffs_sbget: panic: Unregistered use of FPU in kernel Date: Fri, 19 Feb 2021 16:11:00 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: panic X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: arichardson@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: Not A Bug X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status resolution Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2021 16:11:00 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253617 Alex Richardson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|New |Closed Resolution|--- |Not A Bug --- Comment #5 from Alex Richardson --- I just had a look at the QEMU TCG code for crc32 and it does not seem like = it can raise anything other than #UD. Unless of course there is a bug in the decoding logic and it is treating <+126>: crc32q %rsi,%rbx as a different instruction. GDB says the raw bytes= are as follows: 0xffffffff8105a4de <+126>: f2 48 0f 38 f1 de crc32q %rsi,%rbx 0xffffffff8105a4e4 <+132>: f2 48 0f 38 f1 ca crc32q %rdx,%rcx. So this does sound like it must be a QEMU bug. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Fri Feb 19 17:10:13 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 19D365338B5 for ; Fri, 19 Feb 2021 17:10:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4DhykY039qz4kPX for ; Fri, 19 Feb 2021 17:10:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 017105336D6; Fri, 19 Feb 2021 17:10:13 +0000 (UTC) Delivered-To: fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 013275338B4 for ; Fri, 19 Feb 2021 17:10:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DhykX6YQvz4kRs for ; Fri, 19 Feb 2021 17:10:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id D3743797A for ; Fri, 19 Feb 2021 17:10:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11JHACRr017769 for ; Fri, 19 Feb 2021 17:10:12 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11JHACrs017768 for fs@FreeBSD.org; Fri, 19 Feb 2021 17:10:12 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 253617] ffs_sbget: panic: Unregistered use of FPU in kernel Date: Fri, 19 Feb 2021 17:10:13 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: panic X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: arichardson@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: Not A Bug X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2021 17:10:13 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253617 --- Comment #6 from Alex Richardson --- Reported upstream as https://bugs.launchpad.net/qemu/+bug/1916269 --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Fri Feb 19 22:21:01 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 602715421AB for ; Fri, 19 Feb 2021 22:21:01 +0000 (UTC) (envelope-from ryan@ixsystems.com) Received: from mail-oi1-x230.google.com (mail-oi1-x230.google.com [IPv6:2607:f8b0:4864:20::230]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dj5d82fbjz3RGL for ; Fri, 19 Feb 2021 22:21:00 +0000 (UTC) (envelope-from ryan@ixsystems.com) Received: by mail-oi1-x230.google.com with SMTP id 6so7448962ois.9 for ; Fri, 19 Feb 2021 14:21:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ixsystems.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=erx6t3+hCPhGFO3DVgWoEDxijUuJaA9SQ+FQzMBum4Q=; b=NFAAoKZOU1UWQVVQnT4iwnLGq2Pzp30+vWhUmGZbMt7Z3u/x3fA1KKRt4YCWKpxAt3 Uu2WSo9RQK21chKTnThrJLh6HUZ/qYBnOeuiv5Zkm109iTpBr8mJ5bBUYoNVW1cTtUmi EBpXHFYhNoOhjOSy3bVrfYp/Cew5GlCNdhDke7jgtIpPGt83HPTIRgPw7GkgLXaDkXKI 4MfWY0Q+H3Y2VmGRkxOs8KaeovwnBLqhpq/HRz603TltENBk8PBotR9QlfUfRYgbZySe lmNqIyG80XjuELzzMPkdD85nbZwM/S9tq4o6824vYg+KcICvCGgoNSj0heBcUv3cfi1a Uf5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=erx6t3+hCPhGFO3DVgWoEDxijUuJaA9SQ+FQzMBum4Q=; b=boAySlOTaxOELkxpE3K+iXHmvb5Y7wXYPE7ZSk5PtQAsUFkZ/P6POhjOQ5LA+EhJ8Q LZEhKeQ+v85tY6jdA5qGFwsFPWGFuEmJkqMs3xzQFLMweO0Z9wRn8/n9s44pwjeoySsD DrxlDTQIaid7QyHzTyZJuUax3hR1nTxaTlK8qsNYHfHspc+QWMr5I4C+JjN1oBGzhLxt 9MSHUQhI72bQHMMNqksJk9JsC4xjNMY0fmrDN8bsm8dFm/zHUsV6gzCbCwo01o2eg612 Jrbi+bOG/YAbqE2Y0XRcYlOarTxgGmpmg6EKzuXTIavhSs9L1qICYgDifUX13kg70d5S qBHw== X-Gm-Message-State: AOAM5308N0Wpjun0Nw+ME8bf8huQtmGvonYu2hSYClZq9X9HPEtd06j1 pZYH7+O4g7cAHZFX0ycCkn7+Jt4eeXkrYrpJtl6+kg== X-Google-Smtp-Source: ABdhPJxDujEnyaUZ9cEaXAy7guIPgqfdyruRJFj6TbqkedrBHF8/0T13By2bNMrS8Jh87PkXtONd1BXXtSQ8fxAl6Ww= X-Received: by 2002:a05:6808:130c:: with SMTP id y12mr8292743oiv.128.1613773259355; Fri, 19 Feb 2021 14:20:59 -0800 (PST) MIME-Version: 1.0 References: <92c03e85-4014-b5ee-17a5-bac3902678cb@gmail.com> In-Reply-To: <92c03e85-4014-b5ee-17a5-bac3902678cb@gmail.com> From: Ryan Moeller Date: Fri, 19 Feb 2021 17:20:44 -0500 Message-ID: Subject: Re: Reading a corrupted file on ZFS To: Jeremy Faulkner Cc: freebsd-fs Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4Dj5d82fbjz3RGL X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=ixsystems.com header.s=google header.b=NFAAoKZO; dmarc=pass (policy=none) header.from=ixsystems.com; spf=pass (mx1.freebsd.org: domain of ryan@ixsystems.com designates 2607:f8b0:4864:20::230 as permitted sender) smtp.mailfrom=ryan@ixsystems.com X-Spamd-Result: default: False [-4.00 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[ixsystems.com:s=google]; FREEFALL_USER(0.00)[ryan]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-fs@freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; SPAMHAUS_ZRD(0.00)[2607:f8b0:4864:20::230:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[ixsystems.com:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::230:from]; NEURAL_HAM_SHORT(-1.00)[-1.000]; DMARC_POLICY_ALLOW(-0.50)[ixsystems.com,none]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RBL_DBL_DONT_QUERY_IPS(0.00)[2607:f8b0:4864:20::230:from]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[freebsd-fs] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2021 22:21:01 -0000 Recovering files with zdb recently became quite a bit easier if you're on CURRENT: https://github.com/openzfs/zfs/pull/11027 -Ryan On Thu, Feb 18, 2021 at 8:09 PM Jeremy Faulkner wrote: > > ZDB can be used to pull individual blocks out of a zpool to allow you to > piece together what's left of your file. > > https://www.youtube.com/watch?v=y7gQwypNMdk > > https://gist.github.com/mdimura/5aa4c163a7e0856b3712b6a880670678 > > On 2021-02-12 9:53 a.m., Artem Kuchin wrote: > > I did a little experiment > > > > I have a mirror ZFS pool called ZDATA, i created a file and damanged the > > same byte in file in it on both disks. > > > > File has ABCDEF string. > > > > > > ZDATA ONLINE 0 0 0 > > mirror-0 ONLINE 0 0 0 > > ada0 ONLINE 0 0 1 > > ada1 ONLINE 0 0 0 > > > > > > destroy ZDATA > > > > on ada0 change A to Z > > on ada1 change A to Y > > reimport > > > > root@xigmanas:~# zpool status > > pool: ZDATA > > state: ONLINE > > scan: scrub repaired 24K in 0 days 00:03:01 with 0 errors on Fri Feb > > 12 16:48:46 2021 > > config: > > > > NAME STATE READ WRITE CKSUM > > ZDATA ONLINE 0 0 0 > > mirror-0 ONLINE 0 0 0 > > ada0 ONLINE 0 0 0 > > ada1 ONLINE 0 0 0 > > > > errors: No known data errors > > > > Hmm. it repaired something. Read data from disks. > > ada0 - Z > > ada1 - Y > > so, that repair was not the rotten bytes. > > > > Now run scrub > > > > root@xigmanas:~# zpool status -v ZDATA > > pool: ZDATA > > state: ONLINE > > status: One or more devices has experienced an error resulting in data > > corruption. Applications may be affected. > > action: Restore the file in question if possible. Otherwise restore the > > entire pool from backup. > > see:http://illumos.org/msg/ZFS-8000-8A > > > > scan: scrub repaired 0 in 0 days 00:03:02 with 1 errors on Fri Feb 12 > > 16:59:49 2021 > > config: > > > > NAME STATE READ WRITE CKSUM > > ZDATA ONLINE 0 0 1 > > mirror-0 ONLINE 0 0 2 > > ada0 ONLINE 0 0 2 > > ada1 ONLINE 0 0 2 > > > > errors: Permanent errors have been detected in the following files: > > > > /data/DATASET1/test.file > > > > the data is still Z and Y, not sync-ed. > > > > I cannot read or write this file. This is bad. > > > > zfs set checksum=off ZDATA > > > > did not help, still cannot read or write the file. > > > > zpool clear -F ZDATA > > > > still cannot r/w the file > > > > Now i am stuck in worst situation that with UFS - i cannot read what's > > left of this file. > > > > I deleted the file and the scrubbed - error went away. But i lost the file. > > > > So, the question is how to read the file with an error ? I googled for 2 > > hours and still did not find a solution. > > > > > > Artem > > > > _______________________________________________ > > freebsd-fs@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/freebsd-fs > > To unsubscribe, send any mail to "freebsd-fs-unsubscribe@freebsd.org" > > -- > -- > Jeremy Faulkner > _______________________________________________ > freebsd-fs@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-fs > To unsubscribe, send any mail to "freebsd-fs-unsubscribe@freebsd.org" -- Ryan Moeller iXsystems, Inc. OS Developer Email: ryan@iXsystems.com From owner-freebsd-fs@freebsd.org Sat Feb 20 05:54:00 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 278F6539FBD for ; Sat, 20 Feb 2021 05:54:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4DjHgr0RThz4kyR for ; Sat, 20 Feb 2021 05:54:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 0F1BC53A31C; Sat, 20 Feb 2021 05:54:00 +0000 (UTC) Delivered-To: fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0EE4053A31B for ; Sat, 20 Feb 2021 05:54:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DjHgq6xZdz4kdP for ; Sat, 20 Feb 2021 05:53:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id E18C719D62 for ; Sat, 20 Feb 2021 05:53:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11K5rxeo078255 for ; Sat, 20 Feb 2021 05:53:59 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11K5rxMT078253 for fs@FreeBSD.org; Sat, 20 Feb 2021 05:53:59 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 252396] [zfs] [panic] Panic on 'bectl list' after slog removal Date: Sat, 20 Feb 2021 05:54:00 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: panic X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: rew@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Feb 2021 05:54:00 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D252396 Robert Wing changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rew@FreeBSD.org --- Comment #3 from Robert Wing --- Created attachment 222658 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D222658&action= =3Dedit fix panix after slog removal --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Sat Feb 20 05:57:14 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7CF5053A2B6 for ; Sat, 20 Feb 2021 05:57:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4DjHlZ1cYTz4lBd for ; Sat, 20 Feb 2021 05:57:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 375F853A2B5; Sat, 20 Feb 2021 05:57:14 +0000 (UTC) Delivered-To: fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 37281539FD9 for ; Sat, 20 Feb 2021 05:57:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DjHlZ12FZz4lBc for ; Sat, 20 Feb 2021 05:57:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 168A019FF5 for ; Sat, 20 Feb 2021 05:57:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11K5vEY0079009 for ; Sat, 20 Feb 2021 05:57:14 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11K5vEOV079008 for fs@FreeBSD.org; Sat, 20 Feb 2021 05:57:14 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 252396] [zfs] [panic] Panic on 'bectl list' after slog removal Date: Sat, 20 Feb 2021 05:57:14 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: panic X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: rew@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Feb 2021 05:57:14 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D252396 --- Comment #4 from Robert Wing --- Looks like this was patched by Patrick Mooney in https://www.illumos.org/issues/12981 I've submitted a pull request upstream to openzfs, https://github.com/openzfs/zfs/pull/11623 In the meantime, I've included the patch here. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Sat Feb 20 12:43:29 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B14915456CD for ; Sat, 20 Feb 2021 12:43:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4DjSmK4TN8z3Nx1 for ; Sat, 20 Feb 2021 12:43:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 99AC05456CC; Sat, 20 Feb 2021 12:43:29 +0000 (UTC) Delivered-To: fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9970B545648 for ; Sat, 20 Feb 2021 12:43:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DjSmK3pwBz3PN6 for ; Sat, 20 Feb 2021 12:43:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 767C41F43B for ; Sat, 20 Feb 2021 12:43:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11KChT7M006114 for ; Sat, 20 Feb 2021 12:43:29 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11KChTGN006113 for fs@FreeBSD.org; Sat, 20 Feb 2021 12:43:29 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 241117] zfs_unlinked_drain takes "forever" for over-quota ZFS filesystems Date: Sat, 20 Feb 2021 12:43:29 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.2-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: pen@lysator.liu.se X-Bugzilla-Status: Closed X-Bugzilla-Resolution: Overcome By Events X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status resolution Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Feb 2021 12:43:29 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D241117 Peter Eriksson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|New |Closed Resolution|--- |Overcome By Events --- Comment #1 from Peter Eriksson --- I'm closing this bug. Hopefully things will behave nicer with OpenZFS in the future :-) --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Sat Feb 20 18:36:56 2021 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5C29A550942 for ; Sat, 20 Feb 2021 18:36:56 +0000 (UTC) (envelope-from allanjude@freebsd.org) Received: from tor1-11.mx.scaleengine.net (tor1-11.mx.scaleengine.net [209.51.186.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Djcc80P5Dz4Wkc for ; Sat, 20 Feb 2021 18:36:55 +0000 (UTC) (envelope-from allanjude@freebsd.org) Received: from [10.1.1.2] (Seawolf.HML3.ScaleEngine.net [209.51.186.28]) (Authenticated sender: allanjude.freebsd@scaleengine.com) by tor1-11.mx.scaleengine.net (Postfix) with ESMTPSA id 555B3FD07 for ; Sat, 20 Feb 2021 18:36:49 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.10.3 tor1-11.mx.scaleengine.net 555B3FD07 Subject: Re: Reading a corrupted file on ZFS To: freebsd-fs@freebsd.org References: <0ca45adf-8f60-a4c3-6264-6122444a3ffd@denninger.net> <899c6b4f-2368-7ec2-4dfe-fa09fab35447@artem.ru> <20210212165216.2f613482@fabiankeil.de> <10977ffc-f806-69dd-0cef-d4fd4fc5f649@artem.ru> <2f82f113-9ca1-99a9-a433-89e3ae5edcbe@denninger.net> <2bf4f69c-9d5d-5ff9-0daa-c87515437ca3@artem.ru> From: Allan Jude Message-ID: Date: Sat, 20 Feb 2021 13:36:48 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4Djcc80P5Dz4Wkc X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [0.00 / 15.00]; local_wl_from(0.00)[freebsd.org]; ASN(0.00)[asn:6939, ipnet:209.51.160.0/19, country:US] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Feb 2021 18:36:56 -0000 On 2021-02-12 13:51, Alan Somers wrote: > On Fri, Feb 12, 2021 at 11:26 AM Artem Kuchin wrote: > >> 12.02.2021 19:37, Karl Denninger пишет: >>> On 2/12/2021 11:22, Artem Kuchin wrote: >>>> >>>> This is frustrating. why..why.. >>> >>> You created a synthetic situation that in the real world almost-never >>> exists (ONE byte modified in all copies in the same allocation block >>> but all other data in that block is intact and recoverable.) >>> >> I could be 1 GB file with ZFS wisth block size of 1MB and with rotten >> bits within the same 1MB of block on different disks. How i did it is >> not important, life is unpredictable, i'm not trying to avoid >> everything. The question is what to do when it happens. And currently >> the answer is - nothing. >> >> >>> In almost-all actual cases of "bit rot" it's exactly that; random and >>> by statistics extraordinarily unlikely to hit all copies at once in >>> the same allocation block. Therefore, ZFS can and does fix it; UFS or >>> FAT silently returns the corrupted data, propagates it, and eventually >>> screws you down the road. >> >> In active fs you are right. But if this is a storage disk with movies >> and photos, then i can just checksum all files with a little script and >> recheck once in a while. So, for storage >> >> perposes i have all ZFS postitives and also can read as much data as i >> can. Because for long time storage it is more important to have ability >> read the data in any case. >> >> >>> >>> The nearly-every-case situation in the real world where a disk goes >>> physically bad (I've had this happen *dozens* of times over my IT >>> career) results in the drive being unable to >> >> >> *NEARLY* is not good enough for me. >> >> >>> return the block at all; >> >> >> You mix device blocks and ZFS block. As far as i remember default ZFS >> block for checksumming is 16K and for big files storage better to have >> it around 128K. >> >> >>> In short there are very, very few actual "in the wild" failures where >>> one byte is damaged and the rest surrounding that one byte is intact >>> and retrievable. In most cases where an actual failure occurs the >>> unreadable data constitutes *at least* a physical sector. >>> >> "very very few" is enough for me to think about. >> >> One more thing. If you have one bad byte in a block of 16K and you have >> checksum and recalculate it then it is quite possible to just brute >> force every byte to match the checksum, thus restoring the data. >> >> If you have mirror with two different bytes then bute forcing is even >> ether, >> >> Somehow, ZFS slaps my hands and does not allow to be sure that i can >> restore data when i needed it and decide myself if it is okay or not. >> >> For long time storage of big files it now seems better to store it on >> UFS mirror, checksum each 512bytes blocks of files and store checksums >> separetelly and run monthly/weekly "scrub". This way i would sleep better. >> > > GOD NO. ZFS is really quite good at preserving your data integrity. For > example, with your suggested scheme what would protect you from a corrupted > checksum file? Nothing. In ZFS, the Merkle hash tree would detect such a > thing. Karl is correct: the type of corruption you're worried about is > almost non-existent in the real world. Why? LDPC coding, for one reason. > For the last 10+ years, hard disks have encoded data using LDPC. Older > hard disk encoding schemes, like Reed-Solomon encoding, stored the data in > a format similar to RAID: as data + parity. That's why older ATA standards > had a "READ LONG" command. But with LDPC, the "original" data does not > exist anywhere on the platter. It gets transformed into a large codeword > with data and parity intermingled. Physical damage will either be > correctable (most likely), render the entire codeword illegible (less > likely), or cause it to decode into completely wrong data (least likely). > There simply isn't any way to randomly flip a single bit, once it's been > written to the media. > > But if you really, really REALLY want to read blocks that have been > deliberately corrupted, you can do it laboriously with zdb. Use zdb to > show the dnode, which will include the record pointers for each block. You > can decode those and extra the data from the disks with dd. The exact > procedure is left as an exercise to the reader. > > -Alan > _______________________________________________ > freebsd-fs@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-fs > To unsubscribe, send any mail to "freebsd-fs-unsubscribe@freebsd.org" > Specifically, my hackathon project at the 2020 OpenZFS developer summit was to make this less laborious. https://github.com/openzfs/zfs/commit/393e69241eea8b5f7f817200ad283b7d5b5ceb70 It allows you to use zdb to copy the file out, even if the pool will not import. You might need to modify it slightly to do what you want in the case of an error (fill the 1 record with zeros, or return the trashed data). -- Allan Jude