From owner-freebsd-audit Sun Mar 25 9:43:36 2001 Delivered-To: freebsd-audit@freebsd.org Received: from mailgate.originative.co.uk (mailgate.originative.co.uk [62.232.68.68]) by hub.freebsd.org (Postfix) with ESMTP id 9090337B718 for ; Sun, 25 Mar 2001 09:43:28 -0800 (PST) (envelope-from paul@freebsd-services.co.uk) Received: from freebsd-services.co.uk (lobster.originative.co.uk [62.232.68.81]) by mailgate.originative.co.uk (Postfix) with ESMTP id 9C1F41D149 for ; Sun, 25 Mar 2001 18:43:21 +0100 (BST) Message-ID: <3ABE2E39.C69E1160@freebsd-services.co.uk> Date: Sun, 25 Mar 2001 18:43:21 +0100 From: Paul Richards X-Mailer: Mozilla 4.76 [en] (X11; U; Linux 2.2.12 i386) X-Accept-Language: en MIME-Version: 1.0 To: freebsd-audit@freebsd.org Subject: if_name panic Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG If you unload an ethernet driver then you can get a panic from if_name. This patch fixes it but I think it's a cludgy fix since I don't think if_name should be called if the interface is gone and the checks should be elsewhere. There's 44 calls to if_name and their all in the KAME code as far as I can see so it might take a while to fix properly in co-ordination with them but this causes a panic so it should probably be considered a showstopper bug that should be bandaided like this before 4.3 goes out (with a more appropriate error message though :-)). Index: net_osdep.c =================================================================== RCS file: /home/ncvs/src/sys/net/net_osdep.c,v retrieving revision 1.3 diff -u -r1.3 net_osdep.c --- net_osdep.c 2000/07/04 16:35:04 1.3 +++ net_osdep.c 2001/03/25 17:35:32 @@ -54,6 +54,10 @@ { static char nam[IFNAMSIZ + 10]; /*enough?*/ - snprintf(nam, sizeof(nam), "%s%d", ifp->if_name, ifp->if_unit); + if (! ifp || ! ifp->if_name || ! ifp->if_unit) { + snprintf(nam, sizeof(nam), "XXX No name, if gone?"); + } else { + snprintf(nam, sizeof(nam), "%s%d", ifp->if_name, ifp->if_unit); + } return nam; } To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sun Mar 25 10:10:58 2001 Delivered-To: freebsd-audit@freebsd.org Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by hub.freebsd.org (Postfix) with ESMTP id DE00337B718 for ; Sun, 25 Mar 2001 10:10:55 -0800 (PST) (envelope-from imp@harmony.village.org) Received: from harmony.village.org (localhost.village.org [127.0.0.1]) by harmony.village.org (8.11.1/8.11.1) with ESMTP id f2PIAq973489; Sun, 25 Mar 2001 11:10:52 -0700 (MST) (envelope-from imp@harmony.village.org) Message-Id: <200103251810.f2PIAq973489@harmony.village.org> To: Paul Richards Subject: Re: if_name panic Cc: freebsd-audit@FreeBSD.ORG In-reply-to: Your message of "Sun, 25 Mar 2001 18:43:21 +0100." <3ABE2E39.C69E1160@freebsd-services.co.uk> References: <3ABE2E39.C69E1160@freebsd-services.co.uk> Date: Sun, 25 Mar 2001 11:10:52 -0700 From: Warner Losh Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message <3ABE2E39.C69E1160@freebsd-services.co.uk> Paul Richards writes: : If you unload an ethernet driver then you can get a panic from if_name. Even if you call if_detach? I've unloaded bunches of them in the past and haven't seen this problem. Interesting. I'd suggest "gonebug0" as the name for 4.3. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Tue Mar 27 9:20:59 2001 Delivered-To: freebsd-audit@freebsd.org Received: from meow.osd.bsdi.com (meow.osd.bsdi.com [204.216.28.88]) by hub.freebsd.org (Postfix) with ESMTP id 7047D37B719 for ; Tue, 27 Mar 2001 09:20:56 -0800 (PST) (envelope-from eric@meow.osd.bsdi.com) Received: (from eric@localhost) by meow.osd.bsdi.com (8.11.2/8.11.2) id f2RHKq456615 for freebsd-audit@freebsd.org; Tue, 27 Mar 2001 09:20:52 -0800 (PST) (envelope-from eric) Date: Tue, 27 Mar 2001 09:20:52 -0800 From: Eric Melville To: freebsd-audit@freebsd.org Subject: [murray@osd.bsdi.com: Re: quick patch to window(1)] Message-ID: <20010327092052.A56508@meow.osd.bsdi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG ----- Forwarded message from Murray Stokely ----- Date: Tue, 27 Mar 2001 01:35:40 -0800 (PST) From: Murray Stokely To: Eric Melville Subject: Re: quick patch to window(1) In-Reply-To: <20010326193527.A35817@meow.osd.bsdi.com> Just because this is security related you should probably throw it by -audit first even though its so simple. Kris K and everyone are generally good at replying to people for this sort of thing. There is a lot of discussion on that list about the use of these functions so they will have strong opinions about how to do it right. - Murray On Mon, 26 Mar 2001, Eric Melville wrote: % A week ago I had a nice patch for mail(1) too, but mikeh did something % similar and committed it about two days ago. Awww :/ % % This is really simple and brain-dead, and it's mostly just to keep from % using mktemp(3) (which is deprecated, etc). % % Index: scanner.c % =================================================================== % RCS file: /home/ncvs/src/usr.bin/window/scanner.c,v % retrieving revision 1.3 % diff -r1.3 scanner.c % 290c290 % < && (cx.x_val.v_str = str_cpy(buf)) == 0) { % --- % > && (cx.x_val.v_str = (void *)str_cpy(buf)) == 0) { % Index: wwterminfo.c % =================================================================== % RCS file: /home/ncvs/src/usr.bin/window/wwterminfo.c,v % retrieving revision 1.4 % diff -r1.4 wwterminfo.c % 67,68c67 % < mktemp(wwterminfopath); % < if (mkdir(wwterminfopath, 0755) < 0 || % --- % > if (mkdtemp(wwterminfopath) < 0 || % - Murray ----- End forwarded message ----- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Tue Mar 27 11:56: 5 2001 Delivered-To: freebsd-audit@freebsd.org Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by hub.freebsd.org (Postfix) with ESMTP id CE2BE37B719 for ; Tue, 27 Mar 2001 11:55:55 -0800 (PST) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (robert@fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.11.1/8.11.1) with SMTP id f2RJtth95329 for ; Tue, 27 Mar 2001 14:55:55 -0500 (EST) (envelope-from robert@fledge.watson.org) Date: Tue, 27 Mar 2001 14:55:55 -0500 (EST) From: Robert Watson X-Sender: robert@fledge.watson.org To: freebsd-audit@FreeBSD.org Subject: audit of PAM changes (cvs commit: src/etc pam.conf src/libexec/rshd Makefile rshd.8 rshd.c src/libexec/ftpd Makefile ftpd.c src/usr.bin/login Makefile login.1 login.c src/usr.bin/su Makefile su.1 su.c (fwd)) Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG I didn't see an audit request go by for these PAM changes (at least, not recently :-), so it might be a good idea, for those with a bit of time on their hands, to go peruse this to verify correctness as much as possible. Robert N M Watson FreeBSD Core Team, TrustedBSD Project robert@fledge.watson.org NAI Labs, Safeport Network Services ---------- Forwarded message ---------- Date: Tue, 27 Mar 2001 11:40:51 -0800 (PST) From: Mark Murray To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/etc pam.conf src/libexec/rshd Makefile rshd.8 rshd.c src/libexec/ftpd Makefile ftpd.c src/usr.bin/login Makefile login.1 login.c src/usr.bin/su Makefile su.1 su.c markm 2001/03/27 11:40:51 PST Modified files: etc pam.conf libexec/rshd Makefile rshd.8 rshd.c libexec/ftpd Makefile ftpd.c usr.bin/login Makefile login.1 login.c usr.bin/su Makefile su.1 su.c Log: Add full PAM support for account management and sessions. The PAM_FAIL_CHECK and PAM_END macros in su.c came from the util-linux package's PAM patches to the BSD login.c Submitted by: "David J. MacKenzie" Revision Changes Path 1.11 +75 -22 src/etc/pam.conf 1.19 +8 -3 src/libexec/rshd/Makefile 1.23 +11 -1 src/libexec/rshd/rshd.8 1.36 +211 -53 src/libexec/rshd/rshd.c 1.40 +3 -4 src/libexec/ftpd/Makefile 1.75 +51 -10 src/libexec/ftpd/ftpd.c 1.33 +3 -4 src/usr.bin/login/Makefile 1.18 +8 -1 src/usr.bin/login/login.1 1.57 +94 -30 src/usr.bin/login/login.c 1.30 +13 -4 src/usr.bin/su/Makefile 1.20 +8 -1 src/usr.bin/su/su.1 1.36 +212 -62 src/usr.bin/su/su.c To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Tue Mar 27 12:34:17 2001 Delivered-To: freebsd-audit@freebsd.org Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by hub.freebsd.org (Postfix) with ESMTP id 4D87837B718 for ; Tue, 27 Mar 2001 12:34:14 -0800 (PST) (envelope-from phk@critter.freebsd.dk) Received: from critter (localhost [127.0.0.1]) by critter.freebsd.dk (8.11.3/8.11.3) with ESMTP id f2RKYB384389 for ; Tue, 27 Mar 2001 22:34:11 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: audit@freebsd.org Subject: review of nitpicks... From: Poul-Henning Kamp Date: Tue, 27 Mar 2001 22:34:11 +0200 Message-ID: <84387.985725251@critter> Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG http://phk.freebsd.dk/patch/ Contains a "nitpicking.patch" which I wouldn't mind a review on. 20010327 nitpicking.patch This patch contains some virtual brucifications. It's the kinds of stuff Bruce would complain about, but I guess he just havn't got around to it yet. src/sys/bio.h: bio->bio_bcount should be unsigned. src/sys/cdefs.h: Don't examine __GNUC__ unless it is defined. Don't examine __FreeBSD_cc_version unless it is defined. src/sys/kerne.h: Don't cast from enum to unsigned int. src/sys/linker_set.h: Define dummy {TEXT|DATA}_SET() if we're not __GNUC__ src/sys/malloc.h: Wrap MALLOC() in do {...} while(0) like all other respectable macros. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Wed Mar 28 1:52:12 2001 Delivered-To: freebsd-audit@freebsd.org Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by hub.freebsd.org (Postfix) with ESMTP id 8303E37B718; Wed, 28 Mar 2001 01:52:06 -0800 (PST) (envelope-from phk@critter.freebsd.dk) Received: from critter (localhost [127.0.0.1]) by critter.freebsd.dk (8.11.3/8.11.3) with ESMTP id f2S9q3391806; Wed, 28 Mar 2001 11:52:03 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: audit@freebsd.org, current@freebsd.org Cc: kirk@mckusick.com Subject: fsck pass sanitizing patch From: Poul-Henning Kamp Date: Wed, 28 Mar 2001 11:52:03 +0200 Message-ID: <91804.985773123@critter> Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG I have put up a patch which sanitizes the fsck passno handling, you will find it at http://phk.freebsd.dk/patch/ Apologies to Kirk if this conflics with any of his work on delayed fsck... 20010328 fsck.patch This patch sanitizes the way fsck deals with pass numbers. Consider this /etc/fstab: # Device Mountpoint FStype Options Dump Pass# /dev/ad1s1b none swap sw 0 0 /dev/ad0s1b none swap sw 0 0 /dev/ad0s1a / ufs rw 1 1 /dev/ad0s1e /home ufs rw 2 2 /dev/ad1s1e /tmp ufs rw 2 2 /dev/ad1s1f /usr ufs rw 2 2 /dev/ccd0c /syv ufs rw 2 11 proc /proc procfs rw 0 0 ccd0c is striped over /dev/ad0f and /dev/ad1g Without this pass, fsck in preen mode will check ad0s1a first, and then issue three processes in parallel: One process doing ad0s1e One process doing ad1s1e and ad1s1f One process doing ccd0c There is no way to tell it that ccd0c overlaps ad0 and ad1. With the patch, it will do it this way: pass 2: One process doing ad0s1e One process doing ad1s1e and ad1s1f and when they are complete: pass 11: One process doing ccd0c This is much faster and more sane. I retired the '-l' option which tried to allow people to do something like this, but which didn't work and which complicated the code an awful lot. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Wed Mar 28 5:27:47 2001 Delivered-To: freebsd-audit@freebsd.org Received: from peitho.fxp.org (peitho.fxp.org [209.26.95.40]) by hub.freebsd.org (Postfix) with ESMTP id AA83937B71E for ; Wed, 28 Mar 2001 05:27:43 -0800 (PST) (envelope-from jedgar@www.fxp.org) Received: from sushi.44bsd.net (oca-pm3-1-28.hitter.net [207.192.76.28]) by peitho.fxp.org (Postfix) with ESMTP id 914521360C; Wed, 28 Mar 2001 08:27:41 -0500 (EST) Received: by sushi.44bsd.net (Postfix, from userid 1000) id E84D3BA83; Wed, 28 Mar 2001 08:27:38 -0500 (EST) Date: Wed, 28 Mar 2001 08:27:38 -0500 From: Chris Faulhaber To: Eric Melville Cc: freebsd-audit@freebsd.org Subject: Re: [murray@osd.bsdi.com: Re: quick patch to window(1)] Message-ID: <20010328082738.A3405@sushi.44bsd.net> Mail-Followup-To: Chris Faulhaber , Eric Melville , freebsd-audit@freebsd.org References: <20010327092052.A56508@meow.osd.bsdi.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="y0ulUmNC+osPPQO6" Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010327092052.A56508@meow.osd.bsdi.com>; from eric@meow.osd.bsdi.com on Tue, Mar 27, 2001 at 09:20:52AM -0800 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG --y0ulUmNC+osPPQO6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 27, 2001 at 09:20:52AM -0800, Eric Melville wrote: > % This is really simple and brain-dead, and it's mostly just to keep from > % using mktemp(3) (which is deprecated, etc). > % > % Index: scanner.c > % =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > % RCS file: /home/ncvs/src/usr.bin/window/scanner.c,v > % retrieving revision 1.3 > % diff -r1.3 scanner.c > % 290c290 > % < && (cx.x_val.v_str =3D str_cpy(buf)) =3D=3D 0) { > % --- > % > && (cx.x_val.v_str =3D (void *)str_cpy(buf)) =3D=3D 0) { Why the cast? v_str (aka v_un.V_str) is char*, the same that str_cpy() returns... Of course, it would probably be better if the hand-rolled str_cpy() and str_ncpy() went away and replaced with strdup()/strlcpy() and some error checking (of which window(1) seems to do very little). > % Index: wwterminfo.c > % =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > % RCS file: /home/ncvs/src/usr.bin/window/wwterminfo.c,v > % retrieving revision 1.4 > % diff -r1.4 wwterminfo.c > % 67,68c67 > % < mktemp(wwterminfopath); > % < if (mkdir(wwterminfopath, 0755) < 0 || > % --- > % > if (mkdtemp(wwterminfopath) < 0 || > % Looks good. --=20 Chris D. Faulhaber - jedgar@fxp.org - jedgar@FreeBSD.org -------------------------------------------------------- FreeBSD: The Power To Serve - http://www.FreeBSD.org --y0ulUmNC+osPPQO6 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.4 (FreeBSD) Comment: FreeBSD: The Power To Serve iEYEARECAAYFAjrB5soACgkQObaG4P6BelACHQCdEaxtM4CmDFmNthyh3x8TXuWU xXkAnj6bfq2ZkqjUkxZjECiTOYCI3v1M =p+gx -----END PGP SIGNATURE----- --y0ulUmNC+osPPQO6-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Wed Mar 28 5:48: 4 2001 Delivered-To: freebsd-audit@freebsd.org Received: from ringworld.nanolink.com (ringworld.nanolink.com [195.24.48.13]) by hub.freebsd.org (Postfix) with SMTP id C1D3637B718 for ; Wed, 28 Mar 2001 05:47:59 -0800 (PST) (envelope-from roam@orbitel.bg) Received: (qmail 9334 invoked by uid 1000); 28 Mar 2001 13:46:57 -0000 Date: Wed, 28 Mar 2001 16:46:57 +0300 From: Peter Pentchev To: qa@FreeBSD.org Cc: audit@FreeBSD.org Subject: Re: fixed: Re: 4.3-RC bug in /usr/bin/netstat Message-ID: <20010328164657.K5524@ringworld.oblivion.bg> Mail-Followup-To: qa@FreeBSD.org, audit@FreeBSD.org References: <20010328073324.O29550@reptiles.org> <3AC1EA32.77715A14@we.lc.ehu.es> <20010328084444.Q29550@reptiles.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010328084444.Q29550@reptiles.org>; from jim@reptiles.org on Wed, Mar 28, 2001 at 08:44:44AM -0500 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Wed, Mar 28, 2001 at 08:44:44AM -0500, Jim Mercer wrote: > On Wed, Mar 28, 2001 at 03:42:10PM +0200, Jose M. Alcaide wrote: > > Jim Mercer wrote: > > > > > > netstat gets a bus error if handed the -a option and the -i option. > > > > > > > Me too: > > a fix was emailed to me by Peter Pentchev, seems to work. > > thanx. > > http://www.freebsd.org/cgi/query-pr.cgi?pr=26168 Can somebody knowledgeable test and review this patch? This seems to qualify as an important bugfix, and should be fixed before 4.3.. G'luck, Peter -- If you think this sentence is confusing, then change one pig. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Wed Mar 28 11: 7:31 2001 Delivered-To: freebsd-audit@freebsd.org Received: from meow.osd.bsdi.com (meow.osd.bsdi.com [204.216.28.88]) by hub.freebsd.org (Postfix) with ESMTP id 996C437B71F for ; Wed, 28 Mar 2001 11:07:26 -0800 (PST) (envelope-from eric@meow.osd.bsdi.com) Received: (from eric@localhost) by meow.osd.bsdi.com (8.11.2/8.11.2) id f2SJ7CV99639; Wed, 28 Mar 2001 11:07:12 -0800 (PST) (envelope-from eric) Date: Wed, 28 Mar 2001 11:07:12 -0800 From: Eric Melville To: Chris Faulhaber Cc: freebsd-audit@freebsd.org Subject: Re: [murray@osd.bsdi.com: Re: quick patch to window(1)] Message-ID: <20010328110712.A99250@meow.osd.bsdi.com> References: <20010327092052.A56508@meow.osd.bsdi.com> <20010328082738.A3405@sushi.44bsd.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010328082738.A3405@sushi.44bsd.net>; from jedgar@fxp.org on Wed, Mar 28, 2001 at 08:27:38AM -0500 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > > % < && (cx.x_val.v_str = str_cpy(buf)) == 0) { > > % --- > > % > && (cx.x_val.v_str = (void *)str_cpy(buf)) == 0) { > > Why the cast? v_str (aka v_un.V_str) is char*, the same that str_cpy() > returns... Yes, you are right. It's just that the compiler gets upset on this line, claiming the assignment makes a pointer from an integer value without cast. A bit sloppy of me, I didn't actually look at str_cpy() itself, but simply forced the thing to be a pointer. Now, the question is, why the complaint from the compiler in the first place? If I go and cast it to (char *), the compiler remains happy. A bit odd considering that str_cpy() is declared as this type to begin with. > Of course, it would probably be better if the hand-rolled str_cpy() > and str_ncpy() went away and replaced with strdup()/strlcpy() and some > error checking (of which window(1) seems to do very little). Yeah, but I was just trying to make it compile clean ;) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Wed Mar 28 11:44:31 2001 Delivered-To: freebsd-audit@freebsd.org Received: from lennier.cc.vt.edu (lennier.cc.vt.edu [198.82.161.193]) by hub.freebsd.org (Postfix) with ESMTP id A87E837B718 for ; Wed, 28 Mar 2001 11:44:23 -0800 (PST) (envelope-from mheffner@vt.edu) Received: from mail.vt.edu (gkar.cc.vt.edu [198.82.161.190]) by lennier.cc.vt.edu (8.11.0/8.11.0) with ESMTP id f2SJhGu505183; Wed, 28 Mar 2001 14:43:16 -0500 (EST) Received: from enterprise.muriel.penguinpowered.com ([198.82.100.151]) by gkar.cc.vt.edu (Sun Internet Mail Server sims.3.5.2000.03.23.18.03.p10) with ESMTP id <0GAX00MKXAS2F7@gkar.cc.vt.edu>; Wed, 28 Mar 2001 14:43:14 -0500 (EST) Date: Wed, 28 Mar 2001 14:43:14 -0500 (EST) From: Mike Heffner Subject: Re: [murray@osd.bsdi.com: Re: quick patch to window(1)] In-reply-to: <20010328110712.A99250@meow.osd.bsdi.com> To: Eric Melville Cc: freebsd-audit@freebsd.org, Chris Faulhaber Message-id: MIME-version: 1.0 X-Mailer: XFMail 1.4.7 on FreeBSD Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 8bit X-Priority: 3 (Normal) Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 28-Mar-2001 Eric Melville wrote: | but simply forced the thing to be a pointer. Now, the question is, why | the complaint from the compiler in the first place? If I go and cast | it to (char *), the compiler remains happy. A bit odd considering that | str_cpy() is declared as this type to begin with. str_cpy() is declared in mystring.h which isn't included from scanner.c Mike -- Mike Heffner Blacksburg, VA http://filebox.vt.edu/users/mheffner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Wed Mar 28 13:33:19 2001 Delivered-To: freebsd-audit@freebsd.org Received: from meow.osd.bsdi.com (meow.osd.bsdi.com [204.216.28.88]) by hub.freebsd.org (Postfix) with ESMTP id 1456537B71C for ; Wed, 28 Mar 2001 13:33:18 -0800 (PST) (envelope-from eric@meow.osd.bsdi.com) Received: (from eric@localhost) by meow.osd.bsdi.com (8.11.2/8.11.2) id f2SLX6h04493; Wed, 28 Mar 2001 13:33:06 -0800 (PST) (envelope-from eric) Date: Wed, 28 Mar 2001 13:33:06 -0800 From: Eric Melville To: Mike Heffner Cc: freebsd-audit@freebsd.org Subject: Re: [murray@osd.bsdi.com: Re: quick patch to window(1)] Message-ID: <20010328133306.B4179@meow.osd.bsdi.com> References: <20010328110712.A99250@meow.osd.bsdi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from mheffner@vt.edu on Wed, Mar 28, 2001 at 02:43:14PM -0500 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Aha. That would explain things ;) > str_cpy() is declared in mystring.h which isn't included from scanner.c To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Wed Mar 28 13:42:30 2001 Delivered-To: freebsd-audit@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 885) id 4AC4537B71B; Wed, 28 Mar 2001 13:42:29 -0800 (PST) Date: Wed, 28 Mar 2001 13:42:29 -0800 From: Eric Melville To: freebsd-audit@freebsd.org Subject: window.diff, attempt 2 Message-ID: <20010328134229.A9340@hub.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Fix things properly this time, and I'm going to assume that Murray would want me to bounce it off this list again before approving it. Index: scanner.c =================================================================== RCS file: /home/ncvs/src/usr.bin/window/scanner.c,v retrieving revision 1.3 diff -r1.3 scanner.c 46a47 > #include "mystring.h" Index: wwterminfo.c =================================================================== RCS file: /home/ncvs/src/usr.bin/window/wwterminfo.c,v retrieving revision 1.4 diff -r1.4 wwterminfo.c 67,68c67 < mktemp(wwterminfopath); < if (mkdir(wwterminfopath, 0755) < 0 || --- > if (mkdtemp(wwterminfopath) < 0 || To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Thu Mar 29 0:42:11 2001 Delivered-To: freebsd-audit@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id 3007237B71E for ; Thu, 29 Mar 2001 00:42:09 -0800 (PST) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id SAA17389; Thu, 29 Mar 2001 18:41:44 +1000 Date: Thu, 29 Mar 2001 18:41:04 +1000 (EST) From: Bruce Evans X-Sender: bde@besplex.bde.org To: Mike Heffner Cc: Eric Melville , freebsd-audit@FreeBSD.ORG, Chris Faulhaber Subject: Re: [murray@osd.bsdi.com: Re: quick patch to window(1)] In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Wed, 28 Mar 2001, Mike Heffner wrote: > On 28-Mar-2001 Eric Melville wrote: > | but simply forced the thing to be a pointer. Now, the question is, why > | the complaint from the compiler in the first place? If I go and cast > | it to (char *), the compiler remains happy. A bit odd considering that > | str_cpy() is declared as this type to begin with. > > str_cpy() is declared in mystring.h which isn't included from scanner.c And the cast makes things worse by breaking the warning. You will still get a warning on systems with sizeof(char *) != sizeof(int), e.g., alphas, and the error that the warning is about is normally fatal on precisely these systems. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Fri Mar 30 4:36:15 2001 Delivered-To: freebsd-audit@freebsd.org Received: from ringworld.nanolink.com (ringworld.nanolink.com [195.24.48.13]) by hub.freebsd.org (Postfix) with SMTP id 516CC37B720 for ; Fri, 30 Mar 2001 04:36:07 -0800 (PST) (envelope-from roam@orbitel.bg) Received: (qmail 34374 invoked by uid 1000); 30 Mar 2001 12:35:03 -0000 Date: Fri, 30 Mar 2001 15:35:03 +0300 From: Peter Pentchev To: freebsd-qa@FreeBSD.org Cc: freebsd-audit@FreeBSD.org Subject: [Fwd: Re: bin/25243: ftp crashes in remotemodtime ().] Message-ID: <20010330153503.B33524@ringworld.oblivion.bg> Mail-Followup-To: freebsd-qa@FreeBSD.org, freebsd-audit@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Uhm. I think this should be fixed in time for 4.3 :) G'luck, Peter -- This sentence contains exactly threee erors. ----- Forwarded message from Peter Pentchev ----- Date: Tue, 20 Feb 2001 23:00:04 -0800 (PST) To: freebsd-bugs@FreeBSD.org Cc: From: Peter Pentchev Subject: Re: bin/25243: ftp crashes in remotemodtime (). Reply-To: Peter Pentchev The following reply was made to PR bin/25243; it has been noted by GNATS. From: Peter Pentchev To: fumis@bigfoot.com Cc: freebsd-gnats-submit@FreeBSD.org Subject: Re: bin/25243: ftp crashes in remotemodtime (). Date: Wed, 21 Feb 2001 08:55:45 +0200 On Tue, Feb 20, 2001 at 09:35:01PM -0800, fumis@bigfoot.com wrote: > > >Number: 25243 > >Category: bin > >Synopsis: ftp crashes in remotemodtime (). > >Originator: SHIMIZU Fumiyuki > >Release: 4.2-STABLE > >Organization: > >Environment: > FreeBSD ***snip*** 4.2-STABLE FreeBSD 4.2-STABLE #1: Tue Feb 20 14:01:10 JST 2001 ***snip*** > >Description: > /usr/bin/ftp crashes after getting a file. > > ftp> get foobar > local: foobar remote: foobar > 227 Entering Passive Mode (***snip***) > 150 Opening data connection for foobar (696075740 bytes). > 100% |**************************************************| 663 MB 00:00 ETA > 226 Transfer complete. > 696075740 bytes received in 11999.42 seconds (56.65 KB/s) > Segmentation fault - core dumped > > >How-To-Repeat: > Connect to ftpd which answers with less than 14 or more than 15 characters against `MDTM' request, and get some files. > > >Fix: > Braces required just after `if (fmt != NULL)' in remotemodtime (). > /usr/src/usr.bin/ftp/util.c, line 533 And the patch itself (trivial, yet needed indeed).. G'luck, Peter -- "yields falsehood, when appended to its quotation." yields falsehood, when appended to its quotation. Index: src/usr.bin/ftp/util.c =================================================================== RCS file: /home/ncvs/src/usr.bin/ftp/util.c,v retrieving revision 1.13 diff -u -r1.13 util.c --- src/usr.bin/ftp/util.c 2000/05/22 17:18:38 1.13 +++ src/usr.bin/ftp/util.c 2001/02/21 06:52:52 @@ -529,7 +529,7 @@ y2kbug = 1; } else if (len == 14) fmt = "%04d%02d%02d%02d%02d%02d"; - if (fmt != NULL) + if (fmt != NULL) { memset(&timebuf, 0, sizeof(timebuf)); if (sscanf(mtbuf, fmt, &year, &month, &timebuf.tm_mday, &timebuf.tm_hour, @@ -542,6 +542,7 @@ timebuf.tm_year = year - 1900; rtime = mktime(&timebuf); } + } } if (rtime == -1 && (noisy || debug != 0)) printf("Can't convert %s to a time.\n", mtbuf); To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message ----- End forwarded message ----- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Fri Mar 30 13: 7:18 2001 Delivered-To: freebsd-audit@freebsd.org Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by hub.freebsd.org (Postfix) with ESMTP id F04E437B71F; Fri, 30 Mar 2001 13:07:08 -0800 (PST) (envelope-from phk@critter.freebsd.dk) Received: from critter (localhost [127.0.0.1]) by critter.freebsd.dk (8.11.3/8.11.3) with ESMTP id f2UL78P22393; Fri, 30 Mar 2001 23:07:09 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: audit@freebsd.org, current@freebsd.org Subject: Call for review... PR 25577 From: Poul-Henning Kamp Date: Fri, 30 Mar 2001 23:07:08 +0200 Message-ID: <22391.985986428@critter> Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Any comments/reviews before we commit the patch to PR25577 ? Get the up to date version here: http://www.one-eyed-alien.net/~brooks/FreeBSD/ifconfig.diff -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Fri Mar 30 13:14:22 2001 Delivered-To: freebsd-audit@freebsd.org Received: from winston.osd.bsdi.com (winston.osd.bsdi.com [204.216.27.229]) by hub.freebsd.org (Postfix) with ESMTP id CF79237B71B; Fri, 30 Mar 2001 13:14:19 -0800 (PST) (envelope-from jkh@osd.bsdi.com) Received: from localhost (jkh@localhost [127.0.0.1]) by winston.osd.bsdi.com (8.11.3/8.11.2) with ESMTP id f2ULEDg88769; Fri, 30 Mar 2001 13:14:14 -0800 (PST) (envelope-from jkh@osd.bsdi.com) To: phk@FreeBSD.ORG Cc: audit@FreeBSD.ORG, current@FreeBSD.ORG Subject: Re: Call for review... PR 25577 In-Reply-To: <22391.985986428@critter> References: <22391.985986428@critter> X-Mailer: Mew version 1.94.1 on Emacs 20.7 / Mule 4.0 (HANANOEN) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-Id: <20010330131413I.jkh@osd.bsdi.com> Date: Fri, 30 Mar 2001 13:14:13 -0800 From: Jordan Hubbard X-Dispatcher: imput version 20000228(IM140) Lines: 6 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Cool. Does this mean that any of the foocontrol programs can go away? I've long wished that we could have some of the wireless control stuff go directly into ifconfig rather than having to run an external program before bringing up the interface. - Jordan To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Fri Mar 30 13:19:18 2001 Delivered-To: freebsd-audit@freebsd.org Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by hub.freebsd.org (Postfix) with ESMTP id 2573137B742; Fri, 30 Mar 2001 13:19:12 -0800 (PST) (envelope-from imp@harmony.village.org) Received: from harmony.village.org (localhost.village.org [127.0.0.1]) by harmony.village.org (8.11.1/8.11.1) with ESMTP id f2ULJ5O05533; Fri, 30 Mar 2001 14:19:05 -0700 (MST) (envelope-from imp@harmony.village.org) Message-Id: <200103302119.f2ULJ5O05533@harmony.village.org> To: Jordan Hubbard Subject: Re: Call for review... PR 25577 Cc: phk@FreeBSD.ORG, audit@FreeBSD.ORG, current@FreeBSD.ORG In-reply-to: Your message of "Fri, 30 Mar 2001 13:14:13 PST." <20010330131413I.jkh@osd.bsdi.com> References: <20010330131413I.jkh@osd.bsdi.com> <22391.985986428@critter> Date: Fri, 30 Mar 2001 14:17:50 -0700 From: Warner Losh Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message <20010330131413I.jkh@osd.bsdi.com> Jordan Hubbard writes: : Cool. Does this mean that any of the foocontrol programs can go away? : I've long wished that we could have some of the wireless control stuff : go directly into ifconfig rather than having to run an external : program before bringing up the interface. Mostly. There are still some minor issues, but the vast majority of the functionality they provide can go poof. My comment to the patch would be lose the ifdef. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Fri Mar 30 13:20:22 2001 Delivered-To: freebsd-audit@freebsd.org Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by hub.freebsd.org (Postfix) with ESMTP id D927B37B71F; Fri, 30 Mar 2001 13:20:18 -0800 (PST) (envelope-from phk@critter.freebsd.dk) Received: from critter (localhost [127.0.0.1]) by critter.freebsd.dk (8.11.3/8.11.3) with ESMTP id f2ULKGP22566; Fri, 30 Mar 2001 23:20:16 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: Jordan Hubbard Cc: audit@FreeBSD.ORG, current@FreeBSD.ORG Subject: Re: Call for review... PR 25577 In-Reply-To: Your message of "Fri, 30 Mar 2001 13:14:13 -0800." <20010330131413I.jkh@osd.bsdi.com> Date: Fri, 30 Mar 2001 23:20:16 +0200 Message-ID: <22564.985987216@critter> From: Poul-Henning Kamp Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message <20010330131413I.jkh@osd.bsdi.com>, Jordan Hubbard writes: >Cool. Does this mean that any of the foocontrol programs can go away? As far as I can see, anything short of firmware updates can be done by ifconfig and therefore, presumably, foocontrol can die for 802.11-valued foo. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Fri Mar 30 15:18:32 2001 Delivered-To: freebsd-audit@freebsd.org Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by hub.freebsd.org (Postfix) with ESMTP id 0FDF537B71B; Fri, 30 Mar 2001 15:18:27 -0800 (PST) (envelope-from brdavis@odin.ac.hmc.edu) Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.11.0/8.11.0) id f2UNI9W13235; Fri, 30 Mar 2001 15:18:09 -0800 Date: Fri, 30 Mar 2001 15:18:09 -0800 From: Brooks Davis To: Jordan Hubbard Cc: phk@FreeBSD.ORG, audit@FreeBSD.ORG, current@FreeBSD.ORG Subject: Re: Call for review... PR 25577 Message-ID: <20010330151809.B22598@Odin.AC.HMC.Edu> References: <22391.985986428@critter> <20010330131413I.jkh@osd.bsdi.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="VrqPEDrXMn8OVzN4" Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010330131413I.jkh@osd.bsdi.com>; from jkh@osd.bsdi.com on Fri, Mar 30, 2001 at 01:14:13PM -0800 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG --VrqPEDrXMn8OVzN4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 30, 2001 at 01:14:13PM -0800, Jordan Hubbard wrote: > Cool. Does this mean that any of the foocontrol programs can go away? > I've long wished that we could have some of the wireless control stuff > go directly into ifconfig rather than having to run an external > program before bringing up the interface. They won't go away, but 99.99% of people won't have to touch them. There are a number of vendor specific settings that I didn't attempt to build generic ioctl interfaces for, but you really don't need them most of the time. I'm planning to add some more features to the ioctl interface over time including the stuff necessicary to build generic version of the pretty GUI apps you get in Windows. As an extra bonus, this stuff should let you install with a floppy and a wireless nic. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --VrqPEDrXMn8OVzN4 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.4 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE6xRQwXY6L6fI4GtQRArfmAKCtNewElli27won4+LNOOAVmw7KEgCeME01 51QEjnagOcNTXTifSpCIRAg= =OUCm -----END PGP SIGNATURE----- --VrqPEDrXMn8OVzN4-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Fri Mar 30 15:51:36 2001 Delivered-To: freebsd-audit@freebsd.org Received: from bunrab.catwhisker.org (adsl-63-193-123-122.dsl.snfc21.pacbell.net [63.193.123.122]) by hub.freebsd.org (Postfix) with ESMTP id 0EF5637B719; Fri, 30 Mar 2001 15:51:31 -0800 (PST) (envelope-from david@catwhisker.org) Received: (from david@localhost) by bunrab.catwhisker.org (8.10.0/8.10.0) id f2UNpRo26499; Fri, 30 Mar 2001 15:51:27 -0800 (PST) Date: Fri, 30 Mar 2001 15:51:27 -0800 (PST) From: David Wolfskill Message-Id: <200103302351.f2UNpRo26499@bunrab.catwhisker.org> To: audit@FreeBSD.ORG, current@FreeBSD.ORG, phk@FreeBSD.ORG Subject: Re: Call for review... PR 25577 In-Reply-To: <22391.985986428@critter> Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG >From: Poul-Henning Kamp >Date: Fri, 30 Mar 2001 23:07:08 +0200 >Any comments/reviews before we commit the patch to PR25577 ? OK; I've built today's -CURRENT (this time, after applying Brooks' patchset; I had built -CURRENT earlier today). Here's a (slightly sanitized) ifconfig output: m758712358[1] ifconfig gif0: flags=8010 mtu 1280 gif1: flags=8010 mtu 1280 gif2: flags=8010 mtu 1280 gif3: flags=8010 mtu 1280 lo0: flags=8049 mtu 16384 inet6 fe80::1%lo0 prefixlen 64 scopeid 0x5 inet6 ::1 prefixlen 128 inet 127.0.0.1 netmask 0xff000000 ppp0: flags=8010 mtu 1500 faith0: flags=8000 mtu 1500 an0: flags=8843 mtu 1500 inet6 fe80::240:96ff:fe34:4ee9%an0 prefixlen 64 scopeid 0x8 inet 207.76.207.214 netmask 0xffffff00 broadcast 207.76.207.255 ether 00:40:96:34:4e:e9 media: autoselect (DS/11Mbps) status: associated supported media: autoselect autoselect DS/11Mbps DS/11Mbps DS/5.5Mbps DS/5.5Mbps DS/2Mbps DS/2Mbps DS/1Mbps DS/1Mbps ssid stationname "" channel 6 authmode OPEN powersavemode OFF powersavesleep 200 wepmode OFF weptxkey 2 wepkey 1:64-bit m758712358[2] So I haven't got so far as to actually *use* the ifconfig capabilities to get the card configured -- I had already worked up a script to do that with ancontrol, and I wanted to get this out sooner than it would take me to re-work that. First, this looks very promising; I like the direction and the bulk of the implementation (from what I've seen so far). One concern, and this may well affect other NIC flavors, is the list of media types is a little annoying to parse. Hmmm... speaking Perl, I suppose it could be characterized as /^\s+supported media:(\s[\S+(\s)?)+$/ Nevertheless, I believe it would be a little easier to parse (both for people & simple scripts) if the separator before "" were different from the one between adjacent supported media. Or am I just being rather denser than usual? Thanks, david -- David H. Wolfskill david@catwhisker.org As a computing professional, I believe it would be unethical for me to advise, recommend, or support the use (save possibly for personal amusement) of any product that is or depends on any Microsoft product. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Fri Mar 30 16:35:36 2001 Delivered-To: freebsd-audit@freebsd.org Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by hub.freebsd.org (Postfix) with ESMTP id A753437B718; Fri, 30 Mar 2001 16:35:31 -0800 (PST) (envelope-from brdavis@odin.ac.hmc.edu) Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.11.0/8.11.0) id f2V0ZUk25585; Fri, 30 Mar 2001 16:35:30 -0800 Date: Fri, 30 Mar 2001 16:35:30 -0800 From: Brooks Davis To: David Wolfskill Cc: audit@FreeBSD.ORG, current@FreeBSD.ORG, phk@FreeBSD.ORG Subject: Re: Call for review... PR 25577 Message-ID: <20010330163530.A23549@Odin.AC.HMC.Edu> References: <22391.985986428@critter> <200103302351.f2UNpRo26499@bunrab.catwhisker.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="Nq2Wo0NMKNjxTN9z" Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200103302351.f2UNpRo26499@bunrab.catwhisker.org>; from david@catwhisker.org on Fri, Mar 30, 2001 at 03:51:27PM -0800 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG --Nq2Wo0NMKNjxTN9z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 30, 2001 at 03:51:27PM -0800, David Wolfskill wrote: > One concern, and this may well affect other NIC flavors, is the list of > media types is a little annoying to parse. Hmmm... speaking Perl, I > suppose it could be characterized as >=20 > /^\s+supported media:(\s[\S+(\s)?)+$/ > > Nevertheless, I believe it would be a little easier to parse (both for > people & simple scripts) if the separator before "" were > different from the one between adjacent supported media. > > Or am I just being rather denser than usual? No, you're entirely correct. However, this isn't my fault. ;-) The problem here is that our ifconfig's if_media support is really crappy. My proposed solution is to take the -m option from {Net,Open}BSD. Without the -m flag they don't display the supported media list. With it, they display it in a much cleaner manner with one possability per line. It's on my todo list though anyone else could deal with it as well. I figured this patch was big enough without adding a bunch of cleanups to it. As it stands, there is a cleanup of a bug that ment you could never see some mediaopt's in the supported list. Instead you'd see the same media type twice with not differences. Apparently no one actually uses mediaopts other then full-duplex. ;-) -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --Nq2Wo0NMKNjxTN9z Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.4 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE6xSZRXY6L6fI4GtQRAhypAKDGafbjih2bR3i60euj6nU0qx5ciQCfVDoo P/nJPpxBMAUQKXbOuVBZHPM= =oSRH -----END PGP SIGNATURE----- --Nq2Wo0NMKNjxTN9z-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Fri Mar 30 16:42:54 2001 Delivered-To: freebsd-audit@freebsd.org Received: from bunrab.catwhisker.org (adsl-63-193-123-122.dsl.snfc21.pacbell.net [63.193.123.122]) by hub.freebsd.org (Postfix) with ESMTP id 4F54837B718; Fri, 30 Mar 2001 16:42:49 -0800 (PST) (envelope-from david@catwhisker.org) Received: (from david@localhost) by bunrab.catwhisker.org (8.10.0/8.10.0) id f2V0gmo26654; Fri, 30 Mar 2001 16:42:48 -0800 (PST) Date: Fri, 30 Mar 2001 16:42:48 -0800 (PST) From: David Wolfskill Message-Id: <200103310042.f2V0gmo26654@bunrab.catwhisker.org> To: brooks@one-eyed-alien.net, david@catwhisker.org Subject: Re: Call for review... PR 25577 Cc: audit@FreeBSD.ORG, current@FreeBSD.ORG, phk@FreeBSD.ORG In-Reply-To: <20010330163530.A23549@Odin.AC.HMC.Edu> Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG >Date: Fri, 30 Mar 2001 16:35:30 -0800 >From: Brooks Davis >> Or am I just being rather denser than usual? >No, you're entirely correct. However, this isn't my fault. ;-).... OK; fair enough (and thanks for the reality check). :-} So far, it (the patchset) seems to not break anything (which is a moderately nice characteristic), and it looks to have some very useful capabilities. And yes, I think you (Broooks) are correct in judging that the -m (for displaying the mediaopts, and then one per line) is probably better for a separate patch. I'll try to spend some more time with it over the weekend, but I certainly see no objection to committing it as it stands presently. I *may* try it out on -STABLE (not entirely altruism on my part; it would make my life simpler). Cheers, david -- David H. Wolfskill david@catwhisker.org As a computing professional, I believe it would be unethical for me to advise, recommend, or support the use (save possibly for personal amusement) of any product that is or depends on any Microsoft product. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Fri Mar 30 16:48:26 2001 Delivered-To: freebsd-audit@freebsd.org Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by hub.freebsd.org (Postfix) with ESMTP id 9F1DB37B719; Fri, 30 Mar 2001 16:48:21 -0800 (PST) (envelope-from brdavis@odin.ac.hmc.edu) Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.11.0/8.11.0) id f2V0mGA27752; Fri, 30 Mar 2001 16:48:16 -0800 Date: Fri, 30 Mar 2001 16:48:15 -0800 From: Brooks Davis To: David Wolfskill Cc: audit@FreeBSD.ORG, current@FreeBSD.ORG, phk@FreeBSD.ORG Subject: Re: Call for review... PR 25577 Message-ID: <20010330164815.A26890@Odin.AC.HMC.Edu> References: <20010330163530.A23549@Odin.AC.HMC.Edu> <200103310042.f2V0gmo26654@bunrab.catwhisker.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="x+6KMIRAuhnl3hBn" Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200103310042.f2V0gmo26654@bunrab.catwhisker.org>; from david@catwhisker.org on Fri, Mar 30, 2001 at 04:42:48PM -0800 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG --x+6KMIRAuhnl3hBn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 30, 2001 at 04:42:48PM -0800, David Wolfskill wrote: > I'll try to spend some more time with it over the weekend, but I > certainly see no objection to committing it as it stands presently. > I *may* try it out on -STABLE (not entirely altruism on my part; it > would make my life simpler). If anyone wants to try it one -stable, there's a patch against it at: http://www.one-eyed-alien.net/~brooks/FreeBSD/ifconfig.diff-stable The fact that wi hasn't been repo-copied in to sys/dev in stable plus the spl->mutex changes mean the patches against -current don't apply cleanly. The patches work great for me under -stable with a Lucent (wi) card, but I couldn't get my Cisco (an) card to work with or without them. It's probably something to do with the ancient pile of junk I'm using for stable laptop testing. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --x+6KMIRAuhnl3hBn Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.4 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE6xSlPXY6L6fI4GtQRAvgoAKDevxdU9hOmDqmsXbMpjLHPhdFhYACg3zzv uFtyM0pgdp/6Bql5DZTU6mA= =4owK -----END PGP SIGNATURE----- --x+6KMIRAuhnl3hBn-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sat Mar 31 1:16:51 2001 Delivered-To: freebsd-audit@freebsd.org Received: from mta05-svc.ntlworld.com (mta05-svc.ntlworld.com [62.253.162.45]) by hub.freebsd.org (Postfix) with ESMTP id 9940837B719; Sat, 31 Mar 2001 01:16:47 -0800 (PST) (envelope-from dmlb@dmlb.org) Received: from dmlb.org ([62.253.135.104]) by mta05-svc.ntlworld.com (InterMail vM.4.01.02.27 201-229-119-110) with ESMTP id <20010331091646.WYLD272.mta05-svc.ntlworld.com@dmlb.org>; Sat, 31 Mar 2001 10:16:46 +0100 Received: from dmlb by dmlb.org with local (Exim 3.03 #1) id 14jHUz-0001wC-00; Sat, 31 Mar 2001 10:16:45 +0100 Message-ID: X-Mailer: XFMail 1.3 [p0] on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20010330151809.B22598@Odin.AC.HMC.Edu> Date: Sat, 31 Mar 2001 10:16:44 +0100 (BST) From: Duncan Barclay To: Brooks Davis Subject: Re: Call for review... PR 25577 Cc: current@FreeBSD.ORG, audit@FreeBSD.ORG, phk@FreeBSD.ORG, Jordan Hubbard Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Hi Brooks, Can I suggest you add a DS22 for DS 22Mb/s which is going through final approvals at the IEEE. I'll wait for these patches to settle down and merge the functionality into the raylink driver. Are you planning on making a unified interface for things like the signal strenght cache? Duncan -- ________________________________________________________________________ Duncan Barclay | God smiles upon the little children, dmlb@dmlb.org | the alcoholics, and the permanently stoned. dmlb@freebsd.org| Steven King To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sat Mar 31 6:56:28 2001 Delivered-To: freebsd-audit@freebsd.org Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by hub.freebsd.org (Postfix) with ESMTP id AF04137B718; Sat, 31 Mar 2001 06:56:23 -0800 (PST) (envelope-from brdavis@odin.ac.hmc.edu) Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.11.0/8.11.0) id f2VEuJA28558; Sat, 31 Mar 2001 06:56:19 -0800 Date: Sat, 31 Mar 2001 06:56:19 -0800 From: Brooks Davis To: Duncan Barclay Cc: current@FreeBSD.ORG, audit@FreeBSD.ORG, phk@FreeBSD.ORG, Jordan Hubbard Subject: Re: Call for review... PR 25577 Message-ID: <20010331065619.A27505@Odin.AC.HMC.Edu> References: <20010330151809.B22598@Odin.AC.HMC.Edu> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="2oS5YaxWCcQjTEyO" Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from dmlb@dmlb.org on Sat, Mar 31, 2001 at 10:16:44AM +0100 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG --2oS5YaxWCcQjTEyO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 31, 2001 at 10:16:44AM +0100, Duncan Barclay wrote: > Can I suggest you add a DS22 for DS 22Mb/s which is going through final > approvals at the IEEE. I've added it and updated the diff for -current. I'll mess with the -stable diff Thursday when I get back from my short vacation. > I'll wait for these patches to settle down and merge the functionality > into the raylink driver. Sounds good. We'll need to figure out how to specify hopsets. You can either overload channel or add a new hopset option. > Are you planning on making a unified interface for things like the signal > strenght cache? I'm not sure at this point. It's probalby a good idea, though it may be to expensive to populate on interfaces. For instance, the an driver only sets one of the three possible values. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --2oS5YaxWCcQjTEyO Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.4 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE6xfASXY6L6fI4GtQRAiAoAKCRs010k50laPweFlEbGBO0fJ40GgCdFVH0 D3zTpiMtdwyS/us0vGrDUDM= =3DKM -----END PGP SIGNATURE----- --2oS5YaxWCcQjTEyO-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sat Mar 31 22:39:14 2001 Delivered-To: freebsd-audit@freebsd.org Received: from sj-msg-core-4.cisco.com (sj-msg-core-4.cisco.com [171.71.163.10]) by hub.freebsd.org (Postfix) with ESMTP id 4A3FF37B718; Sat, 31 Mar 2001 22:39:08 -0800 (PST) (envelope-from bmah@cisco.com) Received: from bmah-freebsd-0.cisco.com (bmah-freebsd-0.cisco.com [171.70.84.42]) by sj-msg-core-4.cisco.com (8.9.3/8.9.1) with ESMTP id WAA14214; Sat, 31 Mar 2001 22:38:47 -0800 (PST) Received: (from bmah@localhost) by bmah-freebsd-0.cisco.com (8.11.3/8.11.1) id f316cdD83408; Sat, 31 Mar 2001 22:38:39 -0800 (PST) (envelope-from bmah) Message-Id: <200104010638.f316cdD83408@bmah-freebsd-0.cisco.com> X-Mailer: exmh version 2.3.1 01/19/2001 with nmh-1.0.4 To: Poul-Henning Kamp Cc: Jordan Hubbard , audit@FreeBSD.ORG, current@FreeBSD.ORG Subject: Re: Call for review... PR 25577 In-Reply-To: <22564.985987216@critter> References: <22564.985987216@critter> Comments: In-reply-to Poul-Henning Kamp message dated "Fri, 30 Mar 2001 23:20:16 +0200." From: "Bruce A. Mah" Reply-To: bmah@FreeBSD.ORG X-Face: g~c`.{#4q0"(V*b#g[i~rXgm*w;:nMfz%_RZLma)UgGN&=j`5vXoU^@n5v4:OO)c["!w)nD/!!~e4Sj7LiT'6*wZ83454H""lb{CC%T37O!!'S$S&D}sem7I[A 2V%N&+ X-Image-Url: http://www.employees.org/~bmah/Images/bmah-cisco-small.gif X-Url: http://www.employees.org/~bmah/ Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==_Exmh_1727279998P"; micalg=pgp-sha1; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit Date: Sat, 31 Mar 2001 22:38:39 -0800 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG --==_Exmh_1727279998P Content-Type: text/plain; charset=us-ascii If memory serves me right, Poul-Henning Kamp wrote: > In message <20010330131413I.jkh@osd.bsdi.com>, Jordan Hubbard writes: > >Cool. Does this mean that any of the foocontrol programs can go away? > > As far as I can see, anything short of firmware updates can be > done by ifconfig and therefore, presumably, foocontrol can die > for 802.11-valued foo. Uhhh...I don't think this is quite true. I'm not an expert on the an(4) driver, but ancontrol -S and ancontrol -C give a lot more information that the new ifconfig, and I'm pretty sure that ancontrol (8) lets you twiddle things that ifconfig doesn't. (Antenna diversity and transmit power spring to mind, also it is not immediately obvious to me how to set ad-hoc mode using ifconfig(8)). I think that a *majority* of functionality can be done with ifconfig, and that someone would only need to use ancontrol if they really wanted to do something esoteric (or at least unusual). More comments to come...I'm typing up some feedback based on playing with the -stable version. Bruce. --==_Exmh_1727279998P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.4 (FreeBSD) Comment: Exmh version 2.2 06/23/2000 iD8DBQE6xszv2MoxcVugUsMRArtKAJ0SkqTIjYLBsp6EpJkxy3lAWZhw6QCgk2Md VsbZNPl2k6Fel+lR0+VxM5A= =lSnw -----END PGP SIGNATURE----- --==_Exmh_1727279998P-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sat Mar 31 22:43:35 2001 Delivered-To: freebsd-audit@freebsd.org Received: from sj-msg-core-2.cisco.com (sj-msg-core-2.cisco.com [171.69.43.88]) by hub.freebsd.org (Postfix) with ESMTP id ECF1637B719; Sat, 31 Mar 2001 22:43:29 -0800 (PST) (envelope-from bmah@cisco.com) Received: from bmah-freebsd-0.cisco.com (bmah-freebsd-0.cisco.com [171.70.84.42]) by sj-msg-core-2.cisco.com (8.9.3/8.9.1) with ESMTP id WAA09014; Sat, 31 Mar 2001 22:43:48 -0800 (PST) Received: (from bmah@localhost) by bmah-freebsd-0.cisco.com (8.11.3/8.11.1) id f316hPr83541; Sat, 31 Mar 2001 22:43:25 -0800 (PST) (envelope-from bmah) Message-Id: <200104010643.f316hPr83541@bmah-freebsd-0.cisco.com> X-Mailer: exmh version 2.3.1 01/19/2001 with nmh-1.0.4 To: Poul-Henning Kamp , Jordan Hubbard , audit@FreeBSD.ORG, current@FreeBSD.ORG Cc: bmah@FreeBSD.ORG Subject: Re: Call for review... PR 25577 In-Reply-To: <200104010638.f316cdD83408@bmah-freebsd-0.cisco.com> References: <22564.985987216@critter> <200104010638.f316cdD83408@bmah-freebsd-0.cisco.com> Comments: In-reply-to "Bruce A. Mah" message dated "Sat, 31 Mar 2001 22:38:39 -0800." From: "Bruce A. Mah" Reply-To: bmah@FreeBSD.ORG X-Face: g~c`.{#4q0"(V*b#g[i~rXgm*w;:nMfz%_RZLma)UgGN&=j`5vXoU^@n5v4:OO)c["!w)nD/!!~e4Sj7LiT'6*wZ83454H""lb{CC%T37O!!'S$S&D}sem7I[A 2V%N&+ X-Image-Url: http://www.employees.org/~bmah/Images/bmah-cisco-small.gif X-Url: http://www.employees.org/~bmah/ Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==_Exmh_1767685066P"; micalg=pgp-sha1; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit Date: Sat, 31 Mar 2001 22:43:25 -0800 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG --==_Exmh_1767685066P Content-Type: text/plain; charset=us-ascii I stupidly wrote: > it is not immediately obvious to me how to > set ad-hoc mode using ifconfig(8)). Please disregard...I see it now. Must be my allergy meds, yeah, that's it... :-) Bruce. --==_Exmh_1767685066P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.4 (FreeBSD) Comment: Exmh version 2.2 06/23/2000 iD8DBQE6xs4N2MoxcVugUsMRAijeAKDn0PznxkG15yv7jyd+lcrwk/5g0wCbBAkl giXteaovEkO3pcIH9ZTfkR8= =PoRo -----END PGP SIGNATURE----- --==_Exmh_1767685066P-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message From owner-freebsd-audit Sat Mar 31 22:50: 7 2001 Delivered-To: freebsd-audit@freebsd.org Received: from sj-msg-core-1.cisco.com (sj-msg-core-1.cisco.com [171.71.163.11]) by hub.freebsd.org (Postfix) with ESMTP id 5669B37B719; Sat, 31 Mar 2001 22:49:57 -0800 (PST) (envelope-from bmah@cisco.com) Received: from bmah-freebsd-0.cisco.com (bmah-freebsd-0.cisco.com [171.70.84.42]) by sj-msg-core-1.cisco.com (8.9.3/8.9.1) with ESMTP id WAA08667; Sat, 31 Mar 2001 22:49:44 -0800 (PST) Received: (from bmah@localhost) by bmah-freebsd-0.cisco.com (8.11.3/8.11.1) id f316nix83661; Sat, 31 Mar 2001 22:49:44 -0800 (PST) (envelope-from bmah) Message-Id: <200104010649.f316nix83661@bmah-freebsd-0.cisco.com> X-Mailer: exmh version 2.3.1 01/19/2001 with nmh-1.0.4 To: Brooks Davis Cc: David Wolfskill , audit@FreeBSD.ORG, current@FreeBSD.ORG, phk@FreeBSD.ORG Subject: Re: Call for review... PR 25577 In-Reply-To: <20010330164815.A26890@Odin.AC.HMC.Edu> References: <20010330163530.A23549@Odin.AC.HMC.Edu> <200103310042.f2V0gmo26654@bunrab.catwhisker.org> <20010330164815.A26890@Odin.AC.HMC.Edu> Comments: In-reply-to Brooks Davis message dated "Fri, 30 Mar 2001 16:48:15 -0800." From: "Bruce A. Mah" Reply-To: bmah@FreeBSD.ORG X-Face: g~c`.{#4q0"(V*b#g[i~rXgm*w;:nMfz%_RZLma)UgGN&=j`5vXoU^@n5v4:OO)c["!w)nD/!!~e4Sj7LiT'6*wZ83454H""lb{CC%T37O!!'S$S&D}sem7I[A 2V%N&+ X-Image-Url: http://www.employees.org/~bmah/Images/bmah-cisco-small.gif X-Url: http://www.employees.org/~bmah/ Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==_Exmh_1819147488P"; micalg=pgp-sha1; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit Date: Sat, 31 Mar 2001 22:49:44 -0800 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG --==_Exmh_1819147488P Content-Type: text/plain; charset=us-ascii If memory serves me right, Brooks Davis wrote: > If anyone wants to try it one -stable, there's a patch against it at: > > http://www.one-eyed-alien.net/~brooks/FreeBSD/ifconfig.diff-stable Cool, thanks for making this available. > The fact that wi hasn't been repo-copied in to sys/dev in stable plus > the spl->mutex changes mean the patches against -current don't apply > cleanly. The patches work great for me under -stable with a Lucent (wi) > card, but I couldn't get my Cisco (an) card to work with or without > them. It's probably something to do with the ancient pile of junk I'm > using for stable laptop testing. I just re-built world with your patches on an IBM T20 with a Cisco Aironet 342 PCMCIA card. Basic send and receive seem OK, I used the new ifconfig to turn on WEP and set the SSID and I am now typing over the an0 interface to send this mail. Few comments here: 1. Seems like I needed to ifconfig the interface up before my other commands would take effect. I don't recall needing to do any such thing with the old driver before I could do ancontrol. Is this a change in behavior or did I miss something? 2. I think there is an off-by-one error in the listing of wepkeys. I have exactly one 128-bit key set, which I'm using as the transmit key. I'm pretty sure that this is key was configured as number 3 (if starting from 1) or 2 (if starting from 0). I'm not using any of the other four keys supported, but I do not know their exact configurations. "ifconfig an0" returns (santized): constellation:bmah% ifconfig an0 an0: flags=8843 mtu 1500 inet6 fe80::XX:XX:XX:XX%an0 prefixlen 64 scopeid 0x5 inet XX.XX.XX.XX netmask 0xffffff00 broadcast XX.XX.XX.XX inet6 fec0::XX:XX:XX:XX: prefixlen 64 ether XX:XX:XX:XX:XX:XX media: autoselect (DS/11Mbps) status: associated supported media: autoselect autoselect DS/11Mbps DS/11Mbps DS/5.5Mbps DS/5.5Mbps DS/2Mbps DS/2Mbps DS/1Mbps DS/1Mbps ssid XXX stationname "" channel 6 authmode OPEN powersavemode OFF powersavesleep 200 wepmode ON weptxkey 3 wepkey 1:64-bit wepkey 2:128-bit wepkey 3:64-bit Just for the record, I think there's a similar problem in ancontrol(8). The tail of "ancontrol -C" is: WEP Key status: Key 0 is set 40 bits Key 1 is set 128 bits Key 2 is set 40 bits Key 3 is unset The active transmit key is 2 If I had to guess, I'd say that if there is an array of WEP keys, the programs are starting to read one key too late into the array when they display them. There also seems to be a little disagreement as to whether keys are numbered starting from 0 or 1. I did all the key management from within Windows 2000, using the Cisco-supplied utilities. If it's helpful, I can reboot and take some notes from that side. 3. In the "SEE ALSO" section of ieee80211, there is a hanging comma after the cross-reference to wicontrol(8). Thanks for taking the time to do a -STABLE patch...much appreciated. Bruce. --==_Exmh_1819147488P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.4 (FreeBSD) Comment: Exmh version 2.2 06/23/2000 iD8DBQE6xs+I2MoxcVugUsMRArtpAKC38c8XmMPyVIpGj3DedO27Fz6ZKgCggJE8 VvL9wvShDGPvczIiXK/tSgI= =yN5I -----END PGP SIGNATURE----- --==_Exmh_1819147488P-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message