From owner-freebsd-audit@FreeBSD.ORG Sat Apr 12 06:59:19 2003 Return-Path: Delivered-To: freebsd-audit@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 88EE037B401; Sat, 12 Apr 2003 06:59:19 -0700 (PDT) Received: from numeri.campus.luth.se (numeri.campus.luth.se [130.240.197.103]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4D75043FA3; Sat, 12 Apr 2003 06:59:18 -0700 (PDT) (envelope-from k@numeri.campus.luth.se) Received: from numeri.campus.luth.se (localhost [127.0.0.1]) by numeri.campus.luth.se (8.12.9/8.12.9) with ESMTP id h3CDxHEm011980; Sat, 12 Apr 2003 15:59:17 +0200 (CEST) (envelope-from k@numeri.campus.luth.se) Received: (from k@localhost) by numeri.campus.luth.se (8.12.9/8.12.9/Submit) id h3CDxGgB011979; Sat, 12 Apr 2003 15:59:16 +0200 (CEST) Date: Sat, 12 Apr 2003 15:59:16 +0200 From: Johan Karlsson To: sos@freebsd.org, FreeBSD-audit Message-ID: <20030412135916.GA11752@numeri.campus.luth.se> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="wac7ysb48OaltWcw" Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.4i cc: sheldonh@freebsd.org Subject: makeing atacontrol WARNS=2 clean. X-BeenThere: freebsd-audit@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: FreeBSD Security Audit List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Apr 2003 13:59:19 -0000 --wac7ysb48OaltWcw Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit Hi Søren and others. I intend to commit this patch to make atacontrol WARNS=2 clean. I hope it's ok with you. /Johan K -- Johan Karlsson mailto:johan@FreeBSD.org --wac7ysb48OaltWcw Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="atacontrol.diff" Index: atacontrol/Makefile =================================================================== RCS file: /home/ncvs/src/sbin/atacontrol/Makefile,v retrieving revision 1.6 diff -u -r1.6 Makefile --- atacontrol/Makefile 4 Dec 2001 02:19:43 -0000 1.6 +++ atacontrol/Makefile 10 Apr 2003 17:59:19 -0000 @@ -1,7 +1,6 @@ #$FreeBSD: src/sbin/atacontrol/Makefile,v 1.6 2001/12/04 02:19:43 obrien Exp $ PROG= atacontrol -WARNS= 0 MAN= atacontrol.8 .include Index: atacontrol/atacontrol.c =================================================================== RCS file: /home/ncvs/src/sbin/atacontrol/atacontrol.c,v retrieving revision 1.20 diff -u -r1.20 atacontrol.c --- atacontrol/atacontrol.c 22 Mar 2003 12:18:20 -0000 1.20 +++ atacontrol/atacontrol.c 24 Mar 2003 13:22:07 -0000 @@ -30,6 +30,7 @@ #include #include +#include #include #include @@ -137,7 +138,7 @@ printf("lba48%ssupported ", parm->support.address48 ? " " : " not "); if (lbasize48) - printf("%lld sectors\n", lbasize48); + printf("%ju sectors\n", (uintmax_t)lbasize48); else printf("\n"); --wac7ysb48OaltWcw-- From owner-freebsd-audit@FreeBSD.ORG Sat Apr 12 07:11:47 2003 Return-Path: Delivered-To: freebsd-audit@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BD91F37B401; Sat, 12 Apr 2003 07:11:47 -0700 (PDT) Received: from smtp01.syd.iprimus.net.au (smtp01.syd.iprimus.net.au [210.50.30.52]) by mx1.FreeBSD.org (Postfix) with ESMTP id 326E443F75; Sat, 12 Apr 2003 07:11:47 -0700 (PDT) (envelope-from tim@robbins.dropbear.id.au) Received: from dilbert.robbins.dropbear.id.au (203.134.134.181) by smtp01.syd.iprimus.net.au (7.0.012) id 3E96D1D200026F3A; Sun, 13 Apr 2003 00:11:45 +1000 Received: by dilbert.robbins.dropbear.id.au (Postfix, from userid 1000) id 5F0BBB4CD; Sun, 13 Apr 2003 00:11:23 +1000 (EST) Date: Sun, 13 Apr 2003 00:11:23 +1000 From: Tim Robbins To: Johan Karlsson Message-ID: <20030413001123.A4544@dilbert.robbins.dropbear.id.au> References: <20030412135916.GA11752@numeri.campus.luth.se> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.2.5.1i In-Reply-To: <20030412135916.GA11752@numeri.campus.luth.se>; from johan@freebsd.org on Sat, Apr 12, 2003 at 03:59:16PM +0200 cc: FreeBSD-audit cc: sheldonh@freebsd.org cc: sos@freebsd.org Subject: Re: makeing atacontrol WARNS=2 clean. X-BeenThere: freebsd-audit@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: FreeBSD Security Audit List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Apr 2003 14:11:48 -0000 On Sat, Apr 12, 2003 at 03:59:16PM +0200, Johan Karlsson wrote: > Hi Søren and others. > > I intend to commit this patch to make atacontrol WARNS=2 clean. > > I hope it's ok with you. [...] > .include > Index: atacontrol/atacontrol.c > =================================================================== > RCS file: /home/ncvs/src/sbin/atacontrol/atacontrol.c,v > retrieving revision 1.20 > diff -u -r1.20 atacontrol.c > --- atacontrol/atacontrol.c 22 Mar 2003 12:18:20 -0000 1.20 > +++ atacontrol/atacontrol.c 24 Mar 2003 13:22:07 -0000 > @@ -30,6 +30,7 @@ > > #include > #include > +#include > > #include > #include It would be better to use here, even though it is exactly the same as . Tim From owner-freebsd-audit@FreeBSD.ORG Sat Apr 12 07:25:09 2003 Return-Path: Delivered-To: freebsd-audit@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C439037B401; Sat, 12 Apr 2003 07:25:09 -0700 (PDT) Received: from numeri.campus.luth.se (numeri.campus.luth.se [130.240.197.103]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7D87A43F93; Sat, 12 Apr 2003 07:25:08 -0700 (PDT) (envelope-from k@numeri.campus.luth.se) Received: from numeri.campus.luth.se (localhost [127.0.0.1]) by numeri.campus.luth.se (8.12.9/8.12.9) with ESMTP id h3CEP7Em012798; Sat, 12 Apr 2003 16:25:07 +0200 (CEST) (envelope-from k@numeri.campus.luth.se) Received: (from k@localhost) by numeri.campus.luth.se (8.12.9/8.12.9/Submit) id h3CEP7t4012797; Sat, 12 Apr 2003 16:25:07 +0200 (CEST) Date: Sat, 12 Apr 2003 16:25:07 +0200 From: Johan Karlsson To: Tim Robbins Message-ID: <20030412142507.GB11752@numeri.campus.luth.se> References: <20030412135916.GA11752@numeri.campus.luth.se> <20030413001123.A4544@dilbert.robbins.dropbear.id.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030413001123.A4544@dilbert.robbins.dropbear.id.au> User-Agent: Mutt/1.4i cc: FreeBSD-audit cc: sheldonh@FreeBSD.ORG cc: sos@FreeBSD.ORG Subject: Re: makeing atacontrol WARNS=2 clean. X-BeenThere: freebsd-audit@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: FreeBSD Security Audit List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Apr 2003 14:25:10 -0000 On Sun, Apr 13, 2003 at 00:11 (+1000) +0000, Tim Robbins wrote: > > Index: atacontrol/atacontrol.c > > =================================================================== > > RCS file: /home/ncvs/src/sbin/atacontrol/atacontrol.c,v > > retrieving revision 1.20 > > diff -u -r1.20 atacontrol.c > > --- atacontrol/atacontrol.c 22 Mar 2003 12:18:20 -0000 1.20 > > +++ atacontrol/atacontrol.c 24 Mar 2003 13:22:07 -0000 > > @@ -30,6 +30,7 @@ > > > > #include > > #include > > +#include > > > > #include > > #include > > It would be better to use here, even though it is exactly the same > as . Ok, I'll take your word for it :-) /Johan K > > > Tim -- Johan Karlsson mailto:johan@FreeBSD.org