From owner-freebsd-bugs Wed Jan 1 0:16:41 2003 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5D04037B401; Wed, 1 Jan 2003 00:16:40 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0BF7843ED1; Wed, 1 Jan 2003 00:16:40 -0800 (PST) (envelope-from maxim@FreeBSD.org) Received: from freefall.freebsd.org (maxim@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id h018GdNS025260; Wed, 1 Jan 2003 00:16:39 -0800 (PST) (envelope-from maxim@freefall.freebsd.org) Received: (from maxim@localhost) by freefall.freebsd.org (8.12.6/8.12.6/Submit) id h018GYve025256; Wed, 1 Jan 2003 00:16:34 -0800 (PST) Date: Wed, 1 Jan 2003 00:16:34 -0800 (PST) From: Maxim Konovalov Message-Id: <200301010816.h018GYve025256@freefall.freebsd.org> To: matt@gsicomp.on.ca, maxim@FreeBSD.org, freebsd-bugs@FreeBSD.org Subject: Re: kern/45637: wi0 device_probe_and_attach returns 6 Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Synopsis: wi0 device_probe_and_attach returns 6 State-Changed-From-To: open->closed State-Changed-By: maxim State-Changed-When: Wed Jan 1 00:15:55 PST 2003 State-Changed-Why: Closed at the submitters' request. http://www.freebsd.org/cgi/query-pr.cgi?pr=45637 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message From owner-freebsd-bugs Wed Jan 1 6:29:38 2003 Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1B5DA37B405 for ; Wed, 1 Jan 2003 06:29:36 -0800 (PST) Received: from web21108.mail.yahoo.com (web21108.mail.yahoo.com [216.136.227.110]) by mx1.FreeBSD.org (Postfix) with SMTP id 8684143EC2 for ; Wed, 1 Jan 2003 06:29:35 -0800 (PST) (envelope-from hitmaster2k@yahoo.com) Message-ID: <20030101142935.910.qmail@web21108.mail.yahoo.com> Received: from [62.254.0.6] by web21108.mail.yahoo.com via HTTP; Wed, 01 Jan 2003 06:29:35 PST Date: Wed, 1 Jan 2003 06:29:35 -0800 (PST) From: Hiten Pandya Reply-To: hiten@uk.FreeBSD.org Subject: Re: i386/46222: CPU speed incorrectly reported To: hubert@tournier.org, David Malone Cc: freebsd-bugs@FreeBSD.org In-Reply-To: <3E0C71B4.3000003@online.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org --- Hubert Tournier wrote: > >Synopsis: CPU speed incorrectly reported > >State-Changed-From-To: open->feedback > >State-Changed-By: dwmalone > >State-Changed-When: Mon Dec 23 02:57:24 PST 2002 > >http://www.freebsd.org/cgi/query-pr.cgi?pr=46222 > > Hello David and thanks for your answer ! > > >The speed of the CPU is actually measured by seeing how many > >instructions are executed in an interval measured by the real time > >timer. This suggests that either your CPU is running slow or the > >timer is running fast. > >The CPU could be running slow because of APM or ACPI settings > >reducing power consumption by slowing the CPU. Can you look into > >this possibility? > > After modifying the hardware BIOS setup from > "Battery Save Mode = Low Power" to "Full Power" > instead of getting : > > Timecounter "TSC" frequency 184530035 Hz > CPU: Pentium II/Pentium II Xeon/Celeron (184.53-MHz 686-class CPU) > > I get the correct answer: > > Timecounter "TSC" frequency 366597251 Hz > CPU: Pentium II/Pentium II Xeon/Celeron (366.60-MHz 686-class CPU) > > The strange things are: > > 1) that I'm not running on battery but on AC power so (if I understand > correctly) this setting should not be relevant > 2) that with the same hardware settings (if my memory doesn't play tricks > on me), the FreeBSD 4.7-RELEASE previously installed on this machine > reported the correct speed > > Perhaps the ACPI code doesn't detect that the laptop is running on AC > power ? > > In either BIOS settings, after booting sysctl said and now says that the > machine is running at full speed : > > hw.acpi.cpu.max_speed: 8 > hw.acpi.cpu.current_speed: 8 > hw.acpi.cpu.performance_speed: 8 > hw.acpi.cpu.economy_speed: 4 > > But it the first case, perhaps it was at full half-speed :-) > > PS: I'm not running the APM daemon and my kernel does not include > "device apm". > > Have a nice day ! I think this should be FAQ Entry; because this happens with some Compaq Laptops. That is, the CPU Speed is reported lower when running in battery (power-saving) mode and vice versa. -- Hiten __________________________________________________ Do you Yahoo!? Yahoo! Mail Plus - Powerful. Affordable. Sign up now. http://mailplus.yahoo.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message From owner-freebsd-bugs Wed Jan 1 11:50: 3 2003 Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2475937B401; Wed, 1 Jan 2003 11:49:59 -0800 (PST) Received: from rhadamanth.submonkey.net (pc1-cdif2-5-cust47.cdif.cable.ntl.com [81.101.150.47]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9285943E4A; Wed, 1 Jan 2003 11:49:58 -0800 (PST) (envelope-from setantae@submonkey.net) Received: from setantae by rhadamanth.submonkey.net with local (Exim 4.10) id 18TosH-0006Sr-00; Wed, 01 Jan 2003 19:49:57 +0000 Date: Wed, 1 Jan 2003 19:49:57 +0000 From: Ceri Davies To: FreeBSD bugmaster Cc: FreeBSD bugs list Subject: Re: open PR's (mis)filed to gnats-admin and in limbo Message-ID: <20030101194957.GA20425@submonkey.net> Mail-Followup-To: Ceri Davies , FreeBSD bugmaster , FreeBSD bugs list References: <200212301900.gBUJ0Usl070959@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200212301900.gBUJ0Usl070959@freefall.freebsd.org> X-message-flag: All your linuxconf-configured redhat are belong to us. X-message-flag-attribution: suresh, sdm. User-Agent: Mutt/1.5.1i Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Mon, Dec 30, 2002 at 11:00:30AM -0800, FreeBSD bugmaster wrote: > Current FreeBSD problem reports > Critical problems > Serious problems > > S Submitted Tracker Resp. Description > ------------------------------------------------------------------------------- > o [2002/12/20] pending/46400gnats-adminRe: Update of devel/subversion > o [2002/12/23] pending/46509gnats-adminRe: PR kern/46004 > o [2002/12/26] pending/46542gnats-adminRe: Inadequate validity checking on args > o [2002/12/26] pending/46550gnats-adminRe: Update port: sysutils/thefish to 0.2. > o [2002/12/30] pending/46631gnats-adminRe: unbreak audio/lame-devel for -CURRENT > o [2002/12/30] pending/46632gnats-adminRe: unbreak audio/lame-devel for -CURRENT All fixed. Ceri -- The courageous steel is nigh! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message From owner-freebsd-bugs Wed Jan 1 11:50:14 2003 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CF82237B407 for ; Wed, 1 Jan 2003 11:50:11 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id EC26243ED8 for ; Wed, 1 Jan 2003 11:50:09 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id h01Jo9NS025289 for ; Wed, 1 Jan 2003 11:50:09 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.6/8.12.6/Submit) id h01Jo9Pr025280; Wed, 1 Jan 2003 11:50:09 -0800 (PST) Date: Wed, 1 Jan 2003 11:50:09 -0800 (PST) Message-Id: <200301011950.h01Jo9Pr025280@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: Ceri Davies Subject: Re: bin/46533: Inadequate validity checking on args to tcsh builtin 'kill' Reply-To: Ceri Davies Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org The following reply was made to PR bin/46533; it has been noted by GNATS. From: Ceri Davies To: FreeBSD Gnats Submit Cc: Subject: Re: bin/46533: Inadequate validity checking on args to tcsh builtin 'kill' Date: Wed, 1 Jan 2003 19:49:00 +0000 Adding to audit trail; obtained from misfiled PR 46542: On Thu, Dec 26, 2002 at 06:48:51AM -0500, Christos Zoulas wrote: > On Dec 26, 3:40pm, peterjeremy@optushome.com.au (Peter Jeremy) wrote: > -- Subject: Inadequate validity checking on args to tcsh builtin 'kill' > > Thanks, I'll put it in. > > christos > > | > | >Submitter-Id: current-users > | >Originator: Peter Jeremy > | >Organization: n/a > | >Confidential: no > | >Synopsis: Inadequate validity checking on args to tcsh builtin 'kill' > | >Severity: serious > | >Priority: low > | >Category: bin > | >Class: sw-bug > | >Release: FreeBSD 4.7-PRERELEASE i386 > | >Environment: > | System: FreeBSD server.c18609.belrs1.nsw.optusnet.com.au 4.7-PRERELEASE FreeBSD 4.7-PRERELEASE #4: Sat Sep 14 15:07:16 EST 2002 root@server.c18609.belrs1.nsw.optusnet.com.au:/usr/obj/usr/src/sys/server i386 > | > | tcsh: $Id: sh.proc.c,v 3.76 2002/03/08 17:36:46 christos Exp $ > | > | >Description: > | The `kill' builtin in tcsh uses atoi(3) to parse numeric arguments > | (pids or signals). As long as an argument begins with a digit, > | it is treated as a valid number, even if it contains non-numeric > | characters. This bug does not exist in /bin/kill or zsh. > | >How-To-Repeat: > | I found the bug when I accidently entered > | # kill 1q5808 > | as root and found my remote shell (and the entire system) died. > | >Fix: > | Index: sh.proc.c > | =================================================================== > | RCS file: /usr/ncvs/src/contrib/tcsh/sh.proc.c,v > | retrieving revision 1.1.1.1.2.4 > | diff -u -r1.1.1.1.2.4 sh.proc.c > | --- sh.proc.c 10 Aug 2002 18:14:45 -0000 1.1.1.1.2.4 > | +++ sh.proc.c 26 Dec 2002 04:25:36 -0000 > | @@ -1536,6 +1536,7 @@ > | register int signum, len = 0; > | register char *name; > | Char *sigptr; > | + char *ep; > | extern int T_Cols; > | extern int nsig; > | > | @@ -1566,8 +1567,8 @@ > | } > | } > | if (Isdigit(*sigptr)) { > | - signum = atoi(short2str(sigptr)); > | - if (signum < 0 || signum > (MAXSIG-1)) > | + signum = strtol(short2str(sigptr), &ep, 10); > | + if (signum < 0 || signum > (MAXSIG-1) || *ep) > | stderror(ERR_NAME | ERR_BADSIG); > | } > | else { > | @@ -1598,6 +1599,7 @@ > | sigmask_t omask; > | #endif /* BSDSIGS */ > | Char *cp, **vp; > | + char *ep; > | > | #ifdef BSDSIGS > | omask = sigmask(SIGCHLD); > | @@ -1678,11 +1680,16 @@ > | stderror(ERR_NAME | ERR_JOBARGS); > | else { > | #ifndef WINNT_NATIVE > | - pid = atoi(short2str(cp)); > | + pid = strtol(short2str(cp), &ep, 10); > | #else > | - pid = strtoul(short2str(cp),NULL,0); > | + pid = strtoul(short2str(cp),&ep,0); > | #endif /* WINNT_NATIVE */ > | - if (kill(pid, signum) < 0) { > | + if (*ep) { > | + xprintf("%S: Badly formed number\n", cp); > | + err1++; > | + goto cont; > | + } > | + else if (kill(pid, signum) < 0) { > | xprintf("%d: %s\n", pid, strerror(errno)); > | err1++; > | goto cont; > -- End of excerpt from Peter Jeremy To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message From owner-freebsd-bugs Wed Jan 1 12:40: 7 2003 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4A8FB37B401 for ; Wed, 1 Jan 2003 12:40:05 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8A8A743E4A for ; Wed, 1 Jan 2003 12:40:03 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id h01Ke3NS049841 for ; Wed, 1 Jan 2003 12:40:03 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.6/8.12.6/Submit) id h01Ke3LJ049840; Wed, 1 Jan 2003 12:40:03 -0800 (PST) Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E939E37B401 for ; Wed, 1 Jan 2003 12:33:48 -0800 (PST) Received: from rwcrmhc52.attbi.com (rwcrmhc52.attbi.com [216.148.227.88]) by mx1.FreeBSD.org (Postfix) with ESMTP id 868F143EA9 for ; Wed, 1 Jan 2003 12:33:48 -0800 (PST) (envelope-from swear@attbi.com) Received: from localhost.localdomain ([12.242.158.67]) by rwcrmhc52.attbi.com (rwcrmhc52) with ESMTP id <2003010120334805200fhs23e>; Wed, 1 Jan 2003 20:33:48 +0000 Received: from localhost.localdomain (localhost [127.0.0.1]) by localhost.localdomain (8.12.6/8.12.6) with ESMTP id h01KaF8S019418 for ; Wed, 1 Jan 2003 12:36:16 -0800 (PST) (envelope-from swear@attbi.com) Received: (from jojo@localhost) by localhost.localdomain (8.12.6/8.12.6/Submit) id h01KYtZX019398; Wed, 1 Jan 2003 12:34:55 -0800 (PST) (envelope-from swear@attbi.com) Message-Id: <24lm241uds.m24@localhost.localdomain> Date: 01 Jan 2003 12:34:55 -0800 From: "Gary W. Swearingen" Reply-To: swear@attbi.com To: FreeBSD-gnats-submit@FreeBSD.org Subject: misc/46670: 5.0-RC2 install leaves CD drawer locked. Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org >Number: 46670 >Category: misc >Synopsis: 5.0-RC2 install leaves CD drawer locked. >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Jan 01 12:40:03 PST 2003 >Closed-Date: >Last-Modified: >Originator: Gary W. Swearingen >Release: FreeBSD 5.0-RC2 i386 >Organization: none >Environment: FreeBSD localhost.localdomain 5.0-CURRENT FreeBSD 5.0-CURRENT #0: Mon Dec 30 17:04:36 PST 2002 root@localhost.localdomain:/usr/obj/usr/src/sys/GENERIC i386 ================ >Description: At the end of a 5.0-RC2 install, the installer cautions the user to remove the CD from the CD drive, but it leaves the CD drive drawer locked so the CD cannot be removed until after the system starts rebooting but before it starts booting from the CD. ================ >How-To-Repeat: n/a ================ >Fix: Unknown. >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message From owner-freebsd-bugs Wed Jan 1 13: 0:17 2003 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8CAF837B401 for ; Wed, 1 Jan 2003 13:00:15 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id B10CB43EC5 for ; Wed, 1 Jan 2003 13:00:14 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id h01L0ENS054143 for ; Wed, 1 Jan 2003 13:00:14 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.6/8.12.6/Submit) id h01L0Eb7054142; Wed, 1 Jan 2003 13:00:14 -0800 (PST) Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3567B37B401 for ; Wed, 1 Jan 2003 12:56:38 -0800 (PST) Received: from rwcrmhc51.attbi.com (rwcrmhc51.attbi.com [204.127.198.38]) by mx1.FreeBSD.org (Postfix) with ESMTP id C618A43EA9 for ; Wed, 1 Jan 2003 12:56:37 -0800 (PST) (envelope-from swear@attbi.com) Received: from localhost.localdomain ([12.242.158.67]) by rwcrmhc51.attbi.com (rwcrmhc51) with ESMTP id <20030101205637051006jnf6e>; Wed, 1 Jan 2003 20:56:37 +0000 Received: from localhost.localdomain (localhost [127.0.0.1]) by localhost.localdomain (8.12.6/8.12.6) with ESMTP id h01Kwx8S019780 for ; Wed, 1 Jan 2003 12:59:05 -0800 (PST) (envelope-from swear@attbi.com) Received: (from jojo@localhost) by localhost.localdomain (8.12.6/8.12.6/Submit) id h01Kvc9M019763; Wed, 1 Jan 2003 12:57:39 -0800 (PST) (envelope-from swear@attbi.com) Message-Id: Date: 01 Jan 2003 12:57:38 -0800 From: "Gary W. Swearingen" Reply-To: swear@attbi.com To: FreeBSD-gnats-submit@FreeBSD.org Subject: bin/46672: dump(8) program gives unnecessary -L warning Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org >Number: 46672 >Category: bin >Synopsis: dump(8) program gives unnecessary -L warning >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Jan 01 13:00:14 PST 2003 >Closed-Date: >Last-Modified: >Originator: Gary W. Swearingen >Release: FreeBSD 5.0-CURRENT i386 >Organization: none >Environment: FreeBSD localhost.localdomain 5.0-CURRENT FreeBSD 5.0-CURRENT #0: Mon Dec 30 17:04:36 PST 2002 root@localhost.localdomain:/usr/obj/usr/src/sys/GENERIC i386 ================ >Description: The dump(8) program, when used on a filesystem mounted with "-r", warns: "WARNING: should use -L when dumping live filesysterms!" 1) AFAIK, there's no good reason to use "-L" when dumping a read-only filesystem. The program should check for read-only filesystem status and omit the warning in that case. 2) The techno-grammar in the warning is unnecessary. Change it to "WARNING: Use -L when dumping live filesysterms!" (my favorite) or "WARNING: -L should be used when dumping live filesysterms!" or "WARNING: One should use -L when dumping live filesysterms!". ================ >How-To-Repeat: n/a ================ >Fix: >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message From owner-freebsd-bugs Wed Jan 1 13:10: 4 2003 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BE93E37B401 for ; Wed, 1 Jan 2003 13:10:03 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7A0AA43EC2 for ; Wed, 1 Jan 2003 13:10:02 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id h01LA2NS061212 for ; Wed, 1 Jan 2003 13:10:02 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.6/8.12.6/Submit) id h01LA2c1061211; Wed, 1 Jan 2003 13:10:02 -0800 (PST) Date: Wed, 1 Jan 2003 13:10:02 -0800 (PST) Message-Id: <200301012110.h01LA2c1061211@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: Ceri Davies Subject: Re: bin/46672: dump(8) program gives unnecessary -L warning Reply-To: Ceri Davies Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org The following reply was made to PR bin/46672; it has been noted by GNATS. From: Ceri Davies To: "Gary W. Swearingen" Cc: FreeBSD-gnats-submit@FreeBSD.org Subject: Re: bin/46672: dump(8) program gives unnecessary -L warning Date: Wed, 1 Jan 2003 21:01:45 +0000 On Wed, Jan 01, 2003 at 12:57:38PM -0800, Gary W. Swearingen wrote: > > 2) The techno-grammar in the warning is unnecessary. Change it to > "WARNING: Use -L when dumping live filesysterms!" (my favorite) or > "WARNING: -L should be used when dumping live filesysterms!" or > "WARNING: One should use -L when dumping live filesysterms!". And spell "systems" right too ;) Ceri To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message From owner-freebsd-bugs Wed Jan 1 14:40: 5 2003 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3B65237B401 for ; Wed, 1 Jan 2003 14:40:03 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5EF2943EC5 for ; Wed, 1 Jan 2003 14:40:02 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id h01Me2NS086985 for ; Wed, 1 Jan 2003 14:40:02 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.6/8.12.6/Submit) id h01Me2nt086984; Wed, 1 Jan 2003 14:40:02 -0800 (PST) Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1DE4B37B401 for ; Wed, 1 Jan 2003 14:31:14 -0800 (PST) Received: from orthanc.ab.ca (114.216-123-230-0.interbaun.com [216.123.230.114]) by mx1.FreeBSD.org (Postfix) with ESMTP id 757D343EC5 for ; Wed, 1 Jan 2003 14:31:13 -0800 (PST) (envelope-from lyndon@orthanc.ab.ca) Received: from orthanc.ab.ca (localhost6 [IPv6:::1]) by orthanc.ab.ca (8.12.6/8.12.6) with ESMTP id h01MVC1q032797 for ; Wed, 1 Jan 2003 15:31:12 -0700 (MST) (envelope-from lyndon@orthanc.ab.ca) Received: (from lyndon@localhost) by orthanc.ab.ca (8.12.6/8.12.6/Submit) id h01MVCna032796; Wed, 1 Jan 2003 15:31:12 -0700 (MST) Message-Id: <200301012231.h01MVCna032796@orthanc.ab.ca> Date: Wed, 1 Jan 2003 15:31:12 -0700 (MST) From: Lyndon Nerenberg Reply-To: Lyndon Nerenberg To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: bin/46676: [PATCH] bsd.dep.mk restricts domain of tags commands Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org >Number: 46676 >Category: bin >Synopsis: [PATCH] bsd.dep.mk restricts domain of tags commands >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Jan 01 14:40:01 PST 2003 >Closed-Date: >Last-Modified: >Originator: Lyndon Nerenberg >Release: current >Organization: >Environment: System: FreeBSD foo 5.0-CURRENT FreeBSD 5.0-CURRENT #1: Wed Dec 4 11:49:07 MST 2002 root@foo:/u/freebsd/cvssrc/RELENG_4/sys/i386/compile/DL i386 >Description: The tags target in bsd.dep.mk only allows ctags and gtags as tag generator commands. >How-To-Repeat: Set CTAGS=etags in /etc/make.conf, then run make tags. >Fix: The bsd.dep.mk rules have some intimate knowledge of the command line invocations of ctags and gtags. Setting the flags is done by comparing the CTAGS value to the fixed strings "ctags" and "gtags" with no default case. Thus, assigning any other value to CTAGS turns the tags target into a no-op. The attached patch removes the explicit ctags case, and instead makes that the default recipe unless CTAGS is set to gtags. The ctags-style invocation is generic enough that it should adapt to most other tags generators. It's not unreasonable to require the replacement tags command to support the -f switch. --- /usr/src/share/mk/bsd.dep.mk Thu Nov 28 15:19:38 2002 +++ bsd.dep.mk Wed Jan 1 15:16:02 2003 @@ -56,14 +56,14 @@ # Keep `tags' here, before SRCS are mangled below for `depend'. .if !target(tags) && defined(SRCS) && !defined(NOTAGS) tags: ${SRCS} -.if ${CTAGS:T} == "ctags" - @${CTAGS} ${CTAGSFLAGS} -f /dev/stdout \ - ${.ALLSRC:N*.h} | sed "s;${.CURDIR}/;;" > ${.TARGET} -.elif ${CTAGS:T} == "gtags" +.if ${CTAGS:T} == "gtags" @cd ${.CURDIR} && ${CTAGS} ${GTAGSFLAGS} ${.OBJDIR} .if defined(HTML) @cd ${.CURDIR} && htags ${HTAGSFLAGS} -d ${.OBJDIR} ${.OBJDIR} .endif +.else + @${CTAGS} ${CTAGSFLAGS} -f /dev/stdout \ + ${.ALLSRC:N*.h} | sed "s;${.CURDIR}/;;" > ${.TARGET} .endif .endif >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message From owner-freebsd-bugs Wed Jan 1 16: 0:23 2003 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8895F37B405 for ; Wed, 1 Jan 2003 16:00:21 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id D526B43ED4 for ; Wed, 1 Jan 2003 16:00:18 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id h0200INS008612 for ; Wed, 1 Jan 2003 16:00:18 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.6/8.12.6/Submit) id h0200IcZ008611; Wed, 1 Jan 2003 16:00:18 -0800 (PST) Date: Wed, 1 Jan 2003 16:00:18 -0800 (PST) Message-Id: <200301020000.h0200IcZ008611@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: Lyndon Nerenberg {VE6BBM} Subject: Re: bin/46676: [PATCH] bsd.dep.mk restricts domain of tags commands Reply-To: Lyndon Nerenberg {VE6BBM} Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org The following reply was made to PR bin/46676; it has been noted by GNATS. From: Lyndon Nerenberg {VE6BBM} To: FreeBSD-gnats-submit@FreeBSD.org Cc: Subject: Re: bin/46676: [PATCH] bsd.dep.mk restricts domain of tags commands Date: Wed, 01 Jan 2003 16:52:28 -0700 Sorry folks, the second half of the patch got chopped. Here it is again. Index: bsd.dep.mk =================================================================== RCS file: /home/ncvs/src/share/mk/bsd.dep.mk,v retrieving revision 1.38 diff -u -r1.38 bsd.dep.mk --- bsd.dep.mk 2002/10/17 13:48:13 1.38 +++ bsd.dep.mk 2003/01/01 23:50:42 @@ -56,14 +56,14 @@ # Keep `tags' here, before SRCS are mangled below for `depend'. .if !target(tags) && defined(SRCS) && !defined(NOTAGS) tags: ${SRCS} -.if ${CTAGS:T} == "ctags" - @${CTAGS} ${CTAGSFLAGS} -f /dev/stdout \ - ${.ALLSRC:N*.h} | sed "s;${.CURDIR}/;;" > ${.TARGET} -.elif ${CTAGS:T} == "gtags" +.if ${CTAGS:T} == "gtags" @cd ${.CURDIR} && ${CTAGS} ${GTAGSFLAGS} ${.OBJDIR} .if defined(HTML) @cd ${.CURDIR} && htags ${HTAGSFLAGS} -d ${.OBJDIR} ${.OBJDIR} .endif +.else + @${CTAGS} ${CTAGSFLAGS} -f /dev/stdout \ + ${.ALLSRC:N*.h} | sed "s;${.CURDIR}/;;" > ${.TARGET} .endif .endif @@ -160,13 +160,13 @@ .if !target(cleandepend) cleandepend: .if defined(SRCS) -.if ${CTAGS:T} == "ctags" - rm -f ${DEPENDFILE} tags -.elif ${CTAGS:T} == "gtags" +.if ${CTAGS:T} == "gtags" rm -f ${DEPENDFILE} GPATH GRTAGS GSYMS GTAGS .if defined(HTML) rm -rf HTML .endif +.else + rm -f ${DEPENDFILE} tags .endif .endif .endif To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message From owner-freebsd-bugs Wed Jan 1 17:10: 5 2003 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F114237B401 for ; Wed, 1 Jan 2003 17:10:02 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2DB7B43EB2 for ; Wed, 1 Jan 2003 17:10:02 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id h021A2NS033231 for ; Wed, 1 Jan 2003 17:10:02 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.6/8.12.6/Submit) id h021A2qG033230; Wed, 1 Jan 2003 17:10:02 -0800 (PST) Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F32C637B401 for ; Wed, 1 Jan 2003 17:06:12 -0800 (PST) Received: from mail.iskon.hr (inje.iskon.hr [213.191.128.16]) by mx1.FreeBSD.org (Postfix) with SMTP id C3B5743EC5 for ; Wed, 1 Jan 2003 17:06:11 -0800 (PST) (envelope-from dmarion@iskon.hr) Received: (qmail 16009 invoked from network); 2 Jan 2003 02:05:50 +0100 Received: from damjan.iskon.hr (HELO damjan) (213.191.131.38) by mail.iskon.hr with SMTP; 2 Jan 2003 02:05:50 +0100 Message-Id: <20030102010611.C3B5743EC5@mx1.FreeBSD.org> Date: Wed, 1 Jan 2003 17:06:11 -0800 (PST) From: Damjan Marion Reply-To: Damjan Marion To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: kern/46677: Wrong vendor and device defines in ng_ubt.h, shoud go to usbdevs Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org >Number: 46677 >Category: kern >Synopsis: Wrong vendor and device defines in ng_ubt.h, shoud go to usbdevs >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Jan 01 17:10:01 PST 2003 >Closed-Date: >Last-Modified: >Originator: Damjan Marion >Release: FreeBSD 5.0-CURRENT i386 >Organization: >Environment: System: FreeBSD nafta.local 5.0-CURRENT FreeBSD 5.0-CURRENT #3: Wed Jan 1 15:05:04 CET 2003 root@nafta.local:/usr/src/sys/i386/compile/NAFTA i386 >Description: In sys/netgraph/bluetooth/include/ng_ubt.h are defines for USB vendors and defines that should be moved to usbdevs. USB Vendor ID 0x0a12 is assigned to CSR (Cambridge Silicon Radio), not EPOX. >How-To-Repeat: >Fix: Add to usbdevs: vendor CSR 0x0a12 Cambridge Silicon Radio Ltd. vendor MSI 0x0db0 Micro-Star Int'l CO., Ltd. product CSR BLUECORE01B 0x0001 BlueCore01b Bluetooth USB Dongle product 3COM 3CREB96 0x00a0 3Com Bluetooth USB dongle product MITSUMI BT_DONGLE 0x641f Mitsumi Bluetooth USB dongle product TDK BT_DONGLE 0x0309 TDK Bluetooth USB dongle product MSI BT_DONGLE 0x1967 MSI Bluetooth USB dongle product BROADCOM DBW_120M 0x2033 DBW 120M USB dongle Remove from sys/netgraph/bluetooth/include/ng_ubt.h: #define USB_VENDOR_MSI 0x0db0 /* MSI www.msi.com.tw */ #define USB_VENDOR_EPOX 0x0a12 /* EPoX www.epox.com */ #define USB_PRODUCT_3COM_3CREB96 0x00a0 /* 3Com Bluetooth USB dongle */ #define USB_PRODUCT_MITSUMI_BT_DONGLE 0x641f /* Mitsumi Bluetooth USB dongle*/ #define USB_PRODUCT_TDK_BT_DONGLE 0x0309 /* TDK Bluetooth USB dongle */ #define USB_PRODUCT_MSI_BT_DONGLE 0x1967 /* MSI Bluetooth USB dongle */ #define USB_PRODUCT_DBW_120M_BT_DONGLE 0x2033 /* D-Link DBW-120M */ #define USB_PRODUCT_BT_DG02_DONGLE 0x0001 /* EPoX BT-DG02 USB dongle */ Update sys/netgraph/bluetooth/drivers/ubt/ng_ubt.c - { USB_VENDOR_BROADCOM, USB_PRODUCT_DBW_120M_BT_DONGLE }, + { USB_VENDOR_BROADCOM, USB_PRODUCT_BROADCOM_DBW_120M }, - { USB_VENDOR_EPOX, USB_PRODUCT_BT_DG02_DONGLE }, + { USB_VENDOR_CSR, USB_PRODUCT_CSR_BLUECORE01B }, >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message From owner-freebsd-bugs Wed Jan 1 18:20:15 2003 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 857F137B401 for ; Wed, 1 Jan 2003 18:20:08 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id A090443EA9 for ; Wed, 1 Jan 2003 18:20:07 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id h022K7NS053578 for ; Wed, 1 Jan 2003 18:20:07 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.6/8.12.6/Submit) id h022K7mE053577; Wed, 1 Jan 2003 18:20:07 -0800 (PST) Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8219137B401 for ; Wed, 1 Jan 2003 18:11:27 -0800 (PST) Received: from wee.daren.ca (CPE014320028330.cpe.net.cable.rogers.com [24.102.94.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id E537B43EC5 for ; Wed, 1 Jan 2003 18:11:25 -0800 (PST) (envelope-from daren@wee.daren.ca) Received: from wee.daren.ca (localhost [127.0.0.1]) by wee.daren.ca (8.12.6/8.12.6) with ESMTP id h022B9O6052579; Wed, 1 Jan 2003 21:11:09 -0500 (EST) (envelope-from daren@wee.daren.ca) Received: (from daren@localhost) by wee.daren.ca (8.12.6/8.12.6/Submit) id h022B8L5052578; Wed, 1 Jan 2003 21:11:08 -0500 (EST) Message-Id: <200301020211.h022B8L5052578@wee.daren.ca> Date: Wed, 1 Jan 2003 21:11:08 -0500 (EST) From: desjardins@canada.com Reply-To: desjardins@canada.com To: FreeBSD-gnats-submit@FreeBSD.org Cc: desjardins@canada.com X-Send-Pr-Version: 3.113 Subject: misc/46679: added volume stepping to mixer Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org >Number: 46679 >Category: misc >Synopsis: added volume stepping to mixer >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Wed Jan 01 18:20:01 PST 2003 >Closed-Date: >Last-Modified: >Originator: Daren Desjardins >Release: FreeBSD 4.7-STABLE i386 >Organization: >Environment: System: FreeBSD wee.daren.ca 4.7-STABLE FreeBSD 4.7-STABLE #3: Mon Dec 30 17:26:52 EST 2002 daren@wee.daren.ca:/usr/obj/usr/src/sys/WEE i386 Built using mixer.c 1.17 (FreeBSD-current) >Description: Patched to include support for volume stepping using two new command line parameters, -i for increase and -d for decrease. They simply tell the mixer to increase/decrease current levels of the device specified by the amount provided. I have been using this to enable my volume control via Logitech keyboard. Increasing: [daren@wee mixer]$mixer -i 5:5 Increasing the mixer vol from 40:40 to 45:45. [daren@wee mixer]$ Decreasing: [daren@wee mixer]$mixer -d vol 10 Decreasing the mixer vol from 45:45 to 35:35. [daren@wee mixer]$ Attached is the diff of my changes to mixer.c V1.17 >How-To-Repeat: >Fix: --- mixer.diff begins here --- *** mixer_new.c Wed Jan 1 13:26:23 2003 --- mixer.c Wed Jan 1 13:32:41 2003 *************** *** 3,8 **** --- 3,9 ---- * * updated 1/1/93 to add stereo, level query, broken * devmask kludge - cmetz@thor.tjhsst.edu + * updated 1/1/03 to add volume stepping - desjardins@canada.com * * (C) Craig Metz and Hannu Savolainen 1993. * *************** *** 13,19 **** #ifndef lint static const char rcsid[] = ! "$FreeBSD: src/usr.sbin/mixer/mixer.c,v 1.17 2002/12/30 04:23:08 jmallett Exp $"; #endif /* not lint */ #include --- 14,20 ---- #ifndef lint static const char rcsid[] = ! "$FreeBSD: src/usr.sbin/mixer/mixer.c,v 1.11.2.6 2001/07/30 10:22:58 dd Exp $"; #endif /* not lint */ #include *************** *** 35,41 **** { int i, n; ! printf("usage: mixer [-f device] [-s] [[dev [voll[:volr]] | recsrc | {^|+|-|=}rec recdev] ... ]\n"); printf(" devices: "); for (i = 0, n = 0; i < SOUND_MIXER_NRDEVICES; i++) if ((1 << i) & devmask) { --- 36,42 ---- { int i, n; ! printf("usage: mixer [-f device] [-s] [-i|-d] [[dev [voll[:volr]] | recsrc | {^|+|-|=}rec recdev] ... ]\n"); printf(" devices: "); for (i = 0, n = 0; i < SOUND_MIXER_NRDEVICES; i++) if ((1 << i) & devmask) { *************** *** 91,96 **** --- 92,99 ---- int devmask = 0, recmask = 0, recsrc = 0, orecsrc; int dusage = 0, drecsrc = 0, shortflag = 0; int l = 0, r = 0, t = 0; + bool volumeInc = false; + bool volumeDec = false; char ch; char *name; *************** *** 102,108 **** else if (!strcmp(argv[0], "mixer3")) name = strdup("/dev/mixer2"); ! while ((ch = getopt(argc, argv, "f:s")) != -1) switch (ch) { case 'f': name = strdup(optarg); --- 105,111 ---- else if (!strcmp(argv[0], "mixer3")) name = strdup("/dev/mixer2"); ! while ((ch = getopt(argc, argv, "f:sid")) != -1) switch (ch) { case 'f': name = strdup(optarg); *************** *** 110,115 **** --- 113,124 ---- case 's': shortflag = 1; break; + case 'i': + volumeInc = true; + break; + case 'd': + volumeDec = true; + break; default: dusage = 1; } *************** *** 181,195 **** continue; } if ((t = sscanf(*argv, "%d:%d", &l, &r)) > 0) { dev = 0; } else if((dev = res_name(*argv, devmask)) == -1) { warnx("unknown device: %s", *argv); dusage = 1; break; } ! switch(argc > 1 ? sscanf(argv[1], "%d:%d", &l, &r) : t) { case 0: if (ioctl(baz, MIXER_READ(dev),&bar)== -1) { --- 190,206 ---- continue; } + // Check if device is specified if ((t = sscanf(*argv, "%d:%d", &l, &r)) > 0) { dev = 0; } + // read and verify the device else if((dev = res_name(*argv, devmask)) == -1) { warnx("unknown device: %s", *argv); dusage = 1; break; } ! // Read in the volume changes switch(argc > 1 ? sscanf(argv[1], "%d:%d", &l, &r) : t) { case 0: if (ioctl(baz, MIXER_READ(dev),&bar)== -1) { *************** *** 208,213 **** --- 219,259 ---- case 1: r = l; case 2: + + // Read the current volum + if(ioctl(baz, MIXER_READ(dev), &bar) == -1) + { + warn("MIXER_READ"); + continue; + } + + int leftVolume = bar & 0x7f; + int rightVolume = (bar >> 8) & 0x7f; + + if(volumeInc || volumeDec) + { + // Read the current volume for stepping + if(ioctl(baz, MIXER_READ(dev), &bar) == -1) + { + warn("MIXER_READ"); + continue; + } + + int leftVolume = bar & 0x7f; + int rightVolume = (bar >> 8) & 0x7f; + + if(volumeInc) + { + l = leftVolume +l; + r = rightVolume +r; + } + else + { + l = leftVolume -l; + r = rightVolume -r; + } + } + if (l < 0) l = 0; else if (l > 100) *************** *** 217,230 **** else if (r > 100) r = 100; ! if (ioctl(baz, MIXER_READ(dev),&bar)== -1) { ! warn("MIXER_READ"); ! argc--; argv++; ! continue; } ! ! printf("Setting the mixer %s from %d:%d to %d:%d.\n", ! names[dev], bar & 0x7f, (bar >> 8) & 0x7f, l, r); l |= r << 8; if (ioctl(baz, MIXER_WRITE(dev), &l) == -1) --- 263,278 ---- else if (r > 100) r = 100; ! if(volumeInc) ! { ! printf("Increasing the mixer %s from %d:%d to %d:%d.\n", names[dev],leftVolume, rightVolume, l,r); } ! else if(volumeDec) ! { ! printf("Decreasing the mixer %s from %d:%d to %d:%d.\n", names[dev],leftVolume, rightVolume,l, r); ! } ! else ! printf("Setting the mixer %s from %d:%d to %d:%d.\n", names[dev], leftVolume, rightVolume, l, r); l |= r << 8; if (ioctl(baz, MIXER_WRITE(dev), &l) == -1) --- mixer.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message From owner-freebsd-bugs Thu Jan 2 9: 4:39 2003 Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2718D37B405 for ; Thu, 2 Jan 2003 09:04:38 -0800 (PST) Received: from grey.cloud.rain.com (12-241-216-119.client.attbi.com [12.241.216.119]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6F3D243EDC for ; Thu, 2 Jan 2003 09:04:37 -0800 (PST) (envelope-from trost@grey.cloud.rain.com) Received: (qmail 1330 invoked from network); 2 Jan 2003 17:04:36 -0000 Received: from localhost (HELO grey.cloud.rain.com) (@127.0.0.1) by localhost with SMTP; 2 Jan 2003 17:04:36 -0000 To: David Malone Cc: freebsd-bugs@FreeBSD.org Subject: Re: conf/15010: "client" firewall configuration kills incoming broadcast References: <20021221125253.GA13901@walton.maths.tcd.ie> <200211241950.gAOJo2u1096496@freefall.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1326.1041527075.1@grey.cloud.rain.com> Date: Thu, 02 Jan 2003 09:04:35 -0800 Message-ID: <1327.1041527075@grey.cloud.rain.com> From: Bill Trost Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Hi, David, David Malone writes: Bill - are you sure about the patch you submitted in the PR? It seems to allow traffic *from* the broadcast address, rather than to it. Did you mean the opposit way around? That was sort of my reaction, too, upon re-reading the bug report. It seems to me that both directions are necessary. The nmbd needs to receive broadcasts from other SMB servers, as well as be able to transmit its own broadcasts to them. In short, both the bug description and the fix are incomplete. Bill To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message From owner-freebsd-bugs Thu Jan 2 9:50: 5 2003 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ECAE537B401 for ; Thu, 2 Jan 2003 09:50:03 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4347443EB2 for ; Thu, 2 Jan 2003 09:50:02 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id h02Ho2NS030956 for ; Thu, 2 Jan 2003 09:50:02 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.6/8.12.6/Submit) id h02Ho2cU030955; Thu, 2 Jan 2003 09:50:02 -0800 (PST) Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9D7D437B401 for ; Thu, 2 Jan 2003 09:44:44 -0800 (PST) Received: from speedfreak.hexanet.fr (speedfreak.hexanet.fr [81.23.32.34]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1780443EC2 for ; Thu, 2 Jan 2003 09:44:43 -0800 (PST) (envelope-from nighty@speedfreak.hexanet.fr) Received: from speedfreak.hexanet.fr (smmsp@locahost [127.0.0.1]) by speedfreak.hexanet.fr (8.12.6/8.12.6) with ESMTP id h02Hiqr0001028 for ; Thu, 2 Jan 2003 18:44:53 +0100 (CET) (envelope-from nighty@speedfreak.hexanet.fr) Received: (from nighty@localhost) by speedfreak.hexanet.fr (8.12.6/8.12.6/Submit) id gBVKM0iw000592; Tue, 31 Dec 2002 21:22:00 +0100 (CET) Message-Id: <200212312022.gBVKM0iw000592@speedfreak.hexanet.fr> Date: Tue, 31 Dec 2002 21:22:00 +0100 (CET) From: Christophe Prevotaux Reply-To: Christophe Prevotaux To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: misc/46694: Getting DUP packets when in Promiscous mode on wi0 Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org >Number: 46694 >Category: misc >Synopsis: Getting DUP packets when in Promiscous mode on wi0 >Confidential: yes >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Jan 02 09:50:01 PST 2003 >Closed-Date: >Last-Modified: >Originator: Christophe Prevotaux >Release: FreeBSD 4.7-STABLE i386 >Organization: HEXANET Sarl. Reims France >Environment: System: FreeBSD speedfreak 4.7-STABLE FreeBSD 4.7-STABLE #13: Sat Nov 16 23:52:22 CET 2002 nighty@speedfreak:/usr/obj/usr/src/sys/FREAK i386 >Description: Duplicate packets appear when either machine belonging to one session are in promiscous mode and using wi0 (Orinoco Gold 802.11b wireless cards in my case), this behaviour has also been observed on OpenBSD and NetBSD >How-To-Repeat: Just put either side of the wireless link or cards connected to an AP in promiscous mode and ping the other machine that is also using a wireless card. the more machines are in promiscoui s mode the more DUP you get. >Fix: >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message From owner-freebsd-bugs Thu Jan 2 9:50: 8 2003 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0F8B637B405 for ; Thu, 2 Jan 2003 09:50:04 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8D85643EC5 for ; Thu, 2 Jan 2003 09:50:02 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id h02Ho2NS030969 for ; Thu, 2 Jan 2003 09:50:02 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.6/8.12.6/Submit) id h02Ho20N030968; Thu, 2 Jan 2003 09:50:02 -0800 (PST) Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6651137B401 for ; Thu, 2 Jan 2003 09:44:48 -0800 (PST) Received: from speedfreak.hexanet.fr (speedfreak.hexanet.fr [81.23.32.34]) by mx1.FreeBSD.org (Postfix) with ESMTP id 236F843EB2 for ; Thu, 2 Jan 2003 09:44:47 -0800 (PST) (envelope-from nighty@speedfreak.hexanet.fr) Received: from speedfreak.hexanet.fr (smmsp@locahost [127.0.0.1]) by speedfreak.hexanet.fr (8.12.6/8.12.6) with ESMTP id h02Hiqqq001028 for ; Thu, 2 Jan 2003 18:44:52 +0100 (CET) (envelope-from nighty@speedfreak.hexanet.fr) Received: (from nighty@localhost) by speedfreak.hexanet.fr (8.12.6/8.12.6/Submit) id h02H2hl7000406; Thu, 2 Jan 2003 18:02:43 +0100 (CET) Message-Id: <200301021702.h02H2hl7000406@speedfreak.hexanet.fr> Date: Thu, 2 Jan 2003 18:02:43 +0100 (CET) From: Christophe Prevotaux Reply-To: Christophe Prevotaux To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: i386/46695: Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org >Number: 46695 >Category: i386 >Synopsis: >Confidential: no >Severity: critical >Priority: high >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Jan 02 09:50:02 PST 2003 >Closed-Date: >Last-Modified: >Originator: Christophe Prevotaux >Release: FreeBSD 4.7-STABLE i386 >Organization: >Environment: System: FreeBSD speedfreak 4.7-STABLE FreeBSD 4.7-STABLE #13: Sat Nov 16 23:52:22 CET 2002 nighty@speedfreak:/usr/obj/usr/src/sys/FREAK i386 >Description: Duplicate packets appear when either machine belonging to one session are in promiscuous mode and using wi0 (Orinoco Gold 802.11b wireless cards in my case), this behaviour has also been observed on OpenBSD and NetBSD >How-To-Repeat: Just put either side of the wireless link or cards connected to an AP in promiscous mode and ping the other machine that is also using a wireless card. the more machines are in promiscous mode the more DUP you get. >Fix: >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message From owner-freebsd-bugs Thu Jan 2 9:54:45 2003 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 22AA837B405; Thu, 2 Jan 2003 09:54:45 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id A86CF43EB2; Thu, 2 Jan 2003 09:54:44 -0800 (PST) (envelope-from maxim@FreeBSD.org) Received: from freefall.freebsd.org (maxim@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id h02HsiNS033292; Thu, 2 Jan 2003 09:54:44 -0800 (PST) (envelope-from maxim@freefall.freebsd.org) Received: (from maxim@localhost) by freefall.freebsd.org (8.12.6/8.12.6/Submit) id h02HsiUW033288; Thu, 2 Jan 2003 09:54:44 -0800 (PST) Date: Thu, 2 Jan 2003 09:54:44 -0800 (PST) From: Maxim Konovalov Message-Id: <200301021754.h02HsiUW033288@freefall.freebsd.org> To: c.prevotaux@hexanet.fr, maxim@FreeBSD.org, freebsd-bugs@FreeBSD.org Subject: Re: i386/46695: Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Synopsis: State-Changed-From-To: open->closed State-Changed-By: maxim State-Changed-When: Thu Jan 2 09:54:17 PST 2003 State-Changed-Why: Duplicate of misc/46694. http://www.freebsd.org/cgi/query-pr.cgi?pr=46695 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message From owner-freebsd-bugs Thu Jan 2 10:20:19 2003 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 028E037B42B for ; Thu, 2 Jan 2003 10:20:15 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id D72AB43EE1 for ; Thu, 2 Jan 2003 10:20:12 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id h02IKCNS045353 for ; Thu, 2 Jan 2003 10:20:12 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.6/8.12.6/Submit) id h02IKCe8045352; Thu, 2 Jan 2003 10:20:12 -0800 (PST) Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6E7FD37B401 for ; Thu, 2 Jan 2003 10:15:49 -0800 (PST) Received: from stud187236.mobiel.utwente.nl (stud187236.mobiel.utwente.nl [130.89.187.236]) by mx1.FreeBSD.org (Postfix) with ESMTP id 97E7E43EA9 for ; Thu, 2 Jan 2003 10:15:48 -0800 (PST) (envelope-from roderick@stud187236.mobiel.utwente.nl) Received: from stud187236.mobiel.utwente.nl (localhost [127.0.0.1]) by stud187236.mobiel.utwente.nl (8.12.6/8.12.6) with ESMTP id h02IFkHD025067 for ; Thu, 2 Jan 2003 18:15:46 GMT (envelope-from roderick@stud187236.mobiel.utwente.nl) Received: (from roderick@localhost) by stud187236.mobiel.utwente.nl (8.12.6/8.12.6/Submit) id h02IFjXe025066; Thu, 2 Jan 2003 18:15:45 GMT Message-Id: <200301021815.h02IFjXe025066@stud187236.mobiel.utwente.nl> Date: Thu, 2 Jan 2003 18:15:45 GMT From: Roderick van Domburg Reply-To: Roderick van Domburg To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: kern/46696: ep0 hard lockup during -CURRENT install Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org >Number: 46696 >Category: kern >Synopsis: ep0 hard lockup during -CURRENT install >Confidential: no >Severity: critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Jan 02 10:20:04 PST 2003 >Closed-Date: >Last-Modified: >Originator: Roderick van Domburg >Release: FreeBSD 5.0-CURRENT i386 >Organization: University of Twente >Environment: Any -CURRENT release (including most recent snapshots) known on i386. The precise system is a Compaq Armada V300 with a Celeron processor. The cards are 3C589 and a 3CXE589DC. Another user on freebsd-mobile reported the same problem on a Dell Latitude CPi with a TI 1131 CardBus Controller and 3C589D and 3C589E cards. >Description: For three days in a row now I have tried installing the most recent 5.0 snapshots on my Armada V300 from floppies. I have also tried the RC2 floppies. Unfortunately, the system freezes up solid when it configures ep0. I have a DHCP server here but manually entering the IP configuration results in the same hard lockup. No error messages of any kind are given, I can't switch to pty2 and the kernel doesn't panic. It just locks up completely and indefinitely. ep0 is a PCMCIA card. I have two of such cards, one being a 3C589, the other a 3CXE589DC. Both cards produce the same result but worked fine on 4-STABLE. As a user on freebsd-mobile pointed out, this issue is during installation only. Installation from a CD works fine, and there aren't any issues running ep0 once the system is installed. >How-To-Repeat: Install 5.0-CURRENT from floppies using a ep0 PCMCIA card. >Fix: Unknown. >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message From owner-freebsd-bugs Thu Jan 2 11:20:10 2003 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E462C37B401 for ; Thu, 2 Jan 2003 11:20:03 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 68A4D43E4A for ; Thu, 2 Jan 2003 11:20:03 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id h02JK3NS069503 for ; Thu, 2 Jan 2003 11:20:03 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.6/8.12.6/Submit) id h02JK3Zc069502; Thu, 2 Jan 2003 11:20:03 -0800 (PST) Date: Thu, 2 Jan 2003 11:20:03 -0800 (PST) Message-Id: <200301021920.h02JK3Zc069502@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: Bjorn Gronvall Subject: Re: bin/45397: Telnet dumps core when MAKE_KERBEROS5=yes is enabled Reply-To: Bjorn Gronvall Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org The following reply was made to PR bin/45397; it has been noted by GNATS. From: Bjorn Gronvall To: freebsd-gnats-submit@FreeBSD.org, ari.suutari@syncrontech.com, roam@ringlet.net, bug-followup@FreeBSD.org, markm@FreeBSD.org Cc: Subject: Re: bin/45397: Telnet dumps core when MAKE_KERBEROS5=yes is enabled Date: Thu, 02 Jan 2003 20:16:36 +0100 This is a multi-part message in MIME format. --------------D1C7367BBBD2CF5FAB51F35F Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit This patch also renames net_write to telnet_net_write (as Peter suggested). It also includes changes to crypto/telnet/libtelnet/kerberos5.c to ensure that subkeys are properly used (incorporated from heimdal). After these two changes my telnet and telnetd interoperates correctly with the heimdal ditos and and also with the old FreeBSD telnetd. Cheers, Björn --------------D1C7367BBBD2CF5FAB51F35F Content-Type: text/plain; charset=us-ascii; name="telnet.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="telnet.patch" diff -ur crypto/telnet.orig/libtelnet/auth.c crypto/telnet/libtelnet/auth.c --- crypto/telnet.orig/libtelnet/auth.c Sat Apr 13 12:59:07 2002 +++ crypto/telnet/libtelnet/auth.c Thu Jan 2 18:06:48 2003 @@ -359,7 +359,7 @@ } *e++ = IAC; *e++ = SE; - net_write(str_request, e - str_request); + telnet_net_write(str_request, e - str_request); printsub('>', &str_request[2], e - str_request - 2); } } @@ -444,7 +444,7 @@ } auth_send_data += 2; } - net_write(str_none, sizeof(str_none)); + telnet_net_write(str_none, sizeof(str_none)); printsub('>', &str_none[2], sizeof(str_none) - 2); if (auth_debug_mode) printf(">>>%s: Sent failure message\r\n", Name); @@ -537,7 +537,7 @@ } *e++ = IAC; *e++ = SE; - net_write(str_request, e - str_request); + telnet_net_write(str_request, e - str_request); printsub('>', &str_request[2], e - &str_request[2]); return(1); } diff -ur crypto/telnet.orig/libtelnet/enc_des.c crypto/telnet/libtelnet/enc_des.c --- crypto/telnet.orig/libtelnet/enc_des.c Sat Apr 13 12:59:07 2002 +++ crypto/telnet/libtelnet/enc_des.c Thu Jan 2 18:06:50 2003 @@ -225,7 +225,7 @@ *p++ = IAC; *p++ = SE; printsub('>', &fbp->fb_feed[2], p - &fbp->fb_feed[2]); - net_write(fbp->fb_feed, p - fbp->fb_feed); + telnet_net_write(fbp->fb_feed, p - fbp->fb_feed); break; default: return(FAILED); @@ -284,7 +284,7 @@ *p++ = IAC; *p++ = SE; printsub('>', &fbp->fb_feed[2], p - &fbp->fb_feed[2]); - net_write(fbp->fb_feed, p - fbp->fb_feed); + telnet_net_write(fbp->fb_feed, p - fbp->fb_feed); state = fbp->state[DIR_DECRYPT-1] = IN_PROGRESS; break; @@ -309,7 +309,7 @@ *p++ = IAC; *p++ = SE; printsub('>', &fbp->fb_feed[2], p - &fbp->fb_feed[2]); - net_write(fbp->fb_feed, p - fbp->fb_feed); + telnet_net_write(fbp->fb_feed, p - fbp->fb_feed); break; } diff -ur crypto/telnet.orig/libtelnet/encrypt.c crypto/telnet/libtelnet/encrypt.c --- crypto/telnet.orig/libtelnet/encrypt.c Sat Apr 13 12:59:07 2002 +++ crypto/telnet/libtelnet/encrypt.c Thu Jan 2 18:06:50 2003 @@ -427,7 +427,7 @@ */ if (!Server && autodecrypt) encrypt_send_request_start(); - net_write(str_send, str_suplen); + telnet_net_write(str_send, str_suplen); printsub('>', &str_send[2], str_suplen - 2); str_suplen = 0; } @@ -773,7 +773,7 @@ } *strp++ = IAC; *strp++ = SE; - net_write(str_keyid, strp - str_keyid); + telnet_net_write(str_keyid, strp - str_keyid); printsub('>', &str_keyid[2], strp - str_keyid - 2); } @@ -832,7 +832,7 @@ } *p++ = IAC; *p++ = SE; - net_write(str_start, p - str_start); + telnet_net_write(str_start, p - str_start); net_encrypt(); printsub('>', &str_start[2], p - &str_start[2]); /* @@ -858,7 +858,7 @@ return; str_end[3] = ENCRYPT_END; - net_write(str_end, sizeof(str_end)); + telnet_net_write(str_end, sizeof(str_end)); net_encrypt(); printsub('>', &str_end[2], sizeof(str_end) - 2); /* @@ -886,7 +886,7 @@ } *p++ = IAC; *p++ = SE; - net_write(str_start, p - str_start); + telnet_net_write(str_start, p - str_start); printsub('>', &str_start[2], p - &str_start[2]); if (encrypt_debug_mode) printf(">>>%s: Request input to be encrypted\r\n", Name); @@ -896,7 +896,7 @@ encrypt_send_request_end(void) { str_end[3] = ENCRYPT_REQEND; - net_write(str_end, sizeof(str_end)); + telnet_net_write(str_end, sizeof(str_end)); printsub('>', &str_end[2], sizeof(str_end) - 2); if (encrypt_debug_mode) diff -ur crypto/telnet.orig/libtelnet/kerberos.c crypto/telnet/libtelnet/kerberos.c --- crypto/telnet.orig/libtelnet/kerberos.c Sat Apr 13 12:59:07 2002 +++ crypto/telnet/libtelnet/kerberos.c Thu Jan 2 18:06:51 2003 @@ -126,7 +126,7 @@ *p++ = SE; if (str_data[3] == TELQUAL_IS) printsub('>', &str_data[2], p - (&str_data[2])); - return(net_write(str_data, p - str_data)); + return(telnet_net_write(str_data, p - str_data)); } int diff -ur crypto/telnet.orig/libtelnet/kerberos5.c crypto/telnet/libtelnet/kerberos5.c --- crypto/telnet.orig/libtelnet/kerberos5.c Sat Apr 13 12:59:07 2002 +++ crypto/telnet/libtelnet/kerberos5.c Thu Jan 2 18:06:51 2003 @@ -128,7 +128,7 @@ *p++ = SE; if (str_data[3] == TELQUAL_IS) printsub('>', &str_data[2], p - &str_data[2]); - return(net_write(str_data, p - str_data)); + return(telnet_net_write(str_data, p - str_data)); } int @@ -193,6 +193,8 @@ else ap_opts = 0; + ap_opts |= AP_OPTS_USE_SUBKEY; + ret = krb5_auth_con_init (context, &auth_context); if (ret) { if (auth_debug_mode) { @@ -406,6 +408,29 @@ printf("Kerberos V5: " "krb5_auth_con_getremotesubkey failed (%s)\r\n", krb5_get_err_text(context, ret)); + return; + } + + if (key_block == NULL) { + ret = krb5_auth_con_getkey(context, + auth_context, + &key_block); + } + if (ret) { + Data(ap, KRB_REJECT, "krb5_auth_con_getkey failed", -1); + auth_finished(ap, AUTH_REJECT); + if (auth_debug_mode) + printf("Kerberos V5: " + "krb5_auth_con_getkey failed (%s)\r\n", + krb5_get_err_text(context, ret)); + return; + } + if (key_block == NULL) { + Data(ap, KRB_REJECT, "no subkey received", -1); + auth_finished(ap, AUTH_REJECT); + if (auth_debug_mode) + printf("Kerberos V5: " + "krb5_auth_con_getremotesubkey returned NULL key\r\n"); return; } diff -ur crypto/telnet.orig/libtelnet/krb4encpwd.c crypto/telnet/libtelnet/krb4encpwd.c --- crypto/telnet.orig/libtelnet/krb4encpwd.c Sat Apr 13 12:59:07 2002 +++ crypto/telnet/libtelnet/krb4encpwd.c Thu Jan 2 18:06:52 2003 @@ -146,7 +146,7 @@ *p++ = SE; if (str_data[3] == TELQUAL_IS) printsub('>', &str_data[2], p - (&str_data[2])); - return(net_write(str_data, p - str_data)); + return(telnet_net_write(str_data, p - str_data)); } int diff -ur crypto/telnet.orig/libtelnet/misc-proto.h crypto/telnet/libtelnet/misc-proto.h --- crypto/telnet.orig/libtelnet/misc-proto.h Sat Apr 13 12:59:07 2002 +++ crypto/telnet/libtelnet/misc-proto.h Thu Jan 2 18:06:52 2003 @@ -71,7 +71,7 @@ /* * These functions are imported from the application */ -int net_write(unsigned char *, int); +int telnet_net_write(unsigned char *, int); void net_encrypt(void); int telnet_spin(void); char *telnet_getenv(char *); diff -ur crypto/telnet.orig/libtelnet/rsaencpwd.c crypto/telnet/libtelnet/rsaencpwd.c --- crypto/telnet.orig/libtelnet/rsaencpwd.c Sat Apr 13 12:59:07 2002 +++ crypto/telnet/libtelnet/rsaencpwd.c Thu Jan 2 18:06:52 2003 @@ -142,7 +142,7 @@ *p++ = SE; if (str_data[3] == TELQUAL_IS) printsub('>', &str_data[2], p - (&str_data[2])); - return(net_write(str_data, p - str_data)); + return(telnet_net_write(str_data, p - str_data)); } int diff -ur crypto/telnet.orig/libtelnet/sra.c crypto/telnet/libtelnet/sra.c --- crypto/telnet.orig/libtelnet/sra.c Thu May 16 10:46:49 2002 +++ crypto/telnet/libtelnet/sra.c Thu Jan 2 18:06:53 2003 @@ -106,7 +106,7 @@ *p++ = SE; if (str_data[3] == TELQUAL_IS) printsub('>', &str_data[2], p - (&str_data[2])); - return(net_write(str_data, p - str_data)); + return(telnet_net_write(str_data, p - str_data)); } int diff -ur crypto/telnet.orig/telnet/authenc.c crypto/telnet/telnet/authenc.c --- crypto/telnet.orig/telnet/authenc.c Sat Apr 13 12:59:08 2002 +++ crypto/telnet/telnet/authenc.c Thu Jan 2 18:06:53 2003 @@ -55,7 +55,7 @@ #include "types.h" int -net_write(unsigned char *str, int len) +telnet_net_write(unsigned char *str, int len) { if (NETROOM() > len) { ring_supply_data(&netoring, str, len); diff -ur crypto/telnet.orig/telnetd/authenc.c crypto/telnet/telnetd/authenc.c --- crypto/telnet.orig/telnetd/authenc.c Sat Apr 13 12:59:08 2002 +++ crypto/telnet/telnetd/authenc.c Thu Jan 2 18:06:54 2003 @@ -47,7 +47,7 @@ #include int -net_write(unsigned char *str, int len) +telnet_net_write(unsigned char *str, int len) { if (nfrontp + len < netobuf + BUFSIZ) { output_datalen(str, len); --------------D1C7367BBBD2CF5FAB51F35F-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message From owner-freebsd-bugs Thu Jan 2 11:20:21 2003 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 626EF37B405 for ; Thu, 2 Jan 2003 11:20:05 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id D8A4143E4A for ; Thu, 2 Jan 2003 11:20:04 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id h02JK4NS069514 for ; Thu, 2 Jan 2003 11:20:04 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.6/8.12.6/Submit) id h02JK40B069513; Thu, 2 Jan 2003 11:20:04 -0800 (PST) Date: Thu, 2 Jan 2003 11:20:04 -0800 (PST) Message-Id: <200301021920.h02JK40B069513@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: Bjorn Gronvall Subject: Re: bin/45397: Telnet dumps core when MAKE_KERBEROS5=yes is enabled Reply-To: Bjorn Gronvall Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org The following reply was made to PR bin/45397; it has been noted by GNATS. From: Bjorn Gronvall To: freebsd-gnats-submit@FreeBSD.org, ari.suutari@syncrontech.com, roam@ringlet.net, bug-followup@FreeBSD.org, markm@FreeBSD.org Cc: Subject: Re: bin/45397: Telnet dumps core when MAKE_KERBEROS5=yes is enabled Date: Thu, 02 Jan 2003 20:16:36 +0100 This is a multi-part message in MIME format. --------------D1C7367BBBD2CF5FAB51F35F Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit This patch also renames net_write to telnet_net_write (as Peter suggested). It also includes changes to crypto/telnet/libtelnet/kerberos5.c to ensure that subkeys are properly used (incorporated from heimdal). After these two changes my telnet and telnetd interoperates correctly with the heimdal ditos and and also with the old FreeBSD telnetd. Cheers, Björn --------------D1C7367BBBD2CF5FAB51F35F Content-Type: text/plain; charset=us-ascii; name="telnet.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="telnet.patch" diff -ur crypto/telnet.orig/libtelnet/auth.c crypto/telnet/libtelnet/auth.c --- crypto/telnet.orig/libtelnet/auth.c Sat Apr 13 12:59:07 2002 +++ crypto/telnet/libtelnet/auth.c Thu Jan 2 18:06:48 2003 @@ -359,7 +359,7 @@ } *e++ = IAC; *e++ = SE; - net_write(str_request, e - str_request); + telnet_net_write(str_request, e - str_request); printsub('>', &str_request[2], e - str_request - 2); } } @@ -444,7 +444,7 @@ } auth_send_data += 2; } - net_write(str_none, sizeof(str_none)); + telnet_net_write(str_none, sizeof(str_none)); printsub('>', &str_none[2], sizeof(str_none) - 2); if (auth_debug_mode) printf(">>>%s: Sent failure message\r\n", Name); @@ -537,7 +537,7 @@ } *e++ = IAC; *e++ = SE; - net_write(str_request, e - str_request); + telnet_net_write(str_request, e - str_request); printsub('>', &str_request[2], e - &str_request[2]); return(1); } diff -ur crypto/telnet.orig/libtelnet/enc_des.c crypto/telnet/libtelnet/enc_des.c --- crypto/telnet.orig/libtelnet/enc_des.c Sat Apr 13 12:59:07 2002 +++ crypto/telnet/libtelnet/enc_des.c Thu Jan 2 18:06:50 2003 @@ -225,7 +225,7 @@ *p++ = IAC; *p++ = SE; printsub('>', &fbp->fb_feed[2], p - &fbp->fb_feed[2]); - net_write(fbp->fb_feed, p - fbp->fb_feed); + telnet_net_write(fbp->fb_feed, p - fbp->fb_feed); break; default: return(FAILED); @@ -284,7 +284,7 @@ *p++ = IAC; *p++ = SE; printsub('>', &fbp->fb_feed[2], p - &fbp->fb_feed[2]); - net_write(fbp->fb_feed, p - fbp->fb_feed); + telnet_net_write(fbp->fb_feed, p - fbp->fb_feed); state = fbp->state[DIR_DECRYPT-1] = IN_PROGRESS; break; @@ -309,7 +309,7 @@ *p++ = IAC; *p++ = SE; printsub('>', &fbp->fb_feed[2], p - &fbp->fb_feed[2]); - net_write(fbp->fb_feed, p - fbp->fb_feed); + telnet_net_write(fbp->fb_feed, p - fbp->fb_feed); break; } diff -ur crypto/telnet.orig/libtelnet/encrypt.c crypto/telnet/libtelnet/encrypt.c --- crypto/telnet.orig/libtelnet/encrypt.c Sat Apr 13 12:59:07 2002 +++ crypto/telnet/libtelnet/encrypt.c Thu Jan 2 18:06:50 2003 @@ -427,7 +427,7 @@ */ if (!Server && autodecrypt) encrypt_send_request_start(); - net_write(str_send, str_suplen); + telnet_net_write(str_send, str_suplen); printsub('>', &str_send[2], str_suplen - 2); str_suplen = 0; } @@ -773,7 +773,7 @@ } *strp++ = IAC; *strp++ = SE; - net_write(str_keyid, strp - str_keyid); + telnet_net_write(str_keyid, strp - str_keyid); printsub('>', &str_keyid[2], strp - str_keyid - 2); } @@ -832,7 +832,7 @@ } *p++ = IAC; *p++ = SE; - net_write(str_start, p - str_start); + telnet_net_write(str_start, p - str_start); net_encrypt(); printsub('>', &str_start[2], p - &str_start[2]); /* @@ -858,7 +858,7 @@ return; str_end[3] = ENCRYPT_END; - net_write(str_end, sizeof(str_end)); + telnet_net_write(str_end, sizeof(str_end)); net_encrypt(); printsub('>', &str_end[2], sizeof(str_end) - 2); /* @@ -886,7 +886,7 @@ } *p++ = IAC; *p++ = SE; - net_write(str_start, p - str_start); + telnet_net_write(str_start, p - str_start); printsub('>', &str_start[2], p - &str_start[2]); if (encrypt_debug_mode) printf(">>>%s: Request input to be encrypted\r\n", Name); @@ -896,7 +896,7 @@ encrypt_send_request_end(void) { str_end[3] = ENCRYPT_REQEND; - net_write(str_end, sizeof(str_end)); + telnet_net_write(str_end, sizeof(str_end)); printsub('>', &str_end[2], sizeof(str_end) - 2); if (encrypt_debug_mode) diff -ur crypto/telnet.orig/libtelnet/kerberos.c crypto/telnet/libtelnet/kerberos.c --- crypto/telnet.orig/libtelnet/kerberos.c Sat Apr 13 12:59:07 2002 +++ crypto/telnet/libtelnet/kerberos.c Thu Jan 2 18:06:51 2003 @@ -126,7 +126,7 @@ *p++ = SE; if (str_data[3] == TELQUAL_IS) printsub('>', &str_data[2], p - (&str_data[2])); - return(net_write(str_data, p - str_data)); + return(telnet_net_write(str_data, p - str_data)); } int diff -ur crypto/telnet.orig/libtelnet/kerberos5.c crypto/telnet/libtelnet/kerberos5.c --- crypto/telnet.orig/libtelnet/kerberos5.c Sat Apr 13 12:59:07 2002 +++ crypto/telnet/libtelnet/kerberos5.c Thu Jan 2 18:06:51 2003 @@ -128,7 +128,7 @@ *p++ = SE; if (str_data[3] == TELQUAL_IS) printsub('>', &str_data[2], p - &str_data[2]); - return(net_write(str_data, p - str_data)); + return(telnet_net_write(str_data, p - str_data)); } int @@ -193,6 +193,8 @@ else ap_opts = 0; + ap_opts |= AP_OPTS_USE_SUBKEY; + ret = krb5_auth_con_init (context, &auth_context); if (ret) { if (auth_debug_mode) { @@ -406,6 +408,29 @@ printf("Kerberos V5: " "krb5_auth_con_getremotesubkey failed (%s)\r\n", krb5_get_err_text(context, ret)); + return; + } + + if (key_block == NULL) { + ret = krb5_auth_con_getkey(context, + auth_context, + &key_block); + } + if (ret) { + Data(ap, KRB_REJECT, "krb5_auth_con_getkey failed", -1); + auth_finished(ap, AUTH_REJECT); + if (auth_debug_mode) + printf("Kerberos V5: " + "krb5_auth_con_getkey failed (%s)\r\n", + krb5_get_err_text(context, ret)); + return; + } + if (key_block == NULL) { + Data(ap, KRB_REJECT, "no subkey received", -1); + auth_finished(ap, AUTH_REJECT); + if (auth_debug_mode) + printf("Kerberos V5: " + "krb5_auth_con_getremotesubkey returned NULL key\r\n"); return; } diff -ur crypto/telnet.orig/libtelnet/krb4encpwd.c crypto/telnet/libtelnet/krb4encpwd.c --- crypto/telnet.orig/libtelnet/krb4encpwd.c Sat Apr 13 12:59:07 2002 +++ crypto/telnet/libtelnet/krb4encpwd.c Thu Jan 2 18:06:52 2003 @@ -146,7 +146,7 @@ *p++ = SE; if (str_data[3] == TELQUAL_IS) printsub('>', &str_data[2], p - (&str_data[2])); - return(net_write(str_data, p - str_data)); + return(telnet_net_write(str_data, p - str_data)); } int diff -ur crypto/telnet.orig/libtelnet/misc-proto.h crypto/telnet/libtelnet/misc-proto.h --- crypto/telnet.orig/libtelnet/misc-proto.h Sat Apr 13 12:59:07 2002 +++ crypto/telnet/libtelnet/misc-proto.h Thu Jan 2 18:06:52 2003 @@ -71,7 +71,7 @@ /* * These functions are imported from the application */ -int net_write(unsigned char *, int); +int telnet_net_write(unsigned char *, int); void net_encrypt(void); int telnet_spin(void); char *telnet_getenv(char *); diff -ur crypto/telnet.orig/libtelnet/rsaencpwd.c crypto/telnet/libtelnet/rsaencpwd.c --- crypto/telnet.orig/libtelnet/rsaencpwd.c Sat Apr 13 12:59:07 2002 +++ crypto/telnet/libtelnet/rsaencpwd.c Thu Jan 2 18:06:52 2003 @@ -142,7 +142,7 @@ *p++ = SE; if (str_data[3] == TELQUAL_IS) printsub('>', &str_data[2], p - (&str_data[2])); - return(net_write(str_data, p - str_data)); + return(telnet_net_write(str_data, p - str_data)); } int diff -ur crypto/telnet.orig/libtelnet/sra.c crypto/telnet/libtelnet/sra.c --- crypto/telnet.orig/libtelnet/sra.c Thu May 16 10:46:49 2002 +++ crypto/telnet/libtelnet/sra.c Thu Jan 2 18:06:53 2003 @@ -106,7 +106,7 @@ *p++ = SE; if (str_data[3] == TELQUAL_IS) printsub('>', &str_data[2], p - (&str_data[2])); - return(net_write(str_data, p - str_data)); + return(telnet_net_write(str_data, p - str_data)); } int diff -ur crypto/telnet.orig/telnet/authenc.c crypto/telnet/telnet/authenc.c --- crypto/telnet.orig/telnet/authenc.c Sat Apr 13 12:59:08 2002 +++ crypto/telnet/telnet/authenc.c Thu Jan 2 18:06:53 2003 @@ -55,7 +55,7 @@ #include "types.h" int -net_write(unsigned char *str, int len) +telnet_net_write(unsigned char *str, int len) { if (NETROOM() > len) { ring_supply_data(&netoring, str, len); diff -ur crypto/telnet.orig/telnetd/authenc.c crypto/telnet/telnetd/authenc.c --- crypto/telnet.orig/telnetd/authenc.c Sat Apr 13 12:59:08 2002 +++ crypto/telnet/telnetd/authenc.c Thu Jan 2 18:06:54 2003 @@ -47,7 +47,7 @@ #include int -net_write(unsigned char *str, int len) +telnet_net_write(unsigned char *str, int len) { if (nfrontp + len < netobuf + BUFSIZ) { output_datalen(str, len); --------------D1C7367BBBD2CF5FAB51F35F-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message From owner-freebsd-bugs Thu Jan 2 11:40: 7 2003 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2605437B405 for ; Thu, 2 Jan 2003 11:40:07 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id D68E343F0F for ; Thu, 2 Jan 2003 11:40:03 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id h02Je3NS074660 for ; Thu, 2 Jan 2003 11:40:03 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.6/8.12.6/Submit) id h02Je3DI074659; Thu, 2 Jan 2003 11:40:03 -0800 (PST) Date: Thu, 2 Jan 2003 11:40:03 -0800 (PST) Message-Id: <200301021940.h02Je3DI074659@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: Bjorn Gronvall Subject: Re: bin/45397: Telnet dumps core when MAKE_KERBEROS5=yes is enabled Reply-To: Bjorn Gronvall Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org The following reply was made to PR bin/45397; it has been noted by GNATS. From: Bjorn Gronvall To: freebsd-gnats-submit@FreeBSD.org, ari.suutari@syncrontech.com Cc: Subject: Re: bin/45397: Telnet dumps core when MAKE_KERBEROS5=yes is enabled Date: Thu, 02 Jan 2003 20:29:53 +0100 There is no user bg@effnet.com! Please reply to bg@sics.se. Sorry for the inconvenience, Björn To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message From owner-freebsd-bugs Thu Jan 2 16:30: 5 2003 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D958737B401 for ; Thu, 2 Jan 2003 16:30:04 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 772A043EC5 for ; Thu, 2 Jan 2003 16:30:04 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id h030U4NS067644 for ; Thu, 2 Jan 2003 16:30:04 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.6/8.12.6/Submit) id h030U4P1067643; Thu, 2 Jan 2003 16:30:04 -0800 (PST) Date: Thu, 2 Jan 2003 16:30:04 -0800 (PST) Message-Id: <200301030030.h030U4P1067643@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: Christophe Prevotaux Subject: Re: misc/46694: Getting DUP packets when in Promiscous mode on wi0 Reply-To: Christophe Prevotaux Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org The following reply was made to PR misc/46694; it has been noted by GNATS. From: Christophe Prevotaux To: freebsd-gnats-submit@FreeBSD.org, c.prevotaux@hexanet.fr Cc: Subject: Re: misc/46694: Getting DUP packets when in Promiscous mode on wi0 Date: Fri, 03 Jan 2003 01:25:31 +0100 It seems it is also the case on ethernet cards when used in promiscuous mode. -- =============================================================== Christophe Prevotaux =============================================================== To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message From owner-freebsd-bugs Thu Jan 2 18:50:15 2003 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7E43237B401; Thu, 2 Jan 2003 18:50:14 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2AE8543EB2; Thu, 2 Jan 2003 18:50:14 -0800 (PST) (envelope-from des@FreeBSD.org) Received: from freefall.freebsd.org (des@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id h032oENS008937; Thu, 2 Jan 2003 18:50:14 -0800 (PST) (envelope-from des@freefall.freebsd.org) Received: (from des@localhost) by freefall.freebsd.org (8.12.6/8.12.6/Submit) id h032oD8n008927; Thu, 2 Jan 2003 18:50:13 -0800 (PST) Date: Thu, 2 Jan 2003 18:50:13 -0800 (PST) From: Dag-Erling Smorgrav Message-Id: <200301030250.h032oD8n008927@freefall.freebsd.org> To: mbsd@pacbell.net, des@FreeBSD.org, freebsd-bugs@FreeBSD.org Subject: Re: bin/46628: rshd crash, openpam bug, patch included Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Synopsis: rshd crash, openpam bug, patch included State-Changed-From-To: open->closed State-Changed-By: des State-Changed-When: Thu Jan 2 18:50:13 PST 2003 State-Changed-Why: Fixed, thanks. http://www.freebsd.org/cgi/query-pr.cgi?pr=46628 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message From owner-freebsd-bugs Thu Jan 2 22:40: 6 2003 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E888137B408 for ; Thu, 2 Jan 2003 22:40:03 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id B77BB43EA9 for ; Thu, 2 Jan 2003 22:40:02 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id h036e2NS082612 for ; Thu, 2 Jan 2003 22:40:02 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.6/8.12.6/Submit) id h036e2gT082609; Thu, 2 Jan 2003 22:40:02 -0800 (PST) Date: Thu, 2 Jan 2003 22:40:02 -0800 (PST) Message-Id: <200301030640.h036e2gT082609@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: Mike Meyer Subject: Re: bin/46629: md5 checking is a PITA. Reply-To: Mike Meyer Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org The following reply was made to PR bin/46629; it has been noted by GNATS. From: Mike Meyer To: "Sergey N. Voronkov" Cc: FreeBSD-gnats-submit@FreeBSD.ORG Subject: Re: bin/46629: md5 checking is a PITA. Date: Fri, 3 Jan 2003 00:31:57 -0600 In <20021231042916.GA4654@sv.tech.sibitex.tmn.ru>, Sergey N. Voronkov typed: > On Mon, Dec 30, 2002 at 08:31:08AM -0000, Mike Meyer wrote: > > >Description: > > Checking md5 checksums is an error-prone process. > > >How-To-Repeat: > > Download something that includes the output of md5 as a CHECKSUMS > > file. Notice that to confirm the checksum requires verifying the > > rather long and unpatterned checksum string by eye. > > >Fix: > > > > md5 should have a "-c file" option, which expects the output of md5 to > > be in file, and confirms that the files listed in "file" exist and match > > the associated checksums. > > > > Yes, this requires trusting the mdd5 binary. On the other hand, very few > > things one is interested in downloading don't require trusting some > > system utility, like the c compiler. So this is at worst a marginal change > > in the security given by the md5 checksums to start yes. > > > > Yes, this is trivial to script. It shouldn't be required of every user. > > > > Finally, FWIW, I have an Eiffel version of md5 that implements the > > -c option, but is missing the standard options of md5. It's available > > on request. > > > > #cd /var/ftp/pub/FreeBSD/releases/i386/4.7-RELEASE-p2/bin/ > #md5 [a-z]* | diff - CHECKSUM.MD5 > > Looks like verifying is simple with current version. :-)) No, one special case is very simple. Your example quits working as soon as any of the tarballs start with an upper case letter, or if the md5 sum file doesn't have the files in ascii sort order, or if some of the files listed are in subdirectories - all of which md5 will gladly do if invoked. For instance, I did: /sbin/md5 xc/* LimeWireLinux.tgz > CHECKSUM.MD5 and generated an CHECKSUM.MD5 file that does all three of those things. Having to recreate the arguments handed to md5 to get correct results is silly when MD5 already has all the information it needs to check the files listed in the MD5 file. http://www.mired.org/consulting.html Independent WWW/Perforce/FreeBSD/Unix consultant, email for more information. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message From owner-freebsd-bugs Fri Jan 3 0:10:11 2003 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4FC2A37B405 for ; Fri, 3 Jan 2003 00:10:10 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0405543EC2 for ; Fri, 3 Jan 2003 00:10:10 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id h038A9NS014876 for ; Fri, 3 Jan 2003 00:10:09 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.6/8.12.6/Submit) id h038A9LO014875; Fri, 3 Jan 2003 00:10:09 -0800 (PST) Date: Fri, 3 Jan 2003 00:10:09 -0800 (PST) Message-Id: <200301030810.h038A9LO014875@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: Scott Christopher Dodson Subject: Re: kern/45483: Invalid MAC reported by new Linksys LNE-100TX (dc) Reply-To: Scott Christopher Dodson Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org The following reply was made to PR kern/45483; it has been noted by GNATS. From: Scott Christopher Dodson To: Cc: Subject: Re: kern/45483: Invalid MAC reported by new Linksys LNE-100TX (dc) Date: Fri, 3 Jan 2003 03:05:38 -0500 (EST) I'm having the same problem with an older revision of this card under 5-Current. This is one of the initial revisions of the card I believe. dc0: port 0xcc00-0xccff mem 0xdf000000-0xdf0000ff irq 10 at device 17.0 on pci0 dc0: Ethernet address: 00:00:00:00:00:00 miibus0: on dc0 dcphy0: on miibus0 dcphy0: 10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, auto FreeBSD home.sdodson.com 5.0-CURRENT FreeBSD 5.0-CURRENT #17: Sun Dec 29 22:15:11 EST 2002 sdodson@home.sdodson.com:/usr/obj/usr/src/sys/RAGE2 i386 ----------------------------------------- This email was sent using SquirrelMail. "Georgia Southern University" http://www.gasou.edu/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message From owner-freebsd-bugs Fri Jan 3 4: 0: 8 2003 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F1FE037B401 for ; Fri, 3 Jan 2003 04:00:04 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id AA88043EE1 for ; Fri, 3 Jan 2003 04:00:03 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id h03C03NS084506 for ; Fri, 3 Jan 2003 04:00:03 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.6/8.12.6/Submit) id h03C03BF084500; Fri, 3 Jan 2003 04:00:03 -0800 (PST) Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D744437B401 for ; Fri, 3 Jan 2003 03:58:32 -0800 (PST) Received: from kandojozsef-bkp.iif.hu (kandojozsef-bkp.iif.hu [193.6.21.134]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0B02043E4A for ; Fri, 3 Jan 2003 03:58:32 -0800 (PST) (envelope-from root@kandojozsef-bkp.iif.hu) Received: from kandojozsef-bkp.iif.hu (localhost.fsn.hu [127.0.0.1]) by kandojozsef-bkp.iif.hu (8.12.6/8.12.6) with ESMTP id h03BGQBM000720 for ; Fri, 3 Jan 2003 12:16:26 +0100 (CET) (envelope-from root@kandojozsef-bkp.iif.hu) Received: (from root@localhost) by kandojozsef-bkp.iif.hu (8.12.6/8.12.6/Submit) id h03BGQSv000719; Fri, 3 Jan 2003 12:16:26 +0100 (CET) Message-Id: <200301031116.h03BGQSv000719@kandojozsef-bkp.iif.hu> Date: Fri, 3 Jan 2003 12:16:26 +0100 (CET) From: bra@fsn.hu To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: kern/46720: This is the result of Netgraph FEC, tcpdump running and an ICMP ping to the host. Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org >Number: 46720 >Category: kern >Synopsis: This is the result of Netgraph FEC, tcpdump running and an ICMP ping to the host. >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Jan 03 04:00:02 PST 2003 >Closed-Date: >Last-Modified: >Originator: Nagy Attila >Release: FreeBSD 5.0-RC i386 >Organization: individual >Environment: System: FreeBSD test.fsn.hu 5.0-RC FreeBSD 5.0-RC #9: Thu Jan 2 17:48:21 CET 2003 root@test.fsn.hu:/usr/obj/usr/src/sys/TEST i386 >Description: FreeBSD 5.0 contains the Cisco Fast EtherChannel (FEC) Netgraph node, originally written by wpaul@freebsd.org. This node does not work on 5.0 and produces a page fault when trying to test it out by running a tcpdump on the fec0 interface and while receiving an ICMP echo request (ping). >How-To-Repeat: kldload ng_fec ngctl mkpeer fec dummy fec ngctl msg fec0: add_iface '"fxp0"' ngctl msg fec0: add_iface '"fxp1"' ngctl msg fec0: set_mode_inet ifconfig fec0 a.b.c.d netmask q.w.e.r up route add default t.y.u.i tcpdump -i fec0 ping a.b.c.d from another host >Fix: The kernel crashdump and gdb "where" follows here: --- uname begins here --- test# uname -a FreeBSD test.fsn.hu 5.0-RC FreeBSD 5.0-RC #9: Thu Jan 2 17:48:21 CET 2003 root@test.fsn.hu:/usr/obj/usr/src/sys/TEST i386 test# gdb -k kernel.debug.20030102 vmcore.0 GNU gdb 5.2.1 (FreeBSD) Copyright 2002 Free Software Foundation, Inc. GDB is free software, covered by the GNU General Public License, and you are welcome to change it and/or distribute copies of it under certain conditions. Type "show copying" to see the conditions. There is absolutely no warranty for GDB. Type "show warranty" for details. This GDB was configured as "i386-undermydesk-freebsd"... panic: bwrite: buffer is not busy??? panic messages: --- Fatal trap 12: page fault while in kernel mode fault virtual address = 0x1 fault code = supervisor read, page not present instruction pointer = 0x8:0xc02ca7ee stack pointer = 0x10:0xd69aeb88 frame pointer = 0x10:0xd69aebb0 code segment = base 0x0, limit 0xfffff, type 0x1b = DPL 0, pres 1, def32 1, gran 1 processor eflags = interrupt enabled, resume, IOPL = 0 current process = 24 (irq12: fxp1 sym0) trap number = 12 panic: page fault syncing disks, buffers remaining... panic: bwrite: buffer is not busy??? Uptime: 4m27s amr0: flushing cache...done Dumping 511 MB 16 32 48 64 80 96 112 128 144 160 176 192 208 224 240 256 272 288 304 320 336 352 368 384 400 416 432 448 464 480 496 --- #0 doadump () at /usr/src/sys/kern/kern_shutdown.c:232 232 dumping++; (kgdb) where #0 doadump () at /usr/src/sys/kern/kern_shutdown.c:232 #1 0xc01ce342 in boot (howto=260) at /usr/src/sys/kern/kern_shutdown.c:364 #2 0xc01ce583 in panic () at /usr/src/sys/kern/kern_shutdown.c:517 #3 0xc02139a2 in bwrite (bp=0xce603950) at /usr/src/sys/kern/vfs_bio.c:796 #4 0xc0215085 in vfs_bio_awrite (bp=0xce603950) at /usr/src/sys/kern/vfs_bio.c:1643 #5 0xc0197c91 in spec_fsync (ap=0xd69ae980) at /usr/src/sys/fs/specfs/spec_vnops.c:462 #6 0xc0196ff8 in spec_vnoperate (ap=0x0) at /usr/src/sys/fs/specfs/spec_vnops.c:126 #7 0xc0273541 in ffs_sync (mp=0xc4057400, waitfor=2, cred=0xc150ae80, td=0xc031b840) at vnode_if.h:612 #8 0xc0228c1b in sync (td=0xc031b840, uap=0x0) at /usr/src/sys/kern/vfs_syscalls.c:138 #9 0xc01cdf2c in boot (howto=256) at /usr/src/sys/kern/kern_shutdown.c:273 #10 0xc01ce583 in panic () at /usr/src/sys/kern/kern_shutdown.c:517 #11 0xc02cc632 in trap_fatal (frame=0xd69aeb48, eva=0) at /usr/src/sys/i386/i386/trap.c:844 #12 0xc02cc312 in trap_pfault (frame=0xd69aeb48, usermode=0, eva=1) at /usr/src/sys/i386/i386/trap.c:758 #13 0xc02cbe00 in trap (frame= {tf_fs = -694550504, tf_es = -1071841264, tf_ds = -1069416432, tf_edi = -1005170670, tf_esi = 1, tf_ebp = -694490192, tf_isp = -694490252, tf_ebx = 14, tf_edx = 18, tf_ecx = 3, tf_eax = -1005170671, tf_trapno = 12, tf_err = 0, tf_eip ---Type to continue, or q to quit--- = -1070815250, tf_cs = 8, tf_eflags = 66071, tf_esp = 74, tf_ss = -694490084}) at /usr/src/sys/i386/i386/trap.c:445 #14 0xc02bc618 in calltrap () at {standard input}:98 #15 0xc02355f2 in catchpacket (d=0x1, pkt=0x0, pktlen=74, snaplen=0, cpfn=0xc0235250 ) at /usr/src/sys/net/bpf.c:1216 #16 0xc02353cb in bpf_mtap (bp=0xc42c7080, m=0xd69aec1c) at /usr/src/sys/net/bpf.c:1141 #17 0xc03d68f4 in ?? () #18 0xc023931b in ether_input (ifp=0xc417fc00, m=0xc1542100) at /usr/src/sys/net/if_ethersubr.c:601 #19 0xc0170ce9 in fxp_intr_body (sc=0xc4028000, statack=64 '@', count=-1) at /usr/src/sys/dev/fxp/if_fxp.c:1357 #20 0xc0170b3a in fxp_intr (xsc=0xc4028000) at /usr/src/sys/dev/fxp/if_fxp.c:1228 #21 0xc01b9ef1 in ithread_loop (arg=0xc4020300) at /usr/src/sys/kern/kern_intr.c:535 #22 0xc01b8e03 in fork_exit (callout=0xc01b9d20 , arg=0x0, frame=0x0) at /usr/src/sys/kern/kern_fork.c:872 (kgdb) quit --- uname ends here --- >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message From owner-freebsd-bugs Fri Jan 3 8:50: 6 2003 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5931D37B405 for ; Fri, 3 Jan 2003 08:50:03 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id EF7FF43ED8 for ; Fri, 3 Jan 2003 08:50:01 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id h03Go1NS049650 for ; Fri, 3 Jan 2003 08:50:01 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.6/8.12.6/Submit) id h03Go1QH049649; Fri, 3 Jan 2003 08:50:01 -0800 (PST) Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F342837B401 for ; Fri, 3 Jan 2003 08:40:15 -0800 (PST) Received: from mail.darq.net (phear.darq.net [213.253.1.14]) by mx1.FreeBSD.org (Postfix) with SMTP id 8283343ED4 for ; Fri, 3 Jan 2003 08:40:14 -0800 (PST) (envelope-from kaneda@darq.net) Received: (qmail 5457 invoked by uid 1010); 3 Jan 2003 16:40:10 -0000 Message-Id: <20030103164010.A5004@phear.darq.net> Date: Fri, 3 Jan 2003 16:40:10 +0000 From: Richard Airlie Reply-To: Richard Airlie To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: kern/46734: joystick driver doesn't allow for anything but joy0 Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org >Number: 46734 >Category: kern >Synopsis: joystick driver doesn't allow for anything but joy0 >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Jan 03 08:50:01 PST 2003 >Closed-Date: >Last-Modified: >Originator: Richard Airlie >Release: FreeBSD 4.7-STABLE i386 >Organization: >Environment: System: FreeBSD kenya.darq.net 4.7-STABLE FreeBSD 4.7-STABLE #44: Fri Dec 20 19:20:23 GMT 2002 root@kenya.darq.net:/usr/src/sys/compile/KENYA i386 3-Axis 4 button analogue joystick connected to ISA game port on PCI sound card. >Description: The ISA game port allows for 4 axes and 4 buttons, which FreeBSD logically splits into 2 joystick devices, each with 2 axes and 2 buttons. However it is not actually possible to have both joy0 and joy1 at port IO_GAME, because joy_attach() in joy.c calls bus_alloc_resource with RF_ACTIVE. Changing this to RF_ACTIVE|RF_SHAREABLE allows both joy0 and joy1 to share the resource. Also, the joystick driver always uses 0 as the minor device number to make_dev, meaning that only joy0 ever gets attached by joy_attach(). Finally, there is a further problem I encountered whereby reading the game port too quickly gave unreliable results. What seems to be happening is: - A read of /dev/joy0 causes a byte to be written to the game port, causing the timing of all 4 axes to begin. - We wait in a loop until the two bits corresponding to the X and Y axes of joy0 have gone low, then return the results to userland. - A read of /dev/joy1 causes a byte to be written to the game port, causing the timing of all 4 axes to begin. HOWEVER! a timing may already be in progress at this point, since we only waited for the bits corresponding to joy0's axes to go low last time. By waiting for the previous timing to finish before starting a new one this problem disappears. Unfortunately I do not have access to a 4 axis stick to test this more thoroughly From looking at the same code in -CURRENT, it appears that this problem will also be seen there. >How-To-Repeat: 1) On a machine with an ISA game port, build a kernel with the following: device joy0 at isa? port IO_GAME device joy1 at isa? port IO_GAME 2) Reboot with this kernel and try to open /dev/joy1 (eg: cat /dev/joy1 |hexdump). It will not be possible as joy1 is not successfully attached. >Fix: --- usr/src/sys/isa/joy.c Tue Dec 17 10:50:50 2002 +++ /home/kaneda/joy_fix.c Tue Dec 17 10:52:44 2002 @@ -134,13 +134,13 @@ struct resource *res; struct joy_softc *joy = device_get_softc(dev); - res = bus_alloc_resource(dev, SYS_RES_IOPORT, &rid, 0, ~0, 1, RF_ACTIVE); + res = bus_alloc_resource(dev, SYS_RES_IOPORT, &rid, 0, ~0, 1, RF_ACTIVE|RF_SHAREABLE); if (res == NULL) return ENXIO; joy->bt = rman_get_bustag(res); joy->port = rman_get_bushandle(res); joy->timeout[0] = joy->timeout[1] = 0; - make_dev(&joy_cdevsw, 0, 0, 0, 0600, "joy%d", unit); + make_dev(&joy_cdevsw, unit, 0, 0, 0600, "joy%d", unit); return 0; } @@ -198,6 +198,12 @@ #else disable_intr (); #endif + nanotime(&t); + end.tv_sec = 0; + end.tv_nsec = joy->timeout[joypart(dev)] * 1000; + timespecadd(&end, &t); + for( ; timespeccmp(&t, &end, <) && (bus_space_read_1(bt, port, 0) & 0x0f); nanotime(&t) ); + bus_space_write_1 (bt, port, 0, 0xff); nanotime(&start); end.tv_sec = 0; >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message From owner-freebsd-bugs Fri Jan 3 9:40: 9 2003 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C8A8F37B401 for ; Fri, 3 Jan 2003 09:40:02 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id D8F3643ED4 for ; Fri, 3 Jan 2003 09:40:01 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id h03He1NS066536 for ; Fri, 3 Jan 2003 09:40:01 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.6/8.12.6/Submit) id h03He1R0066535; Fri, 3 Jan 2003 09:40:01 -0800 (PST) Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1A94737B401; Fri, 3 Jan 2003 09:31:05 -0800 (PST) Received: from grosbein.pp.ru (www2.svzserv.kemerovo.su [213.184.65.86]) by mx1.FreeBSD.org (Postfix) with ESMTP id B39E243EA9; Fri, 3 Jan 2003 09:30:53 -0800 (PST) (envelope-from eugen@grosbein.pp.ru) Received: from grosbein.pp.ru (eugen@localhost [127.0.0.1]) by grosbein.pp.ru (8.12.6/8.12.6) with ESMTP id h03HTcxg042651; Sat, 4 Jan 2003 00:29:38 +0700 (KRAT) (envelope-from eugen@grosbein.pp.ru) Received: (from eugen@localhost) by grosbein.pp.ru (8.12.6/8.12.6/Submit) id h03HTc5W042650; Sat, 4 Jan 2003 00:29:38 +0700 (KRAT) Message-Id: <200301031729.h03HTc5W042650@grosbein.pp.ru> Date: Sat, 4 Jan 2003 00:29:38 +0700 (KRAT) From: Eugene.Grosbein@grosbein.pp.ru To: FreeBSD-gnats-submit@FreeBSD.org Cc: multimedia@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: kern/46736: ISA audio CS4232 (HP Omnibook 5000C) work only once Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org >Number: 46736 >Category: kern >Synopsis: ISA audio CS4232 (HP Omnibook 5000C) work only once >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Jan 03 09:40:01 PST 2003 >Closed-Date: >Last-Modified: >Originator: Eugene Grosbein >Release: FreeBSD 4.7-STABLE i386 >Organization: Private person >Environment: System: FreeBSD hp.grosbein.pp.ru 4.7-STABLE FreeBSD 4.7-STABLE #5: Fri Jan 3 22:51:17 KRAT 2003 root@hp.grosbein.pp.ru:/usr/src/sys/compile/HP i386 HP OmniBook 5000C without accumulator, ISA audio card CS4232, pcm(4) kernel driver, apm is not enabled. >Description: My HP Omnibook 5000C has built-in ISA sound card CS4232 that is properly detected by a kernel. I use mpg123 from ports to play MP3's. It plays a file OK but only once. If I run it second time, it pretends to work but there is no sound, top(1) shows that mpg123 spends all the time in RUN state (it spends lots of time in pcmwrite first time) and a message is written to console: pcm0:play:0: play interrupt timeout, channel dead Plain reboot does NOT revive audio playback. Note: after reboot my PCMCIA 3com Etherlink III ethernet card will NOT be detected by pccardd as usual uless I manually run 'pccardc enabler'. I have two options: 1. This system doesn't have a battry, so I can halt it and disconect AC power supply for short period of time. NP: this system preserves dmesg(8) output between several plain reboots. -or- 2. This system is dual-boot, so I can just reboot to Windows95 and go back to FreeBSD without turning power off. Sound is revived after one of these two actions and 3com card is detected by pccardd automatically. But, again, until next usage of audio only. It seems there is a bug in a driver. Here is some info about my system: # cat at io 0x534 irq 5 drq 1:0 bufsz 4096 (1p/1r/0v channels duplex) # cat real memory = 16777216 (16384K bytes) sio0: gdb debugging port avail memory = 13156352 (12848K bytes) Preloaded elf kernel "kernel" at 0xc0331000. Intel Pentium detected, installing workaround for F00F bug VESA: v1.2, 960k memory, flags:0x0, mode table:0xc00c36b1 (c00036b1) VESA: CHIPS 65520/525/530 Flat Panel VGA npx0: on motherboard npx0: INT 16 interface pcib0: on motherboard pci0: on pcib0 isab0: at device 1.0 on pci0 isa0: on isab0 pci0: at 2.0 pcic0: port 0x3400-0x3403 at device 3.0 on pci0 pcic0: Polling mode pccard0: on pcic0 pccard1: on pcic0 orm0: