Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 28 Sep 2003 21:24:35 -0700 (PDT)
From:      Sam Leffler <sam@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 38769 for review
Message-ID:  <200309290424.h8T4OZsD024959@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=38769

Change 38769 by sam@sam_ebb on 2003/09/28 21:24:02

	One more time: rtrequest(RTM_DELETE...) locks the route so we cannot
	be holding it when we call it.  

Affected files ...

.. //depot/projects/netperf/sys/netinet/if_ether.c#9 edit

Differences ...

==== //depot/projects/netperf/sys/netinet/if_ether.c#9 (text+ko) ====

@@ -936,13 +936,14 @@
 		 * If this is the only references to a protocol
 		 * cloned route, remove it.
 		 */
+		RT_UNLOCK(rt);
 		if (rt->rt_refcnt == 1 && (rt->rt_flags & RTF_WASCLONED)) {
 			rtrequest(RTM_DELETE,
 					(struct sockaddr *)rt_key(rt),
 					rt->rt_gateway, rt_mask(rt),
 					rt->rt_flags, 0);
 		}
-		RTFREE_LOCKED(rt);
+		RTFREE(rt);
 		return (0);
 	} else {
 		rt->rt_refcnt--;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200309290424.h8T4OZsD024959>