From owner-cvs-src@FreeBSD.ORG Sun Oct 17 01:08:11 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B7CBB16A4CE; Sun, 17 Oct 2004 01:08:11 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9715F43D2F; Sun, 17 Oct 2004 01:08:11 +0000 (GMT) (envelope-from tjr@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9H18Bpm050020; Sun, 17 Oct 2004 01:08:11 GMT (envelope-from tjr@repoman.freebsd.org) Received: (from tjr@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9H18Bql050019; Sun, 17 Oct 2004 01:08:11 GMT (envelope-from tjr) Message-Id: <200410170108.i9H18Bql050019@repoman.freebsd.org> From: "Tim J. Robbins" Date: Sun, 17 Oct 2004 01:08:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.bin/mklocale mklocale.1 yacc.y X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Oct 2004 01:08:11 -0000 tjr 2004-10-17 01:08:11 UTC FreeBSD src repository Modified files: usr.bin/mklocale mklocale.1 yacc.y Log: Remove explicit support for generating LC_CTYPE data files that specify the obsolete "UTF2" encoding. Revision Changes Path 1.24 +1 -7 src/usr.bin/mklocale/mklocale.1 1.22 +0 -1 src/usr.bin/mklocale/yacc.y From owner-cvs-src@FreeBSD.ORG Sun Oct 17 01:52:49 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 01BB516A4CE; Sun, 17 Oct 2004 01:52:49 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D770643D2F; Sun, 17 Oct 2004 01:52:48 +0000 (GMT) (envelope-from tjr@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9H1qm5O051367; Sun, 17 Oct 2004 01:52:48 GMT (envelope-from tjr@repoman.freebsd.org) Received: (from tjr@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9H1qmZg051366; Sun, 17 Oct 2004 01:52:48 GMT (envelope-from tjr) Message-Id: <200410170152.i9H1qmZg051366@repoman.freebsd.org> From: "Tim J. Robbins" Date: Sun, 17 Oct 2004 01:52:48 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libc Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Oct 2004 01:52:49 -0000 tjr 2004-10-17 01:52:48 UTC FreeBSD src repository Modified files: lib/libc Makefile Log: Bump the libc major version number to 6. Revision Changes Path 1.53 +1 -1 src/lib/libc/Makefile From owner-cvs-src@FreeBSD.ORG Sun Oct 17 02:12:51 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8588816A4CE; Sun, 17 Oct 2004 02:12:51 +0000 (GMT) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 668B443D1F; Sun, 17 Oct 2004 02:12:51 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.13.1/8.13.1) with ESMTP id i9H2Co1b020816; Sat, 16 Oct 2004 19:12:50 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.13.1/8.13.1/Submit) id i9H2CouM020811; Sat, 16 Oct 2004 19:12:50 -0700 (PDT) (envelope-from obrien) Date: Sat, 16 Oct 2004 19:12:50 -0700 From: "David O'Brien" To: "Tim J. Robbins" Message-ID: <20041017021250.GA20222@dragon.nuxi.com> References: <200410170152.i9H1qmZg051366@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200410170152.i9H1qmZg051366@repoman.freebsd.org> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 6.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Oct 2004 02:12:51 -0000 On Sun, Oct 17, 2004 at 01:52:48AM +0000, Tim J. Robbins wrote: > tjr 2004-10-17 01:52:48 UTC > > FreeBSD src repository > > Modified files: > lib/libc Makefile > Log: > Bump the libc major version number to 6. Why? This commit doesn't have any .c files in it; so what's the incompatable API change? -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Sun Oct 17 02:29:16 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3943216A4CE; Sun, 17 Oct 2004 02:29:16 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2DF5B43D1D; Sun, 17 Oct 2004 02:29:16 +0000 (GMT) (envelope-from tjr@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9H2TGGx052493; Sun, 17 Oct 2004 02:29:16 GMT (envelope-from tjr@repoman.freebsd.org) Received: (from tjr@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9H2TG3B052492; Sun, 17 Oct 2004 02:29:16 GMT (envelope-from tjr) Message-Id: <200410170229.i9H2TG3B052492@repoman.freebsd.org> From: "Tim J. Robbins" Date: Sun, 17 Oct 2004 02:29:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libc/locale Makefile.inc mbrune.3 multibyte.3 rune.3 setlocale.3 setrunelocale.c utf2.5 utf2.c utf8.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Oct 2004 02:29:16 -0000 tjr 2004-10-17 02:29:15 UTC FreeBSD src repository Modified files: lib/libc/locale Makefile.inc mbrune.3 multibyte.3 rune.3 setlocale.3 setrunelocale.c utf8.5 Removed files: lib/libc/locale utf2.5 utf2.c Log: Remove support for the obsolete UTF2 encoding. Revision Changes Path 1.58 +2 -2 src/lib/libc/locale/Makefile.inc 1.19 +0 -1 src/lib/libc/locale/mbrune.3 1.27 +0 -1 src/lib/libc/locale/multibyte.3 1.28 +0 -1 src/lib/libc/locale/rune.3 1.32 +0 -1 src/lib/libc/locale/setlocale.3 1.42 +0 -3 src/lib/libc/locale/setrunelocale.c 1.16 +0 -103 src/lib/libc/locale/utf2.5 (dead) 1.14 +0 -184 src/lib/libc/locale/utf2.c (dead) 1.6 +1 -21 src/lib/libc/locale/utf8.5 From owner-cvs-src@FreeBSD.ORG Sun Oct 17 03:02:51 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 083DA16A4CE; Sun, 17 Oct 2004 03:02:51 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7889243D67; Sun, 17 Oct 2004 03:02:50 +0000 (GMT) (envelope-from tjr@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9H32oJw053660; Sun, 17 Oct 2004 03:02:50 GMT (envelope-from tjr@repoman.freebsd.org) Received: (from tjr@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9H32ogZ053659; Sun, 17 Oct 2004 03:02:50 GMT (envelope-from tjr) Message-Id: <200410170302.i9H32ogZ053659@repoman.freebsd.org> From: "Tim J. Robbins" Date: Sun, 17 Oct 2004 03:02:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.bin/mklocale yacc.y X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Oct 2004 03:02:51 -0000 tjr 2004-10-17 03:02:50 UTC FreeBSD src repository Modified files: usr.bin/mklocale yacc.y Log: Use instead of since the latter is going away. Revision Changes Path 1.23 +2 -2 src/usr.bin/mklocale/yacc.y From owner-cvs-src@FreeBSD.ORG Sun Oct 17 05:08:30 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2C7C816A4CF; Sun, 17 Oct 2004 05:08:30 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id EB46343D45; Sun, 17 Oct 2004 05:08:29 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9H58TkS063836; Sun, 17 Oct 2004 05:08:29 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9H58TEK063835; Sun, 17 Oct 2004 05:08:29 GMT (envelope-from obrien) Message-Id: <200410170508.i9H58TEK063835@repoman.freebsd.org> From: "David E. O'Brien" Date: Sun, 17 Oct 2004 05:08:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/mk bsd.cpu.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Oct 2004 05:08:30 -0000 obrien 2004-10-17 05:08:29 UTC FreeBSD src repository Modified files: share/mk bsd.cpu.mk Log: + Simplify by treating the standard x86 CPU names as the CPUTYPE vs. treating them as an alias. Treat the shorthand versions as aliases. + Separate the x86 GCC CPU CFLAGS from the ICC CFLAGS. This greatly simplifies the GCC section. It also makes it more clear which CPU's have the same ICC CPU CFLAGS. + Remove redundancy in the alpha section. + Add forgotten ICC CPU CFLAGS for the mobile Intel CPU's added in rev. 1.42. Revision Changes Path 1.43 +46 -69 src/share/mk/bsd.cpu.mk From owner-cvs-src@FreeBSD.ORG Sun Oct 17 05:19:46 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1E54F16A4CE; Sun, 17 Oct 2004 05:19:46 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 00E7143D1F; Sun, 17 Oct 2004 05:19:46 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9H5Jjug064192; Sun, 17 Oct 2004 05:19:45 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9H5JjSY064191; Sun, 17 Oct 2004 05:19:45 GMT (envelope-from obrien) Message-Id: <200410170519.i9H5JjSY064191@repoman.freebsd.org> From: "David E. O'Brien" Date: Sun, 17 Oct 2004 05:19:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/mk bsd.cpu.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Oct 2004 05:19:46 -0000 obrien 2004-10-17 05:19:45 UTC FreeBSD src repository Modified files: share/mk bsd.cpu.mk Log: Embellish the AMD64 sections a little. Including supporting 'nocona'. Revision Changes Path 1.44 +20 -8 src/share/mk/bsd.cpu.mk From owner-cvs-src@FreeBSD.ORG Sun Oct 17 05:36:20 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BCD2B16A4CE; Sun, 17 Oct 2004 05:36:20 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9EE7543D39; Sun, 17 Oct 2004 05:36:20 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9H5aKmZ064839; Sun, 17 Oct 2004 05:36:20 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9H5aK8H064838; Sun, 17 Oct 2004 05:36:20 GMT (envelope-from obrien) Message-Id: <200410170536.i9H5aK8H064838@repoman.freebsd.org> From: "David E. O'Brien" Date: Sun, 17 Oct 2004 05:36:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/examples/etc make.conf X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Oct 2004 05:36:20 -0000 obrien 2004-10-17 05:36:20 UTC FreeBSD src repository Modified files: share/examples/etc make.conf Log: Catch up with share/mk/bsd.cpu.mk revision 1.43. Revision Changes Path 1.237 +6 -4 src/share/examples/etc/make.conf From owner-cvs-src@FreeBSD.ORG Sun Oct 17 06:51:51 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 284D016A4CE; Sun, 17 Oct 2004 06:51:51 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1AE7443D48; Sun, 17 Oct 2004 06:51:51 +0000 (GMT) (envelope-from tjr@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9H6po1h069782; Sun, 17 Oct 2004 06:51:50 GMT (envelope-from tjr@repoman.freebsd.org) Received: (from tjr@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9H6poLf069781; Sun, 17 Oct 2004 06:51:50 GMT (envelope-from tjr) Message-Id: <200410170651.i9H6poLf069781@repoman.freebsd.org> From: "Tim J. Robbins" Date: Sun, 17 Oct 2004 06:51:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/include Makefile rune.h src/lib/libc/locale Makefile.inc frune.c mblocal.h mbrune.3 mbrune.c rune.3 setinvalidrune.c setlocale.3 setrunelocale.c srune.c table.c src/usr.bin/mklocale mklocale.1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Oct 2004 06:51:51 -0000 tjr 2004-10-17 06:51:50 UTC FreeBSD src repository Modified files: include Makefile lib/libc/locale Makefile.inc mblocal.h setlocale.3 setrunelocale.c table.c usr.bin/mklocale mklocale.1 Removed files: include rune.h lib/libc/locale frune.c mbrune.3 mbrune.c rune.3 setinvalidrune.c srune.c Log: Remove the obsolete interface. Revision Changes Path 1.227 +1 -1 src/include/Makefile 1.6 +0 -68 src/include/rune.h (dead) 1.59 +4 -9 src/lib/libc/locale/Makefile.inc 1.7 +0 -83 src/lib/libc/locale/frune.c (dead) 1.4 +0 -8 src/lib/libc/locale/mblocal.h 1.20 +0 -174 src/lib/libc/locale/mbrune.3 (dead) 1.6 +0 -120 src/lib/libc/locale/mbrune.c (dead) 1.29 +0 -282 src/lib/libc/locale/rune.3 (dead) 1.6 +0 -51 src/lib/libc/locale/setinvalidrune.c (dead) 1.33 +2 -9 src/lib/libc/locale/setlocale.3 1.43 +3 -3 src/lib/libc/locale/setrunelocale.c 1.5 +0 -105 src/lib/libc/locale/srune.c (dead) 1.26 +2 -2 src/lib/libc/locale/table.c 1.25 +0 -2 src/usr.bin/mklocale/mklocale.1 From owner-cvs-src@FreeBSD.ORG Sun Oct 17 07:13:35 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 303D516A4CE; Sun, 17 Oct 2004 07:13:35 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1286143D31; Sun, 17 Oct 2004 07:13:35 +0000 (GMT) (envelope-from alfred@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9H7DY1Z070483; Sun, 17 Oct 2004 07:13:34 GMT (envelope-from alfred@repoman.freebsd.org) Received: (from alfred@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9H7DY0I070482; Sun, 17 Oct 2004 07:13:34 GMT (envelope-from alfred) Message-Id: <200410170713.i9H7DY0I070482@repoman.freebsd.org> From: Alfred Perlstein Date: Sun, 17 Oct 2004 07:13:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libc/sys recv.2 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Oct 2004 07:13:35 -0000 alfred 2004-10-17 07:13:34 UTC FreeBSD src repository Modified files: lib/libc/sys recv.2 Log: Document EMSGSIZE return from recvmsg due to insufficient free files when transfering rights (file descriptors.) Revision Changes Path 1.22 +10 -1 src/lib/libc/sys/recv.2 From owner-cvs-src@FreeBSD.ORG Sun Oct 17 09:48:24 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5AD4B16A4CE; Sun, 17 Oct 2004 09:48:24 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1730D43D1F; Sun, 17 Oct 2004 09:48:24 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9H9mN2I081740; Sun, 17 Oct 2004 09:48:23 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9H9mNIl081739; Sun, 17 Oct 2004 09:48:23 GMT (envelope-from ru) Message-Id: <200410170948.i9H9mNIl081739@repoman.freebsd.org> From: Ruslan Ermilov Date: Sun, 17 Oct 2004 09:48:23 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/mklocale Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Oct 2004 09:48:24 -0000 ru 2004-10-17 09:48:23 UTC FreeBSD src repository Modified files: share/mklocale Makefile Log: Utilize FILES and SYMLINKS. Revision Changes Path 1.62 +40 -46 src/share/mklocale/Makefile From owner-cvs-src@FreeBSD.ORG Sun Oct 17 10:49:30 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 74B6216A4CE; Sun, 17 Oct 2004 10:49:30 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5620A43D1F; Sun, 17 Oct 2004 10:49:30 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9HAnUul084950; Sun, 17 Oct 2004 10:49:30 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9HAnUXN084949; Sun, 17 Oct 2004 10:49:30 GMT (envelope-from ru) Message-Id: <200410171049.i9HAnUXN084949@repoman.freebsd.org> From: Ruslan Ermilov Date: Sun, 17 Oct 2004 10:49:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/msgdef Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Oct 2004 10:49:30 -0000 ru 2004-10-17 10:49:30 UTC FreeBSD src repository Modified files: share/msgdef Makefile Log: Utilize FILES and SYMLINKS. Revision Changes Path 1.61 +56 -137 src/share/msgdef/Makefile From owner-cvs-src@FreeBSD.ORG Sun Oct 17 11:07:03 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7B44616A4CE; Sun, 17 Oct 2004 11:07:03 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5ABA243D2D; Sun, 17 Oct 2004 11:07:03 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9HB735V086036; Sun, 17 Oct 2004 11:07:03 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9HB73d0086035; Sun, 17 Oct 2004 11:07:03 GMT (envelope-from ru) Message-Id: <200410171107.i9HB73d0086035@repoman.freebsd.org> From: Ruslan Ermilov Date: Sun, 17 Oct 2004 11:07:03 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/tools/regression/netinet/tcpconnect tcpconnect.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Oct 2004 11:07:03 -0000 ru 2004-10-17 11:07:03 UTC FreeBSD src repository Modified files: tools/regression/netinet/tcpconnect tcpconnect.c Log: Fixed a typo. Submitted by: Pawel Worach Revision Changes Path 1.2 +1 -1 src/tools/regression/netinet/tcpconnect/tcpconnect.c From owner-cvs-src@FreeBSD.ORG Sun Oct 17 13:19:10 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B2A2416A4CE; Sun, 17 Oct 2004 13:19:10 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9103043D31; Sun, 17 Oct 2004 13:19:10 +0000 (GMT) (envelope-from keramida@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9HDJA1F096367; Sun, 17 Oct 2004 13:19:10 GMT (envelope-from keramida@repoman.freebsd.org) Received: (from keramida@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9HDJAhQ096366; Sun, 17 Oct 2004 13:19:10 GMT (envelope-from keramida) Message-Id: <200410171319.i9HDJAhQ096366@repoman.freebsd.org> From: Giorgos Keramidas Date: Sun, 17 Oct 2004 13:19:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/man/man5 rc.conf.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Oct 2004 13:19:10 -0000 keramida 2004-10-17 13:19:10 UTC FreeBSD src repository (doc committer) Modified files: share/man/man5 rc.conf.5 Log: The populate_var variable checks /var for writability, not /tmp. Noticed by: Alan Gerber Revision Changes Path 1.228 +1 -1 src/share/man/man5/rc.conf.5 From owner-cvs-src@FreeBSD.ORG Sun Oct 17 13:39:42 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 698A216A4CE; Sun, 17 Oct 2004 13:39:42 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 491D143D2D; Sun, 17 Oct 2004 13:39:42 +0000 (GMT) (envelope-from schweikh@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9HDdgqd097370; Sun, 17 Oct 2004 13:39:42 GMT (envelope-from schweikh@repoman.freebsd.org) Received: (from schweikh@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9HDdg8p097367; Sun, 17 Oct 2004 13:39:42 GMT (envelope-from schweikh) Message-Id: <200410171339.i9HDdg8p097367@repoman.freebsd.org> From: Jens Schweikhardt Date: Sun, 17 Oct 2004 13:39:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/etc rc.shutdown X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Oct 2004 13:39:42 -0000 schweikh 2004-10-17 13:39:42 UTC FreeBSD src repository Modified files: etc rc.shutdown Log: Fix a bogus variable assignment. You can't expect _msg="a" \ " b" to concat the strings. Use _msg="a" _msg="$_msg b" instead (intent is to not exceed 80 chars per line). MFC after: 1 week Revision Changes Path 1.29 +2 -2 src/etc/rc.shutdown From owner-cvs-src@FreeBSD.ORG Sun Oct 17 14:36:31 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 12FA616A4CE; Sun, 17 Oct 2004 14:36:31 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E68B043D46; Sun, 17 Oct 2004 14:36:30 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9HEaUXP099063; Sun, 17 Oct 2004 14:36:30 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9HEaUDO099062; Sun, 17 Oct 2004 14:36:30 GMT (envelope-from obrien) Message-Id: <200410171436.i9HEaUDO099062@repoman.freebsd.org> From: "David E. O'Brien" Date: Sun, 17 Oct 2004 14:36:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin/pkg_install/add main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Oct 2004 14:36:31 -0000 obrien 2004-10-17 14:36:30 UTC FreeBSD src repository Modified files: usr.sbin/pkg_install/add main.c Log: Set the real limits on 5-current, add 5-stable, add 6-current. Revision Changes Path 1.60 +3 -1 src/usr.sbin/pkg_install/add/main.c From owner-cvs-src@FreeBSD.ORG Sun Oct 17 14:59:19 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 59BC416A4CE; Sun, 17 Oct 2004 14:59:19 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3319B43D64; Sun, 17 Oct 2004 14:59:18 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9HExIRt099812; Sun, 17 Oct 2004 14:59:18 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9HExIUY099811; Sun, 17 Oct 2004 14:59:18 GMT (envelope-from obrien) Message-Id: <200410171459.i9HExIUY099811@repoman.freebsd.org> From: "David E. O'Brien" Date: Sun, 17 Oct 2004 14:59:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src UPDATING X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Oct 2004 14:59:19 -0000 obrien 2004-10-17 14:59:18 UTC FreeBSD src repository Modified files: . UPDATING Log: Remove the suggestion to use libmap.conf to deal with the version bump. People have a tendency to add things to libmap.conf and forget about them (as we've seen in the mailing lists before). The compat4x port should be used instead. Revision Changes Path 1.374 +0 -10 src/UPDATING From owner-cvs-src@FreeBSD.ORG Sun Oct 17 15:08:27 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 631CB16A4CF; Sun, 17 Oct 2004 15:08:27 +0000 (GMT) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 039DF43D2D; Sun, 17 Oct 2004 15:08:27 +0000 (GMT) (envelope-from scottl@freebsd.org) Received: from [192.168.254.11] (junior-wifi.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.12.11/8.12.10) with ESMTP id i9HF8XKW034326; Sun, 17 Oct 2004 09:08:33 -0600 (MDT) (envelope-from scottl@freebsd.org) Message-ID: <41728A91.8090507@freebsd.org> Date: Sun, 17 Oct 2004 09:06:57 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.2) Gecko/20040929 X-Accept-Language: en-us, en MIME-Version: 1.0 To: "David E. O'Brien" References: <200410171459.i9HExIUY099811@repoman.freebsd.org> In-Reply-To: <200410171459.i9HExIUY099811@repoman.freebsd.org> X-Enigmail-Version: 0.86.1.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=0.0 required=3.8 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on pooker.samsco.org cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src UPDATING X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Oct 2004 15:08:27 -0000 David E. O'Brien wrote: > obrien 2004-10-17 14:59:18 UTC > > FreeBSD src repository > > Modified files: > . UPDATING > Log: > Remove the suggestion to use libmap.conf to deal with the version bump. > People have a tendency to add things to libmap.conf and forget about them > (as we've seen in the mailing lists before). > The compat4x port should be used instead. > > Revision Changes Path > 1.374 +0 -10 src/UPDATING Maybe this text couple have been replaced with text that suggests compat4x? Especially since these are no longer part of the base system. Scott From owner-cvs-src@FreeBSD.ORG Sun Oct 17 18:25:50 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 49D9B16A4CE; Sun, 17 Oct 2004 18:25:50 +0000 (GMT) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id D815043D31; Sun, 17 Oct 2004 18:25:49 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.13.1/8.13.1) with ESMTP id i9HIPnoj041913; Sun, 17 Oct 2004 11:25:49 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.13.1/8.13.1/Submit) id i9HIPmZQ041912; Sun, 17 Oct 2004 11:25:48 -0700 (PDT) (envelope-from obrien) Date: Sun, 17 Oct 2004 11:25:48 -0700 From: "David O'Brien" To: Scott Long Message-ID: <20041017182548.GA41354@dragon.nuxi.com> References: <200410171459.i9HExIUY099811@repoman.freebsd.org> <41728A91.8090507@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <41728A91.8090507@freebsd.org> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 6.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src UPDATING X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Oct 2004 18:25:50 -0000 On Sun, Oct 17, 2004 at 09:06:57AM -0600, Scott Long wrote: > David E. O'Brien wrote: > >obrien 2004-10-17 14:59:18 UTC > > > > FreeBSD src repository > > > > Modified files: > > . UPDATING > > Log: > > Remove the suggestion to use libmap.conf to deal with the version bump. > > People have a tendency to add things to libmap.conf and forget about them > > (as we've seen in the mailing lists before). > > The compat4x port should be used instead. > > > > Revision Changes Path > > 1.374 +0 -10 src/UPDATING > > Maybe this text couple have been replaced with text that suggests > compat4x? Especially since these are no longer part of the base > system. I thought that was already clear in the existing statement "FreeBSD 4.10 versions of these libraries will be added to the compat4x collection." -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Sun Oct 17 19:02:17 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A176516A4CE; Sun, 17 Oct 2004 19:02:17 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 81AEE43D41; Sun, 17 Oct 2004 19:02:17 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9HJ2HI3014346; Sun, 17 Oct 2004 19:02:17 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9HJ2HdE014345; Sun, 17 Oct 2004 19:02:17 GMT (envelope-from maxim) Message-Id: <200410171902.i9HJ2HdE014345@repoman.freebsd.org> From: Maxim Konovalov Date: Sun, 17 Oct 2004 19:02:17 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/tools/tools README X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Oct 2004 19:02:17 -0000 maxim 2004-10-17 19:02:17 UTC FreeBSD src repository Modified files: tools/tools README Log: Fix a typo: s/kerncruft/kernelcruft/. PR: misc/72792 Submitted by: Hywel Mallett Revision Changes Path 1.36 +1 -1 src/tools/tools/README From owner-cvs-src@FreeBSD.ORG Sun Oct 17 19:31:58 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B6E3B16A4CE; Sun, 17 Oct 2004 19:31:58 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9848343D45; Sun, 17 Oct 2004 19:31:58 +0000 (GMT) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9HJVwAf015462; Sun, 17 Oct 2004 19:31:58 GMT (envelope-from sam@repoman.freebsd.org) Received: (from sam@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9HJVwnT015461; Sun, 17 Oct 2004 19:31:58 GMT (envelope-from sam) Message-Id: <200410171931.i9HJVwnT015461@repoman.freebsd.org> From: Sam Leffler Date: Sun, 17 Oct 2004 19:31:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/sys/dev/hifn hifn7751.c hifn7751var.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Oct 2004 19:31:58 -0000 sam 2004-10-17 19:31:58 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) sys/dev/hifn hifn7751.c hifn7751var.h Log: MFC: Move session state from on-card memory to host memory... Revision Changes Path 1.5.2.8 +43 -35 src/sys/dev/hifn/hifn7751.c 1.1.2.4 +3 -8 src/sys/dev/hifn/hifn7751var.h From owner-cvs-src@FreeBSD.ORG Sun Oct 17 19:33:33 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A40DE16A4CE; Sun, 17 Oct 2004 19:33:33 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 97F7F43D5F; Sun, 17 Oct 2004 19:33:33 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9HJXXON015625; Sun, 17 Oct 2004 19:33:33 GMT (envelope-from stefanf@repoman.freebsd.org) Received: (from stefanf@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9HJXX0e015624; Sun, 17 Oct 2004 19:33:33 GMT (envelope-from stefanf) Message-Id: <200410171933.i9HJXX0e015624@repoman.freebsd.org> From: Stefan Farfeleder Date: Sun, 17 Oct 2004 19:33:33 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/libexec/ypxfr ypxfr_main.c ypxfr_misc.c src/usr.sbin/rpc.ypupdated yp_dbupdate.c src/usr.sbin/ypbind ypbind.c src/usr.sbin/yppush yppush_main.c src/usr.sbin/ypset ypset.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Oct 2004 19:33:33 -0000 stefanf 2004-10-17 19:33:33 UTC FreeBSD src repository Modified files: libexec/ypxfr ypxfr_main.c ypxfr_misc.c usr.sbin/rpc.yppasswdd yppasswdd_main.c usr.sbin/rpc.ypupdated yp_dbupdate.c usr.sbin/ypbind ypbind.c usr.sbin/yppush yppush_main.c usr.sbin/ypset ypset.c Log: Remove definition of struct dom_binding, it's non-standard C code and unnecessary since src/include/rpcsvc/ypclnt.h's revision 1.10. Revision Changes Path 1.20 +0 -1 src/libexec/ypxfr/ypxfr_main.c 1.17 +0 -1 src/libexec/ypxfr/ypxfr_misc.c 1.25 +0 -1 src/usr.sbin/rpc.yppasswdd/yppasswdd_main.c 1.9 +0 -1 src/usr.sbin/rpc.ypupdated/yp_dbupdate.c 1.40 +0 -1 src/usr.sbin/ypbind/ypbind.c 1.19 +0 -1 src/usr.sbin/yppush/yppush_main.c 1.15 +0 -1 src/usr.sbin/ypset/ypset.c From owner-cvs-src@FreeBSD.ORG Sun Oct 17 20:29:28 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7491E16A4CE; Sun, 17 Oct 2004 20:29:28 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 55A8143D46; Sun, 17 Oct 2004 20:29:28 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9HKTSTu017254; Sun, 17 Oct 2004 20:29:28 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9HKTS0N017253; Sun, 17 Oct 2004 20:29:28 GMT (envelope-from alc) Message-Id: <200410172029.i9HKTS0N017253@repoman.freebsd.org> From: Alan Cox Date: Sun, 17 Oct 2004 20:29:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/vm vm_fault.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Oct 2004 20:29:28 -0000 alc 2004-10-17 20:29:28 UTC FreeBSD src repository Modified files: sys/vm vm_fault.c Log: Remove unnecessary check for curthread == NULL. Revision Changes Path 1.198 +1 -1 src/sys/vm/vm_fault.c From owner-cvs-src@FreeBSD.ORG Sun Oct 17 20:47:36 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 151AB16A4CF; Sun, 17 Oct 2004 20:47:36 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E21D143D2D; Sun, 17 Oct 2004 20:47:35 +0000 (GMT) (envelope-from sam@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9HKlZDl024218; Sun, 17 Oct 2004 20:47:35 GMT (envelope-from sam@repoman.freebsd.org) Received: (from sam@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9HKlZIJ024217; Sun, 17 Oct 2004 20:47:35 GMT (envelope-from sam) Message-Id: <200410172047.i9HKlZIJ024217@repoman.freebsd.org> From: Sam Leffler Date: Sun, 17 Oct 2004 20:47:35 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/sys/dev/hifn hifn7751.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Oct 2004 20:47:36 -0000 sam 2004-10-17 20:47:35 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) sys/dev/hifn hifn7751.c Log: MFC: compile fix for missing ; w/o INVARIANTS Revision Changes Path 1.5.2.9 +1 -1 src/sys/dev/hifn/hifn7751.c From owner-cvs-src@FreeBSD.ORG Sun Oct 17 21:05:40 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CC83216A4CF; Sun, 17 Oct 2004 21:05:40 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id AC89643D48; Sun, 17 Oct 2004 21:05:40 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9HL5erh024798; Sun, 17 Oct 2004 21:05:40 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9HL5eq1024797; Sun, 17 Oct 2004 21:05:40 GMT (envelope-from marcel) Message-Id: <200410172105.i9HL5eq1024797@repoman.freebsd.org> From: Marcel Moolenaar Date: Sun, 17 Oct 2004 21:05:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/release/scripts print-cdrom-packages.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Oct 2004 21:05:41 -0000 marcel 2004-10-17 21:05:40 UTC FreeBSD src repository Modified files: release/scripts print-cdrom-packages.sh Log: Fix typo in rev. 1.58 (missing $) that invalidated the conditional and caused freebsd-update to be added to the ia64 package list. Revision Changes Path 1.67 +1 -1 src/release/scripts/print-cdrom-packages.sh From owner-cvs-src@FreeBSD.ORG Sun Oct 17 21:18:57 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E742C16A4CE; Sun, 17 Oct 2004 21:18:57 +0000 (GMT) Received: from pd4mo3so.prod.shaw.ca (shawidc-mo1.cg.shawcable.net [24.71.223.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 72B1343D1F; Sun, 17 Oct 2004 21:18:57 +0000 (GMT) (envelope-from colin.percival@wadham.ox.ac.uk) Received: from pd2mr5so.prod.shaw.ca (pd2mr5so-qfe3.prod.shaw.ca [10.0.141.8]) by l-daemon (Sun ONE Messaging Server 6.0 HotFix 1.01 (built Mar 15 2004)) with ESMTP id <0I5Q004NXYTPLI10@l-daemon>; Sun, 17 Oct 2004 15:10:38 -0600 (MDT) Received: from pn2ml10so.prod.shaw.ca ([10.0.121.80]) by pd2mr5so.prod.shaw.ca (Sun ONE Messaging Server 6.0 HotFix 1.01 (built Mar 15 2004)) with ESMTP id <0I5Q00HVNYTPHGH0@pd2mr5so.prod.shaw.ca>; Sun, 17 Oct 2004 15:10:38 -0600 (MDT) Received: from [127.0.0.1] (S0106006067227a4a.vc.shawcable.net [24.87.233.42]) 2003)) with ESMTP id <0I5Q00602YTOWI@l-daemon>; Sun, 17 Oct 2004 15:10:37 -0600 (MDT) Date: Sun, 17 Oct 2004 22:10:34 +0100 From: Colin Percival In-reply-to: <200410172105.i9HL5eq1024797@repoman.freebsd.org> To: Marcel Moolenaar Message-id: <4172DFCA.60401@wadham.ox.ac.uk> MIME-version: 1.0 Content-type: text/plain; format=flowed; charset=us-ascii Content-transfer-encoding: 7bit X-Accept-Language: en-us, en References: <200410172105.i9HL5eq1024797@repoman.freebsd.org> User-Agent: Mozilla Thunderbird 0.7.3 (X11/20040928) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/release/scripts print-cdrom-packages.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Oct 2004 21:18:58 -0000 Marcel Moolenaar wrote: > Modified files: > release/scripts print-cdrom-packages.sh > Log: > Fix typo in rev. 1.58 (missing $) that invalidated the conditional and > caused freebsd-update to be added to the ia64 package list. Wow. That typo survived for three months. Now if only I could remember where I put that pointy hat after all this time... Colin Percival From owner-cvs-src@FreeBSD.ORG Sun Oct 17 21:29:54 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 22DB716A4CF; Sun, 17 Oct 2004 21:29:54 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 02B1243D49; Sun, 17 Oct 2004 21:29:54 +0000 (GMT) (envelope-from stefanf@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9HLTr0X025592; Sun, 17 Oct 2004 21:29:53 GMT (envelope-from stefanf@repoman.freebsd.org) Received: (from stefanf@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9HLTrbP025591; Sun, 17 Oct 2004 21:29:53 GMT (envelope-from stefanf) Message-Id: <200410172129.i9HLTrbP025591@repoman.freebsd.org> From: Stefan Farfeleder Date: Sun, 17 Oct 2004 21:29:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin/wicontrol wicontrol.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Oct 2004 21:29:54 -0000 stefanf 2004-10-17 21:29:53 UTC FreeBSD src repository Modified files: usr.sbin/wicontrol wicontrol.c Log: Remove an extra semicolon after a function. Revision Changes Path 1.38 +1 -1 src/usr.sbin/wicontrol/wicontrol.c From owner-cvs-src@FreeBSD.ORG Sun Oct 17 21:44:11 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9D5A316A4CE; Sun, 17 Oct 2004 21:44:11 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7D06E43D48; Sun, 17 Oct 2004 21:44:11 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9HLiBuj026161; Sun, 17 Oct 2004 21:44:11 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9HLiBgZ026160; Sun, 17 Oct 2004 21:44:11 GMT (envelope-from glebius) Message-Id: <200410172144.i9HLiBgZ026160@repoman.freebsd.org> From: Gleb Smirnoff Date: Sun, 17 Oct 2004 21:44:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/ex if_ex.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Oct 2004 21:44:11 -0000 glebius 2004-10-17 21:44:11 UTC FreeBSD src repository Modified files: sys/dev/ex if_ex.c Log: Use cluster if data >= MINCLSIZE. Reviewed by: mdodd Approved by: julian (mentor) MFC after: 1 month Revision Changes Path 1.54 +1 -1 src/sys/dev/ex/if_ex.c From owner-cvs-src@FreeBSD.ORG Sun Oct 17 22:20:40 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6996716A4CE; Sun, 17 Oct 2004 22:20:40 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 477A943D48; Sun, 17 Oct 2004 22:20:40 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9HMKemk027224; Sun, 17 Oct 2004 22:20:40 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9HMKeqq027223; Sun, 17 Oct 2004 22:20:40 GMT (envelope-from marcel) Message-Id: <200410172220.i9HMKeqq027223@repoman.freebsd.org> From: Marcel Moolenaar Date: Sun, 17 Oct 2004 22:20:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/etc/etc.ia64 ttys X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Oct 2004 22:20:40 -0000 marcel 2004-10-17 22:20:39 UTC FreeBSD src repository Modified files: etc/etc.ia64 ttys Log: turn off getty(8) on ttyv[0-7]. We don't support syscons on ia64 and do not have these device special files. Where this previously failed quietly, it now emits annoying but complete messages at best and incomprehensible prefixes on average. During all of October, this is a string of 16 O's, as in: : Starting inetd. Sun Oct 17 15:09:09 PDT 2004 OOOOOOOOOOOOOOOO FreeBSD/ia64 (itanium.pn.xcllnt.net) (ttyu2) login: Revision Changes Path 1.5 +8 -8 src/etc/etc.ia64/ttys From owner-cvs-src@FreeBSD.ORG Sun Oct 17 22:33:40 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EC11F16A4CE; Sun, 17 Oct 2004 22:33:40 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CBE0D43D1D; Sun, 17 Oct 2004 22:33:40 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9HMXekg027596; Sun, 17 Oct 2004 22:33:40 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9HMXeQO027595; Sun, 17 Oct 2004 22:33:40 GMT (envelope-from alc) Message-Id: <200410172233.i9HMXeQO027595@repoman.freebsd.org> From: Alan Cox Date: Sun, 17 Oct 2004 22:33:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/vm vm_page.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Oct 2004 22:33:41 -0000 alc 2004-10-17 22:33:40 UTC FreeBSD src repository Modified files: sys/vm vm_page.c Log: Assert that the containing object is locked in vm_page_io_start() and vm_page_io_finish(). The motivation being to transition synchronization of the vm_page's busy field from the global page queues lock to the per-object lock. Revision Changes Path 1.292 +2 -0 src/sys/vm/vm_page.c From owner-cvs-src@FreeBSD.ORG Sun Oct 17 23:35:20 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5387716A4CE; Sun, 17 Oct 2004 23:35:20 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3368543D2F; Sun, 17 Oct 2004 23:35:20 +0000 (GMT) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9HNZGbs029508; Sun, 17 Oct 2004 23:35:16 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9HNZG33029507; Sun, 17 Oct 2004 23:35:16 GMT (envelope-from kientzle) Message-Id: <200410172335.i9HNZG33029507@repoman.freebsd.org> From: Tim Kientzle Date: Sun, 17 Oct 2004 23:35:16 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libarchive archive_check_magic.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Oct 2004 23:35:20 -0000 kientzle 2004-10-17 23:35:16 UTC FreeBSD src repository Modified files: lib/libarchive archive_check_magic.c Log: Don't rely on stdio here. Revision Changes Path 1.4 +20 -11 src/lib/libarchive/archive_check_magic.c From owner-cvs-src@FreeBSD.ORG Sun Oct 17 23:37:09 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6774716A4CE; Sun, 17 Oct 2004 23:37:09 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 47DEE43D31; Sun, 17 Oct 2004 23:37:09 +0000 (GMT) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9HNb9hZ029669; Sun, 17 Oct 2004 23:37:09 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9HNb9I7029668; Sun, 17 Oct 2004 23:37:09 GMT (envelope-from kientzle) Message-Id: <200410172337.i9HNb9I7029668@repoman.freebsd.org> From: Tim Kientzle Date: Sun, 17 Oct 2004 23:37:09 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libarchive archive.h.in X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Oct 2004 23:37:09 -0000 kientzle 2004-10-17 23:37:09 UTC FreeBSD src repository Modified files: lib/libarchive archive.h.in Log: Correct the return type of archive_write_data to match the documentation. MFC after: 30 days Revision Changes Path 1.18 +1 -1 src/lib/libarchive/archive.h.in From owner-cvs-src@FreeBSD.ORG Sun Oct 17 23:40:11 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1B13216A4CE; Sun, 17 Oct 2004 23:40:11 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F00C943D1F; Sun, 17 Oct 2004 23:40:10 +0000 (GMT) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9HNeAmZ029738; Sun, 17 Oct 2004 23:40:10 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9HNeABI029737; Sun, 17 Oct 2004 23:40:10 GMT (envelope-from kientzle) Message-Id: <200410172340.i9HNeABI029737@repoman.freebsd.org> From: Tim Kientzle Date: Sun, 17 Oct 2004 23:40:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libarchive archive_read_support_compression_compress.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Oct 2004 23:40:11 -0000 kientzle 2004-10-17 23:40:10 UTC FreeBSD src repository Modified files: lib/libarchive archive_read_support_compression_compress.c Log: Refine the error-checking and reporting in the "compress" format decompression code. In particular, distinguish between EOF and fatal data errors. Revision Changes Path 1.3 +11 -6 src/lib/libarchive/archive_read_support_compression_compress.c From owner-cvs-src@FreeBSD.ORG Sun Oct 17 23:47:32 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CDD6316A4E3; Sun, 17 Oct 2004 23:47:30 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A66A943D45; Sun, 17 Oct 2004 23:47:30 +0000 (GMT) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9HNlUk0030117; Sun, 17 Oct 2004 23:47:30 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9HNlUv8030116; Sun, 17 Oct 2004 23:47:30 GMT (envelope-from kientzle) Message-Id: <200410172347.i9HNlUv8030116@repoman.freebsd.org> From: Tim Kientzle Date: Sun, 17 Oct 2004 23:47:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libarchive archive_write_open_fd.c archive_write_open_file.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Oct 2004 23:47:32 -0000 kientzle 2004-10-17 23:47:30 UTC FreeBSD src repository Modified files: lib/libarchive archive_write_open_fd.c archive_write_open_file.c Log: Correctly report write errors from the lowest-level output routines back to the compression layer. Revision Changes Path 1.4 +7 -2 src/lib/libarchive/archive_write_open_fd.c 1.8 +7 -2 src/lib/libarchive/archive_write_open_file.c From owner-cvs-src@FreeBSD.ORG Sun Oct 17 23:55:08 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6CCA016A4CE; Sun, 17 Oct 2004 23:55:08 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 60E2143D2D; Sun, 17 Oct 2004 23:55:08 +0000 (GMT) (envelope-from wollman@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9HNt8d9030343; Sun, 17 Oct 2004 23:55:08 GMT (envelope-from wollman@repoman.freebsd.org) Received: (from wollman@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9HNt8vv030342; Sun, 17 Oct 2004 23:55:08 GMT (envelope-from wollman) Message-Id: <200410172355.i9HNt8vv030342@repoman.freebsd.org> From: Garrett Wollman Date: Sun, 17 Oct 2004 23:55:08 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: ADO Subject: cvs commit: src/share/zoneinfo - Imported sources X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Oct 2004 23:55:08 -0000 wollman 2004-10-17 23:55:08 UTC FreeBSD src repository src/share/zoneinfo - Imported sources Update of /home/ncvs/src/share/zoneinfo In directory repoman.freebsd.org:/tmp/cvs-serv30242 Log Message: Latest timezone database from Arthur Olson. Updates in this round: Current or prospective timestamps: Georgia, Uruguay, Argentina, and Brazil Historial timestamps and/or commentary: Malaysia, Mongolia, Singapore, Peru, Russua, Israel, United States, Canada Changes in Argentina and Brazil have created several new time zone regions. Users are encouraged to rerun tzsetup(8), even if current times appear correct, to ensure that future times will be interepreted correctly. Obtained from: Arthur Olson, ftp://elsie.nci.nih.gov/pub/tzdata2004e.tar.gz Status: Vendor Tag: ADO Release Tags: tzdata2004e C src/share/zoneinfo/africa C src/share/zoneinfo/antarctica C src/share/zoneinfo/asia C src/share/zoneinfo/australasia C src/share/zoneinfo/europe C src/share/zoneinfo/northamerica C src/share/zoneinfo/southamerica U src/share/zoneinfo/pacificnew C src/share/zoneinfo/etcetera U src/share/zoneinfo/factory C src/share/zoneinfo/backward C src/share/zoneinfo/systemv U src/share/zoneinfo/solar87 U src/share/zoneinfo/solar88 U src/share/zoneinfo/solar89 C src/share/zoneinfo/iso3166.tab C src/share/zoneinfo/zone.tab C src/share/zoneinfo/leapseconds C src/share/zoneinfo/yearistype.sh 14 conflicts created by this import. Use the following command to help the merge: cvs checkout -jADO:yesterday -jADO src/share/zoneinfo From owner-cvs-src@FreeBSD.ORG Sun Oct 17 23:57:11 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 058D116A4CE; Sun, 17 Oct 2004 23:57:11 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D717343D2D; Sun, 17 Oct 2004 23:57:10 +0000 (GMT) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9HNvAl8030477; Sun, 17 Oct 2004 23:57:10 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9HNvATM030476; Sun, 17 Oct 2004 23:57:10 GMT (envelope-from kientzle) Message-Id: <200410172357.i9HNvATM030476@repoman.freebsd.org> From: Tim Kientzle Date: Sun, 17 Oct 2004 23:57:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.bin/tar read.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Oct 2004 23:57:11 -0000 kientzle 2004-10-17 23:57:10 UTC FreeBSD src repository Modified files: usr.bin/tar read.c Log: Cosmetic goof: Use two spaces in "Jan 03 2004" but only one in "Jan 03 12:32" MFC after: 15 days Revision Changes Path 1.21 +1 -1 src/usr.bin/tar/read.c From owner-cvs-src@FreeBSD.ORG Sun Oct 17 23:57:38 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2C31516A4CE; Sun, 17 Oct 2004 23:57:38 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 21B4A43D1D; Sun, 17 Oct 2004 23:57:38 +0000 (GMT) (envelope-from wollman@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9HNvcSO030502; Sun, 17 Oct 2004 23:57:38 GMT (envelope-from wollman@repoman.freebsd.org) Received: (from wollman@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9HNvcKA030501; Sun, 17 Oct 2004 23:57:38 GMT (envelope-from wollman) Message-Id: <200410172357.i9HNvcKA030501@repoman.freebsd.org> From: Garrett Wollman Date: Sun, 17 Oct 2004 23:57:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: ADO Subject: cvs commit: src/share/zoneinfo - Imported sources X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Oct 2004 23:57:38 -0000 wollman 2004-10-17 23:57:37 UTC FreeBSD src repository src/share/zoneinfo - Imported sources Update of /home/ncvs/src/share/zoneinfo In directory repoman.freebsd.org:/tmp/cvs-serv30446 Log Message: Redo vendor import using correct (nonstandard) vendor branch. Status: Vendor Tag: ADO Release Tags: tzdata2004e U src/share/zoneinfo/africa U src/share/zoneinfo/antarctica C src/share/zoneinfo/asia U src/share/zoneinfo/australasia C src/share/zoneinfo/europe C src/share/zoneinfo/northamerica C src/share/zoneinfo/southamerica U src/share/zoneinfo/pacificnew U src/share/zoneinfo/etcetera U src/share/zoneinfo/factory U src/share/zoneinfo/backward U src/share/zoneinfo/systemv U src/share/zoneinfo/solar87 U src/share/zoneinfo/solar88 U src/share/zoneinfo/solar89 C src/share/zoneinfo/iso3166.tab C src/share/zoneinfo/zone.tab C src/share/zoneinfo/leapseconds U src/share/zoneinfo/yearistype.sh 7 conflicts created by this import. Use the following command to help the merge: cvs checkout -jADO:yesterday -jADO src/share/zoneinfo From owner-cvs-src@FreeBSD.ORG Sun Oct 17 23:58:17 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C289C16A4CE; Sun, 17 Oct 2004 23:58:17 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A3D5343D46; Sun, 17 Oct 2004 23:58:17 +0000 (GMT) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9HNwH95030561; Sun, 17 Oct 2004 23:58:17 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9HNwHrh030560; Sun, 17 Oct 2004 23:58:17 GMT (envelope-from kientzle) Message-Id: <200410172358.i9HNwHrh030560@repoman.freebsd.org> From: Tim Kientzle Date: Sun, 17 Oct 2004 23:58:17 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.bin/tar bsdtar.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Oct 2004 23:58:17 -0000 kientzle 2004-10-17 23:58:17 UTC FreeBSD src repository Modified files: usr.bin/tar bsdtar.c Log: getopt(3) prints an "unrecognized option" warning for me, so I shouldn't print another. MFC after: 15 days Revision Changes Path 1.56 +0 -1 src/usr.bin/tar/bsdtar.c From owner-cvs-src@FreeBSD.ORG Mon Oct 18 00:03:52 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 795DE16A4CE; Mon, 18 Oct 2004 00:03:52 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6F8D143D2D; Mon, 18 Oct 2004 00:03:52 +0000 (GMT) (envelope-from wollman@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9I03qJV030813; Mon, 18 Oct 2004 00:03:52 GMT (envelope-from wollman@repoman.freebsd.org) Received: (from wollman@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9I03qiF030812; Mon, 18 Oct 2004 00:03:52 GMT (envelope-from wollman) Message-Id: <200410180003.i9I03qiF030812@repoman.freebsd.org> From: Garrett Wollman Date: Mon, 18 Oct 2004 00:03:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/zoneinfo asia europe leapseconds northamerica southamerica zone.tab X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 00:03:52 -0000 wollman 2004-10-18 00:03:52 UTC FreeBSD src repository Modified files: share/zoneinfo asia europe leapseconds northamerica southamerica zone.tab Log: MFV tzdata2004e Users in Brazil and Argentina should run tzsetup(8). Obtained from: Arthur David Olson MFC after re approval Revision Changes Path 1.25 +74 -23 src/share/zoneinfo/asia 1.28 +25 -20 src/share/zoneinfo/europe 1.11 +11 -9 src/share/zoneinfo/leapseconds 1.24 +61 -35 src/share/zoneinfo/northamerica 1.23 +184 -27 src/share/zoneinfo/southamerica 1.17 +13 -6 src/share/zoneinfo/zone.tab From owner-cvs-src@FreeBSD.ORG Mon Oct 18 00:45:28 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8352016A4CE; Mon, 18 Oct 2004 00:45:28 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6458F43D31; Mon, 18 Oct 2004 00:45:28 +0000 (GMT) (envelope-from keramida@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9I0jSHr032061; Mon, 18 Oct 2004 00:45:28 GMT (envelope-from keramida@repoman.freebsd.org) Received: (from keramida@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9I0jS63032060; Mon, 18 Oct 2004 00:45:28 GMT (envelope-from keramida) Message-Id: <200410180045.i9I0jS63032060@repoman.freebsd.org> From: Giorgos Keramidas Date: Mon, 18 Oct 2004 00:45:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/tools/tools/tinderbox tbmaster.1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 00:45:28 -0000 keramida 2004-10-18 00:45:28 UTC FreeBSD src repository (doc committer) Modified files: tools/tools/tinderbox tbmaster.1 Log: Typo fix. PR: misc/72801 Submitted by: Hywel Mallett Revision Changes Path 1.16 +1 -1 src/tools/tools/tinderbox/tbmaster.1 From owner-cvs-src@FreeBSD.ORG Mon Oct 18 00:46:05 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1B0FA16A4CE; Mon, 18 Oct 2004 00:46:05 +0000 (GMT) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id F303743D1D; Mon, 18 Oct 2004 00:46:04 +0000 (GMT) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id E5FB45C84C; Sun, 17 Oct 2004 17:46:04 -0700 (PDT) Date: Sun, 17 Oct 2004 17:46:04 -0700 From: Alfred Perlstein To: Tim Kientzle Message-ID: <20041018004604.GY29177@elvis.mu.org> References: <200410172335.i9HNZG33029507@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200410172335.i9HNZG33029507@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libarchive archive_check_magic.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 00:46:05 -0000 * Tim Kientzle [041017 16:35] wrote: > kientzle 2004-10-17 23:35:16 UTC > > FreeBSD src repository > > Modified files: > lib/libarchive archive_check_magic.c > Log: > Don't rely on stdio here. > > Revision Changes Path > 1.4 +20 -11 src/lib/libarchive/archive_check_magic.c STDERR_FILENO may be more appropriate. -- - Alfred Perlstein - Research Engineering Development Inc. - email: bright@mu.org cell: 408-480-4684 From owner-cvs-src@FreeBSD.ORG Mon Oct 18 01:44:36 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 12B2E16A4CE; Mon, 18 Oct 2004 01:44:36 +0000 (GMT) Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id EA40C43D3F; Mon, 18 Oct 2004 01:44:34 +0000 (GMT) (envelope-from ache@pobrecita.freebsd.ru) Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.13.1/8.13.1) with ESMTP id i9I1iVGp035587; Mon, 18 Oct 2004 05:44:31 +0400 (MSD) (envelope-from ache@pobrecita.freebsd.ru) Received: (from ache@localhost) by pobrecita.freebsd.ru (8.13.1/8.13.1/Submit) id i9I1iUDu035586; Mon, 18 Oct 2004 05:44:30 +0400 (MSD) (envelope-from ache) Date: Mon, 18 Oct 2004 05:44:30 +0400 From: Andrey Chernov To: Garrett Wollman Message-ID: <20041018014430.GA35524@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Garrett Wollman , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200410172355.i9HNt8vv030342@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200410172355.i9HNt8vv030342@repoman.freebsd.org> User-Agent: Mutt/1.5.6i X-AntiVirus: checked by AntiVir Milter 1.1-beta; AVE 6.28.0.7; VDF 6.28.0.20 (host: pobrecita.freebsd.ru) cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/share/zoneinfo - Imported sources X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 01:44:36 -0000 On Sun, Oct 17, 2004 at 11:55:08PM +0000, Garrett Wollman wrote: > wollman 2004-10-17 23:55:08 UTC > > FreeBSD src repository > > src/share/zoneinfo - Imported sources > Update of /home/ncvs/src/share/zoneinfo > In directory repoman.freebsd.org:/tmp/cvs-serv30242 > > Log Message: > Latest timezone database from Arthur Olson. Updates in this round: Some new dirs are missing from BSD.usr.dist: zic: can't create /usr/share/zoneinfo/America/Argentina/Buenos_Aires: No such file or directory *** Error code 1 -- Andrey Chernov | http://ache.pp.ru/ From owner-cvs-src@FreeBSD.ORG Mon Oct 18 02:06:19 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 005F516A4CE; Mon, 18 Oct 2004 02:06:19 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D5B1343D46; Mon, 18 Oct 2004 02:06:18 +0000 (GMT) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9I26Iu0041164; Mon, 18 Oct 2004 02:06:18 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9I26IPd041163; Mon, 18 Oct 2004 02:06:18 GMT (envelope-from ache) Message-Id: <200410180206.i9I26IPd041163@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Mon, 18 Oct 2004 02:06:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libc/locale setrunelocale.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 02:06:19 -0000 ache 2004-10-18 02:06:18 UTC FreeBSD src repository Modified files: lib/libc/locale setrunelocale.c Log: Remove setrunelocale() Revision Changes Path 1.44 +0 -23 src/lib/libc/locale/setrunelocale.c From owner-cvs-src@FreeBSD.ORG Mon Oct 18 03:31:48 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AF99516A4CE; Mon, 18 Oct 2004 03:31:48 +0000 (GMT) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8E18343D2F; Mon, 18 Oct 2004 03:31:48 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.13.1/8.13.1) with ESMTP id i9I3VmHp005941; Sun, 17 Oct 2004 20:31:48 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.13.1/8.13.1/Submit) id i9I3VmFi005940; Sun, 17 Oct 2004 20:31:48 -0700 (PDT) (envelope-from obrien) Date: Sun, 17 Oct 2004 20:31:48 -0700 From: "David O'Brien" To: Poul-Henning Kamp Message-ID: <20041018033148.GA5880@dragon.nuxi.com> References: <200410130827.i9D8RKBM082371@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200410130827.i9D8RKBM082371@repoman.freebsd.org> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 6.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pc98/pc98 sio.c src/sys/dev/sio sio.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 03:31:48 -0000 On Wed, Oct 13, 2004 at 08:27:20AM +0000, Poul-Henning Kamp wrote: > phk 2004-10-13 08:27:20 UTC > > FreeBSD src repository > > Modified files: > sys/pc98/pc98 sio.c > sys/dev/sio sio.c > Log: > Use generic tty code instead of local stuff. > NB: device names are now consistent: {cua,tty}d$(port)[.lock,.init] Please add an UPDATING entry for this. Also, you forgot to update etc/rc.d/serial. -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Mon Oct 18 03:37:11 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0242C16A4CE; Mon, 18 Oct 2004 03:37:11 +0000 (GMT) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id B4C6543D1D; Mon, 18 Oct 2004 03:37:10 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.13.1/8.13.1) with ESMTP id i9I3b96f006118; Sun, 17 Oct 2004 20:37:09 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.13.1/8.13.1/Submit) id i9I3b9fD006117; Sun, 17 Oct 2004 20:37:09 -0700 (PDT) (envelope-from obrien) Date: Sun, 17 Oct 2004 20:37:09 -0700 From: "David O'Brien" To: Poul-Henning Kamp Message-ID: <20041018033709.GB5880@dragon.nuxi.com> References: <200410130827.i9D8RKBM082371@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200410130827.i9D8RKBM082371@repoman.freebsd.org> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 6.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pc98/pc98 sio.c src/sys/dev/sio sio.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 03:37:11 -0000 On Wed, Oct 13, 2004 at 08:27:20AM +0000, Poul-Henning Kamp wrote: > phk 2004-10-13 08:27:20 UTC > > FreeBSD src repository > > Modified files: > sys/pc98/pc98 sio.c > sys/dev/sio sio.c > Log: > Use generic tty code instead of local stuff. > NB: device names are now consistent: {cua,tty}d$(port)[.lock,.init] Is this the correct man page change? Index: sio.4 =================================================================== RCS file: /home/ncvs/src/share/man/man4/sio.4,v retrieving revision 1.53 diff -u -r1.53 sio.4 --- sio.4 3 Jul 2004 18:29:20 -0000 1.53 +++ sio.4 18 Oct 2004 03:36:01 -0000 @@ -36,7 +36,7 @@ .\" from: com.4,v 1.1 1993/08/06 11:19:07 cgd Exp .\" $FreeBSD: src/share/man/man4/sio.4,v 1.53 2004/07/03 18:29:20 ru Exp $ .\" -.Dd July 10, 2002 +.Dd October 17, 2004 .Dt SIO 4 .Os .Sh NAME @@ -342,22 +342,22 @@ to avoid certain security holes, but this needs to be done by getty if the callin port is used for anything else. .Sh FILES -.Bl -tag -width /dev/ttyid? -compact +.Bl -tag -width /dev/ttyd?.init -compact .It Pa /dev/ttyd? for callin ports -.It Pa /dev/ttyid? -.It Pa /dev/ttyld? +.It Pa /dev/ttyd?.init +.It Pa /dev/ttyd?.lock corresponding callin initial-state and lock-state devices .Pp -.It Pa /dev/cuaa? +.It Pa /dev/cuad? for callout ports -.It Pa /dev/cuaia? -.It Pa /dev/cuala? +.It Pa /dev/cuad?.init +.It Pa /dev/cuad?.lock corresponding callout initial-state and lock-state devices .El .Pp -.Bl -tag -width /etc/rc.serial -compact -.It Pa /etc/rc.serial +.Bl -tag -width /etc/rc.d/serial -compact +.It Pa /etc/rc.d/serial examples of setting the initial-state and lock-state devices .El .Pp From owner-cvs-src@FreeBSD.ORG Mon Oct 18 04:34:30 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CF66B16A4CE; Mon, 18 Oct 2004 04:34:30 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id AD03043D49; Mon, 18 Oct 2004 04:34:30 +0000 (GMT) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9I4YU5Q045677; Mon, 18 Oct 2004 04:34:30 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9I4YUWi045676; Mon, 18 Oct 2004 04:34:30 GMT (envelope-from kientzle) Message-Id: <200410180434.i9I4YUWi045676@repoman.freebsd.org> From: Tim Kientzle Date: Mon, 18 Oct 2004 04:34:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libarchive archive_check_magic.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 04:34:31 -0000 kientzle 2004-10-18 04:34:30 UTC FreeBSD src repository Modified files: lib/libarchive archive_check_magic.c Log: Use STDERR_FILENO instead of 2, as POSIX intended. Thanks to: Alfred Perlstein Revision Changes Path 1.5 +1 -1 src/lib/libarchive/archive_check_magic.c From owner-cvs-src@FreeBSD.ORG Mon Oct 18 04:41:39 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8EED116A4CE for ; Mon, 18 Oct 2004 04:41:39 +0000 (GMT) Received: from lakermmtao07.cox.net (lakermmtao07.cox.net [68.230.240.32]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1C42643D53 for ; Mon, 18 Oct 2004 04:41:39 +0000 (GMT) (envelope-from conrads@cox.net) Received: from dolphin.local.net ([68.11.30.24]) by lakermmtao07.cox.net (InterMail vM.6.01.03.04 201-2131-111-106-20040729) with ESMTP id <20041018044138.ITVF3371.lakermmtao07.cox.net@dolphin.local.net> for ; Mon, 18 Oct 2004 00:41:38 -0400 Received: from dolphin.local.net (localhost.local.net [127.0.0.1]) by dolphin.local.net (8.13.1/8.13.1) with SMTP id i9I4fa9w079776 for ; Sun, 17 Oct 2004 23:41:36 -0500 (CDT) (envelope-from conrads@cox.net) Date: Sun, 17 Oct 2004 23:41:31 -0500 From: "Conrad J. Sabatier" To: cvs-src@freebsd.org Message-ID: <20041017234131.7beaace4@dolphin.local.net> In-Reply-To: <200410172337.i9HNb9I7029668@repoman.freebsd.org> References: <200410172337.i9HNb9I7029668@repoman.freebsd.org> X-Mailer: Sylpheed-Claws 0.9.12b (GTK+ 1.2.10; amd64-portbld-freebsd6.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: cvs commit: src/lib/libarchive archive.h.in X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 04:41:39 -0000 On Sun, 17 Oct 2004 23:37:09 +0000 (UTC), Tim Kientzle wrote: > kientzle 2004-10-17 23:37:09 UTC > > FreeBSD src repository > > Modified files: > lib/libarchive archive.h.in > Log: > Correct the return type of archive_write_data > to match the documentation. > > MFC after: 30 days > > Revision Changes Path > 1.18 +1 -1 src/lib/libarchive/archive.h.in Unfortunately, this is a show-stopper, breaking the build of libarchive. -- Conrad J. Sabatier -- "In Unix veritas" From owner-cvs-src@FreeBSD.ORG Mon Oct 18 05:31:01 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C2F7516A4CE; Mon, 18 Oct 2004 05:31:01 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A226F43D2D; Mon, 18 Oct 2004 05:31:01 +0000 (GMT) (envelope-from kientzle@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9I5V17O053715; Mon, 18 Oct 2004 05:31:01 GMT (envelope-from kientzle@repoman.freebsd.org) Received: (from kientzle@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9I5V150053714; Mon, 18 Oct 2004 05:31:01 GMT (envelope-from kientzle) Message-Id: <200410180531.i9I5V150053714@repoman.freebsd.org> From: Tim Kientzle Date: Mon, 18 Oct 2004 05:31:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libarchive archive.h.in X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 05:31:01 -0000 kientzle 2004-10-18 05:31:01 UTC FreeBSD src repository Modified files: lib/libarchive archive.h.in Log: Revert 1.18: It broke Athlon64 builds, which probably means it also requires a .so version bump. Defer it until I finish some related work on cleaning up error returns throughout the library. Thanks to: Conrad J. Sabatier Revision Changes Path 1.19 +2 -1 src/lib/libarchive/archive.h.in From owner-cvs-src@FreeBSD.ORG Mon Oct 18 05:34:54 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B554516A4CE; Mon, 18 Oct 2004 05:34:54 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A7FBB43D2F; Mon, 18 Oct 2004 05:34:54 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9I5YsiZ053853; Mon, 18 Oct 2004 05:34:54 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9I5YsGn053852; Mon, 18 Oct 2004 05:34:54 GMT (envelope-from obrien) Message-Id: <200410180534.i9I5YsGn053852@repoman.freebsd.org> From: "David E. O'Brien" Date: Mon, 18 Oct 2004 05:34:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin/pkg_install/info info.h main.c src/usr.sbin/pkg_install/lib global.c lib.h src/usr.sbin/pkg_install/version main.c perform.c pkg_version.1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 05:34:54 -0000 obrien 2004-10-18 05:34:54 UTC FreeBSD src repository Modified files: usr.sbin/pkg_install/info info.h main.c usr.sbin/pkg_install/lib global.c lib.h usr.sbin/pkg_install/version main.c perform.c pkg_version.1 Log: Add a -q flag to pkg_version. It suppresses the output of <,=,>. This makes it possible to "portupgrade `pkg_version -q -l '<'`". Revision Changes Path 1.28 +0 -1 src/usr.sbin/pkg_install/info/info.h 1.47 +0 -1 src/usr.sbin/pkg_install/info/main.c 1.10 +1 -0 src/usr.sbin/pkg_install/lib/global.c 1.54 +1 -0 src/usr.sbin/pkg_install/lib/lib.h 1.3 +5 -1 src/usr.sbin/pkg_install/version/main.c 1.11 +3 -3 src/usr.sbin/pkg_install/version/perform.c 1.28 +13 -2 src/usr.sbin/pkg_install/version/pkg_version.1 From owner-cvs-src@FreeBSD.ORG Mon Oct 18 05:47:11 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2934016A4CE; Mon, 18 Oct 2004 05:47:11 +0000 (GMT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 68EA343D3F; Mon, 18 Oct 2004 05:47:10 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.13.1/8.13.1) with ESMTP id i9I5l6ml048227; Mon, 18 Oct 2004 07:47:06 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: obrien@FreeBSD.org From: "Poul-Henning Kamp" In-Reply-To: Your message of "Sun, 17 Oct 2004 20:37:09 PDT." <20041018033709.GB5880@dragon.nuxi.com> Date: Mon, 18 Oct 2004 07:47:06 +0200 Message-ID: <48226.1098078426@critter.freebsd.dk> Sender: phk@critter.freebsd.dk cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pc98/pc98 sio.c src/sys/dev/sio sio.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 05:47:11 -0000 Looks like it. In message <20041018033709.GB5880@dragon.nuxi.com>, "David O'Brien" writes: >On Wed, Oct 13, 2004 at 08:27:20AM +0000, Poul-Henning Kamp wrote: >> phk 2004-10-13 08:27:20 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/pc98/pc98 sio.c >> sys/dev/sio sio.c >> Log: >> Use generic tty code instead of local stuff. >> NB: device names are now consistent: {cua,tty}d$(port)[.lock,.init] > >Is this the correct man page change? > >Index: sio.4 >=================================================================== >RCS file: /home/ncvs/src/share/man/man4/sio.4,v >retrieving revision 1.53 >diff -u -r1.53 sio.4 >--- sio.4 3 Jul 2004 18:29:20 -0000 1.53 >+++ sio.4 18 Oct 2004 03:36:01 -0000 >@@ -36,7 +36,7 @@ > .\" from: com.4,v 1.1 1993/08/06 11:19:07 cgd Exp > .\" $FreeBSD: src/share/man/man4/sio.4,v 1.53 2004/07/03 18:29:20 ru Exp $ > .\" >-.Dd July 10, 2002 >+.Dd October 17, 2004 > .Dt SIO 4 > .Os > .Sh NAME >@@ -342,22 +342,22 @@ > to avoid certain security holes, but this needs to be done by > getty if the callin port is used for anything else. > .Sh FILES >-.Bl -tag -width /dev/ttyid? -compact >+.Bl -tag -width /dev/ttyd?.init -compact > .It Pa /dev/ttyd? > for callin ports >-.It Pa /dev/ttyid? >-.It Pa /dev/ttyld? >+.It Pa /dev/ttyd?.init >+.It Pa /dev/ttyd?.lock > corresponding callin initial-state and lock-state devices > .Pp >-.It Pa /dev/cuaa? >+.It Pa /dev/cuad? > for callout ports >-.It Pa /dev/cuaia? >-.It Pa /dev/cuala? >+.It Pa /dev/cuad?.init >+.It Pa /dev/cuad?.lock > corresponding callout initial-state and lock-state devices > .El > .Pp >-.Bl -tag -width /etc/rc.serial -compact >-.It Pa /etc/rc.serial >+.Bl -tag -width /etc/rc.d/serial -compact >+.It Pa /etc/rc.d/serial > examples of setting the initial-state and lock-state devices > .El > .Pp > -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Mon Oct 18 06:09:35 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7005916A4CE; Mon, 18 Oct 2004 06:09:35 +0000 (GMT) Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id B5C8843D54; Mon, 18 Oct 2004 06:09:34 +0000 (GMT) (envelope-from ache@pobrecita.freebsd.ru) Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.13.1/8.13.1) with ESMTP id i9I69X5E043103; Mon, 18 Oct 2004 10:09:33 +0400 (MSD) (envelope-from ache@pobrecita.freebsd.ru) Received: (from ache@localhost) by pobrecita.freebsd.ru (8.13.1/8.13.1/Submit) id i9I69X8c043102; Mon, 18 Oct 2004 10:09:33 +0400 (MSD) (envelope-from ache) Date: Mon, 18 Oct 2004 10:09:32 +0400 From: Andrey Chernov To: Pawel Jakub Dawidek Message-ID: <20041018060932.GA43041@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Pawel Jakub Dawidek , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200410160813.i9G8DKlM063136@repoman.freebsd.org> <20041016193156.GA592@nagual.pp.ru> <20041016193910.GX73767@darkness.comp.waw.pl> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="T4sUOijqQbZv57TR" Content-Disposition: inline In-Reply-To: <20041016193910.GX73767@darkness.comp.waw.pl> User-Agent: Mutt/1.5.6i X-AntiVirus: checked by AntiVir Milter 1.1-beta; AVE 6.28.0.7; VDF 6.28.0.20 (host: pobrecita.freebsd.ru) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc/defaults rc.conf src/etc/rc.d swap1 src/sbin/geom/class/mirror gmirror.8 src/share/man/man5 rc.conf.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 06:09:35 -0000 --T4sUOijqQbZv57TR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Oct 16, 2004 at 09:39:10PM +0200, Pawel Jakub Dawidek wrote: > Nope, it'll be fixed in more proper way in -CURRENT in the near future. In that case, please apply your patch. I already reboot many times and it= =20 works so far (I manually move 'int error;' under '#ifdef MAC'). --=20 Andrey Chernov | http://ache.pp.ru/ --T4sUOijqQbZv57TR Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iQCVAwUBQXNeHOJgpPLZnQjrAQEH2gQAvr98YcVkYGhlO39C/bfsj8fdu8SP8tWe Lag39aHyMQpAHuu6EgFik7ps5DBBkSQyDhH6cSK9EQ/JIe3S02nfnnV8bU0ilxDg B1sWBXmumcgLQ4Zm2IqWD1GmE/focEjy5AEOU/PTj2hkhzbBVqW6/KDdoWEtLmFs UuyxRNrX5yQ= =MPIl -----END PGP SIGNATURE----- --T4sUOijqQbZv57TR-- From owner-cvs-src@FreeBSD.ORG Mon Oct 18 07:02:45 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2A01716A4CE; Mon, 18 Oct 2004 07:02:45 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 08CA343D1F; Mon, 18 Oct 2004 07:02:45 +0000 (GMT) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9I72iS0056457; Mon, 18 Oct 2004 07:02:44 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9I72iLV056456; Mon, 18 Oct 2004 07:02:44 GMT (envelope-from ache) Message-Id: <200410180702.i9I72iLV056456@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Mon, 18 Oct 2004 07:02:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: FSF Subject: cvs commit: src/contrib/libreadline - Imported sources X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 07:02:45 -0000 ache 2004-10-18 07:02:44 UTC FreeBSD src repository src/contrib/libreadline - Imported sources Update of /home/ncvs/src/contrib/libreadline In directory repoman.freebsd.org:/tmp/cvs-serv56442 Log Message: Virgin import of GNU Readline 5.0 Status: Vendor Tag: FSF Release Tags: v5_0 U src/contrib/libreadline/COPYING U src/contrib/libreadline/README U src/contrib/libreadline/MANIFEST U src/contrib/libreadline/INSTALL U src/contrib/libreadline/CHANGELOG U src/contrib/libreadline/CHANGES N src/contrib/libreadline/NEWS U src/contrib/libreadline/USAGE U src/contrib/libreadline/aclocal.m4 U src/contrib/libreadline/config.h.in U src/contrib/libreadline/configure U src/contrib/libreadline/configure.in U src/contrib/libreadline/Makefile.in U src/contrib/libreadline/ansi_stdlib.h U src/contrib/libreadline/chardefs.h U src/contrib/libreadline/history.h U src/contrib/libreadline/histlib.h U src/contrib/libreadline/keymaps.h U src/contrib/libreadline/posixdir.h U src/contrib/libreadline/posixjmp.h U src/contrib/libreadline/posixstat.h U src/contrib/libreadline/rltty.h C src/contrib/libreadline/readline.h U src/contrib/libreadline/rlconf.h U src/contrib/libreadline/tcap.h U src/contrib/libreadline/rldefs.h U src/contrib/libreadline/rlmbutil.h U src/contrib/libreadline/rlprivate.h U src/contrib/libreadline/rlshell.h U src/contrib/libreadline/rlstdc.h U src/contrib/libreadline/rltypedefs.h U src/contrib/libreadline/rlwinsize.h U src/contrib/libreadline/tilde.h U src/contrib/libreadline/xmalloc.h U src/contrib/libreadline/bind.c U src/contrib/libreadline/callback.c U src/contrib/libreadline/compat.c U src/contrib/libreadline/complete.c U src/contrib/libreadline/display.c U src/contrib/libreadline/emacs_keymap.c U src/contrib/libreadline/funmap.c U src/contrib/libreadline/input.c U src/contrib/libreadline/isearch.c U src/contrib/libreadline/keymaps.c U src/contrib/libreadline/kill.c U src/contrib/libreadline/macro.c U src/contrib/libreadline/mbutil.c U src/contrib/libreadline/misc.c U src/contrib/libreadline/nls.c U src/contrib/libreadline/parens.c U src/contrib/libreadline/readline.c U src/contrib/libreadline/rltty.c U src/contrib/libreadline/search.c U src/contrib/libreadline/shell.c U src/contrib/libreadline/signals.c U src/contrib/libreadline/terminal.c U src/contrib/libreadline/text.c U src/contrib/libreadline/tilde.c U src/contrib/libreadline/undo.c U src/contrib/libreadline/util.c U src/contrib/libreadline/vi_keymap.c U src/contrib/libreadline/vi_mode.c U src/contrib/libreadline/xmalloc.c U src/contrib/libreadline/history.c U src/contrib/libreadline/histexpand.c U src/contrib/libreadline/histfile.c U src/contrib/libreadline/histsearch.c U src/contrib/libreadline/doc/Makefile.in N src/contrib/libreadline/doc/version.texi N src/contrib/libreadline/doc/fdl.texi N src/contrib/libreadline/doc/rlman.texi N src/contrib/libreadline/doc/rltech.texi N src/contrib/libreadline/doc/rluser.texi N src/contrib/libreadline/doc/rluserman.texi N src/contrib/libreadline/doc/history.texi N src/contrib/libreadline/doc/hstech.texi N src/contrib/libreadline/doc/hsuser.texi U src/contrib/libreadline/doc/readline.3 U src/contrib/libreadline/doc/history.3 U src/contrib/libreadline/examples/Makefile.in U src/contrib/libreadline/examples/excallback.c U src/contrib/libreadline/examples/fileman.c U src/contrib/libreadline/examples/manexamp.c U src/contrib/libreadline/examples/readlinebuf.h N src/contrib/libreadline/examples/rl-fgets.c U src/contrib/libreadline/examples/rlcat.c U src/contrib/libreadline/examples/rlfe.c U src/contrib/libreadline/examples/rltest.c U src/contrib/libreadline/examples/rl.c U src/contrib/libreadline/examples/rlversion.c U src/contrib/libreadline/examples/histexamp.c U src/contrib/libreadline/examples/Inputrc U src/contrib/libreadline/support/config.guess N src/contrib/libreadline/support/config.rpath U src/contrib/libreadline/support/config.sub U src/contrib/libreadline/support/install.sh U src/contrib/libreadline/support/mkdirs U src/contrib/libreadline/support/mkdist N src/contrib/libreadline/support/mkinstalldirs U src/contrib/libreadline/support/shobj-conf U src/contrib/libreadline/support/shlib-install U src/contrib/libreadline/support/wcwidth.c U src/contrib/libreadline/shlib/Makefile.in 1 conflicts created by this import. Use the following command to help the merge: cvs checkout -jFSF:yesterday -jFSF src/contrib/libreadline From owner-cvs-src@FreeBSD.ORG Mon Oct 18 07:10:35 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8541A16A4CE; Mon, 18 Oct 2004 07:10:35 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6479343D2F; Mon, 18 Oct 2004 07:10:35 +0000 (GMT) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9I7AZoo056765; Mon, 18 Oct 2004 07:10:35 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9I7AZBn056764; Mon, 18 Oct 2004 07:10:35 GMT (envelope-from ache) Message-Id: <200410180710.i9I7AZBn056764@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Mon, 18 Oct 2004 07:10:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: FSF Subject: cvs commit: src/contrib/libreadline - Imported sources X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 07:10:35 -0000 ache 2004-10-18 07:10:34 UTC FreeBSD src repository src/contrib/libreadline - Imported sources Update of /home/ncvs/src/contrib/libreadline In directory repoman.freebsd.org:/tmp/cvs-serv56752 Log Message: Official patches 001-005 Status: Vendor Tag: FSF Release Tags: v5_0_p1_p5 U src/contrib/libreadline/vi_mode.c U src/contrib/libreadline/misc.c U src/contrib/libreadline/mbutil.c U src/contrib/libreadline/display.c No conflicts created by this import From owner-cvs-src@FreeBSD.ORG Mon Oct 18 07:15:45 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1A2E216A4CE; Mon, 18 Oct 2004 07:15:45 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id ED73243D39; Mon, 18 Oct 2004 07:15:44 +0000 (GMT) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9I7FivN056967; Mon, 18 Oct 2004 07:15:44 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9I7Fio7056966; Mon, 18 Oct 2004 07:15:44 GMT (envelope-from ache) Message-Id: <200410180715.i9I7Fio7056966@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Mon, 18 Oct 2004 07:15:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/contrib/libreadline FREEBSD-upgrade X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 07:15:45 -0000 ache 2004-10-18 07:15:44 UTC FreeBSD src repository Modified files: contrib/libreadline FREEBSD-upgrade Log: Update instructions Revision Changes Path 1.6 +4 -4 src/contrib/libreadline/FREEBSD-upgrade From owner-cvs-src@FreeBSD.ORG Mon Oct 18 07:18:07 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7A10116A4CE; Mon, 18 Oct 2004 07:18:07 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6B1A743D4C; Mon, 18 Oct 2004 07:18:07 +0000 (GMT) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9I7I7cJ057091; Mon, 18 Oct 2004 07:18:07 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9I7I7mA057090; Mon, 18 Oct 2004 07:18:07 GMT (envelope-from ache) Message-Id: <200410180718.i9I7I7mA057090@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Mon, 18 Oct 2004 07:18:07 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/contrib/libreadline/doc hist.texinfo hstech.texinfo hsuser.texinfo manvers.texinfo rlman.texinfo rltech.texinfo rluser.texinfo rluserman.texinfo X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 07:18:07 -0000 ache 2004-10-18 07:18:07 UTC FreeBSD src repository Removed files: contrib/libreadline/doc hist.texinfo hstech.texinfo hsuser.texinfo manvers.texinfo rlman.texinfo rltech.texinfo rluser.texinfo rluserman.texinfo Log: Remove files not in 5.0 Revision Changes Path 1.2 +0 -112 src/contrib/libreadline/doc/hist.texinfo (dead) 1.2 +0 -504 src/contrib/libreadline/doc/hstech.texinfo (dead) 1.2 +0 -304 src/contrib/libreadline/doc/hsuser.texinfo (dead) 1.2 +0 -6 src/contrib/libreadline/doc/manvers.texinfo (dead) 1.2 +0 -110 src/contrib/libreadline/doc/rlman.texinfo (dead) 1.2 +0 -1530 src/contrib/libreadline/doc/rltech.texinfo (dead) 1.2 +0 -1166 src/contrib/libreadline/doc/rluser.texinfo (dead) 1.2 +0 -94 src/contrib/libreadline/doc/rluserman.texinfo (dead) From owner-cvs-src@FreeBSD.ORG Mon Oct 18 07:20:45 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1306D16A4CE; Mon, 18 Oct 2004 07:20:45 +0000 (GMT) Received: from darkness.comp.waw.pl (darkness.comp.waw.pl [195.117.238.136]) by mx1.FreeBSD.org (Postfix) with ESMTP id A6C4843D58; Mon, 18 Oct 2004 07:20:42 +0000 (GMT) (envelope-from pjd@darkness.comp.waw.pl) Received: by darkness.comp.waw.pl (Postfix, from userid 1009) id 569BEACAF1; Mon, 18 Oct 2004 09:20:26 +0200 (CEST) Date: Mon, 18 Oct 2004 09:20:26 +0200 From: Pawel Jakub Dawidek To: Andrey Chernov , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <20041018072026.GF73767@darkness.comp.waw.pl> References: <200410160813.i9G8DKlM063136@repoman.freebsd.org> <20041016193156.GA592@nagual.pp.ru> <20041016193910.GX73767@darkness.comp.waw.pl> <20041018060932.GA43041@nagual.pp.ru> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Ct7O0SBSsfHCgafd" Content-Disposition: inline In-Reply-To: <20041018060932.GA43041@nagual.pp.ru> User-Agent: Mutt/1.4.2i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 5.2.1-RC2 i386 Subject: Re: cvs commit: src/etc/defaults rc.conf src/etc/rc.d swap1 src/sbin/geom/class/mirror gmirror.8 src/share/man/man5 rc.conf.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 07:20:45 -0000 --Ct7O0SBSsfHCgafd Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 18, 2004 at 10:09:32AM +0400, Andrey Chernov wrote: +> On Sat, Oct 16, 2004 at 09:39:10PM +0200, Pawel Jakub Dawidek wrote: +> > Nope, it'll be fixed in more proper way in -CURRENT in the near future. +>=20 +> In that case, please apply your patch. I already reboot many times and i= t=20 +> works so far (I manually move 'int error;' under '#ifdef MAC'). The fix I'm planning to implement is different - as discussed with Scott Long the proper way to fix it, is to close mirrors via in-kernel shutdown hooks. --=20 Pawel Jakub Dawidek http://www.FreeBSD.org pjd@FreeBSD.org http://garage.freebsd.pl FreeBSD committer Am I Evil? Yes, I Am! --Ct7O0SBSsfHCgafd Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFBc266ForvXbEpPzQRAuEIAJ9Yg8poFymdiOmLPzf9ttA/RLqkggCglSxW 06mJsPB9qF1MgmUfLGqxe4Q= =Lihz -----END PGP SIGNATURE----- --Ct7O0SBSsfHCgafd-- From owner-cvs-src@FreeBSD.ORG Mon Oct 18 07:25:32 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CE56C16A4CE; Mon, 18 Oct 2004 07:25:32 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id ACF0B43D1D; Mon, 18 Oct 2004 07:25:32 +0000 (GMT) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9I7PW5Z057386; Mon, 18 Oct 2004 07:25:32 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9I7PWB1057385; Mon, 18 Oct 2004 07:25:32 GMT (envelope-from ache) Message-Id: <200410180725.i9I7PWB1057385@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Mon, 18 Oct 2004 07:25:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/contrib/libreadline readline.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 07:25:33 -0000 ache 2004-10-18 07:25:32 UTC FreeBSD src repository Modified files: contrib/libreadline readline.h Log: Merge local changes Revision Changes Path 1.16 +48 -11 src/contrib/libreadline/readline.h From owner-cvs-src@FreeBSD.ORG Mon Oct 18 07:47:40 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 28DE016A4CE; Mon, 18 Oct 2004 07:47:40 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 45D7E43D70; Mon, 18 Oct 2004 07:47:39 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i9I7lcED064248; Mon, 18 Oct 2004 10:47:38 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 65506-14; Mon, 18 Oct 2004 10:47:37 +0300 (EEST) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i9I7lbgU064245; Mon, 18 Oct 2004 10:47:37 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.1/8.13.1) id i9I7lUGH085879; Mon, 18 Oct 2004 10:47:30 +0300 (EEST) (envelope-from ru) Date: Mon, 18 Oct 2004 10:47:30 +0300 From: Ruslan Ermilov To: "Andrey A. Chernov" Message-ID: <20041018074729.GC75602@ip.net.ua> References: <200410180718.i9I7I7mA057090@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="7qSK/uQB79J36Y4o" Content-Disposition: inline In-Reply-To: <200410180718.i9I7I7mA057090@repoman.freebsd.org> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new at ip.net.ua cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/contrib/libreadline/doc hist.texinfo hstech.texinfo hsuser.texinfo manvers.texinfo rlman.texinfo rltech.texinfo rluser.texinfo rluserman.texinfo X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 07:47:40 -0000 --7qSK/uQB79J36Y4o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Andrey, On Mon, Oct 18, 2004 at 07:18:07AM +0000, Andrey A. Chernov wrote: > ache 2004-10-18 07:18:07 UTC >=20 > FreeBSD src repository >=20 > Removed files: > contrib/libreadline/doc hist.texinfo hstech.texinfo=20 > hsuser.texinfo manvers.texinfo=20 > rlman.texinfo rltech.texinfo=20 > rluser.texinfo rluserman.texinfo=20 > Log: > Remove files not in 5.0 > =20 > Revision Changes Path > 1.2 +0 -112 src/contrib/libreadline/doc/hist.texinfo (dead) > 1.2 +0 -504 src/contrib/libreadline/doc/hstech.texinfo (dead) > 1.2 +0 -304 src/contrib/libreadline/doc/hsuser.texinfo (dead) > 1.2 +0 -6 src/contrib/libreadline/doc/manvers.texinfo (dead) > 1.2 +0 -110 src/contrib/libreadline/doc/rlman.texinfo (dead) > 1.2 +0 -1530 src/contrib/libreadline/doc/rltech.texinfo (dead) > 1.2 +0 -1166 src/contrib/libreadline/doc/rluser.texinfo (dead) > 1.2 +0 -94 src/contrib/libreadline/doc/rluserman.texinfo (dea= d) >=20 Please also remove them from the vendor branch, so that "cvs co -rFSF" produces the same output as "cvs co -rv5_0_p1_p5". Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --7qSK/uQB79J36Y4o Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBc3URqRfpzJluFF4RAoFIAJ48XUGpyJXOcMmxfyw0Hmk+m4vI8ACgmoKK xiIUPqh/Z8N0UpKljQAyCPg= =2DHC -----END PGP SIGNATURE----- --7qSK/uQB79J36Y4o-- From owner-cvs-src@FreeBSD.ORG Mon Oct 18 07:49:59 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DC18B16A4D1; Mon, 18 Oct 2004 07:49:59 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9E11243D4C; Mon, 18 Oct 2004 07:49:59 +0000 (GMT) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9I7nxrI058416; Mon, 18 Oct 2004 07:49:59 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9I7nxhr058415; Mon, 18 Oct 2004 07:49:59 GMT (envelope-from ache) Message-Id: <200410180749.i9I7nxhr058415@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Mon, 18 Oct 2004 07:49:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/gnu/lib/libreadline config.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 07:50:00 -0000 ache 2004-10-18 07:49:59 UTC FreeBSD src repository Modified files: gnu/lib/libreadline config.h Log: Update for 5.0 Revision Changes Path 1.7 +23 -6 src/gnu/lib/libreadline/config.h From owner-cvs-src@FreeBSD.ORG Mon Oct 18 08:03:39 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4C4E116A4CE; Mon, 18 Oct 2004 08:03:39 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2B0BA43D45; Mon, 18 Oct 2004 08:03:39 +0000 (GMT) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9I83dgm058913; Mon, 18 Oct 2004 08:03:39 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9I83cw9058912; Mon, 18 Oct 2004 08:03:38 GMT (envelope-from ache) Message-Id: <200410180803.i9I83cw9058912@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Mon, 18 Oct 2004 08:03:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/gnu/lib/libreadline/readline/doc Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 08:03:39 -0000 ache 2004-10-18 08:03:38 UTC FreeBSD src repository Modified files: gnu/lib/libreadline/readline/doc Makefile Log: Upgrade to 5.0 Revision Changes Path 1.5 +6 -6 src/gnu/lib/libreadline/readline/doc/Makefile From owner-cvs-src@FreeBSD.ORG Mon Oct 18 08:08:03 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 825AF16A4CE; Mon, 18 Oct 2004 08:08:03 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6257043D48; Mon, 18 Oct 2004 08:08:03 +0000 (GMT) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9I883l6059111; Mon, 18 Oct 2004 08:08:03 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9I883Uc059110; Mon, 18 Oct 2004 08:08:03 GMT (envelope-from ache) Message-Id: <200410180808.i9I883Uc059110@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Mon, 18 Oct 2004 08:08:03 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/gnu/lib/libreadline/history/doc Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 08:08:03 -0000 ache 2004-10-18 08:08:03 UTC FreeBSD src repository Modified files: gnu/lib/libreadline/history/doc Makefile Log: Upgrade to 5.0 Revision Changes Path 1.3 +1 -3 src/gnu/lib/libreadline/history/doc/Makefile From owner-cvs-src@FreeBSD.ORG Mon Oct 18 08:11:59 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 926A416A4CE; Mon, 18 Oct 2004 08:11:59 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6E95443D45; Mon, 18 Oct 2004 08:11:59 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9I8Bx2D059270; Mon, 18 Oct 2004 08:11:59 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9I8Bx7T059269; Mon, 18 Oct 2004 08:11:59 GMT (envelope-from alc) Message-Id: <200410180811.i9I8Bx7T059269@repoman.freebsd.org> From: Alan Cox Date: Mon, 18 Oct 2004 08:11:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/vm vm_page.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 08:11:59 -0000 alc 2004-10-18 08:11:59 UTC FreeBSD src repository Modified files: sys/vm vm_page.c Log: Correct two errors in PG_BUSY management by vm_page_cowfault(). Both errors are in rarely executed paths. 1. Each time the retry_alloc path is taken, the PG_BUSY must be set again. Otherwise vm_page_remove() panics. 2. There is no need to set PG_BUSY on the newly allocated page before freeing it. The page already has PG_BUSY set by vm_page_alloc(). Setting it again could cause an assertion failure. MFC after: 2 weeks Revision Changes Path 1.293 +1 -2 src/sys/vm/vm_page.c From owner-cvs-src@FreeBSD.ORG Mon Oct 18 08:14:48 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8E41616A4CE; Mon, 18 Oct 2004 08:14:48 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7F31343D2F; Mon, 18 Oct 2004 08:14:48 +0000 (GMT) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9I8Emo0059419; Mon, 18 Oct 2004 08:14:48 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9I8EmSr059418; Mon, 18 Oct 2004 08:14:48 GMT (envelope-from ache) Message-Id: <200410180814.i9I8EmSr059418@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Mon, 18 Oct 2004 08:14:48 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: FSF Subject: cvs commit: src/contrib/libreadline/doc hist.texinfo hstech.texinfo hsuser.texinfo manvers.texinfo rlman.texinfo rltech.texinfo rluser.texinfo rluserman.texinfo X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 08:14:48 -0000 ache 2004-10-18 08:14:48 UTC FreeBSD src repository Removed files: (Branch: FSF) contrib/libreadline/doc hist.texinfo hstech.texinfo hsuser.texinfo manvers.texinfo rlman.texinfo rltech.texinfo rluser.texinfo rluserman.texinfo Log: This files no longer used Asked-by: ru Revision Changes Path 1.1.1.7 +0 -110 src/contrib/libreadline/doc/hist.texinfo (dead) 1.1.1.6 +0 -550 src/contrib/libreadline/doc/hstech.texinfo (dead) 1.1.1.6 +0 -437 src/contrib/libreadline/doc/hsuser.texinfo (dead) 1.1.1.5 +0 -10 src/contrib/libreadline/doc/manvers.texinfo (dead) 1.1.1.7 +0 -108 src/contrib/libreadline/doc/rlman.texinfo (dead) 1.1.1.8 +0 -2165 src/contrib/libreadline/doc/rltech.texinfo (dead) 1.1.1.8 +0 -1796 src/contrib/libreadline/doc/rluser.texinfo (dead) 1.1.1.4 +0 -94 src/contrib/libreadline/doc/rluserman.texinfo (dead) From owner-cvs-src@FreeBSD.ORG Mon Oct 18 08:29:48 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2282716A4CE; Mon, 18 Oct 2004 08:29:48 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 003E643D58; Mon, 18 Oct 2004 08:29:48 +0000 (GMT) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9I8Tl6p059878; Mon, 18 Oct 2004 08:29:47 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9I8Tl4n059877; Mon, 18 Oct 2004 08:29:47 GMT (envelope-from ache) Message-Id: <200410180829.i9I8Tl4n059877@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Mon, 18 Oct 2004 08:29:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/gnu/lib/libreadline Makefile.inc X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 08:29:48 -0000 ache 2004-10-18 08:29:47 UTC FreeBSD src repository Modified files: gnu/lib/libreadline Makefile.inc Log: Upgrade to 5.0 Revision Changes Path 1.11 +1 -1 src/gnu/lib/libreadline/Makefile.inc From owner-cvs-src@FreeBSD.ORG Mon Oct 18 08:36:41 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 76F0116A4CE; Mon, 18 Oct 2004 08:36:41 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 30A7643D41; Mon, 18 Oct 2004 08:36:41 +0000 (GMT) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9I8afuV060145; Mon, 18 Oct 2004 08:36:41 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9I8afRS060144; Mon, 18 Oct 2004 08:36:41 GMT (envelope-from ache) Message-Id: <200410180836.i9I8afRS060144@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Mon, 18 Oct 2004 08:36:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/gnu/lib/libreadline/readline Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 08:36:41 -0000 ache 2004-10-18 08:36:40 UTC FreeBSD src repository Modified files: gnu/lib/libreadline/readline Makefile Log: Back out termcap -> ncurses change in LDADD/DPADD It expand functions scope too wide Revision Changes Path 1.13 +2 -2 src/gnu/lib/libreadline/readline/Makefile From owner-cvs-src@FreeBSD.ORG Mon Oct 18 08:54:17 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7620C16A4E5; Mon, 18 Oct 2004 08:54:17 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5380F43D31; Mon, 18 Oct 2004 08:54:17 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9I8sHCH066974; Mon, 18 Oct 2004 08:54:17 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9I8sHnD066973; Mon, 18 Oct 2004 08:54:17 GMT (envelope-from ru) Message-Id: <200410180854.i9I8sHnD066973@repoman.freebsd.org> From: Ruslan Ermilov Date: Mon, 18 Oct 2004 08:54:17 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/numericdef Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 08:54:17 -0000 ru 2004-10-18 08:54:17 UTC FreeBSD src repository Modified files: share/numericdef Makefile Log: Utilize FILES and SYMLINKS. Revision Changes Path 1.58 +69 -181 src/share/numericdef/Makefile From owner-cvs-src@FreeBSD.ORG Mon Oct 18 09:03:32 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2BDBF16A4CE; Mon, 18 Oct 2004 09:03:32 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5FA9B43D2F; Mon, 18 Oct 2004 09:03:31 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i9I93UdB067331; Mon, 18 Oct 2004 12:03:30 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 74059-09; Mon, 18 Oct 2004 12:03:29 +0300 (EEST) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i9I93M1q067327; Mon, 18 Oct 2004 12:03:25 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.1/8.13.1) id i9I93EOP086591; Mon, 18 Oct 2004 12:03:14 +0300 (EEST) (envelope-from ru) Date: Mon, 18 Oct 2004 12:03:14 +0300 From: Ruslan Ermilov To: "Andrey A. Chernov" Message-ID: <20041018090314.GA86525@ip.net.ua> References: <200410180836.i9I8afRS060144@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BOKacYhQ+x31HxR3" Content-Disposition: inline In-Reply-To: <200410180836.i9I8afRS060144@repoman.freebsd.org> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new at ip.net.ua cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/gnu/lib/libreadline/readline Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 09:03:32 -0000 --BOKacYhQ+x31HxR3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 18, 2004 at 08:36:40AM +0000, Andrey A. Chernov wrote: > ache 2004-10-18 08:36:40 UTC >=20 > FreeBSD src repository >=20 > Modified files: > gnu/lib/libreadline/readline Makefile=20 > Log: > Back out termcap -> ncurses change in LDADD/DPADD > It expand functions scope too wide > =20 > Revision Changes Path > 1.13 +2 -2 src/gnu/lib/libreadline/readline/Makefile >=20 Why a backout? Unless you make a real termcap library, this is just pointless -- we've discussed this already, and we should all know that what gets recorded as a real dependency in a binary is still spelled "libncurses.so". Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --BOKacYhQ+x31HxR3 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBc4bSqRfpzJluFF4RAtYwAJ9WopJEHDdBqUyEwKKvLIbRn17chACfSTla ZOmFbCjNvunSbMhJ79fkKns= =Ww/3 -----END PGP SIGNATURE----- --BOKacYhQ+x31HxR3-- From owner-cvs-src@FreeBSD.ORG Mon Oct 18 09:05:53 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7198B16A4CE; Mon, 18 Oct 2004 09:05:53 +0000 (GMT) Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8FB2943D39; Mon, 18 Oct 2004 09:05:52 +0000 (GMT) (envelope-from ache@pobrecita.freebsd.ru) Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.13.1/8.13.1) with ESMTP id i9I95pUp059393; Mon, 18 Oct 2004 13:05:51 +0400 (MSD) (envelope-from ache@pobrecita.freebsd.ru) Received: (from ache@localhost) by pobrecita.freebsd.ru (8.13.1/8.13.1/Submit) id i9I95pi8059392; Mon, 18 Oct 2004 13:05:51 +0400 (MSD) (envelope-from ache) Date: Mon, 18 Oct 2004 13:05:51 +0400 From: Andrey Chernov To: Ruslan Ermilov Message-ID: <20041018090550.GA59302@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Ruslan Ermilov , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200410180836.i9I8afRS060144@repoman.freebsd.org> <20041018090314.GA86525@ip.net.ua> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="17pEHd4RhPHOinZp" Content-Disposition: inline In-Reply-To: <20041018090314.GA86525@ip.net.ua> User-Agent: Mutt/1.5.6i X-AntiVirus: checked by AntiVir Milter 1.1-beta; AVE 6.28.0.7; VDF 6.28.0.20 (host: pobrecita.freebsd.ru) cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/gnu/lib/libreadline/readline Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 09:05:53 -0000 --17pEHd4RhPHOinZp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 18, 2004 at 12:03:14PM +0300, Ruslan Ermilov wrote: > Why a backout? Unless you make a real termcap library, > this is just pointless -- we've discussed this already, > and we should all know that what gets recorded as a real > dependency in a binary is still spelled "libncurses.so". See private mail. Real dependency unchanged after back out: /lib/libreadline.so.5: libncurses.so.5 =3D> /lib/libncurses.so.5 (0x2819a000) --=20 Andrey Chernov | http://ache.pp.ru/ --17pEHd4RhPHOinZp Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iQCVAwUBQXOHbuJgpPLZnQjrAQEEjQQAh3xgt46ACH8wftJk9LUu0EHFxlHwihUF qh9DB0IuJXaSyUzUCGVznElmqplQoqkzoHJP1QlHlTvkLB+qgpImll8pnUf/8WsI DlrqZAJMPHerPEDzX02mV4/wW+YGfkzGQrpuPFhMt+lf3JX8VpAgmQsCxyEi0/So EKhHE4k86VM= =Wf54 -----END PGP SIGNATURE----- --17pEHd4RhPHOinZp-- From owner-cvs-src@FreeBSD.ORG Mon Oct 18 09:10:21 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A224316A506; Mon, 18 Oct 2004 09:10:21 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id C86E243D45; Mon, 18 Oct 2004 09:10:20 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i9I9AJVO068029; Mon, 18 Oct 2004 12:10:20 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 74574-14; Mon, 18 Oct 2004 12:10:18 +0300 (EEST) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i9I9ABeh068025; Mon, 18 Oct 2004 12:10:14 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.1/8.13.1) id i9I9A4I3086681; Mon, 18 Oct 2004 12:10:04 +0300 (EEST) (envelope-from ru) Date: Mon, 18 Oct 2004 12:10:04 +0300 From: Ruslan Ermilov To: Andrey Chernov , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG Message-ID: <20041018091004.GC86525@ip.net.ua> References: <200410180836.i9I8afRS060144@repoman.freebsd.org> <20041018090314.GA86525@ip.net.ua> <20041018090550.GA59302@nagual.pp.ru> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="PuGuTyElPB9bOcsM" Content-Disposition: inline In-Reply-To: <20041018090550.GA59302@nagual.pp.ru> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new at ip.net.ua Subject: Re: cvs commit: src/gnu/lib/libreadline/readline Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 09:10:21 -0000 --PuGuTyElPB9bOcsM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 18, 2004 at 01:05:51PM +0400, Andrey Chernov wrote: > On Mon, Oct 18, 2004 at 12:03:14PM +0300, Ruslan Ermilov wrote: > > Why a backout? Unless you make a real termcap library, > > this is just pointless -- we've discussed this already, > > and we should all know that what gets recorded as a real > > dependency in a binary is still spelled "libncurses.so". >=20 > See private mail. Real dependency unchanged after back out: >=20 > /lib/libreadline.so.5: > libncurses.so.5 =3D> /lib/libncurses.so.5 (0x2819a000) >=20 Yes, real dependency recorded in binaries is for libncurses, and that was a reason that DPADD and LDADD were changed to point to libncurses. So, what was the reason for backing this out? Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --PuGuTyElPB9bOcsM Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBc4hsqRfpzJluFF4RAp9WAJ9tqj1gqqiY3eN9FpFREFm8jFe2zgCggdHx wOynxX/8c9FzUtn07w9AJo8= =69Xw -----END PGP SIGNATURE----- --PuGuTyElPB9bOcsM-- From owner-cvs-src@FreeBSD.ORG Mon Oct 18 09:13:10 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B7ECB16A4CE; Mon, 18 Oct 2004 09:13:10 +0000 (GMT) Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id F342243D39; Mon, 18 Oct 2004 09:13:09 +0000 (GMT) (envelope-from ache@pobrecita.freebsd.ru) Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.13.1/8.13.1) with ESMTP id i9I9D5Rd059656; Mon, 18 Oct 2004 13:13:05 +0400 (MSD) (envelope-from ache@pobrecita.freebsd.ru) Received: (from ache@localhost) by pobrecita.freebsd.ru (8.13.1/8.13.1/Submit) id i9I9D5EF059655; Mon, 18 Oct 2004 13:13:05 +0400 (MSD) (envelope-from ache) Date: Mon, 18 Oct 2004 13:13:03 +0400 From: Andrey Chernov To: Ruslan Ermilov Message-ID: <20041018091303.GC59302@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Ruslan Ermilov , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200410180836.i9I8afRS060144@repoman.freebsd.org> <20041018090314.GA86525@ip.net.ua> <20041018090550.GA59302@nagual.pp.ru> <20041018091004.GC86525@ip.net.ua> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="CblX+4bnyfN0pR09" Content-Disposition: inline In-Reply-To: <20041018091004.GC86525@ip.net.ua> User-Agent: Mutt/1.5.6i X-AntiVirus: checked by AntiVir Milter 1.1-beta; AVE 6.28.0.7; VDF 6.28.0.20 (host: pobrecita.freebsd.ru) cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/gnu/lib/libreadline/readline Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 09:13:10 -0000 --CblX+4bnyfN0pR09 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 18, 2004 at 12:10:04PM +0300, Ruslan Ermilov wrote: > Yes, real dependency recorded in binaries is for libncurses, > and that was a reason that DPADD and LDADD were changed to > point to libncurses. So, what was the reason for backing > this out? The reason is mentioned in commit message: to indicate proper scope of=20 functions. Somebody could look there and write -lreadline -lncurses, and=20 it is unportable as minimum. Since nothing is changed in the file, proper indication is good thing. --=20 Andrey Chernov | http://ache.pp.ru/ --CblX+4bnyfN0pR09 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iQCVAwUBQXOJH+JgpPLZnQjrAQHIuwQAzzVKt9JCBPVAQvkRcvTqNrX0SKTsbddn p5RPtic83phiDBvxU0jNQs40fmfUNyEt6inQGSro1WArCPO9uHvXMRZEEDXC6htO JN5Qu3zQYy0pdYJR9GlauVmwVKEFqHeHPsiNlvdNernee8zUz6pV0ck+WI9f4ELb yJEIhDPBjLY= =DEeJ -----END PGP SIGNATURE----- --CblX+4bnyfN0pR09-- From owner-cvs-src@FreeBSD.ORG Mon Oct 18 09:19:30 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8188F16A4CE; Mon, 18 Oct 2004 09:19:30 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id B04C443D1F; Mon, 18 Oct 2004 09:19:29 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i9I9JSYV068416; Mon, 18 Oct 2004 12:19:28 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 75665-04; Mon, 18 Oct 2004 12:19:28 +0300 (EEST) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i9I9JLQG068413; Mon, 18 Oct 2004 12:19:24 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.1/8.13.1) id i9I9JCud086790; Mon, 18 Oct 2004 12:19:12 +0300 (EEST) (envelope-from ru) Date: Mon, 18 Oct 2004 12:19:03 +0300 From: Ruslan Ermilov To: Andrey Chernov , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG Message-ID: <20041018091903.GD86525@ip.net.ua> References: <200410180836.i9I8afRS060144@repoman.freebsd.org> <20041018090314.GA86525@ip.net.ua> <20041018090550.GA59302@nagual.pp.ru> <20041018091004.GC86525@ip.net.ua> <20041018091303.GC59302@nagual.pp.ru> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="OROCMA9jn6tkzFBc" Content-Disposition: inline In-Reply-To: <20041018091303.GC59302@nagual.pp.ru> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new at ip.net.ua Subject: Re: cvs commit: src/gnu/lib/libreadline/readline Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 09:19:30 -0000 --OROCMA9jn6tkzFBc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 18, 2004 at 01:13:03PM +0400, Andrey Chernov wrote: > On Mon, Oct 18, 2004 at 12:10:04PM +0300, Ruslan Ermilov wrote: > > Yes, real dependency recorded in binaries is for libncurses, > > and that was a reason that DPADD and LDADD were changed to > > point to libncurses. So, what was the reason for backing > > this out? >=20 > The reason is mentioned in commit message: to indicate proper scope of=20 > functions. Somebody could look there and write -lreadline -lncurses, and= =20 > it is unportable as minimum. >=20 > Since nothing is changed in the file, proper indication is good thing. >=20 My understanding of this is a bit different: these are all FreeBSD makefiles, they use FreeBSD set of libraries, in which the only real library is libncurses, and libtermcap is only provided for third-party software that may want to link with libtermcap. What porting do you mean here? But I won't argue about it anymore... Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --OROCMA9jn6tkzFBc Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBc4qHqRfpzJluFF4RAmm0AJ9oE/iz4kD/Y7cU4i5lz9hMsCEQNACgkmvl KOlA2bO+uL+KAuQZYbVYEBk= =0e2l -----END PGP SIGNATURE----- --OROCMA9jn6tkzFBc-- From owner-cvs-src@FreeBSD.ORG Mon Oct 18 09:23:50 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2D6A216A521; Mon, 18 Oct 2004 09:23:49 +0000 (GMT) Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id CE3DD43D48; Mon, 18 Oct 2004 09:23:48 +0000 (GMT) (envelope-from ache@pobrecita.freebsd.ru) Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.13.1/8.13.1) with ESMTP id i9I9Nl9O059952; Mon, 18 Oct 2004 13:23:47 +0400 (MSD) (envelope-from ache@pobrecita.freebsd.ru) Received: (from ache@localhost) by pobrecita.freebsd.ru (8.13.1/8.13.1/Submit) id i9I9Nlp1059951; Mon, 18 Oct 2004 13:23:47 +0400 (MSD) (envelope-from ache) Date: Mon, 18 Oct 2004 13:23:47 +0400 From: Andrey Chernov To: Ruslan Ermilov Message-ID: <20041018092347.GA59835@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Ruslan Ermilov , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200410180836.i9I8afRS060144@repoman.freebsd.org> <20041018090314.GA86525@ip.net.ua> <20041018090550.GA59302@nagual.pp.ru> <20041018091004.GC86525@ip.net.ua> <20041018091303.GC59302@nagual.pp.ru> <20041018091903.GD86525@ip.net.ua> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="8t9RHnE3ZwKMSgU+" Content-Disposition: inline In-Reply-To: <20041018091903.GD86525@ip.net.ua> User-Agent: Mutt/1.5.6i X-AntiVirus: checked by AntiVir Milter 1.1-beta; AVE 6.28.0.7; VDF 6.28.0.20 (host: pobrecita.freebsd.ru) cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/gnu/lib/libreadline/readline Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 09:23:50 -0000 --8t9RHnE3ZwKMSgU+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 18, 2004 at 12:19:03PM +0300, Ruslan Ermilov wrote: > My understanding of this is a bit different: these are all FreeBSD > makefiles, they use FreeBSD set of libraries, in which the only real > library is libncurses, and libtermcap is only provided for third-party > software that may want to link with libtermcap. What porting do > you mean here? But I won't argue about it anymore... In theory we can switch to another *curses, or make termcap as separate=20 library (even derived from ncurses, subset) to save lots of static linking= =20 space. In all such cases in my variant we don't need to touch anything,=20 but in yours mass Makefiles rewriting required. --=20 Andrey Chernov | http://ache.pp.ru/ --8t9RHnE3ZwKMSgU+ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iQCVAwUBQXOLo+JgpPLZnQjrAQFgrgP9ERjngkP1xq7MJOxsj0BzyNIHuDPyB+LW MCQFuf2fZPUgfuBgzJFpLnDWeH6L6FmVcpPFgImu7OKZH+8eldmEeUJ6czNcvRf9 FwTiqKt+gY6pu+TFezPE+uRjnhPIBVOXUlwRz80qkKuZXixGhyHiF6e1Hij8v80q eX9iC9mTJ8Q= =3VuG -----END PGP SIGNATURE----- --8t9RHnE3ZwKMSgU+-- From owner-cvs-src@FreeBSD.ORG Mon Oct 18 09:27:50 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0D49D16A4CE; Mon, 18 Oct 2004 09:27:50 +0000 (GMT) Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5025A43D54; Mon, 18 Oct 2004 09:27:49 +0000 (GMT) (envelope-from ache@pobrecita.freebsd.ru) Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.13.1/8.13.1) with ESMTP id i9I9RmOW060094; Mon, 18 Oct 2004 13:27:48 +0400 (MSD) (envelope-from ache@pobrecita.freebsd.ru) Received: (from ache@localhost) by pobrecita.freebsd.ru (8.13.1/8.13.1/Submit) id i9I9Rl3v060093; Mon, 18 Oct 2004 13:27:47 +0400 (MSD) (envelope-from ache) Date: Mon, 18 Oct 2004 13:27:47 +0400 From: Andrey Chernov To: Ruslan Ermilov , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG Message-ID: <20041018092747.GB59835@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Ruslan Ermilov , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200410180836.i9I8afRS060144@repoman.freebsd.org> <20041018090314.GA86525@ip.net.ua> <20041018090550.GA59302@nagual.pp.ru> <20041018091004.GC86525@ip.net.ua> <20041018091303.GC59302@nagual.pp.ru> <20041018091903.GD86525@ip.net.ua> <20041018092347.GA59835@nagual.pp.ru> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="yNb1oOkm5a9FJOVX" Content-Disposition: inline In-Reply-To: <20041018092347.GA59835@nagual.pp.ru> User-Agent: Mutt/1.5.6i X-AntiVirus: checked by AntiVir Milter 1.1-beta; AVE 6.28.0.7; VDF 6.28.0.20 (host: pobrecita.freebsd.ru) Subject: Re: cvs commit: src/gnu/lib/libreadline/readline Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 09:27:50 -0000 --yNb1oOkm5a9FJOVX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 18, 2004 at 01:23:47PM +0400, Andrey Chernov wrote: > In theory we can switch to another *curses, or make termcap as separate= =20 > library (even derived from ncurses, subset) to save lots of static linkin= g=20 > space. In all such cases in my variant we don't need to touch anything,= =20 > but in yours mass Makefiles rewriting required. In other words: libraries and applications are linked to termcap, without= =20 knowing its implementation details. It is good, because things can be=20 changed on the fly without any editing. But you insist that they MUST know= =20 implementation details. I see no reason for it. --=20 Andrey Chernov | http://ache.pp.ru/ --yNb1oOkm5a9FJOVX Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iQCVAwUBQXOMk+JgpPLZnQjrAQHPVQP/ZeBR/UuEQB9eLYc81qNxlEXIHng7eKB+ ba4Dn5R59aFDT4J2SzZGUQMtcqCxaPuIv60rC+MwtVAQIK5HuhNLI9PAzizU0LL7 uokCvoJN/+igJmIqFZ1UmgBdKxes/CPmF7xeOilcObEFqETuSnB3QTzbdYd5p4Qh mjW3a0y3Kz4= =WD46 -----END PGP SIGNATURE----- --yNb1oOkm5a9FJOVX-- From owner-cvs-src@FreeBSD.ORG Mon Oct 18 10:02:05 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4046216A4CE; Mon, 18 Oct 2004 10:02:05 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 202C243D39; Mon, 18 Oct 2004 10:02:05 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9IA24gi069137; Mon, 18 Oct 2004 10:02:04 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9IA24uf069136; Mon, 18 Oct 2004 10:02:04 GMT (envelope-from yar) Message-Id: <200410181002.i9IA24uf069136@repoman.freebsd.org> From: Yar Tikhiy Date: Mon, 18 Oct 2004 10:02:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libc/sys sendfile.2 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 10:02:05 -0000 yar 2004-10-18 10:02:04 UTC FreeBSD src repository Modified files: lib/libc/sys sendfile.2 Log: Since sendfile(2) works on regular files only, which have no negative offsets, "negative" and "invalid" are equivalent WRT the offset argument. Suggested by: bde Revision Changes Path 1.26 +1 -1 src/lib/libc/sys/sendfile.2 From owner-cvs-src@FreeBSD.ORG Mon Oct 18 10:11:32 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A0B7716A4CE; Mon, 18 Oct 2004 10:11:32 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 808BB43D54; Mon, 18 Oct 2004 10:11:32 +0000 (GMT) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9IABWUU069479; Mon, 18 Oct 2004 10:11:32 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9IABWlA069478; Mon, 18 Oct 2004 10:11:32 GMT (envelope-from ache) Message-Id: <200410181011.i9IABWlA069478@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Mon, 18 Oct 2004 10:11:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: CVSROOT modules X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 10:11:32 -0000 ache 2004-10-18 10:11:32 UTC FreeBSD src repository Modified files: . modules Log: gdb -> src/gnu/usr.bin/gdb Revision Changes Path 1.6855 +1 -0 CVSROOT/modules From owner-cvs-src@FreeBSD.ORG Mon Oct 18 10:13:24 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C8E9D16A4CE; Mon, 18 Oct 2004 10:13:24 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A7D2B43D69; Mon, 18 Oct 2004 10:13:24 +0000 (GMT) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9IADOMG069617; Mon, 18 Oct 2004 10:13:24 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9IADOMn069616; Mon, 18 Oct 2004 10:13:24 GMT (envelope-from ache) Message-Id: <200410181013.i9IADOMn069616@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Mon, 18 Oct 2004 10:13:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/gnu/usr.bin/gdb/doc Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 10:13:24 -0000 ache 2004-10-18 10:13:24 UTC FreeBSD src repository Modified files: gnu/usr.bin/gdb/doc Makefile Log: Update to readline 5.0 Revision Changes Path 1.13 +7 -3 src/gnu/usr.bin/gdb/doc/Makefile From owner-cvs-src@FreeBSD.ORG Mon Oct 18 11:23:11 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DFDEC16A536; Mon, 18 Oct 2004 11:23:11 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BE74643D2D; Mon, 18 Oct 2004 11:23:11 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9IBNBhD071690; Mon, 18 Oct 2004 11:23:11 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9IBNBM5071689; Mon, 18 Oct 2004 11:23:11 GMT (envelope-from rwatson) Message-Id: <200410181123.i9IBNBM5071689@repoman.freebsd.org> From: Robert Watson Date: Mon, 18 Oct 2004 11:23:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/nfsserver nfs_serv.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 11:23:12 -0000 rwatson 2004-10-18 11:23:11 UTC FreeBSD src repository Modified files: sys/nfsserver nfs_serv.c Log: Correct several instances where calls to vfs_getvfs() resulting in failure in the NFS server would result in a leaked instance of the NFS server subsystem lock. Liberally sprinkle assertions in all target labels for error unwinding to assert the desired locking state. RELENG_5_3 candidate. MFC after: 3 days Reported by: Wilkinson, Alex Revision Changes Path 1.149 +61 -13 src/sys/nfsserver/nfs_serv.c From owner-cvs-src@FreeBSD.ORG Mon Oct 18 11:56:58 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 314B416A4CE; Mon, 18 Oct 2004 11:56:58 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0D4B043D2D; Mon, 18 Oct 2004 11:56:57 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i9IBusZj076923; Mon, 18 Oct 2004 14:56:54 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 93489-14; Mon, 18 Oct 2004 14:56:54 +0300 (EEST) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i9IBukVa076883; Mon, 18 Oct 2004 14:56:49 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.1/8.13.1) id i9IBuWTh087948; Mon, 18 Oct 2004 14:56:32 +0300 (EEST) (envelope-from ru) Date: Mon, 18 Oct 2004 14:56:32 +0300 From: Ruslan Ermilov To: Andrey Chernov , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG Message-ID: <20041018115632.GA87870@ip.net.ua> References: <200410180836.i9I8afRS060144@repoman.freebsd.org> <20041018090314.GA86525@ip.net.ua> <20041018090550.GA59302@nagual.pp.ru> <20041018091004.GC86525@ip.net.ua> <20041018091303.GC59302@nagual.pp.ru> <20041018091903.GD86525@ip.net.ua> <20041018092347.GA59835@nagual.pp.ru> <20041018092747.GB59835@nagual.pp.ru> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="rwEMma7ioTxnRzrJ" Content-Disposition: inline In-Reply-To: <20041018092747.GB59835@nagual.pp.ru> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new at ip.net.ua Subject: Re: cvs commit: src/gnu/lib/libreadline/readline Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 11:56:58 -0000 --rwEMma7ioTxnRzrJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 18, 2004 at 01:27:47PM +0400, Andrey Chernov wrote: > On Mon, Oct 18, 2004 at 01:23:47PM +0400, Andrey Chernov wrote: > > In theory we can switch to another *curses, or make termcap as separate= =20 > > library (even derived from ncurses, subset) to save lots of static link= ing=20 > > space. >=20 Having a separate libtermcap library won't save anything with static linkage as long as it's a subset of libncurses. Ideally, the binary linked with the real termcap library which is a subset of the ncurses library will even be of the same checksum. > > In all such cases in my variant we don't need to touch anything,=20 > > but in yours mass Makefiles rewriting required. >=20 > In other words: libraries and applications are linked to termcap, without= =20 > knowing its implementation details. It is good, because things can be=20 > changed on the fly without any editing. But you insist that they MUST kno= w=20 > implementation details. I see no reason for it. >=20 It's simple. There's no termcap library, whether you specify -lncurses or -ltermcap doesn't matter, libraries and applications linked with either of them all get libncurses.so as their runtime dependency: run ldd(1) and get it. ;) In other words: if you make a real libtermcap today (as a subset of libncurses), you cannot expect old dynamically linked binaries to magically start using it, because they have libncurses.so recorded as their dependency. The difference between us is how we treat the libtermcap symlinks. I treat them as compatibility stuff only for third-party applications that are not part of the standard FreeBSD distribution, and you seem to treat them as different API libraries. I also fail to get your point about why linking with -lncurses as opposed to with -ltermcap is unportable. I have a simple question for you: in your opinion, what's wrong with replacing all these -l{curses,mytinfo,termcap,termlib,tinfo} with one true -lncurses? I planned doing it one day, but you seem to be against it, as follows from the above. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --rwEMma7ioTxnRzrJ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBc69wqRfpzJluFF4RAiSZAJ41yjXhfEuAxxDcpBnPOa/EqnTVqQCeNXon Lz4/8+9tuylHWD/Wql0mSHQ= =nB6x -----END PGP SIGNATURE----- --rwEMma7ioTxnRzrJ-- From owner-cvs-src@FreeBSD.ORG Mon Oct 18 12:08:16 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4C24616A4CE; Mon, 18 Oct 2004 12:08:16 +0000 (GMT) Received: from mailout01.sul.t-online.com (mailout01.sul.t-online.com [194.25.134.80]) by mx1.FreeBSD.org (Postfix) with ESMTP id C4DA243D1D; Mon, 18 Oct 2004 12:08:15 +0000 (GMT) (envelope-from Alexander@Leidinger.net) Received: from fwd08.aul.t-online.de by mailout01.sul.t-online.com with smtp id 1CJWJC-0001vK-02; Mon, 18 Oct 2004 14:08:14 +0200 Received: from Andro-Beta.Leidinger.net (rSjDq6ZerePezF2Nth-qgK6JISq6ta38Nw8H4P5qvrrObLK+7WQqrM@[84.128.193.206]) by fmrl08.sul.t-online.com with esmtp id 1CJWIv-19KXZo0; Mon, 18 Oct 2004 14:07:57 +0200 Received: from Andro-Beta.Leidinger.net (localhost [127.0.0.1]) i9IC7sXk046073; Mon, 18 Oct 2004 14:07:55 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Received: (from www@localhost)i9IC7sGK046072; Mon, 18 Oct 2004 14:07:54 +0200 (CEST) (envelope-from Alexander@Leidinger.net) X-Authentication-Warning: Andro-Beta.Leidinger.net: www set sender to Alexander@Leidinger.net using -f Received: from wwwproxy-2.sns-felb.debis.de (wwwproxy-2.sns-felb.debis.de [53.122.192.14]) by netchild.homeip.net (IMP) with HTTP for ; Mon, 18 Oct 2004 14:07:52 +0200 Message-ID: <1098101272.4173b21825a40@netchild.homeip.net> Date: Mon, 18 Oct 2004 14:07:52 +0200 From: Alexander@Leidinger.net To: "David E. O'Brien" References: <200410180534.i9I5YsGn053852@repoman.freebsd.org> In-Reply-To: <200410180534.i9I5YsGn053852@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit User-Agent: Internet Messaging Program (IMP) 3.2.6 / FreeBSD-4.10 X-Originating-IP: 53.122.192.14 X-ID: rSjDq6ZerePezF2Nth-qgK6JISq6ta38Nw8H4P5qvrrObLK+7WQqrM@t-dialin.net X-TOI-MSGID: bd6678ce-0a82-4885-9035-0ea5336c45d8 cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.sbin/pkg_install/info info.h main.c src/usr.sbin/pkg_install/lib global.c lib.h src/usr.sbin/pkg_install/version main.c perform.c pkg_version.1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 12:08:16 -0000 Zitat von "David E. O'Brien" : > Add a -q flag to pkg_version. It suppresses the output of <,=,>. > This makes it possible to "portupgrade `pkg_version -q -l '<'`". What's the difference between this and "portupgrade -a"? Even when you intent to filter the output of pkg_version first I don't see the need for it, portupgrade has an exclude feature. Bye, Alexander. From owner-cvs-src@FreeBSD.ORG Mon Oct 18 12:11:23 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C122C16A4CE; Mon, 18 Oct 2004 12:11:23 +0000 (GMT) Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id E401643D1F; Mon, 18 Oct 2004 12:11:22 +0000 (GMT) (envelope-from ache@pobrecita.freebsd.ru) Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.13.1/8.13.1) with ESMTP id i9ICBK8D067981; Mon, 18 Oct 2004 16:11:20 +0400 (MSD) (envelope-from ache@pobrecita.freebsd.ru) Received: (from ache@localhost) by pobrecita.freebsd.ru (8.13.1/8.13.1/Submit) id i9ICBKmP067976; Mon, 18 Oct 2004 16:11:20 +0400 (MSD) (envelope-from ache) Date: Mon, 18 Oct 2004 16:11:20 +0400 From: Andrey Chernov To: Ruslan Ermilov Message-ID: <20041018121120.GA67831@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Ruslan Ermilov , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200410180836.i9I8afRS060144@repoman.freebsd.org> <20041018090314.GA86525@ip.net.ua> <20041018090550.GA59302@nagual.pp.ru> <20041018091004.GC86525@ip.net.ua> <20041018091303.GC59302@nagual.pp.ru> <20041018091903.GD86525@ip.net.ua> <20041018092347.GA59835@nagual.pp.ru> <20041018092747.GB59835@nagual.pp.ru> <20041018115632.GA87870@ip.net.ua> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="LZvS9be/3tNcYl/X" Content-Disposition: inline In-Reply-To: <20041018115632.GA87870@ip.net.ua> User-Agent: Mutt/1.5.6i X-AntiVirus: checked by AntiVir Milter 1.1-beta; AVE 6.28.0.7; VDF 6.28.0.20 (host: pobrecita.freebsd.ru) cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/gnu/lib/libreadline/readline Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 12:11:24 -0000 --LZvS9be/3tNcYl/X Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 18, 2004 at 02:56:32PM +0300, Ruslan Ermilov wrote: > Having a separate libtermcap library won't save anything with static > linkage as long as it's a subset of libncurses. Ideally, the binary > linked with the real termcap library which is a subset of the ncurses > library will even be of the same checksum. Of course, I mean crunched variant where whole library packed. > It's simple. There's no termcap library, whether you specify -lncurses > or -ltermcap doesn't matter, libraries and applications linked with > either of them all get libncurses.so as their runtime dependency: run > ldd(1) and get it. ;) It is termcap implementation details. The less anything (including=20 sources) knowns about it, the much better. > In other words: if you make a real libtermcap today (as a subset of > libncurses), you cannot expect old dynamically linked binaries to > magically start using it, because they have libncurses.so recorded > as their dependency. I talk not about binaries compatibility, but about mass Makefiles=20 reediting. > The difference between us is how we treat the libtermcap symlinks. > I treat them as compatibility stuff only for third-party applications > that are not part of the standard FreeBSD distribution, and you seem > to treat them as different API libraries. I also fail to get your Yes. > point about why linking with -lncurses as opposed to with -ltermcap > is unportable. Not every platform have ncurses. > I have a simple question for you: in your opinion, what's wrong with > replacing all these -l{curses,mytinfo,termcap,termlib,tinfo} with > one true -lncurses? I planned doing it one day, but you seem to be > against it, as follows from the above. I am against it for the reasons I already explain, it put our sources into= =20 unneded implementation details deeps. --=20 Andrey Chernov | http://ache.pp.ru/ --LZvS9be/3tNcYl/X Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iQCVAwUBQXOy6OJgpPLZnQjrAQH2XAQAlgRXkZNnJQmFMjofluFU8c0/s58zwOsC SeWLqHPyS0FPg6BFGqJ/skvv+4N2CEd2wyAZmKoDHsOw3h0u2p0gPcWQyTusQxNh 8qw3CgQ0idwi4WFPhqfCDh+A6IEB+w5ATvpPSlZVknLAEsH4h5sNZGfmM0IbqEfX q821xwnqmvg= =cItk -----END PGP SIGNATURE----- --LZvS9be/3tNcYl/X-- From owner-cvs-src@FreeBSD.ORG Mon Oct 18 14:13:21 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1717016A4CE; Mon, 18 Oct 2004 14:13:21 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 01A2243D45; Mon, 18 Oct 2004 14:13:19 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i9IEDI5p086142; Mon, 18 Oct 2004 17:13:18 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 09158-10; Mon, 18 Oct 2004 17:13:17 +0300 (EEST) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i9IEDAnE086133; Mon, 18 Oct 2004 17:13:13 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.1/8.13.1) id i9IED2Ek088483; Mon, 18 Oct 2004 17:13:02 +0300 (EEST) (envelope-from ru) Date: Mon, 18 Oct 2004 17:13:02 +0300 From: Ruslan Ermilov To: Andrey Chernov Message-ID: <20041018141302.GA88398@ip.net.ua> References: <200410180836.i9I8afRS060144@repoman.freebsd.org> <20041018090314.GA86525@ip.net.ua> <20041018090550.GA59302@nagual.pp.ru> <20041018091004.GC86525@ip.net.ua> <20041018091303.GC59302@nagual.pp.ru> <20041018091903.GD86525@ip.net.ua> <20041018092347.GA59835@nagual.pp.ru> <20041018092747.GB59835@nagual.pp.ru> <20041018115632.GA87870@ip.net.ua> <20041018121120.GA67831@nagual.pp.ru> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="sdtB3X0nJg68CQEu" Content-Disposition: inline In-Reply-To: <20041018121120.GA67831@nagual.pp.ru> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new at ip.net.ua cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/gnu/lib/libreadline/readline Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 14:13:21 -0000 --sdtB3X0nJg68CQEu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Andrey, On Mon, Oct 18, 2004 at 04:11:20PM +0400, Andrey Chernov wrote: > On Mon, Oct 18, 2004 at 02:56:32PM +0300, Ruslan Ermilov wrote: > > Having a separate libtermcap library won't save anything with static > > linkage as long as it's a subset of libncurses. Ideally, the binary > > linked with the real termcap library which is a subset of the ncurses > > library will even be of the same checksum. >=20 > Of course, I mean crunched variant where whole library packed. >=20 Crunched binaries don't use whole libraries either. The many .o files just get linked with libraries the usual way. (Unrelated, but I thought I'd mention this anyway...) > > I have a simple question for you: in your opinion, what's wrong with > > replacing all these -l{curses,mytinfo,termcap,termlib,tinfo} with > > one true -lncurses? I planned doing it one day, but you seem to be > > against it, as follows from the above. >=20 > I am against it for the reasons I already explain, it put our sources int= o=20 > unneded implementation details deeps. >=20 OK, you made a decision. :-) But then perhaps you can tell me where the APIs for libcurses, libmytinfo, libtermcap, libtermlib, and libtinfo are documented, so one can decide which pseudo-library to link against in our case of libncurses? If you happen to know... Because I read README and it says it implements the System V curses API with some extensions, and it doesn't mention any of the above libs. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --sdtB3X0nJg68CQEu Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBc89uqRfpzJluFF4RAiGBAJ0fU7BBCzi4I3iRcQq/R9WHZZ+HhwCfQOu0 WZ2SXNxWyMEGuRRx+QrOAOw= =f5pH -----END PGP SIGNATURE----- --sdtB3X0nJg68CQEu-- From owner-cvs-src@FreeBSD.ORG Mon Oct 18 14:53:44 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 836A416A4CE; Mon, 18 Oct 2004 14:53:44 +0000 (GMT) Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id C372F43D31; Mon, 18 Oct 2004 14:53:43 +0000 (GMT) (envelope-from ache@pobrecita.freebsd.ru) Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.13.1/8.13.1) with ESMTP id i9IEreAX070374; Mon, 18 Oct 2004 18:53:40 +0400 (MSD) (envelope-from ache@pobrecita.freebsd.ru) Received: (from ache@localhost) by pobrecita.freebsd.ru (8.13.1/8.13.1/Submit) id i9IEre9G070373; Mon, 18 Oct 2004 18:53:40 +0400 (MSD) (envelope-from ache) Date: Mon, 18 Oct 2004 18:53:39 +0400 From: Andrey Chernov To: Ruslan Ermilov Message-ID: <20041018145339.GA70099@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Ruslan Ermilov , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <20041018090314.GA86525@ip.net.ua> <20041018090550.GA59302@nagual.pp.ru> <20041018091004.GC86525@ip.net.ua> <20041018091303.GC59302@nagual.pp.ru> <20041018091903.GD86525@ip.net.ua> <20041018092347.GA59835@nagual.pp.ru> <20041018092747.GB59835@nagual.pp.ru> <20041018115632.GA87870@ip.net.ua> <20041018121120.GA67831@nagual.pp.ru> <20041018141302.GA88398@ip.net.ua> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="tThc/1wpZn/ma/RB" Content-Disposition: inline In-Reply-To: <20041018141302.GA88398@ip.net.ua> User-Agent: Mutt/1.5.6i X-AntiVirus: checked by AntiVir Milter 1.1-beta; AVE 6.28.0.7; VDF 6.28.0.20 (host: pobrecita.freebsd.ru) cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/gnu/lib/libreadline/readline Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 14:53:45 -0000 --tThc/1wpZn/ma/RB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 18, 2004 at 05:13:02PM +0300, Ruslan Ermilov wrote: > Crunched binaries don't use whole libraries either. The many .o > files just get linked with libraries the usual way. (Unrelated, > but I thought I'd mention this anyway...) The many files may just needs -ltermcap. > But then perhaps you can tell me where the APIs for libcurses, > libmytinfo, libtermcap, libtermlib, and libtinfo are documented, > so one can decide which pseudo-library to link against in our > case of libncurses? If you happen to know... Because I read > README and it says it implements the System V curses API with > some extensions, and it doesn't mention any of the above libs. Usually it is documented in the manpages and in other formats, like=20 nroff-based, depending on system. Before ncurses we and all BSDs have=20 standard manpages describing termcap functions family and file format for years. Do you keep some CDs with old BSDs, by chance? libtermcap =3D libtermlib, historycally libmytinfo is for some non-standard stuff, maybe terminfo emulation based= =20 on termcap, I don't remember exactly now. Curses implementation can be layer on termcap or on terminfo (or even=20 on something else). In later cases it may not provide termcap=20 compatibility or do it poorly. SysV curses API standartization effors=20 shows up relatively recent, many Unix-likes and others (DOS f.e.) have=20 their own not fully SysV API compatible curses-es. --=20 Andrey Chernov | http://ache.pp.ru/ --tThc/1wpZn/ma/RB Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iQCVAwUBQXPY8+JgpPLZnQjrAQEMFAQA3AeVEVmekPCbqEEGflDCNP2q64Auz7Og 53tATJfatLY5pJtS1RG2bQr3Au2DkdfPgljBomcYctL2oYSWouCHkeQ+CLanLIaa RcJEXVnbioFDA5rYXRGA8XRsrcWVk6NGTydZqhxyVyb2ihJvYnA0hqt3mhEjq8KA 61FEwcRJIqY= =feVA -----END PGP SIGNATURE----- --tThc/1wpZn/ma/RB-- From owner-cvs-src@FreeBSD.ORG Mon Oct 18 14:59:54 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 42D7516A4CE; Mon, 18 Oct 2004 14:59:54 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2416A43D41; Mon, 18 Oct 2004 14:59:54 +0000 (GMT) (envelope-from thomas@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9IExskF086315; Mon, 18 Oct 2004 14:59:54 GMT (envelope-from thomas@repoman.freebsd.org) Received: (from thomas@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9IExrvS086314; Mon, 18 Oct 2004 14:59:53 GMT (envelope-from thomas) Message-Id: <200410181459.i9IExrvS086314@repoman.freebsd.org> From: Thomas Quinot Date: Mon, 18 Oct 2004 14:59:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/etc/rc.d dumpon X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 14:59:54 -0000 thomas 2004-10-18 14:59:53 UTC FreeBSD src repository Modified files: etc/rc.d dumpon Log: Remove unused computation of memory size. Reviewed by: des Revision Changes Path 1.6 +0 -1 src/etc/rc.d/dumpon From owner-cvs-src@FreeBSD.ORG Mon Oct 18 15:40:48 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F04E616A4CE; Mon, 18 Oct 2004 15:40:47 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E078543D39; Mon, 18 Oct 2004 15:40:47 +0000 (GMT) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9IFel7j088002; Mon, 18 Oct 2004 15:40:47 GMT (envelope-from cperciva@repoman.freebsd.org) Received: (from cperciva@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9IFelfE088001; Mon, 18 Oct 2004 15:40:47 GMT (envelope-from cperciva) Message-Id: <200410181540.i9IFelfE088001@repoman.freebsd.org> From: Colin Percival Date: Mon, 18 Oct 2004 15:40:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.bin/xargs strnsubst.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 15:40:48 -0000 cperciva 2004-10-18 15:40:47 UTC FreeBSD src repository Modified files: usr.bin/xargs strnsubst.c Log: Modify behaviour of `xargs -I` in order to: 1. Conform to IEEE Std 1003.1-2004, which state that "Constructed arguments cannot grow larger than 255 bytes", and 2. Avoid a buffer overflow. Unfortunately the standard doesn't indicate how xargs is supposed to handle arguments which (with the appropriate substitutions) would grow larger than 255 bytes; this solution handles those by making as many substitutions as possible without overflowing the buffer. OpenBSD's xargs resolves this in a different direction, by making all the substitutions and then silently truncating the resulting string. Since this change may break existing scripts which rely upon the buffer overflow (255 bytes isn't really all that long...) it will not be MFCed. Revision Changes Path 1.7 +2 -2 src/usr.bin/xargs/strnsubst.c From owner-cvs-src@FreeBSD.ORG Mon Oct 18 16:26:26 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6EA8D16A4CE; Mon, 18 Oct 2004 16:26:26 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 50BE243D41; Mon, 18 Oct 2004 16:26:26 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9IGQQZw089322; Mon, 18 Oct 2004 16:26:26 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9IGQQ7L089321; Mon, 18 Oct 2004 16:26:26 GMT (envelope-from ru) Message-Id: <200410181626.i9IGQQ7L089321@repoman.freebsd.org> From: Ruslan Ermilov Date: Mon, 18 Oct 2004 16:26:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libncurses Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 16:26:26 -0000 ru 2004-10-18 16:26:26 UTC FreeBSD src repository Modified files: lib/libncurses Makefile Log: Replaced afterinstall: with FILES. Revision Changes Path 1.74 +2 -6 src/lib/libncurses/Makefile From owner-cvs-src@FreeBSD.ORG Mon Oct 18 16:39:54 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 09CA316A4CE; Mon, 18 Oct 2004 16:39:54 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DE14943D6A; Mon, 18 Oct 2004 16:39:53 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9IGdrwE089746; Mon, 18 Oct 2004 16:39:53 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9IGdr5C089745; Mon, 18 Oct 2004 16:39:53 GMT (envelope-from ru) Message-Id: <200410181639.i9IGdr5C089745@repoman.freebsd.org> From: Ruslan Ermilov Date: Mon, 18 Oct 2004 16:39:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/gnu/lib/libdialog Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 16:39:54 -0000 ru 2004-10-18 16:39:53 UTC FreeBSD src repository Modified files: gnu/lib/libdialog Makefile Log: Replaced afterinstall: with FILES. Revision Changes Path 1.40 +2 -5 src/gnu/lib/libdialog/Makefile From owner-cvs-src@FreeBSD.ORG Mon Oct 18 17:03:54 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 248EE16A4CE; Mon, 18 Oct 2004 17:03:54 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 03F9F43D5A; Mon, 18 Oct 2004 17:03:54 +0000 (GMT) (envelope-from wollman@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9IH3rYN096909; Mon, 18 Oct 2004 17:03:53 GMT (envelope-from wollman@repoman.freebsd.org) Received: (from wollman@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9IH3rvn096908; Mon, 18 Oct 2004 17:03:53 GMT (envelope-from wollman) Message-Id: <200410181703.i9IH3rvn096908@repoman.freebsd.org> From: Garrett Wollman Date: Mon, 18 Oct 2004 17:03:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/etc/mtree BSD.usr.dist X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 17:03:54 -0000 wollman 2004-10-18 17:03:53 UTC FreeBSD src repository Modified files: etc/mtree BSD.usr.dist Log: New directory added for Argentinian timezones. Submitted by: ache Revision Changes Path 1.309 +2 -0 src/etc/mtree/BSD.usr.dist From owner-cvs-src@FreeBSD.ORG Mon Oct 18 17:05:00 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DACF516A4CF; Mon, 18 Oct 2004 17:05:00 +0000 (GMT) Received: from kane.otenet.gr (kane.otenet.gr [195.170.0.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id 16A7A43D2D; Mon, 18 Oct 2004 17:05:00 +0000 (GMT) (envelope-from keramida@freebsd.org) Received: from orion.daedalusnetworks.priv (host5.bedc.ondsl.gr [62.103.39.229])i9IH4i2W005232; Mon, 18 Oct 2004 20:04:49 +0300 Received: from orion.daedalusnetworks.priv (orion [127.0.0.1]) i9IH4gLQ000681; Mon, 18 Oct 2004 20:04:42 +0300 (EEST) (envelope-from keramida@freebsd.org) Received: (from keramida@localhost)i9IH4gbs000680; Mon, 18 Oct 2004 20:04:42 +0300 (EEST) (envelope-from keramida@freebsd.org) Date: Mon, 18 Oct 2004 20:04:42 +0300 From: Giorgos Keramidas To: Andrey Chernov Message-ID: <20041018170442.GA600@orion.daedalusnetworks.priv> References: <200410172355.i9HNt8vv030342@repoman.freebsd.org> <20041018014430.GA35524@nagual.pp.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041018014430.GA35524@nagual.pp.ru> cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: Garrett Wollman cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/share/zoneinfo - Imported sources X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 17:05:01 -0000 On 2004-10-18 05:44, Andrey Chernov wrote: > On Sun, Oct 17, 2004 at 11:55:08PM +0000, Garrett Wollman wrote: > > wollman 2004-10-17 23:55:08 UTC > > > > FreeBSD src repository > > > > src/share/zoneinfo - Imported sources > > Update of /home/ncvs/src/share/zoneinfo > > In directory repoman.freebsd.org:/tmp/cvs-serv30242 > > > > Log Message: > > Latest timezone database from Arthur Olson. Updates in this round: > > Some new dirs are missing from BSD.usr.dist: > > zic: can't create /usr/share/zoneinfo/America/Argentina/Buenos_Aires: No > such file or directory > *** Error code 1 Try applying locally this patch to `BSD.usr.dist'. Since you're an src committer, if this fixes things for you (as it did for me), feel free to commit it any time :-) %%% Index: BSD.usr.dist =================================================================== RCS file: /home/ncvs/src/etc/mtree/BSD.usr.dist,v retrieving revision 1.308 diff -u -u -r1.308 BSD.usr.dist --- BSD.usr.dist 25 Sep 2004 00:42:37 -0000 1.308 +++ BSD.usr.dist 18 Oct 2004 16:57:59 -0000 @@ -1166,6 +1166,8 @@ Africa .. America + Argentina + .. Indiana .. Kentucky %%% From owner-cvs-src@FreeBSD.ORG Mon Oct 18 17:16:01 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CC49C16A4CE; Mon, 18 Oct 2004 17:16:01 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id AD92743D46; Mon, 18 Oct 2004 17:16:01 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9IHG1gU097362; Mon, 18 Oct 2004 17:16:01 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9IHG1BF097361; Mon, 18 Oct 2004 17:16:01 GMT (envelope-from ru) Message-Id: <200410181716.i9IHG1BF097361@repoman.freebsd.org> From: Ruslan Ermilov Date: Mon, 18 Oct 2004 17:16:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.bin/vi Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 17:16:02 -0000 ru 2004-10-18 17:16:01 UTC FreeBSD src repository Modified files: usr.bin/vi Makefile Log: Replaced afterinstall: with equivalent FILES and SYMLINKS. Revision Changes Path 1.43 +33 -34 src/usr.bin/vi/Makefile From owner-cvs-src@FreeBSD.ORG Mon Oct 18 17:19:36 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C990016A4CE; Mon, 18 Oct 2004 17:19:36 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A9E1D43D3F; Mon, 18 Oct 2004 17:19:36 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9IHJa7I097437; Mon, 18 Oct 2004 17:19:36 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9IHJa9l097436; Mon, 18 Oct 2004 17:19:36 GMT (envelope-from obrien) Message-Id: <200410181719.i9IHJa9l097436@repoman.freebsd.org> From: "David E. O'Brien" Date: Mon, 18 Oct 2004 17:19:36 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 17:19:36 -0000 obrien 2004-10-18 17:19:36 UTC FreeBSD src repository Modified files: lib/libc/i386/net htonl.S ntohl.S Log: Sync with sys/i386/include/endian.h: use the single instruction 'bswap'. Revision Changes Path 1.10 +4 -0 src/lib/libc/i386/net/htonl.S 1.10 +4 -0 src/lib/libc/i386/net/ntohl.S From owner-cvs-src@FreeBSD.ORG Mon Oct 18 17:20:30 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2BA1016A4CE; Mon, 18 Oct 2004 17:20:30 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0D92A43D1D; Mon, 18 Oct 2004 17:20:30 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9IHKTYg097538; Mon, 18 Oct 2004 17:20:29 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9IHKTKX097537; Mon, 18 Oct 2004 17:20:29 GMT (envelope-from ru) Message-Id: <200410181720.i9IHKTKX097537@repoman.freebsd.org> From: Ruslan Ermilov Date: Mon, 18 Oct 2004 17:20:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin/mailwrapper Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 17:20:30 -0000 ru 2004-10-18 17:20:29 UTC FreeBSD src repository Modified files: usr.sbin/mailwrapper Makefile Log: Replaced afterinstall: with FILES. Revision Changes Path 1.13 +3 -3 src/usr.sbin/mailwrapper/Makefile From owner-cvs-src@FreeBSD.ORG Mon Oct 18 17:35:33 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1756716A4CE; Mon, 18 Oct 2004 17:35:33 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 611E643D31; Mon, 18 Oct 2004 17:35:32 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i9IHZV0C096982; Mon, 18 Oct 2004 20:35:31 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 32335-14; Mon, 18 Oct 2004 20:35:30 +0300 (EEST) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i9IHZNM3096978; Mon, 18 Oct 2004 20:35:26 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.1/8.13.1) id i9IHZGs8089792; Mon, 18 Oct 2004 20:35:16 +0300 (EEST) (envelope-from ru) Date: Mon, 18 Oct 2004 20:35:16 +0300 From: Ruslan Ermilov To: "David E. O'Brien" Message-ID: <20041018173516.GB89681@ip.net.ua> References: <200410181719.i9IHJa9l097436@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="6sX45UoQRIJXqkqR" Content-Disposition: inline In-Reply-To: <200410181719.i9IHJa9l097436@repoman.freebsd.org> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new at ip.net.ua cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 17:35:33 -0000 --6sX45UoQRIJXqkqR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 18, 2004 at 05:19:36PM +0000, David E. O'Brien wrote: > obrien 2004-10-18 17:19:36 UTC >=20 > FreeBSD src repository >=20 > Modified files: > lib/libc/i386/net htonl.S ntohl.S=20 > Log: > Sync with sys/i386/include/endian.h: use the single instruction 'bswap'. > =20 > Revision Changes Path > 1.10 +4 -0 src/lib/libc/i386/net/htonl.S > 1.10 +4 -0 src/lib/libc/i386/net/ntohl.S =20 : ENTRY(__htonl) : movl 4(%esp),%eax : +#ifdef I386_CPU : xchgb %al,%ah : roll $16,%eax : xchgb %al,%ah : +#else : + bswap %eax : +#endif : ret Ahem, but this makes this code unsuitable for i386. I386_CPU is only defined if kernel config file has "cpu I386_CPU", and this has little relation to libc if at all. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --6sX45UoQRIJXqkqR Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBc/7UqRfpzJluFF4RAlb0AKCKBkmPwZ4YfmT8DjXGnPqFBghLJACeO+Q1 kf9ogMEfcUZVtZIln0505rw= =KpE8 -----END PGP SIGNATURE----- --6sX45UoQRIJXqkqR-- From owner-cvs-src@FreeBSD.ORG Mon Oct 18 17:36:34 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A672316A4CE; Mon, 18 Oct 2004 17:36:34 +0000 (GMT) Received: from zaphod.nitro.dk (port324.ds1-khk.adsl.cybercity.dk [212.242.113.79]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1C30643D5E; Mon, 18 Oct 2004 17:36:34 +0000 (GMT) (envelope-from simon@zaphod.nitro.dk) Received: by zaphod.nitro.dk (Postfix, from userid 3000) id 36708119C7; Mon, 18 Oct 2004 19:36:32 +0200 (CEST) Date: Mon, 18 Oct 2004 19:36:31 +0200 From: "Simon L. Nielsen" To: Garrett Wollman Message-ID: <20041018173631.GA1149@zaphod.nitro.dk> References: <200410181703.i9IH3rvn096908@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="HcAYCG3uE/tztfnV" Content-Disposition: inline In-Reply-To: <200410181703.i9IH3rvn096908@repoman.freebsd.org> User-Agent: Mutt/1.5.6i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc/mtree BSD.usr.dist X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 17:36:34 -0000 --HcAYCG3uE/tztfnV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2004.10.18 17:03:53 +0000, Garrett Wollman wrote: > wollman 2004-10-18 17:03:53 UTC >=20 > FreeBSD src repository >=20 > Modified files: > etc/mtree BSD.usr.dist=20 > Log: > New directory added for Argentinian timezones. [...] > | @@ -1166,6 +1166,8 @@ > | Africa > | .. > | America > | + Argentina > | + .. > | Indiana > | .. > | Kentucky Looks like there is some kind of space vs. tabs issue here. --=20 Simon L. Nielsen FreeBSD Documentation Team --HcAYCG3uE/tztfnV Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBc/8fh9pcDSc1mlERAqauAJ9QuON9jWF5QbWEWS86erVp4wwgzgCeNEfX fiTsmoLONMTyoKIavp6k6sM= =szR0 -----END PGP SIGNATURE----- --HcAYCG3uE/tztfnV-- From owner-cvs-src@FreeBSD.ORG Mon Oct 18 17:39:58 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 19E2316A4CE; Mon, 18 Oct 2004 17:39:58 +0000 (GMT) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id EBAC543D5E; Mon, 18 Oct 2004 17:39:57 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.13.1/8.13.1) with ESMTP id i9IHdvsB006018; Mon, 18 Oct 2004 10:39:57 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.13.1/8.13.1/Submit) id i9IHduW5006017; Mon, 18 Oct 2004 10:39:56 -0700 (PDT) (envelope-from obrien) Date: Mon, 18 Oct 2004 10:39:55 -0700 From: "David O'Brien" To: Alexander@Leidinger.net Message-ID: <20041018173955.GB5737@dragon.nuxi.com> References: <200410180534.i9I5YsGn053852@repoman.freebsd.org> <1098101272.4173b21825a40@netchild.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1098101272.4173b21825a40@netchild.homeip.net> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 6.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.sbin/pkg_install/info info.h main.c src/usr.sbin/pkg_install/lib global.c lib.h src/usr.sbin/pkg_install/version main.c perform.c pkg_version.1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 17:39:58 -0000 On Mon, Oct 18, 2004 at 02:07:52PM +0200, Alexander@Leidinger.net wrote: > Zitat von "David E. O'Brien" : > > > Add a -q flag to pkg_version. It suppresses the output of <,=,>. > > This makes it possible to "portupgrade `pkg_version -q -l '<'`". > > What's the difference between this and "portupgrade -a"? Even when you intent > to filter the output of pkg_version first I don't see the need for it, > portupgrade has an exclude feature. I also sometimes add a "| grep -v firefox" to the command line. One might also want to use the output of pkg_version for other things where the <,=,> gets in the way. -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Mon Oct 18 17:45:13 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3969516A4CE; Mon, 18 Oct 2004 17:45:13 +0000 (GMT) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 12A7443D2F; Mon, 18 Oct 2004 17:45:13 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.13.1/8.13.1) with ESMTP id i9IHjCD4006293; Mon, 18 Oct 2004 10:45:12 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.13.1/8.13.1/Submit) id i9IHjB5w006292; Mon, 18 Oct 2004 10:45:11 -0700 (PDT) (envelope-from obrien) Date: Mon, 18 Oct 2004 10:45:11 -0700 From: "David O'Brien" To: Ruslan Ermilov Message-ID: <20041018174511.GA6079@dragon.nuxi.com> References: <200410181719.i9IHJa9l097436@repoman.freebsd.org> <20041018173516.GB89681@ip.net.ua> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041018173516.GB89681@ip.net.ua> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 6.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 17:45:13 -0000 On Mon, Oct 18, 2004 at 08:35:16PM +0300, Ruslan Ermilov wrote: > On Mon, Oct 18, 2004 at 05:19:36PM +0000, David E. O'Brien wrote: > > obrien 2004-10-18 17:19:36 UTC > > FreeBSD src repository > > Modified files: > > lib/libc/i386/net htonl.S ntohl.S > > Log: > > Sync with sys/i386/include/endian.h: use the single instruction 'bswap'. > > Revision Changes Path > > 1.10 +4 -0 src/lib/libc/i386/net/htonl.S > > 1.10 +4 -0 src/lib/libc/i386/net/ntohl.S > : ENTRY(__htonl) > : movl 4(%esp),%eax > : +#ifdef I386_CPU > : xchgb %al,%ah > : roll $16,%eax > : xchgb %al,%ah > : +#else > : + bswap %eax > : +#endif > : ret > > Ahem, but this makes this code unsuitable for i386. Yes. You missed the discussion in freebsd-current on this? For 6-CURRENT and RELENG_5 running on a real I386 is not supported. > I386_CPU > is only defined if kernel config file has "cpu I386_CPU", and > this has little relation to libc if at all. I know. Give me some other symbol then we can publish that one should add to /etc/make.conf CFLAGS to try to build a userland for an I386. "I386_CPU" looks as good a spelling as any and I didn't see any need to spell it differently than in the kernel. -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Mon Oct 18 17:47:31 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C56C816A4CE; Mon, 18 Oct 2004 17:47:31 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A6A9643D49; Mon, 18 Oct 2004 17:47:31 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9IHlVJm098347; Mon, 18 Oct 2004 17:47:31 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9IHlVop098346; Mon, 18 Oct 2004 17:47:31 GMT (envelope-from ru) Message-Id: <200410181747.i9IHlVop098346@repoman.freebsd.org> From: Ruslan Ermilov Date: Mon, 18 Oct 2004 17:47:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 17:47:31 -0000 ru 2004-10-18 17:47:31 UTC FreeBSD src repository Modified files: . Makefile Log: Fixed MAKEOBJDIRPREFIX variable type check in case the env(1) binary is not in PATH, as is the case with installworld, etc. Revision Changes Path 1.309 +2 -1 src/Makefile From owner-cvs-src@FreeBSD.ORG Mon Oct 18 18:03:37 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 513E816A4CE; Mon, 18 Oct 2004 18:03:37 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8813243D39; Mon, 18 Oct 2004 18:03:36 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i9II3ZJG098360; Mon, 18 Oct 2004 21:03:35 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 34755-19; Mon, 18 Oct 2004 21:03:34 +0300 (EEST) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i9II3RGj098356; Mon, 18 Oct 2004 21:03:30 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.1/8.13.1) id i9II3KOX090004; Mon, 18 Oct 2004 21:03:20 +0300 (EEST) (envelope-from ru) Date: Mon, 18 Oct 2004 21:03:20 +0300 From: Ruslan Ermilov To: "David O'Brien" Message-ID: <20041018180319.GD89681@ip.net.ua> References: <200410181719.i9IHJa9l097436@repoman.freebsd.org> <20041018173516.GB89681@ip.net.ua> <20041018174511.GA6079@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="SO98HVl1bnMOfKZd" Content-Disposition: inline In-Reply-To: <20041018174511.GA6079@dragon.nuxi.com> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new at ip.net.ua cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 18:03:37 -0000 --SO98HVl1bnMOfKZd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 18, 2004 at 10:45:11AM -0700, David O'Brien wrote: > On Mon, Oct 18, 2004 at 08:35:16PM +0300, Ruslan Ermilov wrote: > > On Mon, Oct 18, 2004 at 05:19:36PM +0000, David E. O'Brien wrote: > > > obrien 2004-10-18 17:19:36 UTC > > > FreeBSD src repository > > > Modified files: > > > lib/libc/i386/net htonl.S ntohl.S=20 > > > Log: > > > Sync with sys/i386/include/endian.h: use the single instruction 'bs= wap'. > > > Revision Changes Path > > > 1.10 +4 -0 src/lib/libc/i386/net/htonl.S > > > 1.10 +4 -0 src/lib/libc/i386/net/ntohl.S > > : ENTRY(__htonl) > > : movl 4(%esp),%eax > > : +#ifdef I386_CPU > > : xchgb %al,%ah > > : roll $16,%eax > > : xchgb %al,%ah > > : +#else > > : + bswap %eax > > : +#endif > > : ret > >=20 > > Ahem, but this makes this code unsuitable for i386. >=20 > Yes. You missed the discussion in freebsd-current on this? For > 6-CURRENT and RELENG_5 running on a real I386 is not supported. >=20 Hmm. I remember the plan was to decomission the i386 support only in 6.0-CURRENT, as per sys/i386/conf/NOTES: # Be sure to disable 'cpu I386_CPU' for SMP kernels. # I386_CPU is mutually exclusive with the other CPU types. # I386_CPU is deprecated and will be removed in 6.0-RELEASE. And http://www.freebsd.org/releases/5.2.1R/hardware-i386.html#PROC says i386 (except 386SX) is still supported. I recall phk@ looking for the 386DX testers, but I don't remember what was the result. If you are burning 6.0-CURRENT bridges already, and this change is the step in the I386_CPU deprecation direction, why not just unifdef(1) this libc code, so that the "xchg" is always used? > > I386_CPU > > is only defined if kernel config file has "cpu I386_CPU", and > > this has little relation to libc if at all. >=20 > I know. Give me some other symbol then we can publish that one should > add to /etc/make.conf CFLAGS to try to build a userland for an I386. > "I386_CPU" looks as good a spelling as any and I didn't see any need to > spell it differently than in the kernel. >=20 You can check for the CPUTYPE=3D"i386" for ${MACHINE_ARCH} =3D=3D "i386" in libc/Makefile, and set I386_CPU in CFLAGS in this case. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --SO98HVl1bnMOfKZd Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBdAVnqRfpzJluFF4RArQ8AJwKAdH082TeByAbFDX3edmlTP7QrQCfWmoP 5VJb8+RzBFXbTPdToqTLsyI= =UcvN -----END PGP SIGNATURE----- --SO98HVl1bnMOfKZd-- From owner-cvs-src@FreeBSD.ORG Mon Oct 18 18:14:38 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D9A9716A4CE; Mon, 18 Oct 2004 18:14:38 +0000 (GMT) Received: from smtp.des.no (flood.des.no [217.116.83.31]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2AC1F43D3F; Mon, 18 Oct 2004 18:14:38 +0000 (GMT) (envelope-from des@des.no) Received: by smtp.des.no (Pony Express, from userid 666) id A1B855312; Mon, 18 Oct 2004 20:14:36 +0200 (CEST) Received: from dwp.des.no (des.no [80.203.228.37]) by smtp.des.no (Pony Express) with ESMTP id A7A17530A; Mon, 18 Oct 2004 20:14:29 +0200 (CEST) Received: by dwp.des.no (Postfix, from userid 2602) id 82CE4B861; Mon, 18 Oct 2004 20:14:29 +0200 (CEST) To: obrien@freebsd.org References: <200410180534.i9I5YsGn053852@repoman.freebsd.org> <1098101272.4173b21825a40@netchild.homeip.net> <20041018173955.GB5737@dragon.nuxi.com> From: des@des.no (=?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?=) Date: Mon, 18 Oct 2004 20:14:29 +0200 In-Reply-To: <20041018173955.GB5737@dragon.nuxi.com> (David O'Brien's message of "Mon, 18 Oct 2004 10:39:55 -0700") Message-ID: User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Checker-Version: SpamAssassin 2.64 (2004-01-11) on flood.des.no X-Spam-Level: X-Spam-Status: No, hits=0.0 required=5.0 tests=AWL autolearn=no version=2.64 cc: Alexander@Leidinger.net cc: src-committers@freebsd.org cc: cvs-all@freebsd.org cc: cvs-src@freebsd.org Subject: Re: cvs commit: src/usr.sbin/pkg_install/info info.h main.c src/usr.sbin/pkg_install/lib global.c lib.h src/usr.sbin/pkg_install/version main.c perform.c pkg_version.1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 18:14:39 -0000 "David O'Brien" writes: > On Mon, Oct 18, 2004 at 02:07:52PM +0200, Alexander@Leidinger.net wrote: > > Zitat von "David E. O'Brien" : > > > This makes it possible to "portupgrade `pkg_version -q -l '<'`". > > What's the difference between this and "portupgrade -a"? > I also sometimes add a "| grep -v firefox" to the command line. portupgrade -a -x firefox DES --=20 Dag-Erling Sm=F8rgrav - des@des.no From owner-cvs-src@FreeBSD.ORG Mon Oct 18 18:25:29 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BDED616A4CE; Mon, 18 Oct 2004 18:25:29 +0000 (GMT) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8C98343D55; Mon, 18 Oct 2004 18:25:29 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.13.1/8.13.1) with ESMTP id i9IIPOAo011063; Mon, 18 Oct 2004 11:25:24 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.13.1/8.13.1/Submit) id i9IIPNvk011062; Mon, 18 Oct 2004 11:25:23 -0700 (PDT) (envelope-from obrien) Date: Mon, 18 Oct 2004 11:25:23 -0700 From: "David O'Brien" To: Dag-Erling Sm?rgrav Message-ID: <20041018182522.GA10529@dragon.nuxi.com> References: <200410180534.i9I5YsGn053852@repoman.freebsd.org> <1098101272.4173b21825a40@netchild.homeip.net> <20041018173955.GB5737@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 6.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: Alexander@Leidinger.net cc: src-committers@freebsd.org cc: cvs-all@freebsd.org cc: cvs-src@freebsd.org Subject: Re: cvs commit: src/usr.sbin/pkg_install/info info.h main.c src/usr.sbin/pkg_install/lib global.c lib.h src/usr.sbin/pkg_install/version main.c perform.c pkg_version.1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 18:25:29 -0000 On Mon, Oct 18, 2004 at 08:14:29PM +0200, Dag-Erling Sm?rgrav wrote: > "David O'Brien" writes: > > On Mon, Oct 18, 2004 at 02:07:52PM +0200, Alexander@Leidinger.net wrote: > > > Zitat von "David E. O'Brien" : > > > > This makes it possible to "portupgrade `pkg_version -q -l '<'`". > > > What's the difference between this and "portupgrade -a"? > > I also sometimes add a "| grep -v firefox" to the command line. > > portupgrade -a -x firefox One might want a list of packages for other things. I can't believe a simple -q[uiet] switch is being bike shed. No, wait, this is FreeBSD I *can* believe it. -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Mon Oct 18 18:30:12 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9249916A4CE; Mon, 18 Oct 2004 18:30:12 +0000 (GMT) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4299143D1F; Mon, 18 Oct 2004 18:30:12 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.13.1/8.13.1) with ESMTP id i9IIUBjD011192; Mon, 18 Oct 2004 11:30:11 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.13.1/8.13.1/Submit) id i9IIUB4I011191; Mon, 18 Oct 2004 11:30:11 -0700 (PDT) (envelope-from obrien) Date: Mon, 18 Oct 2004 11:30:11 -0700 From: "David O'Brien" To: Ruslan Ermilov Message-ID: <20041018183011.GB10529@dragon.nuxi.com> References: <200410181719.i9IHJa9l097436@repoman.freebsd.org> <20041018173516.GB89681@ip.net.ua> <20041018174511.GA6079@dragon.nuxi.com> <20041018180319.GD89681@ip.net.ua> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041018180319.GD89681@ip.net.ua> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 6.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 18:30:12 -0000 On Mon, Oct 18, 2004 at 09:03:20PM +0300, Ruslan Ermilov wrote: > On Mon, Oct 18, 2004 at 10:45:11AM -0700, David O'Brien wrote: > > On Mon, Oct 18, 2004 at 08:35:16PM +0300, Ruslan Ermilov wrote: > > > On Mon, Oct 18, 2004 at 05:19:36PM +0000, David E. O'Brien wrote: > > > > obrien 2004-10-18 17:19:36 UTC > > > > FreeBSD src repository > > > > Modified files: > > > > lib/libc/i386/net htonl.S ntohl.S > > > > Log: > > > > Sync with sys/i386/include/endian.h: use the single instruction 'bswap'. > > > > Revision Changes Path > > > > 1.10 +4 -0 src/lib/libc/i386/net/htonl.S > > > > 1.10 +4 -0 src/lib/libc/i386/net/ntohl.S > > > : ENTRY(__htonl) > > > : movl 4(%esp),%eax > > > : +#ifdef I386_CPU > > > : xchgb %al,%ah > > > : roll $16,%eax > > > : xchgb %al,%ah > > > : +#else > > > : + bswap %eax > > > : +#endif > > > : ret > > > > > > Ahem, but this makes this code unsuitable for i386. > > > > Yes. You missed the discussion in freebsd-current on this? For > > 6-CURRENT and RELENG_5 running on a real I386 is not supported. > > Hmm. I remember the plan was to decomission the i386 support > only in 6.0-CURRENT, as per sys/i386/conf/NOTES: ... > If you are burning 6.0-CURRENT bridges already, and this change > is the step in the I386_CPU deprecation direction, why not just > unifdef(1) this libc code, so that the "xchg" is always used? I'm not decommisioning it -- I left a code path in there for someone who cares about running on real I386 CPU's. I also plan on MFC'ing this to RELENG_5 once the branch opens up. Please go read the freebsd-current thread. As noted there we haven't built a 5-CURRENT I386 runable kernel since 2001. Do you really think things haven't attrophied such that one must do some work to run on an I386 at this point? -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Mon Oct 18 18:31:22 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5190216A4D1 for ; Mon, 18 Oct 2004 18:31:22 +0000 (GMT) Received: from av13-1-sn4.m-sp.skanova.net (av13-1-sn4.m-sp.skanova.net [81.228.10.104]) by mx1.FreeBSD.org (Postfix) with ESMTP id B2C8E43D4C for ; Mon, 18 Oct 2004 18:31:20 +0000 (GMT) (envelope-from ertr1013@student.uu.se) Received: by av13-1-sn4.m-sp.skanova.net (Postfix, from userid 502) id BF8C637E44; Mon, 18 Oct 2004 20:31:19 +0200 (CEST) Received: from smtp4-2-sn4.m-sp.skanova.net (smtp4-2-sn4.m-sp.skanova.net [81.228.10.180]) by av13-1-sn4.m-sp.skanova.net (Postfix) with ESMTP id B03FC37E45 for ; Mon, 18 Oct 2004 20:31:19 +0200 (CEST) Received: from falcon.midgard.homeip.net (h201n1fls24o1048.bredband.comhem.se [212.181.162.201]) by smtp4-2-sn4.m-sp.skanova.net (Postfix) with SMTP id 3126A37E4B for ; Mon, 18 Oct 2004 20:31:19 +0200 (CEST) Received: (qmail 80730 invoked by uid 1001); 18 Oct 2004 18:31:18 -0000 Date: Mon, 18 Oct 2004 20:31:18 +0200 From: Erik Trulsson To: David O'Brien Message-ID: <20041018183118.GA80703@falcon.midgard.homeip.net> Mail-Followup-To: David O'Brien , Ruslan Ermilov , cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org References: <200410181719.i9IHJa9l097436@repoman.freebsd.org> <20041018173516.GB89681@ip.net.ua> <20041018174511.GA6079@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041018174511.GA6079@dragon.nuxi.com> User-Agent: Mutt/1.5.6i cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: Ruslan Ermilov cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 18:31:22 -0000 On Mon, Oct 18, 2004 at 10:45:11AM -0700, David O'Brien wrote: > On Mon, Oct 18, 2004 at 08:35:16PM +0300, Ruslan Ermilov wrote: > > On Mon, Oct 18, 2004 at 05:19:36PM +0000, David E. O'Brien wrote: > > > obrien 2004-10-18 17:19:36 UTC > > > FreeBSD src repository > > > Modified files: > > > lib/libc/i386/net htonl.S ntohl.S > > > Log: > > > Sync with sys/i386/include/endian.h: use the single instruction 'bswap'. > > > Revision Changes Path > > > 1.10 +4 -0 src/lib/libc/i386/net/htonl.S > > > 1.10 +4 -0 src/lib/libc/i386/net/ntohl.S > > : ENTRY(__htonl) > > : movl 4(%esp),%eax > > : +#ifdef I386_CPU > > : xchgb %al,%ah > > : roll $16,%eax > > : xchgb %al,%ah > > : +#else > > : + bswap %eax > > : +#endif > > : ret > > > > Ahem, but this makes this code unsuitable for i386. > > Yes. You missed the discussion in freebsd-current on this? For > 6-CURRENT and RELENG_5 running on a real I386 is not supported. I have certainly not seen any message stating that on -current. I know that the GENERIC kernel does not work on a i386, so that you need a custom-built kernel to install on a real i386. I also know that support for FPU-less systems has been dropped, which means that most 386-based systems (those without an '387) (as well as systems with a 486sx w/o a 487sx) will not run RELENG_5 or -CURRENT. Neither of these means that a real 80386+80387 is unsupported, just that you need to build a new kernel first. I think you people need to decide to either drop support for 80386 completely (in which case all the '#ifdef I386_CPU' and similar can go away) or decide to keep support for it, in which case most things should just work 'out of the box' on a 80386 (without recompilation needed more than absolutely necessary.) -- Erik Trulsson ertr1013@student.uu.se From owner-cvs-src@FreeBSD.ORG Mon Oct 18 18:34:52 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3349116A4D2 for ; Mon, 18 Oct 2004 18:34:52 +0000 (GMT) Received: from av13-1-sn4.m-sp.skanova.net (av13-1-sn4.m-sp.skanova.net [81.228.10.104]) by mx1.FreeBSD.org (Postfix) with ESMTP id DF68D43D49 for ; Mon, 18 Oct 2004 18:34:51 +0000 (GMT) (envelope-from ertr1013@student.uu.se) Received: by av13-1-sn4.m-sp.skanova.net (Postfix, from userid 502) id 4EBF737E48; Mon, 18 Oct 2004 20:34:51 +0200 (CEST) Received: from smtp4-2-sn4.m-sp.skanova.net (smtp4-2-sn4.m-sp.skanova.net [81.228.10.180]) by av13-1-sn4.m-sp.skanova.net (Postfix) with ESMTP id 4261537E44 for ; Mon, 18 Oct 2004 20:34:51 +0200 (CEST) Received: from falcon.midgard.homeip.net (h201n1fls24o1048.bredband.comhem.se [212.181.162.201]) by smtp4-2-sn4.m-sp.skanova.net (Postfix) with SMTP id A7B1A37E47 for ; Mon, 18 Oct 2004 20:34:50 +0200 (CEST) Received: (qmail 80744 invoked by uid 1001); 18 Oct 2004 18:34:50 -0000 Date: Mon, 18 Oct 2004 20:34:50 +0200 From: Erik Trulsson To: Ruslan Ermilov Message-ID: <20041018183450.GB80703@falcon.midgard.homeip.net> Mail-Followup-To: Ruslan Ermilov , David O'Brien , cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <200410181719.i9IHJa9l097436@repoman.freebsd.org> <20041018173516.GB89681@ip.net.ua> <20041018174511.GA6079@dragon.nuxi.com> <20041018180319.GD89681@ip.net.ua> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041018180319.GD89681@ip.net.ua> User-Agent: Mutt/1.5.6i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: David O'Brien Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 18:34:52 -0000 On Mon, Oct 18, 2004 at 09:03:20PM +0300, Ruslan Ermilov wrote: > > http://www.freebsd.org/releases/5.2.1R/hardware-i386.html#PROC > > says i386 (except 386SX) is still supported. I recall phk@ Which doesn't make much sense since (AFAIK) there is no difference between 386DX and 386SX from a programmers point of view. (The difference between them is that the 386sx has a 16-bit databus and a 24-bit address bus, while the 386dx has both 32-bit, but this only affects the motherboard designers, not the people who write software.) -- Erik Trulsson ertr1013@student.uu.se From owner-cvs-src@FreeBSD.ORG Mon Oct 18 18:38:08 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4789216A4CE; Mon, 18 Oct 2004 18:38:08 +0000 (GMT) Received: from obsecurity.dyndns.org (CPE0050040655c8-CM00111ae02aac.cpe.net.cable.rogers.com [69.194.102.143]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1EAF843D62; Mon, 18 Oct 2004 18:38:08 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id 686E4521A6; Mon, 18 Oct 2004 11:38:13 -0700 (PDT) Date: Mon, 18 Oct 2004 11:38:13 -0700 From: Kris Kennaway To: David O'Brien Message-ID: <20041018183813.GA52321@xor.obsecurity.org> References: <200410181719.i9IHJa9l097436@repoman.freebsd.org> <20041018173516.GB89681@ip.net.ua> <20041018174511.GA6079@dragon.nuxi.com> <20041018180319.GD89681@ip.net.ua> <20041018183011.GB10529@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wac7ysb48OaltWcw" Content-Disposition: inline In-Reply-To: <20041018183011.GB10529@dragon.nuxi.com> User-Agent: Mutt/1.4.2.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Ruslan Ermilov cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 18:38:08 -0000 --wac7ysb48OaltWcw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 18, 2004 at 11:30:11AM -0700, David O'Brien wrote: > > If you are burning 6.0-CURRENT bridges already, and this change > > is the step in the I386_CPU deprecation direction, why not just > > unifdef(1) this libc code, so that the "xchg" is always used? >=20 > I'm not decommisioning it -- I left a code path in there for someone who > cares about running on real I386 CPU's. I also plan on MFC'ing this to > RELENG_5 once the branch opens up. Please go read the freebsd-current > thread. As noted there we haven't built a 5-CURRENT I386 runable kernel > since 2001. Do you really think things haven't attrophied such that one > must do some work to run on an I386 at this point? Don't be too quick with the assertions; someone already reported successfully running 5.2.1 on an i386 without significant hassles. Kris --wac7ysb48OaltWcw Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBdA2VWry0BWjoQKURAmncAKCoWogOsS/oCRXydPkJAMfQCT4q7QCdFp6h McUuDITAL5lDuuWgPXr4b7o= =wC3m -----END PGP SIGNATURE----- --wac7ysb48OaltWcw-- From owner-cvs-src@FreeBSD.ORG Mon Oct 18 18:42:35 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BE41F16A4D6; Mon, 18 Oct 2004 18:42:35 +0000 (GMT) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 876ED43D58; Mon, 18 Oct 2004 18:42:35 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.13.1/8.13.1) with ESMTP id i9IIgYEF013676; Mon, 18 Oct 2004 11:42:34 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.13.1/8.13.1/Submit) id i9IIgYJ1013675; Mon, 18 Oct 2004 11:42:34 -0700 (PDT) (envelope-from obrien) Date: Mon, 18 Oct 2004 11:42:34 -0700 From: "David O'Brien" To: Ruslan Ermilov , cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Message-ID: <20041018184234.GC10529@dragon.nuxi.com> References: <200410181719.i9IHJa9l097436@repoman.freebsd.org> <20041018173516.GB89681@ip.net.ua> <20041018174511.GA6079@dragon.nuxi.com> <20041018183118.GA80703@falcon.midgard.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041018183118.GA80703@falcon.midgard.homeip.net> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 6.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 18:42:35 -0000 On Mon, Oct 18, 2004 at 08:31:18PM +0200, Erik Trulsson wrote: > On Mon, Oct 18, 2004 at 10:45:11AM -0700, David O'Brien wrote: > > Yes. You missed the discussion in freebsd-current on this? .. > I have certainly not seen any message stating that on -current. To: freebsd-current@freebsd.org Subject: [PATCH] optimizing X now that we don't support i386 CPU's on 6-CURRENT Message-ID: <20041016174925.GA96809@dragon.nuxi.com> > I know that the GENERIC kernel does not work on a i386, so that you > need a custom-built kernel to install on a real i386. > I also know that support for FPU-less systems has been dropped, which > means that most 386-based systems (those without an '387) (as well as > systems with a 486sx w/o a 487sx) will not run RELENG_5 or -CURRENT. > > Neither of these means that a real 80386+80387 is unsupported, just > that you need to build a new kernel first. I see nothing wrong with having to build a new userland before it will run on I386 since we already have to do that with the kernel. > I think you people need to decide to either drop support for 80386 > completely (in which case all the '#ifdef I386_CPU' and similar can go > away) or decide to keep support for it, in which case most things > should just work 'out of the box' on a 80386 (without recompilation > needed more than absolutely necessary.) That is a whole nother issue, and I welcome you to bring it up in freebsd-arch@ (vs. as a follow up to this commit) where all can debate it. -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Mon Oct 18 18:58:11 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0230F16A4CE; Mon, 18 Oct 2004 18:58:11 +0000 (GMT) Received: from smtp.des.no (flood.des.no [217.116.83.31]) by mx1.FreeBSD.org (Postfix) with ESMTP id ABE7D43D39; Mon, 18 Oct 2004 18:58:10 +0000 (GMT) (envelope-from des@des.no) Received: by smtp.des.no (Pony Express, from userid 666) id 96AE1530A; Mon, 18 Oct 2004 20:58:09 +0200 (CEST) Received: from dwp.des.no (des.no [80.203.228.37]) by smtp.des.no (Pony Express) with ESMTP id BA6FF5312; Mon, 18 Oct 2004 20:58:02 +0200 (CEST) Received: by dwp.des.no (Postfix, from userid 2602) id 9D527B861; Mon, 18 Oct 2004 20:58:02 +0200 (CEST) To: "David E. O'Brien" References: <200410170508.i9H58TEK063835@repoman.freebsd.org> From: des@des.no (=?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?=) Date: Mon, 18 Oct 2004 20:58:02 +0200 In-Reply-To: <200410170508.i9H58TEK063835@repoman.freebsd.org> (David E. O'Brien's message of "Sun, 17 Oct 2004 05:08:29 +0000 (UTC)") Message-ID: User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Checker-Version: SpamAssassin 2.64 (2004-01-11) on flood.des.no X-Spam-Level: X-Spam-Status: No, hits=0.0 required=5.0 tests=AWL autolearn=no version=2.64 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/mk bsd.cpu.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 18:58:11 -0000 "David E. O'Brien" writes: > Log: > + Simplify by treating the standard x86 CPU names as the CPUTYPE vs. > treating them as an alias. Treat the shorthand versions as aliases. > + Separate the x86 GCC CPU CFLAGS from the ICC CFLAGS. This greatly > simplifies the GCC section. It also makes it more clear which CPU's > have the same ICC CPU CFLAGS. > + Remove redundancy in the alpha section. > + Add forgotten ICC CPU CFLAGS for the mobile Intel CPU's added in rev.= 1.42. Thanks! DES --=20 Dag-Erling Sm=F8rgrav - des@des.no From owner-cvs-src@FreeBSD.ORG Mon Oct 18 19:00:47 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 664) id 6FC3D16A4CF; Mon, 18 Oct 2004 19:00:47 +0000 (GMT) Date: Mon, 18 Oct 2004 19:00:47 +0000 From: David O'Brien To: Ruslan Ermilov Message-ID: <20041018190044.GA89411@hub.freebsd.org> References: <200410181719.i9IHJa9l097436@repoman.freebsd.org> <20041018173516.GB89681@ip.net.ua> <20041018174511.GA6079@dragon.nuxi.com> <20041018180319.GD89681@ip.net.ua> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041018180319.GD89681@ip.net.ua> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 4.10-STABLE Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 19:00:47 -0000 On Mon, Oct 18, 2004 at 09:03:20PM +0300, Ruslan Ermilov wrote: > On Mon, Oct 18, 2004 at 10:45:11AM -0700, David O'Brien wrote: > > On Mon, Oct 18, 2004 at 08:35:16PM +0300, Ruslan Ermilov wrote: > > > On Mon, Oct 18, 2004 at 05:19:36PM +0000, David E. O'Brien wrote: > > > > obrien 2004-10-18 17:19:36 UTC > > > > FreeBSD src repository > > > > Modified files: > > > > lib/libc/i386/net htonl.S ntohl.S > > > > Log: > > > > Sync with sys/i386/include/endian.h: use the single instruction 'bswap'. .. > > I know. Give me some other symbol then we can publish that one should > > add to /etc/make.conf CFLAGS to try to build a userland for an I386. > > "I386_CPU" looks as good a spelling as any and I didn't see any need to > > spell it differently than in the kernel. > > > You can check for the CPUTYPE="i386" for ${MACHINE_ARCH} == "i386" > in libc/Makefile, and set I386_CPU in CFLAGS in this case. Taking Revision Changes Path 1.10 +4 -0 src/lib/libc/i386/net/htonl.S 1.10 +4 -0 src/lib/libc/i386/net/ntohl.S specifically what patch do you suggest that we used in cases like this rather than #ifdef I386_CPU". And how to use it? That is one in which someone checks out the source and wants to build a userland that is usable on an I386 machine. -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Mon Oct 18 19:24:36 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DD7BC16A4CE; Mon, 18 Oct 2004 19:24:35 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id C614343D49; Mon, 18 Oct 2004 19:24:34 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i9IJOXJ8002635; Mon, 18 Oct 2004 22:24:33 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 42838-10; Mon, 18 Oct 2004 22:24:32 +0300 (EEST) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i9IJOPUS002629; Mon, 18 Oct 2004 22:24:28 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.1/8.13.1) id i9IJOInd000879; Mon, 18 Oct 2004 22:24:18 +0300 (EEST) (envelope-from ru) Date: Mon, 18 Oct 2004 22:24:17 +0300 From: Ruslan Ermilov To: "David O'Brien" Message-ID: <20041018192417.GE89681@ip.net.ua> References: <200410181719.i9IHJa9l097436@repoman.freebsd.org> <20041018173516.GB89681@ip.net.ua> <20041018174511.GA6079@dragon.nuxi.com> <20041018180319.GD89681@ip.net.ua> <20041018190044.GA89411@hub.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BZaMRJmqxGScZ8Mx" Content-Disposition: inline In-Reply-To: <20041018190044.GA89411@hub.freebsd.org> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new at ip.net.ua cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 19:24:36 -0000 --BZaMRJmqxGScZ8Mx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 18, 2004 at 07:00:47PM +0000, David O'Brien wrote: > On Mon, Oct 18, 2004 at 09:03:20PM +0300, Ruslan Ermilov wrote: > > On Mon, Oct 18, 2004 at 10:45:11AM -0700, David O'Brien wrote: > > > On Mon, Oct 18, 2004 at 08:35:16PM +0300, Ruslan Ermilov wrote: > > > > On Mon, Oct 18, 2004 at 05:19:36PM +0000, David E. O'Brien wrote: > > > > > obrien 2004-10-18 17:19:36 UTC > > > > > FreeBSD src repository > > > > > Modified files: > > > > > lib/libc/i386/net htonl.S ntohl.S=20 > > > > > Log: > > > > > Sync with sys/i386/include/endian.h: use the single instruction= 'bswap'. > .. > > > I know. Give me some other symbol then we can publish that one should > > > add to /etc/make.conf CFLAGS to try to build a userland for an I386. > > > "I386_CPU" looks as good a spelling as any and I didn't see any need = to > > > spell it differently than in the kernel. > > >=20 > > You can check for the CPUTYPE=3D"i386" for ${MACHINE_ARCH} =3D=3D "i386" > > in libc/Makefile, and set I386_CPU in CFLAGS in this case. >=20 > Taking=20 > Revision Changes Path > 1.10 +4 -0 src/lib/libc/i386/net/htonl.S > 1.10 +4 -0 src/lib/libc/i386/net/ntohl.S >=20 > specifically what patch do you suggest that we used in cases like this > rather than #ifdef I386_CPU". And how to use it? That is one in which > someone checks out the source and wants to build a userland that is > usable on an I386 machine. >=20 I thought I already made it clear, seems not. In src/lib/Makefile, add this: =2Eif ${MACHINE_ARCH} =3D=3D "i386" && defined(CPUTYPE) && ${CPUTYPE} =3D= =3D "i386" CFLAGS+=3D -DI386_CPU =2Eendif Or maybe even add -DI386_CPU to _CPUCFLAGS globally in bsd.cpu.mk, so it can be used anywhere. Note: this is completely untested! Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --BZaMRJmqxGScZ8Mx Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBdBhhqRfpzJluFF4RArLJAJ969hENApKkGQ1ombX6DumYZEbznACfegei j4xD91a3FlTmqtCIj0CqNU4= =tnkv -----END PGP SIGNATURE----- --BZaMRJmqxGScZ8Mx-- From owner-cvs-src@FreeBSD.ORG Mon Oct 18 19:29:13 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D801216A4CE; Mon, 18 Oct 2004 19:29:13 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B8B7643D46; Mon, 18 Oct 2004 19:29:13 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9IJTDhP001504; Mon, 18 Oct 2004 19:29:13 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9IJTDZH001503; Mon, 18 Oct 2004 19:29:13 GMT (envelope-from rwatson) Message-Id: <200410181929.i9IJTDZH001503@repoman.freebsd.org> From: Robert Watson Date: Mon, 18 Oct 2004 19:29:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/random harvest.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 19:29:14 -0000 rwatson 2004-10-18 19:29:13 UTC FreeBSD src repository Modified files: sys/dev/random harvest.c Log: Annotate that get_cyclecount() can be expensive on some platforms, which juxtaposes nicely with the comment just above on how the harvest function must be cheap. Revision Changes Path 1.25 +4 -0 src/sys/dev/random/harvest.c From owner-cvs-src@FreeBSD.ORG Mon Oct 18 19:44:04 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9C19F16A4CE; Mon, 18 Oct 2004 19:44:04 +0000 (GMT) Received: from ns1.xcllnt.net (209-128-86-226.bayarea.net [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3D6F943D31; Mon, 18 Oct 2004 19:44:04 +0000 (GMT) (envelope-from marcel@xcllnt.net) Received: from ns1.xcllnt.net (localhost [127.0.0.1]) by ns1.xcllnt.net (8.13.1/8.13.1) with ESMTP id i9IJi3Jq017412; Mon, 18 Oct 2004 12:44:04 -0700 (PDT) (envelope-from marcel@ns1.xcllnt.net) Received: (from marcel@localhost) by ns1.xcllnt.net (8.13.1/8.13.1/Submit) id i9IJi3Cs017411; Mon, 18 Oct 2004 12:44:03 -0700 (PDT) (envelope-from marcel) Date: Mon, 18 Oct 2004 12:44:03 -0700 From: Marcel Moolenaar To: Ruslan Ermilov Message-ID: <20041018194403.GB17033@ns1.xcllnt.net> References: <200410181747.i9IHlVop098346@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200410181747.i9IHlVop098346@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 19:44:04 -0000 On Mon, Oct 18, 2004 at 05:47:31PM +0000, Ruslan Ermilov wrote: > ru 2004-10-18 17:47:31 UTC > > FreeBSD src repository > > Modified files: > . Makefile > Log: > Fixed MAKEOBJDIRPREFIX variable type check in case the env(1) > binary is not in PATH, as is the case with installworld, etc. Thank you! -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net From owner-cvs-src@FreeBSD.ORG Mon Oct 18 19:49:45 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 39CFD16A509; Mon, 18 Oct 2004 19:49:45 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4BA2E43D31; Mon, 18 Oct 2004 19:49:44 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i9IJnhpO003729; Mon, 18 Oct 2004 22:49:43 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 46096-07; Mon, 18 Oct 2004 22:49:42 +0300 (EEST) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i9IJnZ0Y003720; Mon, 18 Oct 2004 22:49:38 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.1/8.13.1) id i9IJnRkJ024769; Mon, 18 Oct 2004 22:49:28 +0300 (EEST) (envelope-from ru) Date: Mon, 18 Oct 2004 22:49:27 +0300 From: Ruslan Ermilov To: "David O'Brien" Message-ID: <20041018194927.GG89681@ip.net.ua> References: <200410181719.i9IHJa9l097436@repoman.freebsd.org> <20041018173516.GB89681@ip.net.ua> <20041018174511.GA6079@dragon.nuxi.com> <20041018183118.GA80703@falcon.midgard.homeip.net> <20041018184234.GC10529@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="E69HUUNAyIJqGpVn" Content-Disposition: inline In-Reply-To: <20041018184234.GC10529@dragon.nuxi.com> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new at ip.net.ua cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 19:49:45 -0000 --E69HUUNAyIJqGpVn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 18, 2004 at 11:42:34AM -0700, David O'Brien wrote: > On Mon, Oct 18, 2004 at 08:31:18PM +0200, Erik Trulsson wrote: > > On Mon, Oct 18, 2004 at 10:45:11AM -0700, David O'Brien wrote: > > > Yes. You missed the discussion in freebsd-current on this? > .. > > I have certainly not seen any message stating that on -current. >=20 > To: freebsd-current@freebsd.org > Subject: [PATCH] optimizing X now that we don't support i386 CPU's on 6-= CURRENT > Message-ID: <20041016174925.GA96809@dragon.nuxi.com> >=20 Well, it's less than three days old, and you made a major decision with this commit that the world no longer supports i386 by default. I wish you discussed in on arch@ first. I re-read this thread, and it seems that you think that since nobody reported a success running on i386 then it's time to kill I386 support in our world by default? I can also read a message from John Nielsen in this same thread saying he was able to install 5.2 on 386DX, so perhaps you owe a dinner to Xin next time you're in Bejing. ;) > > I know that the GENERIC kernel does not work on a i386, so that you > > need a custom-built kernel to install on a real i386. > > I also know that support for FPU-less systems has been dropped, which > > means that most 386-based systems (those without an '387) (as well as > > systems with a 486sx w/o a 487sx) will not run RELENG_5 or -CURRENT. > >=20 > > Neither of these means that a real 80386+80387 is unsupported, just > > that you need to build a new kernel first. >=20 > I see nothing wrong with having to build a new userland before it will > run on I386 since we already have to do that with the kernel. >=20 Having libc optimized for >386 by default is good (IMO), but what you've committed can't be used easily to compile for i386. Perhaps you will adopt/apply my suggestions, and then we will fix the issue for i386 users. I agree with Xin that this deserves a HEADS UP since default world will no longer support i386 hardware. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --E69HUUNAyIJqGpVn Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBdB5HqRfpzJluFF4RAr3YAJ9Hy/qiTxGxswm9FJWZ/G3HpDJF0gCbB1qX P+QKSEaLhsdJC/MOur6ILpY= =v3hD -----END PGP SIGNATURE----- --E69HUUNAyIJqGpVn-- From owner-cvs-src@FreeBSD.ORG Mon Oct 18 19:55:00 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 65E0816A4CE; Mon, 18 Oct 2004 19:55:00 +0000 (GMT) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id EE0B343D54; Mon, 18 Oct 2004 19:54:59 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.13.1/8.13.1) with ESMTP id i9IJswDp002801; Mon, 18 Oct 2004 12:54:58 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.13.1/8.13.1/Submit) id i9IJsw66002800; Mon, 18 Oct 2004 12:54:58 -0700 (PDT) (envelope-from obrien) Date: Mon, 18 Oct 2004 12:54:58 -0700 From: "David O'Brien" To: Ruslan Ermilov Message-ID: <20041018195458.GA2457@dragon.nuxi.com> References: <200410181719.i9IHJa9l097436@repoman.freebsd.org> <20041018173516.GB89681@ip.net.ua> <20041018174511.GA6079@dragon.nuxi.com> <20041018180319.GD89681@ip.net.ua> <20041018190044.GA89411@hub.freebsd.org> <20041018192417.GE89681@ip.net.ua> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041018192417.GE89681@ip.net.ua> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 6.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@FreeBSD.ORG List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 19:55:00 -0000 On Mon, Oct 18, 2004 at 10:24:17PM +0300, Ruslan Ermilov wrote: > On Mon, Oct 18, 2004 at 07:00:47PM +0000, David O'Brien wrote: > > On Mon, Oct 18, 2004 at 09:03:20PM +0300, Ruslan Ermilov wrote: > > > On Mon, Oct 18, 2004 at 10:45:11AM -0700, David O'Brien wrote: > > > > On Mon, Oct 18, 2004 at 08:35:16PM +0300, Ruslan Ermilov wrote: > > > > > On Mon, Oct 18, 2004 at 05:19:36PM +0000, David E. O'Brien wrote: > > > > > > obrien 2004-10-18 17:19:36 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > > > > lib/libc/i386/net htonl.S ntohl.S > > > > > > Log: > > > > > > Sync with sys/i386/include/endian.h: use the single instruction 'bswap'. .. > > Taking > > Revision Changes Path > > 1.10 +4 -0 src/lib/libc/i386/net/htonl.S > > 1.10 +4 -0 src/lib/libc/i386/net/ntohl.S > > > > specifically what patch do you suggest that we used in cases like this > > rather than #ifdef I386_CPU". And how to use it? That is one in which > > someone checks out the source and wants to build a userland that is > > usable on an I386 machine. > > I thought I already made it clear, seems not. Not clear enough that I was 100% sure how to make you happy. I386_CPU needs to be userland land global so we establish the a normal way of doing this. What do you think of this patch? Index: /usr/src/share/mk/bsd.cpu.mk =================================================================== RCS file: /home/ncvs/src/share/mk/bsd.cpu.mk,v retrieving revision 1.44 diff -u -r1.44 bsd.cpu.mk --- /usr/src/share/mk/bsd.cpu.mk 17 Oct 2004 05:19:45 -0000 1.44 +++ /usr/src/share/mk/bsd.cpu.mk 18 Oct 2004 19:51:17 -0000 @@ -100,6 +100,9 @@ . else _ICC_CPUCFLAGS = . endif # ICC on 'i386' +. if ${CPUTYPE} == "i386" +CFLAGS += -DI386_CPU +. endif . elif ${MACHINE_ARCH} == "alpha" _CPUCFLAGS = -mcpu=${CPUTYPE} . elif ${MACHINE_ARCH} == "amd64" -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Mon Oct 18 19:55:53 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AB2A516A4CE; Mon, 18 Oct 2004 19:55:53 +0000 (GMT) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 32FA943D45; Mon, 18 Oct 2004 19:55:53 +0000 (GMT) (envelope-from scottl@freebsd.org) Received: from [192.168.254.11] (junior-wifi.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.12.11/8.12.10) with ESMTP id i9IJu7Mn040098; Mon, 18 Oct 2004 13:56:07 -0600 (MDT) (envelope-from scottl@freebsd.org) Message-ID: <41741F6E.90600@freebsd.org> Date: Mon, 18 Oct 2004 13:54:22 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.2) Gecko/20040929 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Ruslan Ermilov References: <200410181719.i9IHJa9l097436@repoman.freebsd.org> <20041018173516.GB89681@ip.net.ua> <20041018174511.GA6079@dragon.nuxi.com> <20041018183118.GA80703@falcon.midgard.homeip.net> <20041018184234.GC10529@dragon.nuxi.com> <20041018194927.GG89681@ip.net.ua> In-Reply-To: <20041018194927.GG89681@ip.net.ua> X-Enigmail-Version: 0.86.1.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=0.0 required=3.8 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on pooker.samsco.org cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org cc: David O'Brien Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 19:55:53 -0000 Ruslan Ermilov wrote: > On Mon, Oct 18, 2004 at 11:42:34AM -0700, David O'Brien wrote: > >>On Mon, Oct 18, 2004 at 08:31:18PM +0200, Erik Trulsson wrote: >> >>>On Mon, Oct 18, 2004 at 10:45:11AM -0700, David O'Brien wrote: >>> >>>>Yes. You missed the discussion in freebsd-current on this? >> >>.. >> >>>I have certainly not seen any message stating that on -current. >> >> To: freebsd-current@freebsd.org >> Subject: [PATCH] optimizing X now that we don't support i386 CPU's on 6-CURRENT >> Message-ID: <20041016174925.GA96809@dragon.nuxi.com> >> > Well, it's less than three days old, and you made a major > decision with this commit that the world no longer supports > i386 by default. I wish you discussed in on arch@ first. This has been discussed for years. It should not be a surpise. Frankly I'm thrilled that David at least made it conditional rather than just culling the support entirely as has been threatened so often in the past. > > I re-read this thread, and it seems that you think that since > nobody reported a success running on i386 then it's time to > kill I386 support in our world by default? i386 hasn't been supported in the default configuration for years. Whether or not someone got it running with 5.2.1 doesn't change this. The knobs are there to (theoretically) turn it on. So as long as those knobs are consistent and documented, nothing is lost. > > I can also read a message from John Nielsen in this same > thread saying he was able to install 5.2 on 386DX, so perhaps > you owe a dinner to Xin next time you're in Bejing. ;) > > >>>I know that the GENERIC kernel does not work on a i386, so that you >>>need a custom-built kernel to install on a real i386. >>>I also know that support for FPU-less systems has been dropped, which >>>means that most 386-based systems (those without an '387) (as well as >>>systems with a 486sx w/o a 487sx) will not run RELENG_5 or -CURRENT. >>> >>>Neither of these means that a real 80386+80387 is unsupported, just >>>that you need to build a new kernel first. >> >>I see nothing wrong with having to build a new userland before it will >>run on I386 since we already have to do that with the kernel. >> > > Having libc optimized for >386 by default is good (IMO), but what > you've committed can't be used easily to compile for i386. Perhaps > you will adopt/apply my suggestions, and then we will fix the issue > for i386 users. I agree with Xin that this deserves a HEADS UP > since default world will no longer support i386 hardware. > > > Cheers, Guys, just decide on the name of the knob and be done with it. Please! This was settled years ago. The 80386 isn't making an unexpected comeback here that warrants a lot of fighting. Scott From owner-cvs-src@FreeBSD.ORG Mon Oct 18 20:05:26 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9FE6316A4CE; Mon, 18 Oct 2004 20:05:26 +0000 (GMT) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7380E43D41; Mon, 18 Oct 2004 20:05:26 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.13.1/8.13.1) with ESMTP id i9IK5P2x003287; Mon, 18 Oct 2004 13:05:25 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.13.1/8.13.1/Submit) id i9IK5PvV003286; Mon, 18 Oct 2004 13:05:25 -0700 (PDT) (envelope-from obrien) Date: Mon, 18 Oct 2004 13:05:25 -0700 From: "David O'Brien" To: Ruslan Ermilov Message-ID: <20041018200525.GA3210@dragon.nuxi.com> References: <200410181719.i9IHJa9l097436@repoman.freebsd.org> <20041018173516.GB89681@ip.net.ua> <20041018174511.GA6079@dragon.nuxi.com> <20041018183118.GA80703@falcon.midgard.homeip.net> <20041018184234.GC10529@dragon.nuxi.com> <20041018194927.GG89681@ip.net.ua> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041018194927.GG89681@ip.net.ua> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 6.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 20:05:26 -0000 On Mon, Oct 18, 2004 at 10:49:27PM +0300, Ruslan Ermilov wrote: > I can also read a message from John Nielsen in this same > thread saying he was able to install 5.2 on 386DX, so perhaps > you owe a dinner to Xin next time you're in Bejing. ;) I'm willing to buy Xin dinner next time I'm in Bejing regardless. He knows much better than I good places to eat. 8-) -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Mon Oct 18 20:11:33 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 27BE016A4CE; Mon, 18 Oct 2004 20:11:33 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3C5D143D45; Mon, 18 Oct 2004 20:11:32 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i9IKBVXf004820; Mon, 18 Oct 2004 23:11:31 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 48655-11; Mon, 18 Oct 2004 23:11:30 +0300 (EEST) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i9IKBTF0004817; Mon, 18 Oct 2004 23:11:29 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.1/8.13.1) id i9IKBMcq068145; Mon, 18 Oct 2004 23:11:22 +0300 (EEST) (envelope-from ru) Date: Mon, 18 Oct 2004 23:11:22 +0300 From: Ruslan Ermilov To: Scott Long Message-ID: <20041018201122.GB34236@ip.net.ua> References: <200410181719.i9IHJa9l097436@repoman.freebsd.org> <20041018173516.GB89681@ip.net.ua> <20041018174511.GA6079@dragon.nuxi.com> <20041018183118.GA80703@falcon.midgard.homeip.net> <20041018184234.GC10529@dragon.nuxi.com> <20041018194927.GG89681@ip.net.ua> <41741F6E.90600@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="GID0FwUMdk1T2AWN" Content-Disposition: inline In-Reply-To: <41741F6E.90600@freebsd.org> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new at ip.net.ua cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org cc: David O'Brien Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 20:11:33 -0000 --GID0FwUMdk1T2AWN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 18, 2004 at 01:54:22PM -0600, Scott Long wrote: > This has been discussed for years. It should not be a surpise. Frankly > I'm thrilled that David at least made it conditional rather than just > culling the support entirely as has been threatened so often in the > past. > _What_ has been discussed for years? It's been for years that GENERIC kernel doesn't support i386. It's been for years that in 6.0-RELEASE the I386_CPU should go away. It wasn't for years that default world won't run on i386. If this is going to happen (you speak for re@?), then let's declare it to the world first -- this is all I ask about. If i386 support should go away completely, I'm fine with this too, but let's declare it before doing it. =20 > i386 hasn't been supported in the default configuration for years.=20 >=20 This was true only about the kernel. > Whether or not someone got it running with 5.2.1 doesn't change this. >=20 How's that? i386 release notes say that running on i386 is still supported, just requires recompiling a kernel. This is no longer the case after this commit. > The knobs are there to (theoretically) turn it on. So as long as those > knobs are consistent and documented, nothing is lost. >=20 They are not, and my complaint was solely about it. I ended up sending a patch to David for libc/Makefile per his request. > Guys, just decide on the name of the knob and be done with it. Please! > This was settled years ago. The 80386 isn't making an unexpected > comeback here that warrants a lot of fighting. >=20 This is not a fighting at all. Rather, this is just a normal polishing of an incomplete commit. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --GID0FwUMdk1T2AWN Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBdCNqqRfpzJluFF4RAq/gAKCb/nyVcxAPcKg6LCyAdVG4ny2ePgCdHy6j +IjNcfwfNtf+oyMNb+4PWkw= =UJ21 -----END PGP SIGNATURE----- --GID0FwUMdk1T2AWN-- From owner-cvs-src@FreeBSD.ORG Mon Oct 18 20:13:58 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 12A1816A4CE; Mon, 18 Oct 2004 20:13:58 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E085243D1F; Mon, 18 Oct 2004 20:13:57 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9IKDvSb002884; Mon, 18 Oct 2004 20:13:57 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9IKDvcR002883; Mon, 18 Oct 2004 20:13:57 GMT (envelope-from glebius) Message-Id: <200410182013.i9IKDvcR002883@repoman.freebsd.org> From: Gleb Smirnoff Date: Mon, 18 Oct 2004 20:13:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netgraph ng_device.c ng_device.h src/sys/modules/netgraph/device Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 20:13:58 -0000 glebius 2004-10-18 20:13:57 UTC FreeBSD src repository Modified files: sys/netgraph ng_device.c ng_device.h sys/modules/netgraph/device Makefile Log: Major overhaul. List of functional changes: - Make a single device per single node with a single hook. This gives us parrallelizm, which can't be achieved on a single node with many devices/hooks. This also gives us flexibility - we can play with a particular device node, not affecting others. - Remove read queue as it is. Use struct ifqueue instead. This change removes a lot of extra memcpy()ing, m_devget()ting and m_copymem()ming. In ng_device_receivedata() we enqueue an mbuf and wake readers. In ngdread() we take one mbuf from qeueue and uiomove() it to userspace. If no mbuf is present we optionally block. [1] - In ngdwrite() we create an mbuf from uio using m_uiotombuf(). This is faster then uiomove() into buffer, and then m_copydata(), and this is much better than huge m_pullup(). - Perform locking of device - Perform locking of connection list. - Clear out _rcvmsg method, since it does nothing good yet. - Implement NGM_DEVICE_GET_DEVNAME message. - #if 0 ioctl method, while nothing is done here yet. - Return immediately from ngdwrite() if uio_resid == 0. List of tidyness changes: - Introduce device2priv(), to remove cut'n'paste. - Use MALLOC/FREE, instead of malloc/free. - Use unit2minor(). - Use UID_ROOT/GID_WHEEL instead of 0/0. - Define NGD_DEVICE_DEVNAME, use it. - Use more nice macros for debugging. [2] - Return Exxx, not -1. style(9) changes: - No "#endif" after short block. - Break long lines. - Remove extra spaces, add needed spaces. [1] Obtained from: if_tun.c [2] Obtained from: ng_pppoe.c Reviewed by: marks Approved by: julian (mentor) MFC after: 1 month Revision Changes Path 1.2 +1 -1 src/sys/modules/netgraph/device/Makefile 1.12 +270 -357 src/sys/netgraph/ng_device.c 1.4 +9 -2 src/sys/netgraph/ng_device.h From owner-cvs-src@FreeBSD.ORG Mon Oct 18 20:19:07 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6B2D416A4CE; Mon, 18 Oct 2004 20:19:07 +0000 (GMT) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0073743D39; Mon, 18 Oct 2004 20:19:05 +0000 (GMT) (envelope-from scottl@freebsd.org) Received: from [192.168.254.11] (junior-wifi.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.12.11/8.12.10) with ESMTP id i9IKJISh040244; Mon, 18 Oct 2004 14:19:18 -0600 (MDT) (envelope-from scottl@freebsd.org) Message-ID: <417424DE.8050308@freebsd.org> Date: Mon, 18 Oct 2004 14:17:34 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.2) Gecko/20040929 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Ruslan Ermilov References: <200410181719.i9IHJa9l097436@repoman.freebsd.org> <20041018173516.GB89681@ip.net.ua> <20041018174511.GA6079@dragon.nuxi.com> <20041018183118.GA80703@falcon.midgard.homeip.net> <20041018184234.GC10529@dragon.nuxi.com> <20041018194927.GG89681@ip.net.ua> <41741F6E.90600@freebsd.org> <20041018201122.GB34236@ip.net.ua> In-Reply-To: <20041018201122.GB34236@ip.net.ua> X-Enigmail-Version: 0.86.1.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=0.0 required=3.8 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on pooker.samsco.org cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org cc: David O'Brien Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 20:19:07 -0000 Ruslan Ermilov wrote: > On Mon, Oct 18, 2004 at 01:54:22PM -0600, Scott Long wrote: > >>This has been discussed for years. It should not be a surpise. Frankly >>I'm thrilled that David at least made it conditional rather than just >>culling the support entirely as has been threatened so often in the >>past. >> > > _What_ has been discussed for years? > > It's been for years that GENERIC kernel doesn't support i386. > > It's been for years that in 6.0-RELEASE the I386_CPU should > go away. > > It wasn't for years that default world won't run on i386. > If this is going to happen (you speak for re@?), then let's > declare it to the world first -- this is all I ask about. > > If i386 support should go away completely, I'm fine with > this too, but let's declare it before doing it. > > >>i386 hasn't been supported in the default configuration for years. >> > > This was true only about the kernel. With this and your previous statement, I'm having a hard time understanding the big distinction between kernel and world supporting i386. If you want to install and run on an i386, you're going to have to build a custom kernel. I guess that changing the libraries means that you're going to have to build a custom world now also, but it's not taking away the ability to do so. And you even said in a previous email that favoring >i386 is a good thing. So lets do it! Like I said before, as long as the knobs to turn the support back on are consistent and documented, nothing is lost! > > >>Whether or not someone got it running with 5.2.1 doesn't change this. >> > > How's that? i386 release notes say that running on i386 is still > supported, just requires recompiling a kernel. This is no longer > the case after this commit. > > >>The knobs are there to (theoretically) turn it on. So as long as those >>knobs are consistent and documented, nothing is lost. >> > > They are not, and my complaint was solely about it. I ended > up sending a patch to David for libc/Makefile per his request. > > >>Guys, just decide on the name of the knob and be done with it. Please! >>This was settled years ago. The 80386 isn't making an unexpected >>comeback here that warrants a lot of fighting. >> > > This is not a fighting at all. Rather, this is just a normal > polishing of an incomplete commit. > > > Cheers, You seem to be focued on the change to the i386 library. Please work with David to find an acceptable combination of letters and numbers that can be used to signify "Turn 80386 support back on" and then move on. I think that we are all violently in agreement here and are picking on each other for gramatical errors. Fact is that 80386 doesn't work out of the box, this is a new tweak that is needed to make it work, and if you are concerned about the documentation and consistency of the tweak then please fix it. Scott From owner-cvs-src@FreeBSD.ORG Mon Oct 18 20:20:08 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E6A3616A4CF; Mon, 18 Oct 2004 20:20:08 +0000 (GMT) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id B336B43D53; Mon, 18 Oct 2004 20:20:08 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.13.1/8.13.1) with ESMTP id i9IKK85d003815; Mon, 18 Oct 2004 13:20:08 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.13.1/8.13.1/Submit) id i9IKK710003814; Mon, 18 Oct 2004 13:20:07 -0700 (PDT) (envelope-from obrien) Date: Mon, 18 Oct 2004 13:20:07 -0700 From: "David O'Brien" To: Ruslan Ermilov Message-ID: <20041018202007.GE3210@dragon.nuxi.com> References: <200410181719.i9IHJa9l097436@repoman.freebsd.org> <20041018173516.GB89681@ip.net.ua> <20041018174511.GA6079@dragon.nuxi.com> <20041018183118.GA80703@falcon.midgard.homeip.net> <20041018184234.GC10529@dragon.nuxi.com> <20041018194927.GG89681@ip.net.ua> <41741F6E.90600@freebsd.org> <20041018201122.GB34236@ip.net.ua> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041018201122.GB34236@ip.net.ua> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 6.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: Scott Long cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 20:20:09 -0000 On Mon, Oct 18, 2004 at 11:11:22PM +0300, Ruslan Ermilov wrote: > They are not, and my complaint was solely about it. I ended > up sending a patch to David for libc/Makefile per his request. What patch? You sent me nothing patch(1) would consume. You just stated a direction to go in. -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Mon Oct 18 20:22:09 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2EE6516A4CF; Mon, 18 Oct 2004 20:22:09 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3F55F43D3F; Mon, 18 Oct 2004 20:22:06 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i9IKM5VV005337; Mon, 18 Oct 2004 23:22:05 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 49963-02; Mon, 18 Oct 2004 23:22:03 +0300 (EEST) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i9IKM3KH005334; Mon, 18 Oct 2004 23:22:03 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.1/8.13.1) id i9IKLuXu085052; Mon, 18 Oct 2004 23:21:56 +0300 (EEST) (envelope-from ru) Date: Mon, 18 Oct 2004 23:21:55 +0300 From: Ruslan Ermilov To: "David O'Brien" Message-ID: <20041018202155.GD34236@ip.net.ua> References: <200410181719.i9IHJa9l097436@repoman.freebsd.org> <20041018173516.GB89681@ip.net.ua> <20041018174511.GA6079@dragon.nuxi.com> <20041018180319.GD89681@ip.net.ua> <20041018190044.GA89411@hub.freebsd.org> <20041018192417.GE89681@ip.net.ua> <20041018195458.GA2457@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="eqp4TxRxnD4KrmFZ" Content-Disposition: inline In-Reply-To: <20041018195458.GA2457@dragon.nuxi.com> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new at ip.net.ua cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 20:22:09 -0000 --eqp4TxRxnD4KrmFZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 18, 2004 at 12:54:58PM -0700, David O'Brien wrote: > On Mon, Oct 18, 2004 at 10:24:17PM +0300, Ruslan Ermilov wrote: > > On Mon, Oct 18, 2004 at 07:00:47PM +0000, David O'Brien wrote: > > > On Mon, Oct 18, 2004 at 09:03:20PM +0300, Ruslan Ermilov wrote: > > > > On Mon, Oct 18, 2004 at 10:45:11AM -0700, David O'Brien wrote: > > > > > On Mon, Oct 18, 2004 at 08:35:16PM +0300, Ruslan Ermilov wrote: > > > > > > On Mon, Oct 18, 2004 at 05:19:36PM +0000, David E. O'Brien wrot= e: > > > > > > > obrien 2004-10-18 17:19:36 UTC > > > > > > > FreeBSD src repository > > > > > > > Modified files: > > > > > > > lib/libc/i386/net htonl.S ntohl.S=20 > > > > > > > Log: > > > > > > > Sync with sys/i386/include/endian.h: use the single instruc= tion 'bswap'. > .. > > > Taking=20 > > > Revision Changes Path > > > 1.10 +4 -0 src/lib/libc/i386/net/htonl.S > > > 1.10 +4 -0 src/lib/libc/i386/net/ntohl.S > > >=20 > > > specifically what patch do you suggest that we used in cases like this > > > rather than #ifdef I386_CPU". And how to use it? That is one in whi= ch > > > someone checks out the source and wants to build a userland that is > > > usable on an I386 machine. > >=20 > > I thought I already made it clear, seems not. >=20 > Not clear enough that I was 100% sure how to make you happy. >=20 Not me, but our i386 users. ;) > I386_CPU > needs to be userland land global so we establish the a normal way of > doing this. What do you think of this patch? >=20 > Index: /usr/src/share/mk/bsd.cpu.mk > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /home/ncvs/src/share/mk/bsd.cpu.mk,v > retrieving revision 1.44 > diff -u -r1.44 bsd.cpu.mk > --- /usr/src/share/mk/bsd.cpu.mk 17 Oct 2004 05:19:45 -0000 1.44 > +++ /usr/src/share/mk/bsd.cpu.mk 18 Oct 2004 19:51:17 -0000 > @@ -100,6 +100,9 @@ > . else > _ICC_CPUCFLAGS =3D > . endif # ICC on 'i386' > +. if ${CPUTYPE} =3D=3D "i386" > +CFLAGS +=3D -DI386_CPU > +. endif > . elif ${MACHINE_ARCH} =3D=3D "alpha" > _CPUCFLAGS =3D -mcpu=3D${CPUTYPE} > . elif ${MACHINE_ARCH} =3D=3D "amd64" >=20 That's what I suggested except that you put it directly to CFLAGS. I agree that putting it directly to CFLAGS is more correct. Yes, I like this patch. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --eqp4TxRxnD4KrmFZ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBdCXjqRfpzJluFF4RAtREAJ9DJsTPb90brlns8EB5JfeftDxEfACff1sI 6c4DFYBlPs7aCQPwrbJ3G8A= =sq26 -----END PGP SIGNATURE----- --eqp4TxRxnD4KrmFZ-- From owner-cvs-src@FreeBSD.ORG Mon Oct 18 20:25:31 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7CC6C16A4D1; Mon, 18 Oct 2004 20:25:31 +0000 (GMT) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6085443D1D; Mon, 18 Oct 2004 20:25:31 +0000 (GMT) (envelope-from mux@freebsd.org) Received: by elvis.mu.org (Postfix, from userid 1920) id 577ED5C941; Mon, 18 Oct 2004 13:25:31 -0700 (PDT) Date: Mon, 18 Oct 2004 22:25:31 +0200 From: Maxime Henrion To: Gleb Smirnoff Message-ID: <20041018202531.GF45249@elvis.mu.org> References: <200410182013.i9IKDvcR002883@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200410182013.i9IKDvcR002883@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/netgraph ng_device.c ng_device.h src/sys/modules/netgraph/device Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 20:25:31 -0000 Gleb Smirnoff wrote: > glebius 2004-10-18 20:13:57 UTC > > FreeBSD src repository > > Modified files: > sys/netgraph ng_device.c ng_device.h > sys/modules/netgraph/device Makefile > Log: [...] > - Use MALLOC/FREE, instead of malloc/free. This is backwards. The MALLOC() and FREE() macros are deprecated, and shouldn't be used in new code. These macros were used because they allowed an optimization when the size of the request is constant; some computation was done at build-time rather than at run-time (if I remember correctly, the computation is for getting the correct power-of-2 free-list). Anyways, this was with the McKusick-Karels memory allocator, and these macros are not appropriate anymore, they just obfuscate the code a bit. I thought you'd like to know :-). Thanks for the great work on ng_device! Cheers, Maxime From owner-cvs-src@FreeBSD.ORG Mon Oct 18 20:55:12 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 12D5A16A4CE; Mon, 18 Oct 2004 20:55:12 +0000 (GMT) Received: from storm.uk.FreeBSD.org (storm.uk.FreeBSD.org [194.242.157.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8339243D1F; Mon, 18 Oct 2004 20:55:11 +0000 (GMT) (envelope-from mark@grondar.org) Received: from storm.uk.FreeBSD.org (uucp@localhost [127.0.0.1]) by storm.uk.FreeBSD.org (8.13.1/8.13.1) with ESMTP id i9IKtAq7061200; Mon, 18 Oct 2004 21:55:10 +0100 (BST) (envelope-from mark@grondar.org) Received: (from uucp@localhost)i9IKt9Ii061199; Mon, 18 Oct 2004 21:55:09 +0100 (BST) (envelope-from mark@grondar.org) Received: from grondar.org (localhost [127.0.0.1]) by grovel.grondar.org (8.13.1/8.13.1) with ESMTP id i9IKoY1x069132; Mon, 18 Oct 2004 21:50:34 +0100 (BST) (envelope-from mark@grondar.org) Message-Id: <200410182050.i9IKoY1x069132@grovel.grondar.org> X-Mailer: exmh version 2.7.0 06/18/2004 with nmh-1.0.4 To: Robert Watson In-Reply-To: Message from Robert Watson <200410181929.i9IJTDZH001503@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 18 Oct 2004 21:50:34 +0100 From: Mark Murray cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: mark@grovel.grondar.org cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/random harvest.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 20:55:12 -0000 > Log: > Annotate that get_cyclecount() can be expensive on some platforms, > which juxtaposes nicely with the comment just above on how the > harvest function must be cheap. Cool. And I have a PHK-inspired improvement to the get_cyclecount() function that should improve the !TSC case quite a bit. Commit in a day or three. M From owner-cvs-src@FreeBSD.ORG Mon Oct 18 20:58:55 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 45FBD16A4CE; Mon, 18 Oct 2004 20:58:55 +0000 (GMT) Received: from newtrinity.zeist.de (newtrinity.zeist.de [217.24.217.8]) by mx1.FreeBSD.org (Postfix) with ESMTP id 923D943D2F; Mon, 18 Oct 2004 20:58:54 +0000 (GMT) (envelope-from marius@newtrinity.zeist.de) Received: from newtrinity.zeist.de (localhost [127.0.0.1]) i9IKwrAZ075334; Mon, 18 Oct 2004 22:58:53 +0200 (CEST) (envelope-from marius@newtrinity.zeist.de) Received: (from marius@localhost) by newtrinity.zeist.de (8.12.10/8.12.10/Submit) id i9IKwlcJ075333; Mon, 18 Oct 2004 22:58:47 +0200 (CEST) (envelope-from marius) Date: Mon, 18 Oct 2004 22:58:47 +0200 From: Marius Strobl To: Marcel Moolenaar Message-ID: <20041018225847.A12117@newtrinity.zeist.de> References: <200410122233.i9CMXJxl047004@repoman.freebsd.org> <20041012225842.GA27757@ns1.xcllnt.net> <20041013114422.A9875@newtrinity.zeist.de> <20041013201920.GA34255@ns1.xcllnt.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20041013201920.GA34255@ns1.xcllnt.net>; from marcel@xcllnt.net on Wed, Oct 13, 2004 at 01:19:20PM -0700 X-AntiVirus: checked by AntiVir Milter (version: 1.1; AVE: 6.28.0.7; VDF: 6.28.0.20; host: newtrinity.zeist.de) cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: Poul-Henning Kamp cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/sab sab.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 20:58:55 -0000 On Wed, Oct 13, 2004 at 01:19:20PM -0700, Marcel Moolenaar wrote: > On Wed, Oct 13, 2004 at 11:44:22AM +0200, Marius Strobl wrote: > > > > > > > > Isn't this driver superseeded by uart(4) anyway ? > > > > > > Yes, in principle. I don't think I'm in the position to remove sab(4) > > > though. > > > > Uart(4) works fine as a replacement for sab(4) but we're not ready to > > switch to uart(4) by default on sparc64. > > Z8530 issues, right? > The Z8530 issues are the biggest problem but there are others: - When both uart(4) and ofw_console(4) are present but the input and output are keyboard and screen respectively one ends up with no working console. The problem simply is that the OFW keyboard driver no longer works once uart(4) attaches to the keyboard port. A quick hack to uart_bus_probe() to fail when the UART is the keyboard port but not a sysdev makes both uart(4) and ofw_console(4) work happily together. But I'd rather make uart(4) attach in sort of a disabled mode in the above case, i.e. claim the resources but don't do anything with the UART, so nothing else can attach to the respective UART, the user can be told what's going on and device numbering is the same whether the keyboard is used directly or via OFW. - Using the second on-board 16550 on the ISA bus of sparc64 machines causes a hang, i.e. an endless loop in uart_intr(), as these UARTs share the same IRQ, uart(4) successfully registers both handlers as fast ones but FreeBSD/sparc64 misses the MD part of shared fast interrupt handlers (and also doesn't prevent setting up shared fast interrupt handlers). A patch implementing the sparc64 part for shared fast handlers is under review. - There's no support for UARTs on the FHC bus (and for that matter also not for powerpc/macio so zs(4) could be entirely replaced), yet. This for one requires working Z8530 support but also a uart_bus_fhc.c and support for FHC in the sparc64 OF_decode_addr() or better finally a rewrite of OF_decode_addr() to be mostly bus-neutral (might even work for powerpc then). If there is a strong desire to remove sab(4) I'd say one could switch to uart(4) by default on sparc64 once the first two problems above are solved but one would have to disable support for Z8530 until uart(4) really supports these or at least don't attach to the Z8530 that are keyboard or mosue ports as those currently causes the most problems (Z8530 as console port works ok, but ttyb, i.e. the non- console port of the first SCC doesn't reliably). As for the Z8530 issues I spent quite a while trying to make it work without success. I think the main problem is the "special" way uart(4) work's around the problem that it can't use the interrupt status register shared between the two channels. But there seem to be other problems, e.g. according to my break-out box ttyb comes up in wired states most of the time when the stock uart(4) initilizes it; I got it to come up in a consistent state by rototilling the initialization to be as close as possible to the datasheet but then ttyb never worked (as opposed to sometimes with the stock uart(4)). The hang when keyboard and mouse are unplugged is caused by an endless stream of breaks on these ports in this case but for reasons unknown to me I didn't manage to make the Z8530 to not trigger an interrupt on non-sysdev ports. I think the first step to get working Z8530 support is to create an chip-aware scc(4) (as opposed to puc(4) which mainly is sort of a resource multiplexer/splitter) but I currently don't really want to deal with the other aspects of a scc(4) like synchronous mode etc. Marius From owner-cvs-src@FreeBSD.ORG Mon Oct 18 21:05:57 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2CC7916A4CE; Mon, 18 Oct 2004 21:05:57 +0000 (GMT) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id C2A3543D3F; Mon, 18 Oct 2004 21:05:56 +0000 (GMT) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (localhost [127.0.0.1]) by fledge.watson.org (8.13.1/8.13.1) with ESMTP id i9IL5n5M055762; Mon, 18 Oct 2004 17:05:49 -0400 (EDT) (envelope-from robert@fledge.watson.org) Received: from localhost (robert@localhost)i9IL5nAh055759; Mon, 18 Oct 2004 17:05:49 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Mon, 18 Oct 2004 17:05:49 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: Mark Murray In-Reply-To: <200410182050.i9IKoY1x069132@grovel.grondar.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: mark@grovel.grondar.org cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/random harvest.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 21:05:57 -0000 On Mon, 18 Oct 2004, Mark Murray wrote: > > Log: > > Annotate that get_cyclecount() can be expensive on some platforms, > > which juxtaposes nicely with the comment just above on how the > > harvest function must be cheap. > > Cool. > > And I have a PHK-inspired improvement to the get_cyclecount() function > that should improve the !TSC case quite a bit. > > Commit in a day or three. Wonderful. I figured, since I wasn't making any progress currently on entropy-related stuff, that I should document the issue. If you have fixes in the pipeline, that sounds good to me. BTW, maybe we should make this dinner and conversation at the Thai Pub (a good concept) a bi-weekly thing for FreeBSD developers? :-) Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Principal Research Scientist, McAfee Research From owner-cvs-src@FreeBSD.ORG Mon Oct 18 21:19:10 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EE3DF16A4CE; Mon, 18 Oct 2004 21:19:10 +0000 (GMT) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id A9DE343D49; Mon, 18 Oct 2004 21:19:10 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.13.1/8.13.1) with ESMTP id i9ILJ9JR005398; Mon, 18 Oct 2004 14:19:09 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.13.1/8.13.1/Submit) id i9ILJ8mC005397; Mon, 18 Oct 2004 14:19:08 -0700 (PDT) (envelope-from obrien) Date: Mon, 18 Oct 2004 14:19:08 -0700 From: "David O'Brien" To: Poul-Henning Kamp Message-ID: <20041018211908.GA5367@dragon.nuxi.com> References: <20041018033709.GB5880@dragon.nuxi.com> <48226.1098078426@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <48226.1098078426@critter.freebsd.dk> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 6.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pc98/pc98 sio.c src/sys/dev/sio sio.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 21:19:11 -0000 Thanks, I'll commit it. Can you please add something to src/UPDATING?? On Mon, Oct 18, 2004 at 07:47:06AM +0200, Poul-Henning Kamp wrote: > Looks like it. > In message <20041018033709.GB5880@dragon.nuxi.com>, "David O'Brien" writes: > >On Wed, Oct 13, 2004 at 08:27:20AM +0000, Poul-Henning Kamp wrote: > >> phk 2004-10-13 08:27:20 UTC > >> FreeBSD src repository > >> > >> Modified files: > >> sys/pc98/pc98 sio.c > >> sys/dev/sio sio.c > >> Log: > >> Use generic tty code instead of local stuff. > >> NB: device names are now consistent: {cua,tty}d$(port)[.lock,.init] > > > >Is this the correct man page change? From owner-cvs-src@FreeBSD.ORG Mon Oct 18 21:24:21 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9AB9516A4CE; Mon, 18 Oct 2004 21:24:21 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7E0C643D1D; Mon, 18 Oct 2004 21:24:21 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9ILOLpR011691; Mon, 18 Oct 2004 21:24:21 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9ILOLC3011690; Mon, 18 Oct 2004 21:24:21 GMT (envelope-from phk) Message-Id: <200410182124.i9ILOLC3011690@repoman.freebsd.org> From: Poul-Henning Kamp Date: Mon, 18 Oct 2004 21:24:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src UPDATING X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 21:24:21 -0000 phk 2004-10-18 21:24:21 UTC FreeBSD src repository Modified files: . UPDATING Log: Add an entry about some tty devices being renamed. Revision Changes Path 1.375 +8 -0 src/UPDATING From owner-cvs-src@FreeBSD.ORG Mon Oct 18 21:29:20 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6640016A4CE; Mon, 18 Oct 2004 21:29:20 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 495F943D41; Mon, 18 Oct 2004 21:29:20 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9ILTKMP011918; Mon, 18 Oct 2004 21:29:20 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9ILTKlt011917; Mon, 18 Oct 2004 21:29:20 GMT (envelope-from ru) Message-Id: <200410182129.i9ILTKlt011917@repoman.freebsd.org> From: Ruslan Ermilov Date: Mon, 18 Oct 2004 21:29:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin/rpc.yppasswdd Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 21:29:20 -0000 ru 2004-10-18 21:29:20 UTC FreeBSD src repository Modified files: usr.sbin/rpc.yppasswdd Makefile Log: Utilize SCRIPTS. Revision Changes Path 1.21 +2 -5 src/usr.sbin/rpc.yppasswdd/Makefile From owner-cvs-src@FreeBSD.ORG Mon Oct 18 21:31:05 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9217F16A4CE; Mon, 18 Oct 2004 21:31:05 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7507A43D31; Mon, 18 Oct 2004 21:31:05 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9ILV5hw012041; Mon, 18 Oct 2004 21:31:05 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9ILV5AF012040; Mon, 18 Oct 2004 21:31:05 GMT (envelope-from obrien) Message-Id: <200410182131.i9ILV5AF012040@repoman.freebsd.org> From: "David E. O'Brien" Date: Mon, 18 Oct 2004 21:31:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/man/man4 sio.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 21:31:05 -0000 obrien 2004-10-18 21:31:05 UTC FreeBSD src repository Modified files: share/man/man4 sio.4 Log: Catch up with PHK's sio(4) rework [sys/dev/sio/sio.c rev. 1.456]. Also catch up with RCng. Reviewed by: phk Revision Changes Path 1.54 +9 -9 src/share/man/man4/sio.4 From owner-cvs-src@FreeBSD.ORG Mon Oct 18 21:33:57 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 42DDD16A4CE; Mon, 18 Oct 2004 21:33:57 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2483443D3F; Mon, 18 Oct 2004 21:33:57 +0000 (GMT) (envelope-from le@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9ILXvBg012114; Mon, 18 Oct 2004 21:33:57 GMT (envelope-from le@repoman.freebsd.org) Received: (from le@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9ILXvsN012113; Mon, 18 Oct 2004 21:33:57 GMT (envelope-from le) Message-Id: <200410182133.i9ILXvsN012113@repoman.freebsd.org> From: Lukas Ertl Date: Mon, 18 Oct 2004 21:33:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/if_ndis if_ndis.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 21:33:57 -0000 le 2004-10-18 21:33:56 UTC FreeBSD src repository Modified files: sys/dev/if_ndis if_ndis.c Log: Drop the NDIS lock before returning from ndis_start(). PR: i386/72795 Submitted by: Frank Mayhar MFC in: 3 days Revision Changes Path 1.71 +3 -1 src/sys/dev/if_ndis/if_ndis.c From owner-cvs-src@FreeBSD.ORG Mon Oct 18 21:42:15 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DD30516A4CF; Mon, 18 Oct 2004 21:42:15 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B199D43D1F; Mon, 18 Oct 2004 21:42:15 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9ILgFFE012753; Mon, 18 Oct 2004 21:42:15 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9ILgFvZ012752; Mon, 18 Oct 2004 21:42:15 GMT (envelope-from ru) Message-Id: <200410182142.i9ILgFvZ012752@repoman.freebsd.org> From: Ruslan Ermilov Date: Mon, 18 Oct 2004 21:42:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin/ypserv Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 21:42:16 -0000 ru 2004-10-18 21:42:15 UTC FreeBSD src repository Modified files: usr.sbin/ypserv Makefile Log: Utilize FILES, SCRIPTS, and SYMLINKS. While here, fixed a bug in the implementation of the following feature in revision 1.4: - Install Makefile.yp as /var/yp/Makefile.dist and link it to /var/yp/Makefile only if /var/yp/Makefile doesn't already exist. Suggested by Peter Wemm. The actual code was only symlinking when no /var/yp/Makefile.dist existed, i.e., never. Revision Changes Path 1.24 +8 -9 src/usr.sbin/ypserv/Makefile From owner-cvs-src@FreeBSD.ORG Mon Oct 18 21:44:18 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4F28F16A4EA; Mon, 18 Oct 2004 21:44:18 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3069943D53; Mon, 18 Oct 2004 21:44:18 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9ILiIix012891; Mon, 18 Oct 2004 21:44:18 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9ILiIqe012890; Mon, 18 Oct 2004 21:44:18 GMT (envelope-from ru) Message-Id: <200410182144.i9ILiIqe012890@repoman.freebsd.org> From: Ruslan Ermilov Date: Mon, 18 Oct 2004 21:44:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/gnu/usr.bin/rcs/rcsfreeze Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 21:44:18 -0000 ru 2004-10-18 21:44:18 UTC FreeBSD src repository Modified files: gnu/usr.bin/rcs/rcsfreeze Makefile Log: Utilize SCRIPTS. Revision Changes Path 1.9 +1 -4 src/gnu/usr.bin/rcs/rcsfreeze/Makefile From owner-cvs-src@FreeBSD.ORG Mon Oct 18 21:51:27 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6844D16A4CE; Mon, 18 Oct 2004 21:51:27 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 582C143D48; Mon, 18 Oct 2004 21:51:27 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9ILpRXf013432; Mon, 18 Oct 2004 21:51:27 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9ILpRE1013431; Mon, 18 Oct 2004 21:51:27 GMT (envelope-from phk) Message-Id: <200410182151.i9ILpRE1013431@repoman.freebsd.org> From: Poul-Henning Kamp Date: Mon, 18 Oct 2004 21:51:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/alpha/alpha promcons.c src/sys/alpha/tlsb zs_tlsb.c src/sys/dev/dcons dcons_os.c src/sys/dev/digi digi.c src/sys/dev/nmdm nmdm.c src/sys/dev/ofw ofw_console.c src/sys/dev/syscons syscons.c sysmouse.c src/sys/dev/zs zs.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 21:51:27 -0000 phk 2004-10-18 21:51:27 UTC FreeBSD src repository Modified files: sys/alpha/alpha promcons.c sys/alpha/tlsb zs_tlsb.c sys/dev/dcons dcons_os.c sys/dev/digi digi.c sys/dev/nmdm nmdm.c sys/dev/ofw ofw_console.c sys/dev/syscons syscons.c sysmouse.c sys/dev/zs zs.c sys/i386/isa/pcvt pcvt_drv.c sys/ia64/ia64 ssc.c sys/kern tty.c tty_pty.c sys/sys tty.h Log: Add new function ttyinitmode() which sets our systemwide default modes on a tty structure. Both the ".init" and the current settings are initialized allowing the function to be used both at attach and open time. The function takes an argument to decide if echoing should be enabled. Echoing should not be enabled for regular physical serial ports unless they are consoles, in which case they should be configured by ttyconsolemode() instead. Use the new function throughout. Revision Changes Path 1.42 +1 -6 src/sys/alpha/alpha/promcons.c 1.49 +1 -6 src/sys/alpha/tlsb/zs_tlsb.c 1.3 +1 -6 src/sys/dev/dcons/dcons_os.c 1.57 +1 -16 src/sys/dev/digi/digi.c 1.31 +1 -7 src/sys/dev/nmdm/nmdm.c 1.30 +1 -6 src/sys/dev/ofw/ofw_console.c 1.431 +20 -20 src/sys/dev/syscons/syscons.c 1.26 +1 -6 src/sys/dev/syscons/sysmouse.c 1.29 +2 -15 src/sys/dev/zs/zs.c 1.90 +1 -6 src/sys/i386/isa/pcvt/pcvt_drv.c 1.24 +1 -6 src/sys/ia64/ia64/ssc.c 1.239 +29 -12 src/sys/kern/tty.c 1.133 +1 -6 src/sys/kern/tty_pty.c 1.97 +1 -0 src/sys/sys/tty.h From owner-cvs-src@FreeBSD.ORG Mon Oct 18 21:56:22 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1AB3716A4CE; Mon, 18 Oct 2004 21:56:22 +0000 (GMT) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id F302C43D31; Mon, 18 Oct 2004 21:56:21 +0000 (GMT) (envelope-from mux@freebsd.org) Received: by elvis.mu.org (Postfix, from userid 1920) id E87895C8FA; Mon, 18 Oct 2004 14:56:21 -0700 (PDT) Date: Mon, 18 Oct 2004 23:56:21 +0200 From: Maxime Henrion To: Gleb Smirnoff Message-ID: <20041018215621.GA41649@elvis.mu.org> References: <200410182013.i9IKDvcR002883@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200410182013.i9IKDvcR002883@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netgraph ng_device.c ng_device.h src/sys/modules/netgraph/device Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 21:56:22 -0000 Gleb Smirnoff wrote: > glebius 2004-10-18 20:13:57 UTC > > FreeBSD src repository > > Modified files: > sys/netgraph ng_device.c ng_device.h > sys/modules/netgraph/device Makefile > Log: [...] > - Use MALLOC/FREE, instead of malloc/free. This is backwards. The MALLOC() and FREE() macros are deprecated, and shouldn't be used in new code. These macros were used because they allowed an optimization when the size of the request is constant; some computation was done at build-time rather than at run-time (if I remember correctly, the computation is for getting the correct power-of-2 free-list). Anyways, this was with the McKusick-Karels memory allocator, and these macros are not appropriate anymore, they just obfuscate the code a bit. I thought you'd like to know :-). Thanks for the great work on ng_device! Cheers, Maxime From owner-cvs-src@FreeBSD.ORG Mon Oct 18 22:18:23 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7707316A4CE; Mon, 18 Oct 2004 22:18:23 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 58F0E43D39; Mon, 18 Oct 2004 22:18:23 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9IMINDd014600; Mon, 18 Oct 2004 22:18:23 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9IMINgc014599; Mon, 18 Oct 2004 22:18:23 GMT (envelope-from ru) Message-Id: <200410182218.i9IMINgc014599@repoman.freebsd.org> From: Ruslan Ermilov Date: Mon, 18 Oct 2004 22:18:23 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libmagic Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 22:18:23 -0000 ru 2004-10-18 22:18:23 UTC FreeBSD src repository Modified files: lib/libmagic Makefile Log: uniq(1) is not an install tool, and using it was causing "uniq: not found" during the installworld. Spotted by: Roman Neuhauser Revision Changes Path 1.4 +2 -2 src/lib/libmagic/Makefile From owner-cvs-src@FreeBSD.ORG Mon Oct 18 22:19:44 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2B88B16A4CF; Mon, 18 Oct 2004 22:19:44 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0FAD443D53; Mon, 18 Oct 2004 22:19:44 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9IMJhFA014861; Mon, 18 Oct 2004 22:19:43 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9IMJhnx014860; Mon, 18 Oct 2004 22:19:43 GMT (envelope-from rwatson) Message-Id: <200410182219.i9IMJhnx014860@repoman.freebsd.org> From: Robert Watson Date: Mon, 18 Oct 2004 22:19:43 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern kern_descrip.c uipc_socket.c uipc_usrreq.c src/sys/net raw_cb.c raw_usrreq.c src/sys/netatalk ddp_pcb.c src/sys/netatm atm_socket.cng_btsocket_l2cap.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 22:19:44 -0000 rwatson 2004-10-18 22:19:43 UTC FreeBSD src repository Modified files: sys/kern kern_descrip.c uipc_socket.c uipc_usrreq.c sys/net raw_cb.c raw_usrreq.c sys/netatalk ddp_pcb.c sys/netatm atm_socket.c sys/netgraph/bluetooth/socket ng_btsocket_hci_raw.c ng_btsocket_l2cap.c ng_btsocket_l2cap_raw.c ng_btsocket_rfcomm.c sys/netinet in_pcb.c tcp_subr.c sys/netinet6 in6_pcb.c sys/netipx ipx_pcb.c ipx_usrreq.c sys/netnatm natm.c sys/sys socketvar.h Log: Push acquisition of the accept mutex out of sofree() into the caller (sorele()/sotryfree()): - This permits the caller to acquire the accept mutex before the socket mutex, avoiding sofree() having to drop the socket mutex and re-order, which could lead to races permitting more than one thread to enter sofree() after a socket is ready to be free'd. - This also covers clearing of the so_pcb weak socket reference from the protocol to the socket, preventing races in clearing and evaluation of the reference such that sofree() might be called more than once on the same socket. This appears to close a race I was able to easily trigger by repeatedly opening and resetting TCP connections to a host, in which the tcp_close() code called as a result of the RST raced with the close() of the accepted socket in the user process resulting in simultaneous attempts to de-allocate the same socket. The new locking increases the overhead for operations that may potentially free the socket, so we will want to revise the synchronization strategy here as we normalize the reference counting model for sockets. The use of the accept mutex in freeing of sockets that are not listen sockets is primarily motivated by the potential need to remove the socket from the incomplete connection queue on its parent (listen) socket, so cleaning up the reference model here may allow us to substantially weaken the synchronization requirements. RELENG_5_3 candidate. MFC after: 3 days Reviewed by: dwhite Discussed with: gnn, dwhite, green Reported by: Marc UBM Bocklet Reported by: Vlad Revision Changes Path 1.246 +1 -0 src/sys/kern/kern_descrip.c 1.214 +4 -3 src/sys/kern/uipc_socket.c 1.141 +1 -0 src/sys/kern/uipc_usrreq.c 1.30 +1 -0 src/sys/net/raw_cb.c 1.35 +1 -0 src/sys/net/raw_usrreq.c 1.45 +1 -0 src/sys/netatalk/ddp_pcb.c 1.21 +1 -0 src/sys/netatm/atm_socket.c 1.16 +1 -0 src/sys/netgraph/bluetooth/socket/ng_btsocket_hci_raw.c 1.14 +2 -0 src/sys/netgraph/bluetooth/socket/ng_btsocket_l2cap.c 1.13 +1 -0 src/sys/netgraph/bluetooth/socket/ng_btsocket_l2cap_raw.c 1.13 +1 -0 src/sys/netgraph/bluetooth/socket/ng_btsocket_rfcomm.c 1.156 +1 -0 src/sys/netinet/in_pcb.c 1.205 +1 -0 src/sys/netinet/tcp_subr.c 1.61 +1 -0 src/sys/netinet6/in6_pcb.c 1.29 +1 -0 src/sys/netipx/ipx_pcb.c 1.41 +1 -0 src/sys/netipx/ipx_usrreq.c 1.35 +2 -0 src/sys/netnatm/natm.c 1.135 +10 -2 src/sys/sys/socketvar.h From owner-cvs-src@FreeBSD.ORG Mon Oct 18 23:06:13 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5DFB316A4CE; Mon, 18 Oct 2004 23:06:13 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3F81A43D48; Mon, 18 Oct 2004 23:06:13 +0000 (GMT) (envelope-from jmg@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9IN6DeN016513; Mon, 18 Oct 2004 23:06:13 GMT (envelope-from jmg@repoman.freebsd.org) Received: (from jmg@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9IN6DDx016512; Mon, 18 Oct 2004 23:06:13 GMT (envelope-from jmg) Message-Id: <200410182306.i9IN6DDx016512@repoman.freebsd.org> From: John-Mark Gurney Date: Mon, 18 Oct 2004 23:06:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/pci if_de.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 23:06:13 -0000 jmg 2004-10-18 23:06:13 UTC FreeBSD src repository Modified files: sys/pci if_de.c Log: fix (for me) the problems where if_de gets really slow after time (usually taking 20 seconds to transmit a packet).. no longer fall back to only transmitting one packet (instead of the entire queue) after we have processed the entire send queue... I have no idea why we didn't start seeing this problem ~6 years ago when this code was introduced... Revision Changes Path 1.159 +0 -21 src/sys/pci/if_de.c From owner-cvs-src@FreeBSD.ORG Mon Oct 18 23:40:14 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 386F716A4CE; Mon, 18 Oct 2004 23:40:14 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 19CA643D1D; Mon, 18 Oct 2004 23:40:14 +0000 (GMT) (envelope-from thomas@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9INeDD8017587; Mon, 18 Oct 2004 23:40:13 GMT (envelope-from thomas@repoman.freebsd.org) Received: (from thomas@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9INeDqn017586; Mon, 18 Oct 2004 23:40:13 GMT (envelope-from thomas) Message-Id: <200410182340.i9INeDqn017586@repoman.freebsd.org> From: Thomas Quinot Date: Mon, 18 Oct 2004 23:40:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/etc/rc.d dumpon savecore X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 23:40:14 -0000 thomas 2004-10-18 23:40:13 UTC FreeBSD src repository Modified files: etc/rc.d dumpon savecore Log: When dumpdev is set to 'auto', and a suitable swap device is found, create a symbolic link /dev/dumpdev designating that device so savecore can find and save a previous kernel dump. Revision Changes Path 1.7 +6 -1 src/etc/rc.d/dumpon 1.9 +5 -2 src/etc/rc.d/savecore From owner-cvs-src@FreeBSD.ORG Tue Oct 19 00:55:42 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D024116A4CE; Tue, 19 Oct 2004 00:55:42 +0000 (GMT) Received: from daintree.corp.yahoo.com (daintree.corp.yahoo.com [216.145.52.172]) by mx1.FreeBSD.org (Postfix) with ESMTP id BAA8043D2F; Tue, 19 Oct 2004 00:55:37 +0000 (GMT) (envelope-from peter@yahoo-inc.com) Received: by daintree.corp.yahoo.com (Postfix, from userid 2154) id ABE0A1C754; Mon, 18 Oct 2004 17:55:37 -0700 (PDT) From: Peter Wemm To: "Andrey A. Chernov" Date: Mon, 18 Oct 2004 17:55:37 -0700 User-Agent: KMail/1.6.2 References: <200410180836.i9I8afRS060144@repoman.freebsd.org> In-Reply-To: <200410180836.i9I8afRS060144@repoman.freebsd.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200410181755.37423.peter@wemm.org> cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/gnu/lib/libreadline/readline Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 00:55:43 -0000 On Monday 18 October 2004 01:36 am, Andrey A. Chernov wrote: > ache 2004-10-18 08:36:40 UTC > > FreeBSD src repository > > Modified files: > gnu/lib/libreadline/readline Makefile > Log: > Back out termcap -> ncurses change in LDADD/DPADD > It expand functions scope too wide No. This is wrong, and a NOP change. Please back this out. The reason why is because libtermcap.so is a symlink to libncurses. And libncurses has a DT_SONAME of "libncurses.so.5". This means peter@daintree[5:51pm]~-25> objdump --all-headers /usr/lib/libtermcap.so | grep SONAME SONAME libncurses.so.5 Any dependencies will be silently "fixed" by ld, so no matter what, you end up with a DT_NEEDED of libncurses.so.5. Except that by using the wrong name, you obfuscate things. peter@daintree[5:53pm]~-30> cc -o x x.c -ltermcap peter@daintree[5:53pm]~-31> objdump --all-headers x | grep NEED NEEDED libncurses.so.5 NEEDED libc.so.5 peter@daintree[5:53pm]~-32> cc -shared -o x.so x.c -ltermcap peter@daintree[5:53pm]~-33> objdump --all-headers x.so | grep NEED NEEDED libncurses.so.5 -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 From owner-cvs-src@FreeBSD.ORG Tue Oct 19 02:39:27 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EDFE616A4CE; Tue, 19 Oct 2004 02:39:27 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CDAB343D45; Tue, 19 Oct 2004 02:39:27 +0000 (GMT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9J2dR88029844; Tue, 19 Oct 2004 02:39:27 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9J2dRF8029843; Tue, 19 Oct 2004 02:39:27 GMT (envelope-from scottl) Message-Id: <200410190239.i9J2dRF8029843@repoman.freebsd.org> From: Scott Long Date: Tue, 19 Oct 2004 02:39:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 02:39:28 -0000 scottl 2004-10-19 02:39:27 UTC FreeBSD src repository Modified files: sys/dev/em if_em.c Log: Use an alignment of 1 instead of PAGE_SIZE for the rx and tx buffer tags. Since the e1000 DMA engines hava no constraints on the alignment of buffer transfers, there is no reason to tell busdma that there is. This save a minimum of 1 malloc call per packet, which translates to eliminating 4 locks. It also means that buffers are not needlessly bounced when transfered. The end result is a 38% improvement in pps in a 4 way bridging environment. Obtained from: Sandvine, Inc. Revision Changes Path 1.48 +2 -12 src/sys/dev/em/if_em.c From owner-cvs-src@FreeBSD.ORG Tue Oct 19 02:42:49 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BA04516A4CE; Tue, 19 Oct 2004 02:42:49 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 99A3943D31; Tue, 19 Oct 2004 02:42:49 +0000 (GMT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9J2gndG029998; Tue, 19 Oct 2004 02:42:49 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9J2gn56029997; Tue, 19 Oct 2004 02:42:49 GMT (envelope-from scottl) Message-Id: <200410190242.i9J2gn56029997@repoman.freebsd.org> From: Scott Long Date: Tue, 19 Oct 2004 02:42:49 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/bge if_bge.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 02:42:50 -0000 scottl 2004-10-19 02:42:49 UTC FreeBSD src repository Modified files: sys/dev/bge if_bge.c Log: Use and alignment of 1 instead of ETHER_ALIGN for rx and tx buffers and jumbo frames. BGE hardware with the rx alignment bug will still be handled by the calls to m_adj() that already exist. m_adj() is probably better suited for this task anyways. Just as with if_em, this saves a malloc + several locks per packet and prevents unneeded data copying within busdma. Revision Changes Path 1.76 +2 -2 src/sys/dev/bge/if_bge.c From owner-cvs-src@FreeBSD.ORG Tue Oct 19 02:44:38 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A2D8716A4CE; Tue, 19 Oct 2004 02:44:38 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8350643D1D; Tue, 19 Oct 2004 02:44:38 +0000 (GMT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9J2icd2030120; Tue, 19 Oct 2004 02:44:38 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9J2icHs030119; Tue, 19 Oct 2004 02:44:38 GMT (envelope-from scottl) Message-Id: <200410190244.i9J2icHs030119@repoman.freebsd.org> From: Scott Long Date: Tue, 19 Oct 2004 02:44:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 02:44:38 -0000 scottl 2004-10-19 02:44:38 UTC FreeBSD src repository Modified files: sys/dev/em if_em.c Log: Forced commit to note that the previous change also elimates calls to bus_dmamap_create|destroy for the rx and tx descriptor buffers. Since these buffers are created with bus_dmamem_alloc(), there is no reason to also create a map, and doing so just wastes memory. Revision Changes Path 1.49 +0 -0 src/sys/dev/em/if_em.c From owner-cvs-src@FreeBSD.ORG Tue Oct 19 03:44:36 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8283D16A4CE; Tue, 19 Oct 2004 03:44:36 +0000 (GMT) Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id B208043D39; Tue, 19 Oct 2004 03:44:35 +0000 (GMT) (envelope-from ache@pobrecita.freebsd.ru) Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.13.1/8.13.1) with ESMTP id i9J3iY7n084611; Tue, 19 Oct 2004 07:44:34 +0400 (MSD) (envelope-from ache@pobrecita.freebsd.ru) Received: (from ache@localhost) by pobrecita.freebsd.ru (8.13.1/8.13.1/Submit) id i9J3iXjR084606; Tue, 19 Oct 2004 07:44:33 +0400 (MSD) (envelope-from ache) Date: Tue, 19 Oct 2004 07:44:32 +0400 From: Andrey Chernov To: Peter Wemm Message-ID: <20041019034432.GA84326@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Peter Wemm , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200410180836.i9I8afRS060144@repoman.freebsd.org> <200410181755.37423.peter@wemm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200410181755.37423.peter@wemm.org> User-Agent: Mutt/1.5.6i X-AntiVirus: checked by AntiVir Milter 1.1-beta; AVE 6.28.0.7; VDF 6.28.0.22 (host: pobrecita.freebsd.ru) cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/gnu/lib/libreadline/readline Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 03:44:36 -0000 On Mon, Oct 18, 2004 at 05:55:37PM -0700, Peter Wemm wrote: > No. This is wrong, and a NOP change. Please back this out. How NOP change can be wrong in the same time? > Any dependencies will be silently "fixed" by ld, so no matter what, you > end up with a DT_NEEDED of libncurses.so.5. I am aware of that. It is internal ld/libraries/ldconfig things application shuld NOT know about. Because it is unneded details for it. Dependences created at _applications_ level, not at (often changed) system architecture level. > Except that by using the wrong name, you obfuscate things. I use the right name - the name of library libradline really _depends_ on. The fact it becomes ncurses by chance is implementation details. It can be anything in some day, f.e. libc. Even it will be libc, there it is no reason change -ltermcap dependance to that. -- Andrey Chernov | http://ache.pp.ru/ From owner-cvs-src@FreeBSD.ORG Tue Oct 19 03:47:45 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 14D6516A4CE; Tue, 19 Oct 2004 03:47:45 +0000 (GMT) Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5031F43D2F; Tue, 19 Oct 2004 03:47:44 +0000 (GMT) (envelope-from ache@pobrecita.freebsd.ru) Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.13.1/8.13.1) with ESMTP id i9J3lgWb084666; Tue, 19 Oct 2004 07:47:42 +0400 (MSD) (envelope-from ache@pobrecita.freebsd.ru) Received: (from ache@localhost) by pobrecita.freebsd.ru (8.13.1/8.13.1/Submit) id i9J3lgfh084665; Tue, 19 Oct 2004 07:47:42 +0400 (MSD) (envelope-from ache) Date: Tue, 19 Oct 2004 07:47:42 +0400 From: Andrey Chernov To: Peter Wemm , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG Message-ID: <20041019034742.GB84326@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Peter Wemm , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200410180836.i9I8afRS060144@repoman.freebsd.org> <200410181755.37423.peter@wemm.org> <20041019034432.GA84326@nagual.pp.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041019034432.GA84326@nagual.pp.ru> User-Agent: Mutt/1.5.6i X-AntiVirus: checked by AntiVir Milter 1.1-beta; AVE 6.28.0.7; VDF 6.28.0.22 (host: pobrecita.freebsd.ru) Subject: Re: cvs commit: src/gnu/lib/libreadline/readline Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 03:47:45 -0000 On Tue, Oct 19, 2004 at 07:44:32AM +0400, Andrey Chernov wrote: > > Except that by using the wrong name, you obfuscate things. > > I use the right name - the name of library libradline really _depends_ on. > > The fact it becomes ncurses by chance is implementation details. It can be > anything in some day, f.e. libc. Even it will be libc, there it is no > reason change -ltermcap dependance to that. BTW, what is really obfuscate things, it is libreadline dependancy on libncurses, knowing the fact that libreadline never use any ncurses function. -- Andrey Chernov | http://ache.pp.ru/ From owner-cvs-src@FreeBSD.ORG Tue Oct 19 04:19:15 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D456F16A4CE; Tue, 19 Oct 2004 04:19:15 +0000 (GMT) Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1C44243D48; Tue, 19 Oct 2004 04:19:15 +0000 (GMT) (envelope-from ache@pobrecita.freebsd.ru) Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.13.1/8.13.1) with ESMTP id i9J4JCVU085333; Tue, 19 Oct 2004 08:19:12 +0400 (MSD) (envelope-from ache@pobrecita.freebsd.ru) Received: (from ache@localhost) by pobrecita.freebsd.ru (8.13.1/8.13.1/Submit) id i9J4JCWZ085328; Tue, 19 Oct 2004 08:19:12 +0400 (MSD) (envelope-from ache) Date: Tue, 19 Oct 2004 08:19:12 +0400 From: Andrey Chernov To: Peter Wemm Message-ID: <20041019041911.GA85175@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Peter Wemm , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200410180836.i9I8afRS060144@repoman.freebsd.org> <200410181755.37423.peter@wemm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200410181755.37423.peter@wemm.org> User-Agent: Mutt/1.5.6i X-AntiVirus: checked by AntiVir Milter 1.1-beta; AVE 6.28.0.7; VDF 6.28.0.22 (host: pobrecita.freebsd.ru) cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/gnu/lib/libreadline/readline Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 04:19:16 -0000 Please repeat after me few simple things: When library uses some functions from another library, and depends on it thereof, it is application level. When library renamed/symlinked/merged in/etc. to another library, or placed somewhere in the ldconfig path, it is system architecture level. Library dependences are at application level and should never know anything, when possible, about system architecture, thereby allowing later one to be changed underway painless. I wonder, why all that can be still unclear to somebody. -- Andrey Chernov | http://ache.pp.ru/ From owner-cvs-src@FreeBSD.ORG Tue Oct 19 07:03:35 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3596416A4CE; Tue, 19 Oct 2004 07:03:35 +0000 (GMT) Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5B87243D64; Tue, 19 Oct 2004 07:03:34 +0000 (GMT) (envelope-from ache@pobrecita.freebsd.ru) Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.13.1/8.13.1) with ESMTP id i9J73XWg002976; Tue, 19 Oct 2004 11:03:33 +0400 (MSD) (envelope-from ache@pobrecita.freebsd.ru) Received: (from ache@localhost) by pobrecita.freebsd.ru (8.13.1/8.13.1/Submit) id i9J73XZ7002975; Tue, 19 Oct 2004 11:03:33 +0400 (MSD) (envelope-from ache) Date: Tue, 19 Oct 2004 11:03:33 +0400 From: Andrey Chernov To: John-Mark Gurney Message-ID: <20041019070333.GA2888@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , John-Mark Gurney , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200410182306.i9IN6DDx016512@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200410182306.i9IN6DDx016512@repoman.freebsd.org> User-Agent: Mutt/1.5.6i X-AntiVirus: checked by AntiVir Milter 1.1-beta; AVE 6.28.0.7; VDF 6.28.0.22 (host: pobrecita.freebsd.ru) cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/pci if_de.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 07:03:35 -0000 On Mon, Oct 18, 2004 at 11:06:13PM +0000, John-Mark Gurney wrote: > Modified files: > sys/pci if_de.c > Log: > fix (for me) the problems where if_de gets really slow after time > (usually taking 20 seconds to transmit a packet).. no longer fall back > to only transmitting one packet (instead of the entire queue) after we > have processed the entire send queue... I have no idea why we didn't > start seeing this problem ~6 years ago when this code was introduced... Thanx, it seems it fix the problem for me too! Already running 3hours without any slowdown, but in old variant it hang to death in nearest 5-10 minutes. -- Andrey Chernov | http://ache.pp.ru/ From owner-cvs-src@FreeBSD.ORG Tue Oct 19 07:11:02 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 1033) id 2835116A4CF; Tue, 19 Oct 2004 07:11:02 +0000 (GMT) Date: Tue, 19 Oct 2004 07:11:02 +0000 From: Alexey Dokuchaev To: David O'Brien , Ruslan Ermilov , cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Message-ID: <20041019071102.GA49717@FreeBSD.org> References: <200410181719.i9IHJa9l097436@repoman.freebsd.org> <20041018173516.GB89681@ip.net.ua> <20041018174511.GA6079@dragon.nuxi.com> <20041018183118.GA80703@falcon.midgard.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20041018183118.GA80703@falcon.midgard.homeip.net> User-Agent: Mutt/1.4.1i Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 07:11:02 -0000 On Mon, Oct 18, 2004 at 08:31:18PM +0200, Erik Trulsson wrote: > I think you people need to decide to either drop support for 80386 > completely (in which case all the '#ifdef I386_CPU' and similar can go > away) or decide to keep support for it, in which case most things > should just work 'out of the box' on a 80386 (without recompilation > needed more than absolutely necessary.) I don't really see your point; what's wrong with having support for i386, just being hidden behind the need to tweak some things (i.e. to recompile a custom kernel)? Methinks that we can expect certain level of competence of someone who is willing to install FreeBSD-5 on i386, definitely being able to rebuild a kernel (which is actually pretty easy to do compared to Linux, for me at least). There's also an option of putting GENERIC-386 next to GENERIC config file in /sys/i386/conf. Just my $.02. ./danfe From owner-cvs-src@FreeBSD.ORG Tue Oct 19 07:23:54 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D500A16A4CE; Tue, 19 Oct 2004 07:23:54 +0000 (GMT) Received: from neo.samodelkin.net (samodelkin.net [195.62.0.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id B043243D31; Tue, 19 Oct 2004 07:23:53 +0000 (GMT) (envelope-from fjoe@neo.samodelkin.net) Received: by neo.samodelkin.net (Postfix, from userid 1000) id 812F81706E; Tue, 19 Oct 2004 14:23:49 +0700 (NOVST) Date: Tue, 19 Oct 2004 14:23:49 +0700 From: Max Khon To: Alexey Dokuchaev Message-ID: <20041019072349.GA28133@samodelkin.net> References: <200410181719.i9IHJa9l097436@repoman.freebsd.org> <20041018173516.GB89681@ip.net.ua> <20041018174511.GA6079@dragon.nuxi.com> <20041018183118.GA80703@falcon.midgard.homeip.net> <20041019071102.GA49717@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041019071102.GA49717@FreeBSD.org> User-Agent: Mutt/1.4.2i cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: Ruslan Ermilov cc: cvs-all@freebsd.org cc: David O'Brien Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 07:23:55 -0000 Hi! On Tue, Oct 19, 2004 at 07:11:02AM +0000, Alexey Dokuchaev wrote: > > I think you people need to decide to either drop support for 80386 > > completely (in which case all the '#ifdef I386_CPU' and similar can go > > away) or decide to keep support for it, in which case most things > > should just work 'out of the box' on a 80386 (without recompilation > > needed more than absolutely necessary.) > > I don't really see your point; what's wrong with having support for i386, > just being hidden behind the need to tweak some things (i.e. to recompile > a custom kernel)? Methinks that we can expect certain level of competence > of someone who is willing to install FreeBSD-5 on i386, definitely being > able to rebuild a kernel (which is actually pretty easy to do compared to > Linux, for me at least). There's also an option of putting GENERIC-386 > next to GENERIC config file in /sys/i386/conf. I am afraid that recompiling a kernel on i386 will require several days. /fjoe From owner-cvs-src@FreeBSD.ORG Tue Oct 19 07:31:11 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 84D1C16A4CF; Tue, 19 Oct 2004 07:31:11 +0000 (GMT) Received: from thingy.tbd.co.nz (thingy.tbd.co.nz [210.48.70.194]) by mx1.FreeBSD.org (Postfix) with ESMTP id D3B6243D3F; Tue, 19 Oct 2004 07:31:10 +0000 (GMT) (envelope-from thompsa@thingy.tbd.co.nz) Received: from thingy.tbd.co.nz (localhost [127.0.0.1]) i9J7VlAX008582; Tue, 19 Oct 2004 20:31:47 +1300 Received: (from thompsa@localhost) by thingy.tbd.co.nz (8.12.3/8.12.3/Debian-7.1) id i9J7VjWn008559; Tue, 19 Oct 2004 20:31:45 +1300 Date: Tue, 19 Oct 2004 20:31:45 +1300 From: Andrew Thompson To: Max Khon Message-ID: <20041019073145.GA29746@thingy.tbd.co.nz> References: <200410181719.i9IHJa9l097436@repoman.freebsd.org> <20041018173516.GB89681@ip.net.ua> <20041018174511.GA6079@dragon.nuxi.com> <20041018183118.GA80703@falcon.midgard.homeip.net> <20041019071102.GA49717@FreeBSD.org> <20041019072349.GA28133@samodelkin.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041019072349.GA28133@samodelkin.net> User-Agent: Mutt/1.3.28i cc: Alexey Dokuchaev cc: src-committers@freebsd.org cc: cvs-src@freebsd.org cc: David O'Brien cc: Ruslan Ermilov cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 07:31:11 -0000 On Tue, Oct 19, 2004 at 02:23:49PM +0700, Max Khon wrote: > Hi! > > On Tue, Oct 19, 2004 at 07:11:02AM +0000, Alexey Dokuchaev wrote: > > > > I think you people need to decide to either drop support for 80386 > > > completely (in which case all the '#ifdef I386_CPU' and similar can go > > > away) or decide to keep support for it, in which case most things > > > should just work 'out of the box' on a 80386 (without recompilation > > > needed more than absolutely necessary.) > > > > I don't really see your point; what's wrong with having support for i386, > > just being hidden behind the need to tweak some things (i.e. to recompile > > a custom kernel)? Methinks that we can expect certain level of competence > > of someone who is willing to install FreeBSD-5 on i386, definitely being > > able to rebuild a kernel (which is actually pretty easy to do compared to > > Linux, for me at least). There's also an option of putting GENERIC-386 > > next to GENERIC config file in /sys/i386/conf. > > I am afraid that recompiling a kernel on i386 will require several days. > Chicken and the egg. To support i386 it must be recompiled, so you would have to do it on another box anyway. From owner-cvs-src@FreeBSD.ORG Tue Oct 19 08:59:46 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0F79816A4CE; Tue, 19 Oct 2004 08:59:46 +0000 (GMT) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3AE8D43D58; Tue, 19 Oct 2004 08:59:45 +0000 (GMT) (envelope-from glebius@freebsd.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.12.11/8.12.8) with ESMTP id i9J8xgvX080015 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 19 Oct 2004 12:59:43 +0400 (MSD) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.sick.ru (8.12.11/8.12.11/Submit) id i9J8xgbK080014; Tue, 19 Oct 2004 12:59:42 +0400 (MSD) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@freebsd.org using -f Date: Tue, 19 Oct 2004 12:59:41 +0400 From: Gleb Smirnoff To: Maxime Henrion Message-ID: <20041019085941.GA79981@cell.sick.ru> References: <200410182013.i9IKDvcR002883@repoman.freebsd.org> <20041018202531.GF45249@elvis.mu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20041018202531.GF45249@elvis.mu.org> User-Agent: Mutt/1.5.6i cc: cvs-src@freebsd.org Subject: Re: cvs commit: src/sys/netgraph ng_device.c ng_device.h src/sys/modules/netgraph/device Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 08:59:46 -0000 On Mon, Oct 18, 2004 at 10:25:31PM +0200, Maxime Henrion wrote: M> Gleb Smirnoff wrote: M> > glebius 2004-10-18 20:13:57 UTC M> > M> > FreeBSD src repository M> > M> > Modified files: M> > sys/netgraph ng_device.c ng_device.h M> > sys/modules/netgraph/device Makefile M> > Log: M> [...] M> > - Use MALLOC/FREE, instead of malloc/free. M> M> This is backwards. The MALLOC() and FREE() macros are deprecated, and M> shouldn't be used in new code. These macros were used because they M> allowed an optimization when the size of the request is constant; some M> computation was done at build-time rather than at run-time (if I M> remember correctly, the computation is for getting the correct M> power-of-2 free-list). Anyways, this was with the McKusick-Karels M> memory allocator, and these macros are not appropriate anymore, they M> just obfuscate the code a bit. I thought you'd like to know :-). Thanks for this information. I did that because MALLOC/FREE is used everywhere inside of sys/netgraph. I'll probably change it back with next commit, if some more changes will appear. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE From owner-cvs-src@FreeBSD.ORG Tue Oct 19 10:16:35 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 97C7316A4CE; Tue, 19 Oct 2004 10:16:35 +0000 (GMT) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3630343D48; Tue, 19 Oct 2004 10:16:35 +0000 (GMT) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (localhost [127.0.0.1]) by fledge.watson.org (8.13.1/8.13.1) with ESMTP id i9JAGPHJ066077; Tue, 19 Oct 2004 06:16:25 -0400 (EDT) (envelope-from robert@fledge.watson.org) Received: from localhost (robert@localhost)i9JAGPIN066074; Tue, 19 Oct 2004 06:16:25 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Tue, 19 Oct 2004 06:16:25 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: Scott Long In-Reply-To: <200410190239.i9J2dRF8029843@repoman.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 10:16:35 -0000 Nice catch. I suspect we have a few more things like this floating around... Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Principal Research Scientist, McAfee Research On Tue, 19 Oct 2004, Scott Long wrote: > scottl 2004-10-19 02:39:27 UTC > > FreeBSD src repository > > Modified files: > sys/dev/em if_em.c > Log: > Use an alignment of 1 instead of PAGE_SIZE for the rx and tx buffer tags. > Since the e1000 DMA engines hava no constraints on the alignment of buffer > transfers, there is no reason to tell busdma that there is. This save a > minimum of 1 malloc call per packet, which translates to eliminating 4 locks. > It also means that buffers are not needlessly bounced when transfered. The > end result is a 38% improvement in pps in a 4 way bridging environment. > > Obtained from: Sandvine, Inc. > > Revision Changes Path > 1.48 +2 -12 src/sys/dev/em/if_em.c > From owner-cvs-src@FreeBSD.ORG Tue Oct 19 10:29:01 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2686116A4CE; Tue, 19 Oct 2004 10:29:01 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0588F43D2D; Tue, 19 Oct 2004 10:29:01 +0000 (GMT) (envelope-from le@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9JAT0RK057005; Tue, 19 Oct 2004 10:29:00 GMT (envelope-from le@repoman.freebsd.org) Received: (from le@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9JAT04O057004; Tue, 19 Oct 2004 10:29:00 GMT (envelope-from le) Message-Id: <200410191029.i9JAT04O057004@repoman.freebsd.org> From: Lukas Ertl Date: Tue, 19 Oct 2004 10:29:00 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/ata ata-card.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 10:29:01 -0000 le 2004-10-19 10:29:00 UTC FreeBSD src repository Modified files: sys/dev/ata ata-card.c Log: Return the unit number of a channel instead of a hardcoded '1' from the ATA pccard locking function. This makes pccard devices like Compact Flash cards work again. PR: kern/72805 Submitted by: James E. Flemer MFC in: 2 days Revision Changes Path 1.27 +1 -1 src/sys/dev/ata/ata-card.c From owner-cvs-src@FreeBSD.ORG Tue Oct 19 12:13:40 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9D50E16A4CE; Tue, 19 Oct 2004 12:13:40 +0000 (GMT) Received: from mailout1.pacific.net.au (mailout1.pacific.net.au [61.8.0.84]) by mx1.FreeBSD.org (Postfix) with ESMTP id E0E0F43D41; Tue, 19 Oct 2004 12:13:39 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.0.87])i9JCDcGx007936; Tue, 19 Oct 2004 22:13:38 +1000 Received: from epsplex.bde.org (katana.zip.com.au [61.8.7.246]) i9JCDZxc019611; Tue, 19 Oct 2004 22:13:36 +1000 Date: Tue, 19 Oct 2004 22:13:34 +1000 (EST) From: Bruce Evans X-X-Sender: bde@epsplex.bde.org To: "David O'Brien" In-Reply-To: <20041018190044.GA89411@hub.freebsd.org> Message-ID: <20041019211832.O1552@epsplex.bde.org> References: <200410181719.i9IHJa9l097436@repoman.freebsd.org> <20041018173516.GB89681@ip.net.ua> <20041018174511.GA6079@dragon.nuxi.com> <20041018180319.GD89681@ip.net.ua> <20041018190044.GA89411@hub.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: Ruslan Ermilov cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 12:13:40 -0000 On Mon, 18 Oct 2004, David O'Brien wrote: > On Mon, Oct 18, 2004 at 09:03:20PM +0300, Ruslan Ermilov wrote: > > You can check for the CPUTYPE="i386" for ${MACHINE_ARCH} == "i386" > > in libc/Makefile, and set I386_CPU in CFLAGS in this case. > > Taking > Revision Changes Path > 1.10 +4 -0 src/lib/libc/i386/net/htonl.S > 1.10 +4 -0 src/lib/libc/i386/net/ntohl.S > > specifically what patch do you suggest that we used in cases like this > rather than #ifdef I386_CPU". And how to use it? That is one in which > someone checks out the source and wants to build a userland that is > usable on an I386 machine. The null patch (to makefiles and *nl.S rev.1.9) should be used in cases like this. The extern interfaces to htonl() and ntohl() are little more than rarely used compatibility cruft. Such interfaces should be just be left compatible and not optimized, especially when the usual macro/inline interfaces remain unoptimized (*). In all of my slightly reduced version of the world, the extern interfaces are used in only 2 places, and both of those uses are bugs: (1) libsmb's smb_lib.h has macros which reference htonl() and ntohl(), but it doesn't include any of the headers that define or declare these functions. In RELENG_4 these functions were normally obtained as macros via namespace pollution in , but the pollution has been fixed so that in -current these functions are only (?) defined in Standard places ( and ). So smb_lib.h is broken unless the .c source file happens to include one of the standard headers. In the world, only libsmb's mbuf.c seems to not have enough includes for smb_lib.h to work. The result is a single reference to htonl() in mbuf.*o. (2) libc's a.out.h has similar bugs. It includes mainly so that the endianness macros used in are defined, but references htonl() and ntohl() in some places and doesn't define these interfaces (it only defines non-networking ones). In the world, only btxld's btxld.c seems to be affected by this. The result is a single reference to ntohl() in btxld.o (but many references to ntohl() in cpp output). This bug seems to be just bitrot in -- it uses the newer htole32() and le32toh() interfaces in many places but still uses htonl() and ntohl() in places that haven't been touched recently. (*) From the original message in this thread: % Modified files: % lib/libc/i386/net htonl.S ntohl.S % Log: % Sync with sys/i386/include/endian.h: use the single instruction 'bswap'. This doesn't actually sync with sys/i386/include/endian.h, since it uses a simple I386_CPU ifdef but endian.h uses a much larger ifdef that causes the bswap instruction to never be used outside the kernel in the usual (non-extern) case. From endian.h: % #if defined(_KERNEL) && (defined(I486_CPU) || defined(I586_CPU) || defined(I686_CPU)) && !defined(I386_CPU) % % #if defined(_KERNEL) && (defined(I486_CPU) || defined(I586_CPU) || defined(I686_CPU)) && !defined(I386_CPU) % % #define __byte_swap_int_var(x) \ % __extension__ ({ register __uint32_t __X = (x); \ % __asm ("bswap %0" : "+r" (__X)); \ % __X; }) % #else % % #define __byte_swap_int_var(x) \ % __extension__ ({ register __uint32_t __X = (x); \ % __asm ("xchgb %h0, %b0\n\trorl $16, %0\n\txchgb %h0, %b0" \ % : "+q" (__X)); \ % __X; }) % #endif So the only effect of this commit is to break i386 support for: - libsmb and btxld in the world - anything in the world that I missed - any packages or ports that are affected by the bugs in the libsmb or a.out.h or have their own wrong includes. (smb_lib.h is internal so it shouldn't affect ports. Ports and not just binary packages are affected because they won't know to define I386_CPU.) - any programs that intentially avoid using the macro versions. (There seem to be none of these in the world, so if there are any then they won't know to define I386_CPU.) Bruce From owner-cvs-src@FreeBSD.ORG Tue Oct 19 14:18:09 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 950A016A4CF; Tue, 19 Oct 2004 14:18:09 +0000 (GMT) Received: from mailhub.sweetdreamsracing.biz (mailhub.sweetdreamsracing.biz [66.92.171.106]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1DC0743D48; Tue, 19 Oct 2004 14:18:09 +0000 (GMT) (envelope-from culverk@sweetdreamsracing.biz) Received: by mailhub.sweetdreamsracing.biz (Postfix, from userid 80) id DECA561AE; Tue, 19 Oct 2004 10:17:52 -0400 (EDT) Received: from 141.156.69.109 ([141.156.69.109]) by www.sweetdreamsracing.biz (Horde) with HTTP for ; Tue, 19 Oct 2004 10:17:52 -0400 Message-ID: <20041019101752.e8ws08k8kcw8408c@www.sweetdreamsracing.biz> Date: Tue, 19 Oct 2004 10:17:52 -0400 From: Kenneth Culver To: John-Mark Gurney References: <200410182306.i9IN6DDx016512@repoman.freebsd.org> In-Reply-To: <200410182306.i9IN6DDx016512@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Internet Messaging Program (IMP) 4.0-cvs cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_de.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 14:18:09 -0000 Quoting John-Mark Gurney : > jmg 2004-10-18 23:06:13 UTC > > FreeBSD src repository > > Modified files: > sys/pci if_de.c > Log: > fix (for me) the problems where if_de gets really slow after time > (usually taking 20 seconds to transmit a packet).. no longer fall back > to only transmitting one packet (instead of the entire queue) after we > have processed the entire send queue... I have no idea why we didn't > start seeing this problem ~6 years ago when this code was introduced... > Do you get an error on boot with this device about it running in Giant. I was seeing similar problems to you and I was seeing a message at boot about this device running in Giant, so I set debug.mpsafenet to 0, and the problem went away. Ken From owner-cvs-src@FreeBSD.ORG Tue Oct 19 14:26:44 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C287016A4CE; Tue, 19 Oct 2004 14:26:44 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A3F4043D46; Tue, 19 Oct 2004 14:26:44 +0000 (GMT) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9JEQina070459; Tue, 19 Oct 2004 14:26:44 GMT (envelope-from andre@repoman.freebsd.org) Received: (from andre@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9JEQiAN070458; Tue, 19 Oct 2004 14:26:44 GMT (envelope-from andre) Message-Id: <200410191426.i9JEQiAN070458@repoman.freebsd.org> From: Andre Oppermann Date: Tue, 19 Oct 2004 14:26:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netinet6 ip6_input.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 14:26:44 -0000 andre 2004-10-19 14:26:44 UTC FreeBSD src repository Modified files: sys/netinet6 ip6_input.c Log: Be more careful to only index valid IP protocols and be more verbose with comments. Revision Changes Path 1.79 +11 -2 src/sys/netinet6/ip6_input.c From owner-cvs-src@FreeBSD.ORG Tue Oct 19 14:31:57 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1E3DA16A4D0; Tue, 19 Oct 2004 14:31:57 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F38A643D2F; Tue, 19 Oct 2004 14:31:56 +0000 (GMT) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9JEVu1v070726; Tue, 19 Oct 2004 14:31:56 GMT (envelope-from andre@repoman.freebsd.org) Received: (from andre@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9JEVuRE070725; Tue, 19 Oct 2004 14:31:56 GMT (envelope-from andre) Message-Id: <200410191431.i9JEVuRE070725@repoman.freebsd.org> From: Andre Oppermann Date: Tue, 19 Oct 2004 14:31:56 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netinet ip_fastfwd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 14:31:57 -0000 andre 2004-10-19 14:31:56 UTC FreeBSD src repository Modified files: sys/netinet ip_fastfwd.c Log: Make comments more clear. Change the order of one if() statement to check the more likely variable first. Revision Changes Path 1.22 +8 -3 src/sys/netinet/ip_fastfwd.c From owner-cvs-src@FreeBSD.ORG Tue Oct 19 14:34:13 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 96F6C16A4CF; Tue, 19 Oct 2004 14:34:13 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 75C9643D4C; Tue, 19 Oct 2004 14:34:13 +0000 (GMT) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9JEYDTI070833; Tue, 19 Oct 2004 14:34:13 GMT (envelope-from andre@repoman.freebsd.org) Received: (from andre@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9JEYDk3070832; Tue, 19 Oct 2004 14:34:13 GMT (envelope-from andre) Message-Id: <200410191434.i9JEYDk3070832@repoman.freebsd.org> From: Andre Oppermann Date: Tue, 19 Oct 2004 14:34:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netinet in_pcb.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 14:34:13 -0000 andre 2004-10-19 14:34:13 UTC FreeBSD src repository Modified files: sys/netinet in_pcb.h Log: Add a macro for the destruction of INP_INFO_LOCK's used by loadable modules. Revision Changes Path 1.77 +1 -0 src/sys/netinet/in_pcb.h From owner-cvs-src@FreeBSD.ORG Tue Oct 19 14:44:40 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DC92C16A4CF for ; Tue, 19 Oct 2004 14:44:40 +0000 (GMT) Received: from harmony.village.org (rover.village.org [168.103.84.182]) by mx1.FreeBSD.org (Postfix) with ESMTP id 895DD43D48 for ; Tue, 19 Oct 2004 14:44:40 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (harmony.village.org [10.0.0.6]) by harmony.village.org (8.13.1/8.13.1) with ESMTP id i9JEh8gO011869; Tue, 19 Oct 2004 08:43:09 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Tue, 19 Oct 2004 08:43:24 -0600 (MDT) Message-Id: <20041019.084324.106215221.imp@bsdimp.com> To: andy@fud.org.nz From: "M. Warner Losh" In-Reply-To: <20041019073145.GA29746@thingy.tbd.co.nz> References: <20041019071102.GA49717@FreeBSD.org> <20041019072349.GA28133@samodelkin.net> <20041019073145.GA29746@thingy.tbd.co.nz> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: danfe@freebsd.org cc: src-committers@freebsd.org cc: cvs-src@freebsd.org cc: cvs-all@freebsd.org cc: ru@freebsd.org cc: obrien@freebsd.org cc: fjoe@samodelkin.net Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 14:44:41 -0000 In message: <20041019073145.GA29746@thingy.tbd.co.nz> Andrew Thompson writes: : > I am afraid that recompiling a kernel on i386 will require several days. : : Chicken and the egg. To support i386 it must be recompiled, so you would : have to do it on another box anyway. The only people that will seriously want to use i386 these days are the folks that build embedded systems. Those you have to build on some host then deploy to the target system. There are some benefits to having i386 in the tree. However, there are also a number of different places in the tree where things are sub-optimal because we still have support for i386 in there. The desire to remove them is to make FreeBSD go faster on more modern hardware. Warner From owner-cvs-src@FreeBSD.ORG Tue Oct 19 15:13:30 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A119116A4D4; Tue, 19 Oct 2004 15:13:30 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 79A3E43D45; Tue, 19 Oct 2004 15:13:30 +0000 (GMT) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9JFDU5F072177; Tue, 19 Oct 2004 15:13:30 GMT (envelope-from andre@repoman.freebsd.org) Received: (from andre@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9JFDUbf072176; Tue, 19 Oct 2004 15:13:30 GMT (envelope-from andre) Message-Id: <200410191513.i9JFDUbf072176@repoman.freebsd.org> From: Andre Oppermann Date: Tue, 19 Oct 2004 15:13:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/sys protosw.h src/sys/kern uipc_domain.c uipc_socket2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 15:13:30 -0000 andre 2004-10-19 15:13:30 UTC FreeBSD src repository Modified files: sys/sys protosw.h sys/kern uipc_domain.c uipc_socket2.c Log: Support for dynamically loadable and unloadable protocols within existing protocol families. The protosw[] array of any particular protocol family ("domain") is of fixed size defined at compile time. This made it impossible to dynamically add or remove any protocols to or from it. We work around this by introducing so called SPACER's which are embedded into the protosw[] array at compile time. The SPACER's have a special protocol number (32767) to indicate the fact that they are SPACER's but are otherwise NULL. Only as many protocols can be dynamically loaded as SPACER's are provided in the protosw[] structure. The pr_usrreqs structure is treated more special and contains pointers to dummy functions only returning EOPNOTSUPP. This is needed because the use of those functions pointers is usually not checked within the kernel because until now it was assumed to be a valid function pointer. Instead of fixing all potential callers we just return a proper error code. Two new functions provide a clean API to register and unregister a protocol. The register function expects a pointer to a valid and complete struct protosw including a pointer to struct pru_usrreqs provided by the caller. Upon successful registration the pr_init() function will be called to finish initialization of the protocol. The unregister function restores the SPACER in place of the protocol again. It is the responseability of the caller to ensure proper closing of all sockets and freeing of memory allocation by the unloading protocol. sys/protosw.h o Define generic PROTO_SPACER to be 32767 o Prototypes for all pru_*_notsupp() functions o Prototypes for pf_proto_[un]register() functions kern/uipc_domain.c o Global struct pr_usrreqs nousrreqs containing valid pointers to the pru_*_notsupp() functions o New functions pf_proto_[un]register() kern/uipc_socket2.c o New functions bodies for all pru_*_notsupp() functions Revision Changes Path 1.37 +136 -2 src/sys/kern/uipc_domain.c 1.138 +78 -1 src/sys/kern/uipc_socket2.c 1.44 +33 -0 src/sys/sys/protosw.h From owner-cvs-src@FreeBSD.ORG Tue Oct 19 15:28:10 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 62B6016A4CE; Tue, 19 Oct 2004 15:28:10 +0000 (GMT) Received: from ebb.errno.com (ebb.errno.com [66.127.85.87]) by mx1.FreeBSD.org (Postfix) with ESMTP id 18F9643D48; Tue, 19 Oct 2004 15:28:10 +0000 (GMT) (envelope-from sam@errno.com) Received: from [66.127.85.93] ([66.127.85.93]) (authenticated bits=0) by ebb.errno.com (8.12.9/8.12.6) with ESMTP id i9JFS9Wi040723 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 19 Oct 2004 08:28:09 -0700 (PDT) (envelope-from sam@errno.com) Message-ID: <417532A2.9000901@errno.com> Date: Tue, 19 Oct 2004 08:28:34 -0700 From: Sam Leffler Organization: Errno Consulting User-Agent: Mozilla Thunderbird 0.8 (Macintosh/20040913) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Andre Oppermann References: <200410191513.i9JFDUbf072176@repoman.freebsd.org> In-Reply-To: <200410191513.i9JFDUbf072176@repoman.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys protosw.h src/sys/kern uipc_domain.c uipc_socket2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 15:28:10 -0000 Andre Oppermann wrote: > andre 2004-10-19 15:13:30 UTC > > FreeBSD src repository > > Modified files: > sys/sys protosw.h > sys/kern uipc_domain.c uipc_socket2.c > Log: > Support for dynamically loadable and unloadable protocols within existing protocol > families. > I don't recall seeing this posted anywhere for comment. I have some concerns about this general topic and this code seems incomplete (e.g. I see no locking). Sam From owner-cvs-src@FreeBSD.ORG Tue Oct 19 15:30:47 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 933A216A4CE; Tue, 19 Oct 2004 15:30:47 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 71E3943D49; Tue, 19 Oct 2004 15:30:47 +0000 (GMT) (envelope-from bms@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9JFUlRw072853; Tue, 19 Oct 2004 15:30:47 GMT (envelope-from bms@repoman.freebsd.org) Received: (from bms@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9JFUlCw072852; Tue, 19 Oct 2004 15:30:47 GMT (envelope-from bms) Message-Id: <200410191530.i9JFUlCw072852@repoman.freebsd.org> From: Bruce M Simpson Date: Tue, 19 Oct 2004 15:30:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/pci if_vr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 15:30:47 -0000 bms 2004-10-19 15:30:47 UTC FreeBSD src repository Modified files: sys/pci if_vr.c Log: Detach the Rhine completely on shutdown, rather than merely stopping it as the original logic did. This fixes a race with vr_intr() which was masked on UP systems and manifested on SMP systems. PR: kern/62889 MFC after: 1 day Revision Changes Path 1.95 +1 -3 src/sys/pci/if_vr.c From owner-cvs-src@FreeBSD.ORG Tue Oct 19 15:39:09 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EBD7A16A4CE for ; Tue, 19 Oct 2004 15:39:09 +0000 (GMT) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1257C43D39 for ; Tue, 19 Oct 2004 15:39:09 +0000 (GMT) (envelope-from andre@freebsd.org) Received: (qmail 59518 invoked from network); 19 Oct 2004 15:38:07 -0000 Received: from unknown (HELO freebsd.org) ([62.48.0.53]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 19 Oct 2004 15:38:07 -0000 Message-ID: <41753522.1E39FEAE@freebsd.org> Date: Tue, 19 Oct 2004 17:39:14 +0200 From: Andre Oppermann X-Mailer: Mozilla 4.8 [en] (Windows NT 5.0; U) X-Accept-Language: en MIME-Version: 1.0 To: Sam Leffler References: <200410191513.i9JFDUbf072176@repoman.freebsd.org> <417532A2.9000901@errno.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys protosw.h src/sys/kern uipc_domain.cuipc_socket2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 15:39:10 -0000 Sam Leffler wrote: > > Andre Oppermann wrote: > > andre 2004-10-19 15:13:30 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/sys protosw.h > > sys/kern uipc_domain.c uipc_socket2.c > > Log: > > Support for dynamically loadable and unloadable protocols within existing protocol > > families. > > > > I don't recall seeing this posted anywhere for comment. I have some > concerns about this general topic and this code seems incomplete (e.g. I > see no locking). Locking is not needed because there are no dead moments in transitioning from unregistered to registered and back. All calls to any of the protocol specific functions will return a valid result (even if it is only EOPNOTSUPP). There is no list manipulation going on. The caller of the function is required to assure that no dangeling sockets, references or memory allocations are left behind after unregistering. It's simply impossible to solve otherwise. For IPDIVERT which I have converted this works very well (it will simply refuse to unload if a divert socket is open). What remaining concerns do you have? -- Andre From owner-cvs-src@FreeBSD.ORG Tue Oct 19 15:45:57 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8E7BC16A4CE; Tue, 19 Oct 2004 15:45:57 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 81DFB43D4C; Tue, 19 Oct 2004 15:45:57 +0000 (GMT) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9JFjvfa073379; Tue, 19 Oct 2004 15:45:57 GMT (envelope-from andre@repoman.freebsd.org) Received: (from andre@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9JFjvGS073378; Tue, 19 Oct 2004 15:45:57 GMT (envelope-from andre) Message-Id: <200410191545.i9JFjvGS073378@repoman.freebsd.org> From: Andre Oppermann Date: Tue, 19 Oct 2004 15:45:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netinet ip_input.c ip_var.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 15:45:57 -0000 andre 2004-10-19 15:45:57 UTC FreeBSD src repository Modified files: sys/netinet ip_input.c ip_var.h Log: Support for dynamically loadable and unloadable IP protocols in the ipmux. With pr_proto_register() it has become possible to dynamically load protocols within the PF_INET domain. However the PF_INET domain has a second important structure called ip_protox[] that is derived from the 'struct protosw inetsw[]' and takes care of the de-multiplexing of the various protocols that ride on top of IP packets. The functions ipproto_[un]register() allow to dynamically adjust the ip_protox[] array mux in a consistent and easy way. To register a protocol within ip_protox[] the existence of a corresponding and matching protocol definition in inetsw[] is required. The function does not allow to overwrite an already registered protocol. The unregister function simply replaces the mux slot with the default index pointer to IPPROTO_RAW as it was previously. Revision Changes Path 1.292 +62 -1 src/sys/netinet/ip_input.c 1.92 +2 -0 src/sys/netinet/ip_var.h From owner-cvs-src@FreeBSD.ORG Tue Oct 19 15:47:24 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9564916A538; Tue, 19 Oct 2004 15:47:22 +0000 (GMT) Received: from arginine.spc.org (arginine.spc.org [195.206.69.236]) by mx1.FreeBSD.org (Postfix) with ESMTP id 484AE43D31; Tue, 19 Oct 2004 15:47:22 +0000 (GMT) (envelope-from bms@spc.org) Received: from localhost (localhost [127.0.0.1]) by arginine.spc.org (Postfix) with ESMTP id 7BF796520C; Tue, 19 Oct 2004 16:47:21 +0100 (BST) Received: from arginine.spc.org ([127.0.0.1]) by localhost (arginine.spc.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 31995-01-12; Tue, 19 Oct 2004 16:47:21 +0100 (BST) Received: from empiric.dek.spc.org (dhcp120.icir.org [192.150.187.120]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by arginine.spc.org (Postfix) with ESMTP id 05BE2651EE; Tue, 19 Oct 2004 16:47:21 +0100 (BST) Received: by empiric.dek.spc.org (Postfix, from userid 1001) id 195D9615E; Tue, 19 Oct 2004 08:47:15 -0700 (PDT) Date: Tue, 19 Oct 2004 08:47:15 -0700 From: Bruce M Simpson To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <20041019154715.GH86472@dhcp120.icir.org> Mail-Followup-To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200410191530.i9JFUlCw072852@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200410191530.i9JFUlCw072852@repoman.freebsd.org> Subject: Re: cvs commit: src/sys/pci if_vr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 15:47:25 -0000 On Tue, Oct 19, 2004 at 03:30:47PM +0000, Bruce M Simpson wrote: > Log: > Detach the Rhine completely on shutdown, rather than merely stopping it > as the original logic did. This fixes a race with vr_intr() which was > masked on UP systems and manifested on SMP systems. Submitted by: Russell Francis From owner-cvs-src@FreeBSD.ORG Tue Oct 19 15:49:52 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 23F2216A4CE; Tue, 19 Oct 2004 15:49:52 +0000 (GMT) Received: from arginine.spc.org (arginine.spc.org [195.206.69.236]) by mx1.FreeBSD.org (Postfix) with ESMTP id CFB6243D5E; Tue, 19 Oct 2004 15:49:51 +0000 (GMT) (envelope-from bms@spc.org) Received: from localhost (localhost [127.0.0.1]) by arginine.spc.org (Postfix) with ESMTP id 186226520C; Tue, 19 Oct 2004 16:49:51 +0100 (BST) Received: from arginine.spc.org ([127.0.0.1]) by localhost (arginine.spc.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 32596-01-3; Tue, 19 Oct 2004 16:49:50 +0100 (BST) Received: from empiric.dek.spc.org (dhcp120.icir.org [192.150.187.120]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by arginine.spc.org (Postfix) with ESMTP id 3643D651EE; Tue, 19 Oct 2004 16:49:50 +0100 (BST) Received: by empiric.dek.spc.org (Postfix, from userid 1001) id 774CE615E; Tue, 19 Oct 2004 08:49:43 -0700 (PDT) Date: Tue, 19 Oct 2004 08:49:43 -0700 From: Bruce M Simpson To: Scott Long Message-ID: <20041019154942.GI86472@dhcp120.icir.org> Mail-Followup-To: Scott Long , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, xorp-dev@xorp.org References: <200410190239.i9J2dRF8029843@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200410190239.i9J2dRF8029843@repoman.freebsd.org> cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: xorp-dev@xorp.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 15:49:52 -0000 On Tue, Oct 19, 2004 at 02:39:27AM +0000, Scott Long wrote: > It also means that buffers are not needlessly bounced when transfered. The > end result is a 38% improvement in pps in a 4 way bridging environment. Excellent. Impressive. Less Frags. (We'll find this very useful indeed...) Thanks again, BMS From owner-cvs-src@FreeBSD.ORG Tue Oct 19 15:58:22 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C063416A4CE; Tue, 19 Oct 2004 15:58:22 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9F28543D5E; Tue, 19 Oct 2004 15:58:22 +0000 (GMT) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9JFwMp6073983; Tue, 19 Oct 2004 15:58:22 GMT (envelope-from andre@repoman.freebsd.org) Received: (from andre@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9JFwMG8073982; Tue, 19 Oct 2004 15:58:22 GMT (envelope-from andre) Message-Id: <200410191558.i9JFwMG8073982@repoman.freebsd.org> From: Andre Oppermann Date: Tue, 19 Oct 2004 15:58:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netinet in_proto.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 15:58:23 -0000 andre 2004-10-19 15:58:22 UTC FreeBSD src repository Modified files: sys/netinet in_proto.c Log: Make use of the PROTO_SPACER functionality for dynamically loadable protocols in inetsw[] and define initially eight spacer slots. Remove conflicting declaration 'struct pr_usrreqs nousrreqs'. It is now declared and initialized in kern/uipc_domain.c. Revision Changes Path 1.74 +19 -2 src/sys/netinet/in_proto.c From owner-cvs-src@FreeBSD.ORG Tue Oct 19 16:27:27 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6E7B516A4E6; Tue, 19 Oct 2004 16:27:27 +0000 (GMT) Received: from portpc-design.spb.ru (ns2.portpc-design.spb.ru [195.161.118.232]) by mx1.FreeBSD.org (Postfix) with ESMTP id 05F1943D31; Tue, 19 Oct 2004 16:27:26 +0000 (GMT) (envelope-from mcsi@mcsi.pp.ru) Received: from [83.237.13.180] (ppp83-237-13-180.pppoe.mtu-net.ru [83.237.13.180]) (authenticated bits=0) by portpc-design.spb.ru (8.13.1/8.13.1) with ESMTP id i9JGRLhF020082; Tue, 19 Oct 2004 20:27:21 +0400 (MSD) (envelope-from mcsi@mcsi.pp.ru) Message-ID: <41754063.5030908@mcsi.pp.ru> Date: Tue, 19 Oct 2004 20:27:15 +0400 From: Maxim Maximov User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.2) Gecko/20040929 X-Accept-Language: ru, en-us, en MIME-Version: 1.0 To: Bruce M Simpson References: <200410191530.i9JFUlCw072852@repoman.freebsd.org> In-Reply-To: <200410191530.i9JFUlCw072852@repoman.freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/pci if_vr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 16:27:27 -0000 Bruce M Simpson wrote: > bms 2004-10-19 15:30:47 UTC > > FreeBSD src repository > > Modified files: > sys/pci if_vr.c > Log: > Detach the Rhine completely on shutdown, rather than merely stopping it > as the original logic did. This fixes a race with vr_intr() which was > masked on UP systems and manifested on SMP systems. > > PR: kern/62889 > MFC after: 1 day > Kernel build fails: cc -c -O -pipe -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -std=c99 -g -nostdinc -I- -I. -I/usr/src/sys -I/usr/src/sys/contrib/dev/acpica -I/usr/src/sys/contrib/altq -I/usr/src/sys/contrib/ipfilter -I/usr/src/sys/contrib/pf -I/usr/src/sys/contrib/dev/ath -I/usr/src/sys/contrib/dev/ath/freebsd -I/usr/src/sys/contrib/ngatm -D_KERNEL -include opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -mno-align-long-strings -mpreferred-stack-boundary=2 -ffreestanding -Werror /usr/src/sys/pci/if_vr.c /usr/src/sys/pci/if_vr.c: In function `vr_shutdown': /usr/src/sys/pci/if_vr.c:1695: warning: passing arg 1 of `vr_detach' from incompatible pointer type *** Error code 1 Stop in /usr/obj/usr/src/sys/ULTRA. *** Error code 1 Stop in /usr/src. *** Error code 1 Stop in /usr/src. Exit 1 -- Maxim Maximov From owner-cvs-src@FreeBSD.ORG Tue Oct 19 16:47:53 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EFFE016A4CE; Tue, 19 Oct 2004 16:47:53 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D0E9643D46; Tue, 19 Oct 2004 16:47:53 +0000 (GMT) (envelope-from bms@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9JGlr1X082092; Tue, 19 Oct 2004 16:47:53 GMT (envelope-from bms@repoman.freebsd.org) Received: (from bms@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9JGlrHO082091; Tue, 19 Oct 2004 16:47:53 GMT (envelope-from bms) Message-Id: <200410191647.i9JGlrHO082091@repoman.freebsd.org> From: Bruce M Simpson Date: Tue, 19 Oct 2004 16:47:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/pci if_vr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 16:47:54 -0000 bms 2004-10-19 16:47:53 UTC FreeBSD src repository Modified files: sys/pci if_vr.c Log: Fix typo sc -> dev. Revision Changes Path 1.96 +1 -1 src/sys/pci/if_vr.c From owner-cvs-src@FreeBSD.ORG Tue Oct 19 16:48:27 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CAE5E16A4CE; Tue, 19 Oct 2004 16:48:27 +0000 (GMT) Received: from arginine.spc.org (arginine.spc.org [195.206.69.236]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2A09543D1D; Tue, 19 Oct 2004 16:48:27 +0000 (GMT) (envelope-from bms@spc.org) Received: from localhost (localhost [127.0.0.1]) by arginine.spc.org (Postfix) with ESMTP id 9332B6530A; Tue, 19 Oct 2004 17:48:25 +0100 (BST) Received: from arginine.spc.org ([127.0.0.1]) by localhost (arginine.spc.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 33229-03-12; Tue, 19 Oct 2004 17:48:25 +0100 (BST) Received: from empiric.dek.spc.org (dhcp120.icir.org [192.150.187.120]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by arginine.spc.org (Postfix) with ESMTP id B77DA65219; Tue, 19 Oct 2004 17:48:24 +0100 (BST) Received: by empiric.dek.spc.org (Postfix, from userid 1001) id C0B96615D; Tue, 19 Oct 2004 09:48:18 -0700 (PDT) Date: Tue, 19 Oct 2004 09:48:18 -0700 From: Bruce M Simpson To: Maxim Maximov Message-ID: <20041019164818.GL86472@dhcp120.icir.org> Mail-Followup-To: Maxim Maximov , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org References: <200410191530.i9JFUlCw072852@repoman.freebsd.org> <41754063.5030908@mcsi.pp.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <41754063.5030908@mcsi.pp.ru> cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/pci if_vr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 16:48:27 -0000 On Tue, Oct 19, 2004 at 08:27:15PM +0400, Maxim Maximov wrote: > /usr/src/sys/pci/if_vr.c: In function `vr_shutdown': > /usr/src/sys/pci/if_vr.c:1695: warning: passing arg 1 of `vr_detach' Hold the front page! Typo. Fix committed. From owner-cvs-src@FreeBSD.ORG Tue Oct 19 17:25:34 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A1D4416A4CE; Tue, 19 Oct 2004 17:25:34 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8039543D5E; Tue, 19 Oct 2004 17:25:34 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9JHPYFg083409; Tue, 19 Oct 2004 17:25:34 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9JHPYr6083408; Tue, 19 Oct 2004 17:25:34 GMT (envelope-from obrien) Message-Id: <200410191725.i9JHPYr6083408@repoman.freebsd.org> From: "David E. O'Brien" Date: Tue, 19 Oct 2004 17:25:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/mk bsd.cpu.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 17:25:34 -0000 obrien 2004-10-19 17:25:34 UTC FreeBSD src repository Modified files: share/mk bsd.cpu.mk Log: Define "I386_CPU" if CPUTYPE is 'i386'. Userland bits can check for "I386_CPU" to determine if they should select code paths suitable for the 80386 CPU. Suggested by: ru Revision Changes Path 1.45 +3 -0 src/share/mk/bsd.cpu.mk From owner-cvs-src@FreeBSD.ORG Tue Oct 19 17:32:56 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C185616A4CE; Tue, 19 Oct 2004 17:32:56 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A38AF43D48; Tue, 19 Oct 2004 17:32:56 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9JHWuRw083696; Tue, 19 Oct 2004 17:32:56 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9JHWuGg083695; Tue, 19 Oct 2004 17:32:56 GMT (envelope-from ru) Message-Id: <200410191732.i9JHWuGg083695@repoman.freebsd.org> From: Ruslan Ermilov Date: Tue, 19 Oct 2004 17:32:56 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/etc/mtree BSD.usr.dist X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 17:32:56 -0000 ru 2004-10-19 17:32:56 UTC FreeBSD src repository Modified files: etc/mtree BSD.usr.dist Log: Apply README guidelines (no tabs). Revision Changes Path 1.310 +2 -2 src/etc/mtree/BSD.usr.dist From owner-cvs-src@FreeBSD.ORG Tue Oct 19 17:39:15 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7A35516A4CE; Tue, 19 Oct 2004 17:39:15 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5A34D43D3F; Tue, 19 Oct 2004 17:39:15 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9JHdFjt083909; Tue, 19 Oct 2004 17:39:15 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9JHdFC6083908; Tue, 19 Oct 2004 17:39:15 GMT (envelope-from obrien) Message-Id: <200410191739.i9JHdFC6083908@repoman.freebsd.org> From: "David E. O'Brien" Date: Tue, 19 Oct 2004 17:39:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/contrib/smbfs/lib/smb nls.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 17:39:15 -0000 obrien 2004-10-19 17:39:15 UTC FreeBSD src repository Modified files: contrib/smbfs/lib/smb nls.c Log: Size matters. Correctly use a size_t so 64-bit hosts can mount SMB FS's when using character set conversions. Also include POSIX vs. BSD now that we've broken traditional BSD behavior [and compatibility with our BSD brethren]. PR: 72445 Submitted by: Vladimir Nechitailo Patch by: Stasys Smailys Revision Changes Path 1.2 +35 -10 src/contrib/smbfs/lib/smb/nls.c From owner-cvs-src@FreeBSD.ORG Tue Oct 19 17:43:08 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 67E4616A4D0 for ; Tue, 19 Oct 2004 17:43:08 +0000 (GMT) Received: from mail5.speakeasy.net (mail5.speakeasy.net [216.254.0.205]) by mx1.FreeBSD.org (Postfix) with ESMTP id E417F43D58 for ; Tue, 19 Oct 2004 17:43:07 +0000 (GMT) (envelope-from jmg@hydrogen.funkthat.com) Received: (qmail 4549 invoked from network); 19 Oct 2004 17:43:07 -0000 Received: from gate.funkthat.com (HELO hydrogen.funkthat.com) ([69.17.45.168]) (envelope-sender ) by mail5.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 19 Oct 2004 17:43:07 -0000 Received: from hydrogen.funkthat.com (inaxyd@localhost.funkthat.com [127.0.0.1])i9JHh6lb067723; Tue, 19 Oct 2004 10:43:07 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.12.10/8.12.10/Submit) id i9JHh670067722; Tue, 19 Oct 2004 10:43:06 -0700 (PDT) Date: Tue, 19 Oct 2004 10:43:06 -0700 From: John-Mark Gurney To: Kenneth Culver Message-ID: <20041019174306.GK22681@funkthat.com> References: <200410182306.i9IN6DDx016512@repoman.freebsd.org> <20041019101752.e8ws08k8kcw8408c@www.sweetdreamsracing.biz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041019101752.e8ws08k8kcw8408c@www.sweetdreamsracing.biz> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 4.2-RELEASE i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_de.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: John-Mark Gurney List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 17:43:08 -0000 Kenneth Culver wrote this message on Tue, Oct 19, 2004 at 10:17 -0400: > Quoting John-Mark Gurney : > > >jmg 2004-10-18 23:06:13 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/pci if_de.c > > Log: > > fix (for me) the problems where if_de gets really slow after time > > (usually taking 20 seconds to transmit a packet).. no longer fall back > > to only transmitting one packet (instead of the entire queue) after we > > have processed the entire send queue... I have no idea why we didn't > > start seeing this problem ~6 years ago when this code was introduced... > > Do you get an error on boot with this device about it running in Giant. I > was > seeing similar problems to you and I was seeing a message at boot about this > device running in Giant, so I set debug.mpsafenet to 0, and the problem went > away. yes, I do: de0: port 0xd800-0xd87f mem 0xe8000000-0xe800007f irq 10 at device 9.0 on pci0 de0: [GIANT-LOCKED] de0: 21140A [10-100Mb/s] pass 2.2 de0: Ethernet address: 00:c0:f0:1f:21:f9 de0: if_start running deferred for Giant but even with those messages about Giant, we did find that the interface ioctl was being called w/o Giant... also, the warning about Giant mean that the network subsystem is suppose to call all of the driver's routines w/ Giant held to appear as if debug.mpsafenet has been set to 0.. I have a patch that addes some Giant requireds, but they can't be commited till the ioctl problem is fixed... If you are interested in tracking down the bug, I'll be more than happy to review and commit any changes... The driver needs to be both locked and busdma'ified... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not." From owner-cvs-src@FreeBSD.ORG Tue Oct 19 17:44:31 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9B5B416A4CE; Tue, 19 Oct 2004 17:44:31 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7A1F943D5C; Tue, 19 Oct 2004 17:44:31 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9JHiVYl084162; Tue, 19 Oct 2004 17:44:31 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9JHiV6X084161; Tue, 19 Oct 2004 17:44:31 GMT (envelope-from obrien) Message-Id: <200410191744.i9JHiV6X084161@repoman.freebsd.org> From: "David E. O'Brien" Date: Tue, 19 Oct 2004 17:44:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/contrib/smbfs/lib/smb kiconv.c mbuf.c rcfile.c rq.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 17:44:31 -0000 obrien 2004-10-19 17:44:31 UTC FreeBSD src repository Modified files: contrib/smbfs/lib/smb kiconv.c mbuf.c rcfile.c rq.c Log: + Get prototypes for libc functions. + Use the correct printf format for size_t. Revision Changes Path 1.3 +1 -0 src/contrib/smbfs/lib/smb/kiconv.c 1.2 +4 -0 src/contrib/smbfs/lib/smb/mbuf.c 1.2 +5 -1 src/contrib/smbfs/lib/smb/rcfile.c 1.3 +1 -1 src/contrib/smbfs/lib/smb/rq.c From owner-cvs-src@FreeBSD.ORG Tue Oct 19 17:58:10 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0821D16A4D1 for ; Tue, 19 Oct 2004 17:58:10 +0000 (GMT) Received: from mail5.speakeasy.net (mail5.speakeasy.net [216.254.0.205]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8770243D6A for ; Tue, 19 Oct 2004 17:58:09 +0000 (GMT) (envelope-from jmg@hydrogen.funkthat.com) Received: (qmail 1591 invoked from network); 19 Oct 2004 17:58:09 -0000 Received: from gate.funkthat.com (HELO hydrogen.funkthat.com) ([69.17.45.168]) (envelope-sender ) by mail5.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 19 Oct 2004 17:58:09 -0000 Received: from hydrogen.funkthat.com (wdixgp@localhost.funkthat.com [127.0.0.1])i9JHw8lb068197; Tue, 19 Oct 2004 10:58:08 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.12.10/8.12.10/Submit) id i9JHw7xe068196; Tue, 19 Oct 2004 10:58:07 -0700 (PDT) Date: Tue, 19 Oct 2004 10:58:07 -0700 From: John-Mark Gurney To: Andre Oppermann Message-ID: <20041019175807.GM22681@funkthat.com> References: <200410191513.i9JFDUbf072176@repoman.freebsd.org> <417532A2.9000901@errno.com> <41753522.1E39FEAE@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <41753522.1E39FEAE@freebsd.org> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 4.2-RELEASE i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html cc: Sam Leffler cc: src-committers@freebsd.org cc: cvs-all@freebsd.org cc: cvs-src@freebsd.org Subject: Re: cvs commit: src/sys/sys protosw.h src/sys/kern uipc_domain.cuipc_socket2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: John-Mark Gurney List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 17:58:10 -0000 Andre Oppermann wrote this message on Tue, Oct 19, 2004 at 17:39 +0200: > > > Modified files: > > > sys/sys protosw.h > > > sys/kern uipc_domain.c uipc_socket2.c > > > Log: > > > Support for dynamically loadable and unloadable protocols within existing protocol > > > families. > > > > > > > I don't recall seeing this posted anywhere for comment. I have some > > concerns about this general topic and this code seems incomplete (e.g. I > > see no locking). > > Locking is not needed because there are no dead moments in transitioning > from unregistered to registered and back. All calls to any of the protocol > specific functions will return a valid result (even if it is only EOPNOTSUPP). > There is no list manipulation going on. > > The caller of the function is required to assure that no dangeling sockets, > references or memory allocations are left behind after unregistering. It's > simply impossible to solve otherwise. For IPDIVERT which I have converted > this works very well (it will simply refuse to unload if a divert socket is > open). > > What remaining concerns do you have? I don't see any GIANT_REQUIRE, or locking around adding a new protocol.. This means there could be a race where two modules loading a protocol get assigned the same slot... I had to do this with the kqueue subsystem when dynamicly loading filters.. -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not." From owner-cvs-src@FreeBSD.ORG Tue Oct 19 18:02:55 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8815916A4CE; Tue, 19 Oct 2004 18:02:55 +0000 (GMT) Received: from mailhub.sweetdreamsracing.biz (mailhub.sweetdreamsracing.biz [66.92.171.106]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2B06143D1F; Tue, 19 Oct 2004 18:02:55 +0000 (GMT) (envelope-from culverk@sweetdreamsracing.biz) Received: by mailhub.sweetdreamsracing.biz (Postfix, from userid 80) id 49A6561AB; Tue, 19 Oct 2004 14:02:37 -0400 (EDT) Received: from 141.156.69.109 ([141.156.69.109]) by www.sweetdreamsracing.biz (Horde) with HTTP for ; Tue, 19 Oct 2004 14:02:37 -0400 Message-ID: <20041019140237.60488wg8oss88ocg@www.sweetdreamsracing.biz> Date: Tue, 19 Oct 2004 14:02:37 -0400 From: Kenneth Culver To: John-Mark Gurney References: <200410182306.i9IN6DDx016512@repoman.freebsd.org> <20041019101752.e8ws08k8kcw8408c@www.sweetdreamsracing.biz> <20041019174306.GK22681@funkthat.com> In-Reply-To: <20041019174306.GK22681@funkthat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Internet Messaging Program (IMP) 4.0-cvs cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_de.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 18:02:55 -0000 Quoting John-Mark Gurney : > Kenneth Culver wrote this message on Tue, Oct 19, 2004 at 10:17 -0400: >> Quoting John-Mark Gurney : >> >> >jmg 2004-10-18 23:06:13 UTC >> > >> > FreeBSD src repository >> > >> > Modified files: >> > sys/pci if_de.c >> > Log: >> > fix (for me) the problems where if_de gets really slow after time >> > (usually taking 20 seconds to transmit a packet).. no longer fall back >> > to only transmitting one packet (instead of the entire queue) after we >> > have processed the entire send queue... I have no idea why we didn't >> > start seeing this problem ~6 years ago when this code was introduced... >> >> Do you get an error on boot with this device about it running in >> Giant. I was >> seeing similar problems to you and I was seeing a message at boot about this >> device running in Giant, so I set debug.mpsafenet to 0, and the problem went >> away. > > yes, I do: > de0: port 0xd800-0xd87f mem > 0xe8000000-0xe800007f > irq 10 at device 9.0 on pci0 > de0: [GIANT-LOCKED] > de0: 21140A [10-100Mb/s] pass 2.2 > de0: Ethernet address: 00:c0:f0:1f:21:f9 > de0: if_start running deferred for Giant > > but even with those messages about Giant, we did find that the interface > ioctl was being called w/o Giant... also, the warning about Giant > mean that the network subsystem is suppose to call all of the driver's > routines w/ Giant held to appear as if debug.mpsafenet has been set to 0.. > > I have a patch that addes some Giant requireds, but they can't be commited > till the ioctl problem is fixed... > > If you are interested in tracking down the bug, I'll be more than happy > to review and commit any changes... The driver needs to be both locked > and busdma'ified... > Well the machine I'm using this interface on is in a production machine. If I can find another card and put it in my personal machine I'll see if I can track down the problem. However I haven't done any kernel work in BSD since 4.x, so it might take me a while to come up to speed on the locking and busdma'ing. Ken From owner-cvs-src@FreeBSD.ORG Tue Oct 19 18:06:29 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B13A216A4CE; Tue, 19 Oct 2004 18:06:29 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9238B43D1F; Tue, 19 Oct 2004 18:06:29 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9JI6Tbo084975; Tue, 19 Oct 2004 18:06:29 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9JI6T85084974; Tue, 19 Oct 2004 18:06:29 GMT (envelope-from obrien) Message-Id: <200410191806.i9JI6T85084974@repoman.freebsd.org> From: "David E. O'Brien" Date: Tue, 19 Oct 2004 18:06:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libsmb Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 18:06:29 -0000 obrien 2004-10-19 18:06:29 UTC FreeBSD src repository Modified files: lib/libsmb Makefile Log: style.Makefile(5) Revision Changes Path 1.4 +4 -5 src/lib/libsmb/Makefile From owner-cvs-src@FreeBSD.ORG Tue Oct 19 18:07:27 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1D4DA16A4CE; Tue, 19 Oct 2004 18:07:27 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F10B443D31; Tue, 19 Oct 2004 18:07:26 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9JI7QRe085062; Tue, 19 Oct 2004 18:07:26 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9JI7QUE085061; Tue, 19 Oct 2004 18:07:26 GMT (envelope-from obrien) Message-Id: <200410191807.i9JI7QUE085061@repoman.freebsd.org> From: "David E. O'Brien" Date: Tue, 19 Oct 2004 18:07:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libsmb Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 18:07:27 -0000 obrien 2004-10-19 18:07:26 UTC FreeBSD src repository Modified files: lib/libsmb Makefile Log: libsmb is now WARNS 2 clean on 64-bit platforms. Revision Changes Path 1.5 +1 -0 src/lib/libsmb/Makefile From owner-cvs-src@FreeBSD.ORG Tue Oct 19 18:09:30 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2F47516A4CE; Tue, 19 Oct 2004 18:09:30 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1097E43D5A; Tue, 19 Oct 2004 18:09:30 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9JI9T92085204; Tue, 19 Oct 2004 18:09:29 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9JI9T8o085203; Tue, 19 Oct 2004 18:09:29 GMT (envelope-from obrien) Message-Id: <200410191809.i9JI9T8o085203@repoman.freebsd.org> From: "David E. O'Brien" Date: Tue, 19 Oct 2004 18:09:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin/mount_smbfs Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 18:09:30 -0000 obrien 2004-10-19 18:09:29 UTC FreeBSD src repository Modified files: usr.sbin/mount_smbfs Makefile Log: This is now WARNS 6 clean on 64-bit platforms. Revision Changes Path 1.5 +1 -1 src/usr.sbin/mount_smbfs/Makefile From owner-cvs-src@FreeBSD.ORG Tue Oct 19 18:11:56 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 21D0916A4CE; Tue, 19 Oct 2004 18:11:56 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 016F943D2F; Tue, 19 Oct 2004 18:11:56 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9JIBtKm085353; Tue, 19 Oct 2004 18:11:55 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9JIBtn6085352; Tue, 19 Oct 2004 18:11:55 GMT (envelope-from rwatson) Message-Id: <200410191811.i9JIBtn6085352@repoman.freebsd.org> From: Robert Watson Date: Tue, 19 Oct 2004 18:11:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/net if.c if_var.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 18:11:56 -0000 rwatson 2004-10-19 18:11:55 UTC FreeBSD src repository Modified files: sys/net if.c if_var.h Log: Define IFF_LOCKGIANT() and IFF_UNLOCKGIANT() macros, which conditionally acquire Giant if the passed interface has IFF_NEEDSGIANT set on it. Modify calls into (ifp)->if_ioctl() in if.c to use these macros in order to ensure that Giant is held. MFC after: 3 days Bumped into by: jmg Revision Changes Path 1.210 +30 -2 src/sys/net/if.c 1.85 +10 -0 src/sys/net/if_var.h From owner-cvs-src@FreeBSD.ORG Tue Oct 19 18:15:33 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5F75216A4D0 for ; Tue, 19 Oct 2004 18:15:33 +0000 (GMT) Received: from mail5.speakeasy.net (mail5.speakeasy.net [216.254.0.205]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0D1F043D46 for ; Tue, 19 Oct 2004 18:15:33 +0000 (GMT) (envelope-from jmg@hydrogen.funkthat.com) Received: (qmail 1577 invoked from network); 19 Oct 2004 18:15:32 -0000 Received: from gate.funkthat.com (HELO hydrogen.funkthat.com) ([69.17.45.168]) (envelope-sender ) by mail5.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 19 Oct 2004 18:15:32 -0000 Received: from hydrogen.funkthat.com (oxqvcp@localhost.funkthat.com [127.0.0.1])i9JIFUlb068763; Tue, 19 Oct 2004 11:15:31 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.12.10/8.12.10/Submit) id i9JIFUab068762; Tue, 19 Oct 2004 11:15:30 -0700 (PDT) Date: Tue, 19 Oct 2004 11:15:30 -0700 From: John-Mark Gurney To: Kenneth Culver Message-ID: <20041019181530.GN22681@funkthat.com> References: <200410182306.i9IN6DDx016512@repoman.freebsd.org> <20041019101752.e8ws08k8kcw8408c@www.sweetdreamsracing.biz> <20041019174306.GK22681@funkthat.com> <20041019140237.60488wg8oss88ocg@www.sweetdreamsracing.biz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041019140237.60488wg8oss88ocg@www.sweetdreamsracing.biz> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 4.2-RELEASE i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_de.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: John-Mark Gurney List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 18:15:33 -0000 Kenneth Culver wrote this message on Tue, Oct 19, 2004 at 14:02 -0400: > Quoting John-Mark Gurney : > > >Kenneth Culver wrote this message on Tue, Oct 19, 2004 at 10:17 -0400: > >>Quoting John-Mark Gurney : > >> > >>>jmg 2004-10-18 23:06:13 UTC > >>> > >>> FreeBSD src repository > >>> > >>> Modified files: > >>> sys/pci if_de.c > >>> Log: > >>> fix (for me) the problems where if_de gets really slow after time > >>> (usually taking 20 seconds to transmit a packet).. no longer fall back > >>> to only transmitting one packet (instead of the entire queue) after we > >>> have processed the entire send queue... I have no idea why we didn't > >>> start seeing this problem ~6 years ago when this code was introduced... > >> > >>Do you get an error on boot with this device about it running in > >>Giant. I was > >>seeing similar problems to you and I was seeing a message at boot about > >>this > >>device running in Giant, so I set debug.mpsafenet to 0, and the problem > >>went > >>away. > > > >yes, I do: > >de0: port 0xd800-0xd87f mem > >0xe8000000-0xe800007f > > irq 10 at device 9.0 on pci0 > >de0: [GIANT-LOCKED] > >de0: 21140A [10-100Mb/s] pass 2.2 > >de0: Ethernet address: 00:c0:f0:1f:21:f9 > >de0: if_start running deferred for Giant > > > >but even with those messages about Giant, we did find that the interface > >ioctl was being called w/o Giant... also, the warning about Giant > >mean that the network subsystem is suppose to call all of the driver's > >routines w/ Giant held to appear as if debug.mpsafenet has been set to 0.. > > > >I have a patch that addes some Giant requireds, but they can't be commited > >till the ioctl problem is fixed... > > > >If you are interested in tracking down the bug, I'll be more than happy > >to review and commit any changes... The driver needs to be both locked > >and busdma'ified... > > > Well the machine I'm using this interface on is in a production machine. If > I > can find another card and put it in my personal machine I'll see if I > can track > down the problem. However I haven't done any kernel work in BSD since > 4.x, so it > might take me a while to come up to speed on the locking and busdma'ing. If you need some pointers, I'll be happy to answer them... there is a man page for busdma(9), so that should make things easier... and of course for locking there is mutex(9)... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not." From owner-cvs-src@FreeBSD.ORG Tue Oct 19 18:15:45 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E223116A4D2; Tue, 19 Oct 2004 18:15:45 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id E5ABD43D41; Tue, 19 Oct 2004 18:15:44 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i9JIFhSJ067955; Tue, 19 Oct 2004 21:15:43 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 56192-02; Tue, 19 Oct 2004 21:15:42 +0300 (EEST) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i9JIFZqL067952; Tue, 19 Oct 2004 21:15:38 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.1/8.13.1) id i9JIFSTO040209; Tue, 19 Oct 2004 21:15:28 +0300 (EEST) (envelope-from ru) Date: Tue, 19 Oct 2004 21:15:28 +0300 From: Ruslan Ermilov To: "David E. O'Brien" Message-ID: <20041019181528.GA40175@ip.net.ua> References: <200410191725.i9JHPYr6083408@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BXVAT5kNtrzKuDFl" Content-Disposition: inline In-Reply-To: <200410191725.i9JHPYr6083408@repoman.freebsd.org> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new at ip.net.ua cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/mk bsd.cpu.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 18:15:46 -0000 --BXVAT5kNtrzKuDFl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 19, 2004 at 05:25:34PM +0000, David E. O'Brien wrote: > obrien 2004-10-19 17:25:34 UTC >=20 > FreeBSD src repository >=20 > Modified files: > share/mk bsd.cpu.mk=20 > Log: > Define "I386_CPU" if CPUTYPE is 'i386'. Userland bits can check for "I= 386_CPU" > to determine if they should select code paths suitable for the 80386 CP= U. > =20 > Suggested by: ru > =20 > Revision Changes Path > 1.45 +3 -0 src/share/mk/bsd.cpu.mk >=20 Thanks David! Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --BXVAT5kNtrzKuDFl Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBdVnAqRfpzJluFF4RAvxHAKCD9FsnqrZTy/CUQp63Kk4F2lAGcgCgjePV YxFDPbd+zp58YUBL48jVUR4= =L1d4 -----END PGP SIGNATURE----- --BXVAT5kNtrzKuDFl-- From owner-cvs-src@FreeBSD.ORG Tue Oct 19 19:05:36 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6DB1516A4CE; Tue, 19 Oct 2004 19:05:36 +0000 (GMT) Received: from portpc-design.spb.ru (ns2.portpc-design.spb.ru [195.161.118.232]) by mx1.FreeBSD.org (Postfix) with ESMTP id 00C8A43D46; Tue, 19 Oct 2004 19:05:35 +0000 (GMT) (envelope-from mcsi@mcsi.pp.ru) Received: from [83.237.195.100] (ppp83-237-195-100.pppoe.mtu-net.ru [83.237.195.100]) (authenticated bits=0) by portpc-design.spb.ru (8.13.1/8.13.1) with ESMTP id i9JJ5Wsf029584; Tue, 19 Oct 2004 23:05:32 +0400 (MSD) (envelope-from mcsi@mcsi.pp.ru) Message-ID: <41756577.6080901@mcsi.pp.ru> Date: Tue, 19 Oct 2004 23:05:27 +0400 From: Maxim Maximov User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.2) Gecko/20040929 X-Accept-Language: ru, en-us, en MIME-Version: 1.0 To: Bruce M Simpson References: <200410191530.i9JFUlCw072852@repoman.freebsd.org> <41754063.5030908@mcsi.pp.ru> <20041019164818.GL86472@dhcp120.icir.org> In-Reply-To: <20041019164818.GL86472@dhcp120.icir.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/pci if_vr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 19:05:36 -0000 Bruce M Simpson wrote: > On Tue, Oct 19, 2004 at 08:27:15PM +0400, Maxim Maximov wrote: > >>/usr/src/sys/pci/if_vr.c: In function `vr_shutdown': >>/usr/src/sys/pci/if_vr.c:1695: warning: passing arg 1 of `vr_detach' > > > Hold the front page! Typo. Fix committed. Thanks! But that's not enough ;) cc -c -O -pipe -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -std=c99 -g -nostdinc -I- -I. -I/usr/src/sys -I/usr/src/sys/contrib/dev/acpica -I/usr/src/sys/contrib/altq -I/usr/src/sys/contrib/ipfilter -I/usr/src/sys/contrib/pf -I/usr/src/sys/contrib/dev/ath -I/usr/src/sys/contrib/dev/ath/freebsd -I/usr/src/sys/contrib/ngatm -D_KERNEL -include opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -mno-align-long-strings -mpreferred-stack-boundary=2 -ffreestanding -Werror /usr/src/sys/pci/if_vr.c /usr/src/sys/pci/if_vr.c: In function `vr_shutdown': /usr/src/sys/pci/if_vr.c:1693: warning: unused variable `sc' *** Error code 1 Stop in /usr/obj/usr/src/sys/ULTRA. *** Error code 1 Stop in /usr/src. *** Error code 1 Stop in /usr/src. Exit 1 -- Maxim Maximov From owner-cvs-src@FreeBSD.ORG Tue Oct 19 20:02:08 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0209516A4CE; Tue, 19 Oct 2004 20:02:08 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D801843D45; Tue, 19 Oct 2004 20:02:07 +0000 (GMT) (envelope-from bms@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9JK27tC089071; Tue, 19 Oct 2004 20:02:07 GMT (envelope-from bms@repoman.freebsd.org) Received: (from bms@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9JK27cd089070; Tue, 19 Oct 2004 20:02:07 GMT (envelope-from bms) Message-Id: <200410192002.i9JK27cd089070@repoman.freebsd.org> From: Bruce M Simpson Date: Tue, 19 Oct 2004 20:02:07 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/pci if_vr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 20:02:08 -0000 bms 2004-10-19 20:02:07 UTC FreeBSD src repository Modified files: sys/pci if_vr.c Log: Really really fix typo this time. Revision Changes Path 1.97 +0 -1 src/sys/pci/if_vr.c From owner-cvs-src@FreeBSD.ORG Tue Oct 19 20:02:37 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DB8BD16A4CE; Tue, 19 Oct 2004 20:02:37 +0000 (GMT) Received: from arginine.spc.org (arginine.spc.org [195.206.69.236]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3072C43D49; Tue, 19 Oct 2004 20:02:37 +0000 (GMT) (envelope-from bms@spc.org) Received: from localhost (localhost [127.0.0.1]) by arginine.spc.org (Postfix) with ESMTP id 9E4C2653FF; Tue, 19 Oct 2004 21:02:35 +0100 (BST) Received: from arginine.spc.org ([127.0.0.1]) by localhost (arginine.spc.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 35836-04-2; Tue, 19 Oct 2004 21:02:35 +0100 (BST) Received: from empiric.dek.spc.org (dhcp120.icir.org [192.150.187.120]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by arginine.spc.org (Postfix) with ESMTP id CBC01653DF; Tue, 19 Oct 2004 21:02:34 +0100 (BST) Received: by empiric.dek.spc.org (Postfix, from userid 1001) id B7B0F615E; Tue, 19 Oct 2004 13:02:24 -0700 (PDT) Date: Tue, 19 Oct 2004 13:02:24 -0700 From: Bruce M Simpson To: Maxim Maximov Message-ID: <20041019200224.GP86472@dhcp120.icir.org> Mail-Followup-To: Maxim Maximov , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org References: <200410191530.i9JFUlCw072852@repoman.freebsd.org> <41754063.5030908@mcsi.pp.ru> <20041019164818.GL86472@dhcp120.icir.org> <41756577.6080901@mcsi.pp.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <41756577.6080901@mcsi.pp.ru> cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/pci if_vr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 20:02:38 -0000 On Tue, Oct 19, 2004 at 11:05:27PM +0400, Maxim Maximov wrote: > >Hold the front page! Typo. Fix committed. > Thanks! But that's not enough ;) % jot -b 'I will not commit driver fixes when I have been awake for more than 24 hours.' 30 BMS From owner-cvs-src@FreeBSD.ORG Tue Oct 19 20:11:24 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3968A16A4CE; Tue, 19 Oct 2004 20:11:24 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 197E243D5F; Tue, 19 Oct 2004 20:11:24 +0000 (GMT) (envelope-from sos@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9JKBNgc092292; Tue, 19 Oct 2004 20:11:23 GMT (envelope-from sos@repoman.freebsd.org) Received: (from sos@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9JKBNMv092291; Tue, 19 Oct 2004 20:11:23 GMT (envelope-from sos) Message-Id: <200410192011.i9JKBNMv092291@repoman.freebsd.org> From: Søren Schmidt Date: Tue, 19 Oct 2004 20:11:23 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/ata ata-queue.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 20:11:24 -0000 sos 2004-10-19 20:11:23 UTC FreeBSD src repository Modified files: sys/dev/ata ata-queue.c Log: Cosmetics Revision Changes Path 1.38 +2 -6 src/sys/dev/ata/ata-queue.c From owner-cvs-src@FreeBSD.ORG Tue Oct 19 20:13:39 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 263D816A4CE; Tue, 19 Oct 2004 20:13:39 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0809C43D41; Tue, 19 Oct 2004 20:13:39 +0000 (GMT) (envelope-from sos@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9JKDc24092429; Tue, 19 Oct 2004 20:13:38 GMT (envelope-from sos@repoman.freebsd.org) Received: (from sos@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9JKDcsO092428; Tue, 19 Oct 2004 20:13:38 GMT (envelope-from sos) Message-Id: <200410192013.i9JKDcsO092428@repoman.freebsd.org> From: Søren Schmidt Date: Tue, 19 Oct 2004 20:13:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/ata ata-all.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 20:13:39 -0000 sos 2004-10-19 20:13:38 UTC FreeBSD src repository Modified files: sys/dev/ata ata-all.c Log: Idle the channel earlier in reinit(). Cosmetic change to suspend, dont call tsleep an extra time at exit. Revision Changes Path 1.233 +10 -10 src/sys/dev/ata/ata-all.c From owner-cvs-src@FreeBSD.ORG Tue Oct 19 20:26:13 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 47A7616A4CF for ; Tue, 19 Oct 2004 20:26:13 +0000 (GMT) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 427BB43D5F for ; Tue, 19 Oct 2004 20:26:10 +0000 (GMT) (envelope-from andre@freebsd.org) Received: (qmail 61592 invoked from network); 19 Oct 2004 20:25:06 -0000 Received: from unknown (HELO freebsd.org) ([62.48.0.53]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 19 Oct 2004 20:25:06 -0000 Message-ID: <41757866.EB97169@freebsd.org> Date: Tue, 19 Oct 2004 22:26:14 +0200 From: Andre Oppermann X-Mailer: Mozilla 4.8 [en] (Windows NT 5.0; U) X-Accept-Language: en MIME-Version: 1.0 To: John-Mark Gurney References: <200410191513.i9JFDUbf072176@repoman.freebsd.org> <417532A2.9000901@errno.com> <41753522.1E39FEAE@freebsd.org> <20041019175807.GM22681@funkthat.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: Sam Leffler cc: src-committers@freebsd.org cc: cvs-all@freebsd.org cc: cvs-src@freebsd.org Subject: Re: cvs commit: src/sys/sys protosw.h src/sys/kern uipc_domain.cuipc_socket2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 20:26:13 -0000 John-Mark Gurney wrote: > > Andre Oppermann wrote this message on Tue, Oct 19, 2004 at 17:39 +0200: > > > > Modified files: > > > > sys/sys protosw.h > > > > sys/kern uipc_domain.c uipc_socket2.c > > > > Log: > > > > Support for dynamically loadable and unloadable protocols within existing protocol > > > > families. > > > > > > > > > > I don't recall seeing this posted anywhere for comment. I have some > > > concerns about this general topic and this code seems incomplete (e.g. I > > > see no locking). > > > > Locking is not needed because there are no dead moments in transitioning > > from unregistered to registered and back. All calls to any of the protocol > > specific functions will return a valid result (even if it is only EOPNOTSUPP). > > There is no list manipulation going on. > > > > The caller of the function is required to assure that no dangeling sockets, > > references or memory allocations are left behind after unregistering. It's > > simply impossible to solve otherwise. For IPDIVERT which I have converted > > this works very well (it will simply refuse to unload if a divert socket is > > open). > > > > What remaining concerns do you have? > > I don't see any GIANT_REQUIRE, or locking around adding a new protocol.. > This means there could be a race where two modules loading a protocol > get assigned the same slot... Ok, that makes sense. Luckily loading protocols is a relatively rare occourence and highly unlikely to bite anyone soon. I'll add the giant lock just to be sure as you suggest though. > I had to do this with the kqueue subsystem when dynamicly loading > filters... I'll have a look how you solved it there. -- Andre From owner-cvs-src@FreeBSD.ORG Tue Oct 19 20:30:10 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2D59916A4CE; Tue, 19 Oct 2004 20:30:10 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0FA4743D4C; Tue, 19 Oct 2004 20:30:10 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9JKU9js093257; Tue, 19 Oct 2004 20:30:09 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9JKU9SL093256; Tue, 19 Oct 2004 20:30:09 GMT (envelope-from ru) Message-Id: <200410192030.i9JKU9SL093256@repoman.freebsd.org> From: Ruslan Ermilov Date: Tue, 19 Oct 2004 20:30:09 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin/zic zic.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 20:30:10 -0000 ru 2004-10-19 20:30:09 UTC FreeBSD src repository Modified files: usr.sbin/zic zic.c Log: Make the -m option actually work. Revision Changes Path 1.17 +1 -1 src/usr.sbin/zic/zic.c From owner-cvs-src@FreeBSD.ORG Tue Oct 19 20:38:50 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 33B3216A4CE; Tue, 19 Oct 2004 20:38:50 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 13CB543D31; Tue, 19 Oct 2004 20:38:50 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9JKcnqV093621; Tue, 19 Oct 2004 20:38:49 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9JKcnho093620; Tue, 19 Oct 2004 20:38:49 GMT (envelope-from ru) Message-Id: <200410192038.i9JKcnho093620@repoman.freebsd.org> From: Ruslan Ermilov Date: Tue, 19 Oct 2004 20:38:49 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/zoneinfo Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 20:38:50 -0000 ru 2004-10-19 20:38:49 UTC FreeBSD src repository Modified files: share/zoneinfo Makefile Log: - Removed the .CURDIR/.OBJDIR magic, it is not necessary here. - Let the built-in sys.mk rule produce the "yearistype" script. - Install zone files with mode 444 (now that the -m option of zic(8) has been fixed). Revision Changes Path 1.20 +2 -12 src/share/zoneinfo/Makefile From owner-cvs-src@FreeBSD.ORG Tue Oct 19 20:46:15 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0797116A4CE; Tue, 19 Oct 2004 20:46:15 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DBDC943D6E; Tue, 19 Oct 2004 20:46:14 +0000 (GMT) (envelope-from tackerman@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9JKkE7w093923; Tue, 19 Oct 2004 20:46:14 GMT (envelope-from tackerman@repoman.freebsd.org) Received: (from tackerman@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9JKkE4g093922; Tue, 19 Oct 2004 20:46:14 GMT (envelope-from tackerman) Message-Id: <200410192046.i9JKkE4g093922@repoman.freebsd.org> From: Tony Ackerman Date: Tue, 19 Oct 2004 20:46:14 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/share/man/man4 em.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 20:46:15 -0000 tackerman 2004-10-19 20:46:14 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) share/man/man4 em.4 Log: Fixes incorrect copyright year and formatting errors introduced in previous version. Reviewed by: Prafulla Deuskar MFC after:1 Revision Changes Path 1.2.2.8 +27 -22 src/share/man/man4/em.4 From owner-cvs-src@FreeBSD.ORG Tue Oct 19 20:48:06 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 80CF116A4CE; Tue, 19 Oct 2004 20:48:06 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 46F4843D67; Tue, 19 Oct 2004 20:48:06 +0000 (GMT) (envelope-from gibbs@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9JKm6jU000506; Tue, 19 Oct 2004 20:48:06 GMT (envelope-from gibbs@repoman.freebsd.org) Received: (from gibbs@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9JKm63l000505; Tue, 19 Oct 2004 20:48:06 GMT (envelope-from gibbs) Message-Id: <200410192048.i9JKm63l000505@repoman.freebsd.org> From: "Justin T. Gibbs" Date: Tue, 19 Oct 2004 20:48:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/aic7xxx aic7xxx.c aic7xxx.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 20:48:06 -0000 gibbs 2004-10-19 20:48:06 UTC FreeBSD src repository Modified files: sys/dev/aic7xxx aic7xxx.c aic7xxx.h Log: aic7xxx.h: Add constants for SPI protocol delays that are needed for target mode. aic7xxx.c: Correct a target mode issue that caused an occassional spurious REQ to be seen on the bus when performing manual message processing (e.g. transfer rate negotiation). Enforce phase change bus settle rules with explicit delays when performing manual message processing in target mode. The sequencer already did this for "fast-path", target mode message processing. Revision Changes Path 1.103 +87 -14 src/sys/dev/aic7xxx/aic7xxx.c 1.53 +4 -0 src/sys/dev/aic7xxx/aic7xxx.h From owner-cvs-src@FreeBSD.ORG Tue Oct 19 20:59:02 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0497416A4CE; Tue, 19 Oct 2004 20:59:02 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D959343D55; Tue, 19 Oct 2004 20:59:01 +0000 (GMT) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9JKx1Sp000939; Tue, 19 Oct 2004 20:59:01 GMT (envelope-from andre@repoman.freebsd.org) Received: (from andre@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9JKx14i000938; Tue, 19 Oct 2004 20:59:01 GMT (envelope-from andre) Message-Id: <200410192059.i9JKx14i000938@repoman.freebsd.org> From: Andre Oppermann Date: Tue, 19 Oct 2004 20:59:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netinet in.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 20:59:02 -0000 andre 2004-10-19 20:59:01 UTC FreeBSD src repository Modified files: sys/netinet in.h Log: Pre-emptively define IPPROTO_SPACER to 32767, the same value as PROTO_SPACER to document that this value is globally assigned for a special purpose and may not be reused within the IPPROTO number space. Revision Changes Path 1.88 +6 -0 src/sys/netinet/in.h From owner-cvs-src@FreeBSD.ORG Tue Oct 19 21:06:14 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 737F316A4CE; Tue, 19 Oct 2004 21:06:14 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5497843D58; Tue, 19 Oct 2004 21:06:14 +0000 (GMT) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9JL6E6x001257; Tue, 19 Oct 2004 21:06:14 GMT (envelope-from andre@repoman.freebsd.org) Received: (from andre@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9JL6EWm001256; Tue, 19 Oct 2004 21:06:14 GMT (envelope-from andre) Message-Id: <200410192106.i9JL6EWm001256@repoman.freebsd.org> From: Andre Oppermann Date: Tue, 19 Oct 2004 21:06:14 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netinet in_var.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 21:06:14 -0000 andre 2004-10-19 21:06:14 UTC FreeBSD src repository Modified files: sys/netinet in_var.h Log: Properly declare the "net.inet" sysctl subtree. Revision Changes Path 1.52 +1 -0 src/sys/netinet/in_var.h From owner-cvs-src@FreeBSD.ORG Tue Oct 19 21:13:11 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4D73416A4DA for ; Tue, 19 Oct 2004 21:13:11 +0000 (GMT) Received: from mail6.speakeasy.net (mail6.speakeasy.net [216.254.0.206]) by mx1.FreeBSD.org (Postfix) with ESMTP id DF05143D49 for ; Tue, 19 Oct 2004 21:13:10 +0000 (GMT) (envelope-from john@baldwin.cx) Received: (qmail 23220 invoked from network); 19 Oct 2004 21:13:10 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 19 Oct 2004 21:13:10 -0000 Received: from zion.baldwin.cx (zion.baldwin.cx [192.168.0.7]) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id i9JLD0oQ050277; Tue, 19 Oct 2004 17:13:00 -0400 (EDT) (envelope-from john@baldwin.cx) Received: from zion.baldwin.cx (localhost [127.0.0.1]) by zion.baldwin.cx (8.12.10/8.12.10) with ESMTP id i9JLD08h005682; Tue, 19 Oct 2004 17:13:00 -0400 (EDT) (envelope-from john@zion.baldwin.cx) Received: from localhost (localhost [[UNIX: localhost]]) by zion.baldwin.cx (8.12.10/8.12.10/Submit) id i9JLD0KN005681; Tue, 19 Oct 2004 17:13:00 -0400 (EDT) (envelope-from john) From: John Baldwin To: "M. Warner Losh" Date: Tue, 19 Oct 2004 15:42:21 -0400 User-Agent: KMail/1.6 References: <20041019071102.GA49717@FreeBSD.org> <20041019073145.GA29746@thingy.tbd.co.nz> <20041019.084324.106215221.imp@bsdimp.com> In-Reply-To: <20041019.084324.106215221.imp@bsdimp.com> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200410191541.54269.jhb@FreeBSD.org> Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 21:13:11 -0000 On Tuesday 19 October 2004 10:43 am, you wrote: > In message: <20041019073145.GA29746@thingy.tbd.co.nz> > > Andrew Thompson writes: > : > I am afraid that recompiling a kernel on i386 will require several > : > days. > : > : Chicken and the egg. To support i386 it must be recompiled, so you would > : have to do it on another box anyway. > > The only people that will seriously want to use i386 these days are > the folks that build embedded systems. Those you have to build on > some host then deploy to the target system. > > There are some benefits to having i386 in the tree. However, there > are also a number of different places in the tree where things are > sub-optimal because we still have support for i386 in there. The > desire to remove them is to make FreeBSD go faster on more modern > hardware. I think 6.0 is the place to drop 80386, not 5.x. I'm already working on a p4 branch (jhb_no386) to remove 80396 support from HEAD, but I think 5.x should be left as is in this regard. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ From owner-cvs-src@FreeBSD.ORG Tue Oct 19 21:14:57 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DBD7D16A5AA; Tue, 19 Oct 2004 21:14:57 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CEE1343D3F; Tue, 19 Oct 2004 21:14:57 +0000 (GMT) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9JLEvk8001575; Tue, 19 Oct 2004 21:14:57 GMT (envelope-from andre@repoman.freebsd.org) Received: (from andre@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9JLEvjQ001574; Tue, 19 Oct 2004 21:14:57 GMT (envelope-from andre) Message-Id: <200410192114.i9JLEvjQ001574@repoman.freebsd.org> From: Andre Oppermann Date: Tue, 19 Oct 2004 21:14:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/modules/ipdivert Makefile src/sys/netinet in_proto.c ip_divert.c ip_divert.h ip_fw2.c ip_fw_pfil.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 21:14:58 -0000 andre 2004-10-19 21:14:57 UTC FreeBSD src repository Modified files: sys/netinet in_proto.c ip_divert.c ip_divert.h ip_fw2.c ip_fw_pfil.c Added files: sys/modules/ipdivert Makefile Log: Convert IPDIVERT into a loadable module. This makes use of the dynamic loadability of protocols. The call to divert_packet() is done through a function pointer. All semantics of IPDIVERT remain intact. If IPDIVERT is not loaded ipfw will refuse to install divert rules and natd will complain about 'protocol not supported'. Once it is loaded both will work and accept rules and open the divert socket. The module can only be unloaded if no divert sockets are open. It does not close any divert sockets when an unload is requested but will return EBUSY instead. Revision Changes Path 1.1 +8 -0 src/sys/modules/ipdivert/Makefile (new) 1.75 +0 -13 src/sys/netinet/in_proto.c 1.101 +67 -8 src/sys/netinet/ip_divert.c 1.4 +10 -4 src/sys/netinet/ip_divert.h 1.82 +2 -4 src/sys/netinet/ip_fw2.c 1.11 +13 -8 src/sys/netinet/ip_fw_pfil.c From owner-cvs-src@FreeBSD.ORG Tue Oct 19 21:19:11 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E11A216A4D0 for ; Tue, 19 Oct 2004 21:19:11 +0000 (GMT) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id D1BA643D48 for ; Tue, 19 Oct 2004 21:19:10 +0000 (GMT) (envelope-from andre@freebsd.org) Received: (qmail 62001 invoked from network); 19 Oct 2004 21:18:07 -0000 Received: from unknown (HELO freebsd.org) ([62.48.0.53]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 19 Oct 2004 21:18:07 -0000 Message-ID: <417584D3.DD1DA0F0@freebsd.org> Date: Tue, 19 Oct 2004 23:19:15 +0200 From: Andre Oppermann X-Mailer: Mozilla 4.8 [en] (Windows NT 5.0; U) X-Accept-Language: en MIME-Version: 1.0 To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200410192114.i9JLEvjQ001574@repoman.freebsd.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: Re: cvs commit: src/sys/modules/ipdivert Makefile src/sys/netinetin_proto.c ip_divert.c ip_divert.h ip_fw2.c ip_fw_pfil.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 21:19:12 -0000 Andre Oppermann wrote: > > andre 2004-10-19 21:14:57 UTC > > FreeBSD src repository > > Modified files: > sys/netinet in_proto.c ip_divert.c ip_divert.h > ip_fw2.c ip_fw_pfil.c > Added files: > sys/modules/ipdivert Makefile > Log: > Convert IPDIVERT into a loadable module. This makes use of the dynamic loadability > of protocols. The call to divert_packet() is done through a function pointer. All > semantics of IPDIVERT remain intact. If IPDIVERT is not loaded ipfw will refuse to > install divert rules and natd will complain about 'protocol not supported'. Once > it is loaded both will work and accept rules and open the divert socket. The module > can only be unloaded if no divert sockets are open. It does not close any divert > sockets when an unload is requested but will return EBUSY instead. I know locking is not perfect here and I will fix it shortly. However the risk to get hit by it duing an unload is very low and does not pose any real-world risk. -- Andre From owner-cvs-src@FreeBSD.ORG Tue Oct 19 21:28:23 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1C16B16A4CE; Tue, 19 Oct 2004 21:28:23 +0000 (GMT) Received: from mail.vicor-nb.com (bigwoop.vicor-nb.com [208.206.78.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id EA0A843D45; Tue, 19 Oct 2004 21:28:22 +0000 (GMT) (envelope-from julian@elischer.org) Received: from elischer.org (julian.vicor-nb.com [208.206.78.97]) by mail.vicor-nb.com (Postfix) with ESMTP id CEE3F7A43E; Tue, 19 Oct 2004 14:28:22 -0700 (PDT) Message-ID: <417586F6.6070003@elischer.org> Date: Tue, 19 Oct 2004 14:28:22 -0700 From: Julian Elischer User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.3.1) Gecko/20030516 X-Accept-Language: en, hu MIME-Version: 1.0 To: Andre Oppermann References: <200410192114.i9JLEvjQ001574@repoman.freebsd.org> In-Reply-To: <200410192114.i9JLEvjQ001574@repoman.freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/modules/ipdivert Makefile src/sys/netinet in_proto.c ip_divert.c ip_divert.h ip_fw2.c ip_fw_pfil.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 21:28:23 -0000 Andre Oppermann wrote: >andre 2004-10-19 21:14:57 UTC > > FreeBSD src repository > > Modified files: > sys/netinet in_proto.c ip_divert.c ip_divert.h > ip_fw2.c ip_fw_pfil.c > Added files: > sys/modules/ipdivert Makefile > Log: > Convert IPDIVERT into a loadable module. This makes use of the dynamic loadability > of protocols. The call to divert_packet() is done through a function pointer. All > semantics of IPDIVERT remain intact. If IPDIVERT is not loaded ipfw will refuse to > install divert rules and natd will complain about 'protocol not supported'. Once > it is loaded both will work and accept rules and open the divert socket. The module > can only be unloaded if no divert sockets are open. It does not close any divert > sockets when an unload is requested but will return EBUSY instead. > Can you unload it if there are divert rules? If yes, what happens if a packet is then diverted..? > > Revision Changes Path > 1.1 +8 -0 src/sys/modules/ipdivert/Makefile (new) > 1.75 +0 -13 src/sys/netinet/in_proto.c > 1.101 +67 -8 src/sys/netinet/ip_divert.c > 1.4 +10 -4 src/sys/netinet/ip_divert.h > 1.82 +2 -4 src/sys/netinet/ip_fw2.c > 1.11 +13 -8 src/sys/netinet/ip_fw_pfil.c > > From owner-cvs-src@FreeBSD.ORG Tue Oct 19 21:29:33 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8248A16A4CE; Tue, 19 Oct 2004 21:29:33 +0000 (GMT) Received: from harmony.village.org (rover.village.org [168.103.84.182]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4BAF943D1D; Tue, 19 Oct 2004 21:29:32 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (harmony.village.org [10.0.0.6]) by harmony.village.org (8.13.1/8.13.1) with ESMTP id i9JLSjiY017470; Tue, 19 Oct 2004 15:28:45 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Tue, 19 Oct 2004 15:29:02 -0600 (MDT) Message-Id: <20041019.152902.02300007.imp@bsdimp.com> To: jhb@freebsd.org From: "M. Warner Losh" In-Reply-To: <200410191541.54269.jhb@FreeBSD.org> References: <20041019073145.GA29746@thingy.tbd.co.nz> <20041019.084324.106215221.imp@bsdimp.com> <200410191541.54269.jhb@FreeBSD.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 21:29:33 -0000 In message: <200410191541.54269.jhb@FreeBSD.org> John Baldwin writes: : On Tuesday 19 October 2004 10:43 am, you wrote: : > In message: <20041019073145.GA29746@thingy.tbd.co.nz> : > : > Andrew Thompson writes: : > : > I am afraid that recompiling a kernel on i386 will require several : > : > days. : > : : > : Chicken and the egg. To support i386 it must be recompiled, so you would : > : have to do it on another box anyway. : > : > The only people that will seriously want to use i386 these days are : > the folks that build embedded systems. Those you have to build on : > some host then deploy to the target system. : > : > There are some benefits to having i386 in the tree. However, there : > are also a number of different places in the tree where things are : > sub-optimal because we still have support for i386 in there. The : > desire to remove them is to make FreeBSD go faster on more modern : > hardware. : : I think 6.0 is the place to drop 80386, not 5.x. I'm already working on a p4 : branch (jhb_no386) to remove 80396 support from HEAD, but I think 5.x should : be left as is in this regard. That was the agreement some months ago. 5.x would have it de-emphasized to allow easier optimizations, and 6.0 would actually remove it unless there was some really compelling reason not to. So far, none of the arguments have come close to getting to compelling, let alone really compelling. The low end of most intel based embedded is the Elan chipset these days, and old 386 desktops are rare. Support for i386 negatively impacts certain low level routines in a number of ways. But we've been through all before when we came to the agreement: 5.x wouldn't support it out of the box, but the clueful can coax 386 support out of the source tree. No one was to do anything to break it. If someone accidentally did break it, it was the resonsibility of the 386 fans to fix it. This has happened at least once that I'm aware of. 6.x would remove support for i386 entirely, unless some really compelling reason was presented that wasn't present in the original discussion. David's commits do nothing to change the above, nor were they intended to do so. Nothing in the ensuing discussion has changed it either, so we're back to the original agreement. I'm posting it here for clarity. Warner From owner-cvs-src@FreeBSD.ORG Tue Oct 19 21:30:22 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 900C916A4D8; Tue, 19 Oct 2004 21:30:22 +0000 (GMT) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.188]) by mx1.FreeBSD.org (Postfix) with ESMTP id 00C5443D2F; Tue, 19 Oct 2004 21:30:20 +0000 (GMT) (envelope-from max@love2party.net) Received: from [212.227.126.207] (helo=mrelayng.kundenserver.de) by moutng.kundenserver.de with esmtp (Exim 3.35 #1) id 1CK1Yg-0005wb-00; Tue, 19 Oct 2004 23:30:18 +0200 Received: from [217.227.158.113] (helo=donor.laier.local) by mrelayng.kundenserver.de with asmtp (TLSv1:RC4-MD5:128) (Exim 3.35 #1) id 1CK1Yb-0007R7-00; Tue, 19 Oct 2004 23:30:18 +0200 From: Max Laier To: Andre Oppermann Date: Tue, 19 Oct 2004 23:29:33 +0200 User-Agent: KMail/1.7 References: <200410191513.i9JFDUbf072176@repoman.freebsd.org> <417532A2.9000901@errno.com> <41753522.1E39FEAE@freebsd.org> In-Reply-To: <41753522.1E39FEAE@freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2773990.mzSJZD2ttK"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200410192329.46723.max@love2party.net> X-Provags-ID: kundenserver.de abuse@kundenserver.de auth:61c499deaeeba3ba5be80f48ecc83056 cc: Sam Leffler cc: src-committers@freebsd.org cc: cvs-all@freebsd.org cc: cvs-src@freebsd.org Subject: Re: cvs commit: src/sys/sys protosw.h src/sys/kern uipc_domain.cuipc_socket2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 21:30:22 -0000 --nextPart2773990.mzSJZD2ttK Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Tuesday 19 October 2004 17:39, Andre Oppermann wrote: > Sam Leffler wrote: > > Andre Oppermann wrote: > > > andre 2004-10-19 15:13:30 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/sys protosw.h > > > sys/kern uipc_domain.c uipc_socket2.c > > > Log: > > > Support for dynamically loadable and unloadable protocols within > > > existing protocol families. > > > > I don't recall seeing this posted anywhere for comment. I have some > > concerns about this general topic and this code seems incomplete (e.g. I > > see no locking). > > Locking is not needed because there are no dead moments in transitioning > from unregistered to registered and back. All calls to any of the protoc= ol > specific functions will return a valid result (even if it is only > EOPNOTSUPP). There is no list manipulation going on. > > The caller of the function is required to assure that no dangeling socket= s, > references or memory allocations are left behind after unregistering. It= 's > simply impossible to solve otherwise. For IPDIVERT which I have converted > this works very well (it will simply refuse to unload if a divert socket = is > open). > > What remaining concerns do you have? I am also a bit worried about this. While it is a cool thing to have someth= ing=20 like this, but I am afraid that there is code that will trigger problems. F= or=20 example, in ip_icmp.c line 457 ff we have: ctlfunc =3D inetsw[ip_protox[icp->icmp_ip.ip_p]].pr_ctlinput; if (ctlfunc) (*ctlfunc)(code, (struct sockaddr *)&icmpsrc, (void *)&icp->icmp_ip); This is clearly a problem if we can remove protocols. There might be more=20 places where we (temporary) cache values from the protocol array. Another=20 problem might be that we check for protocol existence early and assume that= =20 this remains true ... I'd suggest, that you remove the possibility to remove protocols completely= =2E=20 It is very likely that there are no races with adding protocols - though it= =20 might take "some time" for the protocol to be fully useable - but the remov= al=20 is critical. We also have to check that really all code can cope with the addition and=20 properly reinitializes it's view of the protocol arrays. Another point: If you really want to keep the possibility to remove a=20 protocol, you have to introduce some busy counter that pervents removal whi= le=20 the kernel is inside a protocol function. This has to be handled by the=20 protocol itself, but it has to be taken care of somehow. =2D-=20 /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --nextPart2773990.mzSJZD2ttK Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQBBdYdKXyyEoT62BG0RAobtAJ9PrJVaNANAiyB+aWivYsr48MEZswCdG54+ SqrpAqMHgwbJDJxRlXl+mVc= =W45W -----END PGP SIGNATURE----- --nextPart2773990.mzSJZD2ttK-- From owner-cvs-src@FreeBSD.ORG Tue Oct 19 21:35:27 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7321E16A4CF for ; Tue, 19 Oct 2004 21:35:27 +0000 (GMT) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 75D8D43D45 for ; Tue, 19 Oct 2004 21:35:26 +0000 (GMT) (envelope-from andre@freebsd.org) Received: (qmail 62172 invoked from network); 19 Oct 2004 21:34:22 -0000 Received: from unknown (HELO freebsd.org) ([62.48.0.53]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 19 Oct 2004 21:34:22 -0000 Message-ID: <417588A2.D71E122E@freebsd.org> Date: Tue, 19 Oct 2004 23:35:30 +0200 From: Andre Oppermann X-Mailer: Mozilla 4.8 [en] (Windows NT 5.0; U) X-Accept-Language: en MIME-Version: 1.0 To: Julian Elischer References: <200410192114.i9JLEvjQ001574@repoman.freebsd.org> <417586F6.6070003@elischer.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/modules/ipdivert Makefile src/sys/netinetin_proto.c ip_divert.c ip_divert.h ip_fw2.c ip_fw_pfil.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 21:35:27 -0000 Julian Elischer wrote: > > Andre Oppermann wrote: > > >andre 2004-10-19 21:14:57 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/netinet in_proto.c ip_divert.c ip_divert.h > > ip_fw2.c ip_fw_pfil.c > > Added files: > > sys/modules/ipdivert Makefile > > Log: > > Convert IPDIVERT into a loadable module. This makes use of the dynamic loadability > > of protocols. The call to divert_packet() is done through a function pointer. All > > semantics of IPDIVERT remain intact. If IPDIVERT is not loaded ipfw will refuse to > > install divert rules and natd will complain about 'protocol not supported'. Once > > it is loaded both will work and accept rules and open the divert socket. The module > > can only be unloaded if no divert sockets are open. It does not close any divert > > sockets when an unload is requested but will return EBUSY instead. > > > > Can you unload it if there are divert rules? Yes, but not when natd is still running (because then a socket is open). > If yes, what happens if a packet is then diverted..? The same that happens when you have a divert rule but no natd running to take care of the packets; they are m_free'd. -- Andre From owner-cvs-src@FreeBSD.ORG Tue Oct 19 21:35:43 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 11A0316A4CE; Tue, 19 Oct 2004 21:35:43 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E578843D2D; Tue, 19 Oct 2004 21:35:42 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9JLZgdU002302; Tue, 19 Oct 2004 21:35:42 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9JLZgmv002301; Tue, 19 Oct 2004 21:35:42 GMT (envelope-from rwatson) Message-Id: <200410192135.i9JLZgmv002301@repoman.freebsd.org> From: Robert Watson Date: Tue, 19 Oct 2004 21:35:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netinet ip_divert.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 21:35:43 -0000 rwatson 2004-10-19 21:35:42 UTC FreeBSD src repository Modified files: sys/netinet ip_divert.c Log: Annotate a newly introduced race present due to the unloading of protocols: it is possible for sockets to be created and attached to the divert protocol between the test for sockets present and successful unload of the registration handler. We will need to explore more mature APIs for unregistering the protocol and then draining consumers, or an atomic test-and-unregister mechanism. Revision Changes Path 1.102 +4 -0 src/sys/netinet/ip_divert.c From owner-cvs-src@FreeBSD.ORG Tue Oct 19 21:46:26 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 773C916A4CF for ; Tue, 19 Oct 2004 21:46:26 +0000 (GMT) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8A6C543D55 for ; Tue, 19 Oct 2004 21:46:25 +0000 (GMT) (envelope-from andre@freebsd.org) Received: (qmail 62247 invoked from network); 19 Oct 2004 21:45:21 -0000 Received: from unknown (HELO freebsd.org) ([62.48.0.53]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 19 Oct 2004 21:45:21 -0000 Message-ID: <41758B35.D5340AEA@freebsd.org> Date: Tue, 19 Oct 2004 23:46:29 +0200 From: Andre Oppermann X-Mailer: Mozilla 4.8 [en] (Windows NT 5.0; U) X-Accept-Language: en MIME-Version: 1.0 To: Max Laier References: <200410191513.i9JFDUbf072176@repoman.freebsd.org> <417532A2.9000901@errno.com> <41753522.1E39FEAE@freebsd.org> <200410192329.46723.max@love2party.net> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: Sam Leffler cc: src-committers@freebsd.org cc: cvs-all@freebsd.org cc: cvs-src@freebsd.org Subject: Re: cvs commit: src/sys/sys protosw.h src/sys/kern uipc_domain.cuipc_socket2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 21:46:26 -0000 Max Laier wrote: > > On Tuesday 19 October 2004 17:39, Andre Oppermann wrote: > > Sam Leffler wrote: > > > Andre Oppermann wrote: > > > > andre 2004-10-19 15:13:30 UTC > > > > > > > > FreeBSD src repository > > > > > > > > Modified files: > > > > sys/sys protosw.h > > > > sys/kern uipc_domain.c uipc_socket2.c > > > > Log: > > > > Support for dynamically loadable and unloadable protocols within > > > > existing protocol families. > > > > > > I don't recall seeing this posted anywhere for comment. I have some > > > concerns about this general topic and this code seems incomplete (e.g. I > > > see no locking). > > > > Locking is not needed because there are no dead moments in transitioning > > from unregistered to registered and back. All calls to any of the protocol > > specific functions will return a valid result (even if it is only > > EOPNOTSUPP). There is no list manipulation going on. > > > > The caller of the function is required to assure that no dangeling sockets, > > references or memory allocations are left behind after unregistering. It's > > simply impossible to solve otherwise. For IPDIVERT which I have converted > > this works very well (it will simply refuse to unload if a divert socket is > > open). > > > > What remaining concerns do you have? > > I am also a bit worried about this. While it is a cool thing to have something > like this, but I am afraid that there is code that will trigger problems. For > example, in ip_icmp.c line 457 ff we have: > > ctlfunc = inetsw[ip_protox[icp->icmp_ip.ip_p]].pr_ctlinput; > if (ctlfunc) > (*ctlfunc)(code, (struct sockaddr *)&icmpsrc, > (void *)&icp->icmp_ip); Ok, this one is easy to fix. I'll audit the code for any other of these abuses. > This is clearly a problem if we can remove protocols. There might be more > places where we (temporary) cache values from the protocol array. Another > problem might be that we check for protocol existence early and assume that > this remains true ... Well, too bad if some code tries to remember this. Doesn't hurt then. >From my reading of many parts of the netinet/* code this is usually not a problem and the code is rather well behaved. I refuse to take this argument as reason to not have loadable protocols. > I'd suggest, that you remove the possibility to remove protocols completely. > It is very likely that there are no races with adding protocols - though it > might take "some time" for the protocol to be fully useable - but the removal > is critical. I don't think it should be a one-way street. To be able to unload protocols is an important but seldomly used function and it's certainly not that a crash is guarnteed. Far from it. > We also have to check that really all code can cope with the addition and > properly reinitializes it's view of the protocol arrays. The point of the protocol arrays is precisely to have them as the only and sole place where such information is stored. Any code that copies any part of it to its own private structures is horribly broken by design and must be fixed anyway! (BTW: I'm not aware of any code within netinet/* that does this.) > Another point: If you really want to keep the possibility to remove a > protocol, you have to introduce some busy counter that pervents removal while > the kernel is inside a protocol function. This has to be handled by the > protocol itself, but it has to be taken care of somehow. Yes, the protocol has to be able to handle its own unloading. I have documented that fact. If a protocol in unable to do so it should simply refuse any unload attempts with EBUSY. -- Andre From owner-cvs-src@FreeBSD.ORG Tue Oct 19 21:49:19 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4FBD716A4CE; Tue, 19 Oct 2004 21:49:19 +0000 (GMT) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id DA1DC43D64; Tue, 19 Oct 2004 21:49:18 +0000 (GMT) (envelope-from scottl@freebsd.org) Received: from [192.168.254.11] (junior-wifi.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.12.11/8.12.10) with ESMTP id i9JLnbcO046152; Tue, 19 Oct 2004 15:49:38 -0600 (MDT) (envelope-from scottl@freebsd.org) Message-ID: <41758B81.5090903@freebsd.org> Date: Tue, 19 Oct 2004 15:47:45 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.2) Gecko/20040929 X-Accept-Language: en-us, en MIME-Version: 1.0 To: John Baldwin References: <20041019071102.GA49717@FreeBSD.org> <20041019073145.GA29746@thingy.tbd.co.nz> <20041019.084324.106215221.imp@bsdimp.com> <200410191541.54269.jhb@FreeBSD.org> In-Reply-To: <200410191541.54269.jhb@FreeBSD.org> X-Enigmail-Version: 0.86.1.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=0.0 required=3.8 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on pooker.samsco.org cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org cc: "M. Warner Losh" Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 21:49:19 -0000 John Baldwin wrote: > On Tuesday 19 October 2004 10:43 am, you wrote: > >>In message: <20041019073145.GA29746@thingy.tbd.co.nz> >> >> Andrew Thompson writes: >>: > I am afraid that recompiling a kernel on i386 will require several >>: > days. >>: >>: Chicken and the egg. To support i386 it must be recompiled, so you would >>: have to do it on another box anyway. >> >>The only people that will seriously want to use i386 these days are >>the folks that build embedded systems. Those you have to build on >>some host then deploy to the target system. >> >>There are some benefits to having i386 in the tree. However, there >>are also a number of different places in the tree where things are >>sub-optimal because we still have support for i386 in there. The >>desire to remove them is to make FreeBSD go faster on more modern >>hardware. > > > I think 6.0 is the place to drop 80386, not 5.x. I'm already working on a p4 > branch (jhb_no386) to remove 80396 support from HEAD, but I think 5.x should > be left as is in this regard. > I agree that 80386 support should not be removed from RELENG_5, but I don't see anything wrong with optmizing the common case and adding an extra 80386-specific hurdle to 5.x. Scott From owner-cvs-src@FreeBSD.ORG Tue Oct 19 21:49:42 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C000216A4CE; Tue, 19 Oct 2004 21:49:42 +0000 (GMT) Received: from VARK.MIT.EDU (VARK.MIT.EDU [18.95.3.179]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6113F43D2F; Tue, 19 Oct 2004 21:49:42 +0000 (GMT) (envelope-from das@FreeBSD.ORG) Received: from VARK.MIT.EDU (localhost [127.0.0.1]) by VARK.MIT.EDU (8.13.1/8.12.10) with ESMTP id i9JLo7Le013312; Tue, 19 Oct 2004 17:50:07 -0400 (EDT) (envelope-from das@FreeBSD.ORG) Received: (from das@localhost) by VARK.MIT.EDU (8.13.1/8.12.10/Submit) id i9JLo7lo013311; Tue, 19 Oct 2004 17:50:07 -0400 (EDT) (envelope-from das@FreeBSD.ORG) Date: Tue, 19 Oct 2004 17:50:07 -0400 From: David Schultz To: John Baldwin Message-ID: <20041019215007.GA13217@VARK.MIT.EDU> Mail-Followup-To: John Baldwin , "M. Warner Losh" , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <20041019071102.GA49717@FreeBSD.org> <20041019073145.GA29746@thingy.tbd.co.nz> <20041019.084324.106215221.imp@bsdimp.com> <200410191541.54269.jhb@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200410191541.54269.jhb@FreeBSD.org> cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG cc: "M. Warner Losh" Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 21:49:42 -0000 On Tue, Oct 19, 2004, John Baldwin wrote: > On Tuesday 19 October 2004 10:43 am, you wrote: > > In message: <20041019073145.GA29746@thingy.tbd.co.nz> > > > > Andrew Thompson writes: > > : > I am afraid that recompiling a kernel on i386 will require several > > : > days. > > : > > : Chicken and the egg. To support i386 it must be recompiled, so you would > > : have to do it on another box anyway. > > > > The only people that will seriously want to use i386 these days are > > the folks that build embedded systems. Those you have to build on > > some host then deploy to the target system. Yes, and very few of those folks are likely to want a relatively large, non-realtime, monolithic, multi-threaded OS kernel, much less a userland that even vaguely resembles a standard FreeBSD installation. Every time this issue comes up, someone points out that in fact, FreeBSD still runs on the 80386 that they just threw out. However, nobody ever presents an important reason for *wanting* to run FreeBSD on an 80386. > > There are some benefits to having i386 in the tree. However, there > > are also a number of different places in the tree where things are > > sub-optimal because we still have support for i386 in there. The > > desire to remove them is to make FreeBSD go faster on more modern > > hardware. > > I think 6.0 is the place to drop 80386, not 5.x. I'm already working on a p4 > branch (jhb_no386) to remove 80396 support from HEAD, but I think 5.x should > be left as is in this regard. Nice. \me can't wait for the day when developers are no longer required to spend time and effort to support anything older than a PPro. From owner-cvs-src@FreeBSD.ORG Tue Oct 19 21:50:30 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0519D16A4D0 for ; Tue, 19 Oct 2004 21:50:30 +0000 (GMT) Received: from mail6.speakeasy.net (mail6.speakeasy.net [216.254.0.206]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5B14343D48 for ; Tue, 19 Oct 2004 21:50:29 +0000 (GMT) (envelope-from john@baldwin.cx) Received: (qmail 17578 invoked from network); 19 Oct 2004 21:50:29 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 19 Oct 2004 21:50:28 -0000 Received: from zion.baldwin.cx (zion.baldwin.cx [192.168.0.7]) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id i9JLoPCE050735; Tue, 19 Oct 2004 17:50:25 -0400 (EDT) (envelope-from john@baldwin.cx) Received: from zion.baldwin.cx (localhost [127.0.0.1]) by zion.baldwin.cx (8.12.10/8.12.10) with ESMTP id i9JLoO8h005774; Tue, 19 Oct 2004 17:50:24 -0400 (EDT) (envelope-from john@zion.baldwin.cx) Received: from localhost (localhost [[UNIX: localhost]]) by zion.baldwin.cx (8.12.10/8.12.10/Submit) id i9JLoOJo005773; Tue, 19 Oct 2004 17:50:24 -0400 (EDT) (envelope-from john) From: John Baldwin To: "M. Warner Losh" Date: Tue, 19 Oct 2004 17:48:51 -0400 User-Agent: KMail/1.6 References: <20041019073145.GA29746@thingy.tbd.co.nz> <200410191541.54269.jhb@FreeBSD.org> <20041019.152902.02300007.imp@bsdimp.com> In-Reply-To: <20041019.152902.02300007.imp@bsdimp.com> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200410191748.51589.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 21:50:30 -0000 On Tuesday 19 October 2004 05:29 pm, M. Warner Losh wrote: > In message: <200410191541.54269.jhb@FreeBSD.org> > > John Baldwin writes: > : On Tuesday 19 October 2004 10:43 am, you wrote: > : > In message: <20041019073145.GA29746@thingy.tbd.co.nz> > : > > : > Andrew Thompson writes: > : > : > I am afraid that recompiling a kernel on i386 will require several > : > : > days. > : > : > : > : Chicken and the egg. To support i386 it must be recompiled, so you > : > : would have to do it on another box anyway. > : > > : > The only people that will seriously want to use i386 these days are > : > the folks that build embedded systems. Those you have to build on > : > some host then deploy to the target system. > : > > : > There are some benefits to having i386 in the tree. However, there > : > are also a number of different places in the tree where things are > : > sub-optimal because we still have support for i386 in there. The > : > desire to remove them is to make FreeBSD go faster on more modern > : > hardware. > : > : I think 6.0 is the place to drop 80386, not 5.x. I'm already working on > : a p4 branch (jhb_no386) to remove 80396 support from HEAD, but I think > : 5.x should be left as is in this regard. > > That was the agreement some months ago. 5.x would have it > de-emphasized to allow easier optimizations, and 6.0 would actually > remove it unless there was some really compelling reason not to. So > far, none of the arguments have come close to getting to compelling, > let alone really compelling. > > The low end of most intel based embedded is the Elan chipset these > days, and old 386 desktops are rare. Support for i386 negatively > impacts certain low level routines in a number of ways. But we've > been through all before when we came to the agreement: > > 5.x wouldn't support it out of the box, but the clueful can > coax 386 support out of the source tree. No one was to do > anything to break it. If someone accidentally did break it, > it was the resonsibility of the 386 fans to fix it. This has > happened at least once that I'm aware of. > > 6.x would remove support for i386 entirely, unless some really > compelling reason was presented that wasn't present in the > original discussion. > > David's commits do nothing to change the above, nor were they intended > to do so. Nothing in the ensuing discussion has changed it either, so > we're back to the original agreement. I'm posting it here for clarity. David's commits mean that the userland is no longer shared, and do so by optimizing htonl() and htons() of all things which are hardly critical path code for some unknown value with no benchmarks that I saw. That major change is not worth the very trivial (if any) gain I think. 80386 should just be flat killed in 6.0 and I think 5.x's userland can stay as it is. 5.x needs optimization work in the kernel, not userland. 4.x has the same "slower" userland that 5.x does, so I don't think "optimizing" userland hton[ls]() is going to buy us anything worthwhile, but it does obfuscate the code. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ From owner-cvs-src@FreeBSD.ORG Tue Oct 19 21:51:14 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 926B116A4CF; Tue, 19 Oct 2004 21:51:14 +0000 (GMT) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1690643D49; Tue, 19 Oct 2004 21:51:14 +0000 (GMT) (envelope-from scottl@freebsd.org) Received: from [192.168.254.11] (junior-wifi.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.12.11/8.12.10) with ESMTP id i9JLpYWF046185; Tue, 19 Oct 2004 15:51:34 -0600 (MDT) (envelope-from scottl@freebsd.org) Message-ID: <41758BF6.5020909@freebsd.org> Date: Tue, 19 Oct 2004 15:49:42 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.2) Gecko/20040929 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Andre Oppermann References: <200410192114.i9JLEvjQ001574@repoman.freebsd.org> In-Reply-To: <200410192114.i9JLEvjQ001574@repoman.freebsd.org> X-Enigmail-Version: 0.86.1.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=0.0 required=3.8 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on pooker.samsco.org cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/modules/ipdivert Makefile src/sys/netinet in_proto.c ip_divert.c ip_divert.h ip_fw2.c ip_fw_pfil.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 21:51:14 -0000 Andre Oppermann wrote: > andre 2004-10-19 21:14:57 UTC > > FreeBSD src repository > > Modified files: > sys/netinet in_proto.c ip_divert.c ip_divert.h > ip_fw2.c ip_fw_pfil.c > Added files: > sys/modules/ipdivert Makefile > Log: > Convert IPDIVERT into a loadable module. This makes use of the dynamic loadability > of protocols. The call to divert_packet() is done through a function pointer. All > semantics of IPDIVERT remain intact. If IPDIVERT is not loaded ipfw will refuse to > install divert rules and natd will complain about 'protocol not supported'. Once > it is loaded both will work and accept rules and open the divert socket. The module > can only be unloaded if no divert sockets are open. It does not close any divert > sockets when an unload is requested but will return EBUSY instead. > > Revision Changes Path > 1.1 +8 -0 src/sys/modules/ipdivert/Makefile (new) > 1.75 +0 -13 src/sys/netinet/in_proto.c > 1.101 +67 -8 src/sys/netinet/ip_divert.c > 1.4 +10 -4 src/sys/netinet/ip_divert.h > 1.82 +2 -4 src/sys/netinet/ip_fw2.c > 1.11 +13 -8 src/sys/netinet/ip_fw_pfil.c This is interesting. Have you measured performance/latency with this new scheme? Is it still possible to compile IPDIVERT into the kernel and avoid the indirect calls? Scott From owner-cvs-src@FreeBSD.ORG Tue Oct 19 21:51:27 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0BEC316A4CF for ; Tue, 19 Oct 2004 21:51:27 +0000 (GMT) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2F78C43D55 for ; Tue, 19 Oct 2004 21:51:26 +0000 (GMT) (envelope-from andre@freebsd.org) Received: (qmail 62327 invoked from network); 19 Oct 2004 21:50:21 -0000 Received: from unknown (HELO freebsd.org) ([62.48.0.53]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 19 Oct 2004 21:50:21 -0000 Message-ID: <41758C62.E27112C0@freebsd.org> Date: Tue, 19 Oct 2004 23:51:30 +0200 From: Andre Oppermann X-Mailer: Mozilla 4.8 [en] (Windows NT 5.0; U) X-Accept-Language: en MIME-Version: 1.0 To: Robert Watson References: <200410192135.i9JLZgmv002301@repoman.freebsd.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet ip_divert.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 21:51:27 -0000 Robert Watson wrote: > > rwatson 2004-10-19 21:35:42 UTC > > FreeBSD src repository > > Modified files: > sys/netinet ip_divert.c > Log: > Annotate a newly introduced race present due to the unloading of > protocols: it is possible for sockets to be created and attached > to the divert protocol between the test for sockets present and > successful unload of the registration handler. We will need to > explore more mature APIs for unregistering the protocol and then > draining consumers, or an atomic test-and-unregister mechanism. Thanks. I'll commit a little extended locking of that section in a few minutes. Is it possible for someone else to spin on the lock while we are holding it? If yes, it would be impossible to destroy the lock on the next line. The same problem is then resident in ipfw unloading as well. -- Andre From owner-cvs-src@FreeBSD.ORG Tue Oct 19 21:58:07 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6D1FA16A4CF for ; Tue, 19 Oct 2004 21:58:07 +0000 (GMT) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8DC9643D39 for ; Tue, 19 Oct 2004 21:58:06 +0000 (GMT) (envelope-from andre@freebsd.org) Received: (qmail 62421 invoked from network); 19 Oct 2004 21:57:02 -0000 Received: from unknown (HELO freebsd.org) ([62.48.0.53]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 19 Oct 2004 21:57:02 -0000 Message-ID: <41758DF2.D3C1BD26@freebsd.org> Date: Tue, 19 Oct 2004 23:58:10 +0200 From: Andre Oppermann X-Mailer: Mozilla 4.8 [en] (Windows NT 5.0; U) X-Accept-Language: en MIME-Version: 1.0 To: Scott Long References: <200410192114.i9JLEvjQ001574@repoman.freebsd.org> <41758BF6.5020909@freebsd.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/modules/ipdivert Makefile src/sys/netinetin_proto.c ip_divert.c ip_divert.h ip_fw2.c ip_fw_pfil.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 21:58:07 -0000 Scott Long wrote: > > Andre Oppermann wrote: > > andre 2004-10-19 21:14:57 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/netinet in_proto.c ip_divert.c ip_divert.h > > ip_fw2.c ip_fw_pfil.c > > Added files: > > sys/modules/ipdivert Makefile > > Log: > > Convert IPDIVERT into a loadable module. This makes use of the dynamic loadability > > of protocols. The call to divert_packet() is done through a function pointer. All > > semantics of IPDIVERT remain intact. If IPDIVERT is not loaded ipfw will refuse to > > install divert rules and natd will complain about 'protocol not supported'. Once > > it is loaded both will work and accept rules and open the divert socket. The module > > can only be unloaded if no divert sockets are open. It does not close any divert > > sockets when an unload is requested but will return EBUSY instead. > > > > Revision Changes Path > > 1.1 +8 -0 src/sys/modules/ipdivert/Makefile (new) > > 1.75 +0 -13 src/sys/netinet/in_proto.c > > 1.101 +67 -8 src/sys/netinet/ip_divert.c > > 1.4 +10 -4 src/sys/netinet/ip_divert.h > > 1.82 +2 -4 src/sys/netinet/ip_fw2.c > > 1.11 +13 -8 src/sys/netinet/ip_fw_pfil.c > > This is interesting. Have you measured performance/latency with this > new scheme? Is it still possible to compile IPDIVERT into the kernel > and avoid the indirect calls? IPDIVERT can hardly be called a performance/latency critical path. The entire copyout of the packet to userland for nat'ing and copyin again make the function pointer indirection such a small factor that it doesn't make any difference whatsoever. ipfw used to be called through function pointers until I converted it to use pfil_hooks. But even there we go though function pointers for every packet. The same is true for the entire ip_protox[] system and the whole socket layer going through protosw[]. -- Andre From owner-cvs-src@FreeBSD.ORG Tue Oct 19 21:58:16 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 09E7D16A515; Tue, 19 Oct 2004 21:58:16 +0000 (GMT) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7701743D41; Tue, 19 Oct 2004 21:58:15 +0000 (GMT) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (localhost [127.0.0.1]) by fledge.watson.org (8.13.1/8.13.1) with ESMTP id i9JLw5Om082430; Tue, 19 Oct 2004 17:58:05 -0400 (EDT) (envelope-from robert@fledge.watson.org) Received: from localhost (robert@localhost)i9JLw55G082427; Tue, 19 Oct 2004 17:58:05 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Tue, 19 Oct 2004 17:58:05 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: Andre Oppermann In-Reply-To: <41758C62.E27112C0@freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netinet ip_divert.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 21:58:16 -0000 On Tue, 19 Oct 2004, Andre Oppermann wrote: > > Annotate a newly introduced race present due to the unloading of > > protocols: it is possible for sockets to be created and attached > > to the divert protocol between the test for sockets present and > > successful unload of the registration handler. We will need to > > explore more mature APIs for unregistering the protocol and then > > draining consumers, or an atomic test-and-unregister mechanism. > > Thanks. > > I'll commit a little extended locking of that section in a few minutes. > > Is it possible for someone else to spin on the lock while we are holding > it? If yes, it would be impossible to destroy the lock on the next > line. The same problem is then resident in ipfw unloading as well. Yes. In fact, that's precisely what adaptive mutexes do, as our context switch time appears to be more expensive than to spin in most cases. We have started to address this and related problems in a couple of ways in a couple of places -- for example, with the MAC Framework, we count the number of threads that have entered the framework and wait until all threads drain before unloading (potentially starving the unloader). In PFIL, we drop packets that try to enter while a module is waiting for threads to drain so it can unload, avoiding the starvation problem. I believe Poul-Henning has also been working along these lines in the device driver code so that during unload there's an atomic decision point such that we stop letting new threads in once the decision to unload has been finalized. These models appear to be easier to implement than atomic "are we busy or unload" tests, and by putting part of the decision logic in the framework we avoid impossible-to-address races since we can quench the flow of calls into the module (avoiding "unload while the instruction pointer is in a function testing to see if it can be there"). As you point out, we don't have this problem a whole lot right now since load and unload events are pretty infrequent, but it would be nice to avoid adding new APIs that aren't designed to handle safe unload, in as much as is reasonable. For my own part, I'd be willing to simply say "you can't unload protocols once you've loaded them" because it simplifies the assumptions a great deal, but I recognize that that limits the usefulness of loadable protocols for the purposes of a rapid development cycle (load, unload, load, unload, ...) Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Principal Research Scientist, McAfee Research From owner-cvs-src@FreeBSD.ORG Tue Oct 19 22:00:35 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BE4E616A4D0 for ; Tue, 19 Oct 2004 22:00:35 +0000 (GMT) Received: from av6-1-sn2.hy.skanova.net (av6-1-sn2.hy.skanova.net [81.228.8.106]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1B0EF43D39 for ; Tue, 19 Oct 2004 22:00:35 +0000 (GMT) (envelope-from ertr1013@student.uu.se) Received: by av6-1-sn2.hy.skanova.net (Postfix, from userid 502) id C08ED37E42; Wed, 20 Oct 2004 00:00:33 +0200 (CEST) Received: from smtp2-2-sn2.hy.skanova.net (smtp2-2-sn2.hy.skanova.net [81.228.8.178]) by av6-1-sn2.hy.skanova.net (Postfix) with ESMTP id AA52537E50 for ; Wed, 20 Oct 2004 00:00:33 +0200 (CEST) Received: from falcon.midgard.homeip.net (h201n1fls24o1048.bredband.comhem.se [212.181.162.201]) by smtp2-2-sn2.hy.skanova.net (Postfix) with SMTP id B960937E45 for ; Wed, 20 Oct 2004 00:00:32 +0200 (CEST) Received: (qmail 98706 invoked by uid 1001); 19 Oct 2004 22:00:31 -0000 Date: Wed, 20 Oct 2004 00:00:31 +0200 From: Erik Trulsson To: John Baldwin , "M. Warner Losh" , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG Message-ID: <20041019220031.GA98675@falcon.midgard.homeip.net> Mail-Followup-To: John Baldwin , "M. Warner Losh" , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <20041019071102.GA49717@FreeBSD.org> <20041019073145.GA29746@thingy.tbd.co.nz> <20041019.084324.106215221.imp@bsdimp.com> <200410191541.54269.jhb@FreeBSD.org> <20041019215007.GA13217@VARK.MIT.EDU> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041019215007.GA13217@VARK.MIT.EDU> User-Agent: Mutt/1.5.6i Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 22:00:35 -0000 On Tue, Oct 19, 2004 at 05:50:07PM -0400, David Schultz wrote: > On Tue, Oct 19, 2004, John Baldwin wrote: > > On Tuesday 19 October 2004 10:43 am, you wrote: > > > In message: <20041019073145.GA29746@thingy.tbd.co.nz> > > > > > > Andrew Thompson writes: > > > : > I am afraid that recompiling a kernel on i386 will require several > > > : > days. > > > : > > > : Chicken and the egg. To support i386 it must be recompiled, so you would > > > : have to do it on another box anyway. > > > > > > The only people that will seriously want to use i386 these days are > > > the folks that build embedded systems. Those you have to build on > > > some host then deploy to the target system. > > Yes, and very few of those folks are likely to want a relatively > large, non-realtime, monolithic, multi-threaded OS kernel, much > less a userland that even vaguely resembles a standard FreeBSD > installation. > > Every time this issue comes up, someone points out that in fact, > FreeBSD still runs on the 80386 that they just threw out. > However, nobody ever presents an important reason for *wanting* to > run FreeBSD on an 80386. The only reason I am not running FreeBSD on an 80386 is that the PSU in my 80386sx based computer gave up a few months ago (or at least something power-related did.) Until then I was happily running 4.10-stable on it and using it as a firewall/gateway. If it was still working and support for FPU-less systems hadn't been dropped I would have upgraded it to 5-STABLE eventually (along with my main machine.) Why would I want to use such an old machine? Easy - because I had it and couldn't (and still can't) afford to buy a modern machine. I am sure I am not the only one in that position. > Nice. \me can't wait for the day when developers are no longer > required to spend time and effort to support anything older than a PPro. That day will hopefully be far in the future. Personally I don't have anything as modern as a PPro. -- Erik Trulsson ertr1013@student.uu.se From owner-cvs-src@FreeBSD.ORG Tue Oct 19 22:08:14 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 210D216A4CE; Tue, 19 Oct 2004 22:08:14 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0223E43D31; Tue, 19 Oct 2004 22:08:14 +0000 (GMT) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9JM8Dqx003328; Tue, 19 Oct 2004 22:08:13 GMT (envelope-from andre@repoman.freebsd.org) Received: (from andre@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9JM8Dds003327; Tue, 19 Oct 2004 22:08:13 GMT (envelope-from andre) Message-Id: <200410192208.i9JM8Dds003327@repoman.freebsd.org> From: Andre Oppermann Date: Tue, 19 Oct 2004 22:08:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netinet ip_divert.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 22:08:14 -0000 andre 2004-10-19 22:08:13 UTC FreeBSD src repository Modified files: sys/netinet ip_divert.c Log: Slightly extend the locking during unload to fully cover the protocol deregistration. This does not entirely close the race but narrows the even previously extremely small chance of a race some more. Revision Changes Path 1.103 +6 -5 src/sys/netinet/ip_divert.c From owner-cvs-src@FreeBSD.ORG Tue Oct 19 22:09:09 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2040816A4CE for ; Tue, 19 Oct 2004 22:09:08 +0000 (GMT) Received: from av13-2-sn4.m-sp.skanova.net (av13-2-sn4.m-sp.skanova.net [81.228.10.103]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7CF4F43D41 for ; Tue, 19 Oct 2004 22:09:07 +0000 (GMT) (envelope-from ertr1013@student.uu.se) Received: by av13-2-sn4.m-sp.skanova.net (Postfix, from userid 502) id 610E637E45; Wed, 20 Oct 2004 00:09:06 +0200 (CEST) Received: from smtp4-1-sn4.m-sp.skanova.net (smtp4-1-sn4.m-sp.skanova.net [81.228.10.181]) by av13-2-sn4.m-sp.skanova.net (Postfix) with ESMTP id 5304037E42 for ; Wed, 20 Oct 2004 00:09:06 +0200 (CEST) Received: from falcon.midgard.homeip.net (h201n1fls24o1048.bredband.comhem.se [212.181.162.201]) by smtp4-1-sn4.m-sp.skanova.net (Postfix) with SMTP id D9FB437E45 for ; Wed, 20 Oct 2004 00:09:04 +0200 (CEST) Received: (qmail 98852 invoked by uid 1001); 19 Oct 2004 22:09:04 -0000 Date: Wed, 20 Oct 2004 00:09:04 +0200 From: Erik Trulsson To: John Baldwin Message-ID: <20041019220904.GA98840@falcon.midgard.homeip.net> Mail-Followup-To: John Baldwin , "M. Warner Losh" , cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org References: <20041019073145.GA29746@thingy.tbd.co.nz> <200410191541.54269.jhb@FreeBSD.org> <20041019.152902.02300007.imp@bsdimp.com> <200410191748.51589.jhb@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200410191748.51589.jhb@FreeBSD.org> User-Agent: Mutt/1.5.6i cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org cc: "M. Warner Losh" Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 22:09:10 -0000 On Tue, Oct 19, 2004 at 05:48:51PM -0400, John Baldwin wrote: > On Tuesday 19 October 2004 05:29 pm, M. Warner Losh wrote: > > In message: <200410191541.54269.jhb@FreeBSD.org> > > > > John Baldwin writes: > > : On Tuesday 19 October 2004 10:43 am, you wrote: > > : > In message: <20041019073145.GA29746@thingy.tbd.co.nz> > > : > > > : > Andrew Thompson writes: > > : > : > I am afraid that recompiling a kernel on i386 will require several > > : > : > days. > > : > : > > : > : Chicken and the egg. To support i386 it must be recompiled, so you > > : > : would have to do it on another box anyway. > > : > > > : > The only people that will seriously want to use i386 these days are > > : > the folks that build embedded systems. Those you have to build on > > : > some host then deploy to the target system. > > : > > > : > There are some benefits to having i386 in the tree. However, there > > : > are also a number of different places in the tree where things are > > : > sub-optimal because we still have support for i386 in there. The > > : > desire to remove them is to make FreeBSD go faster on more modern > > : > hardware. > > : > > : I think 6.0 is the place to drop 80386, not 5.x. I'm already working on > > : a p4 branch (jhb_no386) to remove 80396 support from HEAD, but I think > > : 5.x should be left as is in this regard. > > > > That was the agreement some months ago. 5.x would have it > > de-emphasized to allow easier optimizations, and 6.0 would actually > > remove it unless there was some really compelling reason not to. So > > far, none of the arguments have come close to getting to compelling, > > let alone really compelling. > > > > The low end of most intel based embedded is the Elan chipset these > > days, and old 386 desktops are rare. Support for i386 negatively > > impacts certain low level routines in a number of ways. But we've > > been through all before when we came to the agreement: > > > > 5.x wouldn't support it out of the box, but the clueful can > > coax 386 support out of the source tree. No one was to do > > anything to break it. If someone accidentally did break it, > > it was the resonsibility of the 386 fans to fix it. This has > > happened at least once that I'm aware of. > > > > 6.x would remove support for i386 entirely, unless some really > > compelling reason was presented that wasn't present in the > > original discussion. > > > > David's commits do nothing to change the above, nor were they intended > > to do so. Nothing in the ensuing discussion has changed it either, so > > we're back to the original agreement. I'm posting it here for clarity. > > David's commits mean that the userland is no longer shared, and do so by > optimizing htonl() and htons() of all things which are hardly critical path > code for some unknown value with no benchmarks that I saw. That major change > is not worth the very trivial (if any) gain I think. 80386 should just be > flat killed in 6.0 and I think 5.x's userland can stay as it is. 5.x needs > optimization work in the kernel, not userland. 4.x has the same "slower" > userland that 5.x does, so I don't think "optimizing" userland hton[ls]() is > going to buy us anything worthwhile, but it does obfuscate the code. Changing libc in that way would also mean that you would not be able to create a statically linked binary on a modern machine and then run it on an 80386 (not without jumping through an inordinate number of hoops anyway.) Dropping 80386 support in 6-CURRENT is one thing and I don't have any real problem with that. Dropping/reducing support for a CPU in -STABLE (which is what 5.x will be as soon as 5.3 is out) is a big POLA violation in my opinion. (And just for the record I disagree with the decisions to drop support for FPU-less systems and to remove 80386 support from the default kernel-configuration, but that was at least done in -CURRENT and not -STABLE.) -- Erik Trulsson ertr1013@student.uu.se From owner-cvs-src@FreeBSD.ORG Tue Oct 19 22:11:29 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 56B2916A4CE; Tue, 19 Oct 2004 22:11:29 +0000 (GMT) Received: from mail.vicor-nb.com (bigwoop.vicor-nb.com [208.206.78.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3055D43D46; Tue, 19 Oct 2004 22:11:29 +0000 (GMT) (envelope-from julian@elischer.org) Received: from elischer.org (julian.vicor-nb.com [208.206.78.97]) by mail.vicor-nb.com (Postfix) with ESMTP id 0D84D7A403; Tue, 19 Oct 2004 15:11:29 -0700 (PDT) Message-ID: <41759110.6010005@elischer.org> Date: Tue, 19 Oct 2004 15:11:28 -0700 From: Julian Elischer User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.3.1) Gecko/20030516 X-Accept-Language: en, hu MIME-Version: 1.0 To: Andre Oppermann References: <200410191513.i9JFDUbf072176@repoman.freebsd.org> <417532A2.9000901@errno.com> <41753522.1E39FEAE@freebsd.org> <200410192329.46723.max@love2party.net> <41758B35.D5340AEA@freebsd.org> In-Reply-To: <41758B35.D5340AEA@freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: Max Laier cc: src-committers@FreeBSD.org cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Sam Leffler Subject: Re: cvs commit: src/sys/sys protosw.h src/sys/kern uipc_domain.cuipc_socket2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 22:11:29 -0000 Andre Oppermann wrote: > > > >>Another point: If you really want to keep the possibility to remove a >>protocol, you have to introduce some busy counter that pervents removal while >>the kernel is inside a protocol function. This has to be handled by the >>protocol itself, but it has to be taken care of somehow. >> each protocol array entry could have either a mutex or a refcount or both.. >> >> > >Yes, the protocol has to be able to handle its own unloading. I have >documented that fact. If a protocol in unable to do so it should simply >refuse any unload attempts with EBUSY. > > > From owner-cvs-src@FreeBSD.ORG Tue Oct 19 22:16:22 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AC41B16A4CF for ; Tue, 19 Oct 2004 22:16:22 +0000 (GMT) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id AC0FA43D69 for ; Tue, 19 Oct 2004 22:16:21 +0000 (GMT) (envelope-from andre@freebsd.org) Received: (qmail 62595 invoked from network); 19 Oct 2004 22:15:17 -0000 Received: from unknown (HELO freebsd.org) ([62.48.0.53]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 19 Oct 2004 22:15:17 -0000 Message-ID: <41759239.A0F5B1DE@freebsd.org> Date: Wed, 20 Oct 2004 00:16:25 +0200 From: Andre Oppermann X-Mailer: Mozilla 4.8 [en] (Windows NT 5.0; U) X-Accept-Language: en MIME-Version: 1.0 To: Robert Watson References: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netinet ip_divert.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 22:16:22 -0000 Robert Watson wrote: > > On Tue, 19 Oct 2004, Andre Oppermann wrote: > > > > Annotate a newly introduced race present due to the unloading of > > > protocols: it is possible for sockets to be created and attached > > > to the divert protocol between the test for sockets present and > > > successful unload of the registration handler. We will need to > > > explore more mature APIs for unregistering the protocol and then > > > draining consumers, or an atomic test-and-unregister mechanism. > > > > Thanks. > > > > I'll commit a little extended locking of that section in a few minutes. > > > > Is it possible for someone else to spin on the lock while we are holding > > it? If yes, it would be impossible to destroy the lock on the next > > line. The same problem is then resident in ipfw unloading as well. > > Yes. In fact, that's precisely what adaptive mutexes do, as our context > switch time appears to be more expensive than to spin in most cases. > > We have started to address this and related problems in a couple of ways > in a couple of places -- for example, with the MAC Framework, we count the > number of threads that have entered the framework and wait until all > threads drain before unloading (potentially starving the unloader). In > PFIL, we drop packets that try to enter while a module is waiting for > threads to drain so it can unload, avoiding the starvation problem. I > believe Poul-Henning has also been working along these lines in the device > driver code so that during unload there's an atomic decision point such > that we stop letting new threads in once the decision to unload has been > finalized. These models appear to be easier to implement than atomic "are > we busy or unload" tests, and by putting part of the decision logic in the > framework we avoid impossible-to-address races since we can quench the > flow of calls into the module (avoiding "unload while the instruction > pointer is in a function testing to see if it can be there"). Hmm... I'll take a look at those attempts and see what I can come up with to get some general solution for the protocol cases. The approach of callout_drain() looks promising though. > As you point out, we don't have this problem a whole lot right now since > load and unload events are pretty infrequent, but it would be nice to > avoid adding new APIs that aren't designed to handle safe unload, in as > much as is reasonable. For my own part, I'd be willing to simply say "you > can't unload protocols once you've loaded them" because it simplifies the > assumptions a great deal, but I recognize that that limits the usefulness > of loadable protocols for the purposes of a rapid development cycle (load, > unload, load, unload, ...) Exactly. I want to leave this decision with the module writer. You can always get this semantics simply with returning EBUSY on unload attempts. And depending on what you protocol module does the race can be so small that chances to get hit by it are so low that it almost doesn't matter. -- Andre From owner-cvs-src@FreeBSD.ORG Tue Oct 19 22:18:50 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 03FBB16A4D0 for ; Tue, 19 Oct 2004 22:18:50 +0000 (GMT) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1C7B143D3F for ; Tue, 19 Oct 2004 22:18:49 +0000 (GMT) (envelope-from andre@freebsd.org) Received: (qmail 62617 invoked from network); 19 Oct 2004 22:17:44 -0000 Received: from unknown (HELO freebsd.org) ([62.48.0.53]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 19 Oct 2004 22:17:44 -0000 Message-ID: <417592CD.64092D9E@freebsd.org> Date: Wed, 20 Oct 2004 00:18:53 +0200 From: Andre Oppermann X-Mailer: Mozilla 4.8 [en] (Windows NT 5.0; U) X-Accept-Language: en MIME-Version: 1.0 To: Julian Elischer References: <200410191513.i9JFDUbf072176@repoman.freebsd.org> <417532A2.9000901@errno.com> <41753522.1E39FEAE@freebsd.org> <200410192329.46723.max@love2party.net> <41758B35.D5340AEA@freebsd.org> <41759110.6010005@elischer.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: Max Laier cc: src-committers@FreeBSD.org cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Sam Leffler Subject: Re: cvs commit: src/sys/sys protosw.h src/sys/kern uipc_domain.cuipc_socket2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 22:18:50 -0000 Julian Elischer wrote: > > Andre Oppermann wrote: > >>Another point: If you really want to keep the possibility to remove a > >>protocol, you have to introduce some busy counter that pervents removal while > >>the kernel is inside a protocol function. This has to be handled by the > >>protocol itself, but it has to be taken care of somehow. > >> > > each protocol array entry could have either a mutex or a refcount or both.. That is unpractical. Please have a deep look into the protosw[] mechanism. Any such refcounting has to be done on a protocol specific level. -- Andre From owner-cvs-src@FreeBSD.ORG Tue Oct 19 22:19:21 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2901416A4CF for ; Tue, 19 Oct 2004 22:19:21 +0000 (GMT) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id A8D4143D41 for ; Tue, 19 Oct 2004 22:19:20 +0000 (GMT) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (localhost [127.0.0.1]) by fledge.watson.org (8.13.1/8.13.1) with ESMTP id i9JMJAKf083088; Tue, 19 Oct 2004 18:19:10 -0400 (EDT) (envelope-from robert@fledge.watson.org) Received: from localhost (robert@localhost)i9JMJAQa083085; Tue, 19 Oct 2004 18:19:10 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Tue, 19 Oct 2004 18:19:10 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: Julian Elischer In-Reply-To: <41759110.6010005@elischer.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: src-committers@FreeBSD.org cc: Andre Oppermann cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Sam Leffler cc: Max Laier Subject: Re: cvs commit: src/sys/sys protosw.h src/sys/kern uipc_domain.cuipc_socket2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 22:19:21 -0000 On Tue, 19 Oct 2004, Julian Elischer wrote: > >>Another point: If you really want to keep the possibility to remove a > >>protocol, you have to introduce some busy counter that pervents removal while > >>the kernel is inside a protocol function. This has to be handled by the > >>protocol itself, but it has to be taken care of somehow. > > each protocol array entry could have either a mutex or a refcount or > both.. The trick here is to get just enough synchronization to not break, but not enough to hurt. That's one of the reasons why I feel like the heavier weight approaches taken elsewhere may not be appropriate here. I guess no one is talking about loading UDP, but at the same time if we're going to have generic loadable protocol support, it would be nice to get a pretty clean API that would meet the requirements of higher volume protocols. As I mentioned in a previous e-mail, it might almost be desirable to say "no unloading" and simply avoid the hard problems, since atomic add is easy whereas atomic remove is hard. Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Principal Research Scientist, McAfee Research From owner-cvs-src@FreeBSD.ORG Tue Oct 19 22:28:50 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C219C16A4CE; Tue, 19 Oct 2004 22:28:50 +0000 (GMT) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6E3C943D2F; Tue, 19 Oct 2004 22:28:50 +0000 (GMT) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (localhost [127.0.0.1]) by fledge.watson.org (8.13.1/8.13.1) with ESMTP id i9JMSekd083361; Tue, 19 Oct 2004 18:28:40 -0400 (EDT) (envelope-from robert@fledge.watson.org) Received: from localhost (robert@localhost)i9JMSe34083358; Tue, 19 Oct 2004 18:28:40 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Tue, 19 Oct 2004 18:28:40 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: Andre Oppermann In-Reply-To: <41759239.A0F5B1DE@freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netinet ip_divert.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 22:28:50 -0000 On Wed, 20 Oct 2004, Andre Oppermann wrote: > Hmm... I'll take a look at those attempts and see what I can come up > with to get some general solution for the protocol cases. The approach > of callout_drain() looks promising though. BTW, it looks like the divert pcb zone uses UMA_ZONE_NOFREE so that the memory is type-stable (presumably in particular for the sysctl), so all memory allocated by the divert module for pcbs is likely leaked on unload. I'm beginning to think we should just block unload for divert and solve the unload problem another day for another protocol... Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Principal Research Scientist, McAfee Research From owner-cvs-src@FreeBSD.ORG Tue Oct 19 22:30:30 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BED1116A4D0 for ; Tue, 19 Oct 2004 22:30:30 +0000 (GMT) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id CEB5143D1D for ; Tue, 19 Oct 2004 22:30:29 +0000 (GMT) (envelope-from andre@freebsd.org) Received: (qmail 62729 invoked from network); 19 Oct 2004 22:29:25 -0000 Received: from unknown (HELO freebsd.org) ([62.48.0.53]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 19 Oct 2004 22:29:25 -0000 Message-ID: <41759589.B2EE8BA9@freebsd.org> Date: Wed, 20 Oct 2004 00:30:33 +0200 From: Andre Oppermann X-Mailer: Mozilla 4.8 [en] (Windows NT 5.0; U) X-Accept-Language: en MIME-Version: 1.0 To: Robert Watson References: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: src-committers@FreeBSD.org cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Julian Elischer cc: Sam Leffler cc: Max Laier Subject: Re: cvs commit: src/sys/sys protosw.h src/sys/kern uipc_domain.cuipc_socket2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 22:30:30 -0000 Robert Watson wrote: > > On Tue, 19 Oct 2004, Julian Elischer wrote: > > > >>Another point: If you really want to keep the possibility to remove a > > >>protocol, you have to introduce some busy counter that pervents removal while > > >>the kernel is inside a protocol function. This has to be handled by the > > >>protocol itself, but it has to be taken care of somehow. > > > > each protocol array entry could have either a mutex or a refcount or > > both.. > > The trick here is to get just enough synchronization to not break, but not > enough to hurt. That's one of the reasons why I feel like the heavier > weight approaches taken elsewhere may not be appropriate here. I guess no > one is talking about loading UDP, but at the same time if we're going to > have generic loadable protocol support, it would be nice to get a pretty > clean API that would meet the requirements of higher volume protocols. As > I mentioned in a previous e-mail, it might almost be desirable to say "no > unloading" and simply avoid the hard problems, since atomic add is easy > whereas atomic remove is hard. No no. Even unloading high volume protocols is not that difficult. When giant protects the manipulations of the protosw[] we can be certain that no new requests will come in for the unregistered protocol. What we are not certain about is whether there still is some previous process inside our functions. But this is something the protocol has to deal with. There is no general solution as there are so many different protocols doing so many different things. In general a protocol that wants to unload first has to stop any new sockets from popping up (from above and below) and then it has to properly close/clear/shutdown all existing sockets. Once this is done it can unregister itself and proceed with unloading. This whole thing is not as bleak as some might think it is. :-) And unloading TCP through a SSH session is certainly not recommended. ;-) -- Andre From owner-cvs-src@FreeBSD.ORG Tue Oct 19 22:35:43 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 97A6216A4CE; Tue, 19 Oct 2004 22:35:43 +0000 (GMT) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.173]) by mx1.FreeBSD.org (Postfix) with ESMTP id 170DF43D48; Tue, 19 Oct 2004 22:35:43 +0000 (GMT) (envelope-from max@love2party.net) Received: from [212.227.126.206] (helo=mrelayng.kundenserver.de) by moutng.kundenserver.de with esmtp (Exim 3.35 #1) id 1CK2Zy-00060C-00; Wed, 20 Oct 2004 00:35:42 +0200 Received: from [217.227.158.113] (helo=donor.laier.local) by mrelayng.kundenserver.de with asmtp (TLSv1:RC4-MD5:128) (Exim 3.35 #1) id 1CK2Zw-0005yE-00; Wed, 20 Oct 2004 00:35:41 +0200 From: Max Laier To: Andre Oppermann Date: Wed, 20 Oct 2004 00:35:10 +0200 User-Agent: KMail/1.7 References: <200410191513.i9JFDUbf072176@repoman.freebsd.org> <200410192329.46723.max@love2party.net> <41758B35.D5340AEA@freebsd.org> In-Reply-To: <41758B35.D5340AEA@freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3269231.sYBdOc9t0i"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200410200035.19752.max@love2party.net> X-Provags-ID: kundenserver.de abuse@kundenserver.de auth:61c499deaeeba3ba5be80f48ecc83056 cc: Sam Leffler cc: src-committers@freebsd.org cc: cvs-all@freebsd.org cc: cvs-src@freebsd.org Subject: Re: cvs commit: src/sys/sys protosw.h src/sys/kern uipc_domain.cuipc_socket2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 22:35:43 -0000 --nextPart3269231.sYBdOc9t0i Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Tuesday 19 October 2004 23:46, Andre Oppermann wrote: <...> > > problems. For example, in ip_icmp.c line 457 ff we have: > > > > ctlfunc =3D > > inetsw[ip_protox[icp->icmp_ip.ip_p]].pr_ctlinput; if (ctlfunc) > > (*ctlfunc)(code, (struct sockaddr *)&icmpsrc, > > (void *)&icp->icmp_ip); > > Ok, this one is easy to fix. I'll audit the code for any other of these > abuses. One of many, I am afraid. > > This is clearly a problem if we can remove protocols. There might be mo= re > > places where we (temporary) cache values from the protocol array. Anoth= er > > problem might be that we check for protocol existence early and assume > > that this remains true ... > > Well, too bad if some code tries to remember this. Doesn't hurt then. > From my reading of many parts of the netinet/* code this is usually not > a problem and the code is rather well behaved. I refuse to take this > argument as reason to not have loadable protocols. "... usually ... rather ..." I really urge you, to reconsider. Many have=20 argumented in the same way. I understand that it is nice to have this=20 possibility, but it *does* cause *real* problems! > > I'd suggest, that you remove the possibility to remove protocols > > completely. It is very likely that there are no races with adding > > protocols - though it might take "some time" for the protocol to be ful= ly > > useable - but the removal is critical. > > I don't think it should be a one-way street. To be able to unload > protocols is an important but seldomly used function and it's certainly n= ot > that a crash is guarnteed. Far from it. > > > We also have to check that really all code can cope with the addition a= nd > > properly reinitializes it's view of the protocol arrays. > > The point of the protocol arrays is precisely to have them as the only > and sole place where such information is stored. Any code that copies > any part of it to its own private structures is horribly broken by design > and must be fixed anyway! (BTW: I'm not aware of any code within netinet= /* > that does this.) I mentioned one above, I am sure there are others. Some as obvious as the o= ne=20 above, some less so ... > > Another point: If you really want to keep the possibility to remove a > > protocol, you have to introduce some busy counter that pervents removal > > while the kernel is inside a protocol function. This has to be handled = by > > the protocol itself, but it has to be taken care of somehow. > > Yes, the protocol has to be able to handle its own unloading. I have > documented that fact. If a protocol in unable to do so it should simply > refuse any unload attempts with EBUSY. Divert can be paniced with the sysctl code, btw. You have something like: lock; unlock; SYSCTL_OUT; <-- this can be made to take *some* time lock; <-- this will panic once the lock is destroyed And there are other problems. Yes, it is not a problem in the common case, = but=20 you have to account for edge cases as well! =2D-=20 /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --nextPart3269231.sYBdOc9t0i Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQBBdZanXyyEoT62BG0RAqacAJ4p7xH50oz47gf+QjkMVZd9FeSvgACfUj4e bC0+2SLN9ZjnBlbH+eoX/S0= =mwLt -----END PGP SIGNATURE----- --nextPart3269231.sYBdOc9t0i-- From owner-cvs-src@FreeBSD.ORG Tue Oct 19 22:37:10 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9B62116A4CE; Tue, 19 Oct 2004 22:37:10 +0000 (GMT) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6468343D31; Tue, 19 Oct 2004 22:37:10 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id i9JMbsPS008284; Tue, 19 Oct 2004 15:37:54 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id i9JMbs0N008283; Tue, 19 Oct 2004 15:37:54 -0700 Date: Tue, 19 Oct 2004 15:37:54 -0700 From: Brooks Davis To: Robert Watson Message-ID: <20041019223754.GA16741@odin.ac.hmc.edu> References: <41759110.6010005@elischer.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="YZ5djTAD1cGYuMQK" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu cc: src-committers@FreeBSD.org cc: Andre Oppermann cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Julian Elischer cc: Sam Leffler cc: Max Laier Subject: Re: cvs commit: src/sys/sys protosw.h src/sys/kern uipc_domain.cuipc_socket2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 22:37:10 -0000 --YZ5djTAD1cGYuMQK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 19, 2004 at 06:19:10PM -0400, Robert Watson wrote: >=20 > On Tue, 19 Oct 2004, Julian Elischer wrote: >=20 > > >>Another point: If you really want to keep the possibility to remove a > > >>protocol, you have to introduce some busy counter that pervents remov= al while > > >>the kernel is inside a protocol function. This has to be handled by t= he > > >>protocol itself, but it has to be taken care of somehow. > >=20 > > each protocol array entry could have either a mutex or a refcount or > > both..=20 >=20 > The trick here is to get just enough synchronization to not break, but not > enough to hurt. That's one of the reasons why I feel like the heavier > weight approaches taken elsewhere may not be appropriate here. I guess no > one is talking about loading UDP, but at the same time if we're going to > have generic loadable protocol support, it would be nice to get a pretty > clean API that would meet the requirements of higher volume protocols. As > I mentioned in a previous e-mail, it might almost be desirable to say "no > unloading" and simply avoid the hard problems, since atomic add is easy > whereas atomic remove is hard. One of the things I've been looking at with interfaces is trying to squash the really big races (mostly dummynet) by avoiding holding a pointer to an interface any longer then necessicary. Instead I'm planning to hold interface indexes instead. I'm planning to introduce a "struct ifnet dead_if" to return when the index is no longer valid. It will attempt to have sane no-op values so when the big races are lost it doesn't matter. At least with interface removals, the small races don't seem to actually happen much in practice so ignoring them may well be a better solution then requiring a refcount every time you need to touch an ifp. Once I get ipfw6 working, I'm planning to take a look at this some more. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --YZ5djTAD1cGYuMQK Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFBdZdCXY6L6fI4GtQRAtrfAJ4xmwfExMtbgdEVcN9Z9j9avj0AQwCfaltj XdWOky32tRp2d6i12ArYYLQ= =r6tn -----END PGP SIGNATURE----- --YZ5djTAD1cGYuMQK-- From owner-cvs-src@FreeBSD.ORG Tue Oct 19 22:51:20 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E0B3C16A4CE; Tue, 19 Oct 2004 22:51:20 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BFCE543D53; Tue, 19 Oct 2004 22:51:20 +0000 (GMT) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9JMpK1Q004748; Tue, 19 Oct 2004 22:51:20 GMT (envelope-from andre@repoman.freebsd.org) Received: (from andre@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9JMpKDk004747; Tue, 19 Oct 2004 22:51:20 GMT (envelope-from andre) Message-Id: <200410192251.i9JMpKDk004747@repoman.freebsd.org> From: Andre Oppermann Date: Tue, 19 Oct 2004 22:51:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netinet ip_divert.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 22:51:21 -0000 andre 2004-10-19 22:51:20 UTC FreeBSD src repository Modified files: sys/netinet ip_divert.c Log: Destroy the UMA zone on unload. Revision Changes Path 1.104 +1 -0 src/sys/netinet/ip_divert.c From owner-cvs-src@FreeBSD.ORG Tue Oct 19 22:51:25 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4462516A4F0 for ; Tue, 19 Oct 2004 22:51:25 +0000 (GMT) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6905A43D55 for ; Tue, 19 Oct 2004 22:51:24 +0000 (GMT) (envelope-from andre@freebsd.org) Received: (qmail 62901 invoked from network); 19 Oct 2004 22:50:19 -0000 Received: from unknown (HELO freebsd.org) ([62.48.0.53]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 19 Oct 2004 22:50:19 -0000 Message-ID: <41759A70.11BF9238@freebsd.org> Date: Wed, 20 Oct 2004 00:51:28 +0200 From: Andre Oppermann X-Mailer: Mozilla 4.8 [en] (Windows NT 5.0; U) X-Accept-Language: en MIME-Version: 1.0 To: Robert Watson References: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netinet ip_divert.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 22:51:26 -0000 Robert Watson wrote: > > On Wed, 20 Oct 2004, Andre Oppermann wrote: > > > Hmm... I'll take a look at those attempts and see what I can come up > > with to get some general solution for the protocol cases. The approach > > of callout_drain() looks promising though. > > BTW, it looks like the divert pcb zone uses UMA_ZONE_NOFREE so that the > memory is type-stable (presumably in particular for the sysctl), so all > memory allocated by the divert module for pcbs is likely leaked on unload. > I'm beginning to think we should just block unload for divert and solve > the unload problem another day for another protocol... It is indeed an oversight by me not to uma_zdestroy() the zone on unload. The sysctl handler uses normal malloc. -- Andre From owner-cvs-src@FreeBSD.ORG Tue Oct 19 22:52:05 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B550416A4CE; Tue, 19 Oct 2004 22:52:05 +0000 (GMT) Received: from VARK.MIT.EDU (VARK.MIT.EDU [18.95.3.179]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5857C43D41; Tue, 19 Oct 2004 22:52:05 +0000 (GMT) (envelope-from das@FreeBSD.ORG) Received: from VARK.MIT.EDU (localhost [127.0.0.1]) by VARK.MIT.EDU (8.13.1/8.12.10) with ESMTP id i9JMqVtp013672; Tue, 19 Oct 2004 18:52:31 -0400 (EDT) (envelope-from das@FreeBSD.ORG) Received: (from das@localhost) by VARK.MIT.EDU (8.13.1/8.12.10/Submit) id i9JMqV9g013671; Tue, 19 Oct 2004 18:52:31 -0400 (EDT) (envelope-from das@FreeBSD.ORG) Date: Tue, 19 Oct 2004 18:52:31 -0400 From: David Schultz To: src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG Message-ID: <20041019225231.GA13522@VARK.MIT.EDU> Mail-Followup-To: src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <20041019071102.GA49717@FreeBSD.org> <20041019073145.GA29746@thingy.tbd.co.nz> <20041019.084324.106215221.imp@bsdimp.com> <200410191541.54269.jhb@FreeBSD.org> <20041019215007.GA13217@VARK.MIT.EDU> <20041019220031.GA98675@falcon.midgard.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041019220031.GA98675@falcon.midgard.homeip.net> Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 22:52:05 -0000 On Wed, Oct 20, 2004, Erik Trulsson wrote: > > > > The only people that will seriously want to use i386 these days are > > > > the folks that build embedded systems. Those you have to build on > > > > some host then deploy to the target system. > > > > Yes, and very few of those folks are likely to want a relatively > > large, non-realtime, monolithic, multi-threaded OS kernel, much > > less a userland that even vaguely resembles a standard FreeBSD > > installation. > > > > Every time this issue comes up, someone points out that in fact, > > FreeBSD still runs on the 80386 that they just threw out. > > However, nobody ever presents an important reason for *wanting* to > > run FreeBSD on an 80386. > > The only reason I am not running FreeBSD on an 80386 is that the PSU in > my 80386sx based computer gave up a few months ago (or at least > something power-related did.) Until then I was happily running > 4.10-stable on it and using it as a firewall/gateway. Okay, so (a) your 80386 doesn't work anymore and (b) you still seem to be getting along fine without it. I maintain that it is still the case that nobody has presented a good reason why the 80386 is an important platform for future versions of FreeBSD. > If it was still working and support for FPU-less systems hadn't been > dropped I would have upgraded it to 5-STABLE eventually (along with my > main machine.) > Why would I want to use such an old machine? Easy - because I had it > and couldn't (and still can't) afford to buy a modern machine. > I am sure I am not the only one in that position. First of all, your 80386 (if it worked) would probably be much snappier running FreeBSD 3.X or 4.X or NetBSD 1.[2-5]. Second, you can purchase a Linksys gateway for $20, whereas a 386 would consume more than $20 of power in a few months. > > Nice. \me can't wait for the day when developers are no longer > > required to spend time and effort to support anything older than a PPro. > > That day will hopefully be far in the future. Personally I don't have > anything as modern as a PPro. Don't worry, it will be. I can dream, can't I? From owner-cvs-src@FreeBSD.ORG Tue Oct 19 22:55:03 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DDBD216A4CE; Tue, 19 Oct 2004 22:55:03 +0000 (GMT) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7F1D843D49; Tue, 19 Oct 2004 22:55:03 +0000 (GMT) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (localhost [127.0.0.1]) by fledge.watson.org (8.13.1/8.13.1) with ESMTP id i9JMsrKZ084112; Tue, 19 Oct 2004 18:54:53 -0400 (EDT) (envelope-from robert@fledge.watson.org) Received: from localhost (robert@localhost)i9JMsrjx084109; Tue, 19 Oct 2004 18:54:53 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Tue, 19 Oct 2004 18:54:53 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: Andre Oppermann In-Reply-To: <41759A70.11BF9238@freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netinet ip_divert.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 22:55:04 -0000 On Wed, 20 Oct 2004, Andre Oppermann wrote: > Robert Watson wrote: > > > > On Wed, 20 Oct 2004, Andre Oppermann wrote: > > > > > Hmm... I'll take a look at those attempts and see what I can come up > > > with to get some general solution for the protocol cases. The approach > > > of callout_drain() looks promising though. > > > > BTW, it looks like the divert pcb zone uses UMA_ZONE_NOFREE so that the > > memory is type-stable (presumably in particular for the sysctl), so all > > memory allocated by the divert module for pcbs is likely leaked on unload. > > I'm beginning to think we should just block unload for divert and solve > > the unload problem another day for another protocol... > > It is indeed an oversight by me not to uma_zdestroy() the zone on > unload. The sysctl handler uses normal malloc. If it's like other instances of type-stable storage, it's so that weak consistency can be used by the monitoring sysctl in order to avoid allocating lots of memory and/or suspending operation while monitoring takes place. Other instances of type-stable storage in the socket code and network stack rely on the "chain'o'pcbs" list pointers not being cleared on allocation and free. Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Principal Research Scientist, McAfee Research From owner-cvs-src@FreeBSD.ORG Tue Oct 19 23:04:18 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6C22916A4CF for ; Tue, 19 Oct 2004 23:04:18 +0000 (GMT) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7B75D43D49 for ; Tue, 19 Oct 2004 23:04:17 +0000 (GMT) (envelope-from andre@freebsd.org) Received: (qmail 63220 invoked from network); 19 Oct 2004 23:03:12 -0000 Received: from unknown (HELO freebsd.org) ([62.48.0.53]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 19 Oct 2004 23:03:12 -0000 Message-ID: <41759D75.1B6BDDC2@freebsd.org> Date: Wed, 20 Oct 2004 01:04:21 +0200 From: Andre Oppermann X-Mailer: Mozilla 4.8 [en] (Windows NT 5.0; U) X-Accept-Language: en MIME-Version: 1.0 To: Max Laier References: <200410191513.i9JFDUbf072176@repoman.freebsd.org> <200410192329.46723.max@love2party.net> <41758B35.D5340AEA@freebsd.org> <200410200035.19752.max@love2party.net> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: Sam Leffler cc: src-committers@freebsd.org cc: cvs-all@freebsd.org cc: cvs-src@freebsd.org Subject: Re: cvs commit: src/sys/sys protosw.h src/sys/kern uipc_domain.cuipc_socket2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 23:04:18 -0000 Max Laier wrote: > > On Tuesday 19 October 2004 23:46, Andre Oppermann wrote: > <...> > > > problems. For example, in ip_icmp.c line 457 ff we have: > > > > > > ctlfunc = > > > inetsw[ip_protox[icp->icmp_ip.ip_p]].pr_ctlinput; if (ctlfunc) > > > (*ctlfunc)(code, (struct sockaddr *)&icmpsrc, > > > (void *)&icp->icmp_ip); > > > > Ok, this one is easy to fix. I'll audit the code for any other of these > > abuses. > > One of many, I am afraid. Where are the others? > > > This is clearly a problem if we can remove protocols. There might be more > > > places where we (temporary) cache values from the protocol array. Another > > > problem might be that we check for protocol existence early and assume > > > that this remains true ... > > > > Well, too bad if some code tries to remember this. Doesn't hurt then. > > From my reading of many parts of the netinet/* code this is usually not > > a problem and the code is rather well behaved. I refuse to take this > > argument as reason to not have loadable protocols. > > "... usually ... rather ..." I really urge you, to reconsider. Many have > argumented in the same way. I understand that it is nice to have this > possibility, but it *does* cause *real* problems! The choice is up to the protocol module writer. Unloading a protocol is a very convinient function during prototyping. For the final version you can refuse to unload. > > The point of the protocol arrays is precisely to have them as the only > > and sole place where such information is stored. Any code that copies > > any part of it to its own private structures is horribly broken by design > > and must be fixed anyway! (BTW: I'm not aware of any code within netinet/* > > that does this.) > > I mentioned one above, I am sure there are others. Some as obvious as the one > above, some less so ... Please point them out. We can discuss specifics then instead of creating a clout of FUD. > > > Another point: If you really want to keep the possibility to remove a > > > protocol, you have to introduce some busy counter that pervents removal > > > while the kernel is inside a protocol function. This has to be handled by > > > the protocol itself, but it has to be taken care of somehow. > > > > Yes, the protocol has to be able to handle its own unloading. I have > > documented that fact. If a protocol in unable to do so it should simply > > refuse any unload attempts with EBUSY. > > Divert can be paniced with the sysctl code, btw. You have something like: > > lock; > unlock; > SYSCTL_OUT; <-- this can be made to take *some* time > lock; <-- this will panic once the lock is destroyed Oh well... > And there are other problems. Yes, it is not a problem in the common case, but > you have to account for edge cases as well! And you have to account for that unloads do not happen for every packet that goes through the box. -- Andre From owner-cvs-src@FreeBSD.ORG Tue Oct 19 23:12:20 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C21E416A4CE for ; Tue, 19 Oct 2004 23:12:20 +0000 (GMT) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0861E43D53 for ; Tue, 19 Oct 2004 23:12:20 +0000 (GMT) (envelope-from andre@freebsd.org) Received: (qmail 63283 invoked from network); 19 Oct 2004 23:11:15 -0000 Received: from unknown (HELO freebsd.org) ([62.48.0.53]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 19 Oct 2004 23:11:15 -0000 Message-ID: <41759F58.F8E5D82F@freebsd.org> Date: Wed, 20 Oct 2004 01:12:24 +0200 From: Andre Oppermann X-Mailer: Mozilla 4.8 [en] (Windows NT 5.0; U) X-Accept-Language: en MIME-Version: 1.0 To: Robert Watson References: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netinet ip_divert.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 23:12:20 -0000 Robert Watson wrote: > > On Wed, 20 Oct 2004, Andre Oppermann wrote: > > > Robert Watson wrote: > > > > > > On Wed, 20 Oct 2004, Andre Oppermann wrote: > > > > > > > Hmm... I'll take a look at those attempts and see what I can come up > > > > with to get some general solution for the protocol cases. The approach > > > > of callout_drain() looks promising though. > > > > > > BTW, it looks like the divert pcb zone uses UMA_ZONE_NOFREE so that the > > > memory is type-stable (presumably in particular for the sysctl), so all > > > memory allocated by the divert module for pcbs is likely leaked on unload. > > > I'm beginning to think we should just block unload for divert and solve > > > the unload problem another day for another protocol... > > > > It is indeed an oversight by me not to uma_zdestroy() the zone on > > unload. The sysctl handler uses normal malloc. > > If it's like other instances of type-stable storage, it's so that weak > consistency can be used by the monitoring sysctl in order to avoid > allocating lots of memory and/or suspending operation while monitoring > takes place. Other instances of type-stable storage in the socket code > and network stack rely on the "chain'o'pcbs" list pointers not being > cleared on allocation and free. Sigh... What a mess... In the IPDIVERT case the sysctl can be protected with a separate (non-adaptive) mutex. We only unload if there are no open sockets, the protocol is unloaded so there should be no cases where weak list pointers are used. I am out of the office tomorrow doing consulting work. I may have time to check into this discussion again tomorrow evening or otherwise on Thursday. -- Andre From owner-cvs-src@FreeBSD.ORG Tue Oct 19 23:12:30 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8534D16A4CE; Tue, 19 Oct 2004 23:12:30 +0000 (GMT) Received: from mail.vicor-nb.com (bigwoop.vicor-nb.com [208.206.78.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2488F43D45; Tue, 19 Oct 2004 23:12:28 +0000 (GMT) (envelope-from julian@elischer.org) Received: from elischer.org (julian.vicor-nb.com [208.206.78.97]) by mail.vicor-nb.com (Postfix) with ESMTP id C3B7D7A427; Tue, 19 Oct 2004 16:12:27 -0700 (PDT) Message-ID: <41759F5B.9080502@elischer.org> Date: Tue, 19 Oct 2004 16:12:27 -0700 From: Julian Elischer User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.3.1) Gecko/20030516 X-Accept-Language: en, hu MIME-Version: 1.0 To: Brooks Davis References: <41759110.6010005@elischer.org> <20041019223754.GA16741@odin.ac.hmc.edu> In-Reply-To: <20041019223754.GA16741@odin.ac.hmc.edu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit cc: src-committers@FreeBSD.org cc: Andre Oppermann cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Robert Watson cc: Max Laier cc: Sam Leffler Subject: Re: cvs commit: src/sys/sys protosw.h src/sys/kern uipc_domain.cuipc_socket2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 23:12:30 -0000 Brooks Davis wrote: >On Tue, Oct 19, 2004 at 06:19:10PM -0400, Robert Watson wrote: > > >>On Tue, 19 Oct 2004, Julian Elischer wrote: >> >> >> >>>>>Another point: If you really want to keep the possibility to remove a >>>>>protocol, you have to introduce some busy counter that pervents removal while >>>>>the kernel is inside a protocol function. This has to be handled by the >>>>>protocol itself, but it has to be taken care of somehow. >>>>> >>>>> >>>each protocol array entry could have either a mutex or a refcount or >>>both.. >>> >>> >>The trick here is to get just enough synchronization to not break, but not >>enough to hurt. That's one of the reasons why I feel like the heavier >>weight approaches taken elsewhere may not be appropriate here. I guess no >>one is talking about loading UDP, but at the same time if we're going to >>have generic loadable protocol support, it would be nice to get a pretty >>clean API that would meet the requirements of higher volume protocols. As >>I mentioned in a previous e-mail, it might almost be desirable to say "no >>unloading" and simply avoid the hard problems, since atomic add is easy >>whereas atomic remove is hard. >> >> > >One of the things I've been looking at with interfaces is trying to >squash the really big races (mostly dummynet) by avoiding holding a >pointer to an interface any longer then necessicary. Instead I'm > > >planning to hold interface indexes instead. > > I've been against this idea for some time.. there are some situations where interfaces can get created and destroyed as some relatively large rate. (i.e several per second in a worst case.) In particular I've seen interface reation and deltion on a very dynamic manner with some proprietary VPN solutions with interfaces coming and going on a regular basis as links come up and down. Consider doing the same as we do for PIDS.. in 386bsd. one of the ealiest bugs we saw was traced back originally to something using a process pointer which had been stored somewhere. (The process however could exit) The fix was to make a hash-table of pids and store the pid instead, (and a gen number). If the process went away you couldn't find it, and the gen number would stop you from matching new processes. I think the same thing here.. rather than storing an index into an array (which could change or become invalid.) store a long interface ID that is always incremented and kept in a small hash table. This allows the slots in the array to be reused. (It's a pity an index is required by some standards.. maye however they could live with the ID as well). I'll live with the wrap time for interface creation.. (It'll probably outlive me however..) >I'm planning to introduce a >"struct ifnet dead_if" to return when the index is no longer valid. It >will attempt to have sane no-op values so when the big races are lost it >doesn't matter. At least with interface removals, the small races don't >seem to actually happen much in practice so ignoring them may well be a >better solution then requiring a refcount every time you need to touch >an ifp. > >Once I get ipfw6 working, I'm planning to take a look at this some more. > >-- Brooks > > > From owner-cvs-src@FreeBSD.ORG Tue Oct 19 23:29:19 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8C34C16A4CE; Tue, 19 Oct 2004 23:29:19 +0000 (GMT) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 521D743D1D; Tue, 19 Oct 2004 23:29:19 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id i9JNU3gH014696; Tue, 19 Oct 2004 16:30:03 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id i9JNU33x014695; Tue, 19 Oct 2004 16:30:03 -0700 Date: Tue, 19 Oct 2004 16:30:03 -0700 From: Brooks Davis To: Julian Elischer Message-ID: <20041019233003.GA11960@odin.ac.hmc.edu> References: <41759110.6010005@elischer.org> <20041019223754.GA16741@odin.ac.hmc.edu> <41759F5B.9080502@elischer.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ibTvN161/egqYuK8" Content-Disposition: inline In-Reply-To: <41759F5B.9080502@elischer.org> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu cc: src-committers@FreeBSD.org cc: Andre Oppermann cc: Brooks Davis cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Robert Watson cc: Max Laier cc: Sam Leffler Subject: Re: cvs commit: src/sys/sys protosw.h src/sys/kern uipc_domain.cuipc_socket2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 23:29:19 -0000 --ibTvN161/egqYuK8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 19, 2004 at 04:12:27PM -0700, Julian Elischer wrote: >=20 >=20 > Brooks Davis wrote: >=20 > >On Tue, Oct 19, 2004 at 06:19:10PM -0400, Robert Watson wrote: > >=20 > > > >>On Tue, 19 Oct 2004, Julian Elischer wrote: > >> > >> =20 > >> > >>>>>Another point: If you really want to keep the possibility to remove a > >>>>>protocol, you have to introduce some busy counter that pervents=20 > >>>>>removal while > >>>>>the kernel is inside a protocol function. This has to be handled by = the > >>>>>protocol itself, but it has to be taken care of somehow. > >>>>> =20 > >>>>> > >>>each protocol array entry could have either a mutex or a refcount or > >>>both..=20 > >>> =20 > >>> > >>The trick here is to get just enough synchronization to not break, but = not > >>enough to hurt. That's one of the reasons why I feel like the heavier > >>weight approaches taken elsewhere may not be appropriate here. I guess= no > >>one is talking about loading UDP, but at the same time if we're going to > >>have generic loadable protocol support, it would be nice to get a pretty > >>clean API that would meet the requirements of higher volume protocols. = As > >>I mentioned in a previous e-mail, it might almost be desirable to say "= no > >>unloading" and simply avoid the hard problems, since atomic add is easy > >>whereas atomic remove is hard. > >> =20 > >> > > > >One of the things I've been looking at with interfaces is trying to > >squash the really big races (mostly dummynet) by avoiding holding a > >pointer to an interface any longer then necessicary. Instead I'm > >=20 > > > >planning to hold interface indexes instead. =20 > >=20 > > > I've been against this idea for some time.. > there are some situations where interfaces can get created and destroyed= =20 > as some relatively large rate. > (i.e several per second in a worst case.) >=20 > In particular I've seen interface reation and deltion on a very dynamic= =20 > manner with some > proprietary VPN solutions with interfaces coming and going on a regular= =20 > basis as links come up and down. >=20 >=20 > Consider doing the same as we do for PIDS.. > in 386bsd. one of the ealiest bugs we saw was traced back originally to= =20 > something using a process > pointer which had been stored somewhere. (The process however could exit) > The fix was to make a hash-table of pids and store the pid instead, (and= =20 > a gen number). > If the process went away you couldn't find it, and the gen number would= =20 > stop you from matching new processes. >=20 > I think the same thing here.. rather than storing an index into an array= =20 > (which could change or > become invalid.) store a long interface ID that is always incremented=20 > and kept in a > small hash table. This allows the slots in the array to be reused. =20 > (It's a pity an index is required by > some standards.. maye however they could live with the ID as well). > I'll live with the wrap time for interface creation.. (It'll probably=20 > outlive me however..) We now have the index plus generation number in the form of if_data.ifi_epoch so you can do that trick (if interfaces are being created and destroyed with sub-second frequency we can move to storing a bintime from a time_t in the 6.x timeframe.) The indexes we generate are useless for SNMP in vpn-like environments. I've proposed a couple of partial solutions in my EuroBSDCon paper, but at the end of the day, complex systems like VPN concentrators will need to manage their own indexes entirely internally and only use the if_index as a temporary handle on each interface. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --ibTvN161/egqYuK8 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFBdaN6XY6L6fI4GtQRAiwJAJ0WR6R3dS1Qrugyda/CWLGaRKw/3QCgtH8B dSnuIMaYEnsNALmTm72q18k= =Guno -----END PGP SIGNATURE----- --ibTvN161/egqYuK8-- From owner-cvs-src@FreeBSD.ORG Tue Oct 19 23:30:13 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E07D016A4CE; Tue, 19 Oct 2004 23:30:12 +0000 (GMT) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.173]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4002C43D31; Tue, 19 Oct 2004 23:30:12 +0000 (GMT) (envelope-from max@love2party.net) Received: from [212.227.126.155] (helo=mrelayng.kundenserver.de) by moutng.kundenserver.de with esmtp (Exim 3.35 #1) id 1CK3Qh-00063u-00; Wed, 20 Oct 2004 01:30:11 +0200 Received: from [217.227.158.113] (helo=donor.laier.local) by mrelayng.kundenserver.de with asmtp (TLSv1:RC4-MD5:128) (Exim 3.35 #1) id 1CK3Qh-0000d9-00; Wed, 20 Oct 2004 01:30:11 +0200 From: Max Laier To: Andre Oppermann Date: Wed, 20 Oct 2004 01:29:44 +0200 User-Agent: KMail/1.7 References: <200410191513.i9JFDUbf072176@repoman.freebsd.org> <200410200035.19752.max@love2party.net> <41759D75.1B6BDDC2@freebsd.org> In-Reply-To: <41759D75.1B6BDDC2@freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart8580614.MdTMLZGYMr"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200410200129.54320.max@love2party.net> X-Provags-ID: kundenserver.de abuse@kundenserver.de auth:61c499deaeeba3ba5be80f48ecc83056 cc: Sam Leffler cc: src-committers@freebsd.org cc: cvs-all@freebsd.org cc: cvs-src@freebsd.org Subject: Re: cvs commit: src/sys/sys protosw.h src/sys/kern uipc_domain.cuipc_socket2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 23:30:13 -0000 --nextPart8580614.MdTMLZGYMr Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Wednesday 20 October 2004 01:04, Andre Oppermann wrote: > Please point them out. We can discuss specifics then instead of creating > a clout of FUD. Okay, that's the last straw. This is not FUD. We are really concerned that = you=20 are introduceing something that is not fully though about. We will have problems with this and I really think that it should be backed= =20 out now and fixed before reconsidered! Unloading (of divert) has races that can be triggered. Claiming that they w= ill=20 not be "most of the time" is not exactly the right approach for serious=20 development. And for pointing out specifics: ip_encap is going to be a lot of fun. And=20 that's just the most obvious, I could find. I will not scan the tree for mo= re=20 places, but the ip_icmp.c example shows that you didn't scan the tree=20 carefully enough before you committed this work without previous discussion= =2E=20 It seems that you just assume that everything is fine. It really is not! I understand that you didn't want to slow things down in a bikeshed, but th= is=20 is not ready, sorry. > > > > Another point: If you really want to keep the possibility to remove= a > > > > protocol, you have to introduce some busy counter that pervents > > > > removal while the kernel is inside a protocol function. This has to > > > > be handled by the protocol itself, but it has to be taken care of > > > > somehow. > > > > > > Yes, the protocol has to be able to handle its own unloading. I have > > > documented that fact. If a protocol in unable to do so it should > > > simply refuse any unload attempts with EBUSY. > > > > Divert can be paniced with the sysctl code, btw. You have something lik= e: > > > > lock; > > unlock; > > SYSCTL_OUT; <-- this can be made to take *some* time > > lock; <-- this will panic once the lock is destroyed > > Oh well... Pardon me? > > And there are other problems. Yes, it is not a problem in the common > > case, but you have to account for edge cases as well! > > And you have to account for that unloads do not happen for every packet > that goes through the box. The fact that an unload happens very seldom, is not an excuse to allow it t= o=20 panic the box. =2D-=20 /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --nextPart8580614.MdTMLZGYMr Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQBBdaNyXyyEoT62BG0RApIqAJ4wRz6J8Hm1f+ggtZQVYt1I8YKUPQCfbfT7 V70uCc7XYCrzxWRylZ3Qb6o= =CajA -----END PGP SIGNATURE----- --nextPart8580614.MdTMLZGYMr-- From owner-cvs-src@FreeBSD.ORG Tue Oct 19 23:31:45 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7671916A4CE; Tue, 19 Oct 2004 23:31:45 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5837B43D1D; Tue, 19 Oct 2004 23:31:45 +0000 (GMT) (envelope-from mux@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9JNVj3E006124; Tue, 19 Oct 2004 23:31:45 GMT (envelope-from mux@repoman.freebsd.org) Received: (from mux@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9JNVjY9006123; Tue, 19 Oct 2004 23:31:45 GMT (envelope-from mux) Message-Id: <200410192331.i9JNVjY9006123@repoman.freebsd.org> From: Maxime Henrion Date: Tue, 19 Oct 2004 23:31:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 23:31:45 -0000 mux 2004-10-19 23:31:45 UTC FreeBSD src repository Modified files: sys/dev/em if_em.c Log: Add missing bus_dmamap_sync() calls. If you are using an architecture with a weak memory model or x86 + PAE (or more specifically, your driver is using bounce pages) and you have had problems with em(4), this may fix it. At least this is needed to have em(4) work properly on FreeBSD/arm. Original version by: cognet Reviewed by: tackerman Tested by: cognet Revision Changes Path 1.50 +12 -2 src/sys/dev/em/if_em.c From owner-cvs-src@FreeBSD.ORG Tue Oct 19 23:35:19 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3AE9616A564; Tue, 19 Oct 2004 23:35:19 +0000 (GMT) Received: from dong.ci0.org (cognet.ci0.org [80.65.224.102]) by mx1.FreeBSD.org (Postfix) with ESMTP id 17F3C43D46; Tue, 19 Oct 2004 23:35:18 +0000 (GMT) (envelope-from doginou@dong.ci0.org) Received: from dong.ci0.org (localhost.ci0.org [127.0.0.1]) by dong.ci0.org (8.12.11/8.12.11) with ESMTP id i9K0L5H4038609; Wed, 20 Oct 2004 02:21:05 +0200 (CEST) (envelope-from doginou@dong.ci0.org) Received: (from doginou@localhost) by dong.ci0.org (8.12.11/8.12.11/Submit) id i9K0L567038608; Wed, 20 Oct 2004 02:21:05 +0200 (CEST) (envelope-from doginou) Date: Wed, 20 Oct 2004 02:21:05 +0200 From: Olivier Houchard To: Maxime Henrion Message-ID: <20041020002105.GA38585@ci0.org> References: <200410192331.i9JNVjY9006123@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200410192331.i9JNVjY9006123@repoman.freebsd.org> User-Agent: Mutt/1.4.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 23:35:19 -0000 On Tue, Oct 19, 2004 at 11:31:45PM +0000, Maxime Henrion wrote: > mux 2004-10-19 23:31:45 UTC > > FreeBSD src repository > > Modified files: > sys/dev/em if_em.c > Log: > Add missing bus_dmamap_sync() calls. If you are using an architecture > with a weak memory model or x86 + PAE (or more specifically, your > driver is using bounce pages) and you have had problems with em(4), > this may fix it. At least this is needed to have em(4) work properly > on FreeBSD/arm. > > Original version by: cognet > Reviewed by: tackerman > Tested by: cognet > > Revision Changes Path > 1.50 +12 -2 src/sys/dev/em/if_em.c Thanks ! Olivier From owner-cvs-src@FreeBSD.ORG Tue Oct 19 23:37:24 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 51B3E16A4CF; Tue, 19 Oct 2004 23:37:24 +0000 (GMT) Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8882D43D46; Tue, 19 Oct 2004 23:37:23 +0000 (GMT) (envelope-from ache@pobrecita.freebsd.ru) Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.13.1/8.13.1) with ESMTP id i9JNbM8V022318; Wed, 20 Oct 2004 03:37:22 +0400 (MSD) (envelope-from ache@pobrecita.freebsd.ru) Received: (from ache@localhost) by pobrecita.freebsd.ru (8.13.1/8.13.1/Submit) id i9JNbLdi022317; Wed, 20 Oct 2004 03:37:21 +0400 (MSD) (envelope-from ache) Date: Wed, 20 Oct 2004 03:37:21 +0400 From: Andrey Chernov To: John-Mark Gurney Message-ID: <20041019233720.GA20655@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , John-Mark Gurney , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200410182306.i9IN6DDx016512@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200410182306.i9IN6DDx016512@repoman.freebsd.org> User-Agent: Mutt/1.5.6i X-AntiVirus: checked by AntiVir Milter 1.1-beta; AVE 6.28.0.7; VDF 6.28.0.24 (host: pobrecita.freebsd.ru) cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/pci if_de.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 23:37:24 -0000 Yes, I have those "deferred" diagnostic too, but it appearse it not affects anything in bad way, all works normally after your fix. de0: [GIANT-LOCKED] de0: SMC 21041 [10Mb/s] pass 1.1 de0: Ethernet address: 00:00:c0:f1:ef:d3 de0: if_start running deferred for Giant -- Andrey Chernov | http://ache.pp.ru/ From owner-cvs-src@FreeBSD.ORG Wed Oct 20 00:27:18 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EE50116A4CE; Wed, 20 Oct 2004 00:27:18 +0000 (GMT) Received: from web.portaone.com (mail.russia.cz [195.70.151.35]) by mx1.FreeBSD.org (Postfix) with ESMTP id 038E343D3F; Wed, 20 Oct 2004 00:27:18 +0000 (GMT) (envelope-from sobomax@portaone.com) Received: from [192.168.1.100] (xDSL-2-2.united.net.ua [193.111.9.226]) (authenticated bits=0) by web.portaone.com (8.12.11/8.12.11) with ESMTP id i9K0R3K9021421 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 20 Oct 2004 02:27:07 +0200 (CEST) (envelope-from sobomax@portaone.com) Message-ID: <4175B0CD.1050204@portaone.com> Date: Wed, 20 Oct 2004 03:26:53 +0300 From: Maxim Sobolev Organization: Porta Software Ltd User-Agent: Mozilla Thunderbird 0.8 (Windows/20040913) X-Accept-Language: en-us, en MIME-Version: 1.0 To: "M. Warner Losh" References: <20041019071102.GA49717@FreeBSD.org> <20041019072349.GA28133@samodelkin.net> <20041019073145.GA29746@thingy.tbd.co.nz> <20041019.084324.106215221.imp@bsdimp.com> In-Reply-To: <20041019.084324.106215221.imp@bsdimp.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit cc: danfe@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-src@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG cc: ru@FreeBSD.ORG cc: obrien@FreeBSD.ORG cc: andy@fud.org.nz cc: fjoe@samodelkin.net Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2004 00:27:19 -0000 M. Warner Losh wrote: > In message: <20041019073145.GA29746@thingy.tbd.co.nz> > Andrew Thompson writes: > : > I am afraid that recompiling a kernel on i386 will require several days. > : > : Chicken and the egg. To support i386 it must be recompiled, so you would > : have to do it on another box anyway. > > The only people that will seriously want to use i386 these days are > the folks that build embedded systems. Those you have to build on > some host then deploy to the target system. > > There are some benefits to having i386 in the tree. However, there > are also a number of different places in the tree where things are > sub-optimal because we still have support for i386 in there. The > desire to remove them is to make FreeBSD go faster on more modern > hardware. Can anyone give at least one valid point why somebody will want to use 6.x on embedded i386? Such hardware is inheretedly limited, so that all good stuff that have been added into FreeBSD during the past few years (SMPng, GEOM, KSE, you-name-it) if of no use on that hardware anyway. IMO any reasonable embedded folks would just stick with 4.x or even 3.x due to their smaller footprint and better performance on old systems. Let's just rip that old junk off! -Maxim From owner-cvs-src@FreeBSD.ORG Wed Oct 20 01:45:23 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BB77016A4CE; Wed, 20 Oct 2004 01:45:23 +0000 (GMT) Received: from mail.soaustin.net (mail.soaustin.net [207.200.4.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id 815D943D2D; Wed, 20 Oct 2004 01:45:23 +0000 (GMT) (envelope-from linimon@lonesome.com) Received: by mail.soaustin.net (Postfix, from userid 502) id 0EC22148D7; Tue, 19 Oct 2004 20:45:23 -0500 (CDT) Date: Tue, 19 Oct 2004 20:45:22 -0500 (CDT) From: Mark Linimon X-X-Sender: linimon@pancho To: David Schultz In-Reply-To: <20041019215007.GA13217@VARK.MIT.EDU> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG cc: John Baldwin cc: "M. Warner Losh" Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2004 01:45:24 -0000 On Tue, 19 Oct 2004, David Schultz wrote: > Yes, and very few of those [embedded systems] folks are likely to want > a relatively large, non-realtime, monolithic, multi-threaded OS kernel, > much less a userland that even vaguely resembles a standard FreeBSD > installation. I think it's fair to ask, are there any such people (e.g. using FreeBSD on embedded systems)? I mean, my background includes a lot of embedded systems work so I'm biased towards it, but there is also no point in trying to optimize FreeBSD for a null set of users. (That's what the ports tree is for. Hey, don't throw that 386 box at me!) > \me can't wait for the day when developers are no longer required > to spend time and effort to support anything older than a PPro. How much of the source base has code specific to that case? Well, in some ways, all of this is probably just jumping the gun on a wider discussion of what we want 6.x to be. I'm hoping that that will start fairly soon after 5.3 goes out the door ... mcl From owner-cvs-src@FreeBSD.ORG Wed Oct 20 01:55:30 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CC1DC16A4CF; Wed, 20 Oct 2004 01:55:30 +0000 (GMT) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 462CE43D41; Wed, 20 Oct 2004 01:55:18 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id i9K1txTA002807; Tue, 19 Oct 2004 18:55:59 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id i9K1txdg002806; Tue, 19 Oct 2004 18:55:59 -0700 Date: Tue, 19 Oct 2004 18:55:59 -0700 From: Brooks Davis To: Mark Linimon Message-ID: <20041020015559.GA1846@odin.ac.hmc.edu> References: <20041019215007.GA13217@VARK.MIT.EDU> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vkogqOf2sHV7VnPd" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu cc: src-committers@FreeBSD.org cc: John Baldwin cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org cc: David Schultz cc: "M. Warner Losh" Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2004 01:55:31 -0000 --vkogqOf2sHV7VnPd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 19, 2004 at 08:45:22PM -0500, Mark Linimon wrote: > On Tue, 19 Oct 2004, David Schultz wrote: >=20 > > Yes, and very few of those [embedded systems] folks are likely to want > > a relatively large, non-realtime, monolithic, multi-threaded OS kernel, > > much less a userland that even vaguely resembles a standard FreeBSD > > installation. >=20 > I think it's fair to ask, are there any such people (e.g. using FreeBSD > on embedded systems)? >=20 > I mean, my background includes a lot of embedded systems work so I'm > biased towards it, but there is also no point in trying to optimize > FreeBSD for a null set of users. (That's what the ports tree is for. > Hey, don't throw that 386 box at me!) If there's actually a need there's always the option of creating an 80386 port. A developer I'm not going to name here recently said that if someone like NASA comes to us and says, "we'd love to use FreeBSD on this satellite, but we need to run on in 80386", he'd do the port himself. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --vkogqOf2sHV7VnPd Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFBdcWvXY6L6fI4GtQRArrzAKCPcM7rD9F8BUv3nWx1Gkl98RhufgCfUwhj Icmz9kXxsFgLHTCMmj6fQsk= =SNKw -----END PGP SIGNATURE----- --vkogqOf2sHV7VnPd-- From owner-cvs-src@FreeBSD.ORG Wed Oct 20 04:44:41 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DB79716A4CE; Wed, 20 Oct 2004 04:44:41 +0000 (GMT) Received: from ebb.errno.com (ebb.errno.com [66.127.85.87]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8EC5943D39; Wed, 20 Oct 2004 04:44:41 +0000 (GMT) (envelope-from sam@errno.com) Received: from [66.127.85.93] ([66.127.85.93]) (authenticated bits=0) by ebb.errno.com (8.12.9/8.12.6) with ESMTP id i9K4ifWi044517 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 19 Oct 2004 21:44:41 -0700 (PDT) (envelope-from sam@errno.com) Message-ID: <4175ED52.6070508@errno.com> Date: Tue, 19 Oct 2004 21:45:06 -0700 From: Sam Leffler Organization: Errno Consulting User-Agent: Mozilla Thunderbird 0.8 (Macintosh/20040913) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Andre Oppermann References: <200410191513.i9JFDUbf072176@repoman.freebsd.org> <417532A2.9000901@errno.com> <41753522.1E39FEAE@freebsd.org> In-Reply-To: <41753522.1E39FEAE@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys protosw.h src/sys/kern uipc_domain.cuipc_socket2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2004 04:44:42 -0000 Andre Oppermann wrote: > Sam Leffler wrote: > >>Andre Oppermann wrote: >> >>>andre 2004-10-19 15:13:30 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/sys protosw.h >>> sys/kern uipc_domain.c uipc_socket2.c >>> Log: >>> Support for dynamically loadable and unloadable protocols within existing protocol >>> families. >>> >> >>I don't recall seeing this posted anywhere for comment. I have some >>concerns about this general topic and this code seems incomplete (e.g. I >>see no locking). > > > Locking is not needed because there are no dead moments in transitioning > from unregistered to registered and back. All calls to any of the protocol > specific functions will return a valid result (even if it is only EOPNOTSUPP). > There is no list manipulation going on. > > The caller of the function is required to assure that no dangeling sockets, > references or memory allocations are left behind after unregistering. It's > simply impossible to solve otherwise. For IPDIVERT which I have converted > this works very well (it will simply refuse to unload if a divert socket is > open). > > What remaining concerns do you have? I went away for the day. It seems many people have responded though not addressing all my concerns. While I applaud your effort to attack this problem I must say I am totally disgusted by the way in which you've dropped this code in the tree with no review or opportunity for comment. There are many decisions made here that I disagree with and from the subsequent commits to patchup issues it's clear your work needed some "soak time" before going in CVS. Sam From owner-cvs-src@FreeBSD.ORG Wed Oct 20 04:54:51 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 180E316A4CE; Wed, 20 Oct 2004 04:54:51 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id ECCFA43D4C; Wed, 20 Oct 2004 04:54:50 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9K4soHc029160; Wed, 20 Oct 2004 04:54:50 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9K4so7L029159; Wed, 20 Oct 2004 04:54:50 GMT (envelope-from imp) Message-Id: <200410200454.i9K4so7L029159@repoman.freebsd.org> From: Warner Losh Date: Wed, 20 Oct 2004 04:54:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/ed if_ed_pccard.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2004 04:54:51 -0000 imp 2004-10-20 04:54:50 UTC FreeBSD src repository Modified files: sys/dev/ed if_ed_pccard.c Log: Rumor has it that ACCTON EN2216 is also an ne2000 compatible. Make it so. Revision Changes Path 1.60 +1 -0 src/sys/dev/ed/if_ed_pccard.c From owner-cvs-src@FreeBSD.ORG Wed Oct 20 05:43:46 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1C88D16A4CE; Wed, 20 Oct 2004 05:43:46 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F167943D1F; Wed, 20 Oct 2004 05:43:45 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9K5hj9e030860; Wed, 20 Oct 2004 05:43:45 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9K5hjbX030859; Wed, 20 Oct 2004 05:43:45 GMT (envelope-from ru) Message-Id: <200410200543.i9K5hjbX030859@repoman.freebsd.org> From: Ruslan Ermilov Date: Wed, 20 Oct 2004 05:43:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sbin/fdisk fdisk.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2004 05:43:46 -0000 ru 2004-10-20 05:43:45 UTC FreeBSD src repository Modified files: sbin/fdisk fdisk.c Log: Don't prepend "/dev" if an argument given is an absolute pathname. Reviewed by: jhb Revision Changes Path 1.75 +1 -1 src/sbin/fdisk/fdisk.c From owner-cvs-src@FreeBSD.ORG Wed Oct 20 05:55:28 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 61FC816A4CE; Wed, 20 Oct 2004 05:55:28 +0000 (GMT) Received: from n33.kp.t-systems-sfr.com (n33.kp.t-systems-sfr.com [129.247.16.33]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0587143D3F; Wed, 20 Oct 2004 05:55:27 +0000 (GMT) (envelope-from harti@freebsd.org) Received: from n81.sp.op.dlr.de (n81g.sp.op.dlr.de [129.247.163.1]) i9K5tOU219024; Wed, 20 Oct 2004 07:55:24 +0200 Received: from zeus.nt.op.dlr.de (zeus.nt.op.dlr.de [129.247.173.3]) i9K5tNI59562; Wed, 20 Oct 2004 07:55:23 +0200 Received: from beagle.kn.op.dlr.de (opkndnwsbsd178 [129.247.173.178]) by zeus.nt.op.dlr.de (8.11.7+Sun/8.9.1) with ESMTP id i9K5tRe18160; Wed, 20 Oct 2004 07:55:28 +0200 (MET DST) Date: Wed, 20 Oct 2004 07:55:32 +0200 (CEST) From: Harti Brandt X-X-Sender: brandt@beagle.kn.op.dlr.de To: Andre Oppermann In-Reply-To: <41758B35.D5340AEA@freebsd.org> Message-ID: <20041020074747.B21281@beagle.kn.op.dlr.de> References: <200410191513.i9JFDUbf072176@repoman.freebsd.org> <417532A2.9000901@errno.com> <41753522.1E39FEAE@freebsd.org> <200410192329.46723.max@love2party.net> <41758B35.D5340AEA@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: Max Laier cc: src-committers@freebsd.org cc: cvs-all@freebsd.org cc: cvs-src@freebsd.org cc: Sam Leffler Subject: Re: cvs commit: src/sys/sys protosw.h src/sys/kern uipc_domain.cuipc_socket2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Harti Brandt List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2004 05:55:28 -0000 On Tue, 19 Oct 2004, Andre Oppermann wrote: AO>Max Laier wrote: AO>> example, in ip_icmp.c line 457 ff we have: AO>> AO>> ctlfunc = inetsw[ip_protox[icp->icmp_ip.ip_p]].pr_ctlinput; AO>> if (ctlfunc) AO>> (*ctlfunc)(code, (struct sockaddr *)&icmpsrc, AO>> (void *)&icp->icmp_ip); AO> AO>Ok, this one is easy to fix. I'll audit the code for any other of these AO>abuses. Actually it is not easy to fix. Even if you don't introduce a temporary variable the compiler can and probably will still use a temporary copy of the function pointer. AO>The point of the protocol arrays is precisely to have them as the only AO>and sole place where such information is stored. Any code that copies AO>any part of it to its own private structures is horribly broken by design AO>and must be fixed anyway! (BTW: I'm not aware of any code within netinet/* AO>that does this.) You cannot prevent the compiler from makeing temporary copies. harti From owner-cvs-src@FreeBSD.ORG Wed Oct 20 06:10:28 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from green.homeunix.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id A3C5916A4CE; Wed, 20 Oct 2004 06:10:27 +0000 (GMT) Received: from green.homeunix.org (green@localhost [127.0.0.1]) by green.homeunix.org (8.13.1/8.13.1) with ESMTP id i9K6ARH5020567; Wed, 20 Oct 2004 02:10:27 -0400 (EDT) (envelope-from green@green.homeunix.org) Received: (from green@localhost) by green.homeunix.org (8.13.1/8.13.1/Submit) id i9K6AQLW020566; Wed, 20 Oct 2004 02:10:26 -0400 (EDT) (envelope-from green) Date: Wed, 20 Oct 2004 02:10:26 -0400 From: Brian Fundakowski Feldman To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <20041020061026.GH1072@green.homeunix.org> References: <200410130412.i9D4CK7v065761@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200410130412.i9D4CK7v065761@repoman.freebsd.org> User-Agent: Mutt/1.5.6i cc: current@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/usb ugen.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: current@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2004 06:10:28 -0000 On Wed, Oct 13, 2004 at 04:12:20AM +0000, Brian Feldman wrote: > green 2004-10-13 04:12:20 UTC > > FreeBSD src repository > > Modified files: > sys/dev/usb ugen.c > Log: > Back out rev.1.91 which implemented bulk read transfers in ugen(4) as > asynchronous. I realize that this means the custom application will > not work as written, but it is not okay to break most users of ugen(4). > > The major problem is that a bulk read transfer is not an interrupt > saying that X bytes are available -- it is a request to be able to > receive up to X bytes, with T timeout, and S short-transfer-okayness. > > The timeout is a software mechanism that ugen(4) provides and cannot > be implemented using asynchronous reads -- the timeout must start at > the time a read is done. > > The status of up to how many bytes can be received in this transfer > and whether a short transfer returns data or error is also encoded > at least in ohci(4)'s requests to the controller. Trying to detect > the "maximum width" results in using a single buffer of far too > small when an application requests a large read. > > Even if you combat this by replacing all buffers again with the > maximal sized read buffer (1kb) that ugen(4) would allow you to > use before, you don't get the right semantics -- you have to > throw data away or make all the timeouts invalid or make the > short-transfer settings invalid. > > There is no way to do this right without extending the ugen(4) API > much further -- it breaks the USB camera interfaces used because > they need a chain of many maximal-width transfers, for example, and > it makes cross-platform support for all the BSDs gratuitously hard. > > Instead of trying to do select(2) on a bulk read pipe -- which has > neither the information on desired transfer length nor ability to > implement timeout -- an application can simply use a kernel thread > and pipe to turn that endpoint into something poll-able. > > It is unfortunate that bulk endpoints cannot provide the same semantics > that interrupt and isochronous endpoints can, but it is possible to just > use ioctl(USB_GET_ENDPOINT_DESC) to find out when different semantics > must be used without preventing the normal users of the ugen(4) device > from working. For what it's worth, it really isn't that hard to make your software account for bulk-ugen(4)'s brain-deadedness; for example, I can use this to do GPRS on my Treo with ppp(8): (I guess it's also useful as a reference implementation for this sort of thing in PPP, in general -- it certainly exposes weaknesses.) -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\ From owner-cvs-src@FreeBSD.ORG Wed Oct 20 08:01:32 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CDC7416A4D6; Wed, 20 Oct 2004 08:01:32 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id ABA1C43D2D; Wed, 20 Oct 2004 08:01:32 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9K81WpK035153; Wed, 20 Oct 2004 08:01:32 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9K81Wak035152; Wed, 20 Oct 2004 08:01:32 GMT (envelope-from rwatson) Message-Id: <200410200801.i9K81Wak035152@repoman.freebsd.org> From: Robert Watson Date: Wed, 20 Oct 2004 08:01:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sbin/fsck_ffs fsck.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2004 08:01:33 -0000 rwatson 2004-10-20 08:01:32 UTC FreeBSD src repository Modified files: sbin/fsck_ffs fsck.h Log: Explicitly break out NETA license from Berkeley license to clearly indicate license grant, as well as to indicate that NETA is asserting only two clauses, not four clauses. Requested by: imp Revision Changes Path 1.34 +21 -0 src/sbin/fsck_ffs/fsck.h From owner-cvs-src@FreeBSD.ORG Wed Oct 20 08:04:36 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B279216A4CE; Wed, 20 Oct 2004 08:04:36 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 90E0743D45; Wed, 20 Oct 2004 08:04:36 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9K84af3035346; Wed, 20 Oct 2004 08:04:36 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9K84aNV035345; Wed, 20 Oct 2004 08:04:36 GMT (envelope-from rwatson) Message-Id: <200410200804.i9K84aNV035345@repoman.freebsd.org> From: Robert Watson Date: Wed, 20 Oct 2004 08:04:36 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/ufs/ffs ffs_alloc.c ffs_balloc.c ffs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2004 08:04:36 -0000 rwatson 2004-10-20 08:04:36 UTC FreeBSD src repository Modified files: sys/ufs/ffs ffs_alloc.c ffs_balloc.c ffs_vnops.c Log: Explicitly break out NETA license from Berkeley license to clearly indicate license grant, as well as to indicate that NETA is asserting only two clauses, not four clauses. Requested by: imp Revision Changes Path 1.125 +21 -0 src/sys/ufs/ffs/ffs_alloc.c 1.45 +21 -0 src/sys/ufs/ffs/ffs_balloc.c 1.137 +21 -0 src/sys/ufs/ffs/ffs_vnops.c From owner-cvs-src@FreeBSD.ORG Wed Oct 20 08:05:02 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E9ECF16A4CE; Wed, 20 Oct 2004 08:05:02 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CABC243D5F; Wed, 20 Oct 2004 08:05:02 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9K852po035395; Wed, 20 Oct 2004 08:05:02 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9K852DM035394; Wed, 20 Oct 2004 08:05:02 GMT (envelope-from rwatson) Message-Id: <200410200805.i9K852DM035394@repoman.freebsd.org> From: Robert Watson Date: Wed, 20 Oct 2004 08:05:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/ufs/ufs dinode.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2004 08:05:03 -0000 rwatson 2004-10-20 08:05:02 UTC FreeBSD src repository Modified files: sys/ufs/ufs dinode.h Log: Explicitly break out NETA license from Berkeley license to clearly indicate license grant, as well as to indicate that NETA is asserting only two clauses, not four clauses. Requested by: imp Revision Changes Path 1.14 +21 -0 src/sys/ufs/ufs/dinode.h From owner-cvs-src@FreeBSD.ORG Wed Oct 20 09:25:29 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 70D9B16A4CE; Wed, 20 Oct 2004 09:25:29 +0000 (GMT) Received: from mail15.syd.optusnet.com.au (mail15.syd.optusnet.com.au [211.29.132.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id C7B8243D1F; Wed, 20 Oct 2004 09:25:28 +0000 (GMT) (envelope-from PeterJeremy@optushome.com.au) Received: from cirb503493.alcatel.com.au (c211-30-75-229.belrs2.nsw.optusnet.com.au [211.30.75.229]) i9K9PQQX030635 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Wed, 20 Oct 2004 19:25:27 +1000 Received: from cirb503493.alcatel.com.au (localhost.alcatel.com.au [127.0.0.1])i9K9PPxP082665; Wed, 20 Oct 2004 19:25:25 +1000 (EST) (envelope-from pjeremy@cirb503493.alcatel.com.au) Received: (from pjeremy@localhost)i9K9PP99082664; Wed, 20 Oct 2004 19:25:25 +1000 (EST) (envelope-from pjeremy) Date: Wed, 20 Oct 2004 19:25:25 +1000 From: Peter Jeremy To: src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG Message-ID: <20041020092525.GB79646@cirb503493.alcatel.com.au> References: <20041019071102.GA49717@FreeBSD.org> <20041019073145.GA29746@thingy.tbd.co.nz> <20041019.084324.106215221.imp@bsdimp.com> <200410191541.54269.jhb@FreeBSD.org> <20041019215007.GA13217@VARK.MIT.EDU> <20041019220031.GA98675@falcon.midgard.homeip.net> <20041019225231.GA13522@VARK.MIT.EDU> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041019225231.GA13522@VARK.MIT.EDU> User-Agent: Mutt/1.4.2i Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2004 09:25:29 -0000 On Tue, 2004-Oct-19 18:52:31 -0400, David Schultz wrote: >First of all, your 80386 (if it worked) would probably be much >snappier running FreeBSD 3.X or 4.X or NetBSD 1.[2-5]. It is a lot easier to administer a collection of machines that are all running close-to-the-same software. And FreeBSD 2.x is probably a better match for 386-class hardware (the memory and disk footprint is much smaller). > Second, >you can purchase a Linksys gateway for $20, whereas a 386 would >consume more than $20 of power in a few months. You might be able to. The cheapest Linksys gateway/router I can find quickly is AUD102 list (USD75). Erik probably has different cost tradeoffs and might not want to use a closed-source proprietary product as a firewall. >> > Nice. \me can't wait for the day when developers are no longer >> > required to spend time and effort to support anything older than a PPro. >> >> That day will hopefully be far in the future. Personally I don't have >> anything as modern as a PPro. > >Don't worry, it will be. I can dream, can't I? The 486 and Pentium provide useful new instructions and system controls. What benefits does a PPro provide as far as the kernel and core userland is concerned? -- Peter Jeremy From owner-cvs-src@FreeBSD.ORG Wed Oct 20 10:11:05 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BA28816A4CE; Wed, 20 Oct 2004 10:11:05 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 994B443D48; Wed, 20 Oct 2004 10:11:05 +0000 (GMT) (envelope-from sos@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9KAB51g045684; Wed, 20 Oct 2004 10:11:05 GMT (envelope-from sos@repoman.freebsd.org) Received: (from sos@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9KAB5KS045683; Wed, 20 Oct 2004 10:11:05 GMT (envelope-from sos) Message-Id: <200410201011.i9KAB5KS045683@repoman.freebsd.org> From: Søren Schmidt Date: Wed, 20 Oct 2004 10:11:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/ata ata-queue.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2004 10:11:05 -0000 sos 2004-10-20 10:11:05 UTC FreeBSD src repository Modified files: sys/dev/ata ata-queue.c Log: Do not retry on requests that has lost thier device during reinit. Should fix hangs on IBM's etc with the fake slave problem. MFC: asap Revision Changes Path 1.39 +5 -8 src/sys/dev/ata/ata-queue.c From owner-cvs-src@FreeBSD.ORG Wed Oct 20 10:11:12 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B91DC16A500; Wed, 20 Oct 2004 10:11:12 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 97B0343D5D; Wed, 20 Oct 2004 10:11:12 +0000 (GMT) (envelope-from simon@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9KABC1Y045713; Wed, 20 Oct 2004 10:11:12 GMT (envelope-from simon@repoman.freebsd.org) Received: (from simon@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9KABCuq045712; Wed, 20 Oct 2004 10:11:12 GMT (envelope-from simon) Message-Id: <200410201011.i9KABCuq045712@repoman.freebsd.org> From: "Simon L. Nielsen" Date: Wed, 20 Oct 2004 10:11:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin/ntp/doc ntpdate.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2004 10:11:13 -0000 simon 2004-10-20 10:11:12 UTC FreeBSD src repository (doc committer) Modified files: usr.sbin/ntp/doc ntpdate.8 Log: Fix typo. Submitted by: Patrick Oonk PR: docs/72912 MFC after: 1 week Revision Changes Path 1.8 +1 -1 src/usr.sbin/ntp/doc/ntpdate.8 From owner-cvs-src@FreeBSD.ORG Wed Oct 20 10:21:16 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6771116A4CE; Wed, 20 Oct 2004 10:21:16 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5CFB843D31; Wed, 20 Oct 2004 10:21:16 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9KALGZ1046050; Wed, 20 Oct 2004 10:21:16 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9KALGwQ046049; Wed, 20 Oct 2004 10:21:16 GMT (envelope-from rwatson) Message-Id: <200410201021.i9KALGwQ046049@repoman.freebsd.org> From: Robert Watson Date: Wed, 20 Oct 2004 10:21:16 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Subject: cvs commit: src/sys/nfsserver nfs_serv.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2004 10:21:16 -0000 rwatson 2004-10-20 10:21:16 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) sys/nfsserver nfs_serv.c Log: Merge nfs_server.c:1.149 from HEAD to RELENG_5: date: 2004/10/18 11:23:11; author: rwatson; state: Exp; lines: +61 -13 Correct several instances where calls to vfs_getvfs() resulting in failure in the NFS server would result in a leaked instance of the NFS server subsystem lock. Liberally sprinkle assertions in all target labels for error unwinding to assert the desired locking state. RELENG_5_3 candidate. MFC after: 3 days Reported by: Wilkinson, Alex MFC after: 1 day Approved by: re (scottl) Revision Changes Path 1.147.2.2 +61 -13 src/sys/nfsserver/nfs_serv.c From owner-cvs-src@FreeBSD.ORG Wed Oct 20 11:05:27 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7335916A4CE; Wed, 20 Oct 2004 11:05:27 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 50E0743D31; Wed, 20 Oct 2004 11:05:27 +0000 (GMT) (envelope-from markm@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9KB5Rh6047403; Wed, 20 Oct 2004 11:05:27 GMT (envelope-from markm@repoman.freebsd.org) Received: (from markm@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9KB5RW2047402; Wed, 20 Oct 2004 11:05:27 GMT (envelope-from markm) Message-Id: <200410201105.i9KB5RW2047402@repoman.freebsd.org> From: Mark Murray Date: Wed, 20 Oct 2004 11:05:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Subject: cvs commit: src/sys/modules/mem Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2004 11:05:27 -0000 markm 2004-10-20 11:05:27 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) sys/modules/mem Makefile Log: Ensure that the loadable module version of the mem device contains the same as for the builtin case. Approved by: re(scottl) Revision Changes Path 1.2.2.1 +6 -0 src/sys/modules/mem/Makefile From owner-cvs-src@FreeBSD.ORG Wed Oct 20 11:18:32 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 33F3116A4D0; Wed, 20 Oct 2004 11:18:32 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 13A4E43D2D; Wed, 20 Oct 2004 11:18:32 +0000 (GMT) (envelope-from maxim@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9KBIVAX048007; Wed, 20 Oct 2004 11:18:31 GMT (envelope-from maxim@repoman.freebsd.org) Received: (from maxim@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9KBIVxr048006; Wed, 20 Oct 2004 11:18:31 GMT (envelope-from maxim) Message-Id: <200410201118.i9KBIVxr048006@repoman.freebsd.org> From: Maxim Konovalov Date: Wed, 20 Oct 2004 11:18:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.bin/netstat main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2004 11:18:32 -0000 maxim 2004-10-20 11:18:31 UTC FreeBSD src repository Modified files: usr.bin/netstat main.c Log: -c flag (cache stats) was killed in rev. 1.68. Fix getopt(3) and usage() accordingly. Submitted by: Pawel Worach Revision Changes Path 1.70 +2 -2 src/usr.bin/netstat/main.c From owner-cvs-src@FreeBSD.ORG Wed Oct 20 11:28:06 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BF2CD16A4CE; Wed, 20 Oct 2004 11:28:06 +0000 (GMT) Received: from zaphod.nitro.dk (port324.ds1-khk.adsl.cybercity.dk [212.242.113.79]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6814243D55; Wed, 20 Oct 2004 11:28:06 +0000 (GMT) (envelope-from simon@zaphod.nitro.dk) Received: by zaphod.nitro.dk (Postfix, from userid 3000) id E13B1119B9; Wed, 20 Oct 2004 13:28:04 +0200 (CEST) Date: Wed, 20 Oct 2004 13:28:04 +0200 From: "Simon L. Nielsen" To: =?iso-8859-1?Q?S=F8ren?= Schmidt Message-ID: <20041020112804.GA757@zaphod.nitro.dk> References: <200410201011.i9KAB5KS045683@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="EeQfGwPcQSOJBaQU" Content-Disposition: inline In-Reply-To: <200410201011.i9KAB5KS045683@repoman.freebsd.org> User-Agent: Mutt/1.5.6i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/ata ata-queue.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2004 11:28:07 -0000 --EeQfGwPcQSOJBaQU Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2004.10.20 10:11:05 +0000, S=F8ren Schmidt wrote: > sos 2004-10-20 10:11:05 UTC >=20 > FreeBSD src repository >=20 > Modified files: > sys/dev/ata ata-queue.c=20 > Log: > Do not retry on requests that has lost thier device during reinit. > =20 > Should fix hangs on IBM's etc with the fake slave problem. This fixes booting on my IBM Thinkpad R40 again, thanks! > MFC: > asap This _really_ should go into 5.3, since a lot of laptop users otherwise won't be able boot. --=20 Simon L. Nielsen FreeBSD Documentation Team --EeQfGwPcQSOJBaQU Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBdkvEh9pcDSc1mlERAqcSAJ9+EiBzke1nHs9RQ7n0Z4kawKNjoACgkv79 /vFIrAa+BcweUm627r2f9/8= =ZBfa -----END PGP SIGNATURE----- --EeQfGwPcQSOJBaQU-- From owner-cvs-src@FreeBSD.ORG Wed Oct 20 11:43:12 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 94DF016A4CF; Wed, 20 Oct 2004 11:43:12 +0000 (GMT) Received: from spider.deepcore.dk (cpe.atm2-0-53484.0x50a6c9a6.abnxx9.customer.tele.dk [80.166.201.166]) by mx1.FreeBSD.org (Postfix) with ESMTP id E834F43D49; Wed, 20 Oct 2004 11:43:11 +0000 (GMT) (envelope-from sos@DeepCore.dk) Received: from [172.18.2.1] (axiell-gw1.novi.dk [130.225.63.24]) by spider.deepcore.dk (8.12.11/8.12.10) with ESMTP id i9KBh7cJ056102; Wed, 20 Oct 2004 13:43:09 +0200 (CEST) (envelope-from sos@DeepCore.dk) Message-ID: <41764F35.9010102@DeepCore.dk> Date: Wed, 20 Oct 2004 13:42:45 +0200 From: =?ISO-8859-1?Q?S=F8ren_Schmidt?= User-Agent: Mozilla Thunderbird 0.7.2 (X11/20040802) X-Accept-Language: en-us, en MIME-Version: 1.0 To: "Simon L. Nielsen" References: <200410201011.i9KAB5KS045683@repoman.freebsd.org> <20041020112804.GA757@zaphod.nitro.dk> In-Reply-To: <20041020112804.GA757@zaphod.nitro.dk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable X-mail-scanned: by DeepCore Virus & Spam killer v1.4 cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG cc: =?ISO-8859-1?Q?S=F8ren_Schmidt?= Subject: Re: cvs commit: src/sys/dev/ata ata-queue.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2004 11:43:12 -0000 Simon L. Nielsen wrote: > On 2004.10.20 10:11:05 +0000, S=F8ren Schmidt wrote: >=20 >>sos 2004-10-20 10:11:05 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/dev/ata ata-queue.c=20 >> Log: >> Do not retry on requests that has lost thier device during reinit. >> =20 >> Should fix hangs on IBM's etc with the fake slave problem. >=20 >=20 > This fixes booting on my IBM Thinkpad R40 again, thanks! >=20 >=20 >> MFC: >> asap >=20 >=20 > This _really_ should go into 5.3, since a lot of laptop users > otherwise won't be able boot. Thats the plan, but let the dust settle a little first... --=20 -S=F8ren From owner-cvs-src@FreeBSD.ORG Wed Oct 20 00:47:17 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3C8AC16A4CE; Wed, 20 Oct 2004 00:47:17 +0000 (GMT) Received: from mail.vicor-nb.com (bigwoop.vicor-nb.com [208.206.78.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0888B43D1F; Wed, 20 Oct 2004 00:47:14 +0000 (GMT) (envelope-from julian@elischer.org) Received: from elischer.org (julian.vicor-nb.com [208.206.78.97]) by mail.vicor-nb.com (Postfix) with ESMTP id A50BD7A41E; Tue, 19 Oct 2004 17:47:13 -0700 (PDT) Message-ID: <4175B591.4090407@elischer.org> Date: Tue, 19 Oct 2004 17:47:13 -0700 From: Julian Elischer User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.3.1) Gecko/20030516 X-Accept-Language: en, hu MIME-Version: 1.0 To: Maxim Sobolev References: <20041019071102.GA49717@FreeBSD.org> <20041019072349.GA28133@samodelkin.net> <20041019073145.GA29746@thingy.tbd.co.nz> <20041019.084324.106215221.imp@bsdimp.com> <4175B0CD.1050204@portaone.com> In-Reply-To: <4175B0CD.1050204@portaone.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Wed, 20 Oct 2004 11:55:09 +0000 cc: danfe@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org cc: ru@FreeBSD.org cc: obrien@FreeBSD.org cc: andy@fud.org.nz cc: "M. Warner Losh" cc: fjoe@samodelkin.net Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2004 00:47:17 -0000 Maxim Sobolev wrote: > M. Warner Losh wrote: > >> In message: <20041019073145.GA29746@thingy.tbd.co.nz> >> Andrew Thompson writes: >> : > I am afraid that recompiling a kernel on i386 will require >> several days. >> : : Chicken and the egg. To support i386 it must be recompiled, so >> you would >> : have to do it on another box anyway. >> >> The only people that will seriously want to use i386 these days are >> the folks that build embedded systems. Those you have to build on >> some host then deploy to the target system. >> >> There are some benefits to having i386 in the tree. However, there >> are also a number of different places in the tree where things are >> sub-optimal because we still have support for i386 in there. The >> desire to remove them is to make FreeBSD go faster on more modern >> hardware. > > > Can anyone give at least one valid point why somebody will want to use > 6.x on embedded i386? Such hardware is inheretedly limited, so that > all good stuff that have been added into FreeBSD during the past few years > (SMPng, GEOM, KSE, you-name-it) is SMP is the only one of these for which you are correct.. KSE and geom couldn't care about 486 or 386.. I think 386 machines are not going to be SMP. I would be happy to see SMP completely incompatible with 386 (I mean you don't need atomic operations at all on a UP system, so any such instructions can be ignored in that case.) doesn't mean we shouldn't rip it out.. just pointing out that in fact there is a "middle position" where we continue to support Uniprocessor 386.. > of no use on that hardware anyway. IMO any reasonable embedded folks > would just stick > with 4.x or even 3.x due to their smaller footprint and better > performance on old systems. I'd like to see a 4.x with threads :-) hmm maybe dragonfly..... > > > Let's just rip that old junk off! > > -Maxim From owner-cvs-src@FreeBSD.ORG Wed Oct 20 01:11:32 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 62DA816A4CE; Wed, 20 Oct 2004 01:11:32 +0000 (GMT) Received: from web.portaone.com (support.portaone.com [195.70.151.35]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8EE9E43D49; Wed, 20 Oct 2004 01:11:31 +0000 (GMT) (envelope-from sobomax@portaone.com) Received: from [192.168.1.100] (xDSL-2-2.united.net.ua [193.111.9.226]) (authenticated bits=0) by web.portaone.com (8.12.11/8.12.11) with ESMTP id i9K1BES6026310 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 20 Oct 2004 03:11:17 +0200 (CEST) (envelope-from sobomax@portaone.com) Message-ID: <4175BB27.2010406@portaone.com> Date: Wed, 20 Oct 2004 04:11:03 +0300 From: Maxim Sobolev Organization: Porta Software Ltd User-Agent: Mozilla Thunderbird 0.8 (Windows/20040913) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Julian Elischer References: <20041019071102.GA49717@FreeBSD.org> <20041019072349.GA28133@samodelkin.net> <20041019073145.GA29746@thingy.tbd.co.nz> <20041019.084324.106215221.imp@bsdimp.com> <4175B0CD.1050204@portaone.com> <4175B591.4090407@elischer.org> In-Reply-To: <4175B591.4090407@elischer.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Wed, 20 Oct 2004 11:55:09 +0000 cc: danfe@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org cc: ru@FreeBSD.org cc: obrien@FreeBSD.org cc: andy@fud.org.nz cc: "M. Warner Losh" cc: fjoe@samodelkin.net Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2004 01:11:32 -0000 Julian Elischer wrote: > > > Maxim Sobolev wrote: > >> M. Warner Losh wrote: >> >>> In message: <20041019073145.GA29746@thingy.tbd.co.nz> >>> Andrew Thompson writes: >>> : > I am afraid that recompiling a kernel on i386 will require >>> several days. >>> : : Chicken and the egg. To support i386 it must be recompiled, so >>> you would >>> : have to do it on another box anyway. >>> >>> The only people that will seriously want to use i386 these days are >>> the folks that build embedded systems. Those you have to build on >>> some host then deploy to the target system. >>> >>> There are some benefits to having i386 in the tree. However, there >>> are also a number of different places in the tree where things are >>> sub-optimal because we still have support for i386 in there. The >>> desire to remove them is to make FreeBSD go faster on more modern >>> hardware. >> >> >> >> Can anyone give at least one valid point why somebody will want to use >> 6.x on embedded i386? Such hardware is inheretedly limited, so that >> all good stuff that have been added into FreeBSD during the past few >> years > > > >> (SMPng, GEOM, KSE, you-name-it) is > > > SMP is the only one of these for which you are correct.. > > KSE and geom couldn't care about 486 or 386.. > I think 386 machines are not going to be SMP. > I would be happy to see SMP completely incompatible with 386 > (I mean you don't need atomic operations at all on a UP system, so > any such instructions can be ignored in that case.) Neither of those technologies is really necessary in such applications to be able to justify an additional 4.x vs. 5.x performance/memory consumption penalty which will be quite considerable for low-performance, low-memory embedded device, which is my point. > doesn't mean we shouldn't rip it out.. just pointing out that in fact > there is a "middle position" > where we continue to support Uniprocessor 386.. > >> of no use on that hardware anyway. IMO any reasonable embedded folks >> would just stick > > >> with 4.x or even 3.x due to their smaller footprint and better >> performance on old systems. > > > > I'd like to see a 4.x with threads :-) > hmm maybe dragonfly..... You have 5.x for that. -Maxim > > >> >> >> Let's just rip that old junk off! >> >> -Maxim > > > > > From owner-cvs-src@FreeBSD.ORG Wed Oct 20 12:42:56 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C2EBD16A4CE; Wed, 20 Oct 2004 12:42:56 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7BE7443D49; Wed, 20 Oct 2004 12:42:56 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9KCgu01050854; Wed, 20 Oct 2004 12:42:56 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9KCgu0L050853; Wed, 20 Oct 2004 12:42:56 GMT (envelope-from rwatson) Message-Id: <200410201242.i9KCgu0L050853@repoman.freebsd.org> From: Robert Watson Date: Wed, 20 Oct 2004 12:42:56 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Subject: cvs commit: src/sys/kern kern_descrip.c uipc_socket.c uipc_usrreq.c src/sys/net raw_cb.c raw_usrreq.c src/sys/netatalk ddp_pcb.c src/sys/netatm atm_socket.cng_btsocket_l2cap.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2004 12:42:57 -0000 rwatson 2004-10-20 12:42:56 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) sys/kern kern_descrip.c uipc_socket.c uipc_usrreq.c sys/net raw_cb.c raw_usrreq.c sys/netatalk ddp_pcb.c sys/netatm atm_socket.c sys/netgraph/bluetooth/socket ng_btsocket_hci_raw.c ng_btsocket_l2cap.c ng_btsocket_l2cap_raw.c ng_btsocket_rfcomm.c sys/netinet in_pcb.c tcp_subr.c sys/netinet6 in6_pcb.c sys/netipx ipx_pcb.c ipx_usrreq.c sys/netnatm natm.c sys/sys socketvar.h Log: Merge kern_descrip.c:1.246, uipc_socket.c:1.214, uipc_usrreq.c:1.141, raw_cb.c:1.30, raw_usrreq.c:1.35, ddp_pcb.c:1.45, atm_socket.c:1.21, ng_btsocket_hci_raw.c:1.16, ng_btsocket_l2cap.c:1.14, ng_btsocket_l2cap_raw.c:1.13, ng_btsocket_rfcomm.c:1.13, in_pcb.c:1.156, tcp_subr.c:1.205, in6_pcb.c:1.61, ipx_pcb.c:1.29, ipx_usrreq.c:1.41, natm.c:1.35, socketvar.h:1.135 from HEAD to RELENG_5: Push acquisition of the accept mutex out of sofree() into the caller (sorele()/sotryfree()): - This permits the caller to acquire the accept mutex before the socket mutex, avoiding sofree() having to drop the socket mutex and re-order, which could lead to races permitting more than one thread to enter sofree() after a socket is ready to be free'd. - This also covers clearing of the so_pcb weak socket reference from the protocol to the socket, preventing races in clearing and evaluation of the reference such that sofree() might be called more than once on the same socket. This appears to close a race I was able to easily trigger by repeatedly opening and resetting TCP connections to a host, in which the tcp_close() code called as a result of the RST raced with the close() of the accepted socket in the user process resulting in simultaneous attempts to de-allocate the same socket. The new locking increases the overhead for operations that may potentially free the socket, so we will want to revise the synchronization strategy here as we normalize the reference counting model for sockets. The use of the accept mutex in freeing of sockets that are not listen sockets is primarily motivated by the potential need to remove the socket from the incomplete connection queue on its parent (listen) socket, so cleaning up the reference model here may allow us to substantially weaken the synchronization requirements. RELENG_5_3 candidate. MFC after: 3 days Reviewed by: dwhite Discussed with: gnn, dwhite, green Reported by: Marc UBM Bocklet Reported by: Vlad MFC after: 1 day Approved by: re (scottl) Revision Changes Path 1.243.2.3 +1 -0 src/sys/kern/kern_descrip.c 1.208.2.4 +4 -3 src/sys/kern/uipc_socket.c 1.138.2.3 +1 -0 src/sys/kern/uipc_usrreq.c 1.29.2.1 +1 -0 src/sys/net/raw_cb.c 1.34.2.1 +1 -0 src/sys/net/raw_usrreq.c 1.44.2.1 +1 -0 src/sys/netatalk/ddp_pcb.c 1.20.2.1 +1 -0 src/sys/netatm/atm_socket.c 1.15.2.1 +1 -0 src/sys/netgraph/bluetooth/socket/ng_btsocket_hci_raw.c 1.13.2.1 +2 -0 src/sys/netgraph/bluetooth/socket/ng_btsocket_l2cap.c 1.12.2.1 +1 -0 src/sys/netgraph/bluetooth/socket/ng_btsocket_l2cap_raw.c 1.12.2.1 +1 -0 src/sys/netgraph/bluetooth/socket/ng_btsocket_rfcomm.c 1.153.2.2 +1 -0 src/sys/netinet/in_pcb.c 1.201.2.2 +1 -0 src/sys/netinet/tcp_subr.c 1.59.2.2 +1 -0 src/sys/netinet6/in6_pcb.c 1.28.2.1 +1 -0 src/sys/netipx/ipx_pcb.c 1.40.2.1 +1 -0 src/sys/netipx/ipx_usrreq.c 1.34.2.1 +2 -0 src/sys/netnatm/natm.c 1.133.2.2 +10 -2 src/sys/sys/socketvar.h From owner-cvs-src@FreeBSD.ORG Wed Oct 20 16:22:00 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AD68E16A4CE; Wed, 20 Oct 2004 16:22:00 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8DDAF43D69; Wed, 20 Oct 2004 16:22:00 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9KGM0LG063858; Wed, 20 Oct 2004 16:22:00 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9KGM0Tn063857; Wed, 20 Oct 2004 16:22:00 GMT (envelope-from jhb) Message-Id: <200410201622.i9KGM0Tn063857@repoman.freebsd.org> From: John Baldwin Date: Wed, 20 Oct 2004 16:22:00 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/zs zs.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2004 16:22:00 -0000 jhb 2004-10-20 16:22:00 UTC FreeBSD src repository Modified files: sys/dev/zs zs.c Log: Fix a typo so that this compiles again. Revision Changes Path 1.30 +1 -1 src/sys/dev/zs/zs.c From owner-cvs-src@FreeBSD.ORG Wed Oct 20 16:22:54 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6291D16A4CE; Wed, 20 Oct 2004 16:22:54 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3152343D1D; Wed, 20 Oct 2004 16:22:54 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9KGMsgl063900; Wed, 20 Oct 2004 16:22:54 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9KGMsWu063899; Wed, 20 Oct 2004 16:22:54 GMT (envelope-from jhb) Message-Id: <200410201622.i9KGMsWu063899@repoman.freebsd.org> From: John Baldwin Date: Wed, 20 Oct 2004 16:22:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/alpha/alpha promcons.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2004 16:22:54 -0000 jhb 2004-10-20 16:22:54 UTC FreeBSD src repository Modified files: sys/alpha/alpha promcons.c Log: Fix a typo so that this compiles. Revision Changes Path 1.43 +1 -1 src/sys/alpha/alpha/promcons.c From owner-cvs-src@FreeBSD.ORG Wed Oct 20 16:58:28 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DC65016A4CF; Wed, 20 Oct 2004 16:58:28 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 88D7643D46; Wed, 20 Oct 2004 16:58:28 +0000 (GMT) (envelope-from keramida@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9KGwSfs071310; Wed, 20 Oct 2004 16:58:28 GMT (envelope-from keramida@repoman.freebsd.org) Received: (from keramida@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9KGwSS7071309; Wed, 20 Oct 2004 16:58:28 GMT (envelope-from keramida) Message-Id: <200410201658.i9KGwSS7071309@repoman.freebsd.org> From: Giorgos Keramidas Date: Wed, 20 Oct 2004 16:58:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/etc/defaults rc.conf src/share/man/man5 rc.conf.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2004 16:58:29 -0000 keramida 2004-10-20 16:58:28 UTC FreeBSD src repository (doc committer) Modified files: etc/defaults rc.conf share/man/man5 rc.conf.5 Log: Introduce root_rw_mount as a new variable in defaults/rc.conf to unbreak /etc/rc.d/root for diskless systems that get their root filesystem from a read-only NFS mount. PR: conf/72927 Submitted by: Ralf Wenk Reviewed by: brooks Revision Changes Path 1.226 +1 -0 src/etc/defaults/rc.conf 1.229 +13 -0 src/share/man/man5/rc.conf.5 From owner-cvs-src@FreeBSD.ORG Wed Oct 20 17:16:08 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9331716A4CE; Wed, 20 Oct 2004 17:16:08 +0000 (GMT) Received: from gw.Awfulhak.org (awfulhak.demon.co.uk [80.177.173.150]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5D19443D3F; Wed, 20 Oct 2004 17:16:07 +0000 (GMT) (envelope-from brian@Awfulhak.org) Received: from dev.lan.Awfulhak.org (brian@dev.lan.Awfulhak.org [172.16.0.5]) by gw.Awfulhak.org (8.13.1/8.13.1) with SMTP id i9KHFde2010304; Wed, 20 Oct 2004 18:15:39 +0100 (BST) (envelope-from brian@Awfulhak.org) Date: Wed, 20 Oct 2004 18:15:49 +0100 From: Brian Somers To: Pawel Jakub Dawidek Message-ID: <20041020181549.1cbc2bd3@dev.lan.Awfulhak.org> In-Reply-To: <200410150611.i9F6BSRd066269@repoman.freebsd.org> References: <200410150611.i9F6BSRd066269@repoman.freebsd.org> X-Mailer: Sylpheed-Claws 0.9.12b (GTK+ 1.2.10; i386-portbld-freebsd6.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.8 required=5.0 tests=ALL_TRUSTED autolearn=failed version=3.0.0 X-Spam-Checker-Version: SpamAssassin 3.0.0 (2004-09-13) on gw.lan.Awfulhak.org cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/geom/raid3 g_raid3.c g_raid3.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2004 17:16:08 -0000 On Fri, 15 Oct 2004 06:11:28 +0000 (UTC), Pawel Jakub Dawidek wrote: > pjd 2004-10-15 06:11:28 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_5) > sys/geom/raid3 g_raid3.c g_raid3.h > Log: > - There is no need to skip providers with 0 sectorsize in taste routine > anymore. Does this apply for raid5 too? I'm getting all sorts of zero sector size errors with a machine upgraded from RELENG_4 - but depending on when I bring vinum up! If I try to boot with vinum enabled, I get a dangling vnode panic. If I try to boot without vinum and have a vinum.sh startup that does a vinum start and a mount, I get a wrong sectorsize error and lose one of the six disks (ending up in degraded mode). The only way to get things up is to boot -s, ``fsck -p'', ``vinum start'', then continue to multi-user. -- Brian Don't _EVER_ lose your sense of humour ! From owner-cvs-src@FreeBSD.ORG Wed Oct 20 17:25:52 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D51C316A4D0 for ; Wed, 20 Oct 2004 17:25:52 +0000 (GMT) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5FC6A43D48 for ; Wed, 20 Oct 2004 17:25:51 +0000 (GMT) (envelope-from andre@freebsd.org) Received: (qmail 69785 invoked from network); 20 Oct 2004 17:24:38 -0000 Received: from unknown (HELO freebsd.org) ([62.48.0.53]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 20 Oct 2004 17:24:38 -0000 Message-ID: <41769FA5.413832D@freebsd.org> Date: Wed, 20 Oct 2004 19:25:57 +0200 From: Andre Oppermann X-Mailer: Mozilla 4.8 [en] (Windows NT 5.0; U) X-Accept-Language: en MIME-Version: 1.0 To: Max Laier References: <200410191513.i9JFDUbf072176@repoman.freebsd.org> <200410200035.19752.max@love2party.net> <41759D75.1B6BDDC2@freebsd.org> <200410200129.54320.max@love2party.net> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: Sam Leffler cc: src-committers@freebsd.org cc: cvs-all@freebsd.org cc: cvs-src@freebsd.org Subject: Re: cvs commit: src/sys/sys protosw.h src/sys/kern uipc_domain.cuipc_socket2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2004 17:25:53 -0000 Max Laier wrote: > > On Wednesday 20 October 2004 01:04, Andre Oppermann wrote: > > Please point them out. We can discuss specifics then instead of creating > > a clout of FUD. > > Okay, that's the last straw. This is not FUD. We are really concerned that you > are introduceing something that is not fully though about. Not exactly. Dynamically registering and unregistering is not the problem. It works without causing panics or races (except when two protcols want to register exactly at the same time which is perfectly solved with GIANT). > We will have problems with this and I really think that it should be backed > out now and fixed before reconsidered! What can be problematic is not the unregistering of an protocol but the subsequent unloading of the module that implemented said protocol. This is where where all this discussion comes from (?). In the case of IPDIVERT I made it unloadable and as you correctly say there can be certain race conditions. The solution is not to back out what I committed but to make IPDIVERT to refuse to unload, *or* to fix IPDIVERT in a way to make it 100% race safe to unload. > Unloading (of divert) has races that can be triggered. Claiming that they will > not be "most of the time" is not exactly the right approach for serious > development. For the record; The risk for a panic I introduced here with IPDIVERT is several squareorders in magnitude lower than the accept() panic fixed a couple of days ago because here it could only happen if someone was actually trying to unload IPDIVERT. It would never happen in any other circumstances. That being said, see above how to fix. > And for pointing out specifics: ip_encap is going to be a lot of fun. And > that's just the most obvious, I could find. I will not scan the tree for more > places, but the ip_icmp.c example shows that you didn't scan the tree > carefully enough before you committed this work without previous discussion. > It seems that you just assume that everything is fine. It really is not! You are on the wrong boat here. ip_encap is an entirely different animal. ip_encap manages its own private protosw to demux many sub-protocols that have accumulated over time on the original GRE IP protocol type. What ip_encap is doing has no relation to the general ip_proto_[un]register function because it can't and doesn't deal with ip_encap's private protosw. And to rebut that I have carelessly thrown some untested and immature piece of code in there; I have in fact looked and thought through this and studied the code that uses it. It fits nicely into the design and intention of the protosw structure concept. That's why I have done this and not some other way. The ip_icmp.c example is the only one in the netinet code. In other places tests are done to check if the function pointer is != NULL. As Harti said the compiler will do whatever it wants. This makes unloading almost any module unsafe, doesn't it? > I understand that you didn't want to slow things down in a bikeshed, but this > is not ready, sorry. No no, things got mixed up wrt. protcol unregistering (which is fine and has its uses) and unloading a module immediatly after it unregistered its protocol. -- Andre From owner-cvs-src@FreeBSD.ORG Wed Oct 20 17:44:41 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1C70A16A4CE; Wed, 20 Oct 2004 17:44:41 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id EFD3543D49; Wed, 20 Oct 2004 17:44:40 +0000 (GMT) (envelope-from alc@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9KHietg072801; Wed, 20 Oct 2004 17:44:40 GMT (envelope-from alc@repoman.freebsd.org) Received: (from alc@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9KHieTo072800; Wed, 20 Oct 2004 17:44:40 GMT (envelope-from alc) Message-Id: <200410201744.i9KHieTo072800@repoman.freebsd.org> From: Alan Cox Date: Wed, 20 Oct 2004 17:44:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern uipc_syscalls.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2004 17:44:41 -0000 alc 2004-10-20 17:44:40 UTC FreeBSD src repository Modified files: sys/kern uipc_syscalls.c Log: Modify the vm object locking in do_sendfile() so that the containing object is locked when vm_page_io_finish() is called on a page. This is to satisfy a new, post-RELENG_5 assertion in vm_page_io_finish(). (I am in the process of transitioning the responsibility for synchronizing access to various fields/flags on the page from the global page queues lock to the per-object lock.) Tripped over by: obrien@ Revision Changes Path 1.202 +3 -2 src/sys/kern/uipc_syscalls.c From owner-cvs-src@FreeBSD.ORG Wed Oct 20 18:32:39 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1B74616A4CE; Wed, 20 Oct 2004 18:32:39 +0000 (GMT) Received: from darkness.comp.waw.pl (darkness.comp.waw.pl [195.117.238.136]) by mx1.FreeBSD.org (Postfix) with ESMTP id E8C2743D1D; Wed, 20 Oct 2004 18:32:37 +0000 (GMT) (envelope-from pjd@darkness.comp.waw.pl) Received: by darkness.comp.waw.pl (Postfix, from userid 1009) id D4DFEAE687; Wed, 20 Oct 2004 20:32:27 +0200 (CEST) Date: Wed, 20 Oct 2004 20:32:27 +0200 From: Pawel Jakub Dawidek To: Brian Somers Message-ID: <20041020183227.GL73767@darkness.comp.waw.pl> References: <200410150611.i9F6BSRd066269@repoman.freebsd.org> <20041020181549.1cbc2bd3@dev.lan.Awfulhak.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="4PJrhwplEACoeAEn" Content-Disposition: inline In-Reply-To: <20041020181549.1cbc2bd3@dev.lan.Awfulhak.org> User-Agent: Mutt/1.4.2i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 5.2.1-RC2 i386 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/geom/raid3 g_raid3.c g_raid3.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2004 18:32:39 -0000 --4PJrhwplEACoeAEn Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 20, 2004 at 06:15:49PM +0100, Brian Somers wrote: +> On Fri, 15 Oct 2004 06:11:28 +0000 (UTC), Pawel Jakub Dawidek wrote: +> > pjd 2004-10-15 06:11:28 UTC +> >=20 +> > FreeBSD src repository +> >=20 +> > Modified files: (Branch: RELENG_5) +> > sys/geom/raid3 g_raid3.c g_raid3.h=20 +> > Log: +> > - There is no need to skip providers with 0 sectorsize in taste rout= ine +> > anymore. +>=20 +> Does this apply for raid5 too? I'm getting all sorts of zero sector size +> errors with a machine upgraded from RELENG_4 - but depending on when I +> bring vinum up! My GEOM classes are not related to vinum at all. You probably should ask greg@ (about 4.x) or le@ (about 5.x). --=20 Pawel Jakub Dawidek http://www.FreeBSD.org pjd@FreeBSD.org http://garage.freebsd.pl FreeBSD committer Am I Evil? Yes, I Am! --4PJrhwplEACoeAEn Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFBdq87ForvXbEpPzQRAkvjAKDfdK4s+zQoeE3itfTp1tIDB/4LZgCfewcA 0FkVpH0ub9iL8Nv1sGjn6b0= =16xW -----END PGP SIGNATURE----- --4PJrhwplEACoeAEn-- From owner-cvs-src@FreeBSD.ORG Wed Oct 20 18:33:45 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ABA8016A4CE; Wed, 20 Oct 2004 18:33:45 +0000 (GMT) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2915743D31; Wed, 20 Oct 2004 18:33:45 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.13.1/8.13.1) with ESMTP id i9KIXhVl037157; Wed, 20 Oct 2004 11:33:43 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.13.1/8.13.1/Submit) id i9KIXhrg037156; Wed, 20 Oct 2004 11:33:43 -0700 (PDT) (envelope-from obrien) Date: Wed, 20 Oct 2004 11:33:43 -0700 From: "David O'Brien" To: src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG Message-ID: <20041020183343.GA37078@dragon.nuxi.com> References: <20041019071102.GA49717@FreeBSD.org> <20041019073145.GA29746@thingy.tbd.co.nz> <20041019.084324.106215221.imp@bsdimp.com> <200410191541.54269.jhb@FreeBSD.org> <20041019215007.GA13217@VARK.MIT.EDU> <20041019220031.GA98675@falcon.midgard.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041019220031.GA98675@falcon.midgard.homeip.net> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 6.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@FreeBSD.ORG List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2004 18:33:45 -0000 On Wed, Oct 20, 2004 at 12:00:31AM +0200, Erik Trulsson wrote: > On Tue, Oct 19, 2004 at 05:50:07PM -0400, David Schultz wrote: > > Yes, and very few of those folks are likely to want a relatively > > large, non-realtime, monolithic, multi-threaded OS kernel, much > > less a userland that even vaguely resembles a standard FreeBSD > > installation. > > > > Every time this issue comes up, someone points out that in fact, > > FreeBSD still runs on the 80386 that they just threw out. > > However, nobody ever presents an important reason for *wanting* to > > run FreeBSD on an 80386. > > The only reason I am not running FreeBSD on an 80386 is that the PSU in > my 80386sx based computer gave up a few months ago (or at least > something power-related did.) Until then I was happily running > 4.10-stable on it and using it as a firewall/gateway. The question isn't would someone want to run FreeBSD on an 80386. The question is would one actually want to run RELENG_5 or 6-CURRENT on an 80386 given how much a dog it will be. I don't think the pro-80386 arguers have any idea how slow 5.3 is on a 80386. I think you would have quickly down-graded back to 4-STABLE on your 80386 after using 5.3 on it for a week. David Schultz summerized things nicely above. -- -- David (obrien@FreeBSD.org) From owner-cvs-src@FreeBSD.ORG Wed Oct 20 18:56:34 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 67F5A16A4D0; Wed, 20 Oct 2004 18:56:34 +0000 (GMT) Received: from mail.ambrisko.com (adsl-64-174-51-43.dsl.snfc21.pacbell.net [64.174.51.43]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3476643D53; Wed, 20 Oct 2004 18:56:34 +0000 (GMT) (envelope-from ambrisko@ambrisko.com) Received: from server2.ambrisko.com (HELO www.ambrisko.com) (192.168.1.2) by mail.ambrisko.com with ESMTP; 20 Oct 2004 11:56:34 -0700 Received: from ambrisko.com (localhost [127.0.0.1]) by www.ambrisko.com (8.12.9p2/8.12.9) with ESMTP id i9KIuXEl016490; Wed, 20 Oct 2004 11:56:33 -0700 (PDT) (envelope-from ambrisko@ambrisko.com) Received: (from ambrisko@localhost) by ambrisko.com (8.12.9p2/8.12.9/Submit) id i9KIuXHw016489; Wed, 20 Oct 2004 11:56:33 -0700 (PDT) (envelope-from ambrisko) From: Doug Ambrisko Message-Id: <200410201856.i9KIuXHw016489@ambrisko.com> In-Reply-To: <200410191541.54269.jhb@FreeBSD.org> To: John Baldwin Date: Wed, 20 Oct 2004 11:56:33 -0700 (PDT) X-Mailer: ELM [version 2.4ME+ PL94b (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: "M. Warner Losh" Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2004 18:56:34 -0000 John Baldwin writes: | I think 6.0 is the place to drop 80386, not 5.x. I'm already working on a p4 | branch (jhb_no386) to remove 80396 support from HEAD, but I think 5.x should | be left as is in this regard. If 6.0 is the place to drop 80386 and amd64 will running on a fair amount of new Intel HW (Xeon/P4/Mobile) then maybe we should just migrate FreeBSD to amd64 in the future and leave the i386 stuff as is and not worry about it as much. It seems amd64 should be the main platform for 6.0 IMHO since amd64 should be common place by then. This to me seems to be a cleaner point to split at. The main reason for not doing this is that there are some vendors kernel modules that won't work on amd64 so that would put a burden on them. For example I can't run the NVidia card with X on the Dell system at have at work when running amd64 but it works fine with their driver on i386. FWIW Doug A. From owner-cvs-src@FreeBSD.ORG Wed Oct 20 19:05:50 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BBC6016A4CE; Wed, 20 Oct 2004 19:05:50 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9D0EA43D46; Wed, 20 Oct 2004 19:05:50 +0000 (GMT) (envelope-from keramida@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9KJ5oCF075797; Wed, 20 Oct 2004 19:05:50 GMT (envelope-from keramida@repoman.freebsd.org) Received: (from keramida@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9KJ5oLO075796; Wed, 20 Oct 2004 19:05:50 GMT (envelope-from keramida) Message-Id: <200410201905.i9KJ5oLO075796@repoman.freebsd.org> From: Giorgos Keramidas Date: Wed, 20 Oct 2004 19:05:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/man/man5 rc.conf.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2004 19:05:50 -0000 keramida 2004-10-20 19:05:50 UTC FreeBSD src repository (doc committer) Modified files: share/man/man5 rc.conf.5 Log: Bump the document date, s/filesystem/file system/ and add missing word. Noticed by: ru Revision Changes Path 1.230 +3 -3 src/share/man/man5/rc.conf.5 From owner-cvs-src@FreeBSD.ORG Wed Oct 20 19:10:59 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C285816A4F3 for ; Wed, 20 Oct 2004 19:10:59 +0000 (GMT) Received: from mail3.speakeasy.net (mail3.speakeasy.net [216.254.0.203]) by mx1.FreeBSD.org (Postfix) with ESMTP id 759DC43D39 for ; Wed, 20 Oct 2004 19:10:59 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 31566 invoked from network); 20 Oct 2004 19:10:59 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 20 Oct 2004 19:10:58 -0000 Received: from [10.50.41.228] (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id i9KJAlbi059480; Wed, 20 Oct 2004 15:10:55 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Scott Long Date: Wed, 20 Oct 2004 14:19:06 -0400 User-Agent: KMail/1.6.2 References: <20041019071102.GA49717@FreeBSD.org> <200410191541.54269.jhb@FreeBSD.org> <41758B81.5090903@freebsd.org> In-Reply-To: <41758B81.5090903@freebsd.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200410201419.06181.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: "M. Warner Losh" Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2004 19:11:00 -0000 On Tuesday 19 October 2004 05:47 pm, Scott Long wrote: > John Baldwin wrote: > > On Tuesday 19 October 2004 10:43 am, you wrote: > >>In message: <20041019073145.GA29746@thingy.tbd.co.nz> > >> > >> Andrew Thompson writes: > >>: > I am afraid that recompiling a kernel on i386 will require several > >>: > days. > >>: > >>: Chicken and the egg. To support i386 it must be recompiled, so you > >>: would have to do it on another box anyway. > >> > >>The only people that will seriously want to use i386 these days are > >>the folks that build embedded systems. Those you have to build on > >>some host then deploy to the target system. > >> > >>There are some benefits to having i386 in the tree. However, there > >>are also a number of different places in the tree where things are > >>sub-optimal because we still have support for i386 in there. The > >>desire to remove them is to make FreeBSD go faster on more modern > >>hardware. > > > > I think 6.0 is the place to drop 80386, not 5.x. I'm already working on > > a p4 branch (jhb_no386) to remove 80396 support from HEAD, but I think > > 5.x should be left as is in this regard. > > I agree that 80386 support should not be removed from RELENG_5, but I > don't see anything wrong with optmizing the common case and adding an > extra 80386-specific hurdle to 5.x. It would be nice to have some actual real-world benchmarks that show that this change actually buys something. Recompiling a kernel isn't too high of a barrier to entry, but recompiling userland is a bit much. Many moons ago we decided to not remove 80386 support from 5.x, and since we've already branched RELENG_5 I think we are pretty much stuck with that now. 6.0 won't be that long in coming and we can kill it for good there. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org From owner-cvs-src@FreeBSD.ORG Wed Oct 20 19:58:03 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7EA2E16A4CF; Wed, 20 Oct 2004 19:58:03 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5E9ED43D31; Wed, 20 Oct 2004 19:58:03 +0000 (GMT) (envelope-from obrien@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9KJw3ZL078670; Wed, 20 Oct 2004 19:58:03 GMT (envelope-from obrien@repoman.freebsd.org) Received: (from obrien@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9KJw34t078669; Wed, 20 Oct 2004 19:58:03 GMT (envelope-from obrien) Message-Id: <200410201958.i9KJw34t078669@repoman.freebsd.org> From: "David E. O'Brien" Date: Wed, 20 Oct 2004 19:58:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/contrib/libreadline readline.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2004 19:58:03 -0000 obrien 2004-10-20 19:58:02 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) contrib/libreadline readline.h Log: Partially MFC rev 1.15: provide an escape to our "savestring" compatibility with ancient readline versions madness when 'RL_NO_COMPAT' is defined. This should help ports/devel/gdb6 to build on RELENG_4. Revision Changes Path 1.9.2.3 +3 -1 src/contrib/libreadline/readline.h From owner-cvs-src@FreeBSD.ORG Wed Oct 20 21:24:38 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3F69816A4CE; Wed, 20 Oct 2004 21:24:38 +0000 (GMT) Received: from VARK.MIT.EDU (VARK.MIT.EDU [18.95.3.179]) by mx1.FreeBSD.org (Postfix) with ESMTP id E153243D3F; Wed, 20 Oct 2004 21:24:37 +0000 (GMT) (envelope-from das@FreeBSD.ORG) Received: from VARK.MIT.EDU (localhost [127.0.0.1]) by VARK.MIT.EDU (8.13.1/8.12.10) with ESMTP id i9KLOvXE020702; Wed, 20 Oct 2004 17:24:57 -0400 (EDT) (envelope-from das@FreeBSD.ORG) Received: (from das@localhost) by VARK.MIT.EDU (8.13.1/8.12.10/Submit) id i9KLOv2P020701; Wed, 20 Oct 2004 17:24:57 -0400 (EDT) (envelope-from das@FreeBSD.ORG) Date: Wed, 20 Oct 2004 17:24:57 -0400 From: David Schultz To: Peter Jeremy Message-ID: <20041020212457.GA20486@VARK.MIT.EDU> Mail-Followup-To: Peter Jeremy , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <20041019071102.GA49717@FreeBSD.org> <20041019073145.GA29746@thingy.tbd.co.nz> <20041019.084324.106215221.imp@bsdimp.com> <200410191541.54269.jhb@FreeBSD.org> <20041019215007.GA13217@VARK.MIT.EDU> <20041019220031.GA98675@falcon.midgard.homeip.net> <20041019225231.GA13522@VARK.MIT.EDU> <20041020092525.GB79646@cirb503493.alcatel.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041020092525.GB79646@cirb503493.alcatel.com.au> cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2004 21:24:38 -0000 On Wed, Oct 20, 2004, Peter Jeremy wrote: > On Tue, 2004-Oct-19 18:52:31 -0400, David Schultz wrote: > >First of all, your 80386 (if it worked) would probably be much > >snappier running FreeBSD 3.X or 4.X or NetBSD 1.[2-5]. > > It is a lot easier to administer a collection of machines that are > all running close-to-the-same software. And FreeBSD 2.x is probably > a better match for 386-class hardware (the memory and disk footprint > is much smaller). Yes, so please don't try to justify continued support for i386 if you don't have a running i386. Every time this bikeshed comes up, there is no shortage of people who rally behind hardware they don't have. > >> > Nice. \me can't wait for the day when developers are no longer > >> > required to spend time and effort to support anything older than a PPro. > >> > >> That day will hopefully be far in the future. Personally I don't have > >> anything as modern as a PPro. > > > >Don't worry, it will be. I can dream, can't I? > > The 486 and Pentium provide useful new instructions and system controls. > What benefits does a PPro provide as far as the kernel and core userland > is concerned? Now we're really getting sidetracked. The main new feature of interest for me (and admittedly not for most other people) is MMX, for a couple of bad reasons. First, gcc generates slightly more correct floating-point code with MMX. Second, as long as we support !MMX, we would have to multilib the math library in order to make it work correctly with programs compiled for newer processors, in particular with respect to the floating-point exception flags. Granted, a few Pentium I chips have MMX support, too. But when you consider that the PPro also has CMOV and FCMOV, that the scheduling is fundamentally different for all processors after the Pentium, and that we currently have several hacks for Pentium I errata, drawing the line at PPro makes sense. But all this talk is all moot because if history is any lesson, this isn't going to happen for another decade. (Moreover, there *are* still plenty of FreeBSD users out there with Pentiums.) From owner-cvs-src@FreeBSD.ORG Wed Oct 20 23:08:09 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 47A1716A4CE for ; Wed, 20 Oct 2004 23:08:09 +0000 (GMT) Received: from av11-1-sn4.m-sp.skanova.net (av11-1-sn4.m-sp.skanova.net [81.228.10.106]) by mx1.FreeBSD.org (Postfix) with ESMTP id 310FD43D53 for ; Wed, 20 Oct 2004 23:08:08 +0000 (GMT) (envelope-from ertr1013@student.uu.se) Received: by av11-1-sn4.m-sp.skanova.net (Postfix, from userid 502) id 1DD2D37E43; Thu, 21 Oct 2004 01:08:07 +0200 (CEST) Received: from smtp4-2-sn4.m-sp.skanova.net (smtp4-2-sn4.m-sp.skanova.net [81.228.10.180]) by av11-1-sn4.m-sp.skanova.net (Postfix) with ESMTP id 0A75E37E42 for ; Thu, 21 Oct 2004 01:08:07 +0200 (CEST) Received: from falcon.midgard.homeip.net (h201n1fls24o1048.bredband.comhem.se [212.181.162.201]) by smtp4-2-sn4.m-sp.skanova.net (Postfix) with SMTP id 7867837E45 for ; Thu, 21 Oct 2004 01:08:06 +0200 (CEST) Received: (qmail 14726 invoked by uid 1001); 20 Oct 2004 23:08:06 -0000 Date: Thu, 21 Oct 2004 01:08:05 +0200 From: Erik Trulsson To: Peter Jeremy , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG Message-ID: <20041020230805.GA14696@falcon.midgard.homeip.net> Mail-Followup-To: Peter Jeremy , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <20041019071102.GA49717@FreeBSD.org> <20041019073145.GA29746@thingy.tbd.co.nz> <20041019.084324.106215221.imp@bsdimp.com> <200410191541.54269.jhb@FreeBSD.org> <20041019215007.GA13217@VARK.MIT.EDU> <20041019220031.GA98675@falcon.midgard.homeip.net> <20041019225231.GA13522@VARK.MIT.EDU> <20041020092525.GB79646@cirb503493.alcatel.com.au> <20041020212457.GA20486@VARK.MIT.EDU> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041020212457.GA20486@VARK.MIT.EDU> User-Agent: Mutt/1.5.6i Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2004 23:08:09 -0000 On Wed, Oct 20, 2004 at 05:24:57PM -0400, David Schultz wrote: > On Wed, Oct 20, 2004, Peter Jeremy wrote: > > On Tue, 2004-Oct-19 18:52:31 -0400, David Schultz wrote: > > >> > Nice. \me can't wait for the day when developers are no longer > > >> > required to spend time and effort to support anything older than a PPro. > > >> > > >> That day will hopefully be far in the future. Personally I don't have > > >> anything as modern as a PPro. > > > > > >Don't worry, it will be. I can dream, can't I? > > > > The 486 and Pentium provide useful new instructions and system controls. > > What benefits does a PPro provide as far as the kernel and core userland > > is concerned? > > Now we're really getting sidetracked. The main new feature of > interest for me (and admittedly not for most other people) is MMX, > for a couple of bad reasons. First, gcc generates slightly more > correct floating-point code with MMX. Second, as long as we > support !MMX, we would have to multilib the math library in order > to make it work correctly with programs compiled for newer > processors, in particular with respect to the floating-point > exception flags. Granted, a few Pentium I chips have MMX support, > too. But when you consider that the PPro also has CMOV and FCMOV, > that the scheduling is fundamentally different for all processors > after the Pentium, and that we currently have several hacks for > Pentium I errata, drawing the line at PPro makes sense. The PentiumPro does not have MMX so the above argument makes no sense. MMX was first supported on the P55C which came out in 1997 (after the original PentiumPro which came out in 1996.) (And there are probably more PentiumMMX computers out there than there are PentiumPro ones.) The Pentium II was the first CPU based on the P6-microarchitecture to support MMX. (P6 is the basic architecture used for the PentiumPro, Pentium II, and Pentium III.) So if you want to have MMX as well as CMOV you will have to draw the line at the Pentium II. As for scheduling that is also quite different between the Netburst architecture (Pentium 4) and the P6-based chips, so that sounds like a red herring. -- Erik Trulsson ertr1013@student.uu.se From owner-cvs-src@FreeBSD.ORG Thu Oct 21 01:11:26 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3EBB316A4CE; Thu, 21 Oct 2004 01:11:26 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1B85143D55; Thu, 21 Oct 2004 01:11:26 +0000 (GMT) (envelope-from ups@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9L1BPqC001924; Thu, 21 Oct 2004 01:11:25 GMT (envelope-from ups@repoman.freebsd.org) Received: (from ups@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9L1BPPK001923; Thu, 21 Oct 2004 01:11:25 GMT (envelope-from ups) Message-Id: <200410210111.i9L1BPPK001923@repoman.freebsd.org> From: Stephan Uphoff Date: Thu, 21 Oct 2004 01:11:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern subr_kdb.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2004 01:11:26 -0000 ups 2004-10-21 01:11:25 UTC FreeBSD src repository Modified files: sys/kern subr_kdb.c Log: Zero terminate empty sting in kdb_sysctl_available. Approved by: sam (mentor) MFC after: 1 week Revision Changes Path 1.9 +2 -0 src/sys/kern/subr_kdb.c From owner-cvs-src@FreeBSD.ORG Thu Oct 21 03:42:25 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0795716A4CE; Thu, 21 Oct 2004 03:42:25 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DB2F743D31; Thu, 21 Oct 2004 03:42:24 +0000 (GMT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9L3gOkj006466; Thu, 21 Oct 2004 03:42:24 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9L3gOMO006465; Thu, 21 Oct 2004 03:42:24 GMT (envelope-from davidxu) Message-Id: <200410210342.i9L3gOMO006465@repoman.freebsd.org> From: David Xu Date: Thu, 21 Oct 2004 03:42:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libpthread/thread thr_sig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2004 03:42:25 -0000 davidxu 2004-10-21 03:42:24 UTC FreeBSD src repository Modified files: lib/libpthread/thread thr_sig.c Log: Decrease reference count if we won't use the thread, this avoids memory leak under some cases. Revision Changes Path 1.80 +4 -0 src/lib/libpthread/thread/thr_sig.c From owner-cvs-src@FreeBSD.ORG Thu Oct 21 07:12:22 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5276816A4CE; Thu, 21 Oct 2004 07:12:22 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 99C5B43D46; Thu, 21 Oct 2004 07:12:21 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i9L7CKZi062927; Thu, 21 Oct 2004 10:12:20 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 15672-15; Thu, 21 Oct 2004 10:12:19 +0300 (EEST) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i9L7CB6I062907; Thu, 21 Oct 2004 10:12:14 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.1/8.13.1) id i9L7BmPg046173; Thu, 21 Oct 2004 10:11:48 +0300 (EEST) (envelope-from ru) Date: Thu, 21 Oct 2004 10:11:48 +0300 From: Ruslan Ermilov To: Andre Oppermann Message-ID: <20041021071148.GA46126@ip.net.ua> References: <200410192114.i9JLEvjQ001574@repoman.freebsd.org> <41758BF6.5020909@freebsd.org> <41758DF2.D3C1BD26@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="T4sUOijqQbZv57TR" Content-Disposition: inline In-Reply-To: <41758DF2.D3C1BD26@freebsd.org> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new at ip.net.ua cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Scott Long cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/modules/ipdivert Makefile src/sys/netinetin_proto.c ip_divert.c ip_divert.h ip_fw2.c ip_fw_pfil.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2004 07:12:22 -0000 --T4sUOijqQbZv57TR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 19, 2004 at 11:58:10PM +0200, Andre Oppermann wrote: > Scott Long wrote: [...] > > This is interesting. Have you measured performance/latency with this > > new scheme? Is it still possible to compile IPDIVERT into the kernel > > and avoid the indirect calls? >=20 > IPDIVERT can hardly be called a performance/latency critical path. The > entire copyout of the packet to userland for nat'ing and copyin again > make the function pointer indirection such a small factor that it doesn't > make any difference whatsoever. >=20 Err. divert(4) sockets can also be accessed through the ng_ksocket(4) interface, in which case no userland-kernel copying takes place. So the performance does matter. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --T4sUOijqQbZv57TR Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBd2E0qRfpzJluFF4RAttVAJkBN+xNuTuSrz/0LnKQB581uPavzgCgjlQQ OJDcsRfxOgRlEwkmWUNCXiM= =b24A -----END PGP SIGNATURE----- --T4sUOijqQbZv57TR-- From owner-cvs-src@FreeBSD.ORG Thu Oct 21 08:54:11 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5E41E16A4CE; Thu, 21 Oct 2004 08:54:11 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3C74743D45; Thu, 21 Oct 2004 08:54:11 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9L8sBY3028723; Thu, 21 Oct 2004 08:54:11 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9L8sBbY028722; Thu, 21 Oct 2004 08:54:11 GMT (envelope-from ru) Message-Id: <200410210854.i9L8sBbY028722@repoman.freebsd.org> From: Ruslan Ermilov Date: Thu, 21 Oct 2004 08:54:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/release Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2004 08:54:11 -0000 ru 2004-10-21 08:54:10 UTC FreeBSD src repository Modified files: release Makefile Log: Pass WORLD_FLAGS down to the distributeworld target, so it's possible to build releases with customizations such as with NOPROFILE. Problem found and fix tested by Roman Neuhauser. Revision Changes Path 1.866 +2 -1 src/release/Makefile From owner-cvs-src@FreeBSD.ORG Thu Oct 21 09:01:03 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2513516A4CF; Thu, 21 Oct 2004 09:01:03 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1882D43D49; Thu, 21 Oct 2004 09:01:03 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9L9125X029069; Thu, 21 Oct 2004 09:01:02 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9L912TA029068; Thu, 21 Oct 2004 09:01:02 GMT (envelope-from rwatson) Message-Id: <200410210901.i9L912TA029068@repoman.freebsd.org> From: Robert Watson Date: Thu, 21 Oct 2004 09:01:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5_3 Subject: cvs commit: src/sys/nfsserver nfs_serv.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2004 09:01:03 -0000 rwatson 2004-10-21 09:01:02 UTC FreeBSD src repository Modified files: (Branch: RELENG_5_3) sys/nfsserver nfs_serv.c Log: Merge nfs_serv.c:1.149 (RELENG_5 1.147.2.2) from HEAD to RELENG_5_3: date: 2004/10/18 11:23:11; author: rwatson; state: Exp; lines: +61 -13 Correct several instances where calls to vfs_getvfs() resulting in failure in the NFS server would result in a leaked instance of the NFS server subsystem lock. Liberally sprinkle assertions in all target labels for error unwinding to assert the desired locking state. RELENG_5_3 candidate. MFC after: 3 days Reported by: Wilkinson, Alex Approved by: re (scottl) Revision Changes Path 1.147.2.1.2.1 +61 -13 src/sys/nfsserver/nfs_serv.c From owner-cvs-src@FreeBSD.ORG Thu Oct 21 09:30:48 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B44D116A4CE; Thu, 21 Oct 2004 09:30:48 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 90B4C43D2D; Thu, 21 Oct 2004 09:30:48 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9L9UmUf030343; Thu, 21 Oct 2004 09:30:48 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9L9Umio030342; Thu, 21 Oct 2004 09:30:48 GMT (envelope-from rwatson) Message-Id: <200410210930.i9L9Umio030342@repoman.freebsd.org> From: Robert Watson Date: Thu, 21 Oct 2004 09:30:48 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5_3 Subject: cvs commit: src/sys/kern kern_descrip.c uipc_socket.c uipc_usrreq.c src/sys/net raw_cb.c raw_usrreq.c src/sys/netatalk ddp_pcb.c src/sys/netatm atm_socket.cng_btsocket_l2cap.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2004 09:30:48 -0000 rwatson 2004-10-21 09:30:48 UTC FreeBSD src repository Modified files: (Branch: RELENG_5_3) sys/kern kern_descrip.c uipc_socket.c uipc_usrreq.c sys/net raw_cb.c raw_usrreq.c sys/netatalk ddp_pcb.c sys/netatm atm_socket.c sys/netgraph/bluetooth/socket ng_btsocket_hci_raw.c ng_btsocket_l2cap.c ng_btsocket_l2cap_raw.c ng_btsocket_rfcomm.c sys/netinet in_pcb.c tcp_subr.c sys/netinet6 in6_pcb.c sys/netipx ipx_pcb.c ipx_usrreq.c sys/netnatm natm.c sys/sys socketvar.h Log: Merge kern_descrip.c:1.246, uipc_socket.c:1.214, uipc_usrreq.c:1.141, raw_cb.c:1.30, raw_usrreq.c:1.35, ddp_pcb.c:1.45, atm_socket.c:1.21, ng_btsocket_hci_raw.c:1.16, ng_btsocket_l2cap.c:1.14, ng_btsocket_l2cap_raw.c:1.13, ng_btsocket_rfcomm.c:1.13, in_pcb.c:1.156, tcp_subr.c:1.205, in6_pcb.c:1.61, ipx_pcb.c:1.29, ipx_usrreq.c:1.41, natm.c:1.35, socketvar.h:1.135 from HEAD to RELENG_5_3: Push acquisition of the accept mutex out of sofree() into the caller (sorele()/sotryfree()): - This permits the caller to acquire the accept mutex before the socket mutex, avoiding sofree() having to drop the socket mutex and re-order, which could lead to races permitting more than one thread to enter sofree() after a socket is ready to be free'd. - This also covers clearing of the so_pcb weak socket reference from the protocol to the socket, preventing races in clearing and evaluation of the reference such that sofree() might be called more than once on the same socket. This appears to close a race I was able to easily trigger by repeatedly opening and resetting TCP connections to a host, in which the tcp_close() code called as a result of the RST raced with the close() of the accepted socket in the user process resulting in simultaneous attempts to de-allocate the same socket. The new locking increases the overhead for operations that may potentially free the socket, so we will want to revise the synchronization strategy here as we normalize the reference counting model for sockets. The use of the accept mutex in freeing of sockets that are not listen sockets is primarily motivated by the potential need to remove the socket from the incomplete connection queue on its parent (listen) socket, so cleaning up the reference model here may allow us to substantially weaken the synchronization requirements. RELENG_5_3 candidate. MFC after: 3 days Reviewed by: dwhite Discussed with: gnn, dwhite, green Reported by: Marc UBM Bocklet Reported by: Vlad Approved by: re (scottl) Revision Changes Path 1.243.2.2.2.1 +1 -0 src/sys/kern/kern_descrip.c 1.208.2.3.2.1 +4 -3 src/sys/kern/uipc_socket.c 1.138.2.2.2.1 +1 -0 src/sys/kern/uipc_usrreq.c 1.29.4.1 +1 -0 src/sys/net/raw_cb.c 1.34.4.1 +1 -0 src/sys/net/raw_usrreq.c 1.44.4.1 +1 -0 src/sys/netatalk/ddp_pcb.c 1.20.4.1 +1 -0 src/sys/netatm/atm_socket.c 1.15.4.1 +1 -0 src/sys/netgraph/bluetooth/socket/ng_btsocket_hci_raw.c 1.13.4.1 +2 -0 src/sys/netgraph/bluetooth/socket/ng_btsocket_l2cap.c 1.12.4.1 +1 -0 src/sys/netgraph/bluetooth/socket/ng_btsocket_l2cap_raw.c 1.12.4.1 +1 -0 src/sys/netgraph/bluetooth/socket/ng_btsocket_rfcomm.c 1.153.2.1.2.1 +1 -0 src/sys/netinet/in_pcb.c 1.201.2.1.2.1 +1 -0 src/sys/netinet/tcp_subr.c 1.59.2.1.2.1 +1 -0 src/sys/netinet6/in6_pcb.c 1.28.4.1 +1 -0 src/sys/netipx/ipx_pcb.c 1.40.4.1 +1 -0 src/sys/netipx/ipx_usrreq.c 1.34.4.1 +2 -0 src/sys/netnatm/natm.c 1.133.2.1.2.1 +10 -2 src/sys/sys/socketvar.h From owner-cvs-src@FreeBSD.ORG Thu Oct 21 11:19:03 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3018216A4CE; Thu, 21 Oct 2004 11:19:03 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 250FE43D1F; Thu, 21 Oct 2004 11:19:03 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9LBJ3Nm033493; Thu, 21 Oct 2004 11:19:03 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9LBJ2mC033492; Thu, 21 Oct 2004 11:19:03 GMT (envelope-from rwatson) Message-Id: <200410211119.i9LBJ2mC033492@repoman.freebsd.org> From: Robert Watson Date: Thu, 21 Oct 2004 11:19:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/security/mac_bsdextended mac_bsdextended.c mac_bsdextended.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2004 11:19:03 -0000 rwatson 2004-10-21 11:19:02 UTC FreeBSD src repository Modified files: sys/security/mac_bsdextended mac_bsdextended.c mac_bsdextended.h Log: Modify mac_bsdextended policy so that it defines its own vnode access right bits rather than piggy-backing on the V* rights defined in vnode.h. The mac_bsdextended bits are given the same values as the V* bits to make the new kernel module binary compatible with the old version of libugidfw that uses V* bits. This avoids leaking kernel API/ABI to user management tools, and in particular should remove the need for libugidfw to include vnode.h. Requested by: phk Revision Changes Path 1.22 +59 -33 src/sys/security/mac_bsdextended/mac_bsdextended.c 1.4 +15 -0 src/sys/security/mac_bsdextended/mac_bsdextended.h From owner-cvs-src@FreeBSD.ORG Thu Oct 21 11:21:13 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E38AF16A4CE; Thu, 21 Oct 2004 11:21:13 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C2A5443D46; Thu, 21 Oct 2004 11:21:13 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9LBLD4L033655; Thu, 21 Oct 2004 11:21:13 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9LBLDPO033654; Thu, 21 Oct 2004 11:21:13 GMT (envelope-from rwatson) Message-Id: <200410211121.i9LBLDPO033654@repoman.freebsd.org> From: Robert Watson Date: Thu, 21 Oct 2004 11:21:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libugidfw ugidfw.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2004 11:21:14 -0000 rwatson 2004-10-21 11:21:13 UTC FreeBSD src repository Modified files: lib/libugidfw ugidfw.c Log: Modify libugidfw(3) to use MBI_* permission flags from mac_bsdextended.h instead of using the V* permission flags from vnode.h. Remove include of vnode.h. Requested by: phk Revision Changes Path 1.7 +12 -13 src/lib/libugidfw/ugidfw.c From owner-cvs-src@FreeBSD.ORG Thu Oct 21 11:22:07 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 56B8A16A4CE; Thu, 21 Oct 2004 11:22:07 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3778B43D3F; Thu, 21 Oct 2004 11:22:07 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9LBM758033703; Thu, 21 Oct 2004 11:22:07 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9LBM72Z033702; Thu, 21 Oct 2004 11:22:07 GMT (envelope-from rwatson) Message-Id: <200410211122.i9LBM72Z033702@repoman.freebsd.org> From: Robert Watson Date: Thu, 21 Oct 2004 11:22:07 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin/ugidfw ugidfw.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2004 11:22:07 -0000 rwatson 2004-10-21 11:22:07 UTC FreeBSD src repository Modified files: usr.sbin/ugidfw ugidfw.c Log: Remove unnecessary include of vnode.h. Requested by: phk Revision Changes Path 1.3 +0 -1 src/usr.sbin/ugidfw/ugidfw.c From owner-cvs-src@FreeBSD.ORG Thu Oct 21 11:29:57 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 08ED616A4CF; Thu, 21 Oct 2004 11:29:57 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DB85F43D53; Thu, 21 Oct 2004 11:29:56 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9LBTuvh033927; Thu, 21 Oct 2004 11:29:56 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9LBTuwT033926; Thu, 21 Oct 2004 11:29:56 GMT (envelope-from rwatson) Message-Id: <200410211129.i9LBTuwT033926@repoman.freebsd.org> From: Robert Watson Date: Thu, 21 Oct 2004 11:29:56 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/security/mac_bsdextended mac_bsdextended.c mac_bsdextended.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2004 11:29:57 -0000 rwatson 2004-10-21 11:29:56 UTC FreeBSD src repository Modified files: sys/security/mac_bsdextended mac_bsdextended.c mac_bsdextended.h Log: Bump copyright dates for NETA on these files. Revision Changes Path 1.23 +1 -1 src/sys/security/mac_bsdextended/mac_bsdextended.c 1.5 +1 -1 src/sys/security/mac_bsdextended/mac_bsdextended.h From owner-cvs-src@FreeBSD.ORG Thu Oct 21 11:59:34 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 096CA16A4CE; Thu, 21 Oct 2004 11:59:34 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DCDBF43D2F; Thu, 21 Oct 2004 11:59:33 +0000 (GMT) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9LBxXaQ034849; Thu, 21 Oct 2004 11:59:33 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from cognet@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9LBxXJD034848; Thu, 21 Oct 2004 11:59:33 GMT (envelope-from cognet) Message-Id: <200410211159.i9LBxXJD034848@repoman.freebsd.org> From: Olivier Houchard Date: Thu, 21 Oct 2004 11:59:33 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/arm/arm busdma_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2004 11:59:34 -0000 cognet 2004-10-21 11:59:33 UTC FreeBSD src repository Modified files: sys/arm/arm busdma_machdep.c Log: We want to ignore BUS_DMASYNC_POSTWRITE, not BUS_DMASYNC_POSTREAD. Spotted out by: mux Pointy hat to: cognet Revision Changes Path 1.5 +1 -1 src/sys/arm/arm/busdma_machdep.c From owner-cvs-src@FreeBSD.ORG Thu Oct 21 12:09:45 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A15E316A4CE; Thu, 21 Oct 2004 12:09:45 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7DBDC43D1D; Thu, 21 Oct 2004 12:09:45 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9LC9jlF035177; Thu, 21 Oct 2004 12:09:45 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9LC9jwZ035176; Thu, 21 Oct 2004 12:09:45 GMT (envelope-from phk) Message-Id: <200410211209.i9LC9jwZ035176@repoman.freebsd.org> From: Poul-Henning Kamp Date: Thu, 21 Oct 2004 12:09:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.bin/fstat Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2004 12:09:45 -0000 phk 2004-10-21 12:09:45 UTC FreeBSD src repository Modified files: usr.bin/fstat Makefile Log: Add -D_KVM_VNODE to indicate that despite being a userland program, we want to know the vnode structures internals. Revision Changes Path 1.9 +2 -0 src/usr.bin/fstat/Makefile From owner-cvs-src@FreeBSD.ORG Thu Oct 21 12:24:39 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 40DC116A4CE; Thu, 21 Oct 2004 12:24:39 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 36EB743D3F; Thu, 21 Oct 2004 12:24:39 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9LCOdpE035625; Thu, 21 Oct 2004 12:24:39 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9LCOdqL035624; Thu, 21 Oct 2004 12:24:39 GMT (envelope-from phk) Message-Id: <200410211224.i9LCOdqL035624@repoman.freebsd.org> From: Poul-Henning Kamp Date: Thu, 21 Oct 2004 12:24:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/sys bufobj.h vnode.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2004 12:24:39 -0000 phk 2004-10-21 12:24:38 UTC FreeBSD src repository Modified files: sys/sys vnode.h Added files: sys/sys bufobj.h Log: Add new function ttyinitmode() which sets our systemwide default modes on a tty structure. Both the ".init" and the current settings are initialized allowing the function to be used both at attach and open time. The function takes an argument to decide if echoing should be enabled by default. Echoing should not be enabled for regular physical serial ports unless they are consoles, in which case they should be configured by ttyconsolemode() instead. Use the new function throughout. Revision Changes Path 1.1 +74 -0 src/sys/sys/bufobj.h (new) 1.245 +15 -7 src/sys/sys/vnode.h From owner-cvs-src@FreeBSD.ORG Thu Oct 21 12:51:36 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9CA5116A4CE; Thu, 21 Oct 2004 12:51:36 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7E5C743D39; Thu, 21 Oct 2004 12:51:36 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9LCpaC2042940; Thu, 21 Oct 2004 12:51:36 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9LCpapf042939; Thu, 21 Oct 2004 12:51:36 GMT (envelope-from phk) Message-Id: <200410211251.i9LCpapf042939@repoman.freebsd.org> From: Poul-Henning Kamp Date: Thu, 21 Oct 2004 12:51:36 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/sys bufobj.h vnode.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2004 12:51:36 -0000 phk 2004-10-21 12:51:36 UTC FreeBSD src repository Modified files: sys/sys bufobj.h vnode.h Log: Forced commit to get the right commit message: Add new include file which will contain the gory details on the new buffer-cache object. (see comments in file about the direction this is moving). Include it from for now to avoid munging a lot of files which can later be munged back. Embed a bufobj in vnode. Move the buf splay trees from the vnode to the bufobj. Alias the fields to avoid sweeping code yet. Hide vnode and bufobj behind #if defined(_KERNEL) || defined(_KVM_VNODE) to discourage userland voyeurism. Revision Changes Path 1.2 +0 -0 src/sys/sys/bufobj.h 1.246 +0 -0 src/sys/sys/vnode.h From owner-cvs-src@FreeBSD.ORG Thu Oct 21 13:31:21 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B43A916A4D0 for ; Thu, 21 Oct 2004 13:31:21 +0000 (GMT) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id B913643D58 for ; Thu, 21 Oct 2004 13:31:20 +0000 (GMT) (envelope-from andre@freebsd.org) Received: (qmail 76926 invoked from network); 21 Oct 2004 13:29:58 -0000 Received: from unknown (HELO freebsd.org) ([62.48.0.53]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 21 Oct 2004 13:29:58 -0000 Message-ID: <4177BA2F.66B1CD71@freebsd.org> Date: Thu, 21 Oct 2004 15:31:27 +0200 From: Andre Oppermann X-Mailer: Mozilla 4.8 [en] (Windows NT 5.0; U) X-Accept-Language: en MIME-Version: 1.0 To: Ruslan Ermilov References: <200410192114.i9JLEvjQ001574@repoman.freebsd.org> <41758BF6.5020909@freebsd.org> <41758DF2.D3C1BD26@freebsd.org> <20041021071148.GA46126@ip.net.ua> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Scott Long cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/modules/ipdivert Makefile src/sys/netinetin_proto.c ip_divert.c ip_divert.h ip_fw2.c ip_fw_pfil.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2004 13:31:21 -0000 Ruslan Ermilov wrote: > > On Tue, Oct 19, 2004 at 11:58:10PM +0200, Andre Oppermann wrote: > > Scott Long wrote: > [...] > > > This is interesting. Have you measured performance/latency with this > > > new scheme? Is it still possible to compile IPDIVERT into the kernel > > > and avoid the indirect calls? > > > > IPDIVERT can hardly be called a performance/latency critical path. The > > entire copyout of the packet to userland for nat'ing and copyin again > > make the function pointer indirection such a small factor that it doesn't > > make any difference whatsoever. > > > Err. divert(4) sockets can also be accessed through the ng_ksocket(4) > interface, in which case no userland-kernel copying takes place. So > the performance does matter. Yes, you are correct. Performance does not suffer from calling divert_input() through a function pointer. It takes four more instructions than calling it directly. Half of the network stack is going through function pointers and all of netgraph is going through function pointers. In all cases for each packet. Going through function pointers does not have any performance impact whatsoever I was able to measure. Granted, I haven't profiled it at the instruction level. I hope we can settle this matter now. My original answer to Scott was badly phrased. -- Andre From owner-cvs-src@FreeBSD.ORG Thu Oct 21 13:48:50 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D92B416A4CE; Thu, 21 Oct 2004 13:48:50 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BB0D843D45; Thu, 21 Oct 2004 13:48:50 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9LDmofb044746; Thu, 21 Oct 2004 13:48:50 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9LDmomG044745; Thu, 21 Oct 2004 13:48:50 GMT (envelope-from phk) Message-Id: <200410211348.i9LDmomG044745@repoman.freebsd.org> From: Poul-Henning Kamp Date: Thu, 21 Oct 2004 13:48:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2004 13:48:51 -0000 phk 2004-10-21 13:48:50 UTC FreeBSD src repository Modified files: sys/kern vfs_subr.c Log: Simplify buf_vlist_remove(). Now that we have encapsulated the splaytree related information into a structure we can eliminate the half of this function. Revision Changes Path 1.531 +16 -34 src/sys/kern/vfs_subr.c From owner-cvs-src@FreeBSD.ORG Thu Oct 21 13:56:24 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8D17D16A4CE; Thu, 21 Oct 2004 13:56:24 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6C95643D53; Thu, 21 Oct 2004 13:56:24 +0000 (GMT) (envelope-from blackend@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9LDuOkm045058; Thu, 21 Oct 2004 13:56:24 GMT (envelope-from blackend@repoman.freebsd.org) Received: (from blackend@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9LDuO93045057; Thu, 21 Oct 2004 13:56:24 GMT (envelope-from blackend) Message-Id: <200410211356.i9LDuO93045057@repoman.freebsd.org> From: Marc Fonvieille Date: Thu, 21 Oct 2004 13:56:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/tools/tools/nanobsd make.conf X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2004 13:56:24 -0000 blackend 2004-10-21 13:56:24 UTC FreeBSD src repository (doc committer) Modified files: tools/tools/nanobsd make.conf Log: Remove NOLIBPTHREAD=yes since BIND related binaries (dig etc.) require LIBPTHREAD. Approved by: phk Revision Changes Path 1.4 +0 -1 src/tools/tools/nanobsd/make.conf From owner-cvs-src@FreeBSD.ORG Thu Oct 21 14:13:55 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0E90116A4CE; Thu, 21 Oct 2004 14:13:55 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E345343D1F; Thu, 21 Oct 2004 14:13:54 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9LEDsxo045616; Thu, 21 Oct 2004 14:13:54 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9LEDssu045615; Thu, 21 Oct 2004 14:13:54 GMT (envelope-from phk) Message-Id: <200410211413.i9LEDssu045615@repoman.freebsd.org> From: Poul-Henning Kamp Date: Thu, 21 Oct 2004 14:13:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2004 14:13:55 -0000 phk 2004-10-21 14:13:54 UTC FreeBSD src repository Modified files: sys/kern vfs_subr.c Log: Polish vtruncbuf() to improve readability and style a bit. Revision Changes Path 1.532 +43 -50 src/sys/kern/vfs_subr.c From owner-cvs-src@FreeBSD.ORG Thu Oct 21 14:42:32 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 17FC716A4CF; Thu, 21 Oct 2004 14:42:32 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E911143D2F; Thu, 21 Oct 2004 14:42:31 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9LEgVOH046531; Thu, 21 Oct 2004 14:42:31 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9LEgV3B046530; Thu, 21 Oct 2004 14:42:31 GMT (envelope-from phk) Message-Id: <200410211442.i9LEgV3B046530@repoman.freebsd.org> From: Poul-Henning Kamp Date: Thu, 21 Oct 2004 14:42:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern vfs_subr.c src/sys/sys bufobj.h vnode.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2004 14:42:32 -0000 phk 2004-10-21 14:42:31 UTC FreeBSD src repository Modified files: sys/kern vfs_subr.c sys/sys bufobj.h vnode.h Log: Add BO_* macros parallel to VI_* macros for manipulating the bo_mtx. Initialize the bo_mtx when we allocate a vnode i getnewvnode() For now we point to the vnodes interlock mutex, that retains the exact same locking sematics. Move v_numoutput from vnode to bufobj. Add renaming macro to postpone code sweep. Revision Changes Path 1.533 +11 -7 src/sys/kern/vfs_subr.c 1.3 +17 -0 src/sys/sys/bufobj.h 1.247 +1 -1 src/sys/sys/vnode.h From owner-cvs-src@FreeBSD.ORG Thu Oct 21 15:53:54 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9F19B16A4CE; Thu, 21 Oct 2004 15:53:54 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8F15943D48; Thu, 21 Oct 2004 15:53:54 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9LFrs8q048839; Thu, 21 Oct 2004 15:53:54 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9LFrsXg048838; Thu, 21 Oct 2004 15:53:54 GMT (envelope-from phk) Message-Id: <200410211553.i9LFrsXg048838@repoman.freebsd.org> From: Poul-Henning Kamp Date: Thu, 21 Oct 2004 15:53:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern vfs_bio.c vfs_cluster.c vfs_default.c vfs_subr.c src/sys/nfs4client nfs4_vnops.c src/sys/nfsclient nfs_subs.c nfs_vnops.c src/sys/sys buf.h bufobj.h vnode.h... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2004 15:53:54 -0000 phk 2004-10-21 15:53:54 UTC FreeBSD src repository Modified files: sys/kern vfs_bio.c vfs_cluster.c vfs_default.c vfs_subr.c sys/nfs4client nfs4_vnops.c sys/nfsclient nfs_subs.c nfs_vnops.c sys/sys buf.h bufobj.h vnode.h sys/ufs/ffs ffs_rawread.c ffs_softdep.c ffs_vnops.c sys/vm swap_pager.c Log: Move the VI_BWAIT flag into no bo_flag element of bufobj and call it BO_WWAIT Add bufobj_wref(), bufobj_wdrop() and bufobj_wwait() to handle the write count on a bufobj. Bufobj_wdrop() replaces vwakeup(). Use these functions all relevant places except in ffs_softdep.c where the use if interlocked_sleep() makes this impossible. Rename b_vnbufs to b_bobufs now that we touch all the relevant files anyway. Revision Changes Path 1.452 +66 -8 src/sys/kern/vfs_bio.c 1.152 +1 -3 src/sys/kern/vfs_cluster.c 1.100 +7 -9 src/sys/kern/vfs_default.c 1.534 +22 -55 src/sys/kern/vfs_subr.c 1.10 +9 -15 src/sys/nfs4client/nfs4_vnops.c 1.132 +1 -1 src/sys/nfsclient/nfs_subs.c 1.224 +9 -15 src/sys/nfsclient/nfs_vnops.c 1.170 +1 -2 src/sys/sys/buf.h 1.4 +7 -0 src/sys/sys/bufobj.h 1.248 +0 -1 src/sys/sys/vnode.h 1.14 +2 -5 src/sys/ufs/ffs/ffs_rawread.c 1.157 +7 -6 src/sys/ufs/ffs/ffs_softdep.c 1.138 +3 -7 src/sys/ufs/ffs/ffs_vnops.c 1.258 +3 -12 src/sys/vm/swap_pager.c From owner-cvs-src@FreeBSD.ORG Thu Oct 21 17:02:38 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 864AB16A4CE; Thu, 21 Oct 2004 17:02:38 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 666E843D48; Thu, 21 Oct 2004 17:02:38 +0000 (GMT) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9LH2cRh057420; Thu, 21 Oct 2004 17:02:38 GMT (envelope-from cperciva@repoman.freebsd.org) Received: (from cperciva@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9LH2cQq057419; Thu, 21 Oct 2004 17:02:38 GMT (envelope-from cperciva) Message-Id: <200410211702.i9LH2cQq057419@repoman.freebsd.org> From: Colin Percival Date: Thu, 21 Oct 2004 17:02:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Subject: cvs commit: src/usr.bin/xargs strnsubst.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2004 17:02:38 -0000 cperciva 2004-10-21 17:02:38 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) usr.bin/xargs strnsubst.c Log: Fix a buffer overflow. This is the same bug as is corrected in rev. 1.7, but the correction is different: Rather than making sure the string we're constructing doesn't grow too large, we realloc() to make sure the buffer is large enough. This violates the IEEE Std 1003.1-2004 standard, but retains backwards compatability. Approved by: re (scottl) Revision Changes Path 1.6.8.1 +12 -0 src/usr.bin/xargs/strnsubst.c From owner-cvs-src@FreeBSD.ORG Thu Oct 21 17:05:09 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4C48716A4CF; Thu, 21 Oct 2004 17:05:09 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 02B0843D45; Thu, 21 Oct 2004 17:05:09 +0000 (GMT) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9LH58E6057526; Thu, 21 Oct 2004 17:05:08 GMT (envelope-from cperciva@repoman.freebsd.org) Received: (from cperciva@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9LH58WN057525; Thu, 21 Oct 2004 17:05:08 GMT (envelope-from cperciva) Message-Id: <200410211705.i9LH58WN057525@repoman.freebsd.org> From: Colin Percival Date: Thu, 21 Oct 2004 17:05:08 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5_3 Subject: cvs commit: src/usr.bin/xargs strnsubst.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2004 17:05:09 -0000 cperciva 2004-10-21 17:05:08 UTC FreeBSD src repository Modified files: (Branch: RELENG_5_3) usr.bin/xargs strnsubst.c Log: MFS revision 1.6.8.1: Fix a buffer overflow. Approved by: re (scottl) Revision Changes Path 1.6.10.1 +12 -0 src/usr.bin/xargs/strnsubst.c From owner-cvs-src@FreeBSD.ORG Thu Oct 21 17:49:12 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 81DAA16A4CE; Thu, 21 Oct 2004 17:49:12 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 632AF43D53; Thu, 21 Oct 2004 17:49:12 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9LHnC4l058968; Thu, 21 Oct 2004 17:49:12 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9LHnCfQ058967; Thu, 21 Oct 2004 17:49:12 GMT (envelope-from phk) Message-Id: <200410211749.i9LHnCfQ058967@repoman.freebsd.org> From: Poul-Henning Kamp Date: Thu, 21 Oct 2004 17:49:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Subject: cvs commit: src/sys/geom geom_io.c src/sys/sys bio.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2004 17:49:12 -0000 phk 2004-10-21 17:49:12 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) sys/geom geom_io.c sys/sys bio.h Log: MFC: Close a possible race which could prevent geom classes from being unloaded on SMP machines due to traffic counters getting out of whack. Approved by: re::scottl Revision Changes Path 1.57.2.3 +63 -27 src/sys/geom/geom_io.c 1.139.2.2 +1 -0 src/sys/sys/bio.h From owner-cvs-src@FreeBSD.ORG Thu Oct 21 17:49:46 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 52F1A16A4D0; Thu, 21 Oct 2004 17:49:46 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 32D3743D2F; Thu, 21 Oct 2004 17:49:46 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9LHnk9m059040; Thu, 21 Oct 2004 17:49:46 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9LHnkEF059039; Thu, 21 Oct 2004 17:49:46 GMT (envelope-from phk) Message-Id: <200410211749.i9LHnkEF059039@repoman.freebsd.org> From: Poul-Henning Kamp Date: Thu, 21 Oct 2004 17:49:46 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5_3 Subject: cvs commit: src/sys/geom geom_io.c src/sys/sys bio.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2004 17:49:46 -0000 phk 2004-10-21 17:49:46 UTC FreeBSD src repository Modified files: (Branch: RELENG_5_3) sys/geom geom_io.c sys/sys bio.h Log: MFC: Close a possible race which could prevent geom classes from being unloaded on SMP machines due to traffic counters getting out of whack. Approved by: re::scottl Revision Changes Path 1.57.2.2.2.1 +63 -27 src/sys/geom/geom_io.c 1.139.2.1.2.1 +1 -0 src/sys/sys/bio.h From owner-cvs-src@FreeBSD.ORG Thu Oct 21 18:34:40 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D6A8316A4D0; Thu, 21 Oct 2004 18:34:40 +0000 (GMT) Received: from smtp3.server.rpi.edu (smtp3.server.rpi.edu [128.113.2.3]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8588443D2D; Thu, 21 Oct 2004 18:34:40 +0000 (GMT) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by smtp3.server.rpi.edu (8.13.0/8.13.0) with ESMTP id i9LIYdGI001310; Thu, 21 Oct 2004 14:34:39 -0400 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <200410211702.i9LH2cQq057419@repoman.freebsd.org> References: <200410211702.i9LH2cQq057419@repoman.freebsd.org> Date: Thu, 21 Oct 2004 14:34:37 -0400 To: Colin Percival , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org From: Garance A Drosihn Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-CanItPRO-Stream: default X-RPI-SA-Score: undef - spam-scanning disabled X-Scanned-By: CanIt (www . canit . ca) Subject: Re: cvs commit: src/usr.bin/xargs strnsubst.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2004 18:34:41 -0000 At 5:02 PM +0000 10/21/04, Colin Percival wrote: >cperciva 2004-10-21 17:02:38 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_5) > usr.bin/xargs strnsubst.c > Log: > Fix a buffer overflow. This is the same bug as is corrected in rev. > 1.7, but the correction is different: Rather than making sure the > string we're constructing doesn't grow too large, we realloc() to > make sure the buffer is large enough. > > This violates the IEEE Std 1003.1-2004 standard, but retains > backwards compatability. Thanks. I think this is a much better solution! -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu From owner-cvs-src@FreeBSD.ORG Thu Oct 21 18:35:25 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5791E16A4CE; Thu, 21 Oct 2004 18:35:25 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 310EF43D1D; Thu, 21 Oct 2004 18:35:25 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9LIZP3k060709; Thu, 21 Oct 2004 18:35:25 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9LIZP2s060708; Thu, 21 Oct 2004 18:35:25 GMT (envelope-from rwatson) Message-Id: <200410211835.i9LIZP2s060708@repoman.freebsd.org> From: Robert Watson Date: Thu, 21 Oct 2004 18:35:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/sys ktr.h src/sys/geom geom_io.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2004 18:35:25 -0000 rwatson 2004-10-21 18:35:25 UTC FreeBSD src repository Modified files: sys/sys ktr.h sys/geom geom_io.c Log: Add KTR_GEOM, which allows tracing of basic GEOM I/O events occuring in the g_up and g_down threads. Each time a bio is propelled up and down the stack, an event is generating showing the provider, offset, and length, as well as thread wakeup and work status information. Revision Changes Path 1.64 +26 -0 src/sys/geom/geom_io.c 1.23 +2 -1 src/sys/sys/ktr.h From owner-cvs-src@FreeBSD.ORG Thu Oct 21 19:14:32 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C332016A4E0; Thu, 21 Oct 2004 19:14:32 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A3CD043D45; Thu, 21 Oct 2004 19:14:32 +0000 (GMT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9LJEWs4062196; Thu, 21 Oct 2004 19:14:32 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9LJEWcv062195; Thu, 21 Oct 2004 19:14:32 GMT (envelope-from scottl) Message-Id: <200410211914.i9LJEWcv062195@repoman.freebsd.org> From: Scott Long Date: Thu, 21 Oct 2004 19:14:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/aac aac_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2004 19:14:32 -0000 scottl 2004-10-21 19:14:32 UTC FreeBSD src repository Modified files: sys/dev/aac aac_pci.c Log: Add support for the 21610SA 16-channel SATA card. Thanks to Adaptec for providing hardware for testing. Revision Changes Path 1.49 +2 -0 src/sys/dev/aac/aac_pci.c From owner-cvs-src@FreeBSD.ORG Thu Oct 21 19:32:15 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6732C16A4CE; Thu, 21 Oct 2004 19:32:15 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4892D43D45; Thu, 21 Oct 2004 19:32:15 +0000 (GMT) (envelope-from markm@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9LJWFnV062946; Thu, 21 Oct 2004 19:32:15 GMT (envelope-from markm@repoman.freebsd.org) Received: (from markm@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9LJWFHh062945; Thu, 21 Oct 2004 19:32:15 GMT (envelope-from markm) Message-Id: <200410211932.i9LJWFHh062945@repoman.freebsd.org> From: Mark Murray Date: Thu, 21 Oct 2004 19:32:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5_3 Subject: cvs commit: src/sys/modules/mem Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2004 19:32:15 -0000 markm 2004-10-21 19:32:15 UTC FreeBSD src repository Modified files: (Branch: RELENG_5_3) sys/modules/mem Makefile Log: MFR_5. Make the loadable module have the same content as the compiled-in mem device. This means the Module has MTRR for i386 and amd64. Approved by: re(scottl) Revision Changes Path 1.2.4.1 +6 -0 src/sys/modules/mem/Makefile From owner-cvs-src@FreeBSD.ORG Thu Oct 21 20:02:02 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 64B6116A4CE; Thu, 21 Oct 2004 20:02:02 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5B39743D4C; Thu, 21 Oct 2004 20:02:02 +0000 (GMT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9LK22GO064025; Thu, 21 Oct 2004 20:02:02 GMT (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9LK22mI064024; Thu, 21 Oct 2004 20:02:02 GMT (envelope-from peter) Message-Id: <200410212002.i9LK22mI064024@repoman.freebsd.org> From: Peter Wemm Date: Thu, 21 Oct 2004 20:02:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/contrib/libreadline complete.c rlconf.h shell.c terminal.c src/contrib/libreadline/doc readline.3 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2004 20:02:02 -0000 peter 2004-10-21 20:02:02 UTC FreeBSD src repository Modified files: contrib/libreadline complete.c rlconf.h shell.c terminal.c contrib/libreadline/doc readline.3 Log: Force these files back off the vendor branch. They should NEVER have been put back on there in the first place. :-( Note that complete.c will need a readline 5.0 merge. Revision Changes Path 1.10 +238 -51 src/contrib/libreadline/complete.c 1.9 +23 -7 src/contrib/libreadline/doc/readline.3 1.6 +1 -0 src/contrib/libreadline/rlconf.h 1.8 +5 -0 src/contrib/libreadline/shell.c 1.6 +8 -11 src/contrib/libreadline/terminal.c From owner-cvs-src@FreeBSD.ORG Thu Oct 21 20:10:15 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5A54516A4CE; Thu, 21 Oct 2004 20:10:15 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3ABB943D45; Thu, 21 Oct 2004 20:10:15 +0000 (GMT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9LKAF4g096606; Thu, 21 Oct 2004 20:10:15 GMT (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9LKAECe096605; Thu, 21 Oct 2004 20:10:14 GMT (envelope-from peter) Message-Id: <200410212010.i9LKAECe096605@repoman.freebsd.org> From: Peter Wemm Date: Thu, 21 Oct 2004 20:10:14 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/contrib/libreadline display.c util.c vi_mode.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2004 20:10:15 -0000 peter 2004-10-21 20:10:14 UTC FreeBSD src repository Modified files: contrib/libreadline display.c util.c vi_mode.c Log: Fix some more files that got butchered to appear to be back on the vendor branch again. (These will need a readline import merge too) Revision Changes Path 1.7 +185 -71 src/contrib/libreadline/display.c 1.9 +2 -4 src/contrib/libreadline/util.c 1.3 +62 -35 src/contrib/libreadline/vi_mode.c From owner-cvs-src@FreeBSD.ORG Thu Oct 21 22:02:23 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5C57316A4CE; Thu, 21 Oct 2004 22:02:23 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6672743D5E; Thu, 21 Oct 2004 22:02:22 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i9LM2KhJ008379; Fri, 22 Oct 2004 01:02:20 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 18809-15; Fri, 22 Oct 2004 01:02:19 +0300 (EEST) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i9LM2CXN008374; Fri, 22 Oct 2004 01:02:15 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.1/8.13.1) id i9LM1pBZ044511; Fri, 22 Oct 2004 01:01:51 +0300 (EEST) (envelope-from ru) Date: Fri, 22 Oct 2004 01:01:50 +0300 From: Ruslan Ermilov To: Peter Wemm Message-ID: <20041021220150.GB67066@ip.net.ua> References: <200410212002.i9LK22mI064024@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="yNb1oOkm5a9FJOVX" Content-Disposition: inline In-Reply-To: <200410212002.i9LK22mI064024@repoman.freebsd.org> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new at ip.net.ua cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/contrib/libreadline complete.c rlconf.h shell.c terminal.c src/contrib/libreadline/doc readline.3 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2004 22:02:23 -0000 --yNb1oOkm5a9FJOVX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Peter, On Thu, Oct 21, 2004 at 08:02:02PM +0000, Peter Wemm wrote: > peter 2004-10-21 20:02:02 UTC >=20 > FreeBSD src repository >=20 > Modified files: > contrib/libreadline complete.c rlconf.h shell.c terminal.c=20 > contrib/libreadline/doc readline.3=20 > Log: > Force these files back off the vendor branch. They should NEVER have b= een > put back on there in the first place. :-( > =20 > Note that complete.c will need a readline 5.0 merge. > =20 > Revision Changes Path > 1.10 +238 -51 src/contrib/libreadline/complete.c > 1.9 +23 -7 src/contrib/libreadline/doc/readline.3 > 1.6 +1 -0 src/contrib/libreadline/rlconf.h > 1.8 +5 -0 src/contrib/libreadline/shell.c > 1.6 +8 -11 src/contrib/libreadline/terminal.c >=20 So why it was a problem putting these files back on their vendor branch? Do you have an insight why CVSup didn't reset the branch for some people? Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --yNb1oOkm5a9FJOVX Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBeDHOqRfpzJluFF4RArJDAJ9Fho5/383k2HWkEmCo+p4OTZETVgCcDLjQ 9vqhv/UgpDs8WkEn1NZCnKU= =K/Ka -----END PGP SIGNATURE----- --yNb1oOkm5a9FJOVX-- From owner-cvs-src@FreeBSD.ORG Thu Oct 21 22:29:19 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 571C616A4CE; Thu, 21 Oct 2004 22:29:19 +0000 (GMT) Received: from zaphod.nitro.dk (port324.ds1-khk.adsl.cybercity.dk [212.242.113.79]) by mx1.FreeBSD.org (Postfix) with ESMTP id BDC1B43D45; Thu, 21 Oct 2004 22:29:18 +0000 (GMT) (envelope-from simon@zaphod.nitro.dk) Received: by zaphod.nitro.dk (Postfix, from userid 3000) id 50D8811A79; Fri, 22 Oct 2004 00:29:17 +0200 (CEST) Date: Fri, 22 Oct 2004 00:29:17 +0200 From: "Simon L. Nielsen" To: Scott Long Message-ID: <20041021222916.GK769@zaphod.nitro.dk> References: <200410211914.i9LJEWcv062195@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="++alDQ2ROsODg1x+" Content-Disposition: inline In-Reply-To: <200410211914.i9LJEWcv062195@repoman.freebsd.org> User-Agent: Mutt/1.5.6i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/aac aac_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2004 22:29:19 -0000 --++alDQ2ROsODg1x+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2004.10.21 19:14:32 +0000, Scott Long wrote: > scottl 2004-10-21 19:14:32 UTC >=20 > FreeBSD src repository >=20 > Modified files: > sys/dev/aac aac_pci.c=20 > Log: > Add support for the 21610SA 16-channel SATA card. Thanks to Adaptec for > providing hardware for testing. Could you please add this to the manual page? --=20 Simon L. Nielsen FreeBSD Documentation Team --++alDQ2ROsODg1x+ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBeDg8h9pcDSc1mlERAsGtAKCu6TZlGP2eOAnB+2Xv+BFcn2zKZACbB0Lq rZBkN1NvKGLspaTDriZru88= =nCd0 -----END PGP SIGNATURE----- --++alDQ2ROsODg1x+-- From owner-cvs-src@FreeBSD.ORG Thu Oct 21 23:45:57 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D6D2416A4CE; Thu, 21 Oct 2004 23:45:57 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CB34F43D2F; Thu, 21 Oct 2004 23:45:57 +0000 (GMT) (envelope-from ache@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9LNjvAP048616; Thu, 21 Oct 2004 23:45:57 GMT (envelope-from ache@repoman.freebsd.org) Received: (from ache@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9LNjvEh048615; Thu, 21 Oct 2004 23:45:57 GMT (envelope-from ache) Message-Id: <200410212345.i9LNjvEh048615@repoman.freebsd.org> From: "Andrey A. Chernov" Date: Thu, 21 Oct 2004 23:45:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/contrib/libreadline complete.c display.c rlconf.h shell.c terminal.c util.c vi_mode.c src/contrib/libreadline/doc readline.3 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2004 23:45:58 -0000 ache 2004-10-21 23:45:57 UTC FreeBSD src repository Modified files: contrib/libreadline complete.c display.c rlconf.h shell.c terminal.c util.c vi_mode.c contrib/libreadline/doc readline.3 Log: Merge files peter takes off the vendor branch Revision Changes Path 1.11 +0 -0 src/contrib/libreadline/complete.c 1.8 +0 -0 src/contrib/libreadline/display.c 1.10 +0 -0 src/contrib/libreadline/doc/readline.3 1.7 +0 -0 src/contrib/libreadline/rlconf.h 1.9 +0 -0 src/contrib/libreadline/shell.c 1.7 +0 -0 src/contrib/libreadline/terminal.c 1.10 +0 -0 src/contrib/libreadline/util.c 1.4 +0 -0 src/contrib/libreadline/vi_mode.c From owner-cvs-src@FreeBSD.ORG Fri Oct 22 00:09:30 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4CC6716A4CE; Fri, 22 Oct 2004 00:09:30 +0000 (GMT) Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6CD9F43D55; Fri, 22 Oct 2004 00:09:29 +0000 (GMT) (envelope-from ache@pobrecita.freebsd.ru) Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.13.1/8.13.1) with ESMTP id i9M09SEq082990; Fri, 22 Oct 2004 04:09:28 +0400 (MSD) (envelope-from ache@pobrecita.freebsd.ru) Received: (from ache@localhost) by pobrecita.freebsd.ru (8.13.1/8.13.1/Submit) id i9M09S4x082989; Fri, 22 Oct 2004 04:09:28 +0400 (MSD) (envelope-from ache) Date: Fri, 22 Oct 2004 04:09:27 +0400 From: Andrey Chernov To: src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG Message-ID: <20041022000927.GA82964@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG, peter@freebsd.org References: <200410212345.i9LNjvEh048615@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200410212345.i9LNjvEh048615@repoman.freebsd.org> User-Agent: Mutt/1.5.6i X-AntiVirus: checked by AntiVir Milter (version: 1.1; AVE: 6.28.0.7; VDF: 6.28.0.30; host: pobrecita.freebsd.ru) cc: peter@FreeBSD.ORG Subject: Re: cvs commit: src/contrib/libreadline complete.c display.c rlconf.h shell.c terminal.c util.c vi_mode.c src/contrib/libreadline/doc readline.3 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 00:09:30 -0000 The strange things those +0 -0, which shows there is no difference... No difference with what? I expect the same problem happens on the next import... On Thu, Oct 21, 2004 at 11:45:57PM +0000, Andrey A. Chernov wrote: > ache 2004-10-21 23:45:57 UTC > > FreeBSD src repository > > Modified files: > contrib/libreadline complete.c display.c rlconf.h shell.c > terminal.c util.c vi_mode.c > contrib/libreadline/doc readline.3 > Log: > Merge files peter takes off the vendor branch > > Revision Changes Path > 1.11 +0 -0 src/contrib/libreadline/complete.c > 1.8 +0 -0 src/contrib/libreadline/display.c > 1.10 +0 -0 src/contrib/libreadline/doc/readline.3 > 1.7 +0 -0 src/contrib/libreadline/rlconf.h > 1.9 +0 -0 src/contrib/libreadline/shell.c > 1.7 +0 -0 src/contrib/libreadline/terminal.c > 1.10 +0 -0 src/contrib/libreadline/util.c > 1.4 +0 -0 src/contrib/libreadline/vi_mode.c -- Andrey Chernov | http://ache.pp.ru/ From owner-cvs-src@FreeBSD.ORG Fri Oct 22 04:17:29 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6EE1B16A4CE; Fri, 22 Oct 2004 04:17:29 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4E98B43D53; Fri, 22 Oct 2004 04:17:29 +0000 (GMT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9M4HTjk072529; Fri, 22 Oct 2004 04:17:29 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9M4HT56072528; Fri, 22 Oct 2004 04:17:29 GMT (envelope-from scottl) Message-Id: <200410220417.i9M4HT56072528@repoman.freebsd.org> From: Scott Long Date: Fri, 22 Oct 2004 04:17:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/man/man4 aac.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 04:17:29 -0000 scottl 2004-10-22 04:17:28 UTC FreeBSD src repository Modified files: share/man/man4 aac.4 Log: Document the 21610SA card. Revision Changes Path 1.26 +2 -0 src/share/man/man4/aac.4 From owner-cvs-src@FreeBSD.ORG Fri Oct 22 04:49:09 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 78A5416A4CE; Fri, 22 Oct 2004 04:49:09 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 55BB243D5A; Fri, 22 Oct 2004 04:49:09 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9M4n9qc079718; Fri, 22 Oct 2004 04:49:09 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9M4n9TC079717; Fri, 22 Oct 2004 04:49:09 GMT (envelope-from marcel) Message-Id: <200410220449.i9M4n9TC079717@repoman.freebsd.org> From: Marcel Moolenaar Date: Fri, 22 Oct 2004 04:49:09 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/release/scripts print-cdrom-packages.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 04:49:09 -0000 marcel 2004-10-22 04:49:09 UTC FreeBSD src repository Modified files: release/scripts print-cdrom-packages.sh Log: Seperate ia64 from the pack. The disc1 is overflowing to such extend that most packages can not be included. It's much easier to list those that we do want on disc1 for ia64. We only need to list 11 of them. Apply proper indentation for better readability. Revision Changes Path 1.68 +94 -83 src/release/scripts/print-cdrom-packages.sh From owner-cvs-src@FreeBSD.ORG Fri Oct 22 05:21:20 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8EC2E16A4CE; Fri, 22 Oct 2004 05:21:20 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6D60643D31; Fri, 22 Oct 2004 05:21:20 +0000 (GMT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9M5LK1B080679; Fri, 22 Oct 2004 05:21:20 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9M5LKin080678; Fri, 22 Oct 2004 05:21:20 GMT (envelope-from scottl) Message-Id: <200410220521.i9M5LKin080678@repoman.freebsd.org> From: Scott Long Date: Fri, 22 Oct 2004 05:21:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/man/man9 bus_dma.9 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 05:21:20 -0000 scottl 2004-10-22 05:21:20 UTC FreeBSD src repository Modified files: share/man/man9 bus_dma.9 Log: Correct and clarify some very incorrect text. Revision Changes Path 1.19 +6 -6 src/share/man/man9/bus_dma.9 From owner-cvs-src@FreeBSD.ORG Fri Oct 22 07:31:13 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 297D616A4CE; Fri, 22 Oct 2004 07:31:13 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 086AD43D48; Fri, 22 Oct 2004 07:31:13 +0000 (GMT) (envelope-from suz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9M7VCoK085440; Fri, 22 Oct 2004 07:31:12 GMT (envelope-from suz@repoman.freebsd.org) Received: (from suz@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9M7VCgT085439; Fri, 22 Oct 2004 07:31:12 GMT (envelope-from suz) Message-Id: <200410220731.i9M7VCgT085439@repoman.freebsd.org> From: SUZUKI Shinsuke Date: Fri, 22 Oct 2004 07:31:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin/rtadvd config.c timer.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 07:31:13 -0000 suz 2004-10-22 07:31:12 UTC FreeBSD src repository Modified files: usr.sbin/rtadvd config.c timer.c Log: removed compilation warning PR: bin/71624 Revision Changes Path 1.24 +1 -0 src/usr.sbin/rtadvd/config.c 1.9 +1 -0 src/usr.sbin/rtadvd/timer.c From owner-cvs-src@FreeBSD.ORG Fri Oct 22 08:12:50 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 15AE216A4CE; Fri, 22 Oct 2004 08:12:50 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id EA42C43D46; Fri, 22 Oct 2004 08:12:49 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9M8CnKI086832; Fri, 22 Oct 2004 08:12:49 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9M8CnH5086831; Fri, 22 Oct 2004 08:12:49 GMT (envelope-from phk) Message-Id: <200410220812.i9M8CnH5086831@repoman.freebsd.org> From: Poul-Henning Kamp Date: Fri, 22 Oct 2004 08:12:49 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/pc98/pc98 fd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 08:12:50 -0000 phk 2004-10-22 08:12:49 UTC FreeBSD src repository Modified files: sys/pc98/pc98 fd.c Log: Use bioq_takefirst() Revision Changes Path 1.157 +2 -4 src/sys/pc98/pc98/fd.c From owner-cvs-src@FreeBSD.ORG Fri Oct 22 08:45:34 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E9D6E16A4CE; Fri, 22 Oct 2004 08:45:34 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C9DE143D4C; Fri, 22 Oct 2004 08:45:34 +0000 (GMT) (envelope-from blackend@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9M8jYCW087649; Fri, 22 Oct 2004 08:45:34 GMT (envelope-from blackend@repoman.freebsd.org) Received: (from blackend@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9M8jYxU087648; Fri, 22 Oct 2004 08:45:34 GMT (envelope-from blackend) Message-Id: <200410220845.i9M8jYxU087648@repoman.freebsd.org> From: Marc Fonvieille Date: Fri, 22 Oct 2004 08:45:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/tools/tools/nanobsd make.conf X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 08:45:35 -0000 blackend 2004-10-22 08:45:34 UTC FreeBSD src repository (doc committer) Modified files: tools/tools/nanobsd make.conf Log: Sort NO* variables. Approved by: phk Revision Changes Path 1.5 +21 -21 src/tools/tools/nanobsd/make.conf From owner-cvs-src@FreeBSD.ORG Fri Oct 22 08:47:21 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5EB9716A4CE; Fri, 22 Oct 2004 08:47:21 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4D10C43D41; Fri, 22 Oct 2004 08:47:21 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9M8lLA1094246; Fri, 22 Oct 2004 08:47:21 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9M8lLM2094245; Fri, 22 Oct 2004 08:47:21 GMT (envelope-from phk) Message-Id: <200410220847.i9M8lLM2094245@repoman.freebsd.org> From: Poul-Henning Kamp Date: Fri, 22 Oct 2004 08:47:21 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/gnu/ext2fs ext2_bmap.c src/sys/kern vfs_bio.c vfs_cluster.c vfs_subr.c src/sys/nfs4client nfs4_vnops.c src/sys/nfsclient nfs_bio.c nfs_subs.c nfs_vfsops.c nfs_vnops.c src/sys/nfsserver nfs_serv.c src/sys/sys buf.h src/sys/ufs/ffs ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 08:47:21 -0000 phk 2004-10-22 08:47:21 UTC FreeBSD src repository Modified files: sys/gnu/ext2fs ext2_bmap.c sys/kern vfs_bio.c vfs_cluster.c vfs_subr.c sys/nfs4client nfs4_vnops.c sys/nfsclient nfs_bio.c nfs_subs.c nfs_vfsops.c nfs_vnops.c sys/nfsserver nfs_serv.c sys/sys buf.h sys/ufs/ffs ffs_softdep.c sys/ufs/ufs ufs_bmap.c sys/vm swap_pager.c Log: Add b_bufobj to struct buf which eventually will eliminate the need for b_vp. Initialize b_bufobj for all buffers. Make incore() and gbincore() take a bufobj instead of a vnode. Make inmem() local to vfs_bio.c Change a lot of VI_[UN]LOCK(bp->b_vp) to BO_[UN]LOCK(bp->b_bufobj) also VI_MTX() to BO_MTX(), Make buf_vlist_add() take a bufobj instead of a vnode. Eliminate other uses of bp->b_vp where bp->b_bufobj will do. Various minor polishing: remove "register", turn panic into KASSERT, use new function declarations, TAILQ_FOREACH_SAFE() etc. Revision Changes Path 1.58 +1 -1 src/sys/gnu/ext2fs/ext2_bmap.c 1.453 +66 -56 src/sys/kern/vfs_bio.c 1.153 +5 -4 src/sys/kern/vfs_cluster.c 1.535 +64 -87 src/sys/kern/vfs_subr.c 1.11 +5 -7 src/sys/nfs4client/nfs4_vnops.c 1.137 +2 -2 src/sys/nfsclient/nfs_bio.c 1.133 +1 -2 src/sys/nfsclient/nfs_subs.c 1.160 +2 -1 src/sys/nfsclient/nfs_vfsops.c 1.225 +5 -7 src/sys/nfsclient/nfs_vnops.c 1.150 +1 -1 src/sys/nfsserver/nfs_serv.c 1.171 +4 -3 src/sys/sys/buf.h 1.158 +1 -1 src/sys/ufs/ffs/ffs_softdep.c 1.61 +1 -1 src/sys/ufs/ufs/ufs_bmap.c 1.259 +3 -4 src/sys/vm/swap_pager.c From owner-cvs-src@FreeBSD.ORG Fri Oct 22 08:49:55 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1857F16A4CE; Fri, 22 Oct 2004 08:49:55 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id EB80143D3F; Fri, 22 Oct 2004 08:49:54 +0000 (GMT) (envelope-from blackend@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9M8nsqb094331; Fri, 22 Oct 2004 08:49:54 GMT (envelope-from blackend@repoman.freebsd.org) Received: (from blackend@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9M8nsup094330; Fri, 22 Oct 2004 08:49:54 GMT (envelope-from blackend) Message-Id: <200410220849.i9M8nsup094330@repoman.freebsd.org> From: Marc Fonvieille Date: Fri, 22 Oct 2004 08:49:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/tools/tools/nanobsd make.conf X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 08:49:55 -0000 blackend 2004-10-22 08:49:54 UTC FreeBSD src repository (doc committer) Modified files: tools/tools/nanobsd make.conf Log: Add NO_BLUETOOTH and NO_AUTHPF variables. [1] While I'm there use lowercase "yes" for consistency. Approved by: phk [1] Revision Changes Path 1.6 +3 -1 src/tools/tools/nanobsd/make.conf From owner-cvs-src@FreeBSD.ORG Fri Oct 22 09:30:47 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 02A2216A4CE; Fri, 22 Oct 2004 09:30:47 +0000 (GMT) Received: from smtp.des.no (flood.des.no [217.116.83.31]) by mx1.FreeBSD.org (Postfix) with ESMTP id 443ED43D46; Fri, 22 Oct 2004 09:30:46 +0000 (GMT) (envelope-from des@des.no) Received: by smtp.des.no (Pony Express, from userid 666) id DEEFC5311; Fri, 22 Oct 2004 11:30:44 +0200 (CEST) Received: from dwp.des.no (des.no [80.203.228.37]) by smtp.des.no (Pony Express) with ESMTP id 4D94F5310; Fri, 22 Oct 2004 11:30:38 +0200 (CEST) Received: by dwp.des.no (Postfix, from userid 2602) id 02099B861; Fri, 22 Oct 2004 11:30:37 +0200 (CEST) To: John Baldwin References: <20041019071102.GA49717@FreeBSD.org> <200410191541.54269.jhb@FreeBSD.org> <41758B81.5090903@freebsd.org> <200410201419.06181.jhb@FreeBSD.org> From: des@des.no (=?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?=) Date: Fri, 22 Oct 2004 11:30:37 +0200 In-Reply-To: <200410201419.06181.jhb@FreeBSD.org> (John Baldwin's message of "Wed, 20 Oct 2004 14:19:06 -0400") Message-ID: User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Checker-Version: SpamAssassin 2.64 (2004-01-11) on flood.des.no X-Spam-Level: X-Spam-Status: No, hits=0.0 required=5.0 tests=AWL autolearn=no version=2.64 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Scott Long cc: cvs-all@FreeBSD.org cc: "M. Warner Losh" Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 09:30:47 -0000 John Baldwin writes: > 6.0 won't be that long in coming famous last words... DES --=20 Dag-Erling Sm=F8rgrav - des@des.no From owner-cvs-src@FreeBSD.ORG Fri Oct 22 09:32:46 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4D24C16A4CE; Fri, 22 Oct 2004 09:32:46 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2A31943D46; Fri, 22 Oct 2004 09:32:46 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9M9WkpA095760; Fri, 22 Oct 2004 09:32:46 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9M9WjKm095759; Fri, 22 Oct 2004 09:32:45 GMT (envelope-from rwatson) Message-Id: <200410220932.i9M9WjKm095759@repoman.freebsd.org> From: Robert Watson Date: Fri, 22 Oct 2004 09:32:45 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Subject: cvs commit: src/sys/net if.c if_var.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 09:32:46 -0000 rwatson 2004-10-22 09:32:45 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) sys/net if.c if_var.h Log: Merge if.c:1.210, if_var.h:1.85 from HEAD to RELENG_5: Define IFF_LOCKGIANT() and IFF_UNLOCKGIANT() macros, which conditionally acquire Giant if the passed interface has IFF_NEEDSGIANT set on it. Modify calls into (ifp)->if_ioctl() in if.c to use these macros in order to ensure that Giant is held. MFC after: 3 days Bumped into by: jmg Approved by: re (kensmith) Revision Changes Path 1.199.2.8 +30 -2 src/sys/net/if.c 1.84.2.1 +10 -0 src/sys/net/if_var.h From owner-cvs-src@FreeBSD.ORG Fri Oct 22 09:43:09 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 81E5016A4CE; Fri, 22 Oct 2004 09:43:09 +0000 (GMT) Received: from smtp.des.no (flood.des.no [217.116.83.31]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1E81243D31; Fri, 22 Oct 2004 09:43:09 +0000 (GMT) (envelope-from des@des.no) Received: by smtp.des.no (Pony Express, from userid 666) id CB92A5311; Fri, 22 Oct 2004 11:43:07 +0200 (CEST) Received: from dwp.des.no (des.no [80.203.228.37]) by smtp.des.no (Pony Express) with ESMTP id D24995310; Fri, 22 Oct 2004 11:43:01 +0200 (CEST) Received: by dwp.des.no (Postfix, from userid 2602) id 82F33B861; Fri, 22 Oct 2004 11:43:01 +0200 (CEST) To: Harti Brandt References: <200410191513.i9JFDUbf072176@repoman.freebsd.org> <417532A2.9000901@errno.com> <41753522.1E39FEAE@freebsd.org> <200410192329.46723.max@love2party.net> <41758B35.D5340AEA@freebsd.org> <20041020074747.B21281@beagle.kn.op.dlr.de> From: des@des.no (=?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?=) Date: Fri, 22 Oct 2004 11:43:01 +0200 In-Reply-To: <20041020074747.B21281@beagle.kn.op.dlr.de> (Harti Brandt's message of "Wed, 20 Oct 2004 07:55:32 +0200 (CEST)") Message-ID: User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Checker-Version: SpamAssassin 2.64 (2004-01-11) on flood.des.no X-Spam-Level: X-Spam-Status: No, hits=0.0 required=5.0 tests=AWL autolearn=no version=2.64 cc: src-committers@freebsd.org cc: Andre Oppermann cc: cvs-src@freebsd.org cc: cvs-all@freebsd.org cc: Sam Leffler cc: Max Laier Subject: Re: cvs commit: src/sys/sys protosw.h src/sys/kern uipc_domain.cuipc_socket2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 09:43:09 -0000 Harti Brandt writes: > You cannot prevent the compiler from makeing temporary copies. Yes, you can, using the volatile keyword. DES --=20 Dag-Erling Sm=F8rgrav - des@des.no From owner-cvs-src@FreeBSD.ORG Fri Oct 22 09:59:37 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CDC0E16A4CE; Fri, 22 Oct 2004 09:59:37 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C139D43D5E; Fri, 22 Oct 2004 09:59:37 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9M9xb0N096752; Fri, 22 Oct 2004 09:59:37 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9M9xbAl096751; Fri, 22 Oct 2004 09:59:37 GMT (envelope-from phk) Message-Id: <200410220959.i9M9xbAl096751@repoman.freebsd.org> From: Poul-Henning Kamp Date: Fri, 22 Oct 2004 09:59:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/conf files src/sys/fs/devfs devfs_vnops.c src/sys/fs/specfs spec_vnops.c src/sys/kern vfs_subr.c src/sys/sys vnode.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 09:59:38 -0000 phk 2004-10-22 09:59:37 UTC FreeBSD src repository Modified files: sys/conf files sys/fs/devfs devfs_vnops.c sys/kern vfs_subr.c sys/sys vnode.h Removed files: sys/fs/specfs spec_vnops.c Log: Alas, poor SPECFS! -- I knew him, Horatio; A filesystem of infinite jest, of most excellent fancy: he hath taught me lessons a thousand times; and now, how abhorred in my imagination it is! my gorge rises at it. Here were those hacks that I have curs'd I know not how oft. Where be your kludges now? your workarounds? your layering violations, that were wont to set the table on a roar? Move the skeleton of specfs into devfs where it now belongs and bury the rest. Revision Changes Path 1.958 +0 -1 src/sys/conf/files 1.74 +551 -26 src/sys/fs/devfs/devfs_vnops.c 1.233 +0 -598 src/sys/fs/specfs/spec_vnops.c (dead) 1.536 +3 -3 src/sys/kern/vfs_subr.c 1.249 +1 -2 src/sys/sys/vnode.h From owner-cvs-src@FreeBSD.ORG Fri Oct 22 10:30:39 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 50CD016A4CE; Fri, 22 Oct 2004 10:30:39 +0000 (GMT) Received: from n33.kp.t-systems-sfr.com (n33.kp.t-systems-sfr.com [129.247.16.33]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4C22643D3F; Fri, 22 Oct 2004 10:30:36 +0000 (GMT) (envelope-from harti@freebsd.org) Received: from n81.sp.op.dlr.de (n81g.sp.op.dlr.de [129.247.163.1]) i9MAUWU555358; Fri, 22 Oct 2004 12:30:33 +0200 Received: from zeus.nt.op.dlr.de (zeus.nt.op.dlr.de [129.247.173.3]) i9MAUWI75028; Fri, 22 Oct 2004 12:30:32 +0200 Received: from beagle.kn.op.dlr.de (opkndnwsbsd178 [129.247.173.178]) by zeus.nt.op.dlr.de (8.11.7+Sun/8.9.1) with ESMTP id i9MAUce23454; Fri, 22 Oct 2004 12:30:39 +0200 (MET DST) Date: Fri, 22 Oct 2004 12:30:30 +0200 (CEST) From: Harti Brandt X-X-Sender: brandt@beagle.kn.op.dlr.de To: =?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?= In-Reply-To: Message-ID: <20041022122708.Y28348@beagle.kn.op.dlr.de> References: <200410191513.i9JFDUbf072176@repoman.freebsd.org> <417532A2.9000901@errno.com> <41753522.1E39FEAE@freebsd.org> <200410192329.46723.max@love2party.net> <41758B35.D5340AEA@freebsd.org> <20041020074747.B21281@beagle.kn.op.dlr.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: src-committers@freebsd.org cc: Andre Oppermann cc: cvs-src@freebsd.org cc: cvs-all@freebsd.org cc: Sam Leffler cc: Max Laier Subject: Re: cvs commit: src/sys/sys protosw.h src/sys/kern uipc_domain.cuipc_socket2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Harti Brandt List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 10:30:39 -0000 On Fri, 22 Oct 2004, [iso-8859-1] Dag-Erling Sm?rgrav wrote: DS>Harti Brandt writes: DS>> You cannot prevent the compiler from makeing temporary copies. DS> DS>Yes, you can, using the volatile keyword. That doesn't help you if the compiler needs to fetch the function pointer into a register to call it. That would be allowed even if you declare the pointer volatile. Something like mov funcptr, r0 call @r0 If some other thread slips just between these two statements your call may end up somewhere. harti From owner-cvs-src@FreeBSD.ORG Fri Oct 22 11:04:59 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7749516A4CE; Fri, 22 Oct 2004 11:04:59 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 57EB943D1F; Fri, 22 Oct 2004 11:04:59 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9MB4xat099222; Fri, 22 Oct 2004 11:04:59 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9MB4xvw099221; Fri, 22 Oct 2004 11:04:59 GMT (envelope-from rwatson) Message-Id: <200410221104.i9MB4xvw099221@repoman.freebsd.org> From: Robert Watson Date: Fri, 22 Oct 2004 11:04:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 11:04:59 -0000 rwatson 2004-10-22 11:04:59 UTC FreeBSD src repository Modified files: sys/kern vfs_subr.c Log: When MAC is enabled, warn if getnewvnode() is asked to produce a vnode without a mountpoint. In this scenario, there's no useful source for a label on the vnode, since we can't query the mountpoint for the labeling strategy or default label. Revision Changes Path 1.537 +2 -0 src/sys/kern/vfs_subr.c From owner-cvs-src@FreeBSD.ORG Fri Oct 22 11:07:19 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1044616A4CE; Fri, 22 Oct 2004 11:07:19 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E606E43D45; Fri, 22 Oct 2004 11:07:18 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9MB7IZJ099402; Fri, 22 Oct 2004 11:07:18 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9MB7INH099401; Fri, 22 Oct 2004 11:07:18 GMT (envelope-from rwatson) Message-Id: <200410221107.i9MB7INH099401@repoman.freebsd.org> From: Robert Watson Date: Fri, 22 Oct 2004 11:07:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/security/mac mac_internal.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 11:07:19 -0000 rwatson 2004-10-22 11:07:18 UTC FreeBSD src repository Modified files: sys/security/mac mac_internal.h Log: Remove extern declaration of mac_enforce_sysv, as it's not present in the CVS version of the MAC Framework. Revision Changes Path 1.112 +0 -1 src/sys/security/mac/mac_internal.h From owner-cvs-src@FreeBSD.ORG Fri Oct 22 11:08:52 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B3C2416A4CE; Fri, 22 Oct 2004 11:08:52 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 92F7643D2D; Fri, 22 Oct 2004 11:08:52 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9MB8qE7099449; Fri, 22 Oct 2004 11:08:52 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9MB8q1F099448; Fri, 22 Oct 2004 11:08:52 GMT (envelope-from rwatson) Message-Id: <200410221108.i9MB8q1F099448@repoman.freebsd.org> From: Robert Watson Date: Fri, 22 Oct 2004 11:08:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/security/mac mac_label.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 11:08:52 -0000 rwatson 2004-10-22 11:08:52 UTC FreeBSD src repository Modified files: sys/security/mac mac_label.c Log: In the MAC label zone destructor, assert that the label is only destroyed in an initialized state. Revision Changes Path 1.3 +3 -1 src/sys/security/mac/mac_label.c From owner-cvs-src@FreeBSD.ORG Fri Oct 22 11:15:47 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E0EEF16A4CE; Fri, 22 Oct 2004 11:15:47 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C145F43D2D; Fri, 22 Oct 2004 11:15:47 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9MBFlDn099812; Fri, 22 Oct 2004 11:15:47 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9MBFl1U099811; Fri, 22 Oct 2004 11:15:47 GMT (envelope-from rwatson) Message-Id: <200410221115.i9MBFl1U099811@repoman.freebsd.org> From: Robert Watson Date: Fri, 22 Oct 2004 11:15:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/security/mac_biba mac_biba.c src/sys/security/mac_bsdextended mac_bsdextended.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 11:15:48 -0000 rwatson 2004-10-22 11:15:47 UTC FreeBSD src repository Modified files: sys/security/mac_biba mac_biba.c sys/security/mac_bsdextended mac_bsdextended.c Log: Minor white space synchronization and line wrapping. Revision Changes Path 1.81 +2 -1 src/sys/security/mac_biba/mac_biba.c 1.24 +1 -0 src/sys/security/mac_bsdextended/mac_bsdextended.c From owner-cvs-src@FreeBSD.ORG Fri Oct 22 11:24:51 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4538116A4CE; Fri, 22 Oct 2004 11:24:51 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 24DA143D3F; Fri, 22 Oct 2004 11:24:51 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9MBOpqF000140; Fri, 22 Oct 2004 11:24:51 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9MBOpUT000139; Fri, 22 Oct 2004 11:24:51 GMT (envelope-from rwatson) Message-Id: <200410221124.i9MBOpUT000139@repoman.freebsd.org> From: Robert Watson Date: Fri, 22 Oct 2004 11:24:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/security/mac_test mac_test.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 11:24:51 -0000 rwatson 2004-10-22 11:24:51 UTC FreeBSD src repository Modified files: sys/security/mac_test mac_test.c Log: Replace direct reference to kdb_enter() with a DEBUGGER() macro that will call printf() if KDB isn't compiled into the kernel. Obtained from: TrustedBSD Project Sponsored by: SPAWAR Revision Changes Path 1.49 +34 -28 src/sys/security/mac_test/mac_test.c From owner-cvs-src@FreeBSD.ORG Fri Oct 22 11:29:30 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 942B716A4CE; Fri, 22 Oct 2004 11:29:30 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7556943D45; Fri, 22 Oct 2004 11:29:30 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9MBTU2u000359; Fri, 22 Oct 2004 11:29:30 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9MBTUm6000358; Fri, 22 Oct 2004 11:29:30 GMT (envelope-from rwatson) Message-Id: <200410221129.i9MBTUm6000358@repoman.freebsd.org> From: Robert Watson Date: Fri, 22 Oct 2004 11:29:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/sys mac_policy.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 11:29:30 -0000 rwatson 2004-10-22 11:29:30 UTC FreeBSD src repository Modified files: sys/sys mac_policy.h Log: Expand comments on various sections of the MAC Framework Policy API, as well as document the properties of the mac_policy_conf structure. Warn about the ABI risks in changing the structure without careful consideration. Obtained from: TrustedBSD Project Sponsored by: SPAWAR Revision Changes Path 1.56 +15 -4 src/sys/sys/mac_policy.h From owner-cvs-src@FreeBSD.ORG Fri Oct 22 12:10:50 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E21A116A4CE; Fri, 22 Oct 2004 12:10:50 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C2A8643D5D; Fri, 22 Oct 2004 12:10:50 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9MCAoBW001802; Fri, 22 Oct 2004 12:10:50 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9MCAokb001801; Fri, 22 Oct 2004 12:10:50 GMT (envelope-from rwatson) Message-Id: <200410221210.i9MCAokb001801@repoman.freebsd.org> From: Robert Watson Date: Fri, 22 Oct 2004 12:10:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern kern_xxx.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 12:10:51 -0000 rwatson 2004-10-22 12:10:50 UTC FreeBSD src repository Modified files: sys/kern kern_xxx.c Log: In osethostname(), don't need to call suser() directly as userland_sysctl() will perform all necessary privilege checks for the caller. Revision Changes Path 1.45 +2 -4 src/sys/kern/kern_xxx.c From owner-cvs-src@FreeBSD.ORG Fri Oct 22 12:12:41 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E9B1B16A4CE; Fri, 22 Oct 2004 12:12:40 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C9DCC43D2D; Fri, 22 Oct 2004 12:12:40 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9MCCeQ1001861; Fri, 22 Oct 2004 12:12:40 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9MCCeiB001860; Fri, 22 Oct 2004 12:12:40 GMT (envelope-from rwatson) Message-Id: <200410221212.i9MCCeiB001860@repoman.freebsd.org> From: Robert Watson Date: Fri, 22 Oct 2004 12:12:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern sysv_ipc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 12:12:41 -0000 rwatson 2004-10-22 12:12:40 UTC FreeBSD src repository Modified files: sys/kern sysv_ipc.c Log: Add an annotation to the comment for sysv_ipc.c to indicate that the MAC Framework doesn't require checks in ipcperm() because checks relating to System V IPC will be performed in individual IPC implementations. Revision Changes Path 1.28 +6 -2 src/sys/kern/sysv_ipc.c From owner-cvs-src@FreeBSD.ORG Fri Oct 22 13:10:54 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from green.homeunix.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 3857A16A4CE; Fri, 22 Oct 2004 13:10:54 +0000 (GMT) Received: from green.homeunix.org (green@localhost [127.0.0.1]) by green.homeunix.org (8.13.1/8.13.1) with ESMTP id i9MDAreI093569; Fri, 22 Oct 2004 09:10:53 -0400 (EDT) (envelope-from green@green.homeunix.org) Received: (from green@localhost) by green.homeunix.org (8.13.1/8.13.1/Submit) id i9MDAr3H093568; Fri, 22 Oct 2004 09:10:53 -0400 (EDT) (envelope-from green) Date: Fri, 22 Oct 2004 09:10:52 -0400 From: Brian Fundakowski Feldman To: Poul-Henning Kamp Message-ID: <20041022131052.GM1072@green.homeunix.org> References: <200410220959.i9M9xbAl096751@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200410220959.i9M9xbAl096751@repoman.freebsd.org> User-Agent: Mutt/1.5.6i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf files src/sys/fs/devfs devfs_vnops.c src/sys/fs/specfs spec_vnops.c src/sys/kern vfs_subr.c src/sys/sys vnode.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 13:10:54 -0000 On Fri, Oct 22, 2004 at 09:59:37AM +0000, Poul-Henning Kamp wrote: > phk 2004-10-22 09:59:37 UTC > > FreeBSD src repository > > Modified files: > sys/conf files > sys/fs/devfs devfs_vnops.c > sys/kern vfs_subr.c > sys/sys vnode.h > Removed files: > sys/fs/specfs spec_vnops.c > Log: > Alas, poor SPECFS! -- I knew him, Horatio; A filesystem of infinite > jest, of most excellent fancy: he hath taught me lessons a thousand > times; and now, how abhorred in my imagination it is! my gorge rises > at it. Here were those hacks that I have curs'd I know not how > oft. Where be your kludges now? your workarounds? your layering > violations, that were wont to set the table on a roar? > > Move the skeleton of specfs into devfs where it now belongs and > bury the rest. Yay! -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\ From owner-cvs-src@FreeBSD.ORG Fri Oct 22 14:03:36 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8689E16A4CE; Fri, 22 Oct 2004 14:03:36 +0000 (GMT) Received: from smtp.des.no (flood.des.no [217.116.83.31]) by mx1.FreeBSD.org (Postfix) with ESMTP id 491B243D5A; Fri, 22 Oct 2004 14:03:36 +0000 (GMT) (envelope-from des@des.no) Received: by smtp.des.no (Pony Express, from userid 666) id 5216D5311; Fri, 22 Oct 2004 16:03:35 +0200 (CEST) Received: from dwp.des.no (des.no [80.203.228.37]) by smtp.des.no (Pony Express) with ESMTP id A31D95310; Fri, 22 Oct 2004 16:03:28 +0200 (CEST) Received: by dwp.des.no (Postfix, from userid 2602) id 3A856B861; Fri, 22 Oct 2004 16:03:28 +0200 (CEST) To: Poul-Henning Kamp References: <200410211348.i9LDmomG044745@repoman.freebsd.org> From: des@des.no (=?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?=) Date: Fri, 22 Oct 2004 16:03:27 +0200 In-Reply-To: <200410211348.i9LDmomG044745@repoman.freebsd.org> (Poul-Henning Kamp's message of "Thu, 21 Oct 2004 13:48:50 +0000 (UTC)") Message-ID: User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Checker-Version: SpamAssassin 2.64 (2004-01-11) on flood.des.no X-Spam-Level: X-Spam-Status: No, hits=0.0 required=5.0 tests=AWL autolearn=no version=2.64 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 14:03:36 -0000 Poul-Henning Kamp writes: > Log: > Simplify buf_vlist_remove(). >=20=20=20 > Now that we have encapsulated the splaytree related information > into a structure we can eliminate the half of this function. Is there any particular reason why you are using a home-grown splay tree implementation instead of ? DES --=20 Dag-Erling Sm=F8rgrav - des@des.no From owner-cvs-src@FreeBSD.ORG Fri Oct 22 14:04:15 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1456B16A4CE; Fri, 22 Oct 2004 14:04:15 +0000 (GMT) Received: from smtp.des.no (flood.des.no [217.116.83.31]) by mx1.FreeBSD.org (Postfix) with ESMTP id C7DF243D5D; Fri, 22 Oct 2004 14:04:14 +0000 (GMT) (envelope-from des@des.no) Received: by smtp.des.no (Pony Express, from userid 666) id 0697A5311; Fri, 22 Oct 2004 16:04:13 +0200 (CEST) Received: from dwp.des.no (des.no [80.203.228.37]) by smtp.des.no (Pony Express) with ESMTP id 2EDC85310; Fri, 22 Oct 2004 16:04:07 +0200 (CEST) Received: by dwp.des.no (Postfix, from userid 2602) id 145ABB876; Fri, 22 Oct 2004 16:04:07 +0200 (CEST) To: Poul-Henning Kamp References: <200410220959.i9M9xbAl096751@repoman.freebsd.org> From: des@des.no (=?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?=) Date: Fri, 22 Oct 2004 16:04:06 +0200 In-Reply-To: <200410220959.i9M9xbAl096751@repoman.freebsd.org> (Poul-Henning Kamp's message of "Fri, 22 Oct 2004 09:59:37 +0000 (UTC)") Message-ID: User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Checker-Version: SpamAssassin 2.64 (2004-01-11) on flood.des.no X-Spam-Level: X-Spam-Status: No, hits=0.0 required=5.0 tests=AWL autolearn=no version=2.64 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf files src/sys/fs/devfs devfs_vnops.c src/sys/fs/specfs spec_vnops.c src/sys/kern vfs_subr.c src/sys/sys vnode.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 14:04:15 -0000 Poul-Henning Kamp writes: > Log: > Alas, poor SPECFS! -- I knew him, Horatio; A filesystem of infinite > jest, of most excellent fancy: he hath taught me lessons a thousand > times; and now, how abhorred in my imagination it is! my gorge rises > at it. Here were those hacks that I have curs'd I know not how > oft. Where be your kludges now? your workarounds? your layering > violations, that were wont to set the table on a roar? Stands to reason that the guy with the Danish battleax had to be a Danish prince :) DES --=20 Dag-Erling Sm=F8rgrav - des@des.no From owner-cvs-src@FreeBSD.ORG Fri Oct 22 14:06:26 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B22AF16A4CE; Fri, 22 Oct 2004 14:06:26 +0000 (GMT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0B04843D1D; Fri, 22 Oct 2004 14:06:26 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.13.1/8.13.1) with ESMTP id i9ME6G3I052101; Fri, 22 Oct 2004 16:06:20 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: des@des.no (=?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?=) From: "Poul-Henning Kamp" In-Reply-To: Your message of "Fri, 22 Oct 2004 16:03:27 +0200." Date: Fri, 22 Oct 2004 16:06:16 +0200 Message-ID: <52100.1098453976@critter.freebsd.dk> Sender: phk@critter.freebsd.dk cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 14:06:26 -0000 In message , =?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?= writes: >Poul-Henning Kamp writes: >> Log: >> Simplify buf_vlist_remove(). >> >> Now that we have encapsulated the splaytree related information >> into a structure we can eliminate the half of this function. > >Is there any particular reason why you are using a home-grown splay >tree implementation instead of ? s/you/Dillon/ None that I know off. Right now I'm just doing the rearrangement of bits, we can look into replacing some of them afterwards. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Fri Oct 22 14:56:23 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E4B0116A4CE; Fri, 22 Oct 2004 14:56:23 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C3D1743D1F; Fri, 22 Oct 2004 14:56:23 +0000 (GMT) (envelope-from simokawa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9MEuNtV014957; Fri, 22 Oct 2004 14:56:23 GMT (envelope-from simokawa@repoman.freebsd.org) Received: (from simokawa@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9MEuNHC014956; Fri, 22 Oct 2004 14:56:23 GMT (envelope-from simokawa) Message-Id: <200410221456.i9MEuNHC014956@repoman.freebsd.org> From: Hidetoshi Shimokawa Date: Fri, 22 Oct 2004 14:56:23 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/boot/i386/libi386 biospci.c libi386.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 14:56:24 -0000 simokawa 2004-10-22 14:56:23 UTC FreeBSD src repository Modified files: sys/boot/i386/libi386 biospci.c libi386.h Log: - Add FireWire subclass and OHCI interface. - Add some PCI BIOS function calls. (find_devclass, read_config, write_config) Revision Changes Path 1.5 +71 -23 src/sys/boot/i386/libi386/biospci.c 1.19 +4 -0 src/sys/boot/i386/libi386/libi386.h From owner-cvs-src@FreeBSD.ORG Fri Oct 22 14:57:28 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D20BB16A4D0; Fri, 22 Oct 2004 14:57:28 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A612743D53; Fri, 22 Oct 2004 14:57:28 +0000 (GMT) (envelope-from simokawa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9MEvSFd015011; Fri, 22 Oct 2004 14:57:28 GMT (envelope-from simokawa@repoman.freebsd.org) Received: (from simokawa@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9MEvSmi015010; Fri, 22 Oct 2004 14:57:28 GMT (envelope-from simokawa) Message-Id: <200410221457.i9MEvSmi015010@repoman.freebsd.org> From: Hidetoshi Shimokawa Date: Fri, 22 Oct 2004 14:57:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/boot/i386/loader main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 14:57:29 -0000 simokawa 2004-10-22 14:57:28 UTC FreeBSD src repository Modified files: sys/boot/i386/loader main.c Log: Respect RB_MULTIPLE flag. Revision Changes Path 1.30 +2 -0 src/sys/boot/i386/loader/main.c From owner-cvs-src@FreeBSD.ORG Fri Oct 22 15:03:22 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7C9E316A4CE; Fri, 22 Oct 2004 15:03:22 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5D01943D54; Fri, 22 Oct 2004 15:03:22 +0000 (GMT) (envelope-from simokawa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9MF3MTk015293; Fri, 22 Oct 2004 15:03:22 GMT (envelope-from simokawa@repoman.freebsd.org) Received: (from simokawa@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9MF3MZL015292; Fri, 22 Oct 2004 15:03:22 GMT (envelope-from simokawa) Message-Id: <200410221503.i9MF3MZL015292@repoman.freebsd.org> From: Hidetoshi Shimokawa Date: Fri, 22 Oct 2004 15:03:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/dcons dcons.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 15:03:22 -0000 simokawa 2004-10-22 15:03:22 UTC FreeBSD src repository Modified files: sys/dev/dcons dcons.h Log: Check _BOOT flag. Revision Changes Path 1.4 +3 -3 src/sys/dev/dcons/dcons.h From owner-cvs-src@FreeBSD.ORG Fri Oct 22 15:14:25 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3C8F916A4CE; Fri, 22 Oct 2004 15:14:25 +0000 (GMT) Received: from smtp.des.no (flood.des.no [217.116.83.31]) by mx1.FreeBSD.org (Postfix) with ESMTP id 97EB243D39; Fri, 22 Oct 2004 15:14:24 +0000 (GMT) (envelope-from des@des.no) Received: by smtp.des.no (Pony Express, from userid 666) id 42C935311; Fri, 22 Oct 2004 17:14:23 +0200 (CEST) Received: from dwp.des.no (des.no [80.203.228.37]) by smtp.des.no (Pony Express) with ESMTP id 873785310; Fri, 22 Oct 2004 17:14:16 +0200 (CEST) Received: by dwp.des.no (Postfix, from userid 2602) id 4C5AEB861; Fri, 22 Oct 2004 17:14:16 +0200 (CEST) To: "Poul-Henning Kamp" References: <52100.1098453976@critter.freebsd.dk> From: des@des.no (=?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?=) Date: Fri, 22 Oct 2004 17:14:16 +0200 In-Reply-To: <52100.1098453976@critter.freebsd.dk> (Poul-Henning Kamp's message of "Fri, 22 Oct 2004 16:06:16 +0200") Message-ID: User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Checker-Version: SpamAssassin 2.64 (2004-01-11) on flood.des.no X-Spam-Level: X-Spam-Status: No, hits=0.0 required=5.0 tests=AWL autolearn=no version=2.64 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vfs_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 15:14:25 -0000 "Poul-Henning Kamp" writes: > Dag-Erling Sm=F8rgrav writes: > > Is there any particular reason why you are using a home-grown splay > > tree implementation instead of ? > s/you/Dillon/ Sorry, I just assumed this was new code from phk_bufwork. I'm not surprised Matt didn't use it; we didn't have it back then. I imported it from OpenBSD two years ago because OpenSSH needed it. DES --=20 Dag-Erling Sm=F8rgrav - des@des.no From owner-cvs-src@FreeBSD.ORG Fri Oct 22 15:39:40 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6626416A4D0; Fri, 22 Oct 2004 15:39:40 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3719E43D48; Fri, 22 Oct 2004 15:39:40 +0000 (GMT) (envelope-from simokawa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9MFdeGC016518; Fri, 22 Oct 2004 15:39:40 GMT (envelope-from simokawa@repoman.freebsd.org) Received: (from simokawa@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9MFdeDl016517; Fri, 22 Oct 2004 15:39:40 GMT (envelope-from simokawa) Message-Id: <200410221539.i9MFdeDl016517@repoman.freebsd.org> From: Hidetoshi Shimokawa Date: Fri, 22 Oct 2004 15:39:40 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/firewire fwcrom.c iec13213.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 15:39:40 -0000 simokawa 2004-10-22 15:39:40 UTC FreeBSD src repository Modified files: sys/dev/firewire fwcrom.c iec13213.h Log: Respect _BOOT flag. Revision Changes Path 1.13 +10 -4 src/sys/dev/firewire/fwcrom.c 1.13 +2 -2 src/sys/dev/firewire/iec13213.h From owner-cvs-src@FreeBSD.ORG Fri Oct 22 16:18:16 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 911B516A4CE; Fri, 22 Oct 2004 16:18:16 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7042D43D53; Fri, 22 Oct 2004 16:18:16 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9MGIGLZ017735; Fri, 22 Oct 2004 16:18:16 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9MGIGfh017734; Fri, 22 Oct 2004 16:18:16 GMT (envelope-from phk) Message-Id: <200410221618.i9MGIGfh017734@repoman.freebsd.org> From: Poul-Henning Kamp Date: Fri, 22 Oct 2004 16:18:16 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/games/fortune/datfiles fortunes X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 16:18:16 -0000 phk 2004-10-22 16:18:16 UTC FreeBSD src repository Modified files: games/fortune/datfiles fortunes Log: I'm surprised this one was not here yet. To save you all a trip to CVSWEB: Experts have correctly predicted nine out of the last five recessions. -- Paul Samuelson, Nobel laureate in economics. Revision Changes Path 1.144 +3 -0 src/games/fortune/datfiles/fortunes From owner-cvs-src@FreeBSD.ORG Fri Oct 22 16:44:40 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0276716A4CE; Fri, 22 Oct 2004 16:44:40 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D6F8943D2D; Fri, 22 Oct 2004 16:44:39 +0000 (GMT) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9MGidXY018559; Fri, 22 Oct 2004 16:44:39 GMT (envelope-from cperciva@repoman.freebsd.org) Received: (from cperciva@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9MGidYh018558; Fri, 22 Oct 2004 16:44:39 GMT (envelope-from cperciva) Message-Id: <200410221644.i9MGidYh018558@repoman.freebsd.org> From: Colin Percival Date: Fri, 22 Oct 2004 16:44:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.bin/mktemp mktemp.1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 16:44:40 -0000 cperciva 2004-10-22 16:44:39 UTC FreeBSD src repository Modified files: usr.bin/mktemp mktemp.1 Log: Add punctuation which appears to have been accidentally removed in revision 1.6. Revision Changes Path 1.18 +1 -1 src/usr.bin/mktemp/mktemp.1 From owner-cvs-src@FreeBSD.ORG Fri Oct 22 17:17:13 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 776B416A4CE; Fri, 22 Oct 2004 17:17:13 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 586C943D39; Fri, 22 Oct 2004 17:17:13 +0000 (GMT) (envelope-from njl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9MHHDmx025902; Fri, 22 Oct 2004 17:17:13 GMT (envelope-from njl@repoman.freebsd.org) Received: (from njl@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9MHHDWQ025901; Fri, 22 Oct 2004 17:17:13 GMT (envelope-from njl) Message-Id: <200410221717.i9MHHDWQ025901@repoman.freebsd.org> From: Nate Lawson Date: Fri, 22 Oct 2004 17:17:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/i386/acpica acpi_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 17:17:13 -0000 njl 2004-10-22 17:17:13 UTC FreeBSD src repository Modified files: sys/i386/acpica acpi_machdep.c Log: Remove a "needs Giant" flag from the /dev/apm compat device. MFC after: 2 weeks Revision Changes Path 1.28 +0 -1 src/sys/i386/acpica/acpi_machdep.c From owner-cvs-src@FreeBSD.ORG Fri Oct 22 17:59:56 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 733C616A4CE; Fri, 22 Oct 2004 17:59:56 +0000 (GMT) Received: from smtp-vbr4.xs4all.nl (smtp-vbr4.xs4all.nl [194.109.24.24]) by mx1.FreeBSD.org (Postfix) with ESMTP id BA18443D2D; Fri, 22 Oct 2004 17:59:55 +0000 (GMT) (envelope-from wb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (freebie.xs4all.nl [213.84.32.253]) by smtp-vbr4.xs4all.nl (8.12.11/8.12.11) with ESMTP id i9MHxs48006640; Fri, 22 Oct 2004 19:59:54 +0200 (CEST) (envelope-from wb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (localhost [127.0.0.1]) by freebie.xs4all.nl (8.13.1/8.12.9) with ESMTP id i9MHxssH053911; Fri, 22 Oct 2004 19:59:54 +0200 (CEST) (envelope-from wb@freebie.xs4all.nl) Received: (from wb@localhost) by freebie.xs4all.nl (8.13.1/8.13.1/Submit) id i9MHxs6q053910; Fri, 22 Oct 2004 19:59:54 +0200 (CEST) (envelope-from wb) Date: Fri, 22 Oct 2004 19:59:54 +0200 From: Wilko Bulte To: Poul-Henning Kamp Message-ID: <20041022175953.GA53879@freebie.xs4all.nl> References: <200410221618.i9MGIGfh017734@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200410221618.i9MGIGfh017734@repoman.freebsd.org> User-Agent: Mutt/1.4.1i X-OS: FreeBSD 4.10-STABLE X-PGP: finger wilko@freebsd.org X-Virus-Scanned: by XS4ALL Virus Scanner cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/games/fortune/datfiles fortunes X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 17:59:56 -0000 On Fri, Oct 22, 2004 at 04:18:16PM +0000, Poul-Henning Kamp wrote.. > phk 2004-10-22 16:18:16 UTC > > FreeBSD src repository > > Modified files: > games/fortune/datfiles fortunes > Log: > I'm surprised this one was not here yet. > > To save you all a trip to CVSWEB: > > Experts have correctly predicted nine out of the last five recessions. > -- Paul Samuelson, Nobel laureate in economics. Trusting economists is like trusting Microsoft to write bugfree software :) -- Wilko Bulte wilko@FreeBSD.org From owner-cvs-src@FreeBSD.ORG Fri Oct 22 18:01:26 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2108C16A4CE; Fri, 22 Oct 2004 18:01:26 +0000 (GMT) Received: from smtp-vbr1.xs4all.nl (smtp-vbr1.xs4all.nl [194.109.24.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5B74A43D1F; Fri, 22 Oct 2004 18:01:25 +0000 (GMT) (envelope-from wb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (freebie.xs4all.nl [213.84.32.253]) by smtp-vbr1.xs4all.nl (8.12.11/8.12.11) with ESMTP id i9MI1NFF080522; Fri, 22 Oct 2004 20:01:23 +0200 (CEST) (envelope-from wb@freebie.xs4all.nl) Received: from freebie.xs4all.nl (localhost [127.0.0.1]) by freebie.xs4all.nl (8.13.1/8.12.9) with ESMTP id i9MI1NRo053944; Fri, 22 Oct 2004 20:01:23 +0200 (CEST) (envelope-from wb@freebie.xs4all.nl) Received: (from wb@localhost) by freebie.xs4all.nl (8.13.1/8.13.1/Submit) id i9MI1N0q053943; Fri, 22 Oct 2004 20:01:23 +0200 (CEST) (envelope-from wb) Date: Fri, 22 Oct 2004 20:01:23 +0200 From: Wilko Bulte To: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= Message-ID: <20041022180123.GB53879@freebie.xs4all.nl> References: <200410220959.i9M9xbAl096751@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.4.1i X-OS: FreeBSD 4.10-STABLE X-PGP: finger wilko@freebsd.org X-Virus-Scanned: by XS4ALL Virus Scanner cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: Poul-Henning Kamp cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/conf files src/sys/fs/devfs devfs_vnops.c src/sys/fs/specfs spec_vnops.c src/sys/kern vfs_subr.c src/sys/sys vnode.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 18:01:26 -0000 On Fri, Oct 22, 2004 at 04:04:06PM +0200, Dag-Erling Smørgrav wrote.. > Poul-Henning Kamp writes: > > Log: > > Alas, poor SPECFS! -- I knew him, Horatio; A filesystem of infinite > > jest, of most excellent fancy: he hath taught me lessons a thousand > > times; and now, how abhorred in my imagination it is! my gorge rises > > at it. Here were those hacks that I have curs'd I know not how > > oft. Where be your kludges now? your workarounds? your layering > > violations, that were wont to set the table on a roar? > > Stands to reason that the guy with the Danish battleax had to be a > Danish prince :) You have not been close to the Amsterdam coffee shops recently, do you? :-P -- Wilko Bulte wilko@FreeBSD.org From owner-cvs-src@FreeBSD.ORG Fri Oct 22 18:07:11 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 447E916A4CE; Fri, 22 Oct 2004 18:07:11 +0000 (GMT) Received: from bast.unixathome.org (bast.unixathome.org [66.11.174.150]) by mx1.FreeBSD.org (Postfix) with ESMTP id E9F1643D48; Fri, 22 Oct 2004 18:07:10 +0000 (GMT) (envelope-from dan@langille.org) Received: from xeon (xeon.unixathome.org [192.168.0.18]) by bast.unixathome.org (Postfix) with ESMTP id 2053E3D37; Fri, 22 Oct 2004 14:07:09 -0400 (EDT) Date: Fri, 22 Oct 2004 14:07:09 -0400 (EDT) From: Dan Langille X-X-Sender: dan@xeon.unixathome.org To: Wilko Bulte In-Reply-To: <20041022175953.GA53879@freebie.xs4all.nl> Message-ID: <20041022140435.T44103@xeon.unixathome.org> References: <200410221618.i9MGIGfh017734@repoman.freebsd.org> <20041022175953.GA53879@freebie.xs4all.nl> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: Poul-Henning Kamp cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/games/fortune/datfiles fortunes X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 18:07:11 -0000 On Fri, 22 Oct 2004, Wilko Bulte wrote: > On Fri, Oct 22, 2004 at 04:18:16PM +0000, Poul-Henning Kamp wrote.. > > phk 2004-10-22 16:18:16 UTC > > > > FreeBSD src repository > > > > Modified files: > > games/fortune/datfiles fortunes > > Log: > > I'm surprised this one was not here yet. > > > > To save you all a trip to CVSWEB: > > > > Experts have correctly predicted nine out of the last five recessions. > > -- Paul Samuelson, Nobel laureate in economics. > > Trusting economists is like trusting Microsoft to write bugfree software I could not find a reference to the quote in Google, but I did find: [20] "The market has anticipated 12 of the last 9 recessions" http://www.gold-eagle.com/editorials_02/cortes012402.html -- Dan Langille - http://www.langille.org/ BSDCan - The Technical BSD Conference: http://www.bsdcan.org/ From owner-cvs-src@FreeBSD.ORG Fri Oct 22 18:48:43 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 020B616A4CE; Fri, 22 Oct 2004 18:48:43 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D676D43D1F; Fri, 22 Oct 2004 18:48:42 +0000 (GMT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9MImgvP028575; Fri, 22 Oct 2004 18:48:42 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9MImgg3028574; Fri, 22 Oct 2004 18:48:42 GMT (envelope-from scottl) Message-Id: <200410221848.i9MImgg3028574@repoman.freebsd.org> From: Scott Long Date: Fri, 22 Oct 2004 18:48:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Subject: cvs commit: src/sys/sys proc.h src/sys/kern kern_switch.c kern_synch.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 18:48:43 -0000 scottl 2004-10-22 18:48:42 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) sys/sys proc.h sys/kern kern_switch.c kern_synch.c Log: MFC: Wake up the pager from critical_exit if the process being switched to needs to be swapped in. Approved by: re Revision Changes Path 1.78.2.13 +4 -0 src/sys/kern/kern_switch.c 1.257.2.4 +5 -5 src/sys/kern/kern_synch.c 1.392.2.13 +1 -1 src/sys/sys/proc.h From owner-cvs-src@FreeBSD.ORG Fri Oct 22 19:01:11 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 23AFD16A4CE; Fri, 22 Oct 2004 19:01:11 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0541243D4C; Fri, 22 Oct 2004 19:01:11 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9MJ1ADf029007; Fri, 22 Oct 2004 19:01:10 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9MJ1ArO029006; Fri, 22 Oct 2004 19:01:10 GMT (envelope-from phk) Message-Id: <200410221901.i9MJ1ArO029006@repoman.freebsd.org> From: Poul-Henning Kamp Date: Fri, 22 Oct 2004 19:01:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/fdc fdc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 19:01:11 -0000 phk 2004-10-22 19:01:10 UTC FreeBSD src repository Modified files: sys/dev/fdc fdc.c Log: Properly handle failure to allocate isadma bounce buffer Revision Changes Path 1.299 +6 -2 src/sys/dev/fdc/fdc.c From owner-cvs-src@FreeBSD.ORG Fri Oct 22 19:12:01 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C693A16A4CE; Fri, 22 Oct 2004 19:12:01 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A550843D46; Fri, 22 Oct 2004 19:12:01 +0000 (GMT) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9MJC1WH029403; Fri, 22 Oct 2004 19:12:01 GMT (envelope-from andre@repoman.freebsd.org) Received: (from andre@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9MJC16j029402; Fri, 22 Oct 2004 19:12:01 GMT (envelope-from andre) Message-Id: <200410221912.i9MJC16j029402@repoman.freebsd.org> From: Andre Oppermann Date: Fri, 22 Oct 2004 19:12:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netinet ip_divert.c src/share/man/man4 divert.4 src/sbin/ipfw ipfw.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 19:12:02 -0000 andre 2004-10-22 19:12:01 UTC FreeBSD src repository Modified files: sys/netinet ip_divert.c share/man/man4 divert.4 sbin/ipfw ipfw.8 Log: Refuse to unload the ipdivert module unless the 'force' flag is given to kldunload. Reflect the fact that IPDIVERT is a loadable module in the divert(4) and ipfw(8) man pages. Revision Changes Path 1.158 +4 -4 src/sbin/ipfw/ipfw.8 1.31 +13 -3 src/share/man/man4/divert.4 1.105 +11 -1 src/sys/netinet/ip_divert.c From owner-cvs-src@FreeBSD.ORG Fri Oct 22 19:13:07 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E2F6316A4CE; Fri, 22 Oct 2004 19:13:07 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C2B7443D54; Fri, 22 Oct 2004 19:13:07 +0000 (GMT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9MJD7H3029493; Fri, 22 Oct 2004 19:13:07 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9MJD7uA029492; Fri, 22 Oct 2004 19:13:07 GMT (envelope-from scottl) Message-Id: <200410221913.i9MJD7uA029492@repoman.freebsd.org> From: Scott Long Date: Fri, 22 Oct 2004 19:13:07 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5_3 Subject: cvs commit: src/sys/sys proc.h src/sys/kern kern_switch.c kern_synch.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 19:13:08 -0000 scottl 2004-10-22 19:13:07 UTC FreeBSD src repository Modified files: (Branch: RELENG_5_3) sys/sys proc.h sys/kern kern_switch.c kern_synch.c Log: MFC: Wake up the pager from critical_exit if the process being switched to needs to be swapped in. Approved by: re Revision Changes Path 1.78.2.12.2.1 +4 -0 src/sys/kern/kern_switch.c 1.257.2.3.2.1 +5 -5 src/sys/kern/kern_synch.c 1.392.2.12.2.1 +1 -1 src/sys/sys/proc.h From owner-cvs-src@FreeBSD.ORG Fri Oct 22 19:18:07 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 48B5116A4CE; Fri, 22 Oct 2004 19:18:07 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2878843D49; Fri, 22 Oct 2004 19:18:07 +0000 (GMT) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9MJI7IY029719; Fri, 22 Oct 2004 19:18:07 GMT (envelope-from andre@repoman.freebsd.org) Received: (from andre@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9MJI7dc029718; Fri, 22 Oct 2004 19:18:07 GMT (envelope-from andre) Message-Id: <200410221918.i9MJI7dc029718@repoman.freebsd.org> From: Andre Oppermann Date: Fri, 22 Oct 2004 19:18:07 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netinet ip_fw2.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 19:18:07 -0000 andre 2004-10-22 19:18:07 UTC FreeBSD src repository Modified files: sys/netinet ip_fw2.c Log: When printing the initialization string and IPDIVERT is not compiled into the kernel refer to it as "loadable" instead of "disabled". Revision Changes Path 1.83 +1 -1 src/sys/netinet/ip_fw2.c From owner-cvs-src@FreeBSD.ORG Fri Oct 22 19:32:37 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9F2D516A4CE; Fri, 22 Oct 2004 19:32:37 +0000 (GMT) Received: from smtp4.server.rpi.edu (smtp4.server.rpi.edu [128.113.2.4]) by mx1.FreeBSD.org (Postfix) with ESMTP id 34AD843D48; Fri, 22 Oct 2004 19:32:37 +0000 (GMT) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by smtp4.server.rpi.edu (8.13.0/8.13.0) with ESMTP id i9MJWWbM029870; Fri, 22 Oct 2004 15:32:33 -0400 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <200410221913.i9MJD7uA029492@repoman.freebsd.org> References: <200410221913.i9MJD7uA029492@repoman.freebsd.org> Date: Fri, 22 Oct 2004 15:32:31 -0400 To: Scott Long , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org From: Garance A Drosihn Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-CanItPRO-Stream: default X-RPI-SA-Score: undef - spam-scanning disabled X-Scanned-By: CanIt (www . canit . ca) Subject: Re: cvs commit: src/sys/sys proc.h src/sys/kern kern_switch.c kern_synch.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 19:32:37 -0000 At 7:13 PM +0000 10/22/04, Scott Long wrote: >scottl 2004-10-22 19:13:07 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_5_3) > sys/sys proc.h > sys/kern kern_switch.c kern_synch.c > Log: > MFC: Wake up the pager from critical_exit if the process being > switched to needs to be swapped in. Would this problem cause any panics during 'shutdown -p' processing? I just loaded up a brand new machine with 5.3-RC1, and it works fine except that it almost always panics when I do a 'shutdown -p'. I just finished building a new world to make sure I have all the latest changes, but I haven't installed that yet. Should I rebuild the kernel with this change included? (the machine does not panic during standard 'shutdown -r' processing, only for 'shutdown -p'. It has a gig of memory now, so I kinda doubt it has anything that it needs to swap in.) -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu From owner-cvs-src@FreeBSD.ORG Fri Oct 22 19:35:03 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7E2BE16A4CF; Fri, 22 Oct 2004 19:35:03 +0000 (GMT) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id E19CA43D49; Fri, 22 Oct 2004 19:35:02 +0000 (GMT) (envelope-from scottl@freebsd.org) Received: from [192.168.254.11] (junior-wifi.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.12.11/8.12.10) with ESMTP id i9MJZeGW062256; Fri, 22 Oct 2004 13:35:40 -0600 (MDT) (envelope-from scottl@freebsd.org) Message-ID: <41796081.7050400@freebsd.org> Date: Fri, 22 Oct 2004 13:33:21 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.2) Gecko/20040929 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Garance A Drosihn References: <200410221913.i9MJD7uA029492@repoman.freebsd.org> In-Reply-To: X-Enigmail-Version: 0.86.1.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=0.0 required=3.8 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on pooker.samsco.org cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/sys proc.h src/sys/kern kern_switch.c kern_synch.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 19:35:03 -0000 Garance A Drosihn wrote: > At 7:13 PM +0000 10/22/04, Scott Long wrote: > >> scottl 2004-10-22 19:13:07 UTC >> >> FreeBSD src repository >> >> Modified files: (Branch: RELENG_5_3) >> sys/sys proc.h >> sys/kern kern_switch.c kern_synch.c >> Log: >> MFC: Wake up the pager from critical_exit if the process being >> switched to needs to be swapped in. > > > Would this problem cause any panics during 'shutdown -p' processing? > I just loaded up a brand new machine with 5.3-RC1, and it works fine > except that it almost always panics when I do a 'shutdown -p'. I > just finished building a new world to make sure I have all the latest > changes, but I haven't installed that yet. Should I rebuild the > kernel with this change included? > > (the machine does not panic during standard 'shutdown -r' processing, > only for 'shutdown -p'. It has a gig of memory now, so I kinda doubt > it has anything that it needs to swap in.) > I would tend to suspect ACPI here. Do you have kind of DDB info from the panic? Scott From owner-cvs-src@FreeBSD.ORG Fri Oct 22 19:36:03 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EA04416A4CE; Fri, 22 Oct 2004 19:36:03 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CAD0043D31; Fri, 22 Oct 2004 19:36:03 +0000 (GMT) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9MJa3UO030248; Fri, 22 Oct 2004 19:36:03 GMT (envelope-from andre@repoman.freebsd.org) Received: (from andre@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9MJa377030247; Fri, 22 Oct 2004 19:36:03 GMT (envelope-from andre) Message-Id: <200410221936.i9MJa377030247@repoman.freebsd.org> From: Andre Oppermann Date: Fri, 22 Oct 2004 19:36:03 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/etc/rc.d natd X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 19:36:04 -0000 andre 2004-10-22 19:36:03 UTC FreeBSD src repository Modified files: etc/rc.d natd Log: Automatically load the ipdivert module if it was not compiled into the kernel and natd_enable is true. Revision Changes Path 1.3 +13 -0 src/etc/rc.d/natd From owner-cvs-src@FreeBSD.ORG Fri Oct 22 19:55:05 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EFD7116A4CF; Fri, 22 Oct 2004 19:55:04 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D09D843D31; Fri, 22 Oct 2004 19:55:04 +0000 (GMT) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9MJt4Kj030817; Fri, 22 Oct 2004 19:55:04 GMT (envelope-from andre@repoman.freebsd.org) Received: (from andre@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9MJt4Au030816; Fri, 22 Oct 2004 19:55:04 GMT (envelope-from andre) Message-Id: <200410221955.i9MJt4Au030816@repoman.freebsd.org> From: Andre Oppermann Date: Fri, 22 Oct 2004 19:55:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src UPDATING src/sys/netinet tcp_var.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 19:55:05 -0000 andre 2004-10-22 19:55:04 UTC FreeBSD src repository Modified files: . UPDATING sys/netinet tcp_var.h Log: Shave 40 unused bytes from struct tcpcb. Revision Changes Path 1.376 +5 -0 src/UPDATING 1.111 +0 -1 src/sys/netinet/tcp_var.h From owner-cvs-src@FreeBSD.ORG Fri Oct 22 19:59:38 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5A62316A4CE; Fri, 22 Oct 2004 19:59:38 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3AE9143D2F; Fri, 22 Oct 2004 19:59:38 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9MJxc1a031019; Fri, 22 Oct 2004 19:59:38 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9MJxcLJ031018; Fri, 22 Oct 2004 19:59:38 GMT (envelope-from phk) Message-Id: <200410221959.i9MJxcLJ031018@repoman.freebsd.org> From: Poul-Henning Kamp Date: Fri, 22 Oct 2004 19:59:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/games/fortune/datfiles fortunes X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 19:59:38 -0000 phk 2004-10-22 19:59:38 UTC FreeBSD src repository Modified files: games/fortune/datfiles fortunes Log: Improve accuracy of last addition, as best Google advices me. Revision Changes Path 1.145 +3 -2 src/games/fortune/datfiles/fortunes From owner-cvs-src@FreeBSD.ORG Fri Oct 22 20:05:47 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E80BA16A4CE; Fri, 22 Oct 2004 20:05:47 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DC3E443D2F; Fri, 22 Oct 2004 20:05:47 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9MK5lsX031324; Fri, 22 Oct 2004 20:05:47 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9MK5lPs031323; Fri, 22 Oct 2004 20:05:47 GMT (envelope-from marcel) Message-Id: <200410222005.i9MK5lPs031323@repoman.freebsd.org> From: Marcel Moolenaar Date: Fri, 22 Oct 2004 20:05:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Subject: cvs commit: src/release/scripts print-cdrom-packages.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 20:05:48 -0000 marcel 2004-10-22 20:05:47 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) release/scripts print-cdrom-packages.sh Log: MFC: rev 1.65: Don't put devel/gdb6 on disc1 for non-i386 platforms. We have gdb6 in the base-system. Adding the port for ia64 on disc1 is especially bogus, because the port doesn't even build on ia64. It also doesn't support libthread_db. MFC: rev 1.68: Seperate ia64 from the pack. The disc1 is overflowing to such extend that most packages can not be included. It's much easier to list those that we do want on disc1 for ia64. We only need to list 11 of them. Approved by: re (scottl) Revision Changes Path 1.64.2.3 +94 -86 src/release/scripts/print-cdrom-packages.sh From owner-cvs-src@FreeBSD.ORG Fri Oct 22 20:09:35 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F3C7016A4CE; Fri, 22 Oct 2004 20:09:34 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E808543D45; Fri, 22 Oct 2004 20:09:34 +0000 (GMT) (envelope-from marcel@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9MK9YwH031399; Fri, 22 Oct 2004 20:09:34 GMT (envelope-from marcel@repoman.freebsd.org) Received: (from marcel@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9MK9Y3i031398; Fri, 22 Oct 2004 20:09:34 GMT (envelope-from marcel) Message-Id: <200410222009.i9MK9Y3i031398@repoman.freebsd.org> From: Marcel Moolenaar Date: Fri, 22 Oct 2004 20:09:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5_3 Subject: cvs commit: src/release/scripts print-cdrom-packages.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 20:09:35 -0000 marcel 2004-10-22 20:09:34 UTC FreeBSD src repository Modified files: (Branch: RELENG_5_3) release/scripts print-cdrom-packages.sh Log: MF5: rev 1.64.2.3: MFC: rev 1.65: Don't put devel/gdb6 on disc1 for non-i386 platforms. We have gdb6 in the base-system. Adding the port for ia64 on disc1 is especially bogus, because the port doesn't even build on ia64. It also doesn't support libthread_db. MFC: rev 1.68: Seperate ia64 from the pack. The disc1 is overflowing to such extend that most packages can not be included. It's much easier to list those that we do want on disc1 for ia64. We only need to list 11 of them. Approved by: re (scottl) Revision Changes Path 1.64.2.2.2.1 +94 -86 src/release/scripts/print-cdrom-packages.sh From owner-cvs-src@FreeBSD.ORG Fri Oct 22 20:15:27 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8C0AC16A4CE; Fri, 22 Oct 2004 20:15:27 +0000 (GMT) Received: from smtp3.server.rpi.edu (smtp3.server.rpi.edu [128.113.2.3]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3647843D39; Fri, 22 Oct 2004 20:15:27 +0000 (GMT) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by smtp3.server.rpi.edu (8.13.0/8.13.0) with ESMTP id i9MKFOS0007348; Fri, 22 Oct 2004 16:15:26 -0400 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <41796081.7050400@freebsd.org> References: <200410221913.i9MJD7uA029492@repoman.freebsd.org> <41796081.7050400@freebsd.org> Date: Fri, 22 Oct 2004 16:15:23 -0400 To: Scott Long From: Garance A Drosihn Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-CanItPRO-Stream: default X-RPI-SA-Score: undef - spam-scanning disabled X-Scanned-By: CanIt (www . canit . ca) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys proc.h src/sys/kern kern_switch.c kern_synch.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 20:15:27 -0000 At 1:33 PM -0600 10/22/04, Scott Long wrote: >Garance A Drosihn wrote: >> >>Would this problem cause any panics during 'shutdown -p' processing? >>I just loaded up a brand new machine with 5.3-RC1, and it works fine >>except that it almost always panics when I do a 'shutdown -p'. I >>just finished building a new world to make sure I have all the latest >>changes, but I haven't installed that yet. Should I rebuild the >>kernel with this change included? >> >>(the machine does not panic during standard 'shutdown -r' processing, >>only for 'shutdown -p'. It has a gig of memory now, so I kinda doubt >>it has anything that it needs to swap in.) > >I would tend to suspect ACPI here. Do you have kind of DDB info >from the panic? I am trying to get it setup with a serial console and debugging. I should have something more useful to report by the end of the day. It also just occurred to me that I am building an SMP kernel, even though this is a single-CPU machine. I think I'll leave it as SMP for now. -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu From owner-cvs-src@FreeBSD.ORG Fri Oct 22 21:21:28 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E72CB16A4CE; Fri, 22 Oct 2004 21:21:28 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C697743D1F; Fri, 22 Oct 2004 21:21:28 +0000 (GMT) (envelope-from jmg@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9MLLS93040390; Fri, 22 Oct 2004 21:21:28 GMT (envelope-from jmg@repoman.freebsd.org) Received: (from jmg@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9MLLSpF040389; Fri, 22 Oct 2004 21:21:28 GMT (envelope-from jmg) Message-Id: <200410222121.i9MLLSpF040389@repoman.freebsd.org> From: John-Mark Gurney Date: Fri, 22 Oct 2004 21:21:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Subject: cvs commit: src/sys/pci if_de.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 21:21:29 -0000 jmg 2004-10-22 21:21:28 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) sys/pci if_de.c Log: MFC: if_de.c v1.159: > fix (for me) the problems where if_de gets really slow after time > (usually taking 20 seconds to transmit a packet).. no longer fall back > to only transmitting one packet (instead of the entire queue) after we > have processed the entire send queue... I have no idea why we didn't > start seeing this problem ~6 years ago when this code was introduced... Approved by: re (scottl) Revision Changes Path 1.158.2.1 +0 -21 src/sys/pci/if_de.c From owner-cvs-src@FreeBSD.ORG Fri Oct 22 21:54:34 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3988216A4CE; Fri, 22 Oct 2004 21:54:34 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 19AE243D2F; Fri, 22 Oct 2004 21:54:34 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9MLsX5Z041322; Fri, 22 Oct 2004 21:54:33 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9MLsXwC041321; Fri, 22 Oct 2004 21:54:33 GMT (envelope-from rwatson) Message-Id: <200410222154.i9MLsXwC041321@repoman.freebsd.org> From: Robert Watson Date: Fri, 22 Oct 2004 21:54:33 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: CVSROOT access X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 21:54:34 -0000 rwatson 2004-10-22 21:54:33 UTC FreeBSD src repository Modified files: . access Log: Welcome back Andrew Reiter , who after being lost in no man's land for ten months wanted his commit bit back. Fortunately, core@ kept it on that handy "temporarily returned" commit bit shelf. Revision Changes Path 1.681 +1 -0 CVSROOT/access From owner-cvs-src@FreeBSD.ORG Fri Oct 22 22:16:24 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D332016A4CE; Fri, 22 Oct 2004 22:16:24 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id B286F43D39; Fri, 22 Oct 2004 22:16:24 +0000 (GMT) (envelope-from arr@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9MMGOYn042097; Fri, 22 Oct 2004 22:16:24 GMT (envelope-from arr@repoman.freebsd.org) Received: (from arr@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9MMGOU8042096; Fri, 22 Oct 2004 22:16:24 GMT (envelope-from arr) Message-Id: <200410222216.i9MMGOU8042096@repoman.freebsd.org> From: "Andrew R. Reiter" Date: Fri, 22 Oct 2004 22:16:24 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/geom geom_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 22:16:25 -0000 arr 2004-10-22 22:16:24 UTC FreeBSD src repository Modified files: sys/geom geom_subr.c Log: - Turn KASSERT()s into warning printf()'s in the g_class_load() routine. This removes a panic that will occur if you build with GENERIC and attempt to kldload a GEOM module that is already in the kernel. Reviewed by: phk Revision Changes Path 1.84 +26 -10 src/sys/geom/geom_subr.c From owner-cvs-src@FreeBSD.ORG Fri Oct 22 22:31:14 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0E7E716A4CE; Fri, 22 Oct 2004 22:31:14 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DFE4443D41; Fri, 22 Oct 2004 22:31:13 +0000 (GMT) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9MMVDLV042582; Fri, 22 Oct 2004 22:31:13 GMT (envelope-from kensmith@repoman.freebsd.org) Received: (from kensmith@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9MMVDUc042581; Fri, 22 Oct 2004 22:31:13 GMT (envelope-from kensmith) Message-Id: <200410222231.i9MMVDUc042581@repoman.freebsd.org> From: Ken Smith Date: Fri, 22 Oct 2004 22:31:13 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5_3 Subject: cvs commit: src/release/doc/zh_CN.GB2312 Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 22:31:14 -0000 kensmith 2004-10-22 22:31:13 UTC FreeBSD src repository Modified files: (Branch: RELENG_5_3) release/doc/zh_CN.GB2312 Makefile Log: Forced commit to note tags were slid to make the Simplified Chinese Translation release docs part of RELENG_5 and RELENG_5_3 so they will be included in the 5.3-RELEASE. Requested by: Xin LI Approved by: re (scottl) Revision Changes Path 1.1.4.1 +0 -0 src/release/doc/zh_CN.GB2312/Makefile From owner-cvs-src@FreeBSD.ORG Fri Oct 22 23:07:52 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C92C716A4CE; Fri, 22 Oct 2004 23:07:52 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A821743D1D; Fri, 22 Oct 2004 23:07:52 +0000 (GMT) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9MN7qt5043628; Fri, 22 Oct 2004 23:07:52 GMT (envelope-from andre@repoman.freebsd.org) Received: (from andre@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9MN7qHe043627; Fri, 22 Oct 2004 23:07:52 GMT (envelope-from andre) Message-Id: <200410222307.i9MN7qHe043627@repoman.freebsd.org> From: Andre Oppermann Date: Fri, 22 Oct 2004 23:07:52 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/man/man5 rc.conf.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2004 23:07:53 -0000 andre 2004-10-22 23:07:52 UTC FreeBSD src repository Modified files: share/man/man5 rc.conf.5 Log: IPDIVERT will automatically load ipdivert.ko if not compiled into the kernel. Revision Changes Path 1.231 +5 -0 src/share/man/man5/rc.conf.5 From owner-cvs-src@FreeBSD.ORG Sat Oct 23 02:58:02 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1E57A16A4CE; Sat, 23 Oct 2004 02:58:02 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0DB1243D2F; Sat, 23 Oct 2004 02:58:02 +0000 (GMT) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9N2w1t7057273; Sat, 23 Oct 2004 02:58:01 GMT (envelope-from kensmith@repoman.freebsd.org) Received: (from kensmith@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9N2w115057272; Sat, 23 Oct 2004 02:58:01 GMT (envelope-from kensmith) Message-Id: <200410230258.i9N2w115057272@repoman.freebsd.org> From: Ken Smith Date: Sat, 23 Oct 2004 02:58:01 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Subject: cvs commit: src/etc/mtree BSD.usr.dist src/share/zoneinfo asia europe leapseconds northamerica southamerica zone.tab X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 02:58:02 -0000 kensmith 2004-10-23 02:58:01 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) etc/mtree BSD.usr.dist share/zoneinfo asia europe leapseconds northamerica southamerica zone.tab Log: MFC the update to the Time Zone files. From the logs of commit to HEAD: > wollman 2004-10-18 00:03:52 UTC > Modified files: > share/zoneinfo asia europe leapseconds northamerica > southamerica zone.tab > Log: > MFV tzdata2004e > > Users in Brazil and Argentina should run tzsetup(8). > Obtained from: Arthur David Olson > MFC after re approval > > Revision Changes Path > 1.25 +74 -23 src/share/zoneinfo/asia > 1.28 +25 -20 src/share/zoneinfo/europe > 1.11 +11 -9 src/share/zoneinfo/leapseconds > 1.24 +61 -35 src/share/zoneinfo/northamerica > 1.23 +184 -27 src/share/zoneinfo/southamerica > 1.17 +13 -6 src/share/zoneinfo/zone.tab > > wollman 2004-10-18 17:03:53 UTC > Modified files: > etc/mtree BSD.usr.dist > Log: > New directory added for Argentinian timezones. > > Submitted by: ache > > Revision Changes Path > 1.309 +2 -0 src/etc/mtree/BSD.usr.dist Work done by: wollman Approved by: re (scottl) Revision Changes Path 1.304.2.3 +2 -0 src/etc/mtree/BSD.usr.dist 1.24.4.1 +74 -23 src/share/zoneinfo/asia 1.27.4.1 +25 -20 src/share/zoneinfo/europe 1.10.4.1 +11 -9 src/share/zoneinfo/leapseconds 1.23.4.1 +61 -35 src/share/zoneinfo/northamerica 1.22.4.1 +184 -27 src/share/zoneinfo/southamerica 1.16.4.1 +13 -6 src/share/zoneinfo/zone.tab From owner-cvs-src@FreeBSD.ORG Sat Oct 23 03:10:50 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 506E216A4CE; Sat, 23 Oct 2004 03:10:50 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 411A143D5A; Sat, 23 Oct 2004 03:10:50 +0000 (GMT) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9N3Ao63058031; Sat, 23 Oct 2004 03:10:50 GMT (envelope-from kensmith@repoman.freebsd.org) Received: (from kensmith@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9N3AoK4058030; Sat, 23 Oct 2004 03:10:50 GMT (envelope-from kensmith) Message-Id: <200410230310.i9N3AoK4058030@repoman.freebsd.org> From: Ken Smith Date: Sat, 23 Oct 2004 03:10:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5_3 Subject: cvs commit: src/etc/mtree BSD.usr.dist src/share/zoneinfo asia europe leapseconds northamerica southamerica zone.tab X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 03:10:50 -0000 kensmith 2004-10-23 03:10:50 UTC FreeBSD src repository Modified files: (Branch: RELENG_5_3) etc/mtree BSD.usr.dist share/zoneinfo asia europe leapseconds northamerica southamerica zone.tab Log: MFR5 of Time Zone update tzdata2004e. Versions being MFR5-ed: > Revision Changes Path > 1.304.2.3 +2 -0 src/etc/mtree/BSD.usr.dist > 1.24.4.1 +74 -23 src/share/zoneinfo/asia > 1.27.4.1 +25 -20 src/share/zoneinfo/europe > 1.10.4.1 +11 -9 src/share/zoneinfo/leapseconds > 1.23.4.1 +61 -35 src/share/zoneinfo/northamerica > 1.22.4.1 +184 -27 src/share/zoneinfo/southamerica > 1.16.4.1 +13 -6 src/share/zoneinfo/zone.tab Work done by: wollman Approved by: re (scottl) Revision Changes Path 1.304.2.2.2.1 +2 -0 src/etc/mtree/BSD.usr.dist 1.24.6.1 +74 -23 src/share/zoneinfo/asia 1.27.6.1 +25 -20 src/share/zoneinfo/europe 1.10.6.1 +11 -9 src/share/zoneinfo/leapseconds 1.23.6.1 +61 -35 src/share/zoneinfo/northamerica 1.22.6.1 +184 -27 src/share/zoneinfo/southamerica 1.16.6.1 +13 -6 src/share/zoneinfo/zone.tab From owner-cvs-src@FreeBSD.ORG Sat Oct 23 03:12:34 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E100B16A4CE; Sat, 23 Oct 2004 03:12:33 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BFD2543D49; Sat, 23 Oct 2004 03:12:33 +0000 (GMT) (envelope-from jmg@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9N3CXEZ058119; Sat, 23 Oct 2004 03:12:33 GMT (envelope-from jmg@repoman.freebsd.org) Received: (from jmg@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9N3CXr6058118; Sat, 23 Oct 2004 03:12:33 GMT (envelope-from jmg) Message-Id: <200410230312.i9N3CXr6058118@repoman.freebsd.org> From: John-Mark Gurney Date: Sat, 23 Oct 2004 03:12:33 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5_3 Subject: cvs commit: src/sys/pci if_de.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 03:12:34 -0000 jmg 2004-10-23 03:12:33 UTC FreeBSD src repository Modified files: (Branch: RELENG_5_3) sys/pci if_de.c Log: MFR5: if_de.c v1.159: > fix (for me) the problems where if_de gets really slow after time > (usually taking 20 seconds to transmit a packet).. no longer fall back > to only transmitting one packet (instead of the entire queue) after we > have processed the entire send queue... I have no idea why we didn't > start seeing this problem ~6 years ago when this code was introduced... Approved by: re (scottl) Revision Changes Path 1.158.4.1 +0 -21 src/sys/pci/if_de.c From owner-cvs-src@FreeBSD.ORG Sat Oct 23 06:50:51 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1E23416A4CE; Sat, 23 Oct 2004 06:50:51 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F265543D41; Sat, 23 Oct 2004 06:50:50 +0000 (GMT) (envelope-from mtm@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9N6oogR073238; Sat, 23 Oct 2004 06:50:50 GMT (envelope-from mtm@repoman.freebsd.org) Received: (from mtm@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9N6oo49073237; Sat, 23 Oct 2004 06:50:50 GMT (envelope-from mtm) Message-Id: <200410230650.i9N6oo49073237@repoman.freebsd.org> From: Mike Makonnen Date: Sat, 23 Oct 2004 06:50:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/etc/rc.d devfs X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 06:50:51 -0000 mtm 2004-10-23 06:50:50 UTC FreeBSD src repository Modified files: etc/rc.d devfs Log: Move devfs earlier in the boot sequence. Some system daemons and other programs may need to use the symlinks and permissions that it sets up. Discussed on: -current Revision Changes Path 1.10 +2 -2 src/etc/rc.d/devfs From owner-cvs-src@FreeBSD.ORG Sat Oct 23 08:33:10 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9498D16A4CE; Sat, 23 Oct 2004 08:33:10 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 886DE43D1D; Sat, 23 Oct 2004 08:33:10 +0000 (GMT) (envelope-from mtm@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9N8XA8v077060; Sat, 23 Oct 2004 08:33:10 GMT (envelope-from mtm@repoman.freebsd.org) Received: (from mtm@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9N8XA8R077059; Sat, 23 Oct 2004 08:33:10 GMT (envelope-from mtm) Message-Id: <200410230833.i9N8XA8R077059@repoman.freebsd.org> From: Mike Makonnen Date: Sat, 23 Oct 2004 08:33:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/bfe if_bfe.c if_bfereg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 08:33:10 -0000 mtm 2004-10-23 08:33:10 UTC FreeBSD src repository Modified files: sys/dev/bfe if_bfe.c if_bfereg.h Log: Locking cleanups to remove the need for a recursive mutex o Instead of locking and unlocking all over the place, use lock assertions to make certain that the bfe lock is held where necessary. o Create locked and unlocked versions of bfe_init and bfe_start. These functions can be called from outside the module and by functions within the bfe module. The calls from outside the module don't hold the bfe lock so the unlocked versions called by these functions simple obtain the bfe lock and call the locked version. - Fix a typo (scp) in the locking macros that only worked because in all the instances in which it was called the softc pointer happened to be named 'sc'. - Mark the interrupt MPSAFE Tested by: matusita, Dario Freni Silence from: -net, wpaul Revision Changes Path 1.18 +46 -58 src/sys/dev/bfe/if_bfe.c 1.5 +3 -2 src/sys/dev/bfe/if_bfereg.h From owner-cvs-src@FreeBSD.ORG Sat Oct 23 10:34:27 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B8E9D16A4CE; Sat, 23 Oct 2004 10:34:27 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9354143D41; Sat, 23 Oct 2004 10:34:27 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NAYR4D087935; Sat, 23 Oct 2004 10:34:27 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NAYR22087934; Sat, 23 Oct 2004 10:34:27 GMT (envelope-from rwatson) Message-Id: <200410231034.i9NAYR22087934@repoman.freebsd.org> From: Robert Watson Date: Sat, 23 Oct 2004 10:34:27 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/sys ktr.h src/sys/i386/i386 busdma_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 10:34:27 -0000 rwatson 2004-10-23 10:34:27 UTC FreeBSD src repository Modified files: sys/sys ktr.h sys/i386/i386 busdma_machdep.c Log: Add some basic KTR tracing to busdma on i386. This is likely not the final set of traces -- someone with more busdma background will probably want to review and expand this, as well as port to other platforms. This tracing is sufficient to identify key busdma events on i386, and in particular to draw attention to bounce buffering events that may have a substantial performance impact. Revision Changes Path 1.61 +60 -10 src/sys/i386/i386/busdma_machdep.c 1.24 +2 -1 src/sys/sys/ktr.h From owner-cvs-src@FreeBSD.ORG Sat Oct 23 11:14:31 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3BF4116A4CE; Sat, 23 Oct 2004 11:14:31 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1CF7C43D1D; Sat, 23 Oct 2004 11:14:31 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NBEVGC089571; Sat, 23 Oct 2004 11:14:31 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NBEU1K089570; Sat, 23 Oct 2004 11:14:30 GMT (envelope-from glebius) Message-Id: <200410231114.i9NBEU1K089570@repoman.freebsd.org> From: Gleb Smirnoff Date: Sat, 23 Oct 2004 11:14:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/man/man4 ng_device.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 11:14:31 -0000 glebius 2004-10-23 11:14:30 UTC FreeBSD src repository Modified files: share/man/man4 ng_device.4 Log: Make documentation up to date with recent changes. Reviewed by: ru Revision Changes Path 1.3 +19 -43 src/share/man/man4/ng_device.4 From owner-cvs-src@FreeBSD.ORG Sat Oct 23 11:20:27 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2DA5216A4CF; Sat, 23 Oct 2004 11:20:27 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0DD8743D41; Sat, 23 Oct 2004 11:20:27 +0000 (GMT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NBKQiw089749; Sat, 23 Oct 2004 11:20:26 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NBKQ4A089748; Sat, 23 Oct 2004 11:20:26 GMT (envelope-from davidxu) Message-Id: <200410231120.i9NBKQ4A089748@repoman.freebsd.org> From: David Xu Date: Sat, 23 Oct 2004 11:20:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern kern_exit.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 11:20:27 -0000 davidxu 2004-10-23 11:20:26 UTC FreeBSD src repository Modified files: sys/kern kern_exit.c Log: Remove P_STOPPED_TRACE bit if debugger dies without a chance to detach debugged process. Revision Changes Path 1.251 +1 -1 src/sys/kern/kern_exit.c From owner-cvs-src@FreeBSD.ORG Sat Oct 23 12:42:18 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D294916A4CF; Sat, 23 Oct 2004 12:42:18 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9837A43D48; Sat, 23 Oct 2004 12:42:18 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NCgIfJ092094; Sat, 23 Oct 2004 12:42:18 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NCgIs8092093; Sat, 23 Oct 2004 12:42:18 GMT (envelope-from phk) Message-Id: <200410231242.i9NCgIs8092093@repoman.freebsd.org> From: Poul-Henning Kamp Date: Sat, 23 Oct 2004 12:42:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/tools/tools/recoverdisk recoverdisk.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 12:42:19 -0000 phk 2004-10-23 12:42:18 UTC FreeBSD src repository Modified files: tools/tools/recoverdisk recoverdisk.c Log: Stop amd64 warnings. Revision Changes Path 1.3 +4 -3 src/tools/tools/recoverdisk/recoverdisk.c From owner-cvs-src@FreeBSD.ORG Sat Oct 23 12:44:19 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8E2B216A4CE; Sat, 23 Oct 2004 12:44:19 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6DBCA43D2D; Sat, 23 Oct 2004 12:44:19 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NCiJh1092201; Sat, 23 Oct 2004 12:44:19 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NCiJ2X092200; Sat, 23 Oct 2004 12:44:19 GMT (envelope-from phk) Message-Id: <200410231244.i9NCiJ2X092200@repoman.freebsd.org> From: Poul-Henning Kamp Date: Sat, 23 Oct 2004 12:44:19 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/ia64/ia64 sscdisk.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 12:44:19 -0000 phk 2004-10-23 12:44:19 UTC FreeBSD src repository Modified files: sys/ia64/ia64 sscdisk.c Log: Use bioq_takefirst() Revision Changes Path 1.31 +1 -3 src/sys/ia64/ia64/sscdisk.c From owner-cvs-src@FreeBSD.ORG Sat Oct 23 12:45:39 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D699516A4CE; Sat, 23 Oct 2004 12:45:39 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 971D043D54; Sat, 23 Oct 2004 12:45:39 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NCjdC8092310; Sat, 23 Oct 2004 12:45:39 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NCjddP092309; Sat, 23 Oct 2004 12:45:39 GMT (envelope-from phk) Message-Id: <200410231245.i9NCjddP092309@repoman.freebsd.org> From: Poul-Henning Kamp Date: Sat, 23 Oct 2004 12:45:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/pc98/pc98 wd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 12:45:40 -0000 phk 2004-10-23 12:45:39 UTC FreeBSD src repository Modified files: sys/pc98/pc98 wd.c Log: use bioq_takefirst() Revision Changes Path 1.140 +2 -5 src/sys/pc98/pc98/wd.c From owner-cvs-src@FreeBSD.ORG Sat Oct 23 15:05:46 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9866F16A4CE; Sat, 23 Oct 2004 15:05:46 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 79A1443D48; Sat, 23 Oct 2004 15:05:46 +0000 (GMT) (envelope-from mlaier@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NF5klh002937; Sat, 23 Oct 2004 15:05:46 GMT (envelope-from mlaier@repoman.freebsd.org) Received: (from mlaier@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NF5kjG002936; Sat, 23 Oct 2004 15:05:46 GMT (envelope-from mlaier) Message-Id: <200410231505.i9NF5kjG002936@repoman.freebsd.org> From: Max Laier Date: Sat, 23 Oct 2004 15:05:46 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/man/man7 firewall.7 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 15:05:46 -0000 mlaier 2004-10-23 15:05:46 UTC FreeBSD src repository Modified files: share/man/man7 firewall.7 Log: Mention pf.conf(5), pfctl(8) and pflogd(8) as ADDITIONAL READINGs. Requested by: Chris Laverdure Revision Changes Path 1.22 +7 -0 src/share/man/man7/firewall.7 From owner-cvs-src@FreeBSD.ORG Sat Oct 23 15:11:05 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D86CB16A4CE; Sat, 23 Oct 2004 15:11:05 +0000 (GMT) Received: from smtp.des.no (flood.des.no [217.116.83.31]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3077D43D48; Sat, 23 Oct 2004 15:11:05 +0000 (GMT) (envelope-from des@des.no) Received: by smtp.des.no (Pony Express, from userid 666) id 1B3145311; Sat, 23 Oct 2004 17:11:04 +0200 (CEST) Received: from dwp.des.no (des.no [80.203.228.37]) by smtp.des.no (Pony Express) with ESMTP id 85AD95310; Sat, 23 Oct 2004 17:10:57 +0200 (CEST) Received: by dwp.des.no (Postfix, from userid 2602) id 48F9AB861; Sat, 23 Oct 2004 17:10:57 +0200 (CEST) To: Poul-Henning Kamp References: <200410231242.i9NCgIs8092093@repoman.freebsd.org> From: des@des.no (=?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?=) Date: Sat, 23 Oct 2004 17:10:56 +0200 In-Reply-To: <200410231242.i9NCgIs8092093@repoman.freebsd.org> (Poul-Henning Kamp's message of "Sat, 23 Oct 2004 12:42:18 +0000 (UTC)") Message-ID: User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Checker-Version: SpamAssassin 2.64 (2004-01-11) on flood.des.no X-Spam-Level: X-Spam-Status: No, hits=0.0 required=5.0 tests=AWL autolearn=no version=2.64 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/tools/tools/recoverdisk recoverdisk.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 15:11:06 -0000 --=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Poul-Henning Kamp writes: > Log: > Stop amd64 warnings. Better patch attached. DES --=20 Dag-Erling Sm=F8rgrav - des@des.no --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=recoverdisk.diff Index: recoverdisk.c =================================================================== RCS file: /home/ncvs/src/tools/tools/recoverdisk/recoverdisk.c,v retrieving revision 1.3 diff -u -r1.3 recoverdisk.c --- recoverdisk.c 23 Oct 2004 12:42:18 -0000 1.3 +++ recoverdisk.c 23 Oct 2004 15:09:58 -0000 @@ -103,9 +103,9 @@ i = sectorsize; time(&t2); if (t1 != t2 || lp->len < BIGSIZE) { - printf("\r%13jd %7jd %13jd %3d %13jd %13jd %.8f", + printf("\r%13jd %7zd %13jd %3d %13jd %13jd %.8f", (intmax_t)lp->start, - (intmax_t)i, + i, (intmax_t)lp->len, lp->state, (intmax_t)d, @@ -125,14 +125,13 @@ else j = i; if (j != i) - printf("\nWrite error at %jd/%jd\n", - lp->start, (intmax_t)i); + printf("\nWrite error at %jd/%zd\n", + lp->start, i); lp->start += i; lp->len -= i; continue; } - printf("\n%jd %jd failed %d\n", - lp->start, (intmax_t)i, errno); + printf("\n%jd %zd failed %d\n", lp->start, i, errno); new_lump(lp->start, i, lp->state + 1); lp->start += i; lp->len -= i; --=-=-=-- From owner-cvs-src@FreeBSD.ORG Sat Oct 23 15:12:34 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9F87616A4CE; Sat, 23 Oct 2004 15:12:34 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7EA4A43D48; Sat, 23 Oct 2004 15:12:34 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NFCYxM003135; Sat, 23 Oct 2004 15:12:34 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NFCYrf003134; Sat, 23 Oct 2004 15:12:34 GMT (envelope-from rwatson) Message-Id: <200410231512.i9NFCYrf003134@repoman.freebsd.org> From: Robert Watson Date: Sat, 23 Oct 2004 15:12:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/security/mac_test mac_test.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 15:12:34 -0000 rwatson 2004-10-23 15:12:34 UTC FreeBSD src repository Modified files: sys/security/mac_test mac_test.c Log: /%x/%s/ -- mismerged DEBUGGER() printf() format stirng from the TrustedBSD branch. Submitted by: bde Revision Changes Path 1.50 +1 -1 src/sys/security/mac_test/mac_test.c From owner-cvs-src@FreeBSD.ORG Sat Oct 23 15:14:09 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4994716A4CE; Sat, 23 Oct 2004 15:14:09 +0000 (GMT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9DF4543D39; Sat, 23 Oct 2004 15:14:08 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.13.1/8.13.1) with ESMTP id i9NFE5Nv075619; Sat, 23 Oct 2004 17:14:05 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: des@des.no (=?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?=) From: "Poul-Henning Kamp" In-Reply-To: Your message of "Sat, 23 Oct 2004 17:10:56 +0200." Date: Sat, 23 Oct 2004 17:14:05 +0200 Message-ID: <75618.1098544445@critter.freebsd.dk> Sender: phk@critter.freebsd.dk cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/tools/tools/recoverdisk recoverdisk.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 15:14:09 -0000 Go for it. In message , =?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?= writes: >--=-=-= >Content-Type: text/plain; charset=iso-8859-1 >Content-Transfer-Encoding: quoted-printable > >Poul-Henning Kamp writes: >> Log: >> Stop amd64 warnings. > >Better patch attached. > >DES >--=20 >Dag-Erling Sm=F8rgrav - des@des.no > > >--=-=-= >Content-Type: text/x-patch >Content-Disposition: attachment; filename=recoverdisk.diff > >Index: recoverdisk.c >=================================================================== >RCS file: /home/ncvs/src/tools/tools/recoverdisk/recoverdisk.c,v >retrieving revision 1.3 >diff -u -r1.3 recoverdisk.c >--- recoverdisk.c 23 Oct 2004 12:42:18 -0000 1.3 >+++ recoverdisk.c 23 Oct 2004 15:09:58 -0000 >@@ -103,9 +103,9 @@ > i = sectorsize; > time(&t2); > if (t1 != t2 || lp->len < BIGSIZE) { >- printf("\r%13jd %7jd %13jd %3d %13jd %13jd %.8f", >+ printf("\r%13jd %7zd %13jd %3d %13jd %13jd %.8f", > (intmax_t)lp->start, >- (intmax_t)i, >+ i, > (intmax_t)lp->len, > lp->state, > (intmax_t)d, >@@ -125,14 +125,13 @@ > else > j = i; > if (j != i) >- printf("\nWrite error at %jd/%jd\n", >- lp->start, (intmax_t)i); >+ printf("\nWrite error at %jd/%zd\n", >+ lp->start, i); > lp->start += i; > lp->len -= i; > continue; > } >- printf("\n%jd %jd failed %d\n", >- lp->start, (intmax_t)i, errno); >+ printf("\n%jd %zd failed %d\n", lp->start, i, errno); > new_lump(lp->start, i, lp->state + 1); > lp->start += i; > lp->len -= i; > >--=-=-=-- > -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-cvs-src@FreeBSD.ORG Sat Oct 23 15:43:21 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 195DF16A4CE; Sat, 23 Oct 2004 15:43:21 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0D69143D41; Sat, 23 Oct 2004 15:43:21 +0000 (GMT) (envelope-from simokawa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NFhKnR004090; Sat, 23 Oct 2004 15:43:20 GMT (envelope-from simokawa@repoman.freebsd.org) Received: (from simokawa@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NFhKax004089; Sat, 23 Oct 2004 15:43:20 GMT (envelope-from simokawa) Message-Id: <200410231543.i9NFhKax004089@repoman.freebsd.org> From: Hidetoshi Shimokawa Date: Sat, 23 Oct 2004 15:43:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/lib/libc/net Makefile.inc eui64.3 eui64.c src/sys/sys eui64.h src/share/man/man5 Makefile eui64.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 15:43:21 -0000 simokawa 2004-10-23 15:43:20 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) lib/libc/net Makefile.inc share/man/man5 Makefile Added files: (Branch: RELENG_4) lib/libc/net eui64.c eui64.3 sys/sys eui64.h share/man/man5 eui64.5 Log: MFC: Add support for eui64(5) to libc. Revision Changes Path 1.36.2.6 +5 -3 src/lib/libc/net/Makefile.inc 1.3.6.1 +230 -0 src/lib/libc/net/eui64.3 (new) 1.2.6.1 +311 -0 src/lib/libc/net/eui64.c (new) 1.27.2.14 +2 -1 src/share/man/man5/Makefile 1.2.6.1 +110 -0 src/share/man/man5/eui64.5 (new) 1.1.6.1 +57 -0 src/sys/sys/eui64.h (new) From owner-cvs-src@FreeBSD.ORG Sat Oct 23 15:50:37 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BD65D16A4CE; Sat, 23 Oct 2004 15:50:37 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 90EA543D4C; Sat, 23 Oct 2004 15:50:37 +0000 (GMT) (envelope-from simokawa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NFobKd004358; Sat, 23 Oct 2004 15:50:37 GMT (envelope-from simokawa@repoman.freebsd.org) Received: (from simokawa@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NFobf3004357; Sat, 23 Oct 2004 15:50:37 GMT (envelope-from simokawa) Message-Id: <200410231550.i9NFobf3004357@repoman.freebsd.org> From: Hidetoshi Shimokawa Date: Sat, 23 Oct 2004 15:50:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/usr.sbin/dconschat dconschat.8 dconschat.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 15:50:37 -0000 simokawa 2004-10-23 15:50:37 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) usr.sbin/dconschat dconschat.8 dconschat.c Log: MFC: - Normalize polling interval while the target is offline. - eui64(5) support. - Invalidate dcons buffer address if the magic is wrong. - Manpage fix. Revision Changes Path 1.2.2.2 +140 -63 src/usr.sbin/dconschat/dconschat.8 1.4.2.2 +19 -9 src/usr.sbin/dconschat/dconschat.c From owner-cvs-src@FreeBSD.ORG Sat Oct 23 15:58:50 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D1B1316A4CE; Sat, 23 Oct 2004 15:58:50 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id AFBC343D39; Sat, 23 Oct 2004 15:58:50 +0000 (GMT) (envelope-from des@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NFwo71004630; Sat, 23 Oct 2004 15:58:50 GMT (envelope-from des@repoman.freebsd.org) Received: (from des@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NFwo6J004629; Sat, 23 Oct 2004 15:58:50 GMT (envelope-from des) Message-Id: <200410231558.i9NFwo6J004629@repoman.freebsd.org> From: Dag-Erling Smorgrav Date: Sat, 23 Oct 2004 15:58:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/tools/tools/recoverdisk recoverdisk.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 15:58:51 -0000 des 2004-10-23 15:58:50 UTC FreeBSD src repository Modified files: tools/tools/recoverdisk recoverdisk.c Log: Use %zu to format size_t instead of %jd and an intmax_t cast. Approved by: hamlet Revision Changes Path 1.4 +5 -6 src/tools/tools/recoverdisk/recoverdisk.c From owner-cvs-src@FreeBSD.ORG Sat Oct 23 18:35:35 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C774116A4CE; Sat, 23 Oct 2004 18:35:35 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A676443D46; Sat, 23 Oct 2004 18:35:35 +0000 (GMT) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NIZZO5016091; Sat, 23 Oct 2004 18:35:35 GMT (envelope-from andre@repoman.freebsd.org) Received: (from andre@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NIZZ2b016090; Sat, 23 Oct 2004 18:35:35 GMT (envelope-from andre) Message-Id: <200410231835.i9NIZZ2b016090@repoman.freebsd.org> From: Andre Oppermann Date: Sat, 23 Oct 2004 18:35:35 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/man/man5 rc.conf.5 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 18:35:35 -0000 andre 2004-10-23 18:35:35 UTC FreeBSD src repository Modified files: share/man/man5 rc.conf.5 Log: Bump document date that was forgotten in the last commit. Reminded by: ru Revision Changes Path 1.232 +1 -1 src/share/man/man5/rc.conf.5 From owner-cvs-src@FreeBSD.ORG Sat Oct 23 18:37:23 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B33CC16A4CE; Sat, 23 Oct 2004 18:37:23 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 93FDA43D55; Sat, 23 Oct 2004 18:37:23 +0000 (GMT) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NIbNMo016184; Sat, 23 Oct 2004 18:37:23 GMT (envelope-from andre@repoman.freebsd.org) Received: (from andre@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NIbNY1016183; Sat, 23 Oct 2004 18:37:23 GMT (envelope-from andre) Message-Id: <200410231837.i9NIbNY1016183@repoman.freebsd.org> From: Andre Oppermann Date: Sat, 23 Oct 2004 18:37:23 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/man/man4 tcp.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 18:37:23 -0000 andre 2004-10-23 18:37:23 UTC FreeBSD src repository Modified files: share/man/man4 tcp.4 Log: Rephrase certain centences and sync description of default values to reality. Revision Changes Path 1.50 +2 -11 src/share/man/man4/tcp.4 From owner-cvs-src@FreeBSD.ORG Sat Oct 23 18:45:53 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B265416A4CE; Sat, 23 Oct 2004 18:45:53 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 912B943D1F; Sat, 23 Oct 2004 18:45:53 +0000 (GMT) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NIjraZ016489; Sat, 23 Oct 2004 18:45:53 GMT (envelope-from andre@repoman.freebsd.org) Received: (from andre@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NIjrGK016488; Sat, 23 Oct 2004 18:45:53 GMT (envelope-from andre) Message-Id: <200410231845.i9NIjrGK016488@repoman.freebsd.org> From: Andre Oppermann Date: Sat, 23 Oct 2004 18:45:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/share/man/man4 inet.4 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 18:45:53 -0000 andre 2004-10-23 18:45:53 UTC FreeBSD src repository Modified files: share/man/man4 inet.4 Log: o Remove entire section talking about RTF_PRCLONING that got nuked in 5.2 already. o Better description of IP fastforwarding. It can do the full thing now including firewalling. o Reword the description of ICMP redirects. o Add references to route(4) and pfil(9). Revision Changes Path 1.33 +25 -76 src/share/man/man4/inet.4 From owner-cvs-src@FreeBSD.ORG Sat Oct 23 18:52:06 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B445616A4CE; Sat, 23 Oct 2004 18:52:06 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9411E43D1D; Sat, 23 Oct 2004 18:52:06 +0000 (GMT) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NIq6Vd016702; Sat, 23 Oct 2004 18:52:06 GMT (envelope-from andre@repoman.freebsd.org) Received: (from andre@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NIq6Kj016701; Sat, 23 Oct 2004 18:52:06 GMT (envelope-from andre) Message-Id: <200410231852.i9NIq6Kj016701@repoman.freebsd.org> From: Andre Oppermann Date: Sat, 23 Oct 2004 18:52:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern uipc_domain.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 18:52:06 -0000 andre 2004-10-23 18:52:06 UTC FreeBSD src repository Modified files: sys/kern uipc_domain.c Log: Aquire GIANT in pf_proto_[un]register() before manipulating the protosw. Revision Changes Path 1.38 +27 -5 src/sys/kern/uipc_domain.c From owner-cvs-src@FreeBSD.ORG Sat Oct 23 18:56:39 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E0A3416A4CE; Sat, 23 Oct 2004 18:56:39 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C1CA843D2F; Sat, 23 Oct 2004 18:56:39 +0000 (GMT) (envelope-from le@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NIudG4016905; Sat, 23 Oct 2004 18:56:39 GMT (envelope-from le@repoman.freebsd.org) Received: (from le@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NIudDm016904; Sat, 23 Oct 2004 18:56:39 GMT (envelope-from le) Message-Id: <200410231856.i9NIudDm016904@repoman.freebsd.org> From: Lukas Ertl Date: Sat, 23 Oct 2004 18:56:39 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Subject: cvs commit: src/sys/dev/if_ndis if_ndis.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 18:56:40 -0000 le 2004-10-23 18:56:39 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) sys/dev/if_ndis if_ndis.c Log: MFC rev. 1.71: Drop the NDIS lock before returning from ndis_start(). PR: i386/72795 Submitted by: Frank Mayhar Approved by: re@ (scottl) Revision Changes Path 1.69.2.2 +3 -1 src/sys/dev/if_ndis/if_ndis.c From owner-cvs-src@FreeBSD.ORG Sat Oct 23 18:58:54 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 47C5916A4CE; Sat, 23 Oct 2004 18:58:54 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 26F5B43D39; Sat, 23 Oct 2004 18:58:54 +0000 (GMT) (envelope-from le@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NIws8T017047; Sat, 23 Oct 2004 18:58:54 GMT (envelope-from le@repoman.freebsd.org) Received: (from le@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NIwsJo017046; Sat, 23 Oct 2004 18:58:54 GMT (envelope-from le) Message-Id: <200410231858.i9NIwsJo017046@repoman.freebsd.org> From: Lukas Ertl Date: Sat, 23 Oct 2004 18:58:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5_3 Subject: cvs commit: src/sys/dev/if_ndis if_ndis.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 18:58:54 -0000 le 2004-10-23 18:58:53 UTC FreeBSD src repository Modified files: (Branch: RELENG_5_3) sys/dev/if_ndis if_ndis.c Log: MFC rev. 1.71: Drop the NDIS lock before returning from ndis_start(). PR: i386/72795 Submitted by: Frank Mayhar Approved by: re@ (scottl) Revision Changes Path 1.69.2.1.2.1 +3 -1 src/sys/dev/if_ndis/if_ndis.c From owner-cvs-src@FreeBSD.ORG Sat Oct 23 19:03:26 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 70B1916A4CE; Sat, 23 Oct 2004 19:03:26 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4F7BF43D2D; Sat, 23 Oct 2004 19:03:26 +0000 (GMT) (envelope-from le@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NJ3QMZ017255; Sat, 23 Oct 2004 19:03:26 GMT (envelope-from le@repoman.freebsd.org) Received: (from le@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NJ3QfO017254; Sat, 23 Oct 2004 19:03:26 GMT (envelope-from le) Message-Id: <200410231903.i9NJ3QfO017254@repoman.freebsd.org> From: Lukas Ertl Date: Sat, 23 Oct 2004 19:03:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Subject: cvs commit: src/sys/dev/ata ata-card.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 19:03:26 -0000 le 2004-10-23 19:03:26 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) sys/dev/ata ata-card.c Log: MFC rev. 1.27: Return the unit number of a channel instead of a hardcoded '1' from the ATA pccard locking function. This makes pccard devices like Compact Flash cards work again. PR: kern/72805 Submitted by: James E. Flemer Approved by: re@ (scottl) Revision Changes Path 1.25.2.2 +1 -1 src/sys/dev/ata/ata-card.c From owner-cvs-src@FreeBSD.ORG Sat Oct 23 19:05:18 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DE75516A4D0; Sat, 23 Oct 2004 19:05:17 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id BA81643D1F; Sat, 23 Oct 2004 19:05:17 +0000 (GMT) (envelope-from le@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NJ5HOW017411; Sat, 23 Oct 2004 19:05:17 GMT (envelope-from le@repoman.freebsd.org) Received: (from le@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NJ5HlU017410; Sat, 23 Oct 2004 19:05:17 GMT (envelope-from le) Message-Id: <200410231905.i9NJ5HlU017410@repoman.freebsd.org> From: Lukas Ertl Date: Sat, 23 Oct 2004 19:05:17 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5_3 Subject: cvs commit: src/sys/dev/ata ata-card.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 19:05:18 -0000 le 2004-10-23 19:05:17 UTC FreeBSD src repository Modified files: (Branch: RELENG_5_3) sys/dev/ata ata-card.c Log: MFC rev. 1.27: Return the unit number of a channel instead of a hardcoded '1' from the ATA pccard locking function. This makes pccard devices like Compact Flash cards work again. PR: kern/72805 Submitted by: James E. Flemer Approved by: re@ (scottl) Revision Changes Path 1.25.2.1.2.1 +1 -1 src/sys/dev/ata/ata-card.c From owner-cvs-src@FreeBSD.ORG Sat Oct 23 19:06:43 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6BBEA16A4CE; Sat, 23 Oct 2004 19:06:43 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 609D443D45; Sat, 23 Oct 2004 19:06:43 +0000 (GMT) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NJ6h4X017496; Sat, 23 Oct 2004 19:06:43 GMT (envelope-from andre@repoman.freebsd.org) Received: (from andre@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NJ6h8q017495; Sat, 23 Oct 2004 19:06:43 GMT (envelope-from andre) Message-Id: <200410231906.i9NJ6h8q017495@repoman.freebsd.org> From: Andre Oppermann Date: Sat, 23 Oct 2004 19:06:43 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern uipc_socket.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 19:06:43 -0000 andre 2004-10-23 19:06:43 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: socreate() does an early abort if either the protocol cannot be found, or pru_attach is NULL. With loadable protocols the SPACER dummy protocols have valid function pointers for all methods to functions returning just EOPNOTSUPP. Thus the early abort check would not detect immediately that attach is not supported for this protocol. Instead it would correctly get the EOPNOTSUPP error later on when it calls the protocol specific attach function. Add testing against the pru_attach_notsupp() function pointer to the early abort check as well. Revision Changes Path 1.215 +2 -1 src/sys/kern/uipc_socket.c From owner-cvs-src@FreeBSD.ORG Sat Oct 23 19:08:15 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 20D0C16A4CE; Sat, 23 Oct 2004 19:08:15 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 00A8443D2D; Sat, 23 Oct 2004 19:08:15 +0000 (GMT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NJ8Etw017550; Sat, 23 Oct 2004 19:08:14 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NJ8EMS017549; Sat, 23 Oct 2004 19:08:14 GMT (envelope-from scottl) Message-Id: <200410231908.i9NJ8EMS017549@repoman.freebsd.org> From: Scott Long Date: Sat, 23 Oct 2004 19:08:14 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Subject: cvs commit: src/sys/dev/aac aac_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 19:08:15 -0000 scottl 2004-10-23 19:08:14 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) sys/dev/aac aac_pci.c Log: MFC: Add Id's for the 21610SA Adapter. Approved by: re Revision Changes Path 1.48.2.1 +2 -0 src/sys/dev/aac/aac_pci.c From owner-cvs-src@FreeBSD.ORG Sat Oct 23 19:18:06 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2AE6816A4CE; Sat, 23 Oct 2004 19:18:06 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 081F943D1F; Sat, 23 Oct 2004 19:18:06 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NJI5jX017933; Sat, 23 Oct 2004 19:18:05 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NJI5Zc017932; Sat, 23 Oct 2004 19:18:05 GMT (envelope-from rwatson) Message-Id: <200410231918.i9NJI5Zc017932@repoman.freebsd.org> From: Robert Watson Date: Sat, 23 Oct 2004 19:18:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5_3 Subject: cvs commit: src/sys/net if.c if_var.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 19:18:06 -0000 rwatson 2004-10-23 19:18:05 UTC FreeBSD src repository Modified files: (Branch: RELENG_5_3) sys/net if.c if_var.h Log: Merge if.c:1.210, if_var.h:1.85 from HEAD to RELENG_5_3: Define IFF_LOCKGIANT() and IFF_UNLOCKGIANT() macros, which conditionally acquire Giant if the passed interface has IFF_NEEDSGIANT set on it. Modify calls into (ifp)->if_ioctl() in if.c to use these macros in order to ensure that Giant is held. MFC after: 3 days Bumped into by: jmg Approved by: re (kensmith, scottl) Revision Changes Path 1.199.2.7.2.1 +30 -2 src/sys/net/if.c 1.84.4.1 +10 -0 src/sys/net/if_var.h From owner-cvs-src@FreeBSD.ORG Sat Oct 23 19:22:23 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 36A4E16A4CE; Sat, 23 Oct 2004 19:22:23 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1624343D46; Sat, 23 Oct 2004 19:22:23 +0000 (GMT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NJMM75018077; Sat, 23 Oct 2004 19:22:22 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NJMMdO018076; Sat, 23 Oct 2004 19:22:22 GMT (envelope-from scottl) Message-Id: <200410231922.i9NJMMdO018076@repoman.freebsd.org> From: Scott Long Date: Sat, 23 Oct 2004 19:22:22 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5_3 Subject: cvs commit: src/sys/dev/aac aac_pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 19:22:23 -0000 scottl 2004-10-23 19:22:22 UTC FreeBSD src repository Modified files: (Branch: RELENG_5_3) sys/dev/aac aac_pci.c Log: MFC: PCI Id for the 21610SA Approved by: re Revision Changes Path 1.48.4.1 +2 -0 src/sys/dev/aac/aac_pci.c From owner-cvs-src@FreeBSD.ORG Sat Oct 23 19:54:18 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9542916A4CE; Sat, 23 Oct 2004 19:54:18 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7564C43D31; Sat, 23 Oct 2004 19:54:18 +0000 (GMT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NJsI3S019139; Sat, 23 Oct 2004 19:54:18 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NJsIYN019138; Sat, 23 Oct 2004 19:54:18 GMT (envelope-from scottl) Message-Id: <200410231954.i9NJsIYN019138@repoman.freebsd.org> From: Scott Long Date: Sat, 23 Oct 2004 19:54:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/release/scripts print-cdrom-packages.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 19:54:18 -0000 scottl 2004-10-23 19:54:18 UTC FreeBSD src repository Modified files: release/scripts print-cdrom-packages.sh Log: Due to space constraints, use gnome2-lite for i386 and gnome2 for everything else. Also add ltmdm to i386 by popular request. Revision Changes Path 1.69 +6 -1 src/release/scripts/print-cdrom-packages.sh From owner-cvs-src@FreeBSD.ORG Sat Oct 23 19:56:29 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4453F16A4CE; Sat, 23 Oct 2004 19:56:29 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5609743D39; Sat, 23 Oct 2004 19:56:28 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i9NJuRG5054305; Sat, 23 Oct 2004 22:56:27 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 59723-18; Sat, 23 Oct 2004 22:56:26 +0300 (EEST) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i9NJuJ2t054295; Sat, 23 Oct 2004 22:56:22 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.1/8.13.1) id i9NJtwqb030357; Sat, 23 Oct 2004 22:55:58 +0300 (EEST) (envelope-from ru) Date: Sat, 23 Oct 2004 22:55:58 +0300 From: Ruslan Ermilov To: Dag-Erling Smorgrav Message-ID: <20041023195558.GC47119@ip.net.ua> References: <200410231558.i9NFwo6J004629@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Bu8it7iiRSEf40bY" Content-Disposition: inline In-Reply-To: <200410231558.i9NFwo6J004629@repoman.freebsd.org> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new at ip.net.ua cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/tools/tools/recoverdisk recoverdisk.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 19:56:29 -0000 --Bu8it7iiRSEf40bY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Oct 23, 2004 at 03:58:50PM +0000, Dag-Erling Smorgrav wrote: > des 2004-10-23 15:58:50 UTC >=20 > FreeBSD src repository >=20 > Modified files: > tools/tools/recoverdisk recoverdisk.c=20 > Log: > Use %zu to format size_t instead of %jd and an intmax_t cast. > =20 > Approved by: hamlet > =20 Feel like adding this to aliases on hub? :-) Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --Bu8it7iiRSEf40bY Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBerdOqRfpzJluFF4RAmJNAKCQHzC9ADUEh6/j3QjLhqMTE89MBACgi4VH iyvSuqYG3Q/nrSqGuWvGWCA= =niPR -----END PGP SIGNATURE----- --Bu8it7iiRSEf40bY-- From owner-cvs-src@FreeBSD.ORG Sat Oct 23 19:56:30 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 29AC516A4D0; Sat, 23 Oct 2004 19:56:30 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0958843D39; Sat, 23 Oct 2004 19:56:30 +0000 (GMT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NJuTdK019285; Sat, 23 Oct 2004 19:56:29 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NJuTvo019284; Sat, 23 Oct 2004 19:56:29 GMT (envelope-from scottl) Message-Id: <200410231956.i9NJuTvo019284@repoman.freebsd.org> From: Scott Long Date: Sat, 23 Oct 2004 19:56:29 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Subject: cvs commit: src/release/scripts print-cdrom-packages.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 19:56:30 -0000 scottl 2004-10-23 19:56:29 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) release/scripts print-cdrom-packages.sh Log: MFC: use gnome2-lite for x86, add ltmdm. Approved by: re Revision Changes Path 1.64.2.4 +6 -1 src/release/scripts/print-cdrom-packages.sh From owner-cvs-src@FreeBSD.ORG Sat Oct 23 19:57:27 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0651416A4CE; Sat, 23 Oct 2004 19:57:27 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D87E843D1F; Sat, 23 Oct 2004 19:57:26 +0000 (GMT) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NJvQwK019334; Sat, 23 Oct 2004 19:57:26 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NJvQbH019333; Sat, 23 Oct 2004 19:57:26 GMT (envelope-from scottl) Message-Id: <200410231957.i9NJvQbH019333@repoman.freebsd.org> From: Scott Long Date: Sat, 23 Oct 2004 19:57:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5_3 Subject: cvs commit: src/release/scripts print-cdrom-packages.sh X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 19:57:27 -0000 scottl 2004-10-23 19:57:26 UTC FreeBSD src repository Modified files: (Branch: RELENG_5_3) release/scripts print-cdrom-packages.sh Log: MFC: Use gnome2-lite for x86, add ltmdm. Approved by: re Revision Changes Path 1.64.2.2.2.2 +6 -1 src/release/scripts/print-cdrom-packages.sh From owner-cvs-src@FreeBSD.ORG Sat Oct 23 19:58:28 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 38F8716A4CE; Sat, 23 Oct 2004 19:58:28 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2DED043D31; Sat, 23 Oct 2004 19:58:28 +0000 (GMT) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NJwSR2019462; Sat, 23 Oct 2004 19:58:28 GMT (envelope-from kensmith@repoman.freebsd.org) Received: (from kensmith@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NJwS2I019461; Sat, 23 Oct 2004 19:58:28 GMT (envelope-from kensmith) Message-Id: <200410231958.i9NJwS2I019461@repoman.freebsd.org> From: Ken Smith Date: Sat, 23 Oct 2004 19:58:28 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Subject: cvs commit: src/sys/amd64/conf GENERIC SMP src/sys/i386/conf GENERIC SMP X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 19:58:28 -0000 kensmith 2004-10-23 19:58:28 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) sys/amd64/conf GENERIC sys/i386/conf GENERIC Added files: (Branch: RELENG_5) sys/amd64/conf SMP sys/i386/conf SMP Log: To be safe for installs as well as providing the faster kernel for the majority of users shift GENERIC back to UP instead of SMP. Provide a config file people with MP boxes can use. Discussed by: re@ Approved by: re (scottl) Revision Changes Path 1.421.2.5 +0 -2 src/sys/amd64/conf/GENERIC 1.1.2.1 +9 -0 src/sys/amd64/conf/SMP (new) 1.413.2.7 +0 -2 src/sys/i386/conf/GENERIC 1.5.2.1 +9 -0 src/sys/i386/conf/SMP (new) From owner-cvs-src@FreeBSD.ORG Sat Oct 23 20:00:51 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1C4FA16A4D0; Sat, 23 Oct 2004 20:00:51 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 966D643D3F; Sat, 23 Oct 2004 20:00:44 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NK0iME019543; Sat, 23 Oct 2004 20:00:44 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NK0iAN019542; Sat, 23 Oct 2004 20:00:44 GMT (envelope-from rwatson) Message-Id: <200410232000.i9NK0iAN019542@repoman.freebsd.org> From: Robert Watson Date: Sat, 23 Oct 2004 20:00:44 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern syscalls.master X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 20:00:51 -0000 rwatson 2004-10-23 20:00:43 UTC FreeBSD src repository Modified files: sys/kern syscalls.master Log: Add system call place-holders for the following system calls implementing Sun's BSM Audit API on FreeBSD: audit() auditon() getauid() setauid() getaudit() setaudit() getaudit_addr() setaudit_addr() auditctl() Submitted by: Wayne Salamon Obtained from: TrustedBSD Project Revision Changes Path 1.178 +11 -0 src/sys/kern/syscalls.master From owner-cvs-src@FreeBSD.ORG Sat Oct 23 20:01:32 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C99C516A4CE; Sat, 23 Oct 2004 20:01:32 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A86AB43D1D; Sat, 23 Oct 2004 20:01:32 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NK1Wdv019667; Sat, 23 Oct 2004 20:01:32 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NK1Wr2019666; Sat, 23 Oct 2004 20:01:32 GMT (envelope-from rwatson) Message-Id: <200410232001.i9NK1Wr2019666@repoman.freebsd.org> From: Robert Watson Date: Sat, 23 Oct 2004 20:01:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern init_sysent.c syscalls.c src/sys/sys syscall.h syscall.mk sysproto.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 20:01:33 -0000 rwatson 2004-10-23 20:01:32 UTC FreeBSD src repository Modified files: sys/kern init_sysent.c syscalls.c sys/sys syscall.h syscall.mk sysproto.h Log: Rebuild from syscalls.master:1.178. Revision Changes Path 1.178 +10 -1 src/sys/kern/init_sysent.c 1.164 +10 -1 src/sys/kern/syscalls.c 1.162 +11 -2 src/sys/sys/syscall.h 1.117 +11 -2 src/sys/sys/syscall.mk 1.161 +43 -1 src/sys/sys/sysproto.h From owner-cvs-src@FreeBSD.ORG Sat Oct 23 20:04:00 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9EC5716A4CE; Sat, 23 Oct 2004 20:04:00 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 929B343D49; Sat, 23 Oct 2004 20:04:00 +0000 (GMT) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NK40V1019754; Sat, 23 Oct 2004 20:04:00 GMT (envelope-from kensmith@repoman.freebsd.org) Received: (from kensmith@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NK40v2019753; Sat, 23 Oct 2004 20:04:00 GMT (envelope-from kensmith) Message-Id: <200410232004.i9NK40v2019753@repoman.freebsd.org> From: Ken Smith Date: Sat, 23 Oct 2004 20:04:00 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5_3 Subject: cvs commit: src/sys/amd64/conf GENERIC SMP src/sys/i386/conf GENERIC SMP X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 20:04:00 -0000 kensmith 2004-10-23 20:04:00 UTC FreeBSD src repository Modified files: (Branch: RELENG_5_3) sys/amd64/conf GENERIC sys/i386/conf GENERIC Added files: (Branch: RELENG_5_3) sys/amd64/conf SMP sys/i386/conf SMP Log: MFR5 shifting GENERIC back to UP instead of MP which should be a little safer for installs and gives the majority of users the correct (faster) kernel. Revs MFR5'd: > Revision Changes Path > 1.421.2.5 +0 -2 src/sys/amd64/conf/GENERIC > 1.1.2.1 +9 -0 src/sys/amd64/conf/SMP (new) > 1.413.2.7 +0 -2 src/sys/i386/conf/GENERIC > 1.5.2.1 +9 -0 src/sys/i386/conf/SMP (new) Discussed by: re@ Approved by: re (scottl) Revision Changes Path 1.421.2.4.2.1 +0 -2 src/sys/amd64/conf/GENERIC 1.1.4.1 +9 -0 src/sys/amd64/conf/SMP (new) 1.413.2.6.2.1 +0 -2 src/sys/i386/conf/GENERIC 1.5.4.1 +9 -0 src/sys/i386/conf/SMP (new) From owner-cvs-src@FreeBSD.ORG Sat Oct 23 20:04:56 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B286216A4CE; Sat, 23 Oct 2004 20:04:56 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 91C6A43D49; Sat, 23 Oct 2004 20:04:56 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NK4u9G019797; Sat, 23 Oct 2004 20:04:56 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NK4u9C019796; Sat, 23 Oct 2004 20:04:56 GMT (envelope-from rwatson) Message-Id: <200410232004.i9NK4u9C019796@repoman.freebsd.org> From: Robert Watson Date: Sat, 23 Oct 2004 20:04:56 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/compat/freebsd32 syscalls.master X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 20:04:56 -0000 rwatson 2004-10-23 20:04:56 UTC FreeBSD src repository Modified files: sys/compat/freebsd32 syscalls.master Log: 32-bit FreeBSD ABI compatibility stubs from syscalls.master:1.178. Revision Changes Path 1.42 +9 -0 src/sys/compat/freebsd32/syscalls.master From owner-cvs-src@FreeBSD.ORG Sat Oct 23 20:05:42 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7D85216A4CE; Sat, 23 Oct 2004 20:05:42 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5C97B43D5A; Sat, 23 Oct 2004 20:05:42 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NK5gYY019920; Sat, 23 Oct 2004 20:05:42 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NK5gW7019916; Sat, 23 Oct 2004 20:05:42 GMT (envelope-from rwatson) Message-Id: <200410232005.i9NK5gW7019916@repoman.freebsd.org> From: Robert Watson Date: Sat, 23 Oct 2004 20:05:42 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/compat/freebsd32 freebsd32_proto.hfreebsd32_syscall.h freebsd32_syscalls.c freebsd32_sysent.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 20:05:42 -0000 rwatson 2004-10-23 20:05:42 UTC FreeBSD src repository Modified files: sys/compat/freebsd32 freebsd32_proto.h freebsd32_syscall.h freebsd32_syscalls.c freebsd32_sysent.c Log: Rebuild from FreeBSD32 syscalls.master:1.42. Revision Changes Path 1.30 +1 -1 src/sys/compat/freebsd32/freebsd32_proto.h 1.30 +2 -2 src/sys/compat/freebsd32/freebsd32_syscall.h 1.21 +10 -1 src/sys/compat/freebsd32/freebsd32_syscalls.c 1.31 +10 -1 src/sys/compat/freebsd32/freebsd32_sysent.c From owner-cvs-src@FreeBSD.ORG Sat Oct 23 20:21:06 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1D5EA16A4CE; Sat, 23 Oct 2004 20:21:06 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id F07F943D2D; Sat, 23 Oct 2004 20:21:05 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NKL5CR020472; Sat, 23 Oct 2004 20:21:05 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NKL5aF020471; Sat, 23 Oct 2004 20:21:05 GMT (envelope-from phk) Message-Id: <200410232021.i9NKL5aF020471@repoman.freebsd.org> From: Poul-Henning Kamp Date: Sat, 23 Oct 2004 20:21:05 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern vfs_mount.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 20:21:06 -0000 phk 2004-10-23 20:21:05 UTC FreeBSD src repository Modified files: sys/kern vfs_mount.c Log: Drop Giant around the call to g_waitidle(). This is necessary to allow any geom events which need it to pick up Giant. Revision Changes Path 1.144 +2 -0 src/sys/kern/vfs_mount.c From owner-cvs-src@FreeBSD.ORG Sat Oct 23 20:22:02 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5BBAD16A4CE; Sat, 23 Oct 2004 20:22:02 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3BE9043D3F; Sat, 23 Oct 2004 20:22:02 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NKM2L6020536; Sat, 23 Oct 2004 20:22:02 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NKM2uT020535; Sat, 23 Oct 2004 20:22:02 GMT (envelope-from phk) Message-Id: <200410232022.i9NKM2uT020535@repoman.freebsd.org> From: Poul-Henning Kamp Date: Sat, 23 Oct 2004 20:22:02 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/geom geom.h src/sys/sys systm.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 20:22:02 -0000 phk 2004-10-23 20:22:02 UTC FreeBSD src repository Modified files: sys/geom geom.h sys/sys systm.h Log: Move the prototype for g_waitidle() to a more visible place. Revision Changes Path 1.86 +0 -1 src/sys/geom/geom.h 1.216 +1 -0 src/sys/sys/systm.h From owner-cvs-src@FreeBSD.ORG Sat Oct 23 20:49:18 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2CEB416A4CF; Sat, 23 Oct 2004 20:49:18 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1EC4043D46; Sat, 23 Oct 2004 20:49:18 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NKnHN2027684; Sat, 23 Oct 2004 20:49:17 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NKnHhH027683; Sat, 23 Oct 2004 20:49:17 GMT (envelope-from phk) Message-Id: <200410232049.i9NKnHhH027683@repoman.freebsd.org> From: Poul-Henning Kamp Date: Sat, 23 Oct 2004 20:49:17 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/geom geom_event.c src/sys/sys proc.h src/sys/kern subr_trap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 20:49:18 -0000 phk 2004-10-23 20:49:17 UTC FreeBSD src repository Modified files: sys/geom geom_event.c sys/sys proc.h sys/kern subr_trap.c Log: Add a new per-thread private flag: TDP_GEOM. This flag gets set whenever the thread posts an event on the GEOM event queue, and if the flag is set when the thread is prepared to return to userland from the kernel, g_waitidle() will be called to make sure that the posted events have completed. This can replace an insufficient number of g_waitidle() calls in various other places, and has the advantage of being failsafe: Any system call which does a VOP_OPEN()/VOP_CLOSE will now correctly wait for any geom events it posted as part of spoils or tastes. Assert that topology and Giant is not held in g_waitidle(). Revision Changes Path 1.51 +8 -1 src/sys/geom/geom_event.c 1.276 +7 -0 src/sys/kern/subr_trap.c 1.411 +1 -0 src/sys/sys/proc.h From owner-cvs-src@FreeBSD.ORG Sat Oct 23 20:50:07 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6CFC816A4CE; Sat, 23 Oct 2004 20:50:07 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4B24943D48; Sat, 23 Oct 2004 20:50:07 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NKo6Em027733; Sat, 23 Oct 2004 20:50:06 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NKo6Dc027732; Sat, 23 Oct 2004 20:50:06 GMT (envelope-from phk) Message-Id: <200410232050.i9NKo6Dc027732@repoman.freebsd.org> From: Poul-Henning Kamp Date: Sat, 23 Oct 2004 20:50:06 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/md md.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 20:50:07 -0000 phk 2004-10-23 20:50:06 UTC FreeBSD src repository Modified files: sys/dev/md md.c Log: Don't explicitly call g_waitidle(), it happens automagically now. Revision Changes Path 1.142 +0 -2 src/sys/dev/md/md.c From owner-cvs-src@FreeBSD.ORG Sat Oct 23 20:51:20 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B22B016A4CE; Sat, 23 Oct 2004 20:51:20 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 90B6A43D64; Sat, 23 Oct 2004 20:51:20 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NKpKjc027872; Sat, 23 Oct 2004 20:51:20 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NKpKAA027871; Sat, 23 Oct 2004 20:51:20 GMT (envelope-from phk) Message-Id: <200410232051.i9NKpKAA027871@repoman.freebsd.org> From: Poul-Henning Kamp Date: Sat, 23 Oct 2004 20:51:20 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/geom geom_ctl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 20:51:20 -0000 phk 2004-10-23 20:51:20 UTC FreeBSD src repository Modified files: sys/geom geom_ctl.c Log: Don't call g_waitidle(), it happens automagically now. Revision Changes Path 1.33 +3 -2 src/sys/geom/geom_ctl.c From owner-cvs-src@FreeBSD.ORG Sat Oct 23 20:51:48 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F213816A4CE; Sat, 23 Oct 2004 20:51:47 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D2A9843D1D; Sat, 23 Oct 2004 20:51:47 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NKplPD027906; Sat, 23 Oct 2004 20:51:47 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NKpliw027905; Sat, 23 Oct 2004 20:51:47 GMT (envelope-from phk) Message-Id: <200410232051.i9NKpliw027905@repoman.freebsd.org> From: Poul-Henning Kamp Date: Sat, 23 Oct 2004 20:51:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/geom geom_dev.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 20:51:48 -0000 phk 2004-10-23 20:51:47 UTC FreeBSD src repository Modified files: sys/geom geom_dev.c Log: Don't call g_waitidle(), it happens automagically now. Revision Changes Path 1.82 +0 -3 src/sys/geom/geom_dev.c From owner-cvs-src@FreeBSD.ORG Sat Oct 23 20:52:15 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6CD3416A4CE; Sat, 23 Oct 2004 20:52:15 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4CC1A43D1F; Sat, 23 Oct 2004 20:52:15 +0000 (GMT) (envelope-from phk@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NKqFsM027966; Sat, 23 Oct 2004 20:52:15 GMT (envelope-from phk@repoman.freebsd.org) Received: (from phk@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NKqF92027965; Sat, 23 Oct 2004 20:52:15 GMT (envelope-from phk) Message-Id: <200410232052.i9NKqF92027965@repoman.freebsd.org> From: Poul-Henning Kamp Date: Sat, 23 Oct 2004 20:52:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/geom geom_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 20:52:15 -0000 phk 2004-10-23 20:52:15 UTC FreeBSD src repository Modified files: sys/geom geom_subr.c Log: Don't call g_waitidle(), it happens automagically now. Revision Changes Path 1.85 +0 -1 src/sys/geom/geom_subr.c From owner-cvs-src@FreeBSD.ORG Sat Oct 23 21:34:42 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1A27B16A4CE; Sat, 23 Oct 2004 21:34:42 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id EC96543D1D; Sat, 23 Oct 2004 21:34:41 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NLYfXs029320; Sat, 23 Oct 2004 21:34:41 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NLYfZO029319; Sat, 23 Oct 2004 21:34:41 GMT (envelope-from ru) Message-Id: <200410232134.i9NLYfZO029319@repoman.freebsd.org> From: Ruslan Ermilov Date: Sat, 23 Oct 2004 21:34:41 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.bin/make compat.c job.c job.h main.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 21:34:42 -0000 ru 2004-10-23 21:34:41 UTC FreeBSD src repository Modified files: usr.bin/make compat.c job.c job.h main.c Log: Expand the scope of the .SHELL specification to also cover the compat mode of operation and the != operator. While here, fixed a bug in the .SHELL directive processing when only the name= attribute is specified and no built-in shell matches this name, causing null pointer dereference. Obtained from: NetBSD (except for bugs) Revision Changes Path 1.38 +5 -2 src/usr.bin/make/compat.c 1.51 +33 -18 src/usr.bin/make/job.c 1.22 +4 -0 src/usr.bin/make/job.h 1.92 +4 -10 src/usr.bin/make/main.c From owner-cvs-src@FreeBSD.ORG Sat Oct 23 21:36:55 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8329D16A4CE; Sat, 23 Oct 2004 21:36:55 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6370B43D1D; Sat, 23 Oct 2004 21:36:55 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NLatXL029476; Sat, 23 Oct 2004 21:36:55 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NLatSQ029475; Sat, 23 Oct 2004 21:36:55 GMT (envelope-from ru) Message-Id: <200410232136.i9NLatSQ029475@repoman.freebsd.org> From: Ruslan Ermilov Date: Sat, 23 Oct 2004 21:36:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.bin/make job.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 21:36:55 -0000 ru 2004-10-23 21:36:55 UTC FreeBSD src repository Modified files: usr.bin/make job.c Log: "unset verbose" is 13 characters, not 10. Revision Changes Path 1.52 +1 -1 src/usr.bin/make/job.c From owner-cvs-src@FreeBSD.ORG Sat Oct 23 21:38:58 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9E59A16A4CE; Sat, 23 Oct 2004 21:38:58 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7DF6B43D1F; Sat, 23 Oct 2004 21:38:58 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NLcwNE029552; Sat, 23 Oct 2004 21:38:58 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NLcwTQ029551; Sat, 23 Oct 2004 21:38:58 GMT (envelope-from ru) Message-Id: <200410232138.i9NLcwTQ029551@repoman.freebsd.org> From: Ruslan Ermilov Date: Sat, 23 Oct 2004 21:38:58 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/tools/regression/usr.bin/make Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 21:38:58 -0000 ru 2004-10-23 21:38:58 UTC FreeBSD src repository Modified files: tools/regression/usr.bin/make Makefile Log: Add a regression test for the alternate shell specification. Revision Changes Path 1.21 +10 -0 src/tools/regression/usr.bin/make/Makefile From owner-cvs-src@FreeBSD.ORG Sat Oct 23 22:03:32 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ED12C16A4CE; Sat, 23 Oct 2004 22:03:31 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CCE4843D48; Sat, 23 Oct 2004 22:03:31 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NM3VBu030691; Sat, 23 Oct 2004 22:03:31 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NM3Vis030690; Sat, 23 Oct 2004 22:03:31 GMT (envelope-from rwatson) Message-Id: <200410232203.i9NM3Vis030690@repoman.freebsd.org> From: Robert Watson Date: Sat, 23 Oct 2004 22:03:31 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/tools/regression/netinet/tcpconnect tcpconnect.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 22:03:32 -0000 rwatson 2004-10-23 22:03:31 UTC FreeBSD src repository Modified files: tools/regression/netinet/tcpconnect tcpconnect.c Log: Use errx() instead of perror()/exit() for conciseness. Suggested by: ru (some time ago) Revision Changes Path 1.3 +14 -25 src/tools/regression/netinet/tcpconnect/tcpconnect.c From owner-cvs-src@FreeBSD.ORG Sat Oct 23 22:07:58 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0057016A4CE; Sat, 23 Oct 2004 22:07:58 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D580A43D1D; Sat, 23 Oct 2004 22:07:57 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NM7va8030850; Sat, 23 Oct 2004 22:07:57 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NM7v78030849; Sat, 23 Oct 2004 22:07:57 GMT (envelope-from rwatson) Message-Id: <200410232207.i9NM7v78030849@repoman.freebsd.org> From: Robert Watson Date: Sat, 23 Oct 2004 22:07:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/tools/regression/netinet/tcpstream tcpstream.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 22:07:58 -0000 rwatson 2004-10-23 22:07:57 UTC FreeBSD src repository Modified files: tools/regression/netinet/tcpstream tcpstream.c Log: Use errx() instead of perror()/exit() for conciseness. Suggested by: ru (some time ago) Revision Changes Path 1.2 +14 -25 src/tools/regression/netinet/tcpstream/tcpstream.c From owner-cvs-src@FreeBSD.ORG Sat Oct 23 22:11:35 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CF8FF16A4CE; Sat, 23 Oct 2004 22:11:35 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id AE20E43D45; Sat, 23 Oct 2004 22:11:35 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NMBZKl030995; Sat, 23 Oct 2004 22:11:35 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NMBZO9030994; Sat, 23 Oct 2004 22:11:35 GMT (envelope-from rwatson) Message-Id: <200410232211.i9NMBZO9030994@repoman.freebsd.org> From: Robert Watson Date: Sat, 23 Oct 2004 22:11:35 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/tools/regression/sockets/accept_fd_leak accept_fd_leak.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 22:11:36 -0000 rwatson 2004-10-23 22:11:35 UTC FreeBSD src repository Modified files: tools/regression/sockets/accept_fd_leak accept_fd_leak.c Log: Use errx() instead of perror()/exit() for conciseness. Suggested by: ru (some time ago) Revision Changes Path 1.4 +24 -44 src/tools/regression/sockets/accept_fd_leak/accept_fd_leak.c From owner-cvs-src@FreeBSD.ORG Sat Oct 23 22:18:37 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 62C4716A4CE; Sat, 23 Oct 2004 22:18:37 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 42BF843D1F; Sat, 23 Oct 2004 22:18:37 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NMIbbj031215; Sat, 23 Oct 2004 22:18:37 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NMIbIm031214; Sat, 23 Oct 2004 22:18:37 GMT (envelope-from rwatson) Message-Id: <200410232218.i9NMIbIm031214@repoman.freebsd.org> From: Robert Watson Date: Sat, 23 Oct 2004 22:18:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/tools/regression/sockets/accf_data_attach accf_data_attach.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 22:18:37 -0000 rwatson 2004-10-23 22:18:37 UTC FreeBSD src repository Modified files: tools/regression/sockets/accf_data_attach accf_data_attach.c Log: Use errx() instead of fprintf()/exit() for conciseness. Suggested by: ru (some time ago) Revision Changes Path 1.2 +38 -65 src/tools/regression/sockets/accf_data_attach/accf_data_attach.c From owner-cvs-src@FreeBSD.ORG Sat Oct 23 23:28:08 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8285B16A4CE; Sat, 23 Oct 2004 23:28:08 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 62FC043D41; Sat, 23 Oct 2004 23:28:08 +0000 (GMT) (envelope-from simokawa@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NNS8sw033437; Sat, 23 Oct 2004 23:28:08 GMT (envelope-from simokawa@repoman.freebsd.org) Received: (from simokawa@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NNS8UT033436; Sat, 23 Oct 2004 23:28:08 GMT (envelope-from simokawa) Message-Id: <200410232328.i9NNS8UT033436@repoman.freebsd.org> From: Hidetoshi Shimokawa Date: Sat, 23 Oct 2004 23:28:08 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/usr.sbin/fwcontrol fwcontrol.8 fwcontrol.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 23:28:08 -0000 simokawa 2004-10-23 23:28:08 UTC FreeBSD src repository Modified files: usr.sbin/fwcontrol fwcontrol.8 fwcontrol.c Log: Add -m option, set default fwmem target. Revision Changes Path 1.13 +4 -0 src/usr.sbin/fwcontrol/fwcontrol.8 1.20 +23 -1 src/usr.sbin/fwcontrol/fwcontrol.c From owner-cvs-src@FreeBSD.ORG Sat Oct 23 23:28:36 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EAA3A16A4EC; Sat, 23 Oct 2004 23:28:36 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id DC92743D5C; Sat, 23 Oct 2004 23:28:36 +0000 (GMT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NNSaOE033520; Sat, 23 Oct 2004 23:28:36 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NNSaBT033519; Sat, 23 Oct 2004 23:28:36 GMT (envelope-from davidxu) Message-Id: <200410232328.i9NNSaBT033519@repoman.freebsd.org> From: David Xu Date: Sat, 23 Oct 2004 23:28:36 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libpthread/thread thr_create.cthr_find_thread.c thr_kern.c thr_private.h thr_sig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 23:28:37 -0000 davidxu 2004-10-23 23:28:36 UTC FreeBSD src repository Modified files: lib/libpthread/thread thr_create.c thr_find_thread.c thr_kern.c thr_private.h thr_sig.c Log: 1. Move thread list flags into new separate member, and atomically put DEAD thread on GC list, this closes a race between pthread_join and thr_cleanup. 2. Introduce a mutex to protect tcb initialization, tls allocation and deallocation code in rtld seems no lock protection or it is broken, under stress testing, memory is corrupted. Reviewed by: deischen patch partly provided by: deischen Revision Changes Path 1.58 +1 -0 src/lib/libpthread/thread/thr_create.c 1.14 +1 -1 src/lib/libpthread/thread/thr_find_thread.c 1.115 +27 -10 src/lib/libpthread/thread/thr_kern.c 1.119 +15 -11 src/lib/libpthread/thread/thr_private.h 1.81 +1 -2 src/lib/libpthread/thread/thr_sig.c From owner-cvs-src@FreeBSD.ORG Sat Oct 23 23:37:54 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6B73B16A4CE; Sat, 23 Oct 2004 23:37:54 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4C64C43D1F; Sat, 23 Oct 2004 23:37:54 +0000 (GMT) (envelope-from davidxu@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i9NNbsQS033826; Sat, 23 Oct 2004 23:37:54 GMT (envelope-from davidxu@repoman.freebsd.org) Received: (from davidxu@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i9NNbsCi033825; Sat, 23 Oct 2004 23:37:54 GMT (envelope-from davidxu) Message-Id: <200410232337.i9NNbsCi033825@repoman.freebsd.org> From: David Xu Date: Sat, 23 Oct 2004 23:37:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libpthread/thread thr_exit.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Oct 2004 23:37:54 -0000 davidxu 2004-10-23 23:37:54 UTC FreeBSD src repository Modified files: lib/libpthread/thread thr_exit.c Log: Check unhandled signals before thread marks itself as DEAD, this reduces chances of signal losting problem found by Peter Holm Revision Changes Path 1.39 +14 -1 src/lib/libpthread/thread/thr_exit.c