From owner-freebsd-rc@FreeBSD.ORG Sun Oct 14 06:36:25 2007 Return-Path: Delivered-To: freebsd-rc@FreeBSD.Org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DDC8C16A418; Sun, 14 Oct 2007 06:36:25 +0000 (UTC) (envelope-from tataz@tataz.chchile.org) Received: from smtp5-g19.free.fr (smtp5-g19.free.fr [212.27.42.35]) by mx1.freebsd.org (Postfix) with ESMTP id 675F213C43E; Sun, 14 Oct 2007 06:36:25 +0000 (UTC) (envelope-from tataz@tataz.chchile.org) Received: from smtp5-g19.free.fr (localhost.localdomain [127.0.0.1]) by smtp5-g19.free.fr (Postfix) with ESMTP id 390743F6165; Sun, 14 Oct 2007 08:36:24 +0200 (CEST) Received: from tatooine.tataz.chchile.org (tataz.chchile.org [82.233.239.98]) by smtp5-g19.free.fr (Postfix) with ESMTP id EAC2B3F6162; Sun, 14 Oct 2007 08:36:23 +0200 (CEST) Received: from obiwan.tataz.chchile.org (unknown [192.168.1.25]) by tatooine.tataz.chchile.org (Postfix) with ESMTP id 5540F9B497; Sun, 14 Oct 2007 06:36:19 +0000 (UTC) Received: by obiwan.tataz.chchile.org (Postfix, from userid 1000) id 4A5E6405B; Sun, 14 Oct 2007 08:36:19 +0200 (CEST) Date: Sun, 14 Oct 2007 08:36:19 +0200 From: Jeremie Le Hen To: Dirk Engling Message-ID: <20071014063619.GM28841@obiwan.tataz.chchile.org> References: <20071010194000.GA7260@terra.mike.lan> <20071014001341.I24298@erdgeist.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="vOmOzSkFvhd7u8Ms" Content-Disposition: inline In-Reply-To: <20071014001341.I24298@erdgeist.org> User-Agent: Mutt/1.5.15 (2007-04-06) X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: freebsd-rc@FreeBSD.Org, Mike Makonnen , jeremie@le-hen.org, bug-followup@FreeBSD.org Subject: Re: conf/116416: [patch] per-jail rc.conf(5) style configuration file in /etc/jail/ X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2007 06:36:26 -0000 --vOmOzSkFvhd7u8Ms Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Dirk, Thank you for your enlightened review. On Sun, Oct 14, 2007 at 12:27:03AM +0200, Dirk Engling wrote: > > On Wed, 10 Oct 2007, Mike Makonnen wrote: > > > I like this patch, especially the second revision. I think people who > > run a very large number of jails will appreciate it. However, I'd like > > to see a few changes made: > > Hi, before you reinvent the wheel, I'd like you to take a look at my > ezjail[1] project. I've done much of the work more than two years ago and > would call the results stable and in wide use. > > I'd be too happy to just use /etc/jail.d as config directory for jails, as I > do today with /usr/local/etc/ezjail. However, if you write config files the > right way, there is no need to throw awk on them, just source them. Certainly we would all benefit from your experience with ezjail. As for files in /etc/jail.d, I personally prefer the way I did it. IMO it is repetitions that /etc/jail.d/myjail contains: % jail_myjail_ip=... % jail_myjail_hostname=... % jail_myjail_rootdir=... The awk script is not a great deal and just translates "ip=..." to "jail__ip=...": % ip=... % hostname=... % rootdir=... Both ways have benefits and I would like to read some FreeBSD developper's opinion on this subject. I will change my patch accordingly, if needed. > Usign an rcorder style scheme on config files allows starting jails in a > predefined order. It is undoubtly necessary to be able to define jail starting order even in the "auto" case. I've made that change. > Allowing some pre-start commands to mount root dirs or attach certain disc > based memory images would be helpful, too. I completly agree. I've already come up to this conclusion for some time. I will submit another PR, unless Mike asks me to achieve this in the same patch. Regards, -- Jeremie Le Hen < jeremie at le-hen dot org >< ttz at chchile dot org > --vOmOzSkFvhd7u8Ms-- From owner-freebsd-rc@FreeBSD.ORG Mon Oct 15 11:06:17 2007 Return-Path: Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 17AC416A4D2 for ; Mon, 15 Oct 2007 11:06:17 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id E355A13C45A for ; Mon, 15 Oct 2007 11:06:16 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.1/8.14.1) with ESMTP id l9FB6GEQ080546 for ; Mon, 15 Oct 2007 11:06:16 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.1/8.14.1/Submit) id l9FB6GOm080544 for freebsd-rc@FreeBSD.org; Mon, 15 Oct 2007 11:06:16 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 15 Oct 2007 11:06:16 GMT Message-Id: <200710151106.l9FB6GOm080544@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-rc@FreeBSD.org Cc: Subject: Current problem reports assigned to you X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 11:06:17 -0000 From owner-freebsd-rc@FreeBSD.ORG Mon Oct 15 17:47:16 2007 Return-Path: Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3571416A417 for ; Mon, 15 Oct 2007 17:47:16 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 1733D13C474 for ; Mon, 15 Oct 2007 17:47:16 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.1/8.14.1) with ESMTP id l9FHlF7s015081 for ; Mon, 15 Oct 2007 17:47:16 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.1/8.14.1/Submit) id l9FHlF6m015077 for freebsd-rc@FreeBSD.org; Mon, 15 Oct 2007 17:47:15 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 15 Oct 2007 17:47:15 GMT Message-Id: <200710151747.l9FHlF6m015077@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-rc@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-rc@FreeBSD.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2007 17:47:16 -0000 Current FreeBSD problem reports Critical problems Serious problems S Tracker Resp. Description -------------------------------------------------------------------------------- o conf/98758 rc [jail] [patch] Templatize 'jail_fstab' in /etc/rc.d/ja o conf/98846 rc [jail] [patch] Templatize 'jail_rootdir' in /etc/rc.d/ o conf/105689 rc syslogd starts too late at boot o conf/107155 rc [ppp] /etc/rc.d/ppp-user does not bring up pppoe at bo o conf/107364 rc pf fails to start on bootup after system update from F 5 problems total. Non-critical problems S Tracker Resp. Description -------------------------------------------------------------------------------- o conf/45226 rc [patch] Fix for rc.network, ppp-user annoyance o conf/48870 rc [PATCH] rc.network: allow to cancel interface status d o conf/58939 rc [patch] dumb little hack for /etc/rc.firewall{,6} o conf/73677 rc [patch] add support for powernow states to power_profi o conf/74817 rc [patch] network.subr: fixed automatic configuration of o conf/77663 rc Suggestion: add /etc/rc.d/addnetswap after addcritremo o conf/79196 rc [PATCH] configurable dummynet loading from /etc/rc.co o kern/81006 rc ipnat not working with tunnel interfaces on startup o conf/85363 rc syntax error in /etc/rc.d/devfs o conf/85819 rc [patch] script allowing multiuser mode in spite of fsc o conf/88913 rc [patch] wrapper support for rc.subr o conf/89061 rc [patch] IPv6 6to4 auto-configuration enhancement o conf/89870 rc [patch] feature request to make netif verbose rc.conf o conf/92523 rc [patch] allow rc scripts to kill process after a timeo o conf/93815 rc [patch] Adds in the ability to save ipfw rules to rc.d o conf/95162 rc [patch] Missing feature in rc.subr o conf/96343 rc [patch] rc.d order change to start inet6 before pf o conf/99444 rc [patch] Enhancement: rc.subr could easily support star o conf/99721 rc [patch] /etc/rc.initdiskless problem copy dotfile in s o conf/102700 rc [geli] [patch] Add encrypted /tmp support to GELI/GBDE o conf/102913 rc [jail] [patch] /etc/rc.d/named killall in jailed OS o conf/103486 rc [rc.d] [jail] [patch] rc.d/jail: mount fstab after dev o conf/103489 rc [rc.d] [jail] [patch] named_chroot_autoupdate doesn't o conf/104549 rc [patch] rc.d/nfsd needs special _find_processes functi o conf/105145 rc [PATCH] add redial function to rc.d/ppp o conf/105568 rc [patch] Add more flexibility to rc.conf, to choose "_e o conf/106009 rc [patch] Fix pppoed startup script to process multiply o conf/109562 rc [rc.d] [patch] Make rc.d/devfs usable from command-lin o conf/109980 rc /etc/rc.d/netif restart doesn't destroy cloned_interfa o conf/114119 rc [jail] [patch] /etc/rc.d/jail improvements for network o conf/116177 rc rc.d/mdconfig2 script fail at -CURRENT 31 problems total. From owner-freebsd-rc@FreeBSD.ORG Tue Oct 16 08:16:32 2007 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 78B9E16A419 for ; Tue, 16 Oct 2007 08:16:32 +0000 (UTC) (envelope-from mmakonnen@gmail.com) Received: from py-out-1112.google.com (py-out-1112.google.com [64.233.166.182]) by mx1.freebsd.org (Postfix) with ESMTP id 477A313C467 for ; Tue, 16 Oct 2007 08:16:32 +0000 (UTC) (envelope-from mmakonnen@gmail.com) Received: by py-out-1112.google.com with SMTP id u77so3692381pyb for ; Tue, 16 Oct 2007 01:16:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; bh=9mdNnFTvUb7fSDxlFBu89xvcyVJ7hsArb7xEL862ms8=; b=bIQcHcCpRfjAeDwLF6y99Kz0f7kSgoDa/ewICzYlwvOCmVRuz0uVsIqrR4dmxyN++psbDKNOJoSuX4VWafIv5aYiAxlwX/Cwo1/jxZUwfEKPAbSDt3YFKozw3G14PHcYqud7NEOUCDQpSJSTdFnF8n8zrAVXoOL9Ftg9frtd8NU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=d7zR5GGwmWr2o9RrQ3V58BB7+NqAxdJuP7jQP9urzUoKBkJAQSuPhlMOG0OYNTMVKbuHszKkS9Ee78IuUXnnK+7Ps8vcOvSvfue0H8niKrgZY7wYDhqw2ortKeodwHvNuIwYegKoqEM3yDCYnoNpV02SNwQ8zhsZxiegyjUQqOk= Received: by 10.35.26.14 with SMTP id d14mr8829800pyj.1192522591251; Tue, 16 Oct 2007 01:16:31 -0700 (PDT) Received: by 10.35.36.17 with HTTP; Tue, 16 Oct 2007 01:16:31 -0700 (PDT) Message-ID: <584bfc3f0710160116o72439c0dnd9cda9ac79a53c61@mail.gmail.com> Date: Tue, 16 Oct 2007 11:16:31 +0300 From: "Mike Telahun Makonnen" Sender: mmakonnen@gmail.com To: "Jeremie Le Hen" In-Reply-To: <20071014063619.GM28841@obiwan.tataz.chchile.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20071010194000.GA7260@terra.mike.lan> <20071014001341.I24298@erdgeist.org> <20071014063619.GM28841@obiwan.tataz.chchile.org> X-Google-Sender-Auth: c3742e7f004c15a3 Cc: freebsd-rc@freebsd.org, bug-followup@freebsd.org Subject: Re: conf/116416: [patch] per-jail rc.conf(5) style configuration file in /etc/jail/ X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2007 08:16:32 -0000 Thanks guys. I'm currently away from my keyboard and won't be able to look at this issue for a couple more days. Cheers. Mike. From owner-freebsd-rc@FreeBSD.ORG Thu Oct 18 06:58:49 2007 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3870E16A41A for ; Thu, 18 Oct 2007 06:58:49 +0000 (UTC) (envelope-from mtm@FreeBSD.Org) Received: from terra.mike.lan (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 614A013C458; Thu, 18 Oct 2007 06:58:15 +0000 (UTC) (envelope-from mtm@FreeBSD.Org) Received: by terra.mike.lan (Postfix, from userid 1000) id 5CBD76780A; Thu, 18 Oct 2007 10:02:32 +0300 (EAT) Date: Thu, 18 Oct 2007 10:02:32 +0300 From: Mike Makonnen To: Maksim Yevmenkin Message-ID: <20071018070232.GA2542@terra.mike.lan> References: <20071006215757.GA10458@terra.mike.lan> <20071007110815.GA16458@terra.mike.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Operating-System: FreeBSD/7.0-CURRENT (i386) Cc: freebsd-rc@freebsd.org Subject: Re: multiple instances of ppp X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 06:58:49 -0000 On Fri, Oct 12, 2007 at 11:41:19AM -0700, Maksim Yevmenkin wrote: > Mike and All, > > any objections to the following patch as an extension for new > /etc/rc.d/ppp? it allows to start/stop individual ppp profiles. > It failed to apply cleanly on a freshly checked out -CURRENT. Nonetheless, I (lightly) tested the part that applied (the stop logic) and it looks good. The start logic looks good also. Thanks for all your work in this area Maksim :-) Cheers. -- Mike Makonnen | GPG-KEY: http://people.freebsd.org/~mtm/mtm.asc mmakonnen @ gmail.com | AC7B 5672 2D11 F4D0 EBF8 5279 5359 2B82 7CD4 1F55 mtm @ FreeBSD.Org | FreeBSD - http://www.freebsd.org From owner-freebsd-rc@FreeBSD.ORG Thu Oct 18 08:11:55 2007 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5297C16A417; Thu, 18 Oct 2007 08:11:55 +0000 (UTC) (envelope-from tataz@tataz.chchile.org) Received: from smtp5-g19.free.fr (smtp5-g19.free.fr [212.27.42.35]) by mx1.freebsd.org (Postfix) with ESMTP id D2B1F13C48E; Thu, 18 Oct 2007 08:11:54 +0000 (UTC) (envelope-from tataz@tataz.chchile.org) Received: from smtp5-g19.free.fr (localhost.localdomain [127.0.0.1]) by smtp5-g19.free.fr (Postfix) with ESMTP id A22AF3F61C4; Thu, 18 Oct 2007 10:11:53 +0200 (CEST) Received: from tatooine.tataz.chchile.org (tataz.chchile.org [82.233.239.98]) by smtp5-g19.free.fr (Postfix) with ESMTP id 3F8823F61B6; Thu, 18 Oct 2007 10:11:53 +0200 (CEST) Received: from obiwan.tataz.chchile.org (unknown [192.168.1.25]) by tatooine.tataz.chchile.org (Postfix) with ESMTP id 20E1C9B497; Thu, 18 Oct 2007 08:11:39 +0000 (UTC) Received: by obiwan.tataz.chchile.org (Postfix, from userid 1000) id 0B65A405B; Thu, 18 Oct 2007 10:11:39 +0200 (CEST) Date: Thu, 18 Oct 2007 10:11:39 +0200 From: Jeremie Le Hen To: Mike Telahun Makonnen Message-ID: <20071018081139.GC43061@obiwan.tataz.chchile.org> References: <20071010194000.GA7260@terra.mike.lan> <20071014001341.I24298@erdgeist.org> <20071014063619.GM28841@obiwan.tataz.chchile.org> <584bfc3f0710160116o72439c0dnd9cda9ac79a53c61@mail.gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="5I6of5zJg18YgZEa" Content-Disposition: inline In-Reply-To: <584bfc3f0710160116o72439c0dnd9cda9ac79a53c61@mail.gmail.com> User-Agent: Mutt/1.5.15 (2007-04-06) X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: freebsd-rc@freebsd.org, Jeremie Le Hen , bug-followup@freebsd.org Subject: Re: conf/116416: [patch] per-jail rc.conf(5) style configuration file in /etc/jail/ X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 08:11:55 -0000 --5I6of5zJg18YgZEa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Mike, On Tue, Oct 16, 2007 at 11:16:31AM +0300, Mike Telahun Makonnen wrote: > Thanks guys. > I'm currently away from my keyboard and won't be able to look at this > issue for a couple more days. I've attached the rc.conf(5) changes to this e-mail. Please, feel free to reword some parts of it since I am not a native english speaker. Best regards, -- Jeremie Le Hen < jeremie at le-hen dot org >< ttz at chchile dot org > --5I6of5zJg18YgZEa-- From owner-freebsd-rc@FreeBSD.ORG Thu Oct 18 16:26:44 2007 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4D4FD16A41A for ; Thu, 18 Oct 2007 16:26:44 +0000 (UTC) (envelope-from jhein@timing.com) Received: from Daffy.timing.com (mx2.timing.com [206.168.13.218]) by mx1.freebsd.org (Postfix) with ESMTP id 0361213C467 for ; Thu, 18 Oct 2007 16:26:43 +0000 (UTC) (envelope-from jhein@timing.com) Received: from gromit.timing.com (gromit.timing.com [206.168.13.209]) by Daffy.timing.com (8.13.1/8.13.1) with ESMTP id l9IGBSdI084828 for ; Thu, 18 Oct 2007 10:11:28 -0600 (MDT) (envelope-from jhein@timing.com) Received: from gromit.timing.com (localhost [127.0.0.1]) by gromit.timing.com (8.14.1/8.14.1) with ESMTP id l9IGBNpv044411; Thu, 18 Oct 2007 10:11:23 -0600 (MDT) (envelope-from jhein@gromit.timing.com) Received: (from jhein@localhost) by gromit.timing.com (8.14.1/8.14.1/Submit) id l9IGBNnf044408; Thu, 18 Oct 2007 10:11:23 -0600 (MDT) (envelope-from jhein) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18199.34219.154950.645190@gromit.timing.com> Date: Thu, 18 Oct 2007 10:11:23 -0600 From: John E Hein To: freebsd-rc@freebsd.org X-Mailer: VM 7.19 under Emacs 22.0.99.1 X-Virus-Scanned: ClamAV version 0.91.2, clamav-milter version 0.91.2 on Daffy.timing.com X-Virus-Status: Clean Subject: rc.subr, 1.34.2.22, breaks amd_map_program="ypcat -k amd.master" in RELENG_6 X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 16:26:44 -0000 I use amd with nis. My rc.conf settings are: amd_enable=YES amd_map_program="ypcat -k amd.master" Output of ypcat -k amd.master looks like so: /foo amd.foo /bar amd.bar /baz amd.baz I was running RELENG_6 from early July. But I just updated to yesterday's RELENG_6. Now upon running /etc/rc.d/amd start, I get: eval: /bar: Permission denied eval: /baz: Permission denied And the /var/run/amd.pid is empty (explained below). The reason is that the rc_flags has line breaks in it and the new rc.subr no longer converts them to spaces. If you put set | grep -A 10 rc_flags in /etc/rc.d/amd after this line: rc_flags="${rc_flags} `eval ${amd_map_program}`" ... you will see something like this: rc_flags='-a /.amd_mnt -l syslog /host /etc/amd.map /net /etc/amd.map /foo amd.foo /bar amd.bar /baz amd.baz' Later the -p ${rc_flags} > /var/run/amd.pid 2> /dev/null is tacked on, putting "> ..." it's own separate line. This explains why /var/run/amd.pid is empty. When using 1.34.2.22 (MFC of 1.72, 2007/08/17, committed by yar from conf/98734), it fails with the described behavior. Using 1.34.2.21 (2007/07/12), it works fine. Something in the .22 commit causes the newlines to not get converted to plain spaces. I have not yet attempted to narrow down what in .22 (+198 -146) actually changes the behavior, but the following works around the problem by converting the newlines to spaces: Index: amd =================================================================== RCS file: /base/FreeBSD-CVS/src/etc/rc.d/amd,v retrieving revision 1.15.2.3 diff -u -p -r1.15.2.3 amd --- amd 22 Oct 2006 20:33:10 -0000 1.15.2.3 +++ amd 18 Oct 2007 15:57:34 -0000 @@ -34,7 +34,7 @@ amd_precmd() [Nn][Oo] | '') ;; *) - rc_flags="${rc_flags} `eval ${amd_map_program}`" + rc_flags="${rc_flags} `echo $(eval ${amd_map_program})`" ;; esac From owner-freebsd-rc@FreeBSD.ORG Thu Oct 18 19:26:44 2007 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9034216A417 for ; Thu, 18 Oct 2007 19:26:44 +0000 (UTC) (envelope-from jhein@timing.com) Received: from Daffy.timing.com (daffy.timing.com [206.168.13.218]) by mx1.freebsd.org (Postfix) with ESMTP id 4744A13C46A for ; Thu, 18 Oct 2007 19:26:44 +0000 (UTC) (envelope-from jhein@timing.com) Received: from gromit.timing.com (gromit.timing.com [206.168.13.209]) by Daffy.timing.com (8.13.1/8.13.1) with ESMTP id l9IIxvnK007084 for ; Thu, 18 Oct 2007 12:59:57 -0600 (MDT) (envelope-from jhein@timing.com) Received: from gromit.timing.com (localhost [127.0.0.1]) by gromit.timing.com (8.14.1/8.14.1) with ESMTP id l9IIxmFp046536; Thu, 18 Oct 2007 12:59:48 -0600 (MDT) (envelope-from jhein@gromit.timing.com) Received: (from jhein@localhost) by gromit.timing.com (8.14.1/8.14.1/Submit) id l9IIxmij046533; Thu, 18 Oct 2007 12:59:48 -0600 (MDT) (envelope-from jhein) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18199.44324.813707.124793@gromit.timing.com> Date: Thu, 18 Oct 2007 12:59:48 -0600 From: John E Hein To: freebsd-rc@freebsd.org In-Reply-To: <18199.34219.154950.645190@gromit.timing.com> References: <18199.34219.154950.645190@gromit.timing.com> X-Mailer: VM 7.19 under Emacs 22.0.99.1 X-Virus-Scanned: ClamAV version 0.91.2, clamav-milter version 0.91.2 on Daffy.timing.com X-Virus-Status: Clean Subject: Re: rc.subr, 1.34.2.22, breaks amd_map_program="ypcat -k amd.master" in RELENG_6 X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 19:26:44 -0000 John E Hein wrote at 10:11 -0600 on Oct 18, 2007: > I have not yet attempted to narrow down what in .22 (+198 -146) > actually changes the behavior, but the following works around the > problem by converting the newlines to spaces: @@ -699,106 +657,52 @@ $command $rc_flags $command_args" fi fi - # run the full command; - # if the cmd failed and force - # isn't set, exit + # run the full command # - debug "run_rc_command: _doit: $_doit" - eval $_doit - _return=$? - [ $_return -ne 0 ] && [ -z "$rc_force" ] && return 1 + _run_rc_doit "$_doit" || return 1 The last diff blob above is the trouble maker. The new run_rc_doit() function does this: + eval "$@" If you remove the quotes, it starts working again. Unfortunately, you can have different problems if you don't quote $@ (for instance, args with spaces become two args). I don't know if yar@ added that to address a specific issue or just to be more future-proof in terms of quoting. But it breaks if the command or args have a newline. Maybe it's best to just do the echo in /etc/rc.d/amd that I showed in the previous email and document that $rc_flags and $command, etc., should not have newlines. Here's that patch again: > Index: amd > =================================================================== > RCS file: /base/FreeBSD-CVS/src/etc/rc.d/amd,v > retrieving revision 1.15.2.3 > diff -u -p -r1.15.2.3 amd > --- amd 22 Oct 2006 20:33:10 -0000 1.15.2.3 > +++ amd 18 Oct 2007 15:57:34 -0000 > @@ -34,7 +34,7 @@ amd_precmd() > [Nn][Oo] | '') > ;; > *) > - rc_flags="${rc_flags} `eval ${amd_map_program}`" > + rc_flags="${rc_flags} `echo $(eval ${amd_map_program})`" > ;; > esac From owner-freebsd-rc@FreeBSD.ORG Fri Oct 19 08:47:28 2007 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B176016A46D for ; Fri, 19 Oct 2007 08:47:28 +0000 (UTC) (envelope-from mtm@FreeBSD.Org) Received: from terra.mike.lan (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 1516313C45B; Fri, 19 Oct 2007 08:47:27 +0000 (UTC) (envelope-from mtm@FreeBSD.Org) Received: by terra.mike.lan (Postfix, from userid 1000) id 9A03A6780D; Fri, 19 Oct 2007 11:51:54 +0300 (EAT) Date: Fri, 19 Oct 2007 11:51:54 +0300 From: Mike Makonnen To: John E Hein Message-ID: <20071019085154.GA3185@terra.mike.lan> References: <18199.34219.154950.645190@gromit.timing.com> <18199.44324.813707.124793@gromit.timing.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="17pEHd4RhPHOinZp" Content-Disposition: inline In-Reply-To: <18199.44324.813707.124793@gromit.timing.com> User-Agent: Mutt/1.4.2.3i X-Operating-System: FreeBSD/7.0-CURRENT (i386) Cc: freebsd-rc@freebsd.org Subject: Re: rc.subr, 1.34.2.22, breaks amd_map_program="ypcat -k amd.master" in RELENG_6 X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 08:47:28 -0000 --17pEHd4RhPHOinZp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Oct 18, 2007 at 12:59:48PM -0600, John E Hein wrote: > > The last diff blob above is the trouble maker. > The new run_rc_doit() function does this: > > + eval "$@" > > If you remove the quotes, it starts working again. > > Unfortunately, you can have different problems if you don't quote $@ > (for instance, args with spaces become two args). I don't know if > yar@ added that to address a specific issue or just to be more > future-proof in terms of quoting. But it breaks if the command > or args have a newline. > > Maybe it's best to just do the echo in /etc/rc.d/amd that I showed in > the previous email and document that $rc_flags and $command, etc., should > not have newlines. Here's that patch again: I agree. I think that modifying rc.d/amd is the proper solution here. It's probably a bug that it depends on run_rc_command()'s internal behaviour. Can you try the following slightly different patch? Cheers. -- Mike Makonnen | GPG-KEY: http://people.freebsd.org/~mtm/mtm.asc mmakonnen @ gmail.com | AC7B 5672 2D11 F4D0 EBF8 5279 5359 2B82 7CD4 1F55 mtm @ FreeBSD.Org | FreeBSD - http://www.freebsd.org --17pEHd4RhPHOinZp Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename=rcd-amd-patch Index: etc/rc.d/amd =================================================================== RCS file: /home/ncvs/src/etc/rc.d/amd,v retrieving revision 1.18 diff -u -r1.18 amd --- etc/rc.d/amd 18 Oct 2006 15:56:11 -0000 1.18 +++ etc/rc.d/amd 19 Oct 2007 08:35:36 -0000 @@ -34,7 +34,7 @@ [Nn][Oo] | '') ;; *) - rc_flags="${rc_flags} `eval ${amd_map_program}`" + rc_flags="${rc_flags} `echo $(eval ${amd_map_program})`" ;; esac @@ -46,7 +46,8 @@ fi ;; *) - rc_flags="-p ${rc_flags} > /var/run/amd.pid 2> /dev/null" + rc_flags="-p ${rc_flags}" + command_args=" > /var/run/amd.pid 2> /dev/null" ;; esac return 0 --17pEHd4RhPHOinZp-- From owner-freebsd-rc@FreeBSD.ORG Fri Oct 19 13:34:56 2007 Return-Path: Delivered-To: freebsd-rc@FreeBSD.Org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1DF0C16A419 for ; Fri, 19 Oct 2007 13:34:56 +0000 (UTC) (envelope-from jhein@timing.com) Received: from Daffy.timing.com (w.timing.com [206.168.13.218]) by mx1.freebsd.org (Postfix) with ESMTP id E084813C46E for ; Fri, 19 Oct 2007 13:34:55 +0000 (UTC) (envelope-from jhein@timing.com) Received: from gromit.timing.com (gromit.timing.com [206.168.13.209]) by Daffy.timing.com (8.13.1/8.13.1) with ESMTP id l9JDYt3Q055172; Fri, 19 Oct 2007 07:34:55 -0600 (MDT) (envelope-from jhein@timing.com) Received: from gromit.timing.com (localhost [127.0.0.1]) by gromit.timing.com (8.14.1/8.14.1) with ESMTP id l9JDYogm073265; Fri, 19 Oct 2007 07:34:50 -0600 (MDT) (envelope-from jhein@gromit.timing.com) Received: (from jhein@localhost) by gromit.timing.com (8.14.1/8.14.1/Submit) id l9JDYoZB073262; Fri, 19 Oct 2007 07:34:50 -0600 (MDT) (envelope-from jhein) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18200.45690.542280.695857@gromit.timing.com> Date: Fri, 19 Oct 2007 07:34:50 -0600 From: John E Hein To: Mike Makonnen In-Reply-To: <20071019085154.GA3185@terra.mike.lan> References: <18199.34219.154950.645190@gromit.timing.com> <18199.44324.813707.124793@gromit.timing.com> <20071019085154.GA3185@terra.mike.lan> X-Mailer: VM 7.19 under Emacs 22.0.99.1 X-Virus-Scanned: ClamAV version 0.91.2, clamav-milter version 0.91.2 on Daffy.timing.com X-Virus-Status: Clean Cc: freebsd-rc@FreeBSD.Org Subject: Re: rc.subr, 1.34.2.22, breaks amd_map_program="ypcat -k amd.master" in RELENG_6 X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 13:34:56 -0000 Mike Makonnen wrote at 11:51 +0300 on Oct 19, 2007: > On Thu, Oct 18, 2007 at 12:59:48PM -0600, John E Hein wrote: > > The new run_rc_doit() function does this: > > > > + eval "$@" > > > > If you remove the quotes, it starts working again. > > > > Unfortunately, you can have different problems if you don't quote $@ > > (for instance, args with spaces become two args). I don't know if > > yar@ added that to address a specific issue or just to be more > > future-proof in terms of quoting. But it breaks if the command > > or args have a newline. > > > > Maybe it's best to just do the echo in /etc/rc.d/amd that I showed in > > the previous email and document that $rc_flags and $command, etc., should > > not have newlines. Here's that patch again: > > I agree. > I think that modifying rc.d/amd is the proper solution here. It's probably > a bug that it depends on run_rc_command()'s internal behaviour. I agree - it'd be best if run_rc_command could handle whatever you throw at it, but I'm not sure that's practical. If run_rc_command can't have newlines in the vars it uses as arguments, then one way to handle the bug is just to document it clearly in rc.subr (with the rc_flags and command_args comments). A quick glance shows that the /etc/rc.d/syslogd script is the only(?) one that does something similar. But it takes pains to convert newlines to spaces using tr(1) (although I think it's unnecessary to do so in a for loop - so, IMO, that tr(1) is superfluous and could be removed for the efficiency conscious - not tested ;). > Can you try the following slightly different patch? > > Index: etc/rc.d/amd > =================================================================== > RCS file: /home/ncvs/src/etc/rc.d/amd,v > retrieving revision 1.18 > diff -u -r1.18 amd > --- etc/rc.d/amd 18 Oct 2006 15:56:11 -0000 1.18 > +++ etc/rc.d/amd 19 Oct 2007 08:35:36 -0000 > @@ -34,7 +34,7 @@ > [Nn][Oo] | '') > ;; > *) > - rc_flags="${rc_flags} `eval ${amd_map_program}`" > + rc_flags="${rc_flags} `echo $(eval ${amd_map_program})`" > ;; > esac > > @@ -46,7 +46,8 @@ > fi > ;; > *) > - rc_flags="-p ${rc_flags} > /var/run/amd.pid 2> /dev/null" > + rc_flags="-p ${rc_flags}" > + command_args=" > /var/run/amd.pid 2> /dev/null" > ;; > esac > return 0 That works fine, too (don't need the space in front of '>'), but I don't see the benefit to splitting it into two variables/lines. Is it just a preferred style issue? If so, please commit that separately or note it in the commit message so as not to confuse the issue for future cvs miners. Thanks for taking a look. If you want me to send-pr this, just let me know. From owner-freebsd-rc@FreeBSD.ORG Fri Oct 19 18:23:47 2007 Return-Path: Delivered-To: freebsd-rc@FreeBSD.Org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5C94616A46B for ; Fri, 19 Oct 2007 18:23:47 +0000 (UTC) (envelope-from mtm@FreeBSD.Org) Received: from terra.mike.lan (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id B8B6113C46A; Fri, 19 Oct 2007 18:23:39 +0000 (UTC) (envelope-from mtm@FreeBSD.Org) Received: by terra.mike.lan (Postfix, from userid 1000) id 617946780D; Fri, 19 Oct 2007 21:27:58 +0300 (EAT) Date: Fri, 19 Oct 2007 21:27:58 +0300 From: Mike Makonnen To: John E Hein Message-ID: <20071019182757.GA38833@terra.mike.lan> References: <18199.34219.154950.645190@gromit.timing.com> <18199.44324.813707.124793@gromit.timing.com> <20071019085154.GA3185@terra.mike.lan> <18200.45690.542280.695857@gromit.timing.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <18200.45690.542280.695857@gromit.timing.com> User-Agent: Mutt/1.4.2.3i X-Operating-System: FreeBSD/8.0-CURRENT (i386) Cc: freebsd-rc@FreeBSD.Org Subject: Re: rc.subr, 1.34.2.22, breaks amd_map_program="ypcat -k amd.master" in RELENG_6 X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 18:23:47 -0000 On Fri, Oct 19, 2007 at 07:34:50AM -0600, John E Hein wrote: > > I agree. > > I think that modifying rc.d/amd is the proper solution here. It's probably > > a bug that it depends on run_rc_command()'s internal behaviour. > > I agree - it'd be best if run_rc_command could handle whatever you > throw at it, but I'm not sure that's practical. > > If run_rc_command can't have newlines in the vars it uses as > arguments, then one way to handle the bug is just to document it > clearly in rc.subr (with the rc_flags and command_args comments). I'm not sure that it is needed. In fact, I would normally assume that any arguments would *not* contain newlines (only spaces) as argument delimiters. As far as I am concerned, the fact rc.d/amd worked up until this change is purely coincidental. In other words, the bug was in the original implementation. It should be up to the script to do whatever cleanup is needed on its input and try to pass sane values to the rc.subr(8) routines. Going the other way and trying to make the run_rc_command() routine permissive in what it accepts is probably asking for trouble. > > A quick glance shows that the /etc/rc.d/syslogd script is the only(?) > one that does something similar. But it takes pains to convert > newlines to spaces using tr(1) (although I think it's unnecessary to > do so in a for loop - so, IMO, that tr(1) is superfluous and could be > removed for the efficiency conscious - not tested ;). I think you're right. I'll take a look at it. [snip patch] > > That works fine, too (don't need the space in front of '>'), but I > don't see the benefit to splitting it into two variables/lines. Is it > just a preferred style issue? If so, please commit that separately or > note it in the commit message so as not to confuse the issue for > future cvs miners. It's a matter of correctness. The rc_flags variable should contain only arguments for the program. Any shell directives or extra switches the script appends should go in command_args. But you're right, it's a separate issue. Cheers. -- Mike Makonnen | GPG-KEY: http://people.freebsd.org/~mtm/mtm.asc mmakonnen @ gmail.com | AC7B 5672 2D11 F4D0 EBF8 5279 5359 2B82 7CD4 1F55 mtm @ FreeBSD.Org | FreeBSD - http://www.freebsd.org From owner-freebsd-rc@FreeBSD.ORG Fri Oct 19 18:59:55 2007 Return-Path: Delivered-To: freebsd-rc@FreeBSD.Org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 180CB16A417; Fri, 19 Oct 2007 18:59:55 +0000 (UTC) (envelope-from jhein@timing.com) Received: from Daffy.timing.com (smtp.timing.com [206.168.13.218]) by mx1.freebsd.org (Postfix) with ESMTP id 1DD9D13C45D; Fri, 19 Oct 2007 18:59:40 +0000 (UTC) (envelope-from jhein@timing.com) Received: from gromit.timing.com (gromit.timing.com [206.168.13.209]) by Daffy.timing.com (8.13.1/8.13.1) with ESMTP id l9JIxMee095162; Fri, 19 Oct 2007 12:59:22 -0600 (MDT) (envelope-from jhein@timing.com) Received: from gromit.timing.com (localhost [127.0.0.1]) by gromit.timing.com (8.14.1/8.14.1) with ESMTP id l9JIxILF083772; Fri, 19 Oct 2007 12:59:18 -0600 (MDT) (envelope-from jhein@gromit.timing.com) Received: (from jhein@localhost) by gromit.timing.com (8.14.1/8.14.1/Submit) id l9JIxI96083769; Fri, 19 Oct 2007 12:59:18 -0600 (MDT) (envelope-from jhein) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18200.65158.288201.786414@gromit.timing.com> Date: Fri, 19 Oct 2007 12:59:18 -0600 From: John E Hein To: Mike Makonnen In-Reply-To: <20071019182757.GA38833@terra.mike.lan> References: <18199.34219.154950.645190@gromit.timing.com> <18199.44324.813707.124793@gromit.timing.com> <20071019085154.GA3185@terra.mike.lan> <18200.45690.542280.695857@gromit.timing.com> <20071019182757.GA38833@terra.mike.lan> X-Mailer: VM 7.19 under Emacs 22.0.99.1 X-Virus-Scanned: ClamAV version 0.91.2, clamav-milter version 0.91.2 on Daffy.timing.com X-Virus-Status: Clean Cc: freebsd-rc@FreeBSD.Org Subject: Re: rc.subr, 1.34.2.22, breaks amd_map_program="ypcat -k amd.master" in RELENG_6 X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 18:59:55 -0000 Mike Makonnen wrote at 21:27 +0300 on Oct 19, 2007: > On Fri, Oct 19, 2007 at 07:34:50AM -0600, John E Hein wrote: > > If run_rc_command can't have newlines in the vars it uses as > > arguments, then one way to handle the bug is just to document it > > clearly in rc.subr (with the rc_flags and command_args comments). > > I'm not sure that it is needed. In fact, I would normally assume that > any arguments would *not* contain newlines (only spaces) as argument > delimiters. As far as I am concerned, the fact rc.d/amd worked up until > this change is purely coincidental. In other words, the bug was in the > original implementation. It should be up to the script to do > whatever cleanup is needed on its input and try to pass sane values > to the rc.subr(8) routines. It can't hurt to put some hints in the comments in rc.subr what sane values are (i.e., "no newlines, please" ;). But since this is pretty abnormal, I'm not going to lose sleep if it's not documented. > Going the other way and trying to make the run_rc_command() routine > permissive in what it accepts is probably asking for trouble. Agreed. > > A quick glance shows that the /etc/rc.d/syslogd script is the only(?) > > one that does something similar. But it takes pains to convert > > newlines to spaces using tr(1) (although I think it's unnecessary to > > do so in a for loop - so, IMO, that tr(1) is superfluous and could be > > removed for the efficiency conscious - not tested ;). > > I think you're right. I'll take a look at it. Thanks. > It's a matter of correctness. The rc_flags variable should contain only > arguments for the program. Any shell directives or extra switches the > script appends should go in command_args. But you're right, it's a > separate issue. Okay. A subtle distinction, but I see it now in the comments in rc.subr From owner-freebsd-rc@FreeBSD.ORG Fri Oct 19 23:13:20 2007 Return-Path: Delivered-To: freebsd-rc@FreeBSD.Org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 394D416A41A for ; Fri, 19 Oct 2007 23:13:20 +0000 (UTC) (envelope-from mtm@FreeBSD.Org) Received: from terra.mike.lan (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 5344113C46A; Fri, 19 Oct 2007 23:13:18 +0000 (UTC) (envelope-from mtm@FreeBSD.Org) Received: by terra.mike.lan (Postfix, from userid 1000) id 15B756780D; Sat, 20 Oct 2007 02:17:46 +0300 (EAT) Date: Sat, 20 Oct 2007 02:17:45 +0300 From: Mike Makonnen To: John E Hein Message-ID: <20071019231745.GA70158@terra.mike.lan> References: <18199.34219.154950.645190@gromit.timing.com> <18199.44324.813707.124793@gromit.timing.com> <20071019085154.GA3185@terra.mike.lan> <18200.45690.542280.695857@gromit.timing.com> <20071019182757.GA38833@terra.mike.lan> <18200.65158.288201.786414@gromit.timing.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <18200.65158.288201.786414@gromit.timing.com> User-Agent: Mutt/1.4.2.3i X-Operating-System: FreeBSD/8.0-CURRENT (i386) Cc: freebsd-rc@FreeBSD.Org Subject: Re: rc.subr, 1.34.2.22, breaks amd_map_program="ypcat -k amd.master" in RELENG_6 X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2007 23:13:20 -0000 I just committed this to HEAD. I'll MFC in about a week, pending re@ approval. Thanks! Cheers. -- Mike Makonnen | GPG-KEY: http://people.freebsd.org/~mtm/mtm.asc mmakonnen @ gmail.com | AC7B 5672 2D11 F4D0 EBF8 5279 5359 2B82 7CD4 1F55 mtm @ FreeBSD.Org | FreeBSD - http://www.freebsd.org