From owner-freebsd-current@FreeBSD.ORG Sun Aug 9 01:47:51 2009 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 597FE1065673; Sun, 9 Aug 2009 01:47:51 +0000 (UTC) (envelope-from oberman@es.net) Received: from mailgw.es.net (mail2.es.net [IPv6:2001:400:107:1::2]) by mx1.freebsd.org (Postfix) with ESMTP id 448708FC16; Sun, 9 Aug 2009 01:47:51 +0000 (UTC) Received: from ptavv.es.net (ptavv.es.net [IPv6:2001:400:910::29]) by mailgw.es.net (8.14.3/8.14.3) with ESMTP id n791lmCI026341 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 8 Aug 2009 18:47:50 -0700 Received: from ptavv.es.net (ptavv.es.net [127.0.0.1]) by ptavv.es.net (Tachyon Server) with ESMTP id 284AB1CC31; Sat, 8 Aug 2009 18:47:48 -0700 (PDT) To: Doug Barton In-reply-to: Your message of "Wed, 05 Aug 2009 20:45:11 PDT." <4A7A51C7.3060702@FreeBSD.org> Date: Sat, 08 Aug 2009 18:47:48 -0700 From: "Kevin Oberman" Message-Id: <20090809014748.284AB1CC31@ptavv.es.net> X-Proofpoint-Virus-Version: vendor=fsecure engine=1.12.8161:2.4.5, 1.2.40, 4.0.166 definitions=2009-08-08_02:2009-07-24, 2009-08-08, 2009-08-08 signatures=0 Cc: current@freebsd.org Subject: Re: Unable to build HEAD X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Aug 2009 01:47:51 -0000 > Date: Wed, 05 Aug 2009 20:45:11 -0700 > From: Doug Barton > > Kevin Oberman wrote: > > > OK. I cleaned out /usr/obj and saved /usr/src/sys/i386/conf. > > I'm going to assume that you mean just your conf file there. > > > > While I > > will have to re-do my kernel config, I prefer to save my old one, > > That's fine, just compare it to GENERIC to make sure that all of your > entries are valid, and that you're not missing anything important. > > > But, as suggested by bf, I think that the WITHOUT_OPENSSH knob is > > broken which is a problem > > Agreed. If you want to help debug this problem you could try building > with clean /usr/obj, up to date /usr/src, and ONLY the ssh knob in > src.conf. Then debug from there. > > This (IMWO) is something that should be fixed before release. > > > Guess I should have tried V8 a couple of months ago. > > In the immortal words of Jiminy Cricket, let your conscience be your > guide. :) Doug, Two patches have been submitted to fix this problem, one by bf (conf/137483) and one by me (conf/137486). I have confidence that the bf patch is correct and appropriate and that buildworld is broken with various src.conf options. I am convinced my patch is correct, but I suspect that some might argue that it is not appropriate. It allows pam_ssh to be built even though WITHOUT_OPENSSH is specified. I will be happy to defend my patch, if challenged, but the short time until 8.0 makes it questionable as to whether a consensus can be reached in time. Whether you like my patch, I'd love to see the patch by bf (conf/137483) committed before 8.0 and I believe that you agree. If so, could you request the RE to approve it to be committed. -- R. Kevin Oberman, Network Engineer Energy Sciences Network (ESnet) Ernest O. Lawrence Berkeley National Laboratory (Berkeley Lab) E-mail: oberman@es.net Phone: +1 510 486-8634 Key fingerprint:059B 2DDF 031C 9BA3 14A4 EADA 927D EBB3 987B 3751