From owner-freebsd-arch@FreeBSD.ORG Mon Feb 15 11:06:56 2010 Return-Path: Delivered-To: freebsd-arch@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6828E106568B for ; Mon, 15 Feb 2010 11:06:56 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 3D2228FC31 for ; Mon, 15 Feb 2010 11:06:56 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id o1FB6ulH070248 for ; Mon, 15 Feb 2010 11:06:56 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id o1FB6tdV070246 for freebsd-arch@FreeBSD.org; Mon, 15 Feb 2010 11:06:55 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 15 Feb 2010 11:06:55 GMT Message-Id: <201002151106.o1FB6tdV070246@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-arch@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-arch@FreeBSD.org X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2010 11:06:56 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o kern/120749 arch [request] Suggest upping the default kern.ps_arg_cache 1 problem total. From owner-freebsd-arch@FreeBSD.ORG Mon Feb 15 22:44:57 2010 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 73B731065697 for ; Mon, 15 Feb 2010 22:44:57 +0000 (UTC) (envelope-from ml@os2.kiev.ua) Received: from s1.sdv.com.ua (s1.sdv.com.ua [77.120.97.61]) by mx1.freebsd.org (Postfix) with ESMTP id 1EEE58FC20 for ; Mon, 15 Feb 2010 22:44:56 +0000 (UTC) Received: from 241-101-243-80.cust.centrio.cz ([80.243.101.241] helo=[192.168.100.104]) by s1.sdv.com.ua with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.71 (FreeBSD)) (envelope-from ) id 1Nh9CD-000OSF-6d; Tue, 16 Feb 2010 00:13:39 +0200 Message-ID: <4B79C711.3060907@os2.kiev.ua> Date: Mon, 15 Feb 2010 23:13:37 +0100 From: Alex Samorukov User-Agent: Thunderbird 2.0.0.23 (X11/20090817) MIME-Version: 1.0 To: freebsd-arch@freebsd.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -3.0 (---) X-Spam-Report: Spam detection software, running on the system "s1.sdv.com.ua", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see The administrator of that system for details. Content preview: Hi, I am working on FreeBSD support for smartmontools project. Current (SVN) version uses 48bit ATA command READ LOG EXT to query some drive information. I found that it is not possible to send this command to the ATA device using IOCATAREQUEST in FreeBSD. [...] Content analysis details: (-3.0 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.8 ALL_TRUSTED Passed through trusted hosts only via SMTP 1.9 TVD_RCVD_IP TVD_RCVD_IP -2.6 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] -0.5 AWL AWL: From: address is in the auto white-list Cc: Alexander Motin Subject: changes to the IOCATAREQUEST request X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Alex Samorukov List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2010 22:44:57 -0000 Hi, I am working on FreeBSD support for smartmontools project. Current (SVN) version uses 48bit ATA command READ LOG EXT to query some drive information. I found that it is not possible to send this command to the ATA device using IOCATAREQUEST in FreeBSD. As far as I understand sys/dev/ata/ata-all.c, the IOCATAREQUEST has no support to set the internal ATA_D_48BIT_ACTIVE flag. This flag is set later by ata_modify_if_48bit() function for some common commands (READ, WRITE, ...) only, it is not set for READ_LOG_EXT. It is not possible to set 48bit flag with current ioctl. The following additions are required for a reasonable pass-through ioctl: sys/ata.h: struct ata_ioc_request { ... int count; int flags; #define ATA_CMD_CONTROL 0x01 #define ATA_CMD_READ 0x02 #define ATA_CMD_WRITE 0x04 #define ATA_CMD_ATAPI 0x08 +#define ATA_CMD_48BIT 0x10 // 48-bit command +#define ATA_CMD_NO_MULTIPLE 0x20 // one DRQ/sector int timeout; int error; }; Here a list of 48-bit commands (provided by Christian Franke from latest ACS 2 draft (T13/2015-D Revision 2). The FreeBSD function ata_modify_if_48bit() selects commands marked with *** if their 28-bit variants are requested and 48 bit addressing is actually required. Only in this case ATA_D_48BIT_ACTIVE is set. The other commands are not supported, I presume. mandatory, 28-bit variants exist: FLUSH CACHE EXT *** READ DMA EXT *** READ MULTIPLE EXT *** READ SECTOR(S) EXT *** READ VERIFY SECTOR(S) EXT *** WRITE DMA EXT *** WRITE DMA FUA EXT WRITE MULTIPLE EXT *** WRITE MULTIPLE FUA EXT WRITE SECTOR(S) EXT *** optional, 28-bit variants exist: READ NATIVE MAX ADDRESS EXT *** SET MAX ADDRESS EXT *** WRITE UNCORRECTABLE EXT optional, 48-bit only: CONFIGURE STREAM DATA SET MANAGEMENT READ FPDMA QUEUED READ LOG DMA EXT READ LOG EXT READ STREAM DMA EXT READ STREAM EXT REQUEST SENSE DATA EXT WRITE FPDMA QUEUED WRITE LOG DMA EXT WRITE LOG EXT WRITE STREAM DMA EXT WRITE STREAM EXT NV Cache (7 subcommands, possible vendor specific commands) Sanitize Device (5 subcommands) There might also be 48-bit commands not defined by ATA ACS in the command ranges reserved for other standards (Compact Flash, SATA, Media Card, Vendor specific). Please, tell me if it is possible to extend this ioctl to support 48bit commands, or if there is another solution for this. From owner-freebsd-arch@FreeBSD.ORG Tue Feb 16 00:10:38 2010 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BEAE71065695; Tue, 16 Feb 2010 00:10:38 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-iw0-f175.google.com (mail-iw0-f175.google.com [209.85.223.175]) by mx1.freebsd.org (Postfix) with ESMTP id 790C98FC0A; Tue, 16 Feb 2010 00:10:38 +0000 (UTC) Received: by iwn5 with SMTP id 5so2273517iwn.9 for ; Mon, 15 Feb 2010 16:10:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=ePfxVQhEFB/luhLu/2gZiKSz7NI1b61BP7vPhEdJc14=; b=KThGKPdkYHm9MZNIwDYkyAcgtI3mn81q34mDzFziGCzGBuFMyjaq92WOQWv68bsdFO Nx53fzQl9oLM1Owh1LTPecXAZncVQ0emcIovlWIZXTuG+lfSPxlbRw/dshyo4TZU56ac fIo3AfZ+vnS7hiRTFI0toapROAJHwfTVqOvsI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type; b=TLJAkD74BO2R+ZmoNY017tcv4d+amTZsjNHQanrRDxZbbHdu98omGy6PLF9IqUBHeW pdzN6u7JzSwDlD8zucrL/nQWnwBK6l60xzSrkeLofuRNNNbpg208mUdHuFvPFWLv/oSx AIPnF7deMeCrtFgL+cMjY8UBgzA3rTUCAhHjY= MIME-Version: 1.0 Sender: asmrookie@gmail.com Received: by 10.231.145.70 with SMTP id c6mr4290355ibv.36.1266279037702; Mon, 15 Feb 2010 16:10:37 -0800 (PST) Date: Tue, 16 Feb 2010 01:10:37 +0100 X-Google-Sender-Auth: f927fe2b39503c93 Message-ID: <3bbf2fe11002151610l41526f55r5e60b5e46ce42b64@mail.gmail.com> From: Attilio Rao To: FreeBSD Arch Content-Type: text/plain; charset=UTF-8 Cc: Ed Maste Subject: [PATCH] Adding shared code support for ia32 and amd64 -- x86 sub-branch X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2010 00:10:38 -0000 The following patch: http://www.freebsd.org/~attilio/x86.diff starts the effort for having a shared sub-tree between amd64 and ia32. In this initial pass I putted the low-hanging fruits (bios/cpufreq) and what my customer was more interested in (isa/*) in order to kick-off the effort and, in the future, move gradually the code there. With the machine/isa/* cleanup about 10 files are trimmed and I'm sure more can be achieved easilly. There are few things to discuss. One, that I had not necessity to dig about still, is about how to organize headers (include/). Maybe some replication ala pc98 may be good. The patch is big but it is mostly added and removed files (look at the files.X in order to understand better how files movements happened). Hope to see comments and reviews. Attilio -- Peace can only be achieved by understanding - A. Einstein From owner-freebsd-arch@FreeBSD.ORG Tue Feb 16 19:04:33 2010 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7ACBF106568B for ; Tue, 16 Feb 2010 19:04:33 +0000 (UTC) (envelope-from emaste@freebsd.org) Received: from mail2.sandvine.com (Mail1.sandvine.com [64.7.137.134]) by mx1.freebsd.org (Postfix) with ESMTP id 440C48FC20 for ; Tue, 16 Feb 2010 19:04:33 +0000 (UTC) Received: from labgw2.phaedrus.sandvine.com ([192.168.3.11]) by mail2.sandvine.com with Microsoft SMTPSVC(6.0.3790.3959); Tue, 16 Feb 2010 13:52:29 -0500 Received: by labgw2.phaedrus.sandvine.com (Postfix, from userid 10332) id DA9B511714; Tue, 16 Feb 2010 13:52:30 -0500 (EST) Date: Tue, 16 Feb 2010 13:52:30 -0500 From: Ed Maste To: Attilio Rao Message-ID: <20100216185230.GA58974@sandvine.com> References: <3bbf2fe11002151610l41526f55r5e60b5e46ce42b64@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3bbf2fe11002151610l41526f55r5e60b5e46ce42b64@mail.gmail.com> User-Agent: Mutt/1.4.2.1i X-OriginalArrivalTime: 16 Feb 2010 18:52:29.0321 (UTC) FILETIME=[30620F90:01CAAF39] Cc: FreeBSD Arch Subject: Re: [PATCH] Adding shared code support for ia32 and amd64 -- x86 sub-branch X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2010 19:04:33 -0000 On Tue, Feb 16, 2010 at 01:10:37AM +0100, Attilio Rao wrote: > The following patch: > http://www.freebsd.org/~attilio/x86.diff > > starts the effort for having a shared sub-tree between amd64 and ia32. > In this initial pass I putted the low-hanging fruits (bios/cpufreq) > and what my customer was more interested in (isa/*) in order to > kick-off the effort and, in the future, move gradually the code there. > With the machine/isa/* cleanup about 10 files are trimmed and I'm sure > more can be achieved easilly. > There are few things to discuss. One, that I had not necessity to dig > about still, is about how to organize headers (include/). Maybe some > replication ala pc98 may be good. > > The patch is big but it is mostly added and removed files (look at the > files.X in order to understand better how files movements happened). > > Hope to see comments and reviews. > > Attilio As you'd expect I'd be very happy to see this cleanup go ahead; having essentially the same file duplicated in two places just adds maintenance burden. Upon a quick review the patch looks OK to me. I assume we'll "svn mv" the i386 files into x86 and then add the amd64 diffs, thus maintaining the history on the files in their new locations? -Ed From owner-freebsd-arch@FreeBSD.ORG Tue Feb 16 19:54:47 2010 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 950BC1065679; Tue, 16 Feb 2010 19:54:47 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 05F558FC14; Tue, 16 Feb 2010 19:54:46 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id o1GJsfQ8003367 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 16 Feb 2010 21:54:41 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3) with ESMTP id o1GJsfcl027520; Tue, 16 Feb 2010 21:54:41 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3/Submit) id o1GJse0V027519; Tue, 16 Feb 2010 21:54:40 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 16 Feb 2010 21:54:40 +0200 From: Kostik Belousov To: Attilio Rao Message-ID: <20100216195440.GF50403@deviant.kiev.zoral.com.ua> References: <3bbf2fe11002151610l41526f55r5e60b5e46ce42b64@mail.gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+SfteS7bOf3dGlBC" Content-Disposition: inline In-Reply-To: <3bbf2fe11002151610l41526f55r5e60b5e46ce42b64@mail.gmail.com> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: FreeBSD Arch , Ed Maste Subject: Re: [PATCH] Adding shared code support for ia32 and amd64 -- x86 sub-branch X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2010 19:54:47 -0000 --+SfteS7bOf3dGlBC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 16, 2010 at 01:10:37AM +0100, Attilio Rao wrote: > The following patch: > http://www.freebsd.org/~attilio/x86.diff >=20 > starts the effort for having a shared sub-tree between amd64 and ia32. > In this initial pass I putted the low-hanging fruits (bios/cpufreq) > and what my customer was more interested in (isa/*) in order to > kick-off the effort and, in the future, move gradually the code there. > With the machine/isa/* cleanup about 10 files are trimmed and I'm sure > more can be achieved easilly. > There are few things to discuss. One, that I had not necessity to dig > about still, is about how to organize headers (include/). Maybe some > replication ala pc98 may be good. >=20 > The patch is big but it is mostly added and removed files (look at the > files.X in order to understand better how files movements happened). >=20 > Hope to see comments and reviews. IMO the diff is unreadable. I suggest to do actual svn cp (not svn mv) operation now, without a review, and post a diff that should be applied to x86/ directory, as well as to build glue. The small proposition I have is to #define read_eflags() read_rflags() for amd64. --+SfteS7bOf3dGlBC Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAkt6+AAACgkQC3+MBN1Mb4hqbACbBB+fo9TKiGOMcOtyEaOkmeMN IEQAoMXiY3VwVWi5HJinqBGQWtPOWMYp =g2EY -----END PGP SIGNATURE----- --+SfteS7bOf3dGlBC-- From owner-freebsd-arch@FreeBSD.ORG Tue Feb 16 19:58:12 2010 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 12F23106566C for ; Tue, 16 Feb 2010 19:58:12 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-yx0-f172.google.com (mail-yx0-f172.google.com [209.85.210.172]) by mx1.freebsd.org (Postfix) with ESMTP id C154D8FC19 for ; Tue, 16 Feb 2010 19:58:11 +0000 (UTC) Received: by yxe2 with SMTP id 2so6606564yxe.7 for ; Tue, 16 Feb 2010 11:58:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type; bh=uyHLOsYK05KaDlhB0Mb5id+kzaytBJ6yY/K4bblN9tA=; b=cwPXAG0eS4jSyX3VLmdlso50fB8EoVgmv+wErbJN1bOOwHbrNm3+I0e+pmFNxG2iVX mrM9v1Cef8HIK2xXs2/iRFit1sdiIdDT8dHdfj3cS+265UwZIEOFu2U9nG4zzegWEJzF hP2/XbdrI7taQNM7ku66Guh5QbA+rRaulf1hs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=wrPiTDMY3BVTsFDMXVVS+6ef6tN38faBoCiV2aN8n+cfopb/TkvBLWzEROAADoLGko uzTzJ1sIftHCfG/ggKEuphvPp8KesuiIWRJflPHxfrCq9VMVDmXFqTUlbvzp00HG42bx MrZuVFrmuv92EMdegiCfbcYnrXJuLDuLiMFUc= MIME-Version: 1.0 Sender: asmrookie@gmail.com Received: by 10.231.153.205 with SMTP id l13mr281188ibw.64.1266350286689; Tue, 16 Feb 2010 11:58:06 -0800 (PST) In-Reply-To: <20100216195440.GF50403@deviant.kiev.zoral.com.ua> References: <3bbf2fe11002151610l41526f55r5e60b5e46ce42b64@mail.gmail.com> <20100216195440.GF50403@deviant.kiev.zoral.com.ua> Date: Tue, 16 Feb 2010 20:58:06 +0100 X-Google-Sender-Auth: da83fa64bee7a984 Message-ID: <3bbf2fe11002161158k79c09e91w1b459ab16e14b7b1@mail.gmail.com> From: Attilio Rao To: Kostik Belousov Content-Type: text/plain; charset=UTF-8 Cc: FreeBSD Arch , Ed Maste Subject: Re: [PATCH] Adding shared code support for ia32 and amd64 -- x86 sub-branch X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2010 19:58:12 -0000 2010/2/16 Kostik Belousov : > On Tue, Feb 16, 2010 at 01:10:37AM +0100, Attilio Rao wrote: >> The following patch: >> http://www.freebsd.org/~attilio/x86.diff >> >> starts the effort for having a shared sub-tree between amd64 and ia32. >> In this initial pass I putted the low-hanging fruits (bios/cpufreq) >> and what my customer was more interested in (isa/*) in order to >> kick-off the effort and, in the future, move gradually the code there. >> With the machine/isa/* cleanup about 10 files are trimmed and I'm sure >> more can be achieved easilly. >> There are few things to discuss. One, that I had not necessity to dig >> about still, is about how to organize headers (include/). Maybe some >> replication ala pc98 may be good. >> >> The patch is big but it is mostly added and removed files (look at the >> files.X in order to understand better how files movements happened). >> >> Hope to see comments and reviews. > > IMO the diff is unreadable. I suggest to do actual svn cp (not svn mv) > operation now, without a review, and post a diff that should be applied > to x86/ directory, as well as to build glue. I'm not sure what you mean here. I also thought svn mv was keeping the file history (the old cvsup repocopy) and handling directly the svn del. > The small proposition I have is to #define read_eflags() read_rflags() > for amd64. I thought about having an unified read_flags() but to do that pass later. Attilio -- Peace can only be achieved by understanding - A. Einstein From owner-freebsd-arch@FreeBSD.ORG Tue Feb 16 19:59:29 2010 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E4CF4106566B; Tue, 16 Feb 2010 19:59:29 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-qy0-f189.google.com (mail-qy0-f189.google.com [209.85.221.189]) by mx1.freebsd.org (Postfix) with ESMTP id 7D6188FC16; Tue, 16 Feb 2010 19:59:29 +0000 (UTC) Received: by qyk27 with SMTP id 27so4185588qyk.3 for ; Tue, 16 Feb 2010 11:59:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type:content-transfer-encoding; bh=D+j0hz46Eit6Apce7hy3JpD38lGu/3UyUGEd7+Rkh6U=; b=q6keUWQ1PyPEhn3qNXMKQhaaEk8nLIa+8GrllJAUKGA+q3RO02g9SwJPUORfjldTcG 8i3EGuWuBJCyYKwQNqTaja/yucz+JfNaF40+9xUQuazYQFz/t9JrS/YRQF1YFhGLji6I GbBnatxaGjSKyXHeL801sC8PMulLpmLl2c6hM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=Ni2YpjHTqXCX2wVrImW0i/SqTIY9FZ1apy4cL43DFB8tQwjrRBQKL7NZtT91YmOU6Q LdKZ52PFXkk9ee+8P7xUSqIsIJidk6LkSS+mfBweLly7THFvckR2sf+S9qNqTmEpTyKL v5X2MNcOq1U5ybbltRap26/dHTxSnQEiLN2n0= MIME-Version: 1.0 Sender: asmrookie@gmail.com Received: by 10.231.168.132 with SMTP id u4mr2084889iby.79.1266350368311; Tue, 16 Feb 2010 11:59:28 -0800 (PST) In-Reply-To: <20100216185230.GA58974@sandvine.com> References: <3bbf2fe11002151610l41526f55r5e60b5e46ce42b64@mail.gmail.com> <20100216185230.GA58974@sandvine.com> Date: Tue, 16 Feb 2010 20:59:28 +0100 X-Google-Sender-Auth: e2e51f5c70d4d25f Message-ID: <3bbf2fe11002161159l4ef33f30i7bc8eb0c2dceb943@mail.gmail.com> From: Attilio Rao To: Ed Maste Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: FreeBSD Arch Subject: Re: [PATCH] Adding shared code support for ia32 and amd64 -- x86 sub-branch X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2010 19:59:30 -0000 2010/2/16 Ed Maste : > On Tue, Feb 16, 2010 at 01:10:37AM +0100, Attilio Rao wrote: > >> The following patch: >> http://www.freebsd.org/~attilio/x86.diff >> >> starts the effort for having a shared sub-tree between amd64 and ia32. >> In this initial pass I putted the low-hanging fruits (bios/cpufreq) >> and what my customer was more interested in (isa/*) in order to >> kick-off the effort and, in the future, move gradually the code there. >> With the machine/isa/* cleanup about 10 files are trimmed and I'm sure >> more can be achieved easilly. >> There are few things to discuss. One, that I had not necessity to dig >> about still, is about how to organize headers (include/). Maybe some >> replication ala pc98 may be good. >> >> The patch is big but it is mostly added and removed files (look at the >> files.X in order to understand better how files movements happened). >> >> Hope to see comments and reviews. >> >> Attilio > > As you'd expect I'd be very happy to see this cleanup go ahead; having > essentially the same file duplicated in two places just adds maintenance > burden. > > Upon a quick review the patch looks OK to me. =C2=A0I assume we'll "svn m= v" > the i386 files into x86 and then add the amd64 diffs, thus maintaining > the history on the files in their new locations? Yes, that is what I did for generating the patch. Attilio --=20 Peace can only be achieved by understanding - A. Einstein From owner-freebsd-arch@FreeBSD.ORG Tue Feb 16 20:36:52 2010 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BCE801065672; Tue, 16 Feb 2010 20:36:52 +0000 (UTC) (envelope-from des@des.no) Received: from smtp.des.no (smtp.des.no [194.63.250.102]) by mx1.freebsd.org (Postfix) with ESMTP id 7BFEC8FC1D; Tue, 16 Feb 2010 20:36:52 +0000 (UTC) Received: from ds4.des.no (des.no [84.49.246.2]) by smtp.des.no (Postfix) with ESMTP id 5063E1FFC51; Tue, 16 Feb 2010 20:36:51 +0000 (UTC) Received: by ds4.des.no (Postfix, from userid 1001) id 28EE58457A; Tue, 16 Feb 2010 21:36:51 +0100 (CET) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Attilio Rao References: <3bbf2fe11002151610l41526f55r5e60b5e46ce42b64@mail.gmail.com> <20100216195440.GF50403@deviant.kiev.zoral.com.ua> <3bbf2fe11002161158k79c09e91w1b459ab16e14b7b1@mail.gmail.com> Date: Tue, 16 Feb 2010 21:36:51 +0100 In-Reply-To: <3bbf2fe11002161158k79c09e91w1b459ab16e14b7b1@mail.gmail.com> (Attilio Rao's message of "Tue, 16 Feb 2010 20:58:06 +0100") Message-ID: <86iq9wor30.fsf@ds4.des.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.95 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: Kostik Belousov , FreeBSD Arch , Ed Maste Subject: Re: [PATCH] Adding shared code support for ia32 and amd64 -- x86 sub-branch X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2010 20:36:52 -0000 Attilio Rao writes: > Kostik Belousov writes: > > IMO the diff is unreadable. I suggest to do actual svn cp (not svn > > mv) operation now, without a review, and post a diff that should be > > applied to x86/ directory, as well as to build glue. > I'm not sure what you mean here. I also thought svn mv was keeping the > file history (the old cvsup repocopy) and handling directly the svn > del. What he's saying is: - svn cp the files - generate and review a patch - apply the patch - fix the Makefiles - svn rm the old copies which would also preserve history. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no From owner-freebsd-arch@FreeBSD.ORG Tue Feb 16 21:07:41 2010 Return-Path: Delivered-To: arch@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 583201065672; Tue, 16 Feb 2010 21:07:41 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 1843A8FC19; Tue, 16 Feb 2010 21:07:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o1GKwqVC035119; Tue, 16 Feb 2010 13:58:53 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Tue, 16 Feb 2010 13:59:06 -0700 (MST) Message-Id: <20100216.135906.812628220523048669.imp@bsdimp.com> To: attilio@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <3bbf2fe11002151610l41526f55r5e60b5e46ce42b64@mail.gmail.com> References: <3bbf2fe11002151610l41526f55r5e60b5e46ce42b64@mail.gmail.com> X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: arch@FreeBSD.org, emaste@sandvine.com Subject: Re: [PATCH] Adding shared code support for ia32 and amd64 -- x86 sub-branch X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2010 21:07:41 -0000 In message: <3bbf2fe11002151610l41526f55r5e60b5e46ce42b64@mail.gmail.com> Attilio Rao writes: : There are few things to discuss. One, that I had not necessity to dig : about still, is about how to organize headers (include/). Maybe some : replication ala pc98 may be good. Most of the pc98 replication these days is in the form of "#include " and we install i386/include into /usr/include/i386 as well as pc98/include into /usr/include/machine. I'm working in a similar vein. For a while, one has had to specify TARGET_BIG_ENDIAN in order to build big endian MIPS or ARM binaries. This is lame. I've eliminated it and have made it possible to build mipsel, mipseb, arm or armeb binaries by setting TARGET_ARCH to one of these, while still sharing all the mips code in one directory and all the arm code in another. Warner From owner-freebsd-arch@FreeBSD.ORG Wed Feb 17 22:47:56 2010 Return-Path: Delivered-To: arch@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 38CB31065676; Wed, 17 Feb 2010 22:47:56 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id ECDD28FC0C; Wed, 17 Feb 2010 22:47:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o1HMeOjW056121; Wed, 17 Feb 2010 15:40:24 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Wed, 17 Feb 2010 15:40:39 -0700 (MST) Message-Id: <20100217.154039.1142818667055144394.imp@bsdimp.com> To: attilio@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <20100216.135906.812628220523048669.imp@bsdimp.com> References: <3bbf2fe11002151610l41526f55r5e60b5e46ce42b64@mail.gmail.com> <20100216.135906.812628220523048669.imp@bsdimp.com> X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: arch@FreeBSD.org, emaste@sandvine.com Subject: Re: [PATCH] Adding shared code support for ia32 and amd64 -- x86 sub-branch X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Feb 2010 22:47:56 -0000 In message: <20100216.135906.812628220523048669.imp@bsdimp.com> "M. Warner Losh" writes: : In message: <3bbf2fe11002151610l41526f55r5e60b5e46ce42b64@mail.gmail.com> : Attilio Rao writes: : : There are few things to discuss. One, that I had not necessity to dig : : about still, is about how to organize headers (include/). Maybe some : : replication ala pc98 may be good. : : Most of the pc98 replication these days is in the form of "#include : " and we install i386/include into /usr/include/i386 as : well as pc98/include into /usr/include/machine. : : I'm working in a similar vein. For a while, one has had to specify : TARGET_BIG_ENDIAN in order to build big endian MIPS or ARM binaries. : This is lame. I've eliminated it and have made it possible to build : mipsel, mipseb, arm or armeb binaries by setting TARGET_ARCH to one of : these, while still sharing all the mips code in one directory and all : the arm code in another. You can see the results of this work in http://people.freebsd.org/~imp/tbemd.diff the patch is a little rough, and there's an issue with make universe for mips kernels still that I need to track down[*], but otherwise it looks good. Warner [*] Well, and a bigger, meta question: if we're building all the kernels for a given MACHINE setting, and that MACHINE setting supports both endians, how do we cope (short of putting back in the big endian hacks I'm trying to eliminate). From owner-freebsd-arch@FreeBSD.ORG Thu Feb 18 02:34:05 2010 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 859FD106566B; Thu, 18 Feb 2010 02:34:05 +0000 (UTC) (envelope-from nyan@FreeBSD.org) Received: from sakura.ccs.furiru.org (sakura.ccs.furiru.org [IPv6:2001:2f0:104:8060::1]) by mx1.freebsd.org (Postfix) with ESMTP id 290E48FC13; Thu, 18 Feb 2010 02:34:05 +0000 (UTC) Received: from localhost (authenticated bits=0) by sakura.ccs.furiru.org (unknown) with ESMTP id o1I2Xs53099741; Thu, 18 Feb 2010 11:33:57 +0900 (JST) (envelope-from nyan@FreeBSD.org) Date: Thu, 18 Feb 2010 11:32:58 +0900 (JST) Message-Id: <20100218.113258.162020867.nyan@FreeBSD.org> To: imp@bsdimp.com From: TAKAHASHI Yoshihiro In-Reply-To: <20100217.154039.1142818667055144394.imp@bsdimp.com> References: <3bbf2fe11002151610l41526f55r5e60b5e46ce42b64@mail.gmail.com> <20100216.135906.812628220523048669.imp@bsdimp.com> <20100217.154039.1142818667055144394.imp@bsdimp.com> X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: attilio@freebsd.org, arch@freebsd.org, emaste@sandvine.com Subject: Re: [PATCH] Adding shared code support for ia32 and amd64 -- x86 sub-branch X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Feb 2010 02:34:05 -0000 In article <20100217.154039.1142818667055144394.imp@bsdimp.com> "M. Warner Losh" writes: > You can see the results of this work in > http://people.freebsd.org/~imp/tbemd.diff The change for sys/conf/Makefile.pc98 in this patch is incorrect. Please see my mail: http://lists.freebsd.org/pipermail/svn-src-user/2010-February/002375.html --- TAKAHASHI Yoshihiro From owner-freebsd-arch@FreeBSD.ORG Thu Feb 18 04:37:51 2010 Return-Path: Delivered-To: arch@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D1E8D1065670; Thu, 18 Feb 2010 04:37:51 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 9288A8FC0C; Thu, 18 Feb 2010 04:37:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o1I4ZH8k059358; Wed, 17 Feb 2010 21:35:17 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Wed, 17 Feb 2010 21:35:33 -0700 (MST) Message-Id: <20100217.213533.978079850573044780.imp@bsdimp.com> To: nyan@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <20100218.113258.162020867.nyan@FreeBSD.org> References: <20100216.135906.812628220523048669.imp@bsdimp.com> <20100217.154039.1142818667055144394.imp@bsdimp.com> <20100218.113258.162020867.nyan@FreeBSD.org> X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: attilio@FreeBSD.org, arch@FreeBSD.org, emaste@sandvine.com Subject: Re: [PATCH] Adding shared code support for ia32 and amd64 -- x86 sub-branch X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Feb 2010 04:37:51 -0000 In message: <20100218.113258.162020867.nyan@FreeBSD.org> TAKAHASHI Yoshihiro writes: : In article <20100217.154039.1142818667055144394.imp@bsdimp.com> : "M. Warner Losh" writes: : : > You can see the results of this work in : > http://people.freebsd.org/~imp/tbemd.diff : : The change for sys/conf/Makefile.pc98 in this patch is incorrect. : : Please see my mail: : http://lists.freebsd.org/pipermail/svn-src-user/2010-February/002375.html In theory, the Makefile.$MACHINE shouldn't need this, but I do understand how useful it is. I'll see what I can do to keep it. Warner From owner-freebsd-arch@FreeBSD.ORG Fri Feb 19 16:55:03 2010 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 031F110656B6 for ; Fri, 19 Feb 2010 16:55:02 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from gv-out-0910.google.com (gv-out-0910.google.com [216.239.58.188]) by mx1.freebsd.org (Postfix) with ESMTP id 41A5E8FC0A for ; Fri, 19 Feb 2010 16:55:01 +0000 (UTC) Received: by gv-out-0910.google.com with SMTP id y18so21648gvf.39 for ; Fri, 19 Feb 2010 08:55:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :x-enigmail-version:content-type; bh=DjDGNQcFmSNHhD1XUxAYgzMjcHlVT2MZmmrduXOkNho=; b=fD6TVStTYymSbsNUboy0Xi3AP9pP1hWUBi2P7Q8Hl2k+wQy6y5/CYh5RaLS/NhxL4j zXWqLtU05U5F0ZDlxf/TwV/PIcI6tkxoVo+jkfuTeTKV8qc81eDiD3Vsh5yCS41QQIgT uz+U/BQrh65bBYLVDiTN4Sd+bOSAmUKyuhRVs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type; b=KL6IGNJBdv8JigWj33i3TuXD7zuxuRDlPjyv7www4OrOl3ysinpVlVa9koOP3uTBnP OvcUS3zsNc/JZZ4F/ATr3/ZZG0Lc9AUHes8GLiDwFBCqK5/Qxb2LOREyFqq6rhbOLi1N Hw9486/3srsWhQdnFJn58q/gIEuJu71CKCWWk= Received: by 10.102.207.12 with SMTP id e12mr8311843mug.97.1266598500357; Fri, 19 Feb 2010 08:55:00 -0800 (PST) Received: from mavbook.mavhome.dp.ua (pc.mavhome.dp.ua [212.86.226.226]) by mx.google.com with ESMTPS id b9sm1708173mug.57.2010.02.19.08.54.58 (version=SSLv3 cipher=RC4-MD5); Fri, 19 Feb 2010 08:54:59 -0800 (PST) Sender: Alexander Motin Message-ID: <4B7EC261.5000103@FreeBSD.org> Date: Fri, 19 Feb 2010 18:54:57 +0200 From: Alexander Motin User-Agent: Thunderbird 2.0.0.23 (X11/20091212) MIME-Version: 1.0 To: Alex Samorukov References: <4B79C711.3060907@os2.kiev.ua> In-Reply-To: <4B79C711.3060907@os2.kiev.ua> X-Enigmail-Version: 0.96.0 Content-Type: multipart/mixed; boundary="------------010506020101090202080601" Cc: freebsd-arch@freebsd.org Subject: Re: changes to the IOCATAREQUEST request X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2010 16:55:03 -0000 This is a multi-part message in MIME format. --------------010506020101090202080601 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi. Alex Samorukov wrote: > The following additions are required for a reasonable pass-through ioctl: > > sys/ata.h: > > struct ata_ioc_request { > ... > int count; > int flags; > #define ATA_CMD_CONTROL 0x01 > #define ATA_CMD_READ 0x02 > #define ATA_CMD_WRITE 0x04 > #define ATA_CMD_ATAPI 0x08 > +#define ATA_CMD_48BIT 0x10 // 48-bit command > +#define ATA_CMD_NO_MULTIPLE 0x20 // one DRQ/sector > int timeout; > int error; > }; The only who really knows command format and meaning are the application and the device. SCSI is more standardized there, but ATA isn't. I think submitting flags from user-level is the only way. I did the same in CAM ATA. > Here a list of 48-bit commands (provided by Christian Franke from > latest ACS 2 draft (T13/2015-D Revision 2). The FreeBSD function > ata_modify_if_48bit() selects commands marked with *** if their 28-bit > variants are requested and 48 bit addressing is actually required. Only > in this case ATA_D_48BIT_ACTIVE is set. The other commands are not > supported, I presume. Alike approach with hardware command decoding is used in SiliconImage SATA controllers. Adding new DSM commands in ACS-2 broke them, requiring right protocol to be specifically enforced for that commands. So compiling this into stack is probably a bad idea also. Small attached patch should handle the issue. PS: Not very understand what do you mean by ATA_CMD_NO_MULTIPLE. -- Alexander Motin --------------010506020101090202080601 Content-Type: text/plain; name="ata.flags.patch" Content-Transfer-Encoding: base64 Content-Disposition: inline; filename="ata.flags.patch" KysrIHN5cy9hdGEuaC5wcmV2CTIwMTAtMDItMDMgMTI6MjA6MzYuMDAwMDAwMDAwICswMjAw Ci0tLSBzeXMvYXRhLmgJMjAxMC0wMi0xOSAxODozNzowMS4wMDAwMDAwMDAgKzAyMDAKQEAg LTQ5Niw4ICs0OTYsNiBAQCBzdHJ1Y3QgYXRhX2lvY19yZXF1ZXN0IHsKICNkZWZpbmUgQVRB X0NNRF9SRUFEICAgICAgICAgICAgICAgICAgICAweDAyCiAjZGVmaW5lIEFUQV9DTURfV1JJ VEUgICAgICAgICAgICAgICAgICAgMHgwNAogI2RlZmluZSBBVEFfQ01EX0FUQVBJICAgICAg ICAgICAgICAgICAgIDB4MDgKKyNkZWZpbmUgQVRBX0NNRF9ETUEgICAgICAgICAgICAgICAg ICAgICAweDEwCisjZGVmaW5lIEFUQV9DTURfNDhCSVQgICAgICAgICAgICAgICAgICAgMHgy MAogCiAgICAgaW50ICAgICAgICAgICAgICAgICB0aW1lb3V0OwogICAgIGludCAgICAgICAg ICAgICAgICAgZXJyb3I7Ci0tLSBkZXYvYXRhLnByZXYvYXRhLWFsbC5jCTIwMTAtMDItMDIg MTM6MjA6MTMuMDAwMDAwMDAwICswMjAwCisrKyBkZXYvYXRhL2F0YS1hbGwuYwkyMDEwLTAy LTE5IDE4OjM4OjMzLjAwMDAwMDAwMCArMDIwMApAQCAtNzE4LDYgKzcxOCwxMCBAQCBhdGFf ZGV2aWNlX2lvY3RsKGRldmljZV90IGRldiwgdV9sb25nIGNtCiAJICAgIHJlcXVlc3QtPmZs YWdzIHw9IEFUQV9SX1JFQUQ7CiAJaWYgKGlvY19yZXF1ZXN0LT5mbGFncyAmIEFUQV9DTURf V1JJVEUpCiAJICAgIHJlcXVlc3QtPmZsYWdzIHw9IEFUQV9SX1dSSVRFOworCWlmIChpb2Nf cmVxdWVzdC0+ZmxhZ3MgJiBBVEFfQ01EX0RNQSkKKwkgICAgcmVxdWVzdC0+ZmxhZ3MgfD0g QVRBX1JfRE1BOworCWlmIChpb2NfcmVxdWVzdC0+ZmxhZ3MgJiBBVEFfQ01EXzQ4QklUKQor CSAgICByZXF1ZXN0LT5mbGFncyB8PSBBVEFfUl80OEJJVDsKIAlhdGFfcXVldWVfcmVxdWVz dChyZXF1ZXN0KTsKIAlpZiAocmVxdWVzdC0+ZmxhZ3MgJiBBVEFfUl9BVEFQSSkgewogCSAg ICBiY29weSgmcmVxdWVzdC0+dS5hdGFwaS5zZW5zZSwgJmlvY19yZXF1ZXN0LT51LmF0YXBp LnNlbnNlLAo= --------------010506020101090202080601--