From owner-freebsd-rc@FreeBSD.ORG Sun Oct 24 03:26:42 2010 Return-Path: Delivered-To: rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AAE9C106564A for ; Sun, 24 Oct 2010 03:26:42 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id 3B68A8FC13 for ; Sun, 24 Oct 2010 03:26:41 +0000 (UTC) Received: by wwb24 with SMTP id 24so2166619wwb.31 for ; Sat, 23 Oct 2010 20:26:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:content-type; bh=3oQH3lVjN70VBKNIiGrZIcRLl3hZqRS29srU7a/FsjM=; b=cbkOqQDHLR4qILiK56yX3WMKI/rjOLoZvsBzWRULlFyHTw1os3bEpJJTvJ80f3g7ZI S37iY0rb0s07j1+qrHX0M/23XlVBq9/aG7YGL13B6Pw3zys3wUGxIWw5K4oRcCqT03up 6MXhaLeYdSRyb8KA/6zRsv+Ahwgq9d077KP/c= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type; b=Dh172ffcsH4piYzRBsVwMnrqhW1OXZC5Nhwct1RYa0gxFJrT3voYhxf6405pVvt4en V+TVKF9VqScw9vzLMmGMrUdz7C2h2m27gVZh0Wg7OqQLh1RCVD1rf8kD3ixyttADxSQ4 ATf5EeJbkdPaBbTf0L6vfwEDPqoczrZQpha44= MIME-Version: 1.0 Received: by 10.216.188.197 with SMTP id a47mr4546215wen.70.1287890801179; Sat, 23 Oct 2010 20:26:41 -0700 (PDT) Sender: yanegomi@gmail.com Received: by 10.216.10.198 with HTTP; Sat, 23 Oct 2010 20:26:41 -0700 (PDT) In-Reply-To: References: Date: Sat, 23 Oct 2010 20:26:41 -0700 X-Google-Sender-Auth: gSNYBcnyQS7xPcGkLONm7g5jNzM Message-ID: From: Garrett Cooper To: rc@freebsd.org Content-Type: multipart/mixed; boundary=0016e65684beb6be1504935471ec Cc: Subject: Re: [PATCH] /etc/rc.d/mdconfig improvements X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Oct 2010 03:26:42 -0000 --0016e65684beb6be1504935471ec Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Sun, Oct 10, 2010 at 8:48 PM, Garrett Cooper wrote= : > Hi RC folks, > =A0 =A0I was looking at /etc/rc.d/mdconfig* recently, and I thought of > two improvements that could be done to the scripts: > =A0 =A01. It's not overly intuitive from the rc.conf manpage that the > memory disks need to be defined in /etc/fstab, so I added an error to > coach people on what to do > =A0 =A02. There was also a missing guard for around a ${_file} reference > where if I did... > > /dev/md0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0/scratch =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0cd9660 =A0 =A0 rw > =A0 =A00 =A0 =A0 =A0 0 > /dev/md1 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0/scratch2 =A0 =A0 =A0 =A0 =A0 =A0= =A0ufs =A0 =A0 rw =A0 =A0 =A0 =A0 =A0 =A0 =A00 =A0 =A0 =A0 0 > > mdconfig_md0=3D"-f /scratch/disk.img -t vnode" > mdconfig_md1=3D"-t swap -s 1M" > > =A0 =A0... it would check test for ${_file} twice and fail the second > time. The check is benign in most cases, but for completeness it > should be fixed as shown above. > =A0 =A0Could someone please commit the attached patch for me, if no one > objects to the change proposed? (Resending with a .patch extension just in case) Does anyone have any comments about the attached patch? Thanks! -Garrett --0016e65684beb6be1504935471ec Content-Type: text/x-patch; charset=US-ASCII; name="etc-rc.d-mdconfig-improvements.patch" Content-Disposition: attachment; filename="etc-rc.d-mdconfig-improvements.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gfnctvly1 SW5kZXg6IGV0Yy9yYy5kL21kY29uZmlnCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGV0Yy9yYy5kL21kY29uZmln CShyZXZpc2lvbiAyMTM2ODApCisrKyBldGMvcmMuZC9tZGNvbmZpZwkod29ya2luZyBjb3B5KQpA QCAtMTQ2LDYgKzE0Niw4IEBACiAJCQlpZiBtb3VudCAtZCAke19kZXZ9IDI+JjEgPi9kZXYvbnVs bDsgdGhlbgogCQkJCWVjaG8gIk1vdW50aW5nICR7X2Rldn0uIgogCQkJCW1vdW50ICR7X2Rldn0K KwkJCWVsc2UKKwkJCQllcnIgMSAiTW91bnRwb2ludCBmb3IgJHtfZGV2fSBub3QgZGVmaW5lZCBp biAvZXRjL2ZzdGFiIgogCQkJZmkKIAkJZmkKIAlkb25lCkluZGV4OiBldGMvcmMuZC9tZGNvbmZp ZzIKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gZXRjL3JjLmQvbWRjb25maWcyCShyZXZpc2lvbiAyMTM2ODApCisr KyBldGMvcmMuZC9tZGNvbmZpZzIJKHdvcmtpbmcgY29weSkKQEAgLTExMyw5ICsxMTMsMTEgQEAK IAogCWZvciBfbWQgaW4gJHtfbWRjb25maWcyX2xpc3R9OyBkbwogCQlpbml0X3ZhcmlhYmxlcyAk e19tZH0KLQkJaWYgWyAhIC1yICR7X2ZpbGV9IF07IHRoZW4KLQkJCWVyciAzICIke19maWxlfSBk b2Vzbid0IGV4aXN0IgotCQkJY29udGludWUKKwkJaWYgWyAiJHt0eXBlfSIgPSAidm5vZGUiIF07 IHRoZW4KKwkJCWlmIFsgISAtciAiJHtfZmlsZX0iIF07IHRoZW4KKwkJCQllcnIgMyAiJHtfZmls ZX0gZG9lc24ndCBleGlzdCIKKwkJCQljb250aW51ZQorCQkJZmkKIAkJZmkKIAkJIyBGaXJzdCBw YXNzOiBjcmVhdGUgbWQoNCkgdm5vZGUgZGV2aWNlcyBmcm9tIGZpbGVzIHN0b3JlZCBvbgogCQkj IG5vbi1yb290IHBhcnRpdGlvbi4gU3dhcCBhbmQgbWFsbG9jIG1kKDQpIGRldmljZXMgaGF2ZSBh bHJlYWR5Cg== --0016e65684beb6be1504935471ec-- From owner-freebsd-rc@FreeBSD.ORG Sun Oct 24 03:28:42 2010 Return-Path: Delivered-To: rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3714C106564A; Sun, 24 Oct 2010 03:28:42 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-ww0-f42.google.com (mail-ww0-f42.google.com [74.125.82.42]) by mx1.freebsd.org (Postfix) with ESMTP id 8E7808FC13; Sun, 24 Oct 2010 03:28:41 +0000 (UTC) Received: by wwe15 with SMTP id 15so189512wwe.1 for ; Sat, 23 Oct 2010 20:28:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type; bh=zxLv2uT6N+PkD5ffyLH2VzF3LeCLsr2FPA6vgZxy7ok=; b=xstuiZKkKovQHvdRjqAglNEOM5r2cHuqX7on/AY+cnoqaVueGg8ctLfY7Y32FdVkIf FXv+/HGspP27zknTKWV6PlNJMBGHRA85ay4JMWVZV1Tl6FwGpw/9KMUVQDNVEePW/cU0 tt3NhogbHvyNM2tUeORx4Tg7FNiYfzaknNn0Y= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=gDbzMcoBmLg8ybMQ3nI+bi9walRt3r9aHsSz0QbbT6hTDRqDjd0LtPSh1XLnhdbxax PZbK1N538vajbpd2XAd76FvWnmqIN00VzXr6BSXcZP+JxN7PSNAs796JberCjliWh12t GmOmaAI/iXyN9Bg7IiFVirJNcUZKRBPuyE38s= MIME-Version: 1.0 Received: by 10.216.0.206 with SMTP id 56mr4598357web.33.1287890920253; Sat, 23 Oct 2010 20:28:40 -0700 (PDT) Sender: yanegomi@gmail.com Received: by 10.216.10.198 with HTTP; Sat, 23 Oct 2010 20:28:40 -0700 (PDT) In-Reply-To: References: Date: Sat, 23 Oct 2010 20:28:40 -0700 X-Google-Sender-Auth: rUtMS5ihznBU7TvVIGjn3CSXd4c Message-ID: From: Garrett Cooper To: bug-followup@freebsd.org, j.unger@jpru.de Content-Type: multipart/mixed; boundary=0016364ed9aecfab390493547883 Cc: rc@freebsd.org Subject: Re: conf/122477: [patch] /etc/rc.d/mdconfig and mdconfig2 are ignoring additional parameter in some cases X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Oct 2010 03:28:42 -0000 --0016364ed9aecfab390493547883 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Sun, Oct 10, 2010 at 9:43 PM, Garrett Cooper wrote= : > =A0 =A0IMO, the problem with this feature is lack of documentation when > it was converted from ramdisk_* to mdconfig_md*. How does this patch > work for you (you get the support you like via mdconfig_units)? > =A0 =A0This also removes all of the outdated documentation for ramdisk_* > because it's no longer used by rc(8). (Resending with a .patch extension just in case) Does anyone have any comments about the attached patch? Thanks! -Garrett --0016364ed9aecfab390493547883 Content-Type: text/x-patch; charset=US-ASCII; name="conf-122477.patch" Content-Disposition: attachment; filename="conf-122477.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gfncxivy1 SW5kZXg6IGV0Yy9yYy5kL21kY29uZmlnCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGV0Yy9yYy5kL21kY29uZmln CShyZXZpc2lvbiAyMTM2ODApCisrKyBldGMvcmMuZC9tZGNvbmZpZwkod29ya2luZyBjb3B5KQpA QCAtMTc0LDEwICsxNzQsMTEgQEAKIH0KIAogX21kY29uZmlnX2NtZD0iJDEiCitldmFsIF9tZGNv bmZpZ19saXN0PVwkbWRjb25maWdfdW5pdHMKIGlmIFsgJCMgLWd0IDAgXTsgdGhlbgogICAgICAg ICBzaGlmdAogZmkKLVsgLW4gIiQqIiBdICYmIF9tZGNvbmZpZ19saXN0PSIkKiIKK1sgLXogIiRf bWRjb25maWdfbGlzdCIgLWEgLW4gIiQqIiBdICYmIF9tZGNvbmZpZ19saXN0PSIkKiIKIAogbG9h ZF9yY19jb25maWcgJG5hbWUKIApJbmRleDogZXRjL3JjLmQvbWRjb25maWcyCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIGV0Yy9yYy5kL21kY29uZmlnMgkocmV2aXNpb24gMjEzNjgwKQorKysgZXRjL3JjLmQvbWRj b25maWcyCSh3b3JraW5nIGNvcHkpCkBAIC0yMDQsMTAgKzIwNCwxMSBAQAogfQogCiBfbWRjb25m aWcyX2NtZD0iJDEiCitldmFsIF9tZGNvbmZpZzJfbGlzdD1cJG1kY29uZmlnX3VuaXRzCiBpZiBb ICQjIC1ndCAwIF07IHRoZW4KICAgICAgICAgc2hpZnQKIGZpCi1bIC1uICIkKiIgXSAmJiBfbWRj b25maWcyX2xpc3Q9IiQqIgorWyAteiAiJF9tZGNvbmZpZzJfbGlzdCIgLWEgLW4gIiQqIiBdICYm IF9tZGNvbmZpZzJfbGlzdD0iJCoiCiAKIGxvYWRfcmNfY29uZmlnICRuYW1lCiAKSW5kZXg6IHNo YXJlL21hbi9tYW41L3JjLmNvbmYuNQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBzaGFyZS9tYW4vbWFuNS9yYy5j b25mLjUJKHJldmlzaW9uIDIxMzY4MCkKKysrIHNoYXJlL21hbi9tYW41L3JjLmNvbmYuNQkod29y a2luZyBjb3B5KQpAQCAtMzk5Nyw2ICszOTk3LDIzIEBACiB3aGljaCBjYXVzZXMgbG9nIGZpbGVz IGZsYWdnZWQgd2l0aCBhCiAuQ20gQwogdG8gYmUgY3JlYXRlZC4KKy5JdCBWYSBtZGNvbmZpZ191 bml0cworLlBxIFZ0IHN0cgorQSBsaXN0IG9mIG9uZSBvciBtb3JlCisuWHIgbWQgNAordW5pdHMg dG8gY29uZmlndXJlIHdpdGgKKy5YciBtZGNvbmZpZyA4CithbmQKKy5YciBuZXdmcyA4CitpbiB0 aW1lIHRvIGJlIG1vdW50ZWQgd2l0aAorLlhyIGZzdGFiIDUgLgorSWYgdW5zcGVjaWZpZWQsIHRo ZQorLlZhIG1kY29uZmlnX21kIE5zIEFxIEFyIFgKK3ZhcmlhYmxlcyBhcmUgZXZhbHVhdGVkIGlu IGNvbnNlY3V0aXZlIG9yZGVyIGZyb20gbWQwLCB1bnRpbCBvbmUgdmFyaWFibGUgaXMKK3Vuc2V0 IG9yIG51bGwuCitTZWUgdGhlCisuVmEgbWRjb25maWdfbWQgTnMgQXEgQXIgWAordmFyaWFibGUg ZGVzY3JpcHRpb25zIGJlbG93IGZvciBtb3JlIGRldGFpbHMuCiAuSXQgVmEgbWRjb25maWdfbWQg TnMgQXEgQXIgWAogLlBxIFZ0IHN0cgogQXJndW1lbnRzIHRvCkBAIC00MDE1LDEwICs0MDMyLDEy IEBACiAuRmwgZiBBciBmaWxlCiBmb3Igdm5vZGUgYmFja2VkCiAuWHIgbWQgNAotZGV2aWNlcy4K LU5vdGUgdGhhdAorZGV2aWNlcy4gRWFjaAogLlZhIG1kY29uZmlnX21kIE5zIEFxIEFyIFgKLXZh cmlhYmxlcyBhcmUgZXZhbHVhdGVkIHVudGlsIG9uZSB2YXJpYWJsZSBpcyB1bnNldCBvciBudWxs LgorZW50cnkgbGlzdGVkIGluCisuVmEgbWRjb25maWdfdW5pdHMKK211c3QgYmUgZGVmaW5lZCBp bgorLlhyIGZzdGFiIDUgLgogLkl0IFZhIG1kY29uZmlnX21kIE5zIEFvIEFyIFggQWMgTnMgVmEg X25ld2ZzCiAuUHEgVnQgc3RyCiBPcHRpb25hbCBhcmd1bWVudHMgcGFzc2VkIHRvCkBAIC00MDgy LDY1ICs0MTAxLDYgQEAKIC5CZCAtbGl0ZXJhbAogbWRjb25maWdfbWQwX2NtZD0idGFyIHhmekMg L3Zhci9maWxlLnRneiBcZSR7X21wfSIKIC5FZAotLkl0IFZhIHJhbWRpc2tfdW5pdHMKLS5QcSBW dCBzdHIKLUEgbGlzdCBvZiBvbmUgb3IgbW9yZSByYW1kaXNrIHVuaXRzIHRvIGNvbmZpZ3VyZSB3 aXRoCi0uWHIgbWRjb25maWcgOAotYW5kCi0uWHIgbmV3ZnMgOAotaW4gdGltZSB0byBiZSBtb3Vu dGVkIGZyb20KLS5YciBmc3RhYiA1IC4KLUVhY2ggbGlzdGVkIHVuaXQKLS5BciBYCi1tdXN0IHNw ZWNpZnkgYXQgbGVhc3QgYQotLkFyIHR5cGUKLWluIGEKLS5WYSByYW1kaXNrXyBOcyBBbyBBciBY IEFjIE5zIFZhIF9jb25maWcKLXZhcmlhYmxlLgotTm90ZSB0aGF0IHRoaXMgd2F5IHRvIGNvbmZp Z3VyZSByYW1kaXNrcyBoYXMgYmVlbiBkZXByZWNhdGVkCi1pbiBmYXZvciBvZiBuZXcKLS5WYSBt ZGNvbmZpZ19tZCoKLXZhcmlhYmxlcyAoc2VlIGFib3ZlKS4KLS5JdCBWYSByYW1kaXNrXyBOcyBB byBBciBYIEFjIE5zIFZhIF9jb25maWcKLS5QcSBWdCBzdHIKLUFyZ3VtZW50cyB0bwotLlhyIG1k Y29uZmlnIDgKLWZvciByYW1kaXNrCi0uQXIgWCAuCi1BdCBtaW5pbXVtIGEKLS5GbCB0IEFyIHR5 cGUKLW11c3QgYmUgc3BlY2lmaWVkLCB3aGVyZQotLkFyIHR5cGUKLW11c3QgYmUgb25lIG9mCi0u Q20gbWFsbG9jCi1vcgotLkNtIHN3YXAgLgotLkl0IFZhIHJhbWRpc2tfIE5zIEFvIEFyIFggQWMg TnMgVmEgX25ld2ZzCi0uUHEgVnQgc3RyCi1PcHRpb25hbCBhcmd1bWVudHMgcGFzc2VkIHRvCi0u WHIgbmV3ZnMgOAotdG8gaW5pdGlhbGl6ZSByYW1kaXNrCi0uQXIgWCAuCi0uSXQgVmEgcmFtZGlz a18gTnMgQW8gQXIgWCBBYyBOcyBWYSBfb3duZXIKLS5QcSBWdCBzdHIKLUFuIG93bmVyc2hpcCBz cGVjaWZpY2F0aW9uIHBhc3NlZCB0bwotLlhyIGNob3duIDgKLWFmdGVyIHRoZSBzcGVjaWZpZWQg cmFtZGlzayB1bml0Ci0uQXIgWAotaGFzIGJlZW4gbW91bnRlZC4KLUJvdGggdGhlCi0uWHIgbWQg NAotZGV2aWNlIGFuZCB0aGUgbW91bnQgcG9pbnQgd2lsbCBiZSBjaGFuZ2VkLgotLkl0IFZhIHJh bWRpc2tfIE5zIEFvIEFyIFggQWMgTnMgVmEgX3Blcm1zCi0uUHEgVnQgc3RyCi1BIG1vZGUgc3Ry aW5nIHBhc3NlZCB0bwotLlhyIGNobW9kIDEKLWFmdGVyIHRoZSBzcGVjaWZpZWQgcmFtZGlzayB1 bml0Ci0uQXIgWAotaGFzIGJlZW4gbW91bnRlZC4KLUJvdGggdGhlCi0uWHIgbWQgNAotZGV2aWNl IGFuZCB0aGUgbW91bnQgcG9pbnQgd2lsbCBiZSBjaGFuZ2VkLgogLkl0IFZhIGF1dG9icmlkZ2Vf aW50ZXJmYWNlcwogLlBxIFZ0IHN0cgogU2V0IHRvIHRoZSBsaXN0IG9mIGJyaWRnZSBpbnRlcmZh Y2VzIHRoYXQgd2lsbCBoYXZlIG5ld2x5IGFycml2aW5nIGludGVyZmFjZXMK --0016364ed9aecfab390493547883-- From owner-freebsd-rc@FreeBSD.ORG Sun Oct 24 03:30:15 2010 Return-Path: Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9636C1065673 for ; Sun, 24 Oct 2010 03:30:15 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 83C8C8FC17 for ; Sun, 24 Oct 2010 03:30:15 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o9O3UFIC052143 for ; Sun, 24 Oct 2010 03:30:15 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o9O3UFEo052139; Sun, 24 Oct 2010 03:30:15 GMT (envelope-from gnats) Date: Sun, 24 Oct 2010 03:30:15 GMT Message-Id: <201010240330.o9O3UFEo052139@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org From: Garrett Cooper Cc: Subject: Re: conf/122477: [patch] /etc/rc.d/mdconfig and mdconfig2 are ignoring additional parameter in some cases X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Garrett Cooper List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Oct 2010 03:30:15 -0000 The following reply was made to PR conf/122477; it has been noted by GNATS. From: Garrett Cooper To: bug-followup@freebsd.org, j.unger@jpru.de Cc: rc@freebsd.org Subject: Re: conf/122477: [patch] /etc/rc.d/mdconfig and mdconfig2 are ignoring additional parameter in some cases Date: Sat, 23 Oct 2010 20:28:40 -0700 --0016364ed9aecfab390493547883 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Sun, Oct 10, 2010 at 9:43 PM, Garrett Cooper wrote= : > =A0 =A0IMO, the problem with this feature is lack of documentation when > it was converted from ramdisk_* to mdconfig_md*. How does this patch > work for you (you get the support you like via mdconfig_units)? > =A0 =A0This also removes all of the outdated documentation for ramdisk_* > because it's no longer used by rc(8). (Resending with a .patch extension just in case) Does anyone have any comments about the attached patch? Thanks! -Garrett --0016364ed9aecfab390493547883 Content-Type: text/x-patch; charset=US-ASCII; name="conf-122477.patch" Content-Disposition: attachment; filename="conf-122477.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gfncxivy1 SW5kZXg6IGV0Yy9yYy5kL21kY29uZmlnCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGV0Yy9yYy5kL21kY29uZmln CShyZXZpc2lvbiAyMTM2ODApCisrKyBldGMvcmMuZC9tZGNvbmZpZwkod29ya2luZyBjb3B5KQpA QCAtMTc0LDEwICsxNzQsMTEgQEAKIH0KIAogX21kY29uZmlnX2NtZD0iJDEiCitldmFsIF9tZGNv bmZpZ19saXN0PVwkbWRjb25maWdfdW5pdHMKIGlmIFsgJCMgLWd0IDAgXTsgdGhlbgogICAgICAg ICBzaGlmdAogZmkKLVsgLW4gIiQqIiBdICYmIF9tZGNvbmZpZ19saXN0PSIkKiIKK1sgLXogIiRf bWRjb25maWdfbGlzdCIgLWEgLW4gIiQqIiBdICYmIF9tZGNvbmZpZ19saXN0PSIkKiIKIAogbG9h ZF9yY19jb25maWcgJG5hbWUKIApJbmRleDogZXRjL3JjLmQvbWRjb25maWcyCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIGV0Yy9yYy5kL21kY29uZmlnMgkocmV2aXNpb24gMjEzNjgwKQorKysgZXRjL3JjLmQvbWRj b25maWcyCSh3b3JraW5nIGNvcHkpCkBAIC0yMDQsMTAgKzIwNCwxMSBAQAogfQogCiBfbWRjb25m aWcyX2NtZD0iJDEiCitldmFsIF9tZGNvbmZpZzJfbGlzdD1cJG1kY29uZmlnX3VuaXRzCiBpZiBb ICQjIC1ndCAwIF07IHRoZW4KICAgICAgICAgc2hpZnQKIGZpCi1bIC1uICIkKiIgXSAmJiBfbWRj b25maWcyX2xpc3Q9IiQqIgorWyAteiAiJF9tZGNvbmZpZzJfbGlzdCIgLWEgLW4gIiQqIiBdICYm IF9tZGNvbmZpZzJfbGlzdD0iJCoiCiAKIGxvYWRfcmNfY29uZmlnICRuYW1lCiAKSW5kZXg6IHNo YXJlL21hbi9tYW41L3JjLmNvbmYuNQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBzaGFyZS9tYW4vbWFuNS9yYy5j b25mLjUJKHJldmlzaW9uIDIxMzY4MCkKKysrIHNoYXJlL21hbi9tYW41L3JjLmNvbmYuNQkod29y a2luZyBjb3B5KQpAQCAtMzk5Nyw2ICszOTk3LDIzIEBACiB3aGljaCBjYXVzZXMgbG9nIGZpbGVz IGZsYWdnZWQgd2l0aCBhCiAuQ20gQwogdG8gYmUgY3JlYXRlZC4KKy5JdCBWYSBtZGNvbmZpZ191 bml0cworLlBxIFZ0IHN0cgorQSBsaXN0IG9mIG9uZSBvciBtb3JlCisuWHIgbWQgNAordW5pdHMg dG8gY29uZmlndXJlIHdpdGgKKy5YciBtZGNvbmZpZyA4CithbmQKKy5YciBuZXdmcyA4CitpbiB0 aW1lIHRvIGJlIG1vdW50ZWQgd2l0aAorLlhyIGZzdGFiIDUgLgorSWYgdW5zcGVjaWZpZWQsIHRo ZQorLlZhIG1kY29uZmlnX21kIE5zIEFxIEFyIFgKK3ZhcmlhYmxlcyBhcmUgZXZhbHVhdGVkIGlu IGNvbnNlY3V0aXZlIG9yZGVyIGZyb20gbWQwLCB1bnRpbCBvbmUgdmFyaWFibGUgaXMKK3Vuc2V0 IG9yIG51bGwuCitTZWUgdGhlCisuVmEgbWRjb25maWdfbWQgTnMgQXEgQXIgWAordmFyaWFibGUg ZGVzY3JpcHRpb25zIGJlbG93IGZvciBtb3JlIGRldGFpbHMuCiAuSXQgVmEgbWRjb25maWdfbWQg TnMgQXEgQXIgWAogLlBxIFZ0IHN0cgogQXJndW1lbnRzIHRvCkBAIC00MDE1LDEwICs0MDMyLDEy IEBACiAuRmwgZiBBciBmaWxlCiBmb3Igdm5vZGUgYmFja2VkCiAuWHIgbWQgNAotZGV2aWNlcy4K LU5vdGUgdGhhdAorZGV2aWNlcy4gRWFjaAogLlZhIG1kY29uZmlnX21kIE5zIEFxIEFyIFgKLXZh cmlhYmxlcyBhcmUgZXZhbHVhdGVkIHVudGlsIG9uZSB2YXJpYWJsZSBpcyB1bnNldCBvciBudWxs LgorZW50cnkgbGlzdGVkIGluCisuVmEgbWRjb25maWdfdW5pdHMKK211c3QgYmUgZGVmaW5lZCBp bgorLlhyIGZzdGFiIDUgLgogLkl0IFZhIG1kY29uZmlnX21kIE5zIEFvIEFyIFggQWMgTnMgVmEg X25ld2ZzCiAuUHEgVnQgc3RyCiBPcHRpb25hbCBhcmd1bWVudHMgcGFzc2VkIHRvCkBAIC00MDgy LDY1ICs0MTAxLDYgQEAKIC5CZCAtbGl0ZXJhbAogbWRjb25maWdfbWQwX2NtZD0idGFyIHhmekMg L3Zhci9maWxlLnRneiBcZSR7X21wfSIKIC5FZAotLkl0IFZhIHJhbWRpc2tfdW5pdHMKLS5QcSBW dCBzdHIKLUEgbGlzdCBvZiBvbmUgb3IgbW9yZSByYW1kaXNrIHVuaXRzIHRvIGNvbmZpZ3VyZSB3 aXRoCi0uWHIgbWRjb25maWcgOAotYW5kCi0uWHIgbmV3ZnMgOAotaW4gdGltZSB0byBiZSBtb3Vu dGVkIGZyb20KLS5YciBmc3RhYiA1IC4KLUVhY2ggbGlzdGVkIHVuaXQKLS5BciBYCi1tdXN0IHNw ZWNpZnkgYXQgbGVhc3QgYQotLkFyIHR5cGUKLWluIGEKLS5WYSByYW1kaXNrXyBOcyBBbyBBciBY IEFjIE5zIFZhIF9jb25maWcKLXZhcmlhYmxlLgotTm90ZSB0aGF0IHRoaXMgd2F5IHRvIGNvbmZp Z3VyZSByYW1kaXNrcyBoYXMgYmVlbiBkZXByZWNhdGVkCi1pbiBmYXZvciBvZiBuZXcKLS5WYSBt ZGNvbmZpZ19tZCoKLXZhcmlhYmxlcyAoc2VlIGFib3ZlKS4KLS5JdCBWYSByYW1kaXNrXyBOcyBB byBBciBYIEFjIE5zIFZhIF9jb25maWcKLS5QcSBWdCBzdHIKLUFyZ3VtZW50cyB0bwotLlhyIG1k Y29uZmlnIDgKLWZvciByYW1kaXNrCi0uQXIgWCAuCi1BdCBtaW5pbXVtIGEKLS5GbCB0IEFyIHR5 cGUKLW11c3QgYmUgc3BlY2lmaWVkLCB3aGVyZQotLkFyIHR5cGUKLW11c3QgYmUgb25lIG9mCi0u Q20gbWFsbG9jCi1vcgotLkNtIHN3YXAgLgotLkl0IFZhIHJhbWRpc2tfIE5zIEFvIEFyIFggQWMg TnMgVmEgX25ld2ZzCi0uUHEgVnQgc3RyCi1PcHRpb25hbCBhcmd1bWVudHMgcGFzc2VkIHRvCi0u WHIgbmV3ZnMgOAotdG8gaW5pdGlhbGl6ZSByYW1kaXNrCi0uQXIgWCAuCi0uSXQgVmEgcmFtZGlz a18gTnMgQW8gQXIgWCBBYyBOcyBWYSBfb3duZXIKLS5QcSBWdCBzdHIKLUFuIG93bmVyc2hpcCBz cGVjaWZpY2F0aW9uIHBhc3NlZCB0bwotLlhyIGNob3duIDgKLWFmdGVyIHRoZSBzcGVjaWZpZWQg cmFtZGlzayB1bml0Ci0uQXIgWAotaGFzIGJlZW4gbW91bnRlZC4KLUJvdGggdGhlCi0uWHIgbWQg NAotZGV2aWNlIGFuZCB0aGUgbW91bnQgcG9pbnQgd2lsbCBiZSBjaGFuZ2VkLgotLkl0IFZhIHJh bWRpc2tfIE5zIEFvIEFyIFggQWMgTnMgVmEgX3Blcm1zCi0uUHEgVnQgc3RyCi1BIG1vZGUgc3Ry aW5nIHBhc3NlZCB0bwotLlhyIGNobW9kIDEKLWFmdGVyIHRoZSBzcGVjaWZpZWQgcmFtZGlzayB1 bml0Ci0uQXIgWAotaGFzIGJlZW4gbW91bnRlZC4KLUJvdGggdGhlCi0uWHIgbWQgNAotZGV2aWNl IGFuZCB0aGUgbW91bnQgcG9pbnQgd2lsbCBiZSBjaGFuZ2VkLgogLkl0IFZhIGF1dG9icmlkZ2Vf aW50ZXJmYWNlcwogLlBxIFZ0IHN0cgogU2V0IHRvIHRoZSBsaXN0IG9mIGJyaWRnZSBpbnRlcmZh Y2VzIHRoYXQgd2lsbCBoYXZlIG5ld2x5IGFycml2aW5nIGludGVyZmFjZXMK --0016364ed9aecfab390493547883-- From owner-freebsd-rc@FreeBSD.ORG Mon Oct 25 11:07:08 2010 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6FD981065670 for ; Mon, 25 Oct 2010 11:07:08 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 51E238FC0C for ; Mon, 25 Oct 2010 11:07:08 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o9PB7841088871 for ; Mon, 25 Oct 2010 11:07:08 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o9PB77ok088869 for freebsd-rc@FreeBSD.org; Mon, 25 Oct 2010 11:07:07 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 25 Oct 2010 11:07:07 GMT Message-Id: <201010251107.o9PB77ok088869@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-rc@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-rc@FreeBSD.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Oct 2010 11:07:08 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o conf/151063 rc [rc.subr] Verify network link and packet flow before s o conf/150752 rc [rc.subr] [patch] be not needed to eval $_pidcmd on re o conf/150474 rc [patch] rc.d/accounting: Add ability to set location o o conf/149867 rc [PATCH] rc.d script to manage multiple FIBS (kern opti o conf/149831 rc [PATCH] add support to /etc/rc.d/jail for delegating Z o conf/148961 rc [PATCH] netstart and network_ipv6 contains references o conf/148656 rc rc.firewall(8): {oip} and {iip} variables in rc.firewa o conf/147685 rc [rc.d] [patch] new feature for /etc/rc.d/fsck o conf/147444 rc [rc.d] [patch] /etc/rc.d/zfs stop not called on reboot o conf/146053 rc [patch] [request] shutdown of jails breaks inter-jail o conf/145445 rc [rc.d] error in /etc/rc.d/jail (bad logic) o conf/145440 rc [rc.d] [patch] add multiple fib support (setfib) in /e o conf/145399 rc [patch] rc.d scripts are unable to start/stop programs o conf/145344 rc [patch] Fix kitchen sink approach for rc.d scripts ins o conf/145009 rc [patch] rc.subr(8): rc.conf should allow mac label con o conf/144213 rc [rc.d] [patch] Disappearing zvols on reboot o conf/143637 rc [patch] ntpdate(8) support for ntp-servers supplied by o conf/143085 rc [patch] ftp-proxy(8) rc(8) with multiple instances o conf/143084 rc [jail] [patch]: fix rc.d/jail creating stray softlinks o conf/142973 rc [jail] [patch] Strange counter init value in jail rc o conf/142434 rc [patch] Add cpuset(1) support to rc.subr(8) o conf/142304 rc rc.conf(5): mdconfig and mdconfig2 rc.d scripts lack e o conf/141909 rc rc.subr(8): [patch] add rc.conf.d support to /usr/loca o conf/141907 rc [rc.d] Bug if mtu (maybe others?) is set as first argu o conf/141678 rc [patch] A minor enhancement to how /etc/rc.d/jail dete o conf/141275 rc [request] dhclient(8) rc script should print something o conf/140440 rc [patch] allow local command files in rc.{suspend,resum o conf/140261 rc [patch] Improve flexibility of mdconfig2 startup scrip o conf/138208 rc [rc.d] [patch] Making rc.firewall (workstation) IPv6 a o conf/137629 rc [rc.d] background_dhclient rc.conf option causing doub o conf/137470 rc [PATCH] /etc/rc.d/mdconfig2 : prioritize cli parameter o conf/137271 rc [rc.d] Cannot update /etc/host.conf when root filesyst o conf/136875 rc [request] _flags appending o conf/136624 rc [rc.d] sysctl variables for ipnat are not applied on b o conf/135338 rc [rc.d] pf startup order seems broken [regression] o conf/134918 rc [patch] rc.subr fails to detect perl daemons o conf/134660 rc [patch] rc-script for initializing ng_netflow+ng_ipfw o conf/134333 rc PPP configuration problem in the rc.d scripts in combi o conf/134006 rc [patch] Unload console screensaver kernel modules if s o conf/133987 rc [rc.d] defaultroute broken with DHCP in some cases o conf/133890 rc [patch] sshd(8): add multiple profiles to the rc.d scr o conf/132483 rc rc.subr(8) [patch] setfib(1) support for rc.subr o conf/132476 rc [rc.d] [patch] add support setfib(1) in rc.d/routing o conf/128299 rc [patch] /etc/rc.d/geli does not mount partitions using o conf/127917 rc [patch] dumpon rejects on start with physmem>swap even o bin/126562 rc rcorder(8) fails to run unrelated startup scripts when o conf/126392 rc [patch] rc.conf ifconfig_xx keywords cannot be escaped p bin/126324 rc [patch] rc.d/tmp: Prevent mounting /tmp in second tim o conf/124747 rc [patch] savecore can't create dump from encrypted swap o conf/124248 rc [jail] [patch] add support for nice value for rc.d/jai o conf/123734 rc [patch] Chipset VIA CX700 requires extra initializatio o conf/123222 rc [patch] Add rtprio(1)/idprio(1) support to rc.subr(8). o conf/122968 rc [rc.d] /etc/rc.d/addswap: md swapfile multiplication a o conf/122477 rc [patch] /etc/rc.d/mdconfig and mdconfig2 are ignoring o conf/122170 rc [patch] [request] New feature: notify admin via page o o kern/121566 rc [nfs] [request] [patch] ethernet iface should be broug o conf/120431 rc [patch] devfs.rules are not initialized under certain o conf/120406 rc [devd] [patch] Handle newly attached pcm devices (eg. o conf/119874 rc [patch] "/etc/rc.d/pf reload" fails if there are macro o conf/119076 rc [patch] [rc.d] /etc/rc.d/netif tries to remove alias a o bin/118325 rc [patch] [request] new periodic script to test statuses o conf/118255 rc savecore never finding kernel core dumps (rcorder prob o conf/117935 rc [patch] ppp fails to start at boot because of missing o conf/113915 rc [patch] ndis wireless driver fails to associate when i o conf/109980 rc /etc/rc.d/netif restart doesn't destroy cloned_interfa o conf/109562 rc [rc.d] [patch] [request] Make rc.d/devfs usable from c o conf/108589 rc rtsol(8) fails due to default ipfw rules o conf/106009 rc [ppp] [patch] [request] Fix pppoed startup script to p o conf/105689 rc [ppp] [request] syslogd starts too late at boot o conf/105568 rc [patch] [request] Add more flexibility to rc.conf, to o conf/105145 rc [ppp] [patch] [request] add redial function to rc.d/pp o conf/104549 rc [patch] rc.d/nfsd needs special _find_processes functi o conf/102700 rc [geli] [patch] Add encrypted /tmp support to GELI/GBDE o conf/99721 rc [patch] /etc/rc.initdiskless problem copy dotfile in s o conf/99444 rc [patch] Enhancement: rc.subr could easily support star o conf/96343 rc [patch] rc.d order change to start inet6 before pf o conf/93815 rc [patch] Adds in the ability to save ipfw rules to rc.d o conf/92523 rc [patch] allow rc scripts to kill process after a timeo o conf/89870 rc [patch] [request] make netif verbose rc.conf toggle o conf/89061 rc [patch] IPv6 6to4 auto-configuration enhancement o conf/88913 rc [patch] wrapper support for rc.subr o conf/85819 rc [patch] script allowing multiuser mode in spite of fsc o kern/81006 rc ipnat not working with tunnel interfaces on startup o conf/77663 rc Suggestion: add /etc/rc.d/addnetswap after addcritremo o conf/73677 rc [patch] add support for powernow states to power_profi o conf/58939 rc [patch] dumb little hack for /etc/rc.firewall{,6} o conf/56934 rc [patch] rc.firewall rules for natd expect an interface o conf/45226 rc [patch] Fix for rc.network, ppp-user annoyance o conf/44170 rc [patch] Add ability to run multiple pppoed(8) on start 89 problems total.