From owner-freebsd-drivers@FreeBSD.ORG Mon May 9 12:56:02 2011 Return-Path: Delivered-To: freebsd-drivers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D49881065680 for ; Mon, 9 May 2011 12:56:02 +0000 (UTC) (envelope-from s10111@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id A1ACA8FC0C for ; Mon, 9 May 2011 12:56:02 +0000 (UTC) Received: by iyj12 with SMTP id 12so6121079iyj.13 for ; Mon, 09 May 2011 05:56:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:date:message-id:subject:from:to :content-type; bh=9TlR4A+ydBubs41RTemfv9L2q0/RyQglQF5/FieJixI=; b=VhqTJGwE/oZpnzim73TWrlUqE7GM+f4DxPUKAaE+qj/ioNyGPIRZLpLMe3xI1gSEvv vQo0mAW5TkCutByqzy38NXFkx4e9Fd/YF4V38kZziRXiXWTlA2d34vPS+JHOP6kyXiIh ZsJ554OPgVkkY0GQZOL382BpjsaiPgC5CjEss= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=u9TPuA0o0+E7wuBhiPRbN6TY/xn7iUjfnlfKSb9y8JvjTR6gc7ea9CmCKY5nLmw6gr WlcSpogebqg1Xw+ahG66suPGAvMagDKh1dfvvQpmpV4avUF/qs1WRYtG/mPLPXZRAN57 rRudocDJDQwoMBwxvOfFMG4enuZekKxkU6xXE= MIME-Version: 1.0 Received: by 10.231.126.195 with SMTP id d3mr4420030ibs.16.1304944195500; Mon, 09 May 2011 05:29:55 -0700 (PDT) Received: by 10.231.19.72 with HTTP; Mon, 9 May 2011 05:29:55 -0700 (PDT) Date: Mon, 9 May 2011 16:29:55 +0400 Message-ID: From: Sergy Goncharov To: freebsd-drivers@freebsd.org Content-Type: text/plain; charset=UTF-8 Subject: re(4) incompatible revision X-BeenThere: freebsd-drivers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Writing device drivers for FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 May 2011 12:56:02 -0000 Hello There is the issue with the revision of chip FreeBSD 8.2-RELEASE #0 CPU: Intel(R) Atom(TM) CPU N550 @ 1.50GHz (1496.26-MHz 686-class CPU) inside the HP Mini 210-2204er none1@pci0:3:0:0: class=0x020000 card=0x1584103c chip=0x813610ec rev=0x05 hdr=0x00 vendor = 'Realtek Semiconductor' device = 'Realtek 10/100/1000 PCI-E NIC Family all in one NDIS Driver v5.728.0604.2009 06/04/2009 (Rtl8023)' class = network subclass = ethernet cap 01[40] = powerspec 3 supports D0 D1 D2 D3 current D0 cap 05[50] = MSI supports 1 message, 64 bit cap 10[70] = PCI-Express 2 endpoint IRQ 2 max data 128(128) link x1(x1) cap 11[b0] = MSI-X supports 4 messages in map 0x20 cap 03[d0] = VPD ecap 0001[100] = AER 1 0 fatal 0 non-fatal 1 corrected ecap 0002[140] = VC 1 max VC0 ecap 0003[160] = Serial 1 99010000364ce000 # kldload if_re re0: port 0x1000-0x10ff mem 0x92004000-0x92004fff,0x92000000-0x92003fff irq 19 at device 0.0 on pci3 re0: Using 1 MSI message re0: Chip rev. 0x40800000 re0: MAC rev. 0x00000000 re0: Unknown H/W revision: 0x40800000 device_attach: re0 attach returned 6 The command ifconfig shows nothing about re0 interface. Can someone help me to solve this problem? -Sergey From owner-freebsd-drivers@FreeBSD.ORG Mon May 9 15:03:15 2011 Return-Path: Delivered-To: freebsd-drivers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ECD361065670 for ; Mon, 9 May 2011 15:03:15 +0000 (UTC) (envelope-from henrik@brixandersen.dk) Received: from solow.pil.dk (relay.pil.dk [195.41.47.164]) by mx1.freebsd.org (Postfix) with ESMTP id 318468FC17 for ; Mon, 9 May 2011 15:03:14 +0000 (UTC) Received: from druadan.brixandersen.dk (0x55534f5f.adsl.cybercity.dk [85.83.79.95]) by solow.pil.dk (Postfix) with ESMTPA id F0B201CC00D; Mon, 9 May 2011 16:47:16 +0200 (CEST) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="Apple-Mail-2-227723083" From: Henrik Brix Andersen In-Reply-To: Date: Mon, 9 May 2011 16:47:17 +0200 Content-Transfer-Encoding: 7bit Message-Id: <6DDBF409-330E-4E41-BD08-33A63E877047@brixandersen.dk> References: To: Sergy Goncharov X-Pgp-Agent: GPGMail 1.3.3 X-Mailer: Apple Mail (2.1084) Cc: freebsd-drivers@freebsd.org Subject: Re: re(4) incompatible revision X-BeenThere: freebsd-drivers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Writing device drivers for FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 May 2011 15:03:16 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --Apple-Mail-2-227723083 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Hi Sergy, On May 9, 2011, at 14:29, Sergy Goncharov wrote: > # kldload if_re > re0: port > 0x1000-0x10ff mem 0x92004000-0x92004fff,0x92000000-0x92003fff irq 19 > at device 0.0 on pci3 > re0: Using 1 MSI message > re0: Chip rev. 0x40800000 > re0: MAC rev. 0x00000000 > re0: Unknown H/W revision: 0x40800000 > device_attach: re0 attach returned 6 Looks like an RTL8105E PCIe Fast Ethernet controller. Support for this = device was added in r217911, see = http://svnweb.freebsd.org/base?view=3Drevision&revision=3D217911 For now, it is only supported by FreeBSD 9-CURRENT, but back-porting the = patch should be trivial. Regards, Brix --=20 Henrik Brix Andersen --Apple-Mail-2-227723083 content-type: application/pgp-signature; x-mac-type=70674453; name=PGP.sig content-description: This is a digitally signed message part content-disposition: inline; filename=PGP.sig content-transfer-encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Darwin) iEYEARECAAYFAk3H/nUACgkQv+Q4flTiePjY2wCeJWf7wV5k/ygNHEKUPJeXl1mr kdQAn0GUhJfiCCbC2gkqd8VSJx+YO87d =6cOY -----END PGP SIGNATURE----- --Apple-Mail-2-227723083-- From owner-freebsd-drivers@FreeBSD.ORG Mon May 9 17:10:56 2011 Return-Path: Delivered-To: freebsd-drivers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6957710657D1 for ; Mon, 9 May 2011 17:10:56 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from mail-pv0-f182.google.com (mail-pv0-f182.google.com [74.125.83.182]) by mx1.freebsd.org (Postfix) with ESMTP id 3BD6C8FC15 for ; Mon, 9 May 2011 17:10:55 +0000 (UTC) Received: by pvg11 with SMTP id 11so3212870pvg.13 for ; Mon, 09 May 2011 10:10:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:date:to:cc:subject:message-id:reply-to :references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=CyzAliQVsUqg8ZhnNVCuN7doLe97ZKdpyvbgCAPXcqY=; b=RUx2Zqo3597Dsioml8YLVZ+kuK6H0sqkSKNfAL1bIb21nKLrTRpd0apOnyWwqavgdj QyJKt59cyk7iQPu3cU49xGMZIfJJSUMhdSpbbUpf9UNGog/apaBM/phcWZ1RAnlDySbH Y6HZ0Ty0JW0ZzHmmQ7mG37zoJt32ugYoo5onw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:date:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=xcTTRHz6ULwFsm9pBuh3nBFr+BljcMpNYpMPNN037EwFVEENLJGQi3am4NGnyddLQ5 xpIQb97o+j7MaRQ9HXCgL2w3AJM5aiZ7Oy9NVenFimEMh/zEzGtKmGcL6j3dHIwb16qk btGuIG5c+0QidPZPFS42KiR8CLomSPnrvwX2I= Received: by 10.68.20.9 with SMTP id j9mr10421269pbe.440.1304959240737; Mon, 09 May 2011 09:40:40 -0700 (PDT) Received: from pyunyh@gmail.com ([174.35.1.224]) by mx.google.com with ESMTPS id 10sm3761984pbo.48.2011.05.09.09.40.37 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 09 May 2011 09:40:38 -0700 (PDT) Received: by pyunyh@gmail.com (sSMTP sendmail emulation); Mon, 09 May 2011 09:39:57 -0700 From: YongHyeon PYUN Date: Mon, 9 May 2011 09:39:57 -0700 To: Sergy Goncharov Message-ID: <20110509163957.GA4936@michelle.cdnetworks.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i Cc: freebsd-drivers@freebsd.org Subject: Re: re(4) incompatible revision X-BeenThere: freebsd-drivers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Writing device drivers for FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 May 2011 17:10:56 -0000 On Mon, May 09, 2011 at 04:29:55PM +0400, Sergy Goncharov wrote: > Hello > > There is the issue with the revision of chip > > FreeBSD 8.2-RELEASE #0 > > CPU: Intel(R) Atom(TM) CPU N550 @ 1.50GHz (1496.26-MHz 686-class > CPU) inside the HP Mini 210-2204er > > none1@pci0:3:0:0: class=0x020000 card=0x1584103c chip=0x813610ec > rev=0x05 hdr=0x00 > vendor = 'Realtek Semiconductor' > device = 'Realtek 10/100/1000 PCI-E NIC Family all in one NDIS > Driver v5.728.0604.2009 06/04/2009 (Rtl8023)' > class = network > subclass = ethernet > cap 01[40] = powerspec 3 supports D0 D1 D2 D3 current D0 > cap 05[50] = MSI supports 1 message, 64 bit > cap 10[70] = PCI-Express 2 endpoint IRQ 2 max data 128(128) link x1(x1) > cap 11[b0] = MSI-X supports 4 messages in map 0x20 > cap 03[d0] = VPD > ecap 0001[100] = AER 1 0 fatal 0 non-fatal 1 corrected > ecap 0002[140] = VC 1 max VC0 > ecap 0003[160] = Serial 1 99010000364ce000 > > # kldload if_re > re0: port > 0x1000-0x10ff mem 0x92004000-0x92004fff,0x92000000-0x92003fff irq 19 > at device 0.0 on pci3 > re0: Using 1 MSI message > re0: Chip rev. 0x40800000 > re0: MAC rev. 0x00000000 Your controller is RTL8105E PCIe Fast Etherent. Support for that controller was added after releasing 8.2-RELEASE. Either update to latest stable/8 or back port required changes(r217911). > re0: Unknown H/W revision: 0x40800000 > device_attach: re0 attach returned 6 > > The command ifconfig shows nothing about re0 interface. > > Can someone help me to solve this problem? > > -Sergey From owner-freebsd-drivers@FreeBSD.ORG Thu May 12 22:02:55 2011 Return-Path: Delivered-To: freebsd-drivers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7393F106566C; Thu, 12 May 2011 22:02:55 +0000 (UTC) (envelope-from brix@FreeBSD.org) Received: from solow.pil.dk (relay.pil.dk [195.41.47.164]) by mx1.freebsd.org (Postfix) with ESMTP id DB1658FC08; Thu, 12 May 2011 22:02:54 +0000 (UTC) Received: from druadan.brixandersen.dk (0x55534f5f.adsl.cybercity.dk [85.83.79.95]) by solow.pil.dk (Postfix) with ESMTPA id 402631CC015; Thu, 12 May 2011 23:45:18 +0200 (CEST) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="Apple-Mail-3-512000088" From: Henrik Brix Andersen In-Reply-To: <201103141028.57324.jhb@freebsd.org> Date: Thu, 12 May 2011 23:45:14 +0200 Content-Transfer-Encoding: 7bit Message-Id: <87F8ACF6-822B-41E3-B832-890F7F68ABA2@FreeBSD.org> References: <3550EA55-ADDE-40AC-9C22-1FAC441A0BC8@freebsd.org> <0A707516-C7D1-4441-B17B-1273B6C256B0@FreeBSD.org> <201103141028.57324.jhb@freebsd.org> To: John Baldwin X-Pgp-Agent: GPGMail 1.3.3 X-Mailer: Apple Mail (2.1084) Cc: freebsd-drivers@freebsd.org Subject: Re: Allocating resources to isab children X-BeenThere: freebsd-drivers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Writing device drivers for FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 May 2011 22:02:55 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --Apple-Mail-3-512000088 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Hi John, On Mar 14, 2011, at 15:28, John Baldwin wrote: > On Sunday, March 13, 2011 12:12:59 pm Henrik Brix Andersen wrote: >> On Mar 12, 2011, at 20:47, Henrik Brix Andersen wrote: >> I have a patch ready for allowing the PCI-ISA bridge to proxy = SYS_RES_MEMORY=20 > and SYS_RES_IOPORT resource allocations from direct children to the = parent PCI=20 > bus. >> The patch is available from here: = http://people.freebsd.org/~brix/src- > patches/isa_pci.c.diff >=20 > Yes, I think this looks good. Having completed the driver for the I2C host bus controller, I have = revised the patch a little. The updated patch is available at = http://people.freebsd.org/~brix/src-patches/isa_pci.c.diff I would appreciate it if you could find the time to review this and - if = possible - approve a commit of this patch. The patch for the glxiic(4) I2C host bus driver is available at = http://people.freebsd.org/~brix/src-patches/glxiic.diff - if somebody = could find the time to review this as well, I would be very grateful. = Since I do not have a commit bit for src, I will eventually need an = approval for this to enter the tree as well. Regards, Brix --=20 Henrik Brix Andersen --Apple-Mail-3-512000088 content-type: application/pgp-signature; x-mac-type=70674453; name=PGP.sig content-description: This is a digitally signed message part content-disposition: inline; filename=PGP.sig content-transfer-encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Darwin) iEYEARECAAYFAk3MVOoACgkQv+Q4flTiePib/ACfYhYVhzXDFhcrWUOtq9y/7f9a ynkAn185GOHE2QeCoiAk1Dl/VM0CADs7 =+lzK -----END PGP SIGNATURE----- --Apple-Mail-3-512000088-- From owner-freebsd-drivers@FreeBSD.ORG Fri May 13 01:40:57 2011 Return-Path: Delivered-To: freebsd-drivers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4B9F9106564A; Fri, 13 May 2011 01:40:57 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 19BFF8FC08; Fri, 13 May 2011 01:40:57 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 9CF2146B2C; Thu, 12 May 2011 21:40:56 -0400 (EDT) Received: from John-Baldwins-Macbook-Pro.local (unknown [24.114.252.233]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id E786E8A01B; Thu, 12 May 2011 21:40:55 -0400 (EDT) Message-ID: <4DCC8C27.2010605@FreeBSD.org> Date: Thu, 12 May 2011 21:40:55 -0400 From: John Baldwin User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.17) Gecko/20110414 Thunderbird/3.1.10 MIME-Version: 1.0 To: Henrik Brix Andersen References: <3550EA55-ADDE-40AC-9C22-1FAC441A0BC8@freebsd.org> <0A707516-C7D1-4441-B17B-1273B6C256B0@FreeBSD.org> <201103141028.57324.jhb@freebsd.org> <87F8ACF6-822B-41E3-B832-890F7F68ABA2@FreeBSD.org> In-Reply-To: <87F8ACF6-822B-41E3-B832-890F7F68ABA2@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Thu, 12 May 2011 21:40:56 -0400 (EDT) Cc: freebsd-drivers@freebsd.org Subject: Re: Allocating resources to isab children X-BeenThere: freebsd-drivers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Writing device drivers for FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 May 2011 01:40:57 -0000 On 5/12/11 5:45 PM, Henrik Brix Andersen wrote: > Hi John, > > On Mar 14, 2011, at 15:28, John Baldwin wrote: >> On Sunday, March 13, 2011 12:12:59 pm Henrik Brix Andersen wrote: >>> On Mar 12, 2011, at 20:47, Henrik Brix Andersen wrote: >>> I have a patch ready for allowing the PCI-ISA bridge to proxy SYS_RES_MEMORY >> and SYS_RES_IOPORT resource allocations from direct children to the parent PCI >> bus. >>> The patch is available from here: http://people.freebsd.org/~brix/src- >> patches/isa_pci.c.diff >> >> Yes, I think this looks good. > > Having completed the driver for the I2C host bus controller, I have revised the patch a little. > The updated patch is available at http://people.freebsd.org/~brix/src-patches/isa_pci.c.diff A few cosmetic nits: - I would use 'isab_pci_*' rather than 'isa_pci_*' as it is an ISA bridge rather than an ISA bus device. - You can probably leave out the blank line in isa[b]_pci_attach() between bus_generic_probe() and isab_attach(). Other than that, you are fine to commit this with a reviewed by from me. > I would appreciate it if you could find the time to review this and - if possible - approve a commit of this patch. > > The patch for the glxiic(4) I2C host bus driver is available at http://people.freebsd.org/~brix/src-patches/glxiic.diff - if somebody could find the time to review this as well, I would be very grateful. Since I do not have a commit bit for src, I will eventually need an approval for this to enter the tree as well. This mostly looks good to me. I can't evaluate the actual driver logic, but the new-bus, etc. bits look fine. One thing is that since you use callout_init_mtx(), I don't think you need any of the callout stuff at the start of your timeout routine (callout_pending/active/deactivate). With callout_init_mtx() your callout will only be called if it is active. That is the only nit that I saw however. -- John Baldwin From owner-freebsd-drivers@FreeBSD.ORG Fri May 13 15:26:39 2011 Return-Path: Delivered-To: freebsd-drivers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EA7C7106566C; Fri, 13 May 2011 15:26:39 +0000 (UTC) (envelope-from brix@FreeBSD.org) Received: from solow.pil.dk (relay.pil.dk [195.41.47.164]) by mx1.freebsd.org (Postfix) with ESMTP id A752B8FC13; Fri, 13 May 2011 15:26:39 +0000 (UTC) Received: from druadan.brixandersen.dk (0x55534f5f.adsl.cybercity.dk [85.83.79.95]) by solow.pil.dk (Postfix) with ESMTPA id 3431A1CC003; Fri, 13 May 2011 17:26:34 +0200 (CEST) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="Apple-Mail-6-575674460" From: Henrik Brix Andersen In-Reply-To: <4DCC8C27.2010605@FreeBSD.org> Date: Fri, 13 May 2011 17:26:28 +0200 Content-Transfer-Encoding: 7bit Message-Id: <501C355E-0107-4185-8B47-C6D55ED71CB2@FreeBSD.org> References: <3550EA55-ADDE-40AC-9C22-1FAC441A0BC8@freebsd.org> <0A707516-C7D1-4441-B17B-1273B6C256B0@FreeBSD.org> <201103141028.57324.jhb@freebsd.org> <87F8ACF6-822B-41E3-B832-890F7F68ABA2@FreeBSD.org> <4DCC8C27.2010605@FreeBSD.org> To: John Baldwin X-Pgp-Agent: GPGMail 1.3.3 X-Mailer: Apple Mail (2.1084) Cc: freebsd-drivers@freebsd.org Subject: Re: Allocating resources to isab children X-BeenThere: freebsd-drivers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Writing device drivers for FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 May 2011 15:26:40 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --Apple-Mail-6-575674460 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On May 13, 2011, at 03:40, John Baldwin wrote: > On 5/12/11 5:45 PM, Henrik Brix Andersen wrote: >>=20 >> Having completed the driver for the I2C host bus controller, I have = revised the patch a little. >> The updated patch is available at = http://people.freebsd.org/~brix/src-patches/isa_pci.c.diff >=20 > A few cosmetic nits: >=20 > - I would use 'isab_pci_*' rather than 'isa_pci_*' as it is an ISA = bridge rather than an ISA bus device. > - You can probably leave out the blank line in isa[b]_pci_attach() = between bus_generic_probe() and isab_attach(). >=20 > Other than that, you are fine to commit this with a reviewed by from = me. Thank you, committed with the changes suggested above. >> I would appreciate it if you could find the time to review this and - = if possible - approve a commit of this patch. >>=20 >> The patch for the glxiic(4) I2C host bus driver is available at = http://people.freebsd.org/~brix/src-patches/glxiic.diff - if somebody = could find the time to review this as well, I would be very grateful. = Since I do not have a commit bit for src, I will eventually need an = approval for this to enter the tree as well. >=20 > This mostly looks good to me. I can't evaluate the actual driver = logic, but the new-bus, etc. bits look fine. One thing is that since = you use callout_init_mtx(), I don't think you need any of the callout = stuff at the start of your timeout routine = (callout_pending/active/deactivate). With callout_init_mtx() your = callout will only be called if it is active. That is the only nit that = I saw however. Ah, right - thanks. I have updated the patch and retested without = issues. Since it seems we lack an official iicbus(4) maintainer (?), perhaps I = should post this patch on the freebsd-embedded@ mailing list for review = (as the CS5536 and I2C are often found in combination on SBCs such as = the Alix boards from PC Engines). Hopefully somebody will be able to = review the actual driver logic and provide approval. Regards, Brix --=20 Henrik Brix Andersen --Apple-Mail-6-575674460 content-type: application/pgp-signature; x-mac-type=70674453; name=PGP.sig content-description: This is a digitally signed message part content-disposition: inline; filename=PGP.sig content-transfer-encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Darwin) iEYEARECAAYFAk3NTaQACgkQv+Q4flTiePjSxgCgswUS5A7yE+/aJW4dsp+r/VyL ZPIAoMb53dYbCd5jBQBxppaVuJgE88Tj =6mo8 -----END PGP SIGNATURE----- --Apple-Mail-6-575674460-- From owner-freebsd-drivers@FreeBSD.ORG Fri May 13 16:18:32 2011 Return-Path: Delivered-To: freebsd-drivers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 280E3106566C; Fri, 13 May 2011 16:18:32 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id EED2D8FC16; Fri, 13 May 2011 16:18:31 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 9DFB546B60; Fri, 13 May 2011 12:18:31 -0400 (EDT) Received: from John-Baldwins-Macbook-Pro.local (unknown [192.75.139.253]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id E8B178A01B; Fri, 13 May 2011 12:18:30 -0400 (EDT) Message-ID: <4DCD59D6.1050909@FreeBSD.org> Date: Fri, 13 May 2011 12:18:30 -0400 From: John Baldwin User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.17) Gecko/20110414 Thunderbird/3.1.10 MIME-Version: 1.0 To: Henrik Brix Andersen References: <3550EA55-ADDE-40AC-9C22-1FAC441A0BC8@freebsd.org> <0A707516-C7D1-4441-B17B-1273B6C256B0@FreeBSD.org> <201103141028.57324.jhb@freebsd.org> <87F8ACF6-822B-41E3-B832-890F7F68ABA2@FreeBSD.org> <4DCC8C27.2010605@FreeBSD.org> <501C355E-0107-4185-8B47-C6D55ED71CB2@FreeBSD.org> In-Reply-To: <501C355E-0107-4185-8B47-C6D55ED71CB2@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Fri, 13 May 2011 12:18:31 -0400 (EDT) Cc: freebsd-drivers@freebsd.org Subject: Re: Allocating resources to isab children X-BeenThere: freebsd-drivers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Writing device drivers for FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 May 2011 16:18:32 -0000 On 5/13/11 11:26 AM, Henrik Brix Andersen wrote: > On May 13, 2011, at 03:40, John Baldwin wrote: >> On 5/12/11 5:45 PM, Henrik Brix Andersen wrote: >>> I would appreciate it if you could find the time to review this and - if possible - approve a commit of this patch. >>> >>> The patch for the glxiic(4) I2C host bus driver is available at http://people.freebsd.org/~brix/src-patches/glxiic.diff - if somebody could find the time to review this as well, I would be very grateful. Since I do not have a commit bit for src, I will eventually need an approval for this to enter the tree as well. >> >> This mostly looks good to me. I can't evaluate the actual driver logic, but the new-bus, etc. bits look fine. One thing is that since you use callout_init_mtx(), I don't think you need any of the callout stuff at the start of your timeout routine (callout_pending/active/deactivate). With callout_init_mtx() your callout will only be called if it is active. That is the only nit that I saw however. > > Ah, right - thanks. I have updated the patch and retested without issues. > > Since it seems we lack an official iicbus(4) maintainer (?), perhaps I should post this patch on the freebsd-embedded@ mailing list for review (as the CS5536 and I2C are often found in combination on SBCs such as the Alix boards from PC Engines). Hopefully somebody will be able to review the actual driver logic and provide approval. Yes, that is fine. In general when I fixed the locking in iicbus(4) it was not easy to get reviews, so if you don't hear anything after a week or so, go ahead and commit it. -- John Baldwin From owner-freebsd-drivers@FreeBSD.ORG Sat May 14 21:54:22 2011 Return-Path: Delivered-To: freebsd-drivers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 36758106566C for ; Sat, 14 May 2011 21:54:22 +0000 (UTC) (envelope-from dieterbsd@engineer.com) Received: from mailout-us.mail.com (mailout-us.gmx.com [74.208.5.67]) by mx1.freebsd.org (Postfix) with SMTP id 046E38FC0C for ; Sat, 14 May 2011 21:54:21 +0000 (UTC) Received: (qmail 3610 invoked by uid 0); 14 May 2011 21:54:21 -0000 Received: from 67.206.162.139 by rms-us012.v300.gmx.net with HTTP Content-Type: text/plain; charset="utf-8" Date: Sat, 14 May 2011 21:54:17 +0000 From: "Dieter BSD" Message-ID: <20110514215419.227500@gmx.com> MIME-Version: 1.0 To: mav@freebsd.org X-Authenticated: #74169980 X-Flags: 0001 X-Mailer: GMX.com Web Mailer x-registered: 0 Content-Transfer-Encoding: 8bit X-GMX-UID: XL6ECpY/zXKnJhiIXHAyf7I6OWhhagfi Cc: freebsd-drivers@freebsd.org Subject: Siis(4) does not play well with others! :-( X-BeenThere: freebsd-drivers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Writing device drivers for FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 May 2011 21:54:22 -0000 FreeBSD 8.2 amd64 With improvements to siis(4) and ahci(4) by Alexander Motin from approx 2011-04-13. SiI3132 SATA controller Port Multiplier 37261095 1706 kernel: siisch3: siis_wait_ready() calling DELAY(1000) kernel: siisch3: siis_wait_ready() calling DELAY(1000) kernel: siisch3: Error while READ LOG EXT kernel: siisch3: siis_wait_ready() calling DELAY(1000) kernel: siisch3: SIIS reset... kernel: siisch3: siis_sata_connect() calling DELAY(1000) kernel: siisch3: SATA connect time=1ms status=00000123 kernel: siisch3: SIIS reset done: devices=00000001 kernel: siisch3: siis_wait_ready() calling DELAY(1000) kernel: siisch3: siis_wait_ready() calling DELAY(1000) kernel: siisch3: Error while READ LOG EXT kernel: siisch3: siis_wait_ready() calling DELAY(1000) kernel: siisch3: SIIS reset... kernel: siisch3: siis_sata_connect() calling DELAY(1000) kernel: siisch3: SATA connect time=1ms status=00000123 kernel: siisch3: SIIS reset done: devices=00000001 kernel: siisch3: siis_wait_ready() calling DELAY(1000) ... kernel: siisch3: Timeout on slot 30 kernel: siisch3: siis_timeout is 00040000 ss 60000000 rs 60000000 es 00000000 sts 801e2000 serr 00000000 kernel: siisch3:  ... waiting for slots 20000000 kernel: siisch3: Timeout on slot 29 kernel: siisch3: siis_timeout is 00040000 ss 60000000 rs 60000000 es 00000000 sts 801e2000 serr 00000000 kernel: siisch3: SIIS reset... kernel: siisch3: siis_sata_connect() calling DELAY(1000) kernel: siisch3: SATA connect time=1ms status=00000123 kernel: siisch3: SIIS reset done: devices=00000001 kernel: siisch3: siis_wait_ready() calling DELAY(1000) /usr/sbin/cron[3369]: (root) CMD (/usr/libexec/atrun -l 10) kernel: siisch3: Timeout on slot 29 kernel: siisch3: siis_timeout is 00040000 ss 20000000 rs 20000000 es 00000000 sts 801f2000 serr 00000000 kernel: siisch3: SIIS reset... kernel: siisch3: siis_sata_connect() calling DELAY(1000) kernel: siisch3: SATA connect time=1ms status=00000123 kernel: siisch3: SIIS reset done: devices=00000001 kernel: siisch3: siis_wait_ready() calling DELAY(1000) /usr/sbin/cron[3373]: (root) CMD (/usr/libexec/atrun -l 10) kernel: siisch3: Timeout on slot 29 kernel: siisch3: siis_timeout is 00040000 ss 20000000 rs 20000000 es 00000000 sts 801f2000 serr 00000000 kernel: siisch3: SIIS reset... kernel: siisch3: siis_sata_connect() calling DELAY(1000) kernel: siisch3: SATA connect time=1ms status=00000123 kernel: siisch3: SIIS reset done: devices=00000001 kernel: siisch3: siis_wait_ready() calling DELAY(1000) kernel: (ada9:siisch3:0:4:0): lost device kernel: siisch3: Timeout on slot 29 kernel: siisch3: siis_timeout is 00040000 ss 30000000 rs 30000000 es 00000000 sts 801f2000 serr 00000000 kernel: siisch3:  ... waiting for slots 10000000 kernel: siisch3: Timeout on slot 28 kernel: siisch3: siis_timeout is 00040000 ss 30000000 rs 30000000 es 00000000 sts 801f2000 serr 00000000 kernel: siisch3: siis_wait_ready() calling DELAY(1000) kernel: siisch3: SIIS reset... kernel: siisch3: siis_sata_connect() calling DELAY(1000) kernel: siisch3: SATA connect time=1ms status=00000123 kernel: siisch3: SIIS reset done: devices=00000001 ... kernel: siisch3: siis_wait_ready() calling DELAY(1000) last message repeated 2 times kernel: siisch3: SIIS reset... kernel: siisch3: siis_sata_connect() calling DELAY(1000) kernel: siisch3: SATA connect time=1ms status=00000123 kernel: siisch3: SIIS reset done: devices=00000001 kernel: siisch3: siis_wait_ready() calling DELAY(1000) last message repeated 2 times kernel: siisch3: SIIS reset... kernel: siisch3: siis_sata_connect() calling DELAY(1000) kernel: siisch3: SATA connect time=1ms status=00000123 kernel: siisch3: siis_wait_ready() calling DELAY(1000) last message repeated 1001 times kernel: siisch3: port is not ready (timeout 1000ms) status = 001f2000 kernel: siisch3: port ready timeout kernel: siisch3: trying full port reset ... kernel: siisch3: siis_reset() calling DELAY(10000) kernel: siisch3: siis_wait_ready() calling DELAY(1000) ... I have LEDs connected to the PM and they were flashing on and off together, but not in a normal disk access pattern. This might be due to a bad disk.  Next time the machine is free I'll move the disk to a different port and see if the problem follows the disk or stays with that PM port. Problem is that this time, siis(4) didn't "just" lock out Ethernet, but nearly the entire machine. Tried to log in on the RS-232 console, getty was running, but login hung on the password.  One Ethernet (PCI card ed(4)) would respond to ping but not to telnet.  Another Ethernet (onboard bge(4)) would not even respond to a ping. The reset button stopped the PM LEDS flashing, but didn't reboot the machine.  Had to power cycle to get the machine back up. Incoming data was lost due to this.  :-( None of the disks connected to the siis controllers have any system partitions,  They are user data only.  The root partition is on the nforce controller, all other system partitions and swap are on the ahci controller. So regardless of whatever problem this PM or disk might have, unrelated system activity such as logging in on the console, responding to ping and telnet, etc. should not have been affected. Siis(4) needs to learn how to play well with others!