From owner-freebsd-arch@FreeBSD.ORG Sun Jun 17 02:35:13 2012 Return-Path: Delivered-To: arch@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5C946106566B; Sun, 17 Jun 2012 02:35:13 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from fallbackmx08.syd.optusnet.com.au (fallbackmx08.syd.optusnet.com.au [211.29.132.10]) by mx1.freebsd.org (Postfix) with ESMTP id C96408FC14; Sun, 17 Jun 2012 02:35:12 +0000 (UTC) Received: from mail36.syd.optusnet.com.au (mail36.syd.optusnet.com.au [211.29.133.76]) by fallbackmx08.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id q5H2Z4rX010071; Sun, 17 Jun 2012 12:35:04 +1000 Received: from c122-106-171-232.carlnfd1.nsw.optusnet.com.au (c122-106-171-232.carlnfd1.nsw.optusnet.com.au [122.106.171.232]) by mail36.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id q5H2YtEF010697 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 17 Jun 2012 12:34:56 +1000 Date: Sun, 17 Jun 2012 12:34:54 +1000 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Robert Millan In-Reply-To: Message-ID: <20120617123021.D933@besplex.bde.org> References: <20120526235510.GB90668@ithaqua.etoilebsd.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: arch@FreeBSD.org, Baptiste Daroussin Subject: Re: switch tounconditionnal boostrapping while to build the tree X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Jun 2012 02:35:13 -0000 On Sat, 16 Jun 2012, Robert Millan wrote: > 2012/5/27 Baptiste Daroussin : >> so if no one care I'll remove the condition to boostrap at least yacc(1) and >> lex(1) on current, 9, 8 and 7. > > While we are at it, would you mind if ${YACC} was set to "byacc" on current? > > This would make sys.mk re-usable on systems where "yacc" is a symlink > to bison (e.g. Debian). This is probably not permitted in the POSIX case. POSIX specifies: % 23836 Default Rules % 23837 The default rules for make shall achieve results that are the same as if the following were used. % ... % 23850 YACC=yacc If YACC=yacc were used, then it would achieves different results from YACC=byacc if yacc is a link to bison; therefore, YACC=byacc would be a bug. It seems wrong for FreeBSD's sys.mk to support non-BSD systems anyway. Bruce From owner-freebsd-arch@FreeBSD.ORG Sun Jun 17 05:12:30 2012 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0829C1065673 for ; Sun, 17 Jun 2012 05:12:30 +0000 (UTC) (envelope-from andrew@fubar.geek.nz) Received: from smtp5.clear.net.nz (smtp5.clear.net.nz [203.97.33.68]) by mx1.freebsd.org (Postfix) with ESMTP id C5ECB8FC0A for ; Sun, 17 Jun 2012 05:12:29 +0000 (UTC) Received: from mxin3-orange.clear.net.nz (lb2-srcnat.clear.net.nz [203.97.32.237]) by smtp5.clear.net.nz (CLEAR Net Mail) with ESMTP id <0M5Q007K6X47V520@smtp5.clear.net.nz> for arch@freebsd.org; Sun, 17 Jun 2012 17:12:07 +1200 (NZST) Received: from 202-0-48-19.paradise.net.nz (HELO localhost) ([202.0.48.19]) by smtpin32.paradise.net.nz with ESMTP; Sun, 17 Jun 2012 17:12:06 +1200 Date: Sun, 17 Jun 2012 17:11:25 +1200 From: Andrew Turner To: arch@freebsd.org Message-id: <20120617171125.18836c93@fubar.geek.nz> MIME-version: 1.0 X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.6; i386-portbld-freebsd8.0) Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Pirate: Arrrr Cc: Subject: wchar_t change for ARM EABI X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Jun 2012 05:12:30 -0000 I have a patch at [1] to move the wchar_t type definition from to I would like feedback on. The need for this change is the ARM EABI requires wchar_t to be either an unsigned int or an unsigned short, with the former preferred. I have only made the change for ARM in the patch but if it looks correct I will update all arch's. Andrew [1] http://people.freebsd.org/~andrew/wchar_unsigned.diff From owner-freebsd-arch@FreeBSD.ORG Sun Jun 17 16:43:06 2012 Return-Path: Delivered-To: arch@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id DDAC61065672 for ; Sun, 17 Jun 2012 16:43:06 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 995938FC0C for ; Sun, 17 Jun 2012 16:43:06 +0000 (UTC) Received: from 63.imp.bsdimp.com (63.imp.bsdimp.com [10.0.0.63]) (authenticated bits=0) by harmony.bsdimp.com (8.14.4/8.14.3) with ESMTP id q5HGgMSA014570 (version=TLSv1/SSLv3 cipher=DHE-DSS-AES128-SHA bits=128 verify=NO); Sun, 17 Jun 2012 10:42:23 -0600 (MDT) (envelope-from imp@bsdimp.com) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Warner Losh In-Reply-To: <20120617171125.18836c93@fubar.geek.nz> Date: Sun, 17 Jun 2012 10:42:22 -0600 Content-Transfer-Encoding: 7bit Message-Id: References: <20120617171125.18836c93@fubar.geek.nz> To: Andrew Turner X-Mailer: Apple Mail (2.1084) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (harmony.bsdimp.com [10.0.0.6]); Sun, 17 Jun 2012 10:42:23 -0600 (MDT) Cc: arch@FreeBSD.org Subject: Re: wchar_t change for ARM EABI X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Jun 2012 16:43:07 -0000 These changes look good. Warner On Jun 16, 2012, at 11:11 PM, Andrew Turner wrote: > I have a patch at [1] to move the wchar_t type definition from > to I would like feedback on. The need > for this change is the ARM EABI requires wchar_t to be either an > unsigned int or an unsigned short, with the former preferred. > > I have only made the change for ARM in the patch but if it looks > correct I will update all arch's. > > Andrew > > [1] http://people.freebsd.org/~andrew/wchar_unsigned.diff > _______________________________________________ > freebsd-arch@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-arch > To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org" > > From owner-freebsd-arch@FreeBSD.ORG Tue Jun 19 11:46:00 2012 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E78461065672 for ; Tue, 19 Jun 2012 11:46:00 +0000 (UTC) (envelope-from andrew@fubar.geek.nz) Received: from smtp5.clear.net.nz (smtp5.clear.net.nz [203.97.33.68]) by mx1.freebsd.org (Postfix) with ESMTP id B107D8FC1E for ; Tue, 19 Jun 2012 11:46:00 +0000 (UTC) Received: from mxin1-orange.clear.net.nz (lb2-srcnat.clear.net.nz [203.97.32.237]) by smtp5.clear.net.nz (CLEAR Net Mail) with ESMTP id <0M5V005D34OIOS20@smtp5.clear.net.nz> for arch@freebsd.org; Tue, 19 Jun 2012 23:45:54 +1200 (NZST) Received: from 202-0-48-19.paradise.net.nz (HELO localhost) ([202.0.48.19]) by smtpin1.paradise.net.nz with ESMTP; Tue, 19 Jun 2012 23:45:54 +1200 Date: Tue, 19 Jun 2012 23:45:20 +1200 From: Andrew Turner In-reply-to: <20120617171125.18836c93@fubar.geek.nz> To: arch@freebsd.org Message-id: <20120619234520.76121ece@fubar.geek.nz> MIME-version: 1.0 X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.6; i386-portbld-freebsd8.0) Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Pirate: Arrrr References: <20120617171125.18836c93@fubar.geek.nz> Cc: Subject: Re: wchar_t change for ARM EABI X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jun 2012 11:46:01 -0000 On Sun, 17 Jun 2012 17:11:25 +1200 Andrew Turner wrote: > I have a patch at [1] to move the wchar_t type definition from > to I would like feedback on. The > need for this change is the ARM EABI requires wchar_t to be either an > unsigned int or an unsigned short, with the former preferred. I have an updated patch at [1]. This moves __WCHAR_MIN/__WCHAR_MAX from to as they are limits rather than types. Does anybody see any issues with this? If not I'll update it for all architectures and commit later in the week. Andrew [1] http://people.freebsd.org/~andrew/wchar_unsigned_1.diff From owner-freebsd-arch@FreeBSD.ORG Tue Jun 19 15:47:43 2012 Return-Path: Delivered-To: arch@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 485771065673 for ; Tue, 19 Jun 2012 15:47:43 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail01.syd.optusnet.com.au (mail01.syd.optusnet.com.au [211.29.132.182]) by mx1.freebsd.org (Postfix) with ESMTP id D6B3F8FC25 for ; Tue, 19 Jun 2012 15:47:42 +0000 (UTC) Received: from c122-106-171-232.carlnfd1.nsw.optusnet.com.au (c122-106-171-232.carlnfd1.nsw.optusnet.com.au [122.106.171.232]) by mail01.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id q5JFlYoV018706 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 20 Jun 2012 01:47:35 +1000 Date: Wed, 20 Jun 2012 01:47:34 +1000 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Andrew Turner In-Reply-To: <20120619234520.76121ece@fubar.geek.nz> Message-ID: <20120620011811.X2306@besplex.bde.org> References: <20120617171125.18836c93@fubar.geek.nz> <20120619234520.76121ece@fubar.geek.nz> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: arch@FreeBSD.org Subject: Re: wchar_t change for ARM EABI X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jun 2012 15:47:43 -0000 On Tue, 19 Jun 2012, Andrew Turner wrote: > On Sun, 17 Jun 2012 17:11:25 +1200 > Andrew Turner wrote: > >> I have a patch at [1] to move the wchar_t type definition from >> to I would like feedback on. The >> need for this change is the ARM EABI requires wchar_t to be either an >> unsigned int or an unsigned short, with the former preferred. > > I have an updated patch at [1]. This moves __WCHAR_MIN/__WCHAR_MAX from > to as they are limits rather > than types. Does anybody see any issues with this? If not I'll update it > for all architectures and commit later in the week. I hoped to keep the types and limits closer together, especially for the types that are declared in . has mainly limits for basic (non-typedefed) types. The exceptions were just for size_t, ssize_t, off_t, and *quad_t (ugh). > [1] http://people.freebsd.org/~andrew/wchar_unsigned_1.diff % Index: sys/sys/_types.h % =================================================================== % --- sys/sys/_types.h (revision 237150) % +++ sys/sys/_types.h (working copy) % @@ -81,13 +81,12 @@ % * % * NOTE: rune_t is not covered by ANSI nor other standards, and should not % * be instantiated outside of lib/libc/locale. Use wchar_t. wchar_t and % - * rune_t must be the same type. Also, wint_t must be no narrower than % - * wchar_t, and should be able to hold all members of the largest % - * character set plus one extra value (WEOF), and must be at least 16 bits. % + * rune_t must be the same type. Also, wint_t should be able to hold all % + * members of the largest character set plus one extra value (WEOF), and % + * must be at least 16 bits. % */ This still says that wchar_t MUST be the same as rune_t... % typedef int __ct_rune_t; /* arg type for ctype funcs */ % typedef __ct_rune_t __rune_t; /* rune_t (see above) */ % -typedef __ct_rune_t __wchar_t; /* wchar_t (see above) */ ... but rune_t is still int, while wchar_t can be different (it is unsigned on arm_eabi). % typedef __ct_rune_t __wint_t; /* wint_t (see above) */ The above removes a MUST on wint_t instead, but wint_t hasn't been changed. Was that intended? The MUST is still satisfied, but isn't stated quite right, since the sign bit is normally counted as part of the width but probably shouldn't be in this requirement. % % typedef __uint32_t __dev_t; /* device number */ % ... % Index: sys/arm/include/_limits.h % =================================================================== % --- sys/arm/include/_limits.h (revision 237150) % +++ sys/arm/include/_limits.h (working copy) % @@ -78,6 +78,14 @@ % #define __QUAD_MAX __LLONG_MAX /* max value for a quad_t */ % #define __QUAD_MIN __LLONG_MIN /* min value for a quad_t */ % % +#ifdef __ARM_EABI__ % +#define __WCHAR_MIN (0) Bogus parentheses. % +#define __WCHAR_MAX __UINT_MAX % +#else % +#define __WCHAR_MIN __INT_MIN % +#define __WCHAR_MAX __INT_MAX % +#endif % + These definitions are missing banal comments, unlike all the other definitions except the ones for __LONG_BIT and __WORD_BIT. (The one for __MINSIGSTKSZ is not missing, but is in an inconsistent style.) % #define __LONG_BIT 32 % #define __WORD_BIT 32 % Bruce From owner-freebsd-arch@FreeBSD.ORG Wed Jun 20 10:52:43 2012 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id F41221065674 for ; Wed, 20 Jun 2012 10:52:42 +0000 (UTC) (envelope-from andrew@fubar.geek.nz) Received: from smtp4.clear.net.nz (smtp4.clear.net.nz [203.97.37.64]) by mx1.freebsd.org (Postfix) with ESMTP id BBDCE8FC18 for ; Wed, 20 Jun 2012 10:52:42 +0000 (UTC) Received: from mxin1-orange.clear.net.nz (lb2-srcnat.clear.net.nz [203.97.32.237]) by smtp4.clear.net.nz (CLEAR Net Mail) with ESMTP id <0M5W0082BWVN3M10@smtp4.clear.net.nz> for arch@freebsd.org; Wed, 20 Jun 2012 22:52:35 +1200 (NZST) Received: from 202-0-48-19.paradise.net.nz (HELO localhost) ([202.0.48.19]) by smtpin1.paradise.net.nz with ESMTP; Wed, 20 Jun 2012 22:52:35 +1200 Date: Wed, 20 Jun 2012 22:52:00 +1200 From: Andrew Turner In-reply-to: <20120620011811.X2306@besplex.bde.org> To: Bruce Evans Message-id: <20120620225200.7566b177@fubar.geek.nz> MIME-version: 1.0 X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.6; i386-portbld-freebsd8.0) Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Pirate: Arrrr References: <20120617171125.18836c93@fubar.geek.nz> <20120619234520.76121ece@fubar.geek.nz> <20120620011811.X2306@besplex.bde.org> Cc: arch@FreeBSD.org Subject: Re: wchar_t change for ARM EABI X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jun 2012 10:52:43 -0000 I have updated the patch at [1]. [1] http://people.freebsd.org/~andrew/wchar_unsigned_2.diff On Wed, 20 Jun 2012 01:47:34 +1000 (EST) Bruce Evans wrote: > On Tue, 19 Jun 2012, Andrew Turner wrote: > > I have an updated patch at [1]. This moves __WCHAR_MIN/__WCHAR_MAX > > from to as they are limits > > rather than types. Does anybody see any issues with this? If not > > I'll update it for all architectures and commit later in the week. > > I hoped to keep the types and limits closer together, especially for > the types that are declared in . > has mainly limits for basic (non-typedefed) > types. The exceptions were just for size_t, ssize_t, off_t, and > *quad_t (ugh). I've moved them back to . > This still says that wchar_t MUST be the same as rune_t... > > % typedef int __ct_rune_t; /* arg type > for ctype funcs */ % typedef __ct_rune_t > __rune_t; /* rune_t (see above) */ % -typedef > __ct_rune_t __wchar_t; /* wchar_t (see above) */ > > ... but rune_t is still int, while wchar_t can be different (it is > unsigned on arm_eabi). As far as I can tell the comment was incorrect. rune_t must be the same type as wint_t, it just happens that wchar_t was also the same type. > % typedef __ct_rune_t __wint_t; /* wint_t (see > above) */ > > The above removes a MUST on wint_t instead, but wint_t hasn't been > changed. Was that intended? The MUST is still satisfied, but isn't > stated quite right, since the sign bit is normally counted as part of > the width but probably shouldn't be in this requirement. I removed the MUST as, on ARM EABI, the number of usable bits for a character in a wint_t is now less than the number of bits in a wchar_t. > % > % typedef __uint32_t __dev_t; /* device number > */ % ... > % Index: sys/arm/include/_limits.h > % =================================================================== > % --- sys/arm/include/_limits.h (revision 237150) > % +++ sys/arm/include/_limits.h (working copy) > % @@ -78,6 +78,14 @@ > % #define __QUAD_MAX __LLONG_MAX /* max value > for a quad_t */ % #define __QUAD_MIN > __LLONG_MIN /* min value for a quad_t */ % > % +#ifdef __ARM_EABI__ > % +#define __WCHAR_MIN (0) > > Bogus parentheses. Ok. > % +#define __WCHAR_MAX __UINT_MAX > % +#else > % +#define __WCHAR_MIN __INT_MIN > % +#define __WCHAR_MAX __INT_MAX > % +#endif > % + > > These definitions are missing banal comments, unlike all the other > definitions except the ones for __LONG_BIT and __WORD_BIT. (The one > for __MINSIGSTKSZ is not missing, but is in an inconsistent style.) Ok. Andrew