From owner-freebsd-xen@FreeBSD.ORG Mon Sep 2 11:06:56 2013 Return-Path: Delivered-To: freebsd-xen@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 32FCB179 for ; Mon, 2 Sep 2013 11:06:56 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 215C623C5 for ; Mon, 2 Sep 2013 11:06:56 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r82B6tHF016247 for ; Mon, 2 Sep 2013 11:06:55 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r82B6tQH016245 for freebsd-xen@FreeBSD.org; Mon, 2 Sep 2013 11:06:55 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 2 Sep 2013 11:06:55 GMT Message-Id: <201309021106.r82B6tQH016245@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-xen@FreeBSD.org Subject: Current problem reports assigned to freebsd-xen@FreeBSD.org X-BeenThere: freebsd-xen@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion of the freebsd port to xen - implementation and usage List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Sep 2013 11:06:56 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o kern/180788 xen [xen] [panic] XEN PV kernel 9.2-BETA1 panics on boot o kern/180403 xen [xen] Problems with GENERIC and XENHVM kernels with Xe o kern/180402 xen [xen] XEN kernel does not load in XenClient 4.5.5 o kern/179814 xen [xen] mountroot fails with error=19 under Xen on 9-STA o kern/176471 xen [xen] xn driver crash on detach o kern/176053 xen [xen] [patch] i386: Correct wrong usage of vsnprintf() o kern/175954 xen [xen] XENHVM xn network driver extreme packet loss dur o kern/175822 xen [xen] FreeBSD 9.1 does not work with Xen 4.0 o kern/175757 xen [xen] [patch] xen pvhvm looses keyboard input from VNC o kern/171873 xen [xen] xn network device floods warning in dmesg o kern/171118 xen [xen] FreeBSD XENHVM guest doesn't shutdown cleanly o kern/166174 xen [xen] Problems ROOT MOUNT ERROR o kern/165418 xen [xen] Problems mounting root filesystem from XENHVM o kern/164630 xen [xen] XEN HVM kernel: run_interrupt_driven_hooks: stil o kern/164450 xen [xen] Failed to install FreeeBSD 9.0-RELEASE from CD i o kern/162677 xen [xen] FreeBSD not compatible with "Current Stable Xen" o kern/161318 xen [xen] sysinstall crashes with floating point exception o kern/155468 xen [xen] Xen PV i386 multi-kernel CPU system is not worki o kern/155353 xen [xen] [patch] put "nudging TOD" message under boot_ver o kern/154833 xen [xen]: xen 4.0 - DomU freebsd8.2RC3 i386, XEN kernel. o kern/154473 xen [xen] xen 4.0 - DomU freebsd8.1 i386, XEN kernel. Not o kern/154472 xen [xen] xen 4.0 - DomU freebsd8.1 i386 xen kernel reboot o kern/154428 xen [xen] xn0 network interface and PF - Massive performan o kern/153674 xen [xen] i386/XEN idle thread shows wrong percentages o kern/153672 xen [xen] [panic] i386/XEN panics under heavy fork load o kern/153620 xen [xen] Xen guest system clock drifts in AWS EC2 (FreeBS o kern/153477 xen [xen] XEN pmap code abuses vm page queue lock o kern/153150 xen [xen] xen/ec2: disable checksum offloading on interfac o kern/152228 xen [xen] [panic] Xen/PV panic with machdep.idle_mwait=1 o kern/144629 xen [xen] FreeBSD 8-RELEASE XEN pvm networking doesn't wor o kern/143398 xen [xen] FreeBSD 8-RELEASE XEN pvm networking doesn't wor o kern/143340 xen [xen] FreeBSD 8-RELEASE XEN pvm networking doesn't wor f kern/143069 xen [xen] [panic] Xen Kernel Panic - Memory modified after f kern/135667 xen ufs filesystem corruption on XEN DomU system f kern/135421 xen [xen] FreeBSD Xen PVM DomU network failure - netfronc. f kern/135178 xen [xen] Xen domU outgoing data transfer stall when TSO i p kern/135069 xen [xen] FreeBSD-current/Xen SMP doesn't function at all f i386/124516 xen [xen] FreeBSD-CURRENT Xen Kernel Segfaults when config o kern/118734 xen [xen] FreeBSD 6.3-RC1 and FreeBSD 7.0-BETA 4 fail to b 39 problems total. From owner-freebsd-xen@FreeBSD.ORG Mon Sep 2 17:58:59 2013 Return-Path: Delivered-To: freebsd-xen@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id DBA04905; Mon, 2 Sep 2013 17:58:59 +0000 (UTC) (envelope-from roger.pau@citrix.com) Received: from SMTP.EU.CITRIX.COM (smtp.eu.citrix.com [46.33.159.39]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 168EA26A7; Mon, 2 Sep 2013 17:58:58 +0000 (UTC) X-IronPort-AV: E=Sophos;i="4.89,1008,1367971200"; d="scan'208,223";a="8345219" Received: from lonpex01cl02.citrite.net ([10.30.203.102]) by LONPIPO01.EU.CITRIX.COM with ESMTP/TLS/AES128-SHA; 02 Sep 2013 17:58:51 +0000 Received: from [172.16.1.30] (10.30.203.1) by LONPEX01CL02.citrite.net (10.30.203.102) with Microsoft SMTP Server id 14.2.342.4; Mon, 2 Sep 2013 18:58:49 +0100 Message-ID: <5224D1DE.8080906@citrix.com> Date: Mon, 2 Sep 2013 19:58:54 +0200 From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: "freebsd-xen@freebsd.org" Subject: blkback making assumptions about the id of the requests Content-Type: multipart/mixed; boundary="------------040403030603090609030105" X-Originating-IP: [10.30.203.1] Cc: "Justin T. Gibbs" X-BeenThere: freebsd-xen@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion of the freebsd port to xen - implementation and usage List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Sep 2013 17:58:59 -0000 --------------040403030603090609030105 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Hello, While playing with driver domains using FreeBSD I've found out that blkback in FreeBSD makes assumptions about the id of a request instead of actually using the id of the request on the shared ring. This seems wrong to me, since a frontend might choose whatever ids it like for the requests (like using 100-131 instead of 0-31). The patch attached fixes it by copying the id from the request on the ring to blkback internal request structure. Roger. --------------040403030603090609030105 Content-Type: text/plain; charset="UTF-8"; x-mac-type=0; x-mac-creator=0; name="0001-xen-blkback-don-t-make-assumptions-about-request-ids.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-xen-blkback-don-t-make-assumptions-about-request-ids.pa"; filename*1="tch" >From 01c3edc4446b113ec85537bb75c56c6072c4ee49 Mon Sep 17 00:00:00 2001 From: Roger Pau Monne Date: Mon, 2 Sep 2013 15:51:47 +0200 Subject: [PATCH] xen-blkback: don't make assumptions about request ids Blkback makes assumptions about the id of the request it received from the frontend, this patch fixes it by always honoring the id passed from the frontend instead of assuming there's an implicit order in the id of the requests. --- sys/dev/xen/blkback/blkback.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/sys/dev/xen/blkback/blkback.c b/sys/dev/xen/blkback/blkback.c index 2a220c4..500b347 100644 --- a/sys/dev/xen/blkback/blkback.c +++ b/sys/dev/xen/blkback/blkback.c @@ -1239,6 +1239,7 @@ xbb_get_resources(struct xbb_softc *xbb, struct xbb_xen_reqlist **reqlist, nreq->reqlist = *reqlist; nreq->req_ring_idx = ring_idx; + nreq->id = ring_req->id; if (xbb->abi != BLKIF_PROTOCOL_NATIVE) { bcopy(ring_req, &nreq->ring_req_storage, sizeof(*ring_req)); -- 1.7.7.5 (Apple Git-26) --------------040403030603090609030105-- From owner-freebsd-xen@FreeBSD.ORG Mon Sep 2 20:27:11 2013 Return-Path: Delivered-To: freebsd-xen@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 9D5AA981 for ; Mon, 2 Sep 2013 20:27:11 +0000 (UTC) (envelope-from gibbs@freebsd.org) Received: from aslan.scsiguy.com (mail.scsiguy.com [70.89.174.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 6C8E92087 for ; Mon, 2 Sep 2013 20:27:10 +0000 (UTC) Received: from [192.168.0.99] (macbook.scsiguy.com [192.168.0.99]) (authenticated bits=0) by aslan.scsiguy.com (8.14.7/8.14.5) with ESMTP id r82K3opK002873 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Mon, 2 Sep 2013 14:03:50 -0600 (MDT) (envelope-from gibbs@freebsd.org) Content-Type: text/plain; charset=iso-8859-1 Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\)) Subject: Re: blkback making assumptions about the id of the requests From: "Justin T. Gibbs" In-Reply-To: <5224D1DE.8080906@citrix.com> Date: Mon, 2 Sep 2013 14:03:50 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: References: <5224D1DE.8080906@citrix.com> To: =?iso-8859-1?Q?Roger_Pau_Monn=E9?= X-Mailer: Apple Mail (2.1508) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (aslan.scsiguy.com [70.89.174.89]); Mon, 02 Sep 2013 14:03:50 -0600 (MDT) Cc: "freebsd-xen@freebsd.org" X-BeenThere: freebsd-xen@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion of the freebsd port to xen - implementation and usage List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Sep 2013 20:27:11 -0000 On Sep 2, 2013, at 11:58 AM, Roger Pau Monn=E9 = wrote: > Hello, >=20 > While playing with driver domains using FreeBSD I've found out that > blkback in FreeBSD makes assumptions about the id of a request instead > of actually using the id of the request on the shared ring. This seems > wrong to me, since a frontend might choose whatever ids it like for = the > requests (like using 100-131 instead of 0-31). The patch attached = fixes > it by copying the id from the request on the ring to blkback internal > request structure. >=20 > Roger. It looks to me like the id is set in xbb_dispatch_io(). Why it is done = there and not earlier, I don't recall. -- Justin From owner-freebsd-xen@FreeBSD.ORG Tue Sep 3 03:49:49 2013 Return-Path: Delivered-To: xen@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id C0237299; Tue, 3 Sep 2013 03:49:49 +0000 (UTC) (envelope-from gibbs@FreeBSD.org) Received: from aslan.scsiguy.com (mail.scsiguy.com [70.89.174.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 8D8C82180; Tue, 3 Sep 2013 03:49:49 +0000 (UTC) Received: from [192.168.0.99] (macbook.scsiguy.com [192.168.0.99]) (authenticated bits=0) by aslan.scsiguy.com (8.14.7/8.14.5) with ESMTP id r833nkad004322 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Mon, 2 Sep 2013 21:49:46 -0600 (MDT) (envelope-from gibbs@FreeBSD.org) From: "Justin T. Gibbs" Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: [CFR] Xen IPI patch Date: Mon, 2 Sep 2013 21:49:46 -0600 Message-Id: To: "xen@FreeBSD.org" Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\)) X-Mailer: Apple Mail (2.1508) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (aslan.scsiguy.com [70.89.174.89]); Mon, 02 Sep 2013 21:49:46 -0600 (MDT) Cc: Konstantin Belousov X-BeenThere: freebsd-xen@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion of the freebsd port to xen - implementation and usage List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Sep 2013 03:49:49 -0000 In my continuing effort to get all of Roger's Xen enhancements into FreeBSD, I'm just about finished reviewing the next patch in his series. The current status of the patch can be found here: http://people.freebsd.org/~gibbs/xen_ipi.diff The main, and late breaking, wrinkle for this patch is the newly committed PCID support form AMD64. I've done my best to translate the updated assembly IPI handlers into the C equivalents needed for Xen. But, I'm by no means an x86 assembly expert, and my current Xen installation doesn't advertise PCID, so all of the new branches I've added have yet to be tested. I also wonder if PVHVM guests are supposed to perform the PCID work natively or use some other Hypervisor functionality. Other things I'm not happy about with the patch: - hvm.c wants to use invltlb_globpcid(), but it is private to pmap.c. I've moved it to cpufunc.h to be next to invltlb(), but the definition of CR4_PGE (from specialreg.h) isn't visible in all of the contexts that include cpufunc.h. So I hackishly define it if necessary. Ick. - With the divergence of IPI handling between i386 and amd64, x86/xen/hvm.c is growing too many ifdefs. Should we delegate the definitions of the ipi functions to amd64/xen/hvm.c and i386/xen/hvm.c? - There's too much code duplication in xen_invlrng() and some of the logic in the other handlers can probably be tightened up. Unfortunately, I'm out of time for tonight. Hopefully the list will have some great suggestions/fixes/improvements for this patch before I pick it up again tomorrow. Thanks, Justin From owner-freebsd-xen@FreeBSD.ORG Tue Sep 3 09:39:20 2013 Return-Path: Delivered-To: freebsd-xen@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 862AFE14; Tue, 3 Sep 2013 09:39:20 +0000 (UTC) (envelope-from roger.pau@citrix.com) Received: from SMTP.EU.CITRIX.COM (smtp.eu.citrix.com [46.33.159.39]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id CE8E628CE; Tue, 3 Sep 2013 09:39:19 +0000 (UTC) X-IronPort-AV: E=Sophos;i="4.89,1013,1367971200"; d="scan'208,223";a="8357008" Received: from lonpmailmx01.citrite.net ([10.30.203.162]) by LONPIPO01.EU.CITRIX.COM with ESMTP/TLS/RC4-MD5; 03 Sep 2013 09:39:17 +0000 Received: from [172.16.1.30] (10.68.19.166) by LONPMAILMX01.citrite.net (10.30.203.162) with Microsoft SMTP Server id 8.3.298.1; Tue, 3 Sep 2013 10:39:16 +0100 Message-ID: <5225AE4C.1030108@citrix.com> Date: Tue, 3 Sep 2013 11:39:24 +0200 From: =?UTF-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: "Justin T. Gibbs" Subject: Re: blkback making assumptions about the id of the requests References: <5224D1DE.8080906@citrix.com> In-Reply-To: Content-Type: multipart/mixed; boundary="------------030404050904070606040801" Cc: "freebsd-xen@freebsd.org" X-BeenThere: freebsd-xen@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion of the freebsd port to xen - implementation and usage List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Sep 2013 09:39:20 -0000 --------------030404050904070606040801 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit On 02/09/13 22:03, Justin T. Gibbs wrote: > On Sep 2, 2013, at 11:58 AM, Roger Pau Monné wrote: > >> Hello, >> >> While playing with driver domains using FreeBSD I've found out that >> blkback in FreeBSD makes assumptions about the id of a request instead >> of actually using the id of the request on the shared ring. This seems >> wrong to me, since a frontend might choose whatever ids it like for the >> requests (like using 100-131 instead of 0-31). The patch attached fixes >> it by copying the id from the request on the ring to blkback internal >> request structure. >> >> Roger. > > It looks to me like the id is set in xbb_dispatch_io(). Why it is done there > and not earlier, I don't recall. Sorry, I've missed to spot that the id is set there, the problem is that requests of type BLKIF_OP_FLUSH_DISKCACHE never reach that point, so they end up having incorrect requests ids. I've reworded the commit message and removed the late setting of the request id, now it is set earlier so requests of type flush also have a valid id when writing the response on the ring. --------------030404050904070606040801 Content-Type: text/plain; charset="UTF-8"; x-mac-type=0; x-mac-creator=0; name="0001-xen-blkback-set-request-id-correctly-for-flush-OP.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-xen-blkback-set-request-id-correctly-for-flush-OP.patch" RnJvbSA4MGRjM2NiZjVlZDg4YmU4OTBkMjhhZTE5OGFiNjk5NjhjYWY5ZDYzIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBSb2dlciBQYXUgTW9ubmUgPHJvZ2VyLnBhdUBjaXRy aXguY29tPgpEYXRlOiBNb24sIDIgU2VwIDIwMTMgMTU6NTE6NDcgKzAyMDAKU3ViamVjdDog W1BBVENIXSB4ZW4tYmxrYmFjazogc2V0IHJlcXVlc3QgaWQgY29ycmVjdGx5IGZvciBmbHVz aCBPUAoKT3JpZ2luYWxseSB0aGUgaW50ZXJuYWwgcmVxdWVzdCBpZCBpcyBzZXQgb24geGJi X2Rpc3BhdGNoX2lvLCBidXQKcmVxdWVzdHMgb2YgdHlwZSBCTEtJRl9PUF9GTFVTSF9ESVNL Q0FDSEUgbmV2ZXIgcmVhY2ggdGhpcyBwb2ludCwgc28KdGhleSBlbmQgdXAgaGF2aW5nIHdy b25nIHJlcXVlc3QgaWRzIHdoZW4gd3JpdHRpbmcgdGhlIHJlc3BvbnNlIG9uIHRoZQpyaW5n LCBicmVha2luZyB0aGUgZnJvbnRlbmQuCgpUaGlzIHBhdGNoIGZpeGVzIGl0IGJ5IHNldHRp bmcgdGhlIHJlcXVlc3QgaWQgZm9yIGFsbCByZXF1ZXN0IHR5cGVzCmVhcmxpZXIsIHNvIHRo YXQgQkxLSUZfT1BfRkxVU0hfRElTS0NBQ0hFIG9wZXJhdGlvbnMgaGF2ZSB0aGUgcmlnaHQK aWQuCi0tLQogc3lzL2Rldi94ZW4vYmxrYmFjay9ibGtiYWNrLmMgfCAgICAyICstCiAxIGZp bGVzIGNoYW5nZWQsIDEgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9zeXMvZGV2L3hlbi9ibGtiYWNrL2Jsa2JhY2suYyBiL3N5cy9kZXYveGVuL2Jsa2Jh Y2svYmxrYmFjay5jCmluZGV4IDJhMjIwYzQuLmZhOWE3NDQgMTAwNjQ0Ci0tLSBhL3N5cy9k ZXYveGVuL2Jsa2JhY2svYmxrYmFjay5jCisrKyBiL3N5cy9kZXYveGVuL2Jsa2JhY2svYmxr YmFjay5jCkBAIC0xMjM5LDYgKzEyMzksNyBAQCB4YmJfZ2V0X3Jlc291cmNlcyhzdHJ1Y3Qg eGJiX3NvZnRjICp4YmIsIHN0cnVjdCB4YmJfeGVuX3JlcWxpc3QgKipyZXFsaXN0LAogCiAJ bnJlcS0+cmVxbGlzdCA9ICpyZXFsaXN0OwogCW5yZXEtPnJlcV9yaW5nX2lkeCA9IHJpbmdf aWR4OworCW5yZXEtPmlkID0gcmluZ19yZXEtPmlkOwogCiAJaWYgKHhiYi0+YWJpICE9IEJM S0lGX1BST1RPQ09MX05BVElWRSkgewogCQliY29weShyaW5nX3JlcSwgJm5yZXEtPnJpbmdf cmVxX3N0b3JhZ2UsIHNpemVvZigqcmluZ19yZXEpKTsKQEAgLTE2MDgsNyArMTYwOSw2IEBA IHhiYl9kaXNwYXRjaF9pbyhzdHJ1Y3QgeGJiX3NvZnRjICp4YmIsIHN0cnVjdCB4YmJfeGVu X3JlcWxpc3QgKnJlcWxpc3QpCiAJCXJlcV9yaW5nX2lkeAkgICAgICA9IG5yZXEtPnJlcV9y aW5nX2lkeDsKIAkJbnJfc2VjdHMgICAgICAgICAgICAgID0gMDsKIAkJbnNlZyAgICAgICAg ICAgICAgICAgID0gcmluZ19yZXEtPm5yX3NlZ21lbnRzOwotCQlucmVxLT5pZCAgICAgICAg ICAgICAgPSByaW5nX3JlcS0+aWQ7CiAJCW5yZXEtPm5yX3BhZ2VzICAgICAgICA9IG5zZWc7 CiAJCW5yZXEtPm5yXzUxMmJfc2VjdG9ycyA9IDA7CiAJCXJlcV9zZWdfaWR4CSAgICAgID0g MDsKLS0gCjEuNy43LjUgKEFwcGxlIEdpdC0yNikKCgo= --------------030404050904070606040801-- From owner-freebsd-xen@FreeBSD.ORG Tue Sep 3 13:49:31 2013 Return-Path: Delivered-To: freebsd-xen@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id E4C69CE7 for ; Tue, 3 Sep 2013 13:49:31 +0000 (UTC) (envelope-from gibbs@freebsd.org) Received: from aslan.scsiguy.com (mail.scsiguy.com [70.89.174.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id B9ADE2DE5 for ; Tue, 3 Sep 2013 13:49:31 +0000 (UTC) Received: from [192.168.0.99] (macbook.scsiguy.com [192.168.0.99]) (authenticated bits=0) by aslan.scsiguy.com (8.14.7/8.14.5) with ESMTP id r83DnSUD008216 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Tue, 3 Sep 2013 07:49:28 -0600 (MDT) (envelope-from gibbs@freebsd.org) Content-Type: text/plain; charset=iso-8859-1 Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\)) Subject: Re: blkback making assumptions about the id of the requests From: "Justin T. Gibbs" In-Reply-To: <5225AE4C.1030108@citrix.com> Date: Tue, 3 Sep 2013 07:49:30 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: <4735C4C7-6348-401D-86BD-013099D2E247@freebsd.org> References: <5224D1DE.8080906@citrix.com> <5225AE4C.1030108@citrix.com> To: =?iso-8859-1?Q?Roger_Pau_Monn=E9?= X-Mailer: Apple Mail (2.1508) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (aslan.scsiguy.com [70.89.174.89]); Tue, 03 Sep 2013 07:49:28 -0600 (MDT) Cc: "freebsd-xen@freebsd.org" X-BeenThere: freebsd-xen@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion of the freebsd port to xen - implementation and usage List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Sep 2013 13:49:32 -0000 On Sep 3, 2013, at 3:39 AM, Roger Pau Monn=E9 = wrote: > On 02/09/13 22:03, Justin T. Gibbs wrote: >> On Sep 2, 2013, at 11:58 AM, Roger Pau Monn=E9 = wrote: >>=20 >>> Hello, >>>=20 >>> While playing with driver domains using FreeBSD I've found out that >>> blkback in FreeBSD makes assumptions about the id of a request = instead >>> of actually using the id of the request on the shared ring. This = seems >>> wrong to me, since a frontend might choose whatever ids it like for = the >>> requests (like using 100-131 instead of 0-31). The patch attached = fixes >>> it by copying the id from the request on the ring to blkback = internal >>> request structure. >>>=20 >>> Roger. >>=20 >> It looks to me like the id is set in xbb_dispatch_io(). Why it is = done there >> and not earlier, I don't recall. >=20 > Sorry, I've missed to spot that the id is set there, the problem is = that > requests of type BLKIF_OP_FLUSH_DISKCACHE never reach that point, so > they end up having incorrect requests ids. I've reworded the commit > message and removed the late setting of the request id, now it is set > earlier so requests of type flush also have a valid id when writing = the > response on the ring. Makes sense. Committed. -- Justin= From owner-freebsd-xen@FreeBSD.ORG Tue Sep 3 14:09:28 2013 Return-Path: Delivered-To: freebsd-xen@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id C0FAD519 for ; Tue, 3 Sep 2013 14:09:28 +0000 (UTC) (envelope-from gibbs@scsiguy.com) Received: from aslan.scsiguy.com (mail.scsiguy.com [70.89.174.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 9FA762F2A for ; Tue, 3 Sep 2013 14:09:28 +0000 (UTC) Received: from [192.168.0.99] (macbook.scsiguy.com [192.168.0.99]) (authenticated bits=0) by aslan.scsiguy.com (8.14.7/8.14.5) with ESMTP id r83E9RRF008903 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) for ; Tue, 3 Sep 2013 08:09:27 -0600 (MDT) (envelope-from gibbs@scsiguy.com) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\)) Subject: Re: Current problem reports assigned to freebsd-xen@FreeBSD.org From: "Justin T. Gibbs" In-Reply-To: <201309021106.r82B6tQH016245@freefall.freebsd.org> Date: Tue, 3 Sep 2013 08:09:29 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201309021106.r82B6tQH016245@freefall.freebsd.org> To: "freebsd-xen@freebsd.org" X-Mailer: Apple Mail (2.1508) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (aslan.scsiguy.com [70.89.174.89]); Tue, 03 Sep 2013 08:09:27 -0600 (MDT) X-BeenThere: freebsd-xen@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion of the freebsd port to xen - implementation and usage List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Sep 2013 14:09:28 -0000 Has anyone made any progress analyzing these bugs? I'm wondering if = there are bugs here we can easily fix for 10 or that we've already fixed and can = be closed. I will start looking at these once Roger's patch series is in the tree. = Please let the list know if you are already taking one of these on so we can avoid = duplicate effort. Thanks, Justin =20 On Sep 2, 2013, at 5:06 AM, FreeBSD bugmaster = wrote: > Note: to view an individual PR, use: > http://www.freebsd.org/cgi/query-pr.cgi?pr=3D(number). >=20 > The following is a listing of current problems submitted by FreeBSD = users. > These represent problem reports covering all versions including > experimental development code and obsolete releases. >=20 >=20 > S Tracker Resp. Description > = --------------------------------------------------------------------------= ------ > o kern/180788 xen [xen] [panic] XEN PV kernel 9.2-BETA1 panics = on boot > o kern/180403 xen [xen] Problems with GENERIC and XENHVM = kernels with Xe > o kern/180402 xen [xen] XEN kernel does not load in XenClient = 4.5.5 > o kern/179814 xen [xen] mountroot fails with error=3D19 under = Xen on 9-STA > o kern/176471 xen [xen] xn driver crash on detach > o kern/176053 xen [xen] [patch] i386: Correct wrong usage of = vsnprintf() > o kern/175954 xen [xen] XENHVM xn network driver extreme = packet loss dur > o kern/175822 xen [xen] FreeBSD 9.1 does not work with Xen 4.0 > o kern/175757 xen [xen] [patch] xen pvhvm looses keyboard = input from VNC > o kern/171873 xen [xen] xn network device floods warning in = dmesg > o kern/171118 xen [xen] FreeBSD XENHVM guest doesn't shutdown = cleanly > o kern/166174 xen [xen] Problems ROOT MOUNT ERROR > o kern/165418 xen [xen] Problems mounting root filesystem from = XENHVM > o kern/164630 xen [xen] XEN HVM kernel: = run_interrupt_driven_hooks: stil > o kern/164450 xen [xen] Failed to install FreeeBSD 9.0-RELEASE = from CD i > o kern/162677 xen [xen] FreeBSD not compatible with "Current = Stable Xen" > o kern/161318 xen [xen] sysinstall crashes with floating point = exception > o kern/155468 xen [xen] Xen PV i386 multi-kernel CPU system is = not worki > o kern/155353 xen [xen] [patch] put "nudging TOD" message = under boot_ver > o kern/154833 xen [xen]: xen 4.0 - DomU freebsd8.2RC3 i386, = XEN kernel.=20 > o kern/154473 xen [xen] xen 4.0 - DomU freebsd8.1 i386, XEN = kernel. Not=20 > o kern/154472 xen [xen] xen 4.0 - DomU freebsd8.1 i386 xen = kernel reboot > o kern/154428 xen [xen] xn0 network interface and PF - Massive = performan > o kern/153674 xen [xen] i386/XEN idle thread shows wrong = percentages > o kern/153672 xen [xen] [panic] i386/XEN panics under heavy = fork load > o kern/153620 xen [xen] Xen guest system clock drifts in AWS = EC2 (FreeBS > o kern/153477 xen [xen] XEN pmap code abuses vm page queue = lock > o kern/153150 xen [xen] xen/ec2: disable checksum offloading = on interfac > o kern/152228 xen [xen] [panic] Xen/PV panic with = machdep.idle_mwait=3D1 > o kern/144629 xen [xen] FreeBSD 8-RELEASE XEN pvm networking = doesn't wor > o kern/143398 xen [xen] FreeBSD 8-RELEASE XEN pvm networking = doesn't wor > o kern/143340 xen [xen] FreeBSD 8-RELEASE XEN pvm networking = doesn't wor > f kern/143069 xen [xen] [panic] Xen Kernel Panic - Memory = modified after > f kern/135667 xen ufs filesystem corruption on XEN DomU system > f kern/135421 xen [xen] FreeBSD Xen PVM DomU network failure - = netfronc. > f kern/135178 xen [xen] Xen domU outgoing data transfer stall = when TSO i > p kern/135069 xen [xen] FreeBSD-current/Xen SMP doesn't = function at all=20 > f i386/124516 xen [xen] FreeBSD-CURRENT Xen Kernel Segfaults = when config > o kern/118734 xen [xen] FreeBSD 6.3-RC1 and FreeBSD 7.0-BETA 4 = fail to b >=20 > 39 problems total. >=20 > _______________________________________________ > freebsd-xen@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-xen > To unsubscribe, send any mail to "freebsd-xen-unsubscribe@freebsd.org" >=20 From owner-freebsd-xen@FreeBSD.ORG Tue Sep 3 14:38:11 2013 Return-Path: Delivered-To: freebsd-xen@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 51B06728 for ; Tue, 3 Sep 2013 14:38:11 +0000 (UTC) (envelope-from mcdouga9@egr.msu.edu) Received: from mail.egr.msu.edu (dauterive.egr.msu.edu [35.9.37.168]) by mx1.freebsd.org (Postfix) with ESMTP id 2A9E12209 for ; Tue, 3 Sep 2013 14:38:10 +0000 (UTC) Received: from dauterive (localhost [127.0.0.1]) by mail.egr.msu.edu (Postfix) with ESMTP id 2BBE12E894 for ; Tue, 3 Sep 2013 10:38:10 -0400 (EDT) X-Virus-Scanned: amavisd-new at egr.msu.edu Received: from mail.egr.msu.edu ([127.0.0.1]) by dauterive (dauterive.egr.msu.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XPd5dkrfGmC1 for ; Tue, 3 Sep 2013 10:38:10 -0400 (EDT) Received: from EGR authenticated sender Message-ID: <5225F451.6060703@egr.msu.edu> Date: Tue, 03 Sep 2013 10:38:09 -0400 From: Adam McDougall User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130824 Thunderbird/17.0.8 MIME-Version: 1.0 To: freebsd-xen@freebsd.org Subject: Re: Current problem reports assigned to freebsd-xen@FreeBSD.org References: <201309021106.r82B6tQH016245@freefall.freebsd.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-xen@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion of the freebsd port to xen - implementation and usage List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Sep 2013 14:38:11 -0000 On 09/03/13 10:09, Justin T. Gibbs wrote: > Has anyone made any progress analyzing these bugs? I'm wondering if there are > bugs here we can easily fix for 10 or that we've already fixed and can be closed. > >> S Tracker Resp. Description >> -------------------------------------------------------------------------------- >> o kern/176471 xen [xen] xn driver crash on detach Can be closed, patch was committed and MFC'ed to 9, details in PR. >> o kern/171118 xen [xen] FreeBSD XENHVM guest doesn't shutdown cleanly Appears to still be relevant from a test just now on 9.2-BETA1 (AMD64-9) r253631. >> o kern/154428 xen [xen] xn0 network interface and PF - Massive performan I had similar issues, some testing I did last week makes me satisfied with r252781 in 9-stable (MFC of r291296, r291297, r291393) but I can't speak for everyone. >> f kern/135178 xen [xen] Xen domU outgoing data transfer stall when TSO i Looks like feedback timeout. From owner-freebsd-xen@FreeBSD.ORG Tue Sep 3 14:50:09 2013 Return-Path: Delivered-To: freebsd-xen@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id D42A4B6A for ; Tue, 3 Sep 2013 14:50:09 +0000 (UTC) (envelope-from bounces+73574-0602-freebsd-xen=freebsd.org@sendgrid.me) Received: from o3.shared.sendgrid.net (o3.shared.sendgrid.net [208.117.48.85]) by mx1.freebsd.org (Postfix) with SMTP id 8457F22FB for ; Tue, 3 Sep 2013 14:50:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.info; h=from :mime-version:to:cc:subject:references:in-reply-to:content-type :content-transfer-encoding; s=smtpapi; bh=+DWOSxaLk1SnPGKJ8KzdLk UgZ1o=; b=YNyHgk8lHA9bmYtqNeabCvKC90EJGWWzXv4YHnNEuFcmoenXFICSSr TsncGcHz6sFIlMTf+dhtK5uGlh+WSeByJAZe0CjU4CYNNf19FAz0UcTXgK90XwWi SbM/BHxXiPkFqHjDYSwAT0cr/ELJBxJqx9W1htIQrTCX121YYyJr4= Received: by with SMTP id mf59.7032.5225F71ED Tue, 03 Sep 2013 14:50:08 +0000 (GMT) Received: from mail.tarsnap.com (unknown [10.60.208.17]) by mi16 (SG) with ESMTP id 140e44d4fe0.b9a.801dfa for ; Tue, 03 Sep 2013 14:50:06 +0000 (UTC) Received: (qmail 80306 invoked from network); 3 Sep 2013 14:50:05 -0000 Received: from unknown (HELO clamshell.daemonology.net) (127.0.0.1) by ec2-107-20-205-189.compute-1.amazonaws.com with ESMTP; 3 Sep 2013 14:50:05 -0000 Received: (qmail 8488 invoked from network); 3 Sep 2013 14:49:26 -0000 Received: from unknown (HELO clamshell.daemonology.net) (127.0.0.1) by clamshell.daemonology.net with SMTP; 3 Sep 2013 14:49:26 -0000 Message-ID: <5225F6F6.8040407@freebsd.org> Date: Tue, 03 Sep 2013 07:49:26 -0700 From: Colin Percival User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130816 Thunderbird/17.0.8 MIME-Version: 1.0 To: Adam McDougall Subject: Re: Current problem reports assigned to freebsd-xen@FreeBSD.org References: <201309021106.r82B6tQH016245@freefall.freebsd.org> <5225F451.6060703@egr.msu.edu> In-Reply-To: <5225F451.6060703@egr.msu.edu> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SG-EID: RUbAm5H8PjswBj/QH+sYVehaJogg3iBnZcyVi1bw/IxZxvpjE3BvC6Ob1FyjX5QnUtPeCwndS5XLUsdCIh4kEdfWqwQT690zzb1Meauyb6W+tQFqT7YAmWqxEjrYWZray40Q8F5ic95LNyzJ4qiCPMiQUobh6a5HCJaSpgpA1nU= Cc: freebsd-xen@freebsd.org X-BeenThere: freebsd-xen@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion of the freebsd port to xen - implementation and usage List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Sep 2013 14:50:09 -0000 On 09/03/13 07:38, Adam McDougall wrote: >>> o kern/154428 xen [xen] xn0 network interface and PF - Massive performan > I had similar issues, some testing I did last week makes me satisfied > with r252781 in 9-stable (MFC of r291296, r291297, r291393) but I can't > speak for everyone. > >>> f kern/135178 xen [xen] Xen domU outgoing data transfer stall when TSO i > Looks like feedback timeout. I'd say that generally any PRs talking about performance problems or packet loss with TSO turned on can be closed. Also any PRs talking about FreeBSD/i386 Xen/PV can probably be closed with "yes, that code is horribly broken and needs a complete rewrite, don't even try to use it for now". -- Colin Percival Security Officer Emeritus, FreeBSD | The power to serve Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid From owner-freebsd-xen@FreeBSD.ORG Tue Sep 3 14:58:14 2013 Return-Path: Delivered-To: freebsd-xen@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 8049ADDF; Tue, 3 Sep 2013 14:58:14 +0000 (UTC) (envelope-from roger.pau@citrix.com) Received: from SMTP.EU.CITRIX.COM (smtp.eu.citrix.com [46.33.159.39]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id B487C2357; Tue, 3 Sep 2013 14:58:13 +0000 (UTC) X-IronPort-AV: E=Sophos;i="4.89,1014,1367971200"; d="scan'208";a="8367104" Received: from lonpmailmx01.citrite.net ([10.30.203.162]) by LONPIPO01.EU.CITRIX.COM with ESMTP/TLS/RC4-MD5; 03 Sep 2013 14:58:11 +0000 Received: from [172.16.1.30] (10.68.19.166) by LONPMAILMX01.citrite.net (10.30.203.162) with Microsoft SMTP Server id 8.3.298.1; Tue, 3 Sep 2013 15:58:10 +0100 Message-ID: <5225F909.8090305@citrix.com> Date: Tue, 3 Sep 2013 16:58:17 +0200 From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: FreeBSD bugmaster Subject: Re: Current problem reports assigned to freebsd-xen@FreeBSD.org References: <201309021106.r82B6tQH016245@freefall.freebsd.org> In-Reply-To: <201309021106.r82B6tQH016245@freefall.freebsd.org> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: freebsd-xen@FreeBSD.org X-BeenThere: freebsd-xen@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion of the freebsd port to xen - implementation and usage List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Sep 2013 14:58:14 -0000 On 02/09/13 13:06, FreeBSD bugmaster wrote: > Note: to view an individual PR, use: > http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). > > The following is a listing of current problems submitted by FreeBSD users. > These represent problem reports covering all versions including > experimental development code and obsolete releases. > > > S Tracker Resp. Description > -------------------------------------------------------------------------------- > o kern/180788 xen [xen] [panic] XEN PV kernel 9.2-BETA1 panics on boot This is due to bugs in i386 PV pmap, and was closed by reverting r244237 in 9.2, but the problem is still present in HEAD. > o kern/180403 xen [xen] Problems with GENERIC and XENHVM kernels with Xe > o kern/180402 xen [xen] XEN kernel does not load in XenClient 4.5.5 This is a duplicate of kern/180403, which contains more info. > o kern/179814 xen [xen] mountroot fails with error=19 under Xen on 9-STA This is due to the change from ad to ada for xbd devices, not really a bug IMHO. > o kern/176471 xen [xen] xn driver crash on detach Fixed. > o kern/176053 xen [xen] [patch] i386: Correct wrong usage of vsnprintf() > o kern/175954 xen [xen] XENHVM xn network driver extreme packet loss dur > o kern/175822 xen [xen] FreeBSD 9.1 does not work with Xen 4.0 I would say this is fixed, or at least I've never encountered this bug. > o kern/175757 xen [xen] [patch] xen pvhvm looses keyboard input from VNC Fixed. > o kern/171873 xen [xen] xn network device floods warning in dmesg Never seen it on any Xen version and Dom0 kernel combination (already fixed?) > o kern/171118 xen [xen] FreeBSD XENHVM guest doesn't shutdown cleanly xl shutdown does the right thing, so I'm not sure if this bug is specific to XCP/XenServer toolstacks. > o kern/166174 xen [xen] Problems ROOT MOUNT ERROR > o kern/165418 xen [xen] Problems mounting root filesystem from XENHVM > o kern/164630 xen [xen] XEN HVM kernel: run_interrupt_driven_hooks: stil > o kern/164450 xen [xen] Failed to install FreeeBSD 9.0-RELEASE from CD i > o kern/162677 xen [xen] FreeBSD not compatible with "Current Stable Xen" FreeBSD runs fine on 4.2, 4.3 and 4.4. > o kern/161318 xen [xen] sysinstall crashes with floating point exception Never seen it on 9.x or HEAD. > o kern/155468 xen [xen] Xen PV i386 multi-kernel CPU system is not worki > o kern/155353 xen [xen] [patch] put "nudging TOD" message under boot_ver > o kern/154833 xen [xen]: xen 4.0 - DomU freebsd8.2RC3 i386, XEN kernel. > o kern/154473 xen [xen] xen 4.0 - DomU freebsd8.1 i386, XEN kernel. Not > o kern/154472 xen [xen] xen 4.0 - DomU freebsd8.1 i386 xen kernel reboot > o kern/154428 xen [xen] xn0 network interface and PF - Massive performan > o kern/153674 xen [xen] i386/XEN idle thread shows wrong percentages > o kern/153672 xen [xen] [panic] i386/XEN panics under heavy fork load > o kern/153620 xen [xen] Xen guest system clock drifts in AWS EC2 (FreeBS Probably fixed by the new PV timer/clock implementation in HEAD. > o kern/153477 xen [xen] XEN pmap code abuses vm page queue lock > o kern/153150 xen [xen] xen/ec2: disable checksum offloading on interfac > o kern/152228 xen [xen] [panic] Xen/PV panic with machdep.idle_mwait=1 > o kern/144629 xen [xen] FreeBSD 8-RELEASE XEN pvm networking doesn't wor > o kern/143398 xen [xen] FreeBSD 8-RELEASE XEN pvm networking doesn't wor > o kern/143340 xen [xen] FreeBSD 8-RELEASE XEN pvm networking doesn't wor > f kern/143069 xen [xen] [panic] Xen Kernel Panic - Memory modified after > f kern/135667 xen ufs filesystem corruption on XEN DomU system Already fixed also I guess (specially regarding last message from Colin Percival). > f kern/135421 xen [xen] FreeBSD Xen PVM DomU network failure - netfronc. > f kern/135178 xen [xen] Xen domU outgoing data transfer stall when TSO i > p kern/135069 xen [xen] FreeBSD-current/Xen SMP doesn't function at all > f i386/124516 xen [xen] FreeBSD-CURRENT Xen Kernel Segfaults when config > o kern/118734 xen [xen] FreeBSD 6.3-RC1 and FreeBSD 7.0-BETA 4 fail to b > > 39 problems total. > > _______________________________________________ > freebsd-xen@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-xen > To unsubscribe, send any mail to "freebsd-xen-unsubscribe@freebsd.org" > From owner-freebsd-xen@FreeBSD.ORG Tue Sep 3 15:04:34 2013 Return-Path: Delivered-To: freebsd-xen@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 32B85FA0 for ; Tue, 3 Sep 2013 15:04:34 +0000 (UTC) (envelope-from bounces+73574-0602-freebsd-xen=freebsd.org@sendgrid.me) Received: from o3.shared.sendgrid.net (o3.shared.sendgrid.net [208.117.48.85]) by mx1.freebsd.org (Postfix) with SMTP id D1FF223B5 for ; Tue, 3 Sep 2013 15:04:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.info; h=from :mime-version:to:cc:subject:references:in-reply-to:content-type :content-transfer-encoding; s=smtpapi; bh=saK51j5nL5fmhKkBzUTY8/ +LEO4=; b=rwehx1G3HTE0G3uEGeRSuGoz9hqe9lJosm2B46fiUYVovMO4r2JE8s 25nBACwGW6jQLJacFm9awwKNUuMRmJKDb7txfkWzMcoGY75yH7DTo81SIz+xpfHa BOlG826yJNGj6uk8sqI06qnjBOGwmlH79LG8OK3KzFCYWScbIHtjg= Received: by with SMTP id mf10.18732.5225FA7D5 Tue, 03 Sep 2013 15:04:29 +0000 (GMT) Received: from mail.tarsnap.com (unknown [10.60.208.17]) by mi20 (SG) with ESMTP id 140e45a77ad.6e5e.101c9a9 for ; Tue, 03 Sep 2013 15:04:28 +0000 (UTC) Received: (qmail 80775 invoked from network); 3 Sep 2013 15:04:26 -0000 Received: from unknown (HELO clamshell.daemonology.net) (127.0.0.1) by ec2-107-20-205-189.compute-1.amazonaws.com with ESMTP; 3 Sep 2013 15:04:26 -0000 Received: (qmail 8614 invoked from network); 3 Sep 2013 15:03:47 -0000 Received: from unknown (HELO clamshell.daemonology.net) (127.0.0.1) by clamshell.daemonology.net with SMTP; 3 Sep 2013 15:03:47 -0000 Message-ID: <5225FA53.30604@freebsd.org> Date: Tue, 03 Sep 2013 08:03:47 -0700 From: Colin Percival User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130816 Thunderbird/17.0.8 MIME-Version: 1.0 To: "Justin T. Gibbs" Subject: Re: Current problem reports assigned to freebsd-xen@FreeBSD.org References: <201309021106.r82B6tQH016245@freefall.freebsd.org> In-Reply-To: X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SG-EID: RUbAm5H8PjswBj/QH+sYVehaJogg3iBnZcyVi1bw/IzQsSxTPMXWb53B9Fgr1q0CgDLP8gxea2u23rRsCOqKvwUOONce+D99Ar3J94Q4RimCq7bBtJxpunU/P3fdJhMKo6VCsq1kmDzW/zetAb2TNc2qL5tNFbYVKkfaZbh/t6E= Cc: "freebsd-xen@freebsd.org" X-BeenThere: freebsd-xen@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion of the freebsd port to xen - implementation and usage List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Sep 2013 15:04:34 -0000 On 09/03/13 07:09, Justin T. Gibbs wrote: >> o kern/161318 xen [xen] sysinstall crashes with floating point exception This is a real bug but not really a Xen bug -- sysinstall is trying to figure out disk geometry and dividing by zero at some point. So this should probably just be reclassified to [sysinstall] and sent over to a different list. -- Colin Percival Security Officer Emeritus, FreeBSD | The power to serve Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid From owner-freebsd-xen@FreeBSD.ORG Wed Sep 4 17:07:47 2013 Return-Path: Delivered-To: freebsd-xen@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id CDD241DD; Wed, 4 Sep 2013 17:07:47 +0000 (UTC) (envelope-from roger.pau@citrix.com) Received: from SMTP.EU.CITRIX.COM (smtp.eu.citrix.com [46.33.159.39]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 23FE22411; Wed, 4 Sep 2013 17:07:46 +0000 (UTC) X-IronPort-AV: E=Sophos;i="4.89,1022,1367971200"; d="scan'208,223";a="8427668" Received: from lonpmailmx01.citrite.net ([10.30.203.162]) by LONPIPO01.EU.CITRIX.COM with ESMTP/TLS/RC4-MD5; 04 Sep 2013 17:07:45 +0000 Received: from [172.16.1.30] (10.68.19.166) by LONPMAILMX01.citrite.net (10.30.203.162) with Microsoft SMTP Server id 8.3.298.1; Wed, 4 Sep 2013 18:07:44 +0100 Message-ID: <522768EA.6010809@citrix.com> Date: Wed, 4 Sep 2013 19:07:54 +0200 From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: "freebsd-xen@freebsd.org" Subject: Another blkback issue related to flush Content-Type: multipart/mixed; boundary="------------090500030802030106080200" Cc: "Justin T. Gibbs" X-BeenThere: freebsd-xen@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion of the freebsd port to xen - implementation and usage List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Sep 2013 17:07:48 -0000 --------------090500030802030106080200 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Hello, I've found another issue with blkback handling of flush operations, it was incorrectly setting one of the bio parameters when using a block device as backend. The attached patch fixes it, and also includes a small fix to correctly set the operation when writing the response on the ring (all responses written by FreeBSD blkback were of type BLKIF_OP_READ, because nreq->operation was not set). --------------090500030802030106080200 Content-Type: text/plain; charset="UTF-8"; x-mac-type=0; x-mac-creator=0; name="0001-xen-blkback-fix-incorrect-handling-of-flush-for-bloc.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-xen-blkback-fix-incorrect-handling-of-flush-for-bloc.pa"; filename*1="tch" >From b6cd715b2a2fcff0321ccaafe9740082f15b5943 Mon Sep 17 00:00:00 2001 From: Roger Pau Monne Date: Wed, 4 Sep 2013 18:33:22 +0200 Subject: [PATCH] xen-blkback: fix incorrect handling of flush for block devices When issuing a flush operation to a block device (from xbb_dispatch_dev), bio->bio_caller1 was incorrectly set to xbb_xen_req, when the bio callback (xbb_bio_done) specifically expects bio_caller1 to be of type xbb_xen_reqlist. Also set the request operation to match the one on the request from the ring, so that when we write the reply the operation matches. --- sys/dev/xen/blkback/blkback.c | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/sys/dev/xen/blkback/blkback.c b/sys/dev/xen/blkback/blkback.c index fa9a744..58b53e7 100644 --- a/sys/dev/xen/blkback/blkback.c +++ b/sys/dev/xen/blkback/blkback.c @@ -1240,6 +1240,7 @@ xbb_get_resources(struct xbb_softc *xbb, struct xbb_xen_reqlist **reqlist, nreq->reqlist = *reqlist; nreq->req_ring_idx = ring_idx; nreq->id = ring_req->id; + nreq->operation = ring_req->operation; if (xbb->abi != BLKIF_PROTOCOL_NATIVE) { bcopy(ring_req, &nreq->ring_req_storage, sizeof(*ring_req)); @@ -2062,7 +2063,6 @@ xbb_dispatch_dev(struct xbb_softc *xbb, struct xbb_xen_reqlist *reqlist, { struct xbb_dev_data *dev_data; struct bio *bios[XBB_MAX_SEGMENTS_PER_REQLIST]; - struct xbb_xen_req *nreq; off_t bio_offset; struct bio *bio; struct xbb_sg *xbb_sg; @@ -2080,7 +2080,6 @@ xbb_dispatch_dev(struct xbb_softc *xbb, struct xbb_xen_reqlist *reqlist, bio_idx = 0; if (operation == BIO_FLUSH) { - nreq = STAILQ_FIRST(&reqlist->contig_req_list); bio = g_new_bio(); if (unlikely(bio == NULL)) { DPRINTF("Unable to allocate bio for BIO_FLUSH\n"); @@ -2094,10 +2093,10 @@ xbb_dispatch_dev(struct xbb_softc *xbb, struct xbb_xen_reqlist *reqlist, bio->bio_offset = 0; bio->bio_data = 0; bio->bio_done = xbb_bio_done; - bio->bio_caller1 = nreq; + bio->bio_caller1 = reqlist; bio->bio_pblkno = 0; - nreq->pendcnt = 1; + reqlist->pendcnt = 1; SDT_PROBE1(xbb, kernel, xbb_dispatch_dev, flush, device_get_unit(xbb->dev)); -- 1.7.7.5 (Apple Git-26) --------------090500030802030106080200-- From owner-freebsd-xen@FreeBSD.ORG Wed Sep 4 17:49:40 2013 Return-Path: Delivered-To: freebsd-xen@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 764BC9AE for ; Wed, 4 Sep 2013 17:49:40 +0000 (UTC) (envelope-from gibbs@freebsd.org) Received: from aslan.scsiguy.com (aslan.scsiguy.com [70.89.174.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 503D7273F for ; Wed, 4 Sep 2013 17:49:40 +0000 (UTC) Received: from benscottlt.sldomain.com (207-225-98-3.dia.static.qwest.net [207.225.98.3]) (authenticated bits=0) by aslan.scsiguy.com (8.14.7/8.14.5) with ESMTP id r84Hnaaw031340 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Wed, 4 Sep 2013 11:49:37 -0600 (MDT) (envelope-from gibbs@freebsd.org) Content-Type: multipart/mixed; boundary="Apple-Mail=_8FB0F9B6-B925-4672-AD4B-78D54204A510" Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\)) Subject: Re: Another blkback issue related to flush From: "Justin T. Gibbs" In-Reply-To: <522768EA.6010809@citrix.com> Date: Wed, 4 Sep 2013 11:49:33 -0600 Message-Id: References: <522768EA.6010809@citrix.com> To: =?iso-8859-1?Q?Roger_Pau_Monn=E9?= X-Mailer: Apple Mail (2.1508) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (aslan.scsiguy.com [70.89.174.89]); Wed, 04 Sep 2013 11:49:37 -0600 (MDT) Cc: "freebsd-xen@freebsd.org" X-BeenThere: freebsd-xen@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion of the freebsd port to xen - implementation and usage List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Sep 2013 17:49:40 -0000 --Apple-Mail=_8FB0F9B6-B925-4672-AD4B-78D54204A510 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=iso-8859-1 On Sep 4, 2013, at 11:07 AM, Roger Pau Monn=E9 = wrote: > Hello, >=20 > I've found another issue with blkback handling of flush operations, it > was incorrectly setting one of the bio parameters when using a block > device as backend. The attached patch fixes it, and also includes a > small fix to correctly set the operation when writing the response on > the ring (all responses written by FreeBSD blkback were of type > BLKIF_OP_READ, because nreq->operation was not set). It seems that the req's pendcnt is unused and can be culled. Otherwise, looks good to me. Here's the patch I have in my tree now. -- Justin --Apple-Mail=_8FB0F9B6-B925-4672-AD4B-78D54204A510 Content-Disposition: attachment; filename=blkback.diff Content-Type: application/octet-stream; name="blkback.diff" Content-Transfer-Encoding: 7bit Index: blkback.c =================================================================== --- blkback.c (revision 255179) +++ blkback.c (working copy) @@ -230,7 +230,7 @@ struct xbb_xen_reqlist { int num_children; /** - * Number of I/O requests dispatched to the backend. + * Number of I/O requests still pending on the backend. */ int pendcnt; @@ -327,13 +327,6 @@ struct xbb_xen_req { int nr_512b_sectors; /** - * The number of struct bio requests still outstanding for this - * request on the backend device. This field is only used for - * device (rather than file) backed I/O. - */ - int pendcnt; - - /** * BLKIF_OP code for this request. */ int operation; @@ -1240,6 +1233,7 @@ xbb_get_resources(struct xbb_softc *xbb, struct xb nreq->reqlist = *reqlist; nreq->req_ring_idx = ring_idx; nreq->id = ring_req->id; + nreq->operation = ring_req->operation; if (xbb->abi != BLKIF_PROTOCOL_NATIVE) { bcopy(ring_req, &nreq->ring_req_storage, sizeof(*ring_req)); @@ -2062,7 +2056,6 @@ xbb_dispatch_dev(struct xbb_softc *xbb, struct xbb { struct xbb_dev_data *dev_data; struct bio *bios[XBB_MAX_SEGMENTS_PER_REQLIST]; - struct xbb_xen_req *nreq; off_t bio_offset; struct bio *bio; struct xbb_sg *xbb_sg; @@ -2080,7 +2073,6 @@ xbb_dispatch_dev(struct xbb_softc *xbb, struct xbb bio_idx = 0; if (operation == BIO_FLUSH) { - nreq = STAILQ_FIRST(&reqlist->contig_req_list); bio = g_new_bio(); if (__predict_false(bio == NULL)) { DPRINTF("Unable to allocate bio for BIO_FLUSH\n"); @@ -2094,10 +2086,10 @@ xbb_dispatch_dev(struct xbb_softc *xbb, struct xbb bio->bio_offset = 0; bio->bio_data = 0; bio->bio_done = xbb_bio_done; - bio->bio_caller1 = nreq; + bio->bio_caller1 = reqlist; bio->bio_pblkno = 0; - nreq->pendcnt = 1; + reqlist->pendcnt = 1; SDT_PROBE1(xbb, kernel, xbb_dispatch_dev, flush, device_get_unit(xbb->dev)); --Apple-Mail=_8FB0F9B6-B925-4672-AD4B-78D54204A510 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=iso-8859-1 --Apple-Mail=_8FB0F9B6-B925-4672-AD4B-78D54204A510-- From owner-freebsd-xen@FreeBSD.ORG Wed Sep 4 18:03:55 2013 Return-Path: Delivered-To: freebsd-xen@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 88A7FF2B; Wed, 4 Sep 2013 18:03:55 +0000 (UTC) (envelope-from roger.pau@citrix.com) Received: from SMTP.EU.CITRIX.COM (smtp.eu.citrix.com [46.33.159.39]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id C5A2028BE; Wed, 4 Sep 2013 18:03:54 +0000 (UTC) X-IronPort-AV: E=Sophos;i="4.89,1022,1367971200"; d="scan'208";a="8430211" Received: from lonpmailmx01.citrite.net ([10.30.203.162]) by LONPIPO01.EU.CITRIX.COM with ESMTP/TLS/RC4-MD5; 04 Sep 2013 18:03:51 +0000 Received: from [172.16.1.30] (10.68.19.166) by LONPMAILMX01.citrite.net (10.30.203.162) with Microsoft SMTP Server id 8.3.298.1; Wed, 4 Sep 2013 19:03:50 +0100 Message-ID: <52277605.3050204@citrix.com> Date: Wed, 4 Sep 2013 20:03:49 +0200 From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: "Justin T. Gibbs" Subject: Re: Another blkback issue related to flush References: <522768EA.6010809@citrix.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8bit Cc: "freebsd-xen@freebsd.org" X-BeenThere: freebsd-xen@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion of the freebsd port to xen - implementation and usage List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Sep 2013 18:03:55 -0000 On 04/09/13 19:49, Justin T. Gibbs wrote: > On Sep 4, 2013, at 11:07 AM, Roger Pau Monné wrote: > >> Hello, >> >> I've found another issue with blkback handling of flush operations, it >> was incorrectly setting one of the bio parameters when using a block >> device as backend. The attached patch fixes it, and also includes a >> small fix to correctly set the operation when writing the response on >> the ring (all responses written by FreeBSD blkback were of type >> BLKIF_OP_READ, because nreq->operation was not set). > > It seems that the req's pendcnt is unused and can be culled. Otherwise, > looks good to me. Here's the patch I have in my tree now. Thanks for catching this one. The patch looks OK to me. From owner-freebsd-xen@FreeBSD.ORG Thu Sep 5 14:21:21 2013 Return-Path: Delivered-To: xen@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 84DB9737; Thu, 5 Sep 2013 14:21:21 +0000 (UTC) (envelope-from roger.pau@citrix.com) Received: from SMTP.EU.CITRIX.COM (smtp.eu.citrix.com [46.33.159.39]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 8EB2C2264; Thu, 5 Sep 2013 14:21:20 +0000 (UTC) X-IronPort-AV: E=Sophos;i="4.90,847,1371081600"; d="scan'208";a="8463029" Received: from lonpmailmx01.citrite.net ([10.30.203.162]) by LONPIPO01.EU.CITRIX.COM with ESMTP/TLS/RC4-MD5; 05 Sep 2013 14:21:12 +0000 Received: from [172.16.1.30] (10.68.19.166) by LONPMAILMX01.citrite.net (10.30.203.162) with Microsoft SMTP Server id 8.3.298.1; Thu, 5 Sep 2013 15:21:11 +0100 Message-ID: <52289356.5090007@citrix.com> Date: Thu, 5 Sep 2013 16:21:10 +0200 From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: "Justin T. Gibbs" Subject: Re: [CFR] Xen IPI patch References: In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: Konstantin Belousov , "xen@FreeBSD.org" X-BeenThere: freebsd-xen@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion of the freebsd port to xen - implementation and usage List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Sep 2013 14:21:21 -0000 On 03/09/13 05:49, Justin T. Gibbs wrote: > In my continuing effort to get all of Roger's Xen enhancements into > FreeBSD, I'm just about finished reviewing the next patch in his > series. The current status of the patch can be found here: > > http://people.freebsd.org/~gibbs/xen_ipi.diff > > The main, and late breaking, wrinkle for this patch is the newly > committed PCID support form AMD64. I've done my best to translate > the updated assembly IPI handlers into the C equivalents needed for > Xen. But, I'm by no means an x86 assembly expert, and my current > Xen installation doesn't advertise PCID, so all of the new branches > I've added have yet to be tested. I also wonder if PVHVM guests > are supposed to perform the PCID work natively or use some other > Hypervisor functionality. PCID is supported inside of HVM containers, nothing special should be done in order to use this instructions. I've been able to test this on a system with PCID support, and everything seems to work fine, PCID is correctly detected and used by FreeBSD (when running under Xen). I've just rebased the PV IPI patch on top of Konstantin's latest PCID change: http://xenbits.xen.org/people/royger/0001-Implement-PV-IPIs-for-PVHVM-guests-and-further-conve.patch > > Other things I'm not happy about with the patch: > - hvm.c wants to use invltlb_globpcid(), but it is private > to pmap.c. I've moved it to cpufunc.h to be next to > invltlb(), but the definition of CR4_PGE (from specialreg.h) > isn't visible in all of the contexts that include cpufunc.h. > So I hackishly define it if necessary. Ick. There seems to be other places were cpufunc.h does this kind of nasty tricks. > - With the divergence of IPI handling between i386 and > amd64, x86/xen/hvm.c is growing too many ifdefs. Should > we delegate the definitions of the ipi functions to > amd64/xen/hvm.c and i386/xen/hvm.c? I will wait for this until we have a plan to merge native and Xen IPIs, right now I would leave all of them inside x86/xen/hvm.c > > - There's too much code duplication in xen_invlrng() > and some of the logic in the other handlers can probably > be tightened up. I've reduced code duplication a little bit there by creating a small inline function that contains the basic invlrng using invlpg. > Unfortunately, I'm out of time for tonight. Hopefully the list > will have some great suggestions/fixes/improvements for this patch > before I pick it up again tomorrow. > > Thanks, > Justin