From owner-freebsd-current@freebsd.org Sun May 20 02:57:06 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7FDACEEF6F6 for ; Sun, 20 May 2018 02:57:06 +0000 (UTC) (envelope-from marklmi26-fbsd@yahoo.com) Received: from sonic314-15.consmr.mail.bf2.yahoo.com (sonic314-15.consmr.mail.bf2.yahoo.com [74.6.132.125]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1764A6B35D for ; Sun, 20 May 2018 02:57:05 +0000 (UTC) (envelope-from marklmi26-fbsd@yahoo.com) X-YMail-OSG: uwIeZ4AVM1l0pAxLGFB1g8c8qcVOUJGqD2OlSDOVi_xJZhh2cK5sqF.6F2PzqE. scwEQ5mPc.Ip5EQhjkr.PYJIbS2Xw4exCecycDhKUjakWQIJJxTWxvVkW0oc.RFKg99Gls59U0qY WT5O57w08iIKtbjGb1rZV8ptybD0z2bqoFcNtj32grosDfe7_tAV6R1PwM67MyhkA6_zPfY4CEGE 7X0jeiLP4Pw5Fj3D.TawpNwmAF1SB85HQrHi4ttHGdBDMy_Rh4_j3.gIdFY.auq5rcQgnGPczndV PcMMeYPiTBPx8OjhQq6sJjotX6TMZbz188ELLzt7iOLa5mbGPi852Lh.UROqkmnpVPJ1fZNabNyF oocYog0q2i6z3yOEBzfGeHCpxdAMPWbc9ifXFCgKyK5jSaSVkCIkC_4p8sKmYUu_llYOVVXmzpgO Bz3QHiIAo1VZDuTDbkEcbkVFXzZ8W4C3eRnXBQGXjxxUIQEGW9l4_EaymO9SjsBOuhuAwP.EdweQ qAmEFOMwPeez0Bqr_.S0UnJHksdKoBmqVQA40H_nXFZahF1Eg4GOeruaAmz3bbI126aBZ_PJzwcd Mh6reE28cQgbYE8M.i3A5sX3XWJ9ehN5DuxBeH.vK6fgkfKpupi_kq.0MuV.10aI4JoNBvclZ9BU o9g-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.bf2.yahoo.com with HTTP; Sun, 20 May 2018 02:56:59 +0000 Received: from c-76-115-7-162.hsd1.or.comcast.net (EHLO [192.168.1.25]) ([76.115.7.162]) by smtp426.mail.bf1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 8a2f960f33fb449453dde59fa45bb71b; Sun, 20 May 2018 02:56:56 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 11.3 \(3445.6.18\)) Subject: head -r333905 broke the builds Message-Id: <1E5B6B0B-82B2-45F2-B10D-B5227C8BDFBC@yahoo.com> Date: Sat, 19 May 2018 19:56:54 -0700 To: mmacy@FreeBSD.org, FreeBSD Current X-Mailer: Apple Mail (2.3445.6.18) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 May 2018 02:57:06 -0000 https://ci.freebsd.org shows all the builds being broken and going through the list -r333903 was working but -r333905 and later are not. (I ignore riscv64 here.) Using powerpc64 as an -r333905 example: --- sourcefilter.o --- In file included from = /usr/obj/usr/src/powerpc.powerpc64/tmp/usr/include/netinet/ip_var.h:39, from /usr/src/lib/libc/net/sourcefilter.c:43: /usr/obj/usr/src/powerpc.powerpc64/tmp/usr/include/sys/epoch.h:42: = error: expected declaration specifiers or '...' before 'epoch_cb_count' cc1: warnings being treated as errors /usr/obj/usr/src/powerpc.powerpc64/tmp/usr/include/sys/epoch.h:42: = warning: data definition has no type or storage class /usr/obj/usr/src/powerpc.powerpc64/tmp/usr/include/sys/epoch.h:43: = error: expected declaration specifiers or '...' before 'epoch_cb_task' /usr/obj/usr/src/powerpc.powerpc64/tmp/usr/include/sys/epoch.h:43: = warning: 'struct grouptask' declared inside parameter list /usr/obj/usr/src/powerpc.powerpc64/tmp/usr/include/sys/epoch.h:43: = warning: its scope is only this definition or declaration, which is = probably not what you want /usr/obj/usr/src/powerpc.powerpc64/tmp/usr/include/sys/epoch.h:43: = warning: data definition has no type or storage class /usr/obj/usr/src/powerpc.powerpc64/tmp/usr/include/sys/epoch.h:43: = error: conflicting types for 'DPCPU_DECLARE' /usr/obj/usr/src/powerpc.powerpc64/tmp/usr/include/sys/epoch.h:42: = error: previous declaration of 'DPCPU_DECLARE' was here /usr/obj/usr/src/powerpc.powerpc64/tmp/usr/include/sys/epoch.h: In = function 'epoch_enter_preempt': /usr/obj/usr/src/powerpc.powerpc64/tmp/usr/include/sys/epoch.h:68: = error: 'curthread' undeclared (first use in this function) /usr/obj/usr/src/powerpc.powerpc64/tmp/usr/include/sys/epoch.h:68: = error: (Each undeclared identifier is reported only once /usr/obj/usr/src/powerpc.powerpc64/tmp/usr/include/sys/epoch.h:68: = error: for each function it appears in.) /usr/obj/usr/src/powerpc.powerpc64/tmp/usr/include/sys/epoch.h: In = function 'epoch_exit_preempt': /usr/obj/usr/src/powerpc.powerpc64/tmp/usr/include/sys/epoch.h:81: = error: 'curthread' undeclared (first use in this function) This seems to match up with: Author: mmacy Date: Sun May 20 00:22:28 2018 New Revision: 333905 URL:=20 https://svnweb.freebsd.org/changeset/base/333905 Log: ip(6)_freemoptions: defer imo destruction to epoch callback task =20 Avoid the ugly unlock / lock of the inpcbinfo where we need to figure out what kind of lock we hold by simply deferring the operation to another context. (Also a small dependency for converting the pcbinfo read lock to epoch) Modified: head/sys/netinet/in_mcast.c head/sys/netinet/in_pcb.c head/sys/netinet/ip_var.h head/sys/netinet6/in6_mcast.c head/sys/netinet6/in6_var.h head/sys/netinet6/ip6_var.h =3D=3D=3D Mark Millard marklmi26-fbsd at yahoo.com ( dsl-only.net went away in early 2018-Mar)