From owner-freebsd-stable@freebsd.org Mon Oct 26 21:32:01 2020 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 70D7A44F2C4 for ; Mon, 26 Oct 2020 21:32:01 +0000 (UTC) (envelope-from mlist@nlned.nl) Received: from one.dhzm.nl (one.dhzm.nl [161.97.88.222]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "dhzm.nl", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CKp2761Mdz3XC5 for ; Mon, 26 Oct 2020 21:31:59 +0000 (UTC) (envelope-from mlist@nlned.nl) Received: from nlned.nl (one.dhzm.nl [161.97.88.222]) by one.dhzm.nl (Postfix) with ESMTP id B113D101AE for ; Mon, 26 Oct 2020 22:31:51 +0100 (CET) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.0 at one.dhzm.nl Received: from 2a10:3781:150:1:9d2a:17ac:f4b1:bb49 (SquirrelMail authenticated user mlist) by nlned.nl with HTTP; Mon, 26 Oct 2020 22:31:51 +0100 Message-ID: <9c05ad281ae0d81972844155254617e2.squirrel@nlned.nl> Date: Mon, 26 Oct 2020 22:31:51 +0100 Subject: Waiting for FreeBSD 12.2-RELEASE From: "Jack Raats" To: freebsd-stable@freebsd.org Reply-To: mlist@nlned.nl User-Agent: SquirrelMail/1.4.23 [SVN] MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal X-Rspamd-Queue-Id: 4CKp2761Mdz3XC5 X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of mlist@nlned.nl designates 161.97.88.222 as permitted sender) smtp.mailfrom=mlist@nlned.nl X-Spamd-Result: default: False [-1.78 / 15.00]; HAS_REPLYTO(0.00)[mlist@nlned.nl]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; DMARC_NA(0.00)[nlned.nl]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-stable@freebsd.org]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-0.88)[-0.880]; TO_DN_NONE(0.00)[]; NEURAL_SPAM_SHORT(0.30)[0.298]; HAS_X_PRIO_THREE(0.00)[3]; NEURAL_HAM_MEDIUM(-0.99)[-0.993]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:51167, ipnet:161.97.88.0/23, country:DE]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[freebsd-stable] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Oct 2020 21:32:01 -0000 I bought a new a PC and now eager waiting for the new release to arrive!!! From owner-freebsd-stable@freebsd.org Mon Oct 26 21:50:29 2020 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3D9E844FDD1 for ; Mon, 26 Oct 2020 21:50:29 +0000 (UTC) (envelope-from SRS0=gOlx=EB=lutter.sk=juraj@ns2.wilbury.net) Received: from ns2.wilbury.net (ns2.wilbury.net [92.60.51.55]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "svc.wilbury.net", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CKpRR6nHSz3YBb for ; Mon, 26 Oct 2020 21:50:27 +0000 (UTC) (envelope-from SRS0=gOlx=EB=lutter.sk=juraj@ns2.wilbury.net) Received: from [10.3.1.13] (hq.bonet.sk [92.60.48.52]) (Authenticated sender: juraj@lutter.sk) by svc.wilbury.net (Postfix) with ESMTPSA id E855F45CE94 for ; Mon, 26 Oct 2020 22:50:18 +0100 (CET) From: Juraj Lutter Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Subject: Interrupt problems(?) on Dell R740xd Message-Id: <9FD07762-5744-480C-A289-DDB09730A74D@lutter.sk> Date: Mon, 26 Oct 2020 22:50:18 +0100 To: freebsd-stable@freebsd.org X-Mailer: Apple Mail (2.3608.120.23.2.4) X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,HELO_MISC_IP, LOTS_OF_MONEY,SPF_FAIL,TW_BN,TW_KD,TW_NV autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on ns2.wilbury.net X-Rspamd-Queue-Id: 4CKpRR6nHSz3YBb X-Spamd-Bar: + Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of SRS0=gOlx=EB=lutter.sk=juraj@ns2.wilbury.net has no SPF policy when checking 92.60.51.55) smtp.mailfrom=SRS0=gOlx=EB=lutter.sk=juraj@ns2.wilbury.net X-Spamd-Result: default: False [1.95 / 15.00]; RCVD_TLS_ALL(0.00)[]; SUBJECT_HAS_QUESTION(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; MV_CASE(0.50)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-stable@freebsd.org]; TO_DN_NONE(0.00)[]; AUTH_NA(1.00)[]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_MEDIUM(-0.49)[-0.485]; ARC_NA(0.00)[]; NEURAL_HAM_SHORT(-0.08)[-0.080]; MID_RHS_MATCH_FROM(0.00)[]; DMARC_NA(0.00)[lutter.sk]; NEURAL_SPAM_LONG(0.82)[0.818]; R_SPF_NA(0.00)[no SPF record]; FORGED_SENDER(0.30)[juraj@lutter.sk,SRS0=gOlx=EB=lutter.sk=juraj@ns2.wilbury.net]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:44185, ipnet:92.60.48.0/22, country:SK]; RCVD_COUNT_TWO(0.00)[2]; FROM_NEQ_ENVFROM(0.00)[juraj@lutter.sk,SRS0=gOlx=EB=lutter.sk=juraj@ns2.wilbury.net]; MAILMAN_DEST(0.00)[freebsd-stable] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Oct 2020 21:50:29 -0000 Hi, on a Dell R740xd with: - 22x nvm0: Dell Express Flash PM1725b 1.6TB SFF - 2x ATA SSDSC2KG240G8R - 2 package(s) x 8 core(s) x 2 hardware threads - 256GB RAM running 12.2-STABLE r367058 I've run into a problem where under some = time, the machine locks up in certain operations (mkdir, for example, not always the = same). In top output, similar entries can be seen: 12 root -80 - 0B 7936K WAIT 0 0:05 0.00% = intr{irq48: pcib12+++} 12 root -88 - 0B 7936K WAIT 6 0:05 0.00% = intr{irq16: ahci0 xhci0*} 12 root -80 - 0B 7936K WAIT 8 0:05 0.00% = intr{irq53: pcib16++} 12 root -80 - 0B 7936K WAIT 12 0:05 0.00% = intr{irq54: pcib17++} For example, running poudriere: 4124 1 I+ 0:00.21 /usr/local/libexec/poudriere/sh -e = /usr/local/share/poudriere/bulk.sh 4217 1 D+ 0:00.00 cap_mkdb = /poudriere/build/data/.m/12sgx64-default/ref/etc/login.conf And then even the root pool is getting checksum errors, with subseqent = scrub needed: Oct 26 11:55:42 bnts-nvs-n1 ZFS[4117]: pool I/O failure, zpool=3D$zroot = error=3D$97 Oct 26 11:55:42 bnts-nvs-n1 ZFS[4118]: checksum mismatch, zpool=3D$zroot = path=3D$/dev/da0p3 offset=3D$30089228288 size=3D$53248 Oct 26 11:55:42 bnts-nvs-n1 ZFS[4119]: checksum mismatch, zpool=3D$zroot = path=3D$/dev/da1p3 offset=3D$30089228288 size=3D$53248 Oct 26 11:55:49 bnts-nvs-n1 ZFS[4121]: pool I/O failure, zpool=3D$zroot = error=3D$97 Oct 26 11:56:26 bnts-nvs-n1 ZFS[4239]: pool I/O failure, zpool=3D$zroot = error=3D$97 This all happens when "increased" I/O is going via mrsas-attached disks: AVAGO MegaRAID SAS FreeBSD mrsas driver version: 07.709.04.00-fbsd mrsas0: port 0x4000-0x40ff mem = 0x9db00000-0x9db0ffff,0x9da00000-0x9dafffff irq 32 at device 0.0 = numa-domain 0 on pci4 mrsas0: FW now in Ready state mrsas0: Using MSI-X with 32 number of vectors mrsas0: FW supports <96> MSIX vector,Online CPU 32 Current MSIX <32> mrsas0: max sge: 0x46, max chain frame size: 0x400, max fw cmd: 0x39f mrsas0: Issuing IOC INIT command to FW. mrsas0: IOC INIT response received from FW. mrsas0: System PD created target ID: 0x0 mrsas0: System PD created target ID: 0x1 mrsas0: FW supports: UnevenSpanSupport=3D1 mrsas0: max_fw_cmds: 927 max_scsi_cmds: 911 mrsas0: MSI-x interrupts setup success mrsas0: mrsas_ocr_thread Internal disks are: at scbus17 target 0 lun 0 (pass2,da0) at scbus17 target 1 lun 0 (pass3,da1) Example: da0 at mrsas0 bus 1 scbus17 target 0 lun 0 da0: Fixed Direct Access SPC-4 SCSI device da0: Serial Number BTYG01730DP5240AGN da0: 150.000MB/s transfers da0: 228936MB (468862128 512 byte sectors) Internal AHCI is: pci0: numa-domain 0 on pcib0 pci0: at device 8.1 (no driver attached) pci0: at device 17.0 (no driver attached) ahci0: ahci0: AHCI v1.31 with 6 6Gbps ports, Port Multiplier not supported ahci1: ahci1: AHCI v1.31 with 8 6Gbps ports, Port Multiplier not supported sesutil map excerpt: ses0: Enclosure Name: AHCI SGPIO Enclosure 2.00 Enclosure ID: 3061686369656d30 Element 0, Type: Array Device Slot Status: Unsupported (0x00 0x00 0x00 0x00) Description: Drive Slots NVME disks are: nda0 at nvme0 bus 0 scbus19 target 0 lun 1 nda0: nda0: Serial Number S5CUNA0N201038 nda0: nvme version 1.2 x4 (max x4) lanes PCIe Gen3 (max Gen3) link nda0: 1526185MB (3125627568 512 byte sectors) The machine also has 4x bge and 4x bnxt. With hw.pci.enable_msi=3D"0" set, it's slightly better, with = hw.pci.enable_msi=3D"1", it happens more often and under even lower load than with enable_msi=3D0. enable_msix is set to 1. Once the machine locks up, one or more of the following also appears: bge2: Interface stopped DISTRIBUTING, possible flapping - this might be = caused by stuck interrupt(?) nvme0: Missing interrupt The only way out is to reboot. And I wonder, what steps could I take to narrow down the source of the = problem? The machine is not yet in production, I even can try a -CURRENT on it, = as a last resort. The one thing I=E2=80=99m also considering is to disable USB in order to = not share interrupt(s) with ahci. The weird thing is that it can survive a full buildworld with 1 make = job, but not with 32 or even 16. Did anyone came across something like this? Any hints are welcome. Thanks. =E2=80=94 Juraj Lutter XMPP: juraj (at) lutter.sk GSM: +421907986576 From owner-freebsd-stable@freebsd.org Tue Oct 27 09:42:06 2020 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 70D21445C79 for ; Tue, 27 Oct 2020 09:42:06 +0000 (UTC) (envelope-from ruben@verweg.com) Received: from erg.verweg.com (erg.verweg.com [IPv6:2a02:898:96::5e8e:f508]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4CL6DY4Tb3z4ZLv for ; Tue, 27 Oct 2020 09:42:05 +0000 (UTC) (envelope-from ruben@verweg.com) DKIM-Filter: OpenDKIM Filter v2.10.3 erg.verweg.com (unknown-jobid) Received: from neon.fritz.box (helium.connected.by.freedominter.net [45.155.157.214]) (authenticated bits=0) by erg.verweg.com (8.16.1/8.15.2) with ESMTPSA id 09R9ftqt022655 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Oct 2020 09:41:56 GMT (envelope-from ruben@verweg.com) X-Authentication-Warning: erg.verweg.com: Host helium.connected.by.freedominter.net [45.155.157.214] claimed to be neon.fritz.box Content-Type: multipart/signed; boundary="Apple-Mail=_E0A661C2-2EBB-48C0-A9F3-6AABC1526149"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Subject: Re: Waiting for FreeBSD 12.2-RELEASE From: Ruben van Staveren X-Priority: 3 (Normal) In-Reply-To: <9c05ad281ae0d81972844155254617e2.squirrel@nlned.nl> Date: Tue, 27 Oct 2020 10:41:49 +0100 Cc: freebsd-stable@freebsd.org Message-Id: <621FFDAB-AC80-49EF-83EF-E298A0568549@verweg.com> References: <9c05ad281ae0d81972844155254617e2.squirrel@nlned.nl> To: mlist@nlned.nl X-Mailer: Apple Mail (2.3608.120.23.2.4) X-Rspamd-Queue-Id: 4CL6DY4Tb3z4ZLv X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.84 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+mx]; HAS_ATTACHMENT(0.00)[]; HAS_XAW(0.00)[]; TO_DN_NONE(0.00)[]; DKIM_TRACE(0.00)[verweg.com:+]; RCPT_COUNT_TWO(0.00)[2]; HAS_X_PRIO_THREE(0.00)[3]; NEURAL_HAM_SHORT(-0.18)[-0.185]; DMARC_POLICY_ALLOW(-0.50)[verweg.com,reject]; SIGNED_PGP(-2.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:8283, ipnet:2a02:898::/32, country:NL]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.07)[-1.068]; R_DKIM_ALLOW(-0.20)[verweg.com:s=verweg]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-0.99)[-0.987]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[freebsd-stable] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Oct 2020 09:42:06 -0000 --Apple-Mail=_E0A661C2-2EBB-48C0-A9F3-6AABC1526149 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hi Jack, > On 26 Oct 2020, at 22:31, Jack Raats wrote: >=20 >=20 > I bought a new a PC and now eager waiting for the new release to = arrive!!! Don=E2=80=99t hold your horses, install now (unless your hardware is not = listed as supported in = https://www.freebsd.org/releases/12.1R/hardware.html) and use the = excellent freebsd-update when it arrives! Good luck! >=20 >=20 >=20 > _______________________________________________ > freebsd-stable@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-stable > To unsubscribe, send any mail to = "freebsd-stable-unsubscribe@freebsd.org" >=20 --Apple-Mail=_E0A661C2-2EBB-48C0-A9F3-6AABC1526149 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBAgAdFiEEJ5YXTZtFY5bgSLwXiG9r7NR3qT8FAl+X610ACgkQiG9r7NR3 qT/WaQ//fPcBb9D7SigdkIRPfdjjK+1qwGuGyHWkl+e2RbIL1HcSV7rbZY9SZxDA /BfEFlL538pjIewh85CLscHC3+8oVZD4VAlkZfucFGXzClEvV3Q+hzmWMOibrlR0 7g0S4T4lX3+tcKoC3hKzNSYUTk7BQdnsBf1ti3pbvlRYsmyyGGx+QEFP8yOZIxrL 3yLrPNDC+qvhP4YBY8nu/bUFa3zgwLhGNHcsek3viF5chFQGaGA882ita5nDojcZ RfAtBYB6AzW8MgQ+hVTVieYbMQxh8srtACMz+wOkeEn3UabWVk5sBJWOLImkWqBU 5H3WQuCBbwcuDdEXKHHWiiq3ddVgXeHwj5fuNVEWLXZ9rqfSzBRB5lMkcRowSL1V ZVD9o+Mtqg1GtYodGFetQnrY2pkOqik2MgeN3Mqv9+PgYD9zbNMF8AZ07VBdfl+k o3CkbBOumkRdU2Ch8zSUOYUOoWwhAdDrHfxUCcxqS3dT2DOWxboAPDoUdBCsGhhv V0VTN62Sn86F2weKaN0uy//k5iRfH2fkiiLzIdwLSKtxhhcsye5P/Q9w5/L/IbVE rbQYi6U/jzP7UJjFtDQ5FMBzftrMzzFElCESVmURwaiN0TJ/eCVEKXABd8OKhhZt wJGhC+rF7UaMTMC2h5vrXMP1oChRsWQjktxU33+9YBDJ+OHfJBk= =ymY3 -----END PGP SIGNATURE----- --Apple-Mail=_E0A661C2-2EBB-48C0-A9F3-6AABC1526149-- From owner-freebsd-stable@freebsd.org Tue Oct 27 14:50:44 2020 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2AD164506E1 for ; Tue, 27 Oct 2020 14:50:44 +0000 (UTC) (envelope-from sergey.dyatko@gmail.com) Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CLF4g2jR7z3SCh for ; Tue, 27 Oct 2020 14:50:43 +0000 (UTC) (envelope-from sergey.dyatko@gmail.com) Received: by mail-lj1-x232.google.com with SMTP id d24so2066260ljg.10 for ; Tue, 27 Oct 2020 07:50:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=cvj/K+v0Zwb7H7cd61V+uD8xpsm5vIih5kYpdY0rTzM=; b=R3Migmr9dVhNgH6xmCT0B1ttm3R9AlHZZjplc+4XcA7ORiXaYXouNUSKh6sSDjlXzh mLz6OAnZu58GBw10HjeNJY760tNGt26swMIhZAogdaF8hNznVY6a9DBYeTLrZmLMbSBB 9b+BVmZkORGQeNyr0D9/bbx6+yIFdUWbnRlUaZM/ShMvosLvY11j9Ea1ntIC0vnV9mqG iGyLPpqRaN8ZE/HPQ6lk3qQtQI3ZFonOWlBq+BrDJ0f5PLVFKNuVOdqsZHy517jB0U21 EH0LipJAcJPizpq+KtFn2NecLrgDxlyIEbX11cD0mwwLpirwZ7QvUUkim+iJKCuztF0k Jwog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cvj/K+v0Zwb7H7cd61V+uD8xpsm5vIih5kYpdY0rTzM=; b=cxehJtPPHnb8eVcVYPrpKJNMTc3ezkPMOEh6dqjjalXR+MRAFIE24TPIKWO9Ia36Cx KqMMyiI5+0Y7FvOtQhdHUlE1cG3mAN4LGQNUDlRm1aJzSDxoVuTk11S+/jJo+va8JT/l +F6dRNQgedBjQmT7e5VMzRoxq5gF557axZC/amxN3x+DUeQTZnrgpbWgoXlXBC7wuvXH 8W2LkM3s5LLlEZckl4DPJEp09VmLXkTT3yo6tZEJ/b1t0FgVVjNF5Xlt3L6k2aN9/xc+ qPaG9+9q/RrnMLp6Bde5PDKmtdjAb5SnI8gBoRdPZw5foSvp4NCwS8ucE3Fh850EJlKi Rb5g== X-Gm-Message-State: AOAM530F2fHPud8mTMcdFo016cXHeZ/qsxjueVMNsvKENrniDxgLGsNC 2qCS4cgcj2IkM7UXhbesBZyTz2FpwsJtGQ== X-Google-Smtp-Source: ABdhPJxJIfb1dDxOb7J7uEEpFxa7f7sR1V0n2dNGtCG9nQfqg9M2IXg7Z0hBvcl+JqQ32WvCf4GcnA== X-Received: by 2002:a2e:8599:: with SMTP id b25mr1196092lji.107.1603810241251; Tue, 27 Oct 2020 07:50:41 -0700 (PDT) Received: from laptop.domain ([86.57.155.118]) by smtp.gmail.com with ESMTPSA id i6sm203412lfo.270.2020.10.27.07.50.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 07:50:40 -0700 (PDT) Date: Tue, 27 Oct 2020 17:50:47 +0300 From: "Sergey V. Dyatko" To: freebsd-stable@freebsd.org Subject: Re: 12.2-RC2 synaptics "tap to click" Message-ID: <20201027175047.774427ea@laptop.domain> In-Reply-To: <921711d6-4cff-99ee-4c3a-13ccaa40237e@gmx.com> References: <52dda53f-2537-b3cd-be03-e7c147fddf56@gmx.com> <809b7e01-e288-5344-5a43-f9ff42baf457@gmx.com> <53d2c374-c198-b522-1d31-9e4d3afbbfcf@daemonic.se> <6292d1f1-e2c2-0e74-0841-36e6f739109f@gmx.com> <037670a9-3deb-3e49-d53e-ed12bb7acb96@daemonic.se> <6a873a86-2f36-b3e3-fe26-f2222797d37e@gmx.com> <921711d6-4cff-99ee-4c3a-13ccaa40237e@gmx.com> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; amd64-portbld-freebsd13.0) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4CLF4g2jR7z3SCh X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=R3Migmr9; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of sergeydyatko@gmail.com designates 2a00:1450:4864:20::232 as permitted sender) smtp.mailfrom=sergeydyatko@gmail.com X-Spamd-Result: default: False [-3.03 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; TO_DN_NONE(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-0.02)[-0.020]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.02)[-1.019]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-0.996]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-stable@freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::232:from]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[freebsd-stable] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Oct 2020 14:50:44 -0000 On Thu, 15 Oct 2020 08:20:25 -0600 David <2yt@gmx.com> wrote:=20 > On 2020-10-12 13:06, Niclas Zeising wrote: > > On 2020-10-12 20:49, David wrote: =20 > >> On 2020-10-12 12:08, Niclas Zeising wrote: =20 > >>> On 2020-10-12 19:02, David wrote: =20 > >>>> On 2020-10-12 10:43, Niclas Zeising wrote: =20 > >>>>> On 2020-10-12 17:08, David wrote: =20 > >>>>>> On 2020-10-12 08:15, Niclas Zeising wrote: =20 > >>>>>>> On 2020-10-11 18:55, 2yt@gmx.com wrote: =20 > >>>>>>>> On 2020-10-11 09:39, Mark Saad wrote: =20 > >>>>>>>>> 2yt > >>>>>>>>> =C2=A0=C2=A0 Can you provide us some details , what do you have= in your > >>>>>>>>> boot/loader.conf , etc/sysctl.conf > >>>>>>>>> and what do you have in your Xorg config ? =20 > >>>>>>>> > >>>>>>>> /etc/X/11/Xorg.conf does not exist. (auto generate on startup) As > >>>>>>>> far as > >>>>>>>> I know, the only synaptics related setting I have is in > >>>>>>>> /etc/boot.conf > >>>>>>>> > >>>>>>>> hw.psm.synaptics_support=3D"1" =20 > >>>>>>> > >>>>>>> This is the default on FreeBSD 12.2. > >>>>>>> =20 > >>>>>> > >>>>>> Thank you for letting me know. > >>>>>> =20 > >>>>>>>> > >>>>>>>> > >>>>>>>> Attached are the files you requested and the output of sysctl > >>>>>>>> hw.psm > >>>>>>>> =20 > >>>>>>>>> On Sun, Oct 11, 2020 at 11:29 AM <2yt@gmx.com> wrote: =20 > >>>>>>>>>> > >>>>>>>>>> I use a Thinkpad X1 Carbon 4th gen. After upgrading to 12.2 fr= om > >>>>>>>>>> 12.1, I > >>>>>>>>>> lost=C2=A0 "tap to click" which worked perfectly in past relea= ses. Is > >>>>>>>>>> this a > >>>>>>>>>> know feature change? Is there a new sysctl variable that needs > >>>>>>>>>> set? > >>>>>>>>>> > >>>>>>>>>> The other synaptics features are all working just fine. > >>>>>>>>>> > >>>>>>>>>> Thanks =20 > >>>>>>> > >>>>>>> Can you show what xinput --list-props for the trackpad? (list with > >>>>>>> xinput --list-devices and then check which device is the trackpad, > >>>>>>> then > >>>>>>> xinput --list-props id-of-trackpad). > >>>>>>> Regards =20 > >>>>>> > >>>>>> Thank you for the troubleshooting help. The output you requested d= oes > >>>>>> show "Tapping Enabled" set to 0. Is this the problem? > >>>>>> =20 > >>>>> > >>>>> It could be.=C2=A0 You could try just running something like > >>>>> `xinput --set-prop 'SynPS/2 Synaptics TouchPad' 'libinput Tapping > >>>>> Enabled'` > >>>>> and see if it helps. > >>>>> You can use the ID of the device instead of the name, but the ID mi= ght > >>>>> change if you for instance boot the machine with an additional > >>>>> keyboard > >>>>> or something.=C2=A0 If it works, you can put it in your .xinitrc eor > >>>>> .xsession, and it should take effect every time you start X. > >>>>> Regards =20 > >>>> > >>>> Yes, running `xinput --set-prop 10 'libinput Tapping Enabled' 1` did > >>>> resolve the problem. I will update .xinitrc as a workaround. > >>>> > >>>> Question: is this problem unique to my laptop? Are other Thinkpad us= ers > >>>> not experiencing this issue with 12.2? > >>>> > >>>> Thank you so much for helping me. I can't stand the clicking noise t= he > >>>> touchpad makes. =20 > >>> > >>> I don't know if others are experiencing this issue.=C2=A0 Myself, I'v= e had > >>> the xinput stuff (and some other things) in my .xinitrc for quite some > >>> time. > >>> Yours is the first report that I've seen about this. > >>> Regards =20 > >> > >> In the next day or so I will do a fresh install to confirm whether it = is > >> a bug in 12.2 or an update/ssd corruption issue. Will update you with > >> the results. > >> > >> Thanks again for the help! =20 > > > > There has been changes in how input devices are handled in FreeBSD xorg. > > =C2=A0Most of them should have been visible in 12.1 already, but it mi= ght be > > due to this. > > It is definitely not a bug, it might have been a default that changed > > with the various updates to xorg and friends, though. > > Regards =20 >=20 > Of course you are correct, it is not a bug, rather an undocumented > feature change. >=20 > I did a fresh install of 12.2-RC2 then installed xorg and > drm-fbsd12.0-kmod but X wouldn't start. I had to install from ports > drm-fbsd12.0-kmod for X to work. The "tap to click" did not work. >=20 > Perhaps we could update the wiki > https://wiki.freebsd.org/SynapticsTouchpad to include the the > instructions to enable/disable "tap to click". >=20 I have following xorg.conf section: Section "InputClass" Identifier "libinput touchpad catchall" MatchIsTouchpad "on" MatchDevicePath "/dev/input/event*" Option "Tapping" "on" Driver "libinput" EndSection maybe there is a better solution, but this works in my case (13.0-CURRENT #2 r362468) -- wbr, Sergey From owner-freebsd-stable@freebsd.org Wed Oct 28 12:02:27 2020 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7333E444EB2 for ; Wed, 28 Oct 2020 12:02:27 +0000 (UTC) (envelope-from jhs@berklix.com) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4CLnJ31w5yz42jk for ; Wed, 28 Oct 2020 12:02:27 +0000 (UTC) (envelope-from jhs@berklix.com) Received: by mailman.nyi.freebsd.org (Postfix) id 3FE1D444D3E; Wed, 28 Oct 2020 12:02:27 +0000 (UTC) Delivered-To: stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3FA83444CC1 for ; Wed, 28 Oct 2020 12:02:27 +0000 (UTC) (envelope-from jhs@berklix.com) Received: from slim.berklix.org (slim.berklix.org [94.185.90.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "slim.berklix.org", Issuer "slim.berklix.org" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CLnJ21hRwz42Ll for ; Wed, 28 Oct 2020 12:02:25 +0000 (UTC) (envelope-from jhs@berklix.com) Received: from mart.js.berklix.net (p4fc4cc8e.dip0.t-ipconnect.de [79.196.204.142]) (authenticated bits=128) by slim.berklix.org (8.15.2/8.15.2) with ESMTPSA id 09SC2D5o020203 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 28 Oct 2020 13:02:17 +0100 (CET) (envelope-from jhs@berklix.com) Received: from fire.js.berklix.net (fire.js.berklix.net [192.168.91.41]) by mart.js.berklix.net (8.14.3/8.14.3) with ESMTP id 09SC2Dbm088883 for ; Wed, 28 Oct 2020 13:02:13 +0100 (CET) (envelope-from jhs@berklix.com) Received: from fire.js.berklix.net (localhost [127.0.0.1]) by fire.js.berklix.net (8.14.7/8.14.7) with ESMTP id 09SC23PC035979 for ; Wed, 28 Oct 2020 13:02:13 +0100 (CET) (envelope-from jhs@berklix.com) Message-Id: <202010281202.09SC23PC035979@fire.js.berklix.net> To: stable@freebsd.org Subject: calendar (1) - patch to correct error description From: "Julian H. Stacey" Organization: http://berklix.com/jhs/ User-agent: EXMH on FreeBSD http://www.berklix.eu/free/ X-From: http://www.berklix.eu/~jhs/ Date: Wed, 28 Oct 2020 13:02:03 +0100 X-Rspamd-Queue-Id: 4CLnJ21hRwz42Ll X-Spamd-Bar: + Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of jhs@berklix.com has no SPF policy when checking 94.185.90.68) smtp.mailfrom=jhs@berklix.com X-Spamd-Result: default: False [1.46 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; FREEFALL_USER(0.00)[jhs]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-0.22)[-0.219]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[stable@freebsd.org]; TO_DN_NONE(0.00)[]; AUTH_NA(1.00)[]; RCPT_COUNT_ONE(0.00)[1]; HAS_ORG_HEADER(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; DMARC_NA(0.00)[berklix.com]; NEURAL_SPAM_SHORT(0.24)[0.240]; NEURAL_SPAM_MEDIUM(0.54)[0.536]; R_SPF_NA(0.00)[no SPF record]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:33824, ipnet:94.185.88.0/22, country:DE]; RCVD_TLS_LAST(0.00)[]; MAILMAN_DEST(0.00)[stable]; RECEIVED_SPAMHAUS_PBL(0.00)[79.196.204.142:received] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Oct 2020 12:02:27 -0000 man calendar states: "The calendar internal cpp does not correctly do #ifndef and will discard the rest of the file if a #ifndef is triggered." That is wrong, as proved by test file: --- // Test data for ~/.calendar/calendar * bla0 #ifdef DEBUG1 * 28 bla1 #endif #ifdef DEBUG2 * 28 bla2 #endif #ifndef DEBUG3 * 28 bla3 #endif #define DEBUG4 TRUE #ifndef DEBUG4 * 28 bla4 #endif * 28 bla5 --- Produces: --- Oct 28 bla5 Oct 28 bla4 Oct 28 bla3 Oct 28 bla2 Oct 28 bla1 --- Correction: The calendar internal cpp ignores directives #ifdef , #ifndef and #endif , and simply including intervening text regardless. Patch built Wed Oct 28 12:39:27 CET 2020 on .ctm_status src-12 914 .svn_revision 366896 : --- http://www.berklix.com/~jhs/src/bsd/fixes/freebsd/src/gen/usr.bin/calendar/calendar.1.ifdef.REL=12.2-STABLE.diff *** 12.2-STABLE/src/usr.bin/calendar/calendar.1 Wed Oct 21 01:14:23 2020 --- new-generic/src/usr.bin/calendar/calendar.1 Wed Oct 28 12:33:12 2020 *************** *** 323,330 **** .Sh BUGS The .Nm ! internal cpp does not correctly do #ifndef and will discard the rest ! of the file if a #ifndef is triggered. It also has a maximum of 50 include file and/or 100 #defines and only recognises #include, #define and #ifndef. --- 323,330 ---- .Sh BUGS The .Nm ! internal cpp ignores directives #ifdef , #ifndef and #endif , ! and simply including intervening text regardless. It also has a maximum of 50 include file and/or 100 #defines and only recognises #include, #define and #ifndef. --- Later I could file this with send-pr, but before that I'm chasing another calendar cpp error (maybe which cpp is used may need to be considered, & that might reflect into discussion of which cpp used on which BSDs) Cheers, -- Julian Stacey, Consultant Sys. Eng. BSD Linux Unix, http://berklix.com/jhs/cv/ Crash Brexit profits financial speculators in cabinet damaging Britain. UK stole 3.7 million votes from Brits abroad 700 K in EU http://stolenvotes.uk From owner-freebsd-stable@freebsd.org Wed Oct 28 12:33:42 2020 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3086844593C for ; Wed, 28 Oct 2020 12:33:42 +0000 (UTC) (envelope-from michal.jakubik@zoho.com) Received: from sender4-op-o13.zoho.com (sender4-op-o13.zoho.com [136.143.188.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4CLp041jRMz448Y for ; Wed, 28 Oct 2020 12:33:39 +0000 (UTC) (envelope-from michal.jakubik@zoho.com) ARC-Seal: i=1; a=rsa-sha256; t=1603888415; cv=none; d=zohomail.com; s=zohoarc; b=fbd/w+NXQczOn2aGDk3syA0ZvVAJ7Ws6aHhxEmJ52OzuMKrhCwx+h8R9VQUKKBJDS3GAIeJKFRb4kylViCQFOv1MwzxkUBCgRcBnNfJcjuI69hEFBCybTy6YV+PYGGFk/BbRUDa5tes3K0SD2vDqmDkK1HXg2JfRHt0eLhsDCpE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603888415; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:MIME-Version:Message-ID:Reply-To:References:Subject:To; bh=yVK9SgzGJc94HUZiHhYwqreuvxSWxPQAXmsi2Zfgbls=; b=hwJKAQNQziS78D/BTU6EGJvoGq1bPpp6ABSccbeH8c1EVSY6RADAPJs0m4sviMrofB+Zq8I88J446NDrFcNrtHpGT9TSSERK5a7leqbuhgB5fNfWoXEiHtq8nXXoBGNCP4ARGxJMnljf00ucrBfiiAoqyFg34B2rKjxxlPzy3E8= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass smtp.mailfrom=michal.jakubik@zoho.com; dmarc=pass header.from= header.from= DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=zapps768; d=zoho.com; h=date:from:reply-to:to:message-id:in-reply-to:references:subject:mime-version:content-type:user-agent; b=TYU1uqySnZzHhuokNLCrzfXYwqmZTZmWJqDeUAjs8BqWxGXYHE3X+Jym08ddyQAM9WGmmC5Xqjcn qpTDhTiuZZ8kvqR6P/xqoCVxU4h5Wb7b3tcBz4s9iLXy+XtzOqDh Received: from mail.zoho.com by mx.zohomail.com with SMTP id 1603888414564591.0224448223632; Wed, 28 Oct 2020 05:33:34 -0700 (PDT) Date: Wed, 28 Oct 2020 08:33:34 -0400 From: Mike Jakubik Reply-To: mike.jakubik@swiftsmsgateway.com To: "Freebsd Stable" Message-ID: <1756f32ff63.11d4fc774212736.6426540380400114083@swiftsmsgateway.com> In-Reply-To: <175511429f5.ff83169625753.7800820802617382912@swiftsmsgateway.com> References: <175511429f5.ff83169625753.7800820802617382912@swiftsmsgateway.com> Subject: Re: Custom kernel breaks py-glances in 12.2 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Importance: Medium User-Agent: Zoho Mail X-Mailer: Zoho Mail X-Rspamd-Queue-Id: 4CLp041jRMz448Y X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of michal.jakubik@zoho.com designates 136.143.188.13 as permitted sender) smtp.mailfrom=michal.jakubik@zoho.com X-Spamd-Result: default: False [-3.36 / 15.00]; HAS_REPLYTO(0.00)[mike.jakubik@swiftsmsgateway.com]; XM_UA_NO_VERSION(0.01)[]; RWL_MAILSPIKE_GOOD(0.00)[136.143.188.13:from]; R_SPF_ALLOW(-0.20)[+ip4:136.143.188.0/24]; REPLYTO_ADDR_EQ_FROM(0.00)[]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-0.35)[-0.350]; FORGED_SENDER(0.30)[mike.jakubik@swiftsmsgateway.com,michal.jakubik@zoho.com]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[zoho.com]; ARC_ALLOW(-1.00)[zohomail.com:s=zohoarc:i=1]; R_DKIM_NA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[mike.jakubik@swiftsmsgateway.com,michal.jakubik@zoho.com]; ASN(0.00)[asn:2639, ipnet:136.143.188.0/23, country:US]; MID_RHS_MATCH_FROM(0.00)[]; NEURAL_HAM_MEDIUM(-1.02)[-1.021]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-0.995]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[swiftsmsgateway.com]; RCPT_COUNT_ONE(0.00)[1]; RCVD_TLS_LAST(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[136.143.188.13:from]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[freebsd-stable] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Oct 2020 12:33:42 -0000 ---- On Thu, 22 Oct 2020 12:11:17 -0400 Mike Jakubik wrote ---- > Hi, > > When i compile a non GENERIC kernel (which mainly removes some debugging and devices i do not have) the Python program glances fails with the following message. > For anyone interested, i found the solution, seems like some sysctl's have changed in 12.2 that the programs still depends on, enabling COMPAT_FREEBSD11 fixes the issue (along with some memory collection issues in Zabbix). From owner-freebsd-stable@freebsd.org Wed Oct 28 13:18:52 2020 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 83391446CA2 for ; Wed, 28 Oct 2020 13:18:52 +0000 (UTC) (envelope-from se@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CLq0D2xlzz45rp; Wed, 28 Oct 2020 13:18:52 +0000 (UTC) (envelope-from se@freebsd.org) Received: from Stefans-MBP-WLAN.fritz.box (p200300cd5f0bbc00c5f6c550d2a7fd66.dip0.t-ipconnect.de [IPv6:2003:cd:5f0b:bc00:c5f6:c550:d2a7:fd66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: se/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id CDD1C18B0D; Wed, 28 Oct 2020 13:18:51 +0000 (UTC) (envelope-from se@freebsd.org) To: "Julian H. Stacey" References: <202010281202.09SC23PC035979@fire.js.berklix.net> From: Stefan Esser Cc: freebsd-stable Subject: Re: calendar (1) - patch to correct error description Message-ID: <3ec7872e-c264-e05f-cc3b-bbd2f421a97f@freebsd.org> Date: Wed, 28 Oct 2020 14:18:48 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <202010281202.09SC23PC035979@fire.js.berklix.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Oct 2020 13:18:52 -0000 Am 28.10.20 um 13:02 schrieb Julian H. Stacey: > man calendar states: > "The calendar internal cpp does not correctly do #ifndef and will discard > the rest of the file if a #ifndef is triggered." > That is wrong, as proved by test file: > --- > // Test data for ~/.calendar/calendar > * bla0 > #ifdef DEBUG1 > * 28 bla1 > #endif > #ifdef DEBUG2 > * 28 bla2 > #endif > #ifndef DEBUG3 > * 28 bla3 > #endif > #define DEBUG4 TRUE > #ifndef DEBUG4 > * 28 bla4 > #endif > * 28 bla5 > --- > Produces: > --- > Oct 28 bla5 > Oct 28 bla4 > Oct 28 bla3 > Oct 28 bla2 > Oct 28 bla1 > --- > Correction: > The calendar internal cpp ignores directives #ifdef , #ifndef and #endif , > and simply including intervening text regardless. Hi Julian, no, the calendar program worked as documented, see the BUGS section of the man-page: .Sh BUGS The .Nm internal cpp does not correctly do #ifndef and will discard the rest-of the file if a #ifndef is triggered.-It also has a maximum of 50 include file and/or 100 #defines and only recognises #include, #define and #ifndef. There is no mention of #ifdef being supported ... And your "#ifndef DEBUG4" did not trigger, since the whole line after #define is used as the identifier, in your case "DEBUG4 TRUE". This is not obvious from reading the man-page and it might be more intuitive, if the identifier was only the word up to the first blank, but the code in the calendar program does just strip off leading and trailing white-space. It might be too late to change this behavior. I have updated the code in -CURRENT to support #ifdef (MFC in 3 days) and I plan to add supported for nested conditions in -CURRENT (not sure whether that should be merged to -STABLE, though). I could change the #define and #if/ifndef to only consider the first following word, but do not plan to do that at this time. Regards, STefan From owner-freebsd-stable@freebsd.org Thu Oct 29 00:30:02 2020 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A3FEF453A3C for ; Thu, 29 Oct 2020 00:30:02 +0000 (UTC) (envelope-from jhs@berklix.com) Received: from slim.berklix.org (slim.berklix.org [94.185.90.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "slim.berklix.org", Issuer "slim.berklix.org" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CM5td4ScDz3XLC; Thu, 29 Oct 2020 00:30:01 +0000 (UTC) (envelope-from jhs@berklix.com) Received: from mart.js.berklix.net (p4fc4cc8e.dip0.t-ipconnect.de [79.196.204.142]) (authenticated bits=128) by slim.berklix.org (8.15.2/8.15.2) with ESMTPSA id 09T0TsHI026052 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 29 Oct 2020 01:29:58 +0100 (CET) (envelope-from jhs@berklix.com) Received: from fire.js.berklix.net (fire.js.berklix.net [192.168.91.41]) by mart.js.berklix.net (8.14.3/8.14.3) with ESMTP id 09T0Ts94093919; Thu, 29 Oct 2020 01:29:54 +0100 (CET) (envelope-from jhs@berklix.com) Received: from fire.js.berklix.net (localhost [127.0.0.1]) by fire.js.berklix.net (8.14.7/8.14.7) with ESMTP id 09T0Td4m004819; Thu, 29 Oct 2020 01:29:49 +0100 (CET) (envelope-from jhs@berklix.com) Message-Id: <202010290029.09T0Td4m004819@fire.js.berklix.net> To: Stefan Esser cc: freebsd-stable cc: Greg Balfour Subject: Re: calendar (1) - patch to correct error description From: "Julian H. Stacey" Organization: http://berklix.com/jhs/ User-agent: EXMH on FreeBSD http://berklix.com/free/ X-From: http://www.berklix.org/~jhs/ In-reply-to: Your message "Wed, 28 Oct 2020 14:18:48 +0100." <3ec7872e-c264-e05f-cc3b-bbd2f421a97f@freebsd.org> Date: Thu, 29 Oct 2020 01:29:39 +0100 X-Rspamd-Queue-Id: 4CM5td4ScDz3XLC X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of jhs@berklix.com has no SPF policy when checking 94.185.90.68) smtp.mailfrom=jhs@berklix.com X-Spamd-Result: default: False [0.19 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; MULTIPLE_UNIQUE_HEADERS(0.70)[Cc]; HAS_ORG_HEADER(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; TO_DN_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:33824, ipnet:94.185.88.0/22, country:DE]; MIME_TRACE(0.00)[0:+]; RECEIVED_SPAMHAUS_PBL(0.00)[79.196.204.142:received]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.67)[-0.667]; FREEFALL_USER(0.00)[jhs]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; NEURAL_SPAM_SHORT(0.19)[0.191]; NEURAL_HAM_LONG(-0.93)[-0.931]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[berklix.com]; AUTH_NA(1.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; R_SPF_NA(0.00)[no SPF record]; FREEMAIL_CC(0.00)[gmail.com]; MAILMAN_DEST(0.00)[freebsd-stable] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Oct 2020 00:30:02 -0000 Hi Stefan > Am 28.10.20 um 13:02 schrieb Julian H. Stacey: > > man calendar states: > > "The calendar internal cpp does not correctly do #ifndef and will discard > > the rest of the file if a #ifndef is triggered." > > That is wrong, as proved by test file: > > --- > > // Test data for ~/.calendar/calendar > > * bla0 > > #ifdef DEBUG1 > > * 28 bla1 > > #endif > > #ifdef DEBUG2 > > * 28 bla2 > > #endif > > #ifndef DEBUG3 > > * 28 bla3 > > #endif > > #define DEBUG4 TRUE > > #ifndef DEBUG4 > > * 28 bla4 > > #endif > > * 28 bla5 > > --- > > Produces: > > --- > > Oct 28 bla5 > > Oct 28 bla4 > > Oct 28 bla3 > > Oct 28 bla2 > > Oct 28 bla1 > > --- > > Correction: > > The calendar internal cpp ignores directives #ifdef , #ifndef and #endif , > > and simply including intervening text regardless. > > Hi Julian, > > no, the calendar program worked as documented, see the BUGS section of > the man-page: > > .Sh BUGS > The > .Nm > internal cpp does not correctly do #ifndef and will discard the rest-of > the file if a #ifndef is triggered.-It also has a maximum of 50 include > file and/or 100 #defines and only recognises #include, #define and > #ifndef. Ah OK, here's 2 test cases ---Ex 1 * 29 bla1 #ifndef RAINEY * 29 bla4 #endif * 29 bla5 --- Ex 2 * 29 bla1 #define RAINEY YES #ifndef RAINEY * 29 bla4 #endif * 29 bla5 --- They both produce: --- Oct 29 bla5 Oct 29 bla4 Oct 29 bla1 --- Where manual misleads with: "internal cpp ... will discard the rest-of the file if a #ifndef is triggered" Triggered or not, that #ifndef to cpp seems not discard rest of file. > There is no mention of #ifdef being supported ... OK, I just assumed that would be supported if #ifndef was. > And your "#ifndef DEBUG4" did not trigger, since the whole line after > #define is used as the identifier, in your case "DEBUG4 TRUE". There lies the problem, Thanks ! Nasty, I dont recall anything called cpp aka C Pre Processor ever being that limited, back to 1983 on a C compiler that ran on CP/M, where masses of other C things were broken. Best that calendar not call it cpp at all, as name misleads. OK, tested with --- * 29 bla1 #define RAINEY #ifndef RAINEY * 29 bla4 #endif * 29 bla5 --- & got --- Oct 29 bla5 Oct 29 bla1 --- & finaly in this special case current manual correctly reports a bug. > This is not obvious from reading the man-page and it might be more > intuitive, if the identifier was only the word up to the first blank, Yes > but the code in the calendar program does just strip off leading and > trailing white-space. It might be too late to change this behavior. Hopefully not too late. Either way, Ameliorations: - Do a global edit in manual from "cpp" to "pre-processor" to remove expectation of similarity to cpp. - Define in manual exactly how the pre-processor handles defines. > I have updated the code in -CURRENT to support #ifdef (MFC in 3 days) Nice > and I plan to add supported for nested conditions in -CURRENT Nice > (not > sure whether that should be merged to -STABLE, though). Probably yes ? > I could change the #define and #if/ifndef to only consider the first > following word, but do not plan to do that at this time. Would be good if you did, silently swallowing space seperated text as extended name of a define instead of value of define, is not intuitive, At least document if you have no time to change it please ? Fixing documenting & extanding a pp in calendar could become like re-inventing the wheel ? As a cpp is in src/ & not ports, can't calendar use popen(/usr/bin/cpp) & save work ? Looks like there's enough work to do in main calendar without extra work of a custom pre processor ? Thanks for copy of your reply to Greg Balfour's off list mail, ref https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=205580 which notes: "This patch is against 11.4-RELEASE. Note that it requires the installation of the devel/tradcpp port/package." I agree your policy point, FreeBSD can't use a port as dependency to build calendar, while calendar is still build by src/ world. (& not just for Free, but Net & Open BSD etc will have similiar views I presume) I don't know which cpp's from where might have been looked at in the past, > Regards, STefan Thanks ! Cheers, -- Julian Stacey, Consultant Sys. Eng. BSD Linux Unix, http://berklix.com/jhs/cv/ Crash Brexit profits financial speculators in cabinet damaging Britain. UK stole 3.7 million votes from Brits abroad 700 K in EU http://stolenvotes.uk From owner-freebsd-stable@freebsd.org Thu Oct 29 12:07:19 2020 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id ED59F44EABE for ; Thu, 29 Oct 2020 12:07:19 +0000 (UTC) (envelope-from db@db.net) Received: from tfm.com (mtbaker.tfm.com [192.231.224.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.tfm.com", Issuer "Sectigo RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CMPMB62hgz4dn5; Thu, 29 Oct 2020 12:07:18 +0000 (UTC) (envelope-from db@db.net) Received: from night.db.net (DB-DSL.ServerNorth.com [98.124.61.131]) (authenticated bits=0) by tfm.com (8.14.4/8.14.4) with ESMTP id 09TC73pB006308 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 29 Oct 2020 05:07:05 -0700 (PDT) Date: Thu, 29 Oct 2020 08:07:02 -0400 From: Diane Bruce To: "Julian H. Stacey" Cc: Stefan Esser , freebsd-stable , Greg Balfour Subject: Re: calendar (1) - patch to correct error description Message-ID: <20201029120702.GA44939@night.db.net> References: <3ec7872e-c264-e05f-cc3b-bbd2f421a97f@freebsd.org> <202010290029.09T0Td4m004819@fire.js.berklix.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202010290029.09T0Td4m004819@fire.js.berklix.net> X-Rspamd-Queue-Id: 4CMPMB62hgz4dn5 X-Spamd-Bar: + Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of db@db.net has no SPF policy when checking 192.231.224.2) smtp.mailfrom=db@db.net X-Spamd-Result: default: False [1.05 / 15.00]; RCVD_TLS_LAST(0.00)[]; ARC_NA(0.00)[]; FREEMAIL_CC(0.00)[freebsd.org,gmail.com]; FREEFALL_USER(0.00)[db]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; NEURAL_HAM_MEDIUM(-0.68)[-0.683]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[db.net]; AUTH_NA(1.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-0.78)[-0.780]; NEURAL_SPAM_LONG(0.11)[0.114]; R_SPF_NA(0.00)[no SPF record]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; ASN(0.00)[asn:10488, ipnet:192.231.224.0/22, country:US]; SUSPICIOUS_RECIPS(1.50)[]; MAILMAN_DEST(0.00)[freebsd-stable] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Oct 2020 12:07:20 -0000 On Thu, Oct 29, 2020 at 01:29:39AM +0100, Julian H. Stacey wrote: > Hi Stefan > > Am 28.10.20 um 13:02 schrieb Julian H. Stacey: > > > man calendar states: > > > "The calendar internal cpp does not correctly do #ifndef and will discard > > > the rest of the file if a #ifndef is triggered." > > > That is wrong, as proved by test file: If I was asked about this I'd suggest ripping out the internal cpp and switching back to an external cpp IFF calendar is all in ports. The idea when the original very hurried hack was done was to remove more from base. No longer a problem if using ports. > > > --- > > > // Test data for ~/.calendar/calendar > > > * bla0 ... > > This is not obvious from reading the man-page and it might be more > > intuitive, if the identifier was only the word up to the first blank, > > Yes > > > but the code in the calendar program does just strip off leading and > > trailing white-space. It might be too late to change this behavior. > > Hopefully not too late. > Either way, Ameliorations: > - Do a global edit in manual from "cpp" to "pre-processor" > to remove expectation of similarity to cpp. > - Define in manual exactly how the pre-processor handles defines. > > > > I have updated the code in -CURRENT to support #ifdef (MFC in 3 days) > > Nice > > > > and I plan to add supported for nested conditions in -CURRENT > > Nice > > > > (not > > sure whether that should be merged to -STABLE, though). > > Probably yes ? > > > > I could change the #define and #if/ifndef to only consider the first > > following word, but do not plan to do that at this time. > > Would be good if you did, silently swallowing space seperated text > as extended name of a define instead of value of define, is not > intuitive, At least document if you have no time to change it please ? > > Fixing documenting & extanding a pp in calendar could become like > re-inventing the wheel ? As a cpp is in src/ & not ports, can't > calendar use popen(/usr/bin/cpp) & save work ? Looks like there's > enough work to do in main calendar without extra work of a custom > pre processor ? > > Thanks for copy of your reply to Greg Balfour's off list mail, ref > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=205580 > which notes: > "This patch is against 11.4-RELEASE. Note that it requires > the installation of the devel/tradcpp port/package." > > I agree your policy point, FreeBSD can't use a port as dependency > to build calendar, while calendar is still build by src/ world. (& > not just for Free, but Net & Open BSD etc will have similiar views > I presume) Indeed I'd revert back to this. > > I don't know which cpp's from where might have been looked at in the past, > > > Regards, STefan > > Thanks ! > > Cheers, > -- > Julian Stacey, Consultant Sys. Eng. BSD Linux Unix, http://berklix.com/jhs/cv/ > Crash Brexit profits financial speculators in cabinet damaging Britain. > UK stole 3.7 million votes from Brits abroad 700 K in EU http://stolenvotes.uk Diane -- - db@FreeBSD.org db@db.net http://www.db.net/~db From owner-freebsd-stable@freebsd.org Thu Oct 29 13:04:14 2020 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 75881450983 for ; Thu, 29 Oct 2020 13:04:14 +0000 (UTC) (envelope-from se@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CMQct2YQ5z3Ssq; Thu, 29 Oct 2020 13:04:14 +0000 (UTC) (envelope-from se@freebsd.org) Received: from Stefans-MacBook-Pro-449.fritz.box (p200300cd5f0bbc0018d60868c7568750.dip0.t-ipconnect.de [IPv6:2003:cd:5f0b:bc00:18d6:868:c756:8750]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: se/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 9A6DF233EA; Thu, 29 Oct 2020 13:04:13 +0000 (UTC) (envelope-from se@freebsd.org) To: Diane Bruce Cc: freebsd-stable , Greg Balfour , "Julian H. Stacey" References: <3ec7872e-c264-e05f-cc3b-bbd2f421a97f@freebsd.org> <202010290029.09T0Td4m004819@fire.js.berklix.net> <20201029120702.GA44939@night.db.net> From: Stefan Esser Subject: Re: calendar (1) - patch to correct error description Message-ID: Date: Thu, 29 Oct 2020 14:04:12 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201029120702.GA44939@night.db.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Oct 2020 13:04:14 -0000 Am 29.10.20 um 13:07 schrieb Diane Bruce: > On Thu, Oct 29, 2020 at 01:29:39AM +0100, Julian H. Stacey wrote: >> Hi Stefan >>> Am 28.10.20 um 13:02 schrieb Julian H. Stacey: >>>> man calendar states: >>>> "The calendar internal cpp does not correctly do #ifndef and will discard >>>> the rest of the file if a #ifndef is triggered." >>>> That is wrong, as proved by test file: > > If I was asked about this I'd suggest ripping out the internal cpp > and switching back to an external cpp IFF calendar is all in ports. > The idea when the original very hurried hack was done was to remove > more from base. No longer a problem if using ports. This is a possibility, but there exists no plan to remove the calendar program from base, currently. I have created the deskutils/calendar port for RELEASE users that want to take advantage of recent changes to the calendar program, but this port exists for only this particular purpose. Piping of the calendar files through CPP leads to other problems, e.g. how to feed error messages from CPP back to the calendar program in a sensible way. I have made the semantics of #define and #if(n)def more similar to that of a CPP, but there still is one major difference: #define COND true #ifdef COND will not get the result you might expect, since "COND true" has been defined and #ifdef COND true will evaluate to true. This is easily changed (I'd use only the first word in #define and reject #ifdef if followed by more than one word), but while being nearer to what CPP would give, it deviates from many years of practice in FreeBSD and might not be allowed to be MFCed. And different semantics in -CURRENT vs. -STABLE are even less acceptable, IMHO. But I'd like to apply such a patch, anyway. There are other changes to the semantics that are possible, e.g. to check that #ifdef/#endif are balanced or that there is no #else outside an #ifdef/#endif range. Implementing such checks is quite simple, given the structure of the code, but I'm not sure that this is required or even a good idea, since it might break current calendar data files that are not really well-formed ... Best regards, STefan From owner-freebsd-stable@freebsd.org Thu Oct 29 19:36:16 2020 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3E5D545BDB9 for ; Thu, 29 Oct 2020 19:36:16 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from gold.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "gate2.funkthat.com", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CMbKC2gM2z4Fh8; Thu, 29 Oct 2020 19:36:14 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from gold.funkthat.com (localhost [127.0.0.1]) by gold.funkthat.com (8.15.2/8.15.2) with ESMTPS id 09TJaDrh024584 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 29 Oct 2020 12:36:13 -0700 (PDT) (envelope-from jmg@gold.funkthat.com) Received: (from jmg@localhost) by gold.funkthat.com (8.15.2/8.15.2/Submit) id 09TJaD1O024583; Thu, 29 Oct 2020 12:36:13 -0700 (PDT) (envelope-from jmg) Date: Thu, 29 Oct 2020 12:36:13 -0700 From: John-Mark Gurney To: sreehari Cc: Kurt Jaeger , "FreeBSD-stable@FreeBSD.org" Subject: Re: 12.2-RC1: RTL8251/8153 1000BASE-T seemingly stuck at 100Mbps Message-ID: <20201029193613.GL31099@funkthat.com> Mail-Followup-To: sreehari , Kurt Jaeger , "FreeBSD-stable@FreeBSD.org" References: <20201007223858.GS4213@funkthat.com> <20201008043602.GV53210@home.opsec.eu> <20201008063620.GT4213@funkthat.com> <20201008075314.GU4213@funkthat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: FreeBSD 11.3-STABLE amd64 X-PGP-Fingerprint: D87A 235F FB71 1F3F 55B7 ED9B D5FF 5A51 C0AC 3D65 X-Files: The truth is out there X-URL: https://www.funkthat.com/ X-Resume: https://www.funkthat.com/~jmg/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (gold.funkthat.com [127.0.0.1]); Thu, 29 Oct 2020 12:36:14 -0700 (PDT) X-Rspamd-Queue-Id: 4CMbKC2gM2z4Fh8 X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of jmg@gold.funkthat.com has no SPF policy when checking 208.87.223.18) smtp.mailfrom=jmg@gold.funkthat.com X-Spamd-Result: default: False [0.01 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; ARC_NA(0.00)[]; FREEFALL_USER(0.00)[jmg]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[funkthat.com]; AUTH_NA(1.00)[]; MID_RHS_MATCH_FROM(0.00)[]; NEURAL_HAM_LONG(-0.23)[-0.231]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.52)[-0.515]; NEURAL_HAM_MEDIUM(-0.45)[-0.448]; R_SPF_NA(0.00)[no SPF record]; FREEMAIL_TO(0.00)[gmail.com]; FORGED_SENDER(0.30)[jmg@funkthat.com,jmg@gold.funkthat.com]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:32354, ipnet:208.87.216.0/21, country:US]; FROM_NEQ_ENVFROM(0.00)[jmg@funkthat.com,jmg@gold.funkthat.com]; MAILMAN_DEST(0.00)[FreeBSD-stable]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Oct 2020 19:36:16 -0000 sreehari wrote this message on Thu, Oct 08, 2020 at 16:04 -0700: > ok I tried cherry picking the commit from head to stable/12 according to > one person's suggestion and I get some hunk failed's when i try patch -C > -p0. Is there any way I can simulate the MFC? Sorry I'm just not familiar > with svn Sorry, I missed this reply... I'll be merging the change into stable/12 in the comming week... > On Thu, Oct 8, 2020, 00:53 John-Mark Gurney wrote: > > > sreehari wrote this message on Wed, Oct 07, 2020 at 23:56 -0700: > > > I see. Since I have the hardware and freebsd head seems broken on my > > > laptop, I'll try compiling stable/12 with the ure patch from head within > > > the next few days. I have gigabit internet and other machines to test the > > > ethernet with the full 1000Mbps. Are there any actions you suggest I take > > > to benchmark or stress test the hardware or make sure everything is > > working > > > properly? > > > > Nothing in particular... iperf or iperf3 works well... do normal > > transfers and make sure you don't see packet drops that are unexpected > > (checksumming was enabled)... If you have vlans, use those... Just be > > aware of any unexpected behaviors.. > > > > Thanks for the additional testing! And letting mek now that it works > > is useful! > > > > > On Wed, Oct 7, 2020, 23:36 John-Mark Gurney wrote: > > > > > > > Kurt Jaeger wrote this message on Thu, Oct 08, 2020 at 06:36 +0200: > > > > > > sreehari wrote this message on Tue, Oct 06, 2020 at 21:02 -0700: > > > > > > > I have a USB C hub that supports gigabit ethernet under any > > other OS, > > > > > > > but under FreeBSD it seems to detect it properly, but I never get > > > > > > > speeds exceeding 100Mbps transfer rate on the whole thing. Is > > this a > > > > > > > known issue? Also is there any way to check what the perceived > > link > > > > > > > speed is? I've attached dmesg.boot if that helps. > > > > > > > > > > > > This is a known issue w/ the ure driver on FreeBSD. This has been > > > > > > fixed in -current, and in a few months I'll look at merging it to > > > > > > stable/12, but it definitly will not make the 12.2 release: > > > > > > https://reviews.freebsd.org/D25809 > > > > > > > > > > The changes seem to be limited to the driver itself -- is some > > > > > structural change in 13 stopping a merge to 12.2 ? > > > > > > > > The issue is that IMO, it's too close to the release of 12.2. It only > > > > recently got committed to 13, and so hasn't had enough time to be > > tested > > > > in more environments than mine. There have been a few others that have > > > > tested it. -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not." From owner-freebsd-stable@freebsd.org Thu Oct 29 23:49:11 2020 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7C7E74412D9 for ; Thu, 29 Oct 2020 23:49:11 +0000 (UTC) (envelope-from jhs@berklix.com) Received: from slim.berklix.org (slim.berklix.org [94.185.90.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "slim.berklix.org", Issuer "slim.berklix.org" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CMhx24w9mz4VSv; Thu, 29 Oct 2020 23:49:10 +0000 (UTC) (envelope-from jhs@berklix.com) Received: from mart.js.berklix.net (p4fc4cc8e.dip0.t-ipconnect.de [79.196.204.142]) (authenticated bits=128) by slim.berklix.org (8.15.2/8.15.2) with ESMTPSA id 09TNmsHe039576 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 30 Oct 2020 00:48:59 +0100 (CET) (envelope-from jhs@berklix.com) Received: from fire.js.berklix.net (fire.js.berklix.net [192.168.91.41]) by mart.js.berklix.net (8.14.3/8.14.3) with ESMTP id 09TNmsBJ002322; Fri, 30 Oct 2020 00:48:54 +0100 (CET) (envelope-from jhs@berklix.com) Received: from fire.js.berklix.net (localhost [127.0.0.1]) by fire.js.berklix.net (8.14.7/8.14.7) with ESMTP id 09TNmXiX022948; Fri, 30 Oct 2020 00:48:43 +0100 (CET) (envelope-from jhs@berklix.com) Message-Id: <202010292348.09TNmXiX022948@fire.js.berklix.net> To: freebsd-stable cc: Diane Bruce , Stefan Esser , Greg Balfour Subject: Re: calendar (1) - patch to correct error description From: "Julian H. Stacey" Organization: http://berklix.com/jhs/ User-agent: EXMH on FreeBSD http://berklix.com/free/ X-From: http://www.berklix.org/~jhs/ In-reply-to: Your message "Thu, 29 Oct 2020 08:07:02 -0400." <20201029120702.GA44939@night.db.net> Date: Fri, 30 Oct 2020 00:48:33 +0100 X-Rspamd-Queue-Id: 4CMhx24w9mz4VSv X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of jhs@berklix.com has no SPF policy when checking 94.185.90.68) smtp.mailfrom=jhs@berklix.com X-Spamd-Result: default: False [0.92 / 15.00]; RCVD_TLS_LAST(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FREEFALL_USER(0.00)[jhs]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; ARC_NA(0.00)[]; NEURAL_HAM_LONG(-0.18)[-0.176]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[berklix.com]; AUTH_NA(1.00)[]; NEURAL_SPAM_SHORT(0.71)[0.712]; HAS_ORG_HEADER(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; NEURAL_HAM_MEDIUM(-0.52)[-0.520]; R_SPF_NA(0.00)[no SPF record]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:33824, ipnet:94.185.88.0/22, country:DE]; FREEMAIL_CC(0.00)[db.net,freebsd.org,gmail.com]; MAILMAN_DEST(0.00)[freebsd-stable]; RECEIVED_SPAMHAUS_PBL(0.00)[79.196.204.142:received] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Oct 2020 23:49:11 -0000 Here's another 2 calendar errors, presumably cpp, that manifest in 12.2-STABLE, that 9.2-RELEASE gets right. Man calendar: Empty lines and lines protected by the C commenting syntax (/* ... */) are ignored. --- Input ~/.calendar/calendar friday fish /* * Oct 21 AAA */ friday and chips ---12.2-STABLE output Oct 30* and chips Oct 30 AAA Oct 30* fish Oct 31 AAA ---9.2-RELEASE output Oct 30* and chips Oct 30* fish --- Error 1: Why does it emit AAA ? Error 2: Why twice ? Puzzle: Doesnt happen if you change Oct above to Aug inside the comment. (PS both do a nasty stack unstack, which may look familiar to us programmers, but looks silly to normal peopler, inverting fish & chips) Cheers, -- Julian Stacey, Consultant Sys. Eng. BSD Linux Unix, http://berklix.com/jhs/cv/ Crash Brexit profits financial speculators in cabinet damaging Britain. UK stole 3.7 million votes from Brits abroad 700 K in EU http://stolenvotes.uk From owner-freebsd-stable@freebsd.org Thu Oct 29 23:53:19 2020 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D56004419DE for ; Thu, 29 Oct 2020 23:53:19 +0000 (UTC) (envelope-from SRS0=P71V=EE=mail.sermon-archive.info=doug@sermon-archive.info) Received: from mail.sermon-archive.info (sermon-archive.info [71.177.216.148]) by mx1.freebsd.org (Postfix) with ESMTP id 4CMj1q1CvDz4WHb for ; Thu, 29 Oct 2020 23:53:19 +0000 (UTC) (envelope-from SRS0=P71V=EE=mail.sermon-archive.info=doug@sermon-archive.info) Received: from [10.0.1.251] (mini [10.0.1.251]) by mail.sermon-archive.info (Postfix) with ESMTPSA id 4CMj1p3yDPz2fjTt for ; Thu, 29 Oct 2020 16:53:18 -0700 (PDT) From: Doug Hardie Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\)) Subject: 12.1 and 12.2 UPDATING files Message-Id: Date: Thu, 29 Oct 2020 16:53:18 -0700 To: List Mailing FreeBSD-STABLE X-Mailer: Apple Mail (2.3445.104.17) X-Virus-Scanned: clamav-milter 0.101.4 at mail X-Virus-Status: Clean X-Rspamd-Queue-Id: 4CMj1q1CvDz4WHb X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of SRS0=P71V=EE=mail.sermon-archive.info=doug@sermon-archive.info designates 71.177.216.148 as permitted sender) smtp.mailfrom=SRS0=P71V=EE=mail.sermon-archive.info=doug@sermon-archive.info X-Spamd-Result: default: False [-1.31 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-0.92)[-0.925]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:71.177.216.148:c]; MV_CASE(0.50)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-stable@freebsd.org]; DMARC_NA(0.00)[lafn.org: no valid DMARC record]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-0.98)[-0.978]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-0.01)[-0.007]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FORGED_SENDER(0.30)[bc979@lafn.org,SRS0=P71V=EE=mail.sermon-archive.info=doug@sermon-archive.info]; RCVD_NO_TLS_LAST(0.10)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:5650, ipnet:71.177.216.0/23, country:US]; FROM_NEQ_ENVFROM(0.00)[bc979@lafn.org,SRS0=P71V=EE=mail.sermon-archive.info=doug@sermon-archive.info]; MAILMAN_DEST(0.00)[freebsd-stable]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Oct 2020 23:53:19 -0000 There is something unusual about these files. The 12.1 version shows an = entry for the 12.1-RELEASE. It does not exist in the 12.2 version even = though entries go back for a number of years before that. The 12.2 version has the entry for 20190913 appearing ahead of the entry = for 20190914. One would think that since the 12.1-RELEASE is dated = 20191104 that it would also appear in the 12.1 version, but it is not = there. The 12.2 version has a release date of 20201027 and there are a number = of entries with dates very close to that. However, in the 12.1 version, = the release date is 20191104 and the latest update is dated 20190914. = That is almost a 2 month gap. Seems a bit unusual. -- Doug From owner-freebsd-stable@freebsd.org Fri Oct 30 18:33:42 2020 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 646A6458A14 for ; Fri, 30 Oct 2020 18:33:42 +0000 (UTC) (envelope-from se@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CN9tZ20YWz4LSf; Fri, 30 Oct 2020 18:33:42 +0000 (UTC) (envelope-from se@freebsd.org) Received: from Stefans-MBP-WLAN.fritz.box (p200300cd5f0bbc00a80cbc70bf701be1.dip0.t-ipconnect.de [IPv6:2003:cd:5f0b:bc00:a80c:bc70:bf70:1be1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: se/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 812D4105C3; Fri, 30 Oct 2020 18:33:41 +0000 (UTC) (envelope-from se@freebsd.org) To: "Julian H. Stacey" Cc: Diane Bruce , Greg Balfour , freebsd-stable References: <202010292348.09TNmXiX022948@fire.js.berklix.net> From: Stefan Esser Subject: Re: calendar (1) - patch to correct error description Message-ID: <60d7c6ac-7e03-2daa-fd1d-000be6b5ace8@freebsd.org> Date: Fri, 30 Oct 2020 19:33:39 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <202010292348.09TNmXiX022948@fire.js.berklix.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="WVdDpY4grSrrJXNrG23bRSJlyUO5qdgqR" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Oct 2020 18:33:42 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --WVdDpY4grSrrJXNrG23bRSJlyUO5qdgqR Content-Type: multipart/mixed; boundary="qUcUdhluoUuOUzwl1B5NyIRbmxbbTXM1S"; protected-headers="v1" From: Stefan Esser To: "Julian H. Stacey" Cc: Diane Bruce , Greg Balfour , freebsd-stable Message-ID: <60d7c6ac-7e03-2daa-fd1d-000be6b5ace8@freebsd.org> Subject: Re: calendar (1) - patch to correct error description References: <202010292348.09TNmXiX022948@fire.js.berklix.net> In-Reply-To: <202010292348.09TNmXiX022948@fire.js.berklix.net> --qUcUdhluoUuOUzwl1B5NyIRbmxbbTXM1S Content-Type: multipart/mixed; boundary="------------952E8770B933A1E93F81BF29" Content-Language: en-US This is a multi-part message in MIME format. --------------952E8770B933A1E93F81BF29 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: quoted-printable Am 30.10.20 um 00:48 schrieb Julian H. Stacey: > Here's another 2 calendar errors, presumably cpp, that manifest in 12.2= -STABLE, > that 9.2-RELEASE gets right. >=20 > Man calendar: > Empty lines and lines protected by the C commenting syntax > (/* ... */) are ignored. >=20 > --- Input ~/.calendar/calendar > friday fish > /* > * Oct 21 AAA > */ > friday and chips > ---12.2-STABLE output > Oct 30* and chips > Oct 30 AAA > Oct 30* fish > Oct 31 AAA > ---9.2-RELEASE output > Oct 30* and chips > Oct 30* fish > --- >=20 > Error 1: Why does it emit AAA ? The version you used does only support /* ... */ on a single line. The "*" in front of "Oct" seems to have been parsed as a wild-card, but I have not checked why it lead to be interpreted as "Oct 30". This is fixed with the comment processing that I have added to the internal pre-processor. > Error 2: Why twice ? No idea and I do not consider this relevant now that the issue is fixed. > Puzzle: Doesnt happen if you change Oct above to Aug inside the commen= t. Feel free to solve this puzzle, I really do not have the time to waste on this question ;-) > (PS both do a nasty stack unstack, which may look familiar to us > programmers, but looks silly to normal peopler, inverting fish & chips)= Yes, a linked list that got built-up be putting the new element at the head and the previously added values into the "next" field of that element. Please check the calendar version in -CURRENT or the deskutil/calendar port version 0.6. Both issues should be fixed there. Regards, STefan --------------952E8770B933A1E93F81BF29-- --qUcUdhluoUuOUzwl1B5NyIRbmxbbTXM1S-- --WVdDpY4grSrrJXNrG23bRSJlyUO5qdgqR Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEo3HqZZwL7MgrcVMTR+u171r99UQFAl+cXIMFAwAAAAAACgkQR+u171r99USi AwgAnfGQy4FDglTewJx5ow0gndPtV01j53dMgYTCtTZub897tYP+zrYxFVgsuLRy6rakLukF52IE 7ddEiR6BZpNu6PzKNp3W40V8OWzOtb6DNbEpWiHlZa2U3dMDb2AAcxjAeuBf/2uhclesAgVA9kE9 sGZZsHPPPjYYe0pwxOb1TgZmX2WzuM/cBLsdPmGbhUBwB8MHywTz1K4Eqf+cXkXwieBOlpru7qRd 7uuDKjXQOwxcPX5p10nNKyXTTLm98HYLkmIVm2rnd9/zxs8Xexcgrrmp5kEXdBYO4gzySIOD+jdn IEJZM7ApE1SUrjzO5NRYn57IS5ls7bTwZvyTnKFOPg== =TEtC -----END PGP SIGNATURE----- --WVdDpY4grSrrJXNrG23bRSJlyUO5qdgqR-- From owner-freebsd-stable@freebsd.org Sat Oct 31 16:24:57 2020 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C231E450546 for ; Sat, 31 Oct 2020 16:24:57 +0000 (UTC) (envelope-from se@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CNkzY4h6Dz4dtt; Sat, 31 Oct 2020 16:24:57 +0000 (UTC) (envelope-from se@freebsd.org) Received: from Stefans-MBP-WLAN.fritz.box (p200300cd5f0bbc00041f9800b152abd1.dip0.t-ipconnect.de [IPv6:2003:cd:5f0b:bc00:41f:9800:b152:abd1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: se/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id E35651A8DD; Sat, 31 Oct 2020 16:24:56 +0000 (UTC) (envelope-from se@freebsd.org) From: Stefan Esser To: "Julian H. Stacey" , Diane Bruce , Greg Balfour Cc: freebsd-stable References: <202010292348.09TNmXiX022948@fire.js.berklix.net> <60d7c6ac-7e03-2daa-fd1d-000be6b5ace8@freebsd.org> Subject: Re: calendar (1) - patch to correct error description Message-ID: Date: Sat, 31 Oct 2020 17:24:55 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <60d7c6ac-7e03-2daa-fd1d-000be6b5ace8@freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rHa6VkXXr7UOpQW9N3wXn2mkQiA1K64Hx" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Oct 2020 16:24:57 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --rHa6VkXXr7UOpQW9N3wXn2mkQiA1K64Hx Content-Type: multipart/mixed; boundary="7OjJ7rxevj9EBrnDJsRLJ33hBb8uvPXkY"; protected-headers="v1" From: Stefan Esser To: "Julian H. Stacey" , Diane Bruce , Greg Balfour Cc: freebsd-stable Message-ID: Subject: Re: calendar (1) - patch to correct error description References: <202010292348.09TNmXiX022948@fire.js.berklix.net> <60d7c6ac-7e03-2daa-fd1d-000be6b5ace8@freebsd.org> In-Reply-To: <60d7c6ac-7e03-2daa-fd1d-000be6b5ace8@freebsd.org> --7OjJ7rxevj9EBrnDJsRLJ33hBb8uvPXkY Content-Type: multipart/mixed; boundary="------------7B34A8B0DDDA3676A9CA051A" Content-Language: en-US This is a multi-part message in MIME format. --------------7B34A8B0DDDA3676A9CA051A Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: quoted-printable JFYI: port version 0.7 or the latest sources in CURRENT include a number of further enhancements (and an important fix to allow the calendar to be build on 11.x/12.x which do not have _PATH_LOCALBASE in paths.h). I have added an #undef command (since it was supported by the calendar program that used cpp and since it occurs in one of calendar files that have traditionally been included in FreeBSD) and checks for the correct use of #else and #endif. Warnings and error messages caused by malformed input files are now reported with filename and line number. The man-page and tests have not been updated to reflect this latest set of changes, I'll hope to be able to update them in the next few days. Please let me know if there are any issues with these changes, since I want to merge them to 11-STABLE and 12-STABLE sometime next week. Regards, STefan --------------7B34A8B0DDDA3676A9CA051A-- --7OjJ7rxevj9EBrnDJsRLJ33hBb8uvPXkY-- --rHa6VkXXr7UOpQW9N3wXn2mkQiA1K64Hx Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEo3HqZZwL7MgrcVMTR+u171r99UQFAl+dj9cFAwAAAAAACgkQR+u171r99UTZ tQf/fKOAxPY6CU14L/tLL1/RpjNq3aXXFSUjkQa43dDXrqmPfHWpS62IWddfb1RhUAQjecNEpMHS 1ngHc203hGCnP4svQUw3dOniWmUQLm3pFS/jbd52Bk8+tzxPLOt9lyGgzF2sT1CYGKTQ3qyryVzG jPq2RR+eKg4N0DUKGJDs0wywO7/me0U4APRyuWObsHjlki2b5SW+nYfz1NPy/0RP6ArhaQ3JY6IY NjVdGHrrRWe8C4t09931V7L/LUu8lnrwYtOESV+BIBDXKZR9U4xRTiZ3RhZODk4kBJVMxDeISDwe NG8mzEVblyfAXGNWPcUxcoztJIjztQtbCehuLXNUZg== =N1Cx -----END PGP SIGNATURE----- --rHa6VkXXr7UOpQW9N3wXn2mkQiA1K64Hx--