From owner-freebsd-net@FreeBSD.ORG Mon Aug 29 06:40:49 2005 Return-Path: X-Original-To: freebsd-net@FreeBSD.org Delivered-To: freebsd-net@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EE2F716A41F for ; Mon, 29 Aug 2005 06:40:49 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 35E3943D45 for ; Mon, 29 Aug 2005 06:40:48 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.13.3/8.13.3) with ESMTP id j7T6efhs054732 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 29 Aug 2005 10:40:41 +0400 (MSD) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.sick.ru (8.13.3/8.13.1/Submit) id j7T6ee5I054731; Mon, 29 Aug 2005 10:40:40 +0400 (MSD) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Mon, 29 Aug 2005 10:40:40 +0400 From: Gleb Smirnoff To: "Daniel O'Connor" Message-ID: <20050829064040.GB48425@cell.sick.ru> Mail-Followup-To: Gleb Smirnoff , Daniel O'Connor , Julian Elischer , Chuck Swiger , freebsd-net@freebsd.org References: <200507290834.10268.doconnor@gsoft.com.au> <42EBD738.2010105@elischer.org> <200507312253.29038.doconnor@gsoft.com.au> <200508291449.15427.doconnor@gsoft.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <200508291449.15427.doconnor@gsoft.com.au> User-Agent: Mutt/1.5.6i Cc: freebsd-net@FreeBSD.org, Julian Elischer Subject: Re: AltQ + ng_iface X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Aug 2005 06:40:50 -0000 On Mon, Aug 29, 2005 at 02:49:14PM +0930, Daniel O'Connor wrote: D> On Sunday 31 July 2005 22:53, Daniel O'Connor wrote: D> > > The calling code must always have a reference on the node to ensure that D> > > it is not removed while it is running in it. This is sometimes D> > > done automatically. This is why there is an ng_callout facility to ensure D> > > that the locking andreferences are done automatically and correctly. D> > D> > OK, I'll look into that. D> D> I see ng_eiface uses ng_send_fn to defer processing until netgraph locking D> allows - should I use it? D> (I'll try it later but a definitive answer would be nice :) If you have put smth into ng_iface_start(), then you should do this stuff via ng_send_fn(). Sorry, that I haven't yet feedbacked on your patches. I'll probably look at them after 6.0-RELEASE. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE