From owner-freebsd-ports@FreeBSD.ORG Fri May 5 13:57:42 2006 Return-Path: X-Original-To: ports@freebsd.org Delivered-To: freebsd-ports@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 628F116A402; Fri, 5 May 2006 13:57:42 +0000 (UTC) (envelope-from itetcu@people.tecnik93.com) Received: from garek.tecnik93.com (garek.tecnik93.com [82.76.1.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id CFE5343D45; Fri, 5 May 2006 13:57:41 +0000 (GMT) (envelope-from itetcu@people.tecnik93.com) Received: from garek.tecnik93.com (localhost [127.0.0.1]) by garek.tecnik93.com (Postfix) with ESMTP id 32A8660BA; Fri, 5 May 2006 16:57:40 +0300 (EEST) Received: from it.buh.cameradicommercio.ro (it.buh.cameradicommercio.ro [192.168.0.10]) by garek.tecnik93.com (Postfix) with ESMTP; Fri, 5 May 2006 16:57:39 +0300 (EEST) Received: from it.buh.cameradicommercio.ro (localhost.buh.tecnik93.com [127.0.0.1]) by it.buh.cameradicommercio.ro (Postfix) with ESMTP id 6A89F8B; Fri, 5 May 2006 16:57:39 +0300 (EEST) Date: Fri, 5 May 2006 16:57:38 +0300 From: Ion-Mihai Tetcu To: "Andrew Pantyukhin" Message-ID: <20060505165738.1965f74f@it.buh.cameradicommercio.ro> In-Reply-To: References: <127FEBDA-4446-47DB-B6CA-4AB6A5CE8562@FreeBSD.org> <20060428003008.19f61dbc@it.buh.tecnik93.com> X-Mailer: Sylpheed-Claws 2.1.1 (GTK+ 2.8.17; i386-portbld-freebsd6.1) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-AV-Checked: on buh by ClamAV using ClamSMTP Cc: FreeBSD Ports , Sam Lawrance Subject: Re: sourceforge subdir default X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 May 2006 13:57:42 -0000 On Fri, 5 May 2006 17:50:37 +0400 "Andrew Pantyukhin" wrote: > On 4/28/06, Ion-Mihai Tetcu wrote: > > On Thu, 27 Apr 2006 19:27:38 +0400 > > "Andrew Pantyukhin" wrote: > > > Okay, I wonder if we can set M_S_SUBDIR to PORTNAME > > > by default no matter what MASTER_SITES we have. I mean > > > if there's a %SUBDIR% to replace, PORTNAME seems to be > > > a reasonable default value, doesn't it? > > > > I've been thinking about the same thing for some time. > > > > Care to provide: > > a) patch for b.p.m > > b) patch for affected ports where this is true > > ( c) the rest of M_S_SF ports should work w/o modifications ) ? > > > > I'll do a test for all the affected ports. > > % find /usr/ports -iname Makefile\* -exec egrep -H > '^MASTER_SITE_SUBDIR=[[:space:]]*\$\{PORTNAME\}$' {} + | wc -l > 1357 > > So I think I won't provide a patch for the ports, we'll do patching > step-by-step later (in the manner of USE_REINPLACE deprecation) > > Attached is a very simple diff. Even without any testing, I don't see > how it can break anything at all. I'll submit a pr some time later. I'll run a (partial) test tonight or tomorrow; first step would be to find for how many ports this default is true and if we shouldn't rather set a default for each MASTER_SITE_* -- IOnut Unregistered ;) FreeBSD "user"