From owner-freebsd-current  Mon Jan 13 13:07:10 1997
Return-Path: <owner-current>
Received: (from root@localhost)
          by freefall.freebsd.org (8.8.4/8.8.4) id NAA05352
          for current-outgoing; Mon, 13 Jan 1997 13:07:10 -0800 (PST)
Received: from news.IAEhv.nl (root@news.IAEhv.nl [194.151.64.4])
          by freefall.freebsd.org (8.8.4/8.8.4) with SMTP id NAA05344
          for <freebsd-current@freebsd.org>; Mon, 13 Jan 1997 13:07:04 -0800 (PST)
Received: from LOCAL (uucp@localhost) 
          by news.IAEhv.nl (8.6.13/1.63) with IAEhv.nl; pid 5699
          on Mon, 13 Jan 1997 21:57:01 +0100; id VAA05699
          efrom: devet@adv.IAEhv.nl; eto: UNKNOWN
Received: by adv.IAEhv.nl (8.7.5/1.63)
    id VAA09476; Mon, 13 Jan 1997 21:56:17 +0100 (MET)
Date: Mon, 13 Jan 1997 21:56:17 +0100 (MET)
From: Arjan.deVet@adv.IAEhv.nl (Arjan de Vet)
Message-Id: <199701132056.VAA09476@adv.IAEhv.nl>
To: imp@village.org
Subject: Re: ppp changes for buffer overflows going in
X-Newsgroups: list.freebsd.current
In-Reply-To: <E0vibeK-00075I-00@rover.village.org>
Organization: Internet Access Eindhoven, The Netherlands
Cc: freebsd-current@freebsd.org
Sender: owner-current@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

In article <E0vibeK-00075I-00@rover.village.org> you write:

>However, I am unable to test ppp to my level of satisfaction easily,
>since I don't have a ppp link to test it with.  I think these changes
>will be good, but thought I'd give a heads up.

In command.c the size of VarDialScript is being used for VarLoginScript:

diff -u -w -r1.28 command.c
--- command.c	1997/01/10 07:53:23	1.28
+++ command.c	1997/01/12 16:35:15
@@ -933,7 +934,7 @@
       VarDialScript[sizeof(VarDialScript)-1] = '\0';
       break;
     case VAR_LOGIN:
-      strncpy(VarLoginScript, *argv, sizeof(VarDialScript)-1);
+      strncpy(VarLoginScript, *argv, sizeof(VarLoginScript)-1);
       VarLoginScript[sizeof(VarLoginScript)-1] = '\0';
       break;
     case VAR_DEVICE:

>They are 2.2 candidates, but I'd like to have them be tested in
>-current for as long as possible before committing to the 2.2 branch.

Everything seems to be working fine. In my own copy I have enlarged the
buffersizes for chat scripts because I have a chat script dealing with
SecurId cards and dialback and that takes more than the default 200
characters and maximum 20 expect/send pairs.

Arjan