From owner-svn-src-head@FreeBSD.ORG  Fri Dec  6 15:28:04 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id F02F2767;
 Fri,  6 Dec 2013 15:28:04 +0000 (UTC)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id C76F016CD;
 Fri,  6 Dec 2013 15:28:04 +0000 (UTC)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id B62E1B93B;
 Fri,  6 Dec 2013 10:28:03 -0500 (EST)
From: John Baldwin <jhb@freebsd.org>
To: Kevin Lo <kevlo@freebsd.org>
Subject: Re: svn commit: r259031 - head/sys/dev/usb/wlan
Date: Fri, 6 Dec 2013 10:27:09 -0500
User-Agent: KMail/1.13.5 (FreeBSD/8.4-CBSD-20130906; KDE/4.5.5; amd64; ; )
References: <201312061517.rB6FHTOa007535@svn.freebsd.org>
In-Reply-To: <201312061517.rB6FHTOa007535@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201312061027.09144.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Fri, 06 Dec 2013 10:28:03 -0500 (EST)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Dec 2013 15:28:05 -0000

On Friday, December 06, 2013 10:17:29 am Kevin Lo wrote:
> Author: kevlo
> Date: Fri Dec  6 15:17:28 2013
> New Revision: 259031
> URL: http://svnweb.freebsd.org/changeset/base/259031
> 
> Log:
>   Replace the magic numbers with something more readable.
> 
> Modified:
>   head/sys/dev/usb/wlan/if_run.c
>   head/sys/dev/usb/wlan/if_runreg.h
> 
> Modified: head/sys/dev/usb/wlan/if_run.c
> 
==============================================================================
> --- head/sys/dev/usb/wlan/if_run.c	Fri Dec  6 15:15:58 2013	(r259030)
> +++ head/sys/dev/usb/wlan/if_run.c	Fri Dec  6 15:17:28 2013	(r259031)
> @@ -4530,7 +4530,7 @@ run_rt5390_bbp_init(struct run_softc *sc
>  
>  	/* Avoid data lost and CRC error. */
>  	run_bbp_read(sc, 4, &bbp4);
> -	run_bbp_write(sc, 4, bbp4 | 0x40);
> +	run_bbp_write(sc, 4, bbp | RT5390_MAC_IF_CTRL);

The s/bbp4/bbp/ here looks like a bug?

-- 
John Baldwin