Date: Thu, 01 May 2003 09:39:31 +0200 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: Mike Barcroft <mike@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/i386 identcpu.c Message-ID: <771.1051774771@critter.freebsd.dk> In-Reply-To: Your message of "Wed, 30 Apr 2003 18:43:51 EDT." <20030430184351.B31859@espresso.bsdmike.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20030430184351.B31859@espresso.bsdmike.org>, Mike Barcroft writes: >Mark Murray <markm@FreeBSD.org> writes: >> markm 2003/04/30 05:23:58 PDT >> >> FreeBSD src repository >> >> Modified files: >> sys/i386/i386 identcpu.c >> Log: >> Warns fixing. Protect against inappropriate linting, and mark >> GCC-specific assemble code as such (in #ifdefs). Fix an easy >> static variable warning while I'm here. >> >> Revision Changes Path >> 1.122 +8 -1 src/sys/i386/i386/identcpu.c > >Is it really useful to #ifdef critical sections of code. This thing >isn't going to compile without asm extentions from the compiler. So >really you just turn compile errors into link error. Not very helpful >IMO. Yes, it is useful, because it allows us to run code validation tools on our source code. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?771.1051774771>