Date: Mon, 29 Sep 2003 13:56:32 -0700 (PDT) From: Robert Watson <rwatson@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 38799 for review Message-ID: <200309292056.h8TKuWKl004026@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=38799 Change 38799 by rwatson@rwatson_tislabs on 2003/09/29 13:55:36 Make sure to unlock the pipe mutex when a MAC check fails on an ioctl, or we might return to userspace still holding the pipe mutex. Tripped over by: areisse Affected files ... .. //depot/projects/trustedbsd/mac/sys/kern/sys_pipe.c#42 edit Differences ... ==== //depot/projects/trustedbsd/mac/sys/kern/sys_pipe.c#42 (text+ko) ==== @@ -1233,8 +1233,10 @@ #ifdef MAC error = mac_check_pipe_ioctl(active_cred, mpipe, cmd, data); - if (error) + if (error) { + PIPE_UNLOCK(mpipe); return (error); + } #endif switch (cmd) {
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200309292056.h8TKuWKl004026>