From owner-cvs-all Mon Oct 26 00:16:03 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id AAA15865 for cvs-all-outgoing; Mon, 26 Oct 1998 00:16:03 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from labinfo.iet.unipi.it (labinfo.iet.unipi.it [131.114.9.5]) by hub.freebsd.org (8.8.8/8.8.8) with SMTP id AAA15710; Mon, 26 Oct 1998 00:13:58 -0800 (PST) (envelope-from luigi@labinfo.iet.unipi.it) Received: from localhost (luigi@localhost) by labinfo.iet.unipi.it (8.6.5/8.6.5) id HAA01467; Mon, 26 Oct 1998 07:08:31 +0100 From: Luigi Rizzo Message-Id: <199810260608.HAA01467@labinfo.iet.unipi.it> Subject: Re: cvs commit: src/sys/i386/isa if_ed.c To: dg@root.com Date: Mon, 26 Oct 1998 07:08:31 +0100 (MET) Cc: luigi@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG In-Reply-To: <199810260615.WAA25974@implode.root.com> from "David Greenman" at Oct 25, 98 10:15:01 pm X-Mailer: ELM [version 2.4 PL23] Content-Type: text Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk > > >luigi 1998/10/25 03:25:59 PST > > > > Modified files: (Branch: RELENG_2_2) > > sys/i386/isa if_ed.c > > Log: > > Fix two problems which can occur with poor cabling: > > 1) the routine to compute length for non-std packets (too short > > or too long) was off by 256 in almost all cases. > > 2) fixing the above triggered a bug in the bridging code causing > > ed_ring_copy to be called with a negative length -> panic. > > It is unlikely that you see the problem unless you use promisc mode, > > bridging and poor cabling. > > This should not have been committed to the 2.2 branch first. It's a bugfix, not a feature, and the bug is very specific to 2.2 because there is no bridging yet in 3.0, thus i doubt the problem can occur. So i figured out it was more urgent to fix 2.2 as soon as i can get my 3.0 machine up i will patch that as well. cheers luigi -----------------------------+-------------------------------------- Luigi Rizzo | Dip. di Ingegneria dell'Informazione email: luigi@iet.unipi.it | Universita' di Pisa tel: +39-50-568533 | via Diotisalvi 2, 56126 PISA (Italy) fax: +39-50-568522 | http://www.iet.unipi.it/~luigi/ _____________________________|______________________________________ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message