From owner-freebsd-toolchain@FreeBSD.ORG  Thu Nov 10 20:47:22 2011
Return-Path: <owner-freebsd-toolchain@FreeBSD.ORG>
Delivered-To: freebsd-toolchain@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1233)
	id C79CD106566C; Thu, 10 Nov 2011 20:47:22 +0000 (UTC)
Date: Thu, 10 Nov 2011 20:47:22 +0000
From: Alexander Best <arundel@freebsd.org>
To: freebsd-toolchain@freebsd.org
Message-ID: <20111110204722.GA85046@freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Subject: format string is not a string literal (potentially insecure)
	[-Wformat-security]
X-BeenThere: freebsd-toolchain@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Maintenance of FreeBSD's integrated toolchain
	<freebsd-toolchain.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain>, 
	<mailto:freebsd-toolchain-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-toolchain>
List-Post: <mailto:freebsd-toolchain@freebsd.org>
List-Help: <mailto:freebsd-toolchain-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain>, 
	<mailto:freebsd-toolchain-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Nov 2011 20:47:22 -0000

hi there,

clang outputs the following warning during 'make buildkernel':

clang -c -O3 -pipe -fno-inline-functions -fno-strict-aliasing -march=core2 -std=c99  -fdiagnostics-show-option -fformat-extensions -Wall  -Wcast-qual -Winline -Wmissing-include-dirs  -Wmissing-prototypes -Wnested-externs -Wpointer-arith  -Wredundant-decls -Wstrict-prototypes -Wundef  -Wno-pointer-sign -nostdinc  -I. -I/usr/git-freebsd-head/sys -I/usr/git-freebsd-head/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h  -mno-aes -mno-avx -mcmodel=kernel -mno-red-zone -mno-mmx -msoft-float  -fno-asynchronous-unwind-tables -ffreestanding -fstack-protector-all   /usr/git-freebsd-head/sys/kern/kern_conf.c
/usr/git-freebsd-head/sys/kern/kern_conf.c:1019:45: warning: format string is not a string literal (potentially insecure) [-Wformat-security]
                ret = make_dev_alias_p(flags, cdev, pdev, devfspath);
                                                          ^~~~~~~~~

does this indicate a security risk, which should be fixed or rather a bugus
warning?

cheers.
alex