From owner-freebsd-current@FreeBSD.ORG  Sun Apr 27 18:16:35 2008
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E57681065675
	for <freebsd-current@freebsd.org>; Sun, 27 Apr 2008 18:16:35 +0000 (UTC)
	(envelope-from sam@freebsd.org)
Received: from ebb.errno.com (ebb.errno.com [69.12.149.25])
	by mx1.freebsd.org (Postfix) with ESMTP id B19E68FC13
	for <freebsd-current@freebsd.org>; Sun, 27 Apr 2008 18:16:35 +0000 (UTC)
	(envelope-from sam@freebsd.org)
Received: from trouble.errno.com (trouble.errno.com [10.0.0.248])
	(authenticated bits=0)
	by ebb.errno.com (8.13.6/8.12.6) with ESMTP id m3RIGY9p028593
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Sun, 27 Apr 2008 11:16:35 -0700 (PDT) (envelope-from sam@freebsd.org)
Message-ID: <4814C302.7080705@freebsd.org>
Date: Sun, 27 Apr 2008 11:16:34 -0700
From: Sam Leffler <sam@freebsd.org>
Organization: FreeBSD Project
User-Agent: Thunderbird 2.0.0.9 (X11/20071125)
MIME-Version: 1.0
To: Scot Hetzel <swhetzel@gmail.com>
References: <20080427.220905.113455362.haro@kgt.co.jp>
	<790a9fff0804270857n643c6ed9p3954abec41c12516@mail.gmail.com>
In-Reply-To: <790a9fff0804270857n643c6ed9p3954abec41c12516@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-DCC-sonic.net-Metrics: ebb.errno.com; whitelist
Cc: freebsd-current@freebsd.org, haro@kgt.co.jp
Subject: Re: iwi0 "need multicast update callback"
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 27 Apr 2008 18:16:36 -0000

Scot Hetzel wrote:
> On Sun, Apr 27, 2008 at 8:09 AM,  <haro@kgt.co.jp> wrote:
>   
>> Hi list,
>>
>> After updating my pc today, I'm getting following message on the console.
>> As it seems to be working ok, but is there any way to get rid of it?
>>
>>   iwi0: need multicast update callback
>>
>>     
> I noticed this with the ndis driver also. I searched the code and
> found that this is coming from the null_update_mcast function in
> /sys/net80211/ieee802.c
>
> To get rid of this notification will require updating the iwi and ndis
> drivers to seperate multicast update and promisc update into seperate
> functions:
>
> ic->ic_update_mcast = null_update_mcast;
> ic->ic_update_promisc = null_update_promisc;
> :
> /*
>  * Synchronize flag bit state in the parent ifnet structure
>  * according to the state of all vap ifnet's.  This is used,
>  * for example, to handle IFF_PROMISC and IFF_ALLMULTI.
>  */
> void
> ieee80211_syncifflag_locked(struct ieee80211com *ic, int flag)
>
> This is to allow  the ieee80211_syncifflag_locked function to update
> the parent ifnet structure.
>
> Search the other wireless drivers (i.e ath) on how the conversion was made.
>
>   
These messages are a reminder to fill in missing functionality and can 
be somewhat ignored.  It may be possible to have the default mcast 
filter handler mark the ALLMULTI flag and fallback to the 802.3 layer 
for multicast filtering but I wasn't convinced that worked right so left 
the printf reminder.

Of course the right solution is to push the mcast address list to the 
device.

    Sam