Date: Sun, 03 Feb 2002 22:39:22 +0000 From: Mark Murray <mark@grondar.za> To: Dag-Erling Smorgrav <des@ofug.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libpam/modules/pam_lastlog pam_lastlog.c src/lib/libpam/modules/pam_login_access login_access.c pam_login_access.c pam_login_access.h src/lib/libpam/modules/pam_securetty pam_securetty.c src/lib/libpam/modules/pam_unix pam_unix.c Message-ID: <200202032239.g13MdRE72311@greenpeace.grondar.org> In-Reply-To: <xzpr8o2p6n4.fsf@flood.ping.uio.no> ; from Dag-Erling Smorgrav <des@ofug.org> "03 Feb 2002 23:01:03 %2B0100." References: <xzpr8o2p6n4.fsf@flood.ping.uio.no>
next in thread | previous in thread | raw e-mail | index | archive | help
> Mark Murray <markm@FreeBSD.org> writes: > > markm 2002/02/03 07:17:57 PST > > > > Modified files: > > lib/libpam/modules/pam_lastlog pam_lastlog.c > > lib/libpam/modules/pam_login_access login_access.c > > pam_login_access.c > > lib/libpam/modules/pam_securetty pam_securetty.c > > lib/libpam/modules/pam_unix pam_unix.c > > Added files: > > lib/libpam/modules/pam_login_access pam_login_access.h > > Log: > > WARNS=n fixes (and some stylistic issues). > > You've introduced memory leaks and potential segfaults in pam_unix() > (you added strdup()s in several places but you don't check the return > value and don't free() them later). Drat. I'll fix that. > Other stuff: > > - pam_securetty should use _PATH_DEV instead of TTY_PREFIX Yes. > - some long lines should be split (have to ask bde about that) Just do it. Usual 4-space indent applies. > - commit included non-trivial changes to salt generation which should > have been mentioned in log message (others would say they should > have been committed separately, but I don't mind) Dammit. I did not mean to commit that yet. I'll force a commit anyway to mention it in the logs. M -- o Mark Murray \_ FreeBSD Services Limited O.\_ Warning: this .sig is umop ap!sdn To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200202032239.g13MdRE72311>