From owner-cvs-all Fri Aug 4 7: 8:52 2000 Delivered-To: cvs-all@freebsd.org Received: from ms.tokyo.jcom.ne.jp (ms.tokyo.jcom.ne.jp [210.234.123.18]) by hub.freebsd.org (Postfix) with ESMTP id E9A8B37BB41; Fri, 4 Aug 2000 07:08:46 -0700 (PDT) (envelope-from knu@idaemons.org) Received: from daemon.local.idaemons.org (203-165-77-17.sugnm1.kt.home.ne.jp [203.165.77.17]) by ms.tokyo.jcom.ne.jp (8.9.3/3.7W 04/27/00) with ESMTP id XAA14436; Fri, 4 Aug 2000 23:08:44 +0900 (JST) Received: by daemon.local.idaemons.org (8.9.3/3.7W) id XAA33405; Fri, 4 Aug 2000 23:08:12 +0900 (JST) Date: Fri, 04 Aug 2000 23:08:11 +0900 Message-ID: <86zomtp19w.wl@localhost.local.idaemons.org> From: "Akinori -Aki- MUSHA" To: Ade Lovett Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/devel/dryad Makefile ports/devel/dryad/patches patch-aa patch-ab ports/graphics/eog Makefile ports/graphics/eog/patches patch-aa patch-ab patch-ac ports/editors/gedit Makefile ports/editors/gedit/patches patch-ao ... In-Reply-To: In your message of "Thu, 3 Aug 2000 18:34:41 -0700 (PDT)" <200008040134.SAA73918@freefall.freebsd.org> References: <200008040134.SAA73918@freefall.freebsd.org> User-Agent: Wanderlust/2.3.0 (Roam) EMIKO/1.13.12 (Euglena sociabilis) FLIM/1.13.2 (Kasanui) APEL/10.2 MULE XEmacs/21.1 (patch 11) (Carlsbad Caverns) (i386--freebsd) Organization: Associated I. Daemons X-PGP-Public-Key: finger knu@FreeBSD.org X-PGP-Fingerprint: 1BEF D9B2 BABD 25D7 659A FD08 89C2 F3BE E981 4E16 MIME-Version: 1.0 (generated by EMIKO 1.13.12 - "Euglena sociabilis") Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG At Thu, 3 Aug 2000 18:34:41 -0700 (PDT), aDe wrote: > Extensive patchfile cleanups using sobomax's wonderful > post-extract rule Hmm.. I think you should use pre-patch or post-patch for that purpose. I mean, "extract" stage should only consist of extracting files, removing unnecessary files, and creating or copying necessary files, when patching and editing files belong in "patch" (or "configure") stage. =46rom my point of view, "make extract" should just extract the distributed files as-is, so one can stand at the start point and look around to find out what materials are provided by the vendor(s). I suppose that would help him/her try (another) hacking on it. Maybe something like above should have been clarified in the Porter's Handbook, but at least it says "Do things rationally", which I'd apply to this case. :> -- = / /__ __ = / ) ) ) ) / Akinori -Aki- MUSHA aka / (_ / ( (__( @ idaemons.org / FreeBSD.org "We're only at home when we're on the run, on the wing, on the fly" To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message