From owner-freebsd-net@FreeBSD.ORG Tue Sep 4 13:13:28 2007 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 76E3C16A417 for ; Tue, 4 Sep 2007 13:13:28 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.freebsd.org (Postfix) with ESMTP id AF12D13C45A for ; Tue, 4 Sep 2007 13:13:26 +0000 (UTC) (envelope-from andre@freebsd.org) Received: (qmail 90085 invoked from network); 4 Sep 2007 13:01:10 -0000 Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 4 Sep 2007 13:01:10 -0000 Message-ID: <46DD59F9.1080107@freebsd.org> Date: Tue, 04 Sep 2007 15:13:29 +0200 From: Andre Oppermann User-Agent: Thunderbird 1.5.0.13 (Windows/20070809) MIME-Version: 1.0 To: Rui Paulo References: <46DCB831.3030207@fnop.net> In-Reply-To: <46DCB831.3030207@fnop.net> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-net@freebsd.org Subject: Re: Killing IPTOS_CE and IPTOS_ECT X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Sep 2007 13:13:28 -0000 Rui Paulo wrote: > Hi, > I'm working on TCP ECN support and I would like to kill these defines > from netinet/ip.h > > #if 1 > /* ECN RFC3168 obsoletes RFC2481, and these will be deprecated soon. */ > #define IPTOS_CE 0x01 > #define IPTOS_ECT 0x02 > #endif > > The are outdated and should no longer be used because that RFC has been > obsoleted. RFC 3168 uses a bit different bits: > #define IPTOS_ECN_NOTECT 0x00 /* not-ECT */ > #define IPTOS_ECN_ECT1 0x01 /* ECN-capable transport (1) */ > #define IPTOS_ECN_ECT0 0x02 /* ECN-capable transport (0) */ > #define IPTOS_ECN_CE 0x03 /* congestion experienced */ > #define IPTOS_ECN_MASK 0x03 /* ECN field mask */ > > The only consumer of the RFC 2481 defines is sbin/ipfw/ipfw2.c and > luigi@ accepted the attached patch. > > Does anyone have any objection against the removal ? No. Please produce a complete unified diff patch including both the changes to ip.h and ipfw2.c, a sufficiently verbose commit message, the result a complete make universe build run with the patch applied to otherwise clean sources and send it to re@ and me in CC. If approved I commit it for you. -- Andre