From owner-freebsd-current@FreeBSD.ORG  Wed Jun  6 11:31:20 2007
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id D942116A46C;
	Wed,  6 Jun 2007 11:31:20 +0000 (UTC)
	(envelope-from krassi@bulinfo.net)
Received: from mx.bulinfo.net (mx.bulinfo.net [193.194.156.1])
	by mx1.freebsd.org (Postfix) with ESMTP id 84ADD13C4AE;
	Wed,  6 Jun 2007 11:31:20 +0000 (UTC)
	(envelope-from krassi@bulinfo.net)
Received: from localhost (localhost [127.0.0.1])
	by mx.bulinfo.net (Postfix) with ESMTP id 3AF9735C47;
	Wed,  6 Jun 2007 14:31:10 +0300 (EEST)
Received: from mx.bulinfo.net ([127.0.0.1])
	by localhost (mx.bulinfo.net [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 86594-04; Wed,  6 Jun 2007 14:31:06 +0300 (EEST)
Received: from [192.168.2.188] (pythia.bulinfo.net [212.72.195.5])
	by mx.bulinfo.net (Postfix) with ESMTP id C907535C3F;
	Wed,  6 Jun 2007 14:31:06 +0300 (EEST)
Message-ID: <46669AFA.2060104@bulinfo.net>
Date: Wed, 06 Jun 2007 14:31:06 +0300
From: Krassimir Slavchev <krassi@bulinfo.net>
User-Agent: Thunderbird 2.0.0.0 (X11/20070601)
MIME-Version: 1.0
To: Attilio Rao <attilio@freebsd.org>
References: <46657B33.5010804@bulinfo.net>
	<3bbf2fe10706050815u619bd2e6p728c0d20e2aae802@mail.gmail.com>
In-Reply-To: <3bbf2fe10706050815u619bd2e6p728c0d20e2aae802@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: amavisd-new at mx.bulinfo.net
Cc: freebsd-arm@freebsd.org, freebsd-current@freebsd.org,
	=?UTF-8?B?QmrDtnJuIEvDtm5pZw==?= <bkoenig@alpha-tierchen.de>
Subject: Re: kernel linking
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Jun 2007 11:31:20 -0000

Attilio Rao wrote:
> 2007/6/5, Krassimir Slavchev <krassi@bulinfo.net>:
>> This is with latest -current on arm:
>>
>> linking kernel
>> kern_intr.o(.text+0x15d8): In function `swi_sched':
>> : undefined reference to `PCPU_LAZY_ADD'
>> kern_synch.o(.text+0x210): In function `mi_switch':
>> : undefined reference to `PCPU_LAZY_ADD'
>> kern_thread.o(.text+0x9b4): In function `thread_exit':
>> : undefined reference to `PCPU_LAZY_ADD'
>> subr_trap.o(.text+0x180): In function `ast':
>> : undefined reference to `PCPU_LAZY_ADD'
>> nfs_bio.o(.text+0x11cc): In function `nfs_getpages':
>> : undefined reference to `PCPU_LAZY_ADD'
>> nfs_bio.o(.text+0x1620): more undefined references to `PCPU_LAZY_ADD' 
>> follow
>
> These have been renamed.
> Be sure you update all your src tree, then recompile by scratch your 
> kernel.
>
> Attilio
>
>
OK, but in src/sys/arm/include/pcpu.h we have:

#define     PCPU_INC(member)        PCPU_LAZY_ADD(member, 1)

which should be:

#define PCPU_INC(member)        PCPU_ADD(member, 1)

or as patch:

RCS file: /home/ncvs/src/sys/arm/include/pcpu.h,v
retrieving revision 1.5
diff -r1.5 pcpu.h
61c61
< #define       PCPU_INC(member)        PCPU_LAZY_ADD(member, 1)
---
 > #define       PCPU_INC(member)        PCPU_ADD(member, 1)

-- 
Krassimir Slavchev           Bulinfo Ltd.
krassi@bulinfo.net           (+359 2) 969-9160
http://www.bulinfo.net       (+359 2) 969-9166