From owner-freebsd-current@FreeBSD.ORG  Thu Nov  1 03:19:54 2007
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5F93916A417
	for <current@FreeBSD.org>; Thu,  1 Nov 2007 03:19:54 +0000 (UTC)
	(envelope-from ache@nagual.pp.ru)
Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69])
	by mx1.freebsd.org (Postfix) with ESMTP id D772313C4BC
	for <current@FreeBSD.org>; Thu,  1 Nov 2007 03:19:53 +0000 (UTC)
	(envelope-from ache@nagual.pp.ru)
Received: from nagual.pp.ru (ache@localhost [127.0.0.1])
	by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id lA13JMBi095240;
	Thu, 1 Nov 2007 06:19:22 +0300 (MSK)
	(envelope-from ache@nagual.pp.ru)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nagual.pp.ru;
	s=default; t=1193887162; bh=99R3ZKcVn1+ekH/qwh9i0HS2DrPCsQQLNbBsx/D
	syTM=; l=700; h=Date:From:To:Cc:Subject:Message-ID:Mail-Followup-To:
	References:MIME-Version:Content-Type:Content-Disposition:
	In-Reply-To:User-Agent; b=hCf83xCvIWILJjhU7RIyGlNESg0C/xxFpSXeILsw
	Kw0Oa8UcaSSEsvEPvlO6srAEAgYTFp9RtWYcFePEo5Ft9RkaXuCKJ+8HLp0OQ3ttwA1
	1IVHvoJpfmcA/efOkp7cFKqErdjvJ0UWJpyB3OqIzVLWWdAmiEU0Q1VELM5yOuWE=
Received: (from ache@localhost)
	by nagual.pp.ru (8.14.1/8.14.1/Submit) id lA13JMLh095239;
	Thu, 1 Nov 2007 06:19:22 +0300 (MSK) (envelope-from ache)
Date: Thu, 1 Nov 2007 06:19:22 +0300
From: Andrey Chernov <ache@nagual.pp.ru>
To: David Xu <davidxu@FreeBSD.org>
Message-ID: <20071101031922.GA95201@nagual.pp.ru>
Mail-Followup-To: Andrey Chernov <ache@nagual.pp.ru>,
	David Xu <davidxu@FreeBSD.org>, current@FreeBSD.org
References: <20071101025937.GB94332@nagual.pp.ru>
	<472944C9.5020304@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <472944C9.5020304@freebsd.org>
User-Agent: Mutt/1.5.16 (2007-06-09)
Cc: current@FreeBSD.org
Subject: Re: non-functional backout for review
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Nov 2007 03:19:54 -0000

On Thu, Nov 01, 2007 at 11:15:21AM +0800, David Xu wrote:
> Andrey Chernov wrote:
>> Some people complaints that new check in __isctype() is not human readable 
>> and requests for backout. Compiler gives almost identical code for old and 
>> new excepting non-optimized case where non-human readable one wins. I am a 
>> bit tired to change it forth and back, so ask for final consensus here.
>> Old one
>> return (_c < 0 || _c >= 128) ? 0 :
>> New one (requests for backout)
>> return (_c & ~0x7F) ? 0 :
> 
> I will use a version which compiler can generate optimized code.
> the name __isctype already tells what the function is doing. :-)

Already done.

-- 
http://ache.pp.ru/