From owner-freebsd-stable@FreeBSD.ORG Fri Feb 18 18:08:22 2011 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 598051065696 for ; Fri, 18 Feb 2011 18:08:22 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from esa-annu.mail.uoguelph.ca (esa-annu.mail.uoguelph.ca [131.104.91.36]) by mx1.freebsd.org (Postfix) with ESMTP id 070888FC0A for ; Fri, 18 Feb 2011 18:08:21 +0000 (UTC) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApwEANdDXk2DaFvO/2dsb2JhbACEH6J5qweQOYRodgSFC4cG X-IronPort-AV: E=Sophos;i="4.62,188,1297054800"; d="scan'208";a="110310918" Received: from erie.cs.uoguelph.ca (HELO zcs3.mail.uoguelph.ca) ([131.104.91.206]) by esa-annu-pri.mail.uoguelph.ca with ESMTP; 18 Feb 2011 13:08:21 -0500 Received: from zcs3.mail.uoguelph.ca (localhost.localdomain [127.0.0.1]) by zcs3.mail.uoguelph.ca (Postfix) with ESMTP id E7E85B3F3D; Fri, 18 Feb 2011 13:08:20 -0500 (EST) Date: Fri, 18 Feb 2011 13:08:20 -0500 (EST) From: Rick Macklem To: mike@jellydonut.org Message-ID: <15348085.102038.1298052500896.JavaMail.root@erie.cs.uoguelph.ca> In-Reply-To: <679701594.102003.1298052457071.JavaMail.root@erie.cs.uoguelph.ca> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_102037_470845040.1298052500894" X-Originating-IP: [172.17.91.202] X-Mailer: Zimbra 6.0.10_GA_2692 (ZimbraWebClient - IE8 (Win)/6.0.10_GA_2692) Cc: george+freebsd@m5p.com, freebsd-stable@freebsd.org, Jeremy Chadwick Subject: Re: statd/lockd startup failure X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Feb 2011 18:08:22 -0000 ------=_Part_102037_470845040.1298052500894 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit I've seen this intermittently for mountd. I think the problem is that the code finds an unused port for udp/ip6 and then tries to use the same port# for tcp/ip6, udp/ip4, tcp/ip4. All three daemons have essentially the same function for doing this. The attached patches changes the behaviour so that it tries to get an unused port for each of the 4 cases. (This all applies to the "wildcard" case, where no port# or hosts have been specified as command args.) If you have the chance to try these patches, please let us know how they work for you? rick ps: I lost track of the thread, so I don't know who started it, but hopefully, they are on the cc list? ------=_Part_102037_470845040.1298052500894 Content-Type: text/x-patch; name=mountd.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=mountd.patch LS0tIHVzci5zYmluL21vdW50ZC9tb3VudGQuYy5zYXYJMjAxMS0wMi0xNyAyMTo0NTozMi4wMDAw MDAwMDAgLTA1MDAKKysrIHVzci5zYmluL21vdW50ZC9tb3VudGQuYwkyMDExLTAyLTE3IDIzOjIz OjM3LjAwMDAwMDAwMCAtMDUwMApAQCAtNTEwLDYgKzUxMCw3IEBAIGNyZWF0ZV9zZXJ2aWNlKHN0 cnVjdCBuZXRjb25maWcgKm5jb25mKQogCWludCByOwogCWludCByZWdpc3RlcmVkID0gMDsKIAl1 X2ludDMyX3QgaG9zdF9hZGRyWzRdOyAgLyogSVB2NCBvciBJUHY2ICovCisJaW50IG1hbGxvY2Rf c3ZjcG9ydCA9IDA7CiAKIAlpZiAoKG5jb25mLT5uY19zZW1hbnRpY3MgIT0gTkNfVFBJX0NMVFMp ICYmCiAJICAgIChuY29uZi0+bmNfc2VtYW50aWNzICE9IE5DX1RQSV9DT1RTKSAmJgpAQCAtNjIw LDcgKzYyMSw3IEBAIGNyZWF0ZV9zZXJ2aWNlKHN0cnVjdCBuZXRjb25maWcgKm5jb25mKQogCQkJ CQlzaW4tPnNpbl9hZGRyLnNfYWRkciA9IGh0b25sKElOQUREUl9BTlkpOwogCQkJCQlyZXMtPmFp X2FkZHIgPSAoc3RydWN0IHNvY2thZGRyKikgc2luOwogCQkJCQlyZXMtPmFpX2FkZHJsZW4gPSAo c29ja2xlbl90KQotCQkJCQkgICAgc2l6ZW9mKHJlcy0+YWlfYWRkcik7CisJCQkJCSAgICBzaXpl b2Yoc3RydWN0IHNvY2thZGRyX2luKTsKIAkJCQkJYnJlYWs7CiAJCQkJY2FzZSBBRl9JTkVUNjoK IAkJCQkJc2luNiA9IG1hbGxvYyhzaXplb2Yoc3RydWN0IHNvY2thZGRyX2luNikpOwpAQCAtNjMx LDEwICs2MzIsMTIgQEAgY3JlYXRlX3NlcnZpY2Uoc3RydWN0IG5ldGNvbmZpZyAqbmNvbmYpCiAJ CQkJCXNpbjYtPnNpbjZfYWRkciA9IGluNmFkZHJfYW55OwogCQkJCQlyZXMtPmFpX2FkZHIgPSAo c3RydWN0IHNvY2thZGRyKikgc2luNjsKIAkJCQkJcmVzLT5haV9hZGRybGVuID0gKHNvY2tsZW5f dCkKLQkJCQkJICAgIHNpemVvZihyZXMtPmFpX2FkZHIpOworCQkJCQkgICAgc2l6ZW9mKHN0cnVj dCBzb2NrYWRkcl9pbjYpOwogCQkJCQkJYnJlYWs7CiAJCQkJZGVmYXVsdDoKLQkJCQkJYnJlYWs7 CisJCQkJCXN5c2xvZyhMT0dfRVJSLCAiYmFkIGFkZHIgZmFtICVkIiwKKwkJCQkJICAgIHJlcy0+ YWlfZmFtaWx5KTsKKwkJCQkJZXhpdCgxKTsKIAkJCQl9CiAJCQl9IGVsc2UgeyAKIAkJCQlpZiAo KGFpY29kZSA9IGdldGFkZHJpbmZvKE5VTEwsIHN2Y3BvcnRfc3RyLApAQCAtNzAwLDYgKzcwMyw3 IEBAIGNyZWF0ZV9zZXJ2aWNlKHN0cnVjdCBuZXRjb25maWcgKm5jb25mKQogCQkJCXN2Y3BvcnRf c3RyID0gbWFsbG9jKE5JX01BWFNFUlYgKiBzaXplb2YoY2hhcikpOwogCQkJCWlmIChzdmNwb3J0 X3N0ciA9PSBOVUxMKQogCQkJCQlvdXRfb2ZfbWVtKCk7CisJCQkJbWFsbG9jZF9zdmNwb3J0ID0g MTsKIAogCQkJCWlmIChnZXRuYW1laW5mbyhyZXMtPmFpX2FkZHIsCiAJCQkJICAgIHJlcy0+YWlf YWRkci0+c2FfbGVuLCBOVUxMLCBOSV9NQVhIT1NULApAQCAtNzE1LDYgKzcxOSwxMiBAQCBjcmVh dGVfc2VydmljZShzdHJ1Y3QgbmV0Y29uZmlnICpuY29uZikKIAkJCQlleGl0KDEpOwogCQkJfQog CisJCQlpZiAobWFsbG9jZF9zdmNwb3J0ICE9IDApIHsKKwkJCQlmcmVlKHN2Y3BvcnRfc3RyKTsK KwkJCQlzdmNwb3J0X3N0ciA9IE5VTEw7CisJCQkJbWFsbG9jZF9zdmNwb3J0ID0gMDsKKwkJCX0K KwogCQkJc2VydmFkZHIuYnVmID0gbWFsbG9jKHJlcy0+YWlfYWRkcmxlbik7CiAJCQltZW1jcHko c2VydmFkZHIuYnVmLCByZXMtPmFpX2FkZHIsIHJlcy0+YWlfYWRkcmxlbik7CiAJCQlzZXJ2YWRk ci5sZW4gPSByZXMtPmFpX2FkZHJsZW47Cg== ------=_Part_102037_470845040.1298052500894 Content-Type: text/x-patch; name=statd.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=statd.patch LS0tIHVzci5zYmluL3JwYy5zdGF0ZC9zdGF0ZC5jLnNhdgkyMDExLTAyLTE3IDIzOjM2OjE1LjAw MDAwMDAwMCAtMDUwMAorKysgdXNyLnNiaW4vcnBjLnN0YXRkL3N0YXRkLmMJMjAxMS0wMi0xNyAy MzozNzo1My4wMDAwMDAwMDAgLTA1MDAKQEAgLTIzMyw2ICsyMzMsNyBAQCBjcmVhdGVfc2Vydmlj ZShzdHJ1Y3QgbmV0Y29uZmlnICpuY29uZikKIAlpbnQgcjsKIAlpbnQgcmVnaXN0ZXJlZCA9IDA7 CiAJdV9pbnQzMl90IGhvc3RfYWRkcls0XTsgIC8qIElQdjQgb3IgSVB2NiAqLworCWludCBtYWxs b2NkX3N2Y3BvcnQgPSAwOwogCiAJaWYgKChuY29uZi0+bmNfc2VtYW50aWNzICE9IE5DX1RQSV9D TFRTKSAmJgogCSAgICAobmNvbmYtPm5jX3NlbWFudGljcyAhPSBOQ19UUElfQ09UUykgJiYKQEAg LTMyNiw3ICszMjcsNyBAQCBjcmVhdGVfc2VydmljZShzdHJ1Y3QgbmV0Y29uZmlnICpuY29uZikK IAkJCQkJc2luLT5zaW5fYWRkci5zX2FkZHIgPSBodG9ubChJTkFERFJfQU5ZKTsKIAkJCQkJcmVz LT5haV9hZGRyID0gKHN0cnVjdCBzb2NrYWRkciopIHNpbjsKIAkJCQkJcmVzLT5haV9hZGRybGVu ID0gKHNvY2tsZW5fdCkKLQkJCQkJICAgIHNpemVvZihyZXMtPmFpX2FkZHIpOworCQkJCQkgICAg c2l6ZW9mKHN0cnVjdCBzb2NrYWRkcl9pbik7CiAJCQkJCWJyZWFrOwogCQkJCWNhc2UgQUZfSU5F VDY6CiAJCQkJCXNpbjYgPSBtYWxsb2Moc2l6ZW9mKHN0cnVjdCBzb2NrYWRkcl9pbjYpKTsKQEAg LTMzNiwxMCArMzM3LDEzIEBAIGNyZWF0ZV9zZXJ2aWNlKHN0cnVjdCBuZXRjb25maWcgKm5jb25m KQogCQkJCQlzaW42LT5zaW42X3BvcnQgPSBodG9ucygwKTsKIAkJCQkJc2luNi0+c2luNl9hZGRy ID0gaW42YWRkcl9hbnk7CiAJCQkJCXJlcy0+YWlfYWRkciA9IChzdHJ1Y3Qgc29ja2FkZHIqKSBz aW42OwotCQkJCQlyZXMtPmFpX2FkZHJsZW4gPSAoc29ja2xlbl90KSBzaXplb2YocmVzLT5haV9h ZGRyKTsKKwkJCQkJcmVzLT5haV9hZGRybGVuID0gKHNvY2tsZW5fdCkKKwkJCQkJICAgIHNpemVv ZihzdHJ1Y3Qgc29ja2FkZHJfaW42KTsKIAkJCQkJYnJlYWs7CiAJCQkJZGVmYXVsdDoKLQkJCQkJ YnJlYWs7CisJCQkJCXN5c2xvZyhMT0dfRVJSLCAiYmFkIGFkZHIgZmFtICVkIiwKKwkJCQkJICAg IHJlcy0+YWlfZmFtaWx5KTsKKwkJCQkJZXhpdCgxKTsKIAkJCQl9CiAJCQl9IGVsc2UgeyAKIAkJ CQlpZiAoKGFpY29kZSA9IGdldGFkZHJpbmZvKE5VTEwsIHN2Y3BvcnRfc3RyLApAQCAtNDAxLDYg KzQwNSw3IEBAIGNyZWF0ZV9zZXJ2aWNlKHN0cnVjdCBuZXRjb25maWcgKm5jb25mKQogCQkJCXN2 Y3BvcnRfc3RyID0gbWFsbG9jKE5JX01BWFNFUlYgKiBzaXplb2YoY2hhcikpOwogCQkJCWlmIChz dmNwb3J0X3N0ciA9PSBOVUxMKQogCQkJCQlvdXRfb2ZfbWVtKCk7CisJCQkJbWFsbG9jZF9zdmNw b3J0ID0gMTsKIAogCQkJCWlmIChnZXRuYW1laW5mbyhyZXMtPmFpX2FkZHIsCiAJCQkJICAgIHJl cy0+YWlfYWRkci0+c2FfbGVuLCBOVUxMLCBOSV9NQVhIT1NULApAQCAtNDE2LDYgKzQyMSwxMiBA QCBjcmVhdGVfc2VydmljZShzdHJ1Y3QgbmV0Y29uZmlnICpuY29uZikKIAkJCQlleGl0KDEpOwog CQkJfQogCisJCQlpZiAobWFsbG9jZF9zdmNwb3J0ICE9IDApIHsKKwkJCQlmcmVlKHN2Y3BvcnRf c3RyKTsKKwkJCQlzdmNwb3J0X3N0ciA9IE5VTEw7CisJCQkJbWFsbG9jZF9zdmNwb3J0ID0gMDsK KwkJCX0KKwogCQkJc2VydmFkZHIuYnVmID0gbWFsbG9jKHJlcy0+YWlfYWRkcmxlbik7CiAJCQlt ZW1jcHkoc2VydmFkZHIuYnVmLCByZXMtPmFpX2FkZHIsIHJlcy0+YWlfYWRkcmxlbik7CiAJCQlz ZXJ2YWRkci5sZW4gPSByZXMtPmFpX2FkZHJsZW47Cg== ------=_Part_102037_470845040.1298052500894 Content-Type: text/x-patch; name=lockd.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=lockd.patch LS0tIHVzci5zYmluL3JwYy5sb2NrZC9sb2NrZC5jLnNhdgkyMDExLTAyLTE3IDIzOjI5OjQ4LjAw MDAwMDAwMCAtMDUwMAorKysgdXNyLnNiaW4vcnBjLmxvY2tkL2xvY2tkLmMJMjAxMS0wMi0xNyAy MzozNTo0Ny4wMDAwMDAwMDAgLTA1MDAKQEAgLTQwMyw2ICs0MDMsNyBAQCBjcmVhdGVfc2Vydmlj ZShzdHJ1Y3QgbmV0Y29uZmlnICpuY29uZikKIAlpbnQgcjsKIAlpbnQgcmVnaXN0ZXJlZCA9IDA7 CiAJdV9pbnQzMl90IGhvc3RfYWRkcls0XTsgIC8qIElQdjQgb3IgSVB2NiAqLworCWludCBtYWxs b2NkX3N2Y3BvcnQgPSAwOwogCiAJaWYgKChuY29uZi0+bmNfc2VtYW50aWNzICE9IE5DX1RQSV9D TFRTKSAmJgogCSAgICAobmNvbmYtPm5jX3NlbWFudGljcyAhPSBOQ19UUElfQ09UUykgJiYKQEAg LTQ5Nyw3ICs0OTgsNyBAQCBjcmVhdGVfc2VydmljZShzdHJ1Y3QgbmV0Y29uZmlnICpuY29uZikK IAkJCQkJCXNpbi0+c2luX2FkZHIuc19hZGRyID0gaHRvbmwoSU5BRERSX0FOWSk7CiAJCQkJCQly ZXMtPmFpX2FkZHIgPSAoc3RydWN0IHNvY2thZGRyKikgc2luOwogCQkJCQkJcmVzLT5haV9hZGRy bGVuID0gKHNvY2tsZW5fdCkKLQkJCQkJCSAgICBzaXplb2YocmVzLT5haV9hZGRyKTsKKwkJCQkJ CSAgICBzaXplb2Yoc3RydWN0IHNvY2thZGRyX2luKTsKIAkJCQkJCWJyZWFrOwogCQkJCQljYXNl IEFGX0lORVQ2OgogCQkJCQkJc2luNiA9IG1hbGxvYyhzaXplb2Yoc3RydWN0IHNvY2thZGRyX2lu NikpOwpAQCAtNTA3LDEwICs1MDgsMTQgQEAgY3JlYXRlX3NlcnZpY2Uoc3RydWN0IG5ldGNvbmZp ZyAqbmNvbmYpCiAJCQkJCQlzaW42LT5zaW42X3BvcnQgPSBodG9ucygwKTsKIAkJCQkJCXNpbjYt PnNpbjZfYWRkciA9IGluNmFkZHJfYW55OwogCQkJCQkJcmVzLT5haV9hZGRyID0gKHN0cnVjdCBz b2NrYWRkciopIHNpbjY7Ci0JCQkJCQlyZXMtPmFpX2FkZHJsZW4gPSAoc29ja2xlbl90KSBzaXpl b2YocmVzLT5haV9hZGRyKTsKKwkJCQkJCXJlcy0+YWlfYWRkcmxlbiA9IChzb2NrbGVuX3QpCisJ CQkJCQkgICAgc2l6ZW9mKHN0cnVjdCBzb2NrYWRkcl9pbjYpOwogCQkJCQkJYnJlYWs7CiAJCQkJ CWRlZmF1bHQ6Ci0JCQkJCQlicmVhazsKKwkJCQkJCXN5c2xvZyhMT0dfRVJSLAorCQkJCQkJICAg ICJiYWQgYWRkciBmYW0gJWQiLAorCQkJCQkJICAgIHJlcy0+YWlfZmFtaWx5KTsKKwkJCQkJCWV4 aXQoMSk7CiAJCQkJfQogCQkJfSBlbHNlIHsgCiAJCQkJaWYgKChhaWNvZGUgPSBnZXRhZGRyaW5m byhOVUxMLCBzdmNwb3J0X3N0ciwKQEAgLTU4NSw2ICs1OTAsNyBAQCBjcmVhdGVfc2VydmljZShz dHJ1Y3QgbmV0Y29uZmlnICpuY29uZikKIAkJCQlzdmNwb3J0X3N0ciA9IG1hbGxvYyhOSV9NQVhT RVJWICogc2l6ZW9mKGNoYXIpKTsKIAkJCQlpZiAoc3ZjcG9ydF9zdHIgPT0gTlVMTCkKIAkJCQkJ b3V0X29mX21lbSgpOworCQkJCW1hbGxvY2Rfc3ZjcG9ydCA9IDE7CiAKIAkJCQlpZiAoZ2V0bmFt ZWluZm8ocmVzLT5haV9hZGRyLAogCQkJCSAgICByZXMtPmFpX2FkZHItPnNhX2xlbiwgTlVMTCwg TklfTUFYSE9TVCwKQEAgLTYwMCw2ICs2MDYsMTIgQEAgY3JlYXRlX3NlcnZpY2Uoc3RydWN0IG5l dGNvbmZpZyAqbmNvbmYpCiAJCQkJZXhpdCgxKTsKIAkJCX0KIAorCQkJaWYgKG1hbGxvY2Rfc3Zj cG9ydCAhPSAwKSB7CisJCQkJZnJlZShzdmNwb3J0X3N0cik7CisJCQkJc3ZjcG9ydF9zdHIgPSBO VUxMOworCQkJCW1hbGxvY2Rfc3ZjcG9ydCA9IDA7CisJCQl9CisKIAkJCXNlcnZhZGRyLmJ1ZiA9 IG1hbGxvYyhyZXMtPmFpX2FkZHJsZW4pOwogCQkJbWVtY3B5KHNlcnZhZGRyLmJ1ZiwgcmVzLT5h aV9hZGRyLCByZXMtPmFpX2FkZHJsZW4pOwogCQkJc2VydmFkZHIubGVuID0gcmVzLT5haV9hZGRy bGVuOwo= ------=_Part_102037_470845040.1298052500894--