From owner-cvs-all Tue Apr 9 19:46:35 2002 Delivered-To: cvs-all@freebsd.org Received: from Awfulhak.org (gw.Awfulhak.org [217.204.245.18]) by hub.freebsd.org (Postfix) with ESMTP id 602F337B405; Tue, 9 Apr 2002 19:46:26 -0700 (PDT) Received: from hak.lan.Awfulhak.org (root@hak.lan.Awfulhak.org [IPv6:fec0::1:12]) by Awfulhak.org (8.12.2/8.11.6) with ESMTP id g3A2kGoi027799; Wed, 10 Apr 2002 03:46:17 +0100 (BST) (envelope-from brian@freebsd-services.com) Received: from hak.lan.Awfulhak.org (brian@localhost [127.0.0.1]) by hak.lan.Awfulhak.org (8.12.2/8.12.2) with ESMTP id g3A2kEOF006117; Wed, 10 Apr 2002 03:46:15 +0100 (BST) (envelope-from brian@freebsd-services.com) Message-Id: <200204100246.g3A2kEOF006117@hak.lan.Awfulhak.org> X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Julian Elischer Cc: Brian Somers , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_linker.c In-Reply-To: Message from Julian Elischer of "Tue, 09 Apr 2002 18:52:24 PDT." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 10 Apr 2002 03:46:14 +0100 From: Brian Somers Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Hmm, This seems to work ok. For example, if I kldload ng_ether or ng_pppoe when nothing is loaded, netgraph is auto-loaded. I can even run ngctl(1), and ng_socket & netgraph are magically loaded. I'm running with an April 3 kernel (I reverted it because kernels over the past few days have dysfunctional shared library support). Perhaps the problem is only in -stable (I know there are some funny problems in -stable when for example options NETGRAPH is in the kernel and you try to kldload ng_xxx) ? > if you are in there, you may find out why loading ng_??? no longer forces > teh loading of module "netgraph" (there is a deopendency > and it USED to work.... > at one stage if you tried to make a node of type xxx it would try load > modul ng_xxx. (the code is in ng_base.c) but it stopped working a while > ago.. > > > On Tue, 9 Apr 2002, Brian Somers wrote: > > > brian 2002/04/09 18:14:45 PDT > > > > Modified files: > > sys/kern kern_linker.c > > Log: > > In linker_load_module(), check that rootdev != NODEV before calling > > linker_search_module(). > > > > Without this, modules loaded from loader.conf that then try to load > > in additional modules (such as digi.ko loading a card's BIOS) die > > badly in the vn_open() called from linker_search_module(). > > > > It may be worth checking (KASSERTing?) that rootdev != NODEV in > > vn_open() too. > > > > Revision Changes Path > > 1.88 +5 -3 src/sys/kern/kern_linker.c -- Brian http://www.freebsd-services.com/ Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message