From owner-cvs-all@FreeBSD.ORG Fri Aug 19 05:19:43 2005 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 38C9B16A41F; Fri, 19 Aug 2005 05:19:43 +0000 (GMT) (envelope-from gordon@tetlows.org) Received: from spiff.melthusia.org (spiff.melthusia.org [207.67.244.17]) by mx1.FreeBSD.org (Postfix) with ESMTP id DA3A643D45; Fri, 19 Aug 2005 05:19:42 +0000 (GMT) (envelope-from gordon@tetlows.org) Received: from [192.168.12.10] (cpe-66-75-147-245.san.res.rr.com [66.75.147.245]) (authenticated bits=0) by spiff.melthusia.org (8.12.10/8.12.10) with ESMTP id j7J5JcTJ040983; Thu, 18 Aug 2005 22:19:39 -0700 (PDT) (envelope-from gordon@tetlows.org) Message-ID: <43056CAC.6040105@tetlows.org> Date: Thu, 18 Aug 2005 22:22:52 -0700 From: Gordon Tetlow User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: en-us, en MIME-Version: 1.0 To: freebsd-arch@freebsd.org References: <200508120005.j7C05ARc090857@repoman.freebsd.org> <20050815053757.GB2660@green.homeunix.org> <20050815070033.GA8368@garage.freebsd.pl> <20050815125814.GC2660@green.homeunix.org> <20050816081644.GA3944@garage.freebsd.pl> <1124182906.2492.4.camel@buffy.york.ac.uk> <20050816095217.GB3944@garage.freebsd.pl> <43028269.50904@FreeBSD.org> <20050817084749.GC11066@garage.freebsd.pl> In-Reply-To: <20050817084749.GC11066@garage.freebsd.pl> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@freebsd.org, Doug Barton , src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/geom/label g_label.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Aug 2005 05:19:43 -0000 Pawel Jakub Dawidek wrote: >On Tue, Aug 16, 2005 at 05:18:49PM -0700, Doug Barton wrote: >+> Pawel Jakub Dawidek wrote: >+> >+> >Because '/' creates a directory and I want each label to be represented >+> >only by one file. >+> >+> I think what people are saying is that they like the directory creating behavior. Can you explain your rationale in more detail? > >Actually, I don't really care. All I wanted was one label to be represented >by one single file. That's all. For me, leaving it as it is just asks for >troubles. > >I can live without this change, really. This is something I'd like to ask >about our TRB, but unfortunately it was retired yesterday:) > >CCing to freebsd-arch@. > >The question(s) is(are): Should we allow '/' in labels or should we replace >it with something (eg. '_')? Maybe we should only deny labels with '/../'? > > When I wrote GEOM_VOL_FFS, I wrote it with the idea that you could make a heirarchy of providers in /dev/vol. Coming from an environment where it wasn't unusual for a single machine to have 30 to 40 disk available to it, it seemed natural that we should allow administrators the ability to define how they wanted things mapped out. Now that I have just gone back and looked at the code that I wrote, I didn't allow non-alphanumerics in the volume name (although I actually didn't check it when creating the provider). I seem to recall making that decision specifically to get around the ../ tree traversal. Anyway, I think it comes down to tools, not policy. I think "/" should be allowed. -gordon