From owner-cvs-src@FreeBSD.ORG Sat Apr 17 18:15:33 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 80B1516A4CE; Sat, 17 Apr 2004 18:15:33 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7A63C43D31; Sat, 17 Apr 2004 18:15:33 -0700 (PDT) (envelope-from luigi@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.10/8.12.10) with ESMTP id i3I1FXGe079175; Sat, 17 Apr 2004 18:15:33 -0700 (PDT) (envelope-from luigi@repoman.freebsd.org) Received: (from luigi@localhost) by repoman.freebsd.org (8.12.10/8.12.10/Submit) id i3I1FXCO079174; Sat, 17 Apr 2004 18:15:33 -0700 (PDT) (envelope-from luigi) Message-Id: <200404180115.i3I1FXCO079174@repoman.freebsd.org> From: Luigi Rizzo Date: Sat, 17 Apr 2004 18:15:32 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/net if_arp.h if_ethersubr.c if_fddisubr.c if_iso88025subr.c if_var.h src/sys/netgraph ng_eiface.c ng_ether.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Apr 2004 01:15:33 -0000 luigi 2004/04/17 18:15:32 PDT FreeBSD src repository Modified files: sys/net if_arp.h if_ethersubr.c if_fddisubr.c if_iso88025subr.c if_var.h sys/netgraph ng_eiface.c ng_ether.c Log: + rename and document an unused field in struct arpcom (field is still there so there are no ABI changes); + replace 5 redefinitions of the IPF2AC macro with one in if_arp.h Eventually (but before freezing the ABI) we need to get rid of struct arpcom (initially with the help of some smart #defines to avoid having to touch each and every driver, see below). Apart from the struct ifnet, struct arpcom now only stores a copy of the MAC address (ac_enaddr, but we already have another copy in the struct ifnet -- if_addrhead), and a netgraph-specific field which is _always_ accessed through the ifp, so it might well go into the struct ifnet too (where, besides, there is already an entry for AF_NETGRAPH data...) Too bad ac_enaddr is widely referenced by all drivers. But this can be fixed as follows: #define ac_enaddr ac_if.the_original_ac_enaddr_in_struct_ifnet (note that the right hand side would likely be a pointer rather than the base address of an array.) Revision Changes Path 1.19 +5 -1 src/sys/net/if_arp.h 1.166 +0 -1 src/sys/net/if_ethersubr.c 1.91 +0 -1 src/sys/net/if_fddisubr.c 1.62 +0 -1 src/sys/net/if_iso88025subr.c 1.72 +4 -0 src/sys/net/if_var.h 1.13 +0 -1 src/sys/netgraph/ng_eiface.c 1.33 +0 -1 src/sys/netgraph/ng_ether.c