From owner-svn-src-all@FreeBSD.ORG Fri Apr 27 14:21:01 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4586A1065675; Fri, 27 Apr 2012 14:21:01 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id 164B98FC08; Fri, 27 Apr 2012 14:21:01 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 79752B91A; Fri, 27 Apr 2012 10:21:00 -0400 (EDT) From: John Baldwin To: Attilio Rao Date: Fri, 27 Apr 2012 10:20:59 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p13; KDE/4.5.5; amd64; ; ) References: <201204262024.q3QKOPA6067287@svn.freebsd.org> <201204270740.43912.jhb@freebsd.org> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201204271020.59067.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Fri, 27 Apr 2012 10:21:00 -0400 (EDT) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r234723 - in head/sys: amd64/amd64 amd64/include i386/i386 i386/include pc98/pc98 sparc64/include sparc64/sparc64 x86/x86 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Apr 2012 14:21:01 -0000 On Friday, April 27, 2012 9:55:41 am Attilio Rao wrote: > 2012/4/27, John Baldwin : > > On Thursday, April 26, 2012 4:24:25 pm Attilio Rao wrote: > >> Author: attilio > >> Date: Thu Apr 26 20:24:25 2012 > >> New Revision: 234723 > >> URL: http://svn.freebsd.org/changeset/base/234723 > >> > >> Log: > >> Clean up the intr* MD KPI from the SMP dependency, removing a cause of > >> discrepancy between modules and kernel, but deal with SMP differences > >> within the functions themselves. > >> > >> As an added bonus this also helps in terms of code readability. > > > > Hmm, this should not have affected anything with modules as no modules > > should have ever called this. Also, making intr_bind() available for UP > > kernels on x86 is largely pointless. It's only caller is already > > conditional > > in sys/x86/x86/nexus.c: > > It doesn't mean that there couldn't be an user in the future of this > KPI in terms of thirdy part modules. > These functions are part of the public KPI and we speak a lot about > making our KPI as less as dependent by compiling options so I don't > really see why you are not happy about this. > > If the function (intr_bind() included) is part of the public KPI it > can be called by thirdy part modules too. No! intr_bind() is _NOT_ part of the public KPI. The public KPI is bus_intr_bind() which accepts a struct resource, which is the approved handle for interrupt resources in drivers and other modules. -- John Baldwin