From owner-cvs-ports@FreeBSD.ORG Fri Aug 25 20:19:19 2006 Return-Path: X-Original-To: cvs-ports@FreeBSD.org Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C4E8E16A4DE; Fri, 25 Aug 2006 20:19:19 +0000 (UTC) (envelope-from kris@obsecurity.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7B4BF43D49; Fri, 25 Aug 2006 20:19:19 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (elvis.mu.org [192.203.228.196]) by elvis.mu.org (Postfix) with ESMTP id 617951A4E0A; Fri, 25 Aug 2006 13:19:19 -0700 (PDT) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id 3E25751619; Fri, 25 Aug 2006 16:19:18 -0400 (EDT) Date: Fri, 25 Aug 2006 16:19:18 -0400 From: Kris Kennaway To: Shaun Amott Message-ID: <20060825201917.GA2949@xor.obsecurity.org> References: <200608232057.k7NKvSES014505@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="T4sUOijqQbZv57TR" Content-Disposition: inline In-Reply-To: <200608232057.k7NKvSES014505@repoman.freebsd.org> User-Agent: Mutt/1.4.2.2i Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/news/inn Makefile X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Aug 2006 20:19:19 -0000 --T4sUOijqQbZv57TR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 23, 2006 at 08:57:28PM +0000, Shaun Amott wrote: > shaun 2006-08-23 20:57:28 UTC >=20 > FreeBSD ports repository >=20 > Modified files: > news/inn Makefile=20 > Log: > Amend hostname check to succeed if /bin/hostname fails. > Another work-around for those pesky amd64 machines. This isn't going to work as you intend since the IGNORE check is run on pointyhat to decide whether to build the ports, which naturally succeeds. The real issue here is not 'amd64 machines' but ports built in a jail without access to a DNS server (this will become the default in the near future). Why does this port need to look up its hostname during build? If it is hard-coding the result in the package, then it is clearly wrong. On the other hand if it not hard-coding the result then it begs the question of why do it at all. Kris > | PORTNAME=3D inn > | @@ -48,12 +48,13 @@ CONFIGURE_ARGS+=3D --mandir=3D${PREFIX}/man=20 > | # Attempt to avoid failures later on, when > | # makedbz is executed: we need a valid hostname. > | =20 > | -.if exists(/bin/echo) && exists(/bin/hostname) > | -HOSTNAME!=3D `/bin/echo /bin/hostname` > | +.if exists(/bin/hostname) > | +HOSTNAME!=3D /bin/hostname > | +. if ${HOSTNAME} !=3D "" > | HOSTNAME:=3D ${HOSTNAME:C/[^\.]//g} > | - > | -. if ${HOSTNAME} =3D=3D "" > | +. if ${HOSTNAME} =3D=3D "" > | IGNORE=3D requires a fully-qualified hostname in order to build > | +. endif > | . endif > | .endif > | =20 >=20 --T4sUOijqQbZv57TR Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFE71tFWry0BWjoQKURAtqDAJ4rogWM8vUCjrFc07N6uwJQ95iUiACdEYbf mKSF/1UftAM69lX6OZZCsPE= =7yqU -----END PGP SIGNATURE----- --T4sUOijqQbZv57TR--