Date: Fri, 25 Aug 1995 17:36:03 -0700 From: "Justin T. Gibbs" <gibbs@freefall.FreeBSD.org> To: Bruce Evans <bde@zeta.org.au> Cc: markm@freefall.FreeBSD.org, CVS-commiters@freefall.FreeBSD.org, cvs-user@freefall.FreeBSD.org Subject: Re: cvs commit: src/eBones/registerd Makefile registerd.c Message-ID: <199508260036.RAA11941@freefall.FreeBSD.org> In-Reply-To: Your message of "Sat, 26 Aug 95 10:19:05 %2B1000." <199508260019.KAA06952@godzilla.zeta.org.au>
next in thread | previous in thread | raw e-mail | index | archive | help
>Perhaps lack of a visible policy in this area.
Perhaps.
>>I don't view this as a cleanup at all. It makes unnecessary conflicts with
>>the original code and makes it more difficult to incomperate patches from
>>outside sources.
>
>I agree.
>
>However, if the original really didn't have an explicit return type, then
>there is no way to get it through gcc -Wall -Wreally-all without changing
>the key line of the declaration.
>
>Bruce
I missed the missing int in the declaration. Taking a look through the
files as they stand now, the declaration format is very inconsistent.
With the few diffs that I've looked at so far, most of the inconsistancies come
from today's changes. The code also will not compile without the following
diff:
Index: registerd/Makefile
===================================================================
RCS file: /usr/cvs/src/eBones/registerd/Makefile,v
retrieving revision 1.2
diff -c -r1.2 Makefile
*** 1.2 1995/08/25 22:52:31
--- Makefile 1995/08/26 00:21:52
***************
*** 10,16 ****
PROG= registerd
SRCS= registerd.c
! CFLAGS+=-DCRYPT -DKERBEROS -I${.CURDIR}/../register
.PATH: ${.CURDIR}/../../usr.bin/rlogin
DPADD= ${LIBKDB} ${LIBKRB} ${LIBDES}
LDADD= -lkdb -lkrb -ldes
--- 10,16 ----
PROG= registerd
SRCS= registerd.c
! CFLAGS+=-DCRYPT -DKERBEROS -I${.CURDIR}/../register -I${.CURDIR}/../include
.PATH: ${.CURDIR}/../../usr.bin/rlogin
DPADD= ${LIBKDB} ${LIBKRB} ${LIBDES}
LDADD= -lkdb -lkrb -ldes
Index: make_keypair/Makefile
===================================================================
RCS file: /usr/cvs/src/eBones/make_keypair/Makefile,v
retrieving revision 1.1.1.1
diff -c -r1.1.1.1 Makefile
*** 1.1.1.1 1994/09/30 14:50:05
--- Makefile 1995/08/26 00:22:39
***************
*** 2,8 ****
PROG= make_keypair
MAN8= make_keypair.8
! CFLAGS+=-DKERBEROS -I${.CURDIR}/../register
DPADD= ${LIBKRB} ${LIBDES}
LDADD= -lkdb -lkrb -ldes
--- 2,8 ----
PROG= make_keypair
MAN8= make_keypair.8
! CFLAGS+=-DKERBEROS -I${.CURDIR}/../register -I${.CURDIR}/../include
DPADD= ${LIBKRB} ${LIBDES}
LDADD= -lkdb -lkrb -ldes
--
Justin T. Gibbs
===========================================
Software Developer - Walnut Creek CDROM
FreeBSD: Turning PCs into workstations
===========================================
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199508260036.RAA11941>