Date: Wed, 31 Oct 2007 23:22:36 -0400 From: Nathan Lay <nslay@comcast.net> To: Andrey Chernov <ache@nagual.pp.ru>, current@freebsd.org Subject: Re: non-functional backout for review Message-ID: <4729467C.3080907@comcast.net> In-Reply-To: <20071101025937.GB94332@nagual.pp.ru> References: <20071101025937.GB94332@nagual.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
Andrey Chernov wrote: > Some people complaints that new check in __isctype() is not human readable > and requests for backout. Compiler gives almost identical code for old and > new excepting non-optimized case where non-human readable one wins. I am a > bit tired to change it forth and back, so ask for final consensus here. > > Old one > > return (_c < 0 || _c >= 128) ? 0 : > > New one (requests for backout) > > return (_c & ~0x7F) ? 0 : > > Why not just comment out the old version just above the new version? Best Regards, Nathan Lay
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4729467C.3080907>