Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 16 Nov 2017 08:58:21 -0800 (PST)
From:      "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
To:        Konstantin Belousov <kib@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r325893 - in head: . etc/mtree share/man/man7 share/man/man9 targets/pseudo/hosttools targets/pseudo/userland usr.bin usr.bin/xlint
Message-ID:  <201711161658.vAGGwLab056683@pdx.rh.CN85.dnsmgr.net>
In-Reply-To: <201711161437.vAGEbIvj043914@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
> Author: kib
> Date: Thu Nov 16 14:37:18 2017
> New Revision: 325893
> URL: https://svnweb.freebsd.org/changeset/base/325893
> 
> Log:
>   Remove xlint(1).
>   
>   xlint is currently a fossil.  We have much more useful and alive tools
>   to do now what xlint did twenty years ago.
>   
>   I did not cleared some stuff which makes lint operational, in
>   sys/x86/include and sys/sys, but I might do it as followup.  The
>   x86/include/ucontext.h and _types.h hacks made to please lint was the
>   main reason for my initial proposal to classify xlint as obsolete and
>   to remove it.
>   
>   Also I do not intend to clear sccs ids.
>   
>   Reviewed by:	bapt, brooks, emaste, jhb, pfg
>   Sponsored by:	The FreeBSD Foundation
>   Differential revision:	https://reviews.freebsd.org/D13015
> 
> Deleted:
>   head/usr.bin/xlint/
> Modified:
>   head/ObsoleteFiles.inc
>   head/etc/mtree/BSD.usr.dist
>   head/share/man/man7/hier.7
>   head/share/man/man9/style.9
>   head/targets/pseudo/hosttools/Makefile.depend.host
>   head/targets/pseudo/userland/Makefile.depend
>   head/usr.bin/Makefile

Relnotes: Y,
And deprication procedures need to be followed.


> Modified: head/ObsoleteFiles.inc
> ==============================================================================
> --- head/ObsoleteFiles.inc	Thu Nov 16 14:27:02 2017	(r325892)
> +++ head/ObsoleteFiles.inc	Thu Nov 16 14:37:18 2017	(r325893)
> @@ -38,6 +38,15 @@
>  #   xargs -n1 | sort | uniq -d;
>  # done
>  
> +# 20171116: lint(1) removal
> +OLD_FILES+=usr/bin/lint
> +OLD_FILES+=usr/libexec/lint1
> +OLD_FILES+=usr/libexec/lint2
> +OLD_FILES+=usr/libdata/lint/llib-lposix.ln
> +OLD_FILES+=usr/libdata/lint/llib-lstdc.ln
> +OLD_FILES+=usr/share/man/man1/lint.1.gz
> +OLD_FILES+=usr/share/man/man7/lint.7.gz
> +OLD_DIRS+=usr/libdata/lint
>  # 20171114: Removal of all fortune datfiles other than freebsd-tips
>  OLD_FILES+=usr/share/games/fortune/fortunes
>  OLD_FILES+=usr/share/games/fortune/fortunes.dat
> 
> Modified: head/etc/mtree/BSD.usr.dist
> ==============================================================================
> --- head/etc/mtree/BSD.usr.dist	Thu Nov 16 14:27:02 2017	(r325892)
> +++ head/etc/mtree/BSD.usr.dist	Thu Nov 16 14:37:18 2017	(r325893)
> @@ -56,8 +56,6 @@
>          ..
>          ldscripts
>          ..
> -        lint
> -        ..
>          pkgconfig
>          ..
>      ..
> 
> Modified: head/share/man/man7/hier.7
> ==============================================================================
> --- head/share/man/man7/hier.7	Thu Nov 16 14:27:02 2017	(r325892)
> +++ head/share/man/man7/hier.7	Thu Nov 16 14:37:18 2017	(r325893)
> @@ -364,10 +364,6 @@ configuration data
>  linker scripts;
>  see
>  .Xr ld 1
> -.It Pa lint/
> -various prebuilt lint libraries;
> -see
> -.Xr lint 1
>  .El
>  .Pp
>  .It Pa libexec/
> 
> Modified: head/share/man/man9/style.9
> ==============================================================================
> --- head/share/man/man9/style.9	Thu Nov 16 14:27:02 2017	(r325892)
> +++ head/share/man/man9/style.9	Thu Nov 16 14:37:18 2017	(r325893)
> @@ -867,14 +867,11 @@ KNF
>  compliant in the repository must not diverge from compliance.
>  .Pp
>  Whenever possible, code should be run through a code checker
> -(e.g.,
> -.Xr lint 1
> -or
> +(e.g., various static analyzers or
>  .Nm cc Fl Wall )
>  and produce minimal warnings.
>  .Sh SEE ALSO
>  .Xr indent 1 ,
> -.Xr lint 1 ,
>  .Xr err 3 ,
>  .Xr warn 3 ,
>  .Xr style.Makefile 5
> 
> Modified: head/targets/pseudo/hosttools/Makefile.depend.host
> ==============================================================================
> --- head/targets/pseudo/hosttools/Makefile.depend.host	Thu Nov 16 14:27:02 2017	(r325892)
> +++ head/targets/pseudo/hosttools/Makefile.depend.host	Thu Nov 16 14:37:18 2017	(r325893)
> @@ -15,7 +15,6 @@ DIRDEPS = \
>  	usr.bin/mkcsmapper_static \
>  	usr.bin/mkesdb_static \
>  	usr.bin/xinstall \
> -	usr.bin/xlint/xlint \
>  	usr.bin/yacc \
>  	usr.sbin/config \
>  	usr.sbin/crunch/crunchgen \
> 
> Modified: head/targets/pseudo/userland/Makefile.depend
> ==============================================================================
> --- head/targets/pseudo/userland/Makefile.depend	Thu Nov 16 14:27:02 2017	(r325892)
> +++ head/targets/pseudo/userland/Makefile.depend	Thu Nov 16 14:37:18 2017	(r325893)
> @@ -416,10 +416,6 @@ DIRDEPS+= \
>  	usr.bin/write \
>  	usr.bin/xargs \
>  	usr.bin/xinstall \
> -	usr.bin/xlint/lint1 \
> -	usr.bin/xlint/lint2 \
> -	usr.bin/xlint/llib \
> -	usr.bin/xlint/xlint \
>  	usr.bin/xo \
>  	usr.bin/xstr \
>  	usr.bin/xz \
> 
> Modified: head/usr.bin/Makefile
> ==============================================================================
> --- head/usr.bin/Makefile	Thu Nov 16 14:27:02 2017	(r325892)
> +++ head/usr.bin/Makefile	Thu Nov 16 14:37:18 2017	(r325893)
> @@ -278,9 +278,6 @@ SUBDIR.${MK_TOOLCHAIN}+=	rpcgen
>  SUBDIR.${MK_TOOLCHAIN}+=	unifdef
>  SUBDIR.${MK_TOOLCHAIN}+=	size
>  SUBDIR.${MK_TOOLCHAIN}+=	strings
> -.if ${MACHINE_ARCH} != "aarch64" # ARM64TODO xlint does not build
> -SUBDIR.${MK_TOOLCHAIN}+=	xlint
> -.endif
>  SUBDIR.${MK_TOOLCHAIN}+=	xstr
>  SUBDIR.${MK_TOOLCHAIN}+=	yacc
>  SUBDIR.${MK_VI}+=	vi
> 
> 

-- 
Rod Grimes                                                 rgrimes@freebsd.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201711161658.vAGGwLab056683>