From owner-svn-src-head@freebsd.org Wed Mar 1 00:49:53 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 315B4CF1D85 for ; Wed, 1 Mar 2017 00:49:53 +0000 (UTC) (envelope-from scottl@netflix.com) Received: from mail-pg0-x229.google.com (mail-pg0-x229.google.com [IPv6:2607:f8b0:400e:c05::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 025F0956 for ; Wed, 1 Mar 2017 00:49:53 +0000 (UTC) (envelope-from scottl@netflix.com) Received: by mail-pg0-x229.google.com with SMTP id s67so13026873pgb.3 for ; Tue, 28 Feb 2017 16:49:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netflix.com; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=gS56KBIDZ8+vy/Z4HOUtF49XExZ8VZMMeHzO7935BWY=; b=jRKw7sqL/vnHPVXDfJHv3E8ld3kJ42ALi7uz+6SYg/SN7vaZr1TFy+MuDqKEWJwwix hNjJFSDvzJiC9gvwqgA0etTdh8rP5ZJXshSmGzTD3I1URy5muUkxuyeUDLv+5txdP2ps HZ+iUBPdKAM7P3dLpVQlePGr/yoZEnO+IRydc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=gS56KBIDZ8+vy/Z4HOUtF49XExZ8VZMMeHzO7935BWY=; b=YVYdFfN3iLg4EK5PhbEcdHvSW/zS+ZejGCG9Dl8JY3nYMkn3qKD7Mcxzlrvsc8gB5z S/YrgvVno09mCfMHOhqaKwtCr1oAQ/slX7VtiTlEjegzItBYBuVpjPwcRksPsHUCUM/m 9aLdXIxQWXIVNcqnMiVUziJe1CxUaRzIWCVSnQev+XoOQjxF1fxKqmxlWYmIRHgMCAVC J+S60BS1er1NEweNC+Za6B60HR/PMxHcmrACLB2gsXKlBsOo26QhmFV4cEKA43G9HsPH GEL+uGDVTHw8QWesKKQw1clJQEHxp59KZY74bhQrSKIK4E5OgTKYg8PEIn3xMl62WU3s +TXA== X-Gm-Message-State: AMke39lp0vfR/+kvEUkP4b65jp22Wclk6p/pcCYUvtjTRbrBRGXqcN9fUMiIquIbbhSUIQFf X-Received: by 10.84.216.15 with SMTP id m15mr6730899pli.22.1488329392524; Tue, 28 Feb 2017 16:49:52 -0800 (PST) Received: from ?IPv6:2600:1010:b01f:88f8:64c6:d797:6b37:3ac1? ([2600:1010:b01f:88f8:64c6:d797:6b37:3ac1]) by smtp.gmail.com with ESMTPSA id 187sm6370049pff.17.2017.02.28.16.49.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Feb 2017 16:49:51 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.2 \(3259\)) Subject: Re: svn commit: r314420 - head/sys/kern From: Scott Long In-Reply-To: Date: Tue, 28 Feb 2017 16:49:50 -0800 Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <201702282127.v1SLRqDH048319@repo.freebsd.org> To: cem@freebsd.org X-Mailer: Apple Mail (2.3259) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 00:49:53 -0000 Sure, but it doesn=E2=80=99t match the comments in that if-else = construct. Scott > On Feb 28, 2017, at 2:02 PM, Conrad Meyer wrote: >=20 > On Tue, Feb 28, 2017 at 1:27 PM, Scott Long = wrote: >> Author: scottl >> Date: Tue Feb 28 21:27:51 2017 >> New Revision: 314420 >> URL: https://svnweb.freebsd.org/changeset/base/314420 >>=20 >> Log: >> Provide a comment on why stdio.h needs to be included. >>=20 >> Modified: >> head/sys/kern/subr_prf.c >>=20 >> Modified: head/sys/kern/subr_prf.c >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/sys/kern/subr_prf.c Tue Feb 28 21:18:45 2017 = (r314419) >> +++ head/sys/kern/subr_prf.c Tue Feb 28 21:27:51 2017 = (r314420) >> @@ -76,6 +76,13 @@ __FBSDID("$FreeBSD$"); >> #include >> #else >> #include >> +#endif >> + >> +/* >> + * This is needed for sbuf_putbuf() when compiled into userland. = Due to the >> + * shared nature of this file, it's the only place to put it. >=20 > Couldn't it go in the #else clause above? >=20 > Best, > Conrad >=20